Adding docs on launching an add-in from an actionable message

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/card-reference.md
:white_check_mark:Succeeded

docs/actionable-messages/images/invoke-mha-add-in.PNG
:white_check_mark:Succeeded

docs/actionable-messages/invoke-add-in-from-actionable-message.md
:white_check_mark:Succeeded

docs/actionable-messages/toc.yml
:white_check_mark:Succeeded

docs/breadcrumb/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support for React 17/18

Hi all- any versions to support React 17 or 18?

not working on react 17 18 till

It's a issue with react-motion: https://github.com/chenglou/react-motion/issues/569#issuecomment-780190833
Based off the recent threads/comments, it doesn't look like the recent React releases will be supported in the near future.

We've created a fork of a fork of this repository: https://github.com/pr0gramm-com/react-text-loop
Even though react-motion still deosn't officially support react 18, it seems to work. You need to pass --legacy-peer-deps, though


can't bypass valorant detected

Valorants kernel anti-cheat is hyper paranoid, you won't bypass that with VmWare, you will need KVM or another program like that with GPU passthrough

Valorants kernel anti-cheat is hyper paranoid, you won't bypass that with VmWare, you will need KVM or another program like that with GPU passthrough


Fix keyword conflict for post-install

Signed-off-by: Luca Giorgi<EMAIL_ADDRESS>

Can be merged now


[BUG] Multi-threaded shuffle CI failed in test_read_case_col_name

I see the following failures:
14:12:15  FAILED ../../src/main/python/json_test.py::test_read_case_col_name[V0-][INJECT_OOM, IGNORE_ORDER]
14:12:15  FAILED ../../src/main/python/json_test.py::test_read_case_col_name[V0-json][IGNORE_ORDER]
14:12:15  FAILED ../../src/main/python/json_test.py::test_read_case_col_name[v0-][INJECT_OOM, IGNORE_ORDER]
14:12:15  FAILED ../../src/main/python/json_test.py::test_read_case_col_name[v0-json][IGNORE_ORDER]

AssertionError: GPU and CPU are not both null at [99, 'v0']

In the MT CI job. I also saw https://github.com/NVIDIA/spark-rapids/issues/8400.

This test was recently added here: https://github.com/NVIDIA/spark-rapids/pull/8371

This repros against a standalone cluster without the multi-threaded cluster.

Trying to come up with a smaller repro, but I ended up with this: https://github.com/NVIDIA/spark-rapids/issues/8411

Related (but not the whole) repro:
import org.apache.spark.sql.types._
val schema = StructType(Array(StructField("k0", LongType, false), StructField("k1", LongType, false), StructField("k2", LongType, false), StructField("k3", LongType, false), StructField("v0", LongType, true), StructField("v1", LongType, true), StructField("v2", LongType, true), StructField("v3", LongType, true)))
val d = spark.read.schema(schema).json("file:///tmp/json_test_repro")
d.show()

Where json_test_repro is a folder with a json file with contents:
{"v1":5139590093827188858,"v2":-1404180295742992878}

And partitioned directory structure, as such:
./k0=1
./k0=1/k1=1
./k0=1/k1=1/k2=2
./k0=1/k1=1/k2=2/k3=3
./k0=1/k1=1/k2=2/k3=3/part-00014-48dd252f-0dec-4969-ac53-79d4cb8a8331.c000.json

Note the schema passed to cuDF has columns v0, v3 that don't exist in the json itself. The issue with this we get back a table from cuDF with 2 columns, instead of 4 columns (after fixing https://github.com/NVIDIA/spark-rapids/issues/8411):
java.lang.ArrayIndexOutOfBoundsException: 2
        at ai.rapids.cudf.Table.getColumn(Table.java:124)
        at org.apache.spark.sql.catalyst.json.rapids.JsonPartitionReader.$anonfun$readToTable$4(GpuJsonScan.scala:326)
        at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36)
        at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
        at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:198)
        at org.apache.spark.sql.catalyst.json.rapids.JsonPartitionReader.$anonfun$readToTable$3(GpuJsonScan.scala:319)
        at com.nvidia.spark.rapids.Arm$.withResource(Arm.scala:29)

Since the files can have any number of columns (if all rows are null, Spark can omit the column), then we need to make sure cuDF follows suit.

We need to file a cuDF bug for this.
My guess is that the integration test failure is an odd combination of contents of a source table.
If the file in question had the following contents:
{"v0":0, "v1":1, "v2":2, "v3":3}
{"v1":5139590093827188858,"v2":-1404180295742992878}

We get back 4 columns and all seems well:
+----+-------------------+--------------------+----+---+---+---+---+
|  v0|                 v1|                  v2|  v3| k0| k1| k2| k3|
+----+-------------------+--------------------+----+---+---+---+---+
|   0|                  1|                   2|   3|  1|  1|  2|  3|
|null|5139590093827188858|-1404180295742992878|null|  1|  1|  2|  3|
+----+-------------------+--------------------+----+---+---+---+---+

The CPU consistently returns the above table with all columns and nulls where appropriate.

Yes, this is a bug in our CUDF JNI layer.
https://github.com/rapidsai/cudf/blob/5e12c25ca40c41f21fc80d4cd36713c514fabaa4/java/src/main/native/src/TableJni.cpp#L1504-L1521
If we cannot find a column that matches the name, we return the original data from unchanged.  We really should be moving columns over to a new table and generating columns of nulls if we cannot find the column we want.

From a performance/efficiency standpoint I think we want to modify where we reorder the columns.  I think we want to return a TableWithMeta, and let the java code handle the column names. This is so we can avoid copying the table multiple times and possibly making multiple copies of the same columns.

Crap. I don't know if we can fix it without pushing some of this back to the plugin or have CUDF actually return nulls for columns that were not in the file.
I'll file an issue and see what CUDF has to say about it.

I filed https://github.com/rapidsai/cudf/issues/13473 for the long term fix. In the short term I am going to do my best to make it work without it.  We will not be able to make the corner case of a file with no columns, only rows, work.


use go-colorable

I'm on Windows7, but possible to display colors.

Dependencies need to be vendored
This will break dlv for people who are using actual TERM=dumb terminals on *nix.

done

By using supportsEscapeCodes to set dumb you are disabling your library in every situation where it's useful (when supportsEscapeCodes == true we are already printing colors correctly).
What you probably want to do is set dumb using os.Getenv("TERM") == "dumb" and then if !dumb enable your library only when stdout is a windows console that doesn't support our ANSI escape sequences.
Also you didn't vendor go-isattty (see how the build is failing on windows) and I don't think you did the vendoring correctly, I think they need to be added with godep, @derekparker will tell you more.

Currently Godep/Godep.json seems strange for me because localtests does't exists.
I did following.
rm -rf Godeps vendor
godep save ./...

@mattn there shouldn't be anything vendored from localtests, what about that is making godeps act up for you?

$ godep save ./...
godep: Package (github.com/spf13/cobra) not found

@mattn (sorry for late response, was away for a few days). You should do godep restore first.

@derekparker i did it already. but got erorrs.

@mattn Ok, I think I know what the issue is, there was some localtest stuff that was included in Godeps.json by accident. Hopefully https://github.com/derekparker/delve/pull/485 will help get rid of any errors you are seeing.

@mattn can you please rebase on master and try again?

Ping @mattn

what you expect command with godep? godep save ./...?

@mattn you should be able to run: godep save $(go list ./... | grep -v vendor) without getting an error back. Also this PR needs to be rebased.

updated.

@mattn Aside from the last comment this looks good. Can you also squash your commits and format the messages according to https://github.com/derekparker/delve/blob/master/CONTRIBUTING.md#format-of-the-commit-message, please.

done

Merged, thanks! I added a commit on top of yours to fix doc strings on getColorableWriter. You can check it out on master and let me know if the documentation is incorrect.


Vol. 13 progress bar

Hey, this might be silly, but the live progress bar for volume 13 has been at 24% since a few weeks ago when I discovered you guys.
I don't actually know if this is because translations have come to a halt or if it's an actual bug (sorry if it isn't haha) but thought I might as well report it just in case.
Keep up the great work! :)

Yeah...progress hasn't been all that steady as of late. Sorry about that, but the bar isn't broken. If you'd like to help, you can find us through the tensei slime discord https://discord.gg/zVWsrEbM .


CM4: Add support for nvme boot

In this PR we update u-boot and apply a set of patches in order enable booting from nvme drives.

@resin-jenkins retest this please


workspace.textDocuments includes closed documents

In #10304 I was advised that workspace.textDocuments was the correct way to get open files; however I'm trying to write tests that rely on documents being closed and finding that they still exist in there despite being closed (I can see in the extension host there there are no open editors).
Here's a sample test:
it.only("test", async () => {
	// Open two files
	await vs.workspace.openTextDocument(emptyFile);
	await vs.workspace.openTextDocument(everythingFile);
	console.log(`There are ${vs.workspace.textDocuments.length} documents`);

	// Close all files
	while (vs.window.activeTextEditor) {
		await vs.commands.executeCommand("workbench.action.closeActiveEditor");
	}
	console.log(`There are ${vs.workspace.textDocuments.length} documents`);

	// Wait a short period just in case...
	await new Promise((resolve) => setTimeout(resolve, 1000));
	console.log(`There are ${vs.workspace.textDocuments.length} documents`);
});

This outputs:
There are 2 documents
There are 2 documents
There are 2 documents

Also weird, the while loop seems to only execute once.

however I'm trying to write tests that rely on documents being closed and finding that they still exist in

You cannot assume the opposite and closing an editor doesn't mean that we close the document too.

@jrieken Then the answer to my original question is not satisfied :( How do I get a list of the documents that are open? I want to provide my language server with a list of priority documents, which are first the visible text editors, and then any editors that are open but not visible.


feat: add opts for terminal colors

This PR adds a configuration option that allows setting terminal colors.

Thanks for the PR! I'll get this merged. Just so you're aware - I'm using panvimdoc to generate the vimdoc from the readme.
I'll make sure your changes are included in the readme so we don't lose them after the merge.


Prevent the duplication of auto refreshing data.

Thanks for the plugin. It's awesome.
I use the feature of refreshing data by specifying the "interval" property. However, it seems to duplicate the setInterval process every time I enters the route. How can I prevent from it? Can I stop the interval process when I leave current route?

Thanks a lot.
Sorry for these bugs, I'm trying to fix as quick as possible.
I published a new release v2.1.2, Issue have been solved.
you can upgrade to<EMAIL_ADDRESS>


Added total number of participants and info of how many are missing b…

…ioklubbkortsnummer

Solves #107


Try out provex with debugger

To get commands to run:
make tests/specs/mcd/cat-file-addr-pass-rough-spec.k.provex TEST_SYMBOLIC_BACKEND=haskell

Something like this to kompile:
make tests/specs/mcd/verification/haskell/verification-kompiled/timestamp

To run debugger, add --debugger --debug-script ....
kevm prove tests/specs/mcd/cat-file-addr-pass-rough-spec.k --verif-module VERIFICATION --backend-dir ... --provex
--debugger --debug-script ...

Try using kore-print instead of kast.
Post here how to do this whole thing using new toolchain, and any problems that show up.

After trying out provex and kore-print I can say this is a nice improvement.

I didn't have any issues with NoSuchElementException when trying to pretty print the configuration
kore-print is so much faster than kast
one thing to mention is that doing something like make tests/specs/mcd/verification/haskell/verification-kompiled/timestamp will compile the verification modules in tests/specs/mcd/verification/haskell, which I used when doing kore-print -d tests/specs/mcd/verification/haskell -o pretty -. Having a generic alias that uses -d .build/usr/lib/kevm/haskell won't work, we'll have to use a more specific path to the spec directory.


debouncing search queries

After figuring out animations in #264, I realized that search queries need to be debounced (i.e. postponed to avoid repeat triggering within a short timeframe). This was previously mentioned in #53, but ended up not being integrated (not quite sure why).
Normally I'd just use a simple helper like this to adjust this within my application:
list.search = debounce(list.search, 100);

However, List.js's searchMethod and its invocation are inaccessible from the outside, leaving me pretty much impotent:
https://github.com/javve/list.js/blob/f17ba5d4fca868b795f3cc3bd0514a47787f566e/src/search.js#L74
https://github.com/javve/list.js/blob/f17ba5d4fca868b795f3cc3bd0514a47787f566e/src/search.js#L101
Would it be worth adding debouncing to List.js's core - if not, could we make searchMethod customizable?

Closed -> https://github.com/javve/list.js/pull/267#issuecomment-133880432


Allow CSS Code Hints in PHP files

Allow CSS Code Hints in style tags for PHP files. Fixes #11629

There are 3 more occurences of ctx.token.state in https://github.com/sprintr/brackets/blob/2e64c0dfd7ec8b15365438068720ce1fa59df480/src/language/CSSUtils.js#L1583-L1592
Please try to fix those as well. In my opinion, a helper function _getState would fit all cases the best.

Tagging @MarcelGerber for review.

@sprintr There are still 3 occurences of ctx.token.state. You should switch them over to _getState(), or state that they should not be changed for some reason.

Closing in favor of #11751


Could not locate that visualization (id: NginxPlus:-Current-Request)

I am facing the same error too. But no one is able to help to look into this bug.


^roles is not indexed

Problem
^roles is mentioned in the tutorial, but not indexed.
Suggestions
It's probably also underdocumented, since it's actually a method of the metamodel, and it should also be documented as such. So some work should be poured on it.

I was looking at role and introspection and metamodel.  All of the Metamodel::* references seem to have Warning: this class is part of the Rakudo implementation, and is not a part of the language specification.
But .^roles as JJ has indicated is a part of the language specification. This raises a more fundamental question about introspection. Clearly, it is a part of Raku, so what part of the Metamodel classes are Rakudo and not necessarily Raku?
Is this difference documented?

By default, I would say all of them.


[test-framework] Improve Kubernetes and Mixer support.

Changed istio-system command-line flag and calculation behavior, so that the default system namespace is "istio-system" when nothing is specified. As we make more progress on being able to deploy dynamically to non-"istio-system" namespaces, we can change the behavior.
Added generic DumpState support to environment interface, to allow dumping of state of later investigation. This should be particularly useful in CI environments.
Sprinkled calls to DumpState everywhere. Ideally we should have a centralized way to do this. Unfortunately, I haven't figured out a clean way
to do this holistically yet.
Improved Pod Data dump to include both the pod logs, as well as the current snapshot of the Pod resource in Yaml format. Both get dumped to the work directory, in case of failures.
Fine-tuned and normalized retry timing characteristics for all Kubernetes operations.
Added logic to extract attribute manifest directly from the Helm charts. The attribute manifest needs to be injected during local environment runs, but is not needed in the Kubernetes environment. This approach allows us to have identical configuration for Mixer that can be used in both Local and Kubernetes environments.
Added a retry logic to Mixer bypass adapter's connectivity logic to help issues with initial connectivity after config push.
Introduced framework/repository as a place for common constants for Istio source repository.
Removed the logic that deletes collected reports from the PolicyBackend fake, to reduce state management that needs to be done in the TestFramework.
Updated PolicyBackend's APIs to do a subset query of reports, instead of exact match. This is needed, as unrelated telemetry is also collected (i.e. Mixer's own telemetry) during testing.
Added retry logic in a few places in the Kubernetes code to deal with eventual consistency.
Added template expansion support to Mixer instances.
Fixed the issue with PolicyBackend deployment in CircleCI environment (ImagePullPolicy Always => IfNotPresent)
Fixed basic Mixer tests to work in both environments.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS
tests/integration2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
19dfae4f1e3e82257b11e1dcc8a86ae0ea617ba0
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: douglas-reid, ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS
pkg/OWNERS
tests/integration2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
99936efdd918df4ed4620fdb0c5e9b6fd66dbf2d
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
99936efdd918df4ed4620fdb0c5e9b6fd66dbf2d
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
71ea7b79a95514a617c6d1a8c8223a48cc8a7887
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can u tell me how to use a github repository to detect imsi-catchers?
On Sun, Sep 23, 2018 at 12:06 AM istio-bot<EMAIL_ADDRESS>wrote:

@ozevren https://github.com/ozevren: The following test failed, say
/retest to rerun them all:
Test name Commit Details Rerun command
prow/e2e-mixer-no_auth-mcp.sh 99936ef
https://github.com/istio/istio/commit/99936efdd918df4ed4620fdb0c5e9b6fd66dbf2d
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8912/e2e-mixer-no_auth-mcp/51/ /test
e2e-mixer-no_auth-mcp
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/8912#issuecomment-423796562, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ApekrfWQkTVv8z-hh-_n88b6D_DEDx92ks5udzMIgaJpZM4W1Dk0
.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
970a35b09eebfa9dac6f7f87c684302b2e2f4807
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: mandarjog, rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
mixer/OWNERS
pkg/OWNERS
tests/integration2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
970a35b09eebfa9dac6f7f87c684302b2e2f4807
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
b2ab9ce19a658e02632360b728dbcd759271306a
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
b2ab9ce19a658e02632360b728dbcd759271306a
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth-mcp.sh
b2ab9ce19a658e02632360b728dbcd759271306a
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
e28be2feefef971c836d2ef12107a8bada01ff16
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: douglas-reid, ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS
pkg/OWNERS
tests/integration2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
abcb0eabd154c83481a3c9bca1fed9bd9fe9e9e8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
eac4ebf850ca875ef01a468cec7bd99f63dafa55
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nmittler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS
pkg/OWNERS [nmittler]
tests/integration2/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nmittler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS
pkg/OWNERS [nmittler]
tests/integration2/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve
Mixer parts look good.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid]
pkg/OWNERS [geeknoid,nmittler]
tests/integration2/OWNERS [geeknoid,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
929f4fbf560a980aacdc822392854178a144ac2c
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
929f4fbf560a980aacdc822392854178a144ac2c
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
929f4fbf560a980aacdc822392854178a144ac2c
link
/test e2e-mixer-no_auth

prow/e2e-mixer-no_auth-mcp.sh
929f4fbf560a980aacdc822392854178a144ac2c
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth


Spectronaut params

This pull request implements the parsing of spectronaut parameters.

@enryH, they are now parsed better. I sent an email to BGS support and asked for a machine-readable format and if they could report a number instead of "System Default." But for now, it's how it is.
Since you typically start a spectronaut analysis from a GUI, the BGS Factory Settings.txt is the only one we have to parse the parameters from, as far as I can see.

This is what BGS support writes:
In the case of MS1/MS2 Mass Tolerance Strategy, the System Default values can be found by hovering over the setting name. Additionally, this information can be found in the Spectronaut user manual. As you can see, this value depends on the type of mass analyzer used in the experiment.

I will replace System Default with 40ppm.


Helm3.8 needs to use go 1.17 or above?

Output of helm version:
Output of kubectl version:
1.23.0
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
The go mod file of helm3.8 still suggests version 1.16

Duplicate of https://github.com/helm/helm/issues/10580.


Create/Update/Delete Priority Values

From @michaelkleinhenz on October 5, 2016 12:44
Reference: 1608V132
Description
As a user, I want to create, update and delete priority values. Priority values are an ordered list of values describing symbolic priority of a work item. Do not confuse them with the order of execution.
Functional Acceptance Criteria

The priority values view displays an ordered list of available priority values from which a user can select one.
If selected, the user can edit the priority value title.
Priority values titles may contain alphanumeric characters including spaces and may not be empty.
Changes are saved by clicking on the save button or typing enter. Changes are instantly visible in the priority value list.
Changing a priority value title and saving it changes the title of that priority value on all work items that have been associated with it.
The order of the priority values can be changed (up and down). Changing a priority value order requires confirmation. Changing the order of priority values does not change WIs, their priority changes implicitly with the reordering.
A priority value can be deleted by clicking on the delete button. Deleting a priority value requires confirmation.
Deleting a priority value removes the priority value from all associated work items, setting it to the lowest value in the ordered list of priority values.
A new priority value can be created by clicking on the new button.
Clicking on the new button opens a title field to give the new priority value a title.
A new priority value can be saved by clicking on the ok button or typing enter. Note: priority value titles may not be empty.

Non-functional Acceptance Criteria

The priority values view is easily reachable from the start page.
Changing the priority order is done with modern UX methods.

Copied from original issue: almighty/almighty-core#339

Note: this story might have to split up. Does not comply to the size rule.

@michaelkleinhenz is this feature to create priority values or assign them to a work item? Priority "types" are not created in the template? Also, is there any inheritance with tasks on a work item or are they independently assigned priorities? So a task/child can have a higher priority than the parent?

Relates to UX Issue:
https://github.com/fabric8io/fabric8-ux/issues/110


Build basic Express API

Leaving this open until #15 is approved.

@harrisonlingren is the #15 already approved. If not, then I would like to work on it.

@malhar12 it is just about done, yes. Just waiting on code review. If you want to look over what was submitted and approve it, feel free


DUOS-1072[risk=no]Dataset Update Validation Bug

Scope:
This fixes the "complete all required fields" bug, and most dataset updates work, however there are at least a couple datasets (including UploadDS 2, GSR Test dataset) that error from consent when attempting to update
Addresses:
https://broadworkbench.atlassian.net/browse/DUOS-1072
Have you read Terra's Contributing Guide lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[ ] PR is labeled with a Jira ticket number and includes a link to the ticket
[ ] PR is labeled with a security risk modifier [no, low, medium, high]
[ ] PR describes scope of changes

In all cases:

[ ] Get a minimum of one thumbs worth of review, preferably 2 if enough team members are available
[ ] Get PO sign-off for all non-trivial UI or workflow changes
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this
[ ] Test this change deployed correctly and works on dev environment after deployment

The onNihStatusUpdate and nihValid state variable look unused to me, we should clean that up in this PR to minimize whatever validation bugs there are.

I think there is an API bug here as well. If we post a dataset with a valid dac id, it doesn't look like that is being honored. When retrieving the dataset again, the dac id is null.

There is at least one API bug. We need to update this code: https://github.com/DataBiosphere/consent/blob/develop/src/main/java/org/broadinstitute/consent/http/service/DatasetService.java#L148
by adding this block to update the DAC on the consent
        if (Objects.nonNull(dataset.getDacId())) {
            Consent consent = consentDAO.findConsentFromDatasetID(datasetId);
            if (Objects.nonNull(consent)) {
                consentDAO.updateConsentDac(consent.getConsentId(), dataset.getDacId());
            }
        }

Have confirmed locally that with the above fix ☝🏽  I can successfully update datasets and have them return with their correct DAC. This also fixes the initial load of the dataset in the case that it does have a DAC. Will file a separate PR for that.

See https://github.com/DataBiosphere/consent/pull/956 for the API fix

The onNihStatusUpdate and nihValid state variable look unused to me, we should clean that up in this PR to minimize whatever validation bugs there are.

the onNihStatusUpdate method is used by eraCommons

@raejohanek

the onNihStatusUpdate method is used by eraCommons

eraCommons is not on the dataset registration page - I think this might have been a copy/paste issue.


added syntax highlighting to liquid

adds shopif snippets to gfm.
trying to solve #145

Ah. Snippets aren't the issue, #145 is about syntax highlighting for Liquid not snippets.

@fusion809 totally got confused removing that and adding the relevant files

Ah, I don't think ya quite understand what #145 is all about still. I don't want this package to syntax highlighting .liquid files, I want this package to syntax highlight Liquid code that is embedded in Markdown files.

@fusion809 ah now I get your exact problem.

@fusion809 yes I think that was what you wanted.
What I thinkg is that problem could be solved by adding including gfm and markdown language in the liquid language package that way the liquid snippets will present and all the relevant liquid and markdown sytax both will be higlighted. What are your thoughts about it @burodepeper

@puranjayjain You are missing a } at the end of the grammars/gfm.cson file. After making this fix locally on my machine I found the package is not providing the inline liquid syntax-highlighting I expected.

@puranjayjain Any ideas of how to solve this problem and make the package provide syntax-highlighting for my Liquid tags?

I'll look at this later today. Should be an easy fix.

Quick update: I noticed that some things have to be fixed in language-liquid too to address @fusion809's original issue. No big issues though.
@puranjayjain I think it's easiest if you close this PR, and then I'll create a new one.

ok


Add a new CLI option / spawn options to hide the welcome screen

What

Partially addresses: https://github.com/rerun-io/rerun/issues/6140

We still need to also tackle https://github.com/rerun-io/rerun/issues/6263 since the place-holder UI isn't great.

Details
Handling this via blueprint is awkward since the welcome screen presentation happens without respect to any given blueprint, or in cases when all the recordings and their blueprints have been closed.
I decided adding this as a spawn option makes the most sense, since this is the context where someone knows how they are embedding Rerun in another application.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

Would it make sense to add a GET arg for rerun.io/viewer?


Instructions for building for and deploying to STM32

What is wrong
There are no instructions for building for and deploying to STM32.
How do you know it is wrong
In slack we have had anecdotal reports of people managing to run it on STM32, but how this was done has not been documented.
Code pointers
@Miceuz @sglow I believe you had success here. Could you please share your progress?

Building for the STM32 is easy thanks to the nice platformio setup that someone (@jlebar possibly?) set up.  You can build for the nucleo board using the Arduino libraries using:
pio run -e nucleo
I've got an alternate build which replaces the large Arduino libraries with a minimal HAL layer that writes directly to the hardware.  This is what all my testing has been on so far.   Once that gets merged you will be able to build that version using:
pio run -e stm32
Either way, you can use the visual studio code debugger to load it to the nucleo board and run.  I was pleasantly surprised that this MS product worked well even on a Linux host.
What you can actually do with the nucleo board is fairly limited at the moment due to the minimal hardware, but in another week or so we should be able to plug the nucleo board into the mounting board that Edwin designed and actually do something useful with it.

You should also be able to do pio run -e stm32 -t upload to build and
upload in one step.
On Tue, May 5, 2020 at 6:48 PM Steve Glow<EMAIL_ADDRESS>wrote:

Building for the STM32 is easy thanks to the nice platformio setup that
someone (@jlebar https://github.com/jlebar possibly?) set up. You can
build for the nucleo board using the Arduino libraries using:
pio run -e nucleo
I've got an alternate build which replaces the large Arduino libraries
with a minimal HAL layer that writes directly to the hardware. This is what
all my testing has been on so far. Once that gets merged you will be able
to build that version using:
pio run -e stm32
Either way, you can use the visual studio code debugger to load it to the
nucleo board and run. I was pleasantly surprised that this MS product
worked well even on a Linux host.
What you can actually do with the nucleo board is fairly limited at the
moment due to the minimal hardware, but in another week or so we should be
able to plug the nucleo board into the mounting board that Edwin designed
and actually do something useful with it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RespiraWorks/VentilatorSoftware/issues/254#issuecomment-624401641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEZB6CJZZV7DEKF3YMSGTRQC6YHANCNFSM4M2BQKYA
.

I believe we now have adequate instructions on how to deploy. There are additional nuances on how to deploy when you have multiple controllers all attached to the machine, but that is also covered under in integration_testing docs.


Fix an issue with Imagenet dataset import

Motivation and context

Fixed #4850 (The shared path to the files was found incorrectly)

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

/check

/check

I see the previous problem has gone, but I was lucky enough to find another one. If we export an Imagenet dataset in CVAT format and then import the dataset, there will be an error
File "cvat/cvat/apps/dataset_manager/bindings.py", line 1685, in import_dm_annotations
    match_dm_item(item, instance_data, root_hint=root_hint))
  File "cvat/cvat/apps/dataset_manager/bindings.py", line 1636, in match_dm_item
    raise CvatImportError("Could not match item id: "
cvat.apps.dataset_manager.bindings.CvatImportError: Could not match item id: 'cat/cat_0.jpg' with any task frame

I don't think this new problem should be fixed here, let's do it in another PR to unblock this.


fix: change information to hint so #eval output doesn't show up in "problems"

Fixes https://github.com/leanprover/lean4/issues/1590.
In LSP Change 'info' to 'hint' to eliminate noisy blue squiggles  and stop them from showing up as "problems" in VS code.
The "hints" now show up with a more subtle ellipsis UI with hover tips containing the message and the problem list remains empty (unless you have an actual error in your lean program):

Without this change all blue squiggles show up in the "Problems" output window which is a bit weird and could cause confusion with other languages that use blue squiggles to signify things that you need to work on - like spell checkers often use blue squiggles.

Closing this PR. See feedback at issue #1591


Remove CHANGELOG file.

The CHANGELOG file is abandoned and can be removed after migrating the change log to https://github.com/dmfs/opentasks/releases

The content of the ChangeLog file has been made available at https://github.com/dmfs/opentasks/releases


Update the build animation for each Swift compiler task

We can't merge this before https://github.com/apple/swift-integration-tests/pull/56 gets merged first.

@swift-ci please smoke test


adding methods to move camera front and back (.move, .forward, .backward)

I have since successfully compiled peasycam and tested the functions that worked seamlessly. Just as I feared I had to invert .forward and .backard but everything works fine.
I'm not sure how pull requests work. The last two commits added themselves to the PR automatically. If considered for master, should probably filter out changes made to the compiler/builder and .gitignore

Ok it's a lot of commits for this, I'm sure there was better way to do it but here should be everything that changes with the pull request:

Implementation of move()
implementation of forward() and backward() which uses move()
pan() now also uses move()
deletion of unused import processing.core.PShape; in Resizable_Offscreen.java Eclipse was complaining about.
Every other file should be reverted to current master state, untouched.

	public void move(final double dx, final double dy, final double dz) {
		center = center.add(rotation.applyTo(new Vector3D(dx, dy, dz)));
		feed();
	}

	public void pan(final double dx, final double dy) {
		move(dx, dy, 0);
	}

	public void forward(final double distance) {
		move(0, 0, -distance);
	}

	public void backward(final double distance) {
		move(0, 0, distance);
	}

@jdf Hi there !
I allow myself to tag you as I'm guessing this might have slipped through your priorities :-)
I was wandering if you were satisfied with the current state of the pull request ?


update PPP

Codecov Report

Merging #126 (df2e535) into master (83ffbda) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage     76.16%   76.16%
  Complexity      680      680
=========================================
  Files           100      100
  Lines          1934     1934
  Branches        204      204
=========================================
  Hits           1473     1473
  Misses          402      402
  Partials         59       59

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Syntax highlighting fails on long lines

I noticed that in some cases, syntax highlighting stops working, apparently on long lines. See screenshot below, where math mode and bold face in the last line are not highlighted anymore.

This is a current limitation of Atom, it matches only the first 100 tokens in a line.
I had a look at it in #74, and an option was the package grammar-token-limit , but the packages warns about a performance hit.
That being said, LaTeX should ignore line breaks, so in this case, you could just split your line where it's convenient.


Refactoring TableFooter

Refactor from class component to functional component
ref : #1346
Sorry. When I split it in PR, it's lot..
codeSandBox : http://codesandbox.io/s/github/wdh2100/mui-datatables/tree/functional/tableFooter

Coverage decreased (-0.004%) to 72.983% when pulling 45ce02c1626e52dcd25b5bb3d3dee2fc60c91589 on wdh2100:functional/tableFooter into 6891ed228ac9ec6991b7d8316855d408e991323c on gregnb:v3_1_0.

@wdh2100 Can you verify that you ran "npm run test"? I had some issues but realized it they were already in the v3.1.0 branch (so not related to you). It's kind of late, so I'm thinking of saving the rest of these for next week's release. However, looks like I can't test from codesandbox so figured I'd ask before doing the merge.

What is the problem?
When I run 'npm run test' it works fine

but mocha.opts <--- deprecated
https://stackoverflow.com/questions/60283197/mocha-opts-deprecated-how-to-migrate-to-package-json

Rebase v3.2.0

Thank you for adding the tests. I have a footer feature I want to add for version 3.2.0. I'm going to merge this branch into the jumpToPage branch and work on it there.

@patorjk
thanks!


my question

Hello, may I ask, is there any sample code for this package?

Hello. Unfortunately the package is in beginning. So I don't have sample code running smoothly yet. I hope in some few weeks the read function will be finished.

@feichenxue just out of curiosity, where do you intend to use the package more for reading or writing ?

Already have some examples in examples and readme


Changing the Browser

Every time I use destreamer, I have to log into my Microsoft school account, which only permits 10 instances. This seems to be a difficult task to deal with. How can I change the browser for destreamer to MS Edge or Google Chrome? I guess there should not be any issues since both browsers are based on Chromium.

You can check out the -k option here that saves the cookies so that once you login it wont as it again, see here
f you really want to change it to your installation of chrome you can do so changing this line
https://github.com/snobu/destreamer/blob/5b62c50b220b1e784bd21654f634105e78249c76/src/PuppeteerHelper.ts#L20
to be return /PATH/TO/EXE where PATH is the path of your chrome executable

Thanks. I realized this from #204.
Thanks for the flexibility of the package!


discovery: Report APM instrumentation by injection

What does this PR do?
Report if APM instrumentation is present by means of injection.
Detection of manual instrumentation involves language-specific code and will be enabled later for each language after review/rework.

Motivation
https://datadoghq.atlassian.net/browse/USMON-1168

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Drop "license-file" from Cargo.toml

This is an extremely unimportant non-issue but I noticed this while updating the NixOS packaging repository:
> warning: only one of `license` or `license-file` is necessary
> `license` should be used if the package license can be expressed with a standard SPDX expression.
> `license-file` should be used if the package uses a non-standard license.
> See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information.

https://github.com/memflow/memflow-win32/blob/74bc68476fd8fc65a0267bbb89c734734545e993/Cargo.toml#L11-L12

I noticed it, too. Its now removed! Thanks :)


Color plugin documentation does not accurately reflect plugin functionality

Expected Behavior
Ability to use all documented modifiers for the color plugin (specifically saturate) or update the documentation to reflect what is currently supported.
Current Behavior
mix, tint, shade, xor, red, green, blue, hue are all working as documented and as expected. Missing rest of documented methods including but not limited to desaturate, saturate, lighten, brighten, etc.
Failure Information (for bugs)
n/a Not a bug per-se, just a discrepancy between documentation and actual functionality. Ideally, it would be nice to have all the methods documented.
Steps to Reproduce
n/a
Screenshots
n/a
Context

Jimp Version: 0.16.1
Operating System: Windows and Ubuntu
Node version: v12.16.3

Failure Logs
n/a

Note: Use of the any keyword (when used in Typescript) seems to resolve this issue.

Note: Use of the any keyword (when used in Typescript) seems to resolve this issue.


MAINT: optimize: Better name for trust-region-exact method.

I changed the name of the optimization method trust-region-exact to trust-exact.
The new name is more in the line of other trust-region optimization methods in scipy
(The idea of changing was suggested by @nmayorov  in the discussion following PR #7292).

The sphinxext submodule was apparently accidentally updated. Try
git checkout HEAD^ doc/
git commit --amend

and re-force-push here

Thanks! All checks have passed when I did as suggested...
It seems however I have modified the file "doc/scipy-sphinx-theme", is that alright?

maybe it should have been git checkout upstream/master -- doc/sphinxext
as github still shows it was changed. the aim would be to not change it
unnecessarily.
6.5.2017 22.39 "Antonio Horta Ribeiro"<EMAIL_ADDRESS>kirjoitti:

Thanks! All checks have passed when I did as suggested...
It seems however I have modified the file "doc/scipy-sphinx-theme", is
that alright?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/7377#issuecomment-299657365, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACI5pG-HLqpVQPKp5QLpCjotcQsFEe0ks5r3LpFgaJpZM4NRMEf
.

ok, fixed the scipy-sphinx-theme for you (git checkout HEAD^ -- doc/scipy-sphinx-theme; git commit --amend)

Thank you @pv! Sorry for make you going into the trouble of doing it yourself.


Should ipython and bpython be listed  in some configuration files?

Hi
I noticed ipython and bpython are used in source code in nameko/cli/shell.py. But there are not any configuration files  which declare them as dependencies. I am wondering if it is necessary to list these dependencies in configuration files.
Expected Bahavior
Add ipython and bpython to configuration files such as requirements-extras.txt

Good idea! PRs welcome :-)


Fix for headlock problem

Fixes headlock on Oculus Browser. Head rotation wasn't working if you update controls after rendering. This also may have been causing a frame of latency on other platforms.
Tested with Oculus Browser and Daydream.
I've filed an issue with the Oculus Browser team to better understand why this worked in Daydream but not Oculus Browser.
Update: The behavior difference between Oculus Browser and Daydream has been located and they'll line up in the next release. There is still a frame of latency without this change.

Thanks so much for the fix. I actually don't have access to an Oculus to test with, so this is super helpful. I'll get a release with this in it pushed either tonight or tomorrow!


Fix copyright year

I'm pretty sure you only have to touch the copyright year if you modify a file in the same year.  Right?

only have to touch the copyright year if you modify

Sure, the script aligns last Git change with header. I'm still thinking to make it as a linter.


fix spotlight indexing check

Check that the userActivity is a spotlight one and from Branch. This should fix the bug mentioned in #464
@aaustin @E-B-Smith

+1

@MikeSilvis Just confirming, did this PR fix the issue you were facing?

Yup!

Awesome! Happy Deep linking!

👍 Great!


Propagate Static everywhere

Describe the solution you'd like
I'm trying to apply your product to a whole project. And it is asking, again and again, to which methods I want to propagate Static. I would appreciate:

a button "select all" to select all methods
a button "All methods" to apply "select all" to every files, so that I don't have to accept so many time.

For what product
Android-studio
Thanks for your product !

Hey @Arthur-Milchior, thank you for your interest in the plugin. However, this plugin doesn't do what you think it does, it is only calling IDE actions when the file is saved. What you are trying to do is applying IDE for all your files, this is outside the scope of the plugin. I also don't know what is "Propagate Static everywhere", is it "Add class qualifier to static member access"?
There is a "batch mode" in the plugin that might help you, see https://github.com/dubreuia/intellij-plugin-save-actions#activation, "Activate save actions on batch".


URL links in ToC file

** Sitemapcrawler link:http://ml-if-git/DEV/Search_and_CA/JAVA/apps/if-app-sitemapcrawler[if-app-sitemapcrawler]

Wrong prefix when injected.

Fixed in #17


Discuss Pipeline Entity removal

Do we want to remove completely the Pipeline Entity?
If yes, should we replace the capability to submit a group of tasks ?
If No, what should be the API to create a Pipeline Entity (at runtime or through ScenarioConfig)?

Decisions made after removing PipelineConfig:

Pipeline entity should be renamed Sequence.
A Scenario sequence is made of a sub-set of the scenario tasks that can be submitted together.
Sequence should implement the Submittable interface like actual Pipeline.
Sequence must not have config_id attribute anymore.
A Sequence should be created from the _SequenceManager._create_sequence method. The method must not accept a PipelineConfig as parameter anymore.
A Scenario should have a new API opened. scenario.add_sequence(sequence_name, list_of_tasks) to create a sequence at runtime. The method should delegate the Sequence creation to the _SequenceManager.
A Scenario should have a new API opened. scenario.remove_sequence(sequence_name, list_of_tasks) to remove a sequence from the scenario at runtime. The method should delegate the Sequence deletion to the _SequenceManager.


Jenkins Warnings Next Generation Plugin Parser

Hi,
do you have a parser for the "Jenkins Warnings Next Generation Plugin" (https://github.com/jenkinsci/warnings-ng-plugin)?
I've tried evaluating the result file with the builtin CodeNarc parser of the plugin but this results in far more errors than there are actually. E.g. 587 REAL errors result in 1467 errors in the plugin.
If there is no such thing: can I adapt the results file to make it work?
Or do you have any other solution to this?
Best regards

Can jenkins plugin handle SARIF format ?
If yes, npm-groovy-lint can output it :)

It can basically handle any format if you have the appropriate parser for it. The problem is that there is no npm-groovy-lint-parser and the builtin CodeNarc doesnt work.
Can I change the output to pure CodeNarc output, so that the plugin would understand it?

SARIF is a generic SAST results format ( many linters use it)
https://github.com/jenkinsci/warnings-ng-plugin should handle it and it will allow to integrate many linters :)

Hi, thanks for the tip. It supports SARIF indeed and it basically works.
Now I've got another problem:
about a third of all linting messages (error, info, ...) cannot be interpreted correctly -> the errors cant be mapped to files even though the files are present in the  "physicalLocation" part of the SARIF file.
I noticed, that this only occurs at errors, info... that do not have the "region" parameter even though when linted via commandline there are specific lines and columns given.
An example is attached.
via commandline (with filename and column):
C:\projects\jenkins_utilities>npm-groovy-lint --noserver --failon none "**/multi_io_integration.groovy"
C:\projects\jenkins_utilities\vars\multi_io_integration.groovy
  60    warning  Variable named RANDOM_ID in class None does not match the pattern [a-z][a-zA-Z0-9]*  VariableName
  616   warning  The String '${SCRIPT,template="mail_template_robot_results.groovy"}' contains a GString-type expression: '${SCRIPT,template="mail_template_robot_results.groovy"}'  GStringExpressionWithinString

npm-groovy-lint results in 1 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      0      │
│    1    │ 'Warning' │      2      │
│    2    │  'Info'   │      0      │
└─────────┴───────────┴─────────────┘

SARIF resultfile:
"results": [
    {
        "level": "warning",
        "message": {
            "text": "Variable named RANDOM_ID in class None does not match the pattern [a-z][a-zA-Z0-9]*"
        },
        "ruleId": "VariableName",
        "locations": [
            {
                "physicalLocation": {
                    "artifactLocation": {
                        "uri": "vars\\multi_io_integration.groovy",
                        "index": 0
                    }
                }
            }
        ],
        "ruleIndex": 373
    },
    {
        "level": "warning",
        "message": {
            "text": "The String '${SCRIPT,template=\"mail_template_robot_results.groovy\"}' contains a GString-type expression: '${SCRIPT,template=\"mail_template_robot_results.groovy\"}'"
        },
        "ruleId": "GStringExpressionWithinString",
        "locations": [
            {
                "physicalLocation": {
                    "artifactLocation": {
                        "uri": "vars\\multi_io_integration.groovy",
                        "index": 0
                    }
                }
            }
        ],
        "ruleIndex": 127
    }
],
"artifacts": [
    {
        "sourceLanguage": "Groovy",
        "location": {
            "uri": "vars\\multi_io_integration.groovy"
        }
    }
]

@ButterBetzi I added region when we just have a line (the region will be the whole line, so not very accurate)
I also added accurate range for rule VariableName
If you see other CodeNarc rules that could have a more accurate range, please post issues :) ( or even PR ? ^^ )


Reorder with animation

Is it possible add animation when I update order property value?
I want to aniamate from [0,1,2] to [2,0,1].

@obetomuniz did you manage to make it work? I need the same functionality... thanks :)

Hey @ilonashub. Sadly I did not. I used this library to solve my problem

I think use can config LayoutAnimation right before you set the new state, I don't test it.

@obetomuniz thanks! that the library I am trying to use as well, just having some flickering issues there.
@nihgwu we use LayoutAnimation today - but it works only in iOS

@ilonashub for Android you need add this line UIManager.setLayoutAnimationEnabledExperimental && UIManager.setLayoutAnimationEnabledExperimental(true); at the very beginning

@nihgwu thanks! I know - we have this line and we use LayoutAnimation in Android in many places - but specifically the swapping that works for lists with LayoutAnimation works on iOS and not Android

LayoutAnimation.easyInOut is only effective for the next state change, I suspect there is other render consumed that, if the RNTester's LayoutAnimation example works for you then I think it should work on this scenario too

@nihgwu now that I think about it.. maybe the order of renders is different between Android and iOS - and what you're saying might be the problem. I'll check that direction. thanks!


Move shouldRespond

This moves the shouldRespond to a higher place in the call stack
(the actual recieve go routine) rather than within the receipt of the
channel message on con.reqChannel. Goal of this PR is to pull out
the change needed for flow control that is independent of the actual
FlowControl code, as the flow control code is recording race conditions
during testing.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@sdake: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-notes_istio

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-notes_istio

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-notes_istio

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

unit-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test unit-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

lint_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test lint_istio

gencheck_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test gencheck_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @howardjohn @hzxuzhonghu this should have no functional impact, although I'd like to isolate this change from the rest of the flow control PR.
Would you mind merging?

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test analyze-tests_istio

release-test_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test release-test_istio

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
47a4fc58ae0fff19369f649dee7731dcdf2c5ec4
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
56c361abd86b1441d9678fa939f883e83eb7605f
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
47a4fc58ae0fff19369f649dee7731dcdf2c5ec4
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
47a4fc58ae0fff19369f649dee7731dcdf2c5ec4
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

As suspected, this small change is producing  a race condition of some sort.
Groaner.
Cheers,
-steve

/test integ-pilot-k8s-tests_istio

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
47a4fc58ae0fff19369f649dee7731dcdf2c5ec4
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
47a4fc58ae0fff19369f649dee7731dcdf2c5ec4
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I am not sure this change makes sense independently if we don't add the flow control? Is there any reason it needs to be split out?

Not really - I just thought it would be easier to test independently against the gate with a small change then all of the flow control work and fix the busted test cases.


[PE-D] Able to add duplicate contacts with case-sensitive names

May be confusing to a user who mistakenly creates a non-capitalised contact.

Labels: severity.Medium type.FeatureFlaw
original: petermonky/ped#9

Case insensitive check in Reache
Update DG that name and tags cannot be the same


ghidra server: Connection to server failed

I've set up a ghidra server and wireguard.
Wireshark shows that the request goes through, but there was no response. What could be the error?

The following parameters were set in ghidra:

wrapper.app.parameter.1=-a0
wrapper.app.parameter.2=-u
wrapper.app.parameter.3=-i <IP_ADDRESS>
wrapper.app.parameter.4=${ghidra.repositories.dir}

I've get this in console:

And this in client:

By the way, when the ghidra client is launched on the server, the connection occurs.

If the packet was getting through your server's firewall, there should be a response from the server's ip back to the client to establish the tcp connection.
Double check your server's firewall configuration.

Thank you, it helped
I completely forgot about firewall...


eternal tests runner tool is broken for nfs tests

Our tool which runs eternal tests is broken.
Specifically:

here we fail to pass parameters properly (should be StrictHostKeyChecking=no)
The newly introduces ssh client here is not used properly in the tool. For example calling pgrep pgbench here will raise exception (the process was killed previously) and will be continuously retried here
when running yc-nbs-run-eternal-load-tests rerun-db-load --test-case eternal-1tb-nfs-postgresql the self.test_config.db parameter is mysql-nfs or postgresql-nfs instead of mysql or postgresql

There might be other things broken. These were the problems when running
yc-nbs-run-eternal-load-tests rerun-db-load --test-case eternal-1tb-nfs-postgresql

fixed by #2532


EmailHandler regression causing crash!

Summary
dracc reported a crash in EmailHandler that appears to be a regression from #637.
Segs/Projects/CoX/Servers/GameServer/EmailService/EmailHandler.cpp:52: virtual void EmailHandler::dispatch(SEGSEvents::Event*): Assertion `false' failed.

It looks as though removing emailHeaderRequest has caused the dispatch switch to fall through to the default condition.
- case EmailEventTypes::evEmailHeaderRequest:
-     on_email_header(static_cast<EmailHeaderRequest *>(ev)); break;

Proposed Solution
Looks like we need to do two things. First it seems like the intention was to replace EmailHeaderRequest with another event, and that isn't working, so we need to get to the bottom of that. Secondly, we really should provide better error handling there by changing the assert(false); to a more verbose error message. qFatal() if failing to dispatch is truly server halting, but more likely qWarning(), with a message about why it failed and what the handler was trying to do (which type).
I'm assigning eoS, as he's most familiar with the code base, and the bug appears to have originated in his PR #637

Thanks for jumping on this so quickly @eoS!


[kirk backport] ostree-kernel-initramfs: fix kernel rebuild

backport https://github.com/uptane/meta-updater/pull/88

In fact, I even started testing this PR on kirkstone but I sent it to master first to follow the good practices.
However I understand perfectly what you are saying.
I don't know if I'm doing the right thing but that's why I get up every day :)


Tried to use the angular-material-fileupload component in my project, getting following error message

index.html:37 Error: Unexpected token <
Evaluating http://localhost:56526/angular-material-fileupload
Evaluating http://localhost:56526/app/app.module.js
Evaluating http://localhost:56526/app/main.js
Loading app
at eval ()
at evaluate (evaluate.js:106)
at instantiate.js:394
at dynamicExecute (register-loader.js:665)
at doEvaluate (register-loader.js:612)
at ensureEvaluate (register-loader.js:520)
at register-loader.js:538
at Object.eval (app.module.ts:18)
at eval (app.module.ts:374)
at eval (app.module.ts:374)
below is my package.json
{
"name": "angular2-registration-login-example",
"version": "1.0.0",
"repository": {
"type": "git",
"url": "https://github.com/cornflourblue/angular2-registration-login-example.git"
},
"scripts": {
"start": "tsc && concurrently "npm run tsc:w" "npm run lite" ",
"lite": "lite-server",
"tsc": "tsc",
"tsc:w": "tsc -w"
},
"module": "./esm5/service-worker.js",
"es2015": "./esm2015/service-worker.js",
"typings": "./service-worker.d.ts",
"license": "MIT",
"dependencies": {
"@angular/animations": "6.1.7",
"@angular/cdk": "^6.4.7",
"@angular/cli": "^6.2.1",
"@angular/common": "6.1.7",
"@angular/compiler": "6.1.7",
"@angular/core": "6.1.7",
"@angular/forms": "6.1.7",
"@angular/material": "6.4.7",
"@angular/platform-browser": "6.1.7",
"@angular/platform-browser-dynamic": "6.1.7",
"@angular/router": "6.1.7",
"angular-material-fileupload": "^1.0.1",
"babel-core": "^6.26.3",
"core-js": "^2.5.7",
"hammerjs": "^2.0.8",
"jquery": "^3.0.1",
"moment": "^2.22.2",
"ng2-bs3-modal": "^0.13.0",
"ng2-file-upload": "^1.3.0",
"rxjs": "^6.3.2",
"rxjs-compat": "^6.3.2",
"systemjs": "^0.20.19",
"systemjs-plugin-babel": "0.0.25",
"zone.js": "^0.8.26"
},
"devDependencies": {
"@types/node": "^8.0.53",
"concurrently": "^3.1.0",
"lite-server": "^2.4.0",
"node-sass": "^4.9.3",
"raw-loader": "^0.5.1",
"sass-loader": "^7.0.3",
"typescript": "^2.6.1",
"babel-loader": "^7.1.5",
"babel-preset-es2015": "^6.24.1"
},
"angularCompilerOptions": {
"skipTemplateCodegen": true,
"skipMetadataEmit": false,
"strictMetadataEmit": true,
"annotationsAs": "decorators",
"noImplicitAny": false
}
}

Can you please provide the template html?

It seems to be an issue in your index.html file.
The message indicates you have an extra opening angle bracket '<'

@sudevanoa did you tried what @andrefortin said? Are you still seeing the issue?

closing the issue, Please feel free to reach out if you still have issues.


IPTT: Default filtering (Report type, target frequency, date ranges)

This ticket replaces #243
Summary
This ticket describes acceptance criteria for date range generation based on report type and target frequency or time period selection. These are the date ranges that are auto-populated in the IPTT filter panel (#120) based on selections made in the IPTT landing page (#119).
IMPORTANT TO NOTE: We are now basing all date ranges (whether we're talking about generating periodic targets or generating IPTT reports) on reporting start and end months, and these are identical for all indicators within a single program. This means that it no longer matters which type of IPTT report you are creating when it comes to the date ranges of our time or target periods. The only difference between the two reports is that we include periodic targets in one report, and only display actuals in the other in order to allow all indicators to be viewed in one table.
Acceptance criteria
The following apply to both types of IPTT reports: Periodic target and Actuals-only
Show all

By default, the report starts on the first day of the reporting start month.
By default, the report ends on the last day of the reporting end month of the time or target period that includes the reporting end month. Here are some test cases based on a reporting start date of May 1, 2017 and a reporting end date of Jul 31, 2020:

[x] 2.1. A report set to Show All and Years has 4 periods ranging from May 1, 2017 to Apr 30, 2021.
[x] 2.2. A report set to Show All and Semi-annual periods has 7 periods ranging from May 1, 2017 to Oct 31, 2020.
[x] 2.3. A report set to Show All and Tri-annual periods has 10 periods ranging from May 1, 2017 to Aug 31, 2020.
[x] 2.4. A report set to Quarters has 13 periods ranging from May 1, 2017 to Jul 31, 2020.
[x] 2.5. A report set to Months has 39 periods ranging from May 1, 2017 to Jul 31, 2020.

Most recent
When today's date is inside the reporting period

[x] 1. The date range is inclusive of the current period. So, "last two months" includes this month and last month.
[x] 2. The report runs from the first day of the earliest time or target period in the range to the last day of the latest time or target period in the range.
[x] 3. If the user enters a "Most recent" number larger than there are actual time or target periods available since the program's reporting start date, the IPTT does not throw an error message; it simply displays all available periods going back from today.

When today's date is after the reporting period ends

[x] The IPTT shows you the most recent time periods available working back from the reporting end date. So "last two months" should give you last two months of the program, even if it's 5 years since the program ended.

I was able to verify everything except the very last item for the Actuals only report. (I can't currently access IPTTs for older programs because they don't yet have program reporting periods. I get an error message.)
I am also holding off on testing the Periodic Targets IPTT until we've implemented the automatic generation of target periods based on program reporting start and end dates.


added nix store gc job

Clean up the nix store once a week to prevent the disk from getting full.

TODO: disable running on pull_request


Module typing_extensions missing from requirements.txt

Importing PecanPy requires the module typing_extensions to be installed, however, this is not listed in the requirements.txt.

Hi @Bertr0 thank you for your note! It's been added now: #244


Fix typo in ResolutionRequest.js

Small fix:
Fix typo in error message - should be npm start --reset-cache

@radko93 this doesn't work for me. I thought the -- was necessary to pass the --reset-cache flag through to node node_modules/react-native/local-cli/cli.js start instead of applying it to npm start. Is it possibly project dependent?

It could be related to npm or node version.

Hmm, based on the comments here it looks like using the double dash is much more common. I honestly don't know how it would work without it, since npm doesn't understand that flag and it needs to be passed through.
Do you think we should open an issue, or how should this be resolved? If it truly works for you without the double dash, something very weird is going on 😕
@radko93 I'm on node v7.7.1, npm v4.1.2, and RN v0.42.0, what about you?

@cooperka I merged this in and I'm willing to look at a PR to revert this if it turns out to be inaccurate.


Not able to see x-axis and y-axis labels in some devices.

How to reproduce
On some devices the x-axis and y-axis labels are not visible in the chart. This is device specific, the labels are getting passed into the chart yet the labels are not visible for both the axis. (Devices: Realme GT2, Samsung S22 ultra)
Observed behavior
The x-axis and y-axis labels are being passed, but not visible on some on specific devices.
Expected behavior
The labels for both the devices should be visible in the screen
Vico version(s)
Latest stable version, Latest unstable version
Android version(s)
13
Additional information
Current Version of vico charts used on my end is: 1.6.4

Hello! Thanks for the report. Under “Additional information,” you’ve mentioned that you’re using Vico 1.6.4. Just to confirm, have you checked if this issue occurs in Vico 1.13.1, Vico 1.14.0 Alpha 2, or Vico 2.0.0 Alpha 6?

Hello! Thanks for the report. For “Vico version(s),” you’ve selected “Latest stable version” and “Latest unstable version,” but under “Additional information,” you’ve mentioned that you’re using Vico 1.6.4. Just to confirm, have you checked if this issue occurs in Vico 1.13.1, Vico 1.14.0 Alpha 2, or Vico 2.0.0 Alpha 6?

Not checked on another versions yet.

I’m afraid we’re unable to accept bug reports for outdated Vico versions—the issue may no longer occur in the latest versions, and only if a bug still exists is a report of it actionable. As per the note in the issue template, we’d ask you to check if the problem affects one of the versions listed above. If it does, please reopen this issue.

This happens for me too.
I am using Vico 1.14.0 (views and core libraries).
On pixel phone everything works as expected.
On device Samsung S21, with Android 14 and One UI version 6.0, neither x or y labels are showed.

Hello, @TatjanaDjurdjevic! Could you please share a minimal reproducible example?

I have just tried it out on Pixel 7A with Android 14 (device), and also the x and y axes are not showing, but however on emulator on my laptop which is pixel 7A with Android 14 everything works fine.
Minimal reproducible example:
    val data = listOf("2022-07-01" to 2f, "2022-07-02" to 6f, "2022-07-04" to 4f).associate { (dateString, yValue) ->
        LocalDate.parse(dateString) to yValue
    }
    val xValuesToDates = data.keys.associateBy { it.toEpochDay().toFloat() }
    val chartEntryModel = entryModelOf(xValuesToDates.keys.zip(data.values, ::entryOf))
    val dateTimeFormatter: DateTimeFormatter = DateTimeFormatter.ofPattern("d MMM")
    val horizontalAxisValueFormatter = AxisValueFormatter<AxisPosition.Horizontal.Bottom> { value, _ ->
        (xValuesToDates[value] ?: LocalDate.ofEpochDay(value.toLong())).format(dateTimeFormatter)
    }

    binding.chartViewTest.setModel(chartEntryModel)
    with(binding.chartViewTest) {
        with(bottomAxis as HorizontalAxis) {
            valueFormatter = horizontalAxisValueFormatter
            isZoomEnabled = true
        }
        with(startAxis as VerticalAxis) {
            title = "Test"
            isZoomEnabled = true
            titleComponent = TextComponent.Builder().build()
        }
    }

It was my bad.
Actually the problem was dark mode.
When device is in dark mode, label color is white, and my background is white (app does not support dark mode, and labels were not visible).

Got it, @TatjanaDjurdjevic. I’m glad you’ve found the cause of the issue. Cheers!


FR: Add possibility of using an entity state as image URL

Please consider an option to use an entity state as option for image URL to allow for dynamic changes.
Or perhaps directly full HA (Jinja) template evaluation using other entities' states and attributes ;)

for the sidebar image type, right?

I'm closing this
Template for image domain already exist
https://www.home-assistant.io/integrations/template/#image
and in ha-fusion you can use sidebar 'template' to do this as well
{% if 1 + 1 == 2 %}

{% else %}

{% endif %}

Thanks, didn't know about the image template!


Type 'IRNG' is not assignable to type 'R'.

TypeScript Version:  3.2.0-dev.201xxxxx

Search Terms:
Code
export class RandomRngWithLibRmath<R extends libRmath.IRNG> extends RNG
{
	protected _rng: R;
	protected _seedable: boolean = true;

	protected _init(seed?, opts?, ...argv)
	{
		if (seed instanceof libRmath.IRNG)
		{
			this._rng = seed // Error:(83, 4) TS2322: Type 'IRNG' is not assignable to type 'R'.
		}
	}
}

Expected behavior:
no error
Actual behavior:

Error:(83, 4) TS2322: Type 'IRNG' is not assignable to type 'R'.

Playground Link:
Related Issues:

Every R is a IRNG, but not every IRNG is a R. The behaviour of the compiler is as expected.

so what is correct way do in typescript?

Annotate argument types on protected _init(seed?, opts?, ...argv) - seed specifically - so the instanceof check narrows to R rather than the concrete subtype of R.


feat: Allow passing an async function to NuxtAuthHandler

🔗 Linked issue
Resolves #137
Resolves #138
❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
NuxtAuthHandler accepts options and runtimeConfig in order to build a response as part of the /api/auth/[...] endpoint.
Some adapters, such as D1Adapter, need access to the event in order to connect to the database.
The current solution of passing options as an object does not expose the event.
This PR allows passing options as an async function, which takes event as its argument. That way, users of this package, can extend it, and add any adapter, or other logic that they want.
📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

I have tried this code:
import Credentials from "@auth/core/providers/credentials"
import type { AuthConfig } from "@auth/core/types"
import { D1Adapter } from "@auth/d1-adapter"
import { NuxtAuthHandler } from "#auth"

const runtimeConfig = useRuntimeConfig()

export async function authOptions(event) {
  const authOptions: AuthConfig = {
    secret: runtimeConfig.authJs.secret,
    providers: [
      Credentials({
        credentials: {
          username: { label: "Username" },
          password: { label: "Password", type: "password" },
        },
        authorize: async (credentials) => {
          const user = { id: "1", name: credentials.username, email<EMAIL_ADDRESS>role: "admin" }
          if (user) {
            return user
          } else {
            return null
          }
        },
      })
    ],
    adapter: D1Adapter(event.context.cloudflare.env.D1)
  }
  return authOptions
}

export default NuxtAuthHandler(authOptions, runtimeConfig)

And I am getting this error:

 ERROR  [auth][error][MissingSecret]: Please define a secret.. Read more at https://errors.authjs.dev#missingsecret

 ERROR      at assertConfig (file:///E:/Projects/Nuxt/test/auth/node_modules/@auth/core/lib/assert.js:46:16)
    at Auth (file:///E:/Projects/Nuxt/test/auth/node_modules/@auth/core/index.js:70:29)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.handler (E:\Projects\Nuxt\test\auth\node_modules\@hebilicious\authjs-nuxt\dist\runtime\lib\server.mjs:23:22)
    at async file:///E:/Projects/Nuxt/test/auth/node_modules/h3/dist/index.mjs:1975:19
    at async Object.callAsync (file:///E:/Projects/Nuxt/test/auth/node_modules/unctx/dist/index.mjs:72:16)
    at async toNodeHandle (file:///E:/Projects/Nuxt/test/auth/node_modules/h3/dist/index.mjs:2266:7)
    at async ufetch (file:///E:/Projects/Nuxt/test/auth/node_modules/unenv/runtime/fetch/index.mjs:9:17)
    at async $fetchRaw2 (file:///E:/Projects/Nuxt/test/auth/node_modules/ofetch/dist/shared/ofetch.37386b05.mjs:222:26)
    at async $fetch2 (file:///E:/Projects/Nuxt/test/auth/node_modules/ofetch/dist/shared/ofetch.37386b05.mjs:268:15)

 ERROR  [auth][error][MissingSecret]: Please define a secret.. Read more at https://errors.authjs.dev#missingsecret

 ERROR      at assertConfig (file:///E:/Projects/Nuxt/test/auth/node_modules/@auth/core/lib/assert.js:46:16)
    at Auth (file:///E:/Projects/Nuxt/test/auth/node_modules/@auth/core/index.js:70:29)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.handler (E:\Projects\Nuxt\test\auth\node_modules\@hebilicious\authjs-nuxt\dist\runtime\lib\server.mjs:23:22)
    at async file:///E:/Projects/Nuxt/test/auth/node_modules/h3/dist/index.mjs:1975:19
    at async Object.callAsync (file:///E:/Projects/Nuxt/test/auth/node_modules/unctx/dist/index.mjs:72:16)
    at async toNodeHandle (file:///E:/Projects/Nuxt/test/auth/node_modules/h3/dist/index.mjs:2266:7)
    at async ufetch (file:///E:/Projects/Nuxt/test/auth/node_modules/unenv/runtime/fetch/index.mjs:9:17)
    at async $fetchRaw2 (file:///E:/Projects/Nuxt/test/auth/node_modules/ofetch/dist/shared/ofetch.37386b05.mjs:222:26)
    at async $fetchRaw2 (file:///E:/Projects/Nuxt/test/auth/node_modules/ofetch/dist/shared/ofetch.37386b05.mjs:263:14)

I think your doc is not up to date with the latest changes. The Nuxt module still has old code. Can you please verify?