inconsistency between Queue:fake() and dispatchSync method

Laravel Version
10*
PHP Version
8.2
Database Driver & Version
No response
Description
When you want to test the job class it self, You cannot do it because the Queue::fake() always intercept the job even when using dispatchSync method
Steps To Reproduce
create a job:
class TestJob
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

    public function handle()
    {
        dump('here');
    }
}

create a test:
/** @test */
public function exampleTest()
{
    Queue::fake();

    //assert pushed any other jobs here

    //it doesn't run, but i want to test job itself
    TestJob::dispatchSync();

    //
}

When you run this the dump never executed, The dispatchNow() method was working but removed in laravel 10

This is expected. If you need to test the job itself you'd do so without using the queue or dispatchSync method. Just call the handle method on the job directly.

What if the job has the container's dependency?

You could either just pass the dependencies manually or use the call method on the container:
$job = new TestJob();

$this->app->call([$job, 'handle']);

// Or
App::call([$job, 'handle']);

// Or
app()->call([$job, 'handle']);

This is why i create this issue, the removal DispatchNow was mistaken


[SB] Add sample testing back

Samples were failing after the switch to test proxy due to the resource not being created correctly. Passing locally with tox command
Change tests.yml file add back in:
  MatrixReplace:
    - TestSamples=.*/true

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Service Bus:0.13321856,Cosmos:0.09482916,Azure.Core:0.05242489'


"Error while copying content to a stream" when Run-TestsInBCContainer

I tried to run Run-TestsInBCContainer script but it failed.
Here is a script to create bc container:
import-module navcontainerhelper

$imageName = "mcr.microsoft.com/businesscentral/onprem:cz-ltsc2019"
$containerName = "bctester"
$licenseFile = "C:\Docker\SharedFolder\License.flf"
$auth = "NavUserPassword"
$credential =  New-Object pscredential 'admin', (ConvertTo-SecureString -String 'Pass.1234' -AsPlainText -Force)

New-BCContainer     -accept_eula `
                    -containerName $containerName `
                    -imageName $imageName `
                    -licenseFile $licenseFile `
                    -Auth $auth `
                    -Credential $credential `
                    -doNotExportObjectsToText `
                    -includeTestToolkit `
                    -updateHosts `
                    -dns '<IP_ADDRESS>'

Result of this script:
NavContainerHelper is version <IP_ADDRESS>
Host is Microsoft Windows 10 Enterprise - 1903
Docker Client Version is 19.03.4
Docker Server Version is 19.03.4
Using image mcr.microsoft.com/businesscentral/onprem:cz-ltsc2019
Removing bctester from hosts
Removing C:\ProgramData\NavContainerHelper\Extensions\bctester
Creating Container bctester
Version: 15.0.36560.0-cz
Style: onprem
Platform: 15.0.36510.0
Generic Tag: <IP_ADDRESS>
Container OS Version: 10.0.17763.737 (ltsc2019)
Host OS Version: 10.0.18362.418 (1903)
The container operating system does not match the host operating system, forcing hyperv isolation.
Using locale cs-CZ
Using hyperv isolation
Disabling the standard eventlog dump to container log every 2 seconds (use -dumpEventLog to enable)
Using license file C:\Docker\SharedFolder\License.flf
Files in C:\ProgramData\NavContainerHelper\Extensions\bctester\my:
- AdditionalOutput.ps1
- license.flf
- MainLoop.ps1
- updatehosts.ps1
Creating container bctester from image mcr.microsoft.com/businesscentral/onprem:cz-ltsc2019
4fa6c11d81403d92ccad899373caab23a363ecc966af1f272641fc1540afb139
Waiting for container bctester to be ready
Initializing...
Starting Container
Hostname is bctester
PublicDnsName is bctester
WARNING: Container starts with TimeZone = Střední Evropa (běžný čas), which is not recognized in the list of TimeZones.
Using NavUserPassword Authentication
Starting Local SQL Server
Starting Internet Information Server
Creating Self Signed Certificate
Self Signed Certificate Thumbprint 2E5E5F380878BD230431DECCAEE39B170A49A57A
Modifying Service Tier Config File with Instance Specific Settings
Starting Service Tier
Registering event sources
Creating DotNetCore Web Server Instance
Using license file 'c:\run\my\license.flf'
Import License
Creating http download site
Setting SA Password and enabling SA
Creating admin as SQL User and add to sysadmin
Creating SUPER user
Container IP Address: <IP_ADDRESS>
Container Hostname  : bctester
Container Dns Name  : bctester
Web Client          : http://bctester/BC/
Dev. Server         : http://bctester
Dev. ServerInstance : BC

Files:
http://bctester:8080/al-4.0.176004.vsix

Initialization took 124 seconds
Ready for connections!
Reading CustomSettings.config from bctester
Creating Desktop Shortcuts for bctester
Copy from container bctester (C:\Applications\TestFramework\TestLibraries\Any\Microsoft_Any.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Any.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Any.app
Synchronizing Any on tenant default
Installing Any on tenant default
App successfully published
Copy from container bctester (C:\Applications\TestFramework\TestLibraries\Assert\Microsoft_Library Assert.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Library Assert.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Library Assert.app
Synchronizing Library Assert on tenant default
Installing Library Assert on tenant default
App successfully published
Copy from container bctester (C:\Applications\TestFramework\TestRunner\Microsoft_Test Runner.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Test Runner.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Test Runner.app
Synchronizing Test Runner on tenant default
Installing Test Runner on tenant default
App successfully published
Copy from container bctester (C:\Applications\System Application\Test\Microsoft_System Application Test Library.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_System Application Test Library.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_System Application Test Library.app
Synchronizing System Application Test Library on tenant default
Installing System Application Test Library on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-TestLibraries.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-TestLibraries.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-TestLibraries.app
Synchronizing Tests-TestLibraries on tenant default
Installing Tests-TestLibraries on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Bank.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Bank.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Bank.app
Synchronizing Tests-Bank on tenant default
Installing Tests-Bank on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Cash Flow.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Cash Flow.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Cash Flow.app
Synchronizing Tests-Cash Flow on tenant default
Installing Tests-Cash Flow on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Cost Accounting.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Cost Accounting.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Cost Accounting.app
Synchronizing Tests-Cost Accounting on tenant default
Installing Tests-Cost Accounting on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-CRM integration.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-CRM integration.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-CRM integration.app
Synchronizing Tests-CRM integration on tenant default
Installing Tests-CRM integration on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Data Exchange.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Data Exchange.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Data Exchange.app
Synchronizing Tests-Data Exchange on tenant default
Installing Tests-Data Exchange on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Dimension.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Dimension.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Dimension.app
Synchronizing Tests-Dimension on tenant default
Installing Tests-Dimension on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-ERM.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-ERM.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-ERM.app
Synchronizing Tests-ERM on tenant default
Installing Tests-ERM on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Fixed Asset.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Fixed Asset.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Fixed Asset.app
Synchronizing Tests-Fixed Asset on tenant default
Installing Tests-Fixed Asset on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-General Journal.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-General Journal.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-General Journal.app
Synchronizing Tests-General Journal on tenant default
Installing Tests-General Journal on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Graph.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Graph.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Graph.app
Synchronizing Tests-Graph on tenant default
Installing Tests-Graph on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Integration.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Integration.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Integration.app
Synchronizing Tests-Integration on tenant default
Installing Tests-Integration on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Invoicing.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Invoicing.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Invoicing.app
Synchronizing Tests-Invoicing on tenant default
Installing Tests-Invoicing on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Job.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Job.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Job.app
Synchronizing Tests-Job on tenant default
Installing Tests-Job on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Local.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Local.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Local.app
Synchronizing Tests-Local on tenant default
Installing Tests-Local on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Misc.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Misc.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Misc.app
Synchronizing Tests-Misc on tenant default
Installing Tests-Misc on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Permissions.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Permissions.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Permissions.app
Synchronizing Tests-Permissions on tenant default
Installing Tests-Permissions on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Physical Inventory.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Physical Inventory.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Physical Inventory.app
Synchronizing Tests-Physical Inventory on tenant default
Installing Tests-Physical Inventory on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Prepayment.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Prepayment.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Prepayment.app
Synchronizing Tests-Prepayment on tenant default
Installing Tests-Prepayment on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Rapid Start.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Rapid Start.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Rapid Start.app
Synchronizing Tests-Rapid Start on tenant default
Installing Tests-Rapid Start on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Report.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Report.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Report.app
Synchronizing Tests-Report on tenant default
Installing Tests-Report on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Resource.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Resource.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Resource.app
Synchronizing Tests-Resource on tenant default
Installing Tests-Resource on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Reverse.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Reverse.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Reverse.app
Synchronizing Tests-Reverse on tenant default
Installing Tests-Reverse on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-SCM.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-SCM.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-SCM.app
Synchronizing Tests-SCM on tenant default
Installing Tests-SCM on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-SMB.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-SMB.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-SMB.app
Synchronizing Tests-SMB on tenant default
Installing Tests-SMB on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-SMTP.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-SMTP.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-SMTP.app
Synchronizing Tests-SMTP on tenant default
Installing Tests-SMTP on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Upgrade.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Upgrade.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Upgrade.app
Synchronizing Tests-Upgrade on tenant default
Installing Tests-Upgrade on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-User.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-User.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-User.app
Synchronizing Tests-User on tenant default
Installing Tests-User on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-VAT.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-VAT.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-VAT.app
Synchronizing Tests-VAT on tenant default
Installing Tests-VAT on tenant default
App successfully published
Copy from container bctester (C:\Applications\BaseApp\Test\Microsoft_Tests-Workflow.app) to C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Workflow.app
Publishing C:\ProgramData\NavContainerHelper\Extensions\bctester\_Microsoft_Tests-Workflow.app
Synchronizing Tests-Workflow on tenant default
Installing Tests-Workflow on tenant default
App successfully published
TestToolkit successfully imported
Container bctester successfully created
bctester is running!

Then I run this script:
import-module navcontainerhelper

$containerName = "bctester"
$xunitResultsFile = "c:\programdata\navcontainerhelper\Tests-Local-results.xml"
$credential =  New-Object pscredential 'admin', (ConvertTo-SecureString -String 'Pass.1234' -AsPlainText -Force)
$app = Get-NavContainerAppInfo $containerName | Where-Object { $_.Name -eq "Tests-Local" }
Run-TestsInBCContainer `
    -containerName $containerName `
    -credential $credential `
    -detailed `
    -XUnitResultFileName $xunitResultsFile `
    -extensionId $app.AppId

But this error occur:
CommunicationError : Error while copying content to a stream.
CommunicationError InnerException : System.Net.Http.HttpRequestException: Error while copying content to a stream. ---> System.IO.IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. ---> System.Net.Sockets.SocketException: An existing connection was forcibly closed by the remote host
   at System.Net.Sockets.Socket.EndReceive(IAsyncResult asyncResult)
   at System.Net.Sockets.NetworkStream.EndRead(IAsyncResult asyncResult)
   --- End of inner exception stack trace ---
   at System.Net.ConnectStream.EndRead(IAsyncResult asyncResult)
   at System.Net.Http.HttpClientHandler.WebExceptionWrapperStream.EndRead(IAsyncResult asyncResult)
   at System.Net.Http.StreamToStreamCopy.BufferReadCallback(IAsyncResult ar)
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Dynamics.Framework.UI.Client.JsonHttpClient.<>c__DisplayClass15_0.<EndInvokeInteractions>b__0() in s:\repo\src\Platform\Client\ClientService\Prod.Client.ClientService.Client\Service\ServiceClients\JsonHttpClient\JsonHttpClient.cs:line 299
   at Microsoft.Dynamics.Framework.UI.Client.JsonHttpClient.ConvertExceptions[T](Func`1 action) in s:\repo\src\Platform\Client\ClientService\Prod.Client.ClientService.Client\Service\ServiceClients\JsonHttpClient\JsonHttpClient.cs:line 182
ClientSession State is InError (Wait time 5 seconds)
at AwaitState, C:\ProgramData\NavContainerHelper\Extensions\bctester\PsTestTool-4\ClientContext.ps1: line 179
at InvokeInteraction, C:\ProgramData\NavContainerHelper\Extensions\bctester\PsTestTool-4\ClientContext.ps1: line 197
at InvokeInteractionAndCatchForm, C:\ProgramData\NavContainerHelper\Extensions\bctester\PsTestTool-4\ClientContext.ps1: line 206
at OpenForm, C:\ProgramData\NavContainerHelper\Extensions\bctester\PsTestTool-4\ClientContext.ps1: line 221
at Run-Tests, C:\ProgramData\NavContainerHelper\Extensions\bctester\PsTestTool-4\PsTestFunctions.ps1: line 281
at <ScriptBlock>, <No file>: line 49
ClientSession State is InError (Wait time 5 seconds)
At C:\Program Files\WindowsPowerShell\Modules\navcontainerhelper\<IP_ADDRESS>\AppHandling\Run-TestsInNavContainer.ps1:368 char:17
+                 throw $_.Exception.Message
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (ClientSession S...time 5 seconds):String) [], RuntimeException
    + FullyQualifiedErrorId : ClientSession State is InError (Wait time 5 seconds)

I assume that this happens every time? and immediately?
Could you try to add -debugMode and -connectFromHost to your run-tests line?

Yes it happens every time. What is the immediately? It will happen after 10 - 15 seconds.
I tried to add -debufMode and -connectFromHost but the result is the same.

We are looking after a problem on your setup.
I copy/pasted you exact script and it works here, so you are not looking for a problem in that.

Are you running any kind of endpoint-protection, antivirus software?

Yes I have antivirus software. Could that be a problem?

You could try to disable it temporarily - we have seen antivirus and endpoint protection give strange problems - and your script runs without any modifications on my box.

Ok. It's a little problem because I can't disable that due to our internal policy. So I will close this issue. Thanks


fix: remove blur effect causing unwanted shadows in dark mode navbar

Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:

[x] Target branch: Please verify that the pull request targets the dev branch.
[x] Description: Provide a concise description of the changes made in this pull request.
[ ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[ ] Testing: Have you written and run sufficient tests for validating the changes?
[x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[x] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description

Removed blur in Navbar component that added unwanted shadows around the ModelSelector component in Darkmode.

Added
Changed

Removed unwanted "blur" in Navbar.svelte

Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
Screenshots or Videos

Hey, just out of curiosity, why was this closed? I wanted to contribute to Open WebUI and remove the extra "unwanted" shadows around the model selector. Thanks for all your hard work!


Adding material design icons.

To use:

Set `font-family: "Material Icons"
Set the content to the material design icon name such as fast_forward
Change font size
Add .material-icons class

Merging...

Hey, Brian Im having trouble getting this to work. Should I declare an @fontface ?


Tables not centered

Right now the tables are left aligned, which looks strange since the table titles are centered.
In addition, the top and bottom of tables lack spacing, so when there are multiple tables without text in between, the spacing looks very condensed.

Ping @opoudjis . This is certainly a regression?

The spacing is https://github.com/riboseinc/metanorma-iso/issues/242
The alignment of tables was ever thus; we just haven't noticed it before because our tables were wide enough to cover the page.
Word HTML only enforces centering of tables by wrapping them in <div align=center>.


[actions] cli output formatting for fastlane action changelog_from_git_commits

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
It's difficult to read the output of fastlane action changelog_from_git_commits
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

PR coming

@hjanuschka just pointed out that we have a PR ready for this: https://github.com/fastlane/fastlane/pull/7391


Support installation with pip

Please add EmmaPython to PyPI so we can install and keep up with versions with pip.

+1

+1

+1

+1


Google Colab Notebook?

I am having issues with the install of PointSite. I would like to use it. Do you think you could set up a Google Colab Notebook to run it? Many thanks!

It's Tencent.  Not likely going to get any help or assistance from them :(

Oh, is that right? I did not know that... Oh, well, it has been 4 months already. I did not expect a response.


Get and set layout

Does the API provide a way to get the layout settings of the current artboard and also set them?

what do you mean by layout?

The user settings in View > Canvas > Layout Lettings.
The context API exposes all of those settings via artboard.layout(), totalWidth(), numberOfColumns(), etc.
Would love for this to be built into the JS api to be able to read those properties and set them as well.


fix advanced filtering issue

Fixes #7452

fix advanced filtering issue where we were trying to search for a specific value in all cols (including labels) and some items to be searched don't even have metadata.labels
bump rancher icons version

QA Testing

Test on rancher/dashboard, OS management (elemental) product

Add the elemental-ui repo to Apps/repositories so that elemental-ui extension becomes available to install

Install the elemental-ui on extensions in rancher/dashboard

Install elemental-operator

Go to Local cluster -> open kubectl shell -> install helm chart:
helm install --create-namespace -n cattle-elemental-system elemental-operator \
             oci://registry.opensuse.org/isv/rancher/elemental/charts/elemental/elemental-operator

Update elemental-operator

On the same kubectl shell run:
helm upgrade --create-namespace -n cattle-elemental-system --install elemental-operator oci://registry.opensuse.org/isv/rancher/elemental/stable/charts/elemental/elemental-operator

Enter side-menu entry OS Management

Go to Machine Inventories list view and create a few items of this resource type

Make sure advanced filtering is working as expected

I encountered 2 issues while testing the UI:

For some reasons on first load the navigation does not show the filter, but it appears if I navigate
The error is still persistent if I create a resource with a label

Left is local this PR, right is production on DO.

https://user-images.githubusercontent.com/5009481/201972281-f5b7d75f-558b-42ff-b50d-b764f3b1e3ed.mov

@cnotv I don't think this is testable since the extension installed has been built using an npm package called @rancher/shell  , from which it gets all of it’s @shell stuff from the core rancher/dashboard, including sortable table and filtering…. If I am correct, then I need the code to be approved, then update the @rancher/shell package which comes from rancher/dashboard, rebuild the extension and publish it  :sweating: :sweating: :sweating: :sweating:

another way to test is to run the elemental-ui repo locally
https://github.com/rancher/elemental-ui
go to node_modules/@rancher/shell , modify the code manually and check if it’s running properly

Screenshot from running the repo locally and modifying the code (just a couple of line):

another way to test is to run the elemental-ui repo locally

For some reasons on first load the navigation does not show the filter, but it appears if I navigate -> will create a separate issue to deal with that as it's a non-blocker and should be self contained on the elemental-ui repo

FYI @nwmac . This is untestable in the current scenario. There are a couple of ways to circumvent it, but not a "straight-line" to easy testing.

As discussed today, we may test this PR by linking the package with yarn link as well.

@cnotv can you give it another try, if possible? I need to merge this and release a new version of @rancher/shell package so that I can move forward with my Elemental work 🙏 🙇

I am not able to retrieve the branched code and use yarn link for some reasons, as the code seems outdated and still cause issues.

Changing the code I still have the same issue 🤔

@aalves08 Since the filter.js file you are working on includes a function and we can setup the test it in 2 minutes, given the right data, I would recommend you to write a unit test out of it.


usb: device_next: wait for device to resume after remote wakeup signal

After the remote wake-up signal, wait a short time for the device to resume.
If device is suspended, try to signal remote wakeup before buffer enqueue.

@jfischer-no do you plan to come back to this PR?

@jfischer-no do you plan to come back to this PR?

Yes.


Intallation failure on OSX

Can't install drafter package on OSX 10.11, npm 3.5.2, node v5.3.0, npm-debug.log
../../nan/nan.h:676:12: error: no viable conversion from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>'
../../nan/nan.h:683:26: error: no member named 'Use' in namespace 'node::Buffer'
/Users/Skay/.node-gyp/5.3.0/include/node/v8.h:221:5: error: assigning to 'v8::Primitive *volatile' from incompatible type 'v8::Value *'
...
9 errors generated.
make: *** [Release/obj.target/protagonist/src/annotation.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 15.0.0
gyp ERR! command "/usr/local/Cellar/node/5.3.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/Skay/Webserver/skaternames/api/node_modules/drafter/node_modules/protagonist
gyp ERR! node -v v5.3.0
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok

Hi @pavelkornev, drafter.js and boutique do not support Node 3/4/5 and probably never will since the libraries are deprecated.
I'd highly recommend you instead use Protagonist. Check out the README for more information.


Exposing symbol entry point to kore_parser

This PR is intended to expose how to parse a symbol name from KORE. This is a demand from the Math Proof team of Pi2 to help them with their parser.

You will need to bump the hint trace format version here as you're adding new data to the trace.

There's a big switch-case statement where we parse sentences; is it possible to refactor the code in that part to use this new method?

I can do it in application_pattern but not in sentence. The difference is that in the last, we're setting it as hooked or not, and we're using sort_variables(symbol.get()) instead of init_pattern_arguments().
I've modified the code to use symbol in application_pattern .

Makes sense!


Add code style

See #32 for more information.
This PR enforces a common style across all JS code, specifically eslint-config-i-am-meticulous.

@MoOx I ignored
statinamic-static*

and unignored the scripts, but now I still get 30000 warnings. Any ideas?

I will check later, not on my computer anymore.
Where does the issues came from (which file)?

I can't see it's too many lines of errors and my terminal cuts the output. :hankey:


[Android] dive deeper to picture

url encoded things

This is not possible, I have spoken with server and things should stay decoded


Docker support to fix Windows builds (and Linux/Mac)

Hi,
Firstly, thanks for this project - it makes building ffmpeg far easier!
I wanted to be able to easily build this on Windows but noticed that's now not possible in v2.0.0, and last time I did try and build it on Windows using MSYS2 pre v2.0.0 I ended up with a whole range of strange build problems and just ended up installing an Ubuntu VM where it was quite straight forward.
I'd like to avoid having to use a Linux VM so I figured the best way would be to be able to build it in Docker. I've created pull request 21 which will build a Docker image that does all the work for you. You can mount /build/build from the Docker container to a path on your host to access to the built files.
I've updated the readme in the pull request which explains how to use it.

Hello @akiller ,
Thanks for your contribution.
Actually I wanted to reenable MSYS2 support. I just didn't have much time during last 2 months.
In a couple of days finally I'll return to my projects. And I will examine the opportunity to fix MSYS2 as well as your solution. I'm not really familiar with Docker.

Great. All you should need to do is install Docker then run the two commands I added to the readme and wait for them to do the work for you.
Personally I would say with Docker support there's little need to support MSYS2 as this is far easier to set-up and should be more consistent as regardless of whether you're running Linux, Mac, or Windows  using the Docker method means the build process will always happen inside a containerised Ubuntu instance and you don't need to bother configuring all your paths to the NDK etc.

Hello @akiller ,
I've spent some time reviewing the Docker and the integration you made. In general I would like to thank you for the idea of abstracting the building process. However, I see a pretty narrow use case of this thing. Let me explain.
Here are pros:

It really allows building the FFmpeg on any machine regardless the dependencies that are necessary for it.
It fixes (or introduces) Windows support.

And here are cons as I see them:

The necessity of installing the Docker itself.
It doesn't run natively (even though it isn't a virtual machine).
On macOS the Docker does use the Linux virtual machice.
Inside the container the Android SDK and Android NDK will be downloaded as well as a lot of other dependencies.

The first 3 points here are pretty small. But the 4th one is major I think. In my opinion the main use case of ffmpeg-android-maker is to be executed on an Android developer machine which already has Android SDK and Android NDK installed. So I don't think downloading of them again are necessary at all. Even caching of them isn't necessary inside the container.
For now I see Docker only as a way of replacing MSYS2 on Windows and definitely not as a primary way of executing the ffmpeg-android-maker on any machine.
For that reason I would like to move the description of how to use it to a separate Wiki page and leave only a mentioning in the README.md.
On Linux and macOS I would keep executing the ffmpeg-android-maker only natively.
As for the MSYS2, I still think it is a viable way to execute the script. Soon I'll update its integration and prepare new Wiki pages with proper descriptions of how to execute the script with necessary preparations.

And one more thing @akiller ,
I actually didn't succeed in making Docker work with this particular repository. Could you please have a look:

The sources directory is created to cache the sources of FFmpeg and its external dependencies. It doesn't exist before the first execution of the script. And your Docker script tries to copy it for some reason. Please, have a look at this use case when there are no caches at all.
And another thing. Actually a question. Is it really necessary to install platforms;android-29? My Travis CI integration downloads a pure Android SDK and doesn't install it. And it works fine.

@Javernaut,
I agree - if you're running Linux and already have the NDK installed and set-up then you probably don't need this as your script already helps make the build process very simple.
However if like me you're running Windows and don't really want to set-up MSYS2 then clearly this is useful.

The necessity of installing the Docker itself.

Sure. The Docker approach is just an option available, you obviously don't need to use it. Installing Docker is no harder than installing MSYS2 on Windows and I'd imagine quite a lot of people already use it, certainly if you're a full-stack developer.

It doesn't run natively (even though it isn't a virtual machine).

True, but this isn't a bad thing because it provides a consistent build platform.
E.g., imagine there's a weird bug in the Windows NDK that doesn't exist in the Linux one or a weird bug in the NDK if you're running OSX Catalina that causes the library to crash on the phone - I'm clearly making these examples up, but hopefully my sentiment makes sense!

On macOS the Docker does use the Linux virtual machice.

It does on Windows too, it's managed entirely by Docker.

Inside the container the Android SDK and Android NDK will be downloaded as well as a lot of other dependencies.

This is the Docker way really. I did try and keep it as lean as I could.
It's done like this so you can guarantee consistency. So if you and I both ran the same Dockerfile on our PCs we could be sure we're using the same version of the NDK for example, and have the same build tools (e.g., clang) installed. Perhaps you have r20 installed on your PC but this project only supports r18: you can easily fulfil that dependency via Docker.
You only need to build the image once, you don't need to build it every time so it doesn't have to keep downloading all these dependencies unless of course you change the NDK/SDK versions.

For now I see Docker only as a way of replacing MSYS2 on Windows and definitely not as a primary way of executing the ffmpeg-android-maker on any machine.
For that reason I would like to move the description of how to use it to a separate Wiki page and leave only a mentioning in the README.md.
On Linux and macOS I would keep executing the ffmpeg-android-maker only natively.

I agree. If you're already using Linux there's likely no need to use this, unless you have some weird incompatible built tool versions installed like I mentioned before.

As for the MSYS2, I still think it is a viable way to execute the script. Soon I'll update its integration and prepare new Wiki pages with proper descriptions of how to execute the script with necessary preparations.

I wonder if it might be better to look at using WSL2 rather than MSYS2 on Windows. Like MSYS2 it just gives you a Linux terminal, but behind the scenes runs a lightweight Linux VM in Hyper-V. Your original script might actually work fine using it without any changes because of this.

I actually didn't succeed in making Docker work with this particular repository. Could you please have a look:
The sources directory is created to cache the sources of FFmpeg and its external dependencies. It doesn't exist before the first execution of the script. And your Docker script tries to copy it for some reason. Please, have a look at this use case when there are no caches at all.

Oops my mistake. I've removed this and it now builds.

And another thing. Actually a question. Is it really necessary to install platforms;android-29? My Travis CI integration downloads a pure Android SDK and doesn't install it. And it works fine.

Oh OK, I've removed it and it seems to still build for me. I've pushed the changes 🙂.

Hello @akiller ,
I've been thinking about Docker for a while and your particular implementation. I came up with certain ideas.
From the very beginning I didn't like the idea of placing Docker files right in the root of the repository. I think tooling-specific files shouldn't live there. Even the .travis.yml bothers me :)
Also, I don't really like the idea of preparing a Docker image for building the specific version of ffmpeg-android-maker. Here I mean the specific state of the ffmpeg-android-maker repo, because you upload it to the image during the construction. So I would leave only a build-ready image and provide the whole ffmpeg-android-maker directory in docker container run command.
The whole point is to work on those scripts directly on a developer machine and Docker should just pick up whatever you are working on, ins't it?
By merging the aforementioned ideas I came up to the idea of creating a separate Github repository for building Docker images and share them via Docker HUB. Hanse the Docker HUB can build and publish images from a Github repo automatically.
Thus the ffmpeg-android-maker will be clean of Docker integration and still users will be able to build their custom images if they want by working with that separate repository.
I'm really excited with this idea, hope to implement it in reasonable time. I start liking Docker.
Really appreciate your participating and introducing Docker to me. I'll leave this issue opened till it's done, but will close your pull request.

And one more thing @akiller ,
One more thank for the idea to using WSL on Windows. The actual Linux virtual machine is bigger in size than MSYS2, but provides better environment than MSYS2 emulation.

@Javernaut,

I've been thinking about Docker for a while and your particular implementation. I came up with certain ideas.
From the very beginning I didn't like the idea of placing Docker files right in the root of the repository. I think tooling-specific files shouldn't live there. Even the .travis.yml bothers me :)

Haha fair enough!

Also, I don't really like the idea of preparing a Docker image for building the specific version of ffmpeg-android-maker. Here I mean the specific state of the ffmpeg-android-maker repo, because you upload it to the image during the construction. So I would leave only a build-ready image and provide the whole ffmpeg-android-maker directory in docker container run command.
The whole point is to work on those scripts directly on a developer machine and Docker should just pick up whatever you are working on, ins't it?
By merging the aforementioned ideas I came up to the idea of creating a separate Github repository for building Docker images and share them via Docker HUB. Hanse the Docker HUB can build and publish images from a Github repo automatically.
Thus the ffmpeg-android-maker will be clean of Docker integration and still users will be able to build their custom images if they want by working with that separate repository.
I'm really excited with this idea, hope to implement it in reasonable time. I start liking Docker.
Really appreciate your participating and introducing Docker to me. I'll leave this issue opened till it's done, but will close your pull request.

Sure, no problem. At first I also wasn't very sure about the benefits of Docker but the more I use it the more I like it. It generally just makes things very easy and rapid to deploy.
So I got a bit of free time today and I decided to build https://github.com/akiller/ffmpeg-android-maker-docker which I think solves your problem.
Please check the readme on the project as it explains it in more detail, but effectively this either lets you build from a specific Github commit (which is what 99% of people would use), or you can mount your current working directory and build using that which is useful if you're developing ffmpeg-android-maker but want to build using Docker without having to commit the code.
It also removes all of your code from the base image which was one of the problems you raised.
Hope to hear your feedback!

Hello @akiller ,
It is really nice when someone is interested in my project and does such a contribution.
However, I think I have to reimplement the same thing myself. Here are my reasons:

I really want to practice with Docker myself. I think this is the most important reason.
In this case publishing to Docker HUB will be easier for me.
You and me have just a little different considerations of what the Docker image should do (I'll explain below).
I realised there should be done one important change in this repo which actually may impact the Docker image construction.

I'm not sure in usefulness of both environment variables (EXTRA_BUILD_CONFIGURATION_FLAGS and ANDROID_MAKER_COMMIT) you are featuring to use.
The idea of ffmpeg-android-maker is to be able to customise the build script and compile the FFmpeg the way that is suitable for a particular project. For now the whole repo serves the particular Android app - WhatTheCodec. For example, ffmpeg-android-maker doesn't compile any encoders and muxers.
So this means ANDROID_MAKER_COMMIT is not really usable for anyone except me. And EXTRA_BUILD_CONFIGURATION_FLAGS can potentially have flags that will clash with those that are already in ffmpeg-android-maker's script.
Moreover, particular customisation may involve creating of new shell scripts (when a new external library is integrated). And I think it decreases the value of EXTRA_BUILD_CONFIGURATION_FLAGS even more.
I strongly believe users should be able to edit all files in the ffmpeg-android-maker directly and Docker should just pickup it and build.
I don't want to delegate too much work to Docker image and would like have it only as a thing that can build whatever a developer has done in his/her ffmpeg-android-maker repo.
Just a side note, I see you didn't configure the image with necessary software to build libdav1d. Apart from necessary software I feel like the list of software that is getting installed is a little bit bigger than it should be. I need to check it out.
The 'important change' I mentioned is that I realised the ffmpeg-android-maker should be more generic and serve both as a basis for customisation and as an example of such a customisation. So I'll change the master branch to compile FFmpeg without any customisation and will create a separate branch for my particular Android app to be the example.
I'm sorry for being such a bad collaborator by just discarding your work and saying that I'll do it myself, but I have reasons. But I'm really grateful for your ideas and the opportunity to learn a new technology.

However, I think I have to reimplement the same thing myself. Here are my reasons:
* I really want to practice with Docker myself. I think this is the most important reason.
* In this case publishing to Docker HUB will be easier for me.
* You and me have just a little different considerations of what the Docker image should do (I'll explain below).

Haha don't worry about it. My repo solves the problems we have. You're obviously welcome to take whatever you want from it, and feel free to drop me a message if you need some Docker help. I'm not an expert but I've built quite a few different images.
Having this available on Dockerhub would be great.

I'm not sure in usefulness of both environment variables (EXTRA_BUILD_CONFIGURATION_FLAGS and ANDROID_MAKER_COMMIT) you are featuring to use.
The idea of ffmpeg-android-maker is to be able to customise the build script and compile the FFmpeg the way that is suitable for a particular project. For now the whole repo serves the particular Android app - WhatTheCodec. For example, ffmpeg-android-maker doesn't compile any encoders and muxers.
So this means ANDROID_MAKER_COMMIT is not really usable for anyone except me. And EXTRA_BUILD_CONFIGURATION_FLAGS can potentially have flags that will clash with those that are already in ffmpeg-android-maker's script.
Moreover, particular customisation may involve creating of new shell scripts (when a new external library is integrated). And I think it decreases the value of EXTRA_BUILD_CONFIGURATION_FLAGS even more.
I strongly believe users should be able to edit all files in the ffmpeg-android-maker directly and Docker should just pickup it and build.

I see what you're trying to say now and why you thought my approach was strange!
As it happens for our requirements building directly from Github was fine we didn't need to customise any of the scripts.
The only thing we needed to do was pass the --disable-gpl flag because we need to use it in a commercial app which was the sole reason I added EXTRA_BUILD_CONFIGURATION_FLAGS.

I don't want to delegate too much work to Docker image and would like have it only as a thing that can build whatever a developer has done in his/her ffmpeg-android-maker repo.

It would perhaps be a good idea to add some default build scripts for different scenarios and let the user choose one when they create the container, e.g., let's say you create one called swscale in /ffmpeg-android-maker that will build libswscale, and set a gpl=0 environment variable for the script to read:
docker run --rm -e "gpl=0" ffmpeg-android-maker swscale.sh

And if they wanted to use their own bespoke scripts they could just mount a volume to /ffmpeg-android-maker containing the script and specify to execute that instead:
docker run --rm -v /path/to/my/custom/scripts:/ffmpeg-android-maker ffmpeg-android-maker mycustomscript.sh

I'm just thinking out loud, I'm not sure if this is the best way or not.

Just a side note, I see you didn't configure the image with necessary software to build libdav1d. Apart from necessary software I feel like the list of software that is getting installed is a little bit bigger than it should be. I need to check it out.

Oh OK. We're only using libavutil and libswscale so that we can resize images using Lanczos in Android.
One thing you (or any user) could do with Docker is create your base image that contains the minimal build tools and then you could create another Dockerfile that builds on top of it and generates a new image for special cases like libdav1d,  e.g.:
FROM ffmpeg-android-maker:latest

RUN apt-get update && \
	apt-get install -y --no-install-recommends \
	...

I'm sorry for being such a bad collaborator by just discarding your work and saying that I'll do it myself, but I have reasons. But I'm really grateful for your ideas and the opportunity to learn a new technology.

Don't worry about it, I don't like people touching my code either 😊
The fact you're exploring Docker and how to improve the project going forwards is really the best option.

Hey @akiller ,
I've finished my own implementation. There is even a Docker image available on Docker Hub. It was really nice experience.
There is even a separate release for it. I mentioned you there :)
Stay healthy and have a good day!

That's great! Thanks for letting me know and glad you got it all working in the end.


Feature/py stel

This pull request improves the pySTEL libarary.

Classes are now implemented for the various codes.
Seperate classes now exist for dealing with input data.
Classes wrapper fortran code for reading/writing files.
BEAMS3D, DIAGNO, FIELDLINES, and STELLOPT input namelist routines now reside in LIBSTELL.
A few helper utilities now exist for quickly making a few python plots.
Included two examples for importing Blender data to render VMEC equilibria and coils data.

This closes issue #231 .

@kudav Can you check this doesn't break anything for you?


Add docker registry, orchestrator and worker namespaces

Also fixed some issues discovered in the process, commit messages should provide enough explanation.
The only thing that is missing now is the buildroot.
TODO:

[x] update README, but only minor changes until buildroot is done

Removed deprecated items from client config secret

Removed the insecure option for openshift from reactor-config-map, removed empty plays :eyes:

Works like charm, except I got this traceback when I run build.
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/koji/daemon.py", line 1292, in runTask
    response = (handler.run(),)
  File "/usr/lib/python3.7/site-packages/koji/tasks.py", line 314, in run
    return koji.util.call_with_argcheck(self.handler, self.params, self.opts)
  File "/usr/lib/python3.7/site-packages/koji/util.py", line 263, in call_with_argcheck
    return func(*args, **kwargs)
  File "/usr/lib/koji-builder-plugins/builder_containerbuild.py", line 913, in handler
    triggered_after_koji_task=opts.get('triggered_after_koji_task', None),
  File "/usr/lib/koji-builder-plugins/builder_containerbuild.py", line 568, in runBuilds
    semi_results = self.createContainer(**kwargs)
  File "/usr/lib/koji-builder-plugins/builder_containerbuild.py", line 642, in createContainer
    build_response = create_method(**orchestrator_create_build_args)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 57, in catch_exceptions
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 882, in create_orchestrator_build
    return self._do_create_prod_build(**kwargs)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 784, in _do_create_prod_build
    response = self._create_build_config_and_build(build_request)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 473, in _create_build_config_and_build
    existing_bc = self.os.create_build_config(json.dumps(build_json)).json()
  File "/usr/local/lib/python3.7/site-packages/osbs/http.py", line 216, in json
    raise OsbsResponseException(text, self.status_code)
osbs.exceptions.OsbsResponseException: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"the API version in the data (v1) does not match the expected API version (build.openshift.io/v1)","reason":"BadRequest","code":400}

This is caused by old metadata in /usr/shares/osbs/orchestrator.json. It seems that those tempaltes are not updated from git installation so osbs-client from master code fails.

I also noticed that rebuilds are done from cache, I'd prefer no-cache builds to avoid nasty race conditions when I want just update code from git
https://docs.openshift.com/container-platform/3.11/dev_guide/builds/build_strategies.html#no-cache

This is caused by old metadata in /usr/shares/osbs/orchestrator.json. It seems that those tempaltes are not updated from git installation so osbs-client from master code fails.

@MartinBasti the templates should be updated, but by default, pip3 will install everything in /usr/local/, so they get updated in the wrong location. This should not be the case for the koji images, because koji-base sets the PIP_PREFIX=/usr environment variable.
I suspect the traceback is not from koji-builder but rather the buildroot - speaking of, what are you using for that?

Added noCache options for koji base, client, builder and hub (db should not need it), changed default names for namespace, increased PV "capacity" (it probably does not do anything)

Again, new origin installation with fetched PR changes
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/koji/daemon.py", line 1292, in runTask
    response = (handler.run(),)
  File "/usr/lib/python3.7/site-packages/koji/tasks.py", line 314, in run
    return koji.util.call_with_argcheck(self.handler, self.params, self.opts)
  File "/usr/lib/python3.7/site-packages/koji/util.py", line 263, in call_with_argcheck
    return func(*args, **kwargs)
  File "/usr/lib/koji-builder-plugins/builder_containerbuild.py", line 913, in handler
    triggered_after_koji_task=opts.get('triggered_after_koji_task', None),
  File "/usr/lib/koji-builder-plugins/builder_containerbuild.py", line 568, in runBuilds
    semi_results = self.createContainer(**kwargs)
  File "/usr/lib/koji-builder-plugins/builder_containerbuild.py", line 642, in createContainer
    build_response = create_method(**orchestrator_create_build_args)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 57, in catch_exceptions
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 882, in create_orchestrator_build
    return self._do_create_prod_build(**kwargs)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 784, in _do_create_prod_build
    response = self._create_build_config_and_build(build_request)
  File "/usr/local/lib/python3.7/site-packages/osbs/api.py", line 473, in _create_build_config_and_build
    existing_bc = self.os.create_build_config(json.dumps(build_json)).json()
  File "/usr/local/lib/python3.7/site-packages/osbs/http.py", line 216, in json
    raise OsbsResponseException(text, self.status_code)
osbs.exceptions.OsbsResponseException: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"the API version in the data (v1) does not match the expected API version (build.openshift.io/v1)","reason":"BadRequest","code":400}

Man, I thought docker was supposed to fix the "works on my machine" issue:
$ oc -n osbs-koji rsh dc/koji-builder cat /usr/share/osbs/orchestrator.json
{
  "apiVersion": "build.openshift.io/v1",
  "kind": "BuildConfig",
  ...
}

$ oc -n osbs-koji rsh dc/koji-builder ls /usr/local/lib/python3.7/
ls: cannot access '/usr/local/lib/python3.7/': No such file or directory
command terminated with exit code 2

oc -n osbs-koji rsh dc/koji-builder cat /usr/share/osbs/orchestrator.json
{
  "apiVersion": "v1",
  "kind": "BuildConfig",
  "metadata": {
....

I'm not using overrides

@MartinBasti

I'm not using overrides

Right, that means the images are built from containerbuildsystem/osbs-box@a-new-box. You need to override the defaults to make openshift build from this PR (either use my repo, or somehow specify this PR instead of the a-new-box branch if that is possible)


pull main to ref renaming

Motivation

Solution

hoping this would merge automatically or easily but nope. closing and i will start again


Helm package --destination needs to run twice

When running helm package with --destination ./helm/tarballs and this directory did not exist before, then the command needs to be run twice to succeed:
$ rm -rf helm/tarballs/
$ helm package .  --destination ./helm/tarballs/
Successfully packaged chart and saved it to:
$ helm package .  --destination ./helm/tarballs/
Successfully packaged chart and saved it to: helm/tarballs/mytest-0.1.0.tgz

The chart tarball is only written on the second execution.
Output of helm version: v3.0.0.beta.2
Output of kubectl version: v1.15.3

I also encountered this problem

Hi I just made a PR(#6360) to address this. It should fix your problem.

Closing as #6360 merged.


test(isclass.spec.ts): add is creditCard

Codecov Report

Merging #2 into master will increase coverage by 0.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage    56.3%   56.86%   +0.56%
==========================================
  Files           1        1
  Lines         357      357
  Branches       47       47
==========================================
+ Hits          201      203       +2
+ Misses        156      154       -2

Impacted Files
Coverage Δ

src/index.ts
56.86% <0%> (+0.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3486baa...58bb916. Read the comment docs.


Evaluate system's performance

Benchmark should be performed in testing environment, using various loads (which are yet to be specified). Results must include:

average request rate
errors frequency
messages throughput
underlying system metrics

##HTTP
https://github.com/rakyll/hey
https://github.com/tsenart/vegeta
MQTT
https://github.com/takanorig/mqtt-bench
https://github.com/emqtt/emqtt_benchmark
https://github.com/krylovsk/mqtt-benchmark

This issue should be treated as follow up to #170. The decision is to use Gatling as primary testing utility due to its maturity and the number of available plugins.


"Add cursor above" shortcut does not work

Environment:

VSCode Version: 1.16.0-insider
OS Version: macOS Sierra 10.12.6

Steps to Reproduce:

Try to add a cursor below with ⌥⌘↓: works
Try to add a cursor below with ⌥⌘↑: does not work

Reproduces without extensions: Yes
Below is a screen capture of my keybinding, filtered on "alt cmd up" (first line is in French: "Add a cursor above"):

I'm talking about a macOS issue there.
As far as I remember, I never had this problem with Windows.
I tried the keybinding definition, and you're right, cmd+alt+up does not reach VS Code.
I'll try to investigate and see if other softwares are interfering.

The hovering text:

code: MetaLeft, keyCode: 91, key: Meta => UI: Alt+Commande+, user settings: alt+cmd+, dispatch: none

@zessx Yes, I included a recording of Windows, but the steps are the same for OSX. I try to avoid always recording the same gif again ... and again ... and again :).
Yeah, it appears that we do not receive the keypress from the OS. My best guess is that you have something, either an app, or an OS setting, where cmd+alt+up is "stolen" by some other application or the OS itself.
You can try searching for this online to find out which other application is "stealing" that key combo... or if it is the OS itself. AFAIK, out-of-the-box OSX will allow cmd+alt+up to reach applications.

It works with:

CmdRight+AltRight+Up
CmdLeft+AltRight+Up
CmdRight+AltLeft+Up

But not with:

CmdLeft+AltLeft+Up

That is bizzare. I have just tried it on my machine and for me it works for any cmd / alt combo, both on the laptop keyboard and on an external keyboard.

That: it works on my laptop, but not on my external keyboard.
So this definitely looks like hardware-related.


Worth adding some sort of secret URL part

I'm worried it will become really easy to scan for this web hook. It might be worth configuring the URL we listen too to include a configurable pretty shared secret.
Until ynab add a way to sign or encrypt the payload this might be the best we can do.

Agreed. Just a simple query param would be fine

I will get this done 👍

I have added this. We just needs some docs around it now

Ha ha you don't hang about do you. Feel guilty just adding it! Nice work though!

I've confirmed this now works fine, and the docs you have added cover it's use just fine (https://github.com/scottrobertson/fintech-to-ynab/wiki/Getting-Started#url-secret)


I found a problem with recovered application.

Sorry for my low English level. I'm not good at English.
I really really thanks for this package.
This is very useful for me and hope to be maintained greatly.
What I found issue is hidden for special case.
I'm using google signing and deploy with app bundle. not apk.
If user recover our app from another device like Samsung smart switch then maybe app is recovered with SharedPreference but not contain keystore.
case 1. Recovered app access keystore via this package is occur error.
case 2. User remove app and reinstall from playstore and do case 1. is occur error.
case 3. User reinstall using direct apk and do case 1. is going well.
Many of developers can't realize this problem. Because this is only caused by Play store with recovered app who are using app bundle.
I fixed this error to set 'allowBackup' false at manifest.

Hey @bunker89, is it the same config as describe in Readme or different?

oh... my...
I'm really sorry...
I missed disable autobackup in documnet TT


Including parent information in recycle bin

According to issue #2594 when a child item has been deleted and the parent item also gets deleted, there is no way to see the parent information in order to recover child item. This PR includes parent information in recycle bin to help user recover child elements.

Thank you very much for offering this @arjvand.
I don't think this alone would have solved all scenarios of the original request, since you'd still have limited visibility on pages, within chapters, where the parent book has been deleted (Since it's an extra hop away) so I've followed this up with 3a402f6adc78fa939d898369e425088fed141544 to support your addition to provide the user an immediate jump to the actual deletion upon restore.
All now merged, This will be part of the next feature release.


Debian packaging in progress

Hi!
This is a friendly notice to let you know that Debian is working on packaging your software for Debian. You can follow the progress of that work in bug #867800 in the Debian Bug Tracking System (BTS).
The source code for the Debian package is in this git repository. It will be uploaded into Debian shortly, at which point it will end up in the NEW queue for legal review. Once the NEW process is completed, it takes about 10 days for the package to trickle down into "testing", which will become the next Debian release. This means your software will eventually be shipped in a "long term support" release, which last from three to five years, according to the current statistics.
If you are interested in maintaining the package yourself upstream, that is definitely possible. You can either upload the package yourself if you are a Debian member or I can act as a sponsor when a new release is published.
This is just a notification, but can also act as a coordination point for upstream packaging if you wish to followup on this. otherwise, feel free to close this issue whenever you like.

Hi, thanks you for your support on this. If you have any documentation on what process and code change this implies, this will be of interest for me whenever I'll have time. The global packaging tools provided in the code might be a little unusual, so tell me if I can help. Meanwhile, thanks again.

As far as I can tell so far, the library can be packaged directly without change. At least, I didn't have to do anything special to package it, and it seems to just work here now.
Also, I am happy to announce that the library has passed the NEW process and is now in Debian "unstable". You can subscribe to updates to the Debian package in the package tracker if you want to keep track of what's going on there. The package also now shows up in the repology page if you want to show badges or keep track of the versions across distributions...


Is there a reason ListItemSecondaryAction is absolutley positioned?

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
I just run into #8205 for the nth time and my fix is always the same, make ListItemSecondaryAction staticly positioned, make the list item container a flexbox and undo the additional padding.
        <ListItem
          style={{paddingRight: 16}}
          ContainerProps={{
            style: {display: 'flex', alignItems: 'center'},
          }}
        >
          ...
          <ListItemSecondaryAction
            style={{position: 'static', transform: 'none'}}
          >
            ...
          </ListItemSecondaryAction>
        </ListItem>

It would be nice if this was not necessary and instead the default behavior.
Current Behavior
The ListItemSecondaryAction is absolutely positioned, causing the problem that it does not grow to take the space needed for its content.
Examples

N/A
Context

I think this is described with enough context above.

Is there a reason ListItemSecondaryAction is absolutely positioned?

Yes, it's because HTML5 specification prohibits the nesting of <button> elements.

I'm probably missing some use case, but this doesn't cause nesting of <button> elements.
ListItemSecondaryAction lies next to the ListItem-root, both having <li> as parent.
Event when adding the button property to the list item does not seem to cause a difference, however as ListItem-root no longer extends the full width the hover effect (and click area) is also no longer the full width as it does not stretch below the ListItemSecondaryAction
Not nested:

Button example, not using the full width:

I can't say if not extending the full width when using button is an improvement or a problem. It looks a bit weird but also, having two buttons on top of each other is also weird. The use case ListItem with button + secondary actions feels strange all together. But still, it's a breaking change I guess.

I tried this long ago and we merged https://github.com/mui-org/material-ui/pull/5911 but reverted.
I did try to revisit this, I still have the branch https://github.com/alienfast/material-ui/tree/list-item-flex-revisited - I tried with a ripple bounding element but I did not have success.
I just bumped into this again - am using a ListItem without button but with secondary actions, and want the content to grow but not overflow the actions. I'll do something custom for now but I definitely think revisiting this is worthwhile.

This kind of hard-coded padding-right makes UI overflow when the action is wider than expected

Use a scary method to patch it

    const buttonRef = useRef<HTMLElement>(null)
    const listRef = useRef<HTMLDivElement>(null)
    useLayoutEffect(() => {
        if (!buttonRef.current || !listRef.current) return
        const width = buttonRef.current.getBoundingClientRect().width
        const child = listRef.current.children[0]
        if (!child) return
        ;(child as HTMLElement).style.paddingRight = `${width + 10}px`
    })

@Jack-Works If the container isn't a button, I would personally trash the isolate of the ListItem and use custom CSS.


show on-run-start/end + hooks in dbt output

Feature
dbt doesn't output any info about the start/end hooks that it runs, so it can be hard to understand why the stdout seems to stall. Instead, dbt should log the start/end hooks that it is running to the console.
Example:
$ dbt run

Found 3 models, 2 tests, 0 archives, 0 analyses, 96 macros, 2 operations, 0 seed files

12:27:16 | Concurrency: 8 threads (target='dev')
12:27:16 |
12:27:16 | Running 3 on-run-start hooks:
12:27:16 | 1 of 3 START grant usage on ...
12:27:16 | 2 of 3 START grant create on ...
12:27:16 | 3 of 3 START insert into public._audit ...
12:27:16 |
12:27:16 | Running 2 models:
12:27:16 | 1 of 2 START table model demo_schema.dep............................. [RUN]
12:27:16 | 2 of 2 START incremental model demo_schema.local..................... [RUN]
12:27:16 | 1 of 2 OK created table model demo_schema.dep........................ [SELECT 1 in 0.13s]
12:27:16 | 2 of 2 OK created incremental model demo_schema.local................ [INSERT 0 1 in 0.14s]
12:27:16 |
12:27:16 | Running 3 on-run-end hooks:
12:27:16 | 1 of 3 START grant usage on ...
12:27:16 | 2 of 3 START grant create on ...
12:27:16 | 3 of 3 START insert into public._audit ...
12:27:16 |
12:27:16 | Finished running 1 table models, 1 incremental models, 6 run hooks in 0.32s.

Completed successfully

Done. PASS=2 ERROR=0 SKIP=0 TOTAL=2

If there are no on-run-start/end hooks, dbt should skip those sections of the info logs. Note that we should also add something like 6 run hooks to the final line of model run logs.
^ this is an initial idea of how this could look, but I don't know that I love it. Very open to other ideas!

I'd like to take a stab at this.

This looks good


Missing sprite key in Demo Tiles style

The Demo Tiles style is missing an entry for sprite, cf. source.

This is causing an issue with a tool (behind a firewall) that reads & processes Mapbox flavored styles ("version": 8 styles).  In this case, the rendering of the style.json throws an error as the expected sprite key is missing.

Commit c3aabe2 adds a sprite key as a workaround for this issue.

This change adds a sprite key to the Demo Tiles style.json, even though the style does not use sprites.  By making this commit, the author of the tool can now test before & after changes of this style.
See source change:  https://github.com/roblabs/demotiles/blob/gh-pages/style.json#L9,L11
     "glyphs": "https://demotiles.maplibre.org/font/{fontstack}/{range}.pbf",
+    "sprite": "https://demotiles.maplibre.org/styles/osm-bright-gl-style/sprite",

Test plan for testing for those who have access to the tool (my internal team + author of original tool that processes Mapbox-flavored styles).

[ ] Before, causes original issue — https://demotiles.maplibre.org/style.json
[ ] After, should draw the MapLibre demo map —  https://roblabs.com/demotiles/style.json


clean state store on tear down because we use ceramic node to do it

We have to clean the state store on teardown, not on setup
because we are using the ceramic node to remove its pins
And the ceramic node will not start if the state store has old data

weirdly this change is not showing up correctly


ProxyConnection should close when ProxyStatement close

If a connection is not closed, the PoolEntry remains in the IN_USE state, leading to a connection leak.

@quaff I agree. This pull request is definitely not correct.
The connection absolutely should not be closed when a statement is closed as that would, along with potentially thousands of other problems, prevent users from using multiple statements for a single connection.
@soosue, what you want to do is close your connection in your application code explicitly after you have finished with it, you should not expect a statement close to close a connection for you. A try-with-resources block with the connection is the most idiomatic way to achieve this.
I'm marking this as closed.


Hey Question about AeonProfiler

Hello
I really like the AeonProfiler.. it does a good job.. especially auto save on terminate, it saves when my program crashes.. The problem is I want to see all the calls in order.. until the crash happened not really profiling anyway I can convert this tool to do this? to list all function calls in order. Know of any tools for this purpose?.
I replaced SORT_UNUSED with SORT_INCREASING to # thinking the last call will be on the very end, but I couldn't find it feasible.
	{ TEXT("#"), SORT_Increasing, false, 50, false },							// column 1 (the row number)
Modified the void WINAPI ProcessCallTreeDataThread(LPVOID lpData) removed qsort and all the FindCallTreeRecord_BinarySearch stuff.

If you want a callstack at the time of the crash, you would probably just run your application in the Visual Studio debugger and it should break at an assert or exception.

The thing is it's not a program it's a plugin I cannot attach any debugger to it either it's protected process with a driver.

I don't know of a way to do what you want.

I think I found what I wanted it was made in 1998 I put it up on my github
https://github.com/fatrolls/CallMonitor


feat: SerdeVecMap type for serializing ID maps

This PR introduces a new type SerdeVecHashMap that can be used in places where we need a HashMap with the following properties:

When serialized, it is serialized as a list of key-value pairs, instead of a map
When deserialized, it assumes the serialization format from (1.) and deserializes from a list of key-value pairs to a map
Does not allow for duplicate keys on deserialization

This is useful in places where we need to create map types that map from an identifier (integer) to some value, and need to serialize that data. For example: in the WAL when serializing write batches, and in the catalog when serializing the database/table schema.
This PR refactors the code in influxdb3_wal and influxdb3_catalog to use the new type for maps that use DbId and TableId as the key. Follow on work can give the same treatment to ColumnId based maps once that is fully worked out.
Explanation
If we have a HashMap<u32, String>, serde_json will serialize it in the following way:
{"0": "foo", "1": "bar"}

i.e., the integer keys are serialized as strings, since JSON doesn't support any other type of key in maps.
SerdeVecHashMap<u32, String> will be serialized by serde_json in the following way:
[[0, "foo"], [1, "bar"]]

and will deserialize from that vector-based structure back to the map. This allows serialization/deserialization to run directly off of the HashMap's Iterator/FromIterator implementations.
The Controversial Part
One thing I also did in this PR was switch the catalog from using a BTreeMap for tables to using the new HashMap type. This breaks the deterministic ordering of the database schema's tables map and therefore wrecks the snapshot tests we were using. I had to comment those parts of their respective tests out, because there isn't an easy way to make the underlying hashmap have a deterministic ordering just in tests that I am aware of.
If we think that using BTreeMap in the catalog is okay over a HashMap, then I think it would be okay to roll a similar SerdeVecBTreeMap type specifically for the catalog. Coincidentally, this may actually be a good use case for indexmap, since it holds supposedly similar lookup performance characteristics to hashmap, while preserving order and having faster iteration which could be a win for WAL serialization speed. It also accepts different hashing algorithms so could be swapped in with FNV like HashMap can.
Follow-up work
Use the SerdeVecHashMap for column data in the WAL following https://github.com/influxdata/influxdb/issues/25461

Given the review comments, I went and cleaned up the commented out code and removed the now unused snapshot files in influxdb3_catalog in https://github.com/influxdata/influxdb/pull/25492/commits/06e9689984cd853d802bfb49f06314f8ee8187a0
Once ✅ I will merge.


merge sparse hair-short stature-skin anomalies syndrome

close #7150

@twhetzel this is ready for re-review


🐛 fix: handle snackBar queue while reacting on message

Fix if already snackBar is there then it open new snackBar on previous one.

Description

Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have followed the Contributor Guide when preparing my PR.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?

[ ] Yes, this PR is a breaking change.
[x] No, this PR is not a breaking change.

Related Issues

update changelog


HDMI audio is high-pitched/sped up

I have a Sapphire R9-270 and I hadn't gotten HDMI audio to work on my previous setup. With GamerOS it worked right away. Or so I thought.
The audio is high-pitched and sped up (both in the menu and in the LEGO game I tested), which makes me think that the bitrate is wrong. I have no Idea how to best investigate that issue.

Strange, this looks relevant with some things you could try: https://bbs.archlinux.org/viewtopic.php?id=163908

Hi @alkazar, @maweki,
I had a similar issue, https://github.com/ChimeraOS/chimeraos/issues/172
Audio was sped up on the Sapphire RX570 in combo with older hardware.
This issue is still unresolved, changing to Geforce 750ti and problem was gone for me.

I'm closing this as it seems to be fixed, but if not, please open it again with a reproducible test on latest versions.


Path traversal vulnerability in flusity-CMS-v2.4

Description:
The vulnerability occurred in the download_backup.php file. The $filename parameter is directly passed from the user through $_GET['file'] without being filtered. Hackers exploit this to insert the "../" characters to exploit the path traversal vulnerability:

Especially since define isAdmin is always True, hackers can exploit the vulnerability without needing to authenticate:

PoC:
The request exploits the vulnerability to download the win.ini file without needing authentication:

Impact:
The attacker exploiting this vulnerability could execute the download of any sensitive file on the system.

Integrated 'basename()' function to protect against path traversal vulnerabilities, implemented authentication via checkIfAdmin() to prevent unauthorized file downloads, and added file_exists() and is_file() checks to ensure that only allowed files from the specified directory are downloaded.


Scoped label display and documentation tweaks

Fix scoped label left and right part breaking across lines.
Remove slanted divider in scoped label display, make it straight. After using this for a while, this feels more visually noisy than helpful.
Reduce contrast between scope and item to reduce probability of unreadable text on background.
Change documentation to remove mention of non-exclusive scoped labels.

Deduplicate template code for labels selection menu.

Interesting, I thought that point would fall under this PR as well…

I though to submit that as a separate PR, and then you can decide to take the risk of backporting it to 1.19 or not.


Remove check for if a file is open before activating project.nvim

Fix suggestion 2 for #5
This should would regardless of how vim is opened etc.

sry once again


Add retries to create partitions test

Closes https://github.com/zendesk/ruby-kafka/issues/796
I noticed when running CI on https://github.com/zendesk/ruby-kafka/pull/795 that create partitions was failing on a single Kafka version, which seemed weird.  That particular test also depends on the topic metadata getting updated, which may be subject to a race condition.
To fix this, I'm adding a retry to that particular case (and including a small with_retry function to accomplish that).  I investigated using https://github.com/NoRedInk/rspec-retry or https://github.com/rstacruz/rspec-repeat, however those wrap the entire example block when in this particular case we only want the expect to be retried.

@dasch in case you missed this 😸

Thanks!


[Request] Compatibility

Please check for compatibility with other modules that use ace (like not enough npcs) since ace is very prone to breaking if multiple modules use it (ace.config.basePath might break other modules using ace for example)

Thanks man. Will do. I'm just seeing if I can standardize importing ace and its dependencies for now. It's very touchy.

My forked repo of yours is looking a lot better than this one. But took me a while to understand what it was your code was editing in the first place. UI dev isn't my area of expertise.

The Furnace is no more, but this editor module is still incompatible with at least one of the successor modules, Advanced Macros.
And yeah, even if I disable the Furnace checks, the editor breaks with Advanced Macros enabled.
Is there a way to make them compatible?

I'll look into it.

Please use VTTMacroEditor instead @DrMcCoy . This project will be closed.

Ah.
Thank you for your service!


Problem with Zoom and Page Size settings

Hello,
I have a problem with zoom and page size settings i receive error from wkhtmltopdf, this is my config:
Shark.PdfConvert.PdfConversionSettings config = new Shark.PdfConvert.PdfConversionSettings
                    {
                        Title = "Converted by Shark.PdfConvert",
                        LowQuality = false,
                        Margins = new Shark.PdfConvert.PdfPageMargins() { Bottom = 10, Left = 10, Right = 10, Top = 10 },
                        Size = Shark.PdfConvert.PdfPageSize.A4,
                        Zoom = 1.2f,
                        OutputPath = @"C:\DATA\pdfSharkTest.pdf"
                    };

this is the error i receive:
WkHTMLToPdf conversion of HTML data failed. Output: \r\nWkHTMLToPdf exited with code 1.
am I using it wrong? :) without Zoom and Size options it generates file normally

No, you're not using it wrong. I had it wrong with where those options should go and a missing space in the configuration.
I have the code changes and added a test for those two options. Uploaded a new version to NuGet (1.0.3) and it should be visible shortly.
If that doesn't help let me know.

Thank you for the fast fix, It works perfectly now!


More conservative client build targets

As we get towards mainnet, more conservative default targets than "master" may be desirable.

I built this for my needs. There may be pieces that you can pull out that will help with this:
#!/bin/bash
set -e

RED='\033[0;31m'
GREEN='\033[0;32m'
ORANGE='\033[0;33m'
NC='\033[0m'

# Change this
REGISTRY=registry_host:port

populate_build_list () {
  builds=()
  for entry in ./Dockerfile.*
  do
    IFS='.' read -ra docker_files <<< "$entry"
    builds+=("${docker_files[-1]}")
  done
}

get_desired_build () {
  echo "${builds[@]}"
  echo -e "$GREEN[*] Available build options:$NC"
  for ((i=1; i<="${#builds[@]}"; i++));
  do
    echo "$i: ${builds[$i-1]}"
  done
  echo -ne "$ORANGE[+] Enter the number that you want to build:$NC "
  read build_num
  BUILD="${builds[$build_num -1]}"
}

print_urls () {
  case $BUILD in
    deposit_cli)
      echo -e "$GREEN[*] Check available tags here: https://github.com/ethereum/eth2.0-deposit-cli/tags$NC";;
    go_ethereum)
      echo -e "$GREEN[*] Check available tags here: https://github.com/ethereum/go-ethereum/tags$NC";;
    lighthouse)
      echo -e "$GREEN[*] Check available tags here: https://github.com/sigp/lighthouse/tags$NC";;
    prysm)
      echo -e "$GREEN[*] Check available tags here: https://github.com/prysmaticlabs/prysm/tags$NC";;
    teku)
      echo -e "$GREEN[*] Check available tags here: https://github.com/PegaSysEng/teku/tags$NC";;
  esac

  DOCKER_FILE="./Dockerfile.$BUILD"
}

check_latest () {
  # If utility than don't ask about the release or the latest. Just mark latest as true.
  if [ "$BUILD" != "utility" ]; then
    echo -ne "$ORANGE[+] Enter the version release you want to build:$NC "
    read RELEASE
    while true
    do
      echo -ne "$ORANGE[+] Do you want me to tag this release as the latest? [Y]:$NC "
      read LATEST
      LATEST=${LATEST:-Y}
      case $LATEST in
        [yY]* ) LATEST=true
                break;;
        [nN]* ) LATEST=false
                break;;
        * ) echo "Enter Y or N";;
      esac
    done
  else
    LATEST=true
  fi
}

echo_summary () {
  echo -e "$GREEN[*] ***** Summary *****"
  echo -e "[*] Build: $BUILD"
  echo -e "[*] Release: $RELEASE"
  echo -e "[*] Tag as Latest: $LATEST"
  if [ -z "$RELEASE" ] ; then
    echo -e "[*] Push to Registry: $REGISTRY/ethereum/$BUILD:latest$NC"
  else
    echo -e "[*] Push to Registry: $REGISTRY/ethereum/$BUILD:$RELEASE$NC"
  fi
  while true
  do
    echo -ne "$ORANGE[+] Is the summary correct? [Y]:$NC "
    read CORRECT
    CORRECT=${CORRECT:-Y}
    case $CORRECT in
      [yY]* ) break;;
      [nN]* ) exit 1;;
      * ) echo "Enter Y or N";;
    esac
  done
}

build_image () {
  if [ "$LATEST" = true ] ; then
    # If release is not set build as latest.
    if [ -z "$RELEASE" ]; then
      docker build -t $REGISTRY/ethereum/$BUILD:latest -f $DOCKER_FILE .
    else
      docker build --build-arg RELEASE=$RELEASE -t $REGISTRY/ethereum/$BUILD:$RELEASE -t $REGISTRY/ethereum/$BUILD:latest -f $DOCKER_FILE .
    fi
  else
    docker build --build-arg RELEASE=$RELEASE -t $REGISTRY/ethereum/$BUILD:$RELEASE -f $DOCKER_FILE .
  fi
}

push_image () {
  if [ "$LATEST" = true ] ; then
    echo -e "$GREEN[*] Pushing the image to the registry with the latest tag$NC"
    docker push $REGISTRY/ethereum/$BUILD:latest
  fi

  # If release is set, tag it with that release
  if [ ! -z "$RELEASE" ]; then
    echo -e "$GREEN[*] Pushing the $BUILD image to the registry with a tag of: $RELEASE$NC"
    docker push $REGISTRY/ethereum/$BUILD:$RELEASE
  fi
}

prune_images () {
  while true
  do
    echo -ne "$ORANGE[+] Do you want me to run 'docker image prune -f'? [Y]:$NC "
    read PRUNE
    PRUNE=${PRUNE:-Y}
    case $PRUNE in
      [yY]* ) PRUNE=true
              break;;
      [nN]* ) PRUNE=false
              break;;
      * ) echo "Enter Y or N";;
    esac
  done

  if [ "$PRUNE" = true ] ; then
    echo -e "$GREEN[*] Pruning docker images$NC"
    docker image prune -f
  fi
}

read_args () {
  # If no argument was passed
  if [ -z $1 ]; then
    populate_build_list
    get_desired_build
    print_urls
    check_latest
    echo_summary
    build_image
    push_image
    prune_images
  # If an agrument was passed
  else
    populate_build_list
    # Check if argument is part of builds
    if [[ " ${builds[@]} " =~ " ${1} " ]]; then
      BUILD=$1
      print_urls
      check_latest
      echo_summary
      build_image
      push_image
      prune_images
    fi
  fi
}

read_args $1

Super thank you! This'll come in handy as clients come out of alpha and move into beta and then release.

Here is an example running the script for Lighthouse v0.3.0:

More conservative targets are in; the scripted idea above to show and build updates is not yet.