Quantiles sketch agg fails on inner query numeric post-agg columns

Affected Version
0.12.0+
Description
When using a quantiles sketch agg (http://druid.io/docs/latest/development/extensions-core/datasketches-quantiles.html) in the outer query of a nested GroupBy that references a numeric column generated by a post-agg in the inner query, the following exception occurs:
java.lang.ClassCastException: java.lang.Double cannot be cast to com.yahoo.sketches.quantiles.DoublesSketch
	at org.apache.druid.query.aggregation.datasketches.quantiles.DoublesSketchMergeBufferAggregator.aggregate(DoublesSketchMergeBufferAggregator.java:65) ~[?:?]
	at org.apache.druid.query.groupby.epinephelinae.AbstractBufferHashGrouper.aggregate(AbstractBufferHashGrouper.java:165) ~[druid-processing-0.14.2-incubating.jar:0.14.2-incubating]
	at org.apache.druid.query.groupby.epinephelinae.SpillingGrouper.aggregate(SpillingGrouper.java:167) ~[druid-processing-0.14.2-incubating.jar:0.14.2-incubating]
	at org.apache.druid.query.groupby.epinephelinae.Grouper.aggregate(Grouper.java:82) ~[druid-processing-0.14.2-incubating.jar:0.14.2-incubating]
	at org.apache.druid.query.groupby.epinephelinae.RowBasedGrouperHelper$1.accumulate(RowBasedGrouperHelper.java:270) ~[druid-processing-0.14.2-incubating.jar:0.14.2-incubating]
	at org.apache.druid.query.groupby.epinephelinae.RowBasedGrouperHelper$1.accumulate(RowBasedGrouperHelper.java:247) ~[druid-processing-0.14.2-incubating.jar:0.14.2-incubating]
	at org.apache.druid.java.util.common.guava.FilteringAccumulator.accumulate(FilteringAccumulator.java:41) ~[druid-core-0.14.2-incubating.jar:0.14.2-incubating]
	at org.apache.druid.java.util.common.guava.MappingAccumulator.accumulate(MappingAccumulator.java:40) ~[druid-core-0.14.2-incubating.jar:0.14.2-incubating]

This occurs because the factorizeBuffered method in DoublesSketchAggregatorFactory relies on metricFactory.getColumnCapabilities(fieldName) to determine if an input column is numeric. If the column is not numeric, the aggregator assumes the input is a complex DoublesSketch object. For postaggs, the type information is not available, so the type mismatch occurs.
This issue may also be present in other aggregator types, I have not searched through the other implementations.
The following query structure will reproduce the issue:
{
  "queryType": "groupBy",
  "intervals": [
    "2015-09-12/2015-09-13"
  ],
  "dataSource": {
    "type": "query",
    "query": {
      "queryType": "groupBy",
      "dataSource": "wikipedia",
      "intervals": [
        "2015-09-12/2015-09-13"
      ],
      "dimensions": [
        "page"
      ],
      "aggregations": [
        {
          "type": "quantilesDoublesSketch",
          "name": "innerSketch",
          "fieldName": "added"
        },
        {
          "type": "count",
          "name": "sampleCount"
        }
      ],
      "postAggregations": [
        {
          "type": "quantilesDoublesSketchToQuantile",
          "name": "innerMedian",
          "field": {
            "type": "fieldAccess",
            "fieldName": "innerSketch"
          },
          "fraction": 0.5
        }
      ],
      "granularity": "all"
    }
  },
  "dimensions": [
    "page"
  ],
  "aggregations": [
    {
      "type": "quantilesDoublesSketch",
      "name": "outerSketch",
      "fieldName": "innerMedian"
    },
    {
      "type": "count",
      "name": "clientCount"
    }
  ],
  "postAggregations": [
    {
      "type": "quantilesDoublesSketchToQuantile",
      "name": "outerMedian",
      "field": {
        "type": "fieldAccess",
        "fieldName": "outerSketch"
      },
      "fraction": 0.5
    }
  ],
  "granularity": "all",
  "context": {
    "skipEmptyBuckets": "true"
  }
}

@jon-wei
We are looking at this.  We think it is a problem in the aggregator and not the sketch itself.

@leerho
Thanks! The issue is with the aggregator (or perhaps with Druid's column capabilities not providing info about post-aggs), a quick fix would be to allow the user to force the use of the build/merge aggregator in the AggregatorFactory properties.
A larger adjustment (non-aggregator specific) that would also fix this would be for Druid to provide type information about postagg columns in the capabilities.

A larger adjustment (non-aggregator specific) that would also fix this would be for Druid to provide type information about postagg columns in the capabilities.

FYI, I'm investigating this approach due to necessity for a more optimized handling of group by stuff from row selector factories for #7588.

@jon-wei @clintropolis
It is clear to us that you folks have a much deeper understanding of the Druid infrastructure and what is required to fix the aggregator.   Is it fair to assume you folks will take the lead on this?  If there are any issues wrt the sketch itself we would gladly help.

It is clear to us that you folks have a much deeper understanding of the Druid infrastructure and what is required to fix the aggregator. Is it fair to assume you folks will take the lead on this? If there are any issues wrt the sketch itself we would gladly help.

Sure, I'll update this ticket if my approach doesn't pan out or runs into any issues specific to this aggregator

The HllSketch aggregator seems to have a similar issue.

Theta Sketch[Buffer]Aggregator just does type check and dispatch, which would possibly be the quickest fix.

Theta Sketch[Buffer]Aggregator just does type check and dispatch, which would possibly be the quickest fix.

In the interest of sooner than later, I think I'm going to add this approach as a fallback for when column capabilities are not available for a column, because it is definitely the quickest fix. Typing all the things is a bit more involved, and I still plan on doing because it would offer improvements here allowing us to take optimized paths when types are known up front, but it can be done at a more leisurely pace.


Is the download path of nodejs changed?

I cannot download and install nodejs after installing nvm
When I run nvm ls-remote, only versions of iojs are listed, the latest being 3.3.1
So I'm wondering if the download path for nodejs has changed and nvm hasn't been updated

No, nothings changed. However, if you filled out the entire issue template (that’s why it’s there), my suspicion is that you have a curl issue that prevents loading nodejs.org/dist.

No, nothings changed. However, if you filled out the entire issue template (that’s why it’s there), my suspicion is that you have a curl issue that prevents loading nodejs.org/dist.

I just gave it a try and found that everything is fine, I couldn't access the nodejs website from my location for the past two or three days, everything is back to normal now, thanks


idrisPackages.tparsec: 2019-06-18 -> 2019-09-19

Motivation for this change
update idrisPackages.tparsec to latest rev
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @Infinisil

Looks good after a squash


pkg/nvme: delete unused code

this code is discovery-service code.
it was wrongfully ported to the discovery-client repo when the projects were splitted.

Looks legit. I assume needsDataOut added to tcp_queue.go is on purpose?
How was this tested?

tested by running CI
This code was not invoked so... no changes were done.
as for this method - it is the only one called from this file so i moved it to a different existing file.

@ronen-lb are we in code freeze or can we merge this?


possiblity to set requesting-user-name

Hi,
I was wondering if it is possible to set the requesting-user-name property on a per-printer basis. We have created a cups shared printer that accepts unauthenticated print jobs and want to send print jobs via ipp from client computers.
These print jobs are later sorted according the requesting-user-name that is sent along but at the moment we are not able to set it to a custom value . It is always the name of the system user that is logged in on the client computer.
What we have tried

adding Option requesting-user-name <printeruser> to the printer configuration in /etc/printers.conf on the client.
adding Option job-originating-user-name <printeruser> to the printer configuration in /etc/printers.conf on the client.
adding username and a random password to the device uri on the client like ipp://<printeruser>:dummy@<ip>:631/printers/<printername>
Which are recommended when searching for similar issues.

In all cases the ipp messages for a print job have the requesting-user-name attribute to the logged in linux user.
We know it works by issuing lp -U <printeruser> ... from the command line and also when we set the CUPS_USER environment variable. But the first one is impractical for our users and the second one seems to apply to all printers.
Is it at all possible to customize this value per printer? From reading the documentation the attribute should be set correctly if we enabled authentication which we would rather not do at this time.

The only way to use a different remote username is to enable authentication. We have no plans of supporting alternate requesting-user-name values.

I'm hitting the same issue here: the Papercut printing system for organizations, uses IPPS URIs and looks for requesting-user-name to authenticate, ignoring the username embedded in the URI (although it does use it, and the password, at some point). So from our point of view, the ability to set requesting-user-name per printer is essential.
This is not a problem for desktop computers, but for laptops, it is.


docs: add example with github deployments

Although not specific to the dokku workflow, it might be helpful to include examples of how to use GitHub deploys.
I recently set this up on my repo and find it somewhat useful.
Here's an example of the GitHub deploys:

I find it especially useful in pull requests. In my case i'm using the review-apps:create feature to create a staging deploy when I add a "staging" label to my PR.
In progress:

Complete:

Hello, the GH deployments API is out of preview and also is another action that handles creating and displaying GH deployments - for anyone looking here's an example:
---
name: 'deploy'

# yamllint disable-line rule:truthy
on:
  push:
    branches:
      - master

jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - name: Cloning repo
        uses: actions/checkout@v2
        with:
          fetch-depth: 0

      - uses: chrnorm/deployment-action@v2
        name: Create GitHub deployment
        id: deployment
        with:
          token: '${{ github.token }}'
          environment-url: 'https://appname.dokku.me'
          environment: 'production'

      - name: Push to dokku
        uses: dokku/github-action@master
        with:
          git_remote_url: 'ssh://dokku@dokku.me:22/appname'
          ssh_private_key: '${{ secrets. SSH_PRIVATE_KEY }}'

      - name: Update deployment status (success)
        if: success()
        uses: chrnorm/deployment-status@v2
        with:
          token: '${{ github.token }}'
          environment-url: '${{ steps.deployment.outputs.environment_url }}'
          deployment-id: '${{ steps.deployment.outputs.deployment_id }}'
          state: 'success'

      - name: Update deployment status (failure)
        if: failure()
        uses: chrnorm/deployment-status@v2
        with:
          token: '${{ github.token }}'
          environment-url: '${{ steps.deployment.outputs.environment_url }}'
          deployment-id: '${{ steps.deployment.outputs.deployment_id }}'
          state: 'failure'

Other than this dokku action, the third party actions in use are:
https://github.com/chrnorm/deployment-action
https://github.com/chrnorm/deployment-status


User Defined Routing - Virtual Appliance Next-hop configuration

Proposing to add a note to specify that the next hop ip address needs to have direct connectivity to virtual appliance. Came across multiple customers where they were trying to use next-hop virtual appliance in a different VNET connected via Virtual WAN Hubs. This results in an invalid user defined route.

@nthewara : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver  any update on this ?

@kumudd Could you review the proposed update?
-PR review team

@ktoliver @KumudD Any update on this ?

@ktoliver @KumudD Any update on this ?

@KumudD or a member of the content team must review and approve the update; then, I could merge it.

@allegradomel Please can you review the proposed update for its technical accuracy. Thanks!

Looks good to me, @KumudD  or @ktoliver can you please merge it? Thanks!

#sign-off


model but don't parse external resources

it would be nice to have external stylesheets, scripts, etc modeled in the graph as external. It wouldn't be parsed, but it'd be linkable.
Would need to add a new variable, maybe mode to indicate external or internal asset.

supported via the re-write in 1.0


Stuck in reload handler after rule changes

Description
In some servers it gets stuck when reloading after a change in the rules. It can be solved by stop using the reload handler and only use the restart handler, which works well.
Steps to Reproduce

Playbook with changes in rules
When it tries to reload does not end

Expected behavior:
To work after changing the rules
Actual behavior:
Gets stuck reloading after change in rules
Reproduces how often:
Only on some servers
Environment

The release version/s you are using: 1.10.1
OS: debian 9/10

Additional Information
N/A

The cause of the problem was that the remote write to a new version of promscale was not working properly. The promscale version was 0.5.1 and the prometheus one 2.2.1


yank AdvancedMH.jl 0.7.6

Yank AdvancedMH.jl as it was mistakenly released and contains breaking changes.

FYI I don't think this problematic release can be fixed by reverting some changes and making another non-breaking release: the problematic release added AbstractMCMC 5 to the compat section but AbstractMCMC 5 support is broken and the package can't be updated to AbstractMCMC 5 without breaking changes.


Twitter, no email address

There's no suitable flow for Twitter sign ins when you have the following settings in the zfcuser config.
'enable_username' => false,
'auth_identity_fields' => array( 'email' ),
//or
'enable_display_name' => false

This is still an issue, facing that problem too...

Yup.  This is still an issue.  I've moved all my projects away from
ScnSocialAuth.  Also, in order to use doctrine, now, you have to use an old
version of zfcuser.  Abandonware.
On Mon, Mar 16, 2015 at 4:48 PM, P0rnflake<EMAIL_ADDRESS>wrote:

This is still an issue, facing that problem too...
—
Reply to this email directly or view it on GitHub
https://github.com/SocalNick/ScnSocialAuth/issues/169#issuecomment-81928452
.

It is possible to run this module with doctrine and the latest stable of zfc-user (1.2.2). I am currently running this setup with "socalnick/scn-social-auth-doctrine-orm" in combination with "zf-commons/zfc-user-doctrine-orm" works out of the box, even with migrations.
Maybe all we need is a check whether the user exists with the email / username before inserting and instead of insert an update should be called, or?


Adding new audit rules

Hi Guys,
Is there an api to add new set of audit rules? i am running on the latest version of the security monkey.

Assuming you are already picking up the required detail with a watcher, you'll need to write an auditor in Python to generate audit items based on the collected data. Adding an auditor wasn't too challenging when I did it. Have a look at the auditors folder and see how you go.

I wonder how difficult it would be to allow users to plug in the rulesets from projects like Scout2 or CloudSploit:
https://github.com/iSECPartners/Scout2
https://github.com/cloudsploit/scans
I think that'd be pretty neat, and I'd love the inter-project collaboration.  I wonder if the other projects would appreciate that.

It would be great if we could use their rulesets in sec monkey

closing as a duplicate of #157. (general auditor rewrite)

Spoke with the author of Scout2 (Loic).
The re-architecture will have a new audit system. We're hoping to implement pluggable audit plugins in a format that can be shared between the libraries.  We have not yet sketched out an architecture or anything.


SyntaxError: Unexpected reserved word at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)

Description
I'm a 1st-time lint-staged user and haven't gotten it working yet.
Steps to reproduce
I have this in package.json:
  "lint-staged": {
    "**/*.{js,jsx,ts,tsx}": [
      "yarn eslint"
    ]
  }

My Husky precommit:
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

yarn lint-staged  --debug

Debug Logs

I don't know where to see debug logs, but this is what I see in VSC:
node_modules/lint-staged/bin/lint-staged.js:23
const packageJson = JSON.parse(await fs.readFile(new URL('../package.json', import.meta.url)))
                               ^^^^^

SyntaxError: Unexpected reserved word
    at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)
    at async link (internal/modules/esm/module_job.js:42:21)
error Command failed with exit code 1.

Environment

OS: Ubuntu 22.04.3
Node.js: v18.18.0
lint-staged: 15.0.2

If I solve it myself, I'll update this ticket with the answer.

I think I had Node.js: v18.18.0 via nvm but 12.12 on my system. So I uninstalled node at my system level so that now Node only exists via nvm.
Now I get this error in my commit attempt:
> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
/usr/bin/env: ‘node’: No such file or directory
husky - pre-commit hook exited with code 127 (error)

As I mentioned at https://stackoverflow.com/questions/67063993/sh-husky-command-not-found#comment136565022_72617424, I'll now try to figure out whether VSC is the problem.
Husky successfully called lint-staged when I do the git commit in the Ubuntu terminal instead of VSC, even without making a ~/.huskyrc as https://typicode.github.io/husky/troubleshooting.html suggests.
I thought https://github.com/typicode/husky/issues/953 or https://github.com/ohmyzsh/ohmyzsh/issues/9252 or https://github.com/typicode/husky/issues/1025 or https://stackoverflow.com/questions/67198286/how-to-make-shell-agnostic-a-husky-hook would be related, but now I think there is just something about VSC that I need to learn.

Unfortunately I can't give support for configuration setup  on Ubuntu, but it sounds like you are on the right track. If lint-staged works in your terminal but not when called through husky, I would take a look at where node is installed and whether it's available in your $PATH.

Thanks.

Yep, here nvm defaulted to some ancient Node and triggered this.


animated bgs

What feature do you want to get added on the base engine?
hey i hope im not bothering but can you add animated bg editors? like so you can put in animated bgs?


Update service-topology.md

During investigation of Topology Aware Hints, documentation is very confusing.
States that it is similar, but only provides zone level topology management. Regional based topology is stated as out of scope: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/2433-topology-aware-hints/README.md#non-goals, but there is no reference at all to node level topology management.
Proposing documentation change as suggested here: https://github.com/kubernetes/enhancements/issues/2433#issuecomment-1282807905

I may also like to reference the following in some way? I would have liked to have found these earlier in my investigation.
https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/
https://github.com/kubernetes/enhancements/pull/3293
https://discuss.kubernetes.io/t/deprecated-topologykeys-alternative-for-node-locality/18184

Hi @jonathon2nd Please sign the CLA, below is the link for refrence:

Hi @jonathon2nd , I'm closing this PR since the CLA has not been signed
When you have signed the CLA, please feel free to reopen this PR with /reopen in a comment
/close


is there any way to use start of the input as a token?

Something similar ^ in regexp

Unfortunately no, the tokenizer does not currently track this. What use case do you have for it?

in some cases we need only "first" capture.


Zip compression alignment in large layout

There is still an alignment issue in Russian or long languages if one of the radio buttons has a 2 lines text or more.
Landscape/Large Russian Layout:

In edit_sync_folder_dlg_zip.xml, replacing android:gravity="center_vertical" in RadioGroup by "Top" fixes it but less nice looking for most one line languages
I couldn't find any simple clue to fix it

I'm going to change it to Spinner.

good idea :-)


Some questions regarding decoder in vanilla_vae

Hello @AntixK !
Thanks for sharing this helpful repository.
I am a beginner in VAE implementation and hence, had a confusion related to vanilla_vae:

In the self.final_layer, why is nn.ConvTranspose2d created with both in_channels and out_channels as hidden_dims[-1] i.e. 32 followed later by nn.Conv2d? Can we not have out_channels as 3 directly in nn.ConvTranspose2d and omit nn.Conv2d?

Could you please provide me insight on these?
Thank you, and have a nice day!

I had the same question. Came across this:
Advanced: to avoid checkerboard artifacts, an alternative upsampling method that’s gaining popularity
is to apply classical upsampling followed by a regular convolution (that preserves the spatial dimensions).

Source: https://medium.com/apache-mxnet/transposed-convolutions-explained-with-ms-excel-52d13030c7e8


Endwise breaks Visual Block insertion

Description
add "{" over a visual block area → `Ctrl-v`, `4j`,`I{`
        │
        │
    use │'shaunsingh/doom-vibrant.nvim'
    use │'flrnprz/plastic.vim'
    use │'joshdick/onedark.vim' -- Theme inspired by Atom
    use │'arcticicestudio/nord-vim'
    use │'mhartington/oceanic-next'

What happens is that 'endwise' adds the } at the end of the first line
and stops, leaving all the rest of the lines with no changing
The end result should be:
    use {'shaunsingh/doom-vibrant.nvim'}
    use {'flrnprz/plastic.vim'}
    use {'joshdick/onedark.vim'} -- Theme inspired by Atom
    use {'arcticicestudio/nord-vim'}
    use {'mhartington/oceanic-next'}

It also does not repeat the last insertion when using normal 'i'
Mapping  bug
1.If you report a bug about indent. Please remember that plugin doesn't do anything about indent.
It just trigger the indent of your vim config so if you have wrong indent config then it will do wrong indent.
You can check by select a block of code and press ==
2. provide result of command :verbose imap <cr>.
Steps to reproduce
Just try to insert {, ( in a visual block area
Minimal config
vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvim/site]]
local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'
local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      {
        'windwp/nvim-autopairs',
      },
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
      display = { non_interactive = true },
    },
  }
end
_G.load_config = function()
  require('nvim-autopairs').setup()
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing nvim-autopairs and dependencies.")
  vim.fn.system { 'git', 'clone', '--depth=1', 'https://github.com/wbthomason/packer.nvim', install_path }
end
load_plugins()
require('packer').sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]]

that feature will execute when you set option enable_afterquote=true.
it can't be working on visual block mode because it use an api to set the whole line text.
it will try to disable that option after visual block mode. but make it working to what you want is not possible now.


Provide a PDF cheat sheet of all commands

yes it would be very useful

I can generate for now a pdf directly from markdown but it is not well formatted :/ If you have any ideas for that one, just leave it there

I made a PDF cheat sheet for myself, so I wanted to share. Feel free to pull it from my Google Docs here: https://drive.google.com/file/d/1YtP6h_8o48lVloY6QgndeV_SiP15Z1ps/view?usp=sharing
I'm not sure if this kind of thing belongs in a pull request, but I'm happy to submit the PDF in one if necessary.

@jaredjgebel That would be also nice if you have some command with which I could regenerate it from README.md. If you have this, feel free to open PR. I will close it ASAP 💃

Could potentially set that up with either:
https://www.npmjs.com/package/markdown-pdf
or
https://www.npmjs.com/package/mdpdf


cannot copy paste from the serial output

Type: Bug Report
Describe the bug

OS and Version: Windows 11
VS Code Version: 1.73.1
Serial Monitor Extension Version: v0.5.0
Target embedded device:
Other extensions you installed (and if the issue persists after disabling them):
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

collect some serial port data
select text
use Ctrl-C to copy
use Ctrl-V into an editor window to attempt to paste

Expected behavior
text is copied and pasted

Hi @klaff, could you provide a gif or video of the reproduction? I wasn't able to reproduce this issue on a similar machine and the same version.
Thanks!

Hi @gcampbell-msft , here you go:
In other instances, it has pasted the previously copied item again instead of a blank line. Before recording this demo, I disabled all other extensions in vs_code, restarted vs_code, and grabbed fresh serial input.

The problem is observed if I paste to another application as well, or if I use keyboard shortcuts (I used right-click menu for the .gif so you could see what I'm doing).  Also tried just now to use the Clipboard History tool in Windows (which one has to enable with settings -> clipboard ..., and it also does not show the result of the copy operation.

@klaff Have you noticed this issue when using the Ctrl-C command?
The issue in your screenshot is known and there is a bug with the vscode handling of webviews and the cut/copy/paste context menu commands, I believe: https://github.com/microsoft/vscode/issues/165679 (there are many other issues as well)

I would have sworn I tried both keyboard shortcuts and the right-click menu (I even wrote Ctrl-C explicitly in my issue post), but right now it is working if I use Ctrl-C for the copy operation, so the most logical assumption is that I only tried the non-working right-click menu for the copy operation and implicitly assumed equivalence of Ctrl-C and the right-click menu.
Thank you for the debug.

@klaff Perfect! I'll close this bug in favor of tracking that issue on the vscode repository.


add centered label class

this class centers each line, rather than left-aligning. this allows for different sized lines of text to be centered together, for example
for a single text object spanning multiple lines, (eg if printing on a vertically-oriented label) it may make more sense to use an approach like this: https://gist.github.com/turicas/1455973

Ah, good catch(es). I had actually just copied most of the contents of that method (including those debug print statements) from the original Label class: https://github.com/NotAFile/labelprinterkit/blob/5540c032231fa1b16ed5bde80c45ec0c19270238/labelprinterkit/label.py#L76-L79
The  new commit changes all of them over to debug logger statements


icu: 67.1 -> 68.2

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build postgresql tesseract

@GrahamcOfBorg build tesseract
@GrahamcOfBorg build postgresql

postgres failed it seems

postgres failed it seems

postgres failed it seems

PostgreSQL fixed its build with ICU 68 in the latest bump https://github.com/NixOS/nixpkgs/pull/112853
@GrahamcOfBorg build nodejs
@GrahamcOfBorg build tesseract
@GrahamcOfBorg build postgresql

@GrahamcOfBorg build nodejs
@GrahamcOfBorg build tesseract
@GrahamcOfBorg build postgresql

This broke the nodejs-10_x build.


Folder and Index created but nothing else happening :(

I just came across your extension today but upon trying it out it is not working for me.  I select a file (or multiple), select Folderize and select ok (or check both optional files) and a folder with the correct name is created, the index is created but the files aren't moved into the folder.  Additionally, the path in the index file isn't valid either...
Path
'./d:\FolderName\ProjectFolder\src\components\NewlyCreatedFolderizedComponentName';
I am running on a Win10 machine, with the latest version of VSCode

@cadmus-software Thanks for raising the issue, I think I know exactly what problem is. Might take me a few days to get to it unfortunately.
Btw, I like never considered multiple... what is your use case for that?

The link below is what turned me onto the idea of 'folderizing' when then lead me to your extension, I have the scenario where in order to keep my component as clean and simple as possible I have broken it into small pieces. I have the files grouped by filename but it starts to get rather messy rather quickly, when you have style sheets, tests, etc
#2 Folderize Your Components @ https://dev.to/jsmanifest/14-beneficial-tips-to-write-cleaner-code-in-react-apps-1gcf

Hey, I'm getting this issue on Windoze 10 too. Guessing it's a windows path issue?
If you could point me in the right direction, would you accept a pull request?


typo

…rpreviousowner.md
typo fix

Thank you!

🙏🏾
On Wed, Jul 19, 2023 at 12:33 PM Tom Lehman @.***>
wrote:

Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/ethscriptions-protocol/ESIPs/pull/4#issuecomment-1641917873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7CV7XFGRGYO5VMSMBH4CPTXQ7A2HANCNFSM6AAAAAA2PVIXAQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Hi! How to disable it? I used .attr() and had no result.

Not implemented now, that will be in the next version

Hi, I have published a new release with your proposition, to disable the tokenize:

If on load just use disabled attr to the select
If after load, use the api $('#select').data('tokenize').disable(); or $('#select').data('tokenize').enable();

Don't forget to update your css if you use an other than mine.


refactor(linter): remove unused serde features

#7738  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Add auto-save feature

https://github.com/sunfish-shogi/electron-shogi/issues/9

Codecov Report

Merging #214 (3b033ec) into main (92cb0fb) will decrease coverage by 0.20%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   61.42%   61.21%   -0.21%
==========================================
  Files          59       59
  Lines        3899     3914      +15
  Branches      766      770       +4
==========================================
+ Hits         2395     2396       +1
- Misses        816      826      +10
- Partials      688      692       +4

Impacted Files
Coverage Δ

src/helpers/path.ts
29.41% <0.00%> (-5.89%)
:arrow_down:

src/ipc/api.ts
24.00% <ø> (ø)

src/ipc/web.ts
22.41% <0.00%> (-0.40%)
:arrow_down:

src/settings/csa.ts
78.94% <ø> (ø)

src/settings/game.ts
44.44% <ø> (ø)

src/store/index.ts
43.96% <0.00%> (-1.41%)
:arrow_down:

tests/unit/mock/csa.ts
100.00% <ø> (ø)

tests/unit/mock/game.ts
100.00% <ø> (ø)

src/store/csa.ts
58.45% <50.00%> (-0.13%)
:arrow_down:

src/store/game.ts
48.48% <50.00%> (+0.01%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Machida hangs/livelocks? for several minutes after mute events

I ran into very strange Machida behavior (built with default resilience=off) when testing the alphabet example app when the TCP sink is extremely slow (simulated with SIGSTOP and SIGCONT).  I was using code on the ponyc-update-0.19.1 branch, based on commit 1c0c77bb22a28ff843f13cee3cfd2c9f6c98ff6d and run on an OS X Sierra/10.12 machine.
The system under test is the same as described by the alphabet example's README, then extended with a 2nd sender process.  Both sender processes are configured to send 16K ops/sec.  The README sample code's data size + the default OS X socket buffer sizes help factor into the timing of this scenario.  We want to be sure that the mute activity inside machida and the TCP throttle events inside sender happen in this order.

Send 16K ops/sec load to a system described by the README.
The receiver process is suspended with SIGSTOP
The single sender is throttled by backpressure after less than 10 seconds.
A new  sender is started, also using the 16K ops/sec sending rate.
The 2nd sender isn’t throttled for a much longer time, roughly 30 seconds.  (This timing is odd, but it isn't the heart of this ticket's problem.)
The receiver process is permitted to resume execution with SIGCONT.
Machida goes into a hang/livelock state for 3+ minutes.

Machida's CPU utilization is 100% of one core (as measured by top and iostat).
Machida performs zero message passing between actors (as observed by DTrace) for the entire period.
The only syscalls performed are writev calls to the receiver’s socket (as observed by DTrace).
TCP socket events for new sources are not handled until the livelock period ends.

After the livelock period ends, the Machida sink finally unmutes and the sender processes have their TCP backpressure eliminated.  Activity returns to normal at 32K ops/sec (2 senders * 16K ops/sec).

A reproducing script can be found at https://gist.github.com/slfritchie/1e6434b5de08f92fb087558ec9f4b7a6.  I've also created a 4 minute screen capture to demonstrate the problem, see http://www.snookles.com/scotttmp/screen-recording-1-big.mov.

I suspect this is somehow related to writev calls in TCPSink but have no evidence of that. Purely conjecture based on knowledge of the system. I'm sure there is more to it then that.

Minor clarification: The call to _pending_writes() would happen as soon as the connection becomes writeable again due to ASIO event notification and _event_notify calling _pending_writes() if we received notification that the connection is writeable again.

re #2: I think it could be because our backpressure is push oriented so the new source starts up and sends some messages along. Then it gets told to mute. There might be a lot of data that gets sent. During that time. Not sure. It seems odd though. I wouldn't expect more than 25 to 100 messages at most to get sent and handled at the sink before muting happens for the 2nd source. But I could be wildly wrong.

That sounds like another bug. The new source should start muted until it can confirm it's safe to unmute because downstreams are not muted.

Its not a bug, it was a conscious tradeoff. Otherwise you need a credit system, which didn't work out for a variety of reasons. You become muted when you ask for work to be done by something that can do the work.

It's a binary check. I'm a new source, am I supposed to be muted or not? Granted, I might be missing something but a full credit system doesn't seem required for this check.

Thats not the check @dipinhora. Its
I'm a new source. Is the system initialized. Good, I will start.

I feel like maybe we're talking about two different things @SeanTAllen.
I believe that what you described is what is currently implemented and what I described is what I think should be implemented. In my version one of the checks for the "am i supposed to be muted" would be the "is the system initialized" that you mentioned and another would be "are downstreams ready to accept data" so that sources don't unnecessarily send data if downstreams are already muted/not ready to accept data when new sources are created. My main point was that I don't believe that implementing the check I've described requires a "credit system" (and all that a "credit system" implies to you and why it didn't work out for the variety of reasons that it didn't work out previously).

We dont know what the downstreams are until we start sending data. To know, we need to send data. That is what we do. How will we know if downstreams are accepting data? We would need to add a list of every downstream (as well as each upstream) to each step. And then track when each is muted or not muted. If any is muted then we dont send. That's problematic though because there are times when processing could be done. Or, we could do processing and push downstream until we are told not to, which is what we currently do and what I think we should continue to do.

Pinging this thread just to put https://github.com/WallarooLabs/wallaroo/issues/2547 and Dipin's upcoming Pony ASIO fix on your radar(s). May or may not be related. If not, please disregard.

#2547 and the fix to it are somewhat related but will not resolve this issue. The fix to this would be to have _pending_writes yield after it has send a bunch of data to not hog the cpu.


Fixed issue with wrapNumbers failing when string ends with backslash.

Hi @reimund, thank you very much for the pull request! Can you also provide a small json file inside "tests" with the use case you are fixing?
Example: https://github.com/tulios/json-viewer/blob/master/tests/test.jsonp.for.json
Thanks again!

Np, thanks for a great Chrome extension :)
Hope this file works.

Without this PR:

With the PR:

Thanks again @reimund! I'll post here when I release this version in chrome web store.

Awesome!

Sorry for the delay, released with version 0.15.0! Thanks again


Node loses the state when running in docker container (the .mc/{clientid}.json is not updated on the host.

The node sometimes loses the state when it gets redeployed without changes in the code after it was onboarded.
See also:
https://community.plm.automation.siemens.com/t5/General-Forum/mindconnect-node-red-contrib-mindconnect-error-token-validaton/m-p/601292#M895

This was until now only reproducable when using docker container with mounted directory on the host file. The state of the .mc file between the host and the container data was somehow not updating. Resarting the container seemed to fix the issue. This needs further observation.

We will close this for now and maybe reopen in the future. The docker command documentation has been updated to use explicit :rw


Customizable Calendar Day fail to compile

So I tried to create a custom calendar day, according to the storybook it can be applied by using CustomizableCalendarDay, but I think It's not exported inside index.js, is there anyway to create a customizable calendar day without fail when compiling, thank you
error:

Module parse failed: Unexpected token (307:21)
You may need an appropriate loader to handle this file type, currently no loaders are >configured to process this file. See https://webpack.js.org/concepts#loaders
|     const { isHovered } = this.state;
|
if (!day) return ;
|
|     const {

@jackbloo seems like CustomizableCalendarDay does not exported. As a workaround you can use CalendarDay and overwriting css

@jackbloo seems like CustomizableCalendarDay does not exported. As a workaround you can use CalendarDay and overwriting css

Thank you!

Everything's exported<EMAIL_ADDRESS>

@jackbloo I just updated sandbox with CustomizableCalendarDay

@ljharb I suppose it will be a good idea to get some info about it in documentation, it seems like it is not so trivial

It's intentionally undocumented :-) but it's there, and you can depend on it as semver dictates.


Hide related reports with non-public statuses

2021-0136 is related to 2021-0353. 2021-0353 is still a Draft, so the related report link in the sidebar of 2021-0136 goes to "Page not found".
We'd like to update the logic for showing related reports to hide reports that are Drat, Approval review, or other non-public statuses. If they're not viewable on the web, they shouldn't show in the sidebar.

@shrayshray Just deployed a fix for this to the staging site! Observe: Draft report 2021-0353 is no longer listed as a related board report here: https://lametro-upgrade.datamade.us/board-report/2021-0136/
The logic is that related board reports will not be shown if they are private. A board report is private if one or more of the following is True:

MatterRestrictViewViaWeb is True
MatterStatusName is "Draft"
MatterBodyName is "TO BE REMOVED"
MatterTypeName is one of 'Board Box' or 'Board Correspondence' AND MatterStatusName is not "Sent"
The board report isn't viewable in InSite

Can you help me to QA another board report or two with private related board reports, and also a couple of board reports without private related board reports, to confirm relations are hidden/shown as expected?


[fix bug 1104629] Do not resolve newly created action items.

@johngian r?

Coverage decreased (-0.02%) when pulling 0acb2ad85bae10c4d826957f9f3829da9a48711f on akatsoulas:bug-needinfo into ba24e9c5a278fd968c78b3c945c1654d6b39d181 on mozilla:master.

@johngian pr updated

Coverage decreased (-0.02%) when pulling 782b39f8482dd4f85dff36f120d5f6dc33d00407 on akatsoulas:bug-needinfo into ba24e9c5a278fd968c78b3c945c1654d6b39d181 on mozilla:master.

Coverage decreased (-0.01%) when pulling 782b39f8482dd4f85dff36f120d5f6dc33d00407 on akatsoulas:bug-needinfo into ba24e9c5a278fd968c78b3c945c1654d6b39d181 on mozilla:master.

lgtm r+


Add badges to README

We could add some useful badges from https://shields.io/. Which badges would be nice to have?

Cool! For now, I'd suggest the:

Number of downloads in a month
License
Version

Do you want to take this one @gabraganca?

Sure. I'll give a shot.

I think we can close this now.


README: Encourage use of virtualenv

Relates https://github.com/zlj-zz/minimycobotflasher/issues/1 https://github.com/elephantrobotics/mycobot_ros/issues/17

Hey @eacousineau do you think that it would overcomplicate things to recommend poetry for users of this repo?
The instructions could be simplified to:
# Install Poetry
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python -

# Install project dependencies
poetry install

and poetry would handle creation and entry of the venv.

Personally I think it's a bit overkill since there's only one dependency in this project, but I thought I'd mention the option.

Howdy @apockill,
Yeah, I think in this case, it'd be overkill since this usage is relatively simple and this project doesn't directly use poetry for dependency declarations / management. But thanks for the suggestion!


Content Security Policy

I serve my app with a CSP.  I'd previously been using Airbrake, and thought I'd try rollbar. The main stumbling block was setting up the CSP for inline script in ember-cli-rollbar. I didn't just want to add 'unsafe-inline' so here's what to do

Install and configure ember-cli-rollbar (changing configuration will change the script hash)
Run ember locally in production environment ember server -e production
Have a look in chrome console for the error similar to

Either the 'unsafe-inline' keyword, a hash ('sha256-Fm2/whhYQWeKGsFHC3/85HdIC/aNhx6cI/mOZSebPSo='), or a nonce ('nonce-...') is required to enable inline execution.

Copy and paste the 'sha256-....' portion to the relevant server configuration file.

I add it to my config/environment.js file and generate my CSP headers using https://gist.github.com/mrloop/41ee14daecaf1873cee0
Now I need to remember to update the hash if the rollbar snippet is updated or my configuration changes.
I'm wondering if there's a better way of loading rollbar which isn't inline.

Hm - perhaps we could export a script file into the public/ folder, and use that instead of a inlined tag.
The Rollbar snippet is just a loader though, which loads the full Rollbar library via script tag injection. Would that trip the unsafe-inline? If so, I don't see a way around it. If not, then perhaps the approach I mentioned above would work.

Closing - should be fixed shortly (working through some test issues)


Add single node control-plane cluster to EC2

Configuration steps should be documented, but this need not be applied to automation quite yet. Assessing he role of my primary AWS infrastructure with respect to public versus private repositories may necessitate a Terraform migration to a private repository. The fact of the matter is that the scope of the primary infrastructure requirements will be continuously changing, irrespective of the changes solely in this project.

https://registry.terraform.io/modules/weibeld/kubeadm/aws/0.2.2

https://github.com/kubernetes/kops is the right way to go

https://github.com/jrcasso/terraform-aws-applications
https://github.com/jrcasso/terraform-aws-operations


WIP improve quickstart

Proposed changes:

make quickstart interactive.

Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog

@amn41 there is some issue with travis, do you mind taking a look at that?


update to 2.1.1

execnet 2.1.1
Destination channel: main
Links

https://github.com/pytest-dev/execnet/tree/v2.1.1

Explanation of changes:

Keeping as noarch for convenience.

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_29308z4mmz/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:39: invalid_url: https://execnet.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:16: avoid_noarch: noarch: python packages should be avoided
clone/recipe/meta.yaml:37: invalid_url: https://execnet.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
===== Final Report: =====
0 Errors and 4 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_48kuf4qzem/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:37: invalid_url: https://execnet.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
clone/recipe/meta.yaml:16: avoid_noarch: noarch: python packages should be avoided
clone/recipe/meta.yaml:39: invalid_url: https://execnet.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 4 Warnings were found


How to connect a download folder outside the Docker container?

Hello and thank you for this ingenious JDownloader solution.
However, I have a problem that I can't get solved.
How do I manage to connect a download folder outside the Docker container/folder? I have a Share folder on Volume1 of my Synology DS916+ with OS DSM7 with a download folder. And I would like to connect it with the JDownloader.
Output should not be:
/docker/jdownloader2/output:/output \
but:
/Share/Downloads:/output \
Thank you in advance and I will also donate you a coffee 😉

Are you using the Synology Docker App ?  In container's setting, there is a Volume tab where you can map your share folder to the container.

... that's what I tried to do.  Unfortunately without success.  It seems to be a permission issue.  I will try again shortly with a newly created folder.
After that I will continue to report.

@Lz178
I'm not sure how good or bad the synology interface for docker is, but the qnap one was really poor.  Maybe consider switching to sth. like portainer or rancher. Those will make your life a lot easier in the end.

Hi. I'm having the same Issue. Inside the Docker Container a DL Dir works. Outside on the Filebase Share it doesn't. Pretty sure it is an permission Problem. But unsure how to fix it. In DSM there is no "Docker" User or anything thelike you could grant permissions to.
Interesting observation: If i put the DL Dir to a external USB Drive (ext4) it works. Guess there are simpler permissions in place.
Anybody can help?

I guess you could create a user if needed ?

Of Cause you could Create a User. But how do you get the Docker Container to run/act as this User?

Got an Answer from Support today:
You can open the folder properties of the shared folder in File Station. There you can create new ACL rules under "Permissions".
You can create a new rule for the "Everyone" group and allow the group to read and write. Before saving the new permissions, you must check "Apply to this folder, subfolders and files".
Most containers will use either User ID 0 or 1000. So if you want to avoid the "Everyone" permission,
you would have to give read/write permissions to these users, but this is not possible via the GUI
Translated with www.DeepL.com/Translator (free version)
So sadly, there is no good Solution jet :(

Allow Everyone on the Fileshare - messes up you existing Permissions
Allow User ID 0 or 1000 from shell/root - is not Standard and not manageable/viewable via GUI and might fuck up with the next update
Same when trying to tweak docker to run the Container as a different User

I uess we will have to hope and wait for Synology to implement at least a way to mount the external volumes as a defined User for a Container.
Feel free to suggest this to Synology or open Tickets. ;)

There is a fix, @Beejai and everyone else who's running into this permissions problem with Docker on Synology. Took me forever to figure out.
Granting full access for "Everyone" on the Shared Folder in File Station is definitely not a good approach.
The cause is, I believe, a clash between Unix permissions and Synology's own ACL system. As a result, the permissions inside the Docker container for the mounted volume will typically show as ----------.
The fix is relatively simple, and also works for other images with the same problem (e.g. Plex).

pick a location, e.g. Shared Folder downloads, which Docker will mount into /output. You can also use a sub-directory of a Shared Folder.
decide the user you want to use inside the container; for JDownloader, I figured it'd be appropriate to use a personal DSM user rather than admin.

for this user, ensure read/write permissions are in place on the location (see above) using File Station in the DSM admin interface (so either the Shared Folder itself, or, if you're using that instead, the sub-directory).
for this user, using SSH on the Synology, get the UID and GID values by running id yourusername.

stop the container.
ensure the container has the right UID and GID set using the USER_ID and GROUP_ID environment variables - this will ensure that the permissions for the user on the Synology host you picked earlier apply correctly inside the Docker container and vice versa.
ensure the volume mapping in the Docker app in the DSM admin interface is correct, so that your location from above (e.g. Shared Folder downloads, or a sub-directory of it) maps to /output.
in File Station in the DSM admin interface, on your downloads (or whatever you picked) Shared Folder, grant full permissions (checkboxes "Administration", "Read" and "Write") for group SYSTEM (do it on the Shared Folder itself in the left hand column, even if you picked a sub-directory for mounting into Docker)
optionally reset the container (some images such as Plex need this, as they perform permissions corrections only on first startup).
start the container.
once you've verified everything works, you may remove the permissions for group SYSTEM from the Shared Folder again.

Enjoy!

Hey guys,
i'm facing a similar issue. Im using an Intel NUC with proxmox and a virtual machine with portainer. I configured portainer to use a volume based on the synology shared folder via CIFS.
I created a dedicated Synology user for this connection and getting permission denied problems.
I already tried set permission to SYSTEM / Everyone (and all the steps mentioned by @dzuelke) with all rights but it doesn't work. Also tried to use a different USER_ID from my admin account etc.
My compose file from jdownloader:
version: '3'
services:
jdownloader-2:
container_name: jdownloader-2
image: jlesage/jdownloader-2:v1.7.1
ports:
- "9666:9666" #cnl
- "30080:5800" #ui
environment:
USER_ID: 1043
GROUP_ID: 100
restart: always
volumes:
- "jdownloader-downloads:/output" #Currently not working because UID not same as host fck synology
- "jdownloader-config:/config"
#- "/data/docker/jdownloader/volume/output:/output"
#- "/data/docker/jdownloader/volume/config:/config"
volumes:
jdownloader-downloads:
external: true
jdownloader-config:
external: true
USER ID: 1043 = my Synology user dedicated for portainer (username portainer, uid = 1043)
GROUP_ID: 100 = Synology group "users"
Volumes CIFS (v.3.0) volumes:
jdownloader-downloads = //<IP_ADDRESS>/docker/jdownloader/downloads
jdownloader-config = //<IP_ADDRESS>/docker/jdownloader/config
It seems like the USER_ID / GROUP_ID isnt working correctly. If im connecting inside the container and trying to create files / folders from the shell its working wthout any issues. Just the ui can not create / update any files :(
Maybe someone found a solution for my case?

I have a different solution to offer:
Connect a /bin/sh as root to the container (will work on Synology Web as well as via portioner (if in use))
and check the permissions of the mount point (this defaults to /output in all tutorials)
Most likely the permission is set to d---------
So the default "app" user (used inside the container) cannot access the share.
If you change this to say 755 and reboot, it should work.

The solution provided by @dzuelke works like a charm. I just ran into the same reason today when i switched the permissions from one user to another after defining additional groups. Couldn't get it to work again afterwards though.
One thing to add is that you have test whether setting the permissions via a group in Synology is working. In my case i had to explicitly check the permission boxes on the User level. Granting them via a group did not work. Only after that the container actually started up as it did before.

hello folks,
I up this thread, I have the same issue :D and I came to the same conclusion, user permission looks the issue
On my side, I tried to figure it out, for now the only solution whom works is to put everyone read write on dedicated folder, without restart JDownloader docker is able to list files in the folder and write new ones as well.
The conclusion I found, as @Beejai, is user 1000 run the docker but cannot be allowed to permission on this external folder, it like a ghost user specifically created on the fly for the docker app ?
I tried to create a dedicated user and run docker with this user
In Settings > Environment variable > USER_ID > and put the user ID of my dedicated user
and put permission on folder, but no success, I have to put everyone too
Is it needed to change the GROUP_ID ? No clue
So any follow up on this ?
I was thinking about create a folder inside the docker default folders. aka /config and /output, because those folders are ok, user 1000 have full control on those, and JDownloader is able to read write into this default folder


queued tests have old elapsed time

Zafira: <IP_ADDRESS>.
for each queued test we should reset elapsed time during copying tests from previously testrun

now time is not displayed 944a2c3b1958d294b2938efd98c71454847ac48f


Update release notes and version for 0.9.0a0

Please check the release notes carefully, hadn't had much time to write them.
Draft release available here.

Thanks @EwoutH!
@tpike3 Need your review here

We’re with the two maintainers that made all the changes in this PR, I’m saying we’re good!


Exported game with title containing single quote gets replaced with exclamation mark

Describe the bug
If you export a game with a single quote in the title, then it gets changed to an exclamation point in the exported page title, header, and metadata.
Reproduction Steps

Start new project
Put "Can't be" as the title of the project

title Can't be

Export
Open exported file

<meta name="description" content="Can!t be">
<title>Can!t be</title>
...

Can!t be

What did you expect would happen?
Title text to be preserved:
<meta name="description" content="Can't be">
<title>Can't be</title>
...

Can't be

OS & Browser version, desktop/mobile
Windows 10 Edge Desktop
Screenshots, example projects, other relevant issues, etc.

Not really a bug. You should be getting a message "Unsafe characters found in script will be replaced by !".
Maybe this isn't the best way to deal with them, but figuring out what else could be done is more than a quick fix.

Not really a bug. You should be getting a message "Unsafe characters found in script will be replaced by !".

Oh, I totally didn't see that in the blue on blue and as a 'header' style at the top:

It's also not actionable as it doesn't tell me the line or the offending character or any info. It should show up like the other message does about 'V' with a link to the line and in a brighter color.
I'd also suggest with both of these 'warnings' the message about "successful compilation" is a bit misleading, maybe it should be "Compilation completed with X warnings" (2 in this case). Only call it "Success" if there are no warnings, and use "Failed" if there are any errors?

Maybe this isn't the best way to deal with them, but figuring out what else could be done is more than a quick fix.

Shouldn't these just get escaped with ' and " and such during export? It doesn't seem unreasonable that folks would want these characters in titles for games. E.g.

Sally's Sunny Day
Bob and his "Breakfast"
George's Pet Monster

As far as I can tell, this appears here and is only checked/used solely in local script export (not cloud share) here:
https://github.com/david-pfx/PuzzleScriptNext/blob/544fe7c88fc9d1194e3dff6839d7730c0a6ce2c9/src/js/buildStandalone.js#L23-L32
And only for these three fields:
https://github.com/david-pfx/PuzzleScriptNext/blob/544fe7c88fc9d1194e3dff6839d7730c0a6ce2c9/src/js/buildStandalone.js#L61-L63
If the exported script is an html file the own developer of the script is downloading for themselves, why is the input even bothering to be sanitized? Especially, when no other values are?
There's not really incentive for them to enter an invalid url to their own homepage, and even if they wanted to be malicious, they can just modify the HTML file they get as a result anyway as it's just the local exported version being checked here.
I suppose they could try and put a tag in their title and that'd lead to some other issue, but I still feel like the proper solution, if this is required, is to replace character in the string for each of the characters you're worried about with their corresponding HTML entity code:

Character
HTML Escape Code

<
<

>
>

&
&

'
'

"
"

\v
??

Not sure where the vertical tab would come from, would it just be blanked or should it be replaced with a horizontal one 	?


untangle reth-provider crate

Describe the feature
similar to #8342
the provider crate is super bloated, making it hard to consume just the interfaces for accessing the chain.
Additional context
No response

ref https://github.com/paradigmxyz/reth/issues/8158


How to retrieve request inside Strategy?

I want to retrieve the current request object inside the Strategy logic. Is this possible?

+1. I have a use case in which I allow authentications that originates from specific IP's or networks, therefore I need to retrieve the remoteAddress from the  req object.


Error setting property on RCTBubblingEventBlock

Description
Hi, i have created a RCTViewManager class in swift :
`@objc(RCTSDKRecoView)
class RCTSDKRecoView: RCTViewManager {
var myFitRecommendationView: MyFitRecommandationSDKView?
override static func requiresMainQueueSetup() -> Bool {
return true
}
@objc var onCallback: RCTBubblingEventBlock?
override func view() -> UIView! {
myFitRecommendationView = MyFitRecommandationSDKView()
return myFitRecommendationView
}
}
`
and the bridge in Obj :
`@interface RCT_EXTERN_MODULE(RCTSDKRecoView, RCTViewManager)
RCT_EXPORT_VIEW_PROPERTY(onCallback, RCTBubblingEventBlock)
@end`
My ts :
<SDKRecoView           ref={sdkRecoViewRef}           onCallback={(result: any) => {             console.log(result);           }}           style={styles.fullsize}         />
My goal is to trigger callback in the swift class
I have a runtime error on the render method :
Error setting property 'onCallback' of RCTSDKRecoView with tag #579: Exception thrown while executing UI block: -[PodMyFitScan.MyFitRecommandationSDKView setOnCallback:]: unrecognized selector sent to instance 0x11360dce0
Steps to reproduce

Launch the application with the RCTViewManager above

React Native Version
0.73.1
Affected Platforms
Runtime - iOS
Output of npx react-native info
System:
  OS: macOS 14.0
  CPU: (8) arm64 Apple M1
  Memory: 89.31 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.8.1
    path: /opt/homebrew/bin/node
  Yarn: Not Found
  npm:
    version: 10.1.0
    path: /opt/homebrew/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.14.3
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2021.2 AI-212.5712.43.2112.8815526
  Xcode:
    version: 15.1/15C65
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: javac 21
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.1
    wanted: 0.73.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs
Error setting property 'onCallback' of RCTSDKRecoView with tag #579: Exception thrown while executing UI block: -[PodMyFitScan.MyFitRecommandationSDKView setOnCallback:]: unrecognized selector sent to instance 0x11360dce0

Reproducer
https://github.com/facebook/react-native
Screenshots and Videos
No response

Please provide a valid reproducer @LionelMyFit


tests, Adapt primary_pod_network and migration tests to be dual stack compatible

Create ValidateVMIandPodIPMatch
which validates the following:
virt-launcher PodIP equal vmi.Status.Interfaces[0].IP
virt-launcher PodIPs equal vmi.Status.Interfaces[0].IPs
Length of vmi.Status.Interfaces[0].IPs is not zero.
Use it in migration tests 1783, 3245 in order to support and test dual stack.
Adapt primary_pod_network tests to support dual stack.
Signed-off-by: Or Shoval<EMAIL_ADDRESS>None

/cc @EdDev

he migration tests have another test that checks IP: "[test_id:1783]should be successfully migrated multiple times with cloud-init disk".
Why that one was not handled here?

As we spoke when researching about the tests,
migration selects internally which ip to use when migrating, and we said we are not doing it on this phase.
we are focusing on the tests layer, with the 3 groups of tests we created.
the test you mention checks for return newvmi.Status.Interfaces[0].IP == vmiPod.Status.PodIP
we can adapt that it will also check for IPs, i didnt mention this test in the title.

I do not really understand the relation between the commits except of the fact they cover multiple IP/s. Is there any other commonality?

There isnt, i can refactor it to 2 commits, and change the title

/hold
until #3958 is merged
Still need to test it locally and update description, will update when done

/test pull-kubevirt-goveralls

/hold cancel
3958 was merged, rebased
done comments, PTAL (testing locally)

Moved to libvmi networking, thanks for the tips Edy.
Done the comments.
Testing locally.

Moved to libvmi networking, thanks for the tips Edy.
Done the comments.
Testing locally.
PTAL.

Travis failed on missing blank line. fixed
ready to review, arranging commits, but beside it not changing code until new notice.

Rearranged commits.

/lgtm

About commit "tests, Create ValidateVMIandPodIPMatch to libvmi networking"
There is not context for the error messages, you cann understand if it related to pod or VMI
please specify if it related to the pod or the VMI
see example at my PR cf8e94e#diff-d47bf036797965d742615e64adc3b777

Please point in my PR to what you mean, all the ips are mentioned and the scope of them.

About commit "tests, Create ValidateVMIandPodIPMatch to libvmi networking"
There is not context for the error messages, you cann understand if it related to pod or VMI
please specify if it related to the pod or the VMI
see example at my PR cf8e94e#diff-d47bf036797965d742615e64adc3b777

Please point in my PR to what you mean, all the ips are mentioned and the scope of them.
Check again please the function and point to the line that looks wrong if it looks wrong.
The entities have different name so its known who is vmi and who is pod, and on pod it says the word pod.
I can add the word VMI if its critical.

@ormergi
added the word vmi
PTAL

/test pull-kubevirt-check-tests-for-flakes

@phoracek @qinqon this is an interesting situation.
We have a common verification on vmi vs pod, ip related. So it is can be classified under network.
If we add it to the network package (see last commit) we have a problem of importing tests.
On the other hand, placing the verification under libvmi makes it odd due to the pod getting there.
We may need to separate the tests in network from the libs (e.g. network & network_test).
What say you? How we resolve this?

@phoracek @qinqon this is an interesting situation.
We have a common verification on vmi vs pod, ip related. So it can be classified under network.
If we add it to the network package (see last commit) we have a problem of importing tests.

One nit, it does work now.
do you talk about now (if so please reconsider it works now) ?
or you talk on future that will need to use it?

On the other hand, placing the verification under libvmi makes it odd due to the pod getting there.
We may need to separate the tests in network from the libs (e.g. network & network_test).
What say you? How we resolve this?

/test pull-kubevirt-check-tests-for-flakes

/retest

@EdDev @oshoval do we have any issue at imports at current approach ?
I see this comment from ed: If we add it to the network package (see last commit) we have a problem of importing tests.

@EdDev @oshoval do we have any issue at imports at current approach ?
I see this comment from ed: If we add it to the network package (see last commit) we have a problem of importing tests.

We dont have any logical problem (it compiles and works), just semantics in case this what Edy meant (importing network module from non network test).

@oshoval so issue is non network tests importing network package ?

@oshoval so issue is non network tests importing network package ?

Just my guess that Edy meant either this, or that Edy thought it doesnt work (because there was a middle stage with a WIP bug).

@oshoval so issue is non network tests importing network package ?

Yes, that is the problem.
We do not want to have tests importing tests, we want tests importing test-helpers.
The fact that is working now is not sign about its correctness, it is a sign that the scenario did not present itself yet.

@oshoval so issue is non network tests importing network package ?

Yes, that is the problem.
We do not want to have tests importing tests, we want tests importing test-helpers.
The fact that is working now is not sign about its correctness, it is a sign that the scenario did not present itself yet.

just a note, its not test that import tests, its a pure lib, just the package name and the folder might imply on other test, which i believe its what you mean.
so what do we do please?
and can we take it to other PR and fall back with one of the directions ?

@oshoval If we follow the current pattern under kubevirt/tests the test code has the header package tests_test and the helpers there package tests we can do the same for the network subdirectory since there are tests so primary_pod_network.go should use package network_test and the rest of stuff just network.

@oshoval If we follow the current pattern under kubevirt/tests the test code has the header package tests_test and the helpers there package tests we can do the same for the network subdirectory since there are tests so primary_pod_network.go should use package network_test and the rest of stuff just network.

We cannot follow that pattern. network/ directory cannot be turned into _test module since that would prevent us from importing it to the main suite file.

@phoracek It's a known golang idiom just for test to use package foo_test for test under package foo golang will take care of that and compile a different package from https://golang.org/pkg/cmd/go/internal/test/#pkg-variables:
separate package, and then linked and run with the main test binary.```

@phoracek It's a known golang idiom just for test to use package foo_test for test under package foo golang will take care of that and compile a different package from https://golang.org/pkg/cmd/go/internal/test/#pkg-variables:
Test files that declare a package with the suffix "_test" will be compiled as a
separate package, and then linked and run with the main test binary.

That is the issue, we don't follow the "one directory per test suite" model. We _ import our network tests to the main suite, so we don't need to introduce our own suite (and all the boiler plate connected to it). If we changed our network into network_test we would not be able to import.
https://github.com/kubevirt/kubevirt/blob/master/tests/tests_suite_test.go#L36

That is the issue, we don't follow the "one directory per test suite" model. We _ import our network tests to the main suite, so we don't need to introduce our own suite (and all the boiler plate connected to it). If we changed our network into network_test we would not be able to import.
https://github.com/kubevirt/kubevirt/blob/master/tests/tests_suite_test.go#L36

Why can't we import "network_test" and that in turn will import "network" or it will not (we do not really care).

That is the issue, we don't follow the "one directory per test suite" model. We _ import our network tests to the main suite, so we don't need to introduce our own suite (and all the boiler plate connected to it). If we changed our network into network_test we would not be able to import.
https://github.com/kubevirt/kubevirt/blob/master/tests/tests_suite_test.go#L36

Why can't we import "network_test" and that in turn will import "network" or it will not (we do not really care).
EDIT: i.e. _ "kubevirt.io/kubevirt/tests/network_test"

That's what I suggest we do in case we indeed cannot split network internally with package network and package network_test.

Why can't we import "network_test" and that in turn will import "network" or it will not (we do not really care).
EDIT: i.e. _ "kubevirt.io/kubevirt/tests/network_test"

That's what I suggest we do in case we indeed cannot split network internally with package network and package network_test.

What I mentioned is without changing the folder name. Just following the pattern we see on ./tests folder.
Folder stays network, we have there two packages network and network_test, we import network_test so it will be included in the main binary. Will this work?

Why can't we import "network_test" and that in turn will import "network" or it will not (we do not really care).
EDIT: i.e. _ "kubevirt.io/kubevirt/tests/network_test"

That's what I suggest we do in case we indeed cannot split network internally with package network and package network_test.

What I mentioned is without changing the folder name. Just following the pattern we see on ./tests folder.
Folder stays network, we have there two packages network and network_test, we import network_test so it will be included in the main binary. Will this work?

I believe that the import is based on the path (and directory name), not the package name. If not, I learnt something new today.

@phoracek for tests is special, I have move locally the test under network to package network_test and focus on sig-network and look like it's working
• [SLOW TEST:15.104 seconds]
[sig-network] Primary Pod Network
/root/go/src/kubevirt.io/kubevirt/tests/network/framework.go:27
  Status
  /root/go/src/kubevirt.io/kubevirt/tests/network/primary_pod_network.go:47
    VMI connected to the pod network using bridge binding
    /root/go/src/kubevirt.io/kubevirt/tests/network/primary_pod_network.go:72
      should report PodIP as its own on interface status
      /root/go/src/kubevirt.io/kubevirt/tests/network/primary_pod_network.go:83
------------------------------

@phoracek looks like it's working if I don't add a new package there if I add foobar.go at package network there i get
go version go1.13.14 linux/amd64
# kubevirt.io/kubevirt/tests
package kubevirt.io/kubevirt/tests_test
	imports kubevirt.io/kubevirt/tests/network: found packages network (foo.go) and network_test (framework.go) in /root/go/src/kubevirt.io/kubevirt/tests/network
FAIL	kubevirt.io/kubevirt/tests [setup failed]
FAI

Good to know. Well, then I'd keep directories network/ and netowork_tests/ to work around this limitation.

@phoracek the only thing that we need is to resuse network validations for network tests under kubevirt/tests so maybe just creating a networkvalidations.go there is enough without touching network package at all or creating network_test package

@phoracek what about libnet and network ? so we have something similar to libvmi although maybe in long run would be nicer to have kind of opreator-sdk structure test/e2e, test/e2e/network/ for tests and for helpers test/vmiandtest/network/

@qinqon and me agreed to leave this as is now and squash the changes.
I would add that I prefer the filename to be singular and not plural (i.e. validation.go).
In a following PR, we will open up a new package for network libs (libnet) and move that validation there.

Rearranged commits, renamed to validation.go
rebased.
PTAL

/lgtm

/approve
/hold
Feel free to cancel the hold once you are ready to merge this.

Thanks
/hold cancel
The comment of Edy, was asked by Quique and said as a non blocker, in case we need will will learn from it.

looks good!
/lgtm


Merging develop into master

Current coverage is 65.82% (diff: 100%)

Merging #30 into master will not change coverage

@@             master        #30   diff @@
==========================================
  Files             4          4
  Lines            79         79
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             52         52
  Misses           27         27
  Partials          0          0

Powered by Codecov. Last update 182c2c7...10639a2


Liveness probe failed: calico/node is not ready: Felix is not live: liveness probe reporting 503

Getting following error for calico-node pod
Liveness probe failed: calico/node is not ready: Felix is not live: liveness probe reporting 503
Steps to Reproduce (for bugs)
I am deploying calico CNI in 2 node kubernetes Kind(https://github.com/kubernetes-sigs/kind) cluster. I keep seeing following liveness probe failures with following logs
2021-05-12 08:53:53.213 [WARNING][53] felix/health.go 66: Report timed out name="int_dataplane" 2021-05-12 08:53:53.213 [WARNING][53] felix/health.go 184: Reporter is not live. name="int_dataplane" 2021-05-12 08:53:53.213 [WARNING][53] felix/health.go 55: Report timed out name="int_dataplane" 2021-05-12 08:53:53.213 [WARNING][53] felix/health.go 188: Reporter is not ready. name="int_dataplane" 2021-05-12 08:53:53.213 [INFO][53] felix/health.go 196: Overall health status changed newStatus=&health.HealthReport{Live:false, Ready:false} 2021-05-12 08:53:53.213 [WARNING][53] felix/health.go 165: Health: not live 2021-05-12 08:53:54.565 [WARNING][53] felix/health.go 66: Report timed out name="int_dataplane" 2021-05-12 08:53:54.565 [WARNING][53] felix/health.go 184: Reporter is not live. name="int_dataplane" 2021-05-12 08:53:54.565 [WARNING][53] felix/health.go 55: Report timed out name="int_dataplane" 2021-05-12 08:53:54.565 [WARNING][53] felix/health.go 188: Reporter is not ready. name="int_dataplane" 2021-05-12 08:53:54.565 [WARNING][53] felix/health.go 154: Health: not ready 2021-05-12 08:54:00.455 [INFO][56] monitor-addresses/startup.go 768: Using autodetected IPv4 address on interface eth0: <IP_ADDRESS>/25 2021-05-12 08:54:03.223 [WARNING][53] felix/health.go 66: Report timed out name="int_dataplane" 2021-05-12 08:54:03.223 [WARNING][53] felix/health.go 184: Reporter is not live. name="int_dataplane" 2021-05-12 08:54:03.223 [WARNING][53] felix/health.go 55: Report timed out name="int_dataplane" 2021-05-12 08:54:03.223 [WARNING][53] felix/health.go 188: Reporter is not ready. name="int_dataplane" 2021-05-12 08:54:03.223 [WARNING][53] felix/health.go 165: Health: not live 2021-05-12 08:54:04.557 [WARNING][53] felix/health.go 66: Report timed out name="int_dataplane" 2021-05-12 08:54:04.558 [WARNING][53] felix/health.go 184: Reporter is not live. name="int_dataplane" 2021-05-12 08:54:04.558 [WARNING][53] felix/health.go 55: Report timed out name="int_dataplane" 2021-05-12 08:54:04.558 [WARNING][53] felix/health.go 188: Reporter is not ready. name="int_dataplane" 2021-05-12 08:54:04.558 [WARNING][53] felix/health.go 154: Health: not ready 2021-05-12 08:54:13.187 [WARNING][53] felix/health.go 66: Report timed out name="int_dataplane" 2021-05-12 08:54:13.187 [WARNING][53] felix/health.go 184: Reporter is not live. name="int_dataplane" 2021-05-12 08:54:13.187 [WARNING][53] felix/health.go 55: Report timed out name="int_dataplane" 2021-05-12 08:54:13.187 [WARNING][53] felix/health.go 188: Reporter is not ready. name="int_dataplane" 2021-05-12 08:54:13.187 [WARNING][53] felix/health.go 165: Health: not live 2021-05-12 08:54:14.537 [WARNING][53] felix/health.go 66: Report timed out name="int_dataplane" 2021-05-12 08:54:14.537 [WARNING][53] felix/health.go 184: Reporter is not live. name="int_dataplane" 2021-05-12 08:54:14.537 [WARNING][53] felix/health.go 55: Report timed out name="int_dataplane" 2021-05-12 08:54:14.537 [WARNING][53] felix/health.go 188: Reporter is not ready. name="int_dataplane" 2021-05-12 08:54:14.537 [WARNING][53] felix/health.go 154: Health: not ready
Your Environment

Calico version: v3.18
Kubernetes Kind(https://github.com/kubernetes-sigs/kind)

Can someone please help?

I am still facing this issue. Can someone please help?

@song-jiang Calico backend is "bird".
Here is the yaml file used for deploying calico. Please note that CRDs are deployed separately.
calico-all.yaml.zip

@pagarwal-tibco I think we will need more logs to understand this.  Could you try changing
            - name: FELIX_LOGSEVERITYSCREEN
              value: "info"

to
            - name: FELIX_LOGSEVERITYSCREEN
              value: "debug"

and then redeploy, and attach one of the node logs here?
Also wondering about your KIND version and config.  Here's a config sample from our own testing:
    ${KIND} create cluster --config - <<EOF
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
networking:
  disableDefaultCNI: true
  podSubnet: "<IP_ADDRESS>/17"
nodes:
# the control plane node
- role: control-plane
- role: worker
- role: worker
- role: worker
EOF

Is yours also like that?
Our testing is using https://github.com/kubernetes-sigs/kind/releases/download/v0.8.1/kind-linux-amd64.  Could you try with that version - just in case something important has changed since then in KIND master?

We are using KIND version 0.9 and 0.10 as we need to use Kubernetes version 1.19 and 1.20. We are using following KIND config,
apiVersion: kind.x-k8s.io/v1alpha4
networking:
  disableDefaultCNI: true
  podSubnet: '<IP_ADDRESS>/16'
  serviceSubnet: '<IP_ADDRESS>/20'
  apiServerPort: 6443
nodes:
- role: control-plane
- role: worker

Calico node debug logs are here
calico.log

@pagarwal-tibco Thanks for the log.  It indicates that the Felix component does become live after a few seconds.  So perhaps the liveness problem is in another component.  Can you check what kubectl describe says for a calico-node pod when it is not becoming live?  There should be a message that gives a bit more detail about the problem.

@neiljerram
Calico node pod keeps toggling between ready and not ready.
I see following event for calico-node
calico/node is not ready: felix is not ready: readiness probe reporting 503
  Warning  Unhealthy  36s (x17 over 9m24s)  kubelet  Liveness probe failed: calico/node is not ready: Felix is not live: liveness probe reporting 503

@neiljerram
I see same problem with calico 3.19.
  Warning  Unhealthy  13m (x14 over 23m)   kubelet  Liveness probe failed: calico/node is not ready: Felix is not live: liveness probe reporting 503
  Warning  Unhealthy  3m6s (x24 over 18m)  kubelet  (combined from similar events): Readiness probe failed: 2021-05-25 06:36:25.848 [INFO][6210] confd/health.go 180: Number of node(s) with BGP peering established = 1
calico/node is not ready: felix is not ready: readiness probe reporting 503

Please let me know if you need anymore information.

@neiljerram
I am still facing this issue. Any pointers please?

Any updates on this issue?

I have seen these symptoms in a system that was starved of CPU. It might be worth trying this on a machine with more CPU?

Are the pod and service cidrs overlapping? Can you try removing the serviceSubnet?

@lmm I tried removing serviceSubnet and using non overlapping value. But still the same issue.
@lwr20 I have a good machine and top command shows CPU is idle as well.

@pagarwal-tibco are you using a Linux host? I cannot repro what you're seeing and we use kind quite a bit in our automated tests. Perhaps there is something on your host that is interfering with Calico.
If you're using a Mac, there is this kind issue that might be worth looking into: https://github.com/kubernetes-sigs/kind/issues/2308

@caseydavenport why you closed the ticket?

@pierluigilenoci I presume because the OP did not respond since 13th July?

A month is not that long. Maybe he took the covid or is on vacation. Let's try to stimulate him...
@pagarwal-tibco knock knock!

A month is plenty long - we usually close tickets without a response in 2-3 weeks. We can always re-open if the OP returns.

Sorry for late reply, I was away. I upgraded docker for mac to 3.6.0 and I confirm that it works now. So it seems that the issue was caused by docker for mac.
Thanks for all the help.

Thanks @pagarwal-tibco !

The same problem on k8s node(Ubuntu 18.04.5 LTS/5.4.0-60-generic)
Events:
  Type     Reason     Age                   From     Message
  ----     ------     ----                  ----     -------
  Warning  Unhealthy  11m (x8338 over 10d)  kubelet  (combined from similar events): Readiness probe failed: 2021-10-09 06:49:07.655 [INFO][27506] confd/health.go 180: Number of node(s) with BGP peering established = 76
calico/node is not ready: felix is not ready: readiness probe reporting 503
  Warning  Unhealthy  5m17s (x6281 over 20d)  kubelet  Liveness probe failed: calico/node is not ready: Felix is not live: liveness probe reporting 503

Seems that nobody cares about this issue...

I've been struggled with this issue for past few days and managed to fix this by editing a clusterrole resource.
I have an RKE-based cluster (version 1.21.10), and I upgraded calico related images up to 3.21.5, after that the initial healthcheck issue had cropped up.
Make sure you have the proper clusterrole manifest as following (copied from the original Calico website):
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: calico-node
rules:
  # The CNI plugin needs to get pods, nodes, and namespaces.
  - apiGroups: [""]
    resources:
      - pods
      - nodes
      - namespaces
    verbs:
      - get
  # EndpointSlices are used for Service-based network policy rule
  # enforcement.
  - apiGroups: ["discovery.k8s.io"]
    resources:
      - endpointslices
    verbs:
      - watch
      - list
  - apiGroups: [""]
    resources:
      - endpoints
      - services
    verbs:
      # Used to discover service IPs for advertisement.
      - watch
      - list
      # Used to discover Typhas.
      - get
  # Pod CIDR auto-detection on kubeadm needs access to config maps.
  - apiGroups: [""]
    resources:
      - configmaps
    verbs:
      - get
  - apiGroups: [""]
    resources:
      - nodes/status
    verbs:
      # Needed for clearing NodeNetworkUnavailable flag.
      - patch
      # Calico stores some configuration information in node annotations.
      - update
  # Watch for changes to Kubernetes NetworkPolicies.
  - apiGroups: ["networking.k8s.io"]
    resources:
      - networkpolicies
    verbs:
      - watch
      - list
  # Used by Calico for policy information.
  - apiGroups: [""]
    resources:
      - pods
      - namespaces
      - serviceaccounts
    verbs:
      - list
      - watch
  # The CNI plugin patches pods/status.
  - apiGroups: [""]
    resources:
      - pods/status
    verbs:
      - patch
  # Calico monitors various CRDs for config.
  - apiGroups: ["crd.projectcalico.org"]
    resources:
      - globalfelixconfigs
      - felixconfigurations
      - bgppeers
      - globalbgpconfigs
      - bgpconfigurations
      - ippools
      - ipamblocks
      - globalnetworkpolicies
      - globalnetworksets
      - networkpolicies
      - networksets
      - clusterinformations
      - hostendpoints
      - blockaffinities
      - caliconodestatuses
    verbs:
      - get
      - list
      - watch
  # Calico must create and update some CRDs on startup.
  - apiGroups: ["crd.projectcalico.org"]
    resources:
      - ippools
      - felixconfigurations
      - clusterinformations
    verbs:
      - create
      - update
  # Calico stores some configuration information on the node.
  - apiGroups: [""]
    resources:
      - nodes
    verbs:
      - get
      - list
      - watch
  # These permissions are required for Calico CNI to perform IPAM allocations.
  - apiGroups: ["crd.projectcalico.org"]
    resources:
      - blockaffinities
      - ipamblocks
      - ipamhandles
    verbs:
      - get
      - list
      - create
      - update
      - delete
  - apiGroups: ["crd.projectcalico.org"]
    resources:
      - ipamconfigs
    verbs:
      - get
  # Block affinities must also be watchable by confd for route aggregation.
  - apiGroups: ["crd.projectcalico.org"]
    resources:
      - blockaffinities
    verbs:
      - watch
EOF

Hopefully it helps.

I upgrade calico version resolved my probles, see https://github.com/kubesphere/kubekey/issues/1282

We ran into a similar issue and were able to resolve it by setting CPU requests for calico-node Pods. https://github.com/projectcalico/calico/issues/3420#issuecomment-1468897178

I checked my log and found I forgot to instll ipset which it requires to use. (I'm in a hush tho)
So I just installed it and then the problem disappears.😂
maybe I'm dumb here, but I just post here if anyone runs into the same situation


[CENNSO-569] Fix crash during bond setup

@ivan4th in which situation does the crash occur?

ip4_sas_by_sw_if_index() call with dst == 0 was causing VPP to crash

This happens only with the newer (WiP) FPP version which employs a DAG (dependency graph) of FPP config actions. From what I see, this may happen if an IP address is set for the bond before adding any members, but there may be other triggers. With earlier FPP versions (current stable included), this problem has never been observed.


EPCT-21 We no longer accept decimal number on dispensation

Coverage remained the same at 70.957% when pulling 743dbc77e357ad7588bae0a64105edf36430b3de on edrisse:fix-decimal-number-amount-drugs into df0534869217a15b37e8e9546ee3946875221684 on esaude:master.


tertiary analysis vignette

Vignette to show end-to-end analysis path for geomx data with examples of the following:
see the following document for reference: Box PPT File
Primary & Secondary

[x] loading data
[x] QC

[x] include table of pass / warning by type
[x] include histograms of QCs

[x] bioQC

[x] include table of total local, global outliers & passed probes

[x] gene filtering
[x] AOI filtering
[ ] Normalization

[ ] include example boxplots for raw data, q3, and neg norm

Downstream analysis

[ ] Umap
[ ] tSNE
[ ] LMM

[ ] include volcano plot

[ ] target visualization - heatmap
[ ] target visualization - boxplot
Stretches: Pathway & Cell Decon

additional adjustments needed:

[ ] text updates
[ ] confirm LOQ functions correctly
[ ] swap neg_norm -> Q3 for tertiary analysis

[] move histograms before QC
[] functions generalized for multi-panel use case

[ ] move LOQ after count aggregation to use panel-specific geomean / geosd columns

[ ] implement bioconductor workflow markdown

see these:
link 1
link 2


Fail to write pd.TimedeltaIndex and np.timedelta64

Hi,
When I try to write a pd.DataFrame with pd.TimedeltaIndex or np.timedelta64 column, I got

ArrowNotImplementedError: Unsupported numpy type 22.

I see that there's a Jira ARROW-835 that is about implementing parquet I/O of pd.TimedeltaIndex and np.timedelta64. However, there seems to be no update on that since Nov/17. Is there a chance that this'll be resolved any time soon? What's the show stopper?
Thanks

@xwang777 The showstopper is like in most cases that someone needs to work on the issue. Arrow just like any other opensource projects relies upon the contribution by individuals. If this is a feature that is of great interest for you, I would recommend that you try to implement it. When you need help making your contribution, feel free to reach out on the mailing list or the Slack channel and we will try to support you.

I have opened a JIRA specifically for the Python/pandas conversions to and from Arrow intervals: https://issues.apache.org/jira/browse/ARROW-2625.
However, first we must resolve the format discussion in ARROW-835. We would welcome your assistance. I will close this issue in the meantime and steer discussion to JIRA.


Fix offset projection under offset modes

Background
Instance Y is flipped when using offset modes. The switch from LNGLAT to LNGLAT_AUTO_OFFSETS can illustrate this issue:

Related PR:
https://github.com/uber/deck.gl/pull/2167
Cause

Y is reversed in Web Mercator projection (worldPosition.y goes down as lnglat.y goes up) during projection.
CPU projection function (webMercatorViewport.projectFlat) produces flipped Y. This is used in calculating the projection center.
Shader function project_mercator_ produces flipped Y. This is used in the old LNGLAT projection mode.
Shader function project_offset_ produces non-flipped Y. This is used in offset modes (LNGLAT_OFFSETS, METER_OFFSETS, LNGLAT_AUTO_OFFSET).
Shader function project_scale produces non-flipped Y. This is used in all modes.

A Viewport instance has two properties: viewMatrixUncentered and viewMatrix. Only viewMatrix contains a Y flip.
In LNGLAT mode, the projection to clipspace roughly goes like this:
project_uViewProjectionMatrix * (project_mercator_(position) + project_scale(offset))

a.k.a.
(flipped) * (flipped + non-flipped)
In offset modes, viewport.viewMatrixUncentered is used instead of viewMatrix, see here. As a result, viewProjectionMatrix does not include the Y flip.
project_uCenter + project_uViewProjectionMatrix * (project_offset_(position) + project_scale(offset))

a.k.a.
(flipped) + (non-flipped) * (non-flipped + non-flipped)
This PR makes the offset modes behave consistently with the LNGLAT mode.
The question remains
Whether we should flip Y in project_scale to conform with the east-north coordinate system (likely by changing viewport-mercator-project to produce reversed y values in pixelsPer* in getDistanceScale). Since it will be a breaking change, I do not think we should do it in a patch/minor release.
Change List

Move y flip to viewMatrixUncentered
Flip y in project_offset_

@georgios-uber Please go ahead and land this so that we can start getting the new LNGLAT mode ready for 6.2.


Fix pattern detection in relative path condition (#89)

Error in IDE "Failed to check if current file is included" #89

Hi, thanks for your contribution.
Your code looks good but could you please add a test case for the problem it fixes? Maybe just reuse the failing parameters reported inside the issue. There's already a data driven test for the isFileIncluded function.
In order to release it, please also add a "Fixes" entry to the file CHANGELOG.md under the [Unreleased] section.
This project uses KeepAChangelog for automatic versioning. In order to trigger a release you also need to bump the pluginVersion inside the gradle.properties from 3.0.0 to 3.0.1.

Hi, thanks for your contribution.
Your code looks good but could you please add a test case for the problem it fixes? Maybe just reuse the failing parameters reported inside the issue. There's already a data driven test for the isFileIncluded function.
In order to release it, please also add a "Fixes" entry to the file CHANGELOG.md under the [Unreleased] section. This project uses KeepAChangelog for automatic versioning. In order to trigger a release you also need to bump the pluginVersion inside the gradle.properties from 3.0.0 to 3.0.1.

Hi ! Well this code fix the existing unit tests that fails because of pattern like **/*.yaml that can be set by users. So I think that we don't have to create another tests as they already exists ? 😊

Hi, thanks for your contribution.
Your code looks good but could you please add a test case for the problem it fixes? Maybe just reuse the failing parameters reported inside the issue. There's already a data driven test for the isFileIncluded function.
In order to release it, please also add a "Fixes" entry to the file CHANGELOG.md under the [Unreleased] section. This project uses KeepAChangelog for automatic versioning. In order to trigger a release you also need to bump the pluginVersion inside the gradle.properties from 3.0.0 to 3.0.1.

Hi ! Well this code fix the existing unit tests that fails because of pattern like **/*.yaml that can be set by users. So I think that we don't have to create another tests as they already exists ? 😊

I see, could it be that you're working on windows?
Because on mac and linux (our CI) all tests were already passing beforehand.

Hi, thanks for your contribution.
Your code looks good but could you please add a test case for the problem it fixes? Maybe just reuse the failing parameters reported inside the issue. There's already a data driven test for the isFileIncluded function.
In order to release it, please also add a "Fixes" entry to the file CHANGELOG.md under the [Unreleased] section. This project uses KeepAChangelog for automatic versioning. In order to trigger a release you also need to bump the pluginVersion inside the gradle.properties from 3.0.0 to 3.0.1.

Hi ! Well this code fix the existing unit tests that fails because of pattern like **/*.yaml that can be set by users. So I think that we don't have to create another tests as they already exists ? 😊

I see, could it be that you're working on windows? Because on mac and linux (our CI) all tests were already passing beforehand.

Yes ! We are working on windows environment. Mmh maybe do you want us to add an os detection condition to make the code works a little bit differently on windows ?

Hi, thanks for your contribution.
Your code looks good but could you please add a test case for the problem it fixes? Maybe just reuse the failing parameters reported inside the issue. There's already a data driven test for the isFileIncluded function.
In order to release it, please also add a "Fixes" entry to the file CHANGELOG.md under the [Unreleased] section. This project uses KeepAChangelog for automatic versioning. In order to trigger a release you also need to bump the pluginVersion inside the gradle.properties from 3.0.0 to 3.0.1.

Hi ! Well this code fix the existing unit tests that fails because of pattern like **/*.yaml that can be set by users. So I think that we don't have to create another tests as they already exists ? 😊

I see, could it be that you're working on windows? Because on mac and linux (our CI) all tests were already passing beforehand.

Yes ! We are working on windows environment. Mmh maybe do you want us to add an os detection condition to make the code works a little bit differently on windows ?

No, it think we can make it work with the same logic for windows and unix, maintaining two sets of logic is just more effort and might introduce bugs. I'd like to avoid that if possible.
I just created the branch run-ci-on-windows inside this repo. Could you please rebase your branch on that so we can properly verify that all tests are passing on windows as well as on unix systems?

This might be ok now for this PR, let us know.
Thanks !

Hi @ludovic-pourrat, this looks good. Thanks again for your contribution :)
I'll merge and release this, please keep in mind that it can take up to a few days until the new release was reviewed and approved by Jetbrains and is visible in the marketplace.