Question: Compilation issues with a lot of Pods

First of all, this is a great plugin and I'm looking forward to using it in all of our projects. Thank you for this!
Unfortunately I'm facing a lot of issues with existing Pods. I'm not exactly sure how did it work before, but there were some frameworks that didn't need import X in the source files of Pods (mainly UIKit and Foundation).
So now there are many Pods that don't compile with this plugin active, because they lack those imports in their source files.
My question is, can we workaround it somehow?
Thanks!

Static framework support on cocoapods 1.4 is totally a disaster. Cocoapods 1.5 beta is released now, and everything works fine.


Add a note in the prerequisites section stating that the example image works only with AMD64 architecture

https://kubernetes.io/docs/tutorials/services/source-ip/
I'm following the tutorial using minikube on M1 Mac. The echoserver image fails with "failed to initialize Lua VM" error and the pod goes into a CrashLoopbackOff state. I couldn't find an echoserver image that supports ARM/M1 Mac. We should add a note or update the tutorial with an image that supports both ARM & AMD64.
➜  ~ kubectl create deployment source-ip-app --image=registry.k8s.io/echoserver:1.4
deployment.apps/source-ip-app created
➜  ~ kubectl get pods
NAME                             READY   STATUS             RESTARTS      AGE
source-ip-app-5dffb8774f-9tg98   0/1     CrashLoopBackOff   2 (23s ago)   42s
➜  ~ kubectl logs source-ip-app-5dffb8774f-9tg98
2023/03/06 04:52:37 [error] 1#1: failed to initialize Lua VM in /etc/nginx/nginx.conf:54
nginx: [error] failed to initialize Lua VM in /etc/nginx/nginx.conf:54

/retitle Using Source IP tutorial doesn't work on AArch64 architecture
(to be a bit more general)

Looks like PR #37383 made a doc change to specify multiarch echoserver image in one tutorial page. Also, there is an issue minikube/15650 talking about use of different echoserver images used in different places.
We might need a clean up to specify working echoserver for AArch64 architecture.
/triage accepted

Let's either:

list AMD64 as a prerequisite, and track a separate issue to support other CPUs
fix this tutorial to work with several CPU architectures, including AMD64 and AArch64

/remove-lifecycle rotten

/remove-lifecycle rotten

Let's either:

list AMD64 as a prerequisite, and track a separate issue to support other CPUs
fix this tutorial to work with several CPU architectures, including AMD64 and AArch64

1 to the first approach. By listing, we can ensure that users who stumble upon this are able to understand that AMD64 is a prerequisite before going further. Fixing the tutorial for ALL architectures will be a bigger endeavour that would be doable over another issue IMO.

/triage accepted

/assign

/assign

Hello @Manish-hr14 i am already working on the issue

Hello @Manish-hr14 i am already working on the issue

ok go on..

Closing this issue as a Note is added by PR #44241
/close


[Application] :

Contact Details
Davide De Marchi
Past Projects
https://www.linkedin.com/in/davide-de-marchi-a257481a4/
Which disaster risk or issue are you addressing?
We are based in southern Italy and our company, SLY (sly.eco) makes a wildfire mitigation platform for public administrations and energy infrastructure operators. We currently detect wildfires with edge-AI gas sensors.
Disaster
WildFires
Where are you from?
Europe / Southern Europe
Readiness Level of a Project
TRL 8 - System Complete and Qualified
Storytelling

[X] I agree to follow this project's will to share my project evolution with documentation and short interviews during the project's deployment

Hello,
Thank you for sharing your impressive proposal! After careful consideration, we've decided to proceed further.
We have also added a few additional requirements and you may choose whether to agree to the following terms and conditions.
Project Showcase

One (1) Hackster Post or Github Post
A video demonstrating a working demo
Two to three (2-3) images documenting the setup and operation

Guarantee fee
Due to customs and postage issues, we have to add a guarantee fee and shipping cost.

Guarantee fee : To protect against potential equipment damage, we require a deposit fee that will vary based on the equipment needed. This deposit is fully refundable upon the return of the product.
Shipping Costs: You will be responsible for covering the international shipping costs.

Welcome your reply, we look forward to collaborating with you on this project.
Feel free to ping me by replying here or on Linkedin.


LobCreatorArgumentPreparedStatementSetter class is duplicated

LobCreatorArgumentPreparedStatementSetter is duplicated in the following locations:

JdbcOAuth2AuthorizationService
JdbcRegisteredClientRepository

It is also duplicated in spring-security:

JdbcOAuth2AuthorizedClientService

Ideally, it would exist in only one location, possibly spring-security-oauth2-core.

This was suggested in discussion on #291.

At the moment, this is no longer the case due to 67e62a2f21dcbbb4534afb0007f6a28fa800c876. In light of that, I'm going to close this for now.


remove early stopping round from lightgbm example notebook

Description
remove early stopping round from lightgbm example notebook since it isn't used
Related Issues
This is a related issue to this minor notebook patch:
https://github.com/microsoft/recommenders/issues/1615
Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[x] This PR is being made to staging branch and not to main branch.

weird, the build seems to be failing.  did I make a mistake?

weird, the build seems to be failing. did I make a mistake?

No, this happens frequently I am afraid. The GitHub host has low resources. I will rerun the jobs.

weird, the build seems to be failing. did I make a mistake?

it's because the default machines we have in GitHub actions have low memory. However, @pradnyeshjoshi is going to start a new set of tests using AzureML #995 that hopefully eliminated this problem and reduced massively the test time

thank you for merging!


Add production build task

Should minify output to dist/openvv.min.js and not include source maps

Add "grunt-contrib-uglify" as devDependency and "uglify" to default task with exit file "dist/openvv.min.js"


Correlation types and MvDistribution

What is the best way to represent a Correlation matrix and a Multivariate Distribution type? The choices here can have an affect on the stable API and how users interact with the package. There are two thoughts:

Create a set of "building block" functions to use to convert/check correlations and simulate data
Create wrapper functions that take care of converting/checking correlation matrices through function arguments

We can incorporate both by providing the low-level building blocks while also shipping the user-friendly wrappers and types (Correlation, MvDistribution, PDCorMat, etc. ).
Comment below on suggested data types and fields, and how they should interact.

Correlation Matrix: Option 1
Uses PDMats.jl as the supertype so it can inherit a set of useful and efficient functions
struct PDCorMat{T<:Real, S<:AbstractMatrix} <: AbstractPDMat{T}
    dim::Int
    mat::S
    type::AbstractCorrelation
    chol::Cholesky{T,S}
end

Correlation Matrix: Option 2
Essentially re-implement PDMat.jl
struct CorMat{T<:Real, S<:AbstractMatrix, C<:AbstractCorrelation} <: AbstractMatrix{T}
    mat::S
    type::C
    chol::Cholesky{T, S}
end

A correlation matrix can stand as its own type, and a MvDist can have a CorMat as a data field. The minimum CorMat structure needed is
struct CorMat{T<:Real, S<:AbstractMatrix} <: AbstractMatrix{T}
    mat::S
    chol::Cholesky{T,S}
end

and is correlation type agnostic.
An MvDist type must have
struct MvDist{T<:Real, C<:AbstractCorrelation}
    margins::Vector{<:UnivariateDistribution}
    target_cor::CorMat{T}
    adjust_cor::CorMat{T}
    type::C
end

If we use option 2 (where cor_type is stored), then we can implement things like
r = cor_randPD(Float32, 10)
R = CorMat(r, Spearman)
convert(CorMat{Float64, Pearson}, R)

Then we can implement
struct MvDist{T<:Real, C<:AbstractCorrelation}
    margins::Vector{<:UnivariateDistribution}
    target_cor::CorMat{T, C}
    adjust_cor::CorMat{T, Pearson}
end

This is functionality that has not been asked for, and is not necessarily necessary. Until there is more demand for functionality, I am closing this issue.


ModuleNotFoundError: No module named 'commons'

🐛 Bug
I receive a ModuleNotFoundError for the module commons when calling infer.py for examples/mms/tts
To Reproduce

I cloned fairseq
did a pip install --editable ./
changed the directory to examples/mms/tts/
called python infer.py --model-dir model/ --wav test.wav --txt "Heute ist ein schöner Tag."

Expected behavior
I expect the wav to be generated.
Environment

fairseq Version (e.g., 1.0 or main): main
PyTorch Version (e.g., 1.0): 2.0.1
OS (e.g., Linux): Windows 10
How you installed fairseq (pip, source): pip from github
Build command you used (if compiling from source):
Python version: 3.10
CUDA/cuDNN version: 11.8
GPU models and configuration:
Any other relevant information:

How to Transcribe Audio to text (Google Colab Version)👇
Step 1: Clone the Fairseq Git Repo
import os

!git clone https://github.com/pytorch/fairseq

# Get the current working directory
current_dir = os.getcwd()

# Create the directory paths
audio_samples_dir = os.path.join(current_dir, "audio_samples")
temp_dir = os.path.join(current_dir, "temp_dir")

# Create the directories if they don't exist
os.makedirs(audio_samples_dir, exist_ok=True)
os.makedirs(temp_dir, exist_ok=True)

# Change current working directory
os.chdir('fairseq')

!pwd

Step 2: Install requirements and build
Be patient, takes some minutes
!pip install --editable ./
Step 3: Install Tensor Board
!pip install tensorboardX
Step 4: Download your preferred model
Un-comment to download any. If you're not using Google Colab pro then use a smaller model to avoid memory outrage
# # MMS-1B:FL102 model - 102 Languages - FLEURS Dataset
# !wget -P ./models_new 'https://dl.fbaipublicfiles.com/mms/asr/mms1b_fl102.pt'

# # MMS-1B:L1107 - 1107 Languages - MMS-lab Dataset
# !wget -P ./models_new 'https://dl.fbaipublicfiles.com/mms/asr/mms1b_l1107.pt'

# MMS-1B-all - 1162 Languages - MMS-lab + FLEURS + CV + VP + MLS
!wget -P ./models_new 'https://dl.fbaipublicfiles.com/mms/asr/mms1b_all.pt'

Step 5: Upload your audio(s)
Create a folder on path '/content/audio_samples/'  and upload your .wav audio files that you need to transcribe
e.g. '/content/audio_samples/small_trim4.wav'
Note: You need to make sure that the audio data you are using has a sample rate of 16000
You can easily do this with FFMPEG like the example below that converts .mp3 file to .wav and fixing the audio sample rate
ffmpeg -i .\small_trim4.mp3 -ar 16000 .\wav_formats\small_trim4.wav

Step 6: Run Inference and transcribe your audio(s)
Takes some time for long audios
import os

os.environ["TMPDIR"] = '/content/temp_dir'
os.environ["PYTHONPATH"] = "."
os.environ["PREFIX"] = "INFER"
os.environ["HYDRA_FULL_ERROR"] = "1"
os.environ["USER"] = "micro"

!python examples/mms/asr/infer/mms_infer.py --model "/content/fairseq/models_new/mms1b_all.pt" --lang "swh" --audio "/content/audio_samples/small_trim4.wav"

After this you'll get your preffered transcription
I have this Collab Example in my GitHub Repo👉 fairseq_meta_mms_Google_Colab_implementation

@padmalcom Please make sure you installed vits and do:PYTHONPATH=$PYTHONPATH:/path/to/vits python infer.py .....

@chevalierNoir Thank you, I was missing vits.


Content API V2: always return a post excerpt (calculated field)

(refs #9866)
The custom_excerpt is a field in the post resource. But it's null by default.
We offer a handlebars helper to return an excerpt based on the html content if the custom_excerpt field is null.
But if you use the Content V2 API directly, you won't get this extra feature.
@ErisDS is working on making this easily possible. What we basically have to do is, we have to extract the logic from our theme helpers and create a set of generic functions, which can be then used in our theme layer (handlebars helpers) and in our Content API V2.
This serializsation will happen in the Content V2 output serializer.
Performance? This might slow down the request a little. The one who works on this task, should make a quick test to get a picture/idea. We might have to use an internal cache, but we'll see.
See:
https://github.com/TryGhost/gatsby-starter-ghost/blob/3ed004e99d9870eaee382f19dcbefaa9c03236f9/src/utils/getPostExcerpt.js#L1

Sorry for re-opening,
I thought I found a bug but it turns out I didn't. Sometimes I think I'm smart but I'm not 🙃


Reduce test for CI

Codecov Report
Patch coverage has no change and project coverage change: -10.69 :warning:

Comparison is base (c348d48) 77.43% compared to head (ed2e850) 66.75%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #901       +/-   ##
===========================================
- Coverage   77.43%   66.75%   -10.69%
===========================================
  Files          18       18
  Lines        8404     8176      -228
===========================================
- Hits         6508     5458     -1050
- Misses       1896     2718      +822

see 12 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat: add support for starknet messages

Fix #368 and https://github.com/snapshot-labs/pitches/issues/83
This PR add support for verifying starknet messages
Depends on

https://github.com/snapshot-labs/snapshot.js/pull/1032

yarn link the branch above to test this PR. SDK need to be updated and merge for the CI tasks to pass
Changes

feat: add support for creating an alias, from a message signed by a starknet address
fix: return a "Network not allowed" error when following a space on an invalid network
fix: Edit signature's type to allow both string and string[] (used by starknet messages). Will save the array as , concatenated string on ipfs
fix: format all addresses before saving to database (using SDK getFormattedAddress: checksum EVM address, and pad/lowercase starknet address)

How to test
See https://github.com/snapshot-labs/snapshot.js/pull/1032

I tried with yarn link in my local. and I get same errors weirdly

I see it is because of dist folder in my local in snapshot.js. when I delete it, it is working now. but types doesn't have types,

There are some type errors weirdly
src/ingestor.ts:52:44 - error TS2339: Property 'isEvmAddress' does not exist on type '{ call: (provider: any, abi: any[], call: any[], options?: any) => Promise<any>; multicall: (network: string, provider: any, abi: any[], calls: any[], options?: any) => Promise<any>; ... 25 more ...; SNAPSHOT_SUBGRAPH_URL: { ...; }; }'.

52     const networkDataType = snapshot.utils.isEvmAddress(req.body.address) ? 'evm' : 'starknet';
                                              ~~~~~~~~~~~~

src/ingestor.ts:119:50 - error TS2554: Expected 1 arguments, but got 2.

119     const id = snapshot.utils.getHash(body.data, body.address);
                                                     ~~~~~~~~~~~~

src/ingestor.ts:213:43 - error TS2339: Property 'getFormattedAddress' does not exist on type '{ call: (provider: any, abi: any[], call: any[], options?: any) => Promise<any>; multicall: (network: string, provider: any, abi: any[], calls: any[], options?: any) => Promise<any>; ... 25 more ...; SNAPSHOT_SUBGRAPH_URL: { ...; }; }'.

213       legacyBody.address = snapshot.utils.getFormattedAddress(legacyBody.address, networkDataType);
                                              ~~~~~~~~~~~~~~~~~~~

src/ingestor.ts:217:40 - error TS2339: Property 'getFormattedAddress' does not exist on type '{ call: (provider: any, abi: any[], call: any[], options?: any) => Promise<any>; multicall: (network: string, provider: any, abi: any[], calls: any[], options?: any) => Promise<any>; ... 25 more ...; SNAPSHOT_SUBGRAPH_URL: { ...; }; }'.

217       legacyBody.from = snapshot.utils.getFormattedAddress(legacyBody.from, networkDataType);

Have you updated to latest branch ?

It is because of this https://github.com/snapshot-labs/snapshot-sequencer/pull/400#issuecomment-2218098139
I had previously built dist, but now there are no types defined for utils some how

I see it is because of dist folder in my local in snapshot.js. when I delete it, it is working now. but types doesn't have types,
Before:

Fixed. Seems like the new es6 version is putting the types file in /src instead of root


Issue with "is" check's "unnecessary condition: expression will always evaluate to 'true'"

Description:
We have currently disallowed always true is checks.
However in some scenarios this fails compilation incorrectly.
For example, consider the following scenario where a stamping is done to change the type:
public function main() {
    map<string|int> m = { one: 1 };
    map<string|int|float> m2 = map<string|int|float>.stamp(m);

    if (m is map<string|int>) {
        // this should be false since the type of `m` is changed!
    }
}

Currently this fails with
$ ballerina run is_test.bal
error: .::is_test.bal:5:9: unnecessary condition: expression will always evaluate to 'true'

This is wrong since the condition will in fact be false due to stamping!

Stamp can also fail at certain scenarios. In that case the type of m will still be map<string|int>.
Also, one can stamp within an if block, then we can't determine the exact type of m.
Therefore, I think we can mark this as an improvement, and may requires some dataflow analysis to determine the type.

This should no longer be an issue anyway, since we do not support changing the type of a value itself now (stamping).


Fixing cucumber test for build pipeline

Simple cucumber fix - making a PR to test the build in the dev cluster.

NOTE: DON'T MERGE UNTIL THIS PASSES THE DEV CLUSTER CHECKS

This can be merged now


Userdata changes for unencrypted guests

These changes enable running MV instances (launched from the usual 'creator' images/AMIs with unencrypted guest roots attached. Such instances must have 'solo_mode: metavisor' in the userdata; they may also need Yeti endpoints and Yeti CA certs included as well.
Adds (hidden) --unencrypted-guest arg to make-user-data to allow MV instances to be launched with unencrypted guest root disks.
Allow brkt env and CA certs to be included in userdata for instances in 'metavisor' mode.
Ensure the solo_mode is always included in userdata (only new for 'metavisor' mode.
Adapted unit tests to these new behaviors.

Testing:

Ran updated unit tests.
Encrypted instance in GCE.
Generated userdata manually for various CLI inputs.

PTAL


Enable software metrics

I would like to propose software metrics for the Language Server. Possibly this is not the right place, then I apologize. Maybe I didn't understand something technical correctly, then I apologize for that as well.
Jim Wanner, the author of one of my favorite tools has ended his career as a software developer. With SourceMonitor, I was able to view various software metrics about source code. This is a great support to write better code. It is also a great help for restructuring and improving code. Unfortunately, there will be no further development for this tool.
So I had the idea that this could be a topic for the Language Server. The Language Server is available for many programming languages. Then no programming language specific plugin would be necessary, all languages could profit from a uniform interface.
A few metrics are easily implemented: The number of lines in the file, the number of lines of code, the number of comment lines, ... It gets more elaborate with the McCabe metric (cyclomatic complexity) or the branch depth. It is even more complex if this is to be done not only for a single file, but for a workspace. Then there are the average values and a maximum in addition to the previous values.
From my point of view this would be a great feature. Since I use VSCode very often, this would be enormously helpful in my daily work. I use VSCode with Pyhton, C/C++, C#, JavaScript, HTML and CSS, sometimes for Ruby and others.
What do you think about this, would it be possible?
Regards
Jochen

@ThirtySomething can you explain why this can't be implemented using the generic CodeLens request (see https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_codeLens) I do know that some metric tools for VS Code use that approach.

Hello @dbaeumer ,
thank you for your comment. I lack knowledge about the architecture/parts that make up VSCode.
My guess was that the desired function could be a part of the language server. As far as I understand, the server provides all language specific functions. I also assume that the calculation of code metrics could be somehow language specific. For example, there is no switch/case statement in Python, but there is for C/C++, C# and Java. Each language has its own syntactic and lexical properties.
My idea was to build some kind of interface for metrics into the language server to provide the information for each client. Because each language has its own language server, parts of the code could possibly be reused to compute the metrics as well. The language server maintainer(s) could add this metrics information with less effort.
If I am informed correctly, for example Eclipse also uses the language server. Is Eclipse also able to use the generic request you suggest? If so, that could be a good way to provide these metrics.

I am not sure about Eclipse. You need to ask them whether they support CodeLens. But I think there is a high change that they do.

Eclipse IDE integration for LSP (aka Eclipse LSP4E project) has had support for codelenses for more than 3 years now. See http://www.eclipse.org/community/eclipse_newsletter/2018/june/images/let_example.png for instance of how this looks.

Note that LSP isn't really intended to spec the content of the various language assistance, but instead to specify the interactions and workflow that do happen when providing assistance for file edition.
It seems to me that what you are willing to discuss is about the content; and that there are already interactions existing in LSP to cover that: complexity can be shows as codelens, as hover information or as diagnostics... So LSP seems complete for your case and it becomes just a matter for you to build or extend a language server to add the information you want where you think it fits best.
IMO, this issue can be closed.

@mickaelistria  @dbaeumer Thank you for the provided informations. What I understand is:

The requested feature is not part of the language server protocol.
The feature should be implemented at the language server itself.
To visualize the software metrics on client side, e. g. in Visual Studio Code, many different ways are possible. A generic CodeLens request could be one of the ways, another might be hover information or diagnostics like @mickaelistria proposes.

So I have to request the feature in the vscode-cpptools - the language server implementation for C/C++? Maybe there's again a misunderstanding from my side - in this case I'll be happy about any hint to get me in the right direction. Then this issue can be closed - I agree to @mickaelistria .

I've startet a discussion here and opened an issue here.


Proper HTTP/1.1 parser

Parsing HTTP/1.1 is substantially trickier than parsing HTTP/2. I'm happy with my HTTP/2 parsing code, but I'm not even close to happy with the HTTP/1.1 parsing code in #92 (that will eventually make it into master).
I think the ad-hoc parsing that's there right now is totally acceptable for an initial release, but as time passes we should really tighten it up.
There are some options here:

Handwrite a parser in pure-Python. This idea terrifies me: the HTTPHeaderMap already has some unfortunate performance problems in CPython, and writing a parser that has to individually examine every byte of the HTTP header is going to be terribly slow in CPython.
As (1), but use zero buffer to speed stuff up. It's not clear to me what performance improvement this would give me (particularly over using memoryviews, which I already use) over (1).
Embed a parser written in another language that I distribute with the code. An obvious choice is picohttpparser. This is likely to be the fastest approach to the problem.

In an ideal world I'd like to do (3). However, the idea of distributing C code along with my library gives me pause. On Windows and OS X it should be not too terrible, because I can presumably bundle the dynamic library with a wheel. With Linux this becomes much more of an extraordinary pain in the ass, because I need to get the code to build at install time.
Additionally, it causes me to incur much larger development overheads. I'll need Windows boxes to build wheels for Windows, OS X boxes to build wheels for OS X...it's all kind of a nightmare.

Actually, for Linux it might not be too bad, because picohttpparser doesn't have to link against Python itself. That means the .so should be fairly platform independent (he said, hopefully).
I think the way to think about this is to see if I can build a good cffi-based Python wrapper for picohttpparser. If I can, then I can bring that in as a dependency and solve this problem neatly.

Btw, if @dstufft could weigh in with insights about packaging this stuff that'd be really helpful. I already know that @dstufft wants me to do (3) in some form. =D

Some notes from an extremely helpful conversation with @reaperhulk and @dstufft (so I don't forget!):
<lukasa> What's the recommended story for bundling a .so with a python package, and calling into it with CFFI?
<lukasa> Wheels for Win and OS X, then src for Linux?
<Alex_Gaynor> lukasa: works fine; for cryptography we ship wheels for windows which statistically link openssl
<lukasa> Mm, I glanced through what cryptography was doing
<lukasa> Couldn't entirely convince myself that it worked because some of the magic is done on Jenkins
<Alex_Gaynor> reaperhulk: can tell you what jenkins does.
<Alex_Gaynor> I'm pretty sure it's just `pip wheel cryptography` though
<reaperhulk> lukasa: Yeah we just pip wheel cryptography
<reaperhulk> The entirety of the jenkins batch file is: https://gist.github.com/reaperhulk/a580c72e58f99e99f254
<reaperhulk> there's also one for windows64 but that's just to point it at the 64-bit binaries/libraries
<lukasa> Is pip install wheel taking care of actually building OpenSSL here, or do you have a separate job for that?
<lukasa> Oh, nvm
<reaperhulk> we have openssl prebuilt on the builders
<lukasa> Why would you be building it
<lukasa> =P
<reaperhulk> yep
<lukasa> However, pip install wheel/pip wheel do bundle the .dll?
<reaperhulk> We statically link it so there's no bundling required
<lukasa> Ah, that makes more sense
<lukasa> Actually makes way more sense, that's a far better plan
<lukasa> Ok, time to go back to your CFFI invocation and work out how you do that. ;)
<reaperhulk> It works pretty well on Windows, although it does require us to ship a new cryptography whenever openssl gets revv'd
<lukasa> Thanks! Would like to distribute a C library with my Python module without it requiring everyone to compile everything all the time
<reaperhulk> incidentally if you need a wheel job for windows we can potentially set it up on our jenkins. It's a pain to maintain this infra so you're welcome to piggyback on it
<lukasa> reaperhulk: Thanks! Won't happen in the next few days or anything, but you might come to regret that offer. ;)
<reaperhulk> haha, well we build cffi wheels already
<reaperhulk> https://jenkins.cryptography.io :)
<lukasa> Shiny
<lukasa> So, follow-on question
<lukasa> Can that static-link approach work on Linux as well? Or is there some pain there I'm not familiar with?
<dstufft> it works on Linux-ish, you still have to link to Python, and Python might have different API incompatabilities
<dstufft> but PyPI doesn't allow linux wheel uploads
<reaperhulk> so dstufft's got some thoughts there, but in general you'll have to statically link everything so you're going to pull in glibc and such (and if you're on a distro that uses a different libc is that okay) + python linking
<reaperhulk> oop dstufft already responded
<lukasa> Hmm
<lukasa> So, can I distribute the .c file and get that compiled at install time with an sdist?
<lukasa> (This is a whole world of Python packaging I've never had to think about before)
<dstufft> yea
<dstufft> https://caremad.io/2014/11/distributing-a-cffi-project/
<lukasa> Shiny

This makes it seem like building a python wrapper for picohttpparser as a PyPI module and then depending on that might actually work.

In a hypothetical world where hyper ends up in urllib3, how much difficulty does a cffi dependency represent.

@dstufft In a hypothetical world where hyper ends up in urllib3, how much difficulty does a cffi dependency represent for pip?

Ideally you'd have a pure Python fallback, pip can't have a C dependency because of the bootstrapping problem. I recognize that's more work but an optional C dependency is most likely the best way to handle it, not just for pip but for anyone trying to use requests in a situation where C deps are less ideal.

On Mar 14, 2015, at 10:44 AM, Cory Benfield<EMAIL_ADDRESS>wrote:
@dstufft In a hypothetical world where hyper ends up in urllib3, how much difficulty does a cffi dependency represent for pip?
—
Reply to this email directly or view it on GitHub.

Ok, this is done and merged into #92: hyper will use pycohttpparser if it's available, and if not it'll fall back to using the pure-Python bundled version.


Refactored Syncada SFTP client config

Description
This PR refactors the Syncada SFTP client config on the mb-MB-6905-service-object-to-read-files-from-syncada-sftp-server branch to more align with how we have handled third-party connections in other cases.
Reviewer Notes

I had to put a lint suppression (#nosec G101) in because of a false positive around a variable name.  We have to do this in other places too.

Setup
See notes on base branch.

Warnings

:warning:

It looks like you are attempting to bypass a linter rule, which is not within
security compliance rules.
** Contains prohibited linter override "#nosec". **
Please remove the bypass code and address the underlying issue. cc: @transcom/Truss-Pamplemoose

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 82aba7daac959165955389aac5730d437cbcd356


Example/Usage Code

Hello,
I was wondering if you had available any snippets of usage/example code for this package.  I'm hoping to integrate KissMetrics into a node.js app, with some events needing to be tracked outside of the browser.  Any help is greatly appreciated.
Thanks

Hello,
It there any way to call identify in this module?

@antonisa90 no ; each call to the library is meant to be accompanied by the identifying information of the user to which we're attaching the event.


use from_queue options in Worker.enqueue

Given the following worker:
class MyWorker
  include Sneakers::Worker
  from_queue 'swag', exchange: 'other'
end

MyWorker.enqueue 'yolo' would now publish the message to sneakers (the default) exchange. The worker will never pick it up.
This patch fixes this behaviour. Calling MyWorker.enqueue 'yolo' will publish a message to an exchange called other.

:+1: I agree this should be done; however, the publishing aspect of this is odd in the general use case.
Not sure if the worker's should have their own connections to each exchange or share them among workers; or this should be removed and made into its own concern.
e.g. there is 5 workers that use the same exchange, but different queues.
or
e.g. there is 5 workers that use a set of exchanges, but the same queue.
@jondot Both of these scenarios seem extremely odd to me in sneakers right now, maybe some insight into design decisions? Or maybe you have opinions on the way to move forward?

@AlexRiedler you mention a valid concern. I think, for the publisher, the problem @luxflux is solving is of the default. It's removing the element of surprise - which is always a good thing.
As a design point of view, publishing was always a lower concern for Sneakers (since the crux of the work is for consuming messages), so that typically I've published from Go, Node, and Rails apps (as so other Sneakers users).
So all in all I'm in favor of eliminating the element of surprise - what do you think?

@jondot I agree, lets push this through :)

Has been a while... How can I help to have this merged?

This change looks good but I really wonder why :exchange is suddenly an option on the queue DSL method. It should be a separate method in my opinion.

Since I use sneakers, :exchange has always been in the from_queue method. This pull request does not add this functionality, it just ensures it is also taken into account for publishing.

Yes, we've always been able to pass any options we can pass to Sneakers.configure to from_queue include exchange_options. I don't see the issue with making a worker's configuration of subscription and publishing consistent. That said, I do think we need to rethink how what exchanges mean at the endpoint-level. We one endpoint really be subscribing or publishing messages to multiple exchanges?

@luxflux fair enough. Then looks like a useful change to me. @jondot WDYT?

I agree. let's merge this in!
Thanks :+1:  :+1:

Thanks a lot!


#371 better encoding support

I just explain problem first.
I got situation where irc server sends both utf8 and iso-8859-1 messages. And i want both to be human readable. Problem is, if i use utf8, i cant see or recover iso-8859-1 messages. But if i use iso-8859-1 as encoding, i cant see utf8 messages but i can recover them.  Using iso-8859-1 makes other problem, if outgoing messages are coded on iso-8859-1, you cant send utf8 text correctly like Iñtërnâtiônàlizætiøn☃💩'
So, to fix it, you need different encodings to irc incoming messages and outgoing messages. And top of that, you need to get rid Mojibake, miscoded characters.  My solution is backward compatible encoding string in irc-framework configuration. So you can configure it in lounge for every network you connect.
utf8- normal way
iso-8859-1/utf8- incoming messages are coded in iso-8859-1, outgoing in utf8
iso-8859-1:auto- incoming and outgoing is iso-8859-1 and gets rid of mojibikes on incoming messages
iso-8859-1:auto/utf8- incoming messags are coded iso-8859-1 and gets rid of mojibikes, outgoing messages are coded utf8
autocorrect reqursively makes text human readable. That means certain text combinations, like Ã¤ automatcly will be converted to ä and text will lose that information. For humans its good, but not for computers.
;tldr made thing that fixes utf8 - iso-8859-1 Mojibake characters in node.

I will close this PR for now as it won't work without irc-fw changes, and seeing the discussion doesn't make it seem like it will happen any time soon.


Designer Incompatible with Extensions that reference SciLexer.dll

I don't believe there is anything that can be done with this other than a note in the Wiki, but the designer will fail to add the Scintilla control in design mode with a dll initialization failure if you happen to be running an extension that uses SciLexer.dll.  I found two extensions that use it: ActiveAssistX by WholeTomato and Object Exporter.  Disabling 'Object Exporter' seems to allow it to work (I didn't test ActiveAssistX intensively to see if something breaks there).  Hopefully this can assist others that experienced the same issue.
To locate potentially problematic extensions, check in your local AppData\Local\Microsoft\VisualStudio\14.0\Extensions folder.  A simple dir command "dir scilexer.dll /s" will help you find these problematic extensions.

Interesting. Good to know that.

Is there any workaround to run multiple extensions using SciLexer.dll?


[BUG] DNS failure after upgrading to fedora 41

General information

OS: Linux
Hypervisor: KVM
Did you run crc setup before starting it (Yes/No)? Yes
Running CRC on: Laptop

CRC version
WARN A new version (2.44.0) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/2.44.0/crc-linux-amd64.tar.xz
CRC version: 2.43.0+268795
OpenShift version: 4.17.1
MicroShift version: 4.17.1

CRC status
CRC VM:          Stopped
OpenShift:       Stopped (v4.17.1)
RAM Usage:       0B of 0B
Disk Usage:      0B of 0B (Inside the CRC VM)
Cache Usage:     46.53GB
Cache Directory: /home/thobson/.crc/cache

CRC config
- consent-telemetry                     : yes
- cpus                                  : 8
- disk-size                             : 64
- memory                                : 24000

Host Operating System
NAME="Fedora Linux"
VERSION="41 (Workstation Edition)"
RELEASE_TYPE=stable
ID=fedora
VERSION_ID=41
VERSION_CODENAME=""
PLATFORM_ID="platform:f41"
PRETTY_NAME="Fedora Linux 41 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:41"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f41/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=41
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=41
SUPPORT_END=2025-12-15
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Steps to reproduce

After upgrade to Fedora 41
Start CRC
Note DNS failure
Note Pull Secret Save Failure

Expected
CRC starts without errors
Actual
CRC starts with errors.
New pods experience imagePullBackOff
Logs
Before gather the logs try following if that fix your issue
Done
output of crc start --log-level debug

This is related to a network issue, but we have not been able to reproduce this. It might be an issue with systemd-resolved, but we can not be sure yet. Too little information to go by.
As an alternative, you can use the usermode network-mode.

Using network-mode fixes the issues for me.
If anyone is interested, here are the commands to fix:
❯ crc config view |grep network

❯ crc config set network-mode user
Network mode changed. Please run `crc cleanup` and `crc setup`.

❯ crc config view |grep network
- network-mode                          : user

❯ crc config set host-network-access true
Changes to configuration property 'host-network-access' are only applied during 'crc setup'.
Please run 'crc cleanup' followed by 'crc setup' for this configuration to take effect.

❯ crc config view |grep network
- host-network-access                   : true
- network-mode                          : user

❯ crc cleanup

btw, here is some more info if it helps dev(s) reproduce:
NAME="Fedora Linux"
VERSION="41 (Workstation Edition)"
RELEASE_TYPE=stable
ID=fedora
VERSION_ID=41
VERSION_CODENAME=""
PLATFORM_ID="platform:f41"
PRETTY_NAME="Fedora Linux 41 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:41"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f41/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=41
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=41
SUPPORT_END=2025-12-15
VARIANT="Workstation Edition"
VARIANT_ID=workstation

❯ rpm -qa | egrep -i 'resolved|dns|udev|kernel'
libmicrodns-0.2.0-10.fc41.x86_64
kernel-srpm-macros-1.0-24.fc41.noarch
kernel-headers-6.11.3-300.fc41.x86_64
libgudev-238-6.fc41.x86_64
kernel-modules-core-6.11.5-300.fc41.x86_64
kernel-core-6.11.5-300.fc41.x86_64
nss-mdns-0.15.1-12.fc41.x86_64
kernel-modules-6.11.5-300.fc41.x86_64
kernel-6.11.5-300.fc41.x86_64
dnsmasq-2.90-3.fc41.x86_64
mod_dnssd-0.6-32.fc41.x86_64
kernel-devel-6.11.5-300.fc41.x86_64
libreport-plugin-kerneloops-2.17.15-3.fc41.x86_64
python3-pyudev-0.24.3-3.fc41.noarch
abrt-addon-kerneloops-2.17.6-2.fc41.x86_64
system-config-printer-udev-1.5.18-11.fc41.x86_64
kernel-modules-extra-6.11.5-300.fc41.x86_64
kernel-modules-core-6.11.7-300.fc41.x86_64
kernel-core-6.11.7-300.fc41.x86_64
kernel-modules-6.11.7-300.fc41.x86_64
aardvark-dns-1.13.1-1.fc41.x86_64
kernel-modules-extra-6.11.7-300.fc41.x86_64
kernel-6.11.7-300.fc41.x86_64
kernel-devel-6.11.7-300.fc41.x86_64
systemd-udev-256.8-1.fc41.x86_64
systemd-resolved-256.8-1.fc41.x86_64
kernel-modules-core-6.11.8-300.fc41.x86_64
kernel-core-6.11.8-300.fc41.x86_64
kernel-modules-6.11.8-300.fc41.x86_64
kernel-tools-libs-6.11.8-300.fc41.x86_64
kernel-tools-6.11.8-300.fc41.x86_64
kernel-modules-extra-6.11.8-300.fc41.x86_64
kernel-6.11.8-300.fc41.x86_64
kernel-devel-6.11.8-300.fc41.x86_64

❯ uname -a
Linux 6.11.8-300.fc41.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Nov 14 20:37:39 UTC 2024 x86_64 GNU/Linux

❯ crc version
CRC version: 2.44.0+facc77
OpenShift version: 4.17.3
MicroShift version: 4.17.3

The OP switched between VPN use and experienced issues with DNS not being resolved inside the VM. The preflight for curl quay.io failed. Though it was not obvious what caused this.

@mscherer is there any specific reason of using docker instead podman (which is by default)? Any missing feature from podman side?


Wordpress-like image manager

This would make image usage easier. Have a store where we can upload images, and then reference them from events, emails, etc. (we could also upload inline)
This will be useful for things such as presets where restoring an unuploaded image is impossible.

This has been replaced by the AJAX uploader now used for themes.
It does need to be updated so it can be used on ModelForms and in custom properties.

This can now be used as a normal field


add muon test files and fix plot_muon_event call

adding mst-fc and sst-1m muon test files at 100% optical efficiency. Minor fix to call to plot_muon_event

ctapipe-extra is a separate package, so you should not commit files in it to the ctapipe repo.  You have to check out ctapipe-extra's git repo separately and modify it.  In fact there should not be a ctapipe-extra subdirectory in ctapipe (it was removed several versions ago).
So unfortunately I cannot merge this in since it would add a fantom ctapipe-extra subdir with data files in it.

in fact I'll just make this change manually since I'm cleaning up the code already

OK - the minor fix was just removing one argument in the call to plot_muon_event .
Things got messy here - added the muon files to ctapipe-extra separate repository now.


Fix Permissions

All files and directories in /opt/zookeeper are being installed as root. This updates them to use the zookeeper user.
Files being owned by root is causing the following issue in https://github.com/evertrue/exhibitor-cookbook
2017-02-08_11:07:50.94238 java.io.FileNotFoundException: /opt/zookeeper-3.4.9/conf/zoo.cfg (Permission denied)
2017-02-08_11:07:50.94238       at java.io.FileOutputStream.open(Native Method)
2017-02-08_11:07:50.94239       at java.io.FileOutputStream.<init>(FileOutputStream.java:221)
2017-02-08_11:07:50.94239       at java.io.FileOutputStream.<init>(FileOutputStream.java:171)
2017-02-08_11:07:50.94240       at com.netflix.exhibitor.core.processes.StandardProcessOperations.prepConfigFile(StandardProcessOperations.java:167)
2017-02-08_11:07:50.94240       at com.netflix.exhibitor.core.processes.StandardProcessOperations.startInstance(StandardProcessOperations.java:109)
2017-02-08_11:07:50.94240       at com.netflix.exhibitor.core.state.KillRunningInstance.completed(KillRunningInstance.java:41)
2017-02-08_11:07:50.94240       at com.netflix.exhibitor.core.activity.ActivityQueue$1.run(ActivityQueue.java:127)
2017-02-08_11:07:50.94240       at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
2017-02-08_11:07:50.94240       at java.util.concurrent.FutureTask.run(FutureTask.java:262)
2017-02-08_11:07:50.94240       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
2017-02-08_11:07:50.94241       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
2017-02-08_11:07:50.94241       at java.lang.Thread.run(Thread.java:745)

@davidsayers oh my goodness, thanks for chasing that down!

@davidsayers hm. The exhibitor cookbook doesn’t use the zookeeper_config resource. How does this solve this?

It looked to me like the exhibitor cookbook will need to use zookeeper_config. Currently there is an issue in where java_opts are being ignored.

@davidsayers it doesn’t use zookeeper_config on purpose; Exhibitor handles configuring ZooKeeper.
That said, you’re right; that’s tricky. Once upon a time, this & the exhibitor cookbook were tightly coupled.

@davidsayers this is tricky for me to help out with; I’m not actually using ZooKeeper at my current job. @eherot is still using it at EverTrue. Doing my best to keep contributing to this cookbook!
That said, I think that Exhibitor’s --defaultconfig takes over the zoo.cfg. So that covers that portion.
Perhaps the zookeeper-env.sh file needs to be part of the zookeeper resource, and not zookeeper_config?

What things are you trying to configure via the JVMFLAGS (which corresponds to the java_opts property of zookeeper_config)?

I'm not sure if it is the way I will go but I was testing Zookeeper authentication as described here
https://www.cloudera.com/documentation/enterprise/5-6-x/topics/cdh_sg_zookeeper_security.html
This requires a JVM settings.

What about setting Exhibitor’s java.env config value? It’s very lightly described in the Exhibitor wiki Config UI docs.
Based on what I can tell, you’d populate that config with what you want the contents of a Java environment file to contain.
So if you want that to pass along JVMFLAGS to ZooKeeper, I think you’d do something like:
override['exhibitor']['config']['java-environment'] = "JVMFLAGS=#{your_flags}"

That is entirely guesswork, but give it a go in your wrapper cookbook!

I’ve got to get back to other things now unfortunately. I’ll ship this ownership fix though.

I did try java.env but it didn't work. Maybe I didn't spend enough time on it. Will try again.
If that ends up being the recommended approach, https://github.com/evertrue/exhibitor-cookbook/blob/master/recipes/default.rb#L25 should be removed as it is confusing.

@davidsayers good point; that is confusing. I’ll nix that, since it doesn’t have any effect anymore (it used to, long ago).


[WB-6792] RDKit Molecules

https://wandb.atlassian.net/browse/WB-6792
Description
In this PR:

wandb.Molecule.from_smiles method to initialize wandb.Molecule from SMILES strings.
wandb.Molecule.from_rdkit method to initialize wandb.Molecule from rdkit.Chem.rdchem.Mol objects and a number of rdkit-supported file types ("mol", "mol2", "pdb", "png", "tpl", "sdf"). Kudos to @tssweeney for the great idea!
Added support of wandb.Image initialization from the same input types for rendering 2D representations of the molecules (wandb.Image.from_smiles and wandb.Image.from_rdkit). Kudos to @dannygoldstein for this wonderful idea!

Notes:

When converting from a SMILES string to rdkit.Chem.rdchem.Mol object, by default we check if the molecule is chemically reasonable by the rdkit's definition. This could be disabled by passing sanitize=False to the wandb.Molecule.from_smiles method.
Converting molecules to rdkit.Chem.rdchem.Mol objects with 3D coordinates is an expensive operation that may take a long time for complicated molecules. This can be disabled by passing convert_to_3d_and_optimize=False to the wandb.Molecule.from_smiles and wandb.Molecule.from_rdkit constructors.

Testing

Added tests to test_data_types.py
The following code snippet produces expected output (see screenshot below)

import datetime
import pandas as pd
from rdkit import Chem
from rdkit.Chem import AllChem, Draw
import wandb

# create wandb.Molecule and wandb.Image objects from SMILES strings
data = [
    {
        "name": "ciprofloxacin",
        "smiles": "C1CC1N2C=C(C(=O)C3=CC(=C(C=C32)N4CCNCC4)F)C(=O)O",
        "molecule": None,
        "molecule_2d": None,
    },
    {
        "name": "acetaminophen",
        "smiles": "CC(=O)Nc1ccc(O)cc1",
        "molecule": None,
        "molecule_2d": None,
    },
]
for substance in data:
    substance["molecule"] = wandb.Molecule.from_smiles(substance["smiles"])
    substance["molecule_2d"] = wandb.Image.from_smiles(substance["smiles"])

# create wandb.Molecule object from an rdkit.Chem.rdchem.Mol object
green_fluorescent_protein = Chem.rdmolfiles.MolFromPDBFile("data/2b3p.pdb")
green_fluorescent_protein_smiles = Chem.MolToSmiles(green_fluorescent_protein)
data.append(
    {
        "name": "green fluorescent protein",
        "smiles": green_fluorescent_protein_smiles,
        "molecule": wandb.Molecule.from_rdkit(
            green_fluorescent_protein,
            convert_to_3d_and_optimize=False
        ),
    }
)

wandb.init(
    project="rdkit",
    name=datetime.datetime.now().strftime("%Y%m%d_%H%M%S"),
)

dataframe = pd.DataFrame.from_records(data)
table = wandb.Table(dataframe=dataframe)
wandb.log(
    {
        "table": table,
        "molecules": [substance.get("molecule") for substance in data],
    }
)

Release Notes
Below, please enter user-facing release notes as one or more bullet points.
If your change is not user-visible, write NO RELEASE NOTES instead, with no bullet points.
------------- BEGIN RELEASE NOTES ------------------
Added support of wandb.Molecule and wandb.Image initialization from SMILES strings, rdkit.Chem.rdchem.Mol objects, and files in rdkit-supported formats.
------------- END RELEASE NOTES --------------------

For future reference, rdkit-js can render 2D representations of molecules: https://unpkg.com/<EMAIL_ADDRESS>

A note on 1799b77: we decided to remove the Image.from_rdkit and Image.from_smiles methods and instead expand the relevant documentation demonstrating how to log 2D representations of molecules to wandb with rdkit with the already available tools.

@tssweeney @raubitsj @kptkin as discussed, I removed the Image methods for the sake of a clean API, so this should be ready to go in.

Another screen capture for a Colab demo.


will there any recent update?

So sorry, I'm working for a new app which fetch data with selector and regular expression from most of manga websites, like H-Viewer, this project will not be updated until any bugfix.


Windows support?

any luck to add windows binary?

Sorry, I used to compile the Windows version, but many users found problems when testing. The log is normal, but the browser cannot access it.
I have no experience in Windows adaptation, so I removed the windows binary.

Hey guys, hello, are you from the original rancher team ? or not?
Is this project's source available? if it is based on HTML, js, ... I think we can make a way like Lens and OpenLens to use Electron for cross-platform builds . Can I contribute?

Yes, I am from Rancher, and based in China.
Those js and html files are embedded into the Golang binary.
Golang supports cross-platform for Windows binary, but after running, I cannot access the web service. I'm not a Windows expert, and don't have a Windows usage scenario, so didn't take the time to troubleshoot it.
Any references in this project are public and free to use.

两位大佬，我在阿里云的服务器上用make dev 编译时，用zypper下载安装包的速度很慢，并且还出错，

请问如何解决下载速度慢，以及编译错误的问题@orangedeng @niusmallnan

Try to use HongKong region machine to compile this project. Github access is not reliable in Mainland China. zypper install should be fine.

Already supported windows binary in v0.4.0. Closing this issue


Fix/controller auth method

adds suport for auth method authentication in the pkp-base forwarding controllerAuthMethod to the pkpSign endpoints. changes the auth checks to use a filter to make sure only a single method is used when forwarding to the nodes.

Makes sense to me!


Missing dependency in check_driver.sh for Intel Graphics on 20.04

Describe the bug
20.04 running on integrated Intel graphics appears to require the intel-media-va-driver-non-free package, but this is not addressed by the script.
System

OS: Ubuntu
OS Version: 20.04
Environment: Gnome
Application: AppImage
Application Version: 4.14.16

Configuration

The user is in input group: yes
The environment uses Xorg: yes
VA API detects H264 ? And H265: yes

To Reproduce
Steps to reproduce the behavior:

Install 20.04 on an Intel CPU with no discrete graphics (integrated only)
Run the scripts in this repo
Try to launch Shadow
See error L-100

Workaround
sudo apt install intel-media-va-driver-non-free

I had the same issue, and the workaroud fix it ! (thanks @bradloh ).
If it can help to fix the issue, here is my system report https://nicolasguilloux.eu/hostbin/564211515

hehe glad you got it work, it's not a workaround, but package required to install on 20.04, it's unrelated to shadow but the linux VAAPI drivers required :p

Hi @aarnoud I see you closed this issue. Could this check be added to the check_driver.sh as stated in this issue ? It could help other to troubleshoot this problem (my future self is one of them ! :p )


Go to next/previous sibling not working

Go to next and previous sibling (shift + j / shift + k) is no longer working in logseq 0.10.6 via snap on Ubuntu 23.10, vim-shortcuts v0.1.22.
I've recently migrated my system from Fedora to Ubuntu and just noticed these shortcuts no longer work. Other shortcuts seem to work fine. I loaded logseq with the Dev Tools console and I see messages about the shortcuts being registered. For example:
:shortcut/register-shortcut [:shortcut.handler/global-non-editing-only :plugin.logseq-vim-shortcuts/vim-shortcut-next-sibling-0 {:fn #object[Function], :desc nil, :key vim-shortcut-next-sibling-0, :type $palette$, :binding (shift+j), :label Go to next sibling, :cmd {:id :plugin.logseq-vim-shortcuts/vim-shortcut-next-sibling-0, :desc Go to next sibling, :shortcut shift+j, :handler-id :shortcut.handler/global-non-editing-only, :action #object[Function]}, :keybinding {:mode non-editing, :binding shift+j}, :extras nil}]

However, when I try to use the shortcut (eg. shift + j), I get the following error:
index.e8f2ed0c.js:1018 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'uuid')
    at g6 (index.e8f2ed0c.js:1018:19313)
    at async qr.<anonymous> (index.e8f2ed0c.js:1018:19793)

I'm happy to help debug. I noticed that @Weiming-Hu recently commented on #41 about this issue. Maybe related?
Thank you so much for this amazing extension!

Thanks for reporting. Can you show me where to find the error message? I want to confirm whether we had the same errors.

 Once in Developer Tools, I opened the Console tab to see if anything was being logged by the plugin. I also disabled all other plugins to avoid extra logs.
This process is well described in this logseq forum discussion and in the Chrome Dev Tools documentation. Hope this helps.

Thank you for the instructions. I was able to capture the error message. It looks like we are hitting the same error. Details below.
index.e8f2ed0c.js:1018 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'uuid')
    at F6 (index.e8f2ed0c.js:1018:22219)
    at async qr.<anonymous> (index.e8f2ed0c.js:1018:22674)

It looks like this issue was introduced in version 0.1.21 of this plugin with commit 707eca6. I was able to install version 0.1.20 of the plugin and shift+j and shift+k work as expected.
To install previous versions of this plugin I used the logseq feature Install plugins from plugins.edn, which is described in the docs.
Content of my .logseq/config/plugins.edn file:
{
:logseq-plugin-vim-shortcuts {:version "v0.1.20", :repo "vipzhicheng/logseq-plugin-vim-shortcuts", :effect true, :theme false}
}

Confirm that 0.1.20 works for me. But always happy to test further if needed.


yq: failed traversing anchors in version.yaml

Description of problem
Recently, initrd-related CI are failing frequently.
http://jenkins.katacontainers.io/job/kata-containers-runtime-ubuntu-18-04-PR-initrd/2843/
INFO: Image to generate: kata-containers-*default-initrd-name-*default-initrd-version-osbuilder-7526f49-agent-36b37f6.initrd
......
./rootfs-builder/rootfs.sh: line 280: /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR-initrd/go/src/github.com/kata-containers/osbuilder/rootfs-builder/*default-initrd-name/config.sh: No such file or directory
Failed at 120: sudo -E AGENT_INIT="${AGENT_INIT}" AGENT_VERSION="${agent_commit}" GOPATH="$GOPATH" USE_DOCKER=true OS_VERSION=${os_version} ./rootfs-builder/rootfs.sh "${distro}"
Failed at 26: "${cidir}/install_kata_image.sh" "${tag}"

Debugging on the above output, the cause may come from that yq failed reading values from assets.initrd.architecture.$arch.name
Based on the latest yq spec, the read command could print out the anchors of a document and can also traverse them.
But when anchor refers to an scalar (string, integer etc), the latest yq could not traverse it.
e.g.
$ yq read versions.yaml "assets.initrd.architecture.ppc64le.name"
*default-initrd-name

@Pennyzct also see https://github.com/kata-containers/tests/pull/2275
/cc @chavafg @GabyCT

For ref, some yq docs referring to the difference between fetching an anchor and resolving (following) an anchor ... https://mikefarah.gitbook.io/yq/commands/read#anchors-and-aliases
I think some of this got 'added' in v3 - so, maybe we need to adapt to a new call?

I dug a fraction more (as this is something I don't know much about in yaml, and wanted to). I think the issue is when we have an anchor on something that has a value - I think that is called a 'scalar'?. So, with the yaml:
---
assets:
  initrd:
    architecture:
      aarch64:
        name: &default-initrd-name "alpine"
        version: &default-initrd-version "3.7"
      ppc64le:
        name: *default-initrd-name

    a2:
      aarch64: &default-initrd
        name: "alpine"
        version: "3.7"
      ppc64le: *default-initrd

and the code:
#!/bin/bash

set -x

yq2 read v2.yaml "assets.initrd.architecture.ppc64le.name"
yq3 read v2.yaml "assets.initrd.architecture.ppc64le.name"

yq2 read v2.yaml "assets.initrd.a2.ppc64le.name"
yq3 read v2.yaml "assets.initrd.a2.ppc64le.name"

I get:
 ./go.sh
+ yq2 read v2.yaml assets.initrd.architecture.ppc64le.name
alpine
+ yq3 read v2.yaml assets.initrd.architecture.ppc64le.name
*default-initrd-name
+ yq2 read v2.yaml assets.initrd.a2.ppc64le.name
alpine
+ yq3 read v2.yaml assets.initrd.a2.ppc64le.name
alpine

Looking around, I think what we have is valid YAML anchors - so, I suspect this is a yq issue.
/cc @jodh-intel for yaml expertise.... and tenacity....

I've raised https://github.com/mikefarah/yq/issues/340.


Update Go SDK: typo fix

stout => stderr
Signed-off-by: Steve Phillips<EMAIL_ADDRESS>

You bet :slightly_smiling_face: . Great project, btw!


"helm install --description" flag not available

Output of helm version:
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.11-eks-5876d6", GitCommit:"5876d6b7429820450950ade17fe7b4bf5ccada7f", GitTreeState:"clean", BuildDate:"2019-09-24T20:54:25Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
any of them
Steps to reproduce the issue
Just run:
helm install ... --description "your description" ...
Actual behavior
I get this error:
Error: unknown flag: --description
Expected behavior
As for Helm2 I need to add a description to my release.
Additional
I don't know if there is an equivalent flag on Helm 3. I couldn't find anything on the internet.
If there is a command to add description please let me know. If there is not, isn't it a desirable feature?
Thanks.

It shouldn't be all that difficult to port https://github.com/helm/helm/pull/3825 over to Helm 3. Feel like taking this one on?

@bacongobbler I can give it a try... I'm not a go developer but I have the will... so, any advice is welcome.

The developer guide should be a helpful resource. https://helm.sh/docs/community/developers/
Let us know how you get along.

Ok, I did it, added flag to install, upgrade and delete.
Hope it is ok. :)


Changing BlobContainerRenameOptions and FileSystemRenameOptions to Private

Description
Since Rename API is no longer supported for BlobContainer and FileSystems, we need to make the options bag classes for these private.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob


Better Add component label

When adding a component, it is nice to see what parent it adheres to. Look at the following example:

Then it is nice to know what parent will receive the child.
This PR adds the parent component label to the add component (child) button below the list of components:

Rebased this to be easily merged


Fix TestValidateRoutedOverrides

ValidateRoutedOverrides does not guarantee a specific order of the returned ErrorList. As a result the "Multiple wrong override endpoints" sometimes fails even the expected errors are in the list. This changes to use ContainElements as it does not matter which order the errors are in the returned ErrorlList from ValidateRoutedOverrides.

e.g. seen in https://github.com/openstack-k8s-operators/lib-common/actions/runs/10287052007/job/28469175427
=== RUN   TestValidateRoutedOverrides/Multiple_wrong_override_endpoints
    types_test.go:137:
        Expected
            <field.ErrorList | len:2, cap:2>: [
                {
                    Type: "FieldValueInvalid",
                    Field: "spec.foo[wroooooong]",
                    BadValue: <string>"wroooooong",
                    Detail: "invalid endpoint type: wroooooong",
                },
                {
                    Type: "FieldValueInvalid",
                    Field: "spec.foo[wrooong]",
                    BadValue: <string>"wrooong",
                    Detail: "invalid endpoint type: wrooong",
                },
            ]
        to equal
            <field.ErrorList | len:2, cap:2>: [
                {
                    Type: "FieldValueInvalid",
                    Field: "spec.foo[wrooong]",
                    BadValue: <string>"wrooong",
                    Detail: "invalid endpoint type: wrooong",
                },
                {
                    Type: "FieldValueInvalid",
                    Field: "spec.foo[wroooooong]",
                    BadValue: <string>"wroooooong",
                    Detail: "invalid endpoint type: wroooooong",
                },
            ]
--- FAIL: TestValidateRoutedOverrides (0.00s)

@abays can you please approve it again. I had "Require branches to be up to date before merging" in the branch ruleset.


Refactor the render method

https://github.com/dictyBase/Genomepage/blob/ee3986f3f9c0993468df623b793310d168d2623d/src/app/layout/App.js#L68

Reduce multi argument checks in the if block. You could convert !navbar.links and !footer.links into error, so at least it will become if (navbar.error || footer.error)
Now the issue with above logic is you're not covering for if (navbar.error && footer.error). Now if you do this

if (navbar.error || footer.error) {
   return 'something'
}
if (navbar.error && footer.error)  {
   return 'something'
}

in any sequence, it might leave out one of the error checking, because navbar.error || footer.error will never go to footer.error is navbar.error is true. You could use a boolean along with two if blocks to handle the situation.
let navOrFootterError = false
let navbarErrorUI
let footerErrorUI
if (navbar.error) {
   navOrFooterError = true
   navbarErrorUI = '<navbarErrorUIComponent />'
}
if (footer.error) {
   navOrFooterError = true
   footerErrorUI = '<footerErrorUIComponent />'
}
if (navOrFooterError) {
   return <Something>{navbarErrorUI}{footerErrorUI}</Something>
}

Approach to refactoring

Instead of  sequential fetchNavbar() and fetchFooter() methods in the lifecycle, combine them to one action call. In the action call do the sequential fetches.
Refactor the reusable pieces into a HOC or render prop component. The reusable pieces will be

Fetching the data.
Handling errors.
In case of successful fetch, hand over the data to the child component that is wrapped by the HOC or render prop

I have refactored the render method as specified in the above comment. However, after adding my withDataFetching HOC to the App component, the SummaryContainer component is now being mounted and rendered three different times. Still trying to determine why this is happening.


Discard edit and delete-actions which are older than the current HEAD

For this, timestamps in this actions are necessary

Removed from milestone because I'm not entirely sure anymore whether this is the most intuitive behavior.


Add Japanese translations for v2.2.0

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes
I added Japanese translations requested in https://github.com/node-red/node-red/pull/3243#issuecomment-1022112531 and https://github.com/node-red/node-red/pull/3374#issuecomment-1022092276 .
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage decreased (-0.03%) to 67.307% when pulling 0f50355deb92f3857b0c412a3f108058889a2df2 on kazuhitoyokoi:dev-addjpn into bd6e35fea2fe6994d1184c4fe2ff337c339cd728 on node-red:dev.

@knolleary Thank you! I checked my translations in v2.2.0!


Recreate workspace with the same name after the soft-delete period

The first section mentions that "After the soft-delete period, the workspace and its data are non-recoverable – data is queued for permanent deletion within 30 days and the workspace name is available and can be used to create a new workspace."
I am trying to recreate a workspace with the same name on the 18th day after deletion. This is after the soft-delete period of 14 days, but before the additional 30 days mentioned until permanent deletion. From the article I expected to have the workspace name available immediately after the 14 days soft-delete period, but I get a Conflict error when trying to create the workspace with New-AzOperationalInsightsWorkspace or directly from the Azure portal.
Can you please edit the article to clarify the following:

When does the name of a deleted workspace become available again?
In the 30 days following the soft-delete period is the workspace name blocked (so the workspace can neither be recovered nor recreated with the same name)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86984751-da7f-c77b-c78b-a9c9ffacb4a3
Version Independent ID: 57838082-5ee8-097c-9814-803a5077ba4e
Content: Delete and recover Azure Log Analytics workspace
Content Source: articles/azure-monitor/platform/delete-workspace.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@adrianagdi Thanks for your comment. We are actively investigating and will get back to you shortly.

@adrianagdi As per document,you should be able to create workspace after the soft delete period.
@bwren Can you please provide your inputs on this as it takes time to reproduce the issue and check?

Checking with engineering team. #in-progress

The article is correct, but there was a bug that caused the name to remain reserved after the soft-delete period. This bug was fixed and in deployment phase and should be available on the week of 13-Jan.
In addition, we are adding support for -force delete, which can delete workspaces immediately. This is of course very risky as you can loose all your data, but following customers' requests, we are adding this support. Once this is supported, we will add it to documentation.

Thank you for the updates!
As a workaround, we temporarily used a different name for the log analytics workspace but I will check again with the reserved name after the week of 13-Jan.

#please-close


filtering bools in a stream doesn't work as expected

if i look in the stream of syslog for a word, the output is as expected
>tail -f /var/log/syslog | map contains Attached
False
False
False
False
True
False

but if i filter for True nothing comes out
>tail -f /var/log/syslog | map contains Attached | filter equals True

Strangely it works if the stream is saved to a file before
>tail -f /var/log/syslog > syslog.temp
>cat syslog.temp | map contains Attached | filter equals True
True
True

latest version: 0.3.0

maybe it has something to do with the buffer.
A similar similar command with grep shows the same problem
>tail -f /var/log/syslog | grep --line-buffered Attached | while read line ; do echo "$line"; done

but with the --line-buffered parameter it runs smoothly
>tail -f /var/log/syslog | grep --line-buffered Attached | while read line ; do echo "$line"; done
Nov 30 02:30:23 mycomputername kernel: [498264.335276] sd 8:0:0:0: [sdc] Attached SCSI removable disk
...

unbuffer -p has an effect:
tail -f /var/log/syslog | unbuffer -p map contains Attached | unbuffer -p map append " " | map replace True "aaaa"

is responding but
tail -f /var/log/syslog | unbuffer -p map contains Attached | unbuffer -p map append " " | filter eq True

is not.

Thank you for reporting this. That seems to be a problem in filter, indeed.
Another way to reproduce this:
(echo "A"; sleep 1; echo "B"; sleep 1; echo "A") | map contains A | filter equals True

This outputs
True
True

as it should, but the output is not streaming. Both lines are only printed after 2 seconds

Small correction: the problem seems to be with buffered writing in the map command, not with reading in filter. Observe:
(echo "A"; sleep 1; echo "B"; sleep 1; echo "A") | map append C

# versus

(echo "A"; sleep 1; echo "B"; sleep 1; echo "A") | map append C | cat

The first one streams to the console, the second does not.

Should hopefully be fixed via  c79d764

great it runs now.
Maybe this is not the right place, but i want want to say that your coding work really is bewundernswert. I absolutely love all your projects i've seen. Great sense for style and simplicity.

Maybe this is not the right place, but i want want to say that your coding work really is bewundernswert. I absolutely love all your projects i've seen. Great sense for style and simplicity.

Thank you very much for the feedback!


Replace troubleshoot.io with troubleshoot.sh

Relates to: https://github.com/replicatedhq/troubleshoot/issues/1070

What this PR does / why we need it:
This changes references to troubleshoot.io in Support Bundle types to troubleshoot.sh.  The reason for this is that the Troubleshoot project does not own troubleshoot.io.
Which issue(s) this PR fixes:

Fixes Troubleshoot #1070
Special notes for your reviewer:

Note that this changes the label stored on secrets that contain support bundles.  This should be reviewed alongside https://github.com/replicatedhq/troubleshoot/pull/1075
Steps to reproduce

Does this PR introduce a user-facing change?

Support-bundle specs stored in-cluster prior to this change were stored with a label `"troubleshoot.io/kind=support-bundle"`.  The label was used as a default setting for the Troubleshoot command to search for support bundles.  As of release 0.60.0, Troubleshoot searches for `"troubleshoot.sh/kind=support-bundle"`.  The label has been updated in this change to match the new search value.

Does this PR require documentation?

NONE

KOTS appears to be using kots.io/kind: supportbundle as it's label rather than the default, which is fine.  That makes this change no longer required.


Unexpected token 'export'

Hi everyone,
after updating to 1.0.0-beta.4 i've become the following error:

This is my config-file:

I hope someone can help 🙏

You have to rename your file to astro-i18next.config.mjs or add "type": "module" to your package.json.

Oh sorry, i didnt noticed that. Did the file extensionchanged over the update?

It's not related to astro-i18next directly, it's related to your project's configuration and Node. By default, all javascript files in a Node environment are considered to be CommonJS syntax. The astro-i18next.config.js file that I have put in the documentation is written using the ESModules syntax (more modern javascript).
So, for your astro-i18next config to be recognized, you have to explicitly specify that it is an ESModule (hence the .mjs extension) or define that your Node environment should expect ESModules by default (hence the "type": "module" property that could be added to your package.json).
Note that if you go the package.json route, you have to do the opposite when using the CommonJS syntax in your project: you have use the .cjs extension.
To recap

No "type": "module" in package.json  (defaults to "type": "commonjs"):

use CommonJS syntax by default in your .js files
specify the .mjs extension when using ESModules syntax

With "type": "module" in package.json:

use ESModules syntax by default in your .js files
specify the .cjs extension when using CommonJS syntax

What's the difference between CommonJS vs ESModules syntaxes? Basically:

CommonJS is when you write require()
ESModules is when you write import / export

Hope it helps!

Further reading for reference:

CommonJS vs. ES modules in Node.js: https://blog.logrocket.com/commonjs-vs-es-modules-node-js/
https://nodejs.org/api/modules.html#enabling


A.13.IR18.keywords.node

This issue has been extracted from the issue list on:https://ies-svn.jrc.ec.europa.eu/issues/2685
Comment
Overlap with A.39.IR16, which already checks for '/inspire_common:MandatoryKeyword'
Testability: if it is optional to define additional keywords (/inspire_common:Keyword) on top of /inspire_common:MandatoryKeyword, then this test would fail if no additional keywords are provided.
This test case only needs to be executed in the context of 'scenario 2'.
Proposed Change
Consider merging with A.39.IR16

Agreed if test for IR 16 is based on testing a keyword in an extended capabilities section (scenario 2) then the tests should be merged.
However I'm not at all sure why there is a need to have a keyword in an extended capabilities section because  keywords are obviously catered for in a standard WMS response; the sections in the TG relating to keywords show the use of the standard WMS keyword to hold the mandatory keyword, so the test for IR 16 should probably be testing for keywords her and not in the  extended capabilities section of a scenario 2 response.

Test case A.39 for IR16 was merged with this test case as a resolution to issue #116.
Implemented precondition that test case metadataURL.node must indicate scenario 2


Add API to zookeeper operator

Fix here: https://github.com/kubernetesbigdataeg/zookeeper-operator/pull/6


crusaders crossbow missing on a standing still player

ok and how close were they, how soon did they stop moving from when you shot? were they also using fedoraware with the thing that makes u stop moving as soon as u let go of a movement key? there's loads of things that could affect this

also no config attached nor video?

and you dont know if you can make it reproduce this constantly?

template exists for a reason - use it please.


Description for the DontShow parameters should provide more info

For the DontShow parameters like -Proxy or -AppendPipeline, although we are hiding them from the online doc, but when the in-tool help still displays those parameters.

We should consider being more descriptive, add works like "This cmdlet is for internal use only........".

In the medium to long term, would there be an opportunity to do the internal mock testing using these parameters, then a second export without them, this would eliminate the issue entirely.
In the short term we should definitely tell customers that these parameters are for internal MSFT use only.

For [-Break] [-HttpPipelineAppend] [-HttpPipelinePrepend], which are for internal use, will add descriptions to tell users they are for internal use only.
For [-Proxy] [-ProxyCredential], [-ProxyUseDefaultCredentials], which are used to support cmdlet level proxy. Will add description to recommend users to use system level proxy support. And if usage is low, will considering to deprecate cmdlet level proxy support.


False positive when using structural pattern matching inside a loop

Please note the false positive regarding the prefix: str variable in the MWE below.
In the line prefix: str = partName + "." if partName else instanceName + "." if instanceName else "", the type checker correctly assumes (variable) partName: LiteralString | Literal[''] and (variable) instanceName: LiteralString | Literal['']. So, prefix should not be flagged as Unknown | LiteralString | Literal[''].
Environment data

Language Server version: 2023.8.20 (latest)
OS and version: Windows 11
Python version: 3.11.4

Code Snippet
data = """
*PART, NAME=PART-A, TYPE=UNKNOWN
*SET, NAME=PART-SET
1, 2, 3
4, 5, 6
*END PART
*SET, NAME=INSTANCE-SET, INSTANCE=PART-A-1
10, 20, 30
50, 50
"""

partName: str = ""
setName: str = ""
command: str = ""
sets: dict[str, set[int]] = {}
for line in data.split("\n"):
    line = line.strip().replace(" ", "").upper()
    if not line: continue
    if line[0] == "*":
        command = (
            "PART" if "*PART" in line else
            "SET"  if "*SET"  in line else
            "END"  if "*END"  in line else
            ""
        )
        match command:
            case "PART":
                partName = line.split("NAME=")[1].split(",")[0]
            case "END":
                partName = ""
            case "SET":
                instanceName: str = line.split("INSTANCE=")[1].split(",")[0] if ",INSTANCE" in line else ""
                prefix: str = partName + "." if partName else instanceName + "." if instanceName else "" # Type of "prefix" is partially unknown
                setName = prefix + line.split("NAME=")[1].split(",")[0]                                  # which affects this
                sets[setName] = set()                                                                    # and this
            case _: pass
    else:
        match command:
            case "SET":
                numbers: list[int] = [int(x) for x in line.split(",")]
                sets[setName].update(numbers) # this line causes the false positive above
            case _:
                pass

for name, set in sets.items():
    print(name, set)

# output:
# PART-A.PART-SET {1, 2, 3, 4, 5, 6}
# PART-A-1.INSTANCE-SET {10, 20, 50, 30}

Logs
log.txt

Could someone from the pylance team please transfer this to the pyright project since it's a core type checking issue? Thanks!

Actually, I'm not able to repro the problem as specified.
@carlos-souto, can you confirm that when you paste the above code into a new file and add a # pyright: strict to the top (to enable strict-mode checks), you see an error when using the latest production build of pylance (2023.8.20)?
Here's what I see:

Oh, I take it back. I am able to repro in pylance. Just not with pyright. That means the problem is likely related to evaluation ordering. Pylance's semantic token highlighting feature can cause expressions to evaluated in a different order than pyright. The resulting type evaluation should be the same regardless of ordering, but bugs can cause results to differ. I'll investigate further.

I found and fixed the problem. This is a really old bug. I'm surprised it hasn't shown up before in any bug reports. Thanks for the bug report. This will be fixed in the next preview release of pylance.


new message blocks (add/delete MQTT subscriptions)

Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
adds blocks to give user ability to subscribe and unsubscribe to publications on an topic entered into the input field
Describe what this Pull Request does
Reason for Changes
Explain why these changes should be made
Test Coverage
Please show how you have added tests to cover your changes

reformatted back to production version of spacing according to  .eslintrc.js


Comparison different image didn't added in html test report.

Hi There,
Currently, i can run visual comparison with codeceptjs-resemblehelper. But found the diff image can't be added in allure test report. Only latest screenshot could be added.

Have configured allure in my test as below:

Running command as :

codeceptjs run --reporter mocha-multi --config=config-files/codecept_demo_visual_regression_config.js --verbose

Is there a way to add the diff result image in the test report? That will make the report checking easy when run in cloud with Jenkins.

I'll take a look at this and update the thread.


Implement Camera

Implement a extremely basic camera system.
The camera system is intended only for rendering a 3D-Scene to a 2D-Viewport.
fn renderToTarget(scene, camera, viewport);

struct Scene; // the things to render
trait Camera; // projection and camera transform
struct Viewport; // width, height, render-target

Later changes might include...

A stencil-based see-trough portal system.
Eye-based rendering for HMD-VR.

Implemented as of commit 7d31be8.
Notes:

Geometry moved into Scene structure.
Movement is part of Camera; hooked into GLFW-Events and Tick-Updates.
No position & rotation interpolation yet.
Still using implicit framebuffer.


Two class functions before declaring class reports E056, but no report if only one function.

jshint reports E056 in the following code.
'use strict';
function foo() {
  Test.hello();
}
function bar() {
  Test.hello();
}
class Test {
  static hello() {
    console.log('Hello, world');
  }
}

But it does not report if Test.hello() is only one.
'use strict';
function foo() {
  //Test.hello();
}
function bar() {
  Test.hello();
}
class Test {
  static hello() {
    console.log('Hello, world');
  }
}

.jshintrc is as follows
{
  "esversion": 6,
  "node": true
}

Thanks for the report! This is a duplicate of gh-2838. The bug was fixed via gh-2842, and the fix will be available in the next (post-2.9.1) version of JSHint.


EPSG:28992 Reprojection is incorrect using TileWMS.

Example at https://jsfiddle.net/66Lo5n69/.
The tiles do not match the other reprojection. Additionally, manually adding EPSG:28992 by doing the following is broken:
proj4.defs("EPSG:28992","+proj=sterea +lat_0=52.15616055555555 +lon_0=5.38763888888889 +k=0.9999079 +x_0=155000 +y_0=463000 +ellps=bessel +towgs84=565.2369,50.0087,465.658,1.9725,-1.7004,9.0677,4.0812 +units=m +no_defs");     var proj28892 = ol.proj.get('EPSG:28892');     proj28892.setExtent([483.87, 308912.81, 275904.19, 636380.52])
We're using Openlayers 3.19.1, but this problem was put on the backburner since then.
Debugging the code shows that proj28892 is always null, as such I can't set the extent.

you have typos 28892 versus 28992
Sent from my iPhone

On 13 Jan 2017, at 16:33, Heerco Grond<EMAIL_ADDRESS>wrote:
Example at https://jsfiddle.net/66Lo5n69/.
The tiles do not match the other reprojection. Additionally, manually adding EPSG:28992 by doign the following is broken:
proj4.defs("EPSG:28992","+proj=sterea +lat_0=52.15616055555555 +lon_0=5.38763888888889 +k=0.9999079 +x_0=155000 +y_0=463000 +ellps=bessel +towgs84=565.2369,50.0087,465.658,1.9725,-1.7004,9.0677,4.0812 +units=m +no_defs"); var proj28892 = ol.proj.get('EPSG:28892'); proj28892.setExtent([483.87, 308912.81, 275904.19, 636380.52])
We're using Openlayers 3.19.1, but this problem was put on the backburner since then.
Debugging the code shows that proj28892 is always null, as such I can't set the extent.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Right, you are correct, however fixing the typos (changing everything to 28992) still gives me null if I try to do proj28992 = ol.proj.get('EPSG:28992'); , which is the basis of the problem. It skips over the step it seems.

In your snippet, you are not including proj4, which is required if you do not have custom transform functions configured. I have updated your fiddle, and everyting looks good there: https://jsfiddle.net/66Lo5n69/1/.

Thank you! I figured out the problem, I wasn't reassigning proj4 to the ol using ol.proj.setProj4(proj4). It works amazingly now.


Add 1.10 to travis since it was just released

FYI travis is not picking up 1.10.x yet and is falling back to 1.7

GIMME_OUTPUT="$(gimme 1.10.x | tee -a $HOME/.bashrc)" && eval "$GIMME_OUTPUT"
I don't have any idea what to do with '1.10.x'.
(using type 'auto')

@jmank88 Yes indeed, apparently we have to write : "1.10" for now.. until https://github.com/travis-ci/gimme/issues/132  is fixed

LGTM!


Forms with a media column result in unhelpful error message.

If you have a form with a media column (not media::image) and something in that column, pyxform gives a very unhelpful error.

Error: 'str' object has no attribute 'items'

See test.xlsx for an example.
It would be ideal if we warn that the column heading is likely to be incorrect. Maybe we build on the sheet name checking at #544?

media is not a known column name. It used to just be ignored like other unknown columns but since the translation checks were added, there's an assumption that media will be a dictionary.
I wanted to add a helpful error message but then I realized that we don't currently have an example of rejecting based on an issue in the header.
In the mean time, I propose restoring the prior behavior which is to ignore the unknown column name.

I think https://github.com/getodk/docs/issues/1546 will sufficiently address this.


Doom airline themes

No issue here. Just wanted to say thanks for the great themes!
I added modeline themes for doom-one and doom-molokai to https://github.com/AnthonyDiGirolamo/airline-themes
Screenshots
airline-doom-one-theme

airline-doom-molokai-theme

Fantastic work, they look great!

i use airline and doom-one both  XD

@hlissner  @AnthonyDiGirolamo  How can I have that square shape in the screenshot?

(setq powerline-default-separator nil)
There are a bunch of options besides the arrow and nothing. See https://github.com/milkypostman/powerline/blob/master/powerline.el#L75 for all valid options.

@AnthonyDiGirolamo  Thanks. Hope you could add some guidance for customization in the README


Added asciiart-logo to cli category

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆

Thanks for the suggestion, but I'm going to pass on this. This is a curation, so I unfortunately can't include everything. That means making the hard decision of leaving out some cool projects for various reasons.


Added 46elks SMS agent

46elks SMS agent
What is this?
This is an agent that allows you to send SMS with the help of https://46elks.com.
What is covered so far?
Agent
This is an early pull request but I consider the agent to be done, I don't usually code in Ruby so I would love to get some feedback regarding my submitted code.
Agent specs
There are currently no tests, this is because I'm a bit unsure on what to test.
If I could get some examples of what basic coverage could be, that would be awesome.

I updated the agent with some tests now.

Thank you for your work! The code looks goo to me, I think you could simplify it by using the faraday gem that is already included in Huginn.
I think that is a good candidate for a Huginn Agent gem. I believe that every new Agent that makes it into Huginn "proper" should be a "helper" Agent or an Agent for a very popular service like Twitter.
@knu Feel free to reopen the PR if you disagree.


scripts: Remove unused QEMU scripts

Signed-off-by: Gordan Markuš<EMAIL_ADDRESS>

Since we have a documentation in the SWF (http://pelux.io/software-factory/master/swf-blueprint/docs/articles/baseplatform/booting-qemu-image.html) I am not sure how applicable this is and up to date so I would rather remove it, at least in master.

Closes #15


remove deprecated og pages

this finally removes all "og-image.thirdweb.com" references so we can turn off the service - these have already not been in active use anymore for a while so it should be safe

📝 Changed routes:
2 deleted routes:

/_og/profile
/_og/release

Commit f98909ce71143b901450926f5a2878255ae10418 (https://thirdweb-8vmfrc3su.thirdweb-preview.com).


the color in setting,json change itself

We have written the needed data into your clipboard because it was too large to send. Please paste.

/needsMoreInfo


Update docs mentioning tests should be run in release mode

Given that certain behavior only triggers in release mode in Rust like arithmetic operations wrapping, we should run tests in release mode.
This issue reflects the work needed to update all docs to mention the above.

Closing in favor of #189


Updated gradle to 7.0, jdk to 11

Could you also do the following please?

Create a new branch v6.x from master branch
Create v6.x track on snapcraft.io and integrate v6.x branch with this new track
All master builds will continue to go into edge track as usual (and I'll promote it to stable once builds are complete)

12 days.. and counting... 😞

* Create `v6.x` track on snapcraft.io and integrate `v6.x` branch with this new track

This request would have to be made on the forum but I guess let's first wait for the new branch to get created.

* Create `v6.x` track on snapcraft.io and integrate `v6.x` branch with this new track

This request would have to be made on the forum but I guess let's first wait for the new branch to get created.

I didn't know that. 🤔  Is there a reason for making branching requests on the forum? Is it because the snap belongs to Snapcrafters?

Do you expect any major breakages in workflows btw? Anything for users to be aware of if they need to switch to this proposed track?

@igorljubuncic - nope. it's just a maintenance track. 6.8.x will probably get security updates etc. so I want to make sure that it still exists.

OK, let's do the following - can you create a forum post asking for a new track creation, tag me please so I can +1 it. Then, we can build and push this to that track. Which one should be the default one btw (6.x or 7.x)?

@igorljubuncic - 7.x should be default. I'm creating the forum thread now. Cheers!

@igorljubuncic - Now that the track is ready, how do we proceed? I was planning the following:

master branch -> default track (7.x)
6.8.x branch -> 6.8.x track

gradle 7.0.2 has been released. 🙄


OSS -> Azure Health Data Fhir Service

Hi,
We currently host the OSS FHIR server in our own subscription within Azure.  We are currently evaluating whether we can switch to the Azure Health Data Fhir Service but we have a few questions:

In our existing setup we modify some of the configuration parameters, such as the default count limit and bundle size.  I can't see a way of doing this in the health fhir service, is this possible?
We currently use AFD in front of our fhir service.  This works well but relies on the fact that we can add a custom domain to the app service so that the URLs returned in the FHIR responses match the AFD url (rather than the default app service url).  I note that others have a problem with custom URLs using Application Gateway.  Are there plans to allow for custom urls?
I note that the managed service only supports FHIR versions 3 and 4.  We are not planning on using v5 anytime soon but it is concerning that support isn't available even though it was released a while back.  What are the expected timeframes around new FHIR releases?

Thanks,
Reuben
AB#118212

Hi @reubenelder, I can jump on a few points here.

Currently no, HDS is has limits that we feel balance the best performance vs latency across accounts. We're always open to learning where this doesn't work, let me know what you're using here.
I'll need to discuss this one internally, there would be some dev cost in the security aspect of this.
I'll let @EXPEkesheth weigh in on this topic. We will continue to track the demand for R5, my current read is that there is some debate over the wide R4 support + R6 being a larger normative release vs the effort in moving through R5. While R5 does have its improvements and use-cases, the incentive for a major shift through R5 doesn't seem clear.

@reubenelder - are your questions answered? If no response, the issue ticket will be closed in a week

thanks for the reply @brendankowitz  (sorry I was away for Easter otherwise I would have replied quicker).

We set the FhirServer__CoreFeatures__MaxItemCountPerSearch to 2000 currently.  I can't remember what the default is - what is it set to in HDS?  The reason for this is that we primarily use the FHIR service for medication resources of which there are over 80000 in various forms.  Vendors need to be able to retrieve subsets of these in reasonable batches.  We also set the FhirServer__Bundle__EntryLimit as when we submit updates we want as many batched up in a transaction as possible.  Currently we use batches of 500 however most are a lot smaller than this but some are bigger.  We would have liked to always include everything in one update batch but performance wise this was an issue (also when we last tested a very large batch asp.net core rejected the size of the request).
Thanks - do you know how others get around this currently?
I don't think I was very clear on this - we won't be moving to R5 either but was more concerned about how long R6 support would take after R6 is released?

@reubenelder

In the managed service, by default search parameter count is set to 1000 . For details, please see Search Result Parameters. For bundles, the default value is 500 resources per bundle.
We have customers update the url in the application gateway. We have similar ask in our backlog and OSS issue tracking the ask.
R6 is meant to be a normative release and we would likely start investigating with the release. Also note, the support for R6 in FHIR service will be driven by customer demand.

thank you @EXPEkesheth for your response.  I'll monitor the url request, hopefully this can be added soon.
In terms of the default count of 1000.  Is there any hope that this could be adjustable in the future?

Have created workitem in the backlog for consideration. Thankyou !

Excellent - thanks for that


[SplashScreen] use directly QSplashScreen & update splash medInria logo

As done on MUSICardio side: https://github.com/Inria-Asclepios/medInria-public/pull/800

This PR removes the use of medSplashScreen which is not needed anymore, we can use directly QSplashScreen.
It's now launched at the creation of the app (in the beginning of medApplication constructor), and automatically closed when the window of the app is displayed.
This change debugs also a problem at least of Ubuntu side where the splashScreen was not displayed at the right time.

Also, i updated the medInria splashscreen logo to be a dedicated one (not the same as the one on homepage), with a background color, and no need to space for text.
:m:

At a moment of code review the question was
QSplashScreen *splashScreen

leek or not ?
Thanks to Mathilde investigation, the lines
d->splashScreen->setAttribute(Qt::WA_DeleteOnClose, true);

d->splashScreen->finish(d->mainWindow);

prouve we don't have a leek.
Then for me the PR is good to merge ;)
But a question still open. After the line
d->splashScreen->finish(d->mainWindow);

Do we need a d->splashScreen = nullptr;  the answer to this question is in a future discussion...

as a reminder it's possible to switch QSplashScreen *splashScreen; to QPointer<QSplashScreen> splashScreen; because QPointer set automatically to null the variable if it has been deleted. It's not really useful here but could be helpful in other part of the code


Placeholder for Emerging Priority (SFAS to SIMS Data bridge EXPASSIONS #2686 / #2689

This will be a fully understood and groomed ticket that is blocking multiple tickets but is not yet complete

Closing placeholder ticket.


Prevent application submission where only Foundation level degrees have been entered

This updates the prototype to prevent candidates from marking the degree section as complete if they've only added Foundation degrees.
To do this, the "Have you completed this section?" question is removed from the bottom, and the "Add another degree" buttons switches to the primary green colour (rather than secondary grey). A line of guidance is also included.
Screenshot

could we use the same term here and here? so that the user can automatically see which thing they're looking for based on the guidance they've just seen

Should we say something here that makes it obvious that it's ok if you're still studying for your degree? e.g. you can still apply if you haven't got your grade yet

Thanks @EmmaFrith!
We’ve review the guidance and updated it to:

You need a bachelor’s degree or equivalent to start teacher training.
Add your bachelor’s degree even if you have not got your grade yet.
You can also add any other degrees that you have, or you’re working towards.

...having decided that it was better to consistently use "bachelor" than "undergraduate" (which is a more loosely-defined term which technically might include a Foundation course).


Feature Toggle Spec

Spec for #364
Microsoft Reviewers: Open in CodeFlow

Feature flags or toggles are a great idea. Why not look at how Powershell does this and leverage their code. So Get-WgExperimentalFeature, Set-WgExperimentalFeature?

Feature flags or toggles are a great idea. Why not look at how Powershell does this and leverage their code. So Get-WgExperimentalFeature, Set-WgExperimentalFeature?

I think that is a good thing to include in future PowerShell work, but we also want to support non-PowerShell paths.


body: add knee support

The body route has FW b'0.0.01', for engine, but since that was removed in this PR it doesn't fingerprint and process replay thinks controlsd crashes. If you get a new route it should work

Gonna close this for now and keep the branch around