Bug Report

Current Behaviour
The ProfileReport fails to generate, and i dont find if the issue is already solved or a way to bypass it.
I think because of the size of my data, it fails to generate the wordcloud.
The full error output is:

IndexError                                Traceback (most recent call last)
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\wordcloud\wordcloud.py:458, in WordCloud.generate_from_frequencies(self, frequencies, max_font_size)
457 try:
--> 458     font_size = int(2 * sizes[0] * sizes[1]
459                     / (sizes[0] + sizes[1]))
460 # quick fix for if self.layout_ contains less than 2 values
461 # on very small images it can be empty
IndexError: list index out of range
During handling of the above exception, another exception occurred:
IndexError                                Traceback (most recent call last)
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\wordcloud\wordcloud.py:464, in WordCloud.generate_from_frequencies(self, frequencies, max_font_size)
463 try:
--> 464     font_size = sizes[0]
465 except IndexError:
IndexError: list index out of range
During handling of the above exception, another exception occurred:
ValueError                                Traceback (most recent call last)
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\IPython\core\formatters.py:344, in BaseFormatter.call(self, obj)
342     method = get_real_method(obj, self.print_method)
343     if method is not None:
--> 344         return method()
345     return None
346 else:
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\profile_report.py:520, in ProfileReport.repr_html(self)
518 def repr_html(self) -> None:
519     """The ipython notebook widgets user interface gets called by the jupyter notebook."""
--> 520     self.to_notebook_iframe()
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\profile_report.py:500, in ProfileReport.to_notebook_iframe(self)
498 with warnings.catch_warnings():
499     warnings.simplefilter("ignore")
--> 500     display(get_notebook_iframe(self.config, self))
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\report\presentation\flavours\widget\notebook.py:75, in get_notebook_iframe(config, profile)
73     output = get_notebook_iframe_src(config, profile)
74 elif attribute == IframeAttribute.srcdoc:
---> 75     output = get_notebook_iframe_srcdoc(config, profile)
76 else:
77     raise ValueError(
78         f'Iframe Attribute can be "src" or "srcdoc" (current: {attribute}).'
79     )
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\report\presentation\flavours\widget\notebook.py:29, in get_notebook_iframe_srcdoc(config, profile)
27 width = config.notebook.iframe.width
28 height = config.notebook.iframe.height
---> 29 src = html.escape(profile.to_html())
31 iframe = f''
33 return HTML(iframe)
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\profile_report.py:470, in ProfileReport.to_html(self)
462 def to_html(self) -> str:
463     """Generate and return complete template as lengthy string
464         for using with frameworks.
465
(...)
468
469     """
--> 470     return self.html
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\profile_report.py:277, in ProfileReport.html(self)
274 @property
275 def html(self) -> str:
276     if self._html is None:
--> 277         self._html = self._render_html()
278     return self._html
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\profile_report.py:385, in ProfileReport._render_html(self)
382 def _render_html(self) -> str:
383     from ydata_profiling.report.presentation.flavours import HTMLReport
--> 385     report = self.report
387     with tqdm(
388         total=1, desc="Render HTML", disable=not self.config.progress_bar
389     ) as pbar:
390         html = HTMLReport(copy.deepcopy(report)).render(
391             nav=self.config.html.navbar_show,
392             offline=self.config.html.use_local_assets,
(...)
400             version=self.description_set.package["ydata_profiling_version"],
401         )
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\profile_report.py:271, in ProfileReport.report(self)
268 @property
269 def report(self) -> Root:
270     if self._report is None:
--> 271         self._report = get_report_structure(self.config, self.description_set)
272     return self._report
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\report\structure\report.py:387, in get_report_structure(config, summary)
368 section_items: List[Renderable] = [
369     Container(
370         get_dataset_items(config, summary, alerts),
(...)
374     ),
375 ]
377 if len(summary.variables) > 0:
378     section_items.append(
379         Dropdown(
380             name="Variables",
381             anchor_id="variables-dropdown",
382             id="variables-dropdown",
383             is_row=True,
384             classes=["dropdown-toggle"],
385             items=list(summary.variables),
386             item=Container(
--> 387                 render_variables_section(config, summary),
388                 sequence_type="accordion",
389                 name="Variables",
390                 anchor_id="variables",
391             ),
392         )
393     )
395 scatter_items = get_interactions(config, summary.scatter)
396 if len(scatter_items) > 0:
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\report\structure\report.py:162, in render_variables_section(config, dataframe_summary)
160     variable_type = summary["type"]
161 render_map_type = render_map.get(variable_type, render_map["Unsupported"])
--> 162 template_variables.update(render_map_type(config, template_variables))
164 # Ignore these
165 if reject_variables:
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\report\structure\variables\render_text.py:81, in render_text(config, summary)
77 top_items.append(table)
79 if words and "word_counts" in summary:
80     mini_wordcloud = Image(
---> 81         plot_word_cloud(config, summary["word_counts"]),
82         image_format=config.plot.image_format,
83         alt="Mini wordcloud",
84     )
85     top_items.append(mini_wordcloud)
86 template_variables["top"] = Container(top_items, sequence_type="grid")
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\contextlib.py:75, in ContextDecorator.call..inner(*args, **kwds)
72 @wraps(func)
73 def inner(*args, **kwds):
74     with self._recreate_cm():
---> 75         return func(*args, **kwds)
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\visualisation\plot.py:126, in plot_word_cloud(config, word_counts)
124 @manage_matplotlib_context()
125 def plot_word_cloud(config: Settings, word_counts: pd.Series) -> str:
--> 126     _plot_word_cloud(series=word_counts)
127     return plot_360_n0sc0pe(config)
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\ydata_profiling\visualisation\plot.py:38, in _plot_word_cloud(series, figsize)
36 for i, series_data in enumerate(series):
37     word_dict = series_data.to_dict()
---> 38     wordcloud = WordCloud(
39         background_color="white", random_state=123, width=300, height=200, scale=2
40     ).generate_from_frequencies(word_dict)
42     ax = plot.add_subplot(1, len(series), i + 1)
43     ax.imshow(wordcloud)
File ~\AppData\Roaming\jupyterlab-desktop\jlab_server\lib\site-packages\wordcloud\wordcloud.py:466, in WordCloud.generate_from_frequencies(self, frequencies, max_font_size)
464                 font_size = sizes[0]
465             except IndexError:
--> 466                 raise ValueError(
467                     "Couldn't find space to draw. Either the Canvas size"
468                     " is too small or too much of the image is masked "
469                     "out.")
470 else:
471     font_size = max_font_size
ValueError: Couldn't find space to draw. Either the Canvas size is too small or too much of the image is masked out.
Expected Behaviour
I'm expecting the ProfileReport to generate, but skipping the wordclouds.
Maybe an option to turn the wordclouds off, so the profile generates but skips that.
Data Description
My data is private, about 2 million rows and +200 columns. Can't identify the column (s ???) that is causing the error.
Code that reproduces the bug
import pandas as pd
from ydata_profiling import ProfileReport
profile=ProfileReport(df, title="my_data_report", minimal=True)
profile

pandas-profiling version
v4.6.1
Dependencies
pandas==2.0.3

OS
Windows 11
Checklist

[X] There is not yet another bug report for this issue in the issue tracker
[X] The problem is reproducible from this bug report. This guide can help to craft a minimal bug report.
[X] The issue has not been resolved by the entries listed under Common Issues.

Hello there.
I'm experiencing the same issue here.
So far, I´ve tried to remove part of the string coming from the categorical column to try to make an smaller string, using this function . Unfortunaltely , I am not able to make it work yet.
def remove_substring_from_column(df, column_name, substring, inplace=True):
    """
    Removes a specified substring from a particular column in a DataFrame.

    Parameters:
    - df (pandas.DataFrame): The input DataFrame.
    - column_name (str): The name of the column from which the substring should be removed.
    - substring (str): The substring to remove.
    - inplace (bool, optional): If True, modifies the input DataFrame directly. If False, returns a modified copy.
                                Defaults to True.

    Returns:
    - pandas.DataFrame or None: If inplace is False, returns a modified copy of the DataFrame.
                                If inplace is True, returns None and the input DataFrame is modified in place.
    """
    if inplace:
        target_df = df
    else:
        target_df = df.copy()

    if column_name in target_df.columns:
        print(f"Before removal: {target_df[column_name].head()}")
        target_df[column_name] = target_df[column_name].str.replace(substring, '', regex=False)
        print(f"After removal: {target_df[column_name].head()}")
    if not inplace:
        return target_df
    print('# ----data removed----#' + str(substring) + ' ' + str(column_name))
    return target_df`

Maybe decreasing the font size or increasing the Canvas Size might work.
Anyone has any idea of how to tackle this , beyond trying changing the string length or doing a label encoding step ?
🙏🙏 Thanks for the time dedicated to tackle this issue ! 🙏🙏

Hi @SoyGema and @gonzalezhomar ,
can you please share what is the python version that you are using? And how are you installing ydata-profiling in your env (pip, conda, etc.)

I'm getting the same error as OP and also believe it's due to data size since I used ydataprofiling successfully in the same environment on a smaller dataset a couple of hours prior.
OS:
Amazon Linux 2 (Sagemaker Notebook Instance)
Versions:
Python  3.9.18
pip installed -
ydata-profiling==4.6.2
pandas==2.0.3
Data:
Private Data >500k rows,  22 cols

Hi there. we are using
Python 3.10.12
ydata-profiling 4.5.0

Following...I am running into the same problem, utilizing both 4.5 and 4.6 ydata-profiling with the above error message and the output being: <Figure size 600x400 with 0 Axes>

Same issue here
Python 3.11.5
pandas 2.0.3
ydata_profiling v4.6.2

Thank you for the information provided!
This issue is related with the wordcloud plot. We will analyze the issue in more detail, and considered it for the next release expected for mid January.

Just to get around of this error, I change generate_from_frequencies(word_dict) to generate_from_frequencies(word_dict, max_font_size=10) in
https://github.com/ydataai/ydata-profiling/blob/b0c422b2e06de5eb3ae41af68ac565ffc5aef9af/src/ydata_profiling/visualisation/plot.py#L38-L40
to avoid automatic determination of max_font_size. This is of course not ideal so I will be waiting for a proper solution.

For me, the cause of the problem was that I included in the dataframe also very long ID strings. When removed, the profiling started to work again :)

I'm having a similar issue - @fabclmnt was that issue resolved in the Jan (01/2024 i guess) version?
@gonzalezhomar , did you manage to turn off word cloud?

I have the same issue (see below). What helped me as a workaround is to set in ydata_profiling/visualisation/plot.py a max_font_size value for the WordCloud
        wordcloud = WordCloud(
            font_path=config.plot.font_path,
            background_color="white",
            max_font_size=100,
            random_state=123,
            width=300,
            height=200,
            scale=2,
        ).generate_from_frequencies(word_dict)

---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
File ~/.local/share/virtualenvs/dartgen-k85DvGnY/lib/python3.12/site-packages/wordcloud/wordcloud.py:458, in WordCloud.generate_from_frequencies(self, frequencies, max_font_size)
    457 try:
--> 458     font_size = int(2 * sizes[0] * sizes[1]
    459                     / (sizes[0] + sizes[1]))
    460 # quick fix for if self.layout_ contains less than 2 values
    461 # on very small images it can be empty

IndexError: list index out of range

During handling of the above exception, another exception occurred:

I'm also having this issue (font_size = int(2 * sizes[0] * sizes[1]). From previous comments I am assuming long values in some columns are causing this. I was hoping that as a workaround one could just disable wordcloud easily, but was not able to find a way to do that quickly.


Support for Az Module (3.8.0)

Description
Added support for PowerShell Az Module 3.8.0
This allows to leverage the new APIs introduced in 3.8.0
Related issue:
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

This code file definitely should be refactored :)
cc: @alepauly


Alphanumeric passcodes

This seems simple enough (store a string instead of a four digit int in Shared Preferences). Going to see if this can be done in 1.3. If not, will move to 1.4

Might be bigger than I'm assuming, since it'll also need a dynamic Lock screen (eg. if alphanumeric, show one EditText, but if 4-digit pin show the four EditText we have now)

Before i could implement this, i need to know if we give the user the choice between an alphanumeric passcode and a "PIN". As you mention, it could be a slightly bigger task if we want to differentiate between the both in the future.
I think I could easily get it done for 1.3.

Yes, in the settings they can tap "Pin Lock" or "Alphanumeric Lock", and if one is toggled on, the other switches off.


HTML tables in NextJS is not formatted and ugly - basic formatting would help

Please select the area your bug applies to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[ ] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[x] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

make tables in markdown
publish with NextJS
see that ugly HTML tables are ugly

Expected behavior

some basic formatting on HTML tables

Screenshots
Desktop (please complete the following information)
n/a
Additional context
Dendron Log file

Hi @nz-john, Thanks for reporting the issue.

Fixed with https://github.com/dendronhq/dendron/pull/1737?

This should be fixed in v0.70 of Dendron. Please post here if not, otherwise this issue will auto close in 4 days


Potential error with accelerate + lm-eval + rwkv sharded models

The following error occurs when running lm-eval with accelerate, with a sharded RWKV model
# ------------------------------
# Running Task : anli
# ------------------------------
The following values were not passed to `accelerate launch` and had defaults used instead:
	`--num_processes` was set to a value of `7`
		More than one GPU was found, enabling multi-GPU training.
		If this was unintended please pass in `--num_processes=1`.
	`--num_machines` was set to a value of `1`
	`--mixed_precision` was set to a value of `'no'`
	`--dynamo_backend` was set to a value of `'no'`
To avoid this warning pass in values for each of the problematic parameters or run `accelerate config`.
Using RTX 4000 series which doesn't support faster communication speedups. Ensuring P2P and IB communications are disabled.
2024-02-25:19:16:47,809 INFO     [utils.py:145] Note: detected 160 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
2024-02-25:19:16:47,809 INFO     [utils.py:148] Note: NumExpr detected 160 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-02-25:19:16:47,887 INFO     [utils.py:145] Note: detected 160 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
2024-02-25:19:16:47,887 INFO     [utils.py:148] Note: NumExpr detected 160 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-02-25:19:16:47,897 INFO     [utils.py:145] Note: detected 160 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
2024-02-25:19:16:47,897 INFO     [utils.py:148] Note: NumExpr detected 160 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-02-25:19:16:47,904 INFO     [utils.py:145] Note: detected 160 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
2024-02-25:19:16:47,905 INFO     [utils.py:148] Note: NumExpr detected 160 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-02-25:19:16:47,905 INFO     [utils.py:145] Note: detected 160 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
2024-02-25:19:16:47,905 INFO     [utils.py:148] Note: NumExpr detected 160 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-02-25:19:16:47,906 INFO     [utils.py:145] Note: detected 160 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
2024-02-25:19:16:47,906 INFO     [utils.py:148] Note: NumExpr detected 160 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-02-25:19:16:47,937 INFO     [utils.py:145] Note: detected 160 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
2024-02-25:19:16:47,937 INFO     [utils.py:148] Note: NumExpr detected 160 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
2024-02-25:19:16:48,003 INFO     [config.py:58] PyTorch version 2.1.2 available.
2024-02-25:19:16:48,088 INFO     [config.py:58] PyTorch version 2.1.2 available.
2024-02-25:19:16:48,097 INFO     [config.py:58] PyTorch version 2.1.2 available.
2024-02-25:19:16:48,098 INFO     [config.py:58] PyTorch version 2.1.2 available.
2024-02-25:19:16:48,101 INFO     [config.py:58] PyTorch version 2.1.2 available.
2024-02-25:19:16:48,102 INFO     [config.py:58] PyTorch version 2.1.2 available.
2024-02-25:19:16:48,110 INFO     [config.py:58] PyTorch version 2.1.2 available.
2024-02-25:19:16:49,485 INFO     [__main__.py:162] Verbosity set to INFO
2024-02-25:19:16:49,485 INFO     [__init__.py:358] lm_eval.tasks.initialize_tasks() is deprecated and no longer necessary. It will be removed in v0.4.2 release. TaskManager will instead be used.
2024-02-25:19:16:49,558 INFO     [__main__.py:162] Verbosity set to INFO
2024-02-25:19:16:49,559 INFO     [__init__.py:358] lm_eval.tasks.initialize_tasks() is deprecated and no longer necessary. It will be removed in v0.4.2 release. TaskManager will instead be used.
2024-02-25:19:16:49,568 INFO     [__main__.py:162] Verbosity set to INFO
2024-02-25:19:16:49,568 INFO     [__init__.py:358] lm_eval.tasks.initialize_tasks() is deprecated and no longer necessary. It will be removed in v0.4.2 release. TaskManager will instead be used.
2024-02-25:19:16:49,589 INFO     [__main__.py:162] Verbosity set to INFO
2024-02-25:19:16:49,589 INFO     [__init__.py:358] lm_eval.tasks.initialize_tasks() is deprecated and no longer necessary. It will be removed in v0.4.2 release. TaskManager will instead be used.
2024-02-25:19:16:49,599 INFO     [__main__.py:162] Verbosity set to INFO
2024-02-25:19:16:49,599 INFO     [__init__.py:358] lm_eval.tasks.initialize_tasks() is deprecated and no longer necessary. It will be removed in v0.4.2 release. TaskManager will instead be used.
2024-02-25:19:16:49,607 INFO     [__main__.py:162] Verbosity set to INFO
2024-02-25:19:16:49,607 INFO     [__init__.py:358] lm_eval.tasks.initialize_tasks() is deprecated and no longer necessary. It will be removed in v0.4.2 release. TaskManager will instead be used.
2024-02-25:19:16:49,681 INFO     [__main__.py:162] Verbosity set to INFO
2024-02-25:19:16:49,[681](https://github.com/RWKV/lm-evaluation-harness/actions/runs/8040203638/job/21958032153#step:3:688) INFO     [__init__.py:358] lm_eval.tasks.initialize_tasks() is deprecated and no longer necessary. It will be removed in v0.4.2 release. TaskManager will instead be used.
2024-02-25:19:16:54,373 INFO     [__main__.py:238] Selected Tasks: ['anli']
2024-02-25:19:16:54,373 INFO     [__main__.py:239] Loading selected tasks...
2024-02-25:19:16:54,478 INFO     [__main__.py:238] Selected Tasks: ['anli']
2024-02-25:19:16:54,478 INFO     [__main__.py:239] Loading selected tasks...
2024-02-25:19:16:54,487 INFO     [__main__.py:238] Selected Tasks: ['anli']
2024-02-25:19:16:54,487 INFO     [__main__.py:239] Loading selected tasks...
2024-02-25:19:16:54,490 INFO     [__main__.py:238] Selected Tasks: ['anli']
2024-02-25:19:16:54,490 INFO     [__main__.py:239] Loading selected tasks...
2024-02-25:19:16:54,501 INFO     [__main__.py:238] Selected Tasks: ['anli']
2024-02-25:19:16:54,501 INFO     [__main__.py:239] Loading selected tasks...
2024-02-25:19:16:54,507 INFO     [__main__.py:238] Selected Tasks: ['anli']
2024-02-25:19:16:54,507 INFO     [__main__.py:239] Loading selected tasks...
  exitcode  : 1 (pid: 45813)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[2]:
  time      : 2024-02-25_19:16:59
  host      : 0c7aa106d18a
  rank      : 2 (local_rank: 2)
  exitcode  : 1 (pid: 45814)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[3]:
  time      : 2024-02-25_19:16:59
  host      : 0c7aa106d18a
  rank      : 3 (local_rank: 3)
  exitcode  : 1 (pid: 45815)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[4]:
  time      : 2024-02-25_19:16:59
  host      : 0c7aa106d18a
  rank      : 4 (local_rank: 4)
  exitcode  : 1 (pid: 45816)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[5]:
  time      : 2024-02-25_19:16:59
  host      : 0c7aa106d18a
  rank      : 5 (local_rank: 5)
  exitcode  : 1 (pid: 45817)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
[6]:
  time      : 2024-02-25_19:16:59
  host      : 0c7aa106d18a
  rank      : 6 (local_rank: 6)
  exitcode  : 1 (pid: 45818)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
------------------------------------------------------------
Root Cause (first observed failure):
[0]:
  time      : 2024-02-25_19:16:59
  host      : 0c7aa106d18a
  rank      : 0 (local_rank: 0)
  exitcode  : 1 (pid: 45812)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
============================================================

This error does not seem to occur with smaller unsharded models.
As such as a temporary work around, we would be avoiding sharding the checkpoint for the HF implementation.

Might be related to:
https://github.com/huggingface/transformers/issues/29251

After multiple back and forth trial and errors
The issue has been isolated to a folder name/test name with . in it, which coincide with the larger test file


Add missing content to submission page

What is the context of this PR?
Minor submission page content changes needed for the Eng/Wls Household and Individual census schemas. Changes described on this Trello card.
How to review
Check that the content changes match the checklist on the Trello card.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Missing content - Submission Page


Add new data type "array" ?

My goal here is to find a way to filter and aggregate on arrays of simple types, like arrays of strings or arrays of floats.
As I understand, one has to use cross reference data types  to be able to define arrays.
But it is not clear that aggregations can work on cross reference, while filters can.

@eostis Could you give an example? I don't fully understand the question.

Indeed.
On WooCommerce, a product can have multi-value attributes. For instance, it can be sold with colors ['blue', 'red', 'yellow'].
This product must be indexed with its 3 colors, and a facet on colors should appear in the search UI to displays available colors, with their respective counts. The colors can then be selected and used as a filter.
My question was:

Can we create a property 'color' with a data type 'array of strings' ?
Can we create a facet on the property color with the aggregation query?

If it is not possible, one could create a class 'Color', and use this class has a beacon on the 'Product' class.
But:
3) Can we filter 'Products' (it seems so) on the class 'Color'?
4) Can we create a 'Product' facet on the beacon 'Color' with the aggregation query?
A live Woocommerce example with multi-value tags and categories: https://demo-woocommerce-flatsome-kinsta.wpsolr.com/shop/

From a technical perspective an aggregation on cross-refs would be considerably more expensive than an array data type, so it'd be in favor of that. Especially if we limit it to arrays of primitives (e.g. string[], int[], number[], text[]) it should not be too complex to implement.
@eostis can you give an example of an array would be aggregated? For example on a count would we just count each occurrence as if it was it's own object? I.e. obj1.colors: red, blue and obj2.colors: red would be aggregated to red: 2, blue: 1, etc? Or are you looking for a different type of aggregation?

@etiennedi

I'd be in favor of arrays. Especially if we limit it to arrays of primitives

Indeed, an array of primitive types is good enough for my use cases.

would be aggregated to red: 2, blue: 1

Your aggregation example is correct.
Also, is it possible:

to build a slider range facet on numerics (the min and max should be returned by the aggregation) ?
to get a range facet on numeric: 0-10: 2, 11-*: 89

Also, is it possible:

I'd carefully say that anything is possible, but it's always a matter of prioritization among limited resources we have. Given that aggregations are more of a "secondary" feature of Weaviate, this might take some time until we get to it. What I mean is: Users come because of the vector search and having the ability to aggregate is a convenience feature. Worst case they'd have to use a different db for the aggregations, whereas for the vector search there aren't any / hardly any alternatives.
So, additional aggregation functions might be something that we design, but rely on an open source contributor for the actual implementation at the moment.
tl;dr: I'm all for improving aggregations, but it's a bit hard to prioritize at the moment. A well made pull-request would certaintly be appreciated and accepted.

This makes perfect sense.
One still can use Weaviate for instant search, Q&A, or similarities, while letting Lucene-based solutions take care of the faceted search.

As an additional requirement, if the schema settings for an array property have (or the default setting is) "moduleConfig": { "text2vec-*": { "vectorizePropertyName": true } } a string[] or text[] should be used in the vectorization process.
e.g.
name: Jane
Job: Ice Cream Parlor Owner

and
someTextArray: ["Jane", "Ice Cream Parlor Owner"]

would lead to the same vector (if the property names aren’t vectorized)

Would it be possible to consider all data types as array by default?
This is the behavior of Elasticsearch/Solr: a simple type is declared for a field, but this field will accept simple data and array data as well.

For the sake of simplicity and homogeneity, it would also be great to have an array types for all simple types.
According to https://www.semi.technology/developers/weaviate/current/data-schema/datatypes.html, the following types have no array types:

boolean
date
geoCoordinates
phoneNumber
blob


chore: import repository https://github.com/vnemane/gohttpaws.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


#1385 added new field to rotation gesture detector to watch overlay disable…

fixed UI jumps caused by gesture detector when it's rotation overlay is disabled and re-enabled

do you think we need a getter for isEnabled?


git commit :DDDDDDdd

👷 Deploy Preview for joyful-lokum-960ccc processing.

Name
Link

🔨 Latest commit
7b54270c2e77c210ce0b2b5d6f652e28f0052983

🔍 Latest deploy log
https://app.netlify.com/sites/joyful-lokum-960ccc/deploys/67202033a1f3500008d3b50c


Update overview page for 7.1

Update overview page for 7.1

Docs Build status updates of commit 59cecad:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

archived-reference/docs-conceptual/overview.md
:white_check_mark:Succeeded
View (>=powershell-3.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Can the Microsoft provide the shell or python version of prepost deployment powershell for ADF deployment?

Our Jenkins and Azure Pipeline self-hosted agent is hosted by Linux, the PowerShell scripts make the maintain is more difficulty.
So is it possible to provide the other programming language version of this powershell script ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36b2d75a-07c4-75b6-32d3-6e7dd78683f7
Version Independent ID: 57d29c39-e05f-b95d-de80-d81686935fc0
Content: Continuous integration and delivery pre- and post-deployment scripts - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-delivery-sample-script.md
Service: data-factory
Sub-service: ci-cd
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@zephoon
Thanks for your feedback! We will investigate and update as appropriate.

@zephoon
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly


Enhancement: Use of Labels

For labels within issues it would be nice to be able to map some labels (flag indicators really) to have meaningful text. For example in RHMWRT we use RT_MW_PROD_REL to indicate it is a product release issue.
Having a section such as
"lookups" : {
    "labels": {
      "Empty": "Features",
      "RT_MW_PROD_REL": "Product Release"
    }
}

Not the use of Empty to indicate those records without any labels (I think it says None at the moment) - we could use that instead of Empty if preferred

Accidentally closed it

Not the use of Empty to indicate those records without any labels (I think it says None at the moment) - we could use that instead of Empty if preferred

@markeastman re ^^ - None currently means it has absolutely no labels. If the absence of RT_MW_PROD_REL means it is a feature, I think this looks like another requirement. I'll ponder it in the back of my mind

What I mean is if you do a swim lane with labels then we get a lane per label, at the bottom we have a lane with the word None (Ie all the issues that have no labels at all), I thought it might be nice to allow the administrator to replace the word None with what ever they like, For us the absence of all labels means something specific - but I don’t think that is a good use!

On 6 Nov 2018, at 15:17, Kabir Khan<EMAIL_ADDRESS>wrote:
Not the use of Empty to indicate those records without any labels (I think it says None at the moment) - we could use that instead of Empty if preferred
@markeastman https://github.com/markeastman re ^^ - None currently means it has absolutely no labels. If the absence of RT_MW_PROD_REL means it is a feature, I think this looks like another requirement. I'll ponder it in the back of my mind
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/overbaard/overbaard/issues/64#issuecomment-436288882, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqw9bZsCYAUaSIYn_8VpXi9hgh0PDcyks5usaf3gaJpZM4YQpIb.

I can replace the text None with whatever as easily as the other ones. But to me giving empty or none special meaning beyond that sounds very fragile. If people start adding ad-hoc labels (e.g. Kabir-sprint1), then those would not appear in the empty swimlane and so they would not get that special meaning.

Agreed - the use fo having RT_MW_PROD_REL or not is not a good approach, I have suggested to John that if he wants to see them like that he could have RT_MW_PROD_REL and RT_MW_FEATURE to distinguish between which ones are field related features and which ones are product releases. - To tell the truth I am not 100% certain of what they really mean to the field, but that is someones else definition. Having the absence of labels should not be construed as anything other than no labels have been set yet.

On 6 Nov 2018, at 15:55, Kabir Khan<EMAIL_ADDRESS>wrote:
I can replace the text None with whatever as easily as the other ones. But to me giving empty or none special meaning beyond that sounds very fragile. If people start adding ad-hoc labels (e.g. Kabir-sprint1), then those would not appear in the empty swimlane and so they would not get that special meaning.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/overbaard/overbaard/issues/64#issuecomment-436303593, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqw9aqWEE4P15UP-yDWd1hhktOXCG0kks5usbDqgaJpZM4YQpIb.

@markeastman I know this kind of 'died'. But I've been thinking about it, and I think perhaps what we need instead is to be able to define swimlanes/filters manually (like Jira has) in addition to the automagic ones Overbård provides.
The pseudo config would be something like:
  "custom-selectors": [
    {
      "name": "Feature or Release",
      "options": [
        {
          "name": "Feature",
          "filter": {
            "types": ["Feature"],
            "labels": ["MW_BLAH_BLAH"]
          }
        },
        {
          "name": "Release",
          "filter": {
            "types": ["Feature"],
            "labels": ["!MW_BLAH_BLAH"]
          }
        }
      ]
    }
  ]

So each 'custom selector' would appear in the list of swimlanes/filters (e.g. 'Feature or Release' would appear next to Assignee, Priority etc.) and each of the options would be a swimlane/filter entry in that.
That would allow you more 'heterogeneous' choices for swimlanes at least. And although I've only used "types" and "labels" in the example I could add something similar for everything else. I believe this would solve your use-case, and even if you guys probably won't end up using Overbård, I think it would be useful to others. It would also be quite simple to implement, as it is mostly extending the filtering that happens in the UI.

I agree this looks interesting. It would solve our use case and be useful to others as well.
We are moving forward on the Jira overview project for runtimes and I think Overbård will be used on it as it offers a lot of additional visibility.

On 17 Dec 2018, at 17:53, Kabir Khan<EMAIL_ADDRESS>wrote:
@markeastman https://github.com/markeastman I know this kind of 'died'. But I've been thinking about it, and I think perhaps what we need instead is to be able to define swimlanes/filters manually (like Jira has) in addition to the automagic ones Overbård provides.
The pseudo config would be something like:
"custom-selectors": [
{
"name": "Feature or Release",
"options": [
{
"name": "Feature",
"filter": {
"types": ["Feature"],
"labels": ["MW_BLAH_BLAH"]
}
},
{
"name": "Release",
"filter": {
"types": ["Feature"],
"labels": ["!MW_BLAH_BLAH"]
}
}
]
}
]
So each 'custom selector' would appear in the list of swimlanes/filters (e.g. 'Feature or Release' would appear next to Assignee, Priority etc.) and each of the options would be a swimlane/filter entry in that.
That would allow you more 'heterogeneous' choices for swimlanes at least. And although I've only used "types" and "labels" in the example I could add something similar for everything else. I believe this would solve your use-case, and even if you guys probably won't end up using Overbård, I think it would be useful to others. It would also be quite simple to implement, as it is mostly extending the filtering that happens in the UI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/overbaard/overbaard/issues/64#issuecomment-447936624, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqw9UHmWlQ5lq9yH_dSy765Yp7TTC1nks5u59odgaJpZM4YQpIb.


Theme (BaseLight/BaseDark) doesn't change half the time and can't be set at startup

When I use either
ThemeManager.ChangeAppStyle(Application.Current,
    ThemeManager.GetAccent("Yellow"),
    ThemeManager.GetAppTheme("BaseDark"))

or
ThemeManager.ChangeAppTheme(Application.Current, "BaseDark")
the theme of my application doesn't change. I have to duplicate the line for it to work, even though when I use ThemeManager.DetectAppStyle, it says the theme changed.
It also doesn't work when the application is started up (in the Window.Loaded sub). The startup theme seems to be influenced only by the order in which the XAML files in Application.xaml are loaded. The accent color loads correctly. The theme change does however work when I press on a button that runs the commands. I have all the XAML files loaded in Application.xaml (accents and themes). I have tried doing this on version 1.0.0, 1.1.2, and 1.1.3-ALPHA149.
Any ideas on how to fix this?

Nevermind, found out it was an issue with other styles I had in Application.xaml. Sorry for the bother.


Rust: Don't borrow borrowed types

Fixes #673
This partially reverts a change now live in v0.12 that was introduced in #669. If a type has a lifetime associated with it, treat it as already borrowed and don't borrow again.

Thinking through this a bit now, one consequence of this is that the generation of this:
package foo:bar

world x {
  resource z

  record x {
    y: list<u32>,
    z: borrow<z>,
  }

  import the-fn: func(x: x)
}

changes. Before this PR this generates:
pub struct X<'a> {
    pub y: wit_bindgen::rt::vec::Vec<u32>,
    pub z: &'a Z,
}

pub fn the_fn(x: &X<'_>) { ... }

whereas after this PR it generates
pub struct X<'a> {
    pub y: wit_bindgen::rt::vec::Vec<u32>,
    pub z: &'a Z,
}

pub fn the_fn(x: X<'_>) { ... }

that means that this PR requires ownership of the Vec field whereas previously it wasn't required, and I think this was one thing I was trying to fix implicitly in #673 as well.

@alexcrichton sorry for the delay in getting back to you.
I've updated the code I'm working on from wit-bindgen 11 to 12 so we can see what the code ends up looking like. I think it's hard to argue that the generated code here is more idiomatic. Any thoughts on how we might keep the implicitness you desire while reducing the amount of double/triple borrows seen in the code I've linked to?

Well hey if we've already got double and triple borrows may as well go for the quadruple and legendary quintuple borrow while we're at it!
But no my main concern here is the runtime implications of the generated signatures as opposed to feeling that the current bindings are idiomatic (those clearly aren't). I think we should probably go back to what was there prior, like with this PR, but there probably needs to be affordances for resources to handle the case above I mention. I'm a bit frustrated with how I can't seem to ever settle on a strategy of types generated here (it feels like constant whack-a-mole), but such is the experience of developing a bindings generator!
If you've run out of time to work on this I can also poke around and see if I can't restore the bindings from before too

@alexcrichton I've rebased - I believe this is what we've agreed upon (i.e., the original changes). Perhaps we can revisit this with more targeted improvements in the future?

Sounds good!


Cow: Watch techfonist.com

Cow requests the watch of the watch_keyword techfonist\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

techfonist\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/262 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 6b731d7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Skip loading and printing plugins when running --help

You can reproduce using bundle exec fastlane --help | cat

why the cat at the end?

Because otherwise it's using less, you'd still see the plugins, but only after exiting 👍

💯


ARROW-9891: [Rust] [DataFusion] Made math functions accept f32.

Given a math function f,
Before this commit, f(f32) was computed using f(cast(f32 AS f64)).
After this commit, f(f32) is computed using cast(f(f32) AS f64).
Since operations on f32 are faster than on f64, this is a simple optimization.
The return type remains the same (f64).

@alamb , I did not want to open that discussion on this PR because the current optimization is already an improvement, regardless of our choice.
However, I do agree with you: I would also prefer keeping the types. The main issue for me of sqrt(f32) -> f64 is that this optimization only works for a single operation. E.g. the exp in exp(sqrt(f32)) is evaluated with input f64 because sqrt is mapped to f64. In other words, f32 is not really used in computations, as it is quickly absorbed into f64.
OTOH, as @andygrove pointed out in another thread, spark returns a consistent f64 regardless of the input type.


Cookies does not work with Pothos GraphQL & Bun

Describe the bug
Using Yogi and Pothos with the recommended cookie plugin from @whatwg-node/server-plugin-cookies gives two bugs:

Cookies er not being set in the browser
Cookies are not being flushed on the server (and hence shared between requests)

To reproduce:

Start a server using the snippet below
run mutation:mutation {
  set(value: "test 123456")
}

Restart server
Observe that the following query fails:query {
  get
}

Note: If the server is not being restarted, the cookies will stay in all subsequent requests. (we use cookies to store JWTs so that part os obviously critical).
From my perspective it looks like a cache that is not being properly flushed to the client.
The test setup:
import { YogaInitialContext, createYoga } from "graphql-yoga";
import SchemaBuilder from "@pothos/core";
import AuthzPlugin from "@pothos/plugin-authz";
import { useCookies } from "@whatwg-node/server-plugin-cookies";

const builder = new SchemaBuilder<{
    Context: YogaInitialContext;
}>({
    plugins: [
        AuthzPlugin,
    ],
});

builder.mutationType();
builder.queryType();

builder.queryField("get", t =>
    t.string({
        resolve: async (p, a, c, i) => {
            const cookieVal = (await c.request.cookieStore?.get("test"))?.value
            if (cookieVal === undefined) {
                throw new Error("No cookie set")
            }
            return cookieVal
        }
    })
)
builder.mutationField("set", t => t.string({
    args: {
        value: t.arg.string({ required: true })
    },
    resolve: async (p, a, c, i) => {
        await c.request.cookieStore?.set("test", a.value)
        return "OK"
    }
}))

const yoga = createYoga({
    schema: builder.toSchema(),
    plugins: [useCookies()]
})

const server = Bun.serve({
    fetch: yoga,
    port: process.env.PORT,
    hostname: "<IP_ADDRESS>",
  });

Your Example Website or App
https://codesandbox.io/p/devbox/falling-silence-3hphlr
Steps to Reproduce the Bug or Issue

Start a server using the snippet below
run mutation:mutation {
  set(value: "test 123456")
}

Restart server
Observe that the following query fails:query {
  get
}

Expected behavior
It is expected that:

The cookies is set on the client
The cookies is not store in the server

Screenshots or Videos
No response
Platform

OS: MacOS
Bun 1.0.12
"graphql-yoga": "^5.0.0"

Additional context
As written, it seems like cookie store is not flushed to the client, but is being persisted in the server.

Note: It could also be Bun that is the issue here.

Experiencing the same issue. 😕
Followed this documentation: https://the-guild.dev/graphql/yoga-server/docs/features/cookies

So if I follow you, this is not in particular linked to Photos ?
It's just because our documentation is using a non working boilerplate for Bun right ?
For now, this workaround seems acceptable, PR are very welcome!
For typing, HTTP adapter related types are defined here: https://github.com/ardatan/whatwg-node/blob/master/packages/server/src/types.ts


[JN-373] Add change password

Change password is currently implemented with a separate policy. The policy name comes from config fetched from the API, so this PR also contains those config plumbing changes.

The conditions under which the user is prompted to sign in when trying to change their password may be a little different than what I explained in https://github.com/broadinstitute/terraform-ap-deployments/pull/1066. I'm not 100% sure what the conditions are. I'm not terribly satisfied with my level of understanding of this -- I fully expect to get bug reports that will take a lot of fiddling to iron out -- but change password is there and generally works.
To test:

Restart participant API and UI
Sign in to https://sandbox.ourhealth.localhost:3001/
Open the profile menu and click "Change Password"
Change your password and make sure you end up back at the OurHealth portal
Sign out and make sure you are required to use your new password to sign back in

@devonbush FWIW, I think it's possible to get B2C to do more of what we want, but this is a workable starting point and we can improve it down the road if we choose to.


Jasmine requires Rails?

I just installed Jasmine into an empty gemset,
tried to run 'jasmine init', and got an error stating:
"Could not find rails (>= 3.0)".
Is this a known issue?

I forgot to mention installing Rails into the same gemset enables Jasmine to work correctly.

This is an existing issue in the Jasmine gem project. A pull request has been submitted, but hasn't been merged yet.

I believe Jasmine 1.1.1 fixes this. Let me know if you are still experiencing issues.
Thanks!


merge package from Kronos-Tools/npm-package-template

package.json

chore(devDependencies): add rollup-plugin-commonjs:^9.1.3 from template
chore(devDependencies): add rollup-plugin-node-resolve:^3.3.0 from template
chore(devDependencies): add rollup-plugin-executable:1.2.0 from template
chore(devDependencies): update semantic-release:^15.4.1 from template
docs(package): remove keyword null

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update Jetty to 9.4.29

Motivation
There are several CVEs reported on the version we're currently using (9.4.20): https://www.eclipse.org/jetty/security-reports.html.
Update to latest stable version.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Unable to Decrypt

Hello,
I received a notification from IRS however unable to decrypt. I received BAD DATA. I tried to manually decrypt using openSSL through the following commad:
openssl rsautl -decrypt -hexdump -in<PHONE_NUMBER>0.SL.422_Key privatekey.pam -out aeskey.txt
I Received the Following:
Enter pass phrase for privatekey.pem:
RSA operation error
24976:error:0407109F:rsa routines:RSA_padding_check_PKCS1_type_2:pkcs decoding e
rror:.\crypto\rsa\rsa_pk1.c:273:
24976:error:04065072:rsa routines:RSA_EAY_PRIVATE_DECRYPT:padding check failed:.
\crypto\rsa\rsa_eay.c:602:
Please suggest

Hi,
In your openSSL command you have privatekey.pam. Then in the message you receive back it's looking for a pass phrase for privatekey.pem. I don't know enough to know if it's supposed to be like that or not, but it stood out to me.

Hi,
Thank you for your post. After my review it is pem not pam sorry for the typo in my previous post.

Every time I have seen the Bad Data error, it has been a problem with the private key. For example, if I decrypt a packet and then change the private key to some random key and try again, it will give me Bad Data. And other methods, such as OpenSSL won't work for it either. So when both are bad, I suggest people double check the key being used.

Thanks Daniel,
Let's assume something went wrong during the encryption phase causing certificate mismatch, shall I encrypt and resend the payload again? Will it be refused by IRS? How shall I proceed?

No, it wouldn't be refused. If you take the exact same XML and package and send again, the worst you would get is an NDM error for duplicate MessageRefId. That would at least tell you that the initial file was received and we were able to process it. If it was received and we were not able to process it, you could get an NVF or some other code from the new file.

Thanks Daniel,
Below I'll elaborate more the issue I'm facing:
I'm sure that the private key I'm using in "Sender's private key" during encryption is the same private key that I'm using in the "Receiver's private key" during decryption. My private key is a global sign certificate in .pfx format. I'm also certain that it was not revoked or updated.
The public key used is a certificate in .cer format issued by encryption-service.services.irs.gov
Moreover, I used the same procedure with the same keys previously in 2015 but never faced decryption issues.
Is there any changes at IRS side? How shall I proceed ?

Can you send the alert information from the RC001 email to<EMAIL_ADDRESS>We can put in a ticket to get information from the logs which may help narrow down the error code.

Hello,
Sorry to jump in unannounced. I read in the comments that you are using
private keys all the time, and a reference to a public key at one point but
I am not sure how you are using it.
In brief, to encrypt you use the private key and to decrypt the public key.
You encrypt the messages you send with your private key.
Yo decrypt the message you receive with the public key from the sender.
Could that be the issue?
El 7 abr. 2016 8:52 a. m., "DanielCrouch"<EMAIL_ADDRESS>escribió:

Can you send the alert information from the RC001 email to
<EMAIL_ADDRESS>We can put in a ticket to get information from
the logs which may help narrow down the error code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/IRSgov/IDES-Data-Preparation-Dot-Net/issues/13#issuecomment-206878581

One thing worth mentioning again is to make sure that your private key corresponds to the enrolled public key in IDES. You can use the same private key for encryption and decryption, but if it doesn't match what is in IDES, it won't work. Just as a precaution, you can export the keys from your certificate and update it in IDES and then send a new packet through. It may not be your issue, but it happens a lot. I have seen people use our sender and receiver test keys that we have in our testpacket.zip file, thinking those were the correct keys. Usually it is a case of the IDES administrator updating the certificate in IDES and then not passing that information down to the technical team that does the packaging. Again, that may not be your case at all, but it helps rule it out. But with your alert information, I should be able to at least find out if the inbound decryption worked or not.

Daniel:
if I send an email to<EMAIL_ADDRESS>will your receive a copy?
Jachaos:
Process is like following:
**Encryption Phase: **

Opening the .Net application posted by Github
Uploading XML file
Uploading private Key (.pfx format, Global Sign 256 AES)
Uploading public Key (.cer format same certificate enrolled within IRS website)
Press "Sign and Encrypt XML"

**Uploading/Downloading Phase: **

Sign in IRS Gateway and Unload the .Zip file
Download the incoming .Zip file

Decryption Phase:

Opening the .Net application posted by Github
Unloading the downloaded .Zip file
Uploading private Key (.pfx format, Global Sign 256 AES)
Press "Decrypt Notification"

The result is message popup "BAD DATA"

Hello Anajdi
I think in the Decryption Phase should use the Public Key from the IRS
website, as you are trying to decrypt a message received from them.
2016-04-07 10:52 GMT-04:00 anajdi<EMAIL_ADDRESS>
Daniel:
if I send an email to<EMAIL_ADDRESS>will your receive a copy?
Jachaos:
Process is like following:
**Encryption Phase: **

Opening the .Net application posted by Github
Uploading XML file
Uploading private Key (.pfx format, Global Sign 256 AES)
Uploading public Key (.cer format same certificate enrolled within
IRS website)
Press "Sign and Encrypt XML"

**Uploading/Downloading Phase: **

Sign in IRS Gateway and Unload the .Zip file
Download the incoming .Zip file

Decryption Phase:

Opening the .Net application posted by Github
Unloading the downloaded .Zip file
Uploading private Key (.pfx format, Global Sign 256 AES)
Press "Decrypt Notification"

The result is message popup "BAD DATA"
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/IRSgov/IDES-Data-Preparation-Dot-Net/issues/13#issuecomment-206940023

Hi,
Surely the IRS would sign with their private key and encrypt with your
public key.  That way ONLY you the intended recipient can un-encrypt the
message and you would know for certain it came from the IRS.
Andrew
On Thursday, 7 April 2016, Javier Chaos<EMAIL_ADDRESS>wrote:

Hello Anajdi
I think in the Decryption Phase should use the Public Key from the IRS
website, as you are trying to decrypt a message received from them.
2016-04-07 10:52 GMT-04:00 anajdi<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>:

Daniel:
if I send an email to<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','lbi.fatca.ides@irs.gov');> will your
receive a copy?
Jachaos:
Process is like following:
**Encryption Phase: **

Opening the .Net application posted by Github
Uploading XML file
Uploading private Key (.pfx format, Global Sign 256 AES)
Uploading public Key (.cer format same certificate enrolled within
IRS website)
Press "Sign and Encrypt XML"

**Uploading/Downloading Phase: **

Sign in IRS Gateway and Unload the .Zip file
Download the incoming .Zip file

Decryption Phase:

Opening the .Net application posted by Github
Unloading the downloaded .Zip file
Uploading private Key (.pfx format, Global Sign 256 AES)
Press "Decrypt Notification"

The result is message popup "BAD DATA"
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
<
https://github.com/IRSgov/IDES-Data-Preparation-Dot-Net/issues/13#issuecomment-206940023

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/IRSgov/IDES-Data-Preparation-Dot-Net/issues/13#issuecomment-206941192

Yes, I will have access to the email. One other thing to check, make sure you decrypt into an empty folder so that the program isn't trying to grab an incorrect key.
We use the enrolled Public Key in IDES to encrypt. So the receiver needs to use their corresponding Private Key to decrypt. Otherwise, anyone with the IRS Public Key could decrypt. This will reveal the AES key which is used to decrypt the payload file.

Hello again,
thank you for your posts and thank you for opening for us a ticket.
After assessment and based on your comments, I have noted that the private is not correspondent to the public Key I'm using in the .NET application and the one uploaded at IRS website. They are totally different certificates, I think that's the issue.
By the time you are reviewing the RC001 notification I'm going to do the following:
1- Split my PFX certificate into private and public key using OpenSSL
2- Update public key within IRS Website by uploading the new public key
3- Go again through the encryption process and upload the same XML file uploaded before through IRS Gateway website
4- Wait IRS load and decrypt
Is there anything wrong by doing so ?

No, that sounds like exactly what you need to do. I haven't seen the results of the ticket yet, but if there is a mismatch, your file would have never processed through. I would suggest following those steps and seeing what happens.

I did the above steps and finally able to decrypt but received Fatca notification with NDC error.
The solution was as following:
Download the certification offered by IDES website and use it within the .NET application.
Thank you all for your comments and special thanks for Daniel :+1:


GUI implementation

Discussion here
https://blog.jessfraz.com/post/docker-containers-on-the-desktop/
Suggested parameters:
    -v /tmp/.X11-unix:/tmp/.X11-unix \ # mount the X11 socket
    -e DISPLAY=unix$DISPLAY \ # pass the display
    --device /dev/snd \ # sound

to be tested

an implementation by beast2's authors found here. Uses vnc locally to send through the GUI.
https://github.com/CompEvol/beast2/blob/master/Dockerfile


Support composite folding strategy

it would be nice to allow users to use both indentation and foldingProvider at the same time. It will be even nicer to support full composite power to enable/disable foldingProvider and indentation.
For instance, see https://github.com/zokugun/MrCode/blob/master/docs/settings/editor.foldingStrategy.md#composite-strategy

Merging the ranges of two providers is not easily possible if the ranges overlap. All we currently have (TypeScript, HTML, CSS, Markdown, JSON, ...) would all conflict.


Admin Login – Show plain failure notification when user account locked

Show plain failure notification when user account locked
As an admin user
I don't want to see an "account locked" notification when I fail my login too many times
in order to prevent hackers from being able to enumerate the valid accounts on the app
Scenarios
Given I am a legitimate user
When I enter the right email with the wrong password once
Then I expect to see an "Invalid username or password" message
Given I am a legitimate user
When I enter the right email with the wrong password five times
Then I expect to see an "Invalid username or password" message
And I expect to receive an email informing me that my account has been locked
Given I am a malicious attacker
When I enter an invalid email or wrong password once
Then I expect to see a "Invalid username or password" message
Given I am a malicious attacker
When I enter an invalid email or wrong password five times
Then I expect to see a "Invalid username or password" message
Given I am a malicious attacker
When I enter a valid email with the wrong password five times
Then I expect to see a "Invalid username or password" message
And I expect the legitimate user to receive an email informing them that their account has been locked
BUSINESS RULES

The DfE service team has asked that a record should be kept of 'who and when the account is accessed'.

Currently with @dgamblin3008 to investigate about what mail server to use to send the email

I identified the person in Technology Directorate responsible for mail servers, his name is Chris Gradden. We had a meeting on 16/09/2020, where he agreed to send me an email of next steps, which I haven't yet received.

On Chris Gradden's advice I applied for a 'service account' for F&E, that has access to the DFE mail server. A further meeting was held with Chris on 16th October, where he provided me and Cristina with the mail server details. The service team has asked that a record should be kept of 'who and when the account is accessed'.

We have been unable to get this to work. There appears to be something in the setup of the DfE servers that doesn't permit the sending of automated emails. Chris Gradden , email server administrator, and Julian Holland, Cyber Security Officer, advised we meet with Angie Paylor, IT Infrastructure Team Leader. Angie passed it to two of her staff, Nic Leroux and Morne Derckson, but they've been unable to come up with a solution.
So, we'll present a plain failure notification when a user submits a wrong username or password but can't sendf an automated email to admin users to say their account has been locked. Instead, we will make sure admin users know the situation with regard to locking their accounts (5 attempts with an incorrect password locks the account for 20 minutes), and the admin guidance will be updated to reflect this.

@cacquani I've updated the ACs to remove the reference to an automated email. thanks.

Tested and passed. Will get users to do UAT.

Passed UAT and released to production. Post release checks passed. Ticket closed.


popup_setoptions() resets the window-local 'signcolumn' option of that window

Describe the bug
Changing popup window options with popup_setoptions() always resets the signcolumn option of that window. This does not happen for the number option.
To Reproduce

Run vim --clean -S test.vim withlet g:winid = range(1, 5)
        \ ->map({_, i -> repeat('test ', i)})
        \ ->popup_create({'minwidth': 40})

call setwinvar(g:winid, '&signcolumn', 'yes')
call setwinvar(g:winid, '&number', 1)

Now set one of the popup options, for example call popup_setoptions(g:winid, {'zindex': 1000}), and redraw the screen with CTRL-L.
Result: The signcolumn has been disabled.

Expected behavior
Since the number option of that window is kept the same, I would have expected the same behavior for signcolumn.
Environment
Vim version 8.2.1287

Can confirm.


[Question] Do you only use Fussillade in Get methods or do Post/Delete etc also benefit?

Hi Paul,
Small question regarding the use of Fussillade. Do you design your API client service POST/DELETE/etc methods also with a priority parameter? In other words, do you differentiate between background/user_initiated for non-GET methods?
I tend to think those non-GET methods should also be as quick as possible... so always user_initiated.

POST/DELETEs don't get cached or deduped, but they can still be prioritized. Whether that makes sense depends on your app


Shibboleth Project Status Submission

Submission Template
Please provide the following information.

Vendor Name: Shibboleth
Product Name: All Products
Version(s) affected: Identity Provider >= 3.0, All other software versions
Status:  Not Affected
Update Available:  No
Notes: Third parties that package our software in various forms may introduce this library and thus create a vulnerability, and deployers are generally responsible for their own servlet container environment, and could introduce the problem themselves.
References: https://shibboleth.net/pipermail/announce/2021-December/000253.html
Last Updated: 2021-12-15

This product has been added to the repository. Thank you.


YFG6

Use the preview tab to see the example given below. Edit the relevant information and preview the changes before submitting. You may delete these instructions.

Key
Value

ID
YFG6

Source
Vaaran Bhai Gurdas Ji

Page
26

Line
mhwdyau AauDUqu hY; kvlwsix Awsix rskylw [

Correction
THIS ≠ THAT

PROOF (EDITION)
Image:

Correction:
rskylw ≠ rs kylw
Proof:
Vaaran Bhai Gurdaas Ji | November 2011 | Shamsher Singh Ashok | SGPC, Sri Amritsar
Image:


Instance segmentation

Looking forward to instance segmentation!

Looking forward to instance segmentation!

Instance Segmentation will be released at the same time with detection, refer to link

What's the prompt in semseg?

What's the prompt in semseg?

Now the semseg prompt is none, I will implement prompt part later, your are welcome to submit PR for that


Toggling of Non-Contiguous Line Legend Adds a Data Point

When the legend item is toggled off and then on again for a non-contiguous line, a random point will appear at the bottom of the graph.
When the legend item is toggled back on, no new points should be added to the graph

We have to handle the y = null case in this inside the clickHandler
 const point = canvasSVG         .selectAll(.${styles.point}[aria-describedby="${item.key}"]`)
.attr("aria-hidden", legendSelected);
point.each(function(node) {
if (node.y !== null) {
d3.select(this).attr("aria-hidden", legendSelected);
} else {
d3.select(this).attr("aria-hidden", true);
}
`

Is it required to render the data point with y value as null in the DOM?
cc / @abhijit945

@pranav300 Yeah I agree, we shouldnt render the data point in the first place.
@Prashant-Kamboj Can you think of doing the same for bubble? I dont think we would even need to do the processing in clickHandler if there is no data point in the dom

Yes, I will handle in that way I will not add any bubble point in the DOM if the value is null.

:tada: This issue has been resolved in version 1.21.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


 My devices don't ping openwrt for dns. I have something similar to pihole and can see this happening every minute.

Maybe it is one of the preinstalled services.
just a guess.

It seems that has some services keeping  check some DNS list, but I didn't find any on OpenWrt.
Can you  leave the OpenWrt alone to  uplink to pihole for a  check?


Add to docs

Assigned team: @CollectionFS/doc-masters
(why can't we assign teams @github?)
You are welcome to add comments and references to and what need to be better documented :)
NOTE: All discussion comments will be removed and items added on the todo list.

Todo status:

[x] Test wiki pages for documentation options
[x] #561 - On Meteor deploy to *.meteor.com we can't use the filesystem SA - the filesystem is reset at every deploy (added in package README)
[ ] Add documentation in wiki - guide about contributing reg. issues etc.

#561 - On Meteor deploy to *.meteor.com we can't use the filesystem SA - the filesystem is reset at every deploy

Hey Morten! I did some refactoring of the docs in the standard-packages README and created a PR if you want to have a look. Essentially, I moved some portions into some Wiki pages. I also tried to rearrange some paragraphs to hopefully make it a little more understandable for new users.
Should we move the standard-packages README to the mail repo README?
(I also added the *.meteor.com note to the filesystem package)

Just merged :) looked good - I think its a good idea to move much of the docs from standard-packages to the main repo (much of it is general intro stuff - should perhaps be ultra slim and reference the wiki's)
I think the wiki's looks good - we should prop. customize the toc at some point - but for now it's fine :)
(I'll have to get some t-shirts printed soon...)

What's the state of this document:
https://github.com/CollectionFS/Meteor-CollectionFS/blob/devel/packages/standard-packages/ADVANCED.md
Seems like a good starting point for new adapters. It mentions some internals of the DPP upload method. Does it apply for the HTTP method as well? Because then I would drop the DDP references to not confuse people.

I think so too, the ddp work, but it's not recommended

@wursttheke, I've kept it updated somewhat, but not all of it is accurate. We don't recommend the DDP upload pkg anymore, but the HTTP package works similarly. It's a good starting point for developer docs that we should create at some point.

There's been some confusion over the allow/deny rules requirement for uploading that I've noticed as issues in the repo, and as questions elsewhere. The Getting Started which should contain a basic end to end example, only briefly mentions this at the bottom.
Also exporting the AWS keys as env variables, detailed in the S3 package readme needs to be brought into the wiki.

Also it doesn't look like debug mode is documented

Good points @rhyslbw. Anyone can edit the wiki. :)

re: Debug Wiki location
Any objections to listing it as #1 item on the Getting Started page? Having that turned on is one of the best ways to understand the processes

@rhyslbw sounds good to me


[WIP] Watch test refactor

What this PR does / why we need it:
This is attempt into making watch e2e test more stable
NONE

/retest

/retest

/retest

/retest

/retest


build bundle

Rename folder for the bundle (and index)
Import operator-fetch-payload from cpaas…
Run fetch-operator-upload to get a recent version.
Fix bundle Dockerfile

/approve
/lgtm


Add seandewar/killersheep.nvim

Checklist:

[X] The plugin is specifically built for Neovim.
[X] The lines end with a .. This is to conform to awesome-list linting and requirements.
[X] It's not already on the list.
[X] If it's a colorscheme, it supports treesitter syntax.
[X] The title of the pull request is Add `username/repo`  when adding a new plugin.

:sheep:

Thanks for the PR!


pulling down permit information, making final combined data structure

Need to update readme with schema of data structure of the categories, types, and permits.
This also utilizes angular 2 Observables to simultaneously make two requests to each required endpoint and start processing the data only once both requests have returned successfully.

@ajcrites let's sync up at some point to figure out how to combine your clean up changes (which look good) and this PR since it now uses two Observables instead of one (two simultaneous http requests) and basically creates the final data structure that has all the information I think we should need

It seems like the correct number of requests are sent now...not sure what was causing the duplicate behavior.

In order to preserve simplicity I'm going to close this PR. I would like this code to be approachable and the above implemented methods don't improve readability or performance. While there are many less lines of code, essentially the .map and .groupBy functions are iterators and therefore the time complexity of the solution seems roughly equivalent to the originally proposed solution, using for loops.
While the for loops aren't as pretty, I believe they are more approachable by new developers because they are platform agnostic. This can always be adjusted later, but for the sake of finishing the service layer and moving on to actually displaying the data in a useful way on the frontend, I'm going to close this and reopen a slightly cleaner version of the original code I had proposed for this PR.


Outbound traffic sankey diagrams

Depends On: https://github.com/leoluk/NetMeta/issues/44
Once we have the AS paths, it's trivial to build a Sankey diagram for egress traffic. Might require a server-side component to feed something like this: https://github.com/kumaravel29/grafana-sankey-panel

Done already


Track release goals with GitHub milestones

Part of being in the kubernetes-incubator is regular releases and conveying the development roadmap. While the README has a section about this, it's pretty out of date, and only addresses extremely high level goals.
As discussed on the #kompose slack channel, consider using GitHub milestones to address this.
cc @dustymabe @sebgoa

great idea Eric, @sebgoa can we come up with a list of things that can be achieved via a F2F meeting at kubecon? coming up with a list of milestones would be a good thing to do there when a part of the team is meeting face to face.

yes, I will remove the roadmap in the README in a small PR.
I created 2 milestones and labels....now we need to tag the issues properly to fill up the milestone.
Still need criteria that trigger the actual release...

@sebgoa thanks! Couple of follow up todo's before I close this issue.

Someone should update the README to refer to the milestones.
It seems odd to have a point release milestone since kompose only has one branch. How would you release 0.2.1 features without 0.3.0 features commit to master getting in.
There need to be more high level feature issues. As @dustymabe pointed out kubecon might be a good place to spec some of these out.

no need to close. This was just a five minute thing.
We need a release process and and write up about how to tag issues and create milestone.

cc #315


Implementing Active Directory Certificate Services in Windows Server 2016 - lab configs Pluralsight Course

Hoping the config files for this Pluralsight course are still available for PS-AutoLab-Env.
They ref the POC and Test files in the video.
The course - Implementing Active Directory Certificate Services in Windows Server 2016
Configs - Test-SingleServer, POC-MultiRole

Those configurations are no longer offered or supported. I think you can use the MultiRole-Server-2016 and SingleServer-GUI-2016 configurations.


Can we avoid PIL

Hi I see that PIL is still imported in the vision module.
Would be nice an easy to avoid it so that we only used opencv
What do you think ?

Discussions about the development should be done in the forum, thanks!


This package requires yarn >1.15.1, seems really aggressive

I'm not sure what features are required from recent releases of yarn, but this makes it so that all your consumers will have to have a yarn version above 1.15. This likely isn't the most friction free way to consume this library. Perhaps you don't need this requirement?

Thanks very much for letting us know! We didn't realize that engine requirement was transitive; I'd mistakenly assumed it just applied to folks directly developing this project. We'll loosen the requirement :)


Inline blame is completely obscured if cursorline is turned on

Is your feature request related to a problem? Please describe.
The inline blame is completely invisible if cursorline is turned on, since the color of the blame text and the color of the cursorline are the same. I'm assuming that this is not an issue with all colorschemes, but I would imagine it would be an issue with many.
Describe the solution you'd like
A config option to change the color of the text or providing a default that is less likely to be obscured would both work.
Additional context
I am using Neovim 0.5 with this fork of the nord theme that has support for treesitter.

I tried a selection of colorschemes and only nord had this issue:

lewis6991/github_dark.vim
lewis6991/moonlight.vim
joshdick/onedark.vim
folke/tokyonight.nvim
shaunsingh/nord.nvim
chriskempson/base16-vim

A config option to change the color of the text

You can already customize this since the current_line_blame has its own highlight GitSignsCurrentLineBlame, you just need to define it. Something like highlight link GitSignsCurrentLineBlame Visual will work. You may want to raise a PR for nord to fix this.

As a note, I also have this issue with Dracula

As a note, I also have this issue with Dracula, using highlight link GitSignsCurrentLineBlame Visual fixed it 👍

For anyone that wants to set this with lua:
vim.api.nvim_set_hl(
  0,
  "GitSignsCurrentLineBlame",
  { link = "Visual" }
)


Router: Getting params object before handing request over to functions

Hi there..
my application is pushing a request through some common middlewares before actually handing it over to the router and matching the route.
The routes are containing parameter like ":test" and i need some of those values in a common middleware (ACL).
Is there a way to use the buildin function of the router that fills the parameter object to get them up front and outside of the target function of the router?
Something like:
var app = express.createServer();

app.use(function (req, res, next) {
    console.log("Name:"+app.getParams(req.url).name);
    next();
});

app.get('/hello/:name', function(req, res){
    res.send('Hello '+req.params.name);
});

I think what you want is app.param( ... )


Vouchers types

Vouchers updated - as talked about with @darekg11

Vouchers updated - as talked about with @darekg11

Hey, I've made requested changes.

Changes pushed. I want to wait with testing this seralization - i would like to merge other types and then make those tests (because right now i would need to install this additional Qs package for every branch)


Image Dimension reviews

define image_height and image_width based on the dimensions of your input images. Typically, you would specify these values to match the size of your images. For example:
image_height = 224  # Height of the input images
image_width = 224   # Width of the input images
You should define these variables before using them in your model architecture. Adjust the values of image height and image width according to the dimensions of your actual images.
What if I have Image dimensions that are different and various ?

Working on a .py script that resizes all the images to 1600 width and  1079 hieght

Created a .py script to automaticly resize images to better help train the AL model to learn


Atualiza valores dos formularios a partir do objeto values

Let's Say we have some credit card in our database and we want to edit it using this card form. I was struggling with this issue and found out that when I passed the values  prop to the CreditCardInput nothing would happen.
Also, I tried to use additionalInputsProps as suggested in the readme:
 <CreditCardInput
    ...other props
    additionalInputsProps= name: {
    defaultValue: 'Tony Stark',
 } />

But still the values I passed were reflected in the form or cardView. So, I noticed that in the connectToState.js the values were only injected or passed to the CreditCardInput component if the user manually changed the TextInputs values. So What I did to fix this was setting the values in the componentDidMount:
// src/connectToState.js
componentDidMount = () => setTimeout(() => {
   this.props.autoFocus && this.focus("number");
   this.setValues(this.props.values); // Added this line to initially set default values to form
});

So now, using the component like this works fine:
<CreditCardInput
      ...
      values={{
       name: "Tony Stark",
       number: "4111***111",
       expiry: "12/22",
       cvc: "122"
     }}

I'd like to continue using and contributing with this repo. Also, I need this change/feature in order to finish a project I'm working on...So it'd be great if you upgrade the rpm version so I don't have to use it locally.
Nice work, keep it up!

Sorry, I was working on something else and pushed to the master branch. For this pull request I just modified one file.
By the way, I finished feature I that I needed for a project and I want to know if I could open another PR for that, if it interests you. I added a flag so that the user can change the direction of the credit card form to vertical/horizontal. What do you think ?

@quixote15 Sure, it's a good feature, if you could, open a PR.


Doesn't work with ember-cli 2.4.3

I'm interested in your addon.
I did some tests and I can't use it with the last version of ember-cli.
I found app.vendorStaticStyles and app.legacyFilesToAppend are always empty.
Can you fix it?
Thank you.

Yep. I will check, thx for feedback

Just adding a +1 to say that it would be awesome if this could be fixed. I would also really like to use it with ember-cli-fastboot, but I think it should just work if this issue is solved.

Hi, is there any update on this ?
Thank you

Not working with Ember 2.9.1 as well.


Remove InstanceId when Scene Despawn

Objective

Fix #12746
When users despawn a scene, the InstanceId within spawned_scenes and spawned_dynamic_scenes is not removed, causing a potential memory leak

Solution

spawned_scenes field was never used, and I removed it
Add a component remove hook for Handle<DynamicScene>, and when the Handle<DynamicScene> component is removed, delete the corresponding InstanceId from spawned_dynamic_scenes

Fixex one leak. We still leak in spawned_instances. You'll have to pass the instance id into SceneSpawner::despawn_instance.

Handle

If calling SceneSpawner::despawn_instance, the user removing the Handle<DynamicScene> component would cause the entity to be despawned, and I'm not sure if this is appropriate.

It shouldn't despawn_instance will eventually through despawn_queued_instances will despawn the scene instance. It shouldn't despawn the parent entity itself. If you're removing the scene handle from an entity you're likely trying to despawn the scene.

It shouldn't. despawn_instance will eventually through despawn_queued_instances despawn the scene instance. It shouldn't despawn the parent entity itself. If you're removing the scene handle from an entity you're likely trying to despawn all the entities in said scene.

Additionally, if the user calls despawn_recursive, it could lead to a repeated despawn action, resulting in a warning.

We will still leak in spawned_instances when we're removing normal scene handles. Another suggestion I have. If there are no more instances of a dynamic scene we should despawn it.

It shouldn't. despawn_instance will eventually through despawn_queued_instances despawn the scene instance. It shouldn't despawn the parent entity itself. If you're removing the scene handle from an entity you're likely trying to despawn all the entities in said scene.

Additionally, if the user calls despawn_recursive, it could lead to a repeated despawn action, resulting in a warning.

The just remove the instance from spawned_instances. Don't forget to do the same for normal scenes.

removing from the 0.13.2 milestone as this use components hooks from https://github.com/bevyengine/bevy/pull/10756 which are not available in the 0.13


X button is missing in Tag element

Create/Open a Maps and apps Gallery application in dev environment

Click on a Tag element. Notice there is no 'x' button.
Note: Issue is seen on all browsers. Can't be reproduced in production.
![image](https://cloud.githubusercontent.com/assets/3836616/15163456/6efde56a-16bd-11e6-9411-6e30df5f8205.png)

Production environment

x button restored


Move registry_resolver/ci_ffi_build to registry_resolver/static

Added static flag to skip protobuf generation and put out a warning in stdout in rr build.rs
Renamed the function signature for rr to be infallible for the static feature flag
Ran cargo update && cargo clippy --fix

@mkatychev Can you lmk when this PR is ready for review btw? Or is it ready to review as is?

@LuisOsta , I've moved this PR to draft as the underlying solution was resolved in https://github.com/knox-networks/ssi/pull/142
SSI is now playing nice with Nix 😄, take a look at the discussion thread linked in the PR above for more context on OUT_DIR.

Okay awesome sounds good, I'll follow that discussion thread

Resolved by protofetch work


Unable to pull empty ink cartridges from printer

You are unable to pull ink cartridges from printers. It will give a "target does not exist" error for both printer.pushItems() and chest.pullItems() despite the computer recognizing both peripherals as existent and are able to push ink cartridges into the printer.
Steps to recreate:

Refuel a printer and leave the ink cartridge in
Try and remove the ink cartridge and put it into a chest with the pullItems or pushItems function

Expected behaviour:
Being able to remove ink cartridges put into a printer with Lua

The issue was the modem wasnt on the same network as the printer


Try another documentation tool

The hugo template I used is fine but I think having search will be great and it has been kind of a pain to add new pages and stuff. So going to mark this down as something I want to consider changing.
Requirements:

Must support markdown content files ( cobra and my own gen command generate markdown files )
Must support github actions/github pages ( pretty easy )
Should have built-in or optional support for searching
Should integrate with vhs built animations #467
more?

Ideas:

GitBook

Take a peek at docusaurus if you feel adventurous, of if you want to get up and running quick....
I have mage fully quote with notes.sheldonhull.com. You can look at https://github.com/sheldonhull/digital-garden and if you clone and run mage you'll see the dockerized mkdocs run, build, serve. The github actions use this too.
This mkdocs powered site is one of the best for "plug and play" docs.
Docusaurus (I've been testing migration to this as well on my own knowledge base) is also very promising out of the box.
I'd be willing to take a swing at a draft mkdocs based site using what I've built on my own if you like, if you aren't in a rush.

I have mage fully quote with notes.sheldonhull.com. You can look at https://github.com/sheldonhull/digital-garden and if you clone and run mage you'll see the dockerized mkdocs run, build, serve. The github actions use this too.
This mkdocs powered site is one of the best for "plug and play" docs. Docusaurus (I've been testing migration to this as well on my own knowledge base) is also very promising out of the box.
I'd be willing to take a swing at a draft mkdocs based site using what I've built on my own if you like, if you aren't in a rush.

Yea I think I will go back to my usual material mkdocs setup, Docusaurus seems fine but using React feels a bit excessive for my needs.

For anyone curious or for my future self, the tedious part about this conversion comes from the custom markdown generation I built as part of make gen and how it builds docs for the configuration and potentially the cobra CLI gen. There are also some custom work done as part of the template on top of that for adding code links and share links.

The branch I mentioned has functional mkdocs invoked by Mage.
However, I've been sticking so far with hugo as well.
While it's not perfect, I was able to reproduce the tree view on the side and give myself some flexibility.
Might consider this if you want to keep your custom rendering but just restyle some things.
Personal docs example
I've got things to update and improve, but overall I've decided to stick with hugo rather than try to fit in the mkdocs world due to my custom content.

I was recently starting a new project and started from scratch with mkdocs and I like it a lot. Hugo has been great but a lot of the hard work is done by themes and I just couldn't really get behind any of the themes. Material for Mkdocs is just too good in my opinion. There are a few like astro and docusaurus that make sense if you are a javascript project, but for plain markdown material for mkdocs is the go to for me.
https://github.com/miniscruff/scopie has all the stuff I want to use, I just need to swap some codegen stuff around and I should be all good.


Angular18 compat

I figured you could merge the other one, build and publish, then merge this one and repeat.

Thank you for the update


Add support for WithValidation with OnEachRow

Requirements
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Mark the following tasks as done:

[x] Checked the codebase to ensure that your feature doesn't already exist.
[x] Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
[ ] Adjusted the Documentation.
[ ] Added tests to ensure against regression.

Description of the Change
This adds support for WithValidation when using OnEachRow, so you can use both validation and custom persistence.
Why Should This Be Added?
This previously was not possible, and validation was only supported when using ToModel.
Benefits
Support for validated data on custom persistence.
Possible Drawbacks
Possible performance impact due to additional processing.
Verification Process
The code was run locally against an existing importer to achieve the desired results.
Applicable Issues
Refs https://github.com/Maatwebsite/Laravel-Excel/issues/2364

I have not but I’ll commit to updating it within a week.

@patrickbrouwers I've updated the code but I'm not sure how to match the StyleCI code style. Is that something resolved after the PR is merged?

@hotmeteor I think it will fix it after merge yes, so no worries

Apologies for the reversion. I was testing it against a huge dataset and accidentally forgot to clean it up. I’ll do it here shortly.

No problem! Thanks!

@patrickbrouwers Updated

@hotmeteor Thanks for the changes. One last thing, can you update the WithValidationTest with a test case of OnEeachRow?

Any update on this getting merged?

@devonmather @patrickbrouwers Working on it right now.

@patrickbrouwers Test added.

Is there an example of how this pull request works with the onEachRow trait. Currently I have the following.
<?php

namespace App\Imports;

use App\Product;
use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\ValidationException;
use Maatwebsite\Excel\Concerns\Importable;
use Maatwebsite\Excel\Concerns\OnEachRow;
use Maatwebsite\Excel\Concerns\SkipsFailures;
use Maatwebsite\Excel\Concerns\SkipsOnFailure;
use Maatwebsite\Excel\Concerns\WithHeadingRow;
use Maatwebsite\Excel\Concerns\WithValidation;
use Maatwebsite\Excel\Row;

class ProductImport implements OnEachRow, WithValidation, WithHeadingRow, SkipsOnFailure
{
    use SkipsFailures, Importable;

    public function onRow(Row $row)
    {
        $row = $row->toArray();

        $product = Product::firstOrNew([
            'id_from_brand' => $row['id_from_brand'],
        ]);
        $product->title = $row['title'];
        $product->description = $row['description'];
        $product->save();

        if($row['thumbnail']) {
            $product->addMediaFromUrl($row['thumbnail'])
                ->toMediaCollectionOnCloudDisk('thumbnails');
        }
    }

    public function rules(): array
    {
        return [
            'id_from_brand' => 'required',
            'title' => 'required',
            'thumbnail' => 'sometimes|required|url',
        ];
    }
}

and the following test.
/** @test */
public function a_csv_file_requires_product_title()
{
    $import = new ProductImport();

    $import->import(base_path('storage/testing/product/error--title-required.csv'));

    $this->assertEquals(1, $import->failures()->count());
    $this->assertEquals('title', $import->failures()[0]->attribute());
}

error--title-required.csv Contents
title;description;thumbnail
;;

Unfortunately, the test assertion is failing. "Failed asserting that 2 matches expected 1." Are there any examples of this trait in action. Currently it feels like various traits are conflicting with each other when it comes to validation :/

Traits look fine, are you on 3.1.18?

Yep, have confirmed with composer show maatwebsite/excel
name     : maatwebsite/excel
descrip. : Supercharged Excel exports and imports in Laravel
keywords : PHPExcel, batch, csv, excel, export, import, laravel, php, phpspreadsheet
versions : * 3.1.18
type     : library
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
source   : [git] https://github.com/Maatwebsite/Laravel-Excel.git d0231ab1f4bb93c8695630cb445ada1fdc54add0
dist     : [zip] https://api.github.com/repos/Maatwebsite/Laravel-Excel/zipball/d0231ab1f4bb93c8695630cb445ada1fdc54add0 d0231ab1f4bb93c8695630cb445ada1fdc54add0
names    : maatwebsite/excel

Modifying my source code of the package as follows in the link below seems to have fixed my issue with validation not working correctly. Can you confirm if that is a required fix?
https://github.com/Maatwebsite/Laravel-Excel/pull/2371/files#r374351893

At first glance, I think you are right


Switch back to automatic Debug derive for Header struct

The Header Debug implementation was accidentally printing the size
field for the signature. Rather than just fix that field, switch the
whole thing back to using derive(Debug). This adds in the _reserved
field, which probably doesn't matter much either way but might as well
show the whole struct when debug printing.

I've also discovered the Derivative crate which would allow us to use a custom Debug trait derivation with support for skipping certain fields. Would it be worth adding it as a dependency and using it?

I've also discovered the Derivative crate which would allow us to use a custom Debug trait derivation with support for skipping certain fields. Would it be worth adding it as a dependency and using it?

I think in this case I would mildly prefer to continue printing the reserved field, because the spec mentions that it must be set to zero. So I see this as a bit different from a padding field, which could be safely set to any value. If you debug print the header and see the reserved field is not all zeros that could be useful info.

Got it. LGTM then!


body responsive on desktop

I'm pushing this as an example.
Feel free to adjust the breakpoints to your preference or explore alternative solutions in future

whats it meant to do?

On larger screens (desktop), opening the app in full screen renders it unusable as the expanded content spans the entire width, causing common chats in 4K resolution to condense into a single line, making it challenging to read.
In this commit, I've introduced a basic horizontal padding calculation tied to screen width, enhancing readability

yeah, but in this way mid-size are broken


chore(main): release 2.3.2

:robot: I have created a release beep boop
2.3.2 (2024-08-23)
Bug Fixes

load: recursive import when using FindFiles and RegexLookup (09443c1)
stubgen crashes for newer numpy versions (f48a94f)

Build System

move from rye to uv (f2345b6)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.3.2
:sunflower:


fix color overflow error on some terminals

fixes #3

I'm still not sure if this is a macOS specific issue or an issue with the color compatibility of my font, so test if some colors aren't working elsewhere because of this change


Read appconfig flag to control admission scenarios (EXPOSUREAPP-11801)

The new admission scenario tile is now enabled / disabled depending on the dcc-admission-check-scenarios-disabled appconfig flag.
Details: https://github.com/corona-warn-app/cwa-app-tech-spec/pull/157/commits/c0cb645ae4dfddc2a6e4e441248b7e6cd397b729
I also did some refactorings in CWAConfigMapper its associated test.
Flag can be enabled/disabled via Mock-Server:

in text, thanks to Safari:
cwa app-config set ccl-admission-check-scenarios-disabled 0 --android -e cf
cwa app-config set ccl-admission-check-scenarios-disabled 1 --android -e cf

@LukasLechnerDev  did you push your latest changes ? I don't see them here yet

@mtwalli Ah, you are right. I forgot to push the "Add default value" commit. Its now pushed.


Lambda Event Logs Handling

Feature or Bugfix

Bugfix

Detail

Ensure any potential sensitive information redacted from logged events

Relates

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Testing Covered:

[x] Deployed to AWS
[x] CloudWatch Logs redacting any credentials or sensitive information