Changed changeQuantity to use forward instead redirect

1. Why is this change necessary?
Redirect loses all given parameters like POST, forward they are still available. Other checkout actions also use forward
2. What does this change do, exactly?
Changes redirect to forward
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/SW-21381
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

CLA already signed.


Feature Request - Get-DbaAvailabilityGroup - Explode out AvailabilityReplicas, AvailabilityDatabases & AvailabilityGroupListeners

Hi,
It is not possible to export the above data columns to CSV due to them being an array. Could they instead be listed as a semi-colon (;) separated string to enable their easier export and readability to CSV file formats

an array is an object you can manipulate as you wish down the line of your powershell script.
If we turn them to a string separated by a semi-colon that would mean that we'd LOWER the flexibility of the function.
If you want strings from awways, the "transformation" you seek is just  a simple one-liner away, which is $array -Join ';' .


Problem installing due to tests.various module missing

Hello!
Thanks for making larvaworld! I would love to try it to simulate larval movement (to compare movement to my own behavioural assays). I have followed all the installation steps. Only additional step was installing the 'siunits' module myself. This is all with python3.7.7.
I am trying to run some of the example lines from the README.txt (specifically the lines related to larvaworld_gui.py and batch_run.py)
When running any of the scripts I run into an error:
Traceback (most recent call last):
  File "larvaworld_gui.py", line 11, in <module>
    from lib.gui.tabs.gui import LarvaworldGui
  File "../lib/gui/tabs/gui.py", line 10, in <module>
    from lib.gui.tabs import intro_tab, model_tab, life_tab, sim_tab, batch_tab, essay_tab, import_tab, \
  File "../lib/gui/tabs/sim_tab.py", line 11, in <module>
    from run.exec_run import Exec
  File "../run/exec_run.py", line 10, in <module>
    from lib.sim.batch.functions import retrieve_results
  File "../lib/sim/batch/functions.py", line 15, in <module>
    from lib.sim.single.single_run import SingleRun
  File "../lib/sim/single/single_run.py", line 8, in <module>
    from lib.model.envs._larvaworld_sim import LarvaWorldSim
  File "../lib/model/envs/_larvaworld_sim.py", line 9, in <module>
    from lib.model.envs._larvaworld import LarvaWorld, generate_larvae, get_sample_bout_distros, sample_group
  File "../lib/model/envs/_larvaworld.py", line 30, in <module>
    import tests.various.gui.dtype_dicts as dtypes
ModuleNotFoundError: No module named 'tests.various'

I'm unsure whether this is meant to be part of a module called tests - which I did make sure I have. That made me think that it might be a missing directory/script that is meant to be downloaded with larvaworld. I've tried on both linux and mac (same error is raised).
Do you have any ideas on how I could get past this error?
Thanks again!
TK

Thank you very much Panos! That worked for downloading. I now noticed that the examples do not work.
For example:
I ran
python batch_run.py odor_pref -N 25 -t 3.0 -rng -200.0 200.0 -Ngrd 5
I then got the error:
batch_run.py: error: argument batch: invalid choice: 'odor_pref' (choose from 'chemotaxis_approach', 'chemotaxis_local', 'PItest_off', 'PItrain_mini', 'PItrain', 'patchy_food', 'food_grid', 'growth', 'RvsS', 'imitation', 'tactile_detection')

so I changed it to patchy food:
i.e. python batch_run.py patchy_food -N 25 -t 3.0 -rng -200.0 200.0 -Ngrd 5
I then get
Traceback (most recent call last):
  File "batch_run.py", line 43, in <module>
    space_kwargs[k] = batch_conf['space_search'][k]
KeyError: 'pars'

This error happens for other keys I tried too like 'chemotaxis_approach'.

I also tried:
python exp_run.py dispersion -N 30 -t 3.0 -img -a
I got the error message: exp_run.py: error: unrecognized arguments: -N 30  -img
I then changed -img to -m image, and did not find an appropriate replacement for -N30.
Running: python exp_run.py dispersion -t 3.0 -m image -a gave me the follwoing error:
Traceback (most recent call last):
  File "exp_run.py", line 24, in <module>
    ds = SingleRun(**exp_conf, vis_kwargs=d['visualization']).run()
  File "../lib/sim/single/single_run.py", line 57, in __init__
    save_to=self.d.vis_dir, **kwargs)
  File "../lib/model/envs/_larvaworld_sim.py", line 24, in __init__
    self.create_larvae(larva_groups=self.larva_groups, parameter_dict=parameter_dict)
  File "../lib/model/envs/_larvaworld_sim.py", line 94, in create_larvae
    sample_dict = sample_group(sample, N, self.sample_ps)
  File "../lib/model/envs/_larvaworld.py", line 675, in sample_group
    d = LarvaDataset(sample['dir'], load_data=False)
  File "../lib/stor/larva_dataset.py", line 22, in __init__
    self.define_paths(dir)
  File "../lib/stor/larva_dataset.py", line 635, in define_paths
    os.makedirs(v, exist_ok=True)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 213, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 213, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 213, in makedirs
    makedirs(head, exist_ok=exist_ok)
  [Previous line repeated 4 more times]
  File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 223, in makedirs
    mkdir(name, mode)
OSError: [Errno 45] Operation not supported: '/home/panos'

I think there is a path hard coded.

I also could not find process.py, I guess it is now exec_run.py
Would you prefer if I opened these in another ticket?
These errors also occur from the lines in the tutorials.
The first goal I have is to be able to simulate x third instar larva on a 1000x1000px grid for 20 minutes (sampling their coordinates at either 1 or 10 fps).
Thanks again!
Tane

Hello Tane and thanks again for your patience
Indeed the terminal executables are somewhat obsolete because of the GUI.
Especially importing experimental data is much more transparent there.
Did you manage to launch the GUI by python larvaworld_gui.py?
Στις Δευ, 18 Οκτ 2021 στις 11:40 μ.μ., ο/η TK @.***>
έγραψε:

Thank you very much Panos! That worked for downloading. I now noticed that
the examples do not work.
For example:
I ran
python batch_run.py odor_pref -N 25 -t 3.0 -rng -200.0 200.0 -Ngrd 5
I then got the error:
batch_run.py: error: argument batch: invalid choice: 'odor_pref' (choose from 'chemotaxis_approach', 'chemotaxis_local', 'PItest_off', 'PItrain_mini', 'PItrain', 'patchy_food', 'food_grid', 'growth', 'RvsS', 'imitation', 'tactile_detection')
so I changed it to patchy food:
i.e. python batch_run.py patchy_food -N 25 -t 3.0 -rng -200.0 200.0 -Ngrd
5
I then get
Traceback (most recent call last):
File "batch_run.py", line 43, in
space_kwargs[k] = batch_conf['space_search'][k]KeyError: 'pars'
This error happens for other keys I tried too like 'chemotaxis_approach'.
I also tried:
python exp_run.py dispersion -N 30 -t 3.0 -img -a
I got the error message: exp_run.py: error: unrecognized arguments: -N 30
-img
I then changed -img to -m image, and did not find an appropriate
replacement for -N30.
Running: python exp_run.py dispersion -t 3.0 -m image -a gave me the
follwoing error:
Traceback (most recent call last):
File "exp_run.py", line 24, in
ds = SingleRun(**exp_conf, vis_kwargs=d['visualization']).run()
File "../lib/sim/single/single_run.py", line 57, in init
save_to=self.d.vis_dir, **kwargs)
File "../lib/model/envs/_larvaworld_sim.py", line 24, in init
self.create_larvae(larva_groups=self.larva_groups, parameter_dict=parameter_dict)
File "../lib/model/envs/_larvaworld_sim.py", line 94, in create_larvae
sample_dict = sample_group(sample, N, self.sample_ps)
File "../lib/model/envs/_larvaworld.py", line 675, in sample_group
d = LarvaDataset(sample['dir'], load_data=False)
File "../lib/stor/larva_dataset.py", line 22, in init
self.define_paths(dir)
File "../lib/stor/larva_dataset.py", line 635, in define_paths
os.makedirs(v, exist_ok=True)
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 213, in makedirs
makedirs(head, exist_ok=exist_ok)
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 213, in makedirs
makedirs(head, exist_ok=exist_ok)
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 213, in makedirs
makedirs(head, exist_ok=exist_ok)
[Previous line repeated 4 more times]
File "/usr/local/Caskroom/miniconda/base/lib/python3.7/os.py", line 223, in makedirs
mkdir(name, mode)OSError: [Errno 45] Operation not supported: '/home/panos'
I think there is a path hard coded.
I also could not find process.py, I guess it is now exec_run.py
Would you prefer if I opened these in another ticket?
These errors also occur from the lines in the tutorials.
The first goal I have is to be able to simulate x third instar larva on a
1000x1000px grid for 20 minutes (sampling their coordinates at either 1 or
10 fps).
Thanks again!
Tane
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nawrotlab/larvaworld/issues/1#issuecomment-946189224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTJYJJZ3ZDB33BQWN4TJODUHSH45ANCNFSM5GG3L3TQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hey,
I am still unable to run simulations even through the gui.
To use mode: video, I had to install imageio-ffmpeg, python -m pip install imageio_ffmpeg
I tried each of the tabs ('simulation', 'batch_run', and 'essay'), each of them gave different errors. I was not able to successfully run the simulation on any of them (errors raised on each).
For example, when I run the 'batch_run' tab. I leave everything default. I just change the first drop down to 'PItest_off' (the simulation drop down also changes to 'PItest_off' automatically)

Hello from the pygame community. https://www.pygame.org/contribute.html
* Error performing wm_overrideredirect *
MainProcess pypet.storageservice.HDF5StorageService INFO     I will use the hdf5 file `larvaworld/data/SimGroup/batch_runs/PItest_off/PItest_off.hdf5`.
MainProcess pypet.environment.Environment INFO     Environment initialized.
Created novel environment
MainProcess pypet.naturalnaming.NaturalNamingInterface ERROR    Failed adding `ranges` under ``.
Traceback (most recent call last):
  File "larvaworld/run/exec_run.py", line 90, in <module>
    k.exec_run()
  File "larvaworld/run/exec_run.py", line 78, in exec_run
    res = batch_run(**batch_kwargs)
  File "../lib/sim/batch/batch.py", line 48, in batch_run
    return _batch_run(**kwargs)
  File "../lib/sim/batch/batch.py", line 154, in _batch_run
    env =test_batch()
  File "../lib/sim/batch/batch.py", line 147, in test_batch
    space=space, **env_kws)
  File "../lib/sim/batch/batch.py", line 59, in get_batch_env
    traj = config_traj(traj, optimization, batch_methods)
  File "../lib/sim/batch/aux.py", line 23, in config_traj
    traj.f_aconf(k, v)
  File "larvaworld/larvaworld_venv/lib/python3.7/site-packages/pypet/naturalnaming.py", line 3624, in f_add_config
    args=args, kwargs=kwargs)
  File "larvaworld/larvaworld_venv/lib/python3.7/site-packages/pypet/naturalnaming.py", line 1230, in _add_generic
    constructor, args, kwargs)
  File "larvaworld/larvaworld_venv/lib/python3.7/site-packages/pypet/naturalnaming.py", line 1331, in _add_to_tree
    args, kwargs)
  File "larvaworld/larvaworld_venv/lib/python3.7/site-packages/pypet/naturalnaming.py", line 1612, in _create_any_param_or_result
    instance = root._construct_instance(constructor, full_name, *args, **kwargs)
  File "larvaworld/larvaworld_venv/lib/python3.7/site-packages/pypet/trajectory.py", line 3223, in _construct_instance
    return constructor(full_name, *args, **kwargs)
  File "larvaworld/larvaworld_venv/lib/python3.7/site-packages/pypet/parameter.py", line 733, in __init__
    self.f_set(data)
  File "larvaworld/larvaworld_venv/lib/python3.7/site-packages/pypet/parameter.py", line 951, in f_set
    'tuple or list.' % (str(data), str(type(data))))
TypeError: Unsupported data `[]` of type `<class 'numpy.ndarray'>`. If you passed a tuple or list, this error might also be caused by heterogeneous data within the tuple or list.

Also when I try other settings such as patchy_food the problem is: larvaworld/data/SimGroup/batch_runs directory is missing so the hdf5 files (e.g. patchy_food.hdf5 is not found).
When I try to run batch_runs.py on the command line, the error I get is always - no matter the line:
Traceback (most recent call last):
  File "batch_run.py", line 43, in <module>
    space_kwargs[k] = batch_conf['space_search'][k]
KeyError: 'pars'

If you have any solutions to how I could get that running, please let me know. it would be helpful to be able to run the batch_runs.py to simulate the movement of larvae without any attractors.
Best,
TK

Hello tkjmk
There has now been a new release of the package.
The GUI is currently deprecated and the batch run is buggy.
Other than that it should work.
Also the pkg is tested for python versions 3.8-3.11.
This will now be closed.
Please feel free to try the new version and report any issues (a more functional issue publication property is supported)


Update documentation for Replaces and isReplacedBy

The metadata fields Replaces and isReplacedBy can indicate a relationship between two records A and B where:

A= old data, deprecated but still available
B= new data, to be used instead of A

For the purposes of GeoBlacklight, users only need to enter a value (ID of corresponding record) in the field Replaces in record B. This is because GeoBlacklight is set up to create widgets that display a two-way relationship that has only been declared on one record. (see the Data Relations documentation for more details)
For the purposes of OpenGeoMetadata, users should enter a value (ID of corresponding record) in both records. This is to ensure that the relationship is declared in the metadata regardless of how a discovery application functions.

Furthermore, we should note that is would be a Best Practice to also include a warning in the displayNote field to alert users to deprecated datasets.

We'll probably want to update the documentation on the new Relations Fields page as well.

should GBL be updated to not show duplicated relationships?


Changing font size and style

I am trying to use the ipysankeywidget, and it works fine, but I can't find a way to change the font size of node titles. I don't know much Javascript, so the line in the readme "the value of the SankeyWidget is exactly the same as the sankey object described there" unfortunately doesn't help me very much. I have tried setting things by accessing the sankey object like this:
nbsankeyExample.font_style = 'italic'
nbsankeyExample.font_style
u'italic'
, and it returns the value correctly, but when showing the widget again, the value is not used.

Found it (the styling part of the docs). Works fine now.

Thanks for raising this. When I tried doing nbsankeyExample.font_style = 'italic', it did nothing, as you said. How did you get it to work?
I normally adjust the styling in the notebook using CSS:
%%html
<style>
.sankey .node {
    font-style: italic;
}
</style>

Do you mean these styling docs?
http://ipywidgets.readthedocs.io/en/latest/examples/Widget Styling.html

I was referring to this: https://github.com/ricklupton/ipysankeywidget/blob/7762bdd6981a53cace697d9d4a2e1cb5fc0e135f/examples/More examples.ipynb, but it did not help with the italics or font_size. I think I was thinking about node titles when I said it helped. Thanks for the tip on using CSS.


model file?

i very good study. appreciate it. i want to try it but i could not find the model checkpoint file.

any improvement?

Hey Mehmet,
thank you for your interest.
I just uploaded the model checkpoints here https://zenodo.org/records/10403044.
The link is also available in the readme file.

thanks a lot


⚠ Turnos 24x7 has degraded performance

In fcaafee, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 2975 ms

Resolved: Turnos 24x7 performance has improved in 000ca84.


doc.nouns(...).toSingle is not a function

I'm not sure whether I've done something wrong here but I'm getting a doc.nouns(...).toSingle is not a function error when trying to convert a noun.  I've tried a few options before finally copying the example directly from the docs.
First tried with 11.0.2, then upgraded to 11.1.0.
// package.json
  "dependencies": {
    "compromise": "^11.1.0"
  }

// index.js
const nlp = require('compromise');

var doc = nlp('dinosaur')
doc.nouns().toSingle()
doc.out('text')

nouns().toPlural() works as expected.
Have I missed something?
(Superb library by the way)

hey Adam, ah thanks.
yeah, looks its the docs. the Method is nouns().toSingular().
you can check it out here
my bad!
p.s. neo4j is a really fun database. cheers


helen

helen bio

Helen fix the Heading issue in your MD file and run lint:md file again. Adjust the link at the top of your MD file and start with an h1 statement


Ignore with RegEx?

Is it possible to set ignore patterns as regex?
I want to ignore any selector in CSS sheets that includes ".open"
By the way, this uncss fails with Bootstrap where navigation panel is displayed on press/click, it only adds a class ".open". This class is not used otherwise.

Yes, an array of either strings or regexes is accepted.


Circle USDC checkout, connected account, and withdrawal

this is what we're using for now on
https://media-wallet-dv3.dev.app.eluv.io/
we're aiming to get into into a state where we can merge it for use w/ circle enabled on some demov3 test marketplaces.

ok to merge this? @elv-michelle is fine w/ the UI..

no, not until we are ready to deploy it to prod

deployed to https://media-wallet-dv3.dev.app.eluv.io/


Pyperclip must catch ImportError and ModuleNotFoundError

Starting with Python 3.6, ModuleNotFoundError is raised when an import fails, while previous versions raise ImportError. Pyperclip must be able to handle both of these cases. Currently it only catches ImportError.

ModuleNotFoundError is a subclass of ImportError, so you should still be able to catch ImportError and be safe.


How to ignore HTTPS certificate errors when using AtataContext.GlobalConfiguration.AutoSetUpConfiguredDriversAsync()

Hello,
So I've recently upgraded my Atata project from 1.x to 2.x (currently using Atata.WebDriverSetup 2.5.0) and everything builds properly, but I can't run my tests yet, as in my test setup logic, I am using AtataContext.GlobalConfiguration.AutoSetUpConfiguredDriversAsync() and it keeps throwing an exception at this point:
   at System.Net.Http.ConnectHelper.<EstablishSslConnectionAsyncCore>d__4.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at System.Net.Http.HttpConnectionPool.<ConnectAsync>d__52.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at System.Net.Http.HttpConnectionPool.<CreateHttp11ConnectionAsync>d__53.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at System.Net.Http.HttpConnectionPool.<GetHttpConnectionAsync>d__45.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at System.Net.Http.HttpConnectionPool.<SendWithRetryAsync>d__47.MoveNext()
   at System.Net.Http.RedirectHandler.<SendAsync>d__4.MoveNext()
   at System.Net.Http.HttpClient.<FinishSendAsyncUnbuffered>d__71.MoveNext()
   at System.Net.Http.HttpClient.<GetStringAsyncCore>d__35.MoveNext()
   at Atata.WebDriverSetup.HttpRequestExecutor.DownloadString(String url)
   at Atata.WebDriverSetup.ReliableHttpRequestExecutor.<>c__DisplayClass5_0.<DownloadString>b__0()
   at Atata.WebDriverSetup.ReliableHttpRequestExecutor.ExecuteWithRetries[TResult](Func`1 operation)
   at Atata.WebDriverSetup.ReliableHttpRequestExecutor.DownloadString(String url)
   at Atata.WebDriverSetup.ChromeDriverSetupStrategy.GetDriverVersionCorrespondingToBrowserVersion(String browserVersion)
   at Atata.WebDriverSetup.XmlFileDriverVersionCache.GetOrAdd(String browserVersion, DateTime minimumAcceptableTimestamp, Func`2 versionResolveFunction)
   at Atata.WebDriverSetup.CachedDriverVersionCorrespondingToBrowserVersionResolver.GetDriverVersionCorrespondingToBrowserVersion(String browserVersion)
   at Atata.WebDriverSetup.DriverVersionResolver.ResolveByBrowserVersion(String version)
   at Atata.WebDriverSetup.DriverVersionResolver.ResolveCorrespondingVersion()
   at Atata.WebDriverSetup.DriverVersionResolver.ResolveCorrespondingOrLatestVersion()
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.ResolveDriverVersion(IDriverSetupStrategy setupStrategy, String version)
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.ExecuteSetUp()
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.SetUp()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__274_0(Object obj)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
   at Atata.WebDriverSetup.DriverSetupConfigurationBuilder.<SetUpAsync>d__13.MoveNext()
   at Atata.WebDriverSetup.DriverSetup.<AutoSetUpAsync>d__27.MoveNext()
   at Atata.WebDriverSetup.DriverSetup.<AutoSetUpAsync>d__29.MoveNext()
   at Atata.WebDriverSetup.DriverSetup.<AutoSetUpSafelyAsync>d__31.MoveNext()
   at Atata.WebDriverSetup.DriverSetup.AutoSetUpSafely(IEnumerable`1 browserNames)
   at Atata.MethodInfoExtensions.InvokeStaticAsLambda(MethodInfo method, Object[] args)
   at Atata.AtataContextBuilder.InvokeAutoSetUpSafelyMethodOfDriverSetup(IEnumerable`1 browserNames)
   at Atata.AtataContextBuilder.AutoSetUpDriverToUse()
   at OurClientMatters.UiTests.SetUpFixture.GlobalSetUp() in C:\Users\mmiftah\source\repos\OCM\OCM.UiTests\SetUpFixture.cs:line 23

I know what the cause of the issue is: my work network has MITM-HTTPS decryption, so all the HTTPS certificates resolve to a top-level CA that is self-signed, so it will always been invalid. Is there any way to configure the call to AutoSetUpConfiguredDriversAsync() to ignore HTTPS certificate errors?
I note that it calls Atata.WebDriverSetup.DriverSetup.AutoSetUpSafely(IEnumerable``1 browserNames), which is why I posted the issue here.

Can you try to add the following line to your global setup method before the AtataContext configuration:
ServicePointManager.ServerCertificateValidationCallback += (sender, cert, chain, sslPolicyErrors) => true;

If it works for you, I will think about the cleaner solution to add to Atata.WebDriverSetup library.

Unfortunately no this didn't work:

What's weird is that this worked in version 1.x perfectly fine. I was using Atata.WebDriverSetup 1.2.0 and also Atata 1.12.0 where it worked.

I believe that it happens because of CheckCertificateRevocationList property of HttpClientHandler, which became enabled by default in Atata.WebDriverSetup v2.0.0. Let's try to disable it, which is now possible with the latest v2.6.0 release. So please update the Atata.WebDriverSetup package to the latest version. Then you can try one of the code blocks, again in global setup method before the AtataContext configuration.
DriverSetup.GlobalConfiguration
    .WithCheckCertificateRevocationList(false);

or
DriverSetup.GlobalConfiguration
    .WithCheckCertificateRevocationList(false)
    .WithHttpClientHandlerConfiguration(x => x.ServerCertificateCustomValidationCallback += (_, _, _, _) => true);

And you can remove ServicePointManager.ServerCertificateValidationCallback += ... code.

Thank you - I can confirm that:
DriverSetup.GlobalConfiguration     .WithHttpClientHandlerConfiguration(x => x.ServerCertificateCustomValidationCallback += (_, _, _, _) => true);
resolves the issue for me. DriverSetup.GlobalConfiguration.WithCheckCertificateRevocationList(false); had no effect.

You are welcome. Thanks for letting know which method solved the issue.


add  status : "force stop " for jobs which are forced to stop

作业被强停，期望结果运行状态展示"被强停"

返回信息有显示“force stop”


rednotebook: 2.25 -> 2.26

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for rednotebook is: "A modern journal that includes a calendar navigation, customizable templates, export functionality and word clouds"
meta.homepage for rednotebook is: "https://rednotebook.sourceforge.io/"
meta.changelog for rednotebook is: "https://github.com/jendrikseipp/rednotebook/blob/v2.26/CHANGELOG.md"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.26 with grep in /nix/store/jnw5cajdf076vwanhzk6ylp6pzgbqcsm-rednotebook-2.26
found 2.26 in filename of file in /nix/store/jnw5cajdf076vwanhzk6ylp6pzgbqcsm-rednotebook-2.26

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
rednotebook

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jnw5cajdf076vwanhzk6ylp6pzgbqcsm-rednotebook-2.26 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rednotebook https://github.com/r-ryantm/nixpkgs/archive/716d45cc489a6569491192c5ea6a19ca3d0462be.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jnw5cajdf076vwanhzk6ylp6pzgbqcsm-rednotebook-2.26
ls -la /nix/store/jnw5cajdf076vwanhzk6ylp6pzgbqcsm-rednotebook-2.26/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

rednotebook

Maintainer pings
cc @orivej for testing.

Result of nixpkgs-review pr 193343 run on x86_64-linux 1

1 package built:

rednotebook


Ommit validation for non basic types

Fixes #96

Hi @kylefinley, this should fix the problem

PTAL @crhym3

LGTM :+1:

@campoy Excellent! Thank you for the quick response.


chore(main): release 1.6.2

:robot: I have created a release beep boop
1.6.2 (2024-11-07)
Build System

updates packages + script (0e10e78)

Styles

update eslint (1e02c17)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Basalt-Lab/basalt-auth/releases/tag/v1.6.2 :sunflower:


ToolTask class should have an overridable method which is called right after tool process is started

Steps to reproduce
There is a long standing issue when CL and Link tasks hang sometimes waiting on a pipe they create to get unicode output from the tools (the problem described here: https://docs.microsoft.com/en-us/windows/win32/ipc/pipe-handle-inheritance).
To avoid this problem, the write handle of the pipe must be closed right after the tool process is created.
Currently, there is no way we can do it in a task derived from
https://github.com/microsoft/msbuild/blob/master/src/Utilities/ToolTask.cs
Please add an overridable method in ToolTask class and call it in Execute() after process.Start().

Did you mean proc.Start() in the ExecuteTool?


Parsing error with sbt 0.13.9-RC1

When I tried testing sbt 0.13.9-RC1 I get weird parsing errors with 2 plugins (scalastyle and scalariform); they did not appear in 0.13.9-M1.  This gist shows a very simple project that illustrates the error, which in this example is:
> scalastyle
    ...
> last compile:scalastyle
[info] scalastyle using config /.../scalastyle-config.xml
[debug] Starting scalastyle
[debug] start file /.../src/main/scala/Test.scala
[error] /.../src/main/scala/Test.scala: Expected token RBRACKET but got Token(XML_START_OPEN,<,18,<)
[debug] end file /.../src/main/scala/Test.scala
java.lang.RuntimeException: errors exist
	at scala.sys.package$.error(package.scala:27)
	at org.scalastyle.sbt.Tasks$.onHasErrors$1(Plugin.scala:123)
	at org.scalastyle.sbt.Tasks$.doScalastyleWithConfig$1(Plugin.scala:167)
	at org.scalastyle.sbt.Tasks$.doScalastyle(Plugin.scala:175)
	at org.scalastyle.sbt.ScalastylePlugin$$anonfun$rawScalastyleSettings$1$$anonfun$apply$1$$anonfun$apply$2.apply(Plugin.scala:88)
	at org.scalastyle.sbt.ScalastylePlugin$$anonfun$rawScalastyleSettings$1$$anonfun$apply$1$$anonfun$apply$2.apply(Plugin.scala:76)
	at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
	at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
	at sbt.std.Transform$$anon$4.work(System.scala:63)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
	at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
	at sbt.Execute.work(Execute.scala:235)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
	at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
	at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Potentially related #1666 #1765 #2068

Just tried this with RC2 and got the same error.

Same with RC3

Same with 0.13.9

not actually an sbt bug, but a scalariform issue (affecting scalastyle as well, since scalastyle depends on scalariform) having to do with Scala 2.10.5 compatibility; see @mrerrormessage's scalariform PR linked above

Okay no need to keep this issue open then; we'll just wait for scalariform to update.  Thanks for the update :)

As an aside, what does this error mean:
Expected token RBRACKET but got Token(XML_START_OPEN,<,18,<)
?
I've seen a similar error in my 200-line test file, yet my error message shows:
 Expected token RBRACKET but got Token(XML_START_OPEN,<,1288,<)

@kevinmeredith it means you need to upgrade to a newer version of Scalariform and/or Scalastyle

@kevinmeredith Seth is write, and it's to do with Scala 2.10 version bumping and things in scala.xml...

Thank you. Upgrading the scalastyle plugin fixed my issue:
-addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.7.0")
+addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.8.0")


Find a free address if default address is already taken

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

I don't think that's a good thing to have since it may cause unexpected hard-to-find errors. For example, if we run Codeception tests we expect the server to be on a certain port. If it starts on another port, it will error but in a quite unexpected way: server is started and works but tests fail for a weird reason.

Current error is enough to know that current port is occupied and re-run the command with another port.


IGNITE-14815 Metrics for thin clients

Added metrics for thin clients and tests for them.
Following metrics were added:
client.connector.RejectedSessionsByTimeout
client.connector.RejectedSessionsDueAuthentication
client.connector.RejectedSessionsTotal
client.connector.thin.AcceptedSessions
client.connector.thin.ActiveSessions
client.connector.odbc.AcceptedSessions
client.connector.odbc.ActiveSessions
client.connector.jdbc.AcceptedSessions
client.connector.jdbc.ActiveSessions
The Contribution Checklist

[x] There is a single JIRA ticket related to the pull request.
[x] The web-link to the pull request is attached to the JIRA ticket.
[x] The JIRA ticket has the Patch Available state.
[x] The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
[x] The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[x] A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
[x] The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

How to Contribute
Coding abbreviation rules
Coding Guidelines
Apache Ignite Teamcity Bot

If you need any help, please email<EMAIL_ADDRESS>or ask anу advice on http://asf.slack.com #ignite channel.

@isapego I propose to change names to follow the pattern RejectedSessionsREASON:

RejectedSessionsDueAuthentication -> RejectedSessionsAuthenticationFailed
RejectedSessionsByTimeout -> RejectedSessionsTimeout


SYNC additional options does not create a floating menu

Describe the bug
On the staging cluster I can see that when I click the arrow for the dropdown option "SYNC WITHOUT SOURCE" that it bumps the rest of the content down on the detail page.  This is not the expected behavior.  I would expect for that to be a floating menu option and for it to not adjust any of the content underneath.
Environment

Weave-Gitops Version
main-26c1230

Flux Version
N/A

Kubernetes version
v1.22

To Reproduce
Steps to reproduce the behavior:

Expected behavior
I would expect for that to be a floating menu option and for it to not adjust any of the content on the detail screen.
Actual Behavior
When you click the down arrow the menu appears and pushes content down.  When it is dismissed the content moves back up.
Additional Context (screenshots, logs, etc)

@JamWils which browser are you using? I'm unable to reproduce the issue in Chrome on Mac.

@JamWils and could you please re-confirm the issue? The recently merged PR for suspend/resume could fix this issue too.

I can confirm a related minor issue in both Chrome and Safari with content slightly pushed down on clicking Sync or Sync without source, probably, because of the icon which is displayed while syncing.

Sync button DOES in fact create a floating menu on main (fixed with the addition of the suspend button) - but the button itself weirdly expands now as seen in Olga's screenshot. That should be fixed 🌞


Fix typing for SystemCallError and its subclasses

SystemCallError is a bit of a mess. It has a custom object creator that varies in behaviour if it called on a subclass, even if that subclass doesn't define its own constructor.
Basically the way it works is:

SystemCallError.new takes 1-3 args
(class < SystemCallError).new takes 0-2 args
SystemCallError.new will return a SystemCallError object
SystemCallError.new(1) will return a Errno::EPERM object
SystemCallError.new(999) will return a SystemCallError object (no child class found)
SystemCallError#errno will return a nilable integer based on what was passed to the constructor
(class < SystemCallError)#errno will return the value of (class < SystemCallError)::Errno. It is an error to create a subclass without defining the Errno constant. The constant must be an integer or nil.

Therefore the stdlib Errno::E.*#errno can never return nil as they all have Errno correctly defined to an integer.

We can't really check all of that in Sorbet so I did the best I could.
Motivation
Original motivation was seeing that rescue SystemCallError was untyped: https://sorbet.run/#%23 typed%3A strong
extend T%3A%3ASig

sig {void}
def bar
  begin
  rescue SystemCallError %3D> e
  end
end

And then I opened a can of worms I perhaps shouldn't have of trying to type the rest of SystemCallError.
Test plan
See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_QfOfSsqY0UW9Jr
→ https://go/builds/bui_QfOfjFexceGlxa
→ https://go/builds/bui_QfOfSGqe5rPItr

This is basically the "to_s problem".
class A
  def to_s
    "from to_s"
  end
end

Errno::ECONNRESET.new("abc", A.new)
=> #<Errno::ECONNRESET: Connection reset by peer @ from to_s - abc>

irb(main):001> Errno::ECONNRESET.new("abc", BasicObject.new)
(irb):1:in `initialize': undefined method `to_s' for an instance of BasicObject (NoMethodError)

What's the usual rule for those type of signatures?
FWIW, the argument is technically undocumented: https://docs.ruby-lang.org/en/3.3/SystemCallError.html.

I tend to think the error without the hash is better

For the example you provide: I agree.

Ah, the to_s problem, yes.
I think func should probably be Object, then, or Sorbet will complain unnecessarily -- even if String would in some sense be the better choice.

Updated to use Object


这是什么问题，方法第一种好还第二种好？？

File "D:\llm\VideoLingo-1.7.0\st.py", line 117, in
main()
File "D:\llm\VideoLingo-1.7.0\st.py", line 113, in main
text_processing_section()
File "D:\llm\VideoLingo-1.7.0\st.py", line 30, in text_processing_section
process_text()
File "D:\llm\VideoLingo-1.7.0\st.py", line 48, in process_text
step3_2_splitbymeaning.split_sentences_by_meaning()
File "D:\llm\VideoLingo-1.7.0\core\step3_2_splitbymeaning.py", line 118, in split_sentences_by_meaning
sentences = parallel_split_sentences(sentences, max_length=load_key("max_split_length"), max_workers=load_key("max_workers"), nlp=nlp, retry_attempt=retry_attempt)
File "D:\llm\VideoLingo-1.7.0\core\step3_2_splitbymeaning.py", line 100, in parallel_split_sentences
split_result = future.result()
File "d:\Users\NINGMEI\anaconda3\envs\videolingo\lib\concurrent\futures_base.py", line 445, in result
return self.__get_result()
File "d:\Users\NINGMEI\anaconda3\envs\videolingo\lib\concurrent\futures_base.py", line 390, in __get_result
raise self.exception
File "d:\Users\NINGMEI\anaconda3\envs\videolingo\lib\concurrent\futures\thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "D:\llm\VideoLingo-1.7.0\core\step3_2_splitbymeaning.py", line 60, in split_sentence
best_split = response_data[f"split{response_data['best']}"]
KeyError: 'split_Due to slight differences in flow between the two methods outlined above (considering not just length but also the readability of them as independent units), method 1 might generally be preferred because it retains each point as a separate unit, which is clearer for context and smoother reading by preserving the natural progression of ideas within subtitles.'

这是 llm 响应格式出错，请问使用的什么 llm

不建议使用小模型，在安装文档中有说明，小模型的格式遵循不好


Bug: Sqlite drops foreign keys when altering table

PHP Version
8.0
CodeIgniter4 Version
4.3
CodeIgniter4 Installation Method
Git
Which operating systems have you tested for this bug?
Windows
Which server did you use?
apache
Database
SQLite3
What happened?
When performing certain table modifications foreign keys are dropped. This happens because Sqlite uses a Table class to recreate the table when modified. This Table class is missing logic to recreate foreign keys.
Steps to Reproduce
Test Sqlite with the following:
    public function testDropColumnForeignKey()
    {
        $this->forge->dropTable('forge_test_invoices', true);
        $this->forge->dropTable('forge_test_users', true);

        $attributes = [];

        $this->forge->addField([
            'id' => [
                'type'       => 'INTEGER',
                'constraint' => 11,
            ],
            'second_id' => [
                'type'       => 'VARCHAR',
                'constraint' => 50,
            ],
            'name' => [
                'type'       => 'VARCHAR',
                'constraint' => 255,
            ],
        ]);
        $this->forge->addPrimaryKey(['id', 'second_id']);
        $this->forge->createTable('forge_test_users', true, $attributes);

        $fields = [
            'id' => [
                'type'       => 'INTEGER',
                'constraint' => 11,
            ],
            'name' => [
                'type'       => 'VARCHAR',
                'constraint' => 255,
            ],
            'users_id' => [
                'type'       => 'INTEGER',
                'constraint' => 11,
            ],
            'users_second_id' => [
                'type'       => 'VARCHAR',
                'constraint' => 50,
            ],
            'preferences' => ['type' => 'TEXT'],
        ];

        $this->forge->addField($fields);
        $this->forge->addPrimaryKey('id');
        $this->forge->addForeignKey(['users_id', 'users_second_id'], 'forge_test_users', ['id', 'second_id'], 'CASCADE', 'CASCADE');

        $this->forge->createTable('forge_test_invoices', true, $attributes);

        $foreignKeyData = $this->db->getForeignKeyData('forge_test_invoices');

        $this->assertCount(1, $foreignKeyData);

        $this->forge->dropColumn('forge_test_invoices', 'preferences');

        $foreignKeyData = $this->db->getForeignKeyData('forge_test_invoices');

        $this->assertCount(1, $foreignKeyData);

        $this->forge->dropTable('forge_test_invoices', true);
        $this->forge->dropTable('forge_test_users', true);
    }

Expected Output
Expected success
Anything else?
No response

https://github.com/codeigniter4/CodeIgniter4/pull/6676 closes this

Resolved with https://github.com/codeigniter4/CodeIgniter4/pull/6676


Bad fast5 attribute pore type

I got this error when using f2s in v0.6.0.
Bad fast5: Attribute read_008c8f1f-f32f-4b23-ab6f-1ef4f4531a20/pore_type in /nfs/research/zi/mbhall/tech_wars/data/madagascar/nanopore/raw_data/md_tb_reseq_2019_5/multi_fast5s/BC76_r0b1235_0.fast5 is duplicated and has two different values in two different places. Please report this with an example FAST5 file at 'https://github.com/hasindu2008/slow5tools/issues' for us to investigate.

Here is the fast5 that caused it.
BC76_r0b1235_0.fast5.gz

Hi @mbhall88
Is this a very recently generated FAST5 file?
@hiruna72 can you have a look at this attached file please?

interesting!
So i had a quick look at this with h5py
If you do something like this:
import h5py

f = h5py.File('BC76_r0b1235_0.fast5', 'r')

for read in f:
    for i, j in f[read].attrs.items():
        print(read, i, j)

you get something like...
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type b'not_set'
read_001526db-9526-4bc7-9e76-00f4259392cc run_id b'e7c896467265d9c5a774efee85e670ff7a21a05d'
read_008c8f1f-f32f-4b23-ab6f-1ef4f4531a20 pore_type b'not_set'
read_008c8f1f-f32f-4b23-ab6f-1ef4f4531a20 run_id b'e7c896467265d9c5a774efee85e670ff7a21a05d'
read_00b22781-bc8f-441a-a7c9-de8dcc597c59 pore_type b'not_set'
read_00b22781-bc8f-441a-a7c9-de8dcc597c59 run_id b'e7c896467265d9c5a774efee85e670ff7a21a05d'
read_01b85d51-168b-42c7-afaa-fce73c24f47f pore_type b'not_set'
read_01b85d51-168b-42c7-afaa-fce73c24f47f run_id b'e7c896467265d9c5a774efee85e670ff7a21a05d'
read_020f7362-e31b-46c6-8e4d-70b08a6f2c43 pore_type b'not_set'
read_020f7362-e31b-46c6-8e4d-70b08a6f2c43 run_id b'e7c896467265d9c5a774efee85e670ff7a21a05d'
read_032ba99a-a786-4c96-a962-a589588da4c2 pore_type b'not_set'
...

But if I look at the actual values...
for read in f:
    for i in f[read].attrs['pore_type']:
        print(read,'pore_type:', i)

I can see this
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type: 110
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type: 111
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type: 116
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type: 95
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type: 115
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type: 101
read_001526db-9526-4bc7-9e76-00f4259392cc pore_type: 116
read_008c8f1f-f32f-4b23-ab6f-1ef4f4531a20 pore_type: 110
read_008c8f1f-f32f-4b23-ab6f-1ef4f4531a20 pore_type: 111
read_008c8f1f-f32f-4b23-ab6f-1ef4f4531a20 pore_type: 116
read_008c8f1f-f32f-4b23-ab6f-1ef4f4531a20 pore_type: 95
...

This is hilarious. @hasindu2008 what do you wanna do?
James

Okay a few more details.
for read in f:
    for i, j in f[read].attrs.items():
        print(read, i, type(j))

gives:
read_fec54356-9a3a-42c3-9e8f-739513a3619b pore_type <class 'numpy.bytes_'>
read_fec54356-9a3a-42c3-9e8f-739513a3619b run_id <class 'numpy.bytes_'>
read_feec9e55-5765-4440-a414-0b624ac0d3aa pore_type <class 'numpy.bytes_'>
read_feec9e55-5765-4440-a414-0b624ac0d3aa run_id <class 'numpy.bytes_'>
read_ff126eff-7d31-48a5-b635-1637ed385fef pore_type <class 'numpy.bytes_'>
read_ff126eff-7d31-48a5-b635-1637ed385fef run_id <class 'numpy.bytes_'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type <class 'numpy.bytes_'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba run_id <class 'numpy.bytes_'>

but
for read in f:
    for i in f[read].attrs['pore_type']:
        print(read,'pore_type:', type(I))

gives
read_ff126eff-7d31-48a5-b635-1637ed385fef pore_type: <class 'int'>
read_ff126eff-7d31-48a5-b635-1637ed385fef pore_type: <class 'int'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type: <class 'int'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type: <class 'int'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type: <class 'int'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type: <class 'int'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type: <class 'int'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type: <class 'int'>
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type: <class 'int'>

weird

Apparently we have to do
print(read, i, j.decode('UTF-8'))

to get this:
read_fec54356-9a3a-42c3-9e8f-739513a3619b pore_type not_set
read_fec54356-9a3a-42c3-9e8f-739513a3619b run_id e7c896467265d9c5a774efee85e670ff7a21a05d
read_feec9e55-5765-4440-a414-0b624ac0d3aa pore_type not_set
read_feec9e55-5765-4440-a414-0b624ac0d3aa run_id e7c896467265d9c5a774efee85e670ff7a21a05d
read_ff126eff-7d31-48a5-b635-1637ed385fef pore_type not_set
read_ff126eff-7d31-48a5-b635-1637ed385fef run_id e7c896467265d9c5a774efee85e670ff7a21a05d
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba pore_type not_set
read_fff2915e-9a13-4da9-b9d2-cd616a36dfba run_id e7c896467265d9c5a774efee85e670ff7a21a05d

That will do the correct decoding of the numpy.bytes_ class

Not sure what the C equivalent here will be.
Not sure why I get different types when using an item() getter rather than a named get. If I tried to do a named get, I would not be able to see "note_set" at all, just random numbers. This has to be some kind of bug from the ONT side of things.
My guess is that slow5_tools is looking at the type of the value, and seeing int rather than some byte string, then comparing those values and seeing them as different, triggering the error. This information would be stored in the header once, as you would not expect multiple pore_types (at least not yet).

Hello @mbhall88,
Thank you very much for reporting this issue. The file you sent does not have an expected attribute (file_type) which is usually found at the root group. The file was misidentified as a single-fast5 file and that caused f2s to error out. The error message was saying something completely different. However, that helped us to discover another bug related to pore_type.

Could you please share any information on how this file was generated?

This sequencing run was done a few years ago - ~2019 I think. There's not really anything else I can think of that is out of the ordinary.... I thought that maybe I merged a bunch of single fast5s, but the file name makes me think not (I normally use the default prefix in the ont fast5 api singoe 2 multi tool, which renames them batch_0 etc.)
What other kind of info do you need?

It seems like this is one of those files between when ONT did the transition from single to multi-fast5. This file structure is something in between real  multi-fast5 and single to multi-converted fast5. Do you have many datasets like this or is it only a few? We have to think about how we can go ahead in doing this in f2s without affecting the types of fast5 files it work with. Till then could you please use this script? It is a script that I wrote to handle multi-fast5 generated using the ONT's single_to_multi_fast5 when multiple run IDs are mixed up in the same file. I ran this script on your file and it worked. Make sure you have multi_to_single_fast5   that comes with ONT fast5 API, h5dump (apt-get install hdf5-tools), parallel (apt-get install parallel) and slow5tools in PATH.

I've got about 5/6 runs I think. I wouldn't worry about trying to support files like this if they're a weird transition/corner case. Gotta maintain your sanity!
I'll give that script a go. Thanks!

Ohh there was a typo on this link and sorry I did not see the last 404 part until @hiruna72 told me, the link is https://github.com/hasindu2008/slow5tools/blob/master/scripts/mixed-multi-fast5-to-blow5.sh.

@mbhall88 Did this script work?

I think so. Sorry, I haven't forgotten about this. I am running it on a collection of nanopore runs and it's taking a few days. Hopefully the jobs will finish over the weekend. I'll close this issue when/if they finish successfully if that's okay?

Sure. No prob.

That script seems to have done the trick! Thanks a lot @hasindu2008


feat: wire up support for env variables

Description
The adds support for env variables to the list of optional ways to configure the OpenFGA server. Configuration is loaded according to the default behavior of the spf13/viper package. That is,

Viper uses the following precedence order. Each item takes precedence over the item below it:
explicit call to Set
flag
env
config
key/value store
default

Each config property is mapped to an env variable by translating the config to all uppercase and replacing any usage of . with _ and attaching the OPENFGA_ prefix to it. For example, http.enabled becomes OPENFGA_HTTP_ENABLED and authn.preshared.keys becomes OPENFGA_AUTHN_PRESHARED_KEYS etc..
References
https://github.com/spf13/viper#why-viper
Review Checklist

[X] I have added documentation for new/changed functionality in this PR or in openfga.dev
[X] The correct base branch is being used, if not main

Codecov Report

Merging #100 (74b9b22) into main (01571f9) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   76.58%   76.49%   -0.10%
==========================================
  Files          76       76
  Lines        8335     8337       +2
==========================================
- Hits         6383     6377       -6
- Misses       1567     1574       +7
- Partials      385      386       +1

Impacted Files
Coverage Δ

pkg/cmd/service/service.go
86.54% <100.00%> (+0.15%)
:arrow_up:

server/errors/errors.go
77.94% <0.00%> (-1.48%)
:arrow_down:

server/commands/check_utils.go
91.23% <0.00%> (-1.20%)
:arrow_down:

storage/postgres/postgres.go
64.74% <0.00%> (-0.67%)
:arrow_down:

storage/postgres/utils.go
83.43% <0.00%> (-0.64%)
:arrow_down:

server/commands/check.go
84.68% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01571f9...74b9b22. Read the comment docs.


Skype api integration in native android app

am new to  skype api integration can anyone tell me how to integrate it in my android app.and how to get that sky api in my applicatiion

Hi friend,
You have to do this: https://msdn.microsoft.com/en-us/skype/appsdk/gettingstarted


Subsequent commits to a tested pull request results in failures

It seems to not be able to parse the changelog

Check that you have the refspec set correctly for git.  +refs/pull/*:refs/remotes/origin/pr/*

Yes, I have this here on the Job/configure page ...
Is there anywhere else I should be doing this

Any update on this?


fix view signature and revoke btc

@keybase/react-hackers final integration for btc stuff

@keybase/react-hackers bump

👍


(suggestion) instead of replacing the character with a cursor you could keep both :D

I'm still mulling over whether I want the player to exist as a character in the world. I've designed some of the core mechanics I want, but I'm still feeling really vague about what the overall story/game looks like.

I like to think having a character in the world is an extra level of immersion which can get players more hooked. Factorio has one, it's nice to be able to take a break from building factories and go fight monsters in the world. The cursor system you have designed could be well adapted to a reticule aiming system.


odo reports no port for routes created through the Web UI

What versions of software are you using?

Created a component (nodejs-ex, pushed it, create an url, pushed it then went on the Web UI of the cluster and created another route to the same service.
Then run odo url list from the component folder.
Actual behavior
odo url list
Found the following URLs for component node1 in application app1:
NAME           STATE               URL                                                                 PORT     SECURE
               Locally Deleted     http://my-jeff.6923.rh-us-east-1.openshiftapps.com                  0        false
node1-8080     Pushed              http://node1-8080-app1-jeff.6923.rh-us-east-1.openshiftapps.com     8080     false

odo url list -o json
{
    "kind": "List",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {},
    "items": [
        {
            "kind": "url",
            "apiVersion": "odo.openshift.io/v1alpha1",
            "metadata": {
                "creationTimestamp": null
            },
            "spec": {
                "host": "my-jeff.6923.rh-us-east-1.openshiftapps.com",
                "protocol": "http",
                "secure": false
            },
            "status": {
                "state": "Locally Deleted"
            }
        },
        {
            "kind": "url",
            "apiVersion": "odo.openshift.io/v1alpha1",
            "metadata": {
                "name": "node1-8080",
                "creationTimestamp": null
            },
            "spec": {
                "host": "node1-8080-app1-jeff.6923.rh-us-east-1.openshiftapps.com",
                "protocol": "http",
                "port": 8080,
                "secure": false
            },
            "status": {
                "state": "Pushed"
            }
        }
    ]
}

Expected behavior
Either the second route should be discarded or correct port should be returned. This causes an issue in the IntelliJ OpenShift Connector which expect a port always to be returned.
Any logs, error output, etc?
Please not that although the second route is created with the Web UI, it has the Odo annotations, maybe retrieved from the service:
oc get routes
NAME              HOST/PORT                                                  PATH   SERVICES     PORT       TERMINATION   WILDCARD
my                my-jeff.6923.rh-us-east-1.openshiftapps.com                       node1-app1   8080-tcp                 None
node1-8080-app1   node1-8080-app1-jeff.6923.rh-us-east-1.openshiftapps.com          node1-app1   8080                     None

oc get route -o json
{
    "apiVersion": "v1",
    "items": [
        {
            "apiVersion": "route.openshift.io/v1",
            "kind": "Route",
            "metadata": {
                "annotations": {
                    "openshift.io/host.generated": "true"
                },
                "creationTimestamp": "2020-05-04T16:23:18Z",
                "labels": {
                    "app": "app1",
                    "app.kubernetes.io/instance": "node1",
                    "app.kubernetes.io/managed-by": "odo",
                    "app.kubernetes.io/managed-by-version": "v1.1.3",
                    "app.kubernetes.io/name": "nodejs",
                    "app.kubernetes.io/part-of": "app1",
                    "app.openshift.io/runtime-version": "10"
                },
                "name": "my",
                "namespace": "jeff",
                "resourceVersion": "452766276",
                "selfLink": "/apis/route.openshift.io/v1/namespaces/jeff/routes/my",
                "uid": "9054e198-8e23-11ea-91cc-02e0bae989b4"
            },
            "spec": {
                "host": "my-jeff.6923.rh-us-east-1.openshiftapps.com",
                "port": {
                    "targetPort": "8080-tcp"
                },
                "to": {
                    "kind": "Service",
                    "name": "node1-app1",
                    "weight": 100
                },
                "wildcardPolicy": "None"
            },
            "status": {
                "ingress": [
                    {
                        "conditions": [
                            {
                                "lastTransitionTime": "2020-05-04T16:23:18Z",
                                "status": "True",
                                "type": "Admitted"
                            }
                        ],
                        "host": "my-jeff.6923.rh-us-east-1.openshiftapps.com",
                        "routerCanonicalHostname": "elb.6923.rh-us-east-1.openshiftapps.com",
                        "routerName": "router",
                        "wildcardPolicy": "None"
                    }
                ]
            }
        },
        {
            "apiVersion": "route.openshift.io/v1",
            "kind": "Route",
            "metadata": {
                "annotations": {
                    "openshift.io/host.generated": "true"
                },
                "creationTimestamp": "2020-05-04T16:22:11Z",
                "labels": {
                    "app": "app1",
                    "app.kubernetes.io/instance": "node1",
                    "app.kubernetes.io/managed-by": "odo",
                    "app.kubernetes.io/managed-by-version": "v1.1.3",
                    "app.kubernetes.io/part-of": "app1",
                    "odo.openshift.io/url-name": "node1-8080"
                },
                "name": "node1-8080-app1",
                "namespace": "jeff",
                "ownerReferences": [
                    {
                        "apiVersion": "apps.openshift.io/v1",
                        "kind": "DeploymentConfig",
                        "name": "node1-app1",
                        "uid": "f3ec313d-8e22-11ea-bf74-02747f6a71ea"
                    }
                ],
                "resourceVersion": "452765881",
                "selfLink": "/apis/route.openshift.io/v1/namespaces/jeff/routes/node1-8080-app1",
                "uid": "68556716-8e23-11ea-91cc-02e0bae989b4"
            },
            "spec": {
                "host": "node1-8080-app1-jeff.6923.rh-us-east-1.openshiftapps.com",
                "port": {
                    "targetPort": 8080
                },
                "to": {
                    "kind": "Service",
                    "name": "node1-app1",
                    "weight": 100
                },
                "wildcardPolicy": "None"
            },
            "status": {
                "ingress": [
                    {
                        "conditions": [
                            {
                                "lastTransitionTime": "2020-05-04T16:22:11Z",
                                "status": "True",
                                "type": "Admitted"
                            }
                        ],
                        "host": "node1-8080-app1-jeff.6923.rh-us-east-1.openshiftapps.com",
                        "routerCanonicalHostname": "elb.6923.rh-us-east-1.openshiftapps.com",
                        "routerName": "router",
                        "wildcardPolicy": "None"
                    }
                ]
            }
        }
    ],
    "kind": "List",
    "metadata": {
        "resourceVersion": "",
        "selfLink": ""
    }
}

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

Still valid for odo 2.2.3

/remove-lifecycle stale

/remove-lifecycle stale
/lifecycle frozen

Either the second route should be discarded or correct port should be returned. This causes an issue in the IntelliJ OpenShift Connector which expect a port always to be returned.

The current behavior is wrong, but the second route (the one created by odo) can't be discarded. For odo the source of truth is devfile.yaml. If there is endpoint defined in devfile odo will create a route for it.
There are two possibilities how to do this right.
Option 1: odo will ignore the route that was not created by odo
Optoin 2: odo will get things into the correct state from odo point of view. This will result in next odo push deleting extra route created by webconsole.

this is v2 specific, v3 doesn't  have odo url list command
/close


Better cpuinfo for Macs

+1
On Sun, Oct 28, 2018 at 10:11 AM Tom Swirly<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/ManiacalLabs/BiblioPixel/pull/1032
Commit Summary

Better cpuinfo for Macs

File Changes

M bibliopixel/main/info.py
https://github.com/ManiacalLabs/BiblioPixel/pull/1032/files#diff-0
(5)
M bibliopixel/util/platform.py
https://github.com/ManiacalLabs/BiblioPixel/pull/1032/files#diff-1
(7)

Patch Links:

https://github.com/ManiacalLabs/BiblioPixel/pull/1032.patch
https://github.com/ManiacalLabs/BiblioPixel/pull/1032.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/1032, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA6a6l2VbyBWtCybHh9aOB9-n1UT5Heqks5upbsOgaJpZM4X9--P
.


[Security] Workflow gradle-wrapper-validation.yml is using vulnerable action gradle/wrapper-validation-action

The workflow gradle-wrapper-validation.yml is referencing action gradle/wrapper-validation-action using references v1. However this reference is missing the commit 89eda1fdc0167f59521d2bb10767f7169fb4d018 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

@akulpillai  please update your scripts or data, as specific version is used


metasploit: 6.1.15 -> 6.1.16

Motivation for this change
Update to latest upstream release 6.1.16
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147580 run on x86_64-linux 1

1 package built:

msf (metasploit)


1.4 branch: fix image caption not being centered

On Mac Firefox 66 (and I'm sure many other browsers), image captions on Casper 1.5.0 are not correctly centered. This small CSS change fixes this.
Before:

After:

Hey @soroushjp,
Thank you for the contribution but we're accepting PRs only for the latest Casper release. Of course if you want to fix figcaption alignment in 1.4, you can make these changes on your own verison of Casper 1.4.

No worries @peterzimon. I'm using this personally, was just providing fix for the community. Understand that this branch is no longer maintained, thanks.


Wrong filename in serv container of SeedImage pod

In CI and manual tests the SeedImage pod fails with this error in the serve container:
# kubectl -n fleet-default logs seed-image-master-cluster-k3s serve
2023/10/26 07:24:49 stat elemental-machine-registration-master-cluster-k3s-2023-10-26T07:24:47Z.iso: no such file or directory

According to the logs of the build container all looks fine:
# kubectl -n fleet-default logs seed-image-master-cluster-k3s build
xorriso 1.5.6 : RockRidge filesystem manipulator, libburnia project.

xorriso : NOTE : Loading ISO image tree from LBA 0
xorriso : UPDATE :      14 nodes read in 1 seconds
[...]
xorriso : UPDATE : Writing:      57344s   13.5%   fifo 100%  buf  50%
xorriso : UPDATE : Writing:     376832s   88.8%   fifo 100%  buf  50%  471.9xD
ISO image produced: 424245 sectors
Written to medium : 424400 sectors at LBA 48
Writing to '/iso/elemental-machine-registration-master-cluster-k3s-2023-10-26T07:24:02Z.iso' completed successfully.

But if you check carefully you can see that the filename is different in each containers, it ended with -2023-10-26T07:24:02Z.iso for the one in build and with -2023-10-26T07:24:47Z.iso for the one in serve.
According to PR #542 it seems that the ConfigMap is generated for each container but in that case the isoName seems to be re-generated each time (just an an assumption on my side).

Unable to replicate, but I will guess that the reconcile changes the output-name configMap and the pod is not picking up the change.
I put up #556 to try to fix this.


feat(areaLayersDetails): 13354 - Calculate Urban Core and Settled Per…

…iphery for any focused area
https://kontur.fibery.io/Tasks/Task/Calculate-Urban-Core-and-Settled-Periphery-for-any-focused-area-13354
Context:
Urban Core and Settled Periphery don't recalculate on new drawn geometry.
But we want to have them recalculated every time we draw something.
The reason was in cache invalidation.
After request on api/layers/details we put results in cache.
Before we had 2 type of record in cache:

eventId: Map
null: Map

Now we extended it with 3rd type:

hash: true

This is the hash of focusedGeometry, to invalidate layer with boundaryRequiredForRetrieval flag.
So if layer is boundaryRequiredForRetrieval and current focusedGeometry is already in cache - we don't need to request this layer again.
Notes:
if (layer.eventIdRequiredForRetrieval && !eventId) {
  console.warn(
    `Layer ${layer.id} request is skipped, as eventIdRequiredForRetrieval is true but evenntId is empty.`,
  );
  return false;
}

These lines fix a situation when in atom comes eventShape layer, that requires eventId, but eventId is already null.
This layer disappears next update, so this code just prevent invalid request. (check screenshot, 400 error)

Codecov Report

Merging #422 (880c91a) into main (bca5aed) will increase coverage by 0.37%.
The diff coverage is 4.91%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   11.74%   12.11%   +0.37%
==========================================
  Files         543      544       +1
  Lines       38827    38805      -22
  Branches     1166     1180      +14
==========================================
+ Hits         4560     4702     +142
+ Misses      33822    33669     -153
+ Partials      445      434      -11

Impacted Files
Coverage Δ

...yersDetailsResource/areaLayersDetailsParamsAtom.ts
0.00% <0.00%> (ø)

...ailsResource/areaLayersDetailsResourceAtomCache.ts
0.00% <0.00%> (ø)

...s_in_area/atoms/areaLayersDetailsResource/types.ts
0.00% <0.00%> (ø)

...ayers_in_area/atoms/areaLayersLegendsAndSources.ts
0.00% <0.00%> (ø)

src/core/shared_state/focusedGeometry.ts
61.22% <60.00%> (+0.17%)
:arrow_up:

src/core/app_config/index.ts
83.96% <0.00%> (-2.96%)
:arrow_down:

src/core/auth/types.ts
96.82% <0.00%> (-0.58%)
:arrow_down:

...omponents/ConnectedMap/map-libre-adapter/index.tsx
61.35% <0.00%> (-0.02%)
:arrow_down:

src/core/app/init.ts
0.00% <0.00%> (ø)

src/core/app/types.ts
0.00% <0.00%> (ø)

... and 24 more

@Akiyamka let's check the last  commit - it applies boundary required layer from cache when you switch event


Wrong download

I have download CreateBCSandBox from a customer's production cloud enviroment.
The docker image is this one:
$navdockerimage = 'mcr.microsoft.com/businesscentral/sandbox:15.3.40074.40822-es'
Which is fine, because it is the spanish localization that I want.
After some workarounds I finally can access Business Central on my machine, but localization is W1
Version: W1 15.4 (Platform 15.0.40939.41271 + Application 15.4.41023.41345)
Am I doing something wrong?

I answer my self: when download CreateBCSandBox from a BC Cloud enviroment, it includes
-includeCSide `
This parameter causes an error while installing:
IncludeCSide is no longer supported in Dynamics 365 Business Central 2019 wave 2 release (1910 / 15.x)
As I have very little (very) knowledge of Powershell I thought that putting this symbol # before that parameter would override it, so I just edited in the following manner:
#-includeCSide
after installing several times I figured out that my correction, what it really did was to override that parameter AND THE REST of the following parameters.
Finally I just deleted that parameter and re-run ps file and then it worked out fine.

Thanks for pointing this out - will remove the parameter from the script before downloaded.


release: make proper backup of map with stats

important for comparison

I mean - it's a screenshot, any more wishes?


cmd/compile: mid-stack inline dispatch functions that call a function on each path

package p

func dispatch(x int) int {
	if x < 10 {
		return small(x)
	}
	return big(x)
}

//go:noinline
func small(x int) int { return 0 }

//go:noinline
func big(x int) int { return 1 }

dispatch should be inlined: It is very simple, and on either path through the function we call exactly one other simple function.
It is not:
x.go:3:6: cannot inline dispatch: function too complex: cost 126 exceeds budget 80
This is because we attach a significant cost to each function call.
Note that we are happy to inline this dispatch function:
func dispatch(x int) int {
	fn := big
	if x < 10 {
		fn = small
	}
	return fn(x)
}

Fixing this requires either some special casing to recognize common patterns (like the original dispatch) or a bit of control flow analysis.
cc @randall77 @dr2chase

A similar-but-not-identical case (but I can open a separate issue if needed) is common in logging libraries like zap:
https://github.com/uber-go/zap/blob/feeb9a050b31b40eec6f2470e7599eeeadfe5bdd/logger.go#L175-L181
So much so that library authors resort to suggesting to users to -basically- perform the inlining manually:
https://github.com/uber-go/zap/blob/feeb9a050b31b40eec6f2470e7599eeeadfe5bdd/logger.go#L168-L173
as it allows to turn something like this:
logger.Debug("something happened",
  zap.String("field", obj.Field()),
  zap.Int64("state", obj.State()),
)

into this, potentially bypassing the vararg call:
if e := logger.Check(zap.DebugLevel, "something happened"); e != nil {
  e.Write(
    zap.String("field", obj.Field()),
    zap.Int64("state", obj.State()),
  )
}

If the compiler inlined Debug, it would be possible to avoid the vararg call in case debug-level logging is disabled at runtime, and potentially even calling the two obj methods if we knew they were side-effect free.

 That would treat these two cases similarly. Any interest in prototyping this?

I have a simplistic prototype that halves extraCallCost of calls inside the if. But it obviously falls for
if condition {
  return f1()
}
return f2()

even though it inlines
if condition {
  return f1()
} else {
  return f2()
}

This prototype doesn't seem to affect the time it takes for make.bash, and bin/go increases by 0.5% (+73K). Haven't run yet more benchmarks.
That made me think that maybe a better way to handle this would be to have the extraCallCost of the second call in each function to be always 1 (even the first one would work, but that would also affect functions with a single call) possibly with the added condition that at least one of the calls is inside the if.

maybe a better way to handle this would be to have the extraCallCost of the second call in each function to be always 1

Seems worth a shot.

possibly with the added condition that at least one of the calls is inside an if (assuming we don't want to inline a(), b())

I  think we want that added condition. I assume that we don't want to inline a(), b().
@dr2chase put together the initial heuristic, but that piece at least seems pretty clearly intentional.

Btw, for testing the impact, you may find github.com/josharian/compilecmp helpful

The ideas here will resolves the different use-cases I was targeting in https://github.com/golang/go/issues/19348#issuecomment-439370742.
My initial use-cases were around helper methods that do a switch/if-else-if-else or that call 2 functions (see f and g below).
f() {
    if x {
        a() // cost 57
    } else if y {
        b() // cost 1
    } else {
        c() // cost 1
    }
    d() // cost 1 (second function)
    e() // cost 57 // without this call, f should be inlineable
}

g() {
    a() // cost 57
    b() // cost 1
}

https://github.com/golang/go/issues/19348#issuecomment-439370742

Seems like we could rewrite the visitor slightly, make it compute the max of visits down two arms of an if, rather than the sum.

CL coming....

If y'all feel like playing with the CL to see how it does with your examples, that might be good.
When I benchmark, I don't get ginormous binary growth, but also things don't get much faster, but perhaps people have coded around this already.
amd64: https://perf.golang.org/search?q=upload:20200914.8
arm64: https://perf.golang.org/search?q=upload:20200915.1
Both did poorly on the same benchmark, which is "interesting".

Mystery regression debugged; if a function f looks like "return new(Thing).initThing()", and

initThing does not escape its receiver,
initThing is large enough that inlining it into f causes f to become too large to inline,
a hot caller of f does not escape f's result

then inlining initThing into f is a Bad Idea, because it results in avoidable heap allocation.  The "solution" to this is a hack, whereby small functions that contain allocations have a lower limit on the size of things that they will inline (similar mechanism to not-inlining into giant methods) which will tend to let them inline more often.  This bug could be biting us already, I just happened to make it appear with this bit of tinkering.
Better interleaving of escape analysis and inlining would help with this.  Like I said, hack.  I am benchmarking just to see what the this-time-for-sure heuristic does for binary size and benchmark time.
Interested parties are again invited to tinker with this, to see if it helps their code enough to matter.

There, regressions gone.  Slight performance increase, slight binary size increase.
https://perf.golang.org/search?q=upload:20200916.1

My Go time is severely restricted at the moment, but I really look forward to trying this out. And reverting my math/big hacks.

@josharian We're also discussing better hacks.  I'm not thrilled at the existence of additional knobs that are not measuring precisely what we care about, yet definitely have value.

@dr2chase Gentle ping. Any update? It will be great to get this into go1.16.
For more context, I have many functions that does something to the tune of:
func read1Byte() byte {
    if decodingFromBytes {
          read1ByteFromByteSlice()
    } else if decodingFromBufferedIO {
          read1ByteFromBufIO()
    } else {
          read1ByteFromIO()
    }
}

Currently, code like this can never be inlined, and using an interface prevented inlining from happening.
The common path of read1ByteFromByteSlice() is very cheap, and I wanted that inlined.

So, the CL is up for review, and there's an open "bug", and this is low-risk -- so it might go in later, rather than sooner -- i.e., it can go in after the deadline, unless I misunderstand that policy.  Right now I'm working on stuff that I'd call much riskier that we need to be sure works.  There's also some higher-priority inlining work going on to deal with a performance regression in 1.15, and that needs to happen first.  See #41474.  It's mostly done.
There's default/automatic concern about the effect this will have on build times and binary size, since it will by default cause more things to become inlineable, hence larger binaries, and more time needed to produce them, so we may want to tweak those knobs a little bit.

What's special about
if x { return f() } else { return g() }

that it should be inlined, but that
return f() + g()

should not be?
The inlining heuristics are currently oriented around the resulting code size. This justifies inlining a := g; if x { a = f }; return a() because it needs less code size than if x { return f() } else { return g() }: in particular, it only needs to generate one function call rather than two.
If the inlining heuristic cost assigned to function calls is too high, I think it's reasonable to just lower it. I don't see how control flow details weigh in here, since we're not doing any substantive control flow analysis at time of inlining.

Cutting the cost of a call in half  increases text size by 3.5%.
Cutting it to 39 (half of inline budget, minus 1) increases text size by 2%.
I could benchmark for a corresponding performance increase, but my recollection is we won't get it.
By-the-way, the best-looking "floats-all-boats" version of this CL doesn't work for a 3-call if tree.  It includes a budget for how much the "max accounting" can be lower than the "sum accounting", and the current works-best number there is only 68, which is 11 more than the cost of a call; 100 was also tested, and it was not as good -- the binaries were a bit larger (of course) and the performance improvements were not as good, and there were more losers.
All the benchmarking results used to obtain these parameters appear here.
Some heuristics were dropped, and two were added, in the course of this experiment.  Most recent is the right-most "sheet" (of many).  Escape-analysis-informed heuristics seemed like they ought to be better, but (1) other well-motivated CLs made it harder to use them and (2) given the parameters being tested at the time, they didn't work that well and (3) the hacky allocation/call/size heuristics worked surprisingly well.  Further research (that I don't have time for -- the freeze is getting harder and harder every day, and I need to return to the register ABI work) might revive them, though that would require a discussion of updating the call-graph on the fly (there are algorithms for this, but they're not the sort of thing you'd introduce this late in the release cycle).

What's special about
if x { return f() } else { return g() }

that it should be inlined, but that
return f() + g()

should not be?
The inlining heuristics are currently oriented around the resulting code size. This justifies inlining a := g; if x { a = f }; return a() because it needs less code size than if x { return f() } else { return g() }: in particular, it only needs to generate one function call rather than two.

My understanding of the inlining heuristics, is that a function takes more budget (~57 out of 80) than a simple instruction, because we decided the inclusion of a call that cannot be inlined suggests that inlining the wrapping function is of less value, so we reduced the leftover budget to about ~20.
However, a call like if x { f1() } else if y { f2() } else { f3() } is really a single function being called. Based on that, the cost should be the max cost of each block.
It should be just as possible to inline:
func a() {
  i++
  f()
}

as to inline
func a() {
  i++
  if i > 0 {
    f()
  } else {
    g()
  }
}

When we started talking about mid-stack inlining, the goal was to reduce function call cost to 1 (similar to panic, append, and other intrinsic functions). Since that is no longer on the table and a function call costs a large portion of the inlining budget, then we should allow a switch where only one branch is taken to equal roughly the same cost.
This is what the CL achieves.

If the inlining heuristic cost assigned to function calls is too high, I think it's reasonable to just lower it. I don't see how control flow details weigh in here, since we're not (at least yet) doing any substantive control flow analysis at time of inlining.

It would suck, both in performance (creating unnecessary temp closures) and readability, if we unintentionally encourage folks to resort to this.

However, a call like if x { f1() } else if y { f2() } else { f3() } is really a single function being called. Based on that, the cost should be the max cost of each block.

One of the costs we're trying to model here is code size. Inlining that 3-branch if statement replaces 1 call (the callsite) with 3 calls. The fact that only one of those 3 calls can execute on a particular invocation doesn't help with code size (unless the conditions can be statically evaluated).

Putting this off till 1.17, need to do other work first.  I do think the max-of-if-arms is reasonable, but we need to do a better job at not inlining in some cases.  The companion CL that was supposed to help with this was too flaky, Keith and I were discussing ideas in comments there.  Crude sketch is to put off the inlining decision till we can tell if it will over-fill an otherwise inlineable caller; alternately, look ahead more careful in the max-cost estimator.
One thing I tried that seems like a win is to also impose a quota/budget on the amount that max-if-cost may diverge from sum-if-cost; this reduced binary size increase without doing much at all to hurt performance.  Note that the interaction of max-if-cost with look-before-leap inline cost estimation will be a bit of pain.

Before I forget, here's a writeup of what I tried and what I learned, and what I might try in the future. https://docs.google.com/document/d/17LAdIdHbcdhvxxQ2nszx4SgM_vbDGz6rDoj7BjL7VqM/edit?usp=sharing


Expose maxclients option to command line

chef-zero is used for spinning up a Chef server for taste-tester (https://github.com/facebook/taste-tester). We've built futher automation around this and have run into practical limits on the number of clients that can reliably retrieve data via https.
Description
chef-zero uses WEBrick to serve https. The default number of request is tied to the default number of threads in WEBrick, which appears to be 100. As this is a subordinate component we need a way to pass in a different value so we can increase the the limit where needed.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

There's no new tests to test this, because actually testing the effects of maxclients being set is difficult to verify or falsify - due to timing.

After further testing, I've found that naievly increasing the number for "MaxClients" does not make a significant difference to the amount of concurrent requests that can be served. I am looking at other options for improving performance/scalability. Closing this for now.


fix toc

Docs Build status updates of commit 57e08c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/v8-web-control/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


ROX-16038 fix data race in the enricher

Description
If runImageScanAsync gets called more than once for the same image at the same time we could run into a data races in runScan if more than one goroutine gets to call scanAndSet.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed
TODO

/retest

/retest


Fix regeneratorRuntime errors

This closes #797 and #817
What's Changing and Why
This now uses @babel/plugin-transform-runtime and @babel/runtime in order to fix issues with the runtime builds in the current version.
We also updates core-js to version 3 to keep versions as up-to-date as possible
What else might be affected
This would be a patch release, or a minor release (as it changes deps from core-js from 2 to 3, which may potentially break transitive deps)
Tasks
This has been tested against node-vibrant with an upgraded version of jimp that originally had #797 issues

Published PR with canary version: 0.8.6-canary.815.502.0

@hipstersmoothie it seems that this PR has fixed the issue as confirmed by myself and @andrewrt

@crutchcorn can you fix up the merge conflicts?

No problem, will do

Resolved

:rocket: PR was released in v0.9.3 :rocket:


docs(batcher): incorrect metricDescriptor field labels

The doc says that custom batcher can determine aggregator for metrics by metricDescriptor.labels, while this is not true -- there are no metricDescriptor.labels in MetricDescriptor.
export class CustomBatcher extends UngroupedBatcher {
  aggregatorFor (metricDescriptor: MetricDescriptor) {
    if (metricDescriptor.labels === 'metricToBeAveraged') { // <= here is the problem
      return new AverageAggregator(10);
    }
    // this is exactly what the "UngroupedBatcher" does, we will re-use it
    // to fallback on the default behavior
    switch (metricDescriptor.metricKind) {
      case MetricKind.COUNTER:
        return new CounterSumAggregator();
      case MetricKind.OBSERVER:
        return new ObserverAggregator();
      default:
        return new MeasureExactAggregator();
    }
  }
}

Link: https://github.com/open-telemetry/opentelemetry-js/blob/master/doc/batcher-api.md
Also, I'd believe it can be documented too that how do we declare a metrics that will be aggregated by the custom aggregators with custom batcher.

@legendecas are you planning on fixing this? If so, assign yourself please. If not, can you mark it as up-for-grabs?

I think it was a typo when i wrote this, it's indeed not possible. At the bottom with the complete version i use if (metricDescriptor.name === 'requests').

Also, I'd believe it can be documented too that how do we declare a metrics that will be aggregated by the custom aggregators with custom batcher.

I believe thats what i was achieving with the complete exemple at the bottom ? Was i wrong ?

@vmarchaud  I believe thats what i was achieving with the complete exemple at the bottom

Yeah, you are right. I've missed that.


u coordinate expected 56 bytes, got 57

Here's an example in codesandbox:
https://codesandbox.io/s/morning-currying-59ptsd?file=/src/App.tsx
I've also tried this in node v18 and v20 with the same issue running with ts-node.
Perhaps I'm doing something incorrect?
My use case:
Users have pub/priv keys generated by this library -> convereted to hex -> encryped -> stored.
After that they use ECDH to save and exchange data.

It looks like the example was a little off, unless this is wrong but:
const priv = ed448.utils.randomPrivateKey();
const pub = x448.getPublicKey(priv);

x448.getSharedSecret(priv, pub);

That works, if using x448 to get the public and ed448 to get private.

ed448 and x448 keys are NOT interchangeable
const priv = x448.utils.randomPrivateKey();
const pub = x448.getPublicKey(priv);
x448.getSharedSecret(priv, pub);
x448.getPublicKey(priv);

Makes much more sense thank you!


make influence on latency more clear

By not running a full simulation, we reduce the time necessary to run the benchmark and make the effect on latency more clear.

No CI will run here, so I'll merge this manually.


Implement xml and Jason parsing

This will most likely be implemented via third party library

Potential XML is RapidXML

I believe chaiscript has the ability to with from_JSON. More testing needed & review on IMGUI integration


Can you add a default name?

It used to have it but I don't see that option anymore.

Yes, I removed this feature in 2.2.0 or 2.3.0. This option was applied to all chans and I thought that it isn't good.
Is it a big problem for you? When you send a post, your name will be saved in draft for this thread as long as client is running.

I'm fine with it being saved in drafts. I was just asking to see if it was an error.

There could be a setting added so that users can specify default logins for each Chan that is installed?


Should not exit with error when ghooks is missing

dcc01d2eca73275563248f49c16d0c3e91ec8fc5 introduced an error return value for when ghooks is not found.
This is a really bad idea, since git commands start failing whenever the node_modules directory is not populated. This started breaking our (Microsoft/vscode) integration.
I believe the previous behaviour of warning the user was the best one.

cc @dbaeumer

+1
and I found my gitlab ci build fail today because of this change.

@kentcdodds @gtramontina:
We could think about ways to make exiting with an error a configurable option (taken into account on install, maybe as a "re-runable" update script?).

Yeah, in retrospect, maybe this feature should have been released behind a flag so it doesn't break for people relying on the previous "default". On the other hand, and this can be very context specific, it could be potentially harmful to have ghooks installed, expecting hooks to run, but ignoring the fact that they where not actually running…
On a separate note, but somewhat related to this issue, one thing that just occurred me is that if we embed lib/runner.js within the template that gets dumped into each hook, we would not need ghooks to actually exist in node_modules, because all the logic to read from package.json, and so on, would be in the hook itself. Maybe this is a really bad idea, idk…

Patching the logic into the hooks themselves sounds good for me.
Couldn't we alternatively put the lib/runner.js into a separate file in the hooks folder, then being required by the hooks?
Updating ghooks as a dependency might then reinvoke the patching procedure to update the runner logic.

I like it.
Going down this route, though, would have the hooks running regardless of ghooks being under node_modules or not, which is still different than the "default" behavior pre 1.1.0. If users where relying simply on the warning, this could represent an issue for them.
@joaomoreno, @bruceCzK any :thought_balloon:?

Love that idea.

I wanted to weigh in that this new behavior is really painful on a project where I've recently added ghooks, but developers are still working on branches that don't yet have it. For "reasons" they can't rebase on the branch that has ghooks installed, but if they've visited that ghooks branch and run npm install, then they have these unskippable hooks. I expected -n to skip git hooks like it says on the tin -- indeed, it even says "Skipping git hooks" -- so this new behavior is incredibly unexpected.

This should be fixed now. Could y'all try out the latest version and let us know please? Thank you for your patience :-)


[2.0-preview] Effects for content stamped by dom-if keep running even when !if

dom-if supports a restamp mode, however that isn't the default. If a dom-if template is stamped, its property effects are enabled during the entire life of the app even if the if prop is set to false after being true.
Live Demo
http://jsbin.com/qitifu/edit?html,output
Steps to Reproduce

Add a the following dom-if:

<dom-if if="[[condition]]">
  <template>
     <div>[[prop]]</div>
  </template>
</dom-if>

Change to if=true
Change to if=false
Change prop
prop is actually updated in the DOM even though if=false

Expected Results
Changing properties that are bound to some nodes shouldn't have any cost when if=false
Actual Results
It does have a cost
Browsers Affected

All
Versions

Polymer: 2.0-preview

Fixed in https://github.com/Polymer/polymer/pull/4299!


DISTRO: add pathogenome

this adds the pathogenome distro to the cron-prepare workflow, which will trigger create-prepare-pr for the pathogenome distro after metagenome has completed.

waiting for this PR to pass before merging: https://github.com/qiime2/distributions/pull/366