[Feature Request] Delayed shutdown

As the popularity of the Palworld is fading away, watcher provides a lot of benefits. But because it immediately shutdown the server after all the player leaves. It doesn't allow 1 hour timer for the boss monster spawn to finish. It would be beneficial if we had a delay shutdown (DELAYED_SHUTDOWN) as env variable to control how long watcher to wait to close the server when eveybody leaves.
Thank you!

Hey @chowhi123! Thank you so much for your feature request. I think it would make for a great addition to the watcher! I will let you know when it's implemented :)

@chowhi123 Hi there, this feature has been added in the latest release, v0.2.0!

Thank you! You are amazing!


Space Creation: Deleted Space Names Trigger Unique Constraint Error

Description
When creating a new open space with a unique name, the space is successfully created. However, after deleting the newly created space, attempting to create another space using the same name triggers an error. The error message indicates an internal server issue with a SequelizeUniqueConstraintError: Validation error, suggesting the name is still being treated as non-unique despite the original space being deleted.
Video
https://www.loom.com/share/0517839429f14de3a0af6bd0f00933cc?sid=47cf6e1d-e74d-4032-9156-bbd0db89b66e
Steps to Reproduce

Create a new open space using a unique name
Delete the newly created open space
Attempt to create a new open space using the same name as the previously deleted space
Observe the error message:

Error creating space
Error: Unhandled internal server error: SequelizeUniqueConstraintError: Validation error.

https://github.com/dust-tt/dust/pull/9476


[HUDI-6126] Fix test testInsertDatasetWithTimelineTimezoneUTC

Change Logs
This PR fixes testInsertDatasetWIthTimelineTimezoneUTC which causes the GH Java CI to timeout during Spark tests (introduced by #8528).  The fix resets the TimeZone after the test is done.
Impact
Fixes the test.
Risk level
none
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

CI is green.


Game randomly refuses to go back to gamepad icons after an alt tab

I'd occasionally have to alt-tab again to get the game to show gamepad icons.
Would an option to force gamepad icons be possible?

Is this happening with PauseOnFocusLoss set to false in MetaphorFix.ini?

@Lyall Yeah I had that set to false when I was playing

@Lyall Yeah I had that set to false when I was playing

Did it happen before with pause on focus loss left enabled? I've just removed this option in the latest update as it was causing some bugs. I plan on revisiting it from a different approach at a later date.

I hadn't checked

The full game still seems to have this issue. I'd love if it were possible to just have an option to always force gamepad controls, and never show keyboard controls...

@Lyall I write this as I alt+f4 the game for the fifth time to reset the icons - the next 80 hours of my life would be super indebted to you if there was a way to get the game to force always having the gamepad icons shown... 😅

@Lyall I write this as I alt+f4 the game for the fifth time to reset the icons - the next 80 hours of my life would be super indebted to you if there was a way to get the game to force always having the gamepad icons shown... 😅

Is this an issue with the game even without MetaphorFix installed? I had assumed it would be related to the pause on focus loss option but I removed that several versions ago. If it does happen with the vanilla game, I can certainly look into forcing gamepad icons.

@Lyall I write this as I alt+f4 the game for the fifth time to reset the icons - the next 80 hours of my life would be super indebted to you if there was a way to get the game to force always having the gamepad icons shown... 😅

Is this an issue with the game even without MetaphorFix installed? I had assumed it would be related to the pause on focus loss option but I removed that several versions ago. If it does happen with the vanilla game, I can certainly look into forcing gamepad icons.

This is absolutely an issue with the vanilla game. For me if I ever Alt-Tab out of the game while playing, keyboard icons are forced on until a full restart. It's even happened to me without an Alt-Tab, but the issue is tough to pin down. I played the first 10 hours of the game without MetaphorFix, had the issue, had someone recommend the Fix, but saw no change in behavior.
I'm sure there are more subtle system-level things (multiple controllers plugged in, type of controller) at play here causing this issue to happen for some folks but not others...I've tried running the game with Steam Input disabled and enabled but seen no difference.

@Lyall I write this as I alt+f4 the game for the fifth time to reset the icons - the next 80 hours of my life would be super indebted to you if there was a way to get the game to force always having the gamepad icons shown... 😅

Is this an issue with the game even without MetaphorFix installed? I had assumed it would be related to the pause on focus loss option but I removed that several versions ago. If it does happen with the vanilla game, I can certainly look into forcing gamepad icons.

This is absolutely an issue with the vanilla game. For me if I ever Alt-Tab out of the game while playing, keyboard icons are forced on until a full restart. It's even happened to me without an Alt-Tab, but the issue is tough to pin down. I played the first 10 hours of the game without MetaphorFix, had the issue, had someone recommend the Fix, but saw no change in behavior.
I'm sure there are more subtle system-level things (multiple controllers plugged in, type of controller) at play here causing this issue to happen for some folks but not others...I've tried running the game with Steam Input disabled and enabled but seen no difference.

Okay, I just wanted to clarify that it wasn't MetaphorFix that was breaking something, since it would be better that I fix that instead! I'll look into forcing gamepad icons and report back when I have something.

Okay here is a test build that has an option to force controller icons at all times. Check MetaphorFix.ini to enable it.
MetaphorFix_v0.8.0_test2.zip

FYI you can edit comments on github

I tried this as had the same issue, it fixes the issue and buttons stay after alt-tab at the sacrifice of keyboard labels and mouse itself never appearing so navigating with the mouse becomes very hard (and the volume set to 4.0 also puts the game to the proper standard full level!) but it introduces a new bug as the text labels on the in game menu are now blank, tested by switching back to old version and back again and same issue re-occurs. Note that it happens with this version regardless if the gamepad icon setting is true or false.

Thanks for testing it. So you'd want ideally for the controller labels/glyphs to stay but the mouse cursor to still be visible when you switch inputs?
The blank menu bug is unrelated, I'd been doing some testing on fixing that particular issue a different way and those changes are present in the test build.

Yeah that'd be good imo (though I'm fine with keyboard input disabled in entirety personally)
Ideally, it'd be great if you manage to fix the handler in entirety so it works automatically as intended, but I'll be fine with just forcing myself

Yeah that'd be good imo (though I'm fine with keyboard input disabled in entirety personally)
Ideally, it'd be great if you manage to fix the handler in entirety so it works automatically as intended, but I'll be fine with just forcing myself

I think fixing the root cause would be very hard given that I can't replicate the issue on my end. We'd probably have to hope for Atlus to fix it, which, given that they actually patched the demo multiple times, might happen.

Here's another test build then. This time the approach is more targeted and should allow the mouse cursor to become visible.
MetaphorFix_v0.8.0_test4.zip

It works great!!!

Thanks for the feedback! This is added in v0.8.0.


Better messages on parse errors

Any error encountered by the lexer or parser will result in the somewhat unhelpful message gitsh: parse error.
We should try to tell the user:

what went wrong.
where the error occurred (especially for scripts).

The work done in #355 for reporting tab completion config file errors is probably relevant to this.


How to develop with default_app.asar?

Electron version: 0.37.4
Operating system: any

When default_app was folder, I can easly create instead it symlink to any folder with package.json, electron.js, e t. c. and process of developing was simple:
edit file -> restart electron app -> see result.
But new feature default_app.asar discouraged me. How I can develop? On any file change need to create asar archive of all my files that see result of what I coding?

Thankfully, you don't need to create an asar archive to start an electron project.
In fact, if you install electron globally on your system, all you need is a package.json file with a main: 'filePath' entry that points to the bootstrap file.
Then just run the command electron . in that directory and your app should attempt to start, provided you've set everything up correctly.
I'd recommend reading the Quick Start Guide to help orient you a bit with the standard development practices.

I try that way. Electron runs as node process, without gui.

You can use asar to unpack the archive yourself. Make sure to unpack it in /resources/app for it to work.

If you put your app in the same folder that default_app.asar is in but call the folder app/ then Electron should launch that app at startup instead of the default app.
Closing this out.

Thanks

It actually would be pretty nice to not ASAR default_app, it's pretty convenient to mess around with it for creating Electron bug repros / samples


Add support for FSDP+QLoRA and DeepSpeed ZeRO3+QLoRA

What does this PR do?

prepare_model_for_kbit_training and peft_module_casting_to_bf16 should be disabled when using FSDP+QLoRA or DeepSpeed ZeRO3+QLoRA.

This PR should be merged after Transformers PR https://github.com/huggingface/transformers/pull/29587

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

cc @younesbelkada

I can't repro the CI failure locally and on main, will fix in a follow up PR!


Can you please provide training code?

It would be really appreciated

Can you atleast mention the best hyperparameters used to get these results.

可以分享一下训练的代码吗，学习一下


Fix build falure by calling unexisting function __CFInitializeWinSock

#2026 seems to be calling wrong function.

@swift-ci please test

@swift-ci please smoke test and merge

@swift-ci please test and merge


Bump to v0.14.0.

Should we wait for this to be merged first? https://github.com/FuelLabs/sway/pull/1235


Use path.sep when generating readme

Currently the readmes sample commands to run bootstrap etc default to windows style paths. It would be cool to use path.sep when generating the readme to default to the system format that init was run on

:+1:


[develop] Tests for runtime and fixed lookup tables

Fixes https://github.com/MinaProtocol/mina/issues/13961
Fixes https://github.com/MinaProtocol/mina/issues/13091
Fixes https://github.com/MinaProtocol/mina/issues/13960
Built on top and blocked by:

[ ] https://github.com/MinaProtocol/mina/pull/13858
[ ] https://github.com/MinaProtocol/mina/pull/13939

Initially built using (top of my mind):
git checkout feature/custom-gates
git fetch origin
git reset --hard origin/feature/custom-gates
git submodule update --recursive
git checkout -b dannywillems/custom-gates-and-runtime-lookup-tests
git merge dannywillems/lookup-gate-runtime
# not fixing conflicts
cd src/lib/snarkyjs
git checkout feature/custom-gates
git fetch origin
git reset --hard origin/feature/custom-gates
git checkout -b dannywillems/custom-gates-and-runtime-lookup-tests
git merge dannywillems/lookup-gate-runtime
# not fixing conflicts
cd src/bindings
git checkout feature/custom-gates
git fetch origin
git reset --hard origin/feature/custom-gates
git checkout -b dannywillems/custom-gates-and-runtime-lookup-tests
git merge dannywillems/lookup-gate-runtime
# Fixing conflicts in `bindings.js` and `plonk_verifier_index.rs`
# Select one of the branch for the conflicts in `MINA_COMMIT` and `compiled`
cd ../../
npm run bindings
cd src/bindings
git add MINA_COMMIT compiled
git merge --continue
cd ../../
git add src/bindings
git merge --continue
cd ../../../
git add src/snarkyjs
git merge --continue

Related changes in snarkyjs and snarkyjs-bindings:

https://github.com/o1-labs/snarkyjs-bindings/pull/129
https://github.com/o1-labs/snarkyjs/pull/1094

TODO:

[x] Add a simple lookup with a fixed lookup tables
[x] Add m lookup into n random and indexed lookup tables (indexed = whose indexed starts at 0).

[ ] Fix 60f68d77f7e64d93c72f60ccbb36c5019667de01. Getting a ValueNotInTable from time to time. When using non random values, it seems to work. When using random values, it fails.

[ ] Test when the flag is not to None.
[ ] Add a test with a unique table and but with a random ID to see if it needs to be sequential.
[ ] Mixing with range check and xor built-in tables.
[ ] Mixing with runtime tables
[ ] Do the same than above, but with runtime tables
[ ] Negative tests for lookup and runtime tables. We must check the error message is consistent with the wrong values (ValueNotInTable is raised).
[ ] Remove the REMOVEME commit

Explain your changes:

This PR adds tests for runtime and fixed lookup tables in Pickles.

Explain how you tested your changes:

dune build @src/lib/pickles/test/optional_custom_gates/runtest

Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

When using random values, we are getting:
[exception] (monitor.ml.Error (Failure "ValueNotInTable(1)")
  ("Raised at Base__Result.ok_exn in file \"src/result.ml\", line 201, characters 17-26"
    "Called from Async_kernel__Deferred1.M.map.(fun) in file \"src/deferred1.ml\", line 17, characters 40-45"
    "Called from Async_kernel__Job_queue.run_job in file \"src/job_queue.ml\" (inlined), line 128, characters 2-5"
    "Called from Async_kernel__Job_queue.run_jobs in file \"src/job_queue.ml\", line 169, characters 6-47"
    "Caught by monitor block_on_async"))
Raised at Stdlib__String.index_rec in file "string.ml", line 128, characters 19-34
Called from Sexplib0__Sexp.Printing.index_of_newline in file "src/sexp.ml", line 113, characters 13-47

See dannywillems/custom-gates-and-runtime-lookup-tests-rebased.

See also https://github.com/MinaProtocol/mina/pull/13973/commits/04e8db2047ebd1e2e97575a4827dfe0a458d247a

See https://github.com/MinaProtocol/mina/pull/14064#issue-1887086535 instead.


Add HTTP Size Support for 301/302 Requests

Currently HTTP Response size of Redirects is not displayed, even with the -l flag in Directory Mode.  I'm not sure how common it is in the real world, but I've come across several CTF Machines that unintentionally expose PHP Scripts by forgetting to call exit() after HTTP Redirect.
This is the only reason I'd prefer to use DirBuster over the command line alternatives (GoBuster/Dirb).  I'd love to recommend GoBuster as its CLI Driven, Faster, and more reliable however I really dislike the lack of response since on the 301/302 requests.

This appears to be due to the HTTP Redirect being classified as an Error.

Are you able to confirm this is still an issue with 2.0.0 ?

closing due to lack of response


add profiles feature (issue #678)

Users now can set up profiles for the whole family. and continue watching only those movies that were watched only in this profile

can you remove the files ProfileSpec.groovy & ProfileControllerSpec.groovy? Since no real tests are implemented, only the default one, travis is failing.

I will review asap :)

Ok awesome! lets add it to streama :)


Naming convention for service name in our repos

As part of the repo structure guidelines we have been hitting a number of questions on what we should exactly name the <service name> folders in the guidelines outlined at https://github.com/Azure/azure-sdk/blob/master/docs/engineering-system/repo-structure.md.
Currently the guideline is:
<service name> - Should be the short name for the azure service. It will be used to group all the various packages for a given service, including the management and data-plane packages, as well as any multi-api (e.g. or different profile versions (e.g AzureStack). Any shared artifacts like release notes or versions should go into this root repo. These names should match across all the different language repos and by default should be what is in the specification folder in the azure-rest-api-specs repo.
However the names that are in the specification repo and in the different languages currently are not always consistent. In fact other places are also inconsistent like the docs vs the portal. On top of that a lot of the names are all lowercase with no word separators which can make them difficult to read in a number of cases.
One proposal would be to use the names that we list on our public Azure product page at https://azure.microsoft.com/en-us/services/. They seem to use lower kebab-casing some examples that keep coming up would be as follows:

event-hubs https://azure.microsoft.com/en-us/services/event-hubs/
service-bus https://azure.microsoft.com/en-us/services/service-bus/
cosmos-db https://azure.microsoft.com/en-us/services/cosmos-db/
key-vault https://azure.microsoft.com/en-us/services/key-vault/
storage https://azure.microsoft.com/en-us/services/storage/

So if we use those names then the root sdk examples for all the languages would be:
sdk\event-hubs
sdk\service-bus
sdk\cosmos-db
sdk\key-vault
sdk\stoarge

@adrianhall is this a topic we could get into an upcoming review slot?
Arch Board PTAL @KrzysztofCwalina @bterlson @JeffreyRichter @JonathanGiles @johanste

I think .NET developers would prefer .NET casing, i.e. pascal casing.

The current guideline is:

The current guideline is:
pick a package name that allows the consumer to tie the namespace to the service being
used.  As a default, use the compressed service name at the end of the namespace.  The
namespace does **NOT** change when the branding of the product changes, so avoid the
use of marketing names that may change.  (See below for examples).

However, I defer "compressed" to the language-specific guidelines - whether it's camel case or kebab case or snake case or whatever.  I understand that the GitHub repo should be named consistently, so your engineering system guidelines should define what "compressed" means in that context.   That's a job for @maggiepint

There is I suppose an option where the repo for the language follows the convention that the language follows for packages. Trying to think what the impact of this choice would be on the build system or reporting over time.

Further thought on this - we have chosen snake case for the names of the repos themselves. I'm pretty sure we're not going to change that, so maybe snake case is the best choice for the subfolders as well? I think it creates consistency across a lot of urls which is always good.

For the Java perspective - I have no opinion nor preference, and I don't believe Java users will either. In this case, I vote for consistency across all languages for the reason Maggie states.

I believe we are all sold on this now.
Within the repostructure.md file is the following statement:
These names should match across all the different language repos and by default should be what is in the specificiation folder in the [azure-rest-api-specs](https://github.com/azure/azure-rest-api-specs) repo.

This should cover all the cases.  If not, put in a PR to adjust the repostructure.md (which is moving on Monday to docs/policies/repostructure.md)


#166120924 Fixes user schema field names inconsistency

What does this PR do?

Specifies the field names to get data for the passportUrl, isAdmin, isPolitician fields during deserialization and serialization of the user schema.
Description of Task to be completed?

[x] Add the data_key and attribute parameter.
[x] Run the tests

What are the relevant pivotal tracker stories?
#166120924

Coverage remained the same at 97.375% when pulling cf5b4ad66e724563560f422954a1976518d34124 on bg-rename-user-schema-fields-166120924 into 5516eb1ea0e3a9ca27b6eec0aee1b9f4912a182f on develop.


New package: Wildy.bobonslaught version faf57

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/112077&drop=dogfoodAlpha

https://update.hyundai.com/US/EN/navigationUpdate

https://github.com/kimci86/bkcrack/releases/download/v1.5.0/bkcrack-1.5.0-win64.zip


Make the git:remote command print out the remote's value even if the remote already exists

Currently, the output looks like this:
ENG000656:k8s-claimer aaronschlesinger$ deis git:remote
fatal: remote deis already exists.
Error: exit status 128

Would be nicer if it printed out what the remote should be, but it could still exit non-zero

Even better, we could do something like this:
$ deis git:remote
fatal: remote deis already exists and is not set to the expected url.
Got remote deis ssh://git@deis-builder.test.com:2222/oldapp.git
Expected remote deis ssh://git@deis-builder.test.com:2222/newapp.git
Please run 'deis git:remote -f` to overwrite
$ deis git:remote -f
Git remote deis ssh://git@deis-builder.test.com:2222/newapp.git added.
$ deis get:remote
Git remote deis already exists and is set correctly


Review and add to "SEO best practices"

Review article and cheatsheet and add info to "Seo best practices" cheatsheet:
https://moz.com/blog/seo-cheat-sheet
https://d2eeipcrcdle6.cloudfront.net/seo-cheat-sheet.pdf

https://github.com/devbridge/Front-End-Toolkit/wiki/SEO-best-practices


2FA : add a third option to get Biometric and PIN check at wallet creation or later

see @HugoNDO for UX design

Onbboarding : https://www.figma.com/file/gNQ9POVTHhxZQbzRQl6Qks/Altme?type=design&node-id=7223%3A11995&mode=design&t=BKqlqtMoZh6SLvsA-1
Drawer : https://www.figma.com/file/gNQ9POVTHhxZQbzRQl6Qks/Altme?type=design&node-id=3759%3A9853&mode=design&t=BKqlqtMoZh6SLvsA-1

Hedera grant

@bibash28 You have done this one


Add additional human data to organoid dataset

Dataset/group this task is for:
New 2nd submission: https://docs.google.com/spreadsheets/d/1ASb27e0yLKgA_dEHKKJahsKlGdxjre5H-ZmvSlv0ZHM/edit#gid=75289684

This relates to the organoid dataset: https://data.humancellatlas.org/explore/projects/005d611a-14d5-4fbf-846e-571a1f874f70
Description of the task:

As I was collecting contributor matrices I realised that the data that we have has been published in the papers here:
https://www.nature.com/articles/s41586-019-1654-9?draft=collection
The nature paper has multiple arrayexpress accessions, I crossed out ones that we probably don't want

E-MTAB-7552 (single-cell RNA-seq data based on 10x Genomics) - this contains the data we have in HCA currently, there is more human data in this submission we could add
E-MTAB-8234 (single-cell RNA-seq data based on Fluidigm C1/Smart-seq2)
E-MTAB-8089 (single-cell ATAC-seq of human organoids)
E-MTAB-8043 (single-cell ATAC-seq of chimpanzee organoids)
E-MTAB-8083 (single-cell ATAC-seq of bonobo organoids)
E-MTAB-8087 (single-cell ATAC-seq of macaque organoids)
E-MTAB-8228 (the bulk ATAC-seq data) - ?
E-MTAB-8230 (snRNA-seq data of the adult brain samples)
E-MTAB-8231 (bulk RNA-seq data).

The expression data are also available for exploration in scApeX via the link https://bioinf.eva.mpg.de/shiny/sample-apps/scApeX/
There is also the issue that the data we have has been accessioned twice, once by us and once as part of the arrayexpress submission
Acceptance criteria for the task:

[ ] links are made between the data we currently have and what has been accessioned, publications and supplementary links are added
[ ] other arrayexpress submissions are assessed and relevant data added to the existing submission (or new submissions are made)
[ ] plan for what to do about the double accessioned biomaterials and files

Updating with new donors and samples (2nd submission)

New submission metadata complete but need to ask Alegria about which submission 1 uuids to add.

The new submission is almost ready. The metadata is uploaded but @aaclan-ebi is going to first delete some errors from an old submission. The raw fastq files are downloading from NCBI.

Put into secondary review when ready!

Picking this up for secondary review!

@idazucchi and I need to discuss this dataset, setting up a meeting for Monday

Hello!
As we discussed here is the complete list of suggestion for the dataset. The most important ones are those on the modelling of the organoids and cell suspensions, the rest are suggestions of additional fields you could fill in.
Donor

For donors HC1, HG1 and HE1 brain samples were collected post-mortem, so alive at collection should be no

Collection protocol

I would remove collection_protocol_hIPSC_RIKEN_resource and collection_protocol_hIPSC_system_biosciences, and use the induction protocol from sumbission 1 ipsc_induction_protocol_1
in submission 1 there’s no collection protocol for the specimen, do you think that we can use collection_protocol_skin for submission1’s specimens as well?

Cell line
You could add some information about:

the cell line supplier
growth medium: cell were cultivated using  mTeSR1 (StemCell Technologies) on matrigel-coated plates
feeder layer: standard feeder-free conditions
mycoplasma testing: PCR validation, pass
cell type
the karyotype is normal, can we say normal, like in the disease field of is it just blank?
disease: normal? there’s no indication of disease
the cell line publication information: I think you’ve included it the collection protocol
for h409B2_1 and SC102a1_1 I would reuse the iPSC induction protocol from submission1 rather than the collection protocols collection_protocol_hIPSC_RIKEN_resource and collection_protocol_hIPSC_system_biosciences

Organoid

I would remove the biosample accession from this tab because I think that they more accurately represent the cell suspensions
E-MTAB-7552:

the pooled organoids are included in submission 1, all the files are there too: I think they can be removed should be removed
Org32d_H9_h409B2 should be split into two organoids and pooled at cell suspension level

E-MTAB-8234:

I think it should 3 organoids based on the info in supplementary materials table 1 and then 125 cell suspensions

E-MTAB-8098:

some organoids have 2 cell lines as input need and need to be split up. They have been pooled at cell suspension level

Cell suspension:

You could add the INDSC sample accessions, which are available for all cell suspensions
E-MTAB-7552:

the pooled cell suspensions are in submission 1, all the files are there too: should be removed
You could add the viability method trypan blue

E-MTAB-8234:

are the codes like pate labels? like for SS2?
the estimated cell count could be 1 cell per cell suspension
You could add the viability method trypan blue
I would swap the dissociation protocol Cerebral_whole_organoid_dissociation with Cerebral_dissected_organoid_dissociation_enzymatic because it’s more similar to what is described for organoids processed with Fluidigm

E-MTAB-8231:

the dissociation protocol is missing

E-MTAB-8228:

the organoid age is available from ArrayExpress, but measured in months, either 2 or 4

Library prep

SmartSeq2_library_preparation is not needed
for bulk_RNA_library_preparation you could fill the the preparation kit field

Sequence file

You could fill in the read length field, the information is available from ArrayExpress
The library preparation ID is filled with Experiment accessions, I think that they shouldn’t be there
E-MTAB-8234:

just C1_library_preparation, there’s no SmartSeq2 data

Analysis file
You could add the analysis files available from E-MTAB-7552
Expected number of entities
This is an attempt to check how many files/organoids/cell suspension to expect in the finished spreadsheet

AE   project accession
#oragnoids
#cell suspension
#fastqs

E-MTAB-7552
13
12
42

without mixed samples from early  organoid development || 2 libraries sequenced   twice

E-MTAB-8234
3
125
250

I think it's 3 organoids based on the info in Supplementary table1 - fluidigm

E-MTAB-8089
1008
696
1392

under the assumption that each set of files corresponds to a different   organoid

E-MTAB-8230

not eligible: post mortem donors human samples were processed together with ape samples

E-MTAB-8231

30
60

post mortem donors||bulk data

E-MTAB-8228
12
12
24

Total
1036
875
1768

Duplicated Biosample accessions
This is still an open question, I'm not sure of how we want to address it

@ami-day will finish this for next release.

Thanks @idazucchi I have made almost all of these changes.
About the potentially duplicate biosamples: I decided to remove those biosamples from this submission update.
I am now downloading the fastq files so I can fill the file names and upload to ingest.

upload area: 04dfcbed-8a97-4788-9de2-eacb1f64c7ef/

SRA file conversion is incredibly slow. No other options to get the raw data. Removing this dataset from release 14 and will tag it with release 15.

This will probably be done today

Fix is now in prod. Submission cannot be deleted. Alegria to try to delete again.

The submission with uuid 8e1cee01-4bd4-4c97-a201-a80fa8ec4b5f is now deleted. I'm not sure if my attempts the other day went thru but when I check today the submission is already gone and there's already a new submission.

Alegria and I are looking into an issue in ingest.

syncing the fastq files to ingest prod.

submitted.

In attempting to re-export this as part of the r16 missing file descriptor issue, we have had an exporter failure where the project's supplementary files failed to export to terra because they are "DCP1" files:

hipsci-ipsc-pipeline.pdf
Dissociation_protocol_130-092-628.pdf
CG00052_SingleCell3_ReagentKitv2UserGuide_RevE.pdf

These supplementary files are exported with every experiment so all the experiments "failed" to export because the file metadata was a different schema in DCP1 and DCP2 metadata has not been stored against these files (file type & size and so on)
But the error is kind of irrelevant because we would not have been able to retrieve the file to send to terra since the original HCA S3 bucket no longer operates, so we would not have been able to get the files to add to terra.
Either these supplementary files are important to add with this new dataset and we should:

remove the old supplementary file references
get a copy of the files (either from dcp1 or our wrangling files)
upload the files as supplementary files to the project
reexport

Or the files are not relevant to the new dataset, then we can:

remove the files from the project
reexport

@ami and @yusra-haider, lets talk about this tomorrow.
s3://org-humancellatlas-upload-prod/fce97270-fce0-4744-8a4e-a93d95521852/hipsci-ipsc-pipeline.pdf
s3://org-humancellatlas-upload-prod/fce97270-fce0-4744-8a4e-a93d95521852/Dissociation_protocol_130-092-628.pdf
s3://org-humancellatlas-upload-prod/fce97270-fce0-4744-8a4e-a93d95521852/CG00052_SingleCell3_ReagentKitv2UserGuide_RevE.pdf

Do we need the supplementary files or not? A discussion needs to be made between @ami-day and @idazucchi , maybe for release 18 rather than 17 so no priority here

I have the 3 supplementary files at hand, let me know if you need them (Also sent them to @idazucchi )

Enrique retrieved the missing files from the DCP.
We need to discuss how we want to proceed

@idazucchi @ami-day @yusra-haider @ESapenaVentura to have a discussion on this today

Hi @MightyAx If these files will still be present associated with the initial dataset before it got submitted, if they are not present in the 2nd submission (update) dataset, that is ok.

Can they be deleted and the submission re-exported?

At the moment the plan is to:

upload the supplementary files in a bucket
give them the same metadata as the orginal ones, uuid and fileID (?) in particular
change the cloudURL to point to this new bucket
export

This should allow ingest to find the files and export correctly.
This solutions should allow future updates without running again into this issue
please @yusra-haider feel free to edit my explanation to make it more accurate/detailed
@ami-day we can't really delete these files because they are linked to the protocols of the 1st submission, which are reused in the 2nd submission

I've been looking at the code, and it seems it won't be possible to update the cloudURL  using the rest api calls, as we have guards against that.
I'm planning on:

unlinking the supplementary files from the project
clearing the staging area for this project
re-exporting the project
linking the supplementary files back to the project

this is a one time solution and we need to come up with a more permanent solution for the future.
I'm planning on testing this out on some other environment before doing these steps for this project on prod.

Steps taken to fix this issue:

[ ] remove supplementary files from project
Command used:
curl -X PUT -H "Authorization: Bearer $TOKEN" -H "Content-Type: text/uri-list" "https://api.ingest.archive.data.humancellatlas.org/projects/5cdbdd82d96dad0008592f2a/supplementaryFiles")

[ ] set submission back to graph valid state

[ ] redeploy state tracker to sync state

[ ] delete all the exported files / metadata for this project on GCP, to give exporting a fresh start

[ ] re-export choosing the option:
clicked Submit metadata and data to HCA

[ ] link the supplementary files back to the project
Commands used:

`
curl -X PATCH -H "Authorization: Bearer $TOKEN" -H "Content-Type: text/uri-list" "https://api.ingest.archive.data.humancellatlas.org/projects/5cdbdd82d96dad0008592f2a/supplementaryFiles" -d "https://api.ingest.archive.data.humancellatlas.org/files/5cdbdd82d96dad0008592f2b"
curl -X PATCH -H "Authorization: Bearer $TOKEN" -H "Content-Type: text/uri-list" "https://api.ingest.archive.data.humancellatlas.org/projects/5cdbdd82d96dad0008592f2a/supplementaryFiles" -d "https://api.ingest.archive.data.humancellatlas.org/files/5cdbdd82d96dad0008592f2c"
curl -X PATCH -H "Authorization: Bearer $TOKEN" -H "Content-Type: text/uri-list" "https://api.ingest.archive.data.humancellatlas.org/projects/5cdbdd82d96dad0008592f2a/supplementaryFiles" -d "https://api.ingest.archive.data.humancellatlas.org/files/5cdbdd82d96dad0008592f2d"
`

This still needs the state of the dataset to be set to 'exported'

Was the import form submitted?

Yes. An import form was submitted for Release 17 (on 31st May) specifying New raw data, New contributor-generated matrix, New metadata, Updated metadata


Close sidebar on icon click

Dear Danny,
Consider adding an option or even default behaviour (which should be an easy trick to do) to close formerly opened sidebar panel if user clicks toolbar icon again.

Actually the same behaviour (closing the sidebar) is expected after pressing keyboard combo once again.
For example, Ctrl+B opens Bookmarks panel and closes it as well.

Err… Hello?


Errors during Image build

I am getting the below errors when I am trying to build a docker image. Any thoughts?

My command is "docker build -t tutorial_withvi .". I am trying to add VI to the image. Below are errors in text.
=> ERROR [stage-1 3/7] COPY src/ /usr/local/src/                                                                  0.0s
=> ERROR [stage-1 4/7] COPY ./bin/refresh-exercises /usr/local/bin                                                0.0s
=> CACHED [stage-1 5/7] RUN apt-get install vim                                                                   0.0s
=> ERROR [stage-1 6/7] COPY docker-entrypoint.sh /usr/local/bin

This repo is outdated. Please try with the https://github.com/Accelergy-Project/timeloop-accelergy-exercises


Dylan: Be a guest on Talk Python To Me about Grumpy?

Hi Dylan,
You're a tough guy to find contact info for, so I'll file an issue for my request. :)
Would you be up for coming on https://talkpython.fm/ to talk about your project? I'd love to chat with you.
Best,
Michael

:) You're persistent. I'll reply on LinkedIn. Just haven't gotten around to it yet.

Thanks Dylan. I appreciate it.


Backspace Bug

The following steps result in an exception:

Create a list node
Press Shift+Enter to insert a break inside the list node
Press Backspace

Here's a gomix for reproduction:

https://big-keeper.gomix.me
https://gomix.com/#!/project/big-keeper

Here's a video: https://streamable.com/7o4xz

Added a failing test to Slate https://github.com/ianstormtaylor/slate/pull/524

Waiting for merge https://github.com/ianstormtaylor/slate/pull/594


pyocd cannot flash .bin if there only flash alogrithm defined in .pdsc

The DFP packs works well with keil, but use pyocd it report no identifiable boot memory.
Looks pyocd cannot recognize the flash algo as flash memory.
Device family definition in DFP pack:
  <devices>
    <family Dfamily="LPC54018M" Dvendor="NXP:11">
      <description>The LPC540xx are ARM Cortex-M4 based microcontrollers for embedded applications. These devices include an ARM Cortex-M4 coprocessor, up to 360 KB of on-chip SRAM, full-speed and high speed USB device interface with Crystal-less operation, a DMIC subsystem with PDM microphone interface and I²S, five general-purpose timers, one SCTimer/PWM, one RTC/alarm timer, one 24-bit Multi-Rate Timer (MRT), a Windowed Watchdog Timer (WWDT), eight flexible serial communication peripherals (each of which can be a USART, SPI, or I²C interface), and one 12-bit 5.0 Msamples/sec ADC, and a temperature sensor. The ARM Cortex-M4 is a 32-bit core that offers system enhancements such as low power consumption, enhanced debug features, and a high level of support block integration. The ARM Cortex-M4 CPU incorporates a 3-stage pipeline, uses a Harvard architecture with separate local instruction and data buses as well as a third bus for peripherals, and includes an internal prefetch unit that supports speculative branching. The ARM Cortex-M4 supports single-cycle digital signal processing and SIMD instructions. A hardware floating-point unit is integrated in the core.</description>
      <device Dname="LPC54018M">
        <processor Dcore="Cortex-M4" Dfpu="SP_FPU" Dmpu="MPU" Dendian="Little-endian" Dclock="180000000"/>
        <environment name="iar">
          <file category="linkerfile" name="iar/LPC54018M_spifi_flash.icf"/>
        </environment>
        <memory name="SRAMX" start="0x00000000" size="0x030000" access="rw" default="1"/>
        <memory name="SRAM_0_1_2_3" start="0x20000000" size="0x028000" access="rw" default="1"/>
        <memory name="USB_RAM" start="0x40100000" size="0x2000" access="rw" default="1"/>
        <algorithm name="arm/LPC540xx_W25Q32JVWJX.FLM" start="0x10000000" size="0x00400000" RAMstart="0x20000000" RAMsize="0x00001000" default="1"/>
        <debug svd="LPC54018M.xml"/>
        <variant Dvariant="LPC54018J2MET180">
          <compile header="fsl_device_registers.h" define="CPU_LPC54018J2MET180"/>
        </variant>
        <variant Dvariant="LPC54018J4MET180">
          <compile header="fsl_device_registers.h" define="CPU_LPC54018J4MET180"/>
        </variant>
      </device>
    </family>
  </devices>

$pyocd flash hello_world.bin --pack C:/NXP/LPC54018M_DFP.12.1.0.pack -t LPC54018J2MET180
0001293:WARNING:cmsis_pack:CMSIS-Pack device LPC54018J2MET180 has no identifiable boot memory
0001643:CRITICAL:__main__:No boot memory is defined for this device
Traceback (most recent call last):
  File "c:\mycode\pyocd\pyocd\__main__.py", line 398, in run
    self._COMMANDS[self._args.cmd](self)
  File "c:\mycode\pyocd\pyocd\__main__.py", line 575, in do_flash
    file_format=self._args.format)
  File "c:\mycode\pyocd\pyocd\flash\file_programmer.py", line 157, in program
    self._format_handlers[file_format](file_obj, **kwargs)
  File "c:\mycode\pyocd\pyocd\flash\file_programmer.py", line 170, in _program_bin
    raise exceptions.TargetSupportError("No boot memory is defined for this device")
TargetSupportError: No boot memory is defined for this device

$ pyocd flash hello_world.bin --pack C:/NXP/LPC54018M_DFP.12.1.0.pack -t LPC54018J2MET180 -a 0x10000000
0001065:WARNING:cmsis_pack:CMSIS-Pack device LPC54018J2MET180 has no identifiable boot memory
0001417:CRITICAL:__main__:no memory region defined for address 0x10000000
Traceback (most recent call last):
  File "c:\mycode\pyocd\pyocd\__main__.py", line 398, in run
    self._COMMANDS[self._args.cmd](self)
  File "c:\mycode\pyocd\pyocd\__main__.py", line 575, in do_flash
    file_format=self._args.format)
  File "c:\mycode\pyocd\pyocd\flash\file_programmer.py", line 157, in program
    self._format_handlers[file_format](file_obj, **kwargs)
  File "c:\mycode\pyocd\pyocd\flash\file_programmer.py", line 176, in _program_bin
    self._loader.add_data(address, data)
  File "c:\mycode\pyocd\pyocd\flash\loader.py", line 115, in add_data
    raise ValueError("no memory region defined for address 0x%08x" % address)
ValueError: no memory region defined for address 0x10000000

The DFP is missing a <memory> element for the flash at 0x1000_0000.
It makes sense to create a memory region when there is an <algorithm> defined that has no matching <memory>, as long as it doesn't overlap with another memory region. This is actually already on my todo list, just haven't had time to get to it. If you have time to help it would be greatly appreciated 😄 .

I wonder how this should be solved?If I were to add the  element to my local pack, such a change would not make sense on pyOCD. @flit

Well, the best way would be to implement the fix in pyOCD so it creates a memory region for an algorithm when there isn't one, then submit a pull request for the change. 😁
If you modify your local pack, you can tell pyOCD to use it by using the --pack argument or pack session option.


⚠ Slack has degraded performance

In 31d862f, Slack (https://status.slack.com/api/v2.0.0/current) experienced degraded performance:

HTTP code: 200
Response time: 43 ms

Resolved: Slack performance has improved in 6c07329.


date and time don't displayed

I use the example of Swift. but the cell that displays the date does not appear
thnx

Thanks @trikiano ! :smile:
Please provide all the information in the issue template so we can help!
And don't forget to read our contribution guidelines. :blush:


No login screen after clicking save button

No screen is shown after save button button is clicked and do i have to store my github username and password in the password file or i can use any set of username and password
Thanks in advance

same as #8?

hi srinivas,
actually as soon as i add a file and set settings in admin tab it ask for the username and password. and  after that i set configuration for plugin so no login screen is shown but logging out and filling the text boxes with github username and password and clicking on github button instead of sign in button takes me to github website so issue solved
Thanks

you will not need to fill Go's username & password field with Github credentials. Clicking on Github button should suffice.

yeah thats too working


[Refactor] Add LogiQA

follows #654
Hi @lintangsutawika. Thanks for bearing with me. Mps was giving me slightly different results from the two branches. Was driving me crazy. Still using the script from master to load the dataset though.
Master:
hf (pretrained=EleutherAI/pythia-160m), limit: None, provide_description: False, num_fewshot: 0, batch_size: 32

Task
Version
Metric
Value

Stderr

logiqa
0
acc
0.1905
±
0.0154

acc_norm
0.2504
±
0.0170

Refactor:
hf (pretrained=EleutherAI/pythia-160m), limit: None, num_fewshot: 0, batch_size: 32

Task
Version
Filter
Metric
Value

Stderr

logiqa
Yaml
none
acc
0.1905
±
0.0154

none
acc_norm
0.2504
±
0.0170

While we’re at it, can you see if you can reproduce the LogiQA results from some other LLM papers? I know that the paper only does finetuned BERT and RoBERTa on unreleased models, but maybe we can replicate the numbers in LLaMA?

Haven't been able to find any LLM results to compare against tbh. Was trying to verify the prompts earlier and couldn't find much. LLaMA didn't evaluate LogiQA from what I can tell.

@baberabb I've added the loading script from master to EleutherAI's huggingface org: EleutherAI/logiqa should now work as a dataset path!
It seems like https://arxiv.org/pdf/2304.03439.pdf evaluates on GPT-4 / ChatGPT and also releases a 2.0 version of the dataset. Their format appears to be similar with the exception of removing "Choices:\n" from the prompt we use, maybe we should switch to that?
Do you have the compute to run this on a couple different models? If not, we can set you up on some GPUs.

@haileyschoelkopf Great! I changed the format as you said! Don't have any compute right now but let me know if you need anything on my end.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 5 committers have signed the CLA.:white_check_mark: haileyschoelkopf:white_check_mark: baberabb:white_check_mark: lintangsutawika:white_check_mark: yeoedward:x: baber abbasibaber abbasi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@baberabb please sign the CLA. It’s a requirement for merging this PR.

@StellaAthena Sorry about this. I've already signed with my github account but this commit was from the terminal and not connected to my email for some reason. I'll create a clean pull once I get the task validation done

@StellaAthena Sorry about this. I've already signed with my github account but this commit was from the terminal and not connected to my email for some reason. I'll create a clean pull once I get the task validation done

follows #654

This PR is a little cursed to be honest.

Understood. Looking ah the commit history, it might be a good idea to create a fresh branch and copy the new files over tbh. I usually find that to be less work than rebasing PRs


Can't compile runtime in MacOS High Sierra

Followed readme instructions to the letter. Linked cmake and llvm-config to /usr/local/bin/.
We want to compile the runtime to then modify with custom features like we did with Android's. But maybe I'm not doing it right... I selected the project "NativeScript" in Xcode.
Fails with this message:
echo "Performing configure step for 'WebKit'"
Performing configure step for 'WebKit'
cd /Users/dev/ios-runtime/cmake-build/WebKit-prefix/src/WebKit-build && /Applications/CMake.app/Contents/bin/cmake --debug=all -DCMAKE_SYSTEM_PROCESSOR=arm "-DCMAKE_XCODE_ATTRIBUTE_SUPPORTED_PLATFORMS=iphoneos iphonesimulator" -DCMAKE_XCODE_EFFECTIVE_PLATFORMS=-iphoneos -iphonesimulator -DPORT=Mac -DENABLE_REMOTE_INSPECTOR=OFF -DENABLE_INTL=OFF -DJSC_OBJC_API_ENABLED=OFF -DUCONFIG_NO_COLLATION=ON -Wno-dev -DCMAKE_C_COMPILER_WORKS=YES -DCMAKE_CXX_COMPILER_WORKS=YES -DHAVE_QOS_CLASSES=ON -DENABLE_WEBCORE=OFF -DENABLE_WEBKIT_LEGACY=OFF -DENABLE_WEBKIT=OFF -DENABLE_STATIC_JSC=1 -DENABLE_JIT=ON -DENABLE_EXCEPTION_SCOPE_VERIFICATION=ON -DUSE_CAPSTONE=ON -DCMAKE_C_COMPILER_ID=AppleClang -DCMAKE_CXX_COMPILER_ID=AppleClang -DCMAKE_C_COMPILER=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -DCMAKE_CXX_COMPILER=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -DCMAKE_CXX_STANDARD_REQUIRED=ON "-DCMAKE_CXX_FLAGS_RELWITHDEBINFO=-O2 -g -DNDEBUG -O3" -GXcode /Users/dev/ios-runtime/src/WebKit
-- The CMake build type is: RelWithDebInfo
CMake Error at Source/cmake/WebKitCompilerFlags.cmake:115 (message):
  Compiler with C++17 support is required
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:57 (include)
  CMakeLists.txt:157 (include)

-- Configuring incomplete, errors occurred!
See also "/Users/dev/ios-runtime/cmake-build/WebKit-prefix/src/WebKit-build/CMakeFiles/CMakeOutput.log".
See also "/Users/dev/ios-runtime/cmake-build/WebKit-prefix/src/WebKit-build/CMakeFiles/CMakeError.log".
make: *** [/Users/dev/ios-runtime/cmake-build/WebKit-prefix/src/WebKit-stamp/Debug-iphoneos/WebKit-configure] Error 1
Command /bin/sh failed with exit code 2

I think that you may have missed this step:
sudo ./src/webkit/Tools/Scripts/configure-xcode-for-ios-development
Can you try repeating it? Also, it may help if you attach the CMakeOutput.log and CMakeError.log files if the issue persists.

I'm sure I did that step but maybe I was missing something at that moment.
I've built an app the usual way (with tns instead of compiling the runtime
myself) and that works. I repeated the steps on the readme for the runtime
and it doesn't. Should I remove the build directory and try again?
Attached are the log files, the ones named webkit are in
cmake-build/WebKit-prefix/src/WebKit-build/CMakeFiles
On Mon, Mar 18, 2019 at 7:47 AM Martin Bektchiev<EMAIL_ADDRESS>wrote:

I think that you may have missed this step
https://github.com/NativeScript/ios-runtime/blob/master/README.md#local-development
:
sudo ./src/webkit/Tools/Scripts/configure-xcode-for-ios-development
Can you try repeating it? Also, it may help if you attach the
CMakeOutput.log and CMakeError.log files if the issue persists.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NativeScript/ios-runtime/issues/1097#issuecomment-473789623,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEzHtye-AHW309m7HiGrkGIiTel9x_wks5vXzZ7gaJpZM4b3lrs
.

I noticed that you are using CMake version 3.13.4, but we currently require version 3.3.2. Can you please switch to it and see how it goes?

iOS Runtime should now build correctly with the latest version of CMake


Prefix pgcrypto hmac function with @extschema@

This PR resolves #6
It sounds like, quoting the Postgres docs:
https://www.postgresql.org/docs/10/extend-extensions.html#EXTEND-EXTENSIONS-RELOCATION

If any prerequisite extensions are listed in requires in the control file, their target schemas are appended to the initial setting of search_path. This allows their objects to be visible to the new extension's script file.

pgcrypto is listed in the control file so it should be available within this extension via<EMAIL_ADDRESS>And indeed, this fixes the issue for me.
Thanks!

Thanks @twopoint718 !


Add real-complex FFT gradients and tests.

This PR adds real-complex FFT gradient back propagation and tests, according to the autograd convention of complex gradients.

@j-towns I removed the np reference anyway. Does this look better?

Added a few more goodies. How does it look now?

Ping. Updates?

Sorry for being slow! This looks great. Thanks very much for the contribution!

Thanks for merging! Feel free to ping me if bugs rise. I tried to cover most cases in the test suite; but I am really more familiar with the 'naive' fft gradients than the 'proper' ones autograd uses.


Rotate schematic

I would like to make a statement about something missing in the program: Option rotaqcionar a schematic. For example the pixel arts, which are perhaps the largest source of search for your program, however the schematic are always in wonderful vertical.a position has a tool to lay it. This could be of great help to the world of builders, using a pixel art of any program to generate a detailed map for example.
I appreciate your generozidade for offering us this wonderful tool called mcedit.

If I understand this correctly you want to rotate a vertical schematic flat, why not use the existing roll function?

I apologize for my English terribly translated. My question was about rotate an object in an angle that I want. For example the tower of Pisa. I tried to do up there in his hand, but was terrible kkkk. Using pixel art and trying to fill to make it cylindrical. Google translate has not helped me as before hahaha

I think there is a filter that can do that, try searching around for it. As far as built in functionality we don't really plan to add something of that sort.

Thank you for your kindness. You were very attentive to me to answer. Thank you.

No problem, going to close the issue now.


Add a note that local is a bash keyword

The example will run from the command line, but not as part of a bash script.  It took me an embarrassing several minutes to figure out why my start script wouldn't run with the cryptic error "docker: invalid reference format," so I thought a one-line note was worth making in the documentation.

Proposed changes

Related issues (optional)

Thank you @crdotson for your contribution. I've approved and merged your PR. Have a great day.


Enhancement - Column to show the Error Failures for failed runs

Currently had to open each flow individually to check for the failures.  Instead can an additional column be shown displaying the "Error Details"

That was on my mind for a while, but I didn't get much love from my side since it requires additional API calls per failed flow to get the details.
It's the best idea to add an option to toggle the error details column if needed and if it's not needed it should stay hidden so the fetch for flow runs executes faster.

Hi @DynamicsNinja
Can we set the Error Detail column display based only on the Status like

'Failed' Status - show the column by default.
All and Others Statuses - we can hide it and we don't have to show the column to avoid additional API Calls.

The toggle for showing the error column can be found in the settings dialog.

Great @DynamicsNinja. Let me review this and let you know! Thank you again.

This is really helpful @DynamicsNinja. Thank you for implementing it.  I had an issue few times primarily when searching for a longer duration for multiple flows and raised a separate ticket.  Thank you.


Merge refs/heads/feature/chunked into alpha

Merge refs/heads/feature/chunked into alpha

This PR has been merged into alpha and tagged as 1.6.0-alpha-202304051416. Thanks for your contribution!


Battery doorbell Camera continues to start live stream

Hi, i have ha 2022.5.4, battery doorbell, ring2mqtt 5.0.1 intalled
i have configured user/pw for livestream and my camera is constantly opening live stream connection, here are the logs.
if i turn switch off, sudenly turns on, but if i send mqtt publish ring/cfa12cc8-09cd-4b6e-90ea-1053516457f6/camera/50f14af94113/stream/state/OFF, the seems to turn off correctly.
2022-05-15T08:31:04.078Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52164] opened
2022-05-15T08:31:04.084Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command started
2022-05-15T08:31:04.095Z ring-rtsp [Puerta principal] Sending command to activate live stream ON-DEMAND
2022-05-15T08:31:04.115Z ring-mqtt [Puerta principal] Received set live stream state ON-DEMAND
2022-05-15T08:31:14.084Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command stopped
2022-05-15T08:31:14.084Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52164] closed (source of path '50f14af94113_live' has timed out)
2022-05-15T08:31:14.085Z ring-rtsp [Puerta principal] Deactivating live stream due to signal from RTSP server (no more active clients or publisher ended stream)
2022-05-15T08:31:14.091Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T08:31:14.092Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
2022-05-15T08:31:19.219Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52250] opened
2022-05-15T08:31:19.224Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command started
2022-05-15T08:31:19.230Z ring-rtsp [Puerta principal] Sending command to activate live stream ON-DEMAND
2022-05-15T08:31:19.241Z ring-mqtt [Puerta principal] Received set live stream state ON-DEMAND
2022-05-15T08:31:29.227Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command stopped
2022-05-15T08:31:29.227Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52250] closed (source of path '50f14af94113_live' has timed out)
2022-05-15T08:31:29.227Z ring-rtsp [Puerta principal] Deactivating live stream due to signal from RTSP server (no more active clients or publisher ended stream)
2022-05-15T08:31:29.235Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T08:31:29.235Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
2022-05-15T08:31:44.381Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52342] opened
2022-05-15T08:31:44.384Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command started
2022-05-15T08:31:44.387Z ring-rtsp [Puerta principal] Sending command to activate live stream ON-DEMAND
2022-05-15T08:31:44.391Z ring-mqtt [Puerta principal] Received set live stream state ON-DEMAND
2022-05-15T08:31:44.743Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T08:31:44.743Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
2022-05-15T08:31:54.387Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command stopped
2022-05-15T08:31:54.388Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52342] closed (source of path '50f14af94113_live' has timed out)
2022-05-15T08:31:54.388Z ring-rtsp [Puerta principal] Deactivating live stream due to signal from RTSP server (no more active clients or publisher ended stream)
2022-05-15T08:31:54.399Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T08:31:54.399Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
2022-05-15T08:32:19.532Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52468] opened
2022-05-15T08:32:19.557Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command started
2022-05-15T08:32:19.563Z ring-rtsp [Puerta principal] Sending command to activate live stream ON-DEMAND
2022-05-15T08:32:19.571Z ring-mqtt [Puerta principal] Received set live stream state ON-DEMAND
2022-05-15T08:32:29.558Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:52468] closed (source of path '50f14af94113_live' has timed out)
2022-05-15T08:32:29.558Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command stopped
2022-05-15T08:32:29.559Z ring-rtsp [Puerta principal] Deactivating live stream due to signal from RTSP server (no more active clients or publisher ended stream)
2022-05-15T08:32:29.567Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T08:32:29.568Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
and this are the logs after sending mqq publish
2022-05-15T11:00:53.957Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T11:00:53.957Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
2022-05-15T11:01:02.271Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T11:01:02.271Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
2022-05-15T11:05:10.176Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:55842] opened
2022-05-15T11:05:10.182Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command started
2022-05-15T11:05:10.184Z ring-rtsp [Puerta principal] Sending command to activate live stream ON-DEMAND
2022-05-15T11:05:10.192Z ring-mqtt [Puerta principal] Received set live stream state ON-DEMAND
2022-05-15T11:05:20.184Z ring-rtsp INF [path 50f14af94113_live] runOnDemand command stopped
2022-05-15T11:05:20.184Z ring-rtsp INF [RTSP] [conn <IP_ADDRESS>:55842] closed (source of path '50f14af94113_live' has timed out)
2022-05-15T11:05:20.185Z ring-rtsp [Puerta principal] Deactivating live stream due to signal from RTSP server (no more active clients or publisher ended stream)
2022-05-15T11:05:20.192Z ring-mqtt [Puerta principal] Received set live stream state OFF
2022-05-15T11:05:20.193Z ring-mqtt [Puerta principal] Stopping live stream session on workerId 1
2022-05-15T11:05:41.075Z ring-mqtt [Puerta principal] Requesting an updated interval snapshot

I don't accept issues on this project, thus I will transfer this issue to ring-mqtt project, please follow there.


Correct >>> DEMO <<< website url

I wanted to open the Demo and it did not work. So I checked the commits and saw the changes from laxxx to lax.
This PR changes back the website linked to https://alexfox.dev/laxxx/ instead of  https://alexfox.dev/lax/.
Or is the new url in progress?

Thanks fixed :)


[Key Request] Table 17 "G/L Entry" - One new key

Currently it is not passible to use a table Extension to create new keys on existing tables. In these special case it is not possible to use a query for substitution of a key.
New Key
Gen. Posting Type,VAT Bus. Posting Group,VAT Prod. Posting Group,Posting Date,G/L Account No.

In general we do not add keys for partner extensions. Please provide justification why do you need this key.

We are going to deliver possibility for partners to add table keys soon. Closing this old request for now.


GitHub Action for auto updating pull requests

Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration tests.
[x] I ensured that the PR title is good enough for the changelog.
[x] I labeled the PR.

Didn't we talk about adopting mergify for that topic?

Didn't we talk about adopting mergify for that topic?

I want to use the built-in merge queues as soon as they are stable. But as a short-term solution, I will just use this.


KAFKA-2837: fix transient failure of kafka.api.ProducerBounceTest > testBrokerFailure

I can reproduced this transient failure, it seldom happen;
code is like below:
// rolling bounce brokers
for (i <- 0 until numServers) {
for (server <- servers) {
server.shutdown()
server.awaitShutdown()
server.startup()
Thread.sleep(2000)
}
  // Make sure the producer do not see any exception
  // in returned metadata due to broker failures
  assertTrue(scheduler.failed == false)

  // Make sure the leader still exists after bouncing brokers
  (0 until numPartitions).foreach(partition => TestUtils.waitUntilLeaderIsElectedOrChanged(zkUtils, topic1, partition))

Brokers keep rolling restart, and producer keep sending messages;
In every loop, it will wait for election of partition leader;
But if the election is slow, more messages will be buffered in RecordAccumulator's BufferPool;
The limit for buffer is set to be 30000;
TimeoutException("Failed to allocate memory within the configured max blocking time") will show up when out of memory;
Since for every restart of the broker, it will sleep for 2000 ms,  so this transient failure seldom happen;
But if I reduce the sleeping period, the bigger chance failure happens;
for example if the broker with role of controller suffered a restart, it will take time to select controller first, then select leader, which will lead to more messges blocked in KafkaProducer:RecordAccumulator:BufferPool;
In this fix, I just enlarge the producer's buffer size to be 1MB;
@guozhangwang , Could you give some comments?

@ZoneMayor Thanks for looking into this. I think this reasoning makes sense.
In the current producer version we have already deprecated METADATA_FETCH_TIMEOUT_CONFIG and BLOCK_ON_BUFFER_FULL_CONFIG, so in order to eliminate this issue instead of just reducing its likelihood we could choose to not set any of these two, and instead set MAX_BLOCK_MS_CONFIG to Long.MAX_VALUE so that the producer will be blocked forever if there is not enough data.

:+1: The reasoning also makes sense to me.

LGTM. Merged to trunk.

@guozhangwang I don't understand the reasoning for setting MAX_BLOCK_MS_CONFIG to Long.MaxValue by default. Doesn't this mean that the test suite could hang instead of failing after a time out in case of bugs? Wouldn't it be better to set a time out that is high enough for our tests, but much lower than Long.MaxValue? Maybe 1 minute or something along those lines?

@ijuma Yeah you are right. Setting it to MaxValue is not a good solution actually. I will submit a follow-up patch shortly.


Adding myself to top level owners

/cc @deepak-vij @shivramsrivastava
/assign @shivramsrivastava

@m1093782566 I hope you don't have any issues with the permissions in the repo?
/assign @deepak-vij

/lgtm

/approve


faster kde predictive sliders

This change makes the option "kde" to be almost as fast as the "hist" option.

Codecov Report

Merging #237 (935110f) into main (33e9a74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   82.82%   82.82%
=======================================
  Files          29       29
  Lines        3673     3674    +1
=======================================
+ Hits         3042     3043    +1
  Misses        631      631

Impacted Files
Coverage Δ

preliz/internal/plot_helper.py
72.63% <100.00%> (+0.08%)
:arrow_up:

preliz/predictive/predictive_sliders.py
90.90% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


AKS Recommendation Updates

Overview/Summary

Added AKS rec 08067d85-962b-4d91-a7ca-c6228e45d5bd about using a Standard LB with the cluster
Added AKS rec 9200aca6-0e83-4749-a5eb-e3939367bdc2 about deploying at least 2 replicas of your app
Added AKS rec f46b0d1d-56ef-4795-b98a-f6ee00cb341a about using Azure Linux instead of other Linux distributions
Removed AKS rec about planning a version upgrade at PG's request because they stated it does not contribute to resiliency.

Related Issues/Work Items
Breaking Changes
As part of this pull request I have

[x] Read the Contribution Guide and ensured this PR is compliant with the guide
[x] Checked for duplicate Pull Requests
[x] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Ensured PR tests are passing
[x] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
[x] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ejhenry I included it here because the LB SKU is specified at creation time of the cluster and if they're not using Standard, it would require a change to their AKS deployment

@ejhenry I included it here because the LB SKU is specified at creation time of the cluster and if they're not using Standard, it would require a change to their AKS deployment

Thanks @ibersanoMS. We'd like to avoid making the same recommendation more than once on a particular resource. Totally get that there would be different remediation guidance for AKS, but still sounds like it's the same recommendation as the existing LB recommendation. Please ping me if I've misunderstood.

@ejhenry I see what you're saying - I went ahead and removed it.


Polaris scripting

@PrasanthCSW  There are a some issues with this pull request.  Specifically the README.md.
Please resolve and resubmit


dns/ddclinet: Cron action for forced update

Some providers like No-IP need an update every 7 days.
This is necessary even if the IP does not change.

Does the Rc.d script really support the odd Linux style “-force” parameter or did you mean to start ddclient itself with it?

Does the Rc.d script really support the odd Linux style “-force” parameter or did you mean to start ddclient itself with it?

Does the Rc.d script really support the odd Linux style “-force” parameter or did you mean to start ddclient itself with it?

Thanks for the hint. I wanted to start ddclient itself.


Changing front end such logo

is there a way to change the front end design, add or remove element, ?

I'm afraid not :) Wink is an SPA, making it customizable would be a tough one.


Update test suite to use default loop

Builds on top of #182 and https://github.com/reactphp/socket/pull/283

Unrelated test failure for macOS is addressed in #205 :shipit:

Rebased to fix unrelated build error now that #205 has been merged :shipit:


onActiveSpeaker is not called for local user (uid 0)

As mentioned in the docs https://docs.agora.io/en/Voice/API Reference/cpp/classagora_1_1rtc_1_1_i_rtc_engine_event_handler.html#ae643c9dbf94360a23a8b3a56c93f90bc
The onActiveSpeaker has to be called with uid 0 if local user is actively speaking.
It is called if remote users are active but not for the local user.

could you pls put a log print in the callback and share the logs for certain amount of time?

No callback when current user is actively speaking

will be fixed in native SDK version 3.2.0

Just a note: This issue still exists on 3.1.3v

Looks like there's change in the docs. It does not mention about the local speaker

As per the docs This issue can be closed.
onAudioVolumeIndication
Reports which users are speaking and the speakers' volume, and whether the local user is speaking.
onActiveSpeaker
After a successful call of enableAudioVolumeIndication, the SDK continuously determines which remote user has the loudest volume. The remote user determined to be the loudest and most continuous speaker is considered the most active user.

If you still face issues, please try upgrading to the new version to see if it works for you.


Struct methods cause schema generation to fail

Issue Description
Gin handlers that are struct methods cause schema generation to fail.
Steps to Reproduce

Create a main.go with this content:

package main

import (
	"database/sql"

	"github.com/gin-gonic/gin"
	"github.com/ls6-events/astra"
	"github.com/ls6-events/astra/inputs"
	"github.com/ls6-events/astra/outputs"
)

type SharedData struct {
	db *sql.DB
}

func (sd SharedData) GetDatabaseConnectionStats(c *gin.Context) {
	c.JSON(200, sd.db.Stats())
}

func main() {
	r := gin.Default()

	db := InitDB()
	defer db.Close()

	sd := SharedData{db: db}

	r.GET("/stats", sd.GetDatabaseConnectionStats)

	gen := astra.New(inputs.WithGinInput(r), outputs.WithOpenAPIOutput("openapi.generated.yaml"))

	config := astra.Config{
		Title:   "Example API",
		Version: "1.0.0",
		Host:    "localhost",
		Port:    8080,
	}

	gen.SetConfig(&config)

	err := gen.Parse()
	if err != nil {
		panic(err)
	}

	r.Run(":8080")
}

Install dependencies: go get .
Run main.go: go run main.go

Expected Behaviour
Bellow is the expected output in openapi.generated.yaml from running main.go.
openapi: 3.0.0
info:
    title: Example API
    description: Generated by astra
    contact: {}
    license:
        name: ""
    version: 1.0.0
servers:
    - url: http://localhost:8080
paths:
    /stats:
        get:
            operationId: getDatabaseConnectionStats
            responses:
                "200":
                    description: ""
                    content:
                        application/json:
                            schema:
                                $ref: '#/components/schemas/sql.DBStats'
components:
    schemas:
        sql.DBStats:
            type: object
            properties:
                Idle:
                    type: integer
                    format: int32
                InUse:
                    type: integer
                    format: int32
                MaxIdleClosed:
                    type: integer
                    format: int64
                MaxIdleTimeClosed:
                    type: integer
                    format: int64
                MaxLifetimeClosed:
                    type: integer
                    format: int64
                MaxOpenConnections:
                    type: integer
                    format: int32
                OpenConnections:
                    type: integer
                    format: int32
                WaitCount:
                    type: integer
                    format: int64
                WaitDuration:
                    $ref: '#/components/schemas/time.Duration'
            description: DBStats contains database statistics.
        time.Duration:
            enum:
                - 1
            type: integer
            format: int32
            description: |-
                A Duration represents the elapsed time between two instants
                as an int64 nanosecond count. The representation limits the
                largest representable duration to approximately 290 years.

Actual Behaviour
No schema is generated and the bellow error is output in the logs:
Rel: can't make <autogenerated> relative to <path to backend>
Additional Information

Go Version: 1.21.1
Astra Version: 1.19.0

Iv'e done a little bit of looking into this and it seems to be a bug with runtime.FuncForPc().
NB: this is base on a little bit of scrolling through Github issues so I might have a few things wrong here but this is the issue as I understand it.
When passing around a struct method under the hood the go compiler wraps it in a closure and that is what actually gets passed. The auto generated closure has a synthetic file and line metadata so what is being returned by runtime.FuncForPC() is actually correct for the input it is given, its just not what we actually want.
Interestingly this actually used to work in <= 1.17.x
Take the following example
package main

import (
	"fmt"
	"reflect"
	"runtime"

	"github.com/davecgh/go-spew/spew"
)

type MyStruct struct{}

func (MyStruct) ValueRecv() {}

func (*MyStruct) PtrRecv() {}

func MyFunc() {}

func main() {
	val := MyStruct{}

	inspect(val.ValueRecv)
	inspect((&val).PtrRecv)
	inspect(MyFunc)
	inspect(MyStruct.ValueRecv)
	inspect((*MyStruct).ValueRecv)
}

func inspect(v interface{}) {
	pc := reflect.ValueOf(v).Pointer()
	spew.Dump(runtime.FuncForPC(pc).FileLine(pc))
	spew.Dump(runtime.FuncForPC(pc).Name())
	fmt.Println("-----")
}

when ran in 1.22.2:
:!go run /home/indeedhat/Documents/github/fuckery/funcforpc/main.go
(string) (len=15) "<autogenerated>"
(int) 1
(string) (len=26) "main.MyStruct.ValueRecv-fm"
-----
(string) (len=15) "<autogenerated>"
(int) 1
(string) (len=27) "main.(*MyStruct).PtrRecv-fm"
-----
(string) (len=58) "/home/indeedhat/Documents/github/fuckery/funcforpc/main.go"
(int) 17
(string) (len=11) "main.MyFunc"
-----
(string) (len=58) "/home/indeedhat/Documents/github/fuckery/funcforpc/main.go"
(int) 13
(string) (len=23) "main.MyStruct.ValueRecv"
-----
(string) (len=15) "<autogenerated>"
(int) 1
(string) (len=26) "main.(*MyStruct).ValueRecv"
-----

and 1.17.13
:!go1.17.13 run /home/indeedhat/Documents/github/fuckery/funcforpc/main.go
(string) (len=58) "/home/indeedhat/Documents/github/fuckery/funcforpc/main.go"
(int) 13
(string) (len=26) "main.MyStruct.ValueRecv-fm"
-----
(string) (len=58) "/home/indeedhat/Documents/github/fuckery/funcforpc/main.go"
(int) 15
(string) (len=27) "main.(*MyStruct).PtrRecv-fm"
-----
(string) (len=58) "/home/indeedhat/Documents/github/fuckery/funcforpc/main.go"
(int) 17
(string) (len=11) "main.MyFunc"
-----
(string) (len=58) "/home/indeedhat/Documents/github/fuckery/funcforpc/main.go"
(int) 13
(string) (len=23) "main.MyStruct.ValueRecv"
-----
(string) (len=15) "<autogenerated>"
(int) 1
(string) (len=26) "main.(*MyStruct).ValueRecv"
-----

There are a number of issues open and closed around this and related topics such as the -fm name suffix but I'm not hopeful for a fix any time soon.
My current rabbit hole is trying to find out if I can use the name to get a reference back to the parent type but I'm not hopeful at this point.

@indeedhat Thank you very much for looking into this issues, we've come to a similar conclusion (probably should have documented that, sorry). We're looking at moving away from using gin.Engine and using the AST to transfer the whole code and pull out the definitions from that. This change is going to be a hell of a lot of work but should give us lots of benefits especially allowing us to create at standalone CLI instead of having to embed the tool at runtime.


Add dynamic-parsers package

#294  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on  Graphite


Remap?

Looks like current voidTrader is remapped when it's requested.... i think we should either:

request a remap to this format on worldstate-parser
keep the same original data mapping as the api

current remapping:
{
  id: trader.id,
  from: new Date(trader.activation),
  until: new Date(trader.expiry),
  name: trader.character,
  relay: trader.location,
  goodies: trader.inventory,
  active: trader.active,
  fromString: `${name} arrives in ${trader.startString}`,
  untilString: `${name} leaves in ${trader.endString}`,
}

Change it to the mapping from the API is what I'd go with now, I'll have to take a look at current usages though, maybe keep from and until plus activation and expiry

Okiedoke. I've started on that in my branch as well as simplifying the calling structure so you don't have quite so much boilerplate


Fix TLS variable initialization.

Make sure the TLS variables are properly created in all threads, so no special logic is needed to support them not to be defined later in the code.

[Current coverage][cc-pull] is 31.72%

Merging [#1897][cc-pull] into [master][cc-base-branch] will decrease coverage by 55.77%

@@             master      #1897   diff @@
==========================================
  Files           293        293
  Lines         52495      52497       +2
  Methods           0          0
  Messages          0          0
  Branches       5431       5431
==========================================
- Hits          45924      16650   -29274
- Misses         5646      35211   +29565
+ Partials        925        636     -289

16 files (not in diff) in numba/typing were modified. more

Misses +1372
Partials -136
Hits -1236

8 files (not in diff) in numba/types were modified. more

Misses +495
Partials -6
Hits -489

8 files (not in diff) in numba/tests/npyufunc were modified. more

Misses +442
Hits -442

126 files (not in diff) in numba/tests were modified. more

Misses +15329
Partials -123
Hits -15206

3 files (not in diff) in numba/testing were modified. more

Misses +26
Partials -1
Hits -25

31 files (not in diff) in numba/targets were modified. more

Misses +6785
Partials -46
Hits -6739

4 files (not in diff) in numba/rewrites were modified. more

Misses +52
Partials +1
Hits -53

5 files (not in diff) in numba/pycc were modified. more

Misses +269
Partials -12
Hits -257

8 files (not in diff) in numba/npyufunc were modified. more

Misses +756
Partials -10
Hits -746

3 files (not in diff) in numba/jitclass were modified. more

Misses +274
Partials -8
Hits -266

Powered by Codecov. Last updated by [1f4c5b9...b0354eb][cc-compare]
[cc-base-branch]: https://codecov.io/gh/numba/numba/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/numba/numba/compare/1f4c5b90d83d65a244c7e7cece51784d049afdd0...b0354eb29546a78ef70e61c0b5f756cde0fb9022
[cc-pull]: https://codecov.io/gh/numba/numba/pull/1897?src=pr


Disable default cookie store in async-http-client backends

See https://gitter.im/softwaremill/sttp?at=5e5ac6fdec7f8746aaa54037

Released in 2.0.2


Exposing this for external services to use?

I am trying to expose it for external services to connect the replicated cluster, how do I make it via LoadBalancer?

I have the same question. Any solutions?

Yes, I was able to expose one service but I didn't use shards or anything, just a plain mongodb instance. I am still going to make more experiments on the matter so I can test it

@pvsousalima that is cool. I am trying to expose it via LoadBalancer. I am not sure how to manage the secondary instances. Do I need to create services for all of them and manually choose the connection. Or something else.

I had the same problem today when a developer needed to debug a problem in it but didn't have access to the cluster. For the life of me I couldn't find a way to expose the statefulset externally as apparently it's by design that a headless service won't be reacheable from outside the cluster. For a ad-hoc one-off debug session maybe exposing a single mongodb-0 pod (the primary, if possible) does the trick, but for more complex debugging/issues having a way to reach the main service IP of the statefulset and all its replicas would be ideal, so we could use the whole dynamics of master and slaves & data replication from outside the cluster.


only put the answers inside btn

Already fixed in  https://github.com/nicholaschris/browser-quiz-project-starter/pull/21


Update workflow permissions to fix deploy error

Description
Fixes an error with completing the deploy book jobs which I believe deal with permissions. It's a bit strange as this error doesn't always surface in other areas I've used the action. Just the same, the docs recommend updating to this option (or others) (under "warning").
What is the nature of your change?

[ ] Content additions or updates (adds or updates content)
[x] Bug fix (fixes an issue).
[ ] Enhancement (adds functionality).
[ ] Breaking change (these changes would cause existing functionality to not work as expected).

Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.

[x] I have read the CONTRIBUTING.md guidelines.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own contributions.
[ ] I have commented my content, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to related documentation (outside of book content).
[x] My changes generate no new warnings.
[x] New and existing tests pass locally with my changes.
[ ] I have added tests that prove my additions are effective or that my feature works.
[x] I have deleted all non-relevant text in this pull request template.

Thanks @vincerubinetti - the settings change is a better one! After making that change and re-running the job, it succeeded. I'm going to close without merge here as a result.


flutter build hangs if there are named pipes below the project directory

Try running:
flutter create named_pipes
cd named_pipes
mkfifo evil
flutter build --verbose ios

You will notice it hangs on:
[  +15 ms] Podfile not found, skipping global platform iOS version migration.
[   +4 ms] executing: xattr -r -d com.apple.FinderInfo .../named_pipes

Is there any good reason for calling xattr on everything below the project root?

Sorry, wrong repo. Opened https://github.com/flutter/flutter/issues/146569 instead.


Search channels page by full address, including '0x'

Description

Make it so that when querying in the channels page by address, that you can input '0xabcdef...' values including hex prefix. Now developers have to manually copy without 0x

Reasoning

Small change which drastically improves UX. All explorers allow to copy 0x addresses

Acceptance Criteria

Ensure the search filter supports both addresses with or without the '0x' prefix

Fixed in new explorer


Revert L2 fwd table action name

Reverting a table action name that was changed for debug purposes during LNWv3 development, since it was never reverted back
See #84

Comment of interest. Have verified with @n-sandeep  that this is incorrect to change name (although this particular flow is not used and should not result in bugs)


As an application developer I would like to the option to recursively delete an application,

At the moment fn delete app <app-name> deletes an app and all of it's routes/functions/triggers.  This behaviour is a bit brutal and should instead be optional, and by default shouldn't be allowed. So instead, attempting to delete an app with any child elements by fn delete app foo would simply respond with You cannot delete an application that contains functions or triggers.
fn delete app can then be extended to support two additional options:

--cascade that will delete all child elements in bottom-up order, with an initial Application "foo" contains 3 functions and 5 triggers, are you sure you want to delete it? message and confirmation.

--dry-run - this will output a list of elements that would be deleted if fn delete app foo --cascade were executed.

This would also depend on the /apps DELETE API being changed to only delete an application if it were empty. The CLI would instead recursively call DELETE on each /trigger, /function and /app endpoint.

Perhaps the more conventional --dry-run might be more suitable than --impact?

Id also say use cascade not recursive...

Updated above to reflect entirely-reasonable comments...

Is it difficult for the server to check whether an app has any associated functions or triggers? (i.e. whether it is or isn't empty).

I think we shouldn't do any cascading deletes server-side or API-side. Instead, we could have sugar in the CLI to retrieve all resources associated with a function, recursively deleting them via their APIs prior to deleting the app. This would also be the most portable across CLI providers, since not all implementations will be able to support cascading deletes server-side.

@gviedma i think that is what's being proposed.
"The CLI would instead recursively call DELETE on each /trigger, /function and /app endpoint."

We don't need this now - super low priority!


Training Atari games with VPG

We currently train Atari models with DQN + DDQN. VPG (Vanilla Policy Gradient) have shown to be a better structured agent (as tested on Control problems / Health gathering in Doom).
Generate model + hyper params which can solve Breakout Atari retro game

Being addressed here https://github.com/moabitcoin/cherry-pytorch/pull/40


Make the context menu smaller

The context menu looks way too tall to be used on a desktop PC. You should definitely make it less tall.

I use the following to make the context menu smaller, you could probably adjust it to your liking:
/* Smaller context popup */
menupopup menuitem,
menupopup menu,
.autocomplete-richlistitem
{
	height: inherit !important;
	padding: 4px 16px !important;
	border: 0 !important;
	background: 0 !important;
	color: inherit !important;
	fill-opacity: initial !important;
}


[CI] Change branch workflows so that they are triggered only upon request or scheduled

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
We have many active branches and many commits are pushed to these branches. master branch gets commits by merging PRs and in most cases, commits are pushed by cherry-picking commits from master branch to maintenance branches (branch-2.11, branch-2.10, branch-2.9, branch-2.8 and branch-2.7).
In most cases, nobody pays attention to the results of individual builds for commits pushed to maintenance branches.
Therefore, it would be a way to save CI resources if CI builds are only available upon request or in a scheduled manner.
Solution
GitHub Actions has a feature for manually triggering the workflow. Documentation:
https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#defining-inputs-for-manually-triggered-workflows
workflow_dispatch is the event type. Docs for workflow_dispatch
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch
The GitHub UI lets the user choose the branch. The minimum way to add support for manual triggering is adding on: workflow_dispatch to the workflow.
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

In addition, master could have a scheduled workflow to run in the similar way as the existing "CI - Maven Dependency Cache Update" workflow. That workflow after having a scheduled workflow for master branch.

We can set the manual trigger for branch-2.11. For branch-2.10 and previous, the workflow Pulsar CI doesn't exist. A good solution would be to:

Remove the post-commit trigger for all the jobs in branch-2.10 (and prev) branches. When the release manager needs to validate the branch, it has to open a pull. It's not very common that we open pulls against release branches so it will reduce the CI loads a lot.
For branch-2.11 (and future release branches) we can do the same and additionally add the workflow_dispatch trigger.

@nicoloboschi makes sense. triggering 25+ workflows in branch-2.10 (and before) in the UI wouldn't be very usable.


🚀 Feature: S3 file storage

🔖 Feature description
I would like it you could use cheap S3 object storage.
🎤 Pitch
Backblaze offers cheap file storage, it would help with the cost of running a vps dye to the storage needed

Alreadyfixed

So should I close the issue?


Tests without description not found

I have some tests that do not have a description a very simple example to recreate below, these are not found in the buffer or the summary. I'm using LazyVim not sure if I've missed something in the configuration.
describe 'Test' do
  it do
    expect(true).to be(true)
  end
end

I started looking into tree-sitter recently, would adding the following query add what required?
((call
  method: (identifier) @func_name (#eq? @func_name "it")
  block: (do_block (_) @test.name)
)) @test.definition

I'd recommend using Treesitter Playground to test any queries out and then running make test to see if the tests pass.

Thanks, I  used https://github.com/nvim-treesitter/playground to test the query


[core]Line number rendering problem

When changing the line number display style or scrolling code, the line number display has problems, the background color and UI display are confused, and there is no problem in SmalI mode.like this. #404 ,I use the latest version of exe will still have this problem.

Thanks.

The code style looks like Jadx "dark mode" as editor theme. What OS and Java runtime version + vendor do you use?

The code style looks like Jadx "dark mode" as editor theme. What OS and Java runtime version + vendor do you use?

Yes, I used "dark mode", And I still have problems using the "default mode", OS is Windows 10 HOME 20H2, Java version is java 11.0.10 2021-01-19 LTS, Oracle Corporation.

Interesting, I have the identical environment with the only difference that I am using AdoptOpenJDK 11 instead of Oracle and I can not reproduce your issue using latest unstable and stable Jadx version.

I met an even worse problem with line number rendering

I'm using Microsoft build openJDK 16 on Windows 10 19043
openjdk 16.0.1 2021-04-20
OpenJDK Runtime Environment Microsoft-22300 (build 16.0.1+9)
OpenJDK 64-Bit Server VM Microsoft-22300 (build 16.0.1+9, mixed mode, sharing)

@FantasqueX can you check latest unstable build? I made a few fixes in 4732fa36a602d064ac3f543f2fd09aee43450c25.

@FantasqueX can you check latest unstable build? I made a few fixes in 4732fa3.

I checked the latest build just now. The problem has been fixed on my PC. Thank you for your work!

The problem has been fixed on my PC

Great! Thanks for confirm!
I will close issue as fixed.


Feature Request: use tags in docker hub for versioning

Other Stellar Docker images, such as stellar/stellar-core and stellar/horizon have recent tagged versions, where as stellar/quickstart hasnt had a version tag, besides latest and testing for several years.
What problem does your feature solve?
I'm working for a Blockchain infrastructure and we, as feature, users get transparency and choice of which version the want to use. This information is based on the docker image.
What would you like to see?
Similar tagging to what used to happen, for this project.
What alternatives are there?
The alternative would be that we build our own Docker image, and maintain it.  However this quick start is really good. A lot of the 'heavy lifting' is already done. It would be good to keep using this.

Others are requesting the same - https://github.com/stellar/docker-stellar-core-horizon/issues/105


.pyquil_config setup command

This PR includes a script which facilitates the setup of .pyquil_config. The README includes a command for running this script, which is now provided as a command line tool.

@jotterbach

@jotterbach back to you!


Added yml file for the cicd pipeline

Build and test frontend
Build and test backend
Frontend tests are commented for now, uncomment when there are tests that are pushed for frontend

Looks good


Update urlchecks.yml

Looks good!

Now we need to address the regex issue, hopefully @SuperKogito will  have some time soon!

I'll merge this as is but will definitely update my workflow with the regex stuff! Thanks both!


Update usage.rst

This comment have bad recommendation:
m_url = settings.MEDIA_URL       # Typically /static/media/
In settings.py:
MEDIA_URL = "/static/media/"
Because django cant serve media inside static, the recommendation need to be:
m_url = settings.MEDIA_URL       # Typically /media/
In settings.py:
MEDIA_URL = "/media/"

Coverage decreased (-0.5%) to 53.614% when pulling 3f8d1fbbc12250490c3ee749bac2a1fad426804b on devalvarado200:patch-1 into 3f5af31a630eecfc0ffd020f76b99486c35eac97 on xhtml2pdf:master.

Coverage decreased (-0.5%) to 53.614% when pulling 3f8d1fbbc12250490c3ee749bac2a1fad426804b on devalvarado200:patch-1 into 3f5af31a630eecfc0ffd020f76b99486c35eac97 on xhtml2pdf:master.

Include in other commit :)


Add support for Ollama, Palm, Claude-2, Cohere, Replicate, Llama2 CodeLlama (100+LLMs) [LiteLLM]

This PR adds support for the above mentioned LLMs using LiteLLM https://github.com/BerriAI/litellm/
LiteLLM is a lightweight package to simplify LLM API calls - use any llm as a drop in replacement for gpt-3.5-turbo.
Example
from litellm import completion

## set ENV variables
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["COHERE_API_KEY"] = "cohere key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# cohere call
response = completion(model="command-nightly", messages)

# anthropic call
response = completion(model="claude-instant-1", messages=messages)

@loubnabnl @Muennighoff @infinitylogesh
can you take a look at this PR when possible ?
I believe LiteLLM makes it easier to benchmark LLMs - would love your feedback if not

Thanks for the PR, what do you think @Muennighoff ?

@Muennighoff @loubnabnl updated based on feedback - thanks