[Awaiting Payment Sept 15th][$125] Room-mWeb-Inconsistency in Character allowed to create room from fab & via mentions

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.25
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4896867
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap fab - start chat -- room
Paste the room name -<PHONE_NUMBER>65544445665555444555455555555555555555555555555552357777dfghgggggggg5muuuddu
Create a room
Via mentions create another room with same number of characters -<PHONE_NUMBER>65544445665555444555455555555555555555555555555552357777dfghgggggggg6muuuddp
Note user not shown whisper to create room with all characters entered

Expected Result:
There must be consistency in Character allowed to create room from fab & via mentions.
Actual Result:
Inconsistency in Character allowed to create room from fab & via mentions.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/8cf9e4c0-a756-4907-907f-0ffcde81a30f

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018f61735c851b2aec
Upwork Job ID:<PHONE_NUMBER>350296440
Last Price Increase: 2024-08-29
Automatic offers:

alitoshmatov | Reviewer | 103992433
NJ-2020 | Contributor | 103992435

Issue OwnerCurrent Issue Owner: @trjExpensify

@trjExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Room-mWeb-Inconsistency in Character allowed to create room from fab & via mentions
What is the root cause of that problem?
Inside the expensify-common, we limit up to 80 characters only
https://github.com/Expensify/expensify-common/blob/331f53580a4ddd7f1c8e73c7c1494d0bb22962c7/lib/ExpensiMark.ts#L298-L303
{
    name: 'reportMentions',
    regex: /(?<![^ \n*~_])(#[\p{Ll}0-9-]{1,80})(?![^<]*(?:<\/pre>|<\/code>|<\/a>))/gimu,
    replacement: '<mention-report>$1</mention-report>',
},

But here in our case we mention the room name more than 80 characters, which 87 in our case
What changes do you think we should make in order to solve the problem?
We can change the limit to 100 or 90, so it will be:
{
    name: 'reportMentions',
    regex: /(?<![^ \n*~_])(#[\p{Ll}0-9-]{1,100})(?![^<]*(?:<\/pre>|<\/code>|<\/a>))/gimu,
    replacement: '<mention-report>$1</mention-report>',
},

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Room-mWeb-Inconsistency in Character allowed to create room from fab & via mentions
What is the root cause of that problem?
We are allowing only 80 characters when we parse reportMenions in common But the room name character limit we are using in FE is 90 here
https://github.com/Expensify/App/blob/ac5ee2ef790231c67ca3ddb14dc481d77da5bcea/src/CONST.ts#L917
What changes do you think we should make in order to solve the problem?

We need to be consistent and pick a max limit value and ensure that same value is used in both places
What alternative solutions did you explore? (Optional)

I agree we should be consistent here, but this is a quick fix, so I'm dropping the price.

Proposal updated

Added a minor explanation about the react-native-live-markdown,

Seems very straightforward task and all proposals are suggesting the same solution.
I think we can go with @NJ-2020 's proposal. Even without edits his original proposal suggested to update mention name length
C+ reviewed 🎀 👀 🎀

@alitoshmatov PR ready for review

Payment summary as follows:

$125 to @NJ-2020 for the fix
$75 to @alitoshmatov for the C+ review of the proposal

Doesn't look like @alitoshmatov actually reviewed the PR here, so I reduced partial payment of $75 for the proposal review only.
Let me know if that's correct, and I'll issue payments after the regression period.

Melv, go away. @alitoshmatov @NJ-2020, we might need a version bump of expensify-common here actually?

@trjExpensify Yes we need to bump the expensify-common to the latest version

Cool, and will you raise a PR for that?

@trjExpensify PR ready
Just to confirm that we only need to update the expensify-common version to the latest version inside react-native-live-markdown only?

I'll defer to @alitoshmatov on that. 👍

@trjExpensify Everything looks good for me

Great, so we should be good here when payment is due.

Okay, offers have been sent. Please accept, and I'll modify accordingly to match this payment summary and close it out.

Settled up, closing!


logrus -> klog

Signed-off-by: Parul<EMAIL_ADDRESS>
Which issue(s) this PR addresses:

Closes https://github.com/redhat-et/microshift/issues/134

@rootfs @oglok @fzdarsky what's your opinion on moving all those Warningf(+error) to ErrorS right away? all those seem like Errors in the end to me.
I guess they removed WarningS from klog because  it's hard to decide when something is just a warning or an error and we end up using warnings for errors in many cases.

@rootfs @oglok @fzdarsky what's your opinion on moving all those Warningf(+error) to ErrorS right away? all those seem like Errors in the end to me.

I'd suggest following the logging conventions and, yes, replace Warningf() with InfoS(), ideally being specific on the v-level (i.e. use klog.V(x).InfoS() instead).
Totally fine with using structured logging. Guess that includes replacing formatting strings everywhere? If so, I assume you'd supply the returned err as parameter after the error message, or?

@rootfs @oglok @fzdarsky what's your opinion on moving all those Warningf(+error) to ErrorS right away? all those seem like Errors in the end to me.

I'd suggest following the logging conventions and, yes, replace Warningf() with InfoS(), ideally being specific on the v-level (i.e. use klog.V(x).InfoS() instead).
Totally fine with using structured logging. Guess that includes replacing formatting strings everywhere? If so, I assume you'd supply the returned err as parameter after the error message, or?

One of my points, is that we are using Warningf as "errors" in our case, so they belong more to the case of .ErrorS
Specially since we end up passing "err", err  as part of the InfoS,  while ErrorS just accepts "err" as the first parameter.
Anyway, I'm probably splitting threads.

@rootfs @oglok @fzdarsky what's your opinion on moving all those Warningf(+error) to ErrorS right away? all those seem like Errors in the end to me.

I'd suggest following the logging conventions and, yes, replace Warningf() with InfoS(), ideally being specific on the v-level (i.e. use klog.V(x).InfoS() instead).
Totally fine with using structured logging. Guess that includes replacing formatting strings everywhere? If so, I assume you'd supply the returned err as parameter after the error message, or?

One of my points, is that we are using Warningf as "errors" in our case, so they belong more to the case of .ErrorS
Specially since we end up passing "err", err as part of the InfoS, while ErrorS just accepts "err" as the first parameter.
Anyway, I'm probably splitting threads.

Also for that part (turning those warnings into Errors - I believe most of them are errors (warning to me is a transient recoverable error)) it would deserve a different PR if we get agreement. :-)

/retest

/retest

/retest

let me try to launch and test locally.

/retest

/test test-srpm

/test e2e-rpm-install

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/lgtm


Iframe chached Url

Using iziModal's iframe feature keeps using cached URL, not new URL.
I'm having a problem with regards to the iframe feature.
On first load of the page the iframe option works without any problems.
On my page I have a dynamic URL generated based on button click. My problem is, after the first click and successful open of iziModal for that URL, any further button clicks do not update iziModal iframeURL to the new URL, but still uses the old (seemingly cached) URL! How do I stop this?
Asp.NET

Any update on this issue???

Found a workaround:
https://stackoverflow.com/questions/43336583/using-izimodals-iframe-feature-keeps-using-cached-url-not-new-url
But this is unexpected behavior. Grateful if this could be fixed.


fix: handle name conflict in docker network creation

What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Error is not handler and get's lost
What is the new behavior?
propagate error unless is "network already exists" as it is ok to handle internally and continue without giving an error the the use

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.008%) to 40.595%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/start/start.go
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.008%

Covered Lines:
2048

Relevant Lines:
5045

💛  - Coveralls


[e2e]: go schedule main config-noldflags slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2793926776
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.config-noldflags.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Aug  4 03:25:14 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2801107899
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.config-noldflags.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Aug  5 03:44:16 UTC 2022
Tests are passing now. Closing this issue.


React.NET not working on ASP.NET 5 and MVC 6

I have followed tutorial on http://reactjs.net/getting-started/aspnet5.html
to use React with ASP.NET 5.
I cannot make it work. (I have used Reactjs.NET on ASP.NET MVC 5 successfully)
I am just getting blank page. (no info in console) and don't have react tab in chrome develop tools.
Can you please upload a simple project (hello world) where you have managed to run it in ASP.NET 5 so I can try to implement it myself?

Do you see any errors in the Visual Studio output window?
There's a sample project in the React.Sample.Mvc6 project in the
repository. Clone the project, run dev-build.bat, then you can open the
solution in Visual Studio.
Sent from my mobile.
On Mar 11, 2015 6:18 AM, "Radenko Zec"<EMAIL_ADDRESS>wrote:

I have followed tutorial on
http://reactjs.net/getting-started/aspnet5.html
to use React with ASP.NET 5.
I cannot make it work. (I have used Reactjs.NET on ASP.NET MVC 5
successfully)
I am just getting blank page. (no info in console) and don't have react
tab in chrome develop tools.
Can you please upload a simple project (hello world) where you have
managed to run it in ASP.NET 5 so I can try to implement it myself?
--
Reply to this email directly or view it on GitHub
https://github.com/reactjs/React.NET/issues/101.

There is no errors in the Visual Studio output window.
I will try figure out what's wrong from your project.
Thanks for help.
I will post update soon.
On Wed, 11 Mar 2015 at 16:22 Daniel Lo Nigro<EMAIL_ADDRESS>wrote:

Do you see any errors in the Visual Studio output window?
There's a sample project in the React.Sample.Mvc6 project in the
repository. Clone the project, run dev-build.bat, then you can open the
solution in Visual Studio.
Sent from my mobile.
On Mar 11, 2015 6:18 AM, "Radenko Zec"<EMAIL_ADDRESS>wrote:

I have followed tutorial on
http://reactjs.net/getting-started/aspnet5.html
to use React with ASP.NET 5.
I cannot make it work. (I have used Reactjs.NET on ASP.NET MVC 5
successfully)
I am just getting blank page. (no info in console) and don't have react
tab in chrome develop tools.
Can you please upload a simple project (hello world) where you have
managed to run it in ASP.NET 5 so I can try to implement it myself?
--
Reply to this email directly or view it on GitHub
https://github.com/reactjs/React.NET/issues/101.

—
Reply to this email directly or view it on GitHub
https://github.com/reactjs/React.NET/issues/101#issuecomment-78284768.

I have succeeded to run your example by extracting project from solution and manually fixing issues.
It would be nice if you can reference React.js from Bower instead of fb for next versions. (some of us have problems with referencing fb because of company policies for social networks)
Also I am hoping that you will enable support for aspnetcore50 soon. Without .NET Core your implementation for ASP.NET 5 is not complete because we will be stuck with Windows and Full Framework.

Did you figure out what the issue with your project was?

It would be nice if you can reference React.js from Bower instead of fb for next versions

This already works for client-side code, just include your own version of React rather than using it from the CDN.

Also I am hoping that you will enable support for aspnetcore50 soon. Without .NET Core your implementation for ASP.NET 5 is not complete because we will be stuck with Windows and Full Framework.

This is blocked on the dependencies (ClearScript and JavaScriptEngineSwitcher) supporting ASP.NET 5 Core. .NET Core isn't functional on Linux or Mac OS X yet, and ASP.NET 5 still runs on those platforms via Mono even without Core.

Hm That is a great. I got the impression that ASP.NET projects will not work on Linux or MacOS without .NET Core.
Thanks for clarification.

I recently built a hello world app with the Yeoman generator (to scaffold it) and Sublime Text. It worked! :) http://blogs.msdn.com/b/webdev/archive/2014/08/12/develop-asp-net-vnext-applications-on-a-mac.aspx

Great.
I am glad you have already test it .
I haven't got time to test it on Mac yet.

I looked at explanation here:
http://www.asp.net/vnext/overview/aspnet-vnext/aspnet-5-overview
It seams that Cross-Platform CLR is not yet released.
So KRE CLR is actually Full CLR which is not working on Linux?

Actually you are correct: http://blogs.msdn.com/b/cesardelatorre/archive/2014/11/18/what-is-net-core-5-and-asp-net-5-within-net-2015-preview.aspx
Here is stated: This is today (running ASP.NET 5 on top of Mono), but Microsoft is also going to release an official distribution of the .NET Core for Linux, as well as an official distribution of .NET Core for the Mac OS X, as well.


Multiple room admins

Would it be possible -- and (hopefully) relatively simple -- to allow more than one user exercise room administrator privileges?  Specifically, the ability to deletes songs added the playlist be OTHER users, change room name.
Thanks - love what's right so far, would love even more if we could go back to our multi-admin way of doing business.

Yes, looking at the room-system, it's already possible, but needs to be implemented on the front-end. (Make someone admin, remove admin privileges)

Are you saying I should already be able to do it?  Mind you, my technical skills are just shy of your average house cat, so I'd need someone to point me at a button or dialog box.
Ed
Sent from my iPhone

On Jan 2, 2015, at 1:31 PM, Jonas Dellinger<EMAIL_ADDRESS>wrote:
Yes, looking at the room-system, it's already possible, but needs to be implemented on the front-end. (Make someone admin, remove admin privileges)
—
Reply to this email directly or view it on GitHub.

To clarify, I believe Johnny is saying that this would be easy to implement on the "front end" (end user experience) but is only currently possible on the "back-end" (developer world). I would expect that you'll see this functionality soon. :)

Yes, thanks @zackram :)
Currently all room-admins are stored in a JSON-array like this:
"admins": [
    "someID"
]

So there is no problem adding more admins to it, we just need to built it into the user's view (e.g display a button like 'make room-admin') and implement it on the server-side

Yep you're all correct - this is supported by the server backend, and will be coming to the frontend along with the overhaul of the current listeners in room UI.

FYI, this will be fixed once #143 is closed.  No ETA yet.

This is now available!
Not through new UI, but using the new server commands feature.  If you're a room admin, type
/commands    for a list of commands
/addadmin to add an admin
/removeadmin to remove admin
New admins will have to re-connect to the room in order to be able to make changes.

Good news!  So what's the argument for /addadmin?  Spotify uid?  Soundbounce (Spotify|FB) login id?

If you type /addadmin it gives you help text too.  Cheers! Closing this now.

Thanks so much, Paul!  On behalf of Wizard Rock, let me say this: you rock!  So happy to have a new home for our room.
Have a great weekend
Ed
Sent from my iPhone

On Jan 9, 2015, at 6:26 PM, Paul Barrass<EMAIL_ADDRESS>wrote:
If you type /addadmin it gives you help text too. Cheers! Closing this now.
—
Reply to this email directly or view it on GitHub.

At some point, a /listadmin would be helpful too!  :smile:  Thanks again!

Good idea @bgod, added as issue #178


Courseware showJS completion modal - Ctrl+Enter shortcut doesn't work

Ctrl enter seems to advance coursewares along. I thought we had agreed not to flash a modal except for on marked exercises (a flag will need to be passed) to not disrupt the flow since the coursewares are pretty quick.

To clarify, this is on the JavaScript challenges. CTRL + Enter will run the challenge, but if your answer is correct, pressing CTRL+Enter won't advance you to the next one, which is definitely the desired behavior (it even says that on the modal's next challenge button). This functionality seems to work on bonfires and video challenges, but not here.

The twitter button also looks jacked up. It's probably a tabbing issue. I'll give it a look.


Cooldowns, little more typings and object parameters

Well back to more
This was tested and I think it's ready to publish to NPM

made brand new loadCommands() and loadCommandsSync(), as well as with events
put command parameters back into an object, and added a new instance object

getLoadedCommands(), getLoadedEvents(), reloadCommands(), reloadEvents(), getDefaultPrefix() and setDefaultPrefix(prefix) options added for use in command files!

made class fields private in order to prevent someone from setting them
updated readme
added cooldowns, as well as global cooldowns,
bugfixed some stuff
changed package.json dependencies and version to 1.3

This has been merged, been busy and have not been able to keep up with updates


NameError: name 'cnn_learner' is not defined

Hello,
I am having an issue with the recent update in fastai impacting fastai_audio.
When I try to run my learner it posts the following error:

NameError                                 Traceback (most recent call last)
 in
----> 1 learn = audio_learner(db)
2 learn.lr_find()
3 learn.recorder.plot()
~/course-v3/nbs/audio/learner.py in audio_learner(data, base_arch, metrics, **kwargs)
4 def audio_learner(data:DataBunch, base_arch:Callable=models.resnet18, metrics=accuracy, **kwargs):
5     '''Wrapper function for fastai learner. Converts head of model to fit one channel input.'''
----> 6     return cnn_learner(data, base_arch, metrics=metrics, **kwargs)
7
8 def audio_predict(learn, item:AudioItem):
NameError: name 'cnn_learner' is not defined
Is there an update I can pull to fix this?
Thanks!
Claire

What version of fastai are you using? How are you importing the audio module?

Hello - sorry for the delay - 1.0.45

Updated version of fastai and pytorch audio which fixed issue - sorry!


Clear screen option doesn't work

It seems like after a recent update the clear screen option doesn't properly clear the screen anymore. My terminal doesn't reset back to the top and I can scroll up to the output of previous runs. It's possible I'm mistaken but I thought the usual behavior was that you couldn't scroll back to output of previous runs, so if I scroll up all the way I just get to the top of the current run.
I also now see this message every time I Ctrl+C cargo watch:
watchexec::run: 2021-08-24T19:49:13.045-04:00 - WARN - Could not pass on signal to command: I/O error: No such process (os error 3)

I tried running with --debug but didn't see anything suspicious or seemingly related to clearing the screen/TTY stuff.
I'm using:

cargo-watch 7.8.1
cargo 1.55.0-nightly (27277d966 2021-07-16)
xfce4-terminal <IP_ADDRESS>
Xubuntu 18.04.5/Linux 4.15.0-154-generic

Just found #160, seems very similar. Running tput reset in my terminal does what I'm expecting cargo watch -c to do.

What shell are you using and what's the value of TERM?

That warning is known (will go away in a future update): it tries to pass on the SIGINT but the command has already exited; better tracking of the command state is coming, fixing this.

Also: are you using tmux or some other mux (screen etc)

fish, version 3.3.1
TERM=xterm-256color
No other mux

And vte version if you can get that. Also what does tput clear do? And while we're at it, the outputs of tput reset | hexdump -C and for tput clear | hexdump -C
That said, watchexec only runs the clear, not the reset. tput clear does work here (I'm running xfce term 0.8.10/vte 0.64.2 as daily driver).


scale=1,Can it be used for image repair or image denoising?

scale=1,Can it be used for image repair or image denoising?

We've already done that, head to https://upscale.wiki/wiki/Model_Database for a lot of trained models, including 1x denoisers. Join here https://www.reddit.com/r/GameUpscale/ or on the Discord channel if you need any help

We've already done that, head to https://upscale.wiki/wiki/Model_Database for a lot of trained models, including 1x denoisers. Join here https://www.reddit.com/r/GameUpscale/ or on the Discord channel if you need any help

I would like to ask a few questions: that is, ESRGAN generally uses a relatively high resolution image prepared by itself and then generates a relatively low resolution image. The first problem with my problem is that the image dataset I used was originally a relatively low resolution (200*380), and then I wanted to generate a higher resolution image through ESRGAN, so that would not generate a higher resolution. Rate of pictures? The second is that the original image contains noise. If a high-resolution image can be generated, will it affect the generated image? Will the noise be generated at the same time as the high-resolution image is generated? This is my question, thank you.

I don’t understand your questions well enough, but I think that for your first question, you need to use scale=1 and LR and HR (GT) have to be the same size, so it won’t upscale. Also, the framework will always crop the images to the defined size (default:128x128), so the actual images do not have such a high resolution. For the second, if your HR has noise, then yes, your model will learn to add noise. If you use my fork, I added a lot of noise types for augmentation that has been used for some denoising models (gaussian noise, dithering, JPEG compression and others)

I don’t understand your questions well enough, but I think that for your first question, you need to use scale=1 and LR and HR (GT) have to be the same size, so it won’t upscale. Also, the framework will always crop the images to the defined size (default:128x128), so the actual images do not have such a high resolution. For the second, if your HR has noise, then yes, your model will learn to add noise. If you use my fork, I added a lot of noise types for augmentation that has been used for some denoising models (gaussian noise, dithering, JPEG compression and others)
First of all, thank you for your answer.  I want to train my own picture to do super resolution. Through your previous answer, I learned that the model can also be used for denoising (scale=1), which is also part of what I want to do, but whether it is super-resolution or Denoising must have a corresponding GT image, and the problem I am having now is that my image does not have a corresponding GT image. The images I have have lower resolution and contain noise, so I would like to ask you, like If I am in such a situation, I can't do super-resolution and de-noising tasks, or I want to ask you, if you have any good suggestions or solutions for this situation.

I don’t understand your questions well enough, but I think that for your first question, you need to use scale=1 and LR and HR (GT) have to be the same size, so it won’t upscale. Also, the framework will always crop the images to the defined size (default:128x128), so the actual images do not have such a high resolution. For the second, if your HR has noise, then yes, your model will learn to add noise. If you use my fork, I added a lot of noise types for augmentation that has been used for some denoising models (gaussian noise, dithering, JPEG compression and others)

First of all, thank you for your answer.  I want to train my own picture to do super resolution. Through your previous answer, I learned that the model can also be used for denoising (scale=1), which is also part of what I want to do, but whether it is super-resolution or Denoising must have a corresponding GT image, and the problem I am having now is that my image does not have a corresponding GT image. The images I have have lower resolution and contain noise, so I would like to ask you, like If I am in such a situation, I can't do super-resolution and de-noising tasks, or I want to ask you, if you have any good suggestions or solutions for this situation.

You need to create a model with images that are not the images you want to denoise/upscale.
You need to get a dataset of image pairs, one set being the ground truth or high-resolution images and the other being the same images but degraded with the transformation you want your model to learn.
If it's denoising, your low-resolution pairs should contain the noise you want to fix and the GT will be the clean version of the image. Normally such pairs do not exist naturally, so the low-resolution pairs are created artificially (for example, adding Gaussian noise, Poisson noise,  JPEG compression noise, etc).
If it's super-resolution (SR), the low-resolution pairs must be created using the interpolation method you want to revert. Many projects use Matlab's bicubic kernel as a standard to be able to compare with others on equal condition, but that's not the typical case found on normal images around the web, for example.
So you need to take into consideration exactly what you want to achieve in order to design your dataset. If you want to do some augmentations on the fly, like some noise types or downscaling algorithms provided by OpenCV then you can use my fork that allows for that without needed to create the LR pairs a priori: https://github.com/victorca25/BasicSR/wiki/Dataset-Augmentation

I also added other loss functions that may be useful depending on the task you want it to do, like SSIM/MS-SSIM and the HFEN losses and the total variation regularization. You can talk with more people working on those things in the reddit I linked before and the Discord channel there, it's not limited to just games.


Added ProjectorInfo for vision models with CLIP

Nice, where did you find this? Their api docs won't mention projector_info.

Nice, where did you find this? Their api docs won't mention projector_info.

I found it when trying minicpm-v, and there is also something related in ollama-js.

Awesome, nice find!


[1.8.1-b0] If there is any file on the export folder, the plugin stops building website.

Describe the bug
We choose the export directory when we set the plugin.
When building website using this plugin, if there is any extra file (even am empty file), the plugin stops.
If we remove all the files on the export directory, it works.
But I think it is little bit uncomfortable for publishing tasks using git. (because of .git directory)
Operating System
Mac OS
To Reproduce
Steps to reproduce the behavior:

install 1.8.1-b0 version of the plugin.
plugin configuration
create any file in the export directory.
export using the plugin.

Screenshots

In this case, if I remove .DS_Store, it works.
IMPORTANT: Error Log
see screenshots

It is actually any file or is it only files starting with a "."
Both .git and .DS_Store starts with a "."

Any file!
this is an example:

Okay I think I have an idea of what the problem is. Thanks for the report :)

This should be fixed in 1.8.1-1b


Introduce the new version of kubernetes log exporter for dumping logs during a period of time such as pytest

What do these changes do?
As titled.
Related issue number
An optimization for https://github.com/alibaba/GraphScope/pull/2683

Codecov Report

Merging #2706 (30958d0) into main (e447cd5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2706   +/-   ##
=======================================
  Coverage   41.40%   41.40%
=======================================
  Files          99       99
  Lines       10352    10352
=======================================
  Hits         4286     4286
  Misses       6066     6066

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e447cd5...30958d0. Read the comment docs.


[Notebook Issue] hw02 - Task 11

Content Link
hw02
Issue Description
Task 11 public grader feedback shouldn't be so specific about using the numbers array!
[Optional] Solution
Update the language for the success message.

The language was updated to say that all the values in the array were divisible by 1577.


Issue with Connect-IPPSession to DelegatedOrganisation

Hey,
Running into an issue with our scripts here - We are unable to use the Connect-IPPSession with the -DelegatedOrganisation parameter.
Getting Access Denied and A strange issue here

Let me know if you need more info!
I've been to MS and The MS community who've pointed me here.
Any help will be appreciated!

@Adzino1, are you using v3.0.0 of the ExchangeOnlineManagement module?
Notice that the description for the DelegatedOrganization parameter in Connect-IPPSSession is 'reserved for internal Microsoft use'.
You should open a support ticket and ask.

@Adzino1 Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@Adzino1 Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only. We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Funnily enough, Microsoft asked me to come to Git and ask :)

@Adzino1, unless you hear otherwise, presume DelegatedOrganization doesn't work on Connect-IPPSSession. After all, the documentation says, "reserved for internal Microsoft use".
I'm asking some other sources (the same sources the support ticket people should have been asking!), but I'm pretty sure they would have told me about it based on the recent GA launch of v3.0.0, and the massive feature/documentation updates required for it.

@Adzino1, apparently, DelegatedOrganization is expected to work. You must be using v3.0.0 of the module, and you must also use the AzureADAuthorizationEndpointUri parameter in the command.
Report back here if that doesn't work. I've updated the documentation accordingly.

Hey, using this command here -
Connect-IPPSSession -DelegatedOrganization 'xxx.onmicrosoft.com' -AzureADAuthorizationEndpointUri 'https://login.microsoftonline.com/common'
Still getting Access denied errors
running exchange online module 3.0.0

@Adzino1, how is your support ticket about this going? Is it still open?

@chrisda Sent them the updated info, as I have here. Just waiting on a response.

@Adzino1 Any response.

@yogkumgit Hey, yes they've informed us that it only works with GDAP permissions - we are currently testing, during our early test with it was still getting Access denied. We are in contact with a Azure Lighthouse support also.

@Adzino1 Thanks. If you find it suitable and no update is required in the documentation, please feel free to close this issue.

@Adzino1 We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also. We proceed to close it.


dev: migrate to use ethereum-types

Closes #230
@ClementWalter: do you want to migrate the cairo files to a ethereum_types.{numeric | bytes} module?
if so - what about the compound types - do we create a third file ?

seems like some types have changed looking at the failed CI

CI is ok, just this weird error... would be nice to merge soon so as to not be forced to use the "old" types in next PRs.


translate vote pages bullshit

nothing seems right here
also "common.votes" needs to be translated

also please remove "Each Online Voter can participate in the event for free and watch all of the presentations live. Click here to collect your free ticket" as we spoke - this is an anti-pattern.... encouring to register is now part of the voting process ("on voted" behaviour )

updated & changed


Vulkan on RPi

https://blogs.igalia.com/apinheiro/2020/06/v3dv-quick-guide-to-build-and-run-some-demos/

#53


Filter entries to index.

Add a filter system to index only matching journal entries (like ^JRNFILT ).

Done, if the routine ^ZRJNFILT exists, we can use it to include\exclude journal entry to index.


Readme badges

Adds badges for

build status
coverage
pypi

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8f31dbf). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage        ?   79.98%
=======================================
  Files           ?       33
  Lines           ?     1289
  Branches        ?        0
=======================================
  Hits            ?     1031
  Misses          ?      258
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f31dbf...bc2dc47. Read the comment docs.


Checks, error="cannot add type constraint @ monitor.flux

Hi there,
i get the following error message with this check message template ${r._field}:
lvl=info msg="Error exhausting result iterator" log_id=0Lo3wvEG000 service=t ask-executor error="cannot add type constraint @ monitor.flux|121:20-123:11: type error 0:0-0:0: missing object properties (_field)" name=experim ental-to15
The same with ${string(v: r._value)}
Version: 2.0.0 (ad38ed1)

@StefanSa thanks! the data in the monitor is actually pivoted, so it's very likely that you would want to use the _field value instead of r._value.
for example, if my data looks like this:

_value
_field

1
used_percent

Then i would use ${string(v:r.used_percent)} in my status.

@russorat
you are right, this is how it works.
thx for your fast help here.


App Super Slow When Using Debugger

When using the Chrome debugger the application is so slow it gets stuck. When I disable the JS debugger the app runs as normal.
Using RN 0.46

Unfortunately, that's the downside of Chrome debugger as it executes JavaScript into V8 engine instead of JavaScriptCore.
Unless it's much slower than the previous version?

Yea when I updated to RN 0.46 my app will rarely load past the launch screen if the debugger is running. If I turn the debugger off I works normally, and this really only started after I used the React Native Git upgrade.


mixed-content blocked behind proxy

Hey Sebastian
After having tested successfully Typemill on a Vbox, I am trying to make it work on a production server (apache server) which is behind a proxy (nginx) with ssl certificate. Problem : All mixed content are blocked, the site can dispaly but very badly of course. If I understand well, the base url is detected through Slim framework but it seems that it picks the url in http instead of https. Is there a way to force it to https  ?
Olivier

Hi Olivier,
I am not familiar with that setup, but I run my Typemill websites on apache with https/ssl only. Did you already uncomment the http-redirect-rule in the htaccess file on the apache server?
# Use this to redirect HTTP to HTTPS on apache servers
RewriteCond %{HTTPS} off
RewriteRule (.*) https://%{HTTP_HOST}%{REQUEST_URI} [R=301,L]

Yes, the base-url is detected through the Slim framework and I set some security headers depending on https. If that all does not work, then I suppose that the nginx-proxy causes the problem and I am not sure how to solve it within the Typemill applications...

I had already tried to uncomment these lines.. with a worse result. In reality my typemill documentation site is in its very web directory but as an apache alias of a main https site. Probably, as you pointed out, there is likely to to do something at nginx level (but my colleagues in charge of this are a bit overbooked these times). I found, in my empiric way of very-far-from-being-a-php-geek, a solution to force Slim to https. In Uri class  (system/vendor/slim/slim/Slim/http/Uri.php), I set 'https' in hard copy to scheme value :
```
public function __construct(
$scheme,
$host,
$port = null,
$path = '/',
$query = '',
$fragment = '',
$user = '',
$password = ''
) {
//$this->scheme = $this->filterScheme($scheme);
$this->scheme = 'https';
That do the trick but I assume there should be a more orthodox way to proceed.  and maybe some counter effects ?

Olivier

Hi Olivier,
if that is the solution, then your setup seems to call the http version instead of the https-version of the website. In fact I do a similar check with that scheme in the content controller here: https://github.com/typemill/typemill/blob/master/system/Controllers/Controller.php
		if($this->c->request->getUri()->getScheme() == 'https')
		{
			$response = $response->withAddedHeader('Strict-Transport-Security', 'max-age=63072000');
		}

I could of course create some kind of hidden force https configuration that can be configured in the settings.yaml then. Otherwise I think that the real problem is the setup and I am not super confinced to fix it within typemill.
Let me know what you think....
Sebastian

Hey Sebastian,
I agree with you. I can understand you have priorities enough not to deal with this kind of specific config problem. May be if other users should complain of the same problem...
As of now, I can go with this workaround. just be aware of this when updating
Olivier

Hi Olivier,
thank you, I think I will check if a setting "forced https" is easy to integrate. If it is only some lines of code, then I can add it to the next release as a hidden feature for the settings.yaml-file...
Sebastian

Hi Olivier,
I made a quick research into this but I cannot find a clean way to manipulate the scheme and I do not want to overwrite a core constructor of slim framework. The only way I found in other solutions is to check the scheme and to redirect http to https then. But this probably won't help in your case because your main site is https already as you said.
Reading your post again I see that you use an "apache alias of a main https site". I am not super familiar with that topic but you could try to use mod_rewrite instead of mod_alias. The htaccess should work then and mod_rewrite is the correct way to deal with https-redirects. As far as I understand the mod_alias cannot handle schemes.
Does that help? I will close this ticket then...

Create middleware for proxy setup and use X-Forwareded header. See: https://github.com/slimphp/Slim/issues/1861

Pushed to develop branch, proxy support will be part of version 1.4.0.
In settings, there is a checkbox for proxy now. Additionally the admin can add a comma separated list of trusted ip adresses. If there are IP adresses added, then the system checks the REMOTE_ADDR header for that IP and only applies proxy support if the IP is in the list.
For proxy support the script checks for the X-Forwarded-Proto, X-Forwarded-Host and X-Forwarded-Port Headers and rewrites the scheme.
Used the proxy detection middleware by akrabat: https://github.com/akrabat/proxy-detection-middleware

published with version 1.4.0


Eventually hangs unless the buffer gets cleared.

After a few seconds of adding data to the window, it gets choppy, and eventually unresponsive altogether. This does not occur if I clear the window every few seconds.
I'm using Ubuntu 20.04 with Chrome Version 89.0.4389.114 (Official Build) (64-bit)
Maybe we can limit the data buffer size to make this stop?

Can you give me an approximate number of characters when you start to see the slowdown?

Sure. It starts happening around 45000 characters.
Also, while doing this experiment, I noticed that there was no disconnect or stop button. So I had to copy and paste the content fast, before the browser hangs. Maybe it's a good idea to add a stop button...
Thanks for serialterminal.com by the way!!

see if the fix I just solved this issues. @janbbeck

Excellent! Fixed. Thank you.


Second level menu on mobile devices

It seems second level menu items are being hardly accessible on mobile devices
Steps:

go to https://builds.apache.org/view/M-R/view/OpenMeetings/job/OpenMeetings 4.0.x/site/openmeetings-server/index.html on mobile device (I have used android phone)
in top menu try to go to Configuration->User Interface->Hot keys
Result: after "touch" "User Interface" menu closes
Expected result: All levels should be accessible

Thank you, I can't work on it for the moment. I'm going to do at middle of January.

Will also try to investigate :)
Thanks a lot and Happy NY :)


Fix windows build issues

Fix debug build by ignoring the python debug library. An option IGNORE_PYTHON_DEBUG_LIBRARY is introduced for that.
Fix symbol registration issues with redefinition of cuda_version and linker optimizations in Release build.

Fixes #3086

Looks like the Python build is not happening like it is supposed to on Windows. I found the culprit, the models/*.cpp files are not included in the .pyd extension. I did not make any change to this file. I suspect that the change to the vision header broke this.
I can we reconcile this? Shouldn't the models.cpp be included in the .pyd extension?
This can be fixed with the following change, but I am not sure want was intended in the first place. So I will wait for comments before make further changes.
diff --git a/setup.py b/setup.py
index 82c93be..05eb199 100644
--- a/setup.py
+++ b/setup.py
@@ -136,6 +136,8 @@ def get_extensions():

     main_file = glob.glob(os.path.join(extensions_dir, '*.cpp'))
     source_cpu = glob.glob(os.path.join(extensions_dir, 'cpu', '*.cpp'))
+    models_dir = os.path.join(this_dir, 'torchvision', 'csrc', 'models')
+    source_models = glob.glob(os.path.join(models_dir, '*.cpp'))

     is_rocm_pytorch = False
     if torch.__version__ >= '1.5':
@@ -158,7 +160,7 @@ def get_extensions():
     else:
         source_cuda = glob.glob(os.path.join(extensions_dir, 'cuda', '*.cu'))

-    sources = main_file + source_cpu
+    sources = main_file + source_cpu + source_models
     extension = CppExtension

     compile_cpp_tests = os.getenv('WITH_CPP_MODELS_TEST', '0') == '1'

@willyd Thanks for your investigation.
I believe that this is intentional because the model C++ files are only compiled if WITH_CPP_MODELS_TEST=1:
https://github.com/pytorch/vision/blob/74de51d6d478e289135d9274e6af550a9bfba137/setup.py#L164-L174
Adding @fmassa, who could perhaps shed some light on the intended behaviour.

Hi,
We don't want to ship models.cpp together with the python binaries for torchvision. They are currently present in setuptools only as a testing artifact (as we didn't have C++-only tests back then), and shouldn't be present with python builds.
Ideally, we wouldn't need to include Python.h at all in the torchvision C++ libraries. It is currently a requirement probably due to the fact that we are using setuptools to compile the extensions.
The current situation with the models.cpp is that it's not actively maintained, and we are just now starting to improve support for the usage on the C++ api (thanks to work from @bmanga and @datumbox ).

@willyd We just merged to master the PR #3097 that might have fixed some of the header issues you describe here. Could you try if the latest master solves your problem at #3086?

@fmassa

We don't want to ship models.cpp together with the python binaries for torchvision. They are currently present in setuptools only as a testing artifact (as we didn't have C++-only tests back then), and shouldn't be present with python builds.

Understood.

Ideally, we wouldn't need to include Python.h at all in the torchvision C++ libraries. It is currently a requirement probably due to the fact that we are using setuptools to compile the extensions.

Thus we should not rely on the extension vision.cpp to register the operators but have a separate cpp file for operator registration, which I think happen in the TORCH_LIBRARY macros?

@datumbox
Sure. I will try and get back to you.

@datumbox
I just merged and updated my branch with the latest master. The header issues are indeed fixed.
The only remaining issues with master are:

Inclusion of the Python debug library. Ignoring it like I propose fixes the problem.
Without the /OPT:NOREF flag consuming projects have to reference the operators directly to have them included.

This PR addresses both the above issues.

@peterjc123 Could you please have a look?

An alternative solution for the windows registration failure is in #3380

An alternative solution for the windows registration failure is in #3380

@willyd @bmanga Does it make sense to close this PR then?

I haven't looked into the debug python part, but ideally I think we should get rid of the python dep.


Replace tilde (~) with caret (^) for mdast, mdast-lint

I follow SemVer on those, so only non-breaking features are included on minor and patch releases (which the caret catches, but the tilde only catches patch releases).
Yesterday I added support for multiple disables (<!--lint disable no-html first-heading-level-->), but now I have to wait for a new linter-markdown release to get access to them!

I do not know how atom handles updates of dependencies, once there are improvements on mdast and mdast-lint, I want to publish a new version, so that all users can experience the new features.
I will add a watch to mdast and mdast-lint, so every time you upgrade, I will follow within a day or two.

Oh that's great. Yeah you would still need to uninstall and reinstall to get the updates.
Anyway, thanks a lot!

@leipert You can close this btw if you’d like :smile:


better Favorites

After many merging pains, I am proud to present a PR that should improve the multiple favorites system with zero merge conflicts.

@metalcupcake5 this mans about to ruin your whole carrier

Besides my comment, everything else looks good.
I would prefer it to be a gold star when someone has been selected as a favorite, but that's just my preference

Yeah, that's your preference, we had a poll on Discord and this was ultimately desided.

@metalcupcake5  are you ready to sign off on it?

@MartinNemi03 thanks for pointing that out it should be fixed in eee2796


I want to add depth streaming to the C# form. Is there an example?

Required Info

Camera Model
D455

Firmware Version
2.53.1

Operating System & Version
Win 10

Platform
PC

SDK Version
2.5

Language
C#

I want to stream the depth using C#, but I'm asking because there doesn't seem to be an example using a form. If you know, please let me know. Thank you.

Hi @gjdeorl  Does the C# script at https://github.com/IntelRealSense/librealsense/issues/3413#issuecomment-474451376 help to resolve your problem, please?  Thanks!

var frames = pipe.WaitForFrames()  <==== An error occurs here. Why does this error occur? The error content is as follows.
System.InvalidOperationException: 'wait_for_frames cannot be called before start()'
ExternalException: rs2_pipeline_wait_for_frames(pipe:000001ED5ECE9E10)

I believe that https://github.com/IntelRealSense/librealsense/issues/3413#issuecomment-474451376 is not a complete script but is a section that is meant to be placed within a larger C# script.  Once the pipeline has been started (to resolve the problem that wait_for_frames cannot be called before start) then call the function name RunInThread() to jump to the block of code containing the depth display instructions.

Hi @gjdeorl  Do you require further assistance with this case, please?  Thanks!

Thank you for your reply.
One problem arose.
using (var depth = frames.FirstOrDefault(x => x.Profile.Stream == Intel.RealSense.Stream.Depth) as DepthFrame) In this part, the depth value comes out as a null value and 'System.NullReferenceException'(Intel.RealSense .dll) throws an exception.
How should I do this part?
The color part also comes out with a null value in the same way.

The RealSense SDK's C# Cookbook page of code snippets has a simpler way of defining FirstOr Default.
https://github.com/IntelRealSense/librealsense/blob/master/wrappers/csharp/Documentation/cookbook.md#wait-for-coherent-set-of-frames

Hi @gjdeorl  Do you require further assistance with this case, please?  Thanks!

Thank you for your reply. I will close this issue.


Tooltip is misplaced in Chrome extension's content scripts

Bug report
Current Behavior
Tooltip is incorrectly positioned against its trigger when it is used in a Chrome extension's content scripts.

Source code for the content script shown in the above:
import * as RadixTooltip from "@radix-ui/react-tooltip";
import { StrictMode } from "react";
import { createRoot } from "react-dom/client";

const tooltip = document.createElement("div");
tooltip.id = "tooltip";
document.body.append(tooltip);

const App = () => (
  <RadixTooltip.Root open>
    <RadixTooltip.Trigger>Trigger</RadixTooltip.Trigger>
    <RadixTooltip.Content>Content</RadixTooltip.Content>
  </RadixTooltip.Root>
);

createRoot(tooltip).render(
  <StrictMode>
    <App />
  </StrictMode>
);

Expected behavior
Tooltip should be placed in the default location because neither side, sideOffset, align, nor alignOffset is specified.
Reproducible example
CodeSandbox won't help because this problem is about Chrome extension. If I succeed in reproducing this as a normal web app, I'll update this issue and provide a CodeSandbox link.
Meanwhile, I prepared a repository for reproduction: https://github.com/yudai-nkt/radix-tooltip-repro. Please follow the reproduction steps below:

Clone the repository and build the extension

git clone git@github.com:yudai-nkt/radix-tooltip-repro.git
cd radix-tooltip-repro
npm ci
npm run build

Install the extension (this is explained here as well)

Go to chrome://extensions and enable developer mode in the top-right corner.
Click the "Load Unpacked" in the top-left and select the dist directory we built in the previous step.

Visit https://example.com/, and you will see the misplaced tooltip.

Suggested solution
I'm afraid but I have no idea.
Additional context

The same problem happens with @radix-ui/react-popper (cf. react-popper branch of my reproduction), so the getPlacementData function in @radix-ui/popper might be the cause of this issue. This is what I have investigated so far.
#367 and #370 might be related, but I'm not sure if they really are.

Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-tooltip
0.1.8-rc.39

React
n/a
18.1.0

Browser
Google Chrome
102.0.5005.61

Assistive tech
n/a

Node
n/a
v16.13.1

npm/yarn
npm
8.1.2

Operating System
macOS
10.14.6

the new release candidate in which the tooltip isn't portalled by default as you now need to wrap the Content in a new Portal part.

This explains why setting portalled props to the Content component gives a compile error contrary to the documentation (and now I found a preview).
Your suggestion now fixes my problem. Thanks, @benoitgrelard!

@yudai-nkt I got the same issue with @radix-ui/react-dialog. How do you resolve your issue?

@trankhacvy as you can see in this thread my issue was caused by a breaking change in RC. Yours is unlikely to be related to this, so you can ask for a help in Discussions with a minimal reproduction (or open an new issue if you believe it's a Radix's bug)


publish<EMAIL_ADDRESS>

Requested by: @bruno-garcia
Merge target: (default)
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave the #retract comment under this issue to retract the release (original issuer only).
Targets

[x] nuget
[x] github
[x] registry

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

Merge target: (default)

I set the merge branch to feat/4.0.0 this is odd

Worked out, just didn't merge back because of conflict


Question

Hey @giswqs ,
really cool component. Quick question:
Could one combine the timeline with a linechart. So instead of having boxes
one would have just a linechart? So i could also have along the y-axis groups
and for each group i would get a linechart in the x-axis along the time?

Check out the examples at https://visjs.github.io/vis-timeline/examples/timeline/. If you can find a solution there, it should be feasible with this streamlit component as well.

I actually found the page too but no solution for my problem. Do you know the difference between graph2d and timeline and how to combine them?

Can i somehow set the default focus not to hours but days?

I am not really a JavaScript user. I think you can look at the Configuration Options, zoomMin, ZoomMax, hiddenDates, etc.
https://visjs.github.io/vis-timeline/docs/timeline/#items

Thanks


feat: create new download command connected to new endpoint

New download command (download files) currently just next to download sample-results. The command use the new server endpoint so generates only one request for fetching the download links and has the following new features:

files can be filtered for a list of extensions
group results can also be fetched with --folder-type = "all" or "project"
Files can be downloaded with all previous versions or just the current
The generated file names have the following format:
{project_name}.{sample_name}.{folder_name}.{file_name}.{extension}   (without versions)
{project_name}.{sample_name}.{folder_name}.{file_name}.v{version_no}.{extension}.  (with versions)

All "." in entity names are replaced to "-" , "::" to "__" and invalid characters ([":", '"', "<", ">", "/", "\", "|", "?"], maybe there are more actually...) to "-" on the server side.
Download commands will be displayed on the geoseeq FE to help users.
Question: the server currently send links in a simple dictionary where keys are the generated filenames the values are the download links (the --urls-only command downloads this dict as a json). Do we need more info? Previously the stored data of each field was possible to download. Do we need that? If yes I have to modify the server first a bit. Not too much effort if we want to. On the other hand does not really contains more info just in more structured way.

I don’t think we need more info than that now but I could see a future where we want the entire stored info so we could (eg)

grab a different linked file (like a BAM index)
download differently based on storage type
give a preview of the file sizes before initiating download

If/when we want to do stuff like this we can add ?verbose=true or similar to the server side endpoint.

Code looks good but I would like you to add a “preview” that shows the user what’s going to be downloaded before running the download (similar to the upload reads command) and asks the user to confirm.
This should automatically accept if the user adds --confirm (or similar)
This only needs to show if we actually download file content, not just URLs.


Add configuration support

support configuration in ~/.config/pkgdev/pkgdev.conf
Uses mostly similar code to the one in pkgcheck

Resolves: https://github.com/pkgcore/pkgdev/issues/26

Tasks:

[x] Add tests for results of config file passing
[ ] Try to add documentation - maybe need to call for help

Example file at ~/.config/pkgdev/pkgdev.conf:
[DEFAULT]
commit.scan = true
commit.mangle = true
commit.all =
push.ask =

And finally, I managed the thing I wanted from the start! 😃
NOTE: the format of the config changed!
You can set options in the same file, but you prefix every option with the namespace for the program you want to config, so no more mixing of --ask for commit or push.
Now I need real help for the documentation. I will try to copy the documentation from pkgcheck, but this will be done in separate PR.


AnyAnyMap Example

Codecov Report

Merging #1489 (076b15d) into master (f2ef745) will increase coverage by 0.34%.
The diff coverage is 83.93%.

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   70.02%   70.37%   +0.34%
==========================================
  Files         404      406       +2
  Lines       39291    39361      +70
==========================================
+ Hits        27515    27701     +186
+ Misses      10014     9899     -115
+ Partials     1762     1761       -1

Flag
Coverage Δ

go-1.14
?

go-1.15
70.37% <83.93%> (+0.35%)
:arrow_up:

go-1.16
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

container/garray/garray_func.go
100.00% <ø> (ø)

container/gmap/gmap_hash_any_any_map.go
91.97% <ø> (+12.37%)
:arrow_up:

database/gdb/gdb_model_insert.go
68.04% <ø> (ø)

database/gdb/gdb_model_whereor_prefix.go
27.27% <ø> (ø)

database/gdb/gdb_model_where_prefix.go
30.43% <30.43%> (ø)

database/gdb/gdb_model_select.go
71.75% <90.19%> (+8.68%)
:arrow_up:

database/gdb/gdb_model_where.go
96.49% <96.49%> (ø)

database/gdb/gdb_model_whereor.go
100.00% <100.00%> (ø)

database/gdb/gdb_driver_oracle.go
0.00% <0.00%> (-18.58%)
:arrow_down:

os/gspath/gspath_cache.go
75.43% <0.00%> (-12.29%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ccc13...076b15d. Read the comment docs.


Validate constructors in ancestor contracts

Fixes #1332

Funny thing. The GSNRecipient from contracts-ethereum-package extends from Context, which has an internal constructor.
And apparently Solidity generates an ABI entry for the constructor (even if it's internal), which is being picked up by the new validation, and causes the integration test to fail.
$ jq .abi build/contracts/Context.json
[{
    "inputs": [],
    "payable": false,
    "stateMutability": "nonpayable",
    "type": "constructor"
}]

We'll have to think how to get around this. Perhaps adding an exception for the Context contract? Or checking if the ctor body is empty?


[Menu] In 0.7.1, the menu, while always deployed, stays on top of the content (regression)

probably due to your css.
A new FOCUS layout structure will be delivered in next version. Please wait for it before try to correct it. It may clarify HTML and CSS structure.


lpadmin add "gutenprint52+usb" printer error

My working environment is CUPS 2.2.1-8+deb9u2, raspberrypi 3b+, system version is raspberrypi stretch.
$ lpinfo -v | grep usb
direct gutenprint52+usb://Dai+Nippon+Printing/DS-RX1?serial=CY2D83040412&backend=dnpds40
$ /usr/sbin/lpadmin -p DNP-RX1 -E -m DNP-RX1.ppd -v gutenprint52+usb://Dai+Nippon+Printing/DS-RX1?serial=CY2D83040412&backend=dnpds40
[1] 20784
$ lpstat -v
device for Dai_Nippon_Printing_DS-RX1: gutenprint52+usb://Dai+Nippon+Printing/DS-RX1?serial=CY2D83040412&backend=dnpds40
device for DNP-RX1: gutenprint52+usb://Dai+Nippon+Printing/DS-RX1?serial=CY2D83040412

Dai_Nippon_Printing_DS-RX1 is add on the web, It can work. But DNP-RX1 can't work, Because its "device url" is not complate.
So, What should i do now?

Please contact the Gutenprint developers - this backend is not maintained by the CUPS project...


cannot run tests with docker

I had assumed that I do not need any php on my machine because the tests run in docker constainers ... But I get a problem with php and the ldap extension ...
make -C tests/acceptance/docker localApiTests-apiGraph-ocis
[...]
behat composer.lock is not up to date.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laminas/laminas-ldap 2.15.0 requires ext-ldap * -> it is missing from your system. Install or enable PHP's ldap extension.
    - laminas/laminas-ldap[2.16.0, ..., 2.17.0] require php ~8.0.0 || ~8.1.0 || ~8.2.0 -> your php version (7.4; overridden via config.platform, actual: 8.2.9) does not satisfy that requirement.
    - Root composer.json requires laminas/laminas-ldap ^2.15 -> satisfiable by laminas/laminas-ldap[2.15.0, 2.16.0, 2.17.0].

To enable extensions, verify that they are enabled in your .ini files:
    - /etc/php/php.ini
You can also run `php --ini` in a terminal to see which files are used by PHP in CLI mode.
Alternatively, you can run Composer with `--ignore-platform-req=ext-ldap` to temporarily ignore these required extensions.
make[1]: *** [Makefile:263: ../../../vendor-bin/behat/composer.lock] Fehler 2
make: *** [Makefile:145: localApiTests-apiGraph-ocis] Fehler 2
make: Verzeichnis „/home/jfd/Repositories/ocis/tests/acceptance/docker“ wird verlassen

Can't reproduce locally in ubuntu22.04

checked in both PHP version image: owncloudci/php:8.0 and image: owncloudci/php:7.4

@butonic can you give more information like

Operating system
PHP version in your system?

OS is arch based Elementary OS
✗ php -v
PHP 8.2.9 (cli) (built: Aug 13 2023 06:12:43) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.9, Copyright (c) Zend Technologies

I had assumed the docker based tests do NOT use my local PHP. That complicates things ...

fix in https://github.com/cs3org/reva/pull/4134


Suggest supported API method in README

Hello! The README says this alpha software and isn't really been supported.
What is your recommended supported option instead? Using the rest APIs directly? This would be a great thing to put into the README.

Also the samples don't appear to work anymore. Am trying to insert an event per https://github.com/google/google-api-ruby-client/blob/master/samples/cli/lib/samples/calendar.rb and get 'unknown keywords: summary, attendees, start, end'. The example at https://developers.google.com/calendar/v3/reference/events/insert#examples isn't even valid Ruby. Amending the brackets so that it is, it doesn't run with an error Event.new requires 0 parameters, not the 1 given.
By adding puts into the library code I've discovered that lib/google/apis/core/api_command.rb#65 is problematic - the representation object it creates contains data that I pass to insert_event (as a hash with string keys - NOT symbols) but the to_json call returns and empty object {}.
Any help/suggestions/advice welcome, this is most frustrating.

It looks like insert_event does a round trip to the server to get its results. You may have to specify fields to get back the data in the response you are looking for. https://developers.google.com/apis-explorer/#search/calendar/m/calendar/v3/calendar.events.insert has a handy fields editor with a complete list for this method.


chore(main): release grades-view-solid 1.2.0

:robot: I have created a release beep boop
1.2.0 (2024-01-23)
Features

Add link to github repo and to federal prescription for IT CFC (05c51d0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/jobtrek/grades-view-solid/releases/tag/grades-view-solid-v1.2.0 :sunflower:


A ModelChain object to batch simulate PV for multiple different Locations and different PVsystems

I found that instantiating a ModelChain can batch simulate PV for multiple different Locations and different PVsystems.
My task is like this, I have meteorological data, radiation data and PV panel mounting angle data for a certain region at a certain moment in time, they are all originally a 2D array. I need to simulate the PV power generation in this region at this moment in time, following the tutorial on the pvlib website and the comments in the source code:
Stretch this data into a table, with each row representing a Location, instantiate a PVsystem based on the angle of the PV panels installed at this location, which in turn instantiates a ModelChain, and enter the weather data from this row as weather into the ModelChain for simulation. Then need to traverse each row of data in this table to simulate, that is, each row of data need to instantiate a new ModelChain, because each row of my data represents a different Location, a different PV panel installation angle. And finally reassemble them into a 2D array.
But my sis realized that it can be done this way:
Stretch these data into a table, instantiate the whole columns (latitude,longitude) as a pvlib.location, and instantiate the whole columns of PV panel mounting angles (surface_tilt,surface_azimuth) as a PVsystem, which in turn instantiate a ModelChain finally The weather data of the whole table is input into ModelChain as weather for simulation. Thus, only one ModelChain needs to be instantiated to simulate the PV power generation at all locations. Finally, they are then reassembled into a two-dimensional array. Without traversing tens of thousands of rows of samples, the run is naturally ridiculously fast. And the results should be correct as well.
I explored pvlib's modelchain.py source code in the spirit of scientific rigor, and I found that the implementations of the ModelChain model do support matrix operations, i.e., they can be batch computed (note that I'm not talking about the batch simulation of multiple pieces of weather data for a Location and a PVsystem): instantiated shape same Location, PVsystem, instantiate those Locations, PVsystems into a ModelChain, and simulate the weather data with the same shape once.
Also, I found that the instantiation of whole columns (latitude,longitude) into a single pvlib.location on version 0.10.3 of pvlib is working fine, but on version 0.11.0 it reports an error (as in Figure 1). I explored the source code of pvlib.location and found that in version 0.10.3 it defaults to 0 when no altitude parameter is given (Figure 2), but in version 0.11.0 when no altitude parameter is given, it executes a lookup_altitude function (Figure 3), which is implemented to support only a single latitude and longitude inputs, and therefore an error is reported. So if you want to instantiate multiple latitudes and longitudes into a single Location on pvlib version 0.11.0, you need to give altitude, or if not, you need to enter altitude=0 to not report an error (Figure 4).
Therefore, I think it is necessary to point out this usage on pvilb's official website to facilitate different application scenarios. A screenshot of the code for the batching simulation is attached here (see Figure 5).

only one ModelChain needs to be instantiated to simulate the PV power generation at all locations

This capability (if it proves to give correct results) wasn't intentional and isn't tested. I can think of a few use cases, such as simulating power for an array on rolling terrain.
Is your request to vectorize that altitude lookup function?


builtins: implement gateway_region

PR: https://github.com/cockroachdb/cockroach/pull/58423
From release notes:

Implemented the gateway_region builtin, which returns the region of the connection's current node. [#58423][#58423] {% comment %}doc{% endcomment %}

Documented on both of:

https://www.cockroachlabs.com/docs/v21.1/functions-and-operators.html
https://www.cockroachlabs.com/docs/v21.1/set-locality.html


Fix discrepency in pc.KeyboardEvent documentation

In the docs for pc.KeyboardEvent for the event param, it is said that it is 'the original browser event that was fired' but the type assigned for it in the docs is pc.KeyboardEvent. Unless I'm mistaken, it should be the KeyboardEvent object from the web API. This would correspond to the event property which has the same description but is typed KeyboardEvent.

Thanks!


Hyundai: detect FCA feature

Not sure if this will work for all cars, I recall some cars have both messages but FCA is still not used, but I could be mis-remembering
If this works, we can merge some cars and make fuzzy fingerprinting more reliable

Time to see FCA looks good:
Time to see FCA on startup:
Platform: HYUNDAI SONATA 2020, dongles: 100, segments: 711
  mean: 5.763 ms, min: 0.0, ms max: 80.748 ms

Platform: HYUNDAI SANTA FE PlUG-IN HYBRID 2022, dongles: 5, segments: 26
  mean: 5.453 ms, min: 0.0, ms max: 10.54 ms

Platform: HYUNDAI SANTA FE HYBRID 2022, dongles: 3, segments: 53
  mean: 5.024 ms, min: 0.0, ms max: 25.653 ms

Platform: HYUNDAI SANTA FE 2019, dongles: 40, segments: 413
  mean: 5.28 ms, min: 0.0, ms max: 103.148 ms

Platform: HYUNDAI PALISADE 2020, dongles: 89, segments: 663
  mean: 6.14 ms, min: 0.0, ms max: 151.078 ms

Platform: KIA NIRO EV 2020, dongles: 44, segments: 253
  mean: 5.268 ms, min: 0.0, ms max: 26.793 ms

Platform: HYUNDAI KONA ELECTRIC 2019, dongles: 16, segments: 65
  mean: 4.835 ms, min: 0.0, ms max: 26.054 ms

Platform: HYUNDAI SANTA FE 2022, dongles: 10, segments: 48
  mean: 6.035 ms, min: 0.0, ms max: 30.547 ms

Platform: HYUNDAI ELANTRA 2021, dongles: 15, segments: 34
  mean: 5.186 ms, min: 0.0, ms max: 17.41 ms

Platform: KIA STINGER GT2 2018, dongles: 19, segments: 122
  mean: 5.588 ms, min: 0.0, ms max: 17.69 ms

Platform: KIA OPTIMA 4TH GEN FACELIFT, dongles: 5, segments: 21
  mean: 4.067 ms, min: 0.0, ms max: 11.27 ms

Platform: HYUNDAI ELANTRA HYBRID 2021, dongles: 9, segments: 18
  mean: 5.576 ms, min: 0.0, ms max: 10.573 ms

Platform: HYUNDAI SONATA HYBRID 2021, dongles: 27, segments: 140
  mean: 4.874 ms, min: 0.0, ms max: 20.127 ms

Platform: HYUNDAI IONIQ PHEV 2020, dongles: 6, segments: 32
  mean: 6.018 ms, min: 0.0, ms max: 20.056 ms

Platform: HYUNDAI KONA HYBRID 2020, dongles: 1, segments: 1
  mean: 0.0 ms, min: 0.0, ms max: 0.0 ms

Platform: KIA FORTE E 2018 & GT 2021, dongles: 3, segments: 6
  mean: 8.303 ms, min: 0.0, ms max: 10.247 ms

Platform: HYUNDAI ELANTRA 2017, dongles: 1, segments: 15
  mean: 5.491 ms, min: 0.0, ms max: 10.56 ms

Platform: KIA NIRO HYBRID 2021, dongles: 1, segments: 13
  mean: 7.014 ms, min: 0.0, ms max: 20.472 ms

Platform: GENESIS G70 2018, dongles: 1, segments: 5
  mean: 3.998 ms, min: 0.0, ms max: 10.118 ms

Platform: HYUNDAI IONIQ ELECTRIC 2020, dongles: 9, segments: 4
  mean: 2.502 ms, min: 0.0, ms max: 10.009 ms

Platform: KIA K5 2021, dongles: 4, segments: 77
  mean: 3.857 ms, min: 0.0, ms max: 10.966 ms

Platform: GENESIS G70 2020, dongles: 2, segments: 3
  mean: 0.0 ms, min: 0.0, ms max: 0.0 ms

Platform: KIA CEED INTRO ED 2019, dongles: 1, segments: 2
  mean: 5.405 ms, min: 0.0, ms max: 10.81 ms

There's only a few segments above 0.05 seconds, so our 1 second gather time should work for all cases:
Took too long to see FCA11: ('24feb9aaec275c53|2022-03-17--23-00-43--0', 'HYUNDAI SONATA 2020', 0.08075)
Took too long to see FCA11: ('2ac344325fa49bac|2022-05-05--19-17-14--0', 'HYUNDAI SONATA 2020', 0.07033)
Took too long to see FCA11: ('3a1959d8328c9bab|2022-05-25--16-22-42--0', 'HYUNDAI SONATA 2020', 0.08061)
Took too long to see FCA11: ('87f3c4c3b6c4c149|2022-06-15--07-06-16--0', 'HYUNDAI PALISADE 2020', 0.06001)
Took too long to see FCA11: ('925aeb5353ae69a1|2022-03-24--15-43-11--0', 'HYUNDAI SANTA FE 2019', 0.10315)
Took too long to see FCA11: ('9a69c1876d818143|2022-06-12--12-33-13--0', 'HYUNDAI PALISADE 2020', 0.15108)

In addition to checking the FCA detection, I also checked all our segments to make sure that the list we have is a correct and reliable signal to evaluate the detection.

Asserted for all non use_fca cars that the FCA11 message never exists
Asserted for all non use_fca cars that the SCC warn/braking signals never activate erroneously (>200 frames in a segment)
Asserted for all use_fca cars that the SCC warn/brake signal is either erroneous (doesn't signify AEB/FCW) or never activates.

Spot checked ~10 or so dongles, but no real failures for any of these conditions.
Conditions in code:
For 492 dongles across 36 platforms with a total number of 173098 segments, these conditions never activate:
Verifying the detection is reliable
  # use_fca comes from detecting CAN message anywhere in segment
  if platform in FEATURES["use_fca"]:
    if not use_fca:
      print('Should be use_fca but not:', (platform, segment))
  else:
    if use_fca:
      print('Should not be use_fca but is:', (platform, segment))

Verifying the list is correct
No segments failed this test. 36 total FCW events and 4 total AEB events.
  scc_warn_frames = len([i for i in scc_warn if i])
  # if platform uses SCC, check no erroneous SCC warn
  if platform not in FEATURES['use_fca']:
    if scc_warn_frames > 20:
      print('Car uses SCC, but erroneous warn', platform, segment, scc_warn_frames)

I spot checked the segments that popped up from this, and they all looked okay.
  # if platform uses FCA, check SCC warn is either erroneous or never activated
  if platform in FEATURES['use_fca']:
    if 0 < scc_warn_frames < 500:
      print('Car uses FCA, but SCC warn is not erroneous', platform, segment, scc_warn_frames)


scripts: zspdx: fix writing custom license IDs

The builtin list function .sort() sorts the list in-place and returns
None. As this is an invalid type for iteration, use the builtin sorted
function, which returns a sorted copy of the list, which we can iterate
over.
Signed-off-by: Jordan Yates<EMAIL_ADDRESS>

Thank you @JordanYates! Good catch. I haven't tested this on a project with a LicenseRef- set of licenses, but this makes sense and if you can confirm that it works as expected with your change then LGTM.

Yes, I was trying to run west spdx against a repo pulling in Nordics nrfxlib, which contains their Nordic 5-clause license. I can verify that the script at least runs to completion now.

Awesome, thanks @JordanYates. +1 from me.
@mbolivar-nordic I'm not sure if others will be reviewing patches for the zspdx scripts, so I'm good with this being merged.

@mbolivar-nordic I'm not sure if others will be reviewing patches for the zspdx scripts, so I'm good with this being merged.

Nope, you're the maintainer for this one, and your approval is fine with me. Thanks!


Update material.scss

remove padding on checkbox to make the checkbox level with the text (seems kinda ocd, but anyways)
What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Checkbox is out of line with the text behind
What is the new behavior?
Now it's not out of line
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Just as good or even better. Will change the request.


lxd snap v4.0.0: lxc commands hang for some time

This is on an Ubuntu 18.04 host running kernel 4.15.0-91-generic
Since the automatic update of the lxd snap to v4.0.0 basic lxc commands hang for almost a minute,e.g.:
$ time lxc list
[...]
real  0m51,010s
user  0m0,084s
sys   0m0,103s

lxc info CONTAINER shows output until here:
[...]
  Network usage:
    eth1:
      Bytes received: 9.77MB
      Bytes sent: 375.59MB
      Packets received: 94351
      Packets sent: 41851
    lo:
      Bytes received: 48.59MB
      Bytes sent: 48.59MB
      Packets received: 168219
      Packets sent: 168219

then hangs for the same amount of time before finally showing the snapshots.
This is with few containers (around 10). Storage backend is ZFS. Reboot of the server did not help. I'm happy to provide more info, just tell me where to look. I didn't see anything strange in the logs so far.
Here's some output from strace lxc info CONTAINER:
[...]
getsockname(6, {sa_family=AF_UNIX}, [112->2]) = 0
getpeername(6, {sa_family=AF_UNIX, sun_path="/var/snap/lxd/common/lxd/unix.socket"}, [112->39]) = 0
futex(0xc000100148, FUTEX_WAKE_PRIVATE, 1) = 1
write(6, "GET /1.0 HTTP/1.1\r\nHost: unix.so"..., 144) = 144
futex(0xc000180148, FUTEX_WAKE_PRIVATE, 1) = 1
epoll_pwait(3, [], 128, 0, NULL,<PHONE_NUMBER>68) = 0
futex(0x1383a28, FUTEX_WAIT_PRIVATE, 0, NULL) = 0
epoll_pwait(3, [], 128, 0, NULL, 0)     = 0
epoll_pwait(3, [{EPOLLOUT, {u32=212315976, u64=140308203941704}}], 128, -1, NULL, 0) = 1
epoll_pwait(3, [], 128, 0, NULL, 20633544) = 0
futex(0x1383a28, FUTEX_WAIT_PRIVATE, 0, NULL) = 0
epoll_pwait(3, [], 128, 0, NULL, 0)     = 0
mmap(NULL, 262144, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f9c0c840000
openat(AT_FDCWD, "/etc//localtime", O_RDONLY) = 6
read(6, "TZif2\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\5\0\0\0\5\0\0\0\0"..., 4096) = 1918
read(6, "", 4096)                       = 0
close(6)                                = 0
futex(0xc000180148, FUTEX_WAKE_PRIVATE, 1) = 1
socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 6
setsockopt(6, SOL_SOCKET, SO_BROADCAST, [1], 4) = 0
connect(6, {sa_family=AF_UNIX, sun_path="/var/snap/lxd/common/lxd/unix.socket"}, 39) = 0
epoll_ctl(3, EPOLL_CTL_ADD, 6, {EPOLLIN|EPOLLOUT|EPOLLRDHUP|EPOLLET, {u32=212315976, u64=140308203941704}}) = 0
getsockname(6, {sa_family=AF_UNIX}, [112->2]) = 0
getpeername(6, {sa_family=AF_UNIX, sun_path="/var/snap/lxd/common/lxd/unix.socket"}, [112->39]) = 0
futex(0xc000180148, FUTEX_WAKE_PRIVATE, 1) = 1
read(6, 0xc000476000, 4096)             = -1 EAGAIN (Resource temporarily unavailable)
futex(0x1383a28, FUTEX_WAIT_PRIVATE, 0, NULL) = 0
futex(0x1383a28, FUTEX_WAIT_PRIVATE, 0, NULL

and this is where it hangs. Does that help?
PS: just occurred to me, should I have filed this under lxc/lxc?

Does lxc list --fast behave differently?

Tracing the client is very unlikely to be helpful, all it does is send a REST request to the daemon.

I suspect that's the feature where we go and fetch the snapshot sizes now.
I already talked with @tomponline about not doing that when we list all containers (lxc list).
lxc info has a stronger case for fetching that information, though we need to look into why ZFS is being that slow in your case.

Yes --fast does not hang.
RIght... I wasn't aware how lxc and the daemon communicate.

I've checked lxc info for all the containers now, and it only hangs for some of them. But it doesn't seem to depend on the number of snapshots. lxc snapshot CONTAINER SNAPSHOTNAME hangs too for these containers. lxc delete CONTAINER/SNAPSHOTNAME is fast however.

Yeah, so that's hitting some kind of ZFS issue. So we'll be landing some changes in logic to at least speed up list and look at how we retrieve the size of snapshots in info.
But if creating a new snapshot is slow too, that does hint at some ZFS issues maybe.
Can you try manually creating and deleting a snapshot on the dataset?
zfs snapshot pool/dataset@blah
zfs destroy pool/dataset@blah

And see if that also is slow for those containers?

Manually creating and destroying snapshots on these containers is fast (command returns in less than 0.1 seconds)

NAME                                                                                USED  AVAIL  REFER  MOUNTPOINT
tank/containers/zulip                                                                          9,96G  1,29T  6,39G  /var/snap/lxd/common/lxd/storage-pools/tank/containers/zulip
tank/containers/zulip@snapshot-clean                                                           51,4M      -   701M  -
tank/containers/zulip@snapshot-zulip-clean                                                      735M      -  1,66G  -
<EMAIL_ADDRESS>                                                          904M      -  4,54G  -
<EMAIL_ADDRESS>                                                     82,9M      -  5,75G  -
<EMAIL_ADDRESS>                                                         83,4M      -  6,13G  -
<EMAIL_ADDRESS>                                                     82,6M      -  6,52G  -
<EMAIL_ADDRESS>                                                         9,38M      -  6,39G  -

Just noticed that zpool status tells me
status: Some supported features are not enabled on the pool. The pool can
	still be used, but some features are unavailable.
action: Enable all features using 'zpool upgrade'. Once this is done,
	the pool may no longer be accessible by software that does not support
	the features. See zpool-features(5) for details.

I suppose this is safe to do for lxd 4.0.0?

Yeah, you can upgrade your pool, that's fine. What matters is that your kernel supports it but that should be the case here.

Interesting about snapshot creation being fast at the ZFS level, this may suggest that something in the LXD code calls for the snapshot details and causes the same slowdown.

Seems that way. I also copied one of the containers to a different host (running lxd 3.0.3), deleted it, and copied it back. Problem still persist. Let me know if you need more info, debug logs or anything

I suspect that's the feature where we go and fetch the snapshot sizes now.
Should I see the snapshot size there somewhere? Neither lxc list nor lxc info CONTAINER shows anything about snapshot size. I just see the time when the snapshot was taken.

[...]
Snapshots:
  1.9.2-ready-to-go (taken at 2019/10/28 16:11 UTC) (stateless)
  2.0.4 (taken at 2019/10/28 16:14 UTC) (stateless)
  pre-2.1.2 (taken at 2020/02/19 18:45 UTC) (stateless)
  2.1.2 (taken at 2020/02/19 19:03 UTC) (stateless)

and the number of snapshots with lxc list.

@stiobhan so this PR (https://github.com/lxc/lxd/pull/7117) that got merged yesterday should partially alleviate the issue somewhat as it removes the mounting of snapshots when listing information introduced in https://github.com/lxc/lxd/pull/7071.
@stgraber you are correct that when taking a snapshot before https://github.com/lxc/lxd/pull/7117 is cherry-picked into the snapd package, the issue is that LXD updates the instance's backup.yaml file when creating a snapshot, which i turn populates info about all prior snapshots, which in turn calls mount on each snapshot. This was particularly bad on filesystems that needed UUID regeneration before mount, but would likely slow down the process for instances on other storage backends too.

@stiobhan I am going to put a PR up shortly that totally removes the snapshot usage metric from the RenderFull() function used in in lxc list

@stiobhan accessing the actual snapshot usage is currently only in API, e.g.
lxc query /1.0/instances/c1/snapshots/snap0 | jq .size
61440

@tomponline any guess why lxc query /1.0/instances/c1/snapshots/snap0 takes about 10 seconds for some containers and less than a second for others in my case?

@stiobhan can you provide the lxc config show <conainer> --expanded for a container that is quick and a container that is slow please.
Also can you show the output of zfs list on the host? Thanks

quick: https://pastebin.com/ReStBdQe
slow: https://pastebin.com/qmAXPEU7
zfs list: https://pastebin.com/mvAUnTfw

Cheers, can you get me the output of zfs list -t snapshot too please

pastebin is down, here's everything again on a different site (also nicer without big commercial banners ;-) ).
quick (ganglia): https://paste.ubuntu.com/p/kg59qGFPz9/
slow (zulip): https://paste.ubuntu.com/p/CNByzJg3q3/
zfs list: https://paste.ubuntu.com/p/kMGXDzsh2z/
zfs list -t snapshot: https://paste.ubuntu.com/p/XccyMJZq8x/

Another observation, this is fast:
$ lxc query /1.0/instances/zulip/snapshots
[
	"/1.0/instances/zulip/snapshots/2.0.4",
	"/1.0/instances/zulip/snapshots/clean",
	"/1.0/instances/zulip/snapshots/zulip-clean",
	"/1.0/instances/zulip/snapshots/2.1.2",
	"/1.0/instances/zulip/snapshots/pre-2.1.2",
	"/1.0/instances/zulip/snapshots/2.1.3",
	"/1.0/instances/zulip/snapshots/pre-2.1.3"
]

But accessing the snapshots with e.g. lxc query /1.0/instances/zulip/snapshots/2.0.4 takes around 10 seconds, except for the last two, which I think I created with lxd 4.0.0. So does lxd store additional info now in the snapshot that needs to be retrieved in some other way if not present?

Does that also fix the slow output for lxc query ... and lxc info ... I mentioned above?

It will fix lxc list for sure, for the others, it should be a bit better because there will not be any attempt at mounting the pool, there's still a bit more work needed to optimize fetching the value, but those fixes may be good enough for most already.

I would like to test this. Is it safe to install the snap from latest/edge, and then downgrade to 3.23/stable? Or is it in general not a good idea to downgrade from 4.0 to 3.23?

In general, assume that downgrades will not work. If any change had to be made to the database or on disk structure, LXD will refuse to start after a downgrade.

I tried the latest/edge snap (git-fcbba26) on a different machine, and indeed both lxc list and lxc info CONTAINER are as quick as they used to be. Any plans to push this to 4.0/stable any time soon?

It's rolling out to stable now

Hi @stgraber @tomponline ! I just found the real issue, I think. I found it quite suspicious that commands like this:
lxc query /1.0/instances/zulip/snapshots/2.1.2

took just slightly above 10 seconds as I mentioned here https://github.com/lxc/lxd/issues/7124#issuecomment-608296972
And as I mentioned here https://github.com/lxc/lxd/issues/7124#issuecomment-608402234 only the snapshots created with 4.0.0 have directories under /var/snap/lxd/common/lxd/storage-pools/tank/containers-snapshots/zulip/. If I create the missing directories for the other snapshots there manually the query returns immediately. So I suspect mounting fails if that directory does not exist and there must be a 10 second timeout somewhere in snapshot mounting code.

Oh, yes, that could definitely be an issue :)
@tomponline can you send a branch to sort that out?
We either need a patch that creates all the missing bits one time or we need to have logic which creates the mountpoint if missing on mount.

@stgraber will do


CORE-5143: Implemented filter for group retrieval

@domholmes just a minor change. I have also found that the sdk library is a bit old, have you try with a new version?

@domholmes just a minor change. I have also found that the sdk library is a bit old, have you try with a new version?

Done.


Archival workflow design

Design and document workflow for archiving and updating content on SingularityNET GitBooks.

Practical part of meeting will demonstrate how workflow might work

So far, after discussions, the workflow is

Within a week of the date of a meeting (ideally, sooner) the WG facilitator collects whatever is the agreed documentation from the meeting, and posts it in Discord "Meeting summary" channel (complete with date and title of meeting, and formatted). NB Different WGs will collect different things; but they should aim to be consistent in having the same things each meeting.
An Archives team member cut-and-pastes the material to the Archives GitBook
(TBC) The Archives team will develop a tags taxonomy, and tag posts appropriately. This will form the start of a finding-aid process. Taxonomy to be develped with community input?
If the Archive team member is aware of any additional material related to the meeting (e.g. a video or slide deck that the facilitator forgot to post), they should add it - but they should not actively go searching for more material to add.
The Archive team member replies in the Discord meeting summary channel with a link to where the material is on GitBook, for confirmation; and also states anything they added.
WG facilitator can then raise any corrections needed by replying in Discord. Any Archives team member can make the correction, and should reply in Discord to say it's done.

Meeting notes changed often - Tevo
We need to integrate this into our archival workflow - Vani
Becomes like Spam if too much information or notes added - Tevo
If a person facilitates more than one workgroup - connections can be made between WGs - A month from the day of the meeting do updates - Vani

Meeting 4 - 5th July 2023

Meeting summary channel is only for meetings not discussion - Vanessa
How we close issues - Archive issue for each month - Vanessa
Miro is just going focus on Archive WG transcriptions - Stephen
Look for new Archive resource to assist Vanessa
Write off meetings not submitting summaries - Vanessa
Settle for a partial Archive - Vanessa
Less participation ? - Tevo

Note that Andre's interface will send a copy of a meeting summary to the Discord meeting summary channel.
And adding to GitBook will be automatic - won't need anyone to actually archive it separately

Current workflow as of Sept 2023 https://docs.google.com/document/d/1OshEmaikeOta7STfQRm51An2meJdVJMJLOOBQQ9iJfI/edit?usp=sharing

[ ] Action Item - @VanCardui to tidy up workflow document and close issue

Final version of workflow is here https://docs.google.com/document/d/1OshEmaikeOta7STfQRm51An2meJdVJMJLOOBQQ9iJfI/edit?usp=sharing
Issue closed


ollama response missing

Hello Tom,
I tried this one with my local ollama and got undefined as a reply.

Here it must be <IP_ADDRESS> since it's the virtual gateway between the 2 containers.
My direct test call (from the saltcorn container) works:
root@7ba074ef19d5:/# curl --location --request POST 'http://<IP_ADDRESS>:11434/api/generate' --header 'Content-Type: application/json' --data-raw '{
  "model": "benob/vigostral",
  "prompt":"écris un poème haiku",
  "stream": false
 }'

{"model":"benob/vigostral","created_at":"2024-04-15T14:21:02.545540187Z","response":" Dans l'ombre des arbres\n\nLe temps s'écoule sans bruit,\n\nLa nature dort en paix.","done":true,"context":[733,16289,28793,28705,24688,3665,521,1627,8158,3631,23550,733,28748,16289,28793,14527,305,28742,300,2152,634,597,13243,13,13,3514,12974,268,28742,6915,280,291,12062,287,6424,28725,13,13,5798,4735,19187,481,5881,833,28723],"total_duration":536798612,"load_duration":3550333,"prompt_eval_duration":25484000,"eval_count":31,"eval_duration":507195000}root@7ba074ef19d5:/#

The Saltcorn plugin doesn't get the "response".
Any idea?

Hello @j2l. I have tried the same with "Local Ollama" as my interface backend, and it worked.

Mine also failed with "local ollama server" + "OpenAI-compatible API". Would you please give "Local Ollama" a try?

Thank you @Atozzio ! I'll have to test it again.


Integrated console seems lead to a long delay when executing C/C++ code

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.74.3 x64
OS Version: Windows 11Pro 22H2 22621.1105

Steps to Reproduce:

Install VSCode and Coderunner.
Run any C++ code with Code Runner (or anything else that uses the integrated console).

To make things more precise, I also did the following experiments in the latest insider version without any extensions:

Write a python shell that compiles C/C++ code, executes it immediately, and measures execution duration at the same time. Configure it to be the default build task (which runs in the integrated console).

The compiler args look like
g++ test.cpp -o test -std=c++17 -O2 -Wall -Wextra -Wconversion -Wshadow -Wl,--stack=1048576000

where test.cpp looks like
#include <bits/stdc++.h>

int main() {
    return 0;
}

The shell reports that compile finished immediately while the execution holds for about 10 seconds.

Remove -Wl,--stack=1048576000 in compiler args, and do the same things in (1). The execution time was reduced to about 2 seconds, which is still weird but much more acceptable.
Manually compile and run test.cpp (with compiler args in both (1) and (2)) in the external console in VSCode, and the program exits immediately as expected in both cases.

Could you please tell me why this is caused by an extension?
It can be reproduced on my laptop even after I launch VSCode with code --disable-extensions.


Error in Ember 2.8

Hello,
First thank you very much for this useful ember extension.
I recently tested my application under ember v2.8.0-beta.2 and have the following errors in console wen
TypeError: Component.create(...).createElement is not a function.
I traced that the error comes from the following location addon/components/aupac-typeahead.js# initializeTypeahead when using the createElement method.
This seems to comes form the following commit in ember : https://github.com/emberjs/ember.js/pull/13892 that remove the createElement method.
Regards,
ymh

Thanks for reporting this, this is a major issue.

I think the quickest solution here would be to create a DOM element, then use appendTo (instead of createElement).

OK, thanks.  I will give this a try.

Hello,
Just some observation I made during my attempts to solve this problem:

appendTo is not part of the ember component official API (
http://emberjs.com/api/classes/Ember.Component.html). Ember does not offer
an access to the API documentation of the previous versions, therefore, I
was unable to determine if it was there before.
The problem I was not able to solve was in fact to "realize" the newly
created component, i.e. to find a way to initialize the component element.

regards,
ymh
On Sat, Aug 27, 2016 at 4:43 PM, Jack Matthews<EMAIL_ADDRESS>wrote:

OK, thanks. I will give this a try.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aupac/ember-aupac-typeahead/issues/23#issuecomment-242921136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKV0hUaMjvMjMcO1iYYymg1930Vd7Yhks5qkE0hgaJpZM4Jg5WZ
.

@ymph Have not had time to look at this yet, I will give it a go this weekend probably.

Has there been any progress on this? Anything I can do to help? (This is the last step for my Ember 2.8 upgrade)

Have not had time to do anything on this. Will accept a pull request that
solves the issue.
On 21 Sep 2016 6:05 a.m., "Steven"<EMAIL_ADDRESS>wrote:

Has there been any progress on this? Anything I can do to help? (This is
the last step for my Ember 2.8 upgrade)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aupac/ember-aupac-typeahead/issues/23#issuecomment-248418081,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGDdOCPIIyQtEimSnBsacGjl6MIWuU1Rks5qsDx5gaJpZM4Jg5WZ
.

Let me know what you think of #24 - I think there are issues that need to be resolved, but it seems like a reasonable approach, considering how simple the templates are.

Just noticed that this destroys the extensibility of the suggestionTemplate. I'll keep investigating.


If an IP address is specified via the ScsTcpEndPoint it will be used as ...

...the local listen address by the TCP server listener (allows server binding to specific address/interface).

Can you briefly describe what this PR does and how does it. Sorry, I have forgotten to merge it. Also, I have forgotten purpose of this.


Retry canonical signature

I ran into a non-canonical signature, can't reproduce it anymore though but I guess having something to deal with it in the code doesn't hurt ...
Also noticed there was no test for signing ... so I added one.
And there was some random test failure because I did BitcoinLib::setMagicByteDefaults('bitcoin-testnet'); somewhere in RawTransactionTest so I added BitcoinLib::setMagicByteDefaults('bitcoin'); to the setup() so that it will always be bitcoin unless overwritten.

I'll try have another look at this in the next day or so, I've been incredibly busy this past while :frown:
One or two tests in the is_canonical_signature function are commented, and I know they were proving awkward at the time. I suspect we can get this working, since it's probably an issue with padding or AND operations not being carried out to detect that there's an issue, instead of repeating the signing process.

I'm not entirely sure because half the signatures were from bitcoinlib-js and the other half from BitcoinLib, but I think this error from bitcoind was because of signatures created by BitcoinLib (because I retried feeding the same partially-signed hex to the PHP part of the system and the 2nd time it succeeded):
2015-01-14 15:58:46 ERROR: Non-canonical signature: R value excessively padded
2015-01-14 15:58:46 ERROR: Non-canonical signature: R value excessively padded

Ok I had a go at this. https://github.com/Bit-Wasp/bitcoin-lib-php/compare/fixCheckCanonicalSignature?expand=1#diff-c87fe9e3825f612fc0cdf8dc090676e9R316 Rewrote is_canonical_signature() and encode_signature() and have tests for canonical signatures, and also signatures which fail for a specific reason (taken from the Satoshi client)
I also have a loop where 100 sigs are generated, serialized, and checked by is_canonical_check().
It's possible that the encoding function was incorrect, as it was doing str_pad() to pad it to 64 characters. is_canonical_signature() wasn't checking that either, so there was no way for it to ever catch it.
Let me know how this goes!

okay, dropping this PR in favor of your work