Add missing code for segmentation with --tune Psnr

Without this, encoding with --tune Psnr crashes:
thread 'main' panicked at 'attempt to subtract with overflow', /home/davidbarr/Archive/exp/rav1e/src/util/kmeans.rs:23:42
stack backtrace:

   0: rust_begin_unwind
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/panicking.rs:142:14
   2: core::panicking::panic
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/panicking.rs:48:5
   3: rav1e::util::kmeans::kmeans::{{closure}}
             at ./src/util/kmeans.rs:23:42
   4: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/ops/function.rs:301:13
   5: core::option::Option<T>::map
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/option.rs:929:29
   6: <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::next
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/iter/adapters/map.rs:103:9
   7: <&mut I as core::iter::traits::iterator::Iterator>::next
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/iter/traits/iterator.rs:3781:9
   8: <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::next
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/iter/adapters/map.rs:103:9
   9: core::array::try_collect_into_array
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/array/mod.rs:824:33
  10: core::array::try_collect_into_array_unchecked
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/array/mod.rs:764:14
  11: core::array::collect_into_array_unchecked
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/array/mod.rs:777:20
  12: core::array::<impl [T; N]>::map
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/array/mod.rs:445:18
  13: rav1e::util::kmeans::kmeans
             at ./src/util/kmeans.rs:23:5
  14: rav1e::segmentation::segmentation_optimize_inner
             at ./src/segmentation.rs:93:6
  15: rav1e::segmentation::segmentation_optimize
             at ./src/segmentation.rs:57:5
  16: rav1e::encoder::encode_frame
             at ./src/encoder.rs:3770:5
  17: rav1e::api::internal::ContextInner<T>::encode_packet
             at ./src/api/internal.rs:1366:9
  18: rav1e::api::internal::ContextInner<T>::receive_packet
             at ./src/api/internal.rs:1485:19
  19: rav1e::api::context::Context<T>::receive_packet::{{closure}}
             at ./src/api/context.rs:309:27
  20: rav1e::api::context::Context<T>::receive_packet
             at ./src/api/context.rs:313:15
  21: rav1e::process_frame
             at ./src/bin/rav1e.rs:172:21
  22: rav1e::do_encode
             at ./src/bin/rav1e.rs:272:32
  23: rav1e::run
             at ./src/bin/rav1e.rs:584:5
  24: rav1e::main
             at ./src/bin/rav1e.rs:318:3
  25: core::ops::function::FnOnce::call_once
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/ops/function.rs:248:5

Codecov Report
Base: 86.50% // Head: 86.45% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (468007d) compared to base (27997eb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2997      +/-   ##
==========================================
- Coverage   86.50%   86.45%   -0.06%
==========================================
  Files          88       88
  Lines       33964    33973       +9
==========================================
- Hits        29381    29371      -10
- Misses       4583     4602      +19

Impacted Files
Coverage Δ

src/api/internal.rs
97.47% <0.00%> (-0.08%)
:arrow_down:

src/encoder.rs
87.09% <0.00%> (-0.34%)
:arrow_down:

src/asm/x86/lrf.rs
92.85% <0.00%> (-1.27%)
:arrow_down:

src/context/mod.rs
91.57% <0.00%> (-1.06%)
:arrow_down:

src/tiling/tile_state.rs
88.40% <0.00%> (-0.73%)
:arrow_down:

src/context/frame_header.rs
68.32% <0.00%> (-0.46%)
:arrow_down:

src/rdo.rs
85.83% <0.00%> (-0.14%)
:arrow_down:

src/cpu_features/x86.rs
41.66% <0.00%> (ø)

v_frame/src/plane.rs
89.01% <0.00%> (+0.22%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Can we add a test to cover that path?

Patch coverage: 0.00% of modified lines in pull request are covered.

This is pretty telling.


Command failed with exit code 127

I cloned the repository with git today and installed vueman.ga by changing into the directory and running yarn install. That command worked fine, but all the other ones mentioned in the README.md file of this repository fail with exit code 127.
root@debian:/opt/vueman.ga# yarn run serve
yarn run v1.13.0
$ vue-cli-service serve
/bin/sh: 1: vue-cli-service: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
root@debian:/opt/vueman.ga# yarn run build
yarn run v1.13.0
$ vue-cli-service build
/bin/sh: 1: vue-cli-service: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
root@debian:/opt/vueman.ga# yarn run test
yarn run v1.13.0
error Command "test" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
root@debian:/opt/vueman.ga# yarn run lint
yarn run v1.13.0
$ vue-cli-service lint
/bin/sh: 1: vue-cli-service: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

The issue turns out to have been caused by some missing NPM packages. I was able to fix it with the following command:
npm install -g \
@vue/cli-plugin-babel \
@vue/cli-plugin-eslint \
@vue/cli-plugin-pwa \
@vue/cli-service \
@vue/cli-service-global \
vue-cli \
vue-cli-plugin-vuetify

However, now I get the following error:
root@debian:/opt/vueman.ga# yarn run build
yarn run v1.13.0
$ vue-cli-service build
 ERROR  Error: Cannot find module 'vuetify-loader/lib/plugin'
Error: Cannot find module 'vuetify-loader/lib/plugin'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:649:15)
    at Function.Module._load (internal/modules/cjs/loader.js:575:25)
    at Module.require (internal/modules/cjs/loader.js:705:19)
    at require (internal/modules/cjs/helpers.js:14:16)
    at module.exports (/usr/lib/node_modules/vue-cli-plugin-vuetify/index.js:8:33)
    at plugins.forEach (/usr/lib/node_modules/@vue/cli-service/lib/Service.js:80:7)
    at Array.forEach (<anonymous>)
    at Service.init (/usr/lib/node_modules/@vue/cli-service/lib/Service.js:79:18)
    at Service.run (/usr/lib/node_modules/@vue/cli-service/lib/Service.js:206:10)
    at Object.<anonymous> (/usr/lib/node_modules/@vue/cli-service/bin/vue-cli-service.js:36:9)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hi @whalehub, thanks for the report, this should not happen ideally, does it still occur?

@anshumanv Yeah, it still occurs.

@anshumanv Yeah, it still occurs. Any idea how to fix it?

Can you do -
rm -r node_modules package-lock.json yarn.lock
yarn install
yarn start

And check once again?
Also, I've pushed a dockerfile which you can use to build it if the above fails, still unsure of the reason though, works well everywhere.

@anshumanv Oh, I definitely prefer Docker. Could you push an official image to the Docker Hub so I can download it from there?


Some tests shouldn't pass on a well behaved emulator

This test for example:
{
    "name": "00 1d 8f",
    "initial": {
      "cpu": {
        "a": "0xa6",
        "b": "0x12",
        "c": "0xcd",
        "d": "0x94",
        "e": "0x75",
        "f": "0x50",
        "h": "0x43",
        "l": "0x3e",
        "pc": "0xff1d",
        "sp": "0x8fc0"
      },
      "ram": [
        [
          "0xff1d",
          "0x0"
        ]
      ]
    },
    "final": {
      "cpu": {
        "a": "0xa6",
        "b": "0x12",
        "c": "0xcd",
        "d": "0x94",
        "e": "0x75",
        "f": "0x50",
        "h": "0x43",
        "l": "0x3e",
        "pc": "0xff1e",
        "sp": "0x8fc0"
      },
      "ram": [
        [
          "0xff1d",
          "0x0"
        ]
      ]
    },
    "cycles": [
      [
        "0xff1d",
        "0x0",
        "read"
      ]
    ]
  }

reads at PC == 0xFF1D. This is in audio register land, and reading from that location should always return 0xFF (so we'll execute a RST instead of NOP)
Perhaps the tests should always execute in 0x0000-0xC000 address space ?

So technically an SM83 would pass this. Those registers are GBC custom processor specific, right


Comparative table of feature support in SFZ players

Would make comparisons easier and quicker.

From menu Software -> Players you can look for documented SFZ players (except Sforzando that uses the ARIA engine, the link points to the related product page) clicking from a player name link, but we have no an "all players" comparison table. Currently I removed the LinuxSampler one, linking to their sfz page instead which has its own opcode support table.

It would be even more informative to group information about what file formats each SFZ player can handle, along with the name of the related library the software.

BTW I'm not sure we want to maintain other people software information if they don't give it to us, this work was started as "we know about the existence of some software out there, here is a list" thing in the beginning

"if they don't give it to us"
how is that currently the case?

the current case might be that IDK which audio formats are supported by sfzero or zerberus (musescore), only for sfizz and (AFAIK also) liquidsfz because libsndfile. I'm not even sure about Sforzando... (currently I'm the only one working on those lists with all the information I can get from others...)

Have you started? Have you made any notes? Can you enable one of the sfz wikis so notes can be taken?

I'm sorry but I think in the end this is something that cannot be maintained except by their developers. If you are interested, the wiki is active.


ModuleNotFoundError: No module named 'leonardo'

Hi ,
After i have installed 'leonardo-3d-viewer' by using pip3 in my virtual environment django web-framework
And then I added 'leonardo' modules in models.py like as below
from leonardo.module.web.models import Widget
from leonardo.module.web.widgets.forms import WidgetUpdateForm
from constance.forms import JsonField
from leonardo.module.media.fields import FileField
And then , i tried to migrate myproject.
But , It seems like that have someting wrong.
How to solve it?
I want to show 3d model viewer in my project for user.
Thank you

Leonardo is standalone cms app which needs extra instalation steps, please proced the readme & doc for more informations.


Keychain error accessing User data.

Hi,
There is some problem accessing any data with the latest build. This is not an issue when I run the sample applications, but they are using old builds.
Basically I can't access any data due to a keychain issue. Here is the code snippet I'm running when first running the app and checking for an existing user:
func configureDefaultRealm() -> Bool {
    if let user = User.all().first {
        setDefaultRealmConfigurationWithUser(user: user)
        return true
    }
    return false
}

The error occurs at accessing the User.all() method.
Here is the error from the log:

libc++abi.dylib: terminating with uncaught exception of type realm::keychain::KeychainAccessException: Keychain returned unexpected status code:<PHONE_NUMBER>3709517598

Realm version: ? 2.0.0
Xcode version: ? 8.0
iOS/OSX version: ? 10
Dependency manager + version: ? None, installed frameworks manually

The error code<PHONE_NUMBER>3709517598 looks to be the result of an OSStatus error code being misinterpreted as an uint64_t. Converting it back to an OSStatus reveals the value is -34018, or errSecMissingEntitlement. I suspect this means your app is missing an entitlement related to the keychain.

Discussion at https://forums.developer.apple.com/thread/51071 suggests that the absence of an entitlements file can result in keychain calls failing with errSecMissingEntitlement in the simulator. Specifying an entitlements file, even if it contains no entitlements, can work around this problem. @bmctigue, does this workaround work for you?

Hi, I actually had to turn on KeyChain sharing in the Capabilities section for the app. This created the entitlements file with the setting. I removed the setting to see if just having the file would work, but I received the same error. So turning on Keychain sharing solved this, but I don't think this should be necessary. I'll let you decide this is an issue or not and whether we can close this. Thanks for the help! At least I can move forward...8>)

Per the link I shared above this appears to be a bug in the iOS 10 simulators. I agree that the Keychain Sharing entitlement shouldn't be necessary, but it seems unavoidable until Apple addresses the problem.

Ok, sorry, didn't read the forum entry, just went to try the fix. I'll close this.


Cache data more aggressively

It would be kinda neat if the app has a timeline similar to most Twitter clients: It shows the old news when opened and refreshes in the background.

I think we should use okhttp's caching feature


[NEW ALGORITHM] Extreme Gradient Boosting (XGBoost) Algorithm

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[Extreme Gradient Boosting (XGBoost)]
About:
A highly efficient and scalable implementation of gradient boosting, often used in Kaggle competitions. C implementation can be challenging but can be achieved using libraries like XGBoost itself or custom implementations.
Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

do not create unnecessary issues

@MastanSayyad I need a reasoning for why this unnecessary


Webassembly preview

Hello!
Can we have a preview for wasm through binaryen?
Firefox nightly and chrome canary have a demo: Demo
Another demo: demo-bananabread
Toggle javascript.options.wasm in (about:config).
Here is fire fox nightly: https://nightly.mozilla.org/

I'm not sure Godot at current moment is using Webassembly as it's html5 backend.  However core developers are having high hopes for this technology for the future, you can read more here: http://godotengine.org/article/webassembly-godot-web

Is there any timetable for WebAssembly? I'm sure the core devs want to use it but it's hard to do anything while the API is in flux and there's no prediction when it'll become stable. Also, they plan to make it easy conversion from Emscripten, which we use already.

Currently Emscripten still goes the extra mile over asm.js (C++ → LLVM bitcode → asm.js → wasm).
This is not going to change before LLVM has a proper wasm backend. I don't think it's worth it to look into changing the build system before then, unless someone is curious enough to do it themselves.
Until then, web export still has more than enough issues (that will persist with or without WebAssembly)

https://webassembly.github.io/demo/ looks cool.


[RFC] pluggable filters

have a directory with a per (popular) schema namespace filters that will inherit the base Odoo filters. Thus UBL could have its customizations, same for Brazilian electronic invoicing and so one. Also make a way to load custom filters.

at least you can easily override them by loading your CustomGenerator with your CustomFilters(OdooFilters)...


Install-Module -Name Microsoft.Online.SharePoint.PowerShell fails with error ""Could not load type 'Microsoft.SharePoint.Client.CustomerKeyVaultKeyType' from assembly 'Microsoft.SharePoint.Client, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=71e9bce111e9429c'."

I am attempting to configure a one-way Outbound Hybrid with my SP2016 on-prem farm (w/April 20019 CU).  I am executing the steps in the article https://docs.microsoft.com/en-us/sharepoint/hybrid/configure-server-to-server-authentication.  On Step 10 of "To install the online service management tools and configure the PowerShell window:" provides the following commands:
Add-PSSnapin Microsoft.SharePoint.PowerShell
Import-Module Microsoft.PowerShell.Utility
Import-Module MSOnline -force
Import-Module MSOnlineExt -force
Import-Module Microsoft.Online.SharePoint.PowerShell -force
The Import-Module Microsoft.Online.SharePoint.PowerShell -force fails so I run the Install-Module for this module and it successfully installs version 16.0.8812.1200 of the module.  After this when I attempt to execute Import-Module (as above) I get the following error:

TerminatingError(Import-Module): "Could not load type 'Microsoft.SharePoint.Client.CustomerKeyVaultKeyType' from assembly 'Microsoft.SharePoint.Client, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=71e9bce111e9429c'."
Import-Module : Could not load type 'Microsoft.SharePoint.Client.CustomerKeyVaultKeyType' from assembly
'Microsoft.SharePoint.Client, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=71e9bce111e9429c'.
At line:1 char:1

Import-Module -Name Microsoft.Online.SharePoint.PowerShell

  + CategoryInfo          : NotSpecified: (:) [Import-Module], TypeLoadException
  + FullyQualifiedErrorId : System.TypeLoadException,Microsoft.PowerShell.Commands.ImportModuleCommand

Import-Module : Could not load type 'Microsoft.SharePoint.Client.CustomerKeyVaultKeyType' from assembly
'Microsoft.SharePoint.Client, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=71e9bce111e9429c'.
At line:1 char:1

Import-Module -Name Microsoft.Online.SharePoint.PowerShell

  + CategoryInfo          : NotSpecified: (:) [Import-Module], TypeLoadException
  + FullyQualifiedErrorId : System.TypeLoadException,Microsoft.PowerShell.Commands.ImportModuleCommand

After some digging I found some reference to articles that seemed to suggest that these module require specific version of server-side modules to be present.  So I naturally thought of downgrading the module.  When I try to Uninstall the module it will not le let me uninstall too.
Any suggestions is greatly appreciated.

Is there a reason you're not using the Hybrid Config wizard? This is the strongly recommended way to configure any hybrid scenario (Search will just require the extra onboarding script post-Hybrid config wizard run).

Are you referring to this script?
https://blogs.msdn.microsoft.com/spses/2015/11/17/office-365-sharepoint-hybrid-configuration-wizard/

It appears that when you execute "Install-Module -Name Microsoft.Online.SharePoint.PowerShell" it picks up the latest version (i.e. 16.0.8812.1200) in the gallery.  However if you install the "SharePoint Online Management Shell" from the download link (https://www.microsoft.com/en-us/download/details.aspx?id=35588) using SharePointOnlineManagementShell_8812-1200_x64_en-us.msi, it installs version 16.0.8812.0.
Initially I had downloaded from the PowerShell gallery and the subsequent Import-Module cmd for this was failing with the above errors.
After I downloaded and installed from the .msi, I found the result of Get-Module -Name Microsoft.Online.SharePoint.PowerShell -ListAvailable | Select Name,Version returns the following output:
Name                                   Version

Microsoft.Online.SharePoint.PowerShell 16.0.8812.1200
Microsoft.Online.SharePoint.PowerShell 16.0.8812.0
After this I was able to successfully run Import-Module.
Not sure if there are any differences between the two.

@ashokgop Thank you for submitting feedback. We are currently investigating this.

@officedocsbot assign @scanum

@ashokgop Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@officedocsbot close


use ECMAScript 2015

rewrite done.
but require and import are not yet supported -> follows in a later release


Logo Design Offer as Open Source Contribution

Hello Sir. I'm a UI/UX and Graphics Designer. I want provide a logo for you. Would you mind if I propose a new logo design for your project as my Open Source Contribution?
Thanks before.

@anharismail Welcome！Pull request please.

Hello, Sir @ko1o . These are my logo proposal for your application.
I'm very welcome if you have any comments, opinions, or revisions. Please just tell me.
I'll provide all file types and sizes you needed.
Hope you like it.
Version 1

Version 2

@anharismail Nice ! Can you provide two pictures of the red box mark in the picture? like this.

Hello Sir @ko1o , could you mind if you place my logo design on your project Readme?
Thanks before :)

@anharismail You can add your logo at the top of Readme like this and pull a request!


WebApiAssemblyToSwaggerGenerator fails to generate action with 2 lists as parameter

When I try to generate SwaggerDocument from an assembly which contains an action with 2 collections as parameter, as following :
[HttpGet]
[Route("MyFailingAction")]
public List<int> MyFailingAction(List<int> list1, List<int> list2)

the generator fails with following exception :  The operation 'MyControllerName_MyFailingAction' has more than one body parameter.
But when generation is done with static method SwaggerDocument.FromUrlAsync(url), the action is correctly generated.
Is it an issue or is it as expected ?

An hack exists : add parameters into route enforce SwaggerParameterKind.Path instead of SwaggerParameterKind.Body
[HttpGet]
[Route("MyFailingAction/{list1}/{list2}")]
public List<int> MySuccessAction(List<int> list1, List<int> list2)

I think this is a bug and should work if the http method is GET

Ok but if I want to do a POST action with the same signature, is the exception the expected behavior ?

The question is: How does Web API handle this action method (for GET and POST)? If we know that, we can implement it in the same way in NSwag


Manual update button for database and rules

Feature description
I would like a manual trigger to update "dati e regole". It would be implemented as a "refresh" button in the "Dati e Regole" box. This would not replace the automatic periodic update, just enhance it.

Problem and motivation
At the moment the update only triggers every once in a while. I get the reason (not overloading servers), but sometimes this can be an issue when certificates have been generated only a few minutes earlier, and the user wants to check the validity via the app.
I got my green pass AUTHCODE at 1:30pm today, and I opened the app to check the downloaded QR code at 1:33pm. It was "invalid". I opened the app on another phone at 1:44pm and it was valid. Despite this, I was unable to trigger an update on the original phone, which kept scanning it as invalid for 15 more minutes.
Now, after 30 minutes, both phones recognize it as valid, due to the first one having updated the "Dati e Regole" database, so that was indeed the issue.
This issue is especially relevant for those that rely on a "48 hour" EUDCC for travel: for instance, many airports offer Covid-19 tests right before departure, and the inability to trigger a database update at will could cause delays at the gates when the EUDCC is checked right after having been generated.

Is this something you're interested in working on
No

Hi
this is a design choice and the reason for this is, as you also declared, avoiding servers overloading
this should not affect DCC QR code validation though. The issue you experienced could be cause by an inconsistent state of VerificaC19 we could investigate on.
However clearing the app cache should solve the issue.


Clean up cocnept-designs/sean

Currently a lot of stuff is in here, and I think some of the important / finalized stuff can be moved to more appropriate places (like intro.html, demos and stuff seem alright there). Also there are some old things that can be removed like interface.html and lernejogolio.html (might wanna save that tho cuz it's cool).

This applies to everything else too, just that this one folder understandably has a lot of stuff


fix(react): unitTestRunner failed when jest

when passing jest as the unitTestRunner there was no
@nrlw/workspace version in paackage.json to base the version off for
@nrwl/jest.
This fixes that by adding a version to the package.json before running
the test and fixing the duplicated test case to catch it

Not sure but does something changes here with the latest version? How does the workspace package is needed as a dep for jest?

Not sure if this is something that has changed in a recent version @DominikPieper.
We were having issues with our own generator tests and looking at the source code in packages/react/src/generators/init/init.spec.ts noticed that there was not a test case for having jest enabled.
Adding that test then saw the same failure we were seeing in our codebase and so I added the fix for the test and a new testcase.
You can see the logic for why the workspace package is needed in packages/react/src/generators/init/lib/add-jest-plugin.ts and packages/react/src/generators/init/lib/util.ts.
The logic seems to be getting the current version of @nrwl/workspace to work out the version of @nrwl/jest to add. In the test file tree, there is no @nrwl/workspace in the package.json

Here I’m not sure if it’s more a problem of the test setup. Cause two things here I don’t like:

@newl/workspace should be automatically there in each workspace, so peerDependency should be enough. For unit tests we should have a closer look.
with this change the @nrwl/workspace is added in a specific version. If the user has a different Nx version then there will be mixed versions what could be lead to problems

I took a look at the areas in code. It should be enough to define the workspace version in the unit test setup for that. No need to add workspace here

So you are saying @nrwl/workspace should be added to the package.json as part of createTreeWithEmptyWorkspace() testing util?

You can just add a working package.json like here: https://github.com/nxext/nx-extensions/blob/main/packages/solid/src/generators/utils/testing.ts That should work

@DominikPieper added a createTestProject testing helper adding @nrwl/workspace to package.json for the react generator and updated the unit tests to use this


unable to find model_web directory

I have followed instructions but I am not able to find model_web directory or TensorFlow.js? can you please help me to find?

Follow this tutorial on how to build a model: https://github.com/cloud-annotations/training/


It only shows the path to the partial

The Template
`

Toggle navigation

Home (current)

Arcade

Arcade
`
The View Being Rendered
{{#extend "frontend"}} {{/extend}}

Not able to tell what you're trying to do or why it's not working based on what you've provided.

Closing due to lack of detail and no response to the request for more. Feel free to re-open if you're still having issues.


Compass example repeatedly initialises IMU

In the compass example, there's a call within the loop to sense.get_compass(), which performs IMU setup. This is probably not a good idea, one of the effects is a huge lag in responding to changes in orientation (because you're not reading nearly fast enough from the underlying IMU FIFO). Better to do sense.get_compass() outside the loop, then use raw magnetometer readings and a bit of geometry to calculate bearing within the loop.

I've noticed a large lag whilst doing compass readings maybe this is the cause

and other option is to just use orientation['raw']


Should we be using the data on postera website?

As shown in the ASAP meeting we should have access to the Postera data (even programmatic access through an API), we already have code that  can help with that in the repo (the postera code in asapdiscovery-data). I just thought I raised the question here for folks, since it seems relevant that we might find using this data useful for our purposes and it seems we could do it in an automated way.

Outdated now.


kmmo: Update OCP version links in readme

Signed-off-by: vbedida79<EMAIL_ADDRESS>

Addressed in #197


Server Database arm64 notarization

Using 3/8/21 build with arm64 support
Applying the tool to a signed v19 built server, its built client and built single user (3 apps)
Single user and Client app OK
Server returns this:
      "path": "ViniMaster_F_Server.dmg/ViniMaster_F Server.app/Contents/Server Database/Libraries/lib4d-arm64.dylib",
      "message": "The binary is not signed with a valid Developer ID certificate.",

      "path": "ViniMaster_F_Server.dmg/ViniMaster_F Server.app/Contents/Server Database/Libraries/lib4d-arm64.dylib",
      "message": "The signature does not include a secure timestamp.",

Looks like Server Database is not processed for arm64 notarization. What should I change/set?
Or is it a 4D build issue?
Thanks in advance
Phil

if you trace the code you'd see that the $signDatabase  option does not look into Server Database.
I've added and pushed the needed changes but I don't have time to test it

It works, thank you.


monitor the data loading time

I am running the imagenet example and found that there is no "data time" as in the original pytorch example.
How to monitor the data loading time?

Also, it's weird that one epoch becomes 5201; it should be 5005.

I think the profiler can do that, if you turn it on in the Trainer.

Also, it's weird that one epoch becomes 5201; it should be 5005.
Are you referring to the progress bar? I think it is because it includes the validation set.

My understanding is the profiler only output the result after training.
Yes. The progress bar,  thanks.

In the profiler you get something like this:
Profiler Report

Action              	|  Mean duration (s)	|  Total time (s)
-----------------------------------------------------------------
on_train_start      	|  0.0            	|  0.0
on_epoch_start      	|  0.0            	|  0.0
get_train_batch     	|  0.5312         	|  2.656
on_batch_start      	|  0.0            	|  0.0
model_forward       	|  0.2186         	|  1.093
model_backward      	|  0.2128         	|  1.064
on_after_backward   	|  0.0            	|  0.0
optimizer_step      	|  0.2124         	|  1.062
on_batch_end        	|  0.0032         	|  0.016
on_epoch_end        	|  0.0            	|  0.0
on_train_end        	|  0.0            	|  0.0

"get_train_batch" is the loading time of the training batch. If you don't want to wait for these stats for the end of training, just run one epoch with max_epochs=1 or a few steps with max_steps=10 by setting these flags in the Trainer.

Btw, here is what I am doing right now:

    def training_step(self, data, batch_idx):
        ...
        data_time = self.trainer.profiler.recorded_durations["get_train_batch"][-1]
        data_time = torch.tensor(data_time)


INVALID_BLOCK when deploying crypto kitties

Block receipt hashes do not match

This turns out to be a regression bug, from our miner timestamp change. Changes are being reverted!


cp: missing file operand

The action is no longer working for me, failing at the Copying files into /tmp/local-repo step:
Copying files into /tmp/local-repo
  Copying ./PKGBUILD
  Copying
  cp: missing file operand
  Try 'cp --help' for more information.

I believe it's because of this line https://github.com/KSXGitHub/github-actions-deploy-aur/blob/master/build.sh#L69 that was newly added

Can you try the new commit to see if there's still any problem?


Inconsistant behaviour of groupby_bins mean when using flox and numbagg

What happened?
When I group an xarray.DataArray in a single group and calculate the mean, then I expect the mean of this group to be the same as the mean of the input data.
When I have flox and numbagg installed next to xarray, I get inconsistant behavoir. The behaviour is consistent again when setting the option "use_flox" to False.
What did you expect to happen?
I expected xarray to give the mean of the values in the group. I expected this mean to be the same with flox as without flox. More specifically, I expected it to be (almost) equal to the numpy.mean.
Minimal Complete Verifiable Example
# in a clean python.org environment:
# pip install xarray, numbagg, flox
import numpy as np
import xarray as xr

def grouped_mean(number):
    # Generate a set of random values
    np.random.seed(0)
    values = np.random.rand(number)
    # Use numpy to calculated the expected mean
    expected = np.mean(values)
    # Create an xarray dataset with coordinates
    data = xr.DataArray(values, [("dim_0", np.arange(number, dtype=float))])
    # Group the coordinates to that all values fall in a single bin
    grouped = data.groupby_bins("dim_0", [-1.0, number + 1.0])

    # Calculated the grouped mean without flox
    xr.core.options.OPTIONS["use_flox"] = False
    result_no_flox = grouped.mean().values[0]

    # Calculate the grouped mean with flox
    xr.core.options.OPTIONS["use_flox"] = True
    result_flox = grouped.mean().values[0]

    # Print the results
    print(f"Try with number = {number}")
    print(expected, "using numpy.mean")
    print(result_no_flox, "grouped.mean no flox")
    print(result_flox, "grouped.mean with flox")

for number in [127, 128, 255, 256, 1000]:
    grouped_mean(number)

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[ ] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.
[x] Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output
Run python test.py
Try with number = 127
0.5000245417623892 using numpy.mean
0.5000245417623892 grouped.mean no flox
0.5000245417623891 grouped.mean with flox
Try with number = 128
0.49847415328514055 using numpy.mean
0.49847415328514055 grouped.mean no flox
-0.49847415328514033 grouped.mean with flox
Try with number = 255
0.4973500025365464 using numpy.mean
0.4973500025365464 grouped.mean no flox
-126.82425064681932 grouped.mean with flox
Try with number = 256
0.4957330979775834 using numpy.mean
0.4957330979775834 grouped.mean no flox
nan grouped.mean with flox
Try with number = 1000
0.49592153437178277 using numpy.mean
0.49592153437178277 grouped.mean no flox
-20.663397265490953 grouped.mean with flox

Anything else we need to know?
This behaviour is only there when installing numbagg and flox next to xarray.
(pip install xarray flox numbagg)
The above mentioned output is from a github action, using linux and windows latest with python 3.11
Environment

Run python -c "import xarray as xr;print(xr.show_versions())"
/opt/hostedtoolcache/Python/3.[11](https://github.com/daanscheltens/test_xarray/actions/runs/7088608658/job/19291471251#step:10:12).6/x64/lib/python3.11/site-packages/_distutils_hack/__init__.py:33: UserWarning: Setuptools is replacing distutils.
  warnings.warn("Setuptools is replacing distutils.")

There does seem to be something wrong with numbagg. To use flox for now, specify engine="numpy" (grouped.mean(engine="numpy"))

Traced down to numbagg: https://github.com/numbagg/numbagg/issues/211

Sorry for this — it's extremely important that numbagg return correct results. I have patched this & released 0.6.5, so will close this issue.
I haven't understood why this happens — the fix is just a workaround. So I'll come back to this later to work through that, and have left https://github.com/numbagg/numbagg/issues/211 open.
As I mentioned in that issue, we do have tests for int8s, but this seems to require a specific size of array to trigger. So possibly we should add some fuzz tests. That might also be a way of giving back to the numba project if we can unearth issues there.
Thanks for the excellent report @daanscheltens . Please direct all blame at me & numbagg, rather than xarray / flox! :)

Sorry for this — it's extremely important that numbagg return correct results. I have patched this & released 0.6.5, so will close this issue.
I haven't understood why this happens — the fix is just a workaround. So I'll come back to this later to work through that, and have left numbagg/numbagg#211 open.
As I mentioned in that issue, we do have tests for int8s, but this seems to require a specific size of array to trigger. So possibly we should add some fuzz tests. That might also be a way of giving back to the numba project if we can unearth issues there.
Thanks for the excellent report @daanscheltens . Please direct all blame at me & numbagg, rather than xarray / flox! :)
To confirm — running pip install numbagg -U or pip install numbagg==0.6.5 will fix this (or the conda equivalent)

Thanks for the quick solution. I tested it on our systems and all tests pass, so this is perfect.


Change FactoryBot/CreateList so that it is not an offense if not repeated multiple times

~This PR is add support cases of offense for FactoryBot/CreateList when create call dees have method call in the argument, but it does not repeat multiple times.~
~In the case of multiple repeats, the following problems were ignored.~
~- https://github.com/rubocop/rubocop-rspec/issues/1087~
~However, if it is not repeated more than once, it is not a problem as an offense.~
This PR is change FactoryBot/CreateList so that it is not an offense if not repeated multiple times.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[-] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

I assume that this change would be useful to autocorrect code like
[create(:user, name: foo)] to create_list(:user, 1, name: foo).
# Original code
[create(:user, name: do_something)]]
# |
# v
# Autocorrected by `FactoryBot/CreateList` (implemented at https://github.com/rubocop/rubocop-factory_bot/pull/31)
1.times.map { create(:user, name: do_something) }
# |
# v
# Autocorrected by `Performance/TimesMap` if enabled
Array.new(1) { create(:user, name: do_something) }
# |
# v
# Autocorrected by `FactoryBot/CreateList`
create_list(:user, 1, name: do_something)

I would like to support the case exactly as @r7kamura mentioned with this PR. Thank you.

Maybe the cop should ignore cases with one item in an array? This would allow to skip all t this correction chain.

The original code is a literal array with a single element is perfectly fine.
Can original code be written as ‘Array.new(1)’ or ‘1.times.map’?
This is unrealistic from my perspective.
If ‘Array.new(1)’ or ‘1.times.map’ is a product from this cop’s correction, we should fix the cop not to change that to ‘1.times.map’.
Does any of this make sense?

Ah Indeed it is, I was a little confused😅
It sure looks like I just need to change it so that it doesn't convert to '1.times.map'.

I updated this PR.


Update radix

Tested up to 62 bytes, I have an application for this and would be thrilled to discuss it with you! Thank you so much for creating a golang FF3-1!!!

@bdw666 would be happy to connect!  I run engineering at Ubiq - please feel free to contact me at<EMAIL_ADDRESS>Our "primary" repo is actually on GitLab and we sync over here to GitHub, so if you're okay with it, I'd like to replicate your PR here https://gitlab.com/ubiqsecurity/ubiq-fpe-go to get it reviewed

It looks like this change is possible because the math/big package has (added) support for larger radixes. Is there any reason that the same change won't work for FF3-1 as well? If not, there is no reason for the new interfaces. We can just update the maximum allowed value at line 37 of ffx.go.


how to get value of ''c

lib:
int GetPeoleName(char *strTemp,int *strLen)
javascript:
var card = ffi.Library('term',{
       'GetPeopleName':['int',['string',ref.refType('int')]]
});

how to pass the value and then get a return value  in javascript?this is my code,it not works:
buf.type = ref.types.char;
var len = ref.alloc('int');
card.GetPeopleName(buf,len);
console.log(buf.toString())

No promises or warranty, but I think I have a solution 😃.  Use ref.types.CString as the type and allocate a buffer for the native code to populate. Consider using the length parameter as an input to tell the native code how large of a name can fit. And if the name doesn't fit, return an error code. Setting length of the output is useless, as CString must be NUL terminated -- the readCString() methods go until NUL, even beyond the bounds of the buffer! If that makes sense, then the length can become a regular ref.types.int and not a ref to it.
const ref = require('ref');
const ffi = require('ffi');
const path = require('path');

const int = ref.types.int;
const intPtr = ref.refType(int);
const cstring = ref.types.CString;

const myLib = ffi.Library(path.join(__dirname, 'myLib'), {
  GetName: [ int, [ cstring, intPtr]]
});

const outNameBuffer = new Buffer(250);
const outNumber = ref.alloc(int);
myLib.GetName(outNameBuffer, outNumber);
console.log(ref.readCString(outNameBuffer));
console.log(outNumber.deref());

And remember on the native side to use strcpy or similar because you can't reassign the pointer.


Enhance generate_static_provisioning_yamls.sh script based on the new volumehandle definition

Is your feature request related to a problem? Please describe.
Enhance generate_static_provisioning_yamls.sh based on the new volumehandle type for new storageclass
Describe the solution you'd like
Improve generate_static_provisioning_yamls.sh
Describe alternatives you've considered
NA
Additional context
NA

verified

@Jainbrt please close this defect


"Enable Rating Filter" breaks /uploader/ pages

What you see on https://e-hentai.org/uploader/WindyNii:

What you will see after you enable "Enable Rating Filter" and reload page (you are redirected to https://e-hentai.org/?f_search=WindyNii&advsearch=1&f_srdd=2):

What happens if you manually set minimum rating without enabling "Enable Rating Filter" and press search (you will be redirected to https://e-hentai.org/?f_search=uploader%3AWindyNii&tag_name_bar=[{"key"%3A"uploader%3AWindyNii"%2C"value"%3A"uploader%3AWindyNii"%2C"editable"%3Afalse}]&advsearch=1&f_srdd=2):

Thanks for reporting.
I will try to fix it after next Wednesday.

Hi @soredake,
Is "Enable Rating Filter" a function of e-hentai itself?
I have never used it before.
Also, there are no such function exist in my script.

Is "Enable Rating Filter" a function of e-hentai itself?

It's from your script:

No, that's not my script.
Filtering things is not what my script do.
This is the settings of my script:


kubelet complaining: Nameserver limits exceeded

We're seeing this log line serveal times from the kubelet service:
Nov 16 21:02:17 control-0 kubelet[7914]: {"ts":1700168537196.4094,"caller":"dns/dns.go:153","msg":"Nameserver limits exceeded","err":"Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>"}
``

It looks like we've added **<IP_ADDRESS>** twice to the config.

info: https://stackoverflow.com/questions/72382966/rancher-node-nameserver-limits-were-exceeded-some-nameservers-have-been-omitte


Adding feedback to improve some lab steps

@ibonilm,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


custom layout inflation error

Caused by: java.lang.ClassCastException: android.support.v7.widget.AppCompatTextView cannot be cast to android.widget.EditText
Probably you this is the cause?

I found that when using androidx I too got an inflation error on the custom layout when it tried to cast TextView to an EditText.  I was able to fix the situation by replacing the TextView tag in the sample number_picker_custom_layout code with an EditText tag.

@traviju: Can you please include bluefirepatrick's solution in your readme. It saves a lot of searching and time!


Local + Local Control

Dear Authors,
How do you perform local + local operation can you tell this?

For technical details, please refer to our paper https://arxiv.org/abs/2305.16322.

Dear ShihaoZhaoZSH/Uni-ControlNet,
Your paper just mention that you compose local + local controls. But no
details are provided.
On Sat, 17 Jun 2023, 7:47 pm ShihaoZhaoZSH, @.***>
wrote:

For technical details, please refer to our paper
https://arxiv.org/abs/2305.16322.
—
Reply to this email directly, view it on GitHub
https://github.com/ShihaoZhaoZSH/Uni-ControlNet/issues/11#issuecomment-1595816217,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV4VZBFL3MSLK6XMYYYPOHLXLXURPANCNFSM6AAAAAAZDGV544
.
You are receiving this because you authored the thread.Message ID:
@.***>

In Section 3.2, Control Adapter - Local Control Adapter, we explained that we concatenate different local conditions along the channel dimension. This means that you can place different local conditions at their corresponding channels to achieve the composed control by different local conditions. Our code also demonstrates this implementation.

Thanks alot.
On Sun, 18 Jun 2023, 3:05 am ShihaoZhaoZSH, @.***>
wrote:

In Section 3.2, Control Adapter - Local Control Adapter, we explained that
we concatenate different local conditions along the channel dimension. This
means that you can place different local conditions at their corresponding
channels to achieve the composed control by different local conditions. Our
code also demonstrates this implementation.
—
Reply to this email directly, view it on GitHub
https://github.com/ShihaoZhaoZSH/Uni-ControlNet/issues/11#issuecomment-1595914186,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV4VZBBSG3GX62WJAFB57LLXLZH6NANCNFSM6AAAAAAZDGV544
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add number of scrobbles

As a enhancement I would recommend this for any future improvements you might want to do.
The app's cool though, so thank you. 😄

Glad you like it :)
I think I'll add this to the extended info display. It'll either be its own text, or mouseover text for the Last.fm username that's already there. I'd lean toward mouseover text, but that may not be ideal since the user isn't really meant to interact with the app regularly. I'll see which looks/behaves better.


Nix flake config and package for nix

Ocamlscript looks like it would be incredibly useful for a nixos user.
If ocamlscript is intended to eventually be built with dune, I could help out once that is done by adding a flake.nix to add an easy installation option (including spawning a shell that temporarily has the git master version of ocamlscript and cleans  up & removes it once you are done).

look at this PR and try to unlock it https://github.com/ocaml-community/ocamlscript/pull/13

This being said, ocamlscript is a fairly complex piece of software which is not actively maintained.
You might have more luck trying to use a similar tool made by Daniel Bunzli.

@dbuenzli what is the name of your ocamlscript clone?

It's b0caml but I'm afraid it's not ready for general consumption.


Add integration tests ...

... that execute a trajectory on a simulated robot.
This builds upon #32 and needs to be rebased at some point.
Problems shown at this point:

The UR5 seems to be shaky in gazebo causing the trajectory test to fail (all distros)

This affects #37

I've marked this ready for review, though it needs https://github.com/UniversalRobots/Universal_Robots_ROS2_Description/pull/127 to be merged in order for the tests being able to succeed.

Closing this since Gazebo classic is no longer supported on Rolling / Jazzy


Split Geometry singleton into Geometry2D and Geometry3D

Closes godotengine/godot-proposals#640.
I had nothing to do so I made this PR. I hope the benefits are obvious. 🙂
My method:

Duplicate geometry.cpp/h to 2D and 3D.
Remove methods not belonging to either of those files.
Same for documentation.
Remove extra suffixes.

So no copy pasting involved for the most part.
I've tried to disable the compilation of Geometry3D altogether to reduce the export templates sizes but it has dependency in RenderingServer currently.
I've already made some similar naming conventions in my dedicated geometry module: GeometryTools, and I invite you to do the same.

Closing this for now due to the same reasons as in https://github.com/godotengine/godot/pull/35929#issuecomment-634566288.

You can keep it open too. It's not because we have more chances to refuse a PR when a proposal wasn't discussed before that it cannot be merged at all.

Well yeah I closed this specifically because this kind of rewrite should probably be done by @reduz himself, not to mention that I could mess up the code (unintentionally 😄).
@reduz is free to take this PR though.
Given that GitHub has a nice feature to reopen closed PRs, it kinda makes sense.
I wonder if any of members can reopen PRs closed by the author himself. If so, feel free to reopen this any moment. 🙂

IMO this didn't need to be closed, as I already gave positive feedback on the proposal, and it's mostly a matter of asking @reduz what he thinks of it on IRC - which I assume would also be an OK, unless there is a strong reason to keep everything in Geometry.
But yes, I guess it can be reopened once the proposal has been reviewed. But per se it's not wrong to open a PR to support a pre-existing and non rejected proposal.

This sounds pretty cool

Could you amend the commit "Split documentation" to be more explicit? (e.g. "Split Geometry documentation in two singletons").
Or alternatively, squash commits into one.

Probably better to squash all then, because the last commit includes documentation fixes as well.

Thanks!


Fails to build due to: libkimera_semantics_ros undefined reference to cv::String::deallocate()

Fails to build with the above error on Ubuntu 20.04 when following the instructions in the README.
The kimera_semantics_ros library seems to be missing linking against OpenCV.
I added the following lines, which link against the same opencv3_catkin package used in Kimera-VIO-ROS (https://github.com/MIT-SPARK/Kimera-VIO-ROS/blob/master/install/kimera_vio_ros_https.rosinstall):
find_package(opencv3_catkin REQUIRED)

target_link_libraries(${PROJECT_NAME} ${opencv3_catkin_LIBRARIES})

After these lines were added, the ROS stack successfully builds with Noetic on Ubuntu 20.04.

thank you, your note about building on Ubuntu 20.04 is really helpful.


Pin all application requirements in requirements.txt

The list of top-level dependencies is moved to reqirements-app.txt which is used to by make compile-requirements to generate the full list of requirements in requirements.txt.
requirements_for_test and releated make step are renamed to requirements-dev to reflect the fact that it should contain any dependencies that aren't used by the app itself including dependencies for tests, utility scripts and dev tools.
Rationale
We've had a number of issues caused by unpinned dependencies (eg alphagov/digitalmarketplace-api#607). They can cause things to fail at different stages depending on the root cause, but generally highlight a few problems with our current approach:

The latest version of unpinned packages are installed, so whenever there's a breaking change in a new package release we're forced to either update our code or pin the package alongside our top-level application dependencies.
pip install is run at different times. Eg Travis CI will install dependencies on each test run but our image builds will only run it if requirements.txt have changed. This means that libraries we're running the tests with could be different from libraries that are used by the deployed application.
Finding out which library release broke the build is hard because there's no easily available list of "known-good" versions. These could be extracted from the previous application container versions, but the process isn't documented.

The common solution to this is to ship a full list of pinned dependencies.
There are currently 3 ways to do this in Python:

Generating a requirements.txt file with pip freeze. This stores the full list of currently installed packages.
Using pip-tools to generate a full list of required packages from a list of top-level dependencies. pip-tools also provides utilities to upgrade package versions without modifying the files manually.
Defining dependencies in a Pipfile and using pipenv to manage pinned versions and the virtualenv.

Pipfile seems to be the planned replacement for requirements files, however the tools appear to have some issues when applied to our repos. For example, pipenv doesn't appear to be locking dependencies of the VCS packages (eg utils and apiclient). It also doesn't detect non-semver package versions correctly (eg functools32==3.2.3.post2). We could fix the VCS dependencies issue by publishing our packages on PyPI, but my feeling is the tools aren't ready for production just yet.
pip-tools appears to be more commonly used at the moment. It works by examining setup.py files of packages listed in requirements.in file and generating a full list of dependencies in requirements.txt. The main issue with pip-tools when applied to our current applications is that it's stricter than pip in resolving version conflicts. Some of the packages we depend on are locking the libraries we use directly in their own setup.py (eg mandrill requires docopt==0.4, while we
generally use 0.6.2). While pip would install the latest package version despite the conflict, pip-tools requires us to resolve the conflict, which in this case means relying on a fork of mandrill client.
And pip's behaviour in this case isn't really a problem for us, since docopt isn't used when mandrill is loaded as a module.
pip freeze is the simplest approach that doesn't require any additional tools, however it also isn't very usably without additional tooling. The main problems with using pip freeze directly is that it
will save whatever is installed in the current virtualenv including the test packages and packages that have been installed manually and that it loses VCS packages, only storing the names. This is solved by wrapping pip freeze with a make compile-requirements step that:

Creates a temporary virtualenv.
Installs application requirements.
Runs pip freeze to get a full list of installed packages.
Modifies pip freeze output to maintain the list of application dependencies in the original format.

The benefits of this approach is that it keeps the existing process of running pip install -r requirements.txt for application builds. It also requires only one command to be run whenever application dependencies change to regenerate requirements.txt.
The known downsides and unsolved problems:

You need to remember to run make compile-requirements after changing requirements-app.txt
Since the virtualenv is rebuilt from the application requirements it will still install newer versions of all unpinned packages. The difference is that the process is explicit and changes will be visible in the requirements.txt diff. This allows us to either accept the new package version or ignore it by discarding the change. This does mean that if there's a package we want to hold back we'll need to do this repeatedly after each requirements-app.txt change. The benefit of this approach is that it makes us aware of new package versions.

Another major point is that development requirements don't go through the same process but are now loading the full list of application dependencies. This in turn means that:

requirements-dev.txt can't list any of the packages present in requirements.txt since pip will complain about a duplicate record. We can either rely on the record in requirements.txt in this case or move the dependency to requirements-app.txt
While it's not possible for one of the dev requirements to override the application dependencies (pip's resolver prioritises the top-level dependency version) they do install additional packages that aren't present in the application deployment container. This is unchanged from the existing process but could potentially hide issues that are only discovered once the app has been deployed.

Well damn, one of us is going to have to rebase
I think the choice of the word "compile" here is a slightly confusing collision with the fact that some of the dependencies do need to be compiled and I initially assumed the new command was for doing that. I think "generate-requirements" would do fine. Or even freeze-requirements.

@risicle I'll keep this open for a bit to give people a chance to give feedback.

Yeah, the naming is generally inconsistent across tools. pip-tools calls it "compile", pipenv - "lock" and pip itself uses "freeze". I'm happy with "freeze-requirements" as it's pretty unambiguous and close to what it actually does.
Yep. I didn't want to make a big deal out of it by changing everything, but we do tend to use dashes in scripts so it feels like make targets should use a similar convention. But maybe that's the wrong approach here. I'm happy to either rename all steps or keep the new ones with underscores if people think it'd be better.

Meh please everyone and put aliases in.

If I were feeling really crazy I'd hypothesize that this freeze-requirements command would be a good place to run pypi2nix if people decided they liked that tool.

We could have a comment at the top of requirements-app.txt to remind people to run the make freeze thing if they update the file?

I've changed the comments in requirements.txt and requirements-app.txt so that they hopefully make sense when the files are joined. I've also added a test-requirements target to check that the files match up and have renamed other make targets to consistently use dashes instead of underscores.
Since there don't seem to be any major objections, I'm going to merge this and will make PRs for other apps. Thanks everyone!

Yeah I think this is a positive.


Make GitHub Pages

What is the github pages for?

To make it cool and D I S R U P T I V E

I can't believe you made an issue and then didn't invite the web designer

Not necessary for now, closing


[FIX] idp: always fetch metadata from URL without cache

This pull request objective is to remove the ETS cache table when fetching metadata from IDP.
It is usually done once (at application startup) and if it is done later, it is done to refresh metadata; not fetching the cache. The cache optimization does not seem necessary.
When the IDP changes the metadata file frequently (upon certificates rollup for instance); hard refreshing the metadata is required.

No activity on this PR, closing


Can we use GPT3.5 turbo here?

Since GPT4 is not available for everyone.

Yes, should be slightly less smart but def works


Create Speeder1.netkan

Failed with "no identified problem" :/

See this issue https://github.com/KSP-CKAN/CKAN-support/issues/107

#rebuild


fix: Multiple buttons not rendered in mso

Introduced in #61 the author forgot to also handle this case for mso.
"MSO" clients:

"Normal" clients:

Hi @Guergeiro,
Thanks so much for your contribution and for resolving this issue.
Merged & published to npm in 2.0.25.


Copilot Chat - use opened tabs as context

So before Copilot Chat, i've been working with co pilot and GPT interchangeably,
for auto completes and no brainer issues I let co pilot deal with, and where I need to solve something more complex, or get some inspiration I turn to the good ol` chat, I usually inject a bunch of code in it and work my way up to a solution
When the Copilot Chat was released, I was under the impression that since it already resides in your code space,
it could just read your files and use them as context, so when you ask a question it would know the project, or parts of it, for example if I ask it "join table X with table Y where Z" it would already know the structure of those tables and yield some query
Because currently in this version I find myself developing the same way I've been so far,
copying and pasting code into the chat, so it seem to just save a tab switch, while it could be so much more
Am I missing anything? is this type of feature planned?

Version: 1.79.0-insider (user setup)
Commit: 2946b1ee55db1d406526d3fd1df49250b2f8322d
Date: 2023-05-18T05:25:02.319Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
GitHub Copilot Chat v0.1.2023051801
When I received the Copilot Chat beta access, the first thing I did was to try to generate some unit tests for a Typescript pure function.
This was the simplest test I could think of. I have two files:
model.ts contains:
export type RelationalOperator = 'None' | 'GT' | 'GE' | 'EQ' | 'NE' | 'LT' | 'LE' | 'BT';

export type BooleanOperator = 'Or' | 'And' | 'Not';

export interface Item {
    id: number;
    name: string;
    order: number;
    creator: string;
    creationDate: string;
    relationship: BooleanOperator;
    countLower: number | null;
    countUpper: number | null;
    countRelation: RelationalOperator;
}

and utils.ts contains:
import { Item } from './model';

export function descriptionText(item: Item) {
    if (item.countRelation === 'None') {
        return '';
    }

    if (item.countRelation === 'EQ') {
        return `(matching exactly ${item.countLower} of the criteria)`;
    }

    if (item.countRelation === 'GT') {
        return `(matching more than ${item.countLower} of the criteria)`;
    }

    if (item.countRelation === 'LT') {
        return `(matching fewer than ${item.countLower} of the criteria)`;
    }

    if (item.countRelation === 'BT') {
        return `(matching between ${item.countLower} and ${item.countUpper} of the criteria)`;
    }

    return '';
}

So I opened both files in VSCode, selected the code for the function and asked Copilot Chat to write unit tests.
It generated a set of tests that would not compile because the required properties were not set e.g.:
import { Item } from './model';
import { descriptionText } from './utils';

describe('descriptionText', () => {
  it('should return an empty string when countRelation is None', () => {
    const item: Item = {
      countRelation: 'None',
    };
    expect(descriptionText(item)).toBe('');
  });

  // etc...
});

I then asked it for definition of the Item interface:

So it knows that the Item interface is defined in model.ts but it gives the wrong definition - even though that file is open in the editor.
The only way I could get Copilot Chat to generate a valid set of tests was to paste all of the code into the chat.
It then generated some correct tests, but when I asked it to simplify those tests it reverted back to generating a set of tests like the first ones which would not compile.
I tried ChatGPT4 with the same problem - by pasting all of the code into the chat, and it generated some working tests.
I then asked ChatGPT4 to optimize those test, and it did it correctly.
I was expecting Copilot Chat to perform like ChatGPT4 but with the added benefit that it could use my source files as context.
But so far I have had to paste all of the code into the chat section, and it has produce answers which are not a good as using ChatGPT4.
As a final test a explicitly asked Copilot Chat if it could read my source code files, and to show me the definition of the Item interface:

I have no idea where it got its answer - but it was not from my code.
Maybe I have missed the point here?
Can anyone answer the following:

Does Copilot Chat use the GPT-3 or GTP-4 model, or something else?
Can Copilot Chat really read my source files?

Can Copilot Chat really read my source files?

It can only read what you have highlighted, and if you highlight too much it doesn't take it into account from what I've experienced.

Could be a user "error" onn my part but I didn't have anything highlighted, discussed with the chat and it "read" my code and reproduced it as an output with the same variables etc. it was mildly infuriating.

There is supposed to be an @editor function now, but it doesn't work.

You can use #file multiple times though.

Still double imports though...

I was in the middle of submitting a bug for vs-code copilot plug-in, and it popped up with this previous bug as a suggestion.
I'm trying to get Frigate running on my Kubernetes cluster.  I have the Frigate yaml in one tab in vs-code, and the frigate config.yml in another tab. I need to work across both of them to get a working solution, and just assumed the GitHub copilot plug-in would be reading all files in my workspace as the context. But it seems to only be reading the current active tab. I then opened the chat as it's own tab, and tried in there, but it was still only reading the last file I was working on.
It feels like an obvious thing that should be baked in by default, right? and the fact it's been called out since 2023 and it's almost 2025 and still not there is concerning.


fix(build): missing build of tokens/global.json

🔗 Linked issue
resolves https://github.com/six7/figma-tokens-example-tailwindcss/issues/10
📚 Description
I added build-transform-global in package.json

Nice, thank you! 🎉


Add Testplatform 2017 support for DTA task

[x]  Currently works with installation of TA 2015/2017/Vs 2017/Vs 2015

[x]  Acquisition of TA 2015 works,

[x]  Shipping the Deploy SDK

[ ] Acuqisition of 2017 support needs to be added

[ ] Pending log dumping and clearing

[ ] UI revamp/breaking v2 changes pending

:shipit:


Theme attribute doesn't propagate to the sub-menus / items

Theme attribute on the host element should propagate to the sub-menus / items so they can be exclusively styled.

Fixed by #68


Error unpacking mediaInfo ARM64

I get this error:
7-Zip 22.00 (x64) : Copyright (c) 1999-2022 Igor Pavlov : 2022-06-15

Scanning the drive for archives:
1 file, 2016596 bytes (1970 KiB)

Extracting archive: E:\Desktop\mediainfo-aarch64-git-6579441.7z
--
Path = E:\Desktop\mediainfo-aarch64-git-6579441.7z
Type = 7z
Physical Size = 2016596
Headers Size = 269
Method = 0A LZMA2:12m LZMA:20 BCJ2
Solid = +
Blocks = 2

ERROR: Unsupported Method : mediainfo.exe
ERROR: Unsupported Method : mimalloc-override.dll

Sub items Errors: 2

Archives with Errors: 1

Sub items Errors: 2

Error: Exit code 2

It happens also with mpv:
7-Zip 22.00 (x64) : Copyright (c) 1999-2022 Igor Pavlov : 2022-06-15

Scanning the drive for archives:
1 file, 27631862 bytes (27 MiB)

Extracting archive: E:\Desktop\mpv-aarch64-20240717-git-6739503.7z
--
Path = E:\Desktop\mpv-aarch64-20240717-git-6739503.7z
Type = 7z
Physical Size = 27631862
Headers Size = 390
Method = 0A LZMA2:26
Solid = +
Blocks = 2

ERROR: Unsupported Method : mpv.com
ERROR: Unsupported Method : mpv.exe

Sub items Errors: 2

Archives with Errors: 1

Sub items Errors: 2

Error: Exit code 2

Thanks. With newer 7zip version, it unpacks fine.
With zhongfly the old 7zip version works.


Printer methods do not accept null port

According to comments in index.d.ts I should be able to call print methods, openCashDrawer, and checkStatus passing null for the port to use a printer I've already connected to via connect. However these methods specifically expect only a string, causing potentially-null values to throw an exception during compilation in strictly-typed applications.
I'm opening this issue for record keeping, but I'll be setting up a PR today to address the issue by changing the type from string to string|null.

... I opened this on the wrong repository. I meant to do so on @awesome-cordova-plugins/star-prnt. Sorry for the mistake.


added poetry pre-commit hook

This should be fixed :)

Thanks for spotting this! The second yml file in the root folder shouldn't have been there, I'll remove it now and commit.
I was thinking of just merging the two PRs separately to main - there shouldn't be merge conflicts, and if there are, would probably be easily solved. But I never done a branch rebase, so I'd like to try your suggested solution :)


[W.I.P.] Design Proposal for OOKCluster and Profiles

This patch is an proposal to define OOKCluster and Profiles custom
resources for OpenStack cluster management in KupenStack.
Signed-off-by: Parth<EMAIL_ADDRESS>

/lgtm


Make sure attributes/styles of clicked points reset.

Point fill not behaving correctly when toggling between 'by visit' and 'max' views.


Playing soundtrack doesn't seem to work.

When an echo has been created, I can't re-play the soundtrack to validate that the transcription is correct.
Here is a recording.
https://user-images.githubusercontent.com/12861981/198301029-cdfe8b26-1c4b-4362-a18f-4832e554f630.mov

@tchaton Are you able to reproduce this reliably? Also, can you provide the following info:

Browser
Operating System
Mobile/Desktop

@tchaton Are you still able to reproduce this issue?

I'm going to close this issue as not reproducible.


Piping special keys to Stdin doesn't seem to transfer properly

I noticed this behavior when I use such things as MidnightCommand (mc). I can't navigate around using arrow keys and I can't use any Function keys.
Is there a simple fix to this that I'm missing?

My mistake. It is working when use your example from the readme versus my bastardized version. My apologies.


Add support for bitnami/sealed-secrets

The unsealing key should use the CA interface (encrypted private key + password) to enable the sealing key to be stored in Vault in the future.

Closed by #181


Is "beNil" working?

I recently wrote some code like this:
it(@"Testing", ^{
		NSString *x;
		expect(x).notTo.beNil;
		expect(x).toNot.beNil;
		expect(x).to.beNil;
		x = @"test";
		expect(x).notTo.beNil;
		expect(x).toNot.beNil;
		expect(x).to.beNil;
});

and my tests pass with success.

You want to be using beNil()- you're making a reference to the function, not calling it.


fix: format test otps

What kind of change does this PR introduce?

Apply basic formatting on test OTPs when config is loaded
Fixes #1566

What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 7 (14.29%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 65.704%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/conf/configuration.go
1
7
14.29%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
8209

Relevant Lines:
12494

💛  - Coveralls

Maybe some better validation is necessary though...

@hf this applies the same formatting we perform on phone numbers for other endpoints - i didn't want to apply the E.164 validation because it didn't want it to fail when the config loads


wrong type inference in Promise

TypeScript Version:  3.4.3

Search Terms:
Code
let foo: string | undefined;
if (!foo) foo = 'hello';

foo.length; // ok

new Promise(resolve => resolve(foo.length));
//                              ^ should be string, but inferred as string | undefined

Expected behavior:
Actual behavior:
Playground Link:
Related Issues:

No, that is not ok: foo.length -> [Object is possibly 'undefined']

@GongT You mean the 3rd line? There is no error in the playground, with all optional checks enabled.

Most likely, related to #9998.

Yep, see #9998 - we cutoff control flow analysis on function boundaries (mostly), so foo only has it's declared type within the Promise callback. If you capture the narrowed value with a const before the callback is made, that'll capture the narrowed value.

@lll000111

we cutoff control flow analysis on function boundaries (mostly)

Which makes perfect sense, because in general the compiler can't know when a function will be called--or even how many times.  In the specific case of Promise we know the function will be called only once, and immediately--but this isn't an assumption the compiler can make in the general case.

let foo: string | undefined;
if (!foo) foo = 'hello';

new Promise(resolve => resolve(foo!.length));

ok,It seems that it is the correct solution


⚠ Bofrost.at has degraded performance

In 27233ec, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1959 ms

Resolved: Bofrost.at performance has improved in d2da788 after 310 days, 8 hours, 36 minutes.


tests aren't running in the browser when using custom boot_partial

Hi
I'm currently trying to run the tests in the browser and use a custom boot_partial
In my teaspoon_env.rb I've set:
  config.fixture_paths = ["spec/javascripts/fixtures"]
  suite.boot_partial = "/boot"

And I have spec/javascripts/fixtures/_boot.html.erb which contains one javascript_include_tag
When I run rails s and visit localhost:3000/teaspoon/default, nothing is rendered. The javascript file is loaded though.
Am I not supposed to be able to see the tests results as I normally would without the boot_partial?
Any help is appreciated. Thank you :)

I can't tell without seeing it, so try and base your boot partial off the one in the gem. Load that, see what's loaded, make a small adjustment, see if it works, etc.. my guess is that you're not telling teaspoon to execute though.

Ah Thank you!


Add traces to debug_traceCall and debug_traceTransaction

Agree, but I think a potential slowdown in the debug_ methods is acceptable, at least for now.


[SPARK-16983][SQL] Add prettyName for row_number, dense_rank, percent_rank, cume_dist

What changes were proposed in this pull request?
Currently, two-word window functions like row_number, dense_rank, percent_rank, and cume_dist are expressed without _ in error messages. We had better show the correct names.
Before
scala> sql("select row_number()").show
java.lang.UnsupportedOperationException: Cannot evaluate expression: rownumber()

After
scala> sql("select row_number()").show
java.lang.UnsupportedOperationException: Cannot evaluate expression: row_number()

How was this patch tested?
Pass the Jenkins and manual.

Test build #63477 has started for PR 14571 at commit 2c875dc.

Test build #63477 has finished for PR 14571 at commit 2c875dc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63477/
Test PASSed.

Test build #63499 has started for PR 14571 at commit aadb419.

Oh, @rxin . It will break LogicalPlanToSQLSuite since the upper case function names like ROW_NUMBER is changed into row_number. I need to update LogicalPlanToSQLSuite, too. I will update them, too.

Hm, interesting. Sorry, @rxin. I missed that the window functions need to hide their children. The default behavior should be overrided. I'll revert the last commit. Please refer the following.
[-DENSE_RANK()-]{+dense_rank(`gen_attr_0`, `gen_attr_1`)+}

Finally,

Add prettyName and remove sql for row_number and cume_dist.
Add prettyName for dense_rank and percent_rank.
LogicalPlanToSQLSuite does not changed.

Test build #63502 has started for PR 14571 at commit 0858a13.

Test build #63499 has finished for PR 14571 at commit aadb419.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63499/
Test FAILed.

Test build #63502 has finished for PR 14571 at commit 0858a13.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63502/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @rxin .
It's ready for review again.

Test build #63628 has started for PR 14571 at commit 7533000.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63628/
Test PASSed.

Do you think you can create a test file for window functions in the new SQLQueryTestSuite along with this fix?

Oh, I think you are working on that transition somewhere else.
BTW, what about other tests? If you have a plan to enrich SQLQueryTestSuite, I prefer to do all of them in a single PR during this weekend. How do you think about making a single JIRA for that transition?

If window_function.sql is the only one left or you want to do that gradually, I will include that here today.

We can probably start with that one and then expand it if necessary.

I see. Then, I'll include only that today.

Hi, @rxin . The target suite will be WindowQuerySuite, I'll move all and remove that testsuite.

Test build #63660 has started for PR 14571 at commit 14339ae.

Hi, @rxin .
I added test files for window functions for SQLQueryTestSuite and removed the old WindowQuerySuite.scala. Could you review this again?

Test build #63660 has finished for PR 14571 at commit 14339ae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63660/
Test PASSed.

THanks - it's a great 1st step to move the test case. That said, do you think you can simplify the test data? It is currently very verbose. It'd be better if it is something much simpler and easier to tell if the result is the correct one or not.

In that case, I'm wondering if we are able to delete WindowQuerySuite.scala safely here.

https://github.com/petermaxlee/spark/blob/76defceb9fbaf13ca522da750d92eeb5f7799472/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L227
Instead of creating a table in this .sql file, you can load it. Then, the other test cases can share it.

Hi, @gatorsmile . Thank you for review!
BTW, I'm worrying if we are trying to keep two different things into one PR.
I had better make a new Jira issue for the @rxin 's request.

I felt that we need more decision points to improve window_function.sql. So, I made another jira and PR for that, https://github.com/apache/spark/pull/14623 for SPARK-17044 . I will improve window function test there.

Test build #63701 has started for PR 14571 at commit 6ece3b1.

Test build #63701 has finished for PR 14571 at commit 6ece3b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63701/
Test PASSed.

Test build #63758 has started for PR 14571 at commit 5f298e5.

Test build #63758 has finished for PR 14571 at commit 5f298e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63758/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @rxin .
After splitting window functions PR, is there any thing to do more for this prettyName PR?

Test build #63987 has started for PR 14571 at commit 3184424.

Hi, @rxin .
Could you review this PR again?

Test build #63987 has finished for PR 14571 at commit 3184424.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63987/
Test PASSed.

Merged build finished. Test PASSed.

Test build #64130 has started for PR 14571 at commit 27b419a.

Test build #64130 has finished for PR 14571 at commit 27b419a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64130/
Test PASSed.

Merged build finished. Test PASSed.

Test build #64355 has started for PR 14571 at commit 5446a05.

Test build #64364 has started for PR 14571 at commit 64440c7.

LGTM - pending jenkins.

Thank you always, @hvanhovell !

Test build #64355 has finished for PR 14571 at commit 5446a05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64355/
Test PASSed.

Test build #64364 has finished for PR 14571 at commit 64440c7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merging to master. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64364/
Test PASSed.

Thank you for merging, @hvanhovell !


Occasional Crash during startup

I've been adding new Windows 10 machine to the cluster, and occasionally SyncTrayzor would crash during startup with the following message:
Version: <IP_ADDRESS>; Variant: Installed; Arch: Amd64
Path: C:\Program Files\SyncTrayzor\SyncTrayzor.exe
System.NullReferenceException: Object reference not set to an instance of an object.
   at SyncTrayzor.Syncthing.SyncthingManager.<LoadStartupDataAsync>d__130.MoveNext() in C:\projects\synctrayzor\src\SyncTrayzor\Syncthing\SyncthingManager.cs:line 467
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at SyncTrayzor.Syncthing.SyncthingManager.<StartClientAsync>d__124.MoveNext() in C:\projects\synctrayzor\src\SyncTrayzor\Syncthing\SyncthingManager.cs:line 361
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at SyncTrayzor.Syncthing.SyncthingManager.<StartAsync>d__114.MoveNext() in C:\projects\synctrayzor\src\SyncTrayzor\Syncthing\SyncthingManager.cs:line 189
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at SyncTrayzor.Utils.SafeSyncthingExtensions.<StartWithErrorDialogAsync>d__0.MoveNext() in C:\projects\synctrayzor\src\SyncTrayzor\Utils\SafeSyncthingExtensions.cs:line 17
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at SyncTrayzor.Pages.ShellViewModel.<Start>d__39.MoveNext() in C:\projects\synctrayzor\src\SyncTrayzor\Pages\ShellViewModel.cs:line 89
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__6_0(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Duplicate of #231.
Good to see that it's still around though - I'll get that new release (with the required logging) out soon....

Oh, ok then, I'll close this one


Unblocked Fibers

This is a feature of Ruby 3.0 where a Fiber can mark itself as being blocked, notify a scheduler of this information, and let the scheduler change the execution to a different fiber. Given that we currently have Fibers but no Threads, this is probably the easiest way into getting some form of concurrency into Natalie.
I found some example scripts on https://blog.monotone.dev/ruby/2020/12/25/ruby-3-fiber.html and I want those to work with Natalie.
This does require the following steps:

[x] Add blocking status to Fiber (#1166)
[x] Add a possibility to get and set the Fiber scheduler (#1183)
[ ] Get the kernel_sleep example to work. This requires at least updates to the sleep method to make the callback
[ ] Get the io_wait example to work
[ ] Get the block/unblock example to work. This probably requires some more primitives in the code, like Mutex and Queue

@herwinw I need to contact you via email if possible. Can you email me at<EMAIL_ADDRESS>


Remove unnecessary surrogates attached to double quotes

Hello, thank you for the wonderful library.
I found unnecessary surrogates, so I removed them.

thanks for spotting it !
I thought about where it came from and I think it's my Arabic keyboard which gets enabled by mistake sometimes 😅 "َُِ


File Name of the script execution

Hi, all
How to get the name of the file  or full path where the snippet runs?

https://github.com/L3MON4D3/LuaSnip/blob/master/DOC.md#variables has some examples for this, you'll want TM_FILENAME.


Run spoom bump as part of CI

This change should block a PR that doesn't have the appropriate type strictness level set on a file.

I am not sure why it is trying to bump bundler/helpers/v1/run.rb from true to strict when it clearly doesn't meet the requirements.

I worked around it by removing
def output(obj)
  print JSON.dump(obj)
end

and just inlining it instead. It's a workaround, but IMO a small and acceptable one.


Could you please provide the detailed requirement.txt of your environment?

I don't know the version of packages, which gave me a lot of trouble when setting up the environment.

Hi!
Could you follow the Setup section in the Readme? We also list the related package info here:
https://github.com/opendilab/LMDrive/blob/main/environment.yml
https://github.com/opendilab/LMDrive/blob/main/LAVIS/requirements.txt
https://github.com/opendilab/LMDrive/blob/main/vision_encoder/requirements.txt

Thanks.
This file is useful to solve my problem : https://github.com/opendilab/LMDrive/blob/main/environment.yml


Correctly detect and handle undefined/null in action calls

Fixes a regression introduced in pull request #132 where passing null/undefined as an argument causes an exception to be thrown.
Additional test case has been added.

Great. I was about to fix this.

Released as: v1.17.1


Weird issues

Cool project, I read through the source code. Why are you using nop instead of int3s? It will cause a lot of issues when IDA does analysis on the functions and starts bridging them
Do you also plan on adding a feature where you can fix the IAT, fix the stubbed branches etc.. ?  😁

I'm not really aware of any issues regarding nop instructions. Dumps load fine in IDA and Binary Ninja.
Fixing the IAT will be annoying but I could look into it. Same with the stubbed branches.

truly a THUNK moment

Whoops... I accidentally merged a branch I shouldn't have into main.

I have added support for the import directory in the latest commit. Please check v2.0.0.


Fix playground crashing on chromeos

Copied from https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/openBrowser.js#L100
Fixes: https://github.com/prismagraphql/prisma/issues/2592
Related to: https://github.com/prismagraphql/prisma/pull/2596

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


how to use this nexus-exporter in kuberenetes

Hi ,
can you guys tel me ,how to use this in kubernetes?.
From image if we spin up pod and integrate with Prometheus?

You can do something like this:
---
apiVersion: apps/v1beta1
kind: StatefulSet
metadata:
  name: nexus
spec:
  serviceName: nexus
  replicas: 1
  selector:
    matchLabels:
      app: nexus
  template:
    metadata:
      labels:
        app: nexus
    spec:
      securityContext:
        fsGroup: 2000
      containers:
      - name: nexus3
        image: sonatype/nexus3:3.12.1
        ports:
        - containerPort: 8081
          name: web
        livenessProbe:
          httpGet:
            path: /
            port: web
          initialDelaySeconds: 300
          periodSeconds: 30
          timeoutSeconds: 5
        readinessProbe:
          httpGet:
            path: /
            port: web
          initialDelaySeconds: 10
          periodSeconds: 30
          failureThreshold: 6
        volumeMounts:
        - mountPath: /nexus-data
          name: nexus-data-volume
      - name: nexus-exporter
        image: ocadotechnology/nexus-exporter
        env:
        - name: NEXUS_ADMIN_PASSWORD
          valueFrom:
            secretKeyRef:
              name: nexus-credentials
              key: admin
              optional: true
        ports:
        - containerPort: 9184
          name: http-metrics
        resources:
          requests:
            cpu: "500m"
            memory: "500Mi"
  updateStrategy:
    type: RollingUpdate
  volumeClaimTemplates:
  - metadata:
      name: nexus-data-volume
    spec:
      accessModes: ["ReadWriteOnce"]
      resources:
        requests:
          storage: 10Gi
---
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: nexus
  namespace: nexus
  labels:
    app: nexus
spec:
  selector:
    matchLabels:
      app: nexus
  endpoints:
  - port: http-metrics
    interval: 10s

(Note that's not a full example, it's missing the Secret, headless Service etc, but hopefully illustrates how to use it)

Maybe also mentionable: the stable repo helm chart for nexus supports additional containers. So if you want to deploy this via helm you don't have to alter the deployment template.


Bug: editor becomes unresponsive when switching to a tab that doesn't support tree-sitter

I've found a pretty serious bug where the editor will become completely unresponsive if Oomotion is in tree-sitter mode but the current editor doesn't support it. You're unable to switch modes or insert; basically you can't do anything. I almost uninstalled the extension, but I then found a way to escape such a situation.
Steps to reproduce:

Open two files A and B, where file A is in a language that supports tree-sitter, and file B does not
Focus file A and switch to tree-sitter mode
Focus file B
Note that the editor is unresponsive, and the mode cannot be changed.

Workaround:

Focus on file A
Switch to any mode other than tree-sitter or line-tree
Focus file B
Note that you are once again able to type into the editor

I'm guessing that the fix would be to somehow detect whether the current editor supports tree-sitter or not and automatically switch to something else if it does not? Another solution would be for each editor to support its own mode state (not sure how technically possible that is, though).

Thank you for your report. This bug looks weird. I'm thinking about a default tree-sitter implementation for every language. What languages you use are missing tree-sitter implementation? That will be helpful for my design.

I work in lots of languages (Typescript, C#, F#, Erlang, Haskell, JSON, YAML and a bit of Python) so I'm rarely able to use tree-sitter mode. I discovered this bug when switching between a Typescript file in which I was using tree-sitter to a YAML file (the project's readme).
BTW, if there was ever a case for introducing a new tree-sitter grammar I think YAML might be it!


Recommended hardware for gpt2-medium

Hello!
By adapting the code in this repo, I've been able to fine-tune GPT and GPT-2 small using Topical-Chat with an EC2 instance with 8 Tesla V100 GPUs (32 GB memory each). However, I am unable to fine-tune GPT-2 medium on the same instance with the exact same hyper-parameters - I'm getting out of memory issues, presumably because GPT-2 medium is much larger than GPT-2 small. I haven't tried fine-tuning GPT-2 medium using Persona-Chat yet though.
Have you tried fine-tuning GPT-2 medium (from the attention branch in pytorch-pretrained-BERT) on large dialog datasets with long turns and if so, could you share the details of the underlying hardware used?
Thanks!

What batchsize are you using? Also, are you using FP16?

https://www.gwern.net/GPT-2#training
Seems like a single 1080Ti with 11GB should be enough - if you switch to FP16 you wouldn't even need to use gradient checkpointing (Gwern used FP32).

Tweaking the gradient checkpointing was enough to get 774M to work, but not 1.5b. We experimented with FP16 when we were trying to get 1.5b to work a 1080ti. It caused a lot of issues: the codebase multiplies by constants which can't be represented in FP16 (so it wound up generating '!!!!!!' infinitely, because that's the first BPE token or whatever) and once we figured that out and converted the pretrained model over to FP16, the output was completely screwed up, so something slightly more clever obviously was required to make reduced precision work. At which point we switched over to Colab TPUs (which opened up an entirely different kettle of worms relating to TPU iterations randomly freezing, our best guess so far is that some reshape or loop makes the TPU very unhappy).

I believe we needed something like this:
diff --git a/src/model.py b/src/model.py
index 4e942d8..71092bc 100644
--- a/src/model.py
+++ b/src/model.py
@@ -124,10 +124,10 @@ def block(x, scope, *, past, hparams):
     with tf.variable_scope(scope):
         nx = x.shape[-1].value
         a, present = attn(norm(x, 'ln_1'), 'attn', nx, past=past, hparams=hparams)
-        x = x + a
+        x = x1 = x + a
         m = mlp(norm(x, 'ln_2'), 'mlp', nx*4, hparams=hparams)
         x = x + m
-        return x, present
+        return x, present, x1

 def past_shape(*, hparams, batch_size=None, sequence=None):
     return [batch_size, hparams.n_layer, 2, hparams.n_head, sequence, hparams.n_embd // hparams.n_head]
@@ -161,9 +161,9 @@ def model(hparams, X, past=None, scope='model', reuse=tf.AUTO_REUSE):
         pasts = tf.unstack(past, axis=1) if past is not None else [None] * hparams.n_layer
         assert len(pasts) == hparams.n_layer
         for layer, past in enumerate(pasts):
-            h, present = block(h, 'h%d' % layer, past=past, hparams=hparams)
-            if layer == 10:
-                tf.add_to_collection('checkpoints', h)
+            h, present, x1 = block(h, 'h%d' % layer, past=past, hparams=hparams)
+            if layer < 48:
+                tf.add_to_collection('checkpoints', x1)
             presents.append(present)
         results['present'] = tf.stack(presents, axis=1)
         h = norm(h, 'ln_f')


Unable to Mute a User.

Involved feature
Unable to mute a user.
Steps to reproduce
Follow the steps here and the mute button is not shown.
https://refined.chat/mute-users#muting
Expected behavior
Mute button should show.
Actual behavior
Mute button is not shown.
System configuration
Browser (include version): Chrome 75.0.3770.142
Extension version: 2.2.18

Hi Tomas,
This is a known issue... most of the features are broken if you land on the new slack version (that is, if you’re redirected to app.slack.com)
I’m not sure which features I’ll be able to bring back to life, I’m also not sure when that would happen (I’d love to say next Monday, but I spent some time this weekend with little to show for it).
Long story short: Slack rewrote their web app exposing as little of it as possible for extensions to mess with it.

My condolences. Your extension makes using Slack bearable. It will be disappointing if Slack start actively trying to stop extensions from modifying the experience.

I'm continuing the development of the extension in private :( read more about it on my blogpost


Minor documentation fix - add information about link.x being necessary.

This baffled me so much i had to ask on matrix about it 😄. As a newcomer to embedded Rust I found it confusing.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thalesfragoso (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks for the PR! No problem including this clarification, but perhaps we could call it a file instead of a section to avoid confusion with the linker sections themselves.

@JDuchniewicz Mind squashing that? Two commits for one sentence seems a bit unnecessary. 😅

I think you can squash it when merging. I am away from computer for the weekend.

@JDuchniewicz Indivual squashing with bors is not implemented as of yet: https://forum.bors.tech/t/rfc-bors-r-squash-to-squash-commits-in-a-specific-pr/509

Oh I didn't know, thanks!