Incomplete certificate chain returned by custom DNS Suffix setup

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
After setting up a custom domain suffix for Container Apps Environment with full certificate chain (leaf + intermediate + root + key) then all container apps are still returning only the leaf certificate. See screenshot below from SSL Labs test. I tried with the following formats and chains. Also, tried waiting some hours + creating new revisions for container apps.
PEM (no password)

leaf + intermediate + key
leaf + intermediate + root + key
PFX
leaf + intermediate + root + key

Steps to reproduce

Create a PEM/PFX with the full certificate chain
Navigate to your Container Apps Engine -> Custom DNS Suffix
Do the DNS custom setup + upload your full certificate chain

Expected behavior
Container apps return the full chain which was uploaded.
Actual behavior
Container apps return only the leaf certificate.
Screenshots

Additional context
Testing via the Portal. Also, the subscription does not have support plan.

Hi Kalmis, we are investigating the issue, but have not managed to reproduce the incomplete chain. Could you provide the following information to help us proceed with the investigation?

Could you share the environment information (e.g. you subscription id, resource group name, environment name) to our email Azure Container Apps Discussions?
Could you open the uploaded PEM file in plain text and verify that it contains three sections that start with "-----BEGIN CERTIFICATE-----" and end with "-----END CERTIFICATE-----"?
Are there self-signed certificates in the certificate chain?

Hello, thanks for the investigation! I got it working now. I uploaded a wrong certificate chain (for another domain) to be sure that the certificate is updated. Then I uploaded the correct chain in PEM format (order leaf + intermediate + root + key), and it seems to work now.
What comes to the questions,
2. The PEM file contains four sections. Three begin certificate sections (leaf, intermediate and root certificates) + the begin private section where the key is.
3. No self-signed certificates were used.


Feature Request: Apply to a change to a String

Maybe I'm not seeing it in the docs, but I think it would be nice to apply a Change Object, or an array of them, to a string to be able to create a changed string.

+1 for this feature

Makes sense, but figuring out how to adapt the logic in applyPatch is not entirely trivial. That logic assumes that the changes are a series of hunks with line numbers and local context (rather than literally the entire file content being included in the diff like it is with change objects) and that each change is to an entire line (allowing lines to be fuzzy-matched using the fuzzFactor option), and these things are not necessarily true when we're dealing with change objects.


Add categories for markers in MarkerTable.

Introduce a new MarkerTableEntry type to alter a marker table entry after creation. It can add a category for the marker and will be easy to extend while preserving the public API in the future.

Change the return type of add_marker() and add_marker_with_stack() functions from () to MarkerTableEntry. This means the add_* calls can now be chained with methods that apply on a MarkerTableEntry to alter the entry that was created; in particular to add a category.

This patch changes the public API of the crate. If users of the crate were calling add_* methods without a trailing ;, they will now need to add that trailing ;.

Example of how to use the new API here: profile.add_marker(thread.handle, name, TextMarker(text), timing).category(category);.

It's a neat trick, but at this stage I'm not too concerned about breaking compatibility. I think it's fine to make the category a required parameter. It looks a bit odd to have just one optional field. We can reconsider this in the future if we want to add any other optional parameters.

It's a neat trick, but at this stage I'm not too concerned about breaking compatibility. I think it's fine to make the category a required parameter. It looks a bit odd to have just one optional field. We can reconsider this in the future if we want to add any other optional parameters.

Alright, I've updated the pull request to just have the category as an argument.


style(typings): fix import errors, remove dependency

Ref: #1456.
This PR:

fixes export errors;
remove dependency on cpx - we can use gulp for this.

Codecov Report

Merging #1460 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1460   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files         141      141
  Lines        2364     2364
=======================================
  Hits         2358     2358
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d72812...38f3484. Read the comment docs.


Jupyter Interactive Cells Do Not Work with August 2020 update

Issue Type: Bug
Cannot click "Run Cell" etc. in actual python script, or it does not show up.
Issue in latest August 2020 release.
VS Code version: Code 1.48.2 (a0479759d6e9ea56afa657e454193f72aef85bd0, 2020-08-25T10:09:08.021Z)
OS version: Darwin x64 19.6.0
Remote OS version: Linux x64 5.3.0-1035-aws
Extensions (9)

Extension
Author (truncated)
Version

remote-ssh
ms-
0.55.0

remote-ssh-edit
ms-
0.55.0

gitlens
eam
10.2.2

gitlab-workflow
Git
3.3.0

gc-excelviewer
Gra
3.0.40

restructuredtext
lex
129.0.0

mssql
ms-
1.9.0

python
ms-
2020.9.112786

vscode-pylance
ms-
2020.9.6

/extPython


how to overwrite index.html and set logo's link to index.html

Problem
I rewrite a page named custom.html in template, and how to set when I click the logo, page link to ../custom.html rather than index.html ?
Reproducible Project
Please give a link to a public reproducible project or provide an example of the Restructured Text that gives an issue.
Place RST code here (if any).

Error Logs/Results
Place any images or error logs that might be able to help solve the issue here.
Expected Results
Please describe how this should work properly.
Environment Info

Python Version:
Sphinx Version:
RTD Theme Version:

We don't have a specific block around just the link or logo link, so you'd have to override the entire sidebartitle block:
https://github.com/readthedocs/sphinx_rtd_theme/blob/master/sphinx_rtd_theme/layout.html#L116-L146
We don't have any specific configuration for this otherwise. If you aren't familiar with Sphinx templating, their docs have some resources, or you can look at some of the existing themes that extend the basic theme for an idea of how to accomplish this. The templating docs do cover extending templates, which is what you'd be looking to do to alter this link.


zh: Issue with k8s.io/zh/docs/tasks/tools/install-minikube/, Could update Aliyun image

This is a Bug Report

Problem:
minikube could not start in China due to GFW
Proposed Solution:
Improved from #21936, Aliyun fully supports the images needed to install minikube, as shown here.
Maybe we could provide link to that page, or update the information in https://kubernetes.io/zh/docs/tasks/tools/install-minikube/#安装确认
Page to Update:
https://kubernetes.io/zh/docs/tasks/tools/install-minikube/

@Yiyiyimu can you please try info on this PR https://github.com/kubernetes/minikube/pull/8555. if it solves your issue?

@RA489 Sure I think our methods are the same. I'll close this issue.


Bookmarks Official Doc - "Platforms" Parameter update

[!IMPORTANT]
Required for API changes:

Link to API.md file: ADD LINK HERE
Link to PR for public-facing schema changes (schema-Prod-beta/v1.0.csdl):  ADD LINK HERE

Add other supporting information, such as a description of the PR changes:
Currently the doc is out of date as it contains many parameters that no longer supported in Graph explorer API. Delete the unused parameters and keep it up to date.

[!IMPORTANT]
The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.

do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

@Lin-Qi-MS please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree Microsoft]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree Microsoft]

@microsoft-github-policy-service agree company="Microsoft"

@Lin-Qi-MS, please add the "ready for content review" label if you're ready for us to continue with the review.

@Danielabom I did not find any place to add the label, but this PR is ready to review now.


auto-naming in analysis modules?

Hi, would it be possible to automatically suggest output file names and locations based on input image name and location? For example, in the Color Deconvolution module, if the input filename is test.tiff, then the module automatically suggest test_stain1.tiff, test_stain2.tiff, and test_stain3.tiff as output filenames instead of letting user to open file dialog multiple times to set filenames, these output files could be conveniently saved at the same location as the input file. This will make HistomicsTK a lot easier to use. Thanks!

We actually added that..I agree it's tedious.. I think it's being reviewed
...
On Feb 13, 2018 1:32 PM, "yliu7366"<EMAIL_ADDRESS>wrote:

Hi, would it be possible to automatically suggest output file names and
locations based on input image name and location? For example, in the Color
Deconvolution module, if the input filename is test.tiff, then the module
automatically suggest test_stain1.tiff, test_stain2.tiff, and
test_stain3.tiff as output filenames instead of letting user to open file
dialog multiple times to set filenames, these output files could be
conveniently saved at the same location as the input file. This will make
HistomicsTK a lot easier to use. Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DigitalSlideArchive/HistomicsTK/issues/462, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AArhzkqT5KDjGUOpvzCyp_eUFGSZ1XdNks5tUdVYgaJpZM4SEND1
.

This was added some time ago.


Adding URLs for new categories.

What does this do?
Adds missing equipment category URLs.
How was it tested?
CI
Is there a Github issue this is resolving?
This resolved #244
Here's a fun image for your troubles

Looks good to me! Thanks for sorting this one out.


Wav2Vec2 features for Tedlium recipe

Guys,
Is it possible to run Tedlium recipe with wav2vec2 features instead of fbank features?
Thanks,
AlexG.

Yes. You need to first dump the wav2vec2 features and then re-build your input manifest for training.

You can refer to this script for making SSL features.

What is size of wav2vec2 feauture vector, is it extracted every 10msec like filter bankd? For filter bank we use 80 bins. In what places in the train file should I replace this value "80" with number of features from wav2vec2.

What is size of wav2vec2 feauture vector, is it extracted every 10msec like filter bankd? For filter bank we use 80 bins. In what places in the train file should I replace this value "80" with number of features from wav2vec2.

The feature dim extract from the default wav2vec2-base model is 768 with a stride of 20 ms.
You would need to change the corresponding value of feature_dim in train.py.

And what about stride? Should be updated somewhere too?

And what about stride? Should be updated somewhere too?

You can set subsampling_factor=2

@DongjiGao I noticed that you use compute_and_store_features in that script. I think you can also use compute_and_store_features_batch for GPU-based extraction. It might make the feature extraction step much faster. Note that SSL features support extract_batch(): https://github.com/lhotse-speech/lhotse/blob/8a4b3b53ed337ecc5def6dcbc0473e0f57f1ecce/lhotse/features/ssl.py#L91


Add a test for ppoll

Looks like our Rust 1.14 problems are solved.
Also, thanks a lot for those comments. I think they're helpful and hopefully weren't too much of a burden to write. Where's the gold star emoji!?
bors r+

The failure looks related to Travis's build cache
bors r+ susurrus

bors r+

The build failed due to an ABI change at libc.  I suspect that the ABI change was unintentional.  If so, we should just wait for libc to revert it.  If not, we'll have to make a matching update to nix.
https://github.com/rust-lang/libc/commit/9029cfb9eb76647cf9122a47252f1129eb18a562

This is already being resolved at least partially at rust-lang/libc#813. See the comment discussion I've been having over there. If you're willing to finish off the fix there, it'd be awesome.

bors r+


Private strings

Add a "private" modifier for strings which keeps that string out of the matched strings when calling the callback. This allows for rules to use strings which could potentially match a lot of times but are only useful as anchor points for other strings without polluting the output (or logs in our case). Essentially, you can now write rules like https://blog.korelogic.com/blog/2015/08/19/yara-ctf-2 without having A LOT of PK header matches in your output.
Without a private string you have to limit the number of string matches in the callback manually. With a private string it is completely hidden from the callback.
Another upside of this is the python bindings won't have to spend as much time converting the matches to python strings if they are marked private, so in theory there is a performance improvement to be had in some cases here (I haven't measured it but it sounds plausible =b).

I signed it!
Though it is only picking up my gmail address which I never use. :(


Query bar gone after installing enchanced table 1.11.0 in kibana 7.10.2

Greetings again,
I am facing this issue: I upgraded kibana from 7.9.2 to 7.10.2 and also upgraded plugin to latest version.
When installing, somehow search bar and time range vanishes and is restored after unistalling the plugin and restarting kibana again.
Sorry to bother, let me know if you cannot reproduce.
Thanks,
Dimitris

Hi,
Very weird issue...
You speak about Kibana core search bar? Or enhanced table filter bar ?

Core search bar.....very weird indeed. I also did an install in another kibana instance that was also running 7.10.1 with no issues.
I was suspicious that maybe previous enhanced table saved objects produced some kind of conflict but I also tested that on a clean setup and it was repeated.

So you reproduce the issue on Kibana 7.10.1, but not on Kibana 7.10.2?

No, both my instances are 7.10.2, but only one of them has this issue, and it is the production one....:(

At this point I believe it's a system index that produces the conflict but I cannot experiment unfortunately

Ok, it is very strange.
But if you don’t see that issue on a kibana 7.10.2 instance, that is probably not because of enhanced table.
by the way, I made some tests with kibana 7.10 and didn’t reproduce this issue.

Thanks for your time and effort. Hopefully it will resolve itself somehow!

Greetings again, please close the issue. It was fixed after clearing browser cache. It seems that it had cached previous kibana page from 7.7 without the navigation bar. No issues with enhanced table whatsoever.
Thanks again for your time! Your work is awesome

Thanks for the feedback.
I have also some problems with browser cache since kibana 7.9.
it is a known problem at Elastic.
Don’t hesitate to open an issue on kibana repository.

As you ask it, I close the issue.


Touch doesn't work for color or alpha when zoomed in

I experience the following error on both Opera (30.0.1856.95530) and Chrome (44.0.2403.133) on Android 5.0.0. JavaScript version V8 <IP_ADDRESS>.
After zooming in on the colour picker tapping or sliding on the sp-color panel will always select a grey scale colour. It seems only the y-axis value is used and the x-axis value is ignored. (I just noticed this is also the case for the sp-alpha channel). Tested on first picker on https://bgrins.github.io/spectrum/

+1
Happens for me on Android 6.0, after pinch-zooming into the page


Update dashboard view

[x] OSMCHA error and feature completeness in one panel for all of types
[x] User engagement in one panel for all of types
[x] One type view under map at a time

Reopening to add a couple items to match mockups:

[ ] Add Areas Covered % to map side panel
[ ] Update text Attribute Completeness, not Feature completeness

@smit1678 how do you calculate the areas covered?

@dimasciput I used a geojson file

Link to campaign: https://staging.campaign.kartoza.com/campaign/115a450e7b244556b026a05d9be35c76

@smit1678 I mean the formula to calculate the covered area, completed/total area ?


slice return type resolves to wrong type when used on string intersection with union containing array type

Bug Report

🔎 Search Terms

union intersection type slice
🕗 Version & Regression Information

4.5.4, nightly (v4.7.0-dev.20220215)
⏯ Playground Link

Playground link with relevant code
💻 Code

type BoyIWishIWouldResolveToString = (string | RegExpMatchArray | undefined) & string;

let test1: BoyIWishIWouldResolveToString = "I can be a string";
let test2: BoyIWishIWouldResolveToString = ['I cannot be an array']; // error here (correct)
let test3: BoyIWishIWouldResolveToString = test1.match(/I cannot be a RegExpMatchArray either/)!; // error here (correct)

function testFn(param: BoyIWishIWouldResolveToString) {
    // type is `string | string[]`
    let iShouldBeAStringButIAmAUnionOfStringAndStringArray = param.slice(0,1);

    // error here (wrong)
    iOnlyAcceptStrings(iShouldBeAStringButIAmAUnionOfStringAndStringArray);
}

function iOnlyAcceptStrings(param: string) {}

🙁 Actual behavior
slice returns a union of string | string[].
🙂 Expected behavior
slice returns string because the underlying intersection type can only resolve to string.

This happens because TS isn't sure whether you're calling Array#slice or String#slice.  It's true that BoyIWishIWouldResolveToString has no legal inhabitants other than string, but TS doesn't know that, it only knows it has something that can either be a string or a RegExpMatchArray & string.  This pattern of intersecting a primitive type with an object type is often used to create branded primitives, so TS doesn't simplify it out of existence.

To be clear on why RegExpMatchArray & string is considered a possibility here: Intersections distributes over unions, so:
type BoyIWishIWouldResolveToString = (string | RegExpMatchArray | undefined) & string;

// is equivalent to

type BoyIWishIWouldResolveToString = (string & string) | (RegExpMatchArray & string) | (undefined & string);

The first is just string and the third reduces to never (thus being simplified away), but the compiler considers the middle one to be inhabited for the reasons mentioned above.

@fatcerberus why does typescript not know this? What would be the correct way to limit the union type to string?

@FatalMerlin There's no technical reason why TS couldn't figure out that string & RegExpMatchArray is uninhabited, but people often write things like string & { foo: never } to create branded types and then manually cast values to them, to enforce validation, e.g.  If such types eagerly collapsed to never, that wouldn't work.  Unfortunately RegExpMatchArray is just another object type from this perspective, thus you hit this issue.  The underlying behavior is by design so there's really no way around it other than "avoid intersecting primitives with object types"

@fatcerberus are you saying that typescript was designed in a way that prevents it from narrowing unions of primitive and object types back down to primitive types contained in the union?

This has nothing to do with narrowing of unions.  What I'm saying is that if you have a type string & SomeObjectType, TS treats that as a distinct type from string.  You're expecting it to automatically simplify to string because string & RegExpMatchArray is an impossible type, but it doesn't because you might have good reason to construct such a type.

The essential part here is that { a: number } is not a type restricted to objects. For example, number is a valid { toFixed(digits?: number): string }. So, string & { a: number } is, theoretically, possible, even though string & object is not. Similarly, RegExpMatchArray isn't restricted to just objects, so it can't reduce string & RegExpMatchArray to never.
Might Extract<string | RegExpMatchArray | undefined, string> (which resolves to string) be what you're looking for?


current uid is a stack

MakeCallback is sometimes called synchronously, thus uid can have multiple values in the same synchronous context.

Fixed by #32


TextChannel fetchMessages

Please describe the issue you are having:
In v0.5 i used channel->fetchMessages alot, this does not seem to work anymore since v6
If you are encountering any errors, post the full stack trace here:
No error is generated, the callback is never called

Please include a Minimal, Complete and Verifiable Example:
        $channel->fetchMessages()->done([$this, 'onMessagesLoaded']);
    }

    /**
     * @param Collection $messages
     */
    public function onMessagesLoaded(Collection $messages): void

Is what I used and worked in v0.5.* but not in v0.6.*
Please include the expected output of the MCVE:
n/a
Please include the actual output of the MCVE:
n/a
Further details:

Yasmin version: 0.6.1

PHP version: 7.3.6

Operating System: Ubuntu / whatever heroku is running

[ /] I have also tested the issue on latest master with commit hash: b8a164282aafd5a004b5399781456b7aaa70fbaa

Thanks you much for providing this lib @CharlotteDunois .
If you need any more info's don't hesitate to ping me!

Between v0.5 and v0.6 has nothing changed for fetchMessages. Errors end up in the promise rejection handler, you don't have a promise rejection handler and even though the done method should be throwing, I've sometimes seen no exception being thrown. So to make absolutely sure that there's no promise rejection, you can add a promise rejection handler (second argument of done).
And as side note: Heroku is not meant to be used as host for bots (it's meant for websites and APIs), so you should consider relocating to a better host for various reasons.

Thanks for the advise, I'll add the rejection code and also ordered a real VPS to deploy on.


[References] Create a more compact design

The existing references are based on tables, even if the data doesn't
require a tabular presentation. Use a flex-box approach instead.
References converted:

Braille
Naval Flags
Semaphore

Also tweaked the sizes for the morse table to get more in view.
Fixes #68

Braille:

Morse:

Naval Flags:

Semaphore:


Windows 11 integration need an option for keeping the old context menu

Feedback from a user.
When calling the context menu from Total Commander, there is no more the context menu because the Windows 11 Explorer style is not supported, so we need an option for keeping the old context menu as it is done in other tools.
WinRAR:

TreeSize:

Unable to reproduce. Windows 11 shell extensions work fine in Total Commander including properly opening the file in MediaInfo and Mp3tag.
The entries for Clipchamp, MediaInfo, Quick Share, Mp3tag and Notepad are all Windows 11 new-type shell extensions.

In my opinion the user should contact developer of Total Commander for any compatibility issues instead of requesting changes from each and every app to be compatible with Total Commander. Most apps that implement the new shell extension no longer have the legacy shell extension.
Unrelated note: Many apps do not even have an option to disable the context menu entry. Mp3tag only has option to disable in Store version while the installer version can only enable/disable the context menu during installation.

Why is this so? WinRAR, EZCDAC & Mp3tag - from main Win11 menu.

Are both options enabled in MediaInfo Preferences?

Yes

If it works properly in Windows File Explorer but not on Total Commander then I have no idea why. It works when I tested in Total Commander. Only the developer of Total Commander will know.

In Explorer the same thing.
In main context menu - available on files and folders. Shift+context menu - only on folders.

If it works properly in Windows File Explorer but not on Total Commander then I have no idea why.

Windows File explorer uses the new package but Total Commandes uses the old fashion registry, so it makes sense up to...

It works when I tested in Total Commander.

This part is weird, it does not work on 1 machine but works on another machine... If Total Commander does not use the new package, how does it get the context menu on @cjee21 machine?
Maybe something remaining from a dev? Does it disappear if options are unchecked in MediaInfo preferences?

If it works properly in Windows File Explorer but not on Total Commander then I have no idea why.

Windows File explorer uses the new package but Total Commandes uses the old fashion registry, so it makes sense up to...

It uses the new package as well. If not, all the app entries will not appear in my test. All those apps use package. Even on his machine, MediaInfo and Mp3tag appears in Total Commander when right-click folder so it does not make sense.

Maybe something remaining from a dev? Does it disappear if options are unchecked in MediaInfo preferences?

If this refers to my test, I have done the test on a newly set-up fresh-install Windows 11 VM (official ISO direct from microsoft.com) with nothing else installed other than the test apps because I do not want to install shareware/trialware on my main PC so there is no possibility of anything remaining from development or previous installs etc.

So I dug abit and found this by author of Total Commander:

Total Commander does not create the context menu by itself. It requests it from Windows via the IContextMenu interface, and then adds its own entries. So when context menu entries are missing, then the program which owns these entries is responsible when they are missing in third party programs. Total Commander cannot control that.

MediaInfo's shell extension does not have any features that prevents it from being used/loaded by third party programs. The fact that it appears when a folder is selected in https://github.com/MediaArea/MediaInfo/issues/994#issuecomment-2541700900 is evidence for this.
Piecing this together with https://github.com/MediaArea/MediaInfo/issues/994#issuecomment-2541738716:

In Explorer the same thing. In main context menu - available on files and folders. Shift+context menu - only on folders.

It now makes sense. This issue is not about old/legacy vs new/packaged shell extensions. It is also not about shell extension not working in Total Commander or third party apps. It is that MediaInfo's entry is missing from legacy context menu when a file is selected but not when folder is selected.
Since https://github.com/MediaArea/MediaInfo/issues/994#issuecomment-2541738716 mentions that it is available for files and folders in the main/new context menu, I have no idea why it does not appear in the other. The fact that it appears on the main context menu means Windows has correctly picked up the registration and successfully loaded the shell extension. It also means MediaInfo's shell extension has correctly read the Preferences and enabled itself. In addition, it works on other Windows 11 systems including in Total Commander for both files and folders. It is looking likely that this is an issue with the particular Windows installation and is not something that MediaInfo can solve.

Feedback from a user. When calling the context menu from Total Commander, there is no more the context menu because the Windows 11 Explorer style is not supported,

This line in the initial post is now proven to be false by screenshots in https://github.com/MediaArea/MediaInfo/issues/994#issuecomment-2541343905 and https://github.com/MediaArea/MediaInfo/issues/994#issuecomment-2541700900.

It now makes sense. This issue is not about old/legacy vs new/packaged shell extensions. It is also not about shell extension not working in Total Commander or third party apps. It is that MediaInfo's entry is missing from legacy context menu when a file is selected but not when folder is selected.

I am completely lost.
Fact is that I receive feedback because something has changed, but the exact issue seems different depending on the machine.
Let's try to summarize, on specific machines:

Before the switch to packaged, there was a menu in e.g. Total Commander
After the switch to package, this menu is no more there, regression
It means that at least one thing was not well "converted" from legacy to packaged, what? I don't know.

Additionally, I just received this email:

since MediaInfo 24.12 the context menue entries from MediaInfo are missing on Windows 11 x64 though the settings are set to enable them. I guess you removed the classic context menue entries and only install the "new" M$-Store-forced context menue... This is a bad solution as I set windows to use classical context menues and do really not want to do 2 more clicks to get my context menue and the M$-entries are almost the least interesting ones for me...

Would you mind reimplementing classical context menue entries or could you @ least provide a regfile to reenable the classical context menu entries..?

It seems that we have an option somewhere for the classic context menu on Win11...
For the moment the easiest solution I see is to keep the legacy menu in addition to the packaged menu, maybe without option so easier, if I understand correctly it would not create duplicate entries because it is not at the same place, so does it hurt? If duplicate entry, we add an option for people having uncommon configs...

is not something that MediaInfo can solve.

Something was working in the past and is not working anymore, so we can solve that at least by reverting to the previous code, but we could also find a way to have everyone happy.
changing something is not easy, different configs, different people, different usages. Now you know why I am reluctant to change something ;-).

Windows will automatically populate both new and old context menus when a context menu entry that is registered by a package is present.
This means @sevastopolcat that has entries for new menu but not the old one and only for files but not folders is an issue unrelated to MediaInfo but is something going wrong in Windows. In this case it is expected that it does not work in Total Commander too since this app uses Windows API to build the old style menu.
It also means doing "For the moment the easiest solution I see is to keep the legacy menu in addition to the packaged menu" will cause duplicate entries.
For "This is a bad solution as I set windows to use classical context menus", something else is the issue as well. I just tried setting Windows to only use the old menu and MediaInfo is still present there.
So in conclusion, all the issues so far are not directly due to the new shell extension.
In addition, right now, MediaInfo will only remove the old shell extension when the new one is found in the registry.
@JeromeMartinez can try removing this if statement and the old one would not be disabled.
https://github.com/MediaArea/MediaInfo/blob/886b55528a23523ecd2a3270612bf64816738b2b/Source/Common/Preferences.cpp#L827

If anyone still has the wrong idea about Windows 11 context menus,
This new shell extension method is supported on Windows 10 Build 19000 onwards.
Although this method is required to appear in new Windows 11 context menu, it has nothing to do with Windows 11 or the new context menu.
This new shell extension does not only work on the new context menu but works on existing/legacy context menus since Windows 10 Build 19000.
So it is not about replacing old shell extension with new one equals will not work if new context menu is disabled or third party app does not support new context menu. Replacing old with new should have no difference other than ability to open multiple files in the same MediaInfo instance. If it breaks something, then there is an issue somewhere and putting back the old shell extension would be just a workaround and not a solution to the underlying issue.

we could also find a way to have everyone happy

My idea (one of the following):

only implement the package identity stuff on Store version of MediaInfo (guarantees no issues with users of exe installer as it will be exact same as before but without Windows 11 integration)
add option in installer to opt-out of package identity (users who mess with their Windows such as disabling services that are not meant to be disabled will still encounter issues due to embedded manifest in MediaInfo.exe)

It appears to be a strange Windows bug that can be mitigated like the following

I am fine with changing that if it is a way to mitigate the issue...

only implement the package identity stuff on Store version of MediaInfo

The feature is good for most users, limiting that to the Store would be sad, it is not because there are a couple of issues that we need to wipe out the feature for most users.

add option in installer to opt-out of package identity

I don't get why we can not just add an option for switching back to the registry and the package just leave like if the option is disabled in that case, no need to remove everything, or do I miss something?

Menu option unchecked (classic menu option grayed out) = no registry, WindowsShellExtension leaves
Menu option checked + classic menu option unchecked = no registry, WindowsShellExtension handles it
Menu option checked + classic menu option checked = registry, WindowsShellExtension leaves

PS: another case at https://sourceforge.net/p/mediainfo/discussion/297610/thread/364aa79842/

I don't get why we can not just add an option for switching back to the registry and the package just leave like if the option is disabled in that case, no need to remove everything, or do I miss something

After we workaround the Windows bugs, most of the other issues (such as MediaInfo not launching) will likely only be mitigated by complete removal of package identity. Those issues will likely be caused by corrupt Windows or disabling of core Windows services. Even this current bug is caused by packaging and likely before the shell extension is loaded and decides whether to show.
Therefore I do not see much benefit of having an option in Preferences for that. It will add the following:

More code in MediaInfo GUI
Another string to translate to so many languages
Changes to Preferences window which may break things again (like that day) especially if I do it on C++Builder 12 (no idea why only Preferences breaks and not Main)
Possibility of users asking about what the new option does, what's the difference between the two extensions etc.
Having to maintain legacy shell extension even after dropping support for Windows 10 < Build 19000 in the far future

Temporarily (before reinstalling Windows), I bypassed my problem not entirely correct. Installed the installer 24.11.1 and rolled on top of the portable 24.12.
Once the same problem was with Mp3tag. After the next updates of the OS and the program itself, it quietly disappeared.

Once the same problem was with Mp3tag. After the next updates of the OS and the program itself, it quietly disappeared.

So it can happen to Mp3tag too... Mp3tag Verb Id is 'Mp3tagShellso starts withM` too.
Microsoft Notepad Verb Id is OpenInNotepad and does not seem to have issues? According to NanaZip devs, using OpenTerminalHere1 causes issues too. NanaZipShellExtension also issue but CNanaZipShellExtension or CNanaZip no issues. I see no pattern.
Fun fact: Microsoft registered Notepad shell extension for Directory as well but of course it does not show.

...you can wait for a new build...
Of course, I will wait for the new version(s) and inform the results.

@cjee21 I received this use case of a user not finding anymore MediaInfo in the context menu:

I use a tool called "Winaero Tweaker" ( https://winaero.com/winaero-tweaker/ )
Luckily this tool explains what it does for (nearly) every tweak it contains and so their explanation for enabling classic context menues is there:
https://winaero.com/how-to-enable-full-context-menus-in-windows-11/

So if we don't go with the idea of an option we may need to check (both in the installer and the GUI?) that HKCU\Software\Classes\CLSID\{86ca1aa0-34aa-4e8b-a509-50c905bae2a2}\InprocServer32 is not set in addition to the test on Windows 11 (I can survive if the user changes his config and is not finding the menu until MediaInfo GUI is launched again)

@cjee21 I received this use case of a user not finding anymore MediaInfo in the context menu:

I use a tool called "Winaero Tweaker" ( https://winaero.com/winaero-tweaker/ )
Luckily this tool explains what it does for (nearly) every tweak it contains and so their explanation for enabling classic context menues is there:
https://winaero.com/how-to-enable-full-context-menus-in-windows-11/

So if we don't go with the idea of an option we may need to check (both in the installer and the GUI?) that HKCU\Software\Classes\CLSID\{86ca1aa0-34aa-4e8b-a509-50c905bae2a2}\InprocServer32 is not set in addition to the test on Windows 11 (I can survive if the user changes his config and is not finding the menu until MediaInfo GUI is launched again)

I expect this is due to same Windows bug and that it will be working after #997.
When I mentioned

I just tried setting Windows to only use the old menu and MediaInfo is still present there.

in a post above, I am doing it with a similar registry tweak manually. This registry tweak just makes Windows go straight to the classic menu instead of opening the new one, nothing else as far as I know. Same behaviour as holding shift before right click. If it does not appear after this tweak, it will not appear in the classic menu without this tweak either.
As I mentioned earlier, the new shell extension although is needed to appear in the new menu, actually has nothing to do with Windows 11 or the new menu and will still work without the new menu. If it doesn't something is wrong somewhere and reverting to old shell extension will be just a workaround rather than addressing the cause.
The Verb Id Windows bug addressed in #997 actually existed since Windows 10 in 2021. Since Windows 10 only has one type of context menu, it results in totally no entry. NanaZip originally received report of this bug in 2021 and someone only found the workaround in 2022.

I expect this is due to same Windows bug and that it will be working after https://github.com/MediaArea/MediaInfo/pull/997.

I asked to test the new build, we'll see.
Note that it seems that it does not resolve the issue for everyone, this person still has the issue with Total Commander.

As I mentioned earlier, the new shell extension although is needed to appear in the new menu, actually has nothing to do with Windows 11 or the new menu and will still work without the new menu. If it doesn't something is wrong somewhere and reverting to old shell extension will be just a workaround rather than addressing the cause.

If we can find the issue for (mostly) everyone, it is fine for me...

NanaZip originally received report of this bug in 2021 and someone only found the workaround in 2022.

And good that you found the thread there!

Note that it seems that it does not resolve the issue for everyone, this person still has the issue with Total Commander.

If it appears in Windows File Explorer classic menu but not in Total Commander then it is an issue with Total Commander. If it does not appear in Explorer classic menu too then it may be some Windows bug again. In that case reverting to old shell extension is not really a solution as it will then be gone from the new menu.
To better determine causes, think we need info about Total Commander version, is it 64 or 32 bit, how many shell extensions are installed (maybe Windows has a bug that stops parsing verb ids at a certain letter after some limit). I also wonder if Microsoft is aware of the bug since it seems to remain from Windows 10 2021 to Windows 11 2024. If it is really caused by some limits then there may be more issues as more apps installed by a typical user adopt the new shell extension.

In that case reverting to old shell extension is not really a solution as it will then be gone from the new menu.

Well, it was working with the old shell extension so it is a solution, but I understand that you want to try to avoid that.
For the moment I wait for feedback from the Winaero user, it the new binary does not work the first thing to implement is to check the indicated registry entry, I think, for checking if this registry entry is a good trigger, I guess. Anyway, let's wait for the feedback.

We should fix/workaround any bugs with the new shell extension as much as possible first. Else there will be more issue reports from Windows 10 users when shell extension is implemented for the Store version. There will be no old shell extension or new context menu as a workaround in the case of Windows 10 + Store app. It will just be no context menu entry.
Also note that the registry tweak is undocumented and the key may be changed by Microsoft.

I specifically checked Winaero Tweak Classic Full Context Menu.
With a developer build 24.12.20241216, the menu item is in an Explorer (main and full menu) and in Total Commander, on files and folders.

🤔 Checking for HKCU\Software\Classes\CLSID\{86ca1aa0-34aa-4e8b-a509-50c905bae2a2}\InprocServer32 will only workaround for people who have used this tweak. Since the issue has nothing to do with this tweak, it will not workaround for others that have the issue but not using the tweak (if there are any remaining). It will also cause 'regression' for those not having issues but are using the tweak by forcing a 'downgrade' to old shell extension that doesn't support opening multiple files in the same MediaInfo instance.

Found M2Team/NanaZip/issues/505#issuecomment-2511086162 which seems similar to our issues.
So I inspect what BandiView does and it also uses packaged shell extension with a Verb Id of BandiViewShellMenu. That starts with a letter before "C" which is also used by NanaZip! So is there a bug in Windows that stops parsing shell extensions at a certain limit and parses in alphabetical order? IF this is true, Microsoft needs to fix this or it will be never ending. Once developers know about this we may end up with a race of who has the earliest alphabet and Verb Ids will end up being "aaaaMyShell". 🤣

Feedback from the Winaero user with the "C prefix" patch:

This one brings back the context menue entries for files but not for folders (although ticked in settings as admin)...

So you are right about the registry key which would be only a workaround if we can not figure out a better workaround (because the "C prefix" is also a workaround, just a better one), but isn't something to do about the folders?

If the hypothesis in https://github.com/MediaArea/MediaInfo/issues/994#issuecomment-2550800782 is right, let's just put Verb Id as '1MediaInfo' and the issue will likely happen with other apps instead (hope MediaInfo will not get wrongly blamed for breaking other apps' entries). This is really something that is only fixable by Microsoft.
As a last resort workaround for the few impacted users (if still any remains), can add a hidden config to always keep legacy shell extension enabled even in presence of new shell extension.

By the way, @JeromeMartinez, do you have access to this? Since MediaInfo is digitally signed, it seems you can get telemetry from Microsoft regarding the Windows versions that MediaInfo is installed on, the number of installs as well as crash dumps and problem reports.

let's just put Verb Id as '1MediaInfo'

Let's try that, please create a PR with '0000MediaInfo' (well, let's go far :-p), I build it and send to the person having the issue.

it seems you can get telemetry from Microsoft regarding the Windows versions that MediaInfo is installed on, the number of installs as well as crash dumps and problem reports.

I have that with the Microsoft Store but I didn't check with the Desktop version, I'll check what I can do.

Did some more tests in VM but unable to reproduce the issue even with BandiView and MediaInfo 24.12 (well there was once where Mp3tag was missing from both menus and MediaInfo missing on classic menu for files but it was okay after a Windows restart and some waiting; restarting File Explorer only did not work; this was after quickly installing MediaInfo then Mp3tag then MediaInfo again). Therefore, I will just let this be a crazy Windows bug with unknown causes with an equally crazy workaround.
In another test, I found that 32-bit shell extensions can be loaded in 64-bit Windows File Explorer and 64-bit shell extensions can be loaded in 32-bit Total Commander. This is as I expected as the shell extensions are run out-of-process in DLLHost so not sure why x64 shell extension does not seem to work on ARM64 previously. Microsoft Clipchamp shell extension is x86 (32-bit) on all Windows including x64 (see screenshot below) and ARM64 and works fine but appears third-party x86 and x64 shell extensions do not work on ARM64 although loaded by DLLHost successfully.
Screenshot showing 64-bit shell extensions in 32-bit Total Commander and 32-bit Clipchamp shell extension on 64-bit Windows:

@cjee21 Looks like you fixed the integration issues in most machines but the option may be still needed for tools not using the new method, another user talks about another file manager called Directory Opus.

The ultimate test in a VM...
I have tried installing as many apps with packaged shell extensions that I can think of as well as several third party file managers.
The test files are .mp4 .jpg and a folder.
Conclusion: Everything works fine except two problematic apps.

Microsoft's VSCode context menu entry does not appear anywhere. No idea why this specific Microsoft app seems to keep having difficulty integrating a shell extension. It is registered correctly and is a 32-bit dll but seems to hang with dllhost constantly running.
Directory Opus only shows entries for folders correctly proving that it does support MediaInfo's shell extension. For files it is missing many entries including Microsoft's pre-installed apps and Mp3tag. It is only showing 5 out of 9 entries for jpg. It appears to not attempt to load the shell extensions that it is not showing at all. It appears those that were loaded are the ones that specify * in their registrations and not file extensions.

So sure, we can add option to keep old shell extension enabled if you want and hope that it will appear. Or alternatively, use * instead of a list of file extensions. The bug is actually in Directory Opus though and they should fix it as other apps are also affected. It is also a paid app so they should provide support.
I am actually using the publicly available MediaInfo 24.12 version for this test so there is no need for our workaround on this Windows installation even with all those other apps installed.

The ultimate test in a VM...

Wow, thanks for the tests.

So sure, we can add option to keep old shell extension enabled if you want and hope that it will appear (this will cause duplicate entries on all other context menus, including in Directory Opus for folders, as they are all already working correctly).

It is always the last hope in case the MediaInfo context menu does not show up on some machines, not something I desperately wish :).
but:

Or alternatively, use * instead of a list of file extensions.

This may be the ultimate solution... Could you try method and say if it works with everything?

I am actually using the publicly available MediaInfo 24.12 version for this test so there is no need for our workaround on this Windows installation even with all those other apps installed.

Unfortunately it is not the case everywhere, but I expect that the * solution would be fine with them too so no need of the "aaaa" workaround.

Or alternatively, use * instead of a list of file extensions.

This may be the ultimate solution... Could you try method and say if it works with everything?

The original design was using * but you didn't want MediaInfo to appear for all files. So if we switch to * but still want an allowlist, need to modify the dll and do the checking there. Can also add shortcut handling while at it if not too difficult.
In this specific Directory Opus case, they seem to be handling shell extensions themeselves rather than using Windows APIs. So it is their developer that has to fix the bug where their expensive paid app is not correctly showing shell extensions that use a list of file extensions. Many shell extensions are affected.

I am actually using the publicly available MediaInfo 24.12 version for this test so there is no need for our workaround on this Windows installation even with all those other apps installed.

Unfortunately it is not the case everywhere, but I expect that the * solution would be fine with them too so no need of the "aaaa" workaround.

* will not solve the previous 'crazy bug' as NanaZip that has been using * all these while is also getting reports of the issue.

So if we switch to * but still want an allowlist, need to modify the dll and do the checking there

I would like a allowlist, the same as with the manifest. Something to maintain but if it is the best method for all machines, we do it...

they seem to be handling shell extensions themeselves rather than using Windows APIs.

But the * part would permit to show MediaInfo context menu, right?

* will not solve the previous 'crazy bug' as NanaZip that has been using * all these while is also getting reports of the issue.

The * update would not put a regression there, right?

But the * part would permit to show MediaInfo context menu, right?

In Directory Opus case, yes. This app is handling shell extensions with * correctly as seen in the 2nd last screenshot. NanaZip, Notepad, Google QuickShare uses *. MediaInfo, Mp3tag, Microsoft Photos, Microsoft Paint uses extensions list in manifest and therefore is not loaded by that app. User should still report the issue to their developer as other shell extensions are missing.

The * update would not put a regression there, right?

Not expecting any regression but I cannot guarantee anything after seeing all these 'crazy bugs' on some systems that are not expected and cannot be reproduced. What I am sure is * works fine in all my previous tests and other apps that use * work fine on all my systems.

Opus developer here. We're happy to take a look at this, but on a quick test using the most recent version (downloaded from here) it seems to work ok for me (when right-clicking a JPG file anyway). Is there anything I need to do to make it stop working?

Opus developer here. We're happy to take a look at this, but on a quick test using the most recent version (downloaded from here) it seems to work ok for me (when right-clicking a JPG file anyway). Is there anything I need to do to make it stop working?

That's interesting. After getting reports from users that it was not working in Directory Opus, I tested in a Windows 11 24H2 VM and found that only for folders it is showing. For mp4, MediaInfo and Mp3tag were not showing while for jpg, MediaInfo, Photos and Paint were not showing. Screenshots are in https://github.com/MediaArea/MediaInfo/issues/994#issuecomment-2558482756 for folder and jpg. In my tests, the ones that appear happen to be the ones who declare * in their manifests and not ones with file extensions list. Maybe try installing more apps? In my test, the apps installed are in the last screenshot above. I used the publicly released version of each app including MediaInfo which is the same as the one you used.

I did a bunch of tests and found that whether Directory Opus shows MediaInfo in context menu depends on the file type.
Not working: webp, ogg, wav, mp3, webm, wmv, mp4, mov, avi.
Working: ico, tiff, gif, png, jpg.

For me, it doesnt show at all anywhere on the latest version nor the latest snapshot. Never shows up anywhere. Latest dopus.


HIDPI support

Hi! Can I somehow scale interface on 4k screen?

In the standalone, yes. In the LV2, possibly (may be host and version dependent). In the VST version, not yet. If you're interested in working on the VST functionality let me know and I can point you in the right direction.

In the standalone, yes.
How can I do that?

I'm using ardour so that means LV2 I guess.

Ah, standalone version resizes properly.

I'm not seeing any way to scale the UI when using the LV2 plugin. Would be great to have this functionality for HiDPI screens.


Ctrl+D should work with the item's links

User should be able to ctrl+d an item and it would return the price with the links preselected.
For example if I have a 6 link item, when I ctrl+d it, instead of showing the price of it unlinked, it should show the price of it as 6 links.
Please delete this if you're already had plans for this, or if it is already implemented.
Thank you for your hard work!

I'll add a basic default query per item type. In 0.5.1 there'll be a customisable version. See #13


Search within breadcrumbs no longer works

Version: 1.70
Operating System: Windows 10 AND Ubuntu 20.04
Extensions: C/C++ themes, Remote - SSH, Remote - SSH: Editing configuration Files, Remote - WSL
This is reproducible after disabling all extensions.
Issue description:
Before 1.70, you could click on a directory in the breadcrumbs view, and start typing to search for a file within that directory. That feature was originally added here: https://github.com/microsoft/vscode/issues/55004
Now, nothing shows up when you start typing. The list of files will automatically highlight a file which starts with the character you type in, but you cannot fully search the directory.
Attached is a screenshot showing the breadcrumb menu I'm talking about. I pressed the "f" key on my keyboard. You can see it highlighted the first file starting with 'f' but did not pull up a search box like it used to before 1.70.

In all the trees and lists, including the one used in breadcrumbs, you now need to begin a search/filter operation by pressing Ctrl/Cmd + F

Thanks @gjsjohnmurray, I did not realize that


proxy regexp isnt quite right

Should be
^(https?://)?([\da-z.-]+)(.([a-z.]{2,6}))?(:[\d])?([/\w .-])/?$
in fact I am not entirely sure that (.([a-z.]{2,6}) is needed.

@mjstein Is this issue still valid? or can I close it

Closing this issue due to no response


[gatsby-theme-minimal-blog]: Comments in MDX code blocks are with different size than other elements on iOS devices

Description
When using a longer comment in MDX code blocks, the font size and height of the comment are not with proper size. The comment is bigger than every other texts
Steps to reproduce
Add a longer comment in some MDX code block. For example // some comment here but if it is long enough it is broken"
Expected result
The size of the comment should be with the size of all other text.
Actual result
Size of the comment is not with the same size. In the screenshot below can be seen better:

Hi, thanks for the issue!
I followed your reproduction steps but don't see anything wrong?

Can you please share a reproduction project where I'd see this behavior?

Hi,
Yes, sure. The problem occurs only on iOS device (I tested it on iPhone 7). It can be tested on simulator as well, it was reproducible there as well.
Please let me know if this helps or if I should provide more information.

Fixed in<EMAIL_ADDRESS>

Thank you very much.


Theme customization: Custom Comment Brightness

Introduction
The low contrast color of comments is by design of Nord and has been selected specifically to not disturb code flow and keep the focus of the developer on the code. It is totally fine that users not agree to all highlighting color assignments, everyone has different preferences. That is the reason why themes exist 😄
Anyway, since I've got a bunch of tickets on various port projects with requests to increase the comment contrast I want to make sure the theme is adaptable to fit everyone's needs, even if I'm not going to change the default color.
In most cases the problem can be solved by using local overrides to adjust specific parts of the theme like I proposed in arcticicestudio/nord-vim #26 or arcticicestudio/nord-emacs #23, but providing a official theme customization is the optimal way to achieve this.
Description
A accessibility theme customization should be added to allow users to set the brightness of comments with percentage adjustments from 0% - 20% where 0 is the default nord3 comment color. When a invalid value is passed (< 0 || > 20 || nil) the default nord3 color should be used.
The customization should be available through the nord-comment-brightness variable.
This should be a optional customization to provide a way for users to adjust the color to fit their needs: It should be a port of the reference implementation from the Nord Atom Syntax project. The values should be calculated using the LESSCSS lighten function to ensure full interoperability with other port projects that providing this theme feature.

Increased by
Calculated value

0%  (default)
nord3

1%
#4e586d

2%
#505b70

3%
#525d73

4%
#556076

5%
#576279

6%
#59647c

7%
#5b677f

8%
#5d6982

9%
#5f6c85

10%
#616e88

11%
#63718b

12%
#66738e

13%
#687591

14%
#6a7894

15%
#6d7a96

16%
#6f7d98

17%
#72809a

18%
#75829c

19%
#78859e

20%
#7b88a1

Usage
Example to increase the comment color brightness by 15%:
(setq nord-comment-brightness 15)

This is really very impressive. Thanks a lot. I want this comment color highlight brightness for a long time. Because there is a issue posted before. but not improved a lot. This time is very good on comment and region (on another issue post). Thanks. REALLY.

@stardiviner Nice to see you like it :smile:
I'll merge the PR tomorrow and prepare a new release version.


New activity log UI

https://www.pivotaltracker.com/story/show/165692434
Audited::Audit is now independent of database connection and serves as an entity in our codebase.

@NoahFisher Ideally I'd like to switch over to something more appropriate to our use case. Here's a story: https://www.pivotaltracker.com/story/show/168167606
This is meant as a band-aid to keep the current codebase running

I'll let @heretge elaborate on reasoning. But I think it's fine to use this bandaid for now to not complicate the other PRs even further and use something else in place of this in a later PR (for which we have a story in the epic).

@NoahFisher These changes are directed to get rid of persistent database connection, which is required by any ActiveRecord model, Audit model in this case. So, I replaced it with an AR independent entity, removing all the stuff related to versioning and other AR-based features of the original gem. Also, I added monkey patches for Audit from our webapp, so they're all in one place.
I agree that some other gem would be a better fit now, but initially I thought it's the way to go to not change too much the webapp integration with it.


[Carbondata 3213] Fix no license files

[Carbondata 3213] Add license for no license files,include 3 md doc and 2 java files.
By this command,I add the license.
find /data/carbondata -name "*.java" | xargs grep -Lr "Licensed to the Apache Software Foundation" | xargs sed -e '1 r license.java' -e '1N' -i

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[N] Any interfaces changed?

[N] Any backward compatibility impacted?

[N] Document update required?

[N] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[N] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Can one of the admins verify this patch?

find /data/carbondata -name "*.java" | xargs grep -Lr "Licensed to the Apache Software Foundation" | xargs sed -e '1 r license.java' -e '1N'  -i
By this command,I add the license.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2101/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10355/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2306/

LGTM

LGTM


question about parFinder

|            - BTC -             |
+--------------------------------+
|      Alpha profit: 0.57 $      |
+--------------------------------+
|  Simple MACD profit: -0.16 $   |
+--------------------------------+
|  Complex MACD profit: 1.07 $   |
+--------------------------------+
|        Stop Limit: -4 %        |
+--------------------------------+
how should i interpretate this? balance in parfinder.py is 100 so  should i add every profit to final balance? 0.57+-0.16+1.07=101,48?

So Alpha profit is the profit someone would make if they put 100$ in bitcoin exactly 10 days ago and sold now. Simple MACD is the profit someone would make if they bought and sold accordingly at each intersection. Lastly Complex MACD is the profit someone would make if they used the same strategie but with a stop loss at the percentage below. In conclusion no don't add then. Each one is a different strategie. The aim of the tool is for you to decide which coin follows the MACD index the best.


Update README.md to add Kira's programming blog to quickblog examples

Please answer the following questions and leave the below in as part of your PR.

[ ] This PR corresponds to an issue with a clear problem statement.

[ ] I have updated the CHANGELOG.md file with a description of the addressed issue.

This is just a small PR to request adding my programming blog to the list of example quickblog blogs. Feel free to ignore if you feel it's not a good fit! Thank you for this amazing project.

Thanks!


Follow the version specification ~ for antora.yml

Follow up to https://github.com/rubocop/rubocop/commit/bb7e5b07.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Gutenberg 0.3.4 panics when building site

I have discovered that version 0.3.4 will not build my site, and provides a non-helpful error message:
Building site...
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Error(-114, target of repeat operator is invalid)', libcore/result.rs:945:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Error(-114, target of repeat operator is invalid)', libcore/result.rs:945:5

0.3.3 work, and 0.4.0 (built from source from the next branch) work.  It also seems like at least some other sites work with 0.3.4 on my local machine, so it doesn't seem to be an issue with my local environment.
Not a high priority issue since I can use other versions, but one that I wanted to raise—especially because I'm not sure how widespread the issue might be.

I did further testing and realized that the issue is related to the syntax highlighting feature.  Although I didn't remember initially, it was the same error I initially encountered in #326, which was caused by building from source without updating the submodules.  Is it possible that the 0.3.4 release did not include the latest upstream changes to submodules that are in 0.3.3?

There was probably a faulty syntax in 0.3.4 that has been fixed since then. I need to make sure I run all the syntect tests when I update the Sublime submodule


Undo/redo don't work after the file from the previous session has been closed

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
From title of issue:
Undo/redo don't work after the file from the previous session has been closed.
Note: In Safe Mode undo/redo don't work for any closed file, not only from the previous session.
Steps to Reproduce

Open existing file (or create the new one)
Edit this file
Close this file
Restore the last closed tab (Ctrl+Shift+T)

Undo/redo work (not in Safe Mode)

Close Atom
Reopen Atom

Undo/redo work

Close this file
Reopen this file (as in step 4)

Undo/redo don't work!

Expected behavior: Undo/redo work in any time and combination of situations.
Actual behavior: Undo/redo don't work in certain combination of situations.
Reproduces how often: 100%
Versions
$ atom --version
Atom    : 1.18.0
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0

$ apm --version
apm  1.18.1
npm  3.10.10
node 6.9.5 x64
python 3.6.2
git 2.13.3

$ uname -a
Linux Alex-ArchMainPC 4.11.9-1-ARCH #1 SMP PREEMPT Wed Jul 5 18:23:08 CEST 2017 x86_64 GNU/Linux

Additional Information
Missing.

Hi, thanks for pointing out this missing feature; it's not something we've attempted to implement. Currently, when you close a buffer, we don't hold onto any of that buffer's state.

Restore the last closed tab (Ctrl+Shift+T)
Undo/redo work (not in Safe Mode)

I'm surprised to hear that this works for you; I don't think we have any logic for doing this. Maybe you have some package installed that provides this behavior, but the package does not work when you reopen Atom?

I'm surprised to hear that this works for you; I don't think we have any logic for doing this. Maybe you have some package installed that provides this behavior, but the package does not work when you reopen Atom?

Oh, OK, I think it's a plugin, sorry (on another computer, can't check now). Thank you, my mistake.
I understood: Undo/Redo buffer works for Atom re-open, not file.
Can I change this issue for the wish of implementation Undo/Redo after file re-opening, or should I create a new one?

Yeah, I've updated the title of the issue to reflect the feature request. If you want, you could edit the body slightly to explain what you'd want Atom to do, and if there are any other similar text editors that do this.

Today I deleted some code to commit the change, and I thought I would simply undo that later to continue. Unfortunately, something got in the way. And by the time I realized, I've already closed Atom long ago. Then I reopened Atom, astonished, as I find the undo still works! I don't even know which package (or Atom itself) provides such a feature! It really saved my day.

Vim (and NeoVim) have the ability to do this out of the box.
Not only do they track history the history, but when you undo changes, then make new ones, it branches to a new line of history, so it keeps all branches of history you've ever done to the file.
Vim has key bindings for regular undo/redo (u and ctrl-r respectively), as well as bindings for traversing all undo/redo history regardless of branch in chronological order (g- and g+, respectively).
Then there's plugins like gundo that can show you a visual of your history, and let you click select items to navigate to.
For example, here's a screenshot showing the history of a file (rendered by gundo), including a branch where I undid some changes then started making new changes:

As you can see there, it shows the changes in chronological order (newest at the top), and also the branches. Pressing undo (u) makes it traverse up the tree to the parent in the tree, until you get to the root. Pressing redo (ctrl-r) makes it traverse all the way back to the leaf of the branch you were on. Pressing g- makes it traverse chronologically in the same order you see in the graph, and opposite for g+.
Here's a video of the history tree visible while I make branches of history:

I have Vim/NeoVim configured to keep the history cached on the filesystem, so if I restart (Neo)Vim and open the same file, I have all the undo/redo history in place and can continue to undo/redo and view the history.

Note, the green highlight if showing me the diff of what changed in the record, and only visible while the undo tree is open.

I landed on this issue, because due to some tooling, I lost all the work I did over the past two days. This feature would've come to the rescue and been a real time saver!

The persistent-undo package does the trick! Let me see if it works long term with no issues...
The undo-tree create a history tree.
undo-tree makes a history provider with buffer.setHistoryProvider. Does this mean persistent-undo will cache it to disk?
Then we need a way to traverse the current branch rather than the whole tree (undo-tree traverse the whole tree).
And then lastly (and optionally) we need is a way to visualize it and click on history items to go there directly.

Yep, verified, undo-tree works paired with persistent-undo!
However, if you have the vim-mode-plus package, then vim-mode-plus will override the history that undo-tree creates, so undo-tree doesn't work in this case. I opened an issue in vim-mode-plus: https://github.com/t9md/atom-vim-mode-plus/issues/1101.

Instead of having plugins implement undo history (f.e. undo-tree and vim-mode-plus both doing their own thing), seems like the tree functionality needs to be centralized in Atom itself, then undo-tree would not be needed, persistent-undo would still be useful, and vim-mode-plus would simply continue to provide the chunks that the user inputted (f.e. while in insert mode).

Verify that you can still reproduce the issue in the latest version of Atom

Yes.

What version of Atom you reproduced the issue on

1.41.0

What OS and version you reproduced the issue on

Arch Linux.

What steps you followed to reproduce the issue

The same as in the issue description.

Atom 1.53.0, no progression of this issue.


Require Sprockets < 4

Sprockets 4 does not support procs in config.assets.precompile which
we currently depend on in pageflow/engine.rb.
REDMINE-17098

Coverage remained the same at ?% when pulling 35cae55cbe0398df14ee48c8d352f90c9965082a on tf:sprockets-lt-4 into 964c78e71f23a48b2e6769997a5c5c37d30b75ff on codevise:master.


Missing note for developers migrating from Xam.Plugins.Settings

The first thought that I had when I started the migration from Xam.Plugins.Settings to Essentials.Preferences was that I should create—and I did—a copy of every current stored value in Settings into the Preferences implementation. But when I was on the final steps of the migration I found out that, in fact, both plugins access to the same file on device to fetch the associated values for the preferences defined in code.
I wasted a few hours on the unnecessary task of copying values between implementations and I take full responsibility for that. My suggestion is to add a note (like the above in italics) on the Preferences documentation for developers in my situation in order to help them save tame on the migration, which is reduced to change:
Settings way:
public string SettingSample {
  get => CrossSettings.Current.GetValueOrDefault(nameof(SettingSample), string.Empty);
  set => CrossSettings.Current.AddOrUpdateValue(nameof(SettingSample), value);
}

to the Preferences way:
public string SettingSample {
  get => Preferences.Get(nameof(SettingSample), string.Empty);
  set => Preferences.Set(nameof(SettingSample), value);
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7a399b1-a8a2-9cbd-c479-1bd98af46988
Version Independent ID: 91a6ae06-508b-b668-52aa-cbdeabb2b46a
Content: Xamarin.Essentials: Preferences - Xamarin
Content Source: docs/essentials/preferences.md
Product: xamarin
Technology: xamarin-essentials
GitHub Login: @jamesmontemagno
Microsoft Alias: jamont

I don't think this is something we would put on official docs. I outlined it all in a blog post: https://montemagno.com/upgrading-from-plugins-to-xamarin-essentials/

That's understandable. What about doing it the other way around, pointing out to this nice and detailed blog post on the SettingsPlugin repo? I opened a tab for each API reference but it didn't hit me until I dug a bit deeper.

Thanks for the feedback and suggestion @albertoms.


add 32-bit tests; return errors in case of string-to-int overflows

Codecov Report

Merging #39 (e6296fd) into main (77f9d31) will not change coverage.
The diff coverage is 88.88%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   71.38%   71.38%
=======================================
  Files          49       49
  Lines        4411     4411
=======================================
  Hits         3149     3149
  Misses        974      974
  Partials      288      288

Impacted Files
Coverage Δ

pkg/playlist/media.go
73.33% <80.00%> (ø)

pkg/playlist/media_skip.go
100.00% <100.00%> (ø)

pkg/playlist/multivariant.go
84.44% <100.00%> (ø)

pkg/playlist/multivariant_variant.go
93.33% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Create jmh benchmark project

Create jmh benchmark project to compare builder speed with regular constructor execution.
Variants:

deep tree structure
deep tree structure with defaults

Document was created here


ORA-27072: File I/O error Linux-x86_64 Error: 95: Operation not supported

I am trying to backup database using RMAN, I mounted Azure blob storage container using goofys on my DB server and tried to run backup, got this:
RMAN-03009: failure of backup command on disk1 channel at 04/30/2022 20:17:09
ORA-19502: write error on file "/dbbackup/790s9423_1257_1_1", block number 1 (block size=16384)
ORA-27072: File I/O error
Linux-x86_64 Error: 95: Operation not supported
Additional information: 4
Additional information: 1
Additional information:<PHONE_NUMBER>

After that tried to create a text file from oracle user using touch a, it succeeded.
Also tried to create a parameter file from sqlplus (note the parameter file was in text format), it succeeded.
But when I tried to create binary file from database, it failed:
SQL> create spfile='/dbbackup/spfile' from pfile='/dbbackup/pfile';
create spfile='/dbbackup/spfile' from pfile='/dbbackup/pfile'
*
ERROR at line 1:
ORA-27072: File I/O error
Linux-x86_64 Error: 95: Operation not supported
Additional information: 4
Additional information: 1
Additional information:<PHONE_NUMBER>
ORA-01078: failure in processing system parameters
ORA-27072: File I/O error
Linux-x86_64 Error: 95: Operation not supported
Additional information: 4
Additional information: 1
Additional information:<PHONE_NUMBER>
ORA-27072: File I/O error
Linux-x86_64 Error: 95: Operation not supported
Additional information: 4
Additional information: 3
Additional information:<PHONE_NUMBER>

Is not goofys supported with Oracle database?

My fstab entries is the following:
<EMAIL_ADDRESS>     /dbbackup         fuse    _netdev,allow_other,--file-mode=0777,--dir-mode=0777,--uid=3001,--gid=2000    0       0


docs: fix link in doc for cmsg_space in sys/socket

Link to cmsg_space macro for recvmmsg and recvmsg should
be the doc's root of crate as macro is an exported macro.
Signed-off-by: bin liu<EMAIL_ADDRESS>

bors r+


page.text showing empty

When I try to print the pdf text, it is showing empty but there is plenty of text in the PDF. Other PDFs created the same way work just fine. Not sure what it is about this particular one that makes it not work. Sorry, cannot post the PDF.

Nevermind. This may have been my error.


Question: error "turnprogress not defined" and "no method matching _setadbackend(::Val{:reverse_diff})"

Question on: https://github.com/TuringLang/Turing.jl/edit/master/docs/_docs/using-turing/guide.md
Hi, I just start to learn Turing by following the documentation. When I ran
Turing.turnprogress(true)

I got the error message: "UndefVarError: turnprogress not defined"
when I ran
Turing.setadbackend(:reverse_diff)

I got the error message: "MethodError: no method matching _setadbackend(::Val{:reverse_diff})"
All of my code is below:
using Turing, Flux, Random

Turing.turnprogress(true)
Turing.setadbackend(:reverse_diff)

I'm using Atom, with Julia Version 1.5.2 (2020-09-23), and I installed Turing today. My computer is MacBook Pro (16-inch, 2019) with 2.6 GHz 6-Core Intel Core i7.
I tried to re-start Julia, but it won't help. Could you please tell me how to fix it?
Thank you so much,
Tianjing

With the latest Turing releases (version 0.15) you have to use setprogress!(true) and setadbackend(:reversediff).

Thank you!


MongoDB and MySql Integration!

feature request
Integration for MongoDB and MySql?
Also is the uplink data is directly inserted into the database?

This won't be supported but please note that LoRa App Server supports sending data over:

GCP Pub/Sub
MQTT
HTTP
InfluxDB

Using the Pub/Sub, MQTT or HTTP integration one could easily write an application to write the data to a database of choice :-)


Implement 501 - Decouple Cluster.Name from Cluster.Endpoint and Cluster.CABundle

Decouple Cluster.Name from Cluster.Endpoint and Cluster.CABundle and add
support to dynamically load CABundle from in-cluster configuration.
Issue, if available:
#501
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you remove the "Implement 501" from the PR Name? We use PR Names to generate release notes, and the issue # will be included if it's tagged to this issue.


Problem saving netcdf from hgt file

When opening a hgt file in SurfaceTopography and saving the netcdf file, there is an error:
In [9]: from SurfaceTopography import open_topography
In [10]: reader = open_topography("../data/hgt/N00E072.hgt")
In [11]: t = reader.topography(physical_sizes=(1, 1))
In [12]: t.to_netcdf("/tmp/hgt.nc")
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Input In [12], in <module>
----> 1 t.to_netcdf("/tmp/hgt.nc")

File ~/work/imtek/topobank/venv/lib/python3.8/site-packages/SurfaceTopography/HeightContainer.py:90, in AbstractTopography.__getattr__.<locals>.func(*args, **kwargs)
     89 def func(*args, **kwargs):
---> 90     return self._functions[name](self, *args, **kwargs)

File ~/work/imtek/topobank/venv/lib/python3.8/site-packages/SurfaceTopography/Support/Bibliography.py:71, in doi.__call__.<locals>.func_with_doi(*args, **kwargs)
     69 doi.dois.update(self._add_these_dois)
     70 doi._n += 1
---> 71 retvals = func(*args, **kwargs)
     72 doi._n -= 1
     73 if doi._n == 0:
     74     # We have reached the point where the original `dois` argument
     75     # was passed. Create a new set such that subsequent calls don't
     76     # contaminate the bibliography.

File ~/work/imtek/topobank/venv/lib/python3.8/site-packages/SurfaceTopography/IO/NC.py:433, in write_nc_uniform(topography, fobj, format)
    430     x_var.unit = mangle_length_unit_ascii(topography.unit)
    432 if topography.dim > 1:
--> 433     x_var[...] = np.arange(nx) / nx * sx
    435     y_var = nc.createVariable('y', 'f8', ('y',), **var_kwargs)
    437     y_var.length = sy

File ~/work/imtek/topobank/venv/lib/python3.8/site-packages/scipy/io/netcdf.py:1004, in netcdf_variable.__setitem__(self, index, data)
   1002     recs = (rec_index.start or 0) + len(data)
   1003 else:
-> 1004     recs = rec_index + 1
   1005 if recs > len(self.data):
   1006     shape = (recs,) + self._shape[1:]

TypeError: unsupported operand type(s) for +: 'ellipsis' and 'int'

Related to https://github.com/ContactEngineering/TopoBank/issues/789.

There is actually a tests that open the example data files in order, saves to NetCDF and reads again. Not sure what is going on here, will check.

Closing this as the whole renewal mechanism has been rewritten with #1012


[bugfix]: fix logging problem when use deeprec

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


STOCK OUT DATA

App syncs STOCK OUT data to the server. The 1st day in the month for which the commodity STOCK ON HAND is zero, App syncs a count of 1 to the server, on 2nd day, app syncs count of 2. app only stops sync when STOCK ON HAND for that commodity is >1, if STOCK ON HAND =0 later in the same month, then app continues STOCK OUT sync from last count (ie 3).
The STOCK OUT is reset on the 1st of every month to zero

Who wrote this please? Can you sign your name?
In what context is this written? Which feature/story number?
Thanks!

This is in context of the SOH app sync, the STOCK OUT days was previously calculated in the SOH script, but as this script is going to be disabled on the server, the app will need to calculate and sync this data to the server

I believe it was Egwuma who wrote this.
Egwuma/@chai-lmis - why are we disabling this script as well?

@ Laskshmi, the SOH script is bundled with the carry forward and AMC calculations

@chai-lmis Ok, makes sense. Are there any other scripts bundled with the SOH calculation? Jason was to provide documentation on the scripts, do we have an update on that?

Just to be clear, are you saying all scripts on the server will be disabled? Or, will certain calculations that were previously done in scripts be turned off, while others will remain?

@chai-lmis Could you confirm.
@karlwbrown Only the script doing SOH calculation is being disabled. However (a) the SOH carry forward code (i.e. next day SOH = previous day SOH) is part of this script, as is (b) # Stock out days calculation. I don't think there are others but will let Egwuma confirm.

This calculation was bundled with the deactivated SOH scripts.NOS OF STOCK OUT DAYS (which is sent as a daily value to the serve) is used to calculate AMC on the server which in turn is used to calculate the MAX/MIN stock levels & the MAX/MIN stock in months, these values are synced from the server to the client.

@chai-lmis, so what you mean is that the MAX/MIN stock value is calculated by the SOH value server receives from the app? But since we don't always sync zero value to the server(issue tracked in #269), but it seems the MAX stock value is always zero.

As previously explained in my comments, the STOCK OUT days was previously calculated in the SOH script, but as this script is going to be disabled on the server, the app will need to calculate and sync this data to the server.
App syncs STOCK OUT data to the server. The 1st day in the month for which the commodity STOCK ON HAND is zero, App syncs a count of 1 to the server, on 2nd day, app syncs count of 2. app only stops sync when STOCK ON HAND for that commodity is >1, if STOCK ON HAND =0 later in the same month, then app continues STOCK OUT sync from last count (ie 3).
The STOCK OUT is reset on the 1st of every month to zero


Add github actions to generate deb and rpm packages

https://github.com/marketplace/actions/build-deb-action
https://github.com/marketplace/actions/build-rpm-action

Alternatively this could be used: https://goreleaser.com/ci/actions/


Reverting the namingScheme changes.

why are we taking this out?

Joel found an issue in his testing referred here: https://github.com/bluek8s/kubedirector/issues/309#issuecomment-658484754

Yah unfortunately. Thanks Koshik; I do like the gist of this and look forward to getting it whipped into shape for the next release.

I'll handle updating the KD addon in everest accordingly.

Thanks Joel!


Update to include Python library

Hi, we've created and are maintaining the kubernetes-py library. It uses python objects to manipulate the kubernetes API objects. We're using it to manage our operations on kubernetes daily.

This change is

I've just signed the CLA. not sure how to update the above checks.

/lgtm


Fix #225

Coverage increased (+0.1%) to 84.719% when pulling 2a7d6cf60c86a6a67fe14c006e9957fb1fe37954 on kamo-naoyuki:fix-225 into b998bae17e5bdc7f9b14461b875ab86af182ea43 on IDSIA:master.

Hey, thanks for tackling this. But your version now doesn't filter the stacktrace at all anymore. The reason I implemented my own formatting was to strip away the many internal calls that sacred uses for captured functions and the like. That way they wouldn't clutter the stacktrace. And I'd like to keep that behavior.
Also,  disabling the filtering can already be done using the -d flag.

Sorry, but I didn't understand what "filtered" means, I'll try to reproduce it.

Oh, sorry for no being clear. The while loop in the else block only prints stack frames that are not part of the code base of sacred (marked by having a __sacred__ = True variable). So ideally this should be changed to not only iterate through the stackframes of the current exception but also print other exceptions. If that is too complicated, it might also be an ok solution to first print the output tb.format_exception as you have it, and then print the filtered stacktrace afterwards.

Coverage decreased (-0.7%) to 83.897% when pulling 46a0f4d343ac84c72ae47e1aad5e98fe1d6f14d3 on kamo-naoyuki:fix-225 into b998bae17e5bdc7f9b14461b875ab86af182ea43 on IDSIA:master.

I appended a function named as "filtered_traceback_format" in utils.py.
It is originated from traceback.TracebackException.format and I modified it to filter the stack trace from sacred, but I'm not sure that my code achieves your purpose.
I only tested on Python3.
In fact, my code is touching the private value of traceback(TracebackException.cause, TracebackException.context, etc), and I have no idea to implement it safely.

Sorry, the syntax of "yield from" doesn't exist in python2. It seems vert difficult for me to solve this.

Coverage decreased (-1.007%) to 83.588% when pulling be7d7ecd2dc1b15c064ffa44a62ff004f55b916e on kamo-naoyuki:fix-225 into b998bae17e5bdc7f9b14461b875ab86af182ea43 on IDSIA:master.

I'm sorry for not reacting. I didn't have time yet to look into this, but I haven't forgotten.


Where are the options on the doc page?

Going at the GitHub index I can find them:

But why they are not on the page itself?
https://github.com/onsip/SIP.js/blob/master/docs/api/sip.js.registererregisteroptions.md

Why split the documentation over so many small pages which does not link everything? This documentation is quite bad. I am not criticizing the contents, but the organization. So many quite small pages make things really hard to find.
But out of topic, it would be nice to have small usage examples as this other documentation does: https://www.doubango.org/sipml5/docgen/symbols/SIPml.Stack.html#newSession

That other documentation also has a problem which splitting things into several pages making things harder to find, but it has much less pages than this documentation. It has about 10 pages, which is tangible to open all in the browser and search for what I am looking for.

I think I just found a page with the options: https://github.com/onsip/SIP.js/blob/master/docs/api/sip.js.registereroptions.md

But again, that page links to several small pages with only few lines each. This make really harder to search for something.
Instead of opening each option on its own page, you can create an anchor on the own options page.

This would significantly reduce the number of pages and would be quite an improvement for what it is today.
My in opinion, everything should be in a single page with anchors (and summary).
But beginning by putting things like the RegistererOptions options on the same page with anchors to each item, would be great first improvement.

It is hard to find stuff when there are quite large number of pages to open because I do not know nothing about this project. Then, I have to read everything. And most important, re-read the same thing several times. So, if everything is scattered into countless pages, I have to open countless browser tabs, to keep track of each thing, but with so many small pages, it is not possible to open that many browser tabs because I would not know which one is what.
On the contrary, if there are a handset of pages to open and read, I can keep track of them and keep they open on the browser.
If you wonder, in case I need to read two different places in the same page, I can open two browser tabs into the same page.

The docs are generated automatically using https://www.npmjs.com/package/@microsoft/api-documenter. If you want to improve them we would happily take a PR.

Better documentation is always good to have. The docs are autogenerated at the moment. If you want to improve them we would happily take a PR.


Public phone call

James Randall brought up a good point https://twitter.com/AzureTrenches/status/1177575068798529537?s=09
Maybe someone should host a community call. There's been some discussion of one in the project leaders circle but maybe it should be opened up to a wider audience.

Totally agree.
How about I post some times to have calls, maybe starting on Tuesday (give a chance to the word to get out). Does that work?


fix linting build

I'm adding the standard ci workflow, but couldn't make the lint build pass.
We should add lint build.

This is failing because the lint command is using gts which is linting for typescript. This is a pure js library, so we can't use gts.


refactoring of maintainability calculation

Make the the maintainability calculation to a function with return value
and push settings.newmi direct. That allows a clear report building in
the main function.

Coverage increased (+0.002%) to 98.822% when pulling f8fec4ad094aadd98adc85735a69598417f76eff on Thomas-P:tp-refactor into 2bc3d40f8973539f91c6bc4e7b40a3175617d1c7 on escomplex:master.

Very cool. Thanks for making this better! 👍


stalled loading initial load -

Storage Explorer Version: 1.6.2
Platform/OS Version: MacOS 10.13.6
Architecture: x64
Regression From: N/A
Steps to Reproduce:

Installed the app.
Tried to run the app. Stuck at "Loading".

Expected Experience:
Present a sign in prompt or some sign of working.
Actual Experience:
App spins forever saying "Loading"
Deleted App Support folder and restarted.  No help.
App Support folder doubled in size, 300k to 600k after 10 minutes. No change after 30 minutes.
Exits gracefully.

Can you open Activity Monitor and see how may Storage Explorer processes open up?

My apologies for not checking back in.
After reboot the software worked as expected.
Mike!

On Feb 6, 2019, at 12:03 PM, Craig<EMAIL_ADDRESS>wrote:
Can you open Activity Monitor and see how may Storage Explorer processes open up?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Revert "Rewrite StatusPage proxy"

Reverts vespa-engine/vespa#6286
StatusPageControllerTest now fails. Running it manually I see this start of the json response:
{"partial_result":{"page":{"id":"g76hfj4nmsyt","name":"Vespa", ....  I have no idea what's going on with the 'partial_result' there...

Slime bug. Fixed by not using slime for ow.


Improve placeholder text in the PreferencesWindow to help novice users

Previously Karabiner was a set and go application. Now people are having
a hard time figuring out how to configure the app.
Case in point,
https://github.com/tekezo/Karabiner-Elements/issues/48
https://github.com/tekezo/Karabiner-Elements/issues/88#issuecomment-248861794
https://github.com/tekezo/Karabiner-Elements/issues/88#issuecomment-248883236

Thanks!


feat: add retry to agol publish calls

Closes #109
Here's what a test of the retry logic looked like:

We could add it to other methods as well if they become a problem.

@jacobdadams The way that I think of lambdas in python is anonymous functions. Thanks for the review.

I've never seen that way of creating a generic interface for passing any function by wrapping it in a lambda function (if I'm understanding the code correctly). Cool!

It's a very handy technique. A lot of people don't realize that you can pass functions as arguments in python. They can really help to remove code duplication.
Scott is using it in a funny way here though. Since python can pass a function by reference and the function in question doesn't have any parameters, the function can be passed without the () and executed in the other method. If you were to expand the lambda as it is written it would be like
def anon_function():
    source_item.publish()

which is basically the same as source_item.publish(). Hopefully that highlights the redundancy.
Lambda's are mainly used for one liners e.g. function_reference = lambda x: x + 1. These are mostly appropriate for simple things like sorting or filtering functions. Inline function are typically more refactor friendly since they don't have any limitations. For instance lambda's can not have multiple expressions. So if you wanted to add more logic to the lambda: source_item.publish() you would have to convert it to an inline method.

Yeah, passing functions as args was new to me too. I've used lambdas once or twice for custom sorts. I was wondering, in this instance, if passing the lambda allows extensibility because now that whatever function you're passing is encased in a lambda it can have any number of arguments without altering retry()? Or does the signature of the function you're passing in as a parameter get "bundled up" (for lack of a better term) and remembered for when you call function_argument() later in the higher-order function?

are you thinking we might move this to the seat module of forklift or something?

We could if we feel like it would be useful for other pallets. It might be good to be in its own package since it's not something specific to forklift. Although at that point it might be just as easy to use an existing library.

I was wondering, in this instance, if passing the lambda allows extensibility because now that whatever function you're passing is encased in a lambda it can have any number of arguments without altering retry()? Or does the signature of the function you're passing in as a parameter get "bundled up" (for lack of a better term) and remembered for when you call function_argument() later in the higher-order function?

I would say that my retry in this case is expecting a function with zero parameters. That's why I'm wrapping some in lambdas. That way they don't require any parameters.


Simplify assert with simpler and equivalent calls.

Codecov Report

Merging #123 (10e6aaf) into master (40fa3aa) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     64.52%   64.55%   +0.03%
+ Complexity     1558     1557       -1
============================================
  Files           105      105
  Lines          5809     5809
  Branches       1068     1068
============================================
+ Hits           3748     3750       +2
+ Misses         1615     1614       -1
+ Partials        446      445       -1

Impacted Files
Coverage Δ

...ava/org/apache/commons/beanutils2/MethodUtils.java
63.88% <0.00%> (+0.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fa3aa...10e6aaf. Read the comment docs.