React to SHA-1 collision (SHAttered).

On February 23, 2017, CWI Amsterdam and Google, demonstrated a first real SHA-1 collision. (https://shattered.io/) Although many of us were aware that this would happen any time soon, we must ensure that the security of Gratipay's users is not affected in any way.
Summary

Original: http://www.poorlydrawnlines.com/
Edited by: https://twitter.com/nathonsecurity
Investigation
Gratipay will take the necessary precautions to remediate any issue related to SHA-1.
Gratipay took the following steps during the investigation:

Ensure none of our services use SHA-1 (HMAC-SHA-1 is not really a problem).
Ensure that no services used by Gratipay use SHA-1.

We checked whether:

Certificate chains are signed with SHA-1. (Certificate)
SHA-1 was used somewhere in the source code. (Source code)
SHA-1 was present somewhere anywhere else. (Other)

Does Gratipay use SHA-1?

Service
Certificate
Source code
Other

gratipay.com
NO
NO
NO

assets.gratipay.com
NO
NO
NO

downloads.gratipay.com
NO
NO
NO

grtp.co
NO
NO
NO

Are any services used by Gratipay affected?
Gratipay uses 6 OAuth providers, which we believe are not affected by this incident.

We would like to thank CWI Amsterdam & Google for their fantastic work.

Psst...
	If you are interested in learning about SHA-1 and cryptography in general, I would highly recommend you have a look at https://www.crypto101.io/.

😳
<details>
  <summary>Psst...</summary>
	If you are interested in learning about SHA-1 and cryptography in general, I would highly recommend you have a look at https://www.crypto101.io/.
</details>

¯_(ツ)_/¯

Any implications for our Git usage?
https://plus.google.com/+LinusTorvalds/posts/7tp2gYWQugL
I suppose this is something GitHub would start addressing?

Any implications for our Git usage?

This is not something we should really worry about as of right now. I will let you know if there are any updates in the future.
In case someone is interested, here is a StackOverflow discussion demonstrating how Git would handle a SHA-1 collision on a blob: https://stackoverflow.com/a/34599081

I suppose this is something GitHub would start addressing?

I hope so.

!m @EdOverflow

https://github.com/git/git/commit/e1fae930193b3e8ff02cee936605625f63e1d1e4

https://github.com/blog/2338-sha-1-collision-detection-on-github-com


Enables recorders to go directly to the field slip edit page

Recorders are currently defined as project admins during the project's date range.  To test:

Create a project whose current date range includes todays date (including projects with no date range).
Go to a QR code URL for an existing observation that uses the field slip prefix for that project.
This PR should take you directly to the field slip edit page rather than the corresponding observation (where you used to have to do two more clicks to get to the field slip edit page).

When the current time is outside the project's date range (or if the current user isn't a project admin), the QR code should take you to the corresponding observation.
This PR also switches back to saying "Create New Observation" on the edit field slip page vs. "Add Images and Other Data" to contrast with "Quick Create" when you are creating a new field slip.

coverage: 93.432% (+0.003%) from 93.429%
when pulling 83c422a2c2455b484556f9a743899c54cfb3a610 on njw-direct-edit-from-field-slip
into 69eef8d0304f8c73729f12367719ff241c02675e on main.


fix: Fix CocoaPods umbrella dependency

fixes #195

Can I contribute to this getting fixed in anyway? I'm new to the open source community and don't know if/how I can help.

How: If you manage to build VisionCamera with the Pod fixes that would work
If: I don't know if you can contribute, you must know that 😄


lxqt.lxqt-archiver: add missing dependence libraries

Description of changes
Fixes the error while loading shared libraries:

libmenu-cache.so.3: cannot open shared object file: No such file or directory
libexif.so.12: cannot open shared object file: No such file or directory

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1179


[coc.nvim]: Error on InsertLeave: Cannot read property 'textDocument' of undefined

Since a72ccfb, I see this error when I press <CR> to apply the sink:

I have opened #575 to fix this, not sure whether you have the same problem, please take a look at it :) @romgrk

TBH I'm not sure I understand the implications of #575, does not using stopinsert prevents InsertLeave from being triggered?
Also I consider this a coc-rust-analyzer bug, I had already opened https://github.com/fannheyward/coc-rust-analyzer/issues/427 a few days ago. After running CocUpdate, I didn't encounter the issue anymore.

does not using stopinsert prevents InsertLeave from being triggered?

Or prevent triggering insertLeave when the document is undefined?
Since #575 is equivalent as before from the view of vim-clap, and some people might have not upgraded coc-rust-analyzer, #575 does not bring any harm, I think it's ok to merge it in even the upstream already fixed this issue.

Ok, sounds good to me then :)


HA Cluster ERR_SSL_PROTOCOL_ERROR

What kind of request is this (question/bug/enhancement/feature request):
question or bug? I'm not sure if I'm doing something wrong with my HA install
Steps to reproduce (least amount of steps as possible):

clean install of Ubuntu 18.04 (with LVM enabled) on 3 machines
these exact steps

Result:
Originally this worked...now, with no changes that I'm aware of I always get ERR_SSL_PROTOCOL_ERROR.
Other details that may be helpful:
this is exactly how I prepared each node via RKE
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): I used helm repo add rancher-stable https://releases.rancher.com/server-charts/stable
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): RKE
Machine type (cloud/VM/metal) and specifications (CPU/memory): Baremetal
Kubernetes version (use kubectl version): v1.13.5

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-19T22:12:47Z", GoVersion:"go1.12.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.5", GitCommit:"2166946f41b36dea2c4626f90a77706f426cdea2", GitTreeState:"clean", BuildDate:"2019-03-25T15:19:22Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

Docker version (use docker version):

Client:
 Version:           18.09.6
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        481bc77
 Built:             Sat May  4 02:35:57 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.6
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.8
  Git commit:       481bc77
  Built:            Sat May  4 01:59:36 2019
  OS/Arch:          linux/amd64
  Experimental:     false

Seems similar to his issue, but I was unsuccessful with his steps https://github.com/rancher/rancher/issues/17906

sorry should I give more info?

@marcstreeter
This issue has fixed in 2.2.4
Please try again. Thanks


How to import this plugin in ionic project

Hi.
I want to know how to import this plugin in ionic angular project.
I tried the following but it sometimes causes error.
import { CordovaWebsocketPlugin } from "cordova-plugin-advanced-websocket/www/plugin.js";
declare const CordovaWebsocketPlugin: CordovaWebsocketPlugin;
Is there ionic native wrapper in this plugin?

There is no Wrapper for this Plugin. You can use it simple by:
// @ts-ignore
CordovaWebsocketPlugin.wsSend(...);

The ts-ignore is necessary for me as my idea doesn't know this Object at this Point.

an example would be very helpful.
core.js:4127 ERROR Error: Uncaught (in promise): ReferenceError: CordovaWebsocketPlugin is not defined
ReferenceError: CordovaWebsocketPlugin is not defined

import {Injectable} from  from '@angular/core';
...
declare var CordovaWebsocketPlugin: any;

@Injectable({
  providedIn: 'root'
})
...

There is no official wrapper for this plugin, but i made one for my project. I can put it in wiki.

https://github.com/HomeControlAS/cordova-plugin-advanced-websocket/wiki/ionic-typescript-wrapper

Hello,
I have been struggling to make this work for the past day so I gently ask for some help here.
If I should start a new thread let me know (I believe I have the same problem as the original author but there is no definitive answer from him as to what he did).
The more I look into it the more I feel I am missing some elephant configuration in the room, any help is really appreciated !
NB: I have this Stackoverflow running for the same question : https://stackoverflow.com/questions/69950489/how-can-i-use-cordova-plugin-advanced-websocket-with-capacitor
I tried to create a new ionic project with both capacitor and cordova but I end up with the same errors :
ionic start websocket-test
cd websocket-test
ionic build
ionic cordova platform add android
ionic cordova plugin add cordova-plugin-advanced-websocket
ionic serve
Then add the following into the src/app/home/home.page.ts constructor:
const wsOptions = {
  url: 'wss://echo.websocket.org'
};

window.CordovaWebsocketPlugin.wsConnect(
  wsOptions,
  event => { // CordovaWebsocketEvent
    console.log(`Received callback from WebSocket: ${event?.callbackMethod}`);
  },
  success => { // CordovaWebsocketSuccess
    console.log(`Connected to WebSocket with id: ${success.webSocketId}`);
  },
  error => { // CordovaWebsocketError
    console.log(`Failed to connect to WebSocket: code: ${error?.code}, reason: ${error?.reason}`, error?.exception);
  }
);

With:

CordovaWebsocketPlugin.wsConnect(...) (with or without // @ts-ignore)
-> I get the error: Cannot find name 'CordovaWebsocketPlugin'.
window.CordovaWebsocketPlugin.wsConnect(...)
-> I get the error: Property 'CordovaWebsocketPlugin' does not exist on type 'Window & typeof globalThis'.

@G-Cyrille did you try to import it after installing types:
import {
  CordovaWebsocketOptions
} from 'cordova-plugin-advanced-websocket-types';

Hello @chax
Thank you for answering, I have just tried on my empty cordova project (with the installation described in my previous comment) to change the home.page.ts with :
import { Component } from '@angular/core';
import {
  CordovaWebsocketOptions
} from 'cordova-plugin-advanced-websocket-types';

declare let CordovaWebsocketPlugin: any;

@Component({
  selector: 'app-home',
  templateUrl: 'home.page.html',
  styleUrls: ['home.page.scss'],
})
export class HomePage {

  constructor() {

const wsOptions: CordovaWebsocketOptions = {
  url: 'wss://echo.websocket.org'
};

CordovaWebsocketPlugin.wsConnect(
  wsOptions,
  event => { // CordovaWebsocketEvent
    console.log(`Received callback from WebSocket: ${event?.callbackMethod}`);
  },
  success => { // CordovaWebsocketSuccess
    console.log(`Connected to WebSocket with id: ${success.webSocketId}`);
  },
  error => { // CordovaWebsocketError
    console.log(`Failed to connect to WebSocket: code: ${error?.code}, reason: ${error?.reason}`, error?.exception);
  }
);
  }

}

I still get the error on starting the web application;
ERROR Error: Uncaught (in promise): ReferenceError: CordovaWebsocketPlugin is not defined
Would it help if I commit this "blank" project on github ?


Fixed according to Ollama API specifications

Description
According to the documentation provided here, the response returns "embedding" instead of "embeddings".
{
"embedding": [
0.5670403838157654, 0.009260174818336964, 0.23178744316101074, -0.2916173040866852, -0.8924556970596313,
0.8785552978515625, -0.34576427936553955, 0.5742510557174683, -0.04222835972905159, -0.137906014919281
]
}
Therefore, I have modified the part of the code that references the response from the Ollama provider to use "embedding" instead of "embeddings".
before

after

Nice catch!  Thank you


vcchone

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e4e2ac78-e08b-d7c8-5eec-baf9e9c13b62
Version Independent ID: 66014f69-00c9-0e9b-fe0a-d0e10f2ca5eb
Content: About registration numbers and under-review notifications
Content Source: microsoft-365/commerce/about-registration-numbers.md
Service: microsoft-365-business
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

[在此处输入反馈]

https://docs.github.co


node analyzeBuffer example not working

This might be happening, because the lastfm mp3 urls are not working as expected.
They redirect to the home page these days.

Fixed, thanks

great module, thanks :+1:


Calling publish method with QoS > 0 throws error

Publishing using qos > 0 will throw an error due to the localstorage calls - localstorage is set as a Map initially in lieu of the browser's local storage, but then it is called using localstorage.setItem / localstorage.getItem / localstorage.removeItem (localStorage api)
These will need to be updated with the map equivalent Map.set, Map.get, Map.delete function calls, respectively, to support qos > 0 when publishing.

same issue

fixed in nativescript-mqtt-new :)


ISPN-9173 Workaround: check the actual members

https://issues.jboss.org/browse/ISPN-9173
Availability mode should be updated atomically with the actual members.
Until that is implemented, we change the tests to wait for the actual
members to change before checking key availability.
Please don't close the JIRA yet.

Still 2 partition handling test failure and 1 conflict resolution failure, I guess this PR was not supposed to fix the tests?

@gustavonalle not all of them, that's for sure...
All these failures are related to https://issues.jboss.org/browse/ISPN-9291:

CrashedNodeDuringConflictResolutionTest.testPartitionMergePolicy fails because the isolated node requests the retransmission of too many messages after the merge
PessimisticTxPartitionAndMergeDuringPrepareTest.testPrimaryOwnerIsolatedPartition and OptimisticTxPartitionAndMergeDuringCommitTest.testPrimaryOwnerIsolatedPartitionWithDiscard most likely fail because the TxCompletionNotificationCommand message that was sent in a partition is not retransmitted to the isolated node after the merge (the ISPN-9291 fix makes them fail every time)

Merged


WIP docs reorganization

Closing; merge-squashed into https://github.com/locationtech/geomesa/pull/935 instead.


change behavior of drainGracePeriod to be smoother for brief outages

Currently drainGracePeriod() causes a hard down if prosody is marked unhealthy due to a health check timeout. We should change this behavior to go into drain if a timeout is causing the issue with prosody.

@aaronkvanmeerten @bgrozev
proposed criteria for hard down (down immediately) vs soft down (drain for grace period then hard down):

hard down if jicofo times out or returns a 500
soft down if jicofo returns 503 because it has no jvbs
hard down for a 5xx from prosody
soft down for prosody timeouts


Debug / Release Toggle

I'm looking at moving from FlashDevelop with just one remaining issue. In FlashDevelop it's possible to use CONFIG::debug as a conditional for Debug / Release. Is there something similar in AS3MXML to be implemented? I have both debug and release options in the launch.json file, so would ideally like to determine which is set on build and respond accordingly.

You can use the define field in the compilerOptions section of asconfig.json for conditional compilation. As of right now,  you'll need to manually change the value of CONFIG::debug when you switch between debug and release build tasks. There's no way to do it automatically yet.
I'm working on a new field in asconfig.json, named extends, that will allow you to reference another asconfig file to use as a base and then tweak some of its values. So, you'll be able to have asconfig.json for debug builds that sets CONFIG::debug to true and all of your main stuff, but then you can also create asconfig.release.json for release builds that extends asconfig.json and sets CONFIG::debug to false.

Thanks Josh, yes I had looked into the define field. The changes to asconfig sound great. Thanks for all your work.


Improve ci

Build the docker images in parallel with running the go unit tests and then upload the images to Google Artifact Registry for staging.
This is builds upon & replaces PR #1633
flowchart TD;
  build-gitops-image[build gitops image]-->gitops-image[/gitops image/]:::asset
  gitops-image-->upload-images;
  build-gitops-server-image[build gitops-server image]-->gitops-server-image[/gitops-server image/]:::asset
  gitops-server-image-->upload-images;
  go-tests[run go unit tests]-.->upload-images;
  ui-tests[run ui tests]-.->upload-images;
  lint[run linters etc.]-.->upload-images;
  upload-images-->finish-ci;

  classDef asset fill:#9f9,stroke:#363;

Successful run here: https://github.com/weaveworks/weave-gitops/actions/runs/1968917828

@jpellizzari I think I've got it so that it'll only push on merge but I've had to create a secondary 'all done' check so not sure if the checks will fully work or not so might have to revert that change

@jpellizzari I don't think we need to although tools in docker images seem to becoming more common place and it may make a nice way to get hold of it for testing.


Colors are differents from provided screenshots

Hello,
I first installed Tmux theme, the colors were exactly the same as on the screenshots of the site.
Then I installed the theme for Gnome terminal.
And now, I find myself with some weird colors (see the following screenshots).
On my system:

On the website:

Hi @MorpheusH3x :wave:
Have you installed the corresponding Nord terminal theme (Nord GNOME in your case) like described in the Nord tmux installation documentations (blue information boy at the top op the page)? Otherwise the actual Nord colors are not available so the mapping of this tmux theme can not be mapped to the colors properly.

awesome, this fixed most of the weird stuff for me! I still have one minor bone to pick: can you see those lines on the first separator? Is that fixable?


fix(lspinfo): fix autostart value reporting

config.autostart is a function in make_config_info.
https://github.com/neovim/nvim-lspconfig/blob/3a5d94df2d61992496d1fc986d2433b944584a8d/lua/lspconfig/configs.lua#L71-L97
Note: this line reports the correct value.
https://github.com/neovim/nvim-lspconfig/blob/3a5d94df2d61992496d1fc986d2433b944584a8d/lua/lspconfig/ui/lspinfo.lua#L78

I think you might be confusing (lspconfig/configs).autostart() with this one:
https://github.com/neovim/nvim-lspconfig/blob/6224c54a9945a52bf43a8bc1a42a112084590c0b/lua/lspconfig/configs.lua#L63
Which I have attempted to make it look better btw 😄
https://github.com/neovim/nvim-lspconfig/pull/1356

Hmm I think that PR doesn't seem to be relevent to this PR. The issue this PR fixes is that even if the configuration has autostart = false, LspInfo always reports autostart = true because (config.autostart and 'true') or 'false' always evaluates to 'true' since config.autostart is a function, not a boolean value. Sorry for not explaining this point earlier.

I think you missed my point. There's some overlap with the naming here, so there are two separate autostart instances:

this is the function one that you're referring to

require("lspconfig/configs").autostart()

this is specific to each client, In the case of LspInfo we only care about this one.
You can set it to false to tell lspconfig that it shouldn't start it automatically

client.config={
---
autostart = false
---
}

You can pass it yourself in the settings and see how it works. Furthermore, you can see an example here: https://github.com/jose-elias-alvarez/null-ls.nvim/blob/64b269b51c7490660dcb2008f59ae260f2cdbbe4/lua/null-ls/lspconfig.lua#L21

I have something like
lspconfig.ltex.setup { autostart = false }

in my config, but LspInfo says autostart: true when run in a buffer with matching filetype (in this case markdown or tex).
If I manually run LspStart ltex, then LspInfo says autostart: false. Is this expected behavior?
Also, all the occurrences of _autostart field (introduced in #964, IIUC in order to keep the value passed in setup) were removed in #1186.

Apologies, I didn't read the post carefully the first time, and I completely forgot that there are two different functions for this.
However, I still stand by my point that LspInfo is not really doing anything wrong here, it's the configs manager that's introducing this needless inconsistency instead of storing config.autostart as is.

Closed by 1356


Piper TTS  support

piper TTS is an excellent TTS system that you can run on your own machine capable of creating very natural speech in real-time using only CPU and no GPU acceleration even in low end machines.
This means that one does not need to upload anything to any cloud service.
There are many models for many languages and some have many hundreds of different voices.
This PR adds support for this back-end and some documentation.
It's fully functional but I'm sure there's room for improvement.
Thank you.

Heh I didn't monitor the project for some time since major init refactoring
As I see we have many opened PRs and tons of issues but @p0n1 seems like not maintaining much, but I don't have permission to accept PRs

Thanks for contributing @vcalv. There was a piper feature contribution before our code refactoring, so we can't merge that one directly. I'm happy to test and merge your contributions when I'm available.

Heh I didn't monitor the project for some time since major init refactoring As I see we have many opened PRs and tons of issues but @p0n1 seems like not maintaining much, but I don't have permission to accept PRs

Hey @Bryksin. It has been a while. I'm still here. Yeah, tons of pending work wait for us. I'd be happy if you could help.

in relation to #18  - it is super outdated and implemented for project before major refactoring, it cannot be accepted


Integrated TransformContext

Add new Canvas component (derived from LayerCake) which handles scaleCanvas() globally and supports scale/translate transforms
[GeoPath] Respect strokeWidth prop within Svg context (not just stroke-width attribute) to align with Canvas context usage
Integrate Transform into Chart () and expose as transformContext(). Renamed to TransformContext and removed direct SVG control (now handled by Svg and Canvas components)

#166  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @techniq and the rest of your teammates on  Graphite


Piping doesn't work

Maybe I'm doing something wrong, but seems as though this should work:
git tag --sort=v:refname | tail -n 1 | semver get major

Instead it errors and gives the usage guide

semver get (part) <version> doesn't read from stdin but expects an argument. Try with git tag --sort=v:refname | tail -n 1 | xargs -L1 semver get major.

Noice, forgot all about xargs somehow.


Replace cassandra's extension with fork to support PHP 8.0

Time to upgrade my projects to PHP 8.0 :)
The original developer of the extension has bailed on its support, but I found a fork, contacted the developers. Behind them is an organization that actively uses this extension, which guarantees support for the extension in the near future. I tested the build with PHP 8.0 and its stability on my working projects: no crashes have been found.

I've incorporated this change into the fork I've created for this project.
Thanks for doing this work! Feel free to shoot any follow up PRs if there are updates.
Docker Hub: https://hub.docker.com/r/mallardduck/gitlab-ci-pipeline-php
GitHub: https://github.com/mallardduck/gitlab-ci-pipeline-php


2.7.0+ production mode issue

Describe the bug
After upgrading to 2.7.0+, the production mode site is broken

Reproduction
Sry, I can not share my repo, here is the package.json
"dependencies": {
"@vitejs/plugin-vue": "2.0.0",
"@vuelidate/core": "^2.0.0-alpha.14",
"@vuelidate/validators": "^2.0.0-alpha.13",
"@vueuse/core": "^7.2.2",
"@vueuse/integrations": "^7.2.2",
"@vueuse/router": "^7.2.2",
"chart.js": "^3.6.2",
"core-js": "^3.19.3",
"devextreme": "^21.2.4",
"devextreme-aspnet-data-nojquery": "^2.8.4",
"devextreme-vue": "^21.2.4",
"lodash": "^4.17.21",
"primeflex": "^3.0.0",
"primeicons": "^5.0.0",
"primevue": "^3.10.0",
"prismjs": "^1.15.0",
"universal-cookie": "^4.0.4",
"vite": "2.7.2",
"vite-plugin-checker": "^0.3.4",
"vite-plugin-eslint": "^1.3.0",
"vue": "^3.2.24",
"vue-router": "^4.0.12",
"vue-tsc": "^0.3.0",
"vue-word-highlighter": "^1.0.4",
"vuedraggable": "^4.1.0",
"@vicons/fa": "^0.11.0",
"@vicons/utils": "^0.1.4"
},
"devDependencies": {
"@types/jest": "^27.0.3",
"@types/lodash": "4.14.178",
"@types/prismjs": "^1.16.5",
"@vue/compiler-sfc": "^3.2.24",
"@vue/eslint-config-airbnb": "^6.0.0",
"@vue/eslint-config-typescript": "^9.0.0",
"sass": "^1.44.0",
"typescript": "^4.4.3"
}
System Info
System:
    OS: Windows 10 10.0.22000
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
    Memory: 18.97 GB / 31.73 GB
  Binaries:
    Node: 17.0.1 - C:\Program Files\nodejs\node.EXE
    npm: 8.1.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (96.0.1054.53)
    Internet Explorer: 11.0.22000.120

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Downgrade to 2.6.14 fix the issue

This also happened to me with e$e is not a function
I have a minimal react setup and it only breaks in production

Please create a repro using https://vite.new/react or upload it as a repo in github

I was able to solve it after some trial and error
I turned on sourcemap and serve it in local, the error is coming from @babel/runtime fn missing
Install that resolve the problem
Still not sure why it only happens after 2.7.0

I was able to solve it after some trial and error I turned on sourcemap and serve it in local, the error is coming from @babel/runtime fn missing Install that resolve the problem
Still not sure why it only happens after 2.7.0

Do you mean install the @babel/runtime in the npm packages?

I was able to solve it after some trial and error I turned on sourcemap and serve it in local, the error is coming from @babel/runtime fn missing Install that resolve the problem
Still not sure why it only happens after 2.7.0

Do you mean install the @babel/runtime in the npm packages?

yes, but just my case, if it doesn't work for you you can turn on source map and debug it in dev tools

I was able to solve it after some trial and error I turned on sourcemap and serve it in local, the error is coming from @babel/runtime fn missing Install that resolve the problem
Still not sure why it only happens after 2.7.0

Do you mean install the @babel/runtime in the npm packages?

yes, but just my case, if it doesn't work for you you can turn on source map and debug it in dev tools

Thanks dude, not my case. It really a show stopper for us to upgrade to 2.7 for vite. 😌

Oh, I read the comments and thought https://github.com/vitejs/vite/issues/6099#issuecomment-994215514 solved it.
Will open, sry for confusion.

Oh, I read the comments and thought #6099 (comment) solved it. Will open, sry for confusion.

Thanks dude, I am trying to get a repo up when I have time.

@Shinigami92 I tried to set a reproduce repo, seems not that successful, however, I debugged into the code a bit more

Do you think it can give you any insights?

@Shinigami92 here is the repo - https://github.com/jzs11/vite-2.7/
Navigate into a workbook under the dev mode should not experience any errors

Then try
npm run build
npm run serve
You will see the error in the dev tool (Not exactly the same as the one I experienced, but it should give you something to start)
Downgrade the Vite into 2.6.14, the problem is gone.
Also, if you have time possible also take a look at another problem in v2.7.0

It is no longer the charset: false rule when publish.
Thanks,
Jing

I use react with<EMAIL_ADDRESS>in development anything is right, but when I run npm run build, it broken. I think maybe it is because some modules is use commonjs require, so I add the @rollup/plugin-commonjs, but it doesn't work.

@Shinigami92 have same issue and provided a repro https://github.com/vitejs/vite/issues/6061

So closing this in favor of #6061 :+1:


changing key file permissions control

fixes https://github.com/livekit/livekit/issues/1889

Looks good, thanks for the PR


core: update to node v14.18.1

Small bump to Node v14 for the core container. I tried this while I was troubleshooting an issue with the container building.
Change-type: patch
Signed-off-by: Joseph Kogut<EMAIL_ADDRESS>

Can one of the admins verify this patch?

@balena-ci rebase


[Bug]: Maven snapshots for a particular version fall behind qualified versions.

Describe the bug
Qualifiers are being added to maven publication's version that adds extra step for all downstream repos that depend on opensearch packages to update to the latest version string in their ci.  With the introduction of the alpha1 build we now have the following builds in sonatype.
2.0.0-SNAPSHOT/	Wed Mar 09 01:41:04 UTC 2022
2.0.0-alpha1-SNAPSHOT/	Tue Apr 05 21:48:15 UTC 2022

The builds with the alpha1 qualifier are now 27 days newer than the 2.0.0-SNAPSHOT while the "alpha1" versions are updated nightly.
To reproduce
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-core
Expected behavior
I'd expect 2.0.0-SNAPSHOT to hold the latest even if it is ahead of a qualified version.  Users should be able to pull in the latest SNAPSHOT of a version, even if a version with a qualifier is cut at a certain point.  OpenSearch doesn't have a 2.0.0 and a 2.0.0-alpha1 branch.
Screenshots
No response
Host / Environment
No response
Additional context
No response
Relevant log output
No response

Closing as duplicate of #1910.


Deleting folder throws an error

Bug Description
When deleting folders, the library throws a FTPError No such file or directory.
This issue might be caused by the initial / present in folder entries, but not in file entries, as far as I can tell from error logs:
...
📄 Delete: _next/static/chunks/main-4008b7bc3b992c03.js  ← no initial / here
📁 Delete: _next/data/37sYNwt2oKohzL5dgd1TZ              ← no initial / here too
...
removing "_next/static/chunks/main-4008b7bc3b992c03.js"   ← still no initial /, this works
removing folder "/_next/data/37sYNwt2oKohzL5dgd1TZ"       ← a / has appeared, and this throws

----------------------------------------------------------------
--------------  🔥🔥🔥 an error occurred  🔥🔥🔥  --------------
----------------------------------------------------------------

----------------------------------------------------------------
----------------------  full error below  ----------------------
----------------------------------------------------------------

FTPError: 550 /_next/data/37sYNwt2oKohzL5dgd1TZ: No such file or directory
    at FTPContext._onControlSocketData (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/v4.3.5/dist/index.js:5[26](https://github.com/<...omissis...>)3:39)
    at TLSSocket.<anonymous> (/home/runner/work/_actions/SamKirkland/FTP-Deploy-Action/v4.3.5/dist/index.js:5107:44)
    at TLSSocket.emit (node:events:519:[28](https://github.com/<...omissis...>))
    at addChunk (node:internal/streams/readable:559:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
    at Readable.push (node:internal/streams/readable:390:5)
    at TLSWrap.onStreamRead (node:internal/stream_base_commons:191:23) {
  code: 550
}

I have also opened a linked issue on SamKirkland/FTP-Deploy-Action.

I have found the line that introduces the initial /:
https://github.com/SamKirkland/ftp-deploy/blob/90398597732148985f6bf25c547eacc3d07aeef3/src/syncProvider.ts#L127
There is no such logic in the removeFile() function, so I don't know why it is necessary here.
@SamKirkland can you help us?

Or maybe the "No such file or directory" error itself is misleading and can be ignored, as done in the removeFile() function:
https://github.com/SamKirkland/ftp-deploy/blob/90398597732148985f6bf25c547eacc3d07aeef3/src/syncProvider.ts#L113C1-L115C18

Fixing this may actually fix the following errors :

https://github.com/SamKirkland/FTP-Deploy-Action/issues/422
https://github.com/SamKirkland/FTP-Deploy-Action/issues/312
https://github.com/SamKirkland/FTP-Deploy-Action/issues/324

The thing is the original code's purpose is not so clear, so I don't know if one could just copy the logic from removeFile() or if something different is needed.
@SamKirkland can you tell us more?


Adjusted AWS credentials configuration

Fixed #188 although #199 still should be merged as well since that is the default behaviour of the AWS SDK.

Successful response with a build attempt this morning using env vars.  Thank you!


PEAR-869 removes no description and empty tooltips

Description

disables/removes tooltips rather than show "no description" or similar, and when it was showing empty tooltips

Checklist

[N/A] Added proper unit tests
[/] Left proper TODO messages for any remaining tasks
[N/A] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

Bah - failing tests


fields2cover: 2.0.0-1 in 'iron/distribution.yaml' [bloom]

Increasing version of package(s) in repository fields2cover to 2.0.0-1:

upstream repository: https://github.com/Fields2Cover/fields2cover.git
release repository: https://github.com/ros2-gbp/fields2cover-release.git
distro file: iron/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.2.1-3

@Gonzalo-Mier we're seeing a regression in the buildfarm from this change which is blocking the Iron sync. See announcement
dpkg-shlibdeps: error: cannot find library libortools.so.9 needed by debian/ros-iron-fields2cover/opt/ros/iron/lib/libFields2Cover.so (ELF format: 'elf64-x86-64' abi: '0201003e00000000'; RPATH: '')
dpkg-shlibdeps: warning: can't extract name and version from library name 'libsteering_functions.so'
dpkg-shlibdeps: warning: can't extract name and version from library name 'libsteering_functions.so'
dpkg-shlibdeps: warning: can't extract name and version from library name 'libsteering_functions.so'
dpkg-shlibdeps: warning: can't extract name and version from library name 'libsteering_functions.so'
dpkg-shlibdeps: error: cannot continue due to the error above
Note: libraries are not searched in other binary packages that do not have any shlibs or symbols file.
To help dpkg-shlibdeps find private libraries, you might need to use -l.
dh_shlibdeps: error: dpkg-shlibdeps -Tdebian/ros-iron-fields2cover.substvars -l/tmp/binarydeb/ros-iron-fields2cover-2.0.0/debian/ros-iron-fields2cover//opt/ros/iron/lib/ -l/tmp/binarydeb/ros-iron-fields2cover-2.0.0/debian/ros-iron-fields2cover//opt/ros/iron/lib/x86_64-linux-gnu debian/ros-iron-fields2cover/opt/ros/iron/lib/libsteering_functions.so debian/ros-iron-fields2cover/opt/ros/iron/lib/libFields2Cover.so debian/ros-iron-fields2cover/opt/ros/iron/lib/x86_64-linux-gnu/libsteering_functions.so debian/ros-iron-fields2cover/opt/ros/iron/lib/libmatplot.so.1.2.0 returned exit code 2
dh_shlibdeps: error: Aborting due to earlier error
make[1]: *** [debian/rules:61: override_dh_shlibdeps] Error 25
make[1]: Leaving directory '/tmp/binarydeb/ros-iron-fields2cover-2.0.0'
make: *** [debian/rules:30: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
Traceback (most recent call last):
  File "/tmp/ros_buildfarm/ros_buildfarm/binarydeb_job.py", line 149, in build_binarydeb
    subprocess.check_call(cmd, cwd=source_dir, env=env)
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['dpkg-buildpackage', '-b', '-us', '-uc', '-Pnocheck']' returned non-zero exit status 2.
# END SUBSECTION

See https://build.ros2.org/view/Ibin_uJ64/job/Ibin_uJ64__fields2cover__ubuntu_jammy_amd64__binary/
Do you have a quick fix to resolve the issue? Else we will need to revert this PR to proceed with the sync.

Hi @Yadunund, fields2cover depends on ortools_vendor, which is also waiting for sync. On my tests, once ortools_vendor is available, fields2cover is able to compile without issues. I cannot promise it on ROS buildfarm.
Please, revert the PR and I will this solution on next release, once ortools_vendor is available.


add onclick hook to rui-card-create

This PR allows you to hook into rui-create-card so that when it is clicked, instead of flipping over and adding a name, you can do something else, like launch a modal. Added so that we can launch a modal form on creating a source or destination where you can enter your environment type.
Also cleaned up some formatting.

Can we update _all.html so that there is an example of the function ability in the docs? Something simple like an alert() should do the trick.

Sounds good. Added an example to _all.html and refactored the click function so it could be used in conjunction with the create function... and is generally a bit cleaner. Also included dst.

Actually, now that I'm working with my actual use case, I want to handle the onclick a little differently. If you're using the click function, it's because you intend to hijack the record creation process. Removed the stuff where you could have a click function and then still get the name input.

The value in createInput is 'sticky' in that we don't clear it out upon onClick(). I guess it could work either way, but it was weird to me when I clicked the card, typed something, then clicked cancel, then clicked on the card again and my text was still there.

Yeah, it's always been like that--shouldn't be any change with this PR.
I'm undecided on whether this is a feature or something else :)  FWIW, once we switch to environment type selection on source/dest creation, the only place that will still use the non-modal version is the organization creation, which is admin only at the moment

Not sure if this is how we'd want it to work, but as you mention, it is unlikely this will come up in the current applications of this directive.
This looks good to go, but there are merge conflicts.

Alrighty, was just a merge conflict with the dst/ files.


Test is broken beginning with python 3.8.1

It seems in patch version of python 3.8.1 something changed underline.
Perhaps it was urlparse? Essentially schema is now being parsed different way, so urlparse no longer allows to put url without http:// while also having port.
Obviously if test failed, its possible that actual codebase is failing now as well for certain scenarios (like one mentioned in #67).
This is the error i get on python 3.8.1 but not on any other version of python.  A string like “path:80” is no longer parsed as a path but as a scheme (“path”) and a path (“80”).
bugs.python.org/issue27657


feat(ctag): add ctag component

Signed-off-by: Shyrro<EMAIL_ADDRESS>Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes
/start features)

Pull request type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Current behavior of the tag is the same as the Tag in Chakra ui React.
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information
I noticed that Cypress tests were loading infinitely, so i opened another PR to fix them : (#147 )
Also, couldn't update the docs in the Vitepress, nothing showed up.

Hi @codebender828 !
Thanks for the review, i'll definitely try to fix that !
Can you just confirm to me what is broken? It seems to me that when i go to the staging, everything breaks after i click on the Accordion, if i don't and click elsewhere (buttons, icons etc.) everything works fine.
If i go here : https://chakra-ui-vue-next-playground-git-fork-shyrro-3e0cb3-chakra-ui.vercel.app/c-icon/examples/base-icon
I see the base icon, but if i click on the Accordion and click back on anything else, nothing works anymore, can you confirm that please?
Thank you and i'll try to fix that ASAP ☺

Hi @codebender828 !
Seems that the playground was broken on develop so i fixed it in another PR (#151 ) but i cherry picked the commit in this PR so that you can check that the Tags are working fine.
Let me know if there is anything else that needs to be changed,
Thanks !

Thank you @Shyrro ! Will go ahead and merge this


Add mention suggestions

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17890
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Users you've chatted with before

Enter @ sign into the text input
Some suggestions should pop up
Type in a few characters
Observe that the suggestions got narrower (if they exist, and they match the typed characters)
Tap on one of the suggestions
Verify that the suggestion is inserted into the text input

Users you haven't chatted with before

Enter @ sign into the text input
Type in the whole email of a user that you haven't chatted with before (e.g<EMAIL_ADDRESS>Tap on the suggestion that appears
Verify that the suggestion is inserted into the text input

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/3111202/236822570-f8d23eee-beda-49c4-9608-80196f40a0b1.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/3111202/237062760-8011ca75-154d-4952-bb6a-6584da9f35a6.mov

Mobile Web - Safari
https://github.com/Expensify/App/assets/3111202/be58f8c5-e84c-422e-a2da-bb00321879b7

Desktop
https://user-images.githubusercontent.com/3111202/236823492-235bb4c6-362a-467d-abda-a7393e9cce95.mov

iOS
https://github.com/Expensify/App/assets/3111202/343fd8c4-9fe5-41b3-9ac1-50e09d78fda2

Android
https://github.com/Expensify/App/assets/3111202/346806a0-1114-4bde-9de4-534aab4cfe68

BUG1:

write some text message
add mention @ and type 2 letters to show suggestions
press Esc key to cancel mention suggestion
now full composer text is cleared

bug1.mov
Question: Is it designed to show suggestions only after 2 letters? On other platforms like slack and discord, suggestions show immediately after adding @

@0xmiroslav
Regarding BUG1: The behaviour is the same for the existing emoji suggestions, and I wasn't sure If it's a bug. I could fix it with the following code change inside ReportActionCompose.js (I'll commit it right now):

Regarding the question: I think the emoji suggestions also appear after 2 letters, and I did the same thing here. I can easily change it (I'll commit it as well).

I've noticed small bug after I've implemented the feedback, working on it now

I've noticed small bug after I've implemented the feedback, working on it now

fixed

If we show suggestions in full width and above composer, what's https://github.com/Expensify/App/issues/16078 for?

That's a refactor of the auto-suggestion component, but it's not a blocker for this.

BUG1:

I've seen a bug report for this for emojis as well, so I don't think we need to fix it here. (unless @szebniok already has).

BUG1:

It seems like this is the default behavior of the composer, as it is reproducible with plain text as well

This can be out of scope but you already did good job! I like this behavior. Thoughts @puneetlath?

Agreed, that seems good to me too!

@here can be added in suggestions list in group chat?

Ah, yes. @here should be an option. We can add that in follow-up though.

My own email not showing as suggestion

Ah great point. That's because we just show whatever the "new chat" page would show. Which wouldn't include your own email or @here. So we will need to manually add those to the list. I think those are both fine to tackle in follow-up.

Code looks good and comments are minimal. Let's try to get this merged tomorrow!

This can also be follow-up?
suggestions still remaining after send and composer cleared
bug5.mov

I believe the solution to this problem is simple, we should simply add a call to resetSuggestions() inside the prepareCommentAndResetComposer() function.

@0xmiroslav how are things looking from your perspective?

Hah, nice catch @0xmiroslav. Normally, I would say yes, that's a bug. But in this case, I'd rather merge with some of these minor bugs that people aren't likely to hit and then fix in follow-up. Just given the EC3 timeline.

Cool, doing now!

Just some very minor comments from me. If @szebniok isn't able to get to them and if the checklist looks good, I can make the updates to the PR myself.

Bug: this is related to https://github.com/Expensify/App/pull/18469#issuecomment-1540341216
So highlightedMentionIndex keeps changing when arrow up/down button pressed even though only 1 suggestion

Sounds like also not a blocker then if it is also happening on emojis, do you agree?

If you already have a fix for this generally, I'd say go ahead and open a PR for it (and we'll compensate you for the fix). No need to delay the process.

I'm seeing them on desktop:

In theory, there will always be at least one suggestion of Concierge.

I updated the QA steps. Do you think that's better @0xmiroslav?

Alright! Going to go ahead and merge this baby.

Thanks for making the list!

suggestions view position (https://github.com/Expensify/App/pull/18469#issuecomment-1539971163)

Will be fixed automatically in: https://github.com/Expensify/App/issues/16078

suggestions don't disappear when move cursor to the start position (https://github.com/Expensify/App/pull/18469#issuecomment-1540306594)

Looks like it was already fixed by @szebniok in this PR

Arrow up/down always loop with 5 even though suggestions list is less than 5 (https://github.com/Expensify/App/pull/18469#issuecomment-1540341216)

Will be fixed in: https://github.com/Expensify/App/issues/16426

support phone users

Created issue: https://github.com/Expensify/App/issues/18729

suggestions still remaining after send and composer cleared

Reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1683751749650109

space is added endlessly while keep selecting suggested user (https://github.com/Expensify/App/pull/18469#pullrequestreview-1420641400)

Issue here: https://github.com/Expensify/App/issues/18742

arrow index is not within range and show console error (https://github.com/Expensify/App/pull/18469#issuecomment-1542544505)

Created issue here: https://github.com/Expensify/App/issues/18744

add myself in suggestions list
add @here in suggestions list, maybe only for group chat

Created issue for this here: https://github.com/Expensify/App/issues/18746

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.13-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

We added the highlightedMentionIndex in this PR but we didn't reset the index to 0 after selection, which caused this bug https://github.com/Expensify/App/issues/18844.

The MENTION_REPLACER caused the this issue. I think this was an odd cause and regex are difficult to test. But testing emojis next to auto completing could have picked this one.
I don't think any checklist update is required.

This PR caused a regression here. Refer to PR for more.


Feature Request: loop::foreach/4 (loop over elements with index)

Currently, Logtalk only has loop::foreach/3, which can not be used if element index is needed. It would be nice to have loop::foreach/4.
Use cases are similar to Python's enumerate function, which are described in PEP-279. Be aware that Python make use of iterator mechanism instead of extending for loop.

Implemented in 29f37bc84652acdc08d9135d1456e4a82d2231bf.

Cool, thanks!


EF Core Plans

Any plans to support EF Core? I read through the README and your blog post and didn't see any plans there, so sorry if it's posted somewhere.

There are no plans to support EF Core. Given how tightly EFCache is coupled to the provider model and how EF6 works it would mean a complete rewrite. Since I left the EF team I have not looked into how EF Core works internally but it is likely that caching needs to be implemented differently (i.e. not as a wrapping provider) and, as a result, can work better (i.e. on the entity level instead of RecordSet level)


Drum-Kit

Developer Checklist

[x] Followed guidelines mentioned in the readme file.
[x] Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
[x] Starred ⭐ the Repo (Optional)

Summary
Drumkit Game added
Screenshot

@PBJI pls check


Cooking Menus nonfunctional

This has been the case for a while. The pregame patch states:
    Campfire...             Failed. This patch may not be compatible with the current game version. The game's default cooking UI pop-ups will be used instead of QudUX's revamped screens.

fixed by #24


Remove AsyncAPI related items from Runtime Expressions until Async support is added

Section Runtime Expressions, ABNF rules message-header-reference and message-payload-reference: are these leftovers from deleted text or "sneak previews" of things to come?
Either way I'd remove them from this specification version.
Originally posted by @ralfhandl in https://github.com/OAI/sig-workflows/issues/49#issuecomment-1836171210

Refs #61


Authentication Handler makes too many authentication roundtrips.

The AuthHeaderCache used in AuthHandshakeMessageHandler currently in place, seems very sensitive in regards of the URLs which leads to unnecessary API call roundtrips for authentication.
The root cause: AuthHeaderCache uses the Host + AbsolutePath components of the URI to choose whether we already have an authentication token. This means that for almost every API call we make an authentication roundtrip because the path parts of the URI differ.
The better approach: Looking into AuthHandshakeMessageHandler.SendAsync and AuthHandshakeMessageHandler.GetAuthenticationAsync we can see that ultimately only the host part of the URL is relevant for determining the authentication information. It is passed into the CredsProvider.GetCredentialsAsync(registry) for loading the credentials and then sending them to the server. Hence we could also just consider the domain part in the AuthHeaderCache and avoid roundtrips for every call.
Maybe this was a security concern to allow registries to be operated on different path segements and not send the credentials potentially to a wrong application?
If this is a major concern, we should pass the registry base path into the AuthHandshakeMessageHandler (created per registry already) and handle the authentication specifically to the base URL.

IIRC it was per-domain initially but that resulted in overcaching for at least one case, so I backed it down to the current approach, favoring undercaching + working. But if we can keep the "working" property I would love to reduce round trips.

Ah - here's the spec I was thinking of: https://www.mankier.com/5/containers-auth.json

Interesting detail which might be in conflict how other tools are doing it. I will have to dig a bit into some registries to see how they are all handling the authentication.
Github seem to have the image name as part of the token in the scope and then this received token is reused:

GET /token?account=danielku15&scope=repository%3Abaronfel%2Fsdk-container-demo%3Apush%2Cpull&service=ghcr.io HTTP/1.1

I am thinking of a two stage authentication system which might work out for most flows and has the strict auth in place:

First try to use the domain level credentials and see if the call succeeds.
If it fails with an authentication/authorization related error (401/403), reauthenticate with host+path and retry with this token.
If this fails, treat things as unauthenticated and fail.

This two stage part already exist for 401 here. If we get 403 we can do something similar.

Stage 1 takes the token from the host
Stage 2 takes the token with the path.

What do you think of such an approach?


Inaccessible partitions created inside container

Distribution: Ubuntu
Distribution version: 16.04
The output of "lxc info" or if that fails:
lxc info
apicompat: 0
auth: trusted
environment:
addresses:

<IP_ADDRESS>:8443
architectures:
x86_64
i686
certificate: |
-----BEGIN CERTIFICATE-----
-----END CERTIFICATE-----
driver: lxc
driverversion: 2.0.0.rc12
kernel: Linux
kernelarchitecture: x86_64
kernelversion: 4.4.0-15-generic
server: lxd
serverpid: 22440
serverversion: 2.0.0.rc5
storage: dir
storageversion: ""
config:
core.https_address: <IP_ADDRESS>:8443
core.trust_password: true
public: false

Kernel version: 4.4.0-15-generic
LXC version: 2.0.0~rc12-0ubuntu1
LXD version: 2.0.0~rc5-0ubuntu1
Storage backend in use: dir

Example container config
config:
raw.lxc: |
lxc.aa_profile=unconfined
lxc.cgroup.devices.allow = b 8:* rwm
security.privileged: "true"
volatile.base_image: 4e8bb333466929ed0c7d25ff5dcc42e7241fd2dad22c5e4e40ae0b60be6d9f53
volatile.eth0.hwaddr: 00:16:3e:54:8d:0a
volatile.last_state.idmap: '[]'
devices:
eth0:
name: eth0
nictype: macvlan
parent: eth0
type: nic
root:
path: /
type: disk
sda:
path: /dev/sda
type: unix-block
Issue description
$ parted /dev/sda mklabel gpt
$ parted /dev/sda mkpart data xfs 1 100G
$ parted /dev/sda p
Partition Table: gpt
Disk Flags:
Number  Start   End    Size   File system  Name  Flags
1      1049kB  100GB  100GB  xfs          data
$ grep sda /proc/partitions
8        0<PHONE_NUMBER> sda
8        1   97654784 sda1
ls -la /dev/sda*
brw-r----- 1 root root 8, 0 Apr  1 20:56 /dev/sda

That's not a bug. Unprivileged containers cannot create device nodes and even if they could, the device cgroup policy wouldn't allow it.
If you partition a disk inside the container you must then add a matching disk entry for every partition in the container config.

Oh, sorry, only noticed now that you container is privileged and unconfined and has a whitelist entry for cgroups.

Assuming the container is Ubuntu 16.04, the problem is very likely that systemd refuses to run udev in a container so device nodes never get created for you, doing a manual mknod would fix that.

Thanks for the fast response. I'll see if I can get lxc.hook.autodev working.

You may be able to get it working with:
security.privileged: true
raw.lxc: |-
lxc.aa_profile=unconfined
lxc.cgroup.devices.allow = b 8:* rwm
lxc.mount.auto=
lxc.mount.auto=sys:rw proc:mixed cgroup:mixed
That should make systemd happy about starting udev in the container. Note that this may mess some of your host settings though, on my system it reset the soundcard volume for some reason :)

Doesn't appear to although I do see a strange line in dmesg:
[856923.560494]  sda: sda1

Looks like the normal kernel message for when it's asked to reload the partition table.

Appears to be just failing to mknod then.


RELATED: RAIL-3511 prepare the library for publication

sync the visuals with gooddata-ui (mainly applying https://github.com/gooddata/gooddata-ui/pull/391)
add disclaimer to the initial page stating that the content is generated
re-generate the vNext to be able to preview it "publicly"

JIRA: RAIL-3511

Build succeeded (check pipeline).

Sonar scan result
More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-apidocs-gate-PR6
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-ui-apidocs-fossa-scanning-zuul-el7/12/ : FAILURE in 2m 21s (non-voting)
https://checklist.intgdc.com/job/compliance/job/gooddata-ui-apidocs-sonarqube-scan-zuul-gate/17/ : SUCCESS in 46s
https://checklist.intgdc.com/job/compliance/job/gooddata-ui-apidocs-merge-compliance-check/12/ : SUCCESS in 18s


Add a --count option

So basically what I want to do is to implement a flag lsd --count which displays the current number of files and directories in a given path.
If this usecase is acceptable for the maintainers, I will proceed to implement it and open a new PR for it.

I don't really see a good usecase for this to be frank. This is probably something that is better served by piping the output of lsd to something like wc.
There was however some discussion around adding a --summary flag to mimic lscolors functionality but nothing solid has been decided yet.

Happy to give my contribute in any possible way.
However I seize the opportunity to ask how I should implement such a function of a new flag.
I know I should add the flag inside the src/app.rs file, but where should I write its own implementation?

https://github.com/Peltoche/lsd/issues/112#issuecomment-460040371 is the item that I was mentioning. We still have to decide on what gets displayed and where.
@Gasu16 I would like to understand what your usecase is. Just to understand what you are expecting this feature to do, so that we can have a clearer understanding on what should go in there.

You got me wrong, what I meant is to understand better how the code works, and asked how to add the implementation for a new functionality (flag), not for my usecase in particular, but generically.

I understood you. It is just that we don't have a solid idea on what the feature should provide. Since you requested a similar feature I thought I would ask you what your usecase is so that we can probably better understand what needs to be build.

Well, I'm glad if I could give any help on the feature you previously mentioned (--summary), or anything else.

Hi @Gasu16, we do not have the guide you mentioned, you could check the code directly, it is not that difficult and is always update-to-date.
as a quick start:
main logic:

main starting here https://github.com/Peltoche/lsd/blob/master/src/main.rs#L91
flags are parsed here https://github.com/Peltoche/lsd/blob/master/src/main.rs#L116
core is called here https://github.com/Peltoche/lsd/blob/master/src/main.rs#L119 and impl here https://github.com/Peltoche/lsd/blob/master/src/core.rs#L77
flags will be used in fetch here https://github.com/Peltoche/lsd/blob/master/src/core.rs#L84 and display here https://github.com/Peltoche/lsd/blob/master/src/core.rs#L137

flags are types defined here https://github.com/Peltoche/lsd/blob/master/src/flags.rs and here https://github.com/Peltoche/lsd/tree/master/src/flags

as this issue is not valid anymore, closing, feel free to open it if there are any other problems.

also, if you want to find something to start, good first issue is always your friend https://github.com/Peltoche/lsd/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A"good+first+issue"


Add the feature for showing the expected header value on rules error.

When there is an error with hashing/value check in headers, show what value was expected.

I think it would be good in the verbose mode!

Agreed!

I want to make this. What need I to run the webhook from source? I'm trying to do this:
`
C:\Users\Marat\Desktop\webhook-1>go run webhook.go
command-line-arguments
.\webhook.go:95:2: undefined: setupSignals
.\webhook.go:205:19: multiple-value uuid.NewV4() in single-value context
`
Help me pls :3

I think I installed the wrong version of the Go or something like that?

Did you do go get .. In the webhook directory after cloning?

Also, try running with go run webhook.go signals.go -verbose

I think the problem is not in the dependencies. I think the problem is in code syntax

C:\Users\Marat\Desktop\webhook>go run webhook.go signals.go +build !windows
# command-line-arguments
.\signals.go:16:25: undefined: syscall.SIGUSR1
.\signals.go:26:13: undefined: syscall.SIGUSR1
``` - now this error :(

I've changed the 266 line to:
rid := uuid.Must(uuid.NewV4()).String()[:6] and it works!
I'm running the script using this go run webhook.go signals_windows -verbose
maybe we need to change the 205 line in the webhook.go from:
rid := uuid.NewV4().String()[:6]
to the:
rid := uuid.Must(uuid.NewV4()).String()[:6]

Which variables can I use to do that? I'm trying to get the &payload but it's null :(
fmt.Fprintf(w, "Hook rules were not satisfied: [%s] [%s] [%s] [%s] [%s] [%s]", &headers, &query, &payload, &body)
My response:
Hook rules were not satisfied: [&map[Connection:keep-alive Upgrade-Insecure-Requests:1 User-Agent:Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 Accept:text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language:en-US,en;q=0.5 Accept-Encoding:gzip, deflate Dnt:1]] [&map[]] [&map[]] [&] [%!s(MISSING)] [%!s(MISSING)]

Did you send any payload? By HTTP specification GET request doesn't officially support payload.
Try using curl to issue POST request with payload

curl localhost:9000/hooks/drawify-redeploy -H "X-Hub-Signature: s"
fmt.Fprintf(w, "Hook rules were not satisfied. %s", query)
Hook rules were not satisfied. map[]
Is it OK that map[] is empty? Which variables can I use to get the payload variables and expected?

I understood:
matchedHook.TriggerRule.Match.Value
And then make for loop for checking TriggerRule array

headers contains key-value pairs of request headers
query contains key-value pairs of request query parameters (i.e. if you used .../drawify-redeploy?a=b, it would contain element named a with the value b)
payload contains parsed payload into key-value pairs
body should contain raw body


[Do Not Merge] Incorporate mobile auth modal

This addresses: https://artsyproduct.atlassian.net/browse/GROW-472
This PR integrates the mobile auth forms and takes in account whether to render the Mobile or Desktop version.

This looks good to me! Feel free to merge when ready. You had a stray comment in there

This is 💚 now. Going to go ahead and merge.


RFM - Foldit

Current Maintainer

[ ] I am the maintainer of the package and wish to pass it to someone else;

I DON'T Want To Become The Maintainer

[x] I have followed the Package Triage Process and I do NOT want to become maintainer of the package;
[x] There is no existing open maintainer request for this package;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details
Package URL: https://chocolatey.org/packages/foldit
Package source URL: https://github.com/dtgm/chocolatey-packages/tree/master/automatic/foldit/
Date the maintainer was contacted: 13 May 2020
How the maintainer was contacted: Via contact maintainers form on Chocolatey.org.

Hello,
I'll look into it this evening, as i'm already maintaining some of his packages.

OK, package ready, i'll ask to be added as maintainer

Package sent waiting for testing

/attach @tunisiano187 tunisiano
You attach my user if it can help ;-)

Package version approved as of today, thanks for picking this up @tunisiano187


Update (windows) python to 3.8.5

What does this PR do?
updates python version to 3.8.5
Additional Notes
corresponding windows zips built and pushed to bucket.

Thanks for generating again, closing in favor of https://github.com/DataDog/datadog-agent/pull/6133


MSID: 97015 Version: 1 DOI: 10.1101/2<IP_ADDRESS>8672

MSID: 97015
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>8672
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=97015
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>8672

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/97015v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>8672
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/97015/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: underline element contains more than 20 characters. Is this tracked change formatting that's been erroneously retained?
warn: underline element contains more than 20 characters. Is this tracked change formatting that's been erroneously retained?


main.go:14: get current user: get current user: context deadline exceeded

I'm setting everything up by the guide and keep receiving this error 18:57:27 main.go:14: get current user: get current user: context deadline exceeded any clue how to solve it?

@Paul-Bob  i am facing the same issue can you let me know how you fixed it.

@vikashcodes check this issue https://github.com/alexandear/import-gitlab-commits/issues/1 it might be useful

I have tried but all in vain.


Issue #13 Adding Version, build_ID

Signed-off-by: Lalatendu Mohanty<EMAIL_ADDRESS>

LGTM :+1:

@hferentschik  I have done changes as per your suggestion. Let me know if you have some comments.


creating difficulty system

MiniMax AI is incomplete
refactored HasWon function
need to create UI for choosing difficulty

yeah, I wonder why

bruh

bruh

Uploading of course, this is the new weapon you ordered.mp4…

that's a long file name

it's the new weapon you ordered

thanks boss


Overflow issue on meshery/community page for specific width

Description
Overflow issue on meshery/community page
Slack Discussion:
https://layer5io.slack.com/archives/C015QJKUMPU/p1690614669705379
Screenshots

Enviroment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

can i work on this


Build error: unix/ibus target

Description
Building for the unix/ibus target fails with a complaint about a missing header <cstdint> and an undeclared variable flags
Commit-id
2e34ec38bf9b311a3640466b904ee198ca29d4d7
Build target
Docker build for Linux and Android-lib
CI build status
passing
Environment:

OS: Arch Linux
Python version (optional): 3.11
Qt5 version (optional): 5.15.9
Compiler version (optional): GCC 13.1.1

Build commands

git submodule update --init --recursive
bazel build renderer/qt:mozc_renderer unix/ibus:ibus_mozc unix/icons --config oss_linux --compilation_mode opt

Error logs
[437 / 515] Compiling src/google/protobuf/descriptor.pb.cc; 6s processwrapper-sandbox ... (12 actions, 11 running)
[446 / 515] Compiling protocol/commands.pb.cc; 4s processwrapper-sandbox ... (12 actions, 11 running)
ERROR: /build/ibus-mozc/src/ibus-mozc-git/src/unix/ibus/BUILD.bazel:87:16: Compiling unix/ibus/ibus_wrapper.cc failed: (Exit 1): gcc failed: error executing command (from target //unix/ibus:ibus_wrapper) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 60 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
unix/ibus/ibus_wrapper.cc: In member function 'void mozc::ibus::IbusBusWrapper::RequestName(absl::lts_20230125::string_view)':
unix/ibus/ibus_wrapper.cc:417:13: error: 'uint32_t' does not name a type
  417 |   constexpr uint32_t flags = 0;
      |             ^~~~~~~~
unix/ibus/ibus_wrapper.cc:31:1: note: 'uint32_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   30 | #include "unix/ibus/ibus_wrapper.h"
  +++ |+#include <cstdint>
   31 |
unix/ibus/ibus_wrapper.cc:418:44: error: 'flags' was not declared in this scope
  418 |   ibus_bus_request_name(bus_, name.data(), flags);
      |                                            ^~~~~
INFO: Elapsed time: 62.714s, Critical Path: 18.74s
INFO: 458 processes: 37 internal, 421 processwrapper-sandbox.
FAILED: Build did NOT complete successfully

Hi Nocifer,
Thank you for your report.
Interestingly, that issue doesn't happen on my environment.
But anyway, including cstdint makes sense.
8dbe1ff added it.
Best,


Chore/4249/brand audit

Try out this version of Leather — download extension builds.

This PR fixes some issues flagged in the:

Brand audit ticket #4249

fix: update address displayer to use text-subdued for odd
fix: change tab hover bg colour,
fix: give activity screen a min height to stop it jumping when empty, c…

Containers ticket #4165

fix: alter position of receive modal in extension view,
fix: stop create account button disappearing at smaller heights,
fix: improve display of select account in extension mode,

Align refresh icon #4290

fix: update collectible header font and align icon,

@pete-watters shall we revert the hard angles to the rounded corners and deal with this is separated ticket?


Error in FindControllersAsync

Hello Jeff,
I have upgraded my version from 1.5.10 to 1.6.1.
I have very often an error in XBeeController.FindControllersAsync
{System.IO.InvalidDataException: Found invalid data while decoding.    at XBee.AtCommandWriter.<WriteAsync>d__3.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Core.XBeeControllerBase.<SetApiModeAsync>d__85.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Core.XBeeControllerBase.<InitializeAsync>d__84.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Core.XBeeControllerBase.<ExecuteAsync>d__83.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Core.XBeeControllerBase.<ExecuteQueryAsync>d__761.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Core.XBeeControllerBase.d__801.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Core.XBeeControllerBase.<GetHardwareVersionAsync>d__73.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Universal.XBeeController.<TryGetControllerAsync>d__3.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Universal.XBeeController.<FindControllersAsync>d__1.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at IT.ITSellingSolution.OmniGreenMaster.XbeeHubNs.XBeeHub.d__89.MoveNext()}
`
I don't have this kind of error in 1.5.10 and I don't have made any changes to code.

Hm, that's a result of the API mode auto-configure from 1.6 not working.
Can you please try 1.6.2-beta and post the exception if it
happens again?  I've added more debug info to the exception message.
Thanks.
On Wed, Apr 18, 2018 at 11:11 AM, scervellera<EMAIL_ADDRESS>wrote:

Hello Jeff,
I have upgrade my version from 1.5.10 to 1.6.1.
I have very often an error in XBeeController.FindControllersAsync
{System.IO.InvalidDataException: Found invalid data while decoding. at
XBee.AtCommandWriter.d__3.MoveNext() --- End of stack trace
from previous location where exception was thrown --- at System.Runtime.
CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task) at XBee.Core.XBeeControllerBase.d__85.MoveNext()
--- End of stack trace from previous location where exception was thrown
--- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task) at System.Runtime.CompilerServices.TaskAwaiter.
HandleNonSuccessAndDebuggerNotification(Task task) at
XBee.Core.XBeeControllerBase.d__84.MoveNext() --- End of
stack trace from previous location where exception was thrown --- at
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.
HandleNonSuccessAndDebuggerNotification(Task task) at
XBee.Core.XBeeControllerBase.d__83.MoveNext() --- End of
stack trace from previous location where exception was thrown --- at
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.
HandleNonSuccessAndDebuggerNotification(Task task) at
XBee.Core.XBeeControllerBase.d__761.MoveNext()
--- End of stack trace from previous location where exception was thrown
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
at System.Runtime.CompilerServices.TaskAwaiter.
HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Core.XBeeControllerBase.d__801.MoveNext() --- End of stack trace
from previous location where exception was thrown --- at System.Runtime.
CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task) at XBee.Core.XBeeControllerBase.d__73.MoveNext()
--- End of stack trace from previous location where exception was thrown
--- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task) at System.Runtime.CompilerServices.TaskAwaiter.
HandleNonSuccessAndDebuggerNotification(Task task) at
XBee.Universal.XBeeController.d__3.MoveNext() ---
End of stack trace from previous location where exception was thrown --- at
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.
HandleNonSuccessAndDebuggerNotification(Task task) at
XBee.Universal.XBeeController.d__1.MoveNext() ---
End of stack trace from previous location where exception was thrown --- at
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.
HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.
CompilerServices.TaskAwaiter1.GetResult()
at IT.ITSellingSolution.OmniGreenMaster.XbeeHubNs.
XBeeHub.d__89.MoveNext()}
`
I don't have this kind of error in 1.5.10 and I don't have made any
changes to code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jefffhaynes/XBee/issues/50, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJSKRzT5nY1i6bsDz8w9Nwr2dVFZMLUCks5tp1e5gaJpZM4TaQR_
.

--
If you want to build a ship, don't drum up people together to collect wood
and don't assign them tasks and work, but rather teach them to long for the
endless immensity of the sea.
Antoine de Saint-Exupery

Hello, i was having the same problem with 1.6.1, tried 1.6.2-beta, and here it is the new error.
System.IO.InvalidDataException
System.IO.InvalidDataException: Expected OK
but received System.Byte[]
at XBee.AtCommandWriter.d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Core.XBeeControllerBase.d__85.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Core.XBeeControllerBase.d__84.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Core.XBeeControllerBase.d__83.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Core.XBeeControllerBase.d__761.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at XBee.Core.XBeeControllerBase.<ExecuteAtQueryAsync>d__801.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Core.XBeeControllerBase.d__73.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Universal.XBeeController.d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at XBee.Universal.XBeeController.d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at IT.ITSellingSolution.OmniGreenMaster.XbeeHubNs.XBeeHub.d__89.MoveNext()

Hello, i forgot  to specify some informations:
-i'm working on a raspberry in UWP
-the xbee connected to the raspberry is the coordinator
Anyway, i downloaded the sources so i can make more tests.
The problem is  in SetApiModeAsync when you try to send :
await writer.WriteAsync("+++").ConfigureAwait(false);
The response is AckResponse, only if xbee network is not established.
In other case (a standard for our application) we don't have  a AckResponse, but the 3 bytes that i always find in the response are : 126,0,35

Interesting. I’m not sure what would cause that. Let me spend more time on it.
If you get a chance can you try issuing “+++” from a serial terminal or X-CTU and see what you get?
Thanks

From: Daniele ilcea Cearini<EMAIL_ADDRESS>Sent: Thursday, April 19, 2018 8:11:11 AM
To: jefffhaynes/XBee
Cc: Jeff Haynes; Comment
Subject: Re: [jefffhaynes/XBee] Error in FindControllersAsync (#50)
Hello, i forgot to specify some informations:
-i'm working on a raspberry in UWP
-the xbee connected to the raspberry is the coordinator
Anyway, i downloaded the sources so i can make more tests.
The problem is in SetApiModeAsync when you try to send :
await writer.WriteAsync("+++").ConfigureAwait(false);
The response is AckResponse, only if xbee network is not established.
In other case (a standard for our application) we don't have a AckResponse, but the 3 bytes that i always find in the response are : 126,0,35
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/jefffhaynes/XBee/issues/50#issuecomment-382710857, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSKR0VejHLZ2DOsE6hLWcQhlSN5RCORks5tqH7fgaJpZM4TaQR_.

ok, tried from Tera-Term sotware.
when i send +++, i always have OK as response.
but when i receive a message from another xbee, the OK response is at the end of the message
(see screenshot).

I think that is necessary to clean the already receveid messages on the serialdevice, or wait for any Ok response bytes in the stream.

Ah, of course. Ok, thank you.

From: Daniele ilcea Cearini<EMAIL_ADDRESS>Sent: Friday, April 20, 2018 4:57:41 AM
To: jefffhaynes/XBee
Cc: Jeff Haynes; Comment
Subject: Re: [jefffhaynes/XBee] Error in FindControllersAsync (#50)
ok, tried from Tera-Term sotware.
when i send +++, i always have OK as response.
but when i receive a message from another xbee, the OK response is at the end of the message
(see screenshot).
[cattura]https://user-images.githubusercontent.com/12558892/39041219-a751a0a0-4488-11e8-8431-55cde1f91646.PNG
I think that is necessary to clean the already receveid messages on the serialdevice, or wait for any Ok response bytes in the stream.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/jefffhaynes/XBee/issues/50#issuecomment-383032514, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSKR52FAm8SAqvc3CSoLCveQ7uaLtsfks5tqaMFgaJpZM4TaQR_.

Can you please try 1.6.2-beta3 and see if it works better for you?  Thanks

it works.
I tryed to start the app several times, and i've never had the error.
Thanks you!!

Great, glad to hear it

From: Daniele ilcea Cearini<EMAIL_ADDRESS>Sent: Monday, April 23, 2018 5:01:06 AM
To: jefffhaynes/XBee
Cc: Jeff Haynes; Comment
Subject: Re: [jefffhaynes/XBee] Error in FindControllersAsync (#50)
it works.
I tryed to start the app several times, and i've never had the error.
Thanks you!!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/jefffhaynes/XBee/issues/50#issuecomment-383504961, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSKR3FuGztby6G6GQi9UN-K-P6cUWK4ks5trZhSgaJpZM4TaQR_.


Fixed issues with dtype in geom functional transforms v2

Description story:
Philip (@pmeier) tried to check if other floating types are working for the transforms: f16, f64 etc. here: https://github.com/pytorch/vision/pull/7195
It seems that f16 is not even working for stable one (ref). But for f64 we had few issues that this PR is supposed to fix.
Some transforms can't work properly for f64, e.g. perspective. Jit is inconsitent etc

Thanks for the PR @vfdev-5 . It's not really clear to me which bugs this issue is trying to address. Could you help me understand?

@NicolasHug This addresses the second point in https://github.com/pytorch/vision/pull/7159#issuecomment-1423212817. TL;DR You saw tests for elastic completely failing and this happened because we failed to consolidate the dtypes of the image and grid that were passed to grid_sample. This PR (hopefully; I haven't reviewed yet either) fixes this and expands our tests so this doesn't happen again.


Add an ability to access operation result in callbacks

Now callbacks' call method optionally receives the operation result as the second positional argument

I though I stated in well in the docs. In my particular case I want to implement audit logging and it is nice to have access to the operation class in order to retrieve the operation name.

@radekzawada btw, I'm gonna actually depricate and drop operation_failure: key in the context you introduced for on_failure in favor of operation_result which is defined for both callbacks and contains more data.

@radekzawada btw, I'm gonna actually depricate and drop operation_failure: key in the context you introduced for on_failure in favor of operation_result which is defined for both callbacks and contains more data.

it will be simple to migrate it to new standard


fix typo in Reference Docs (Request Execution)

Looks like AsciiDoc syntax needs double backticks for plural words like this

@reillylm Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@pivotal-cla This is an Obvious Fix

@reillylm This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

Thanks for the suggestion, but this is intentional. It's the asciidoc syntax that allows adding the "s".

@rstoyanchev Are you sure? I think this change is to add the proper syntax for the "s".
Here's what the rendered version looks like in main right now:

And then with this change:

Sorry, I mistook the change for the current version. Yes double backtick it should be.


want 'concurrency' option to forEachParallel

See SAPI-266 for occasion where this is really wanted, but basically in general where the array of inputs can grow large, you always want a limitation on concurrency. The programmer could do this with vasync.queue right now, but it would reduce boilerplate for a common use case if supported on forEachParallel.

starter patch for discussion: https://gist.github.com/trentm/d90e61035c91fe7e489c


Error in Quota allocation regarding Subscription Throttling Policies

Use Case: Help the subscribers to evenly distribute the allocated quota among application users
Test Scenario: Edit already set subscription policy to limit the max requests per time within the allocated subscription policy plan,

where subscription plan has already used in subscription (subscribed to API)
burst control limit <= allocated plan
Should not change the subscription quota for already subscribed API

Details of the Issue: Issue encountered in editing already set subscription policy to limit the max requests per time within the allocated subscription policy plan. Subscription quota changed for already subscribed API. When I changed the rate limiting of Bronze throttling tier from 5 per minute to 10 per minute, it affected to the already subscribed API.
Relevant Screenshots:
(5 per min)

(10 per min)

This is the expected behaviour. Hence Not a Bug. Closing.


UITapGestureRecognizers are not working

I'm presenting view controller with one simple subview using heroReplaceViewController(with: myViewController) and everything is ok with animations. But UITapGestureRecognizer that's added to subview is not working. When I replace heroReplaceViewController method with present(myViewController, animated: true, completion: nil)  tap gesture recognizer is working normally.
Could this be some problem with library?

might be. Can you upload an example so that I can better help you.

HeroDemo.zip

https://github.com/lkzhao/Hero/pull/30
Should be fixed with this PR. Can you checkout that branch and confirm?
pod "Hero", :git => 'https://github.com/lkzhao/Hero.git', :branch => 'replace-fix'

Note: that branch's API is updated with the new Swift Enum heroModifiers, usage is a bit different.

It's working.
Thanks


Integration test ci

Integration test for installing wasmcc and running sample rust contract
Updated github actions ci

@swetharepakula this looks like it's running. It takes 2 minutes. WDYT?

Only thing I'd prefer is to get the local run of this the same as CI. I find it difficult to run locally.

So I think you how it is right now is fine, but I agree with Morgan. Perhaps it is useful to make a script for some of the intermediary steps so that this can be recreated locally as well.

So I think you how it is right now is fine, but I agree with Morgan. Perhaps it is useful to make a script for some of the intermediary steps so that this can be recreated locally as well.

Ok. The only main thing required to run this is Fabric docker images and HLF 1.4.0 in go path. Maybe I can add both these in a script?

@kleash Rebase, and update the branch. Then we can go ahead and merge this.


Reflect endpoint has no side effects

This setting will enable the use of HTTP GET with this endpoint, so implementations can support caching and conditional GETs.

Not much we can do about the lint warning. Perhaps we should allow changing the idempotency_level to something more strict, as long as it doesn't go the other direction?