WIP: Fix docs

Codecov Report

Merging #6 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   74.61%   74.69%   +0.08%
==========================================
  Files          27       27
  Lines        1733     1739       +6
==========================================
+ Hits         1293     1299       +6
  Misses        440      440

Impacted Files
Coverage Δ

src/alignedseq.jl
57.14% <ø> (ø)
:arrow_up:

src/anchors.jl
100% <ø> (ø)
:arrow_up:

src/submat.jl
59.78% <ø> (ø)
:arrow_up:

src/alignment.jl
83.49% <ø> (-0.98%)
:arrow_down:

src/operations.jl
100% <100%> (+6.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc14ad...564baa5. Read the comment docs.

I'll recheck and merge this tomorrow if no objections.


Capstone - Redis config

redis-config crate
Implemented an Asynchronous Redis Source compatible with config-rs crate to extend the sources list provided by configs-rs.

@sokyrko @vni @tiamo @TheBestTvarynka @pahoma
Thanks a lot for the reviews and comments!


switch from max_exclusive to max_length (inclusive)

fix #23

Codecov Report

Merging #24 (d50aa93) into main (9747ec3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           65        59    -6
  Branches         5         5
=========================================
- Hits            65        59    -6

Impacted Files
Coverage Δ

annotated_types/test_cases.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Fixed some errors in the readme.
And now the coverage report comes through...3 hours to add a comment.


Exception Could not create resource

hi there i have just loaded my configs and userpass wordlists and come up with this issue. any suggests or potential solutions would be highly appreciated!
error: 'Exception
Could not create resource'

Could you provide a series of steps to reproduce the error? Did you move or delete the file since you created the wordlist?


Add bombs in the game

Bombs are placed on cells centers and explode crates and other bombs after a given time (default 2s).
For better testing, the default radius is set to 2 but will have to be set to 1 later.
Default place bomb key is E.
Resolves: #70
Resolves: #71
Resolves: #73
Resolves: #74
Resolves: #75
Resolves: #77
Resolves: #78
Resolves: #110

Codecov Report

Merging #126 (1e9422c) into master (93d98cc) will decrease coverage by 0.99%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   18.19%   17.20%   -1.00%
==========================================
  Files         103      110       +7
  Lines        1506     1587      +81
  Branches      554      589      +35
==========================================
- Hits          274      273       -1
- Misses       1100     1183      +83
+ Partials      132      131       -1

Impacted Files
Coverage Δ

src/game/Game.cpp
0.00% <0.00%> (ø)

src/game/components/Bomb.cpp
0.00% <0.00%> (ø)

src/game/components/Bomb.hpp
0.00% <0.00%> (ø)

src/game/components/Collidable.hpp
0.00% <ø> (ø)

src/game/components/Player.cpp
0.00% <0.00%> (ø)

src/game/components/Player.hpp
0.00% <0.00%> (ø)

src/game/map/Map.cpp
0.00% <0.00%> (ø)

src/game/resources/Map.hpp
0.00% <0.00%> (ø)

src/game/systems/Bomb.cpp
0.00% <0.00%> (ø)

src/game/systems/Bomb.hpp
0.00% <0.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d98cc...1e9422c. Read the comment docs.


Decimal + quantize in _round() is substantially slower than round()

In profiling this library, I have found that a very substantial amount of time is spent in the _round() method in encode.py.
Looking through git history, it looks like this change was made for python3 compatibility. I have done very little work with python3, any chance someone could explain the motivation for the change? Aside from even/odd rounding (is this particularly important?), is this functionally different than just calling round() on the val?
https://github.com/mapzen/mapbox-vector-tile/commit/24ab05b1f8c6093a2606f9a14527492846c590c9
For testing, I used a very large layers object that typically takes a little under 1s to encode. I ran 10 times to reduce noise (hence runtimes in the single digit seconds).
Here is the relevant cProfile output
         12019816 function calls (11938319 primitive calls) in 9.586 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.011    0.011    9.586    9.586 profiler.py:1(<module>)
       10    0.001    0.000    9.281    0.928 __init__.py:11(encode)
      120    0.067    0.001    8.544    0.071 encoder.py:60(addFeatures)
    92100    0.227    0.000    3.980    0.000 encoder.py:55(_round)
     8400    0.047    0.000    3.366    0.000 encoder.py:197(addFeature)
     8400    0.029    0.000    3.328    0.000 encoder.py:122(quantize)
     8400    0.179    0.000    3.295    0.000 ops.py:184(transform)
     8400    0.198    0.000    2.617    0.000 encoder.py:360(_geo_encode)
    92100    0.493    0.000    2.348    0.000 decimal.py:2422(quantize)
    26600    0.069    0.000    2.115    0.000 encoder.py:125(fn)
   276306    0.514    0.000    1.459    0.000 decimal.py:515(__new__)
     8400    0.013    0.000    1.261    0.000 encoder.py:97(enforce_winding_order)
     1120    0.012    0.000    1.207    0.001 encoder.py:168(enforce_polygon_winding_order)

If we change _round to use the built in round like so:
def _round(self, val):
        return round(val)

This is the cProfile output:
         5916397 function calls (5834900 primitive calls) in 5.245 seconds

   Ordered by: cumulative time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.009    0.009    5.245    5.245 profiler.py:1(<module>)
       10    0.000    0.000    4.821    0.482 __init__.py:11(encode)
      120    0.061    0.001    4.102    0.034 encoder.py:60(addFeatures)
     8400    0.042    0.000    2.007    0.000 encoder.py:197(addFeature)
     8400    0.154    0.000    1.306    0.000 encoder.py:360(_geo_encode)
     8400    0.024    0.000    1.122    0.000 encoder.py:122(quantize)
     8400    0.155    0.000    1.094    0.000 ops.py:184(transform)
     8400    0.038    0.000    0.924    0.000 encoder.py:297(_parseGeometry)
       10    0.000    0.000    0.718    0.072 python_message.py:807(SerializeToString)
       10    0.000    0.000    0.682    0.068 python_message.py:821(SerializePartialToString)
 19190/10    0.028    0.000    0.682    0.068 python_message.py:827(InternalSerialize)
   180/10    0.028    0.000    0.682    0.068 encoder.py:744(EncodeRepeatedField)
       13    0.060    0.005    0.550    0.042 __init__.py:1(<module>)

Happy to file a PR with this change, but would like to know more about the motivation in case I missed something.

The change was meant to add consistency across python2/3 versions. The way this was discovered was a test failure in python3 that didn't exist in python2, and the different rounding behavior was the culprit.
How about adding an option to the encoder to allow pluggable rounding behavior? Maybe add an option like round_fn, and you can just pass in the default python round function directly. I think that by default the behavior should be the current one, which is consistent across python versions just to prevent any confusion. Maybe we should also call this out in the readme so users will be aware of the trade-offs.
Thanks for taking the time to profile!

Sounds reasonable to me. Will try and put together a PR today w/ optional round.


stringify properties payload in addtolist

The reason properties were not making it through on creation of a user during add to list was that we were not properly serializing the properties before including them in the form data of the POST request.
See "adding someone to a list" here: https://www.klaviyo.com/docs/api/lists

@ndhoule @tsholmes @hankim813 @WesleyDRobinson

lgtm as long as you were able to do end to end test on this? code looks fine @sperand-io

:shipit: thank you! @sperand-io @hankim813


LIME-126 - Move functionality from Passport CRI access token lambda to shared CRI access token lambda

Proposed changes
What changed
Updated so that

Default ttl values are applied to the session
access token value is hashed in the db
access tokens can be set as revoked
utilised nimbus verifications on jwt

Why did it change
To align with passport and follow the best practice listed here
https://docs.google.com/spreadsheets/d/1CEC4xYgyLcijDKeZm8GhZrRNDKsgLFHPRymOxJWJIao/edit?pli=1#gid=363396808
Issue tracking

LIME-126

Closing as this is likely out of date with the current code; there is a separate task in Jira to re-run the audit in the Google Spreadsheet for the common code.


Feature Request: Expose GLFWwindow handle or otherwise allow means of registering certain callbacks

For example I want to handle drag & drop events in my app. This is easy to do with GLFW by calling glfwSetDropCallback(handle, callback). But the window handle isn't currently exposed so modifying Application.cpp is necessary.
If it's undesirable to expose GLFW I'd be fine with some other abstraction for setting the drop callback.

just modify the source code to expose whatever you need, it's an MIT license after all...


fix mgmt command syntax

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 80.042%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sis_provisioner/management/commands/build_file.py
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
766

Relevant Lines:
957

💛  - Coveralls


Update to preview 3 + Use Container for temporal cli

This PR works around a limitation in Aspire around proxy-less endpoints, such as when you are using an executable resource.
https://github.com/dotnet/aspire/issues/1637
Also, Temporal does not yet published a container image for temporal/cli: https://github.com/temporalio/cli/issues/316
This works around both issues.

I'm going to merge this and if anyone has feedback, lmk.


spatial shader: using VIEWPORT_SIZE in VERTEX calculation breaks shadows

Godot version
v4.1.1.stable.mono.official [bd6af8e0e]
System information
Godot v4.1.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1070 (NVIDIA; <IP_ADDRESS>13) - Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 Threads)
Issue description
I'm trying to implement a vertex jitter shader to emulate psx style graphics.
See: https://github.com/AnalogFeelings/godot-psx for a public implementation I am using for reference.
The shader should support shadows but there appears to be a bug in Godot that is preventing shadows from appearing.
As far as I can tell, the issue relates to VIEWPORT_SIZE. The shader uses VIEWPORT_SIZE to scale the jitter based on screensize.
Steps to reproduce

spatial shader
include render mode render_mode skip_vertex_transform
inside the vertex() function,
use VIEWPORT_SIZE in some part of the calculation of VERTEX.

Minimal reproduction project
no_shadows.zip
See screenshot below:

A cube with a default material; shadows are displayed correctly
A cube with a custom material jitter-not-using-viewport.tres; shadows are displayed correctly
The custom material essentially just does VERTEX = round(VERTEX * i) / i;, where i is set by the user
A cube with a custom material jitter-using-viewport; shadows are not displayed correctly
The custom material scales i by VIEWPORT_SIZE.y

Related: https://github.com/godotengine/godot/issues/41420
The underlying problem here is that the VIEWPORT_SIZE builtin changes depending on whether we are at the shadow pass or in a regular drawing pass. In the shadow pass it is Vector2(1, 1).
I don't think VIEWPORT_SIZE is used internally for anything. Therefore, we should be able to just pass the screen size in their when rendering shadows

Lookes like if we want to pass the correct viewport to shadowpass, we have to add more argument to _render_shadow_pass and _render_shadow_append. I will create a pr for this.
Do we need to add the same to compatibility and mobile ? I guess yes.


FeathersVuexCount not found in feathers-vuex

I can't import FeathersVuexCount component in the feathers-vuex
feathers-vuex: 3.13.0

Looks like it just needs to be imported in index.ts and made available in the exports in the same way as is done here: https://github.com/feathersjs-ecosystem/feathers-vuex/blob/master/src/index.ts#L7
Thank you for catching this!


Incorrect language in Privacy screen

Summary: Incorrect language displayed on Privacy page
Description: Upon opening the Privacy page by selecting the link on the main page, text appears in a language other than that used on the rest of the website. All pages of the website should display in the language that is set through the user’s browser, or just be a single consistently chosen language throughout the whole website.
Severity – Trivial: This should be an easy fix, and is low priority due to limited impact on correctness of the deliverable, but the page may contain important and valuable information so it must be readable to the user.

Low Priority Issue

This page also had Latin placeholder text. Privacy now has content.


The given name for the accesstoken is not unique

After creating a valid Bearer token, I get an "error" on "Create an access token for a user" when using the generated Bearer token and user idUser.
I'm 100% sure that I use the complete (long) generated token, and idUser.
{
  "success": false,
  "error_code": "validation_error",
  "errors": {
    "name": "The given name for the accesstoken is not unique"
  }
}

Any help appreciated.

The easiest way is to go to https://vrm.victronenergy.com/access-tokens instead for creating the access token. I'll add that to the documentation too, as that is much easier than the currently documented way.

Dankjewel.


seccomp starts with small letter

issue : seccomp starts with small letter
In security section all the points are starting with capital letter but seccomp starts with small letter. So to maintain uniformity i have changed seccomp to Seccomp.
STEPS TO SEE THE ISSUE

Go to kubernetes documentation
Then find section "Set up a K8s cluster" and click "Setup up Kubernetes"
Then go to Tutorials section and scroll down to Security section

/retitle Ensure seccomp starts with small letter
/lgtm
/approve


Icon load/set race condition

Sometimes the icon of the wrong tool gets assigned. I suspect a race condition when setting the icon (not loading). But I am not sure where exactly. Does not easily repro.

First: add log instrumentation, to tack what's happening. It's impossible to hope for this to happen with an attached debugger.
Most notably: it seems to happen mainly with Fork, and HWallpaper: These two Icons have the identical ID in different executables. So, maybe it is a race condition during loading after all?

Of course, switching on the log function, which needs some thread-sync, seems to resolve the issue. sigh That's good enough for me for now.

Case reproduced today by chance. From the log file:
...
LoadFromIconFile(C:\[...]\Fork.exe, 32512, {128, 128}) HCION = 67418
...
LoadFromIconFile(H:\[...].exe, 32512, {128, 128}) HCION = 67418
...

The lib variable is a local stack variable.
The paths are clearly different.
The HICON icon values returned from lib.GetIcon are identical.
Open questions:

Both load operations could happen on the same thread.
Are the library handles within lib different?

Next up:

code review of two functions IconLibrary::Open and IconLibrary::GetIcon
Extending logs, then waiting for new repro.

[16112] IconLibrary::Open(C:\F*.exe) : GetModuleHandleExW => 0, 0
[16112] IconLibrary::Open(C:\F*.exe) : LoadLibraryExW =><PHONE_NUMBER>497
[16112] IconLibrary::GetIcon(32512, 128, 128) : LoadImageW(1750162538497) => 198482
[16112] IconLibrary::GetIcon(32512, 128, 128) : AssertSize => 198482
[16112] LoadFromIconFile(C:\F*.exe, 32512, {128, 128}) HICON = 198482
[16112] LoadFromIconFile(C:\F*.exe, 32512, {128, 128}) HBMP = 17108661

[3628] IconLibrary::Open(H:\H*.exe) : GetModuleHandleExW => 0, 0
[3628] IconLibrary::Open(H:\H*.exe) : LoadLibraryExW =><PHONE_NUMBER>497
[3628] IconLibrary::GetIcon(32512, 128, 128) : LoadImageW(1750162538497) => 198482
[3628] IconLibrary::GetIcon(32512, 128, 128) : AssertSize => 198482
[3628] LoadFromIconFile(H:\H*.exe, 32512, {128, 128}) HICON = 198482
[3628] LoadFromIconFile(H:\H*.exe, 32512, {128, 128}) HBMP = 50663122

While the handle reused, both for the lib and the icon, could be ok, as the earlier handles are supposed to be already freed, most likely something is keeping them alive long enough that the other thread fails to notice it.
Since this loading is not time critical at all, I suggest a full thread lock.

After introducting the global threadlock for the whole IconLibrary, "luckily," it happend right away again:
[1772] IconLibrary::Open(C:\*\Fork.exe) : GetModuleHandleExW => 0, 0
[1772] IconLibrary::Open(C:\*\Fork.exe) : LoadLibraryExW =><PHONE_NUMBER>441
[1772] IconLibrary::GetIcon(32512, 128, 128) : LoadImageW(2367826493441) => 180750763
[1772] IconLibrary::GetIcon(32512, 128, 128) : AssertSize => 180750763
[1772] LoadFromIconFile(C:\*\Fork.exe, 32512, {128, 128}) HICON = 180750763
[1772] LoadFromIconFile(C:\*\Fork.exe, 32512, {128, 128}) HBMP =<PHONE_NUMBER>2585810456
[1772] IconLibrary::Close() : FreeLibrary(2367826493441)

[5776] IconLibrary::Open(H:\*.exe) : GetModuleHandleExW => 0, 0
[5776] IconLibrary::Open(H:\*.exe) : LoadLibraryExW =><PHONE_NUMBER>441
[5776] IconLibrary::GetIcon(32512, 128, 128) : LoadImageW(2367826493441) => 180750763
[5776] IconLibrary::GetIcon(32512, 128, 128) : AssertSize => 180750763
[5776] LoadFromIconFile(H:\*.exe, 32512, {128, 128}) HICON = 180750763
[5776] LoadFromIconFile(H:\*.exe, 32512, {128, 128}) HBMP =<PHONE_NUMBER>3324009449
[5776] IconLibrary::Close() : FreeLibrary(2367826493441)

(no overlap between the calls)

Was not observed any more after this commit:

24f8027 - Delayed FreeLibrary to avoid memory reuse for different resource dll mappings

I assume it is fixed.


Was this project an april fools ? Doesn't work on windows or mac?

I'm really curious was this an april fools joke? did anyone get this to work? Not trying to be an a-hole to the creators if this is a real project I tried windows and mac and none of them work. This is a problem with most projects on github everyone is giving this project stars but the project don't work yet.... so why are people giving it a star? give it a star once it works if its real....

No this is a serious project.
It's just super early in development, so it's fairly non-functional at the moment.

@codingphasedotcom lol. After building this project locally(just the master branch), I get why you would ask that question.
But like @basedjux said, it's an early project and I'll add, an ambitions one.
I think it's best to be supportive at this point because if it works out, it'll be an amazing and helpful tool.

install electron fool

Does anyone know why this project exploded so heavily right now? I saw it on twitter like alot of people i'm sure and it has achieved a ton of traction sense http://www.timqian.com/star-history/#reactide/reactide
It seems it just wasn't ready, so I wonder if it had an official announcement or was just found? Seems like a great project and I'm excited. Just curios

@alex-bezek awesome observation.  There has been no official announcement, but there have been some small articles stating that it's here.  The traction comes from the fact that these talented developers have identified a serious need in the react community and has chosen to address that need.  It is still in early development, and we should give them the time and opportunity for further development of this project.  -cheers

@basedjux I'm glad I really thought this was another troll project.
@alex-bezek yea I believe someone told somebody about it and then people started posting to blogs lol but it makes no sense no one has it working so what was the point of promoting it so hard. @makenova I love supporting but my only issue is the article that brought me here talked about it as if its really a working project.
This is like me saying "Hey I just created a flying car" and people start creating articles like "Finally Cars Fly" but when people get there all that I have is a steering wheel... I really think this is one of the downsides of github anyone can make a project and somehow it gets trending without people even checking the project.
I'm just saying as a creator and developer.... Don't share a project to bloggers if you know all you have is an idea because now there's a higher expectation and even if it don't work the only person that knows about it is you. It's cool to get recognition and know if people are interested in what you are going to build but this is not the right way to do it.

Just to add to the discussion...
I just found this in GitHub's trending page (it's the top one this week). I LOVE the idea for this project, and I hope I'll be able to contribute. Currently I'm using gedit for React development...

@njtrettel whats gedit?

@codingphasedotcom It's just the linux default text editor

so why are people giving it a star?

To track project (without receiving all the types of notifications)? To tell the creators it's good idea and people want to see more?
The star isn't just for "real projects"...

Hi everyone. Some of this is discussed in #35.

@codingphasedotcom starring a project is a way of expressing interest.  It's not a rating system.


Adds parameters to Deployment class, Set Set ValidateSqlScriptParams to be Deprecated, change the version number of Common to 1.0.15.

Adds parameters to Deployment class, Set Set ValidateSqlScriptParams to be Deprecated, change the version number of Common to 1.0.15.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Display organism name in gene search results for individual genes

Almost done. Just waiting on organism name from REST API. See also KarrLab/datanator_rest_api#100.

Done


flutter build is not printing the flavor bundle identifier that it actually uses (correctly)

I'm using flavors to build ios for different environments
flutter build ios --release --flavor qa
Building com.highxxxsw.xxx for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: 6HXXXX3K
Running pod install...                                              4.1s
Running Xcode build...

 ├─Building Dart code...                                    56.5s
 ├─Generating dSYM file...                                   0.4s
 ├─Stripping debug symbols...                                0.1s
 ├─Assembling Flutter resources...                           1.7s
 └─Compiling, linking and signing...                        17.5s
Xcode build done.                                           115.7s

it shows

Building com.highxxxsw.xxx for device (ios-release)

i would expect it show Building com.highxxxsw.xxx.qa for device (ios-release) for qa flavor
i would expect it show Building com.highxxxsw.xxx.dev for device (ios-release) for dev flavor
and
i would expect it show Building com.highxxxsw.xxx for device (ios-release) for prod flavor
which i have configured in Xcode with different bundle identifier for different flavors

here is my flutter doctor log
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Mac OS X 10.14.3 18D109, locale en-IN)
    • Flutter version 1.5.4-hotfix.2 at /Users/rajeshkumar/Desktop/flutter
    • Framework revision 7a4c33425d (8 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/rajeshkumar/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/rajeshkumar/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.0

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 33.0.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] IntelliJ IDEA Community Edition (version 2017.3.5)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 25.0.1
    • Dart plugin version 173.4700

[✓] VS Code (version 1.35.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.1.0

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

@rajeshzmoke is it the same while using current flutter stable v1.9.1+hotfix.4?

@BondarenkoStas I'm still seeing this on Beta channel

@rajeshzmoke Please confirm this is fixed in Flutter v1.13.7 or later.

@jmagman I'm currently on Dev channel v1.15.16 and I'm still seeing this.
And yes my Info.plist has
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>

Everything on my dev environment and CI builds works perfectly fine, this is just a minor confusing console message that can be ignored.

@jmagman  currently i cannot change the channel and test this but on stable branch command line information still does not show proper flavor used, and we have moved to codemagic for automated builds
Flutter doctor - v

[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.14.6 18G3020, locale en-IN)
    • Flutter version 1.12.13+hotfix.8 at /Users/rajeshkumar/Desktop/flutter
    • Framework revision 0b8abb4724 (4 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/rajeshkumar/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • ANDROID_HOME = /Users/rajeshkumar/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.7.4

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 37.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] IntelliJ IDEA Community Edition (version 2017.3.5)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 29.0.1
    • Dart plugin version 173.4700

[✓] VS Code (version 1.43.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • Rajesh Kumar’s iPhone • 76fd22d0d6fe8432a90a895351b60bd1d159e8ef • ios • iOS 13.1.2

• No issues found!

Seeing the same issue on:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.16.3-pre.7, on Mac OS X 10.15.3 19D76, locale en-AU)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[✓] VS Code (version 1.43.1)
[✓] Connected device (3 available)
As others have said seems to be an issue with the print statement which leads to confusion.

I'm also experiencing this.
Flutter 1.17.0-3.2.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 2a7bc389f2 (2 days ago) • 2020-04-21 20:34:20 -0700
Engine • revision 4c8c31f591
Tools • Dart 2.8.0 (build 2.8.0-dev.20.10)

I'm also experiencing this.
I expect com.highxxxsw.xxx expected for production release
but, it shows com.highxxxsw.xxx.dev. why???
I actually PROJECT
And I can't resolve.
Why Flutter ignores my setting.
I actually set like this.

Sorry, the blue highlight is a secret.
But, I set this actually.

flutter --version
Flutter 1.12.13+hotfix.9 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f139b11009 (5 weeks ago) • 2020-03-30 13:57:30 -0700
Engine • revision af51afceb8
Tools • Dart 2.7.2

suitable is old? Does beta fix it?

@edTheGuy00
Where is Info.plist?
 find . -type f -name "Info.plist"

SO many..

./ios/Runner/Info.plist
./ios/Flutter/Flutter.framework/Info.plist
./ios/Flutter/App.framework/Info.plist

Ah,  1.13.7 fix it?

not yet...

Before build. use it in the project forlder. Is it okey?
/usr/bin/plutil -replace CFBundleIdentifier -string com.company.appname   ios/Runner/Info.plist

Fixed by https://github.com/flutter/flutter/pull/56620.  See https://github.com/flutter/flutter/issues/14648#issuecomment-627079766 for more details.

@jmagman
Thank you for fix.
Is it already available?

@shinriyo https://github.com/flutter/flutter/pull/56620 is currently available on the master channel.  It will be in the next dev release, which hasn't happened yet.

@jmagman Thank you. I'm looking for #56620 release. When is next dev release?

Should be any day now, pending various processes and tests passing.  Don't have an exact date though.


some tag names not supported

Hi, if I have tag called database, they I can't query on those tags
SELECT max(local_write_count) AS local_write_count INTO telegram."biweekly".cassandra FROM telegram."default".cassandra WHERE time > '2016-03-10' AND time < now() GROUP BY time(15s),host,table,database fill(none)
ERR: error parsing query: found DATABASE, expected identifier, string, number, bool at line 1, char 194

Even default telegraf plugins can't be added to continuoues query:
CREATE CONTINUOUS QUERY diskio_months3 ON telegram BEGIN SELECT mean(io_time) AS io_time, mean(read_bytes) AS read_bytes, mean(read_time) AS read_time, mean(reads) AS reads, mean(write_bytes) AS write_bytes, mean(write_time) AS write_time, mean(writes) AS writes INTO telegram."months3".diskio FROM telegram."biweekly".diskio GROUP BY time(1m) ,host, name, serial END
CREATE CONTINUOUS QUERY diskio_yearly ON telegram BEGIN SELECT mean(io_time) AS io_time, mean(read_bytes) AS read_bytes, mean(read_time) AS read_time, mean(reads) AS reads, mean(write_bytes) AS write_bytes, mean(write_time) AS write_time, mean(writes) AS writes INTO telegram."yearly".diskio FROM telegram."months3".diskio GROUP BY time(5m) ,host, name, serial END

@rubycut Do you see the same issue if you wrap the identifiers in quotes? For example, changing:
SELECT max(local_write_count) AS local_write_count INTO telegram."biweekly".cassandra FROM telegram."default".cassandra WHERE time > '2016-03-10' AND time < now() GROUP BY time(15s),host,table,database fill(none)

To:
SELECT max(local_write_count) AS local_write_count INTO telegram."biweekly".cassandra FROM telegram."default".cassandra WHERE time > '2016-03-10' AND time < now() GROUP BY time(15s),"host","table","database" fill(none)

Yes, double quotes work, leaving issue open, needs to be documented somewhere.

I made an issue in our documentation repository to have this clarified. I'm going to close this one. Thanks!


Update on Content-Types list

Hello @cosad3s
Thanks for the suggestion.
Few things:

Unable to merge - could you fix up the merge conflict?
Do you have a source for any of this? (or any more information really?)

The conflict is fixed. I do not know what's going on with all those github actions stuff.
The source of these additions are not really well documented now ... It's an old thing. Check https://www.msxfaq.de/cloud/identity/aadconnect_kommunikation.htm#status_auslesen, or https://github.com/GDSSecurity/WCF-Binary-SOAP-Plug-In for example.

Thanks @cosad3s
Its appreciated <3


Call PostCreation callback only after the new series is added to the Postings

Hi,
We recently added in cortex and thanos a way to cache "expanded postings" for the head blocks and we are relying on the PostCreation to invalidate this cache.
Unfortunately, recently we noticed that the PostCreation is called on the method getOrSet before the created series is added to the postings on (getOrCreateWithID). This causes problems where we invalidate the cache before the new series are available to be queried and so, we can end up caching results without this new series: See https://github.com/cortexproject/cortex/pull/6417
This change is proposing to only call the PostCreation callback after the series is added to the postings so we can rely on this hook to invalidate the cache. Adding the series to the postings is arguably part of the "creation" so, i think it would be more correct anyway.
I did not add tests as there are already tests around those hooks.
cc @codesome as its the author of the original PR: https://github.com/prometheus/prometheus/pull/7159

@jesusvazquez it would be cool to get your approval, too, before merging.


Laravel Mix breaks when moving laravel files into subdir after setting public path

Laravel Mix Version: 1.4.2
Node Version: 6.9.1
NPM Version: 5.3.0
OS: Windows 10

I am experiencing the same issue. Due to the limitation of the host one of my clients is using I was forced to organize my site as follows:
/public_html/warranty (for the public files)
/private_html/warranty (for all other files & folder related to laravel)
Laravel is running fine on the server but Mix is not due to the change in folders. Setting mix.publicPath(../../public_html_warranty) allows me to start the webpack server but none of the js files can be located on the server. (ie localhost:8080/js/app.js)
When running npm run production it will get stuck @ 95%.
When looking at the mix-manifest.json it is clear why:
"/D:/X Labs/productRegistration/public_html/warranty/D:/X Labs/productRegistration/public_html/warranty/js/app.js":
"/D:/X Labs/productRegistration/public_html/warranty/D:/X Labs/productRegistration/public_html/warranty/js/app.js"

The paths are incorrect.
Steps to reproduce:
Install laravel
Move laravel files into subdir
Adjust publicPath var from subdir to public

npm run hot

I was having a similar problem, try this and see if it works for you.


ios: Keyboard can briefly reappear after "Share" is tapped and before the share sheet appears

If the topic or content input in the compose box was focused when you long-pressed a message, then this sequence is reproducible:

The message action sheet opens in response to your long-press
At the same time, the keyboard goes away
You tap "Share", and the message action sheet closes
The keyboard briefly reappears and disappears
The share sheet appears

It would be good to eliminate step 4.
The keyboard's entrance and exit are unnecessary and unexpected changes of context, so I'm labeling this as an accessibility issue (a-a11y). (The cognitive burden is particularly relevant for our users who are easily distracted, for example. It's also possible that some annoyance is created for screen-reader users; I haven't tested so I'm not sure.)
Here is a recording of the behavior, helpfully provided by @Khader-1 on issue #24:

The keyboard's entrance happens because the message action sheet route is popped. The message-list route under it becomes the active route. That route has a focused text input (in the compose box), which makes the keyboard open.
@Khader-1 mentions one possible solution:

Keep the message action sheet open until the share-sheet action completes successfully.

That might be the cleanest thing to do, actually. But we do have a comment in the current code, which I wrote, in the place where we dismiss the message action sheet before opening the share sheet:
    // Close the message action sheet; we're about to show the share
    // sheet. (We could do this after the sharing Future settles
    // with [ShareResultStatus.success], but on iOS I get impatient with
    // how slowly our action sheet dismisses in that case.)

The words "how slowly our action sheet dismisses" refer to the exit animation of the message action sheet. I wouldn't put too much weight on my report of "impatience" there; I didn't spend much time in manual testing, and I'm open to changing my mind about how important it is to be quick there. 🙂
There's an alternative we could try, though, described by Greg at https://github.com/zulip/zulip-flutter/issues/24#issuecomment-1464631585 :

instead of popping the action-sheet route, we replace it with a new route that's the "share from Zulip" route. That route would do very little except (a) summon the system sharing modal, and (b) serve as a placeholder on the navigation stack, so that any state from the route before the action sheet doesn't try to restore itself until the sharing interaction is complete.

If that route replacement were instantaneous (i.e., the message-list route never activated between pressing "Share" and the appearance of the new route), then the keyboard should not reappear, and also the share-sheet action wouldn't have to be followed by the slow exit of the message action sheet.


How does this library compare to https://github.com/kirjs/react-highcharts?

I'm deciding which one to use. The react-highcharts is obviously more popular, but I'm wondering, @whawker, if you'd describe some reasons to use react-jsx-highcharts over the other? Thank you!

react-jsx-highcharts provides a declarative interface to the highcharts library.
React is declarative in nature and unfortunately, react-highcharts doesn't provide a declarative interface to the Highcharts library.  It does very little beyond that and doesn't adhere to how React apps are built. Because of this, it's very difficult to integrate dynamic charts into React using react-highcharts. You'll really feel the pain when you need to update chart data, change display settings, tie into the range selector, etc.
Here's a great overview of declarative programming with React and why it's important:
https://codeburst.io/declarative-vs-imperative-programming-a8a7c93d9ad2

Thanks @nslocum!
As Nick mentioned, the main motivation for this library was to enable dynamic charts, by making Highcharts charts behave like a React developer would expect.
Breaking the chart down into separate components means that we can intelligently update the Highcharts object behind the scenes depending on which React props changed. Rather than passing a large config object as a single property.
I go into more detail on this blog post, but I'll be happy to answer any more question if you have them.

Thanks for the overview! You clearly put a lot of thought into your design.


Fully implement the compute into the IAS editor

Currently (10/26/21) I am waiting for the new model to get put into FDA. This will include the new compute. Right now when the user clicks the "plot" button, we just fill the 4th plot with dummy data. Once we have the compute we need to actually run it when the user clicks "plot" button and make visible to the user any error messages that come out of the compute.

all that is left of this issue is some results reporting?

no. this is jus the IAS editor. I believe this issue has been resolved. @codymccoy please confirm.

This is resolved. Closing.


Sampling rate and application

Hello! We are very glad to read the code you've shared here. It saves a lot of time for our work!Then we noticed that the audio file sampling rate of file in the dataset is 8k.However, the current audio files are mostly 44.1k.So we wonder if it'll be a good result for the module if  44.1k is used.
In addition, we wonder if this model can be  used in other scenes，for example, to separate mixing birds songs.
Thanks again for your contribution!

I'm not sure you can be sure whether he is feasible for your task. If you
have a supervisory signal, it should be feasible.
dalision<EMAIL_ADDRESS>于2020年10月9日周五 下午5:24写道：

Hello! We are very glad to read the code you've shared here. It saves a
lot of time for our work!Then we noticed that the audio file sampling rate
of file in the dataset is 8k.However, the current audio files are mostly
44.1k.So we wonder if it'll be a good result for the module if 44.1k is
used.
In addition, we wonder if this model can be used in other scenes，for
example, to separate mixing birds songs.
Thanks again for your contribution!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JusperLee/Dual-Path-RNN-Pytorch/issues/21, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIB5NQRH6ALIMVQJHQOVJITSJ3JDJANCNFSM4SJ2SVMQ
.

--
Kai Li
Student, Tsinghua University
18594841812 |<EMAIL_ADDRESS>likai.show https://www.likai.show/
Tsinghua, Beijing, China


Add missing polyfills for ie8

This allows to gather coverage in ie8
/cc @j0tunn @scf2k

Coverage remained the same at 65.4% when pulling f1ca35030ab8bc1983d6fc5ebd89250fd6138933 on fix/missing-polyfills into 17f2cc5dbafe8e90e0a8463ce857aadb2f704afd on master.

:up:

Coverage remained the same at 65.4% when pulling 76e8f16f5589e33f6d7ca24f5ee7654478d62541 on fix/missing-polyfills into 17f2cc5dbafe8e90e0a8463ce857aadb2f704afd on master.


Name the account folder based on the account alias

Rather than naming the account account, it'd be nice to name it based on the account alias. Not entirely sure how the implementation would work. May want to do it as a script.

made obsolete by new module structure #242


Can't compile in HA add-on

Hi! I am using the HA add-on to install a very basic yaml file on a bk7231t. I managed to install the starting yaml after I reinstalled the add-on, but now I can't compile an updated version.
Below is the log output from the compiling:
logs_test2_compile.txt
I am using the dev framework.
What should I do to make it work?

Hello! Try uninstalling and installing the addon again. it will remove all the caches and it will pull again the platforms. Your configurations will not be lost.

Well, I reinstalled the add-on, but it has a similar error with the api.
logs_test2_compile (1).txt
Is this a known problem?

Not something I'm aware off. On what machine are you trying to compile it ? Maybe it's a lack of RAM on the machine...

I'm using a pi 4 2gb for HA and add-ons. I don't know what is causing this issue, but it compiled one time without problems.

2GB is a a bit less for esphome. I had that issue one time so i switched to a 4GB one. You can try and disable some addons and try again to see if it compiles sucessfully. Also you can monitor your RAM using http://<ha_address-here>/config/hardware

I never had any issues with the original Esphome add-on. This time it worked and it compiled. I think that someone should look into this issue.

That was my exact problem. Sometimes it compiles, sometimes it didn't (same hw, with the official esphome addon, not the fork). It was running in a VM with 2GB ram. After i increased the ram, everytime it compiled fine. On the 2GB VM the ram usage spiked to 1.9 GB and then it crashed the compilation.

I will stop some add-ons when compiling in the future. I saw a closed issue in which the solution was to uninstall and install the add-on again. I hope that this is a known issue and it will be resolved soon.
@catalin2402 thank you for your help.

It looks like this is related to an OOM event, you should check the kernel log (with dmesg or something similar) to check if there is an OOM message.
arm-none-eabi-g++: fatal error: Killed signal terminated program cc1plus
If that's the case, the OOM can happen sometimes only, depending on running processes and is not a code bug. It can also happen that the OOM occurs, but it kills a different process, and your compilation ends just fine.
https://www.kernel.org/doc/gorman/html/understand/understand016.html


Muted == when highlighted

After the realization I made in https://github.com/auroral-ui/aurora-obsidian-md/issues/5 , it seems that for  ==highlighted== the == stick out quite a bit compared to other syntax highlighting like **bold**.
I think it'd make sense to use a similar style for == that ** uses

Thanks for reporting, I will look into this one.

@technicalpickles This is fixed in the latest commit.


ESP32 with MPU6050 ping no work

can you helo me, i have a ESP32 WEMOS OLED , i trying your library but dont work , only print constants values :

9:45:02.820 -> GyroY = -0.02 degrees/second
09:45:02.820 -> GyroZ = -0.02 degrees/second
09:45:02.820 -> --- Accel angles:
09:45:02.820 -> AccelAngX = 180.00
09:45:02.867 -> AccelAngY = 180.00
09:45:02.867 -> AccelAngZ = 45.00
09:45:02.867 -> --- Gyro angles:
09:45:02.867 -> GyroAngX = -5.45
09:45:02.867 -> GyroAngY = -5.45
09:45:02.867 -> GyroAngZ = -5.45
09:45:02.867 -> --- Filtered angles:
09:45:02.867 -> FilteredAngX = 177.94
09:45:02.867 -> FilteredAngY = 177.94
09:45:02.867 -> FilteredAngZ = 42.94
09:45:02.867 -> --- Angle filter coefficients:
09:45:02.867 -> Accelerometer percentage = 0.02%
09:45:02.867 -> Gyroscope percentage = 0.98%
09:45:02.867 -> --- Deadzone:
09:45:02.867 -> Accelerometer deadzone = 0.00 m/s²
09:45:02.867 -> Gyroscope deadzone = 0.01 degrees/second

i was testing disconect MPU to ESP32 but the result is the same

Hi @cruizg!
I'm back on developing this library, so your issue can probably be solved on release 0.5.0, if still in need. Let me know as soon as I release it!

Release 0.5.0 is now out here.
I'll close this for now. If you continue to have issues please contact. Thanks!


View compiler references deferred libraries (illegally)

Ran into this while debugging https://github.com/dart-lang/angular/issues/1539.

If you use @deferred in a certain way (details pending), the following is emitted:
import '1539_nested_template_test.dart' deferred as deflib0;

class ViewNestedTemplateTest0 extends AppView<deflib0.NestedTemplateTest> { ... }

That is illegal in Dart, resulting in:
[error] The deferred type 'deflib0.NestedTemplateTest' can't be used in a declaration, cast or type test

This is based, I believe, on trying to re-use existing import statements. We should not be treating deferred libraries as something usable for types. This might be trivial to fix, it might not, but it makes the usability of @deferred fairly brittle :(

Source of issue is here, might be trivial actually:
https://github.com/dart-lang/angular/blob/5ad73932b7885ce78b1371bbe79628f5fec3d6d6/angular/lib/src/compiler/output/dart_emitter.dart#L576-L617

After talking offline, we'll likely just fail instead of waiting for DDC/Dart2JS to fail.


Send abuse reports to an appservice via the transations API

We have an API for submitting abuse reports to the homeserver, where reading those reports is left as an exercise the the reader. It would be nice if we could re-use the AS transactions API to push those abuse reports to an interested party (hey Mjolnir!).
Obviously I'd imagine some kind of opt-in flag rather than every appservice seeing abuse reports, for security purposes. Something like a push_reports: true in the registration file.
(This is crying out for an MSC, but I lack the time atm).

the current spec is permissive of this ftr - abuse reports can be handled however the server wants.


Integration with Appflow

Thanks for the good example. Both Ionic and Capacitor are great products.
But I'm having trouble integrating it with Appflow. When installing Appflow SDK, react-scripts build is required, but it is not compatible with nextjs environment. Please let me know if there is any way. Can't I use nextjs and Appflow together?
Installation Appflow SDK : https://ionic.io/docs/appflow/quickstart/installation
Here's what I tried.
$ ionic deploy add \
--app-id="APPFLOW_APP_ID" \
--channel-name="Production" \
--update-method="auto"
[WARN] Live Updates plugin already added. Reconfiguring only.
> ionic deploy manifest
[OK] Appflow Deploy manifest written to ./build/pro-manifest.json!
> ionic capacitor sync
> react-scripts build

[INFO] Looks like react-scripts isn't installed in this project.

       This package is required for this command to work properly.

? Install react-scripts? No
[WARN] Not installing--here's how to install manually: npm i -D -E react-scripts

[ERROR] react-scripts is required for this command to work properly.

When react-scripts is installed, files not used by nextjs such as index.html are required.

Hey thanks for the heads up, we'll look at why react-scripts is required here...

Is there any update? 😢  @mlynch

is this still an issue or has it been fixed?


[FIX] Added appropriate wildcards in the log and in the benchmarking files of two…

… rules. ( getBamHeader and createReferenceHeaderFile) The newest snakemake version throws an error if they are missing.

Thanks!
I think it is not only snakemake, but the interplay between the cluster system and snakemake (so it should still be running if not submitted).
Another thing, could you change the file ending from "{tumor}.getBamHeader.lsfout..." to "{tumor}. header.lsfout..." while you are already at it. This way it is more inline with all the other rules.
Thanks again!


Now that Data Deduplication is available, make the LineSender safer

There are several issues and pull requests throughout this repo that discuss the fact that the LineSender is not fully safe, i.e. there's issues in auto-reconnection, there's no way to retrieve the failed sent buffer to retry if there is a connection issue, etc.
@puzpuzpuz has said that this can't be implemented without data deduplication on the server side.
According to the QuestDB Docs site, data deduplication is implemented on the DB since QuestDB 7.3: https://questdb.io/docs/concept/deduplication/
Can we get this MAJOR ISSUE fixed (at the very least as an option on the client that we can enable) so we can have some better safety in what will happen if there's a connection issue, so we don't lose data and we don't have to implement reconnection logic on our own?

@puzpuzpuz I agree that commit/error propagation is important, but adding a reconnect+resend of the current batch is something that can be added regardless of commit/error propagation. If there's a TCP write error or a broken pipe, the entire batch is lost on the client side, which is a pretty critical thing to lose, and it doesn't relate to propagating errors from the actual write itself, just to making sure that we don't lose data when there is a TCP error.
This feature can be added now, so that clients don't lose data due to TCP issues (regardless of database write issues).

Closing this one since v3 shipped HTTP sender which allows explicit control over transactions and has automatic retry behavior.


Do you provide development documents

Do you provide development documents

Please check https://rancher.com/docs/rancher/v2.x/en/contributing/ and
https://github.com/rancher/rancher/wiki


[illustration] got rid of icon-transform-svg

Motivation and Context
For now icon and illustration packages are handled by internal icon-transform-svg package. It's weird and produces bugs in the final markup. As the next step I am going to remove this package from icon and from repository at all.
How has this been tested?
I have visually checked that all illustrations are rendered well in Chrome, Firefox and Safari
Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[x] Nice improve.

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly or it's not required.
[x] Unit tests are not broken.
[x] I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
[ ] I have added new unit tests on added of fixed functionality.

Took these changes to the master with cherry-pick


best way to update OS X Yosemite after using CAT

Hi folks,
Just curious whether there are any precautions necessary when updating OS X Yosemite (e.g. to 10.10.2) after using CAT to get Continuity working on my Mac. I'm using a GMYLE dongle on a late 2011 MacBook Pro, in case that matters.
I'm especially wondering whether the modified kexts in /System could impact the update in any way, and whether I can safely assume that the OS X update will simply overwrite the modified versions with clean, updated versions.
I'm also wondering what happens to the backed up kexts in my Documents folder, like whether they are simply overwritten with new versions when CAT is run again after the update, and whether I should be keeping copies of the pre-update versions for any reason.
And I'm wondering whether CAT would ever need an update to handle a given OS X update.
It would be easy enough to undo CAT before the update, and then redo CAT after the update, but it would also be nice to skip the extra step if all of this is cleanly handled for me, especially since there are likely more OS X Yosemite updates coming.
Thanks for any info you can provide.
Eric

Hi @EricPSmith,
Good questions, I'm answering them separately.
TL;DR: If an OS X update breaks Continuity, just apply CAT again, it's safe.

I'm especially wondering whether the modified kexts in /System could impact the update in any way, and whether I can safely assume that the OS X update will simply overwrite the modified versions with clean, updated versions.

That's correct, when Apple provides an OS X update with fixes to the wireless drivers, it overwrites the existing ones with clean, updated ones. When there aren't Wi-Fi or Bluetooth related fixes in an OS X update, then the existing patched kexts will stay as such and won't need to be re-patched by CAT.

I'm also wondering what happens to the backed up kexts in my Documents folder, like whether they are simply overwritten with new versions when CAT is run again after the update,

If CAT detects existing backed up kexts, it will ask you whether you'd like to overwrite the existing backups or not during the activation procedure.

and whether I should be keeping copies of the pre-update versions for any reason.

It's useful to keep a backup of your previously patched kexts, in case CAT doesn't know how to patch the kexts that come with an OS X update. That hasn't happened so far, but in that scenario, your best bet is to

make a manual backup of the new OS X IOBluetoothFamily.kext and IO80211Family.kext (located in /System/Library/Extensions).
manually install older kexts that are known to work, e.g. the ones that are stored by CAT in the KextsBackupAfterPatch folder.
see if your system is stable or not. As far as I know, OS X has not been designed to run with a mix of old/new kext versions and might become unstable.

And I'm wondering whether CAT would ever need an update to handle a given OS X update.
Maybe, we don't know.

CAT has been built to detect the patterns it needs to modify in the kexts before patching, independently from the OS X kext version. If it doesn't find the patterns, then the activation will abort and no changes are made. So far, it has worked with all OS X versions, because the patterns that need to be modified have a small footprint in the kexts and can be easily isolated. So we can just hope CAT continues to be compatible with future OS X versions. In the worst case, it's worth restoring and testing an old kext backup as described above.

It would be easy enough to undo CAT before the update, and then redo CAT after the update, but it would also be nice to skip the extra step if all of this is cleanly handled for me, especially since there are likely more OS X Yosemite updates coming.

CAT doesn't need to be uninstalled before an OS X update. The worst case scenario is that the patches are undone by clean new kexts replacing the old patched kexts. You'll just get regular Wi-Fi / Bluetooth but no Handoff / New AirDrop etc. To activate again, just use the CAT activation. An automatic update could technically could be a nice addition, I've written a draft of how it could work here. I've no plans to implement this, mainly due to the related risks of automating low-level mods with unknown, future OS X releases. The effort/benefit ratio is also not worth it IMO.

Hi dokterdok,
Thank you for the clear explanation. The interaction between CAT and OS X makes much more sense to me now.
I went ahead with the Yosemite 10.10.2 update, using what I thought was a fairly cautious approach, yet ran into CAT-related troubles even so.
Going into this, I had new AirDrop, as well as my Apple wireless keyboard & trackpad, working fine with my MacBook Pro late 2011 (OS X Yosemite 10.10.1) through a GMYLE Bluetooth LE dongle, activated via CAT 2.0.0.
I started the OS X Yosemite 10.10.2 update by quitting all apps, verifying both my internal drive and the startup volume on it with disk utility, and then repairing disk permissions. I then proceeded with installing the OS X update through the Mac App Store, leaving my Bluetooth on and my wireless keyboard & mouse in use during the update. In retrospect, leaving Bluetooth on may have been behind at least some of my troubles.
Upon completion of the OS X update, I was surprised to find the light on my Bluetooth dongle flashing (i.e. in use), as I had expected the update to force a return to the built-in Bluetooth hardware. (The dongle’s light goes on solid when powered but without a driver.) At this point my wireless keyboard and mouse seemed to be working fine, but it’s not clear to me which Bluetooth hardware they were using. When I checked for AirDrop, the Mac did not see my iPhone, and my iPhone did not see my Mac.
I then ran CAT 2.0.0 to reactivate continuity, which appeared to run fine, and reported no issues. Following the requisite restart, my wireless trackpad was extremely jumpy and erratic, to the point of being unusable. Unpairing and repairing seemed to help very briefly, but then the completely erratic behavior returned. Meanwhile, my wireless keyboard was mostly working, but occasionally showed mysterious behavior, like sporadically changing the OS X volume setting (as seen by HUD) without my ever getting near the top row of keys. (I’ve used this keyboard for nearly three years, and have never seen this behavior. I couldn’t figure out how to reliably reproduce it.)
Seeing that my system was confused, I turned off Bluetooth and then uninstalled CAT.
After the requisite restart, I encountered even more bizarre behavior. With the OS X Bluetooth menu indicating that Bluetooth was off, and with the Bluetooth dongle’s light on solid, my wireless keyboard was still working.
I turned Bluetooth back on after the CAT uninstall, and my wireless trackpad started working, but with the same erratic behavior as before. Meanwhile, in the Bluetooth system preferences pane, my wireless keyboard status was ‘not connected,’ yet it continued to work.
At this point, I removed both the keyboard and trackpad from the Bluetooth paired devices list. Somehow, my wireless keyboard still worked.
Finally, with Bluetooth left on, I shut down my Mac, removed the Bluetooth dongle, and then powered back up. Once the Mac powered up, my wireless keyboard & trackpad went back to working normally, with no further issues.
—————
After taking a break from all the disruption, and confirming over days that my native Bluetooth was working properly in 10.10.2, I gave CAT another shot.
I saw on the CAT beta page a 2.0.1 release, but it was not clear to me how to download that version in executable form. Not knowing which version I would get, I redownloaded CAT using the Download Zip button and replaced the copy I had with that fresh one. When launched, it indicated v2.0.0.
With my Mac running fine on OS X 10.10.2 with built-in Bluetooth, I quit all apps, turned off Bluetooth as a preventive measure, and ran CAT’s activate continuity command. The script aborted, complaining of no Bluetooth 4.0 hardware, with no prompt to insert dongle (I had gotten such a prompt with 10.10.1).
I returned to the CAT main menu, inserted the Bluetooth dongle, and ran activate continuity again. The script ran through to completion this time without issue, other than overwriting backup kexts without asking for permission first or offering an alternative.
Before proceeding with the script-prompted reboot, I used Disk Utility to repair permissions on the startup volume, which fixed permissions on a bunch of items in the two patched kexts in /System/Library/Extensions. Then I rebooted.
Following the restart, the Bluetooth dongle’s light was solid, and the Bluetooth menu still indicated that Bluetooth was off, yet my wireless keyboard was somehow working even so (but not my wireless trackpad).
I went to restart again to see if this strange behavior would clear up, and inexplicably during the shutdown process got a password prompt from CAT saying it wanted to make changes. I never give OS X permission to reopen apps on restart, so I don’t know how CAT could have been running after its own terminating reboot. Canceling this password prompt allowed CAT to quit and the restart to proceed.
After this second restart, my wireless keyboard continued to work despite the Bluetooth menu’s indicating that Bluetooth was off, and I went ahead anyway. Turning Bluetooth on caused the dongle’s light to go from solid to blinking; at the same time, Pair buttons appeared beside my wireless keyboard and my wireless trackpad in the Bluetooth system preferences device list. I was able to pair each device successfully, and so far both are working well.
I tested AirDrop from my iPhone to my Mac, and it worked perfectly on the first try. When I tried the other direction, the Mac saw the iPhone, but got stuck Waiting… once the transfer was initiated. As I found before, briefly enabling Airplane Mode on iPhone cleared up the block, and the file transfer completed successfully.
I'm really happy and grateful to have AirDrop and the other Continuity features again. At the same time, I'm a bit disappointed by how messy this process has been, preserving those features through an OS X update. Perhaps these detailed notes will shed light on how to make it smoother and easier.
Many thanks,
Eric


prettyprinting not working in FF

all occurrences of log() function as well as fx-inspector do not work as wanted on FF due to its lack of support for XSLT output intend.
A better solution will be needed.

inspector will use codemirror eventually anyway making this non relevant

out of scope - enought other ways to do it


Change camel-version for capabilities-removal commits; refresh

https://github.com/jboss-fuse/camel/pull/2622 https://github.com/jboss-fuse/camel-spring-boot/pull/453 were breaking changes that changed API; need new camel version

We're back to green, I'm merging this


git-commit: fix variable predicates

git-commit-summary-max-length should be a number, not a symbol.
git-commit-major-mode should be checked more carefully, as otherwise
exploits are possible (e.g. if it is erase-buffer or some dangerous
function of the user's environment).

Thanks!


cleanmymac asks to be moved to /Applications

Similar to #21115, but this time it's already in /Applications and suppress_move_to_applications appears to already be there in the code.

https://github.com/caskroom/homebrew-cask/blob/master/Casks/cleanmymac.rb

How is this popup even showing up? HBC literally moves applications now, not symlinks.
Do you have a different directory set in HBC options possibly?
If not, I'd mark it as a CleanMyMac bug (I refuse to install the app to troubleshoot, as it screams useless)

Yeah, I don't get it either. The app is already in /Applications. Caskroom's installation directory is /usr/local/Caskroom, should it be something else?

Caskroom's installation directory is /usr/local/Caskroom

That’s just a staging directory.
I cannot reproduce this issue, and it seems like it might be something in your setup. Will close but keep an eye out for other reports of this.


privileged: Add containerd and crio versions.

Add containerd and crio versions that support
privileged_without_host_devices behaviour.
Fixes #638
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

/test-ubuntu


British Airways A350-1000

it might need a smol bit of editing

I fliped the text on the one side, and extended the blue line on the bottom. It's basically ok, I will look after where the flaps and etc. comes.

I fliped the text on the one side, and extended the blue line on the bottom. It's basically ok, I will look after where the flaps and etc. comes.

thx

oh

and

and

comparing it to this

Half of the problem solved, the text and the flaps are now good. I will think about the middle of the fuselage.

ok


Implement machine info changes and machine deletion for the inmemory database

When you do this, alter the tests to remove the workaround introduced in f419c2ddb9a46543993b6d5bab9ae12cb2f1dc19 (there's another case of it in the test that follows to)

#156

Blocked on #143

Done


Add discoverability and deviceinfo to mqtt-vacuum

Description:
Adds discoverability for mqtt-vacuum and enables deviceinfo if supplied.
I can't figure out the testing, need help/guidance ...
assert setup_component(self.hass, vacuum.DOMAIN, {  vacuum.DOMAIN: self.default_config })
entity = self.hass.states.get('vacuum.mqtttest')

yields NoneType, but the tests for mqtt cover is "the same" and it seems to work.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

This needs to be split up into multiple PRs, otherwise it's not really possible to review:

ABBREVIATIONS
One for making vacuum a config entry component.
One for making vacuum.mqtt discoverable.
One for adding device reg feature for vacuum.mqtt
One for other refactors you've done in the vacuum.mqtt source.

I guess some of these could be combined (abbreviations for example), but ideally they're in separate PRs.
Oh and also you need to update (and add) tests for this platform in the tests/ folder - this platform is core and therefore needs to be tested thoroughly.


App bar scrolling doesn't follow material spec

What Angular MDC version are you using?
v0.35.7
What browser(s) is this bug affecting?
Google Chrome
What OS are you using?
Windows 10
What are the steps to reproduce the bug?
Add an app-bar in your page or open https://stackblitz.com/edit/angular-mdc-app-bar
What is the expected behavior?
Expected - https://material.io/design/components/app-bars-top.html#behavior

Upon scrolling, the top app bar can remain in place, or transform in the following ways:

Scrolling upward hides the top app bar
Scrolling downward reveals the top app bar

When the top app bar scrolls, its elevation above other elements becomes apparent.
The top app bar disappears upon scrolling up, and appears upon scrolling down.
Top app bars can be positioned at the same elevation as content. Upon scroll, they increase elevation and let content scroll behind them.
When scrolling up, prominent top app bars using imagery can transform into normal top app bars. They should not return to prominent mode until the user scrolls back to the top of the page.

What is the actual behavior?

If not fixed, the app bars go out of vision and there is a white area in its stead.
Material design specs for app-bar scrolling are not fulfilled.

Any other information you believe would be useful?
Current behavior of prominent app bars -

Expected behavior of prominent app bars -

Investigated and thankfully it's just a problem in the example for demo-app. Working on a fix.

@batbrain9392 Updated our StackBlitz example, and demo-app will be updated shortly.
https://stackblitz.com/edit/angular-mdc-app-bar?embed=1&file=app/app.component.html

When the bar is prominent and fixed, then its behavior should not be static, but dynamic in the following way described :

Yep! Thanks for the update. Fixing, this problem was cause for delaying v0.36.0.

@batbrain9392 Fyi, prominent app bars transforming into normal app bars is a missing feature of material-components-web, and can be communicated upstream for a fix.


StudentsImporter: Mark students missing from export as missing_from_last_export

Who is this PR for?
educators, originally came up for folks in New Bedford
What problem does this PR fix?
For some schools in New Bedford, there have been student withdrawals this year.  The export code on their side expresses this by removing the students from the export list (Bedford does the same).  In Insights, StudentsImporter just doesn't process these rows.  This means students who have withdrawn are still shown on homeroom rosters and other places in Insights when they shouldn't be.
The root cause of this mismatch is because Somerville's export process is different - it includes all students and sets different enrollment_status values.
What does this PR do?
Updates RecordSyncer to add a new public method, process_unmarked_records! which is a more generic version of the existing delete_unmarked_records! method.  Updates  StudentsImporter to use the more generic method, and to set missing_from_last_export: true for each Student record within scope of the import that is missing, instead of deleting the record.
On the read path, Student.active now also considers this bit in addition to enrollment_status.
Checklists

[x] Author improved specs for code in need of better test coverage
[x] Author included specs for new code

selfie, this has an env flag for controlling the read path, so I'll do 1) deploy / migrate 2) run import task and verify 3) update read path


Force material selection, debounce searches and fix tips error handling

Check the submitted material contains a valid material from the search list, if it doesn't the form will display a not found error message instead of submitting.

Other improvements

Debounced API calls to the material search endpoint by 250ms
Debounced API calls to the HERE maps auto suggest endpoint by 500ms
Fixed an issue with the app crashing when the tip API endpoint errors

:tada: This PR is included in version 1.38.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update dotnet-help.md

Testing dotnet help new command on .NET version 7.0.201 gives back the following error:
Specified command 'new' is not a valid SDK command. Specify a valid SDK command. For more information, run dotnet help.
Adding -h or --help seems to resolve this issue.
Summary
Documentation Correction
Fixes #Issue_Number (if available)

@dotnet-policy-service agree

I was confused about the expected behavior of the command.  In .NET 7 there is a bug preventing dotnet help new from opening the corresponding docs page.


Restore tests of smart-contracts

Some contracts tests still fail after update to chaindb and change block interval to 3 seconds. Fix them.

[x] 1. Vesting
[x] 2. Emission
[x] 3. Control
[x] 4. Posting
[x] 5. Posting Rewards

Vesting fixed in #201

PR #203


webpa-url with IPv6 address as host does not work

When IPv6 address is passed like --webpa-url="http://[2001:558:fc18:2:f816:3eff:fe7f:6efa]:8080"
then due to ":" parsing in url this address will not work even if valid.
This IPv6 address parsing in URL needs to be fixed.

Fixed


Please provide a .d.ts file

Would you please consider providing a type definitions (.d.ts) file with this package?  I see you've put good jsdoc comments so it should be pretty easy to generate as part of your build process.  Thanks!

it should be pretty easy to generate as part of your build process.

@grosch if it's easy, please open a pull request, thanks.


currency change error on velocity theme

ok so when i make the currency For Iranian rial like below :

and when i change the default channel currency to be rial the store gives this error :
Trying to get property 'code' of non-object (View: C:\wamp64\www\vnicolas\resources\themes\velocity\views\UI\header.blade.php) (View: C:\wamp64\www\vnicolas\resources\themes\velocity\views\UI\header.blade.php) (View: C:\wamp64\www\vnicolas\resources\themes\velocity\views\UI\header.blade.php) (View: C:\wamp64\www\vnicolas\resources\themes\velocity\views\UI\header.blade.php)

Same here, please help

@farshadff same error here, please help.

@sathishpurumani
try to select all the currency in channel->currency https://prnt.sc/sl1g2x

Same issue with me.
No matter how many currencies I select in the default channel, if USD is not one of them, I will receive the same error.

You must clean the browser caches/session and the reload the page. Try acessing it trough incognito tab first so you can see it working.
I hope it helps.

@sathishpurumani
try to select all the currency in channel->currency https://prnt.sc/sl1g2x

I selected all the currencies in the channel and selected my default as INR, but the frontend displays USD only

@Deepanjali-Singh
try to check in the incognito mode.


Issue with imports

The current version on GitHub is failing to import if installed, looking into it now

Okay Should be good now, had to define the package in setup tools, got mixed around when I was changing things the other day.


Concrete syntax for Contract Template DOM

The structure of a full contract and clause template is determined by the Cicero DOM:
https://models.accordproject.org/cicero/dom.html
Also see #79
We need to decide on a concrete syntax for the DOM that we want to put in the Cicero Template Archive.
The proposed name for this syntax is: TBD.
The assumption is that non-technical users will use an editor (web or embedded in MS Word) to edit Cicero contracts (rather than editing this syntax directly), however it is valuable for technical users to have a concrete syntax that is amenable to editing in Emacs, VS Code etc and that integrates smoothly with Git-based workflows for change management.
Current proposals are:

Just use the native JSON serialization
An XML Schema defined serialization
A Nunjucks inspired serialization
A Markdown inspired serialization
Subset of HTML

References:

Common Form: https://commonform.org/kemitchell/apache-2/1e
Common Accord: http://www.commonaccord.org/index.php?action=source&file=G/US-Constitution-CmA/Article/1.md
OpenLaw: https://docs.openlaw.io/markdown/index.html
Legal Document ML: http://docs.oasis-open.org/legaldocml/akn-core/v1.0/akn-core-v1.0-part1-vocabulary.html
https://tools.ietf.org/html/rfc1896
http://doc.qt.io/archives/qt-4.8/richtext-html-subset.html
Commonmark: https://github.com/commonmark/commonmark.js

Native JSON:
{
    "$class" : "org.accordproject.cicero.dom.ContractTemplate",
    "id" : "contract-001",
    "content" : {
        "$class" : "org.accordproject.cicero.dom.Section",
        "id" : "section-001",
        "heading" : {
            "$class" : "org.accordproject.cicero.dom.Text",
            "content" : "LAND SALE CONTRACT",
            "id" : "section-001-heading"
        },
        "children" : [
            {
                "$class" : "org.accordproject.cicero.dom.Text",
                "id" : "sections-001-001",
                "content" : "The first party (henceforth known as "Buyer") agrees to purchase from the second party (henceforth known as "Seller") the land (henceforth known as "Land") located at the following address:",
            },
            {
                "$class" : "org.accordproject.cicero.dom.Parameter",
                "id" : "parameter-address",
                "name" : "address"
            },
            {
                "$class" : "org.accordproject.cicero.dom.Text",
                "id" : "sections-001-003",
                "content" : ", in the city of "
            },
            {
                "$class" : "org.accordproject.cicero.dom.Parameter",
                "id" : "parameter-city",
                "name" : "city"
            }
        ]
    }
}

XML:
<!DOCTYPE accordproject>

<contract>
  <ergo>
    define function area(r : float) : float { return pi * r^2.0 }
  </ergo>

Land Sale Contract

The first party (henceforth known as the <defn>Buyer</defn>) agrees to
    purchase from the second party (henceforth known as <defn>Seller</defn>)
    the land (henceforth known as the <defn>Land</defn>) located at the
    following address:
    <input name="address" class="org.accordproject.address"/>,
    in the city of
    <input name="city" class="org.accordproject.string"/>.

    The <term>Buyer</term> shall pay the <term>Seller</term> for the land.

...

    These countries are exempt from this contract:

Canada

Mexico

    Note: This contract does not apply to so-and-so.

    <signature>
      <name>Dan Selman</name>
      <affiliation>Clause, Inc.</affiliation>
      <date>July 26, 2018</date>
    </signature>

    <signature>
      <name>Kartik Chandra</name>
      <affiliation>Stanford University</affiliation>
      <date>July 26, 2018</date>
    </signature>

</contract>

(I like the XML syntax… 😄)

I'll add a markup version for comparison, inspired by nunjucks:
{% contract %}
  {{
    define function area(r : float) : float { return pi * r^2.0 }
  }}

  {% section:land-sale-contract %}
  {% title %}Land Sale Contract{% endtitle %}

  The first party (henceforth known as the {[Buyer]}) agrees to
  purchase from the second party (henceforth known as {[Seller]}) the
  land (henceforth known as the {[Land]}) located at the following
  address:

    {[address:org.accordproject.address]}, in the city of
    {[city:org.accordproject.string]}.

    {# we can reference past definitions inline pretty easily #}
    The {{ contract.address }} shall pay the {{ contract.city }} for the land.

    {# tables do not come for free #}
    {% table %}
      {% row %}...{% endrow %}
    {% endtable %}

    {# comments come for free, though, now that I think about it #}

    {% lists do not come for free %}
    These countries are exempt from this contract:
    {% list %}
      {% item %}Canada{% item %}
      {% item %}Mexico{% item %}
    {% list %}

    {# and of course no formatting #}
    Note: This contract does not apply to so-and-so.

    {% signature %}
      {{ contract.Buyer }}
      {[ buyerAffiliation ]}
      {[ buyerSignedDate ]}
    { %signature %}

    {% signature %}
      {{ contract.Seller }}
      {[ sellerAffiliation ]}
      {[ sellerSignedDate ]}
    {% signature %}

  {% endsection %}
{% endcontract %}

I had something more like this in mind...
While Markdown is much less expressive and extensible than XML, this option has the advantage of legibility by a less technical user. The trade-off is that extensions need to be written in HTML, and introduce two notations to the concrete syntax.

    define function area(r : float) : float { return pi * r^2.0 }

# Land Sale Contract

The first party (henceforth known as the {[Buyer]}) agrees to
purchase from the second party (henceforth known as {[Seller]}) the
land (henceforth known as the {[Land]}) located at the following
address:

{[address:org.accordproject.address]}, in the city of
{[city]}.

The {{ contract.address }} shall pay the {{ contract.city }} for the land.

| Header 1 | Header 2 |
| --------- |--------- |
| Row 1       |  Cell 2 .   |

These countries are exempt from this contract:
- Canada
- Mexico

**Note:** This contract does *not* apply to so-and-so.

    {{ contract.Buyer }}
    *{[ buyerAffiliation ]}*
    {[ buyerSignedDate ]}

    {{ contract.Seller }}
    *{[ sellerAffiliation ]}*
    {[ sellerSignedDate ]}

And by way of demonstrating one advantage, here's the rendering of the same template in GitHub.

    define function area(r : float) : float { return pi * r^2.0 }

Land Sale Contract
The first party (henceforth known as the {[Buyer]}) agrees to
purchase from the second party (henceforth known as {[Seller]}) the
land (henceforth known as the {[Land]}) located at the following
address:
{[address:org.accordproject.address]}, in the city of
{[city]}.

The {{ contract.address }} shall pay the {{ contract.city }} for the land.

Header 1
Header 2

Row 1
Cell 2 .

These countries are exempt from this contract:

Canada
Mexico

Note: This contract does not apply to so-and-so.

  {{ contract.Buyer }}
  *{[ buyerAffiliation ]}*
  {[ buyerSignedDate ]}

  {{ contract.Seller }}
  *{[ sellerAffiliation ]}*
  {[ sellerSignedDate ]}

Note that none of these examples capture the logical parts of the DOM, e.g. choice or conditional sections. And the XML and MD examples don't include unbounded lists.
For JSON
{
        "$class" : "org.accordproject.cicero.dom.Choice",
        "required": true,
        "elements": [
             {
                  "$class" : "org.accordproject.cicero.dom. Conditional",
                  "element": { ... },
                  "predicate": "enforce value % 10 = 0"
              },
              { ... }
        ]
}

For XML
<choice required="true">
  <choiceOption>
    <conditionalSection predicate="enforce value % 10 = 0">
      ..
    </conditonalSection>
  </choiceOption>
  <choiceOption>
     ....
  </choiceOption>
</choice>

For Jinja2 / Nunjucks style
{# blocks delimit the choices here #}
{% choice %}
  {% if value % 10 = 0 %}
    ...
  {% endif %}
  ...
{% endchoice %}

For Markdown style
We could choose something like the Jijna2 / Nunjucks option above, or otherwise something like Mustache / Handbars.
{{#choice}}
  {{#if value % 10 = 0}}
    ..
  {{/if}}
{{/choice}}

@mttrbrts what is the quality of the output from the Markdown parser, particularly for the inline HTML?

@jeromesimeon what is the quality of the output from the Nunjucks parser? Would we have to roll our own parser?

Default Remark AST from the sample above, https://gist.github.com/mttrbrts/257bc23c22707201075e75e70052a10b
We'd need to add a plug-in to support the variables etc.

In terms of openness of the implementation (ability to parse the DOM on a wide variety of platforms), I think the XML syntax has the edge. Are there other factors people think should be considered, other than:

Openness
Extensibility
Readability
Learning Curve

Amount of existing tooling we can leverage (not just parsers and serializers, but also smaller things like editor plug-ins, etc.)

Some work in progress based on the generated XSD (which a minor tweak to remove the ns prefix for org.accordproject.cicero.dom): https://models.accordproject.org/cicero/dom.html
It's not particularly pretty, but it's powerful and easy to parse in any language. We can make it a bit more palatable by using attributes for some stuff and making more of it optional (encoding for example).
Interested in people's thoughts.
<?xml version="1.0" encoding="UTF-8"?>
<ContractTemplate
	xmlns:org.accordproject.cicero.contract="org.accordproject.cicero.contract"
	xmlns="org.accordproject.cicero.dom"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xsi:schemaLocation="org.accordproject.cicero.dom org.accordproject.cicero.dom.xsd ">
	<id>id</id>
	<metadata>
		<version>1.0</version>
		<locale>en-US</locale>
	</metadata>
	<content xsi:type="Section">
		<id>SECTION_001</id>
		<heading>
			<id>HEAD_001</id>
			<content>Warranties and Disclaimers</content>
			<locale>en-US</locale>
		</heading>
		<children xsi:type="Section">
			<id>CLAUSE_001</id>
			<heading>
				<id>Disclaimer of Warranty</id>
				<content>EXCEPT AS EXPRESSLY PROVIDED IN THIS AGREEMENT, NEITHER PARTY PROVIDES ANY WARRANTIES, WHETHER WRITTEN OR ORAL, EXPRESS OR IMPLIED, REGARDING THE PRODUCTS FOR COMMERCIAL USE, AND EACH PARTY HEREBY DISCLAIMS ALL OTHER WARRANTIES, WHETHER WRITTEN OR ORAL, EXPRESS AND IMPLIED, INCLUDING WITHOUT LIMITATION THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND FREEDOM FROM INFRINGEMENT OF THIRD PARTY RIGHTS.</content>
				<locale>en-US</locale>
			</heading>
			<pageBreak>true</pageBreak>
		</children>
		<children xsi:type="Section">
			<id>CLAUSE_002</id>
			<heading>
				<id>Contract Price.</id>
				<content>In consideration of the Equipment and the Services described in Attachment 2, the Buyer shall pay to the Seller the fixed price of $*** (the Contract Price) in accordance with the Payment Schedule and subject to the terms and conditions as set forth in this Contract. Specific quantities and prices shall be incorporated into each individual PO (the total of all such prices (as multiplied by the relevant quantities) in each PO for a given Project, a Purchase Order Price). The price of each Unit, including a pro-rata share of the Services, special installation tools and shipping fixtures with respect to each Unit and the SCADA system (collectively, the Unit Price), is set forth in Attachment 2 hereto. The currency in which the Contract Price, the Purchase Order Price or any other payments due under this Contract are stated shall be the Contract Currency..</content>
				<locale>en-US</locale>
			</heading>
			<pageBreak>true</pageBreak>
		</children>
		<children xsi:type="Choice">
			<id>OPTIONAL</id>
			<options xsi:type="Section">
				<id>CLAUSE_002</id>
				<heading>
					<id>Optional Section 001</id>
					<content>This is optional section 001.</content>
					<locale>en-US</locale>
				</heading>
				<pageBreak>true</pageBreak>
			</options>
			<options xsi:type="Section">
				<id>CLAUSE_002</id>
				<heading>
					<id>Optional Section 002.</id>
					<content>This is optional section 002.</content>
					<locale>en-US</locale>
				</heading>
				<pageBreak>true</pageBreak>
			</options>
			<required>false</required>
		</children>
		<pageBreak>true</pageBreak>
	</content>
</ContractTemplate>

Quite impressed by the commonmark JS parser. Sample output

Closing, as we have moved to using extended CommonMark for serialisation.


[1.13] Crete Mesos state log and add it to the bunlde

High-level description
Update dcos-diagnostics to latest version including mesos-state feature.
Add a systemd service generating mesos-state.tar wit 90 days of logs.
Add mesos-state.tar to the bundle.
Bacports https://github.com/dcos/dcos/pull/5907
Corresponding DC/OS tickets (required)

DCOS-56379
DCOS-56380
DCOS-56403

Related tickets (optional)

DCOS-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot request-review @drewvanstone @br-lewis @makkes

@mesosphere-mergebot changelog-not-required It's not user facing change, it's only addition for dcos-diagnostics bundle to contain /mesos/state from last 90 days

@jgehrcke Fixed

CC @bbannier


Finding pull requests linked to issues

Hi,
I can't figure out a way to find pull requests linked to an issue without iterating through all the PRs.
I thought I'd work around this by setting specific titles, or additional labels on PRs, but it seems there's no way to search PRs by title, or labels.
What's the best way to do this with ghapi? Do I really have to inspect each PR one by one?
Thanks.

Sorry we can't provide support on using the GitHub API - I suggest you ask on Stackoverflow or similar


Add subscribe_options class, and convert qos and retain_handling to enums which automatically convert

Replaces https://github.com/redboltz/mqtt_cpp/pull/379

Note that almost all of the static asserts that are added by this PR can be removed if a similar treatment is given to the success_code, reason_code, and other values.

Codecov Report

Merging #387 into master will decrease coverage by 12.6%.
The diff coverage is 76.38%.

@@             Coverage Diff             @@
##           master     #387       +/-   ##
===========================================
- Coverage   86.16%   73.56%   -12.61%
===========================================
  Files          38       39        +1
  Lines        6247     6139      -108
===========================================
- Hits         5383     4516      -867
- Misses        864     1623      +759

Note that almost all of the static asserts that are added by this PR can be removed if a similar treatment is given to the success_code, reason_code, and other values

Do you mean static_cast ?

Yes.
I meant static_cast.
Sorry for the confusion.

Thank you!
If you create a PR for reason_code and others to be enum class, I would appreciate.

Thanks for merging this.
It's already helped me catch a bug in my code.
pMqttClient->async_publish(boost::asio::buffer(topic),
                                           {},
                                           topic, // lifetime
                                           false,
                                           redboltz::qos::exactly_once,
                                           { redboltz::v5::property::correlation_data(redboltz::allocate_buffer(requestID)) });

Notice the QOS and Retain parameters are out of order.
Before this change, the bool argument was being implicitly converted to std::uint8_t, and the std::uint8_t was being converted to bool.
Now that you've merged my patch, that call fails to compile, as it should have all along.


keystore: handle mixed case aliases

Aliases in mixed case will be added to the keystore as lowercase.
We do a case sensitive match when checking for alias presence. Make it case insensitive.
Previous Behavior
Given a mixed case alias keystore.manage state complains about alias already being present when it tires to call the keystore.add module.
New Behavior
keystore.manage will not try to re-add a mixed case alias.

woops. Wrong salt repo


Confusion over Early Stopping behavior and how it is intended to work in the future

❓ Questions and Help

What is your question?
So, I intend to use Early Stopping on train_step and training metrics. There were some problems with this (early stopping being called twice in the training loop, not stopping at all when using 'min' mode, not stopping when having no validation, a missing return in the callback class). Those were fixed quickly, but I have some problems with current master still and in #1458 early stopping on training metrics seems to have been disabled, if I understand it correctly. This is also in the 0.8.0-dev documentation. But changing where it is being called is possible.
My question is, will Early Stopping on training metrics be possible going forward? Will calling an Early Stopping subclass in on_train_end catch training metrics and stop training depending on them?
Also, I don't know if I should create another bug report for my current problem with early stopping before #1504 has been merged, which might fix it. I have not changed my code to using a subclass of EarlyStopping, but edited the EarlyStopping class to return self._run_early_stopping_check(trainer, pl_module) in def on_validation_end(self, trainer, pl_module): (which is going to be in #1504  anyway if I understand correctly). Early stopping seems to work now (despite not having a val_step...) but it stops too early again, not before patience has been reached, but clearly before it should.
Code

early_stopping = EarlyStopping(
            monitor='batch/mean_absolute_loss',
            min_delta=hparams.min_delta,
            patience=hparams.patience,
            mode='min'
)

with hparams.patience=150 and hparams.min_delta=0.01, but this happens (epoch/mean_absolute_loss is the mean of all batch/mean_absolute_loss of an epoch, logged in on_epoch_end):

Way too early (provided I understand the expected behavior right), is it not?

yes it will. this is currently being worked on in #1989

Thank you! I like it alot!
About current behavior on master, I seem to be able to stop training early on training metrics despite #1458, so that functionality is still there right now, correct? Any idea why my training stops this early?


terraform/terragrunt packaging: terragrunt would still download all the plugins/providers

Issue description
so i want to install say terraform_0_13.withPlugins and i would also want to add terragrunt to that. i suspect that terragrunt would pickup on my version of terraform: terraform_0_13, not "terraform".
though, actually terragrunt triggers downloading all the providers out there, which is more than frustrating.
Steps to reproduce
{ pkgs, ... }:

{
  environment.systemPackages = with pkgs; [
    terragrunt

    (terraform_0_13.withPlugins (p: [
      p.aws
    ]))
  ];
}

any to omit downloading all the plugins/providers?
any way to pin say terraform version by the means of overriding or something, not to use overlays or own packaging?

another one, in this configuration terragrunt would trigger terraform 0.12.29 instead of 0.13.* version, which is unexpected for sure.

https://github.com/NixOS/nixpkgs/pull/103670 should fix this issue.


Updated emoji set

Will this project be updated with the newest emojis that include bald and red head emojis?

Probably at some point it will, that depends on the emoji-datasource npm package which is an origin of all the emoji data. As I see from the readme it only has v11 emoji at the moment.
And, as I understand, you want new emojis added in v12 (or 12.1).


Publish latest version (2.0.3) to JCenter

Looks like the latest version (2.0.3) is not published to JCenter or Maven Central :(

Looks like in JCenter it is published under "wrong" name: - https://bintray.com/aatarasoff/maven/spring-cloud-marathon-starter/2.0.3
The artifactId is starter instead of spring-cloud-marathon-starter as indicated in the docs.


Link to discussion Page does not work

The link in the readme.md to the discussion Page does not work!

try again

you have to be a member of the team to access that page.


lavamoat broken on nodejs  v20

CI failing on packagelavamoat (aka lavamoat-node) on node 18+: https://github.com/LavaMoat/LavaMoat/actions/runs/4893196868/jobs/8735876501?pr=495

I think this should have been closed a while ago. Is anything missing?

Closed via ef3a0da9960d7f5734e3d4180ebafdae2432a260


Link to "Virtual Entities" is broken

Current link to the Virtual Entities for the Power Platform integration pattern is to https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/data-entities/power-platform/overview.md and returns an 404 error.

@JulijaLudvigaELCA - thanks for the feedback. Can you let us know what page you were on when you found this link so that we can get it updated? Thanks!

@kfend It is here: https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/data-entities/integration-overview
in the "Choose a data integration strategy" section, the first line of the table listing availale integration patterns.

@kfend there is also other broken link on the same page: https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/data-entities/power-platform/overview.md in the sentence: "For detailed information, see Microsoft Power platform integration."

@JulijaLudvigaELCA, thank you for making us aware of these errors!  The links have been fixed.  The updated content will be published later today.


Added Golang-based operator website documentation

Description of the change:
Organize Golang section for documentation website
Closes #2690

@joelanford - I have made the suggested changes. Can you please have a look at it.


Update google-cloud-bigquery to 2.4.0

Updates com.google.cloud:google-cloud-bigquery from 2.3.3 to 2.4.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.3.3).
You might want to review and update them manually.
website/package-lock.json

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-bigquery" } ]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains

Superseded by #146.


[zeppelin] Remove backports for releases older than oldstable

https://github.com/GoogleCloudDataproc/initialization-actions/issues/1157

no tests for this directory