code auto complete not work for some parameter

Operating system or device - Godot version:
Issue description (what happened, and what was expected):
func _on_Area2D_body_enter( body ):
body.
no functions listed after . typed.
Steps to reproduce:
Link to minimal example project (optional but very welcome):

Godot version? Since there were some changes to code completion in the current master branch since 2.0.3 even 2.0.4.

2.0.3  and 2.1

I don't recall completion working for arguments of signal connections. Was this working on a previous version?

Since GdScript is duck typed there's no way the Editor can know what type is body. To solve this you need static typing (or a way to hint the type) i usually add a line body = RigidBody.new() at the start and try not to forget to comment it later...

We'll add type hints for 2.2
On Jul 14, 2016 3:47 PM, "Mariano Javier Suligoy"<EMAIL_ADDRESS>wrote:

Since GdScript is duck typed there's no way the Editor can know what type
is body. To solve this you need static typing (or a way to hint the type) i
usually add a line body = RigidBody.new() at the start and try not to
forget to comment it later...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/5672#issuecomment-232756527,
or mute the thread
https://github.com/notifications/unsubscribe/AF-Z2zxYAsL5oIaU64aQUclootl5MPcmks5qVoRBgaJpZM4JLSqf
.

Also onready var node = get_node("mynode") is a very handy feature,
but get_node have no hint for the node name as write var node = get_node("mynode") in _ready()

As mentioned in https://github.com/godotengine/godot/issues/15718#issuecomment-446207371, this is now solved thanks to optional typing in 3.1.
@vnen Do you think we should go one step further and automatically set the type hint when connecting signals?

@akien-mga that is already the case if you have the option enabled in Editor Settings.

Nice, closing then.

@akien-mga that is already the case if you have the option enabled in Editor Settings.
cool, is this feature enabled by default? it should imho


usage with only eloquent not laravel

I am working on converting an old code base of CI 3 which is currently partially using Eloquent through something called Capsule.
https://github.com/illuminate/database
I am curious if using this package would be possible.  I eventually would like to migrate the entire code base to use Laravel, but for now I am doing things piece by piece.
Adding this package would help alot.  Is it possible to use this with that package only and not the entire laravel stack?

Unfortunately, I don't have idea if this package will work without laravel. Functions and features and mostly dependent on the framework >.<


write_deltalake - Support azure managed identities

Description
Since object_store added support to azure managed identities in the next release see: https://github.com/apache/arrow-rs/pull/3581 and this feature will release in object_store_0.5.4 version, it'll be nice if delta-rs will support Azure managed identities as well.
Use Case
Write delta table using authorized access to blob data with managed identities
write_deltalake(
            f"az://container/delta/test",
            df,
            storage_options={"account_name": account_name},
        )

Hi @rbushri - yes, once we do the next python release, that feature will be included.
I do have one question, In the PR you mentioned, I was able to validate that the workload identities work, but did not have the chance to test the managed identities. I have a python wrapper around the object store crate that I use to validate everything works on the python side. Would it be possible for you to test if that works with managed identities as well?

Could you please confirm whether managed identities now work?

@Jaegin - latest object store is integrated on main, and the functionality has been validated over there.
I was out for a few weeks, so not sure, on what exactly has been released in the meantime, but if it is not already released, it will be included in the next ones.

Thanks, @roeap - appreciate the update and I'll take a look.
In the meantime, any chance you're also involved with the kafka-delta-ingest project? I have the following issue and seeking some help: https://github.com/delta-io/kafka-delta-ingest/issues/151
Many thanks,
Steve

Managed identity should be working because I am using it currently.

Hey @mightyshazam! great to hear - i guess this gives us enough confidence to close this for now 😆


[Bug] docker部署到威联通无法正常代理

Verify steps

[X] I have read the documentation and understand the meaning of all configuration items I have written, avoiding a large number of seemingly useful options or default values.
[ ] I have not reviewed the documentation and resolve this issue.
[ ] I have not searched the Issue Tracker  for the problem I am going to raise.
[X] I have tested with the latest Alpha branch version, and the issue still persists.
[X] I have provided server and client configuration files and processes that can reproduce the issue locally, rather than a desensitized complex client configuration file.
[X] I have provided the simplest configuration that can reproduce the error I reported, rather than relying on remote servers, TUN, graphical client interfaces, or other closed-source software.
[X] I have provided complete configuration files and logs, rather than providing only parts that I believe are useful due to confidence in my own intelligence.

Operating System
No response
System Version
威联通
Mihomo Version
./mihomo -v
Mihomo Meta alpha-0793998 linux amd64 with go1.23.0 Fri Aug 16 06:16:48 UTC 2024
Use tags: with_gvisor
Configuration File
订阅文件使用了 懒人配置：
https://gist.github.com/liuran001/5ca84f7def53c70b554d3f765ff86a33
只是把机场地址换成我自己的

Description
同样的配置在 windows下使用 mihomo-windows-amd64.exe 可以正常代理使用
但是部署到docker后 无法正常代理
使用了 终端命令测试：curl -x http://<IP_ADDRESS>:7890 http://google.com
Reproduction Steps

services:
  meta:
    container_name: meta
    image: docker.io/metacubex/mihomo:Alpha
    restart: always
    pid: host
    ipc: host
    network_mode: host
    cap_add:
      - ALL
    volumes:
      - /share/CACHEDEV1_DATA/Container/clash2/:/root/.config/mihomo/
      - /dev/net/tun:/dev/net/tun

使用以上配置 部署docker 到威联通
Logs
以下是日志

time="2024-08-17T05:09:50.25154239Z" level=info msg="Start initial configuration in progress"

time="2024-08-17T05:09:50.251699988Z" level=error msg="PrepareUIPath error: ExternalUI configure incomplete"

time="2024-08-17T05:09:50.25180345Z" level=info msg="Geodata Loader mode: memconservative"

time="2024-08-17T05:09:50.25188908Z" level=info msg="Geosite Matcher implementation: succinct"

time="2024-08-17T05:09:50.253339592Z" level=info msg="Initial configuration complete, total time: 1ms"

time="2024-08-17T05:09:50.286918085Z" level=info msg="Sniffer is closed"

time="2024-08-17T05:09:50.287277441Z" level=info msg="Mixed(http+socks) proxy listening at: <IP_ADDRESS>:7890"

time="2024-08-17T05:09:50.288977968Z" level=info msg="Start initial Compatible provider default"

time="2024-08-17T05:10:12.695654855Z" level=warning msg="[TCP] dial DIRECT <IP_ADDRESS>:42654 --> google.com:80 error: connect failed: dial tcp <IP_ADDRESS>:80: i/o timeout\nconnect failed: dial tcp [2404:6800:4012:3::200e]:80: connect: network is unreachable"

我的配置问题 已解决


Add back shorthand for --verbose and --quiet

This shorthand flag appears to have been dropped in #2962, the removal of which broke some scripts.

It appears that the short flag for verbose was also dropped. Perhaps check for others before merging this PR.

Codecov Report
Base: 86.40% // Head: 86.45% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (52aa8b9) compared to base (17a70d5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3022      +/-   ##
==========================================
+ Coverage   86.40%   86.45%   +0.04%
==========================================
  Files          89       89
  Lines       34099    34099
==========================================
+ Hits        29464    29481      +17
+ Misses       4635     4618      -17

Impacted Files
Coverage Δ

src/bin/common.rs
54.37% <ø> (ø)

src/tiling/tile_state.rs
88.40% <0.00%> (-0.73%)
:arrow_down:

src/context/partition_unit.rs
89.44% <0.00%> (-0.28%)
:arrow_down:

v_frame/src/plane.rs
88.90% <0.00%> (+0.11%)
:arrow_up:

src/rdo.rs
85.72% <0.00%> (+0.50%)
:arrow_up:

src/asm/x86/lrf.rs
94.11% <0.00%> (+1.26%)
:arrow_up:

src/cpu_features/x86.rs
41.66% <0.00%> (+2.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

It appears that the short flag for verbose was also dropped. Perhaps check for others before merging this PR.

Nice catch, I looked at the code before #2962  and didn't find any other dropped short flags.


Do archival sync in parallel with normal operation

Downloading all blocks and their state back to genesis can take a long time. It should be possible to start a node and make it follow the network, while it downloads historical data in the background.

This duplicates  #2083

As I stated previously.
One suggestion put forward by @goral09 is to launch a task in the participating reactor.
One way of doing this is to extract the following from the run_fast_sync_task, delete it there and launch it as an effect in the participating reactor:
    // Sync to genesis
    let mut walkback_block = *fetch_and_store_block_by_hash(effect_builder, trusted_block_header.hash()).await?;;
    loop {
        sync_deploys_and_transfers_and_state(effect_builder, &walkback_block).await?;
        if walkback_block.height() == 0 {
            break;
        } else {
            walkback_block = *fetch_and_store_block_by_hash(
                effect_builder,
                *walkback_block.header().parent_hash(),
            )
            .await?;
        }
    }


Update to maven-protoc-plugin

New version includes fix for breaking changes to maven-toolchains-plugin introduced in maven 3.2.5.

@snazy Please review.

/cc @guenter @ritazh @VenkateshSub

Just a (minor) prerequisite thing - otherwise LGTM


Content-Type: text/xml not escaped

curl -X POST --location "https://web.hook.sh/$guid-here$" \
    -H "Content-Type: text/xml" \
    -d "<hello>world</hello>"

Shown as "world" (without tags)

Bug confirmed, tomorrow will be fixed. Thanks for your report!

💥 Released in v0.3.1, thank you!


remove docs patch versions (test run)

Compile Times benchmark
Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:
using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

using
create
display
create
display

GLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–

CairoMakie
15.07s (14.84, 15.41) 0.18+-
23.69s (23.44, 23.87) 0.17+-
2.96s (2.94, 3.01) 0.03+-
18.83ms (18.40, 20.32) 0.67+-
29.24ms (29.06, 29.44) 0.13+-

master
15.02s (14.96, 15.10) 0.05+-
23.66s (23.18, 23.87) 0.24+-
2.96s (2.90, 2.99) 0.03+-
18.47ms (18.24, 18.68) 0.18+-
29.22ms (29.03, 29.39) 0.16+-

evaluation
+0.33%, 0.05s invariant (0.39d, 0.49p, 0.11std)
+0.10%, 0.02s invariant (0.11d, 0.84p, 0.21std)
+0.22%, 0.01s invariant (0.23d, 0.67p, 0.03std)
+1.92%, 0.36ms invariant (0.73d, 0.21p, 0.43std)
+0.05%, 0.02ms invariant (0.11d, 0.84p, 0.14std)

WGLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–


failing as we should, instead of printing out an error

I'm not sure why the following print statements were put in - merely printing out an error and proceeding like nothing happened doesn't accomplish anything IMO, and only hides the otherwise invaluable stack trace. It's better to fail explicitly with an ImportError.
I noticed then when a bad installation of torch in my environment was preventing an internal import deep inside pytorch (triggered in our code on from torch.nn import Module), but this was hard to track down because of this print.
If the intention here was to allow osqp code execution even in the absence of the torch module, that's understandable, but again, no other code in osqp seems to be inadvertently picking up this module where it shouldn't except a unit test, and doing an from osqp.nn.torch import .. should trigger an ImportError.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Vineet Bansal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


run install_prereqs only once on a host

related PR: https://github.com/dcos/dcos/pull/477

Seems reasonable to me as an MVP fix

@cmaloney fixed, using /opt/dcos-prereqs.installed flag

:ship:


build a UMD bundle instead of IIFE

remove old ESlint rule to disallow Object.assign
consume Rollup config's output prop in karma-rollup-plugin
simplify rollup.config.js output prop
fix invalid script tag src attrib in lib/browser/template.html (& reformat)

@Munter I found that when using umd output while window.mocha.setup did not exist, window.mocha.mocha.setup did exist.
using object spread syntax module.exports = {...global, ...mocha} causes Rollup (?) to generate a ES module then complains about having default and named exports.  I have no idea why.
I think even the global.mocha = mocha and global.Mocha = Mocha lines are probably unnecessary, since the UMD bundle will stuff module.exports into global.

update: the global.mocha and global.Mocha stuff is necessary.  I guess I really don't get it.  but whatever.

Coverage remained the same at 93.932% when pulling d429190218e2bc10580d22e7638a9d666d940151 on boneskull/rollup-umd into 1392bc937c751e5d23ee26757f3dce4c742398c0 on master.

looks like I jumped the gun a little there.  it worked for a test file anyway (as created by mocha init)

alright, tweaked the exports. it's now
mocha.Mocha = Mocha;
mocha.mocha = mocha;
module.exports = Object.assign(mocha, global);

AMD bundle seems to "work" per manual test, but the failing test isn't of much value.

added a proper test for AMD; closes #2426

@munter something is not pulling in the target browser list here

wow, it works!

@boneskull I can't review this PR explained by my complete incompetence in this matter, sorry.
This rollup thing is a wild fusion of bundling, transpiling and karma/testing without clear distinction. I don't understand neither why we need an additional module definition UMD. What definition have we used before with browserify?

our browserify bundle is not quite UMD, but it 1. defines globals and 2. enables bundling of the bundle.  it does not supply a AMD-compatible bundle, but it also does not inhibit AMD bundles.
The rationale for this PR, then, is:

the iife output of Rollup does not seem to allow number 2, which is going to break consumers; we need the umd output style
after #4293 landed, we're able to use some modern syntax everywhere, but not all modern syntax everywhere.  the changes to our babel config in this PR make it possible to use, e.g., async/await anywhere in our sources and tests (because Node.js v10, our minimum-supported version of Node.js, allows this).  We could not use the native Promise object, either--but now we can, because of the polyfilling core-js does.
the umd output style of Rollup does provide an AMD bundle, which made the previous test case (test.bundle) fail.  I had to write some new tests to assert compatibility (and learn some RequireJS...ugh)

with this PR--for whatever reason--the resulting bundle size is about 20Kb less.

that said, this has been sitting for like 3 weeks, and I need to move forward with it to get global fixtures in.


HV-1216

https://hibernate.atlassian.net/browse/HV-1216
Supersedes #647.

Fixed a few minor issues and merged to master. Will also backport to 5.4.


Sizes best practices

Hello,
I was wondering if anyone has any advice when it comes to the best practices for theming sizes? Should I do: full/half? Or something similar to space theme like [0,2,4,8,...etc]?
Appreciate all the responses.
Thanks a lot!

great. Thanks for the help :D


Term 'Map' could be defined / explained better

the picture show the first occurrence of the term 'map' in https://github.com/WebOfTrust/ietf-cesr-proof/blob/main/draft-pfeairheller-cesr-proof.md#transposable-signature-attachments

Is a map the same as an envelop?
The term 'Map' could be defined / explained better

Ack

Closed with PR #19


rez-pip creates .pyc files by default

This is an issue if the installed package is a "pure" package (no binary components) because the pyc files might not work with other interpreters.
My proposal would be to add --no-compile to pip.py and not generate pyc files at all when using rez-pip.

As discussed on slack, we should add an option called pip_extra_args (or something like that) configurable in the rezconfig so everybody can add settings that fits their needs.
For example, a studio could add a --index-url for example.
It will give us flexibility and will remove us some maintenance (maintaining the cli for pip arguments).

Sounds good. I would pair this with an extra args passthrough option to
rez-pip cli also, which would override the configured pip_extra_args if
present.
On Fri, Dec 6, 2019 at 1:34 PM Jean-Christophe Morin <
<EMAIL_ADDRESS>wrote:

As discussed on slack, we should add an option called pip_extra_args (or
something like that) configurable in the rezconfig so everybody can add
settings that fits their needs.
For example, a studio could add a --index-url for example.
It will give us flexibility and will remove us some maintenance
(maintaining the cli for pip arguments).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/issues/816?email_source=notifications&email_token=AAMOUSV4GEVUKSVZL4VES5TQXG24RA5CNFSM4JVIYLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGC2LMA#issuecomment-562406832,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMOUST2ZL6EBSANLR7T57DQXG24RANCNFSM4JVIYLSA
.

-- target and --user are probably the two interesting ones where imho rez would always win, or is that needed and wanted that pip then reroutes the destination?

Hello everyone, I am working on implementing this as discussed above and based on the discussions you had in slack. The most elegant solution would of course be using the PYTHONWRITEBYTECODE environment variable but since it does not seem to be an option right now I have added the extra functionality to rez-pip cli and rezconfig. I will be submitting a PR soon :+1:

This is solved by switching to python 3, correct? Python 3 writes .pyc files to a __pycache__ folder with the python version number, so that multiple versions of python will each have their own .pyc files.
This would only be an issue for people using different versions of python 2 (and I can't imagine anyone is using anything other than 2.7).

I assume python3 fixes incompatible pyc files and possibly also the network load issue. However the case we are seeing is having two incompatible 2.7 interpreters (namely the official binary and the embedded one in 3dsmax).
Beyond that the extra-args make sense for other stuff like index-url as mentioned above (getting around with an env var, but would prefer to be more explicit).


segfault

The code segfaults when running, as follows:
rick@beast:/z/ParallelFlowDirections$ ./ParallelFlowDir
[beast:344949] *** Process received signal ***
[beast:344949] Signal: Segmentation fault (11)
[beast:344949] Signal code: Address not mapped (1)
[beast:344949] Failing at address: (nil)
[beast:344949] [ 0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x153c0)[0x7f1e551313c0]
[beast:344949] [ 1] /lib/x86_64-linux-gnu/libc.so.6(+0x186b7e)[0x7f1e550b0b7e]
[beast:344949] [ 2] ./ParallelFlowDir(+0x14b25)[0x55908cc88b25]
[beast:344949] [ 3] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3)[0x7f1e54f510b3]
[beast:344949] [ 4] ./ParallelFlowDir(+0x1618e)[0x55908cc8a18e]
[beast:344949] *** End of error message ***
Segmentation fault (core dumped)
rick@beast:/z/ParallelFlowDirections$ mpirun -n 4 ./ParallelFlowDir
[beast:344985] *** Process received signal ***
[beast:344985] Signal: Segmentation fault (11)
[beast:344985] Signal code: Address not mapped (1)
[beast:344985] Failing at address: (nil)
[beast:344985] [ 0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x153c0)[0x7f6b4220a3c0]
[beast:344985] [ 1] /lib/x86_64-linux-gnu/libc.so.6(+0x186b7e)[0x7f6b42189b7e]
[beast:344985] [ 2] ./ParallelFlowDir(+0x14b25)[0x55b7f3c71b25]
[beast:344985] [ 3] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3)[0x7f6b4202a0b3]
[beast:344985] [ 4] ./ParallelFlowDir(+0x1618e)[0x55b7f3c7318e]
[beast:344985] *** End of error message ***
--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun noticed that process rank 0 with PID 0 on node beast exited on signal 11 (Segmentation fault).
--------------------------------------------------------------------------

This is because you don't perform any kind of input sanitization or CLI argument validity checking.
I've personally found CLI11 to be useful for this (example). If you decide to use it, you could include it as a submodule (see here). Otherwise, you should check the number of arguments and ensure they're what you expect potentially like this, but I think CLI11 is really the better option.
In any case, the program shouldn't segfault.

Thanks. Done!

Unfortunately, the problem isn't fixed for me yet.
These lines:
    if ( argc < 4 ) {
        std::cout << "Too few arguments." << std::endl;
        return -1;
    }

don't provide helpful feedback if the user enters no arguments.
And eliminating those lines means a segfault here
if ( strcmp( method, "parallel" ) == 0 ) {

if the user enters no arguments.
I think the code would be significantly simplified if you made a test.cpp which runs the test suite and limited main.cpp to only taking input datasets. That eliminates the if ( strcmp( method, "parallel" ) == 0 ) { if-clause which means you can pass all argument checking off to the CLI11 library.

Unfortunately, the problem isn't fixed for me yet.
These lines:
    if ( argc < 4 ) {
        std::cout << "Too few arguments." << std::endl;
        return -1;
    }

don't provide helpful feedback if the user enters no arguments.
And eliminating those lines means a segfault here
if ( strcmp( method, "parallel" ) == 0 ) {

if the user enters no arguments.
I think the code would be significantly simplified if you made a test.cpp which runs the test suite and limited main.cpp to only taking input datasets. That eliminates the if ( strcmp( method, "parallel" ) == 0 ) { if-clause which means you can pass all argument checking off to the CLI11 library.

Done! I have provide helpful feedback in the program.  If the user enters no arguments., the argc is less than 4, and the program will exit. I think those lines do not mean a segfault here if ( strcmp( method, "parallel" ) == 0 ). The input parameters of the two modes are different, I think it is necessary to know which mode  it is. Therefore, i kept this line of code if ( strcmp( method, "parallel" ) == 0 )

Done! I have provide helpful feedback in the program.  If the user enters no arguments., the argc is less than 4, and the program will exit. I think those lines do not mean a segfault here if ( strcmp( method, "parallel" ) == 0 ). The input parameters of the two modes are different, I think it is necessary to know which mode  it is. Therefore, i kept this line of code if ( strcmp( method, "parallel" ) == 0 )


ES6 bug

Hi there.
Current implementation won't work if we target ES6, because ES6 class constructor couldn't be called without instantiating class.
// call constructor
this.fn.apply(instance, args);

so this code will fail.

Thank you @levan-g for pointing out this, we'll look into it. PR are always welcomed to speed things up!


Disassociate the steve worker creator from the steve store

Summary
Fixes - Alt fix for https://github.com/rancher/dashboard/pull/8064
Occurred changes and/or fixed issues

yarn build-pkg harvester fails due to import of web workers
import fails due to the build process missing web worker build config
Fix is to disassociate the import chain for the web worker creator

Assign the steve worker creator to the store via plugin
On the downside this means rancher/steve specific stuff is applied at a more global level

Areas or cases that should be tested

Web socket updates work correctly when advanced worker setting is enabled and not enabled
When enabled the cluster socket should be 'advanced'

@Sean-McQ Neil has OK'd the design, can you kick the tires?


Support for Projections while querying.

I love the plugin. Thanks for it.
I was wondering if projections support can be added, allowing users to control what fields to return.

Hi,
New query panel available here
Please tell me if it is ok for you.
David

@dboissier Thanks. I have moved to Idea 14. Does this work on 14?

Not yet. I am on it and it should be available by the end of today

Hi,
I uploaded a snapshot version tested on Webstorm 9. It should work on Idea 14 too.
Please tell me if it works on your IDE.
David

@dboissier I tried it on idea 14.0.3 and it works perfect !! Thanks a lot :)

Great.
When you have time, please, provide me some UX feedback on the query panel.
cheers

Release 0.7.0 available on Jetbrains plugin repository


bleno and noble

Why are bleno and noble packages kept in lib dir? Are they modified somehow?
If not then I want to suggest adding them package.json as dependencies.

Yes, they are modified.
Noble:
We need raw hex values of BLE advertisements: EIR broadcasted from device, and the EIR "scan response".  Noble gives us only parsed versions, and in many cases it is not enough to "clone" original device 1:1. My PR to noble:
https://github.com/sandeepmistry/noble/pull/426
Similar discussion:
https://github.com/sandeepmistry/noble/issues/436
I would be happy to depend on unmodified noble. I was planning to give a try a trick by Damien Cauquil in btlejuice:
https://github.com/DigitalSecurity/btlejuice/blob/a0be08e0a05f6946b8c18a5ffa124ff975e0662c/proxy.js#L185-#L191
https://github.com/DigitalSecurity/btlejuice/blob/a0be08e0a05f6946b8c18a5ffa124ff975e0662c/proxy.js#L213-#L227
I haven't been able to test it yet.
Secondly, I recently added long write support for noble:
https://github.com/sandeepmistry/noble/pull/452
This feature is not yet pushed here in GATTacker's lib/noble. But if the PR to noble won't be accepted, this would be another reason to keep fork.
Bleno:
Because of mobile OS GATT cache we need to specify exact handle numbers. And also we don't need default bleno services.
Discussion (with detailed description):
https://github.com/sandeepmistry/bleno/issues/224


support for pre

p-s version:3.1.0
node version:6
npm version:4

Scripts file (or at least the relevant bits):

The command executed:

The output:

Problem description:
currently there's no support for 'pre' scripts in nps.  it would be nice if p-s suppported this for when we import scripts from npm.
Suggested solution:

Hi @benmonro,
Thanks for the issue. But we've discussed this and decided to not do it. You can follow the discussion in #67 and in the PR #83.


Scans 4 files then stalls

🐛 Bug Report

[ X] 📁 I've Included a ZIP file containing my librephotos log files
[ X] ❌ I have looked for similar issues (including closed ones)
[ X] 🎬 (If applicable) I've provided pictures or links to videos that clearly demonstrate the issue

📝 Description of issue:
I have all my photos in the /var/lib/librephotos/photos directory. When I run a scan it's scans 4 pictures then stalls. Takes a docker restart and it will scan another 4 photos and stalls. I've seen the few other issues related to this but their issues seem to be connected to using some kind of network share. I've tried several fresh docker pulls and installs with no success.
🔁 How can we reproduce it:
I dont know
Please provide additional information:

💻 Operating system: Unraid Docker
⚙ Architecture (x86 or ARM): x86
🔢 Librephotos version:
📸 Librephotos installation method (Docker, Kubernetes, .deb, etc.): Docker

🐋 If Docker or Kubernets, provide docker-compose image tag:

📁 How is you picture library mounted (Local file system (Type), NFS, SMB, etc.): local
☁ If you are virtualizing librephotos, Virtualization platform (Proxmox, Xen, HyperV, etc.): Unraid
New folder.zip

Anyone?

There's bug reports open on here from 2 months ago with no comment or help at all that are probably just easy support questions. Owner was real quick to tell me I submitted my bug wrong but not to help anyone.

Not sure why you are thinking, that I can help you, if you a) didn't have an error, b) didn't explain how this bug works. Again, I don't have an unraid system, that I can test. This is an open source project, so feel free to open a pull request, where you fix the bug.
I will close this issue, because I am annoyed by your spamming.

I have this same issue. It scans just 4 photos and then stalls. I'm guessing it has to do with the configuration with using the Community Apps template vs using the docker compose


Spring Integration doesn't work with logs not from classpath when using includes

Environment
Liquibase Version: 4.18.0
Liquibase Integration & Version: Spring Boot 2.7.7
Description
This is a follow-up of #1540. Initially resolving the changelog outside classpath did not work. This was resolved with #1540. When using includes the problem still exists.
The problem is the code resolving files defined with an include. But the problem also exisits for different kind of locations than classpath. The probelmatic code is in liquibase.changelog.DatabaseChangeLog#include(java.lang.String, boolean, liquibase.resource.ResourceAccessor, liquibase.ContextExpression, liquibase.Labels, java.lang.Boolean, liquibase.changelog.DatabaseChangeLog.OnUnknownFileFormat, liquibase.changelog.DatabaseChangeLog.ModifyChangeSets)
`
public boolean include(String fileName,
boolean isRelativePath,
ResourceAccessor resourceAccessor,
ContextExpression includeContextFilter,
Labels labels,
Boolean ignore,
OnUnknownFileFormat onUnknownFileFormat,
ModifyChangeSets modifyChangeSets)
throws LiquibaseException {
if (".svn".equalsIgnoreCase(fileName) || "cvs".equalsIgnoreCase(fileName)) {
return false;
}
    if (isRelativePath) {
        try {
            fileName = resourceAccessor.get(this.getPhysicalFilePath()).resolveSibling(fileName).getPath();
            fileName = Paths.get(fileName).normalize().toString()
                    .replace("\\", "/");
        } catch (IOException e) {
            throw new UnexpectedLiquibaseException(e);
        }
    }

...
`
When the filename is based on a file url the call to Path.normalize() will fail. I would suggest to not normalize when a protocol like file is used in the filename.
Steps To Reproduce

Simple Spring Boot application using a changelog with include specified with file protocol rather than classpath.
Sample project https://github.com/reallyinsane/liquibase-3692

Actual Behavior
Changelog defined as included cannot be loaded.
Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 4: file:D:/.../src/main/liquibase/changelog-1.0.xml 	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) ~[na:na] 	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) ~[na:na] 	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) ~[na:na] 	at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) ~[na:na] 	at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) ~[na:na] 	at java.base/java.nio.file.Path.of(Path.java:147) ~[na:na] 	at java.base/java.nio.file.Paths.get(Paths.java:69) ~[na:na] 	at liquibase.changelog.DatabaseChangeLog.include(DatabaseChangeLog.java:759) ~[liquibase-core-4.18.0.jar:na] 	at liquibase.changelog.DatabaseChangeLog.handleChildNode(DatabaseChangeLog.java:438) ~[liquibase-core-4.18.0.jar:na] 	at liquibase.changelog.DatabaseChangeLog.load(DatabaseChangeLog.java:376) ~[liquibase-core-4.18.0.jar:na] 	at liquibase.parser.core.xml.AbstractChangeLogParser.parse(AbstractChangeLogParser.java:23) ~[liquibase-core-4.18.0.jar:na]
A clear and concise description of what happens in the software with the version used.

The correctly resolved file to included should be loaded with file protocol.
Before parsing file name is normalizes using Path.normalize() which does not work for url based names.

Expected/Desired Behavior
Normalize is not called when a protocol like file protocol is used. When normalize call is skipped, everything works as expected.

Hello! To solve this you need to pass the searchPath param to liquibase with the path to the changelog and the pass the changelog file on the changelog param. We checked if there were any feature that allows that on springboot but couldnt find any, maybe to solve this you need to submit pr to springboot. I think the code is over here

I disagree. If you don't want to support other protocols than classpath then fine. Then this should be documented as I don't want to change the Spring Liquibase Autoconfiguration just because a different protocol. But the code I pointed at just requires to be a file path always. I also don't understand how specifying the searchPath will help with the code mentioned.

I have the same issue with
Liquibase Version: 4.18.0
Spring Boot: 2.7.10
I specify "spring.liquibase.change-log=file:build/database/liquibase/migration/dbchangelog.xml" as TestPropertySource for my SpringBootTest.
If I run the maven build under Linux with openjdk version "17.0.5" 2022-10-18 everything is fine.
Running it under Windows (STS 4.17.s or via maven within eclipse) with OpenJDK 17.0.2 I get:
Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 4: file:build/database/liquibase/migration/changes/feature-01-example-table/changesets.xml 	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) 	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) 	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) 	at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) 	at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:232) 	at java.base/java.nio.file.Path.of(Path.java:147) 	at java.base/java.nio.file.Paths.get(Paths.java:69) 	at liquibase.changelog.DatabaseChangeLog.include(DatabaseChangeLog.java:812) 	at liquibase.changelog.DatabaseChangeLog.handleChildNode(DatabaseChangeLog.java:452) 	at liquibase.changelog.DatabaseChangeLog.load(DatabaseChangeLog.java:388) 	at liquibase.parser.core.xml.AbstractChangeLogParser.parse(AbstractChangeLogParser.java:23) 	... 110 common frames omitted
Maybe it has something todo with the special meaning of ':' under windows?

Hello! You are right that we should improve our documentation, but thats the way liquibase is design, the reason we dont support that kind of behavior is that Liquibase use the path to the changelog as part of the identifier of a changeset, you can read that over here . Using searchPath tells liquibase were to look for, if try to have a path like @tschniewind have, Im asuming its for dev env, if you stage those changes the path would change and the changeset will have a different identifier. We also should fix the


BROKEN APP/NO SUPRISE

Issues:
The entire app is an issue! The app worked fine until the last day or so.
Now it crashes every time I click the play button.
It crashes when importing scripts. It crashes or gives me errors when importing custom textures.
Alot of the hooks and functions are broken.
And it's laggy at times (not that big of an issue though)
So good luck with this app. Maybe one day it will actually work. Till then I'll be using master launcher.

How did it crash? Did you import any new mods, addons, or scripts before it crashed? Which version of MCPE and BlockLauncher are you using?


Hi, everyone. I'd like to ask when the ray tracing renderers can add light sources and spotlights

I'm using ray tracing renderers, but I don't support point light and spot light. I try to add point light according to parallel light. Unfortunately, I can't understand the case of parallel light. Can you give me some advice

Hi @xiaxc1 , what do you mean by " the case of parallel light"? could you re-phrase the question?

Code for parallel light

您好，我还想问一下我每次渲染的时候需要很长的准备时间，有什么办法能解决这个时间很长的问题吗？还有一个就是我能加渲染的进度条吗，渲染完成能否停止渲染，感谢

@xiaxc1 the PBRT book is a great resource with theory and sample (CPU) code: http://www.pbr-book.org/3ed-2018/Light_Sources/Point_Lights.html . The newer version will include a GPU implementation but I don't think that's public yet.
In terms of adding support for other types of light, I recommend looking into the decomposeScene method here: https://github.com/hoverinc/ray-tracing-renderer/blob/4e0c1d024908f1a38339f7006384251e81392621/src/renderer/decomposeScene.js#L3

OK, thank you. Thank you for your answer. I'll take a look at this case

@elfrank  Will there be support for area lights anywhere in the future  ?


Explicit/required options

I don't want LogPolicy and RetryPolicy to have default options in constructor. I want clients to explicitly pass them. If they want the default behavior, they should create empty options themselves. But if they simply don't provide them, they are likely writing bad code, becuse they will not be respecting client options / something that they will get for free, if only they passed that option to constuctor.
Yes, unlike TokenRequestContext (formarly TokenRequestOptions), the default values in RetryOptions and LogOptions do have better degree of sense, but still I want the parameter to be explicit., so please give me guidance if I should rename types, or update the guidance to have exceptions. Out of all outcomes, I don't want to get worse code for the sake of code uniformity. I want options to always be the parameter; plus, after all, what is the sense of having default value you know you should not be using?
(Split from #1795)

I don't want LogPolicy and RetryPolicy to have default options in constructor. I want clients to explicitly pass them.

Why?
The default behavior of RetryPolicy makes sense to me. We shouldn't force users to pass something when we can provide a simpler starting point. This follows progressive disclosure. This also matches other languages.
https://github.com/Azure/azure-sdk-for-cpp/blob/fc79c5b3ad69fd2c75eae0cd8f9b3a951fff4a11/sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp#L186-L201
https://github.com/Azure/azure-sdk-for-net/blob/79223575e7693c46165d50f7232fafa77449aee7/sdk/core/Azure.Core/src/RetryOptions.cs#L12

I don't want LogPolicy and RetryPolicy to have default options in constructor. I want clients to explicitly pass them.

That would be a very bad user experience, especially for beginners, it makes our sdk less easy to use.

@ahsonkhan, @Jinming-Hu, this is not about the Options themselves being default-constructible. I agree - they should be default-constructible, and the ClientOptions should have default values for them without requiring the SDK user to specify them - I can't agree more.
But I don't want std::make_unique<RetryPolicy>() to compile. I want it to be std::make_unique<RetryPolicy>(clientOptions.Retry), or, for the deliberately default options, std::make_unique<RetryPolicy>(RetryOptions()).

But I don't want std::make_unique() to compile. I want it to be std::make_unique(clientOptions.Retry), or, for the deliberately default options, std::make_unique(RetryOptions()).

What's the point? Customers won't use RetryPolicy anyway.

You can remove default constructor of RetryPolicy. It's fine by me

I agree with both. But this question is about guidelines. Formally, our guidelines are so that all options rather must be optional, always. I might be violating that by having RetryPolicy::RetryPolicy(RetryOptions retryOptions) instead of RetryPolicy::RetryPolicy(RetryOptions retryOptions = RetryOptions()), and this what this issue is created for.

Formally, our guidelines are so that all options rather must be optional, always.

This doesn't make any sense. I think your proposal here makes a lot of sense that RetryPolicy should NOT be default-constructible. I always have the feeling that you guys have been trying to make guidelines cover everything. But the real world is complex, we often need human intervention or to make judgement calls, rather than just to follow some rigid guidelines.
So if you want to fix the guideline, or remove this item from guideline, I support you.


ccache: error: failed to rename x to y : The process cannot access the file because it is being used by another process.

I'm trying desperately to run nuitka on a short python program but it keeps failing:
>nuitka --mingw64 --follow-imports --plugin-enable=pkg-resources --plugin-enable=pylint-warnings script.py
[...]
ccache: error: failed to rename C:\Users\user\AppData\Local\Nuitka\Nuitka\Cache\ccache/tmp/tmp.cpp_stdout.P1kAlM to
C:\Users\user\AppData\Local\Nuitka\Nuitka\Cache\ccache/tmp/tmp.cpp_stdout.P1kAlM.i: The process cannot access the file
because it is being used by another process.

It's windows defender. Now figuring out how to disable it - I've had no luck.

Using Windows defender on Nuitka compilation results is a sure way of killing performance entirely.

That is a very likely explanation!


os: TestMkdirStickyUmask failed in github code space

What version of Go are you using (go version)?

$ go version
tip

Does this issue reproduce with the latest release?
yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/codespace/.cache/go-build"
GOENV="/home/codespace/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.5"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/workspaces/go/src/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build17331257=/tmp/go-build -gno-record-gcc-switches"

What did you do?

cd src
./all.bash
What did you expect to see?
Test passed.
What did you see instead?
--- FAIL: TestMkdirStickyUmask (0.00s)
os_unix_test.go:271: unexpected mode dtrwxr-xr--
FAIL    os      0.691s

I suspect that this is an ACL problem.
Per https://man7.org/linux/man-pages/man2/umask.2.html:

if the parent directory has a default ACL (see acl(5)), the umask is ignored, the default ACL is inherited, the permission bits are set based on the inherited ACL, and permission bits absent in the mode argument are turned off.

The test has been fixed.


Fix missing closing bracket in jsx with Pexp_apply unit

Addresses https://github.com/facebook/reason/issues/2297

This is already fixed in master.


Add Digest Export and Manifest Creation for Multi-Arch Docker Builds

This pull request enhances the Docker image build workflow to support exporting image digests and creating a manifest list for multi-architecture Docker builds. The changes include:

Digest Export: The build job now exports digests for each platform and uploads them as artifacts.
Manifest Creation: The merge job downloads all digests and creates a manifest list with these digests for each platform.
Simulated Image Inspection: Added steps to simulate image inspection and creation of a manifest list.

The login and logout steps for DockerHub are currently commented out. Uncomment these steps if DockerHub authentication is required. The workflow now supports linux/amd64, linux/arm64, linux/arm/v6, and linux/arm/v7 platforms.

@viferga

I assume this can be closed in favor of https://github.com/metacall/core/pull/535, right?

I assume this can be closed in favor of https://github.com/metacall/core/pull/535, right?

Yes we can close this PR


About Page

Todo:

[x] turn html to markdown http://domchristie.github.io/to-markdown/
[ ] update history section, timeline
[x] add sidebar navigation section to quickly jump between anchors
[x] add core team
[ ] link to hack team

some ideas from this presentation:
https://docs.google.com/presentation/d/1Kx3HFwkA2evt74OP1dCaGnF5BxhKcMQRiyzjRidB3Ik/edit#slide=id.gd4d126627_0_400

closing this issue since the page is live. if there are specific content or design suggestions, lets open new issues


add magnet control to triton driver

Control of the magnet is added.
@MerlinSmiles @jenshnielsen @WilliamHPNielsen The merge of the driver was not easy, and I cannot test all features here. Can you have a good look at the PR diff?
@gzheng @mnoordam

@jenshnielsen I addressed some of your comments. I did not write the changes myself, so I cannot comment any further.
@gzheng

@jenshnielsen Should I do something with the codecov report?

@eendebakpt There are no tests for the driver hence the coverage stays the same as it is. No need to do anything

@jenshnielsen Is this one good to merge?

Yes it looks fine now


Assigning 1 to multiple binary features in the same field

Consider a case where several of the binary features in a field can be true. For example, one might want to encode the history of recent advertisers that were shown to a user.
In regards to this, the paper says:

Note that according to the number of possible values in a
categorical feature, the same number of binary features are
generated and every time only one of them has the value 1.

I'm using this python wrapper, and it trains on such a feature configuration. For example, the following (field, feature, value) sample will run:
[(1, 2, 1), (2, 3, 1), (3, 5, 1), (3, 6, 1), (3, 7, 1)]. But this seems to go against the statement from the paper.
So is this code just working by coincidence, or is it the FFM actually capable of learning from this sort of "history" encoding?

For FMs, I know it was not a problem. But for FFMs, I don't know.
It is cumbersome that most of the FM data formats force a one-to-one relationship.

same question, any answer?

So, can't we use tags as features? Tags would be one field, but, several of them can be true for one instance. Any thoughts on how to use tags with FFM?


Makefile: allow installation of debug binaries

Distro packaging needs unstripped binaries to create its debuginfo
packages.
Signed-off-by: Lokesh Mandvekar<EMAIL_ADDRESS>Similar to https://github.com/containers/netavark/pull/198 so let's do the netavark PR first.

Waiting for this: https://github.com/containers/netavark/pull/198#issuecomment-1024539219

https://github.com/containers/netavark/pull/198#issuecomment-1025796729


Create 2130-maximum-twin-sum-of-a-linked-list

Submission Link for reference: https://leetcode.com/problems/maximum-twin-sum-of-a-linked-list/submissions/948484943/

File(s) Modified: 2130-maximum-twin-sum-of-a-linked-list
Language(s) Used: Java
Submission URL: https://leetcode.com/problems/maximum-twin-sum-of-a-linked-list/submissions/948484943/

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

Thanks!


fix(io): Fix order of level data.

#120  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donmccurdy and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.47%. Comparing base (1344d3a) to head (0bf2ac5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   97.45%   97.47%   +0.02%
==========================================
  Files           7        7
  Lines         981      989       +8
  Branches       48       49       +1
==========================================
+ Hits          956      964       +8
  Misses         25       25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Zenith RA/Dec

Add a parameter to contain the Zenith RA & Dec of the observation. Not clear if this should be a vector of length Ntimes or a single value with a reference time.

Do at the same time as adding LSTs.

Done.


🐛 [BUG]: Keydown inside node affects selection box

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
Selection Box is present after pressing shift inside input within node
Expected Behavior
Selection box is NOT present after pressing shift inside input within node
Steps To Reproduce

Focus on input inside node
Press Shift
Click on background of vueflow
Selection box is present

REPRO: https://codesandbox.io/s/vue-flow-selection-capture-uw5bto?file=/src/nodes/CustomNode.vue:321-334
Relevant log output
No response
Anything else?
No response

I'm not sure how this is supposed to be a bug? What other behavior should happen here?
You press Shift -> Selection key code is triggered, i.e. a box can be drawn.
If you don't want it triggered you gotta change the selection key code to something else that isn't necessarily used inside an input or just disable it (using key code null) while you're focusing an input.

I'm not sure how this is supposed to be a bug? What other behavior should happen here?
You press Shift -> Selection key code is triggered, i.e. a box can be drawn.

My suggestion is to prevent event from bubbling from node to VueFlow component
Press Shift on VueFlow and VueFlow only -> selection key code is triggered Press Shift on input inside node -> selection key code is not triggered
Is that possible?

Selection key listeners are global (i.e. listening to the window events), so no, that would not be possible and it's not a bug either, that is a design choice at this point.
There is no "bubbling" from node to vue flow as the event isn't caught on the node itself but the window (as mentioned).
Plus I don't see why this is an issue at all? Is this in any way blocking for you?

When you press Shift inside input, and let it go -> VueFlow stuck in SelectionBox state, because there is no listener for keyup event
https://user-images.githubusercontent.com/36544178/212639032-8ab24caf-39a7-4e28-85ca-8024bf92f685.mov

Ah, you should've said that, that looks more like an issue than what you described previously ^^
I'll see what I can do.

Ah, you should've said that, that looks more like an issue than what you described previously ^^

I was a prisoner of my interpretation of the problem. Sorry for that :^)
I tried to write a solution instead of describing the problem

@salmasov
Should be fixed with 1.12.2, please install that version and lmk if you still experience any problems.

I'll assume this is resolved. If you still experience an issue, please re-open the issue :)


[core]: Fail to initialize

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Core
Which platforms are affected?
Web
Description
I'm unable to initialize Firebase in web
FirebaseError: Firebase: No Firebase App '[DEFAULT]' has been created - call initializeApp() first (app/no-app).
https://www.gstatic.com/firebasejs/10.7.0/firebase-app.js 2045:29   getApp
packages/firebase_core_web/src/interop/core.dart 60:28              app$
packages/firebase_core_web/src/firebase_core_web.dart 252:24        initializeApp
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50  <fn>
dart-sdk/lib/async/zone.dart 1661:54                                runUnary
dart-sdk/lib/async/future_impl.dart 162:18                          handleValue
dart-sdk/lib/async/future_impl.dart 846:44                          handleValueCallback
dart-sdk/lib/async/future_impl.dart 875:13                          _propagateToListeners
dart-sdk/lib/async/future_impl.dart 647:5                           [_completeWithValue]
dart-sdk/lib/async/future.dart 529:22                               <fn>
dart-sdk/lib/async/zone.dart 1661:54                                runUnary
dart-sdk/lib/async/future_impl.dart 162:18                          handleValue
dart-sdk/lib/async/future_impl.dart 846:44                          handleValueCallback
dart-sdk/lib/async/future_impl.dart 875:13                          _propagateToListeners
dart-sdk/lib/async/future_impl.dart 647:5                           [_completeWithValue]
dart-sdk/lib/async/future_impl.dart 721:7                           callback
dart-sdk/lib/async/schedule_microtask.dart 40:11                    _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 49:5                     _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 181:7  <fn>

This is my flutter doctor
[√] Flutter (Channel stable, 3.16.5, on Microsoft Windows [Versi¢n 10.0.19045.4529], locale es-CO)
• Flutter version 3.16.5 on channel stable at C:\FlutterSDK\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 78666c8dc5 (6 months ago), 2023-12-19 16:14:14 -0800
• Engine revision 3f3e560236
• Dart version 3.2.3
• DevTools version 2.28.4
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
• Android SDK at C:\Users\57305\AppData\Local\Android\Sdk
• Platform android-34, build-tools 33.0.2
• ANDROID_HOME = C:\Users\57305\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\android-studio\jbr\bin\java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop Windows apps (Visual Studio Build Tools 2019 16.11.19)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
• Visual Studio Build Tools 2019 version 16.11.32901.82
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 4.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] Android Studio (version 2022.3)
• Android Studio at C:\Program Files\android-studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• android-studio-dir = C:\Program Files\android-studio
• Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
[√] VS Code (version 1.90.1)
• VS Code at C:\Users\57305\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.90.0
[√] Connected device (4 available)
• moto g 60 (mobile) • ZY22FVPZCB • android-arm64  • Android 12 (API 31)
• Windows (desktop)  • windows    • windows-x64    • Microsoft Windows [Versi¢n 10.0.19045.4529]
• Chrome (web)       • chrome     • web-javascript • Google Chrome 126.0.6478.114
• Edge (web)         • edge       • web-javascript • Microsoft Edge 126.0.2592.56
[√] Network resources
• All expected network resources are available.
• No issues found!
Reproducing the issue

Create a new flutter application
Run flutterfire configure
Select web
Run flutter pub add firebase_core
Initialize Firebase inside the main

WidgetsFlutterBinding.ensureInitialized();
await Firebase.initializeApp(options: DefaultFirebaseOptions.web);

Run proyect on Chrome

Firebase Core version
2.27.0
Flutter Version
3.16.5
Relevant Log Output
No response
Flutter dependencies

Expand Flutter dependencies snippet

Replace this line with the contents of your `flutter pub deps -- --style=compact`.

Additional context and comments
No response

Hello, are you reproducing this issue using the latest versions?

Hello, I havent tried the latest versions, I can not upgrade Flutter due to some packages, so I can not upgrade Firebase

Hi @Lyokone, now I have tried with flutter 3.22.0, and firebase_core 3.1.0 (latest version), and its still the same result.
I did flutter clean, flutter pub get,  flutter create --platforms web .,  flutterfire configure, even changed Firebase project and registered a new web app, but nothing works. Am I missing something?
This is the dart file
import 'package:firebase_core/firebase_core.dart';
import 'package:flutter/material.dart';
import 'package:test_web/firebase_options.dart';

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp(options: DefaultFirebaseOptions.web);
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() async {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

This is the output where changed the version of firebase js as expected
FirebaseError: Firebase: No Firebase App '[DEFAULT]' has been created - call initializeApp() first (app/no-app).
https://www.gstatic.com/firebasejs/10.11.1/firebase-app.js 2220:29  getApp
[√] Flutter (Channel stable, 3.22.0, on Microsoft Windows [Versi¢n 10.0.19045.4529], locale es-CO)
• Flutter version 3.22.0 on channel stable at C:\Users\57305\fvm\versions\3.22.0
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5dcb86f68f (6 weeks ago), 2024-05-09 07:39:20 -0500
• Engine revision f6344b75dc
• Dart version 3.4.0
• DevTools version 2.34.3

@DavidAriza No issue on my side using your example. At this point I'm just assuming a bad development environment. Not sure if it's updating Chrome or corrupted Flutter installation. But initializing Web on Windows or any other platform is working fine;


Add Prometheus jobs to fetch k8s resource metrics

What this PR does / why we need it:
This PR adds three Prometheus jobs to retrieve resources metrics.
Which issue(s) this PR fixes:
Ref https://github.com/pipe-cd/pipe/issues/1867
Does this PR introduce a user-facing change?:

NONE

applied

Nice.
/lgtm

/trigger test

Way to go 🚀
/approve


[stacked_firebase_auth] FirebaseAuthenticationResult has only uid and userToken information

All sign-in methods (email, google, apple, facebook) return FirebaseAuthenticationResult object that has only uid, userToken and errorMessage.
Is there a reason why only uid and userToken are returned and not the whole User object from FirebaseAuth that has uid, userToken, email, displayName, phoneNumber, photoUrl, and most importantly customClaims?
Is it better to return User object in FirebaseAuthenticationResult ?
And is it better to expose _firebaseAuth, that way all functions of FirebaseAuth.instance can be accessed directly?

I usually listen for authService.authChanges.listen((user) {} to get the user object and sync custom user profiles stored in Firestore.

@merfire No reason the user object is not on there. I usually return only what's needed at the time and add as those requirements change. This way I know exactly what's needed. I don't want code exposed that won't be used.
It could be better to return the user object and have properties on there for quick access.
We could expose firebase auth as well. If you'd like you can make a PR I can review, otherwise I'll most likely only get to this in a week or two from now.

I can do this after finishing Facebook changes for stacked_firebase_auth.

@merfire that would be great thanks.

we now return the user in the Firebase Auth Result


clean up unused files

is https://github.com/efabless/caravel_user_project/blob/main/verilog/rtl/uprj_netlists.v still used?

similarly are files in https://github.com/efabless/caravel_user_project/tree/main/verilog/includes still used? (they don't seem to be using a consistent syntax)

similarly are files in https://github.com/efabless/caravel_user_project/tree/main/verilog/includes still used? (they don't seem to be using a consistent syntax)

Yes they are used in simulation, they have inconsistent syntax because GL and RTL simulations are done using iVerilog, while GL+SDF simulations are done using CVC. The tools use different syntax for including files.

@marwaneltoukhy is  https://github.com/efabless/caravel_user_project/blob/main/verilog/rtl/uprj_netlists.v also used in simulation?

@proppy No it's not, at least not the default flow. Investigating if some users might be using it for any other reason, I don't want to remove a file that might end up breaking someone's flow.


Automated evaluation pipeline and vocabulary hub

Description
To be able to track all experiments and vocabs that were trained, need to setup a R2 bucket and upload there. There needs to be a basic pipeline to be able to identify regressions in the core tokenization algorithm as well as performance etc.

Vocabulary hub is sort-of did. Opening a separate issue to add evaluation through the CLI.


Allow custom rules directories

This allows passing custom rules directories, similar to the eslint --rulesdir option that will be searched for rules.
Fixes #70

changes in @vsiakka

Awesome, thank you so much @joscha  :)


Make it symfony 5.0 compatible

@stof any chance to be merged this?

I do not think these changes can be accepted because it removes all compatibility with all other versions

Agreed that it's not compatible anymore... but symfony 5 has changed so (GetResponseEvent -> RequestEvent), isn't it obvious that it's not compatible anymore? So this bundle should get a new major version when these changes would get accepted.

Same here, I think a new major version is needed here...

@stefanbraspenning RequestEvent has been added in 4.3. So you can block the constraint to this version or delete the type and manage compatibility

Look at how other bundles manage compatibility

Hi, this branch has release date to use the bundle with a Symfony 5 project?

What needs to be done here?

I think this could be merged and released as a new major version 👍

https://github.com/Atlantic18/DoctrineExtensions/pull/2058 merged

I am also facing the following issue:
[prod] Dec  4 10:12:38 |CRITI| REQUES Uncaught PHP Exception Symfony\Component\ErrorHandler\Error\UndefinedMethodError: "Attempted to call an undefined method named "getClientSize" of class "Symfony\Component\HttpFoundation\File\UploadedFile"." at /app/vendor/stof/doctrine-extensions-bundle/Uploadable/UploadedFileInfo.php line 29

For the information : https://github.com/Atlantic18/DoctrineExtensions/issues/2033

See https://github.com/stof/StofDoctrineExtensionsBundle/pull/404

Thank you @TomasVotruba
The https://github.com/antishov/StofDoctrineExtensionsBundle realy good alternative as this bundle last release was in 2017.

So the suggestion is to use ?
https://github.com/antishov/StofDoctrineExtensionsBundle

In the end, what are the differences between https://github.com/antishov/StofDoctrineExtensionsBundle and https://github.com/doctrine-extensions/symfony-bundle ?

@Pierstoval, https://github.com/doctrine-extensions should be a reorganization of https://github.com/Atlantic18/DoctrineExtensions for the major 3.0 version.
You have more info here : https://github.com/Atlantic18/DoctrineExtensions/issues/2033#issue-470637904
But i'm afraid he doesn't have enough support to finish the idea.. :/

In case you want to make your projects run again. I just switched my project from this package to https://github.com/KnpLabs/DoctrineBehaviors/ (alpha3), it run's on Symfony 5 and PHP 7.3 ery well.


Merge common code bases for TdsParserStateObject.cs (5)

This is a draft PR as I intend to add a few more commits. But let me know if you think this should be merged by itself.
So, in this comment, I asked about ValidateSNIConnection (3rd question, 4 possible solutions are suggested). @David-Engel responded and it looks like we both agree on the implementation of this PR.
To sum up, this PR effectively changes the implementation of IsConnectionAlive in netfx to check if the handle is null before passing it to SNICheckConnection. If it is null, the connection will be considered alive. This behavior is in line with netcore implementation for native.
Moreover, it appears that:

Native SNICheckConnection doesn't expect null values.
The handle in question will only be null if the TdsParserStateObject has been disposed.
We assume IsConnectionAlive is not called if TdsParserStateObject has been disposed (otherwise you would have noticed the bug already).

Therefore, an even better implementation would be to throw an exception (or at least use a debug assertion) to make sure the handle is never null when CheckConnection is called. Note that netcore already does this for the managed implementation (which reinforces the assumption (3)). The null check below the linked line is redundant by the way (I guess the null check predated throwing the exception).
Let me know what you think @Wraith2 @DavoudEshtehari @JRahnama @David-Engel

@panoskj Thanks for looking into merging this file. Since it's been sitting for so long, at this point, I think we'll close this PR and make a second attempt at it as part of a new effort to merge the projects.


Show the description property for both nodes and transitions

Add support to showing the description properties for both states and transitions.

Fixes #337

Very nice!

Ah @riccardo-forina real quick: can you add a changeset? yarn changeset will guide you through it.

Done!


Ctrl and Shift modifiers

This fixes #16 (Shift does not open a tab) and implements #13 (open a background tab using Ctrl).

I totally forgot about Chrome. These changes are probably trivial to cherry-pick, but if not I'm willing to do the porting work. Let me know.

No worries I'll take care of the cherry picking - closing this as #18 is latest.


Fixing AttributeError in slice_indicator initialization

The issue was related to an AttributeError raised in the code when initializing the slice_indicator variable. The error occurred due to the usage of np.int as the dtype argument in the np.ones() function. In earlier versions of NumPy, np.int was a deprecated alias for the built-in int type. However, starting from NumPy 1.20, these aliases were removed.
To resolve the issue, the code was modified by changing the dtype argument from np.int to np.int64 to specify the desired precision explicitly. The modified code snippet looks as follows:
# turn partitions into an indicator
slice_indicator = np.ones(y.shape[0], dtype=np.int64)

This change ensures compatibility with the latest versions of NumPy and resolves the AttributeError related to the use of np.int in the code. The modified code should now execute without any errors.
By making this fix, the issue has been resolved, and the code functions as intended, initializing the slice_indicator variable with the correct dtype.

@rafe-sh I noticed there is another np.int in sliced.datasets as well.
https://github.com/joshloyal/sliced/blob/243bde236d8c615f9563279a0a2095e2fa2f4650/sliced/datasets/base.py#L17
@joshloyal May I kindly ask if there is any plan for releasing a new version including this fix? Anyway, I sincerely thank you for making this repository!

A quick fix for this error is to add one line before using sliced:
import numpy as np
np.int = np.int64

Of course, this is an ad-hoc solution. Hope the authors can merge this commit soon.


Cancel payment leads to PaymentException

If I'm cancelling an payment I'm redirected to the webshop again and I can see an error 500 message:
{
  "errors": [
    {
      "code": "0",
      "status": "500",
      "title": "Internal Server Error",
      "detail": "Undefined constant Shopware\\Core\\Checkout\\Payment\\PaymentException::PAYMENT_CUSTOMER_CANCELED_EXTERNAL"
    }
  ]
}

Hello Thx for pointing that out. We already addressed this issue and it will be fixed in upcoming release.
The problem here is within our polyfill classes. in order to ensure that the plugin is working on different shopware versions, we created polyfill classes which comes in place if a current shopware version does not provide it.
the autoloading process in PHP however finds sometimes our polyfill class instead of the original shopware class and then a wrong class is included int he code.
i fixed this with this commit. https://github.com/mollie/Shopware6/commit/8b3253b99887ee50464051d6e9675cc773c3a9b5. maybe you can apply it to your code base until the new version is released so you dont have the error in the meantime

@jackyraimond just released new version, should be fixed now

Thanks, will test it!

This issue does still exists with kiener/mollie-payments-plugin=v4.10.1 and shopware/core=v<IP_ADDRESS>

@luebbt please do not use kiener/mollie-payments-plugin in composer. this is just the branch from github. please use
composer require store.shopware.com/molliepayments  here we upload the ready for release files. but you have to add shopware store as composer repo and provide your key there

@BlackScorp thank you for that hint. Ironically I replaced that package right after testing but did not check the issues again. This fixed all of them for me.


Update Android targetSdkVersion to 28, by 2019-11 deadline

We should update our targetSdkVersion to 28, aka Android 9.0 Pie. It's currently 26, since #3075.
Starting 2019-11-01, Google Play will require this for any new updates to our app.
Upstream doc here:
https://developer.android.com/about/versions/pie/android-9.0-migration
and some useful background here:
https://medium.com/androiddevelopers/picking-your-compilesdkversion-minsdkversion-targetsdkversion-a098a0341ebd
The important steps are

Read about the potentially-breaking changes, and identify those that might affect us.
Make a WIP change to targetSdkVersion.
Test the WIP change thoroughly, especially in the areas highlighted in step 1. Fix things as needed, and repeat.

Fortunately this is a less overwhelming set of changes than we had to deal with in #3075 -- because we aren't catching up on 4 years of platform changes at once, as we were then.
More details to fill in later. Filing now in order to have an issue to link to.

This can also be seen as a followup task from the RN v0.59 upgrade #3399 -- the upstream RN template app made this change in that interval.

I was just going through related docs to close out #3075 (and disaggregate the followup tasks that remain from it), so here are some more links.
A short outline of important changes in 9.0 / 28:
https://developer.android.com/distribute/best-practices/develop/target-sdk#prepie
That includes changes that already apply to us on 9.0, in addition to changes that are opt-in with targetSdkVersion.
A more detailed list, and focused exclusively on changes relevant to this issue (i.e., changes that will come into effect when we update targetSdkVersion):
https://developer.android.com/about/versions/pie/android-9.0-changes-28
A quick skim of that list finds:

Likely requires action: isCleartextTrafficPermitted -- see also 1f55c035a
Might require action: WebView changes re MIME types and re document scrolling
Several others I'd have to investigate more to be confident they don't affect us.

Of the changes that already apply to us on Android 9 devices:

App Standby Buckets can affect ability to receive FCM messages (and hence show notifications.)

Confirms the importance of not overusing priority: high in FCM! Fortunately we've always gotten that right; see #3185.

Rereading that list:

(Again the isCleartextTrafficPermitted change.)

Might require action: WebView changes re MIME types

This applies to file: URLs. Currently our baseUrl is from auth.realm, so it's not on file:, and this doesn't affect us. Soon we'll make it a file: URL, with #3636 . I think this just means we need to make sure it has a .html extension when we do -- which that PR already does.

Might require action: WebView changes [...] re document scrolling

Described in a couple of paragraphs here. This calls for further investigation; I know we use the properties this discusses, so we'll want to check our use against what this says is the new semantics.

"Prior to Android 9, notifications from suspended apps were canceled. Beginning with Android 9, notifications from suspended apps are hidden until the app is resumed."
I'm not sure what a "suspended app" is -- best I can find on the web for searches like [android suspend app] is about an app getting suspended from the Play Store, which doesn't sound like it'd be what this means. Rather, this sounds like something between being in the background and outright stopped?
Probably OK to ignore this one.

"The ConnectivityManager.NetworkCallback class now sends information about VPNs to apps. This change makes it much easier for apps to listen for connectivity events without having to mix synchronous and asynchronous calls and using limited APIs."
This sounds like something that could potentially help with #3602 . It doesn't seem like there's anything we need to do about it that'd block the update, though.

Merged #3658 and about to send it to beta for wider testing. Let's leave this open until we're done validating it, though.
In particular, over on that thread @ray-kraesig noted:

on the Google Play Console there's a list of currently-greylisted APIs we're using. None of them seem to be on the (very short) Pie blacklist, but they should probably still tracked down and verified harmless before a full release.

There are ten weakly-deprecated APIs reported to be in use by our app. Of those, only one has made it onto the Android 10 blacklist.
TL;DR: We're probably good for now.
Used by OkHttp:

Lcom/android/org/conscrypt/OpenSSLSocketImpl;->getAlpnSelectedProtocol()[B
Lcom/android/org/conscrypt/OpenSSLSocketImpl;->setAlpnProtocols([B)V
Ldalvik/system/CloseGuard;->get()Ldalvik/system/CloseGuard;
Ldalvik/system/CloseGuard;->open(Ljava/lang/String;)V
Ldalvik/system/CloseGuard;->warnIfOpen()V

Issue: https://github.com/square/okhttp/issues/3980
OkHttp is used by React Native to implement (at least) fetch(). As can be seen in the linked issue, Square's been on top of this.
Note that getAlpnSelectedProtocol has been fully blacklisted in Android 10, so upgrading to the next SDK target is blocked on

[ ] this getting fixed in OkHttp
[ ] that fix getting into React Native
[ ] us upgrading React Native to a version with the fix

But this is true of literally every consumer of React Native, so this is probably a low risk.
Used by React Native:

Landroid/widget/ScrollView;->mScroller:Landroid/widget/OverScroller;

Issue: https://github.com/facebook/react-native/issues/25120
Unfortunately, this does not appear to be being handled by upstream; the linked issue was locked by a bot as "stale".
The stack trace indicates that this is used by the ScrollView component; digging indicates that this (reflective access of a private member variable) was originally introduced as a hack in this commit.
We (like other React Native users) already suffer degradation of functionality on platforms where ScrollView has been replaced and this member variable does not exist (e.g., as in  https://github.com/facebook/react-native/issues/9697). A formal blacklisting of this API would annoy but not significantly impair us.
Used by Android Support library:

Landroid/view/View;->computeFitSystemWindows(Landroid/graphics/Rect;Landroid/graphics/Rect;)Z
Landroid/view/View;->mAccessibilityDelegate:Landroid/view/View$AccessibilityDelegate;
Landroid/view/ViewGroup;->makeOptionalFitsSystemWindows()V

One assumes that Google will fix their own support libraries before it becomes relevant elsewhere.
Unknown:

Landroid/content/Context;->bindServiceAsUser(Landroid/content/Intent;Landroid/content/ServiceConnection;ILandroid/os/Handler;Landroid/os/UserHandle;)Z

The string bindServiceAsUser does not occur anywhere in our APK. This is probably (?) from the underlying Android-provided WebView implementation, as relatedly conjectured here, but the stack trace isn't strongly indicative of that.

There are ten weakly-deprecated APIs reported to be in use by our app. Of those, only one has made it onto the Android 10 blacklist.

Cool -- thanks for all these details!
I've just gone and filed an issue (#3665) for the next upgrade, so we have a place to record that information.

I think we can call this issue resolved.
One concern that has not yet been acted on is the change to initial element focus. This is important for a11y... but we don't really have a coherent a11y strategy or framework at the moment; so presently it's just a technical detail to be kept in mind when we develop them.
Some informal notes on what was considered, copied from my scratchpad, follow. (These are ordered according to their appearance in the official changelog.)

FOREGROUND_SERVICE doesn't apply; we don't use Service.startForeground
we don’t care about device serial numbers
we don’t have our own DNS resolution mechanism
isCleartextTrafficPermitted was fixed preemptively in 1f55c035

note: release builds can no longer connect directly to dev servers

we have one WebView and one process
we should already disconnect/reconnect when we switch default networks

we actually just rely on RN for this
due to long-polling, we might have exactly one off-network request

Apache? what’s that?

UI changes

initially-focused-element story is unfortunately not great right now
color formatting changes don't affect us due to cross-compat
no file:// MIME type assumptions here (yet, nor now ever)
scrolling behavior appears identical in tests
“Notifications from suspended apps” sounds like it matters…

… but “suspended” isn’t actually a documented app lifecycle state
(new behavior is probably an improvement anyway)


[Bug]: CheckboxGroup widget - When the entire option values are removed the widget disappears when user clicks anywhere on the canvas

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
It is observed that when the checkboxgroup widgets entire option value is removed, the widget disappears when the user clicks anywhere on the canvas. Only on mouse hovering on the are where the widget is initially placed then the widget appears
https://loom.com/share/d88d8c3a02b54ab5b96c2b79b91da53f
Steps To Reproduce
1.Launch appsmith app in release/Prod Environment
2.Drag and drop checkbox group widget
3.Remove the value from the option field
3.click anywhere on the canvas and observe
Environment
Production
Version
Cloud

This doesn't seem to be a bug. If there's no data, then the widget will be empty. Look at the text widget, iframe widget, image widget, etc. I'll close this issue

@areyabhishek But when the data is removed for MultiSelectTree, MultiSelect, TreeSelect or select widget - Still the widget remains.


annotators are here

cycle and rna annotation can now be done :)

Travis is unhappy:
/opt/EDeN/eden/modifier/rna/structure_annotation.py:121:37: E701 multiple statements on one line (colon)
/opt/EDeN/eden/modifier/graph/cycle.py:33:30: W291 trailing whitespace
/opt/EDeN/eden/modifier/graph/cycle.py:36:9: E303 too many blank lines (2)
/opt/EDeN/eden/modifier/graph/cycle.py:53:21: E711 comparison to None should be 'if cond is None:'


Remove ReactGA completely and more detailed errors

Coverage increased (+0.03%) to 78.853% when pulling c0d391dc96d9dabf474693f9e1949dc5dc3a13e8 on eatonphil:drop-react-ga into c02dee32a6a0da983f2746995aa474232a25b9cc on linode:master.

Coverage increased (+0.03%) to 78.853% when pulling 165f2d69c226a09ebce4e8487f0bfa5389b29787 on eatonphil:drop-react-ga into c02dee32a6a0da983f2746995aa474232a25b9cc on linode:master.


add shell comand for the settings subsystem

settings shell commands
Add bunch of commands which allows to :

write a key-value pair
read a key-value pair
delete a key-value pair

Commands shall support basic C types encoding in selected endianess, string and binary blobs.
Objective
Mechanism which allows to create provisioning flash raw image of the settings storage which can be used to prepare storage content for the manufacturer provisioning using natvie_posix targets and flash_simulator (on flash device file).
[Update]
#40429 implemented read capabilities

@nvlsianpu can we decouple the addition of commands to add/edit/remove key-value pairs as shell commands with the creation of pre-baked images? We could start by adding the shell commands and see about the images later.

@carlescufi Yes we can decouple these ideas. Moreover I remember @Laczen example native_posix application which is designed for creation of pre-backed image. https://github.com/Laczen/zephyrmodules/tree/master/utils/native_posix/settings_preload

Label "area: POSIX" is for Zephyr POSIX subsystem, not for native_posix target (confusion between the too is long-standing; the only common thing between them is that they make each other's life more complicated (this include assigning wrong ticket labels ;-) ). Removing that label. The right label is "area: native port".

Vote for this feature

I also vote for this feature. Currently having to develop a cmdline-like module to set/get params for a module that will interface with a PC program. If this feature was developed it would fit right in. I think many embedded applications use a command line to get/set params. Though it's good to keep in mind not all params are "settings"/non-volatile related.. so ideally it would allow some commands to be routed to settings and some to be routed to rest of the application. e.g. get voltage.battery is reporting a real-time value that would not come from settings. but get config.mode would be routed to settings.
Thoughts?

I am also in need of a shell module to read and write settings.
Thankfully, @Damian-Nordic already added the functionality to list keys and read their values. Is there any reasons (other than it being more work) why the writing part has been left out? Any reason that would prevent someone from upstreaming this feature?

@rettichschnidi The only reason was that I needed only listing and reading settings for test/verification purposes and I wanted to achieve that with minimum effort. Also, I wasn't sure if writing would be equally useful, but if it would it can be added for sure :).

@rettichschnidi Actually, I've been recently working on some settings-related stuff and needed a write command for testing, so created a PR https://github.com/zephyrproject-rtos/zephyr/pull/45459 with both write and delete commands.


Laravel 9 packages conflict

Problem 1
- Root composer.json requires raiym/instagram-php-scraper ^0.12 -> satisfiable by raiym/instagram-php-scraper[v0.12.0, ..., v0.12.4].
- tightenco/nova-google-analytics v2.0.0 requires spatie/laravel-analytics ^4.1 -> satisfiable by spatie/laravel-analytics[4.1.0].
- Root composer.json requires tightenco/nova-google-analytics ^2.0.0 -> satisfiable by tightenco/nova-google-analytics[v2.0.0].
- Root composer.json requires spatie/laravel-sitemap ^6.1.0 -> satisfiable by spatie/laravel-sitemap[6.1.0].
- spatie/laravel-analytics 4.1.0 requires laravel/framework ^9.0 -> satisfiable by laravel/framework[v9.1.0, 9.x-dev].
- Only one of these can be installed: illuminate/collections[dev-master, v8.0.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev], laravel/framework[v9.1.0, 9.x-dev]. laravel/framework replaces illuminate/collections and thus cannot coexist with it.
- Conclusion: install illuminate/collections v8.83.1 (conflict analysis result)

Do you mind posting your composer.json file for the project? The conclusion of the message you posted states

Conclusion: install illuminate/collections v8.83.1 (conflict analysis result)

Our package only has two requirements:
"php": "^8.0",
"spatie/laravel-analytics": "^4.1"

@stepanenko3 - Just checking in to see if you were still dealing with this issue. No pressure though, I know there are other things going on.


Migrate to latest versioning document

release/versioning.md that was in the k/design-proposals-archive repository in the past has been migrated to k/sig-release repository repository.
This PR is a split of https://github.com/kubernetes/website/pull/34948.

Wow, thanks!
Would you like to also update this two files? 😊
content/en/releases/release.md
127:  [release versioning](https://git.k8s.io/design-proposals-archive/release/versioning.md).

content/en/docs/reference/using-api/_index.md
42:The [API and release versioning proposal](https://git.k8s.io/design-proposals-archive/release/versioning.md)

/kind cleanup

/lgtm

/approve


[1.20.1] Incompatible with "keybinding fix"

Minecraft 1.20.1
Fabric 0.14.21
remember my txt: 1.0.0
Keybinding fix: 1.0.0
trying to make any changes to the options.txt through the ingame menu causes the error 'Failed to save options' and no changes to be saved after reloading the client. the specific error given is:
temp.txt
https://github.com/fzzyhmstrs/kf/issues/2#issue-1804245534

I can't recreate this error with Fabric API, Fabric Language Kotlin, Keybind Fix, and Remember My Txt on the latest versions of Minecraft, Fabric, and these mods.
I don't think this is an incompatibility with keybinding fix, and is probably another mod.

it seems to happen on the initial launch with this mod only, the other mods previously mentioned do not need to be added. after closing the game the first time every launch seems to save the options.txt fine. my guess is some other conflict was causing the error to occur every launch by resetting something.
first launch logs: 2023-07-26-1.log
second launch logs: latest.log


”Gostinari” is listed in the drop-down menu

Description:
"Gostinari" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Gostinari" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Gostinari, GIURGIU".


New version: LinuxSuRen.HTTPdownloader version 0.0.82 [FP-O]

Result: Installation Failed

Manifest
Add/Remove Programs

Name
HTTP downloader

Version
0.0.82

Publisher
LinuxSuRen

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 5980

@wingetbot run

@wingetbot run


[#5904] Disable the Recycler by default

Motivation:
The Recycler was introduced as a light-weight object pool, to reduce GC pressure. We use it in various places, like pooling ByteBuf objects (not the actual memory, just the container), write tasks (When you call write(...) from outside the EventLoop) and many more.
This usage gave us a lot of trouble in the past and also users a hard time when they ended up with a lot of objects in the Reycler due writing to fast etc.
Modifications:
Disable the recycler by default so users need to explicit enable it to use it.
Result:
Recycler is not used anymore by default.

@nmittler @Scottmitch @buchgr @ejona86 @mosesn @vkostyukov PTAL ... As discussed in #5904.
We did a few internal benchmarks and not noticed any bad impact because of this change. Could you please check and maybe run a benchmark as well ?

Also @trustin @cconroy and @NiteshKant

I can confirm that I saw no performance difference when I disabled the recycler via config.

Thanks for the heads up @normanmaurer! I'm running a benchmark right now. Will report back when I have the results.

@normanmaurer
I've been running some experiments internally and I can confirm this affects us dramatically: GC times are 10x up. Although, I can see how this doesn't actually affect most of Netty users. Here is why.
As you probably know, we're not pooling in Finagle (yet) and turns out we've been relying on recyclers to "pool" our outbound/send buffers (we fall through the first condition because our allocators are not pooled). This makes GC times climb up (I constantly reproduced that on our ping-pong test for Mux).
Even though this affect us so much, I personally don't think this should be considered as a blocker. As long as the majority of the Netty community happy - we're happy. Worst case, as a workaround, we can re-enable recyclers back locally.

@vkostyukov gotcha.... actually the plan was to remove it completely at some point. With what you told me that may be not feasible at all. Let me think a bit about it.

AS this has such a big impact let me close this for now.

Going back to this (I thought you might be interested in hearing the update).
We've been profiling Finagle's HTTP implementations (Netty 4 vs Netty 3) and figured that N4 is performing slightly worse (spends about ~20% more of CPU time normalized per requests) while handling the same amount of traffic.
Turns out Recyclers account for about half of that overhead. Disabling them manually, helped us to reduce the gap to ~10% in our tests. We're in the process of running more tests with different Finagle components to see if Recyclers can be disabled globally in Finagle.
I will report back when I know more.

That’s really interesting... I would be interested in a profiler snapshot of 3.x and 4.x with recycler and without. Would this be possible ?

Am 13.12.2017 um 23:02 schrieb Vladimir Kostyukov<EMAIL_ADDRESS>Going back to this (I thought you might be interested in hearing the update).
We've been profiling Finagle's HTTP implementations (Netty 4 vs Netty 3) and figured that N4 is performing slightly worse (spends about ~20% more of CPU time normalized per requests) while handling the same amount of traffic.
Turns out Recyclers account for about half of that overhead. Disabling them manually, helped us to reduce the gap to ~10% in our tests. We're in the process of running more tests with different Finagle components to see if Recyclers can be disabled globally in Finagle.
I will report back when I know more.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

@vkostyukov not sure you saw the comment above :)

@normanmaurer when disabling the recycler we see increased gc pressure in new TLAB from MessageToMessageEncoder creating CodecOutputList, most likely coming from LengthFieldPrepender.

@johnou yeah this sounds possible. That said we could fix this one easily by use a normal FastThreadLocal here. The recycler is not really needed.

Hey @normanmaurer! Thanks for your patience (and sorry for me being so slow in responding). I think I might be able to get you those profiles. Our simulation framework isn't yet open-sourced so I guess I have to talk to somebody to make sure it doesn't expose any sensitive information.
What format would you prefer? I can do flame-graphs / plain flat texts.

@vkostyukov flame-graphs would be nice

One thing to keep in mind here is that the recycler is doing work in the application that effectively replaces the functionality of GC. GC isn't free, but the JVM has a lot of optimization in the GC implementations. So, while GC pressure might increase without the recycler, overall throughput may still in fact be higher! When I ran tests previously, I found that disabling the recycler had no performance impact but vastly reduced memory footprint.

As I think about this again, it might that Finagle is seeing such a big impact is because it's already quite heavily using thread-locals (though its Local primitive, a thread-local, but for futures).
As you know threads locals are cheap, but not free. They always make it to the top of the CPU profile in our simulations:
<PHONE_NUMBER> ( 1.99%)    2536  java.lang.ThreadLocal$ThreadLocalMap.getEntryAfterMiss
<PHONE_NUMBER> ( 1.77%)    2263  itable stub
<PHONE_NUMBER> ( 1.56%)    1992  java.lang.ThreadLocal$ThreadLocalMap.getEntry
<PHONE_NUMBER> ( 1.37%)    1756  u32_classify	[cls_u32]_[k]
<PHONE_NUMBER> ( 1.16%)    1483  sun.nio.cs.UTF_8$Decoder.decode
<PHONE_NUMBER> ( 1.13%)    1439  com.twitter.util.Promise.isDefined
<PHONE_NUMBER> ( 1.09%)    1394  java.lang.ThreadLocal$ThreadLocalMap.set
<PHONE_NUMBER> ( 1.09%)    1388  java.lang.ThreadLocal.get

One of the ideas we explored recently was to reduce the number of times we access thread-locals and turns out, disabling recyclers do the trick.

SO you say disabling recycler did the trick because it removes threadlocal access ina big fashion ?

I haven't checked the CPU profile with recyclers disabled but based on the throughput improvements, I'd guess it helps to some extent. One thing I forgot to mention, it's HTTP/1.1 that benefits the most (in Finagle) as its implementation is 100% in Netty. The rest of the protocols (i.e., ThriftMux) don't really notice recyclers.

Got it... I would be super interested in the profile ;)

Am 19.12.2017 um 18:28 schrieb Vladimir Kostyukov<EMAIL_ADDRESS>I haven't checked the CPU profile with recyclers disabled but based on the throughput improvements, I'd guess it helps to some extent. One thing I forgot to mention, it's HTTP/1.1 that benefits the most (in Finagle) as its implementation is 100% in Netty. The rest of the protocols (i.e., ThriftMux) don't really notice recyclers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Created new issue for our discussion wrt M2MDecoder https://github.com/netty/netty/issues/7528

@normanmaurer also seeing high allocation in PooledUnsafeDirectByteBuf when disabling the recycler, maybe I didn't run the application for long enough..?

Well one of these ByteBuf will be created whenever you create a new ByteBuf so its no wonder these are allocated a lot.

@normanmaurer I thought they were suppose to be, well, pooled?

@johnou the internal storage is... and the external object (the ByteBuf itself) is in the recycler.

Just wanted to close the loop on this. We re-did our testing just recently and came to a conclusion that disabling recyclers improves the overall throughput of both ThrifMux and HTTP servers (at the cost of extra allocations):
Here are some concrete numbers we observed:

HTTP/1.1: about better 5% thrpt (per core) via 2% increase in allocations/request
ThriftMux: about 7% better thrpt (per core) via <1% increase in allocations/request

We're disabling recyclers in Finagle and are totally onboard if they will be disabled by default (or just removed in a long run) in Netty.

FYI: ByteBufUtil's threadLocalDirectBuffer (non-obviously to me) relies on Recycler. If we disable recycler, at the very least we should add a comment when reading the io.netty.threadLocalDirectBufferSize property that it's probably a bad idea to enable it without also enabling the Recycler.

+1

Am 25.06.2018 um 19:41 schrieb Eric Anderson<EMAIL_ADDRESS>FYI: ByteBufUtil's threadLocalDirectBuffer (non-obviously to me) relies on Recycler. If we disable recycler, at the very least we should add a comment when reading the io.netty.threadLocalDirectBufferSize property that it's probably a bad idea to enable it without also enabling the Recycler.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Is it as simple as removing the recycler completely OR removing certain items that are affecting performance from using the Recycler? Maybe not all objects are suitable for it, e.g. those that are easily created and so would be easier task for the JVM GC to deal with.