Add ogv.js player

Hi!  It can not be enabled or installed, even if you paid the full cost of the computer!  I promise I will not buy another computer with such a silly limitation, I made a mistake.
 It is a shame for a computer to get thrown away for this. It is the company that is trash, not the computer!
Therefore, I have attempted to integrate the ogv.js player into Hybooru, to allow me to view very important videos even on my dumbest computers. I have tested and found even very large video can play quite well on the dumb computer using ogv.js. Who knew?
The PR adds:

Small diversion in File.tsx to decide to load ogv.js player in stead of video tag. Dumb computer detection is accomplished using HTML Video canPlayType function.
Integration of ogv.js library code using symlink to node_modules, just like Ruffle integration.
Simple ogv player component. Ogv.js do not come with player chrome so I only added simple play/pause/fullscreen.

I think we could add full player chrome but video.js seems bloated so I decided it would probably be better if we make it by hand. But, getting WebM video to play first seems better to start.
Maybe it would also be a good idea to add ability to set Ogv.js preference, "Always", "Auto-detect", "Never"?
Let me know what you think!

Not sure if you are either busy, or if you have no intent to merge a feature like this. If you do not want to have a feature like this, please feel free to close the issue, and I can just maintain a fork instead.
In the mean time, for the kind of peoples who download and execute unsigned binary packages from sketchy people with funny names, I have build with the ogv branch for my own personal usage.
https://github.com/LoliOnTop/Hybooru/pkgs/container/hybooru
I guess not many people are going to use fruit devices with Hybooru client, but ogv.js may be interesting again now that browsers are also removing Theora support.
https://winaero.com/chrome-and-firefox-may-soon-drop-theora-codec-support/
Modern Fruit devices can play VP8 WebMs at over 1080P 30FPS using ogv.js, so old Theora files should run very well on even modest computers using WebAssembly software decoding. Ugly as it may be...
Anyway, I hope this finds you well. I do not mean to bother.

I am not sure about adding that just to fix some issue on Apple computers specifically. If this can be fixed with some JS, can't you just install some browser extension that will do it for you on all the websites? Or make a tampermonkey/greasemonkey script?
Either way, I rather not bloat the website with this. However if you can find a way to make it work with simple JS script that could be added to the website, I could add a config option to specify external scripts that would get added in HTML <head> section or something like that.

I understand. I will try to look into less obtrusive ways to do this thing. However, I would like to at least offer some thoughts on why I chose this approach:

I agree regarding bloat. I tried really hard to make the minimum impact on browsers other than Safari. The OgvPlayer component is only used when browsers can not play WebM, and like Ruffle, ogv.js code is only ever loaded lazily when a WebM file is actually loaded in a browser that does not support WebM. I realize this still requires some obtrusive code in the regular path of the program code and thus this is probably still not acceptable...

Unfortunately. I have not managed to make ogv.js work as a polyfill. I think there is no efficient way to do this. ogv.js by default will instead impersonate a  tag and provide a similar API, but it is not identical and internally it uses a . If there is a way to do this I would love to do it.

I also understand not wanting to add code to specifically support Apple products, which are intentionally broken, and I will not try to convince anyone that this should be done. However, now other browsers are removing support for Ogg Theora, so there is a theoretical use case for Ogv.js outside of Apple's browsers now. I do not think this will be a terribly persuasive argument, because I do not think anyone cares about Ogg Theora anymore... but it's worth a shot :)

Anyway, I am sorry that my solution does not meet your expectations. For now, I will just maintain my soft-fork until I can come up with a better approach. Thanks for the consideration.
P.S.: I would love to just install some Tampermonkey/Greasemonkey script, but the Safari browser on iPadOS is not very good, and it is hard to do much of anything to extend it.  I know this is my fault for buying the computer, so I don't expect this to change your mind.


Little typing fix that caused app-class.d.ts to not be accepted by Typescript compiler

Basically, after working on the PR for #3005, I observed the code still not compiled, but now because of the following error:
[at-loader] ./node_modules/framework7/components/app/app-class.d.ts:151:26
    TS2314: Generic type 'Framework7EventsClass<Events>' requires 1 type argument(s).

This PR fixes this error.

Thanks

No problem! Thank you for merging and for working on this awesome project! If possible I hope for the 4.0.2 release soon with these fixes :)


replace deprecated cartopy property on notebook

The goal of this PR is to close #310 . This PR accomplishes the following:

[x] Replace background_patch with patch on Particles.ipynb notebook.
[x] Update documentation (make html)
[x] Replace xlabels_top by top_label and ylabels_right by right_labels on  ospy.plot.horizontal_section().
[ ] Asses whether to set add_labels=True as default argument in od.plot.horizontal_section (and best way to do this), or to simply manually pass it as argument everytime one makes an horizontal section via od.plot module (for example, see cell 7 in  https://oceanspy.readthedocs.io/en/latest/Kogur.html. Running this notebook as is on Sciserver does not plot the axis ticks nor labels).

I wasn't finished. Still missing a task (see first comment).
But these are minor issues with plotting and labels (ticks) not appearing unless add_labels is set True manually as an argument into od.plot.horizontal_section()

Doh!  Sorry about jumping the gun.


High Memory Usage on Jetson TX2

Hello,
I just gave a try on your project. I've been trying to set up the environment for a couple of days. And finally could run it with a little bit changes in the mention configuration on your repo. My configuration is as following:
Jetson TX2:

Jetpack 3.3 (L47 28.2.1)
Opencv 3.4.1 with the contrib modules
Tensorflow 1.9 with gpu
My target was to set up opencv 3.4.1 and Tensorflow 1.6. But there were hundreds of error while installing Tensorflow! It's a just a simple pip installation process, but it took a lot of sweat.

Now, I got an average of 20 FPS which is absolutely breathtaking at this moment. Yet there is a problem, a huge problem I would say. While running the camera stream and video file, memory usage is about 7 Gb with/without visualization which is hard to accept! I was wondering if it's caused by the version of tensorflow. What was your memory usage? Can it be implemented in caffe or pytorch? I would say it's the best performer till now with a huge resource. How do I optimize it as I will be running a whole lot other programs with the detector? Thanks

Hi @magiccreator69,
Unfortunately, the ARM version of Tensorflow requires a large amount of memory resources when loading the CUDA library.
This problem can not be solved.
For both speed and memory resources, TensorRT/C ++ will be the best answer.

Thanks for a prompt response.
You meant should optimize the models using TensorRT, right? Like mentioned here? https://github.com/NVIDIA-AI-IOT/tf_trt_models
That way less memory resource is used? No harm in trying though. I'll give it a try and keep you posted.

Hi @magiccreator69,
No. TF-TRT is python. That uses tensorflow.
You can try https://github.com/Ghustwb/MobileNet-SSD-TensorRT
TensorRT/C++ is really different from TF-TRT.

well. in that case, I don't need to install tensorflow, right? just opencv and cuda libraries are fine? If I don't need to use tensorflow for this, do I need to use any other framework?

Hi @magiccreator69,
Yes, you don't need tensorflow. The framework is TensorRT. It is included in JetPack 3.3.
https://developer.nvidia.com/embedded/jetpack-3_3


fix status panel

still badly sized on Windows version but works fine on Mac version
Need to figure this one out

I would appreciate this a lot. Hard to get a sense of  Some things with the display running in the equivalent of a window Box
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Androidhttps://aka.ms/ghei36

From: LJ Ramones<EMAIL_ADDRESS>Sent: Sunday, January 31, 2021 6:22:29 PM
To: ljramones/trips<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [ljramones/trips] fix status panel (#201)
still badly sized on Windows version but works fine on Mac version
Need to figure this one out
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/ljramones/trips/issues/201, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQPXLNVTNAV5GB2G4H3WA7LS4XQ3LANCNFSM4W32HJHA.

It looks like this has been fixed by changing the size of the applied panel


I have a theoretical question about maskgit cross attention

In cvivit, you would train video clip with the fixed number of frames.
When training maskgit to do cross attention with text tokens, how did you cut(?) corresponding text tokens for the given frames?
Thank you!

@9B8DY6 they don't actually produce the entire video from one large prompt at once
they are basically generating one scene at a time, with the next scene conditioned on the last few frames of the previous scene

in other words, you are always cross attending from all the video tokens to the text, within a scene


Update README.md

Just changed the string name for link.

Could not see any dev branch to submit and so pushing to master.

Hey @krishna-mk,
Thanks for the fix! I've just merged it. You're right, for sub-projects like this one, there's no develop branch because these projects don't have independent CI pipelines.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.


Add context manager to change working directory

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f91581c) to head (a0c0206).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #596   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           71        71
  Lines         1853      1864   +11
  Branches       218       219    +1
=========================================
+ Hits          1853      1864   +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bump brew trigger for v0.12.1

Bumping brew trigger for v0.12.1
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Supply skill change

Change supply skill from once per life to 5-minute cooldown and once per re-supply. You can only use it once everytime you resupply at a station.

Do we want the 5 minute cooldown to start when we resupply or after use?


Reinvigorate remote_archive to support automatic backup of data from ephemeral scratch storage

NCI is upgrading its HPC and at the same time changing replacing the short filesystem with scratch, which is time limited.
payu is so well written (props @marshallward) that there is only one mention of the actual path /short in the entire codebase
https://github.com/payu-org/payu/blob/f567db9dad9fdd219ea632b76d7d715e8e65e457/payu/laboratory.py#L57
(we'll ignore hard coded paths in profiler modules)
So at the very minimum to support the new machine default_short_path should be changed to scratch.
However, as scratch is time limited it is no longer a good fit for the current payu pattern, where bin, input and codebase are stored in the same laboratory as work and archive.
https://github.com/payu-org/payu/blob/f567db9dad9fdd219ea632b76d7d715e8e65e457/payu/laboratory.py#L45-L49
With strict time limited deletion of files on scratch, the only directory that is a clear fit for this pattern is work. The archive directory could live on scratch, with some syncing to a permanent data store, but I think payu should also support archive not being physically co-located with `work.
Thoughts?

This sounds good to me. work would be on scratch. archive could be specified either on scratch (while setting up auto-syncing to a permanent data store for archive) or with the rest presumably at /g/data/--project--/--user--/? Sounds like you just need a new default_gdata_path to set this second directory.
If someone uses scratch for their archive, and doesn't set up an auto-sync, can we get a warning setup about the time limit (or will NCI be providing some kind of warning for when files will be deleted)?

There is a function in Experiment named remote_archive which was once used to transfer model output over to MDSS, back when storage limits were so severe that model runs would often go over quota.
As storage became less of a problem, this function became deprecated and is now basically a zombie function which cannot be called.  But it would not be much work to reinstate something like this.
Which is to say that we've been here before, albeit under different constraints (space vs time), but it should not be a problem to either append this function to the end of archive() or integrate into the payu archive command.

Ok. I think this is well overdue to be implemented.

The COSIMA issue linked above refers to adding syncing of restarts to their existing sync script
https://github.com/COSIMA/01deg_jra55_iaf/blob/master/sync_data.sh
This script is called with the postscript hook in the payu
https://github.com/COSIMA/01deg_jra55_iaf/blob/master/config.yaml#L77
Not everything in that script is appropriate for including in payu, but it gives a good overview of what syncing capability is required.
Also important to note the rsync options that are used. It isn't feasible to use -a with rsync, as it automatically changes the group (project in NCI speak) to that of origin, but in general /g/data directories have the setgid bit set, so that folders and files copied there have the same project code as the enclosing folder. It is important to keep this behaviour as files and folder accounting is (mostly) done by the group (project) of the file/folder.
Using -a with rsync undoes this behaviour.

I've created issue #358 and cross-referenced here. Syncing restarts that will late be deleted is an issue.
It could be that the logic for restarts is different than for outputs: could use rsync machinery to delete restarts at the destination once they're deleted/pruned at the source. This is problematic though if restarts are deleted by time based purging of scratch, and then later deleted.
Another possibility is to have an option to not sync restarts, then tidy them in a separate step and then turn on restart syncing and then call something like
payu sync

If payu did support date based restart frequencies then it potentially has the information it needs to make sure it doesn't sync restarts that will later be pruned.
It would probably require inspection of restart files (so retaining a dependency on the netCDF4 python module, or adding a dependency on xarray, and might not work for all models, so might need to be driver dependent.

Just documenting some notes here:
In the COSIMA issue above, it was also referenced that payu doesn't automatically collate the most recent restart. If rsync was set to exclude uncollated files, then the most recent restart wouldn't be synced. So payu collate -d archive/restart<num>. may need to be another step before syncing restarts.
One payu sync command could potentially collate the latest restart if required, then run a user-script before any syncing (to tidy up any restarts) and then finally rsync the restarts.
Otherwise, auto syncing restarts could be setup to only sync restarts using the integer restart frequency (or using date-based restart frequency).
To automatically sync outputs, could run the sync command where the postscript hook is run, which is at the end of archive if not collating otherwise after collation.
The sync config could something look like:
sync:
        - enable: default false
    # PBS specific:
        - queue: default copyq
        - walltime: (e.g 10:00:00)
        - mem: default 2GB
        - ncpus: default 1

    # rsync specific:
        - directory: destination dir to copy data to
        - rsync_flags: string of any additional flags for rsync

        # For exclusions, could add string to rsync_flag (e.g "--exclude *.nc.* --exclude iceh.????-??-??.nc --exclude *-DEPRECATED --exclude *-DELETE --exclude *-IN-PROGRESS")
        # or have a parameter with a list of strings, e.g.:
        - exclude:
            - *.nc.*
            - iceh.????-??-??.nc
            - etc

        # For restarts
        - restarts:
            enable: default false
            collate_latest: default false # collate latest restart prior to rsync

userscripts:
    # User defined scripts/commands to be called before remote syncing model archive
    # e.g. in access-om2: a script to concatenate cice daily files and deleting cice log files with only 105-char header
    sync: tidy_archive.sh ```


Module or init docstrings reference

Hello, top library... only one i found that solve something a need.
I have one use case i don't know how to solve:
I have python library - I want to document library with referencing modules.
I found how to use docrep in classes and functions, is there a way how to use it in module docstrings (I dont know how to use decorator on module...)
Example
module_1.py
"""
module_1
----------

This fancy module has such a features
"""

init.py
"""
This library modules:

<Somehow get module docstrings of module 1>
"""

Solution can be opposite - document all modules in init and then reference from modules
Why?
In my case there is most copy pasters. Good to be able type once.

hey @Malachov! Glad you like it :smiley: To my knowledge there is no decorator-like syntax for modules. But, as with classes, you can set the __doc__ attribute of the module. I. e. something
module_1.py
"""
module_1
----------

This fancy module has such a features
"""
from docrep import DocstringProcessor

docstrings = DocstringProcessor()

docstrings.get_sections(__doc__, "module_1")

init.py
from module_1 import docstrings

__doc__ = docstrings.dedent("""
This library modules:

%(module_1....)s
""")

It works like charm, thank you very much.
I've tried f'strings docstring, i've tried edit doc, but only this seems to works...
lets close this issue.

hey @Malachov! Yes, that's generally a problem with the concept of docrep, see #18 for instance. IDEs like vs code do not really import the package. So they cannot interprete the commands that docrep is doing to modify the docstring.
Feel free to close this issue.


Add rotation constructors to Matrix4

Matrix4 doesn't currently implement methods like from_euler etc...

I suppose, in addition to the From impl for Matrix4, this issue needs from_angle_x, from_angle_y, from_angle_z, and from_axis_angle?
Anything I'm forgetting?

Fixed by #348 ❤


Deprecation warning - Scheduling into the 'sync' run loop queue

I've upgraded to Ember 3.0.0 and it seems this addon now causes a deprecation warning (although I jumped from 2.16 -> 3.0.0, so it could have been any version in between)

Seems to happen when a slider is rendered on the page (don't even need to interact with it). The deprecation points to this section of code (makes sense):
https://github.com/kennethkalmer/ember-cli-nouislider/blob/master/addon/components/range-slider.js#L77-L89
I did a quick google search and couldn't actually find information on this deprecation anywhere...

I've got the same after - funnily enough - doing an upgrade from 2.16 -> 3.0.0.

It looks like this will be fixed anyway, when 1.0 of this addon is released
https://github.com/kennethkalmer/ember-cli-nouislider/pull/52

Thanks for reporting, I'm gonna keep this open for others to find until #52 is merged in.
Could I ask you a favor please, could you help review and give some feedback over there if needed. I want as many eyes on this as possible!

This has been published to npm as 1.0.0-rc.2, please test with ember install ember-cli-nouislider@next and please open any issues that you encounter.

Thanks @kennethkalmer the update works well, and no more deprecation warning :)


Use 'i' and 'k' to better distinguish variables in an example

It took me a moment of staring at this example to realise that i and j were actually different variables. They're not very different in the monospaced font!
I'm hoping that i and k will make them stand out more, and this example easier to read.
(Most letters seem to have a use already in this file, or I'd have picked an even more different pair of letters.)
—
Pull Request Check List
This is just a friendly reminder about the most common mistakes.  Please make sure that you tick all boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.  If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.

[x] Added tests for changed code.
[x] New features have been added to our Hypothesis testing strategy.
[x] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).

[x] ...and used in the stub test file tests/typing_example.py.

[x] Updated documentation for changed code.

[x] New functions/classes have to be added to docs/api.rst by hand.
[x] Changes to the signature of @attr.s() have to be added by hand too.
[x] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.  Find the appropriate next version in our __init__.py file.

[x] Documentation in .rst files is written using semantic newlines.
[x] Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!

Thanks for improving our docs!


MODULE_NOT_FOUND Error if @jspm/generator is in dependency tree

https://github.com/fusionstrings/jspm-generator-tests
Error with Chomp and @jspm/generator
If @jspm/generator is imported, Chomp build throws. The error seems to be originating from here https://github.com/jspm/generator/blob/8f89dc8cb59cf44c146157097c8a00fd8714a39e/src/trace/resolver.ts#L671
Error case
chomp build:error:html

 chomp build:error:html
🞂 public/error.html
file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:1840
    throw new JspmError(`Unable to resolve ${main ? main + ' in ' : ''}${pkgUrl} resolving ${originalSpecifier}${importedFrom(parentUrl)}.`, 'MODULE_NOT_FOUND');
          ^

JspmError: Unable to resolve<EMAIL_ADDRESS>resolving semver imported from<EMAIL_ADDRESS>    at Resolver.legacyMainResolve (file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:1840:11)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Resolver.resolveExport (file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:1632:45)
    at async TraceMap.resolve (file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:2069:59)
    at async TraceMap.visit (file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:1851:26)
    at async file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:1879:13
    at async Promise.all (index 20)
    at async TraceMap.visit (file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:1874:9)
    at async file:///Users/user/@jspm/jspm-generator-tests/node_modules/@jspm/generator/dist/generator.js:1879:13
    at async Promise.all (index 3) {
  jspmError: true,
  code: 'MODULE_NOT_FOUND'
}
x public/error.html [3.26758714s]
Unable to complete all tasks.

Success case
Here @jspm/generator is not one of the dependencies
chomp build:success:html

What's interesting though is that  Github action seems to pass
https://github.com/fusionstrings/jspm-generator-tests/actions

worked after cache bust
https://github.com/jspm/generator#clearcache
Thanks a lot
https://discord.com/channels/570400367884501026/724211491087056916/1000888114807586846


Match shader samplers type against user-provided texture/sampler pair

Need more safety here!  This affects MSAA #308. AFAIK, the current approach is to have draw calls unfailable.

Will this allow changing texture filter at drawing? In the Piston 2D back-ends we would like to choose between linear and nearest filter using the same program.

This issue is only about safety checks, not new abilities. Changing the filter mode at drawing is, of course, allowed (see my other response).

Not happening in pre-ll


[bug] search functionality could be optimized

When I try to find this page: https://www.nfdi4plants.de/nfdi4plants.knowledgebase/docs/ArcCommanderManual/arc_config.html
I enter arg config in the search bar, but the relevant page is not there.
So I think the search functionality should be optimized. Otherwise it is hard to use.

Thanks for pointing this out @Freymaurer

It is the first hit for me?

But for me, it works like this:

Ahh! You mean if you search for "arg config"? With a g instead of c?
I am sorry for the inconvienience, but it is very difficult to catch typos for short acronyms like arc.

Thank you. I have not realized there is a typo. I think I can close the issue. Sorry for that.


Blood Content Alcohol

Description
I have added the folder Blood Content Alcohol in which all the necessary file are there.
Fixes #1018
Have you read the Contributing Guidelines on Pull Requests?

[X] Yes

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Project Metadata
If there is no-file/nothing to fill the below fields with, then type: none
Example: If no requirements.txt needed/present, then type none in Requirments.
Category:

[ ] Calculators
[ ] AI/ML
[ ] Scrappers
[ ] Social_Media
[ ] PDF
[ ] Image_Processing
[ ] Video_Processing
[ ] Games
[ ] Networking
[ ] OS_Utilities
[ ] Automation
[ ] Cryptography
[ ] Computer_Vision
[ ] Fun
[x] Others

Title: Blood Content Alcohol
Folder: Blood Content Alcohol
Requirements: none
Script: Blood_Alcohol_Content.py
Arguments: none
Contributor: soumik2012
Description: Want to know how much amount of alcohol you drank? Well, the Blood alcohol content program will help you find out the alcohol intake.

@antrikshmisri, please review my PR


Use self-hosted variable Inter

While there are currently some issues regarding the font, I'd suggest being a bit more forward looking and lean towards the variable Inter. Depends on brand guidelines explaining why we need more weights.

I think this is the case now after https://github.com/flathub/website/pull/952


pic_timing sei is not detected properly

We are looking for two timing information:

The VUI timing info (which is mainly found in the SPS). This is different from pic_struct (also in the VUI) which is currently checked by the script.
The PicTiming SEI. SEIs are conveyed as independent NALUs. If it can help, MP4Box -dxml dumps you the NALUs.

Thanks! The VUI timing info was detected (although its absence wasn't handled properly).
The pic_timing SEI presence was mistakenly linked to VUI pic_struct_present_flag = 1, not taking into account the other possible condition CpbDpbDelaysPresentFlag = 1. The script now just checks directly for the pic_timing SEI presence (as detected by ffmpeg).
Both issues should now be resolved with commit https://github.com/nicholas-fr/test-content-validation/commit/a8f64b3c9ff2855b8b8ef21c1ef7c4d97043ac94.

I confirm.


Use (Git) bash scripts for wrapping clang

This simplifies the Windows build experiences.
The entire windows folder can now be removed.

bors r+

Added block label to do more qualification

@anakrish I am just testing bors, don't mind me:
bors r+

bors r-

Oh! I know why that didn't work, it's not rebased on master. Nevermind, I'll spin up another test.

@andschwa I like the new "do not merge" tag.
I will let the CI settle down a bit with the Windows support before pushing this in.

bors try

@johnkord @andschwa Do you know why the following error happens only on one platform?
In scripts/clangw line 70:
    clang -target x86_64-pc-linux ${args[@]}

                                  ^-- SC2068: Double quote array expansions, otherwise they're like $* and break on spaces.

https://oe-jenkins.eastus.cloudapp.azure.com/blue/organizations/jenkins/Bors/detail/trying/747/pipeline

bors try

bors try

@johnkord @andschwa Do you know why the following error happens only on one platform?

Only answer I got for you is different ShellCheck versions.

bors try

@andschwa @johnkord @ionutbalutoiu @aserdean
Is there some way to properly fix the shell-check warnings?
After playing with it for couple of hours, I cannot come up with the correct way to do it so that shell-check is happy.

You can add an ignore like here.

@johnkord @andschwa Do you know why the following error happens only on one platform?

Only answer I got for you is different ShellCheck versions.

Yep, I took a look into this and that's the case. See my https://github.com/Microsoft/openenclave/issues/1526#issuecomment-469733696, and let me know if my suggestion sounds good to you in order to get the inconsistency solved.

@anakrish @ionutbalutoiu What's the status of this PR? Do we want to merge this? Should this be scheduled for 0.6?

@johnkord This is Windows build experience. Applicable for v0.6

@anakrish The CI should report consistent linter errors since https://github.com/Microsoft/openenclave/issues/1526 was fixed.
When you get the chance, you can rebase on top of latest master and have this ready to be merged.

From triage meeting: @anakrish Can you update us on this? Thanks!

@andschwa I will wait for Bruce/Mike's work to go in before working on this again.
Only @anitagov needs this and she can pull in the necessary changes from this branch onto hers if needed.

I cherry-picked these changes into my branch anitagov.libc.win and my issue with not being able to get all the tests to compile on Windows was indeed resolved. So, will take care of checking this into the master whenever possible.

Cool, I'll close this then.

We should probably keep this open until these changes get into master. Please do not delete the branch in any case.
This change does not work in Release mode but works in Debug mode. Need to debug this further.

bors try


[GitHub] branch and release design for triton?

Hi, team, I'm trying to understand the branch design and release procedure of triton. To be specific, I find that the main branch is in 2.1.0 now, while there is a branch called releases/2.2.x. Strangely, releases/2.2.x lags behind the main for about 100 commits.
If I would like to contribute, which branch should I work on in general?
Thanks!

You should work on the main branch.  I'm not sure where you're seeing 2.1.0
in main, but that's probably a mistake.
On Mon, Jan 15, 2024 at 8:55 PM youkaichao @.***> wrote:

Hi, team, I'm trying to understand the branch design and release procedure
of triton. To be specific, I find that the main branch is in 2.1.0 now,
while there is a branch called releases/2.2.x. Strangely, releases/2.2.x
lags behind the main for about 100 commits.
If I would like to contribute, which branch should I work on in general?
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/openai/triton/issues/2940, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEZBYNP5JV4ZVB7SLLNODYOYB35AVCNFSM6AAAAABB4FZREOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DGMBRHE2DGOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I see the release branch in https://github.com/openai/triton/pull/2892 . And I see the main branch version being 2.1.0 at:
https://github.com/openai/triton/blob/34e4288cb95b3fdf628560426e08b42fa563a4db/python/setup.py#L387


refactor: introduce new distribution to avoid the hack of hash of SERIAL

IIUC, the root cause of the problem is because of the improper way to hack the hash() function of Serial.
Currently, we did a hack here: if there is only one column and the column type is Serial, we will use extract_vnode_id_from_row_id instead of the standard hash function.
https://github.com/risingwavelabs/risingwave/blob/8a32a9b21b45c4d91f3235411d35a0a2b3f5102a/src/common/src/hash/consistent_hash/vnode.rs#L133-L168
I think the best solution is to use a special distribution, e.g. RowIdDistribution instead of HashDistribution. This essentially remove the hack and make everything clear.
cc. @st1page
Originally posted by @fuyufjh in https://github.com/risingwavelabs/risingwave/pull/18529#discussion_r1764437003

The problem is that, we still need to maintain compatibility with existing jobs and ensure consistent behavior. 😢 So I'm afraid the hack cannot be fully removed.


Link to https://tech.freckle.com/2021/05/18/haskell-on-actions/ in README

I came by this project via a Google search on how to cache correctly in stack CIs.  After browsing the repo, I wondered where to find more evidence that (and how) this works.
It would be great if you could link to some real-world CI scripts that use this action.
Already linking to https://tech.freckle.com/2021/05/18/haskell-on-actions/ (which found by more googling) from the README would be helpful.

Hi there! I'm always happen to add more context in our READMEs, but I'm not exactly sure what you're after. Could you maybe make a PR that adds something along the lines of what you're thinking?

Thanks for the quick response! See

https://github.com/freckle/stack-cache-action/pull/62


Added methods for creating 7 and 8 versions of UUID to the UuidFactor…

Added methods for creating 7 and 8 versions of UUID to the UuidFactoryInterface
Description
Added methods for creating 7 and 8 versions of UUID to the UuidFactoryInterface
Motivation and context
To work with the factory through the interface, you need methods for generating UUID, which are implemented in the factory.
How has this been tested?
This change does not require further testing. If the description of the methods in the interface is incorrect, tests using the implementation of the interface will fail.
Types of changes

[x] New feature (non-breaking change which adds functionality)

PR checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING.md document.
[ ] I have added tests to cover my changes.

Thanks! This wasn't an oversight. I didn't add them on purpose because releasing this as part of the 4.x series would be a major BC break (since we're adding to an interface).
This will have to wait until the next major version (5.x).

Ok, we will be waiting.

Hi all!
Hope you are well.
@ramsey, when approx 5 version will be released?


Update to Iris 1.1.1

Iris 1.1.1 is much more stable (also bundles sodium now, not sure if that is a problem)

also iris 1.1.1 is compatible with sodium extras, forgot to include


Intersnack - The company can be found on production when the name of the company is typed in the searching bar

Description : The company "Intersnack" can be found on https://peviitor.ro/ after the name of the company was typed in the searching bar.
Expected result : The website https://peviitor.ro/ is up and running

Step 1 : Open the homepage of the URL (https://peviitor.ro/)
Expected result : In the middle of the homepage is a searching bar

Step 2 : Verify if the searching bar is functional by clicking inside it.
Expected result : The text can be typed inside the searching bar

Step 3 : Type the name of the company "Intersnack"
Expected result : You can type the name of the company without problems.

Step 4 : After typing the company's name press ENTER or click on the button "CAUTA" next to the searching bar
Expected result : After entering the company is found and displayed alongside its jobs.


Invalid disparity values

ASP writes the integer correlation  (D_sub.tif and D.tif) as an image with three bands: x direction disparity, y direction disparity, and mask bit. Locations at which the disparity is invalid have their mask band set to zero. The x and y values at those points though may end up being set to strange values. This is not happening for the refined disparity, RD.tif, where the x and y values are explicitly set. It would be nice if this is cleaned up.  Note that this is not an actual bug as it won't affect the final results.

Hasn't been an issue in practice.


Should parse rebases too

I think @lodo1995 discovered that it is quite difficult to get the bug annotation for an already submitted PR. As far as I understand the problem was that rebases aren't parsed, is this correct @lodo1995?

@wilzbach  it's difficult to tell exactly why that PR ( dlang/phobos#4732 ) wasn't recognized.
The first time the message was surely wrong (it used "fixes" instead of "fix", which I think should be allowed).
I changed it a couple of times, and I didn't manage to make it work. The last version was "fix issue 16319 and [...]". Maybe the other things after the "and" fooled the regex (seems unlikely)?
So maybe the problem is really that rebases are not parsed.

So maybe the problem is really that rebases are not parsed.

When I look at the code, all relevant events "opened", "reopened", "synchronize" are processed:
https://github.com/MartinNowak/dlang-bot/blob/master/source/app.d#L66
and according to the API events:
https://developer.github.com/v3/activity/events/types/#pullrequestevent

Can be one of "assigned", "unassigned", "labeled", "unlabeled", "opened", "edited", "closed", or "reopened", or "synchronize".

so we synchronize should be triggered for both rebases and ammends :/
Moreover looking at the code, it seems the bot tries to try to parse all commits:
https://github.com/MartinNowak/dlang-bot/blob/master/source/app.d#L456
So it might be that it run into API restrictions there (due to some other PRs)?
There are a couple of PRs with a lot of commits - e.g. this one which get regularly rebases, but it seems like this one wasn't rebased today :/

We shouldn't change the regex or the matching, b/c that's the one used by GH's Bugzilla integration as well.
https://github.com/MartinNowak/dlang-bot/blob/7d2ae748c21a71517887481e30501f97af0a94f8/source/app.d#L93
Even fixes issue 16319 should have been recognized.
And yes, it parses all commit messages.
No we shouldn't exceed the authenticated rate limit of 3000 req/hour. It's also a single request to get all commit messages.
I'll debug this particular PR later today.


200 0ms

Hi everybody,
elapsed time for every request is always reported as "0ms". I dived in the boss code for a while and I found this code in file src/boss/boss_web_controller_handle_request.erl:
set_timer(Request, Url, Mode, AppInfo, TranslatorPid, RouterPid, ControllerList, RouterAdapter) ->
  NewAppInfo = AppInfo#boss_app_info{translator_pid = TranslatorPid, router_pid = RouterPid, controller_modules = ControllerList},
  %R = timer:tc(process_request,[NewAppInfo, Request, Mode, Url]),
  R = erlang:apply(?MODULE,process_request,[NewAppInfo, Request, Mode, Url, RouterAdapter]),
  {1,R}.

Recovering time information seems as easy as reactivating the call to timer:rc:
set_timer(Request, Url, Mode, AppInfo, TranslatorPid, RouterPid, ControllerList, RouterAdapter) ->
  NewAppInfo = AppInfo#boss_app_info{translator_pid = TranslatorPid, router_pid = RouterPid, controller_modules = ControllerList},
  timer:tc(?MODULE, process_request,[NewAppInfo, Request, Mode, Url, RouterAdapter]).

Am I wrong?
Regards.

Fixed in #560, thanks for your PR


Folder names should not end with dots

Folder names ending with dots are something we don’t usually see in the wild. I would rather not end folder names with dots 🙂

Try solving this issue by making a pull request to your own project! Follow this tutorial: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
Also, when you post that pull request, make sure to reference this issue. Read the following: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Much appreciated, I will follow the link and make use of it.


Type renaming is broken

Test case:
class Thing {
    public:
    bool compare(Thing &other);
};

Code generated by bindgen 1e26a8a0ef76656dc3567eb68a954a701fbb42c8:
#[repr(C)]
#[derive(Debug, Copy)]
pub struct Struct_Thing;
impl ::std::clone::Clone for Struct_Thing {
    fn clone(&self) -> Self { *self }
}
extern "C" {
    fn _ZN5Thing7compareERS_(this: *mut Thing, other: *mut Struct_Thing)
     -> bool;
}
impl Struct_Thing {
    #[inline]
    pub unsafe fn compare(&mut self, other: *mut Struct_Thing) -> bool {
        _ZN5Thing7compareERS_(&mut *self, other)
    }
}

… which fails to build with:
error[E0412]: type name `Thing` is undefined or not in scope
  --> <anon>:10:41
   |
10 |     fn _ZN5Thing7compareERS_(this: *mut Thing, other: *mut Struct_Thing)
   |                                         ^^^^^ undefined or not in scope
   |
   = help: no candidates by the name of `Thing` found in your project; maybe you misspelled the name or forgot to import an external crate?

Using --no-type-renaming works around the issue.
By the way, why is type renaming the default?

Yes, this is known, unfortunately (see https://github.com/servo/rust-bindgen/blob/master/src/parser.rs#L1021).
That's fixed in the rewrite, though.

This is no longer the case, though type renaming is not implemented in current bindgen (we could easily though).


WP CLI: Cancelling command in Windows displays error (but command is cancelled)

Description
When cancelling a running WP CLI command on Windows, the following error is displayed:
  ✕  Unexpected error: Please contact VIP Support with the following error:
  TypeError: Cannot read property 'setRawMode' of null
    at ReadStream.setRawMode (tty.js:66:28)
    at Interface._setRawMode (readline.js:251:16)
    at Interface.close (readline.js:376:10)
    at IOStream.commandStreams.stdoutStream.on (C:\Users\User\Desktop\cli\vip\dist\bin\vip-wp.js:305:20)
    at IOStream.emit (events.js:194:15)
    at endReadableNT (_stream_readable.js:1125:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

The command is still cancelled on the runner, but this is not clear to the user based on the terminal ouput

Related: #361

Could be related:
https://github.com/SBoudrias/Inquirer.js/issues/565
(The Enquirer package uses Inquirer 6.2.2)


Rebase alarm config feature branch from mainline updates

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.7 out of 8 committers have signed the CLA.:white_check_mark: toddtreece:white_check_mark: msshui-amzn:white_check_mark: hwandersman:white_check_mark: mukeshsahay:white_check_mark: jwills-jdubs:white_check_mark: sheilaXu:white_check_mark: ryantxu:x: taleenaYou have signed the CLA already but the status is still pending? Let us recheck it.


Bump version to <IP_ADDRESS>

Description

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
Changes:

Bump plugin version so <IP_ADDRESS>.
Bump OpenSearch core engine version to 3.0.0.
Fix the issues caused by the breaking changes that have already been introduced into OpenSearch 3.0.0.

Testing
ITs, BWC tests
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The BWC test is blocked: https://github.com/opensearch-project/OpenSearch/issues/3615

Codecov Report

Merging #1890 (1ad34e1) into main (8393c71) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main    #1890      +/-   ##
============================================
- Coverage     61.04%   60.99%   -0.05%
+ Complexity     3234     3232       -2
============================================
  Files           256      256
  Lines         18088    18087       -1
  Branches       3224     3224
============================================
- Hits          11041    11032       -9
- Misses         5467     5471       +4
- Partials       1580     1584       +4

Impacted Files
Coverage Δ

...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java
0.00% <0.00%> (ø)

...auth/http/saml/SamlFilesystemMetadataResolver.java
0.00% <0.00%> (ø)

...earch/security/auditlog/impl/AbstractAuditLog.java
73.75% <0.00%> (ø)

...ecurity/configuration/ConfigurationRepository.java
72.13% <0.00%> (ø)

...earch/security/dlic/rest/api/MigrateApiAction.java
4.16% <ø> (ø)

...a/org/opensearch/security/tools/SecurityAdmin.java
37.31% <ø> (ø)

.../opensearch/security/OpenSearchSecurityPlugin.java
79.67% <100.00%> (ø)

...ensearch/security/ssl/DefaultSecurityKeyStore.java
67.63% <100.00%> (ø)

...opensearch/security/ssl/util/SSLRequestHelper.java
64.70% <100.00%> (ø)

.../org/opensearch/security/support/PemKeyReader.java
76.76% <100.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8393c71...1ad34e1. Read the comment docs.


Getting deprecated option metadataUsedHelpers error

When building with the system building using babel:
	var builder = new Builder({
		baseURL: 'source',

		transpiler: 'babel',
	});

	builder.build('app.js', 'outfile.js').then(function() {
		console.log('Build complete');
		done();
	}).catch(function(err) {
		console.log('build error');
		console.log(err);
		done();
	});

I'm getting the error: Deprecated option metadataUsedHelpers: Not required anymore as this is enabled by default
Any ideas on what is causing this and how to get past it?

Appears to be related to the latest version of babel-core, v5.5.3. When I install v5.4.7 of babel-core, this error goes away.

Listed here (https://babeljs.io/blog/2015/03/31/5.0.0/#breaking-changes) as a breaking change.

Thanks, closing as a duplicate of https://github.com/jspm/jspm-cli/issues/809.

This is now just a logged warning and the build actually works. However, the builder should now have a change to longer use metadataUsedHelpers, right?

Yes exactly, the builder will be updated here.

I'm using<EMAIL_ADDRESS>and I'm still seeing this error.

@dmackerman how are you running the builder? Note that Babel is loaded as a module through SystemJS not Node, so the version that needs to be 5.8.19 is the version configured for SystemJS.

@guybedford running it through the jspm CLI tool. JSPM 0.15.6.

@dmackerman and you're 100% sure jspm inspect npm:babel-core comes up as 5.8.19?

Yep.
$ jspm inspect npm:babel-core

Installed versions of npm:babel-core

       babel 5.8.19 (^5.1.13)

@dmackerman if you can share a test case I can look into it.

I have the same issue with the following:
Installed versions of npm:babel-core
   babel 5.8.29 (^5.8.24)

Same here
Installed versions of npm:babel-core
babel 5.8.25 (^5.1.13)
jspm -v
0.15.7

Ah, thanks - fixed in https://github.com/systemjs/builder/commit/2ede3e99780f36590da16ace12aa89acf89ba21b. Apologies.

Thank you


Update ethereum-types to version 0.13.1

@nlordell @vkgnosis this looks good - can we merge & release?


feat(bundler-vite): re-export vite/client

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[x] New feature
[ ] Documentation update
[ ] Other

Description
close #1579

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.607%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
631

Relevant Lines:
1663

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.607%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
631

Relevant Lines:
1663

💛  - Coveralls


⚠ Bofrost.fr has degraded performance

In c325730, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1636 ms

Resolved: Bofrost.fr performance has improved in b42544c after 6 minutes.


can't use brass to cast weapons

You cant use molten brass to cast brass weapon parts
You can cast ingots and blocks though

Thanks for the report. I'll fix and push an update up shortly.


NetworkMagic magic range check for Handshakes isn't 32bit safe

On 32bit platforms 0xffffffff corresponds to -1, which caused the range
check for the network magic to fail.

See #1022

What's the appropriate behavior here. We do not support 32 bit clients at the moment, should we make some kind of dynamic check and if the machine is 32bit and the network magic is above the 32 bit Word32 max should we just crash?

We don't officially support 32bit archs, but we try to be nice to them.  I am not sure if things compile and run right now though.
We shouldn't do any dynamic check in this case, but error unconditionally - this is the only way to make sure that any network will support 32bit nodes. We should double check before if all the known network to us won't fail though. Advertising such a change in the NWG is a good idea.


Try to put the Wasmi engine internals into its own crate

The wasmi crate became very large over the recent years with all the added functionality and the new register-machine engine.
While compilation times are not yet an issue we might want to tackle this problem before it becomes one.
Compared with other crates in the Wasmi workspace the wasmi crate is by far the largest and it would be nice if we could split it up into more smaller crates.
As of today (2024-04-23) the wasmi crate has approx. 51k LoC without comments while its wasmi::engine submodule makes up 44k LoC of the total. It should be noted though that 21k LoC of those 44k LoC are pure test code to verify that the Wasm to Wasmi bytecode translation works correctly.
I am not yet sure if this is going to work out but what we could do is to carve out the entire wasmi::engine module and put it into its own crate. The wasmi crate would then depend on the new wasmi_engine crate and use it to drive execution just like the current wasmi crate uses its internal wasmi::engine submodule to do so.
This issue tracks progress of this work item and accumulates discussion and feasibility studies.
Problems
One problem is that for host function calls the Engine needs to be aware of the Store thus the Store or its internal implementation should reside in the Engine too. So what is ultimately left in the wasmi crate afterwards? Maybe we could move index types such as Func, Global etc. to yet some other crate and entity types such as MemoryEntity could reside in wasmi_engine or even yet another crate that wasmi_engine depends on.

This has been implemented in parts by #1152.

Closed due to the aforementioned comment. Furthermore, this issue is a bit too vague. We probably should be more concretely with respect to what we can, want or should phase out of the wasmi crate.


Job ttlSecondsAfterFinished is not working with Istio

Hi,
We are using Istio in our k8s cluster where we launch deployments and jobs. For jobs we need to use the k8s TTL Mechanism ttlSecondsAfterFinished. When we run jobs with Istio sidecar, the jobs are never clean up (Job and the pod associated are not unregistred automatically). If we run the same job without Istio sidecar the Job is unregistred successfully. We have communication between pods and jobs so
Affected product area
[X] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Jobs must be unregistered automatically
Steps to reproduce the bug
Launch job with Istio and ttlSecondsAfterFinished
kubectl apply -f job_with_istio_and_ttlSecondsAfterFinished.yml
# job_with_istio_and_ttlSecondsAfterFinished.yml
apiVersion: batch/v1
kind: Job
metadata:
  name: pi-with-ttl
spec:
  ttlSecondsAfterFinished: 0
  template:
    spec:
      containers:
      - name: pi
        image: perl
        command: ["perl",  "-Mbignum=bpi", "-wle", "print bpi(2000)"]
      restartPolicy: Never

Job and pod are not unregistered
If launch the same job without Istio the job and pod are unregistered
# job_without_istio_and_ttlSecondsAfterFinished.yml
apiVersion: batch/v1
kind: Job
metadata:
  name: pi-with-ttl
spec:
  template:
    metadata:
      annotations:
        sidecar.istio.io/inject: "false"
  ttlSecondsAfterFinished: 0
  template:
    spec:
      containers:
      - name: pi
        image: perl
        command: ["perl",  "-Mbignum=bpi", "-wle", "print bpi(2000)"]
      restartPolicy: Never

How was Istio installed?
Strict mutual TLS
Environment where bug was observed (cloud vendor, OS, etc)
KOPS AWS

So the problem is that the sidecar keeps running after the job shuts down right?
If so in the next release we are adding a way to shut down the sidecar from the running process so your job could kill the sidecar once it's done.
In the far distant future we will have more control over the lifecycle of the sidecar so this type of problem should be resolved

Not exactly. When the job is executed without Istio only one container is started (pi) and when it finish Kubernetes unregister the job so the pod is deleted.

Yes that is because the istio-proxy is running. In 1.3 which will be released soon you can have your job kill the istio-proxy when its done so both containers will stop

Duplicate of https://github.com/istio/istio/issues/11659 ?

Yes that is because the istio-proxy is running. In 1.3 which will be released soon you can have your job kill the istio-proxy when its done so both containers will stop

That would be nice.
We really need this feature available, when it's 1.3 planned to be released?
Bes regards.


Couple of missing features, 1.16 integration, and wiki pages

Some QOL features:

Converting int to string in constexpr
Allowing Entitys to be used in boolean conditions to check if they exist
A work around for the point above:

int exists = 0;
for (e in filter (e2 in Game.entities){
    e2.has_tag("tag");
}) {
    exists = 1;
}

if (exists) {
   // If true
}

Basic boolean keywords like true and false don't exist
A null or nullptr keyword for comparing Entitys to check if they exist
More ways to filter entity by nbt, name, position, scores, and teams
Support for 1.16 execute in and maybe a keyword as well
as keyword for execute as
Overworld, Nether, and End variables defined in Game, builtins, or somewhere else
A way to get a world by namespace id. eg. minecraft:end

I looked in the ir wiki page and I could not find any definition for forceload. You have other commands, but not forceload.
Wiki pages:

Add intrinsic_extension to the CBL syntax page
Add const to the CBL syntax page
Add a page for using the builtin types like World, Entity, and NBT

I also noticed that
https://github.com/simon816/Command-Block-Assembly/blob/b54c2afee3ea7bdfddfe619b9b207ce30d160e45/examples/carpet_on_stairs.c#L89
PikcupDelay is a typo.
I could be missing something, but using sender gives me an error saying that it doesn't exist.

Oh, and error messages show 0:0 as the coords every time

Oh, and error messages show 0:0 as the coords every time

Just realized that I can make a pr whoops

Just realized that I can make a pr whoops

Thanks for the suggestions :) I agree with most of these, I didn't want to introduce a null value, I created Maybe<T> to represent a value that may or may not exist.
intrinsic_extension is really just for internal usage (I hope that most things can be replaced with ir statements eventually).
Definitely need to improve error messages and reporting. Most errors are to guide me to iron out bugs in the compiler, rather than to point out errors in input code.
Regarding your StrVec2, it sounds like you've added overloaded constructors, which means the implicit "default constructor" is not created (consistent with C++: https://en.cppreference.com/w/cpp/language/default_constructor)
see:
https://github.com/simon816/Command-Block-Assembly/blob/b54c2afee3ea7bdfddfe619b9b207ce30d160e45/cbl/cbl_type.py#L219-L222
You'll either need to create a default constructor, or ensure StrVec2 is not default-constructed.
examples of where default construction can occur are:
void main() {
    StrVec2 foo; // default constructor
}

type MyType {
    StrVec2 foo;
    // implicitly defined default constructor for MyType calls the default constructor for type StrVec2
}

PRs are welcome, apologies that the code isn't well documented!

Thanks for the suggestions :) I agree with most of these, I didn't want to introduce a null value, I created Maybe<T> to represent a value that may or may not exist.
intrinsic_extension is really just for internal usage (I hope that most things can be replaced with ir statements eventually).
Definitely need to improve error messages and reporting. Most errors are to guide me to iron out bugs in the compiler, rather than to point out errors in input code.
Regarding your StrVec2, it sounds like you've added overloaded constructors, which means the implicit "default constructor" is not created (consistent with C++: https://en.cppreference.com/w/cpp/language/default_constructor)
see:
https://github.com/simon816/Command-Block-Assembly/blob/b54c2afee3ea7bdfddfe619b9b207ce30d160e45/cbl/cbl_type.py#L219-L222
You'll either need to create a default constructor, or ensure StrVec2 is not default-constructed.
examples of where default construction can occur are:
void main() {
    StrVec2 foo; // default constructor
}

type MyType {
    StrVec2 foo;
    // implicitly defined default constructor for MyType calls the default constructor for type StrVec2
}

PRs are welcome, apologies that the code isn't well documented!

Sorry for the late reply.
I really enjoyed looking through the code to add a couple of things. I was able to do forceload (kind of) as an ir instruction.
I think that with a little tweaking, this could be a very good tool. It already is. I think that CBL and c/asm need a little work by adding commands, but the ir just needs a couple of instructions like forceload.


Ability to change cdp datalake runtime version

Would be really useful if you can specify the cdp datalake runtime to deploy as opposed to always getting the latest.

Fixed by #3


Development Pipeline Slowing: Image Pipeline

Current Behavior
The local development pipeline (and production build time) are increasingly slowing, this hangs for sometime on the introduced Image pipeline work (which results in a 404 when viewing the website). This massively improves performance when the site is running, but the development experience and start up suffers.
Want to understand, is this slow because:

We have too many images?
We have too many big images?

Is there anything short term we can look at to improve this?
Raised by https://github.com/flowforge/website/issues/609 and https://github.com/flowforge/website/issues/621 referencing speed of recovery for the server.
Expected Behavior
Ideally, smooth happy fast times when it comes to developing locally and iterating.

@Pezmc you'll likely have the best insight here - any quick ideas?

On the development side I never understand why we care about large images. When we push the bot will fix it for us. So When I'm developing, leave me alone?

However, it should be caching the images, so after first build, each subsequent build should be significantly faster. It sounds like this isn't working? Or you're running the build from a clean directory with no caching each time.

I'm running same directory every time, and I know others in the team (cc @iskerrett and @Yndira-FlowForge ) are also hitting this issue a lot too.

I've just tested this locally and can confirm the caching is behaving as expected, even with all the Netlify changes.
First build (via npm run start) after an npm run clean took 57 seconds.
Killing the server, then re-running npm run start took 13 seconds (12 on a re-run).
However, Netlify appears to automatically open a browser to http://localhost:8080/ before 11ty has finished building, which is confusing, since the user sees a 404. 11ty hasn't finished the build yet, so I imagine that's most likely causing the confusion here.
I've been able to partially improve this by updating npm run start not to do a full clean:
First build (via npm run start) after an npm run clean took 54 seconds.
Killing the server, then re-running npm run start took 12 seconds (10 on a re-run).
However, of note, the page no longer 404's when the server builds, as the previous build of 11ty is still available.
The caveat, is that any page changes won't be reflected until the build completes, which could be more confusing
Alternatively, I can tweak the image pipeline not to run at all in dev, however, that means we're seeing different behaviour on prod/dev and I know there are quirks with the <picture> and <srcset> tags.

This is partially addressed in #683, let's evaluate in a couple of days how we're feeling.
Possible follow ups, as per that PR:

Disable image pipeline entirely locally (speeds up first cold build) - downside possible differences between dev and prod

Would need to ensure dev mode behaves as similarly to prod as possible.

@joepavitt @iskerrett @robmarcer How have you found working on the website for the last week. Has it been sped up to a more usable speed?

Thanks @Pezmc, I tend to do something else while I wait so I don't have any useful anecdotes.
As you said above, the issue I often see now is the dev site isn't actually available even when the terminal window suggests it should be. Now I know it's going to happen it's not that much of a problem, I just don't try for 30 seconds.

@robmarcer @Pezmc That indicates that flow state (https://www.medicalnewstoday.com/articles/flow-state#what-it-is) is interrupted, and it's likely still too slow?

As you said above, the issue I often see now is the dev site isn't actually available even when the terminal window suggests it should be

Yes, unfortunately I can't change the wording that Netlify gives us. Though since the changes above, the cache is never cleared, so the server is running and serving as soon as the prompt comes up just serving the old files:

 The important line is [11ty] Watching…, that's when 11ty, which builds the code, is actually ready.

@ZJvandeWeg Let's leave this issue open then for the follow ups in https://github.com/flowforge/website/issues/632#issuecomment-1524965843

I think I've found a trick to not build images locally, but still have the output appear the same, am experimenting in down time.


Add a link to the site to the Github README

I don't remember the link to the site so I checked the GitHub README but found it wasn't there. Might be a nice small addition.

Thanks! I've added it.


Update Go, dependencies and tools

Update Go 1.21
Update to k8s 1.29.1 and OCP release-4.16 module dependencies
Update Dockerfile to use CentOS / UBI 9 and new go install / update method
Update more module dependencies
Required code changes
Updated manifests

skipping draft in order to check if this works on all OCP versions asap

/lgtm

/hold
update CI base image first

/hold
update CI base image first

that was too late :D
so let's see how the rehearsals go here: https://github.com/openshift/release/pull/48052


Minor project and IWebSocketConnection changes

The OnError method seems to be missing from IWebSocketConnection, so I added it in.
Also, the "CommonAssemblyInfo.cs" file is missing after I clone the repo. I copied the AssemblyInfo.cs file from the hybi branch and put it in there.

I have pulled in the adding OnError commit. https://github.com/statianzo/Fleck/commit/e9b218ab154e23d411085890774eabeb86003307
The CommonAssemblyInfo.cs file is created when building from rake. I've modified the .csproj files to conditionally compile it if it exist. That allows for pulling down a clone and compiling without running rake first.
Thanks for the help.

Awesome, ok. Welcome. Thanks for the project, it's been helpful and the most stable WebSocket server example I could find between C# and Python.


.Net Framework 4.8.1 Build Fails

Description
Visual Studio build task fails for .Net Framework target 4.8.1
I've set the image to Windows-latest and VS 2022 as the version.
##[error]C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1220,5): Error MSB3644: The reference assemblies for .NETFramework,Version=v4.8.1 were not found. To resolve this
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions

Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Version: 20220816.1
Is it regression?
No
Expected behavior
Build Framework 4.8.1 projects.
Actual behavior
Fails
Repro steps

Create new .Net Framework Project
Configure Devops VS Build Step
Set Image: windows-latest
VisualStudioVersion="17.0"
Build fails with missing SDK

Hey @simonbaralos-codiance.
We will take a look at it.

Great, thank you 🙂

@simonbaralos-codiance, we are planning to finish new image deployment by next Wed-Thu.

The new Windows2022 image with .Net 4.8.1 has been deployed.


Prepopulate new saved snippets with content in the compose box

Following #31359, we have a new saved snippets feature, accessible via the "Send options" menu in the compose box, though we intend to move it elsewhere. It'd be a nice touch if, when you decide to create a new saved snippet, we prepopulated the "content" block with whatever you had in the compose box at the time.

@zulipbot claim


Update VERSION.md to trigger ci release

What type of PR is this?
(test)
Triggering CI release

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.54%. Comparing base (4e62629) to head (50e885e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   44.54%   44.54%
=======================================
  Files          63       63
  Lines        5296     5296
=======================================
  Hits         2359     2359
  Misses       2617     2617
  Partials      320      320

/lgtm


Bug 1908270 - Limit route prefix to 63 characters

https://github.com/konveyor/mig-operator/pull/547

https://github.com/konveyor/mig-operator/pull/547

I am closing this as discussed with Derek and Scott we are going to go with a simpler change for Release 1.4.0 and adding some additional validation with intention to make this more robust in a future release

I am closing this as discussed with Derek and Scott we are going to go with a simpler change for Release 1.4.0 and adding some additional validation with intention to make this more robust in a future release

I am closing this as discussed with Derek and Scott we are going to go with a simpler change for Release 1.4.0 and adding some additional validation with intention to make this more robust in a future release

I am closing this as discussed with Derek and Scott we are going to go with a simpler change for Release 1.4.0 and adding some additional validation with intention to make this more robust in a future release


Add relationships to neo4j

Example of result:

As we can see, there are no image representation of relationships + source and target should be in the vice versa order. Both changes are in frontend part


Elfinder settings must be contain only strings.

Now settings contain variables, that needed import.
# from os.path import join
# from elfinder.utils.accesscontrol import fs_standard_access
# from elfinder.volumes.filesystem import ElfinderVolumeLocalFileSystem

And if i`m want change them in settings.py you need import them.
And i`m get error if use import:
ImproperlyConfigured: The SECRET_KEY setting must not be empty.

Hi,
Maybe I am missing something about this "new" feature but I am getting an <<AttributeError: 'str' object has no attribute '_driver_id'>>.
I know this is quite an old app for django but I really love it and I'd like to know if I did something wrong.


How to test a JSONModel ?

I have a similar problem as this at : https://stackoverflow.com/questions/76578825/how-to-test-a-jsonmodel-in-a-unittest
How does one test a simple JsonModel without connection to a redis instance?

Hi @efratmiy - you can initialize and access a JsonModel without a Redis instance, if however you wanted to stub out the Redis bits you would need to explicitly add a Redis Mock to the Meta class within your model:
from redis_om import JsonModel

redis = # create your mock Redis connection bit here

class Customer(HashModel):
    first_name: str
    last_name: str
    age: int

    class Meta:
        database = redis

If it's me, IDK that that's the level I would be mocking at (I would go a level up and mock the service layer that's meant to be doing the simple CRUD operations to Redis. But that route is open to you


"Noise handshake failed" error after bundling with browserify

In the following code example, nodejs executes correctly with no errors thrown.
const SecretStream = require('@hyperswarm/secret-stream')

const a = new SecretStream(true)
a.on('error', err => console.error(err))

But when bundling this code with browserify, I encounter this error immediately after loading the webpage:
bundle.js:504 Error: Noise handshake failed
    at NoiseSecretStream._onhandshakert (bundle.js:836:33)
    at NoiseSecretStream._open (bundle.js:884:32)
    at ReadableState.updateNonPrimary (bundle.js:9055:14)
    at ReadableState.update (bundle.js:9032:69)
    at ReadableState.updateReadNT (bundle.js:9177:8)
(anonymous) @ bundle.js:504
emit @ bundle.js:154
afterDestroy @ bundle.js:9142
_destroy @ bundle.js:969
updateNonPrimary @ bundle.js:8887
update @ bundle.js:8872
afterOpen @ bundle.js:9199
_onhandshakert @ bundle.js:836
_open @ bundle.js:884
updateNonPrimary @ bundle.js:9055
update @ bundle.js:9032
updateReadNT @ bundle.js:9177

For some context, I discovered this issue while attempting to replicate a corestore (v6) between the browser and a websocket server. Before corestore-next made its way into the main corestore repo, I was able to do browser replication and could successfully pipe between corestores. But today, this issue prevents me from being able to do so. This leads me to believe the issue may have been introduced into @hyperswarm/secret-stream somewhat recently.

I have also found the same problem using a different approach .
Using node v16 I used package overrides in order to  force to use sodium-javascript
{
  "name": "test-corestore",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
  },
  "type": "module",
  "author": "",
  "license": "ISC",
  "overrides": {
    "noise-handshake": {
      "sodium-universal"<EMAIL_ADDRESS>    },
    "@hyperswarm/secret-stream": {
      "sodium-universal"<EMAIL_ADDRESS>    }
  },
  "dependencies": {
    "noise-handshake": "3.0.2",
    "@hyperswarm/secret-stream": "^6.2.0"
  }
}

and running the below Code in debug
import SecretStream from "@hyperswarm/secret-stream";

(async function () {
  const a1 = new SecretStream(true);
  const b1 = new SecretStream(false);

  // pipe the underlying rawstreams together
  a1.rawStream.pipe(b1.rawStream).pipe(a1.rawStream);

  a1.write(Buffer.from("hello encrypted!"));

  b1.on("data", function (data) {
    console.log(data); // <Buffer hello encrypted!>
  });
})();

I found that the issue was

TypeError [ERR_INVALID_ARG_TYPE]: The "size" argument must be of type number. Received undefined
    at Function.alloc (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/lib/buffer.js:366:3)
    at Object.alloc (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/b4a/index.js:10:17)
    at Object.generateKeyPair (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/noise-curve-ed/index.js:28:27)
    at NoiseState.send (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/noise-handshake/noise.js:187:52)
    at Handshake.send (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/@hyperswarm/secret-stream/lib/handshake.js:40:31)
    at NoiseSecretStream._open (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/@hyperswarm/secret-stream/index.js:390:63)
    at WritableState.updateNonPrimary (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/streamx/index.js:208:14)
    at WritableState.update (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/streamx/index.js:183:72)
    at WritableState.updateWriteNT (/Users/sce9sc/Documents/Work/test-mobile-corestore-pkg/node_modules/streamx/index.js:532:10)
    at processTicksAndRejections (node:internal/process/task_queues:78:11) {code: 'ERR_INVALID_ARG_TYPE', stack: 'TypeError [ERR_INVALID_ARG_TYPE]: The "size" …ons (node:internal/process/task_queues:78:11)', message: 'The "size" argument must be of type number. Received undefined', toString: ƒ, Symbol(kIsNodeError): true}

I traced it to handshake.js and I consoled log the error when
this.noise.send() was failing
  send () {
    try {
      const data = this.noise.send()
      const wrap = b4a.allocUnsafe(data.byteLength + 3)

      writeUint24le(data.byteLength, wrap)
      wrap.set(data, 3)

      return this._return(wrap)
    } catch (e) {
      console.log(e)
      this.destroy()
      return null
    }
  }

It seems that the problem is noise-curve-ed


Repo mirroring doesn't mirror LFS data.

Gitea version (or commit ref): 1.0.0+220-g027591a3
Git version:  2.11.0
Operating system: Ubuntu 16.04 (Docker)
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
In a clean install of Gitea I have attempted to mirror a Bitbucket server repository that I know has LFS enabled and stores LFS data. The LFS data appears to not being mirrored in Gitea. (The configured LFS data directory remains empty, even though the repository mirroring appears to be successful).

This is the same reason with #732. Let's close this and discuss there.

I'm afraid I have to disagree: #732 is not related. Gitea cannot currently retrieve LFS objects from another server. This would basically require adding a complete LFS client on top of the current implementation.
@damomurf: Please see GitHub documentation regarding repository mirroring with LFS

Seems you are right.

I'd suggest to tag this as a feature request. Current behaviour is basically expected imho and supporting LFS mirrors will be challenging in some regards:

Need LFS client implementation

CLI client not developed for interactive use
Reusing source would require rewriting to some extent

Using CLI client

Would use at least double the disk space for the LFS objects during mirror
Continuous mirror pulling would likely need double the disk space all the time

The operation will need to scan all files in every commit for LFS meta files, potentially taking very long for large repositories

Just out of interest, does somebody know whether GitHub support automated LFS object mirroring?
For future reference:
GitLab issue, git-lfs issue

Maybe put a notice on migrating UI at first.

I'll look into adding a note to the UI when LFS support is enabled.

What is steps for mirroring LFS now? Is there some hook to make LFS pull with cmd ?
Or may be I need to setup some cron task ?

@boskiv
You will currently have to manually mirror the repository if you wish to transfer the LFS objects, too.
It may or may not be (easily) possible to setup a custom mirror using cronjobs and shell scripts, but you would need to plan for double the disk space usage (permanently) and possibly use a separate local user account.
Please also see the GitHub docs for manual steps.

BTW, the GitHub docs is what currently Git LFS recommends as per https://github.com/git-lfs/git-lfs/issues/2342#issuecomment-310323647

@fabian-z Forgive me if I'm hijacking the issue, but could you explain your last comment in more details, in the context explained below?
I have a GitHub repo with files in Git LFS.
I'm looking for solution to have Gitea serve mirror that repo (just Git repo).
TL;TR: Is it possible?
Would something along these lines work?

Mirror GitHub repo with LFS
git clone --bare <GITHUB-URL> <GITHUB-DIR>
git lfs fetch origin --all
git push --mirror <GITEA-URL>
git lfs push --all <GITEA-URL>

Attach Gitea to serve the files pushed to <GITEA-URL>

Frequently run
cd <GITHUB-DIR>
git fetch origin --all
git lfs fetch origin --all
git push --all <GITEA-URL>
git lfs push --all <GITEA-URL>

Is there anyone kinda sorta working on it? Or is there anyone who figured out a way how to do this manually/scripted externally for the time being?
I'm using Gitea to keep backups of software I use or just find interesting, just in case... Obviously having the LFS objects as well is often very handy, many times necessary.

No one is working on this. A bounty on bountysource might spur someone to look at it.
From a quick glance we would need to implement an LFS client - possibly through vendoring git-lfs/git-lfs. There would need to be significant changes to the mirroring UI too.

Chipped in 70 bucks into the bounty: https://www.bountysource.com/issues/41700547-repo-mirroring-doesn-t-mirror-lfs-data

Is it rude for me to ask for a maintainer of the repo to add the bounty tag and maybe declare the bounty value in the title?
Cheers and overall many many thanks for this lovely project to everyone who is working on it. It's of great use to me. :)

@GlassedSilver thanks for your support :) I've just applied the bounty label to make this easier to find.

I've upgraded from 6af13dbac to 15d3aa7b95e37cc2e9a06208089169cbe04383b5, because I had this issue on the former version. Now the issue is gone and mirroring works.

I added to this bounty.
Feel free to add the following code to the Issue:
[![Bountysource](https://api.bountysource.com/badge/issue?issue_id=41700547)](https://www.bountysource.com/issues/41700547-feature-request-formatting-for-csv-diff)

I added to this bounty.
Feel free to add the following code to the Issue:
[![Bountysource](https://api.bountysource.com/badge/issue?issue_id=41700547)](https://www.bountysource.com/issues/41700547-feature-request-formatting-for-csv-diff)


Using SSL Certificates on each mail server

Hello all,
i was trying to use SSL certificates on my Postal installation and i see we need to set it up on the configuration file as said here: https://github.com/atech/postal/blob/master/config/postal.defaults.yml#L71-L81
I asumme that this option only allows to use a certificate for the whole installation and i was wondering whether there was a way to add a certificate for a single mail server, i.e. having multiple certificates and using them in the desired mail servers.
Thank you in advance.

All mail servers running from your Postal should use the same domain name which is probably the same address you use to log in to it.
Postal is not set up as a white-label solution that allows each mail server to have a separate domain name that accesses it.

Thanks for the info, well i would use the same installation of Postal with multiple services i manage and all of them have its own domain. i wanted to use its own certificates on each mail server or organisation.
Having said that, i understand your point and probably this is not the tool for my purpose. Correct me if i'm wrong please.
Thanks

If you want to send messages via SMTP and Postal, there can only be one domain.
If you were only intending to use the API, you might be able to get nginx to use different URLs and certificates but this hasn't been tested and isn't what Postal is designed for currently.

hmm forgive me for insisting but i think i didn't explain myself.
My goal is signing the mails i send via Postal. As i have multiple servers (each one with its own domain), i would need to sign mailings from each mail server (each domain) with the corresponding signature.
Regards.

Postal provides SPF and DKIM for emails but no ability to sign or encrypt messages. The certificates are used for connection purposes only.


Switch from bash to rust

This PR aims to switch from the bash script to a rust based approach. Currently, all functions available in sdbootutil are callable and have their designed parameters. A help page exists and is auto-generated.
However, the functions still lack the specific implementation, there currently is no testing framework in place and no github actions are used to e.g. build the source, test for warnings and execute tests.
Contributions are welcome :)
EDIT: Github Actions are added, will automatically build and run the specified tests
Basic tests are added

Implemented functions

[x] help
[ ] kernels
[ ] snapshots
[ ] entries
[ ] bootloader
[ ] add-kernel
[ ] all-all-kernels
[ ] mkinitrd
[ ] remove-kernel
[ ] remove-all-kernels
[ ] list-kernels
[ ] list-entries
[ ] list-snapshots
[ ] set-default-snaphsot
[ ] is-bootable
[ ] install
[ ] needs-update
[ ] update
[ ] force-update
[ ] update-predictions

Implemented functionality

[x] Basic UI
[ ] UI Main menu
[ ] UI Kernels menu
[ ] UI Entries menu
[ ] UI Snapshots menu
[ ] UI install/Update menu
[x] README with contribution instructions
[x] command line parsing

To use, install rust (e.g. rustup and run "rustup default stable") and run "cargo run" in the project directory. This will compile the source.

Interesting exercise for sure :) However, before rewriting sdbootutil in something else we need to reduce it's amount of code. For example the code that installs shim etc needs to be implemented in bootctl directly.
Adding kernels and initrd is done by kernel-install upstream. It needs some brainpower to come up with a way to integrate our use case with snapshots. Lennart proposed some instance handle in the pr linked here https://progress.opensuse.org/issues/127151

However, before rewriting sdbootutil in something else we need to reduce it's amount of code. For example the code that installs shim etc needs to be implemented in bootctl directly.

If you are not against the reformulation of sdbootutil in Rust, I would not condition it until what and how some features will be moved into the right components on systemd.  Both tasks has their own timeline and this PR is starting now.

Interesting exercise for sure :) However, before rewriting sdbootutil in something else we need to reduce it's amount of code. For example the code that installs shim etc needs to be implemented in bootctl directly.
Adding kernels and initrd is done by kernel-install upstream. It needs some brainpower to come up with a way to integrate our use case with snapshots. Lennart proposed some instance handle in the pr linked here https://progress.opensuse.org/issues/127151

Ah I see :)
However, personally, I'm not really a fan of waiting for something that's out of control of oneself. Sdbootutil seems to become more and more important (Aeon wants to switch to systemd-boot and yast supports it already), so it would be nice to have a framework that detects regressions etc. And when the upstream changes happen, we can also reduce the code in a rust based version. However, this is all just my opinion.
So would you say I should stop working on this pr as it doesn't have a chance anyway or should I continue working and when the changes upstream happen, we just reduce code here. :)

you can of course dedicate your time to whatever is fun to you. I started this tool with the idea that it will become obsolete though. Eg. the fancy gui was a nice gimmick and helpful to me in the beginning, not sure it's that useful anymore. To name another example when I started kernel-install was a shell script, now it's in C so that opens new possibilities that wait to be explored.
There is a lot of value in breaking down sdbootutil's features in smaller chunks like you did. I just wouldn't start with right away reimplementing that but rather review what's really needed in a tool of ours or instead needs to go elsewhere/upstream.

you can of course dedicate your time to whatever is fun to you. I started this tool with the idea that it will become obsolete though. Eg. the fancy gui was a nice gimmick and helpful to me in the beginning, not sure it's that useful anymore. To name another example when I started kernel-install was a shell script, now it's in C so that opens new possibilities that wait to be explored.
There is a lot of value in breaking down sdbootutil's features in smaller chunks like you did. I just wouldn't start with right away reimplementing that but rather review what's really needed in a tool of ours or instead needs to go elsewhere/upstream.

I see your point :)
However, I don't know if the components we deem to go upstream will go upstream anytime soon or at all.
Evaluating this, however, is of course useful. I could, for example, focus on the most important features we definitely need to get an MVP as soon as possible.
I agree, the UI is optional, however, I also see a use case for it. And as I'm trying to keep UI and logic apart, the overhead should also be minimal (and with cursive UI is quite straightforward).
I just wouldn't wait for changes to happen upstream, as we have a need for something better now and not in the future. Also, for me it looks like sdbootutil is currently still growing, not shrinking. And everything that's implemented in bash will need to be ported anyway, either upstream or to something else here.


🐞 - dialogs not working on iOS after upgrade from 3.46.0 to 3.51.0

Playground Link
No response
Description
I'm sorry I don't have time right now to provide a reproduction but after upgrading to last version (3.51.0) dialogs were not displayed on iOS (native platform) and downgrading to our current version (3.46.0) fixed the issue.
The overlay is displayed but dialog section is empty and there's no way to close the dialog.
Angular version
16.2.7
Taiga UI version
3.51.0
Which browsers have you used?

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[ ] Windows
[ ] Linux
[X] iOS
[ ] Android

Need provide a reproduction

It's probably this:
https://github.com/taiga-family/taiga-ui/issues/5732#issuecomment-1776928591


Browser bolt websocket address issue - Neo4J 4

Neo4j image tag being used : neo4j:latest (4.0.1)

The output of the docker version command
 Client:
   Version:           18.09.7
   API version:       1.39
   Go version:        go1.10.1
   Git commit:        2d0083d
   Built:             Fri Aug 16 14:20:06 2019
   OS/Arch:           linux/amd64
   Experimental:      false
 Server:
   Engine:
   Version:          18.09.7
   API version:      1.39 (minimum version 1.12)
   Go version:       go1.10.1
   Git commit:       2d0083d
   Built:            Wed Aug 14 19:41:23 2019
   OS/Arch:          linux/amd64
   Experimental:     false

Operating system: (for example Windows 95/Ubuntu 16.04)
Ubuntu 18.04

Steps to reproduce
Run a docker neo4j image and try top access from hostname from remote system. Basically anywhere except same system.

Expected behaviour
Go to browser and try to login. And login happens

Actual behaviour

In connect url instead of hostname now <IP_ADDRESS> comes by default
If we try to login, it does not work (obviously)
If we change <IP_ADDRESS> to hostname, it tries to login but from console log it seems callback it correcting hostname again to <IP_ADDRESS> and failing to connect due to obvious reasons (as its not running on remote systems local)

All of this works good till 3.5.15 image.
Additionally, include (as appropriate) log-files, stacktraces, and other debug output.

compose used
version: "3.2"
services:
neo4j:
image: neo4j
ports:
- 7474:7474
- 7687:7687
volumes:
- ${PWD}/data:/data
environment:
NEO4J_AUTH: neo4j/somepassword@123

Neo4j 4.0.4 has finally been released! It should your problem and I'm going to close the issue now. Thanks for your patience!


Missing colors on the newest version of VS 2022

Colors went missing after updating the VS 2022 to version 17.2.2.

Hi, I cant replicate the bug, I have tried on a fresh install and it works on 17.2.2 and on my personal install on 17.2.2 and works there to. You can try to reinstall the Vsix/extension again. or I have created a new version with all the missing themes if you want to try the new version 😃

Hi, thanks for the reply. I tried reinstalling the VS and the extension itself on two different computers, and still some colors are missing (I'm using it for C++). Before 17.2.2 everything worked super fine and I really enjoyed the colors.

Seems like it was a Visual Studio issue. New VS update fixed the bug.


Iter focused

This is basically the same as https://github.com/tomprogrammer/rust-ascii/pull/31, except with the impl ExactSizeIterator for Lines and associated tests removed. I'll add them in a future pr when I figure out how to implement them, but I don't think they're important enough to block everything else. I'll also modify the Lines iterator to use memchr in a future pr.

Thanks for the PR! It is very useful even without the optimizations that can be added later.


Improve systemd detection for pre-232 systemd

Older systemd versions (for example the Ubuntu 16.04 has systemd 229) have no direct method of determining if the process is run as a unit, since the $INVOCATION_ID envvar was introduced in systemd 232. To work around this limitation, I had to expand the SystemdHelpers.IsSystemdService() method to cover older versions. It still performs the check via the $INVOCATION_ID envvar, and then, if it's not present, follows up with checking the parent process command using the getppid(2) and access to the /proc/<pid>/comm file to check if the parent process is, in fact, an instance of systemd, along with doing some extra checks for user units via $MANAGERPID envvar.
This is a partial application of the tmds/Tmds.Systemd#43, mentioning @tmds as per his request.

@Tratcher @BrennanConroy can you review and merge for p8?

Thanks


Added Java 17 Compatibility to Android Project

in this Pr , i have fixed issue #55
Fixed Error
Execution failed for task ':nb_utils:compileDebugKotlin'.

'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.

Has this pull request been merged?


Clarify effect of scale_predictors on penalization in docstring

When using penalized regression, by default, H2o applies penalties to internally standardized features. This is convenient because users do not need to scale the input manually to ensure fair application of penalties.
How is it done with glum? It seems that features are internally scaled. Are penalties applied to standardized coefficients or to the original coefficients?

Whether penalties are applied to standardized features is governed by the scale_predictors argument, see here. To be precise, features are always standardized, but, in case that scale_predictors=False, the penalty is adjusted as if there was no standardization.

Oh, I see, thanks!
I am typically interested in getting unscaled coefficients in  coef_table(), and at the same time applying penalties to an (internally) scaled design matrix to ensure that all features are treated equally. If I got the docu of scale_predictors right, this combination is not easily available?

No problem!
The behavior that you describe should be the default, the coefficients are "unstandardized" again. You can also check this with an example:
import pandas as pd
import numpy as np

from glum import GeneralizedLinearRegressor

rng = np.random.default_rng(42)

X = pd.DataFrame({"x1": rng.normal(size=100), "x2": rng.normal(size=100)})
y = df["x1"] + df["x2"] + rng.normal(scale=0.1, size=100)
X["x2"] *= 100

GeneralizedLinearRegressor(alpha=0.1, scale_predictors=True).fit(X, y).coef_ # second coef is smaller by order of -2

what does "adjusted as if..." mean?

The standardization is also applied to the penalty matrix so that score equations are unchanged up to an affine transformation compared to no standardization (this is done for numerical stability). You can have a look at _standardize for the details if you are interested.

Fantastic, thanks a lot for the explanation and the example!

Should we mention in the docu of scale_predictors that the default (False) will scale the penalties, i.e., if one wants to penalize each feature equally, one would need to set scale_predictors=True?

Yes, I think this is worth mentioning, thanks for the input.

I adjusted the docstring, see https://github.com/Quantco/glum/pull/778. Can you have a look?


ack can get blocked by files

Initially this issue was reported here: https://bugs.launchpad.net/ubuntu/+source/ack-grep/+bug/1267948
It is still reproducible with ack 2.14 and I'm assuming that it just hit a file that waits for input. Maybe ack should check for such files and then skip them.

What does grep do in such a situation?

Grep does wait too.

If grep has the same problem, then I don't know that ack will be able to do any better.

If I'm not wrong telling the file position should always fail on such files without blocking. This could be used as a way to detect such files.

Just a little note: I have now also opened a ticket for this for grep on Launchpad: https://bugs.launchpad.net/ubuntu/+source/grep/+bug/1447216

Related: #214 #481

I don't think this needs to be fixed at all because it is no bug but just how Linux works. Grepping through whole /proc just doesn't make sense as all files in there are special and only have some file-ish properties.

/proc was just an example but such files can appear at any location. For example applications could use /tmp to store such files there (for example the text editor SciTE is doing this).

Thanks for the input.  I'm closing this as acceptable.