Console azure Fails on " az role assignment list-changelogs"

Describe the bug
use the console Azure to issue  az role assignment list-changelogs
To Reproduce
On console
az role assignment list-changelogs
Expected behavior
The change logs.
Environment summary
AZ console Azure
Additional context
the error:
eduardo@Azure:~/clouddrive$ az role assignment list-changelogs
'properties'
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 197, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 369, in execute
    six.reraise(*sys.exc_info())
  File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
    raise value
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 343, in execute
    result = cmd(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 182, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 436, in default_command_handler
    result = op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/role/custom.py", line 354, in list_role_assignment_change_logs
    payload = payload['properties']
KeyError: 'properties'

A few related issues have been fixed through the refactoring made for the multi-api support. I am no longer able to reproduce this issue, but if you do, please use --debug and send the trace to me at yugangw at microsoft dot com
I am closing this issue, while I have to apologize for not getting to this issue in time.

I had the same issue today.  I installed the latest Azure CLI but the issue was still there.  After installing the latest, the only difference was that it printed the message "To open an issue, please run: 'az feedback'"
I ran az feedback and it generated:
This is an autogenerated template. Please review and update as needed.
Describe the bug
Command Name
az role assignment list-changelogs
Errors:
:confused:

'properties'Traceback (most recent call last):
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\knack\knack\cli.py", line 206, in invoke
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\azure-cli-core\azure\cli\core\commands\__init__.py", line 326, in execute
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\azure-cli-core\azure\cli\core\commands\__init__.py", line 384, in _run_jobs_serially
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\azure-cli-core\azure\cli\core\commands\__init__.py", line 377, in _run_job
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\six\six.py", line 693, in reraise
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\azure-cli-core\azure\cli\core\commands\__init__.py", line 354, in _run_job
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\azure-cli-core\azure\cli\core\commands\__init__.py", line 145, in __call__
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\azure-cli-core\azure\cli\core\__init__.py", line 451, in default_command_handler
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-z6u9vbmn\azure-cli-role\azure\cli\command_modules\role\custom.py", line 300, in list_role_assignment_change_logs
KeyError: 'properties'

To Reproduce:
Steps to reproduce the behavior. Note: Command arguments have been redacted.

Fill in additional info here
Run: az role assignment list-changelogs --start-time {} --end-time {} --output {}

Expected Behavior
A clear and concise description of what you expected to happen.
Environment Summary
Windows-10-10.0.17763-SP0
Python 3.6.6
Shell: cmd.exe

azure-cli                         2.0.62

Additional Context
Add any other context about the problem here.


Added localization file nl-nl

Describe your changes:
Fixes n/a
Added a localization file for the Dutch language (nl-nl). The company I work for is a Dutch-spoken organization, so there was a need for Dutch labels, messages, etcetera. I translated all values in the JSON file.

Type of change:

[ ] Bug fix
[ ] Improvement
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

New feature

[x] The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion
or decision-making process is reflected in the issue.
[ ] I have updated the documentation.
[ ] I have added tests around the new logic.

hi @sandervanlaar thanks for the PR. We will review and merge it in

Thanks @sandervanlaar for the awesome contribution!!


Tests

We need tests, nightwatch is good.

Lots of cypress tests have now been implemented.
I think we have a sufficient amount to justify closing this issue.


(PartitionAssistantLite) Failing verifier

https://gist.github.com/choco-bot/4f08bd345168a44485b5e6ba47cf760f

Should be unlisted (see priorities).


disable interacting with private GitHub repos

Since all the services we interact with are open, we shouldn't be able to work with private GitHub repositories - the code might not be open source.
Also add new check to whitelist whether the repo is private or not.

Also add new check to whitelist whether the repo is private or not.

I don't understand how the check (whether a repo is private) relates to whitelist (of user accounts).

Whitelist check is performed before every packit action. Since the same applies to the private repo check it just seems like a reasonable option to implement it there.
On the other hand, I agree with you that they are not fully related to each other.


Improve integration with token color configuration

First, the extension now checks theme token color customizations as well as global token color customizations when determining what colors to highlight syntax with. Theme token color customizations take precedence over both global token color customizations and the theme token colors.
Second, a few additional token color customization keys used by other themes are added. The original paths still take precedence, but now turning on rust analyzer syntax highlighting should now not unexpectedly homogenize token colors when custom themes are used.

bors r+
Note that we'll be switching to upstream LSP syntax highlighting soon


Deleting database models deletes dataset from storage

[ ] Competitions
[ ] Submissions
[ ] Datasets in general

Merged.


1 vs n command processors?

In the Commander architecture diagram, there are many micro consumers, but only a single command processor (either one logical application with many instances scaled across partitions, or a single instance consuming all partitions. Is this understanding correct?
The benefits of a single command processor seem to be:

A linearisable history of commands, and the ability to process each command serially (similar to Datomic's transactor). I'm not sure how important this turns out to be in practice?
Each command only needs to be read once

The downsides are:

Failover and updating is more complicated
All commands are written in the same application, which means that different teams need to coordinate deployments/updates to the single command processor

The pros/cons of running several command processors are the inverse of this.
Is the single command processor a specific design decision in the commander pattern, or am I misreading the diagram?

Yes, the intent is to have a single command processor to handle all causally-related commands on a partition.  If commands aren't causally linked, they can go on a different topic/partition and be handled by a different command processor.


Local variable

Local variable stack

Class of local variable stack
Cooperate with Module class (no local section).

Merged to master with branch LocalStack


change ansible version to <IP_ADDRESS>

@kenthua this is related to some of this CI infra, lemme look into this quickly for you

@sherl0cks having problems pulling the bpm deployable binary in the travis test

@kenthua yea - that's the infra issue... working on it, but there are few other priorities we gotta work through first

Merging this and then fixing CI in later PR


Resync protobuf def

Resync our private protobuf def with the upstream one.
In the next time, please do not modify these proto files directly. Please update 'onnxruntime/core/protobuf/onnx.in.proto' instead.
And, if it's possible, please do not re-format  'onnxruntime/core/protobuf/onnx.in.proto'.  Please make your change as small as possible.

--- ../../../cmake/external/onnx/onnx/onnx.in.proto	2019-01-23 14:42:23.712936922 -0800
+++ onnx.in.proto	2019-02-01 13:50:19.950650414 -0800
@@ -227,6 +227,8 @@

   // The parameterized graph that is evaluated to execute the model.
   optional GraphProto graph = 7;
+  // kezhan: This field is not in ONNX, and will be pushed into ONNX with good use cases in microsoft.
+  repeated FunctionProto functions = 100;

   // Named metadata values; keys should be distinct.
   repeated StringStringEntryProto metadata_props = 14;
@@ -239,6 +241,14 @@
   optional string value= 2;
 };

+message QuantInfo {
+  optional string tensor_name = 1;
+  // The keys used in the mapping below will be pre-defined in ONNX spec.
+  // For example, for linear case, “SCALE”, “ZERO_POINT” will be pre-defined as
+  // quantization parameter keys.
+  repeated StringStringEntryProto quant_parameter_tensor_names = 2;
+};
+
 // Graphs
 //
 // A graph defines the computational logic of a model and is comprised of a parameterized
@@ -268,6 +278,12 @@
   // must be distinct. It is optional for a value to appear in value_info list.
   repeated ValueInfoProto value_info = 13;

+  // This field carries information to indicate the mapping among a tensor and its
+  // quantization parameter tensors. For example:
+  // A tensor “a” and its quantization parameter tensor are “scale_a” and
+  // “zero_point_a” (in linear case).
+  repeated QuantInfo quantization_annotation = 100;
+
   // DO NOT USE the following fields, they were deprecated from earlier versions.
   // repeated string input = 3;
   // repeated string output = 4;
@@ -536,3 +552,42 @@
   // This field MUST be present in this version of the IR.
   optional int64 version = 2;
 }
+
+// Operator/function status.
+enum OperatorStatus {
+    EXPERIMENTAL = 0;
+    STABLE = 1;
+}
+
+message FunctionProto {
+  // The name of the function, similar usage of op_type in OperatorProto.
+  optional string name = 1;
+
+  // The first version of a function set which contains this function.
+  // When there's any breaking change for this function, the function set
+  // contains the function needs to bump its version, and since_version of
+  // the updated function will be changed to the updated function set version.
+  optional int64 since_version = 2;
+
+  // This field indicates whether the syntax, semantics, or presence
+  // of this function is in an experimental or stable stage. Once an
+  // function is published as STABLE, its syntax and semantics MUST NOT
+  // change in subsequent versions of the operator set.
+  // When a function is published as EXPERIMENTAL, the syntax and semantics
+  // of the function MAY change across operator set versions.
+  // Functions "become" stable by deprecating the experimental version and
+  // introducing a new stable function with the same name.
+  optional OperatorStatus status = 3;
+
+  // The inputs and outputs of the function.
+  repeated string input = 4;
+  repeated string output = 5;
+
+  // The attributes of the function.
+  repeated string attribute= 6;
+
+  // The nodes in the function.
+  repeated NodeProto node = 7;
+  // A human-readable documentation for this function. Markdown is allowed.
+  optional string doc_string = 8;
+}

@snnn So you decided to bring in in.proto files as well. The reason we have our own protobuf definitions is bc we have some customization. Are those customizations reflected now in in.proto files? Presumably they are now going to be used to generate the actual customized proto files.

@snnn So you decided to bring in in.proto files as well. The reason we have our own protobuf definitions is bc we have some customization. Are those customizations reflected now in in.proto files? Presumably they are now going to be used to generate the actual customized proto files.

Yes. They are. I put the changes in this PR's comments.

Does this file also need to be updated as well?
https://github.com/Microsoft/onnxruntime/blob/master/csharp/test/Microsoft.ML.OnnxRuntime.Tests/OnnxMl.cs


Lots of errors when submitting to App Store

When trying to submit my app to the App Store, I'm getting a lot of errors coming from NEKit and his libs, it also say it's trying to use Mac architecture even if I build for iOS, and executed the command carthage update --no-use-binaries --platform ios at the very start
Log summary : https://pastebin.com/06VXHE0N

It has nothing to do with NEKit and everything to do with Carthage.
https://github.com/Carthage/Carthage/blob/master/README.md#if-youre-building-for-ios-tvos-or-watchos


made solution generator cross python

Description
I have fixed a problem: solution generator support python 3.6+ only. made tool cross python.
Changes proposed in this pull request:

python 3.6+ specific calls replaced with universal.

/intelci: run

/intelci: run


Unify normalize_tuple typing

Description
Unify normalize_tuple typing. See https://github.com/tensorflow/addons/blob/master/tensorflow_addons/utils/keras_utils.py#L83-L93.
Type of change

[ ] Bug fix
[ ] New Tutorial
[x] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[ ] By running Black + Flake8
[ ] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
Passes existing tests.

@thaink @mainak431 @ghosalsattam
You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.


Some Strings Got Cut in Tiles View

Explain the bug
While trying to create some Microsoft PowerPoint Presentation files in Tiles View, I noticed some string got cut instead of showing .... I'm not sure whether this issue is similar to #5376, however this issue is produced in tiles view and occurred in files' property.
To reproduce

Create a Microsoft PowerPoint Presentation Files in Tiles View
See the error

Expected behavior
Instead of showing the overflow string, try to shows .....
Screenshots

System Information

OS Version: Windows 10 21H1 19043.1110
App version: v<IP_ADDRESS>

Additional comment
Does this problem happen again after restarting the app? Yes

Could you confirm that this happens depending on Files window width? If you increase the width slightly does the "..." appear?

Ah I just realize that the "..." will appear if I minimize the app, however I can't see the dots when the screen is maximized (as default). Just to make sure that I have updated Files to v<IP_ADDRESS>.

Merging with #1033


pull request for e2e test at 11/26/2016 17:56:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Linter Release Template

This is a draft, I want the same thing as https://github.com/eslint/eslint/issues/17378

Before Release
Tested in

[x] two internal mega monorepos
[x] vscode
[x] node
[x] Affine
[x] Rspack

After Release

[x] smoke test the publish binary by running npx oxlint@latest . and verify its the latest release
[x] Publish release nodes in https://github.com/web-infra-dev/oxc/releases
[x] Tweet

TODO: make this into a template


Incoming unhandled RTP ssrc

I see this error pops up now and again:
pc ERROR: 2020/09/11 01:42:44 Incoming unhandled RTP ssrc(2854263694), OnTrack will not be fired. single media section has an explicit SSRC

Myabe rtx error which pion not supported，can find more info in sdp

This error it's from peerconnection and here, it's seems that pion expect that when it's only a single media in the SDP there must not be a explicit SSRC. I this error generated from a particular test?

it is generated intermittently, which makes me think it is a race condition

it is generated intermittently, which makes me think it is a race condition

This must be called only on SetRemoteDescription, since it's intermittently maybe is on negotiation, something mus be wrong with the generated SDP, maybe log the SDP when this error is fired can help.

I sometimes get this error on the client which i think might be related

here is an sdp diff of two clients to the sfu that received an offer when a 3rd joined:
https://www.diffchecker.com/esVPVDm0
you can see in the one of the left that there is a missing mid on line 127

This is very weird because the errors are not related, the SFU erros it's when the SDP just contain a single M-Line but with a a=ssrc tag, and your front end error is a clear missing of the token in the a=mid:xxx  tag, but it seems that pion will not check for that error.
So something is messing up the SDP... does yor front end is munging the SDP, maybe there is a bug in the parsing library??.

closing since i havent seen this in awhile. i think it was related to RTP arriving before negotiation is complete


How many farms should be allowed for the user to create per twin

currently, the dashboard and threefold connect app allow the user to create farms as many as he needs, but from another view only one farm can be used with the farmerbot as the farmerbot is using the owner's twin to do communication over the RMB. So the question is

should restrict the farm creation to one per twin?
or keep it as is and just document that somewhere that the twin used in the farmerbot should have only one farm?
or the farmerbot can handle more than one farm at the same time?

I believe the last option (third one) makes the most sense, as Twin AFAIK was meant to be a digital representation of a physical person.
So as long as it allowed to same person to have many farms, we should allow twin to have multiple farms, otherwise it will be inconvenient for farmers to maintain different keys for different twins.
Second option, IMO, would be unreasonable restriction and will lead to same inconvenient mentioned above if they want to use this tool.

@AhmedHanafy725 Is that resolved yet?

as per farmerbot's docs, it can take different farmId so the user can have more than one farm and deploy different farmerbot instances for each farm.


Update OpenMapTiles styles to the latest version fixes #901

Update version numbers of OpenMapTiles styles.
These styles are updated with the latest version (v3.15) of OpenMapTiles.
Fixes #901

does this change requires an image change in the selection menu?

does this change requires an image change in the selection menu?

No need to change images

You can ignore the FF tests.
Let me know if there's anything else you would like to change as part of this PR before I merge.

I have already added the tileset url change.
Right now, there is nothing more to add. Thank you so much.
It would also be good to add the OpenStreetMap style https://openmaptiles.org/styles/#osm-openmaptiles, but at the moment, it is only in https://cloud.maptiler.com/maps/openstreetmap/. For that, I will open another issue now. The MapTiler API key is necessary, and I have to see how to do it without putting hardcoded in the style.json.


Fixes 8264: add docs around adding taxonomy project id

Describe your changes:
Fixes #8264

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Can we add taxonomyProjectID in bigquery.yaml file

I have added the same, Thanks.


Correct -PolicyStore path example

The example shows forward slashes in the PolicyStore parameter, which does not work in the cmdlet. A backslash is required - this is also shown in the documentation for the parameter itself.

Docs Build status updates of commit d21f059:
:clock10: Pending: waiting for processors (16 builds ahead of you)
:warning: Docs Build is busy, currently there are 16 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit d21f059:
:clock10: Full build: the average full build time is 16 min(s) 55 sec(s), this is based on the last 21 build(s) for this repository.
:warning: This is a FULL build due to a recent Docs Build service upgrade, normally no action is required on your part. In the result you find subsequent builds still performing full builds, please contact your repository admin to manually perform a full build on the 'live' branch. For more detailed info, please click here.

Docs Build status updates of commit d21f059:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/netsecurity/Set-NetFirewallProfile.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Re-opening to refresh automated checks.

@rdbahm Please change the branch target to master as the time permits. Thank you for your patience with the process.

Docs Build status updates of commit d21f059:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/netsecurity/Set-NetFirewallProfile.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Hm, I switched the base branch, but it did some weird stuff with the other changes that happened since I made the commit. Is there a best way to make sure it doesn't try to do anything weird?

Docs Build status updates of commit 3f6ccef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/netsecurity/Set-NetFirewallProfile.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dariomws @get-itips @tseward
Peer review needed for this PR. Thanks.

Docs Build status updates of commit e0de778:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/netsecurity/Set-NetFirewallProfile.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


WIP: Add support for quiet level

On mne-python, we would like to have access to the --quiet-level parameter to suppress some messages.
This PR adds support for the quiet level.
It's still work in progress, I am not familiar with actions design and I need help to write useful tests.

The failures seem similar to those on master (f53408792b98a46c92075dfc0112858bc97be05d)

Hi @GuillaumeFavelier ,
The failure running against git master within the test was because we had some breaking changes which were released in Codespell 2.0. The other bats failures are seemingly something that slipped through the net with how we're simulating part of our Docker run, I think I'm getting there now.
You're certainly welcome to add this option to the action, there is also another option now Codespell 2.0 has been released, you can just put everything in a config file ( https://github.com/codespell-project/codespell/#using-a-config-file ), which might be a lot easier, it depends on your preferences. Although I appreciate you might want it quiet for your users and verbose for your CI or vice versa.

I've put this into draft as well for now @GuillaumeFavelier feel free to switch it back as appropriate, let me know if you need a hand with the BATS tests (once I've wrangled them into behaving again!).

@GuillaumeFavelier if you update then the existing tests should come good and you can see some working examples to copy/paste in test/test.bats to add a test for this.

I tried 8687724 but I have to admit, I still do not grasp exactly how it works

Sorry for the huge delay :pray:
I updated the branch and tried 19753a4 to "disable the bats diagnostics":
Testing / Diagnose bats are green but not Testing / Run tests though

Sorry for the huge delay :pray:

No worries @GuillaumeFavelier

I updated the branch and tried 19753a4 to "disable the bats diagnostics":

Sorry, I explained that really badly/not at all. I actually meant remove that line. Unfortunately #24 doesn't make it as simple as I'd hoped.

Testing / Diagnose bats are green but not Testing / Run tests though

I've now changed diagnose bats to mimic your test run (one of the things I hoped to be able to automate but it hasn't quite happened yet).
So the dummy bats diagnostics run, shows what bats will be trying to check:
https://github.com/codespell-project/actions-codespell/pull/22/checks?check_run_id=1889049192#step:5:28
Which as you can see returns 0 errors:
https://github.com/codespell-project/actions-codespell/pull/22/checks?check_run_id=1889049192#step:5:40
But in the bats test you're expecting errorCount=$QUIET_LEVEL_MISSPELLING_COUNT with QUIET_LEVEL_MISSPELLING_COUNT=1
https://github.com/codespell-project/actions-codespell/pull/22/files#diff-e98dd325e580e64931383363be3819d3e40938c4ad0fb8a868056d4c58aa80f8R88
So as per the previous comment you'll need to make those two match up for starters.

So as per the previous comment you'll need to make those two match up for starters.

Oh! Then what I want to test is not the number of errors but the number of warnings. Is there a way to do that? Or the opposite let's say turn warnings into errors?

So as per the previous comment you'll need to make those two match up for starters.

Oh! Then what I want to test is not the number of errors but the number of warnings. Is there a way to do that?

Probably not based on the count, but you could also do line matching as some of the other examples show.
If you had a warning sandwich:
ERROR
WARNING
ERROR

Then you could check the line contents of all three, and then disable the warning and check the two still matched maybe.
In theory you could just count all the lines returned, but as you'll see with the add/remove matcher lines that can get a bit complicated if we can't fake them up correctly.

Or the opposite let's say turn warnings into errors?

I'm not sure off-hand if there's a way to do that in Codespell currently, although maybe we should generally add one.


Add the first doctests on CI

This PR adds the first doctests on CI.

[x] add first doctest
[x] activate doctests on CI
[ ] ... add more doctests?  :thinking:
[ ] add doctests in other files?
[ ] automate "search" for doctests in all files (maybe in a later PR?)
[ ] ...

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.02%. Comparing base (076e9d8) to head (c00de51).

Files with missing lines
Patch %
Lines

src/calibrated_explanations/utils/helper.py
16.66%
5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   91.21%   91.02%   -0.20%
==========================================
  Files           9        9
  Lines        2823     2829       +6
==========================================
  Hits         2575     2575
- Misses        248      254       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow dropdown menu customization in profiles.json

We'll probably need a settings redesign that allows you to specify the contents of the menu instead of adding a new profile type.

original content
Summary of the new feature/enhancement
Allow MenuFlyoutSeparator to be programmed in profiles.json

Proposed technical implementation details (optional)
My thoughts are to have a flag that allows a "profile" in the profiles.json to be interpreted as a MenuFlyoutSeparator in App::_CreateNewTabFlyout()

We'll probably need a settings redesign that allows you to specify the contents of the menu instead of adding a new profile type.
I'm just gonna mark this as out of scope for 1.0. :smile:

(directly including the request from #2330 here cause it's a great idea)

Right now I have 5 profiles I use. I just played a bit with adding a ssh-profile and it works fine. But when I want to add all the profiles I have in Putty in WT I need to add another 20+ ssh-profiles. This means the list is going to be really long.
So being able to make submenus and put my profiles in a multiple submenus would be much welcomed.
Initially the menu looks like this:
PowerShell
CMD
WSL
SSH-Group1 >
SSH-Group2 >

When a submenu is selected, something like this
PowerShell
CMD
WSL
SSH-Group1 >
SSH-Group2 > +--------+
             | Host 1 |
             | Host 2 |
             | Host 3 |
             +--------+

I was just about to create a new ticket when I stumbled upon this one. I wish to add "mee too" on this - it's very important to a subgroup of the Terminal power-users - namely the administrators. Currently we are using MobaXTerm which does a wonderful job at storing 100s of distinct host entries (profiles) each with their own access and communication parameters. On MacOS we have a toolbar menu and on Linux simply a very large aliases file. In Terminal, I'd love to see this change:
Instead of doing like this:
"profiles":     [         {             "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee0}",             "hidden": false,             "name": "Company 1, Server X",             "commandline": "ssh<EMAIL_ADDRESS>        },         {             "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee1}",             "hidden": false,             "name": "Company 1, Server Y",             "commandline": "ssh<EMAIL_ADDRESS>        },         {             "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee2}",             "hidden": false,             "name": "Company 2, Server X",             "commandline": "ssh<EMAIL_ADDRESS>        },         {             "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee3}",             "hidden": false,             "name": "Company 2, Server Y",             "commandline": "ssh<EMAIL_ADDRESS>        },         {             "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee4}",             "hidden": false,             "name": "PowerShell 7 Preview",             "source": "Windows.Terminal.PowershellCore"         }     ],
I would rather like to do (something like) this:
   "profiles":     [         {             "folder": "Company 1",             "items": [                 {                     "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee0}",                     "hidden": false,                     "name": "Server X",                     "commandline": "ssh<EMAIL_ADDRESS>                },                 {                     "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee1}",                     "hidden": false,                     "name": "Server Y",                     "commandline": "ssh<EMAIL_ADDRESS>                }             ]         },         {             "folder": "Company 2",             "items": [                 {                     "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee2}",                     "hidden": false,                     "name": "Server X",                     "commandline": "ssh<EMAIL_ADDRESS>                },                 {                     "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee3}",                     "hidden": false,                     "name": "Server Y",                     "commandline": "ssh<EMAIL_ADDRESS>                }             ]         },         {             "guid": "{aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeee4}",             "hidden": false,             "name": "PowerShell 7 Preview",             "source": "Windows.Terminal.PowershellCore"         }     ],
Which would help very much in organizing and accessing a configuration with tens or hundreds of defined servers and several companies/categories of servers.

I would propose something like this
{
    "profiles": {
        "defaults": {},
        "list": [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "hidden": false
            },
            {
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "name": "Command Prompt",
                "commandline": "cmd.exe",
                "hidden": false
            },
            {
                "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
                "hidden": false,
                "name": "PowerShell",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "guid": "{58ad8b0c-3ef8-5f4d-bc6f-13e4c00f2530}",
                "hidden": false,
                "name": "Debian",
                "source": "Windows.Terminal.Wsl"
            },
            {
                "name": "Company Project 1",
                "hidden": false,
                "defaults": {
                    // Put settings here that you want to apply to all profiles in 'Company Project 1'.
                    // Proposal - inherit from parent "defaults"
                },
                "list": [
                    {
                        "guid": "{a3a2e83a-884a-5379-baa8-16f193a13b21}",
                        "hidden": false,
                        "name": "PowerShell 7 Preview",
                        "source": "Windows.Terminal.PowershellCore"
                    },
                    {
                        "commandline": "nu.exe",
                        "guid": "{2b372ca1-1ee2-403d-a839-6d63077ad871}",
                        "hidden": false,
                        "name": "Nu Shell",
                    },
                    {
                        "commandline": "elvish.exe",
                        "guid": "{6ddf0352-a8c2-46c3-9734-0034762b954c}",
                        "hidden": false,
                        "name": "Elvish"
                    }
                ]
            }
        ]
    }
}

By doing so each group/folder will pretty much be like "profiles" section containing defaults (which will be inherited hierarchically) and "list" of profiles.

Forked repo, implementing it in my fork

Partial (working) implementation exists in this branch. Branch is bit lagging from master.

I'll add another 'me too' for this one - and a twist... I'd like to be able to reference one or more external files for my 'profiles.list' section.  My need is similar to several examples above, but I'd like to be able to share 'customer' folders with other users without having to share out my entire configuration (and, since I have the information I need in a database already, I'd like to generate this JSON from there instead of having to edit it manually)

Hello there. I've been searching for the possibility to save my panes in a profile and ended up with the following:
{
    "command": {
        "action": "wt",
        "commandline": "wsl.exe ~ ; sp -H ssh<EMAIL_ADDRESS>mf up; sp -V wsl.exe ~ ; sp -V; mf down; sp -H; mf up; sp -V ssh<EMAIL_ADDRESS>mf down; sp -V; sp -V; sp -H"
    },
    "keys": "ctrl+shift+w",
    "name": "Work Layout"
}

There are nine panes in there which is quite complex, and even though this works fine as a shortcut, I still need to close the original tab since this opens a new one and there is no resizePane subcommand for wt.
I was wondering when we're going to be able to test the proposed profile structure in a preview build and if there's going to be a solution for programmatically resizing panes.
Thanks in advance, love your open-source work!

LOL I just found out that there's an argument for splitPane which resizes it.

I was wondering when we're going to be able to test the proposed profile structure in a preview build

Probably not for a long time. One of the key features we want is for people to be able to nest profile entries, but there's currently a bug in Xaml Islands that causes the whole application to crash when you use nested menuflyouts. (see #8238 for details) We'll need to move over to WinUI 3 to get the fix for that, which will take time and engineering effort that we're not prepared to commit to before polishing up and finishing 2.0.

I was wondering when we're going to be able to test the proposed profile structure in a preview build

Probably not for a long time. One of the key features we want is for people to be able to nest profile entries, but there's currently a bug in Xaml Islands that causes the whole application to crash when you use nested menuflyouts. (see #8238 for details) We'll need to move over to WinUI 3 to get the fix for that, which will take time and engineering effort that we're not prepared to commit to before polishing up and finishing 2.0.

Could this feature perhaps be MVP'd in a simpler way? For my personal use case I would already be mostly unblocked if I could change the single existing menu entry to not open my default profile since my default profile is my wsl distro and I would not want to use this on the windows filesystem. If we could set a default for terminal open and a separate default for the explorer context menu (powershell/powershell core) I think a lot of use cases are already covered.
Holding off on this until it can be fully implemented for power users with submenu's and the like would be a shame imo.

@zadjii-msft I got here from there! Because the first note in that issue links to this I was assuming that changing the context menu was depending on being able to configure the dropdown, and since this is on-hold due to some OS bug I thought the 'main' issue was also waiting on that bug. That's why I thought I would ask for a more MVP solution to the problem. But from your reaction I gather that it was the wrong assumption :)

Ah, yea, so the two are a little intertwined. There's a bit of architecture we want to do beneath both issues, which is described over at #6899 - Action IDs.md. I suppose #6899 is the common parent to both these features ☺

When this feature can be implemented? I am having 20+ profiles and list is continuously growing, I am desperately waiting a solution for this.
Thanks! Kevin

I'd love to get to work on this one, but unfortunately there are some higher priorities at the moment. We're in a bugfix push right now. After that I'm hoping to get back to tear out (#1256). Once that's made an appreciable level of progress then I'm planning on getting to #6899 and this. So it's pretty high up on the backlog, but still a few months away at least.
If someone in the community is interested in working on this sooner than that I can try and give them some pointers. Thinking about it more, all the non-actions bits of New Tab Menu Customization are probably doable without #6899. So that might be even easier to start with.

Is it possible to manually re-arrange the profiles by editing the JSON file? If so, I'm assuming Windows Terminal would need to be closed first in order to do so?

Is it possible to manually re-arrange the profiles by editing the JSON file? If so, I'm assuming Windows Terminal would need to be closed first in order to do so?

Yes, that's always been possible. You shouldn't need to close the Terminal either - that should hot-reload

As a follow up to my previous comment:

[ ] add enum for NewTabMenuEntryType
[ ] add deserialization for enum to TerminalSettingsSerializationHelpers
[ ] add winrt class for NewTabMenuEntry { NewTabMenuEntryType Type; }
[ ] class for ProfileEntry : NewTabMenuEntry { String Profile; } (.cpp, .h, .idl)
[ ] class for SeparatorEntry : NewTabMenuEntry (.cpp, .h, .idl)
[ ] class for FolderEntry : NewTabMenuEntry { IVector<NewTabMenuEntry> Entries; } (.cpp, .h, .idl)
You might be able to get away with all those classes being in one idl, but you'd probably want separate files for the h's and cpp's
[ ] cpp implementations for those Entry's

Not sure there's too much to do for those. WINRT_PROPERTY should likely take care of most of that

[ ] ConversionTrait's for entries (a la the one in ApplicationState.cpp)
[ ] a newTabMenu property in GlobalAppSettings of type IVector<NewTabMenuEntry>
[ ] Build the actual menu in TerminalPage::_CreateNewTabFlyout if that property is set (or fall back to the one we currently have if it isn't)

[ ] parsing the string names -> profiles might be the hardest part

That would be enough for an initial PR, I'd think

Ok I've been at this for a few days now, and I am not getting the simplest things to work and I'm out of ideas, so I would be very grateful if anyone could offer some help.
My problem is that after adding cpp/h/idl for SeparatorEntry, I am no longer able to link Microsoft.Terminal.Settings.Model (the .Lib builds and links fine). It gives this error:
Microsoft.Terminal.Settings.Model.Lib.lib(module.g.obj) : error LNK2019: unresolved external symbol "void * __cdecl winrt_make_Microsoft_Terminal_Settings_Model_SeparatorEntry(void)" (?winrt_make_Microsoft_Terminal_Settings_Model_SeparatorEntry@@YAPEAXXZ) referenced in function "void * __cdecl winrt_get_activation_factory(class std::basic_string_view<wchar_t,struct std::char_traits<wchar_t> > const &)" (?winrt_get_activation_factory@@YAPEAXAEBV?$basic_string_view@_WU?$char_traits@_W@std@@@std@@@Z)

I interpret this as meaning it did not find the factory for SeparatorEntry. However, the code is just there in the header file, it has the exact same style as all other factories for other idls, and I have no clue what goes wrong.
https://github.com/microsoft/terminal/commit/88a336b7cd88bfc2c7da5eac846c3d2f6250769a is the commit that breaks my build and I am out of ideas honestly.
Does anyone have any thoughts? Or is it better to discuss this issue separately from this thread?

@FWest98 I got chu. This was a copypasta error I make all the time:
diff --git a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj
index 80e0cb0ec..83f331876 100644
--- a/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj
+++ b/src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj
@@ -166,12 +166,12 @@
     <ClCompile Include="EnumMappings.cpp">
       <DependentUpon>EnumMappings.idl</DependentUpon>
     </ClCompile>
-    <ClInclude Include="NewTabMenuEntry.cpp">
+    <ClCompile Include="NewTabMenuEntry.cpp">
       <DependentUpon>NewTabMenuEntry.idl</DependentUpon>
-    </ClInclude>
-    <ClInclude Include="SeparatorEntry.cpp">
+    </ClCompile>
+    <ClCompile Include="SeparatorEntry.cpp">
       <DependentUpon>SeparatorEntry.idl</DependentUpon>
-    </ClInclude>
+    </ClCompile>
     <ClCompile Include="VsDevCmdGenerator.cpp" />
     <ClCompile Include="VsDevShellGenerator.cpp" />
     <ClCompile Include="VsSetupConfiguration.cpp" />

You had the c++'s marked as "Include" files, not "Compile" ones. I do that all the time when I'm hand-editing the vcxproj's (which I do exclusively).
That should get you unblocked 😉

This is so incredibly awesome. Thanks for all the hard work!

Is there a good document on how to create these new folders and move profiles into them? I was looking at the spec, but it was somewhat confusing to me, especially given that it referenced multiple approaches that weren't pursued. Can anyone point me at how to set up what was actually implemented?

In lieu of me writing something longer, try starting here:
    "newTabMenu": [
        { "type": "remainingProfiles" },
        {
            "type": "folder",
            "name": "WSLs",
            "entries": [
                {
                    "source": "Windows.Terminal.Wsl",
                    "type": "matchProfiles"
                },
            ]
        },
        {
            "type": "folder",
            "name": "misc",
            "entries": [
                { "type": "profile", "profile": "Ubuntu-18.04" },
                { "type": "profile", "profile": "Ubuntu-22.04" },
                { "type": "profile", "profile": "AlmaLinux-8" }
            ]
        },
        {
            "type": "folder",
            "name": "VS",
            "entries": [
                {
                    "source": "Windows.Terminal.VisualStudio",
                    "type": "matchProfiles"
                },
                { "type": "profile", "profile": "VS 2019 (CMD)" },
            ]
        },
        {
            "type": "folder",
            "name": "Canonical",
            "entries": [
                {
                    "source": "CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc",
                    "type": "matchProfiles"
                },
                {
                    "source": "CanonicalGroupLimited.Ubuntu22.04LTS_79rhkp1fndgsc",
                    "type": "matchProfiles"
                },
                {
                    "source": "CanonicalGroupLimited.Ubuntu_79rhkp1fndgsc",
                    "type": "matchProfiles"
                }
            ]
        },
    ],

Admittedly, you likely won't have all those profiles, but that should point you in the right direction


Fix small typo (distributes → distribute)

This learning path was a good read. Thanks for the docs!
💖

Glad you appreciated it, @yeskunall!
And thanks for the typo fix!


Enhanced Footer with Social Links ON README

📋 Description
The task involves enhancing the footer of the README with social media links for better community engagement and visibility. This enhancement aims to make it easier for contributors and users to connect via various social platforms related to the project.
🔨 Changes Made

Added social media links (LinkedIn, Email, Discord, GitHub) to the footer of the README.
Included icons for better visual appeal.
Added a thank you message for encouraging community interaction.

✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation (if applicable).
[x] My changes generate no new warnings.
[x] I have tested it locally and it works fine.
[x] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[ ] Bug fix (non-breaking change which fixes an issue) 🐛
[x] New feature (non-breaking change which adds functionality) ✨
[x] UI enhancement (non-breaking change which enhances UI) 🎨
[ ] Documentation update 📚

🤝 Related Issues

Fixes #295

📸 Screenshots (if applicable)

Reminder:
Please ensure your pull request is made to the test branch, not main.
Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!

@Vignesh025  the task has been completed.

Thankyou for Contributing!


=sbt Bump reactive-stream-version to 1.0.4

Motivation:
Upgrade reactive stream to the latest version
Result:
Up to date

I'm not against this but could you spell out the pros and cons? In the end, we are being conservative about what changes go into v1.0.0.

@pjfanning I'm trying to port my PRs to pekko. And I think this is fine as it's not changing any surface API.
Release note: https://github.com/reactive-streams/reactive-streams-jvm/blob/master/RELEASE-NOTES.md

So I just read the chaneglog and it seems nothing of significance has changed aside from TCK (technology confirmation kit) which seems to be some verification toolkit???
Pinging @raboof as well incase we miss something but otherwise change seems safe. I guess even if downstream users somehow resolve 1.0.3 it's not going to break anything (but then again if that's the case then there is an argument that we don't really need to bump it now in contrast to let's say Jackson and how problematic an old Jackson version had been)

Let me merge this as the API changes nothing.


Add get_mime_data(), set_mime_data() and supports_mime_type()  to cario surface

what should i use instead of to_glib_none() and ptr::null_mut(), since the CI fails because of them?

I think i fixed all indentation issues, but we really need rustfmt

what should i use instead of to_glib_none() and ptr::null_mut(), since the CI fails because of them?

The former is only available if cairo is built with glib support. You should use CStr / CString for strings, or where are the problems?
For ptr, that should work. How does it fail?

I didn't include ptr in surface, I guess cagro just got it from some where else. Anyhow it is fixed now. Also the CString thing.

@sdroege std::ptr is included already inside the gvalue_impl macro, but this is used only when glib is enabled. How should I import in surface.rs?

@sdroege std::ptr is included already inside the gvalue_impl macro, but this is used only when glib is enabled therefore the build fails if glib is disabled. How should I import in surface.rs?

Just add a use statement for it? :)

@sdroege std::ptr is included already inside the gvalue_impl macro, but this is used only when glib is enabled therefore the build fails if glib is disabled. How should I import in surface.rs?

Just add a use statement for it? :)

Rust doesn't like to include it twice. I now added an annotation to the use statement to include std::ptr only when glib is disabled.

Rust doesn't like to include it twice. I now added an annotation to the use statement to include std::ptr only when glib is disabled.

You could remove the use statement from the macro (and use it as ::std::ptr::...).

Rust doesn't like to include it twice. I now added an annotation to the use statement to include std::ptr only when glib is disabled.

You could remove the use statement from the macro (and use it as ::std::ptr::...).

i tried std::ptr before (which was wrong). let's hope now it works

Looks good to me, but you might want to add an unsafe getter for the data too that does not copy. In librsvg you can ensure that the data stays valid all the time, and could prevent expensive copies that way.

just a unsave function which returns option<&[u8]>? Any ideas how i should name it? I thought about get_mime_data_raw()

just a unsave function which returns option<&[u8]>? Any ideas how i should name it? I thought about get_mime_data_raw()

Sounds good to me

Seems good to me now

Thanks!


operation field must be ommitted

Unsure whether the documentation is aspirational or there's another bug, but attempting to update an item yields:
Warning: Unexpected input(s) 'operation', valid inputs are ['organization', 'project_number', 'content_id', 'field', 'value', 'github_token']

cc @benbalter

Thanks for this @peckjon. Based on your feedback, I believe this was resolved via https://github.com/github/update-project-action/blob/main/src/update-project.ts#L261-L271. I'm going to cut a new release soon. If this is still an issue, please feel free to reopen the PR, and I'll be glad to merge.


[BUG] Plenary: attempt to call field 'list_contains' (a nil value)

Existing Issues

[X] I have searched the existing issues

Describe the bug
When running :Compile or type :Compile  , this error shows up:
Error executing Lua callback: ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...lazy/compile-mode.nvim/lua/compile-mode/config/check.lua:146: attempt to call field 'list_contains' (a nil value) stack traceback:         [C]: in function 'error'         ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'         ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'step'         ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:48: in function 'execute'         ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:118: in function <...share/nvim/lazy/plenary.nvim/lu a/plenary/async/async.lua:117>
Steps To Reproduce
1. Setup compiler-mode.nvim config
2. Install with Lazy
3. Run `:Compile` or type `:Compile `

Expected Behavior
Complation buffer opens and output is shown
Neovim Version
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1692716794

Plugin Version
v5.3.0

Configuration
return {
	"ej-shafran/compile-mode.nvim",
	tag = "v5.3.0",
	dependencies = {
		"nvim-lua/plenary.nvim",
		{ "m00qek/baleia.nvim", tag = "v1.3.0" },
	},
	config = function()
		---@type CompileModeOpts
		vim.g.compile_mode = {
			buffer_name = "compilation",
			-- to add ANSI escape code support, add:
			baleia_setup = true,
		}
	end,
}

Additional Context
I run on Debian 12 Bookworm on WSL2.

Hmmm. Feel like this is probably an issue with the Neovim version. Will give this a look.

 Thinking I'll update the documentation to explain that the minimum supported version is v0.10.0, since I don't feel like reimplementing all of vim.uv and vim.iter on my own...


test: Adds an integration test for SDS

As part of this change, common xDS test functionality has been factored
out into the XdsIntegrationTest class, and both the SdsIntegrationTest
and RtdsIntegrationTest subclass XdsIntegrationTest.  Future xDS
integration tests should also subclass the XdsIntegrationTest to get the
common functionality and setup.
Signed-off-by: Ali Beyad<EMAIL_ADDRESS>

cc @alyssawilk


Change policy/v1beta1 to policy/v1 and remove PSP (from w33dw0r7d)

The Same as the #853 , to 'update the git branch' and make it mergeable.

Merged other RP


[LSP] Getting request timed

Expected behavior
Should not get errors while I am working on a gauge file.
Actual behavior
Getting error -
<-- error #254: textDocument/codeLens: {"code":0,"message":"Request timed out for Message with ID =\u003e 10405 and Type =\u003e StepPositionsRequest","data":null}
[Error - 8:57:43 AM] Request textDocument/codeLens failed.
  Message: Request timed out for Message with ID => 10405 and Type => StepPositionsRequest
  Code: 0

Steps to replicate

Project - LSP Tests
Edit gotodefinition. Line 34
Typing the following

    assert.ok((type=="error")? response==null:response!=null,"Expected response type "+type)

    if(type!="error"){
        verifyDefinitionResponse(response,details,done)
    }

Got the above error

Version
Gauge version: 0.9.8.nightly-2018-01-16
Commit Hash: bd76268

Plugins
-------
js (2.1.1.nightly-2018-01-16)

For Goto Definition test getting the following Request time out error with message
Error Message: Error: Unable to goto definition Error: Request timed out for Message with ID => 3 and Type => StepNameRequest
        Stacktrace:
        Error: Unable to goto definition Error: Request timed out for Message with ID => 3 and Type => StepNameRequest
            at Object.<anonymous> (tests/gotodefinition.js:38:15)

For PublishDiagnostics getting the following Request time out error with message
<-- notif: textDocument/publishDiagnostics: {"uri":"file:///c%3A/work/getgauge/ruby/basic/specs/example.spec","diagnostics":[{"range":{"start":{"line":11,"character":0},"end":{"line":11,"character":41}},"severity":1,"message":"Duplicate step implementation"},{"range":{"start":{"line":12,"character":0},"end":{"line":12,"character":34}},"severity":1,"message":"Request timed out for Message with ID =\u003e 51 and Type =\u003e StepValidateRequest"},{"range":{"start":{"line":19,"character":0},"end":{"line":19,"character":0}},"severity":1,"message":"Request timed out for Message with ID =\u003e 51 and Type =\u003e StepValidateRequest"},{"range":{"start":{"line":29,"character":0},"end":{"line":29,"character":0}},"severity":1,"message":"Duplicate step implementation"}]}

While Gauge is processing a request, it should not timeout if the language runner is alive and still processing the request.

Observation: Gauge does not timeout generating a report if the reporting plugin is alive and still processing the request.

Something similar should be done for language runner.

Machine configuration
Processor CPU @2.80GHz
RAM 16.0GB
Running LSP tests give
Refactoring failed due to errors: Cannot perform refactoring: Request timed out for Message with ID
=> 4 and Type => RefactorRequest

More details
11:36:33.636 --> request #0: initialize: {"processId":12668,"rootPath":"gauge-lsp-tests\\data\\refactor","rootUri":"file:///c%3A/work/getgauge/gauge-lsp-tests/data/refactor","capabilities":{"workspace":{"applyEdit":true,"didChangeConfiguration":{"dynamicRegistration":true},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":true},"executeCommand":{"dynamicRegistration":true}},"textDocument":{"synchronization":{"dynamicRegistration":true,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":true,"completionItem":{"snippetSupport":true,"commitCharactersSupport":true}},"hover":{"dynamicRegistration":true},"signatureHelp":{"dynamicRegistration":true},"definition":{"dynamicRegistration":true},"references":{"dynamicRegistration":true},"documentHighlight":{"dynamicRegistration":true},"documentSymbol":{"dynamicRegistration":true},"codeAction":{"dynamicRegistration":true},"codeLens":{"dynamicRegistration":true},"formatting":{"dynamicRegistration":true},"rangeFormatting":{"dynamicRegistration":true},"onTypeFormatting":{"dynamicRegistration":true},"rename":{"dynamicRegistration":true},"documentLink":{"dynamicRegistration":true}}},"trace":"off","experimental":{}}
11:36:33.637 <-- result #0: initialize: {"capabilities":{"textDocumentSync":1,"completionProvider":{"resolveProvider":true,"triggerCharacters":["*","* ","\"","\u003c",":",","]},"definitionProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentFormattingProvider":true,"renameProvider":true}}
11:36:33.638 --> notif: initialized: {}
11:36:33.638 <-- request #0: client/registerCapability: {"registrations":[{"id":"gauge-runner-didOpen","method":"textDocument/didOpen","registerOptions":{"documentSelector":{"scheme":"file","language":"javascript","pattern":"gauge-lsp-tests\\data\\refactor/**/*"}}},{"id":"gauge-runner-didClose","method":"textDocument/didClose","registerOptions":{"documentSelector":{"scheme":"file","language":"javascript","pattern":"gauge-lsp-tests\\data\\refactor/**/*"}}},{"id":"gauge-runner-didChange","method":"textDocument/didChange","registerOptions":{"documentSelector":{"scheme":"file","language":"javascript","pattern":"gauge-lsp-tests\\data\\refactor/**/*"},"syncKind":1}},{"id":"gauge-runner-codelens","method":"textDocument/codeLens","registerOptions":{"documentSelector":{"scheme":"file","language":"javascript","pattern":"gauge-lsp-tests\\data\\refactor/**/*"}}}]}
11:36:33.638 --> result #0: client/registerCapability: null
11:36:33.640 --> notif: textDocument/didOpen: {"textDocument":{"uri":"file:///c%3A/work/getgauge/gauge-lsp-tests/data/refactor/specs/example.spec","languageId":"markdown","version":1,"text":"Specification Heading\r\n=====================\r\n\r\nThis is an executable specification file. This file follows markdown syntax.\r\nEvery heading in this file denotes a scenario. Every bulleted point denotes a step.\r\n\r\nTo execute this specification, run\r\n\r\n    gauge specs\r\n\r\n\r\n* Vowels in English language are \"aeiou\".\r\n\r\nVowel counts in single word\r\n---------------------------\r\n\r\ntags: single word\r\n\r\n* The word \"gauge\" has \"3\" vowels.\r\n\r\nVowel counts in multiple word\r\n-----------------------------\r\n\r\nThis is the second scenario in this specification\r\n\r\nHere's a step that takes a table\r\n\r\n* Almost all words have vowels \r\n\r\n   |Word  |Vowel Count|\r\n   |------|-----------|\r\n   |Gauge |3          |\r\n   |Mingle|2          |\r\n   |Snap  |1          |\r\n   |GoCD  |1          |\r\n   |Rhythm|0          |\r\n"}}
11:36:33.643 --> request #1: textDocument/rename: {"textDocument":{"uri":"file:///c%3A/work/getgauge/gauge-lsp-tests/data/refactor/specs/example.spec"},"position":{"line":11,"character":13},"newName":"* Vowels in English language are \"aeiou\" \"something\""}
11:36:33.943 <-- notif: textDocument/publishDiagnostics: {"uri":"file:///c%3A/work/getgauge/gauge-lsp-tests/data/refactor/specs/example.spec","diagnostics":[]}
11:36:34.130 <-- notif: textDocument/publishDiagnostics: {"uri":"file:///c%3A/work/getgauge/gauge-lsp-tests/data/refactor/specs/example.spec","diagnostics":[]}
11:36:43.941 <-- notif: window/showMessage: {"type":1,"message":"Refactoring failed due to errors: Cannot perform refactoring: Request timed out for Message with ID =\u003e 4 and Type =\u003e RefactorRequest"}

@sguptatw

Observation: Gauge does not timeout generating a report if the reporting plugin is alive and still processing the request.

Gauge does timeout when a reporting plugin doesn't finish its processing within a given time (default is 4 mins).
Also, waiting on a request invoked by a user without a timeout may not be the best. It is better to tell the user that a request timed out and could not be performed properly.
If the request are timing out, we should be looking at improving the performance of the requests or the cause for these.

@nehashri
I would like to word my suggestion differently

Gauge can send a request to the runner to find if it is done processing. Requests sent to the runners are queued (assumption). But, request to find out if the runner has finished processing should be processed on priority.
Gauge should not timeout if the runner has not yet processed the request or needs more time to process the request.
Gauge does not get a response from the runner(runner could have died) then it can timeout.

Kindly let me know your thoughts.

On Travis with Machine configuration

The timeout issue is replicable - Refer stack trace https://travis-ci.org/getgauge/gauge-lsp-tests/builds/344155649

Steps to replicate on Mac

Project LSP Tests
gauge config runner_request_timeout 10000
gauge run specs

Note: It is timing out only for Find Usages test for the same reason mentioned in this issue -  StepPositionsRequest.

should be available with gauge nightly >= 16-4-18, gauge-js >= 13-4-18, gauge-ruby >= 16-4-18, gauge-python >=17-4-18


Vulnerability roundup 77: gnome-shell-3.34.1: 1 advisory

search, files

[ ] CVE-2019-3820 (nixos-unstable)

Scanned versions: nixos-unstable: c1966522d7d. May contain false positives.

This looks like a false positive, should be fixed by https://gitlab.gnome.org/GNOME/gnome-shell/commit/f0a7395b3006360905ccdc642982f9fc67378927 which is in 3.34.1 and 3.32.2.


current showing 0:00 all the time

the current duration does not gt update neither is the seekbar showing any update

which version are you on ?

I have this issue too,
currently I am using version : ^1.1.1+1

Same here. Using 1.1.1+1. It doesn't happen on all videos. I would say ~30% of them. Video duration appears as 0:00 and pressing play does nothing.

On Android, I was able to wait until the player was ready and then use controller.load() to get it to load. This does not work on IOS though. And the problem occurs on all videos.
I am using the player in a pop-up page that appears when the user presses a button.
Navigator.push(
      context,
      new MaterialPageRoute(builder: (context) {
        //create the page
        return new Scaffold(
          body: Container(
            color: Colors.black,
            alignment: Alignment.center,
            child: YoutubePlayer(
              context: context,
              videoId: YoutubePlayer.convertUrlToId(widget.movie.trailer),
              autoPlay: true,
              showVideoProgressIndicator: true,
              videoProgressIndicatorColor: Theme.of(context).primaryColor,
              progressColors: ProgressColors(
                playedColor: Theme.of(context).primaryColor,
                handleColor: Theme.of(context).primaryColor,
              ),
              onPlayerInitialized: (controller) async {
                //check if we need to reload video
                if(controller.value.duration.inSeconds == 0) {
                  print("Video not loaded.");
                  //wait for the video player to be ready
                  print("Waiting for ready...");
                  while (!controller.value.isReady) {
                    print("Not ready.");
                    //wait a bit before checking again
                    await Future.delayed(Duration(milliseconds: 500));
                  }
                  print("Player ready!");
                  //reload
                  print("Reloading...");
                  controller.load();
                }
              },
            ),
          ),
        );
      }),
    )

Same here

Same issue here. The process bar is not working for the same reason. The buffered part works just fine but the played part is always 0:00.

I think I found the problem. The microseconds increase by 1000 for one second. But one second equals to 10^6 second.

The issue is fixed with Version 1.2.0.
It was a silly mistake btw. 😜

Thank you for timely update. The package helps me a lot.
                            123248001

<EMAIL_ADDRESS>

    Signature is customized by Netease Mail Master

On 06/03/2019 22:20, Sarbagya Dhaubanjar wrote: The issue is fixed with Version 1.2.0.
It was a silly mistake btw. 😜
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/sarbagyastha/youtube_player_flutter/issues/17?email_source=notifications\u0026email_token=AK47XTJHMOZJVGWZSK24XGTPYXGOPA5CNFSM4HNU75MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW3GP6Q#issuecomment-498493434",
"url": "https://github.com/sarbagyastha/youtube_player_flutter/issues/17?email_source=notifications\u0026email_token=AK47XTJHMOZJVGWZSK24XGTPYXGOPA5CNFSM4HNU75MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW3GP6Q#issuecomment-498493434",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


Lists core jobs on Awaiting Installation section

We can uninstall core jobs with just clicking trash icon, but we are not able to restore uninstalled jobs. I think it can be fixed easily, but I can't understand why core jobs are excluded.

We don't generally list items that are in the core directory but not installed as available for installation. Those have to be manually installed.

OK, thanks.


⚠ AGEG website (prod) has degraded performance

In 4f44b9b, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2703 ms

Resolved: AGEG website (prod) performance has improved in 4e1e313.


Configuration info possibly incorrect?

The ConfigurationInfoFromModule seems to gather cellBagSorts just by looking for assoc attributes, without checking whether that bag sort is actually part of the configuration, while the rest of the compiler treats it as if it's the canonical bag generated to whether it's the canonical bag generated to implement multiplicitly="*' cells.  @andreistefanescu  @cos maybe you have some idea.
I think if a definition explicitly makes a bag of it's own things could break, but I haven't constructed examples.

We should eventually get rid of bag as a user-facing concept (replace by AC without uniqueness), so I think we should be fine for now.

This has nothing to do with any user-facing concept of Bags, this is a method compiler passes use to figure out what label to use to join copies of a multiplicity * cell.


Add purpose of baggage claim to the short description

eg: looses your luggage (volume manager for concourse)
Trying to find which parts are what is a bit difficult otherwise.

done!


5758: Remember context

BTW here is the spec failure:
  1) Sms::Decoder authentication with SMS Authentication enabled should lock account after 3 failed attempts
     Failure/Error: expect(error.type).to eq(options[:error])

       expected: "account_locked"
            got: "user_not_found"

       (compared using ==)
     # ./spec/models/sms/sms_decoder_spec.rb:631:in `assert_decoding_fail'
     # ./spec/models/sms/sms_decoder_spec.rb:27:in `block (4 levels) in <top (required)>'

Flapper?

Must be a flapper, since the PR build passed.


Emit ; in Range header when sorting without FirstID/LastID

Previously, this:
h.ReleaseList("myapp",
        &heroku.ListRange{Field: "version", Descending: true})

would generate the header:
Range: version .., order=desc

and yield an error:
{"id":"requested_range_not_satisfiable","message":"End range bounds without a start bound are currently not supported. Please specify a start bound. "}

With the fix, it generates:
Range: version ..; order=desc

which seems to be what the API expects.
Just started writing Go today, I bet there's a better way to structure the fix. Lemme know!

It's the right change but in the wrong place, I will push them to schematic.


PR: Don't request folding when rehighlighting the whole document

This avoids making a folding request per block for the entire document.
Fixes #10766.

@ccordoba12 Fixed, thanks. It now takes a couple seconds for just mainwindow.py on a 4 core 8 thread 2018 gaming laptop vs. instant (<100 ms) in other editors (e.g. Notepad++), but that's about what it was in Spyder 3 IIRC so its not really a regression.


bug(@vtmn/css): VtmnTabsItem active border not showing when focusing outside component

Describe the bug

On the VtmnTabs component, there is a border that shows the active tab. When we focus outside the component, the border disapears.
Steps to reproduce

Expected behavior

The behavior should be :

I click on the first tab of the VtmnTab
I click outside the component
The border to show the active tab should still be visible.

Browsers affected

Version affected

I go to https://decathlon.github.io/vitamin-web/@vtmn/showcase-react/?path=/docs/components-navigation-vtmntabs--overview
I click on the first tab of the VtmnTab
I click outside the component
The border to show the active tab should still be visible.

Hello @MaelthiS, thanks for reaching us.
The tabs component has been reworked lately.
I tested your behaviour and the active tab remains active even if I click outside of the component.
Be aware that only the demo showcase is accessible. The other ones are only visual or limited (because no javascript).
Can you confirm that this problem is resolved so that I can close this issue ?

Hello,
I close this issue in favor to the answer of @GaspardMathon.

Hello @MaelthiS, thanks for reaching us.
The tabs component has been reworked lately. I tested your behaviour and the active tab remains active even if I click outside of the component.
Be aware that only the demo showcase is accessible. The other ones are only visual or limited (because no javascript).
Can you confirm that this problem is resolved so that I can close this issue ?

@MaelthiS feel free to reopen it if this is still not ok for you.
Have a nice day :-)
Laurent

Hi @MaelthiS, all the demos in the CSS showcase are made with vanilla JS inserted inside a script tag: https://github.com/Decathlon/vitamin-web/blob/main/packages/showcases/css/stories/components/navigation/tabs/examples/demo.html

If I'm correct, shouldn't this fix be replicated to the Svelte, React, Vue packages ?

@thibault-mahe alright, we'll see if we can open a PR, otherwise we'll be forced to write our own component.


Comparable property pairs are order dependant

See:
https://github.com/gchq/Gaffer/blob/f54e069c27a61587e54f6406697ad9a4a726d88b/core/store/src/main/java/uk/gov/gchq/gaffer/store/operation/OperationChainValidator.java#L137
isAssignableFrom cast check only occurs in one direction for comparable pair.
i.e. first item in pair is checked if assignable from second
This means we have a comparison which throws an error depending on the order of properties in the pair.
Should it not be order independent? Or is the order dependent logic intentional?

isAssignableFrom cast check only occurs in one direction for comparable pair.

The "pair" object at this area of code IS NOT THE ELEMENTS BEING COMPARED.
see:
https://github.com/gchq/Gaffer/blob/f54e069c27a61587e54f6406697ad9a4a726d88b/core/store/src/main/java/uk/gov/gchq/gaffer/store/operation/OperationChainValidator.java#L129
The method getComparableGroupPropertyPairs ^ returns a pair, this is a (group, property) object.
pair.first() is the Schema element group of thing you want to compare.
pair.second() is the Schema property within that group you want to compare.
it seems Pair object was chosen in place of defining a POJO with field variables group and property
This pair isn't a "Pair of things to compare" it contains the LOCATION of the value within elements you want to compare.
example if the schema defined {"group" = "road", "property" = "milesLong"} for when you want to compare roads by length. In this example pair.first() will be "road" and pair.second() will be "milesLong".
Neither value in the pair object will be the milage of the road.
An example of this pairing being created is here:
https://github.com/gchq/Gaffer/blob/f54e069c27a61587e54f6406697ad9a4a726d88b/core/data/src/main/java/uk/gov/gchq/gaffer/data/element/comparison/ElementPropertyComparator.java#L120
if at
https://github.com/gchq/Gaffer/blob/f54e069c27a61587e54f6406697ad9a4a726d88b/core/store/src/main/java/uk/gov/gchq/gaffer/store/operation/OperationChainValidator.java#L137
the propertyClass retrieved from the schema which belongs to the property value in pair.second() is NOT COMPARABLE. then you have written a schema and defined a property which is not a comparable object, so you cannot compare it.
which would have been specified in the error message
validationResult.addError("Property " + pair.getSecond()
                                + " in group " + pair.getFirst()
                                + " has a java class of " + propertyClass.getName()
                                + " which does not extend Comparable.");

the order of properties in the pair.

The pair is a (group, property) object as defined above.
"There can only be one" :- Connor MacLeod

I'm going to close this ticket.
but if I have miss understood you please re-open and provide more details.
include the error message and group schema.

Thanks for clarifying. May have been some confusion due the method types and signature for  getComparableGroupPropertyPairs().
Following through the logic you are right - I don't believe this is a bug, happy to have this closed. Can't recall if there was any further context, this issue was reported a while back but was never investigated.


Refresh in the background?

Hello, I was working on a few projects and I was wondering if there was any way to run clear() and display() in the background? I was testing dofile and coroutine but if If I loop it, the script doesn't continue, it just stops when it's refreshing.
If there is any way to do this or do I have to find other ways?

Maybe run clear and display in coroutine or dofile?


Need help to interact with a contract

Hello, I've seen a lot of documentation, I think it's very good but unfortunately I still can't sign a transaction. I've come here in the hope that someone will be able to help me. I'll try to describe my problem as fully as possible.
archethic
  .connect()
  .then(async () => {

    const secretKey = Crypto.deriveAddress(userSeed, 0)
    const cipher = Crypto.aesEncrypt(secretKey, seed);

    const authorizedKeys = [
      {
        publicKey: seed,
        encryptedSecretKey: Crypto.ecEncrypt(secretKey, seed),
      },
    ];
    const originPrivateKey = Utils.originPrivateKey;

    const tx = archethic.transaction
      .new()
      .setType('transfer')
      .addUCOTransfer(poolAddressesUcoAeETH, Utils.toBigInt(1))
      .addOwnership(cipher, authorizedKeys)
      .build(seed,0)
      .originSign(originPrivateKey);

    tx.on('confirmation', (nbConf, maxConf) => console.log(nbConf, maxConf))
      .on('error', (_, err) => console.log(err))
      .on('timeout', (_) => console.log('timeout'))
      .send();
  })
  .catch((a) => {
    console.error(a);
  });

my userseed looks like this : "pirate bateau chimie .... "
my seed looks like this :  "0000FD163D0CAD7CF62A6239A037EDABC27AD8467AD2898F899A88C7F9B52D771792"
I know that this code is not at all correct, and that I don't understand all these different keys, if anyone can help me.

Hello, I see a few mixups here and there!
Fortunately @Rudy-Perrin made a recent pull request to simplify the ownerships.
You can see the code to do what you try to do (I think) here: https://github.com/archethic-foundation/libjs/pull/196/files#diff-cc63f119b1879db255abe3dbb493232f19c026790a1514a05a135ef618fdaa23R718
The function will ship in next version of libjs which is imminent I believe.
Your best course of action is either:

wait for new version and use the new function
copy paste the function and use it

Hello.
The ownership's mechanism is a way to delegate secrets to set of authorized public keys.
The secret is encrypted with a AES key, which is encrypted for a set of public keys.
Here some remark about this on your code
const authorizedKeys = [
      {
        publicKey: seed, // It should be the authorized public key and not the seed
        encryptedSecretKey: Crypto.ecEncrypt(secretKey, seed), // The second parameter of the function should be the authorized public key
      },
    ];

You can also note that:  const secretKey = Crypto.deriveAddress(userSeed, 0) this is not really secure, because the key can be disclosed if the address is known. You should rely on randomSecret generation.
But I don't see the contract's interaction you mentioned in your title ?

Thank you both for your replies.
@bchamagne I'll probably take the first option and wait, because I think I'm having trouble understanding the path from the secret key to the signing of the transaction.
@samuelmanzanera I'm trying to interact with the dex , with the aeETH/UCO pool , to create a swap
// UCO --> aeETH
const poolAddressesUcoAeETH =
  '000090C5AFCC97C2357E964E3DDF5BE9948477F7C1DE2C633CDFC95B202970AEA036';

to interact with the dex contract, is this the right way to do it? to send UCOs and receive aeETHs?
archethic.transaction
      .new()
      .setType('transfer')
      .addUCOTransfer(poolAddressesUcoAeETH, Utils.toBigInt(1))
      .addOwnership(cipher, authorizedKeys)
      .build(seed,0)
      .originSign(originPrivateKey)

I'd suggest to test on the testnet first ;)
To interact with the dex you don't need ownership, but you need to transfer funds AND call the named action. If you don't call the contract, you'll just transfer funds and loose them.
archethic.transaction
      .new()
      .setType('transfer')
      .addUCOTransfer(poolAddressesUcoAeETH, Utils.toBigInt(1))
      .addRecipient(poolAddressesUcoAeETH "swap", [minAmountToReceive]);
      .build(seed,0)
      .originSign(originPrivateKey)


Add Allure runner support

To get the results after the run, execute:
adb exec-out sh -c 'cd  /sdcard/googletest/test_outputfiles && tar cf - allure-results' | tar xvf - -C build/reports

Closing in favor of #1621.


Feature/#1799 full screen screenshots

fix for #1799, continuation of https://github.com/selenide/selenide/pull/1800

@rosolko I measured how slow the screenshooting is.
Generating 100 screenshoots took:

Chrome
Chrome headless
Firefox

Old good screenshots
30s
22s
15s

Full-screen screenshots
35s
27s
3min

In Chrome:

The full-screen screenshots are a bit slower, but the difference is minor.

In Firefox:

The full-screen screenshots are a much slower!

reworked in https://github.com/selenide/selenide/pull/1858
(extracted full-size screenshooting to a separate Selenide plugin).


feat: put cli on AUR

The binaries can now be easily installed on Arch Linux through the AUR. I tried to make a from source package, but the dependence on private repositories makes that impossible.

You would just need to register an account on the AUR, stick the below into your .goreleaser.yaml, and fill out maintainers, name, email, and private_key with the info from the registered account.
aurs:
  homepage: "https://nucleuscloud.com"
  description: "Nucleus CLI"
  maintainers:
  license: "Apache-2.0"
  git_url<EMAIL_ADDRESS>  package: |-
    # bin
    install -Dm755 "./nucleus" "${pkgdir}/usr/bin/nucleus"

    # license
    install -Dm644 "./LICENSE" "${pkgdir}/usr/share/licenses/nucleus/LICENSE"
  commit_author:
    name:
    email:
  private_key: '{{ .Env.AUR_KEY }}'


Grafana default password for admin

kube-prometheus
After run hack/cluster-monitoring/deploy
We should be able to reach Grafana on node port 30902
I am wondering what's the Grafana default password for admin user? Not able to login with admin/admin
thanks
-Eric

If you use kube-prometheus then did you try looking into the manifest that generates the secret grafana-credentials: https://github.com/coreos/prometheus-operator/blob/master/contrib/kube-prometheus/manifests/grafana/grafana-credentials.yaml ? (not tested that's just a guess)

according to this https://github.com/coreos/prometheus-operator/blob/master/contrib/kube-prometheus/manifests/grafana/grafana-credentials.yaml it looks like it's admin/admin (the manifest has the values base64 encoded)

@elisiano thanks for reply. Tried admin/admin, but failed.
Any way I can get the admin password?
I can use the following command
   kubectl get secret --namespace default my-release-grafana -o jsonpath="{.data.grafana-admin-password}" | base64 --decode ; echo
if I run "helm install --name my-grafana stable/grafana"
Any way I can get the admin password for this installation?
thanks

I'm not familiar with the chart installation method but if you used the deploy script without setting a NAMESPACE variable then it uses monitoring by default. Try looking up the secret in that namespace.
My experience is limited I'm not sure I can be of further help.
How are you trying to access grafana?
"it works for me" with kubectl proxy  and then accessing http://<IP_ADDRESS>:8001/api/v1/namespaces/monitoring/services/http:grafana:3000/proxy/ but you could also use port-forward instead of proxy

@elisiano Thanks.
Same issue with port-forward
seems the password should be "admin" as per the following:
scs@k8s-master:~/prometheus-operator/contrib/kube-prometheus$ kubectl get secret --namespace  monitoring grafana-credentials -o yaml
apiVersion: v1
data:
password: YWRtaW4=
user: YWRtaW4=
scs@k8s-master:~/prometheus-operator/contrib/kube-prometheus$ echo "YWRtaW4=" | base64 --decode
admin
Now, every time I login to http://<IP_ADDRESS>:30902/login, it reports the error:
Server side error :(
runtime error: index out of range
check the Grafana server logs for the detailed error message.

Are you using a non-standard port? Because with port-forward by default it's port 3000

I am encountering this problem as well.  Looking at the logs it appears the directory /grafana/data does not exist and the grafana does not have permission to add it.
I worked around it by creating a new emptyDir: {} volume and mounting it to /grafana/data in the container.  I don't know if this is the correct solution.  I'm experiment so I can afford to lose data if I make a mistake.

@ericzji could you past the grafana logs?
@mike-henders probably your issue is the same as https://github.com/coreos/prometheus-operator/issues/924 right?

@gianrubio Yes.  My issue looks the same as #924.

@gianrubio I am sorry but where I can get grafana logs? don't see it from /var/log/grafana/grafana.log
BTW, I am running as a non-root user

Also in my case, the kubelet are not up as shown from prometheus. (attached)

Use kubect logs -f -n monitoring grafana-pod-name

@ericzji This helped me resolve the kuebelet 403 issue you're seeing: https://github.com/kubernetes/kubernetes/issues/44330#issuecomment-293287575

Make sure your clusters actually follow the requirements on kubelet authorization and authentication. https://github.com/coreos/prometheus-operator/tree/master/contrib/kube-prometheus#prerequisites

As there doesn’t seem to be an issue with the Prometheus operator here I’m closing this.

According to the README from https://github.com/helm/charts/tree/master/stable/prometheus-operator#grafana, the default password is prom-operator. (The username is admin)

Now it is kubectl get secret grafana -o jsonpath="{.data.admin-password}" | base64 --decode ; echo

At most this is related to kube-prometheus and not the Prometheus Operator. I'm locking this conversation going forward.


Line breaks in attributes causing problems in pagination

Hey there.
I'm using Craft 4 and having a play with Sprig for the first time and soon ran into the following issue.
Given the code from the pagination example:
<button sprig s-val:page="{{ page + 1 }}" s-push-url="?page={{ page + 1 }}">
      Next
</button>

If the following markup is used:
<button class="someclass
anotherclass" sprig s-val:page="{{ page + 1 }}" s-push-url="?page={{ page + 1 }}">
      Next
</button>

...the pagination example will fail. There is no error, but the markup will not work.
Although it's not best practice to use line breaks in HTML attributes, it is not invalid HTML, and I would not have expected it to fail silently.
Anyway, I hope this is helpful in some way.

Thanks for reporting this, I'll look into releasing a fix.

Fixed in https://github.com/putyourlightson/craft-sprig-core/commit/9dfc817fb7637915b761187f8702fc271e91d0f1 and released in Sprig Core 2.0.6, composer update should update it for you. Thanks again!


Adds support for more than one destination in virtuals

Adds support for more than one destination in the virtual map.  This also will now remove entries that are not listed for a given map.
Big credit goes to @champain for the main logic with using the template :+1:

Any suggestions on this ?

I'm sorry I didn't look at this PR before. It's incompatible with the current code of the module and hasn't been updated for a long time, so I will close it for now.
Please reopen and rebase if you're still interested in getting this merged.


Add RS associated AS issuing Access Token

Once we merge #17 I'll rebase this one to only include relevant changes. This variant of sequence diagram introduces RS associated AS which issues an Access Token.

You can see alt block with two options

directly exchange ID Token for Access Token - this would match basic approach of current Solid-OIDC
exchange ID Token for chainable Ticket - this would allow pushing more claims before getting the Access Token
one of the claims would be Data Grant from Solid Application Interoperability providing resource client authorization granted by the requesting party

preview of the diagram in the latest commit:

The latest commits include updates to the text. It still misses describing the discovery of the Authorization Server and pushing OIDC ID Token as part of the Claim Token.
Latest diagram includes Client ID Document:


[Broker] Modify return result of NamespacesBase#internalGetPublishRate

Motivation
It should return null instead of RestException in method NamespacesBase#internalGetPublishRate, because null means that the publish-rate is not configured.
It is the same as internalGetSubscriptionDispatchRate as below:
https://github.com/apache/pulsar/blob/6d9d24d50db5418ddbb845d2c7a2be2b9ac72893/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java#L1303-L1308
Documentation

[x] no-need-doc

/pulsarbot run-failure-checks

@eolivelli @codelipenghui Would you help review this PR when you have a moment :)

/pulsarbot run-failure-checks

@codelipenghui Can you merge if no other problem :)


missing getTrialsOfType from jsPsych.data

Hey, I was working with the example from the jspsych tutorial and the received an error in the console mentioned that jsPsych.data doesn't have the method getTrialsOfType. I inspected it and couldn't find a comparable method within the object. Is there a suggested substitute?

also, an additional questions, is jQuery a requirement? I couldn't find it being called anywhere but it seems to be still suggested in the tutorial.

The master branch of GitHub is the development version. The docs at docs.jspsych.org refer to the last release, which is still v5.0.3. That's causing this mismatch between the tutorial and the website. The /docs folder in the repo is partially updated to reflect v6.0 changes, but there are still lots of updates to the docs that will occur before the official release.
For getTrialsofType the new way is to use the more generic and powerful filter method:
var all_single_stim_trials = jsPsych.data.get().filter({trial_type: 'single-stim'});
var the_array_of_data = all_single_stim_trials.values(); // need to call .values() now because the filter() method returns a DataCollection object.

jQuery is no longer required for v6.0.

awesome, that's great :) thanks!


refactor: use -chdir in terraform_validate wrapper

Use Terraform's -chdir option rather than cd

Docs generation is another place where I think the pushd / popd might not be needed and where the code might be simpler / more readable without it.

/gcbrun

updated the commit type to refactor, since it shouldn't change the behavior (ideally)

/gcbrun

Ok, and then bump the version in #2619 again after merge? Right now, they would both be at the same patch level.

Ok, and then bump the version in #2619 again after merge? Right now, they would both be at the same patch level.

Exactly, a bit of extra work, but I'd like to get this PR merged/released today.

/gcbrun


Feature Request: Make tray icon optional

I know that few people like it but it is useless to me and extremely annoying. Just sitting there doing nothing. Pointless.

Please check closed issues before raising new ones, this has been requested many times and rejected every single time.


Mask/box denoising hparams

What noise hyper-params are used in MaskDINO? Thanks!
Is there any noise added to "init anchors"?
what is "Unified denoising for mask" / "Unified DN" in figure 1? any special losses for this?
Does MaskDINO also use deformable attention? Both in encoder and in decoder?

Hi @FengLi-ust ,
Thanks for your wonderful works. In  the paper, Section 3.2, third paragraph, “It does not support mask refinement as the mask positional prediction from one layer cannot pass to the next layer.” Dose this mean that the masks are also refined layer-by-layer like boxes in MaskDINO? If it does, how to add masks that predicted by previous layer to current layer?


when nodename and appname are both given to list container, nodename is ignored

i thought this would be "listing containers on this node with this appname", but it's actually "listing containers with this appname, nodename? just ignore that" ...

filter by appname
then filter twice


[BUG] ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_initialization_params

CLIENT: Server listening on port 37099...
Received JSON data in run script
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.2, pluggy-1.3.0
rootdir: /home/v/swarms
plugins: anyio-3.7.1
collected 637 items
=============================== warnings summary ===============================
../.local/lib/python3.10/site-packages/PyPDF2/init.py:21
/home/v/.local/lib/python3.10/site-packages/PyPDF2/init.py:21: DeprecationWarning: PyPDF2 is deprecated. Please move to the pypdf library instead.
warnings.warn(
../.local/lib/python3.10/site-packages/wandb/env.py:16
/home/v/.local/lib/python3.10/site-packages/wandb/env.py:16: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
from distutils.util import strtobool
../.local/lib/python3.10/site-packages/timm/models/layers/init.py:49
/home/v/.local/lib/python3.10/site-packages/timm/models/layers/init.py:49: DeprecationWarning: Importing from timm.models.layers is deprecated, please import via timm.layers
warnings.warn(f"Importing from {name} is deprecated, please import via timm.layers", DeprecationWarning)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================= 3 warnings in 2.70s ==============================
ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_initialization_params[gpt2-small-100]
(no name '/home/v/swarms/tests/models/test_huggingface.py::test_llm_initialization_params[gpt2-small-100]' in any of [<Module tests/models/test_huggingface.py>])
ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_initialization_params[gpt2-medium-200]
(no name '/home/v/swarms/tests/models/test_huggingface.py::test_llm_initialization_params[gpt2-medium-200]' in any of [<Module tests/models/test_huggingface.py>])
ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_initialization_params[gpt2-large-None]
(no name '/home/v/swarms/tests/models/test_huggingface.py::test_llm_initialization_params[gpt2-large-None]' in any of [<Module tests/models/test_huggingface.py>])
ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_model_download_progress
(no name '/home/v/swarms/tests/models/test_huggingface.py::test_llm_model_download_progress' in any of [<Module tests/models/test_huggingface.py>])
ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_update_configuration
(no name '/home/v/swarms/tests/models/test_huggingface.py::test_llm_update_configuration' in any of [<Module tests/models/test_huggingface.py>])
ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_change_model_id
(no name '/home/v/swarms/tests/models/test_huggingface.py::test_llm_change_model_id' in any of [<Module tests/models/test_huggingface.py>])
ERROR: not found: /home/v/swarms/tests/models/test_huggingface.py::test_llm_force_download
(no name '/home/v/swarms/tests/models/test_huggingface.py::test_llm_force_download' in any of [<Module tests/models/test_huggingface.py>])
Finished running tests!

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

This can be closed.

This can be closed.


Will parse server support email verifications?

Will parse server support email confirmations/verifications that were supported by parse platform?

It already does. See the README https://github.com/ParsePlatform/parse-server#email-verification-and-password-reset

In my case it does not work. Can you please help me out. See the following link for more info.
http://stackoverflow.com/questions/39891896/parse-server-with-mailgun-adapter-how-can-i-get-verification-email-to-work


Rebrand to WARDEN-roboto and update dependencies

This will be release 1.6.0

Rebrand to WARDEN-roboto
Update to latest upstream attestation code

rollbackResistant -> rollbackResistance
Dependency Updates

Guava: 33.2.1-jre
autovalue: 1.11.0
protobuf-javalite: 4.27.0

i know stuff is working, but I'm tagging you @n0900  to double-check if I introduced any typos or missed sth