Query/Possible bug.

I planted some spruce cones about a week ago (minecraft week) and out of 20 trees i got a total of 16 spruce wood. Most of the trees dropped nothing whatsoever. I tried a tinkers mattock, broad axe and hatchet. I am yet to test it with vanilla tools.
Am I doing something wrong or have I encountered a bug?

Side note, when i did cut the trees down the snow that had settled on leaves/branches remained floating magically in the air.

Please test with vanilla axe and post the result here.  I'll look into the snow issue.

To get experimental results you can grow a single tree and copy it with the woodland staff.

Iron axe did the same thing.

I just tested spruce with vanilla tools and it works fine.  The snow doesn't hang either.  There might be another mod that's not playing nice.  A fully grown spruce tree in the open(not restricted by neighboring trees) will typically yield about 4-6 logs.  A tall skinny spruce in a forest(close to other trees) can yield about 2-3 logs.

this is my modlist. https://gist.github.com/Moobien/b3f75003022ad9024d5bb09e4dbf8768

I appreciate the information but it's not likely that I'm going to go through all of those mods looking for the issue.  If you want to lend me a hand and divide and conquer test..

Remove all mods except the dynamic trees mod.  Create a new world and test.(This tests if there's a mod interaction problem at all).  The new world makes sure you don't break your regular world.
Add half of the mods ("A*-N*" for instance). Test in aforementioned new world.
If the problem doesn't exist then the most recently added mods are safe, add half of the suspect mods not in use. Test again.
Otherwise if the problem does exists then it's in the most recently added mods, remove half of the most recently added mods currently in use.  Test again.
Repeat from step 3 until conflicting mod is discovered.

You have 153 mods so it should take fewer than 8 iterations to isolate the problem to the exact mod.

will do it in the morning, getting late here. for all I know I have done something wrong.

Did you find anything?

Closing issue due to unproductivity.

Sorry have been busy helping find bugs in EnderIO the last few days

According to your list you have the Tree Chopper mod installed. It's most likely why it's broken.


[Android] Fixed crash errors of shared mode

Fixed crash when initializing embedded mode by default
Fixed crash when launching XWalkCoreShell under lite mode
Support setUIClient and setResourceClient before Crosswalk runtime
is ready
Associate XWalkInitializer and XWalkUpdater to each single activity

BUG=XWALK-4072, XWALK-4388, XWALK-4503

@d0ngjun Please help to review

LGTM

@lincsoon okay to merge?

Yes, please


Update nameserver lookup test to use upstream targets

In the long term I don't think this test should be run as a unit test because it can randomly break due to changes in DNS config we don't control, which is a pretty poor user experience for someone trying to change unrelated code.
If we're going to run this kind of check, we should probably run it as a periodic rather than a presubmit, perhaps with the test being run on presubmit when the DNS util code is changed.
But that's all more work than I can really do now. Instead, I'll copy what the upstream go-lego is doing, which should unblock us for now:
https://github.com/go-acme/lego/blob/07c4daeff3c5d5e228b2490e002295716083a5fa/challenge/dns01/nameserver_test.go
Kind
/kind cleanup
Release Note
NONE

/cherry-pick release-1.12

/cherry-pick release-1.11

Thank you for fixing that!!
/lgtm

/cherry-pick release-1.12


Customize this android rom with a specific feature, is it possible ?

Hi,
I need to customize this Android ROM so it can have a specific requirement before installation !
As an example, when someone Flash the Android ROM into the phone, he will be asked to enter a password and to confirm it, then 10 PIN will be given for him and be written into a paper so if someday he forgot the password, he can recover it by using this PINs just like Google do it for Gmail.
And all this will occure while configuring the new installed ROM (When you enter an email for Google Play, and set Timezone etc.).
And the password can be stored so it can't be stolen by hacker ?
Is this possible please ? If yes, can you purpose me a path to follow in order to achieve this ? Of course I don't ask to make it etc. Just to give me a similar things already done in the past by someone else etc.
Big thanks in advance for your help !

10 PIN will be given for him and be written into a paper so if someday he forgot the password, he can recover it by using this PINs just like Google do it for Gmail.

This sounds more like the requirements of a company for their employee phones to me and would better be implemented outside of the OS using https://developers.google.com/android/work/overview.
Also, I don’t think such a feature is wanted for this project. The owner will have to take care of their password. No third party shall have "recovery keys". I am not aware of recovery keys being a thing for Android devices.
Closing as not fitting to the project.


footprint plot in plotxy does not work with beam instance

@srio The footprint plot on the optical element does not work with the 'beam' instance, only via file.
This fails:
Shadow.ShadowTools.plotxy(beam, 1, 2, nbins=101, nolost=2, title="Footprint", ref=0)
This works:
Shadow.ShadowTools.plotxy('mirr.01', 1, 2, nbins=101, nolost=2, title="Footprint", ref=0)
This means that one is obliged to write files to look at the footprint.
@lucarebuffi it would be nice to have a 'footprint plot' tab in ShadowOui.

In ShadowOui is already implemented. You must choose the option "Mirror" or "All", in the "File to Write Out" combo box in the "Output" tab of the "Advanced Settings", and a new Tab "Footprint" will appear in the plotting area.

Yes, this is one of the problems in python/shadow3. It does not export mirr.xx but only star.xx. At the beginning we thought this was OK, but then we see that mirr.xx is very useful. We will see, but it requires work in the python API, which I did not write :(
However, Luca already implemented the footprint plot I see he's answering this at this very the same time...

OK, now is clear to me. Thanks for the tip!


Egress node packet loops on multi-node k8s on vagrant

Bug report

General Information

Cilium version (run cilium version)

vagrant@k8s1:~/go/src/github.com/cilium/cilium$ cilium version
Client: 1.9.90 b447fded0 2021-03-10T16:14:30+01:00 go version go1.16 linux/amd64
Daemon: 1.9.90 b447fded0 2021-03-10T16:14:30+01:00 go version go1.16 linux/amd64

Kernel version (run uname -a)

vagrant@k8s1:~/go/src/github.com/cilium/cilium$ uname -a
Linux k8s1 4.9.258-0409258-generic #202102231505 SMP Tue Feb 23 15:08:14 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Orchestration system version in use (e.g. kubectl version, Mesos, ...)

vagrant@k8s1:~/go/src/github.com/cilium/cilium$ kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.1", GitCommit:"c4d752765b3bbac2237bf87cf0b1c2e307844666", GitTreeState:"clean", BuildDate:"2020-12-18T12:09:25Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.1", GitCommit:"c4d752765b3bbac2237bf87cf0b1c2e307844666", GitTreeState:"clean", BuildDate:"2020-12-18T12:00:47Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

Link to relevant artifacts (policies, deployments scripts, ...)

N/A

Generate and upload a system zip:

curl -sLO https://git.io/cilium-sysdump-latest.zip && python cilium-sysdump-latest.zip

I found that Egress node ICMP echo packet loops on multi-node k8s on vagrant based cluster. This problem is founded by tackling #12585.
This is complete sequence to build this env. I didn't apply any policy.
# start single-node k8s cluster
NWORKERS=0 K8S=1 ./contrib/vagrant/start.sh
# join k8s node to existing cluster
NWORKERS=1 K8S=1 ./contrib/vagrant/start.sh k8s2

After all node initialized, I executed to check connectivity. This is result.
Probe time:   2021-03-26T11:57:37Z
Nodes:
  k8s1 (localhost):
    Host connectivity to <IP_ADDRESS>:
      ICMP to stack:   OK, RTT=5.702674ms
      HTTP to agent:   OK, RTT=298.72µs
    Endpoint connectivity to <IP_ADDRESS>:
      ICMP to stack:   OK, RTT=5.738922ms
      HTTP to agent:   OK, RTT=387.656µs
  k8s2:
    Host connectivity to <IP_ADDRESS>:
      ICMP to stack:   OK, RTT=5.833157ms
      HTTP to agent:   OK, RTT=91.271µs
    Endpoint connectivity to <IP_ADDRESS>:
      ICMP to stack:   Connection timed out
      HTTP to agent:   Get "http://<IP_ADDRESS>:4240/hello": dial tcp <IP_ADDRESS>:4240: connect: no route to host

I wondered endpoint connectivity had downed, then to debug them, I tried to ping k8s2 from k8s1 with
ping <IP_ADDRESS> -c 1

And I got these results.
vagrant@k8s1:~/go/src/github.com/cilium/cilium$ ping <IP_ADDRESS> -c 1
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
From <IP_ADDRESS> icmp_seq=1 Time to live exceeded

--- <IP_ADDRESS> ping statistics ---
1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms

Sent ICMP packet consumed all TTL, so that I considered we have any loop. To check this, I executed tcpdump on k8s1 and got these result.
vagrant@k8s1:~/go/src/github.com/cilium/cilium$ sudo tcpdump -i cilium_vxlan icmp -vv -e
tcpdump: listening on cilium_vxlan, link-type EN10MB (Ethernet), capture size 262144 bytes
11:58:13.429624 7e:1a:f2:0a:3b:7b (oui Unknown) > 4e:4a:d0:7c:b0:73 (oui Unknown), ethertype IPv4 (0x0800), length 98: (tos 0x0, ttl 64, id 21097, offset 0, flags [DF], proto ICMP (1), length 84)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 24509, seq 1, length 64

Note that here is my ip link result (deleted non-related parts on cilium)
26: cilium_vxlan: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/ether 36:72:83:4d:78:53 brd ff:ff:ff:ff:ff:ff
29: cilium_net@cilium_host: <BROADCAST,MULTICAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
    link/ether 4e:4a:d0:7c:b0:73 brd ff:ff:ff:ff:ff:ff
30: cilium_host@cilium_net: <BROADCAST,MULTICAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
    link/ether 7e:1a:f2:0a:3b:7b brd ff:ff:ff:ff:ff:ff
32: lxc_health@if31: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
    link/ether 1a:e2:b6:a2:c2:67 brd ff:ff:ff:ff:ff:ff link-netns cilium-health

According to above logs, cilium_vxlan captured the ICMP packet from cilium_host to cilium_net.
After that, I captured same packet on cilium_net. This is the result.
vagrant@k8s1:~/go/src/github.com/cilium/cilium$ sudo tcpdump -i cilium_net icmp -vv -e
tcpdump: listening on cilium_net, link-type EN10MB (Ethernet), capture size 262144 bytes
11:16:17.977971 36:72:83:4d:78:53 (oui Unknown) > 7e:1a:f2:0a:3b:7b (oui Unknown), ethertype IPv4 (0x0800), length 98: (tos 0x0, ttl 63, id 17504, offset 0, flags [DF], proto ICMP (1), length 84)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP echo request, id 12025, seq 1, length 64

It seems that the captured ICMP packet is from cilium_vxlan to cilium_host. This result means the ICMP packet has been evolved cilium_host -> cilium_vxlan -> cilium_net loop.
This result is what cilium expected, or unexpected behavior?

Interesting. I think it's the same bug as https://github.com/cilium/cilium/issues/15402. I'm saying that because of:
  k8s2:
    Host connectivity to <IP_ADDRESS>:

It should be:
  k8s2:
    Host connectivity to <IP_ADDRESS>:

Could you try to restart Cilium on k8s2 and see if it solves the issue.

Interesting. I think it's the same bug as #15402. I'm saying that because of:
  k8s2:
    Host connectivity to <IP_ADDRESS>:

It should be:
  k8s2:
    Host connectivity to <IP_ADDRESS>:

Could you try to restart Cilium on k8s2 and see if it solves the issue.

@pchaigno It fixed with restarting k8s2. Thanks :+1:


Adding multisig types with tests on new verifier

This adds a new verifier which handles multi-sigs as discussed in #26. In this issue there are two approaches and this PR addresses the first approach.
Checklist:

[x] Add new MultiSig Types
[x] Implement Verifier Trait on new ThresholdMultiSignature type
[x] Add isolated Verifier tests
[ ] Add new Verifier to OuterVerifier in tuxedo-template-runtime

I sketched out an idea for how to ensure that no duplicate signatories exist at creation time. https://github.com/Off-Narrative-Labs/Tuxedo/pull/51 But the more I think about it, the more I like the way you handled it here. The only slight disadvantage is that a multisig with duplicate signatories will create a utxo that is forever stuck in state. But maybe this can be better solved by having some kind of cleanup transaction that allows anyone to remove an unspendable utxo for a reward.

I can build release with no issues and check and tests all pass is something weird going on with caching in the CI? If you look the code it is complaining about the missing outerverifier arm is already satisified.
https://github.com/Off-Narrative-Labs/Tuxedo/actions/runs/4473038238/jobs/7859921163?pr=50#step:6:435

Confirmed. cargo test, cargo check, and cargo +nightly clippy all pass locally for me as well. I've merged main into this branch to see if that helps. I don't see why it would, but worth checking. If CI caching slows us down, I'm very okay with getting rid of it.


4.2.2 does not allow updating to latest GoogleMaps (8.x)

Podfile dependency should be updated or relaxed to allow clients to move to the current major version of Google Maps SDK 8.x

If you would like to upvote the priority of this issue, please comment below or react on the original post above with :+1: so we can see what is popular when we triage.
@jotai-coder Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

Note, this was possible until 4.2.2

@wangela any update on this? I'm blocked due to this issue.
I'm using Xcode 14.3.0 and I installed GoogleMaps iOS SDK 8.3.1 with SPM.

Now since SPM is out for Google Maps and Google Places you could easily update your Package.swift and depende on one of the newest Google Maps versions.

This means users using the latest GoogleMaps are stuck on 4.1.0, which annoying overrides the EXCLUDED_ARCHS setting, meaning we have to manually clean up the setting every time we update. Please fix this, it's so simple!

I tried the branch but it didnt work for me

Here is the link to the Google Maps iOS SDK for Swift Package Manager:
https://github.com/googlemaps/ios-maps-sdk

@wangela This will become a blocking issue for shipping this SDK soon; as you noted in this comment the Google Maps SDK has privacy manifest instructions, but they state:

Important: These instructions for the Apple Privacy Manifest File apply only to the latest SDK version.

That means that only Google Maps 8.4.0 or later will be shippable once enforcement starts, which isn't compatible with the current ~> 7.3 requirement in this pod.

Is there any ETA on this library being updated @wangela ?
We're currently using v8.2.0 and have had an email warning about ensuring we update because that version defaults to the Open GL renderer rather than Metal but we currently aren't able to upgrade due to incompatibility with the utils library.

In the meanwhile you can use up to version 4.1.0 and it lets you use the last version of GoogleMaps.

@remarcoble Only if you also modify your Podfile to remove 4.1.0's EXCLUDED_ARCHS setting, which was quite annoying, otherwise you're limited to Intel-only builds.

@jshier how are you modifying your Podfile to remove the EXCLUDED_ARCHS setting? I've tried adding the following to my Podfile:
post_install do |installer|
  installer.pods_project.build_configurations.each do |config|
    config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = ""
  end
end

but the Google-Maps-iOS-Utils project in the Pods folder still has the EXCLUDED_ARCHS setting. The only solution I've found is manually opening (or writing a script) that opens the .xconfig folder and deletes the EXCLUDED_ARCHS setting and then everything builds just fine on my M2 Mac.

@Loubear111 You need to do it at a higher level to modify the xcconfig rather than the generated project file:
if config.base_configuration_reference.is_a? Xcodeproj::Project::Object::PBXFileReference
  xcconfig_path = config.base_configuration_reference.real_path
  open('xcconfig_mod', 'w') do |xcconfig_mod|
    File.open(xcconfig_path).each do |line|
      xcconfig_mod << line unless line =~ /EXCLUDED_ARCHS/
    end
  end
  File.rename('xcconfig_mod', xcconfig_path)
end

Thanks for that code @jshier. I was tinkering around with it quite a bit because it wasn't working but I realized it was because I was looping through the global config as opposed to looping through the targets in my post_install. For anyone looking for this in the future my post_install in my Podfile ended up looking like this:
post_install do |installer|
  installer.pods_project.targets.each do |target| # This is the line I forgot to include
    target.build_configurations.each do |config|
      if config.base_configuration_reference.is_a?(Xcodeproj::Project::Object::PBXFileReference)
        xcconfig_path = config.base_configuration_reference.real_path
        File.open('xcconfig_mod', 'w') do |xcconfig_mod|
          File.open(xcconfig_path).each do |line|
            xcconfig_mod << line unless line =~ /EXCLUDED_ARCHS/
            if line =~ /EXCLUDED_ARCHS/
              puts "Removing EXCLUDED_ARCHS for pod " + target.name
            end
          end
        end
        File.rename('xcconfig_mod', xcconfig_path)
      end
    end
  end
end

v5.0.0 was released for SPM yesterday and CocoaPods today. v6.0.0 was released for both SPM and CocoaPods today.
See the README for installation instructions.


Limitations on number of trees and the height of trees

I am looking at the benchmark suite. I feel there exists a big constraint for wide adoption: the number of trees must be one of the 10, 500, 1600, and the height of trees must be 6 or 8. Can we remove such constraints?

It is done now.

Great!


Avoid overwritting file in VS Code user snippet files.

I'm sitting on a case where I would like to copy a powershell.json VS Code file to the users VS Code snippets folder. But I risk overwritting a powershell.json file already there. As far as I can read in the VS Code documentation snippet files are global per user and not per workspace. Also I see no help here (https://code.visualstudio.com/docs/editor/userdefinedsnippets).
In the Plaster documentation https://github.com/PowerShell/Plaster/blob/master/docs/en-US/about_Plaster_CreatingAManifest.help.md#content-element-modify one can read about the modify element. But, as far as I can conclude that doesn't fit this scenario. Anyone with a good idea :-) ?
For good measure I had a look in the VS Code Github repo. Found this --> https://github.com/Microsoft/vscode/issues/8102 <-- however that leaves me/us with a need for a directive that can control if a specific extension is installed or not. Or alternatively we can go down the less intelligent road of just messaging the user via Plaster "message", to tell them that they should install the "Project snippets" extension in order for this to work.
What do you say? Thank you very much.

You can add (or modify an existing) .vscode\extensions.json file that contains "recommended" extensions for the project.  But I would still probably add a message to indicate that they run the VSCode command Extensions; Show Recommended Extensions.
Whatever else we might do we would need to consider the case where the user just invokes the template from the console (or maybe even another editor).

@rkeithhill yeah found the documentation on it (here it is, for forthcoming peeping eyes: https://code.visualstudio.com/docs/editor/extension-gallery). Great idea. On the same VS Code documentation page I can also read that it is possible to execute the following cmdline: code --list-extensions <-- which makes me think that one could parse the output of that and confirm if "x" extension is installed or not. If it isn't then do  code --install-extension "NAME OF EXTENSION TO INSTALL".....now, is that something that is within the scope of what Plaster tries to help us with?
Thank you.

@rkeithhill the suggestion I gave in the above, could that be a plausible solution?


error on send text message

Describe the bug
await self._driver.chats[message.chat.id].send_text(text)))
Additional context
response Manager chats not found
can hel p me please?

We have the same issue with self._driver.chats[chat_id].send_text(qtext) the messages has not been sent, please your help urgently.
Best regards.

I have same problem, any solutions?

I see there is no update in the repo since last two whatsapp updates. things have changes. while you wait for new update to be fixed you can use other python based repos like https://github.com/mukulhase/WebWhatsapp-Wrapper

i find a solution i can help you ws +573505620505


Add Buildable gyb

From #263

2. Actually create the Buildable types
I think with that we’re already to the main part. Here is a random collection on thoughts, how I would approach it. Again a disclaimer: I haven’t tested any of this and it might be whofully wrong.
First off, I would try and get a raw API up and running. At this stage, I wouldn’t worry about a nice API or result builders yet, I would just want to get an initialiser-based API up and running with which all syntax nodes can be created.

As a baseline, I would start with SyntaxBuilders.swift and modify it according to our needs.
I wouldn’t be too focused on the current design of the buildables since we probably can’t automatically re-create a generic modelling like it’s currently done for variables here. I’m fine with any design that’s easy to use and we are not concerned about source breakage here.
As a first step, I would try modifying the SyntaxBuilders so they are purely initialiser based, that is all children are passed in the initialiser and we don’t need the use* methods anymore.

After this, I am expecting the API to be much worse than it is today, but it should be exhaustive now. This means, we now need to make it easy to use again. I’ve got a couple of (more or less) necessary improvements in my head already, I’m sure there are more once you get to it.

Of course the entire result builder thing. Any syntax collection should be buildable using a corresponding result builder.

Any non-optional token without custom text (i.e. a keyword or punctuator) ccan be implicitly synthesized and does not have a corresponding argument in the initialiser

Example: We don't need to specify the open { for a struct decl.

And as far as I can tell we’re now already at a stage, where custom specialisations are needed. These can be made in a separate file through extensions.

Example: According to the specification of a VariableDecl, it is (simplified) a var/let keyword with a following PatternBindingList. But that’s not how anybody thinks about a Var decl. We should create an initialiser that’s closer to what we have today, which correctly creates the pattern binding etc.
Example: According to the definition of a StructDecl, it takes its members as a MemberDeclBlock, consisting of a pair of braces and decls which might be followed by a semicolon. The braces can already be implicitly synthesized as described above and nobody cares about semicolons. So we should have a specialised initialiser taking a list of decls (through a result builder) that correctly creates the MemberDeclBlock etc.

I think the advantage of this approach (auto-generate a exhaustive, but verbose API and add convenience extensions on top) apposed to the previous approach (hand write everything), is that there is always a fall-back to create every syntax element, even cutting-edge ones. I expect the convenience initialisers to concern the most commonly used syntax elements, which should also be the most stable, so I expect they should be fairly easy to maintain.
What do you think @kimdv? Does this sound good to you?

Okay, now we are ready for the next step. 🚀
(I have modified this file, not sure if it is the right, but then we can start a conversation)
I'm a little confused on how I should approach this.

As a baseline, I would start with SyntaxBuilders.swift and modify it according to our needs.
I wouldn’t be too focused on the current design of the buildables since we probably can’t automatically re-create a generic modelling like it’s currently done for variables here. I’m fine with any design that’s easy to use and we are not concerned about source breakage here.
As a first step, I would try modifying the SyntaxBuilders so they are purely initialiser based, that is all children are passed in the initialiser and we don’t need the use* methods anymore.

So the idea is that inside etc StructDeclSyntaxBuilder should not have add* but all possibilities should be basses within the init method?

Disclaimer up front: I had a fairly good idea how the tokens should look like, my ideas further down become a lot more vague – there might be an altogether better design. Don’t feel like you have to stick to what I tell you as you dive into the implementation.
With that said, the way I would approach it, would be to start of by generating something like the following
// Simple syntax element
public struct IntegerLiteral: ExprBuildable {
  let digits: Token

  public init(digits: Token) {
    self.digits = digits
  }

  public func buildExpr(format: Format, leadingTrivia: Trivia) -> ExprSyntax {
    let integerLiteral = SyntaxFactory.makeIntegerLiteralExpr(
      digits: SyntaxFactory.makeIntegerLiteral(String(value))
    ).withLeadingTrivia(leadingTrivia)
    return ExprSyntax(integerLiteral)
  }
}

// More complex element
public struct ImportDecl: DeclBuildable {
  let attributes: AttributeListSyntax
  let modifiers: ModifeirListSyntax
  let importTok: Token
  let importKind: Token
  let path: AccessPathSyntax

  public init(
    attributes: AttributeListSyntax,
    modifiers: ModifeirListSyntax,
    importTok: Token,
    importKind: Token?,
    path: AccessPathSyntax,
  ) {
    self.attributes = attributes
    self.modifiers = modifiers
    self.importTok = importTok
    self.importKind = importKind
    self.path = path
  }

  public func buildDecl(format: Format, leadingTrivia: Trivia) -> DeclSyntax {
    let importDecl = SyntaxFactory.makeImportDecl(
      attributes: attributes,
      modifiers: modifiers,
      importTok: importTok,
      importKind: importKind,
      path: path
    ).withLeadingTrivia(leadingTrivia)
    return DeclSyntax(importDecl)
  }
}

// Syntax collection
public struct CodeBlockItemList: SyntaxBuildable {
  let elements: [CodeBlockItem]

  public init(elements: [CodeBlockItem]) {
    elements = elements
  }

  public func buildSyntax(format: Format, leadingTrivia: Trivia) -> DeclSyntax {
    let codeBlockItemList = makeCodeBlockItemList(elements)
      .withLeadingTrivia(leadingTrivia)
    return Syntax(codeBlockItemList)
}

Notice how each buildable takes exactly the arguments that are specified, so it’s essentially a wrapper around SyntaxFactory.
Once we have that, I imagine we can improve it as I described in the previous long post.

Okay @ahoppen I have pushed my progress now, but tests don't pass yet!
I have tried to make what you mentioned in (this comment)[https://github.com/apple/swift-syntax/pull/268#discussion_r598647295].
I found out that the API with leadingTrivia and format is a little hard (as I see it) to control, like have some custom indent.
If we take the SourceFileTests
We expect:
    ␣import SwiftSyntax
    struct ExampleStruct {
        let syntax: Syntax
    }

But get
␣import ␣SwiftSyntax␣struct ExampleStruct ␣{
  ␣let ␣syntax␣: ␣Syntax}

I have also tried to add some of the convince extensions for ImportDecl, SourceFile, StructDecl.
I have also tried to make some generic Var and Let.
The Python code is still some messy for me.
Etc there is some special handling for two types here.
I found there is an IdentifierToken and Token. They didn't fit in the other cases.
Maybe you can guide me to some place, so it can be more clean and easier to read?
Thanks!

Trivia and indentation

I found out that the API with leadingTrivia and format is a little hard (as I see it) to control, like have some custom indent.

Really good indentation will probably be hard to get to work in any case, so for now I’d settle with indentation that compiles, is not too horrible to look at and which e.g. swift-format could improve. But what we have right now is definitely not what we want.
What do you think about adding a newline after every line in a code block and after every member declaration? I.e. add a boolean flag to MemberDeclList and CodeBlock like elements_separated_by_newline and if that flag is set, in the builder you then add a newline between the items like so:
SyntaxFactory.make${node.syntax_kind}(elements.map {
  $0.build${node.collection_element}(format: format, leadingTrivia: .newlines(1) + format._makeIndent())
})

(side node: you are currently passing leadingTrivia down to every child. I think that’s not correct since the leading trivia parameter is being handled by the withLeadingTrivia here. The leadingTrivia should only add that trivia to the currently constructed node, not to every nested node. format is responsible for doing that)
With that, I think, we would get the following result:
import␣SwiftSyntax␣
struct ExampleStruct ␣{
let␣syntax␣:␣Syntax
let␣syntax2␣:␣Syntax}

which is already a lot better (and compiles 🎉). Now two things remain:

Indent the members inside the struct
Add a newline before the closing brace

For 1.) I would suggest to add a property is_indented to the Statements child of CodeBlock here (and similarly for the member decls). If that property is set, you don’t pass down format here but format._indented(), just like it is currently done in the old Struct Syntax buildable, e.g.
if child.is_indented:
  let format = format._indented()

For 2.) I would suggest adding a property requires_leading_newline to the RightBrace child of CodeBlock here (again similarly for member decls). If that property is set, you again use .newline(1) + format._makeIndent() as the child’s leading trivia here. Again, as noted above, passing down leadingTrivia like you do today, isn’t correct.
With 1.) and 2.) in, I think we should get what we want
import␣SwiftSyntax␣
struct ExampleStruct ␣{
␣␣let␣syntax␣:␣Syntax
␣␣let␣syntax2␣:␣Syntax
}

A background note on my suggestion: I would implement the entire indentation behavior on the level of the Child classes in Python, not the Node classes because the indentation is IMHO the property of a syntax node occurring at a specific location inside a parent, not a property of the syntax node itself. For SyntaxCollections the Child nodes are implicit. Here the elements_separated_by_newline is the equivalent of having a requires_leading_newline on every of its implicit child nodes.
Convenience extensions

I have also tried to add some of the convince extensions for ImportDecl, SourceFile, StructDecl.

I would like to keep any convenience extensions out of this PR for now to (a) make it smaller and easier to review and (b) to see how far we can get with the purely generated code. If this means you need to delete some test cases, that’s totally fine with me. We can always add them again later.
Python code

The Python code is still some messy for me.

Actually, I think it’s fine. I just skimmed over it and was able to understand what’s going on. Perhaps we can move the code that determines what type a SyntaxBuildable child should have to a function to avoid duplication and make it clearer. E.g.
def syntax_buildable_child_type(syntax_kind, is_optional=False):
  if 'Token' in syntax_kind: # Alternatively, add a `is_token` method to `Node`
    buildable_type = 'TokenSyntax'
  elif node.syntax_kind in SYNTAX_BASE_KINDS:
    buildable_type = syntax_kind + 'Buildable'
  else:
    buildable_type = syntax_kind

  if is_optional:
    buildable_type += '?'

  return buildable_type

and then use it in line 69 and line 123.

I found there is an IdentifierToken and Token. They didn't fit in the other cases.

IdentifierTokens are just plain Tokens as far as the SwiftSyntax API is concerned. If you use is_token() on Child the two types are treated exactly the same.

Trivia and indentation

I found out that the API with leadingTrivia and format is a little hard (as I see it) to control, like have some custom indent.

Really good indentation will probably be hard to get to work in any case, so for now I’d settle with indentation that compiles, is not too horrible to look at and which e.g. swift-format could improve. But what we have right now is definitely not what we want.
What do you think about adding a newline after every line in a code block and after every member declaration? I.e. add a boolean flag to MemberDeclList and CodeBlock like elements_separated_by_newline and if that flag is set, in the builder you then add a newline between the items like so:
SyntaxFactory.make${node.syntax_kind}(elements.map {
  $0.build${node.collection_element}(format: format, leadingTrivia: .newlines(1) + format._makeIndent())
})

(side node: you are currently passing leadingTrivia down to every child. I think that’s not correct since the leading trivia parameter is being handled by the withLeadingTrivia here. The leadingTrivia should only add that trivia to the currently constructed node, not to every nested node. format is responsible for doing that)
With that, I think, we would get the following result:
import␣SwiftSyntax␣
struct ExampleStruct ␣{
let␣syntax␣:␣Syntax
let␣syntax2␣:␣Syntax}

which is already a lot better (and compiles 🎉). Now two things remain:

Indent the members inside the struct
Add a newline before the closing brace

For 1.) I would suggest to add a property is_indented to the Statements child of CodeBlock here (and similarly for the member decls). If that property is set, you don’t pass down format here but format._indented(), just like it is currently done in the old Struct Syntax buildable, e.g.
if child.is_indented:
  let format = format._indented()

For 2.) I would suggest adding a property requires_leading_newline to the RightBrace child of CodeBlock here (again similarly for member decls). If that property is set, you again use .newline(1) + format._makeIndent() as the child’s leading trivia here. Again, as noted above, passing down leadingTrivia like you do today, isn’t correct.
With 1.) and 2.) in, I think we should get what we want
import␣SwiftSyntax␣
struct ExampleStruct ␣{
␣␣let␣syntax␣:␣Syntax
␣␣let␣syntax2␣:␣Syntax
}

A background note on my suggestion: I would implement the entire indentation behavior on the level of the Child classes in Python, not the Node classes because the indentation is IMHO the property of a syntax node occurring at a specific location inside a parent, not a property of the syntax node itself. For SyntaxCollections the Child nodes are implicit. Here the elements_separated_by_newline is the equivalent of having a requires_leading_newline on every of its implicit child nodes.

I have added your suggestions and almost something that generates some code (But will not compile yet).
I have some thoughts that I wanted some feedback on before adding it.
Should we add something like requires_leading_space for places like (here)[https://github.com/apple/swift/pull/36726/files#diff-de4680aa2bbb7151cb6595294ce91fb29fec2ecd719ae270ae1cdbd4c37a3c87R48] (and all other related places, where there is a left brace or Identifier etc).
And if requires_leading_space  is set we will add a withLeadingTrivia(.spaces(1)).
The reason is, that now we are generating
}```

Or can we make some general rule somewhere for applying all places so we don't need to add the something multiple places?

> ## Python code
> > The Python code is still some messy for me.
>
> Actually, I think it’s fine. I just skimmed over it and was able to understand what’s going on. Perhaps we can move the code that determines what type a `SyntaxBuildable` child should have to a function to avoid duplication and make it clearer. E.g.
>
> ```python
> def syntax_buildable_child_type(syntax_kind, is_optional=False):
>   if 'Token' in syntax_kind: # Alternatively, add a `is_token` method to `Node`
>     buildable_type = 'TokenSyntax'
>   elif node.syntax_kind in SYNTAX_BASE_KINDS:
>     buildable_type = syntax_kind + 'Buildable'
>   else:
>     buildable_type = syntax_kind
>
>   if is_optional:
>     buildable_type += '?'
>
>   return buildable_type
> ```
>
> and then use it in [line 69](https://github.com/apple/swift-syntax/pull/268/files#diff-1692562863ad5b0153cfede0d8b3fa518b3792f644fa2425ad41b1ac2f9ed33fR69) and [line 123](https://github.com/apple/swift-syntax/pull/268/files#diff-1692562863ad5b0153cfede0d8b3fa518b3792f644fa2425ad41b1ac2f9ed33fR123).
>
> > I found there is an IdentifierToken and Token. They didn't fit in the other cases.
>
> `IdentifierToken`s are just plain `Tokens` as far as the `SwiftSyntax` API is concerned. If you use [is_token()](https://github.com/apple/swift/blob/63d5cf1e5efff46698680a81b3137648a265dbc7/utils/gyb_syntax_support/Child.py#L69) on `Child` the two types are treated exactly the same.

I have tried to add it to the gyb file?
Maybe I have misunderstood something, but should it be added in `Buildables.swift.gyb` or as an method on node/child?

I haven’t looked at the code yet. Let me know once you think that is ready for review.

Should we add something like requires_leading_space for places like here (and all other related places, where there is a left brace or Identifier etc).
And if requires_leading_space is set we will add a withLeadingTrivia(.spaces(1)).

I don’t think that’s necessary. IIUC when we generate the struct-Keyword with Tokens.struct, we already receive struct␣. For now I think we can put it in the user’s responsibility to create an identifier token with a trailing space so that we would get
struct␣TestStruct␣{
}

Please correct me if I’m wrong.
Later, when we create convenience constructors that take Strings instead of IdentifierTokens, these could add the trailing space.

I have tried to add it to the gyb file?
Maybe I have misunderstood something, but should it be added in Buildables.swift.gyb or as an method on node/child?

Sorry, I don’t quite understand the question. What is “it” referring to?

Okay @ahoppen, after some evenings working on it, I have something that works now.
I have commented below.

I haven’t looked at the code yet. Let me know once you think that is ready for review.

Should we add something like requires_leading_space for places like here (and all other related places, where there is a left brace or Identifier etc).
And if requires_leading_space is set we will add a withLeadingTrivia(.spaces(1)).

I don’t think that’s necessary. IIUC when we generate the struct-Keyword with Tokens.struct, we already receive struct␣. For now I think we can put it in the user’s responsibility to create an identifier token with a trailing space so that we would get
struct␣TestStruct␣{
}

Please correct me if I’m wrong.
Later, when we create convenience constructors that take Strings instead of IdentifierTokens, these could add the trailing space.

If you have time, it would be nice if you would look a little on the tests I have added.
I think it will give you an idea on how the API works now and if it matches your vision.
I have added some comments in the code, with some thoughts/ideas

I have tried to add it to the gyb file?
Maybe I have misunderstood something, but should it be added in Buildables.swift.gyb or as an method on node/child?

Sorry, I don’t quite understand the question. What is “it” referring to?

I figured it out, had some problems where to add the code, that is added here.
I first tried to add it add bottom of the gyb file, like this
%  def syntax_buildable_child_type(syntax_kind, is_token=False, is_optional=False):
%    if syntax_kind in SYNTAX_BASE_KINDS:
%      buildable_type = syntax_kind + 'Buildable'
%    elif not is_token:
%      buildable_type = syntax_kind
%
%    else:
%      buildable_type = 'TokenSyntax'
%
%    if is_optional:
%      buildable_type += '?'
%
%    return buildable_type

Again, thanks for your patience 😁

I have address more less all off them, I have some small questions and added some comments.

I’ve added some comments inline but they are all mostly stylistic now, nothing major.
Once you’ve addressed them, I will give the PR another review, run the test suite and get this merged. I’ve lost track but are there any related. If there are any, could you also push any pending changes to your apple/swift PR for that?

Yes, there is one here: https://github.com/apple/swift/pull/36726

Let’s see what CI has to say about this.
https://github.com/apple/swift/pull/36726
@swift-ci Please test

🎉 CI passed. I’m proposing that we merge this as is and you address the following outstanding things in follow-up PRs:

Add comment describing behavior of nil leadingTrivia (https://github.com/apple/swift-syntax/pull/268#discussion_r616595072)
Use Token static properties instead of constructing tokens manually in tests (https://github.com/apple/swift-syntax/pull/268#discussion_r616522144)
Add syntax node description comments to buildables (https://github.com/apple/swift-syntax/pull/268#discussion_r616537232)

Yes!
Let's get it merged and I will fix the 3 things you mentioned after.
I just rebased on main.

apple/swift#36726
@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 396f756e90b27e8d75781abecb01635473ec69fa

Build failed
Swift Test OS X Platform
Git Sha - 396f756e90b27e8d75781abecb01635473ec69fa

If it didn’t come through when you put up the PR and during review, I wanted to give you a huge thank you for working on this and having the perseverance to see this patch through to the end (I only now realized that it was started more than a month ago). 🙏🏼

I love this work so much, thank you @kimdv! 🥳

You're welcome!


[Docs]: Inconsistent documentation on support status for multi-arch clusters

Is there an existing issue already for your request/idea?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new documentation enhancement to be evaluated.

What problem in the existing documentation this issue aims to solve?
The documentation on multi-arch Kubernetes clusters is inconsistent on whether multi-arch clusters are supported.
On https://cloudnative-pg.io/documentation/1.22/#container-images there is an info box saying multi-arch clusters are not supported. But then, on https://cloudnative-pg.io/documentation/1.22/installation_upgrade/#in-place-updates-of-the-instance-manager it says that for this feature all pods need to run on the same architecture.
This is inconsistent: I would assume that if multi-arch clusters would not be supported, the rest of the documentation would not need to refer to that.
My assumption is that multi-arch clusters might not have been supported in the past but are with recent releases of the operator.
Describe what additions need to be done to the documentation
No response
Describe what pages need to change in the documentation, if any
If my assuptions are correct, https://cloudnative-pg.io/documentation/1.22/#container-images would need a change.
I think there are 2 good ways to go forward:

Remove that box entirely, as multi-arch clusters are supported by the operator
Change the text to something in the direction of "multi-arch clusters are supported. Limitations apply"

Describe what pages need to be removed from the documentation, if any
No response
Additional context
No response
Backport?
N/A
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Related to #3868 . See https://github.com/cloudnative-pg/cloudnative-pg/issues/3868#issuecomment-1964271703

Please let's include this change in #3868


Update documentation URL

The original Bellman site on Sourceforge is out-of-date and potentially confusing; I'd like to take it down.
This patch updates the documentation link to point at a copy that's not about to disappear.

Hi, @MikePlayle!
This repository is just a fork of @simsim314's repo, I think it makes more sense to open a pull request to the upsteam repo.


Missing 'Issues' viewer

Extension version: 0.14.0
VSCode Version: 1.42.1
OS: macOS Catalina

Steps to Reproduce:

After installing the extension, it's just showing me the PRs not the Issues unlike on my Ubuntu Laptop which is running 0.16.0 version of the extension.

Has the issues viewer not yet been rolled out for MacOS?

@sacredvoid This is available in version 0.16 of the extension, please update your version of VSCode to get it. Thanks!


Make list work well

bacalhau list --id-filter=${JOB_ID} --output json
Prints out a JSON listing all jobs, should filter for ${JOB_ID} instead.

Maybe we can address all of these in one go; we should make list work well:

[ ] Server side query response with only the data that's needed that's already sorted
[ ] Remove client code that does pagination and move it to the server
[ ] It's slow because it does lots of requests
[ ] Make sure that all existing flags still work

what is the user expectation from a list, assuming no filters were passed? Is it listing all the jobs in the network since the beginning of time? If an explicit or an implicit limit was set, do we support pagination with continuation tokens? Do all Bacalhau nodes need to be aware of the jobs submitted to the network along with their state?
I mainly want to understand the use case and how we plan to scale list and the job state

@wdbaruni has a good point and I'd like to take it further.
It's a public network, and while we still need to be able to list all jobs in some way, I question whether we want to expose all that to users. The point is, if the number of entries in list is large, wouldn't you'll be interested only in a sub-set of that? Your scope may be your own work, project, organization, whatever, maybe we can come up with a number of possible hierarchies.

If we label the job with a hash of the the client's public key, we could
default to only showing you your own jobs, with a flag for showing all
jobs. If we do that filtering on the server side, list would get nice and
quick for most users most of the time, which would be a big win.
On Mon, 19 Sept 2022, 13:07 Enrico Rotundo, @.***>
wrote:

@wdbaruni https://github.com/wdbaruni has a good point and I'd like to
take it further.
It's a public network, and while we still need to be able to list all
jobs in some way, I question whether we want to expose all that to users.
The point is, if the number of entries in list is large, wouldn't you'll
be interested only in a sub-set of that? Your scope may be your own work,
project, organization, whatever, maybe we can come up with a number of
possible hierarchies.
—
Reply to this email directly, view it on GitHub
https://github.com/filecoin-project/bacalhau/issues/611#issuecomment-1250931468,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACATUWQKJRTKCMIEM2SWBTV7BJOPANCNFSM6AAAAAAQLMTVH4
.
You are receiving this because you commented.Message ID:
@.***>

I like Luke's proposal as it will allow scaling the state the network needs to maintain without having each node keep a copy of every single job state.
To handle describe/get we can use a DHT where the key is the jobId and the value is the job state. To handle list we can also use another DHT where the value is the client public key and the value is a list of jobIds along with a state summary. The problem here is we can still run into hot partitions for the clients that submit a lot of jobs. There can be multiple mitigations here, but if the goal of list is to just return the latest n jobs or the jobs that were submitted in the last t time, then this can simplify things a little, specially that we now have rate limiting enabled


Running Chef with webgis-windows.json returns "Could not satisfy version constraints for: line"

Attempting to install Portal 10.6.1, and running the out-of-the-box cookbooks with updated values in webgis-windows.json using the following command:
chef-solo -j C:\chef\roles\webgis-windows.json
running Chef 14.3.37 using the ArcGIS cookbook version 3.2.1, I get the following error:
=====================================================
Error Resolving Cookbooks for Run List:
Missing Cookbooks:
Could not satisfy version constraints for: line

The metadata file for line shows the following:
chef_version     '>= 12.13.37'
I also get the following error, which I assume is unrelated:
[2018-07-30T12:24:54-07:00] FATAL: Net::HTTPServerException: 412 "Precondition Failed"
I have downloaded the latest cookbook set, checked the metadata and log files, but cannot determine the cause of this error.
To what version is the message referring, the Chef version, the cookbook version, ...?
Any help is appreciated.

Thank you, jonathanan, for the quick and accurate response to my issue.  Looks like I showed my chef beginner stripes.....


x/crypto/cryptobyte: cannot read boolean values

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10.3 darwin/amd64
Does this issue reproduce with the latest release?
yes
What did you do?
I tried to decode a boolean asn.1 value using the cryptobyte package.
Boolean "True" value encoded using the stdlib asn.1 encoder is 0x0101FF tag 0x01 - boolean value
length 0x01 - 1 byte and the value 0xff - 0x00 is false, everything else if true.
When decoding the value using the cryptobyte package I have encountered some issues.

Using ReadASN1Boolean - it expects tag 0x02 - Integer instead of tag 0x01 - Boolean, so it returns false when reading 0x0101FF value

Using ReadOptionalASN1Boolean - it correctly expects 0x01 tag, and reads the value into a child cryptobyte string (that would contain x0FF bytes in my case), then in case the value exists, proceeds to read the remainder of the input which is not correct, it should examine the value read into the child cryptobyte string and return without advancing further.

Both bugs are trivial to fix and I am happy to submit a patch.

CC: @FiloSottile

Hi, I'm using the cryptobyte library and I stumbled upon this, too
What version of Go are you using?

$ go version
go1.11.5 darwin/amd64

Does this issue reproduce with the latest release?
yes
What did you do?
I tried to decode an optional boolean asn1 value using the cryptobyte package. I expected the String "0x01 0x01 0xFF" to be decoded as "true", but ReadOptionalASN1Boolean fails to read the String.
The underlying issues pointed out by szank seem to be correct.
I can't provide a playground example, so I'll just copy paste it here
package main

import (
	"fmt"

	"golang.org/x/crypto/cryptobyte"
)

func main() {
	var b bool

	// This should read the booleanDER successfully and set 'b' to TRUE
	//
	// It fails to read the optional BOOLEAN because it updates the String to check
	// the presence and then tries to read from the updated string instead of the
	// extracted child
	var booleanDER = cryptobyte.String{0x01, 0x01, 0xFF}

	if !booleanDER.ReadOptionalASN1Boolean(&b, false) {
		fmt.Println("Couldn't read booleanDER")
	} else {
		fmt.Printf("Read optional booleanDER: %t\n", b)
	}

	fmt.Println("===")

	// This should read the boolean and set 'b' to FALSE. compositeDER should then
	// be updated to point at the start of the encoded integer.
	//
	// It actually checks the presence of the boolean with a BOOLEAN tag, then
	// proceeds reading the value from the updated String as above.
	// Since ReadASN1Boolean uses the INTEGER tag, it reads the following INTEGER
	// and sets 'b' to TRUE (0xFF), updating the String again.
	// At the end of the operation compositeDER has no bytes left, due to the double
	// update.
	var compositeDER = cryptobyte.String{0x01, 0x01, 0x00, 0x02, 0x01, 0xFF}

	if !compositeDER.ReadOptionalASN1Boolean(&b, false) {
		fmt.Println("Couldn't read compositeDER")
	} else {
		fmt.Printf("Read compositeDER: %t\n", b)
		fmt.Printf("Remaining bytes: \"%X\"\n", compositeDER)
	}
}

I also agree with the last point by szank. Both fixes should be trivial and I'd be happy to contribute.

According to ITU-T X.690:

8.2.2 If the boolean value is:
FALSE
the octet shall be zero.
If the boolean value is
TRUE
the octet shall have any non-zero value, as a sender's option.

11 Restrictions on BER employed by both CER and DER
11.1 Boolean values
If the encoding represents the boolean value TRUE, its single contents octet shall have all eight bits set to one. (Contrast
with 8.2.2.)

So the problem for ReadASN1Boolean seems to be just the wrong tag, like said previously.

Fixed by golang.org/cl/233161.


[Tree] The order of top level rootless nodes is incorrect

When using a tree entity that has no root property (as instructed here) DoctrineExtensions should treat your table as one whole tree, thus allowing nodes on the top-level to be sorted.
Unfortunately, in this case the the order of the nodes is persisted incorrectly. The node is always persisted last, no matter which of the following methods is used:

persistAsFirstChild
persistAsLastChild
persistAsNextSiblingOf
persistAsPrevSiblingOf

I've created a fork and added a unit test to demonstrate the problem. The issue can be reproduced in both the v2.4.x and the master branch. I've also tried to find the bug but felt a little lost. These are the things I found:

The Nested strategy class seems not to handle this case (as there is no switch case as above)
Several calls to Nested::updateNode don't pass the $position parameter (defaults to 'FirstChild' or pass a hard coded value [1] [2] [3]

I'm down to helping investigate this issue but I fear that my knowledge is not sufficient for finding this bug. Any help would be appreciated.

Hi, I have left the php world, but from the looks in location you gave the edge always take the LAST CHILD position. It should build a gap with shiftRL method and make there some space for new node like this switch, so it looks like a bug. The nested set implementation is very easy, but managing it with ORM becomes too complex, all small changes takes much time to implement. I think you would spend much of the time to make this fix, that is why there are so many users but not much of the contributors and not many of behaviors for ORM from other parties.

I got it working here.
I'd be really happy if someone could skim though it to make sure I did nothing stupid. 😅

My fix seems not to work on master. I'll check it out tonight and get back to you.

any chance to get a bugfix tag for this ? :)

@mneuhaus This bug is fixed but it has not been released yet. The issue with the master branch was fixed and merged in #1692.

yea, i know, that's why i asked for a bugfix tag, in order to avoid a dev-master in my composer ;)

@mneuhaus Oh sorry, my bad. I misread your question. 😅 Yeah I think this is safe to be tagged after two months without any issues 👍

@mneuhaus The tag has been created, can you confirm that this solves the issue?

yea, thanks :)


fix(unix,iour): musl libc compatibility

The libc crate does not provide statx on musl, and msghdr contains private padding fields :(
See also: https://github.com/DataDog/glommio/pull/590

Interestingly I'm getting one test failure on my machine:
---- cancel_before_poll stdout ----
thread 'cancel_before_poll' panicked at compio-driver/tests/file.rs:72:24:
index out of bounds: the len is 0 but the index is 0

Interestingly I'm getting one test failure on my machine...

Oh, it's a logical bug of this test. I'll fix it later.


crash shortly after loading

Whenever I load the game with this mod specifically, my game will crash without fail, usually within 10 minutes. I've deleted temp files and deleted and reinstalled my graphics drivers.
I don't know how to reproduce this behavior, it just happens. All I want to do is romance two characters at once and guarantee that I get the secret ending without having to play a wizard or a Rogue.
The expected behavior is as listed above, a crash after a few minutes, usually somewhere around 5-15 minutes, its kinda random.
linked below is a save file of a fresh game I literally just made and all I did was load the game with the mod. I cannot start from scratch with the mod enabled because it will also crash.
this is the most recent of the mod btw.
Quick_37.zip

Player.log
GameLogFull.txt

And try to update your DirectX. The log says you are using  Version:  Direct3D 11.0 [level 11.1]. Your graphic card should support D3D 12


feat: connect to dapps using WalletConnect

Description
This PR contains the ability to connect to any dApp using WalletConnect. Figma designs here:
https://www.figma.com/file/OHbVrAVaV2xQWUsq0nKzGm/ShapeShift-Library?node-id=1222%3A4033
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Risk
This is currently hidden behind a feature flag, so should be low risk to roll out
Testing

Engineering
You need to have the following folder structure:
/app-repo (named whatever)
/hdwallet

And then, in hdwallet, checkout the southbear/dw-2760/implement-walletconnect branch and run cd packages/hdwallet-walletconnect-bridge && yarn build
Operations

Not really sure how to enable non-devs to test at this point since this relies on an unmerged hdwallet PR. Is there a way I can generate e.g. a Vercel build locally and pass that link around?
Once we have a place to test this, the easiest is to connect using e.g. https://example.walletconnect.org/ or https://app.uniswap.org/#/swap and try making swaps and using personal_sign
Screenshots (if applicable)

Outstanding questions

[ ] How to get the latest version of develop working locally? Need to merge with develop, but can't verify that stuff still works

[ ] How to format this properly? It's just cutting of the text and not getting laid out properly. Code: https://github.com/shapeshift/web/pull/2914/files#diff-8760b37468b65035a1e469f7a6c04d740220020d8390efc80f10c3b50e6234f7R52

[ ] https://github.com/shapeshift/web/pull/2914/files#diff-bc7b6663c8419d3f7a7fb8768b3ec71d07a03a58e9aa13d43acb522a75052c92R47
[ ] What values to use? https://github.com/shapeshift/web/pull/2914/files#diff-64f644f5f3d4f6d53a8ba95473b76d2436fdeb021c94db955e93454e51bb48ccR51
[ ] How to translate fee txFee to gas price? https://github.com/shapeshift/web/pull/2914/files#diff-64f644f5f3d4f6d53a8ba95473b76d2436fdeb021c94db955e93454e51bb48ccR52
[ ] https://github.com/shapeshift/web/pull/2914/files#diff-9d3ba3f2c7a29ba38c6006a5c51cfe373d8a5fc26bd4da057689f068cd275319R60 and https://github.com/shapeshift/web/pull/2914/files#diff-7c8de020d515a092c474fae97ebe0a93cbf88b689f8274aa3bb7333661bb7937R57
[ ] Fetching gas estimates doesn't work: https://github.com/shapeshift/web/pull/2914/files#diff-f3e22c98b08694ce3af3c5bed8fbbde85f06b419208fa2139d610899f5eb8b5eR28 More context in Discord msg: https://discord.com/channels/554694662431178782/1006309093037842542/1025157707646369802

closing in favor of https://github.com/shapeshift/web/pull/3173


Clear selection after submit

Context
The selection and name is cleared after submitting a vote. This behavior was understood as a bug (#63) and iirc it was cleared before (somewhere at the beginning of the project). Presumably the deletion of the input after a successfull vote would discourage spamming and clicking the button multiple times.

This would need to change a bit after #79 is merged. Please wait for that PR.


Implement Middle End

Implement the middle end processor for Metal.

[ ] - (optional) AST optimizations
[ ] - Bytecode Compiler (rkyv-based)

Rust calls it "MIR", Mid-level Intermediate Representation


[BUG]I cant install bloxstrap latest version

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
2.8.3
What problem did you encounter?
I cant install bloxstrap "2.8.3" because it says "Make sure you trust bloxstrap-v2.8.3 before opening it"

Bloxstrap Log
N/A

Common error when downloading the installer on Edge. Just force it to download if you can.


Not able to access an existing code component

Hi,
I used a code component in my app, which worked just fine until a couple of days ago.
Now I face issues:

I cannot find this component under the "code" section in my canvas apps anymore
I cannot access existing apps that already had this code component implemented

Link to the used code component:
https://github.com/OOlashyn/PCF-RangeSliderControl/releases
See also my post about the issue here:
https://powerusers.microsoft.com/t5/Power-Apps-Experimental-Features/Help-to-restore-an-app-with-git-integration-and-a-Custom-Code/td-p/1726313

@PowerDashDash If you have a question or issue with our documentation, please provide a link to the doc page.

Thanks for contacting us. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, visit https://powerapps.microsoft.com/support/.
Closing this issue.


ERROR: Server returned error 504 for https:///organizations//pushy/node_states, retrying 1/5 in 3s

Push Jobs Server version - 2.2.6
Push Jobs Client version - 2.4.5
When executing 'knife node status'

Found the root cause. AWS security group inbound rule was missing.

This thread is quite old. I am running into a similar issue. Wondering what's the inbound rule you are referring to ?
Thanks
Shynee

AWS Secuirty Group ingress rule :-)

What port though ? I am trying to move a server from one chef server to another (both are in cloud). Have same security group. One works, but not on the other. It fails with the following.
[10.xx.xxx.x] [2020-04-07T16:49:01-05:00] ERROR: Server returned error 504 for https://chefserver.mydomain.net/organizations/nonprod-corp/data-collector, retrying 1/5 in 4s
[10.xx.xxx.x] [2020-04-07T16:50:06-05:00] ERROR: Server returned error 504 for https://chefserver.mydomain.net/organizations/nonprod-corp/data-collector, retrying 2/5 in 8s
[10.xx.xxx.x] [2020-04-07T16:51:14-05:00] ERROR: Server returned error 504 for https://chefserver.mydomain.net/organizations/nonprod-corp/data-collector, retrying 3/5 in 12s
[10.xx.xxx.x] [2020-04-07T16:52:27-05:00] ERROR: Server returned error 504 for https://chefserver.mydomain.net/organizations/nonprod-corp/data-collector, retrying 4/5 in 31s
[10.xx.xxx.x] [2020-04-07T16:53:59-05:00] ERROR: Server returned error 504 for https://chefserver.mydomain.net/organizations/nonprod-corp/data-collector, retrying 5/5 in 40s


Question about the Grid View

Would it be at all possible for you to make the Grid view resemble something to what this theme did?
https://playnite.link/forum/thread-311.html
I'm currently in love with that theme's layout for grid but I love your theme's style. I think it would be amazing if you could somehow incorporate that grid design into your theme

There is a lot of issues if i do that because of the current layout design and also in the next update it might show even more issues as the Overview is getting a complete do over with new functions.

Lemme see if i can somehow fit everything into the side, just checked and there is a small chance for it to work out

Lemme see if i can somehow fit everything into the side, just checked and there is a small chance for it to work out

it would be super cool if you could manage it.
Thank you for checking


Update PagerDuty Plugin Doc

Hey, I just made a Pull Request!
Added screenshots to the PagerDuty plugin documentation.
Fixes #5510
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@adamdmharvey it is valid markdown for Github (see https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#images), it shows in tooltips and as the alternate text for an image if the image can't load. Works well for accessibility for screenreaders. I can remove it for now, but would be good to support the accessibility aspect of alt-text for the images.

@jamesrenaud Hmm isn't the link text itself ([View Open Incidents] for example) already used as the alt text?

Yeah at least the alt attribute does get populated this way. https://guides.github.com/features/mastering-markdown/ You can see it in action in the image example

I think title is different than alt txt, no?  alt text shows when the image can't display, vs. title shows on tool tip hover when the image DOES display.  I think bottom line is the current link checker seems to not support it :) so either it gets removed, or the link checker maybe needs refactoring.
Maybe here?
https://github.com/backstage/backstage/blob/a9697e61073b32bde50a6b6adc13c5295f4a39b3/scripts/verify-links.js#L111-L122

@freben is right, the alt text for accessibility is populated from the title as opposed to the tooltip text. I think it's fair to remove it as it's not serving any useful purpose.
It may be worth based on this still being valid Github flavoured markdown to modify the link parser, but it can be a low priority backlog item.

Looking good! I just slapped a changeset on it as well since the readme affects the published package on npm. Waiting for it to go green and then we're good to go 👍


Enable recording webinars

In webinars there are some different behaviors of zoom, such as entering email address when entering the call, and then some of the screens are a bit different causing zoomrec to be stuck on "zoom is not ready yet". Enabling configuring a call as a webinar and then handling the differences will be a great addition.

Bumping


Update Falco use-cases.md following feedback from ToC

What type of PR is this?
/kind content
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
To address ToC feedback regarding use cases for Falco.
Which issue(s) this PR fixes:
Fixes #1035

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: aijamalnk
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 4ae009e34ab6ddae99c5fa3b0be3c40e2d427f25


Forward Traffic to Another HTTP Proxy with Authentication Using wstunnel

Describe the goal
I am trying to use wstunnel to forward traffic from my local machine to an external HTTP proxy that requires a username and password for authentication. My goal is to have my local machine connect to a VPS via wstunnel, and then have wstunnel on the VPS forward the traffic to the external HTTP proxy.
Describe what does not work
wstunnel doesn't respect http_proxy env variable
Describe your wstunnel setup
Client:
wstunnel client -L socks5://<IP_ADDRESS>:8888 --connection-min-idle 5 wss://<VPS_IP>:8080

Server:
#!/bin/bash

export http_proxy=http://<USER>:<PASS>@<PROXY_IP>:<PROXY_PORT>
export https_proxy=http://<USER>:<PASS>@<PROXY_IP>:<PROXY_PORT>

wstunnel server wss://[::]:8080

Desktop

OS: Linux Ubuntu x86_64
Version: 6.8.0-38-generic

Duplicate of #324


Feature - snap to grid, snap to neighbor

This is very useful when manually rearranging nodes. Snap to neighbor is a simple issue, maybe allow the function to have some options such as

Snap to vertical/horizontal centers
Snap to top/bottom/left/right border alignment

Snap to grid is somewhat trickier, as the grid can be relative to the screen (pixels), or relative to the control's zoom factor. Maybe both options should be considered.
Is it worthwhile pursuing? I think it'd be a nice feature for OCD-disabled people like myself.. :laughing:

So you want to implement smth like virtual grid that can be turned on/off and vertices can be aligned to that grid on demand? Am i correct?

Yeah, exactly! If you have little time, I can give it a stab.

This can be a handy feature, you can try to implement it :) I think it's all about DragBehaviour class as it is responsible for vertex movement, but not sure how to handle grid visualization if you'll want to implement it.

I'll have a look at the drag behaviour class this evening (this rare unbooked evening!) :laughing:
I'll probably do it in three steps:

Get snapping in place (both against virtual grid and neighbors)
Get drawing of snap grid working
Get drawing of "virtual snap lines" against neighbors working

Of course, these changes will have an effect on the API, but I think they'll add to it, rather than change and/or delete from it.
About snap grid: I will not let the user set a size for the grid. I will make it use multiples of some constant (say 5 pixels). That way, I can adapt the grid dynamically depending on the zoom factor. Since GraphX is not an "exact drawing program", I think a dynamic grid should suffice the needs of most users that only want to organize nodes on the screen. What do you think?

Yeah, i think there will be minimal breaking changes needed for an API. Overall this thing looks good and will represent nice feature for GraphX :) Dynamic grid should be the right solution as it seems casual for usage and pro to develope at the same time. If you need any help/questions please let me know, currently i'm quite busy with my main work but i'll try to help in any way.

Sometimes instead of drawing grid lines they draw dots in the background where grid lines would intersect

Thanks for the tip! This could be an option.

in fact, such dots could even be custom objects at an extreme

Implemented in a basic variation


tools: add trendplot script

This script can be used to plot trendline test results from results.xml files.  It may be a useful visualization tool for regression analysis.
cc: @wenqingx

Some examples:
tools/trendplot results.xml
tools/trendplot results/session.latest/ --failures
tools/trendplot results/session.latest/ --platform ADL --failures --case 480p 1080p
tools/trendplot results.xml --case 480p --gop 1 30 100 --component ffmpeg-qsv ffmpeg-vaapi --rc cqp cqp_lp

The --bias, --tolerance, and --add-trendline options are useful for exploring the effects of changing parameters would have on existing test results.

This script can be used to plot trendline test results from results.xml files. It may be a useful visualization tool for regression analysis.
cc: @wenqingx

Thanks, I saw this message, but I haven't had time to try it yet, so I haven't replied yet.


Document the web-content features for badges

There are some fields which can be set in try.html:

Add search terms (data-keywords)
Provide documentation (data-doc)
Set the link target in the generated markdown (data-link)

Maybe there are more. Would be good to write these up in a help doc to make them more discoverable to contributors.

Obsoleted by #1163 and #1273.


type error

Type: Bug
'builtin function or methoed object is nor subscriptable'
VS Code version: Code 1.89.0 (Universal) (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:10:10.196Z)
OS version: Darwin arm64 22.6.0
Modes:

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
1, 2, 1

Memory (System)
8.00GB (0.08GB free)

Process Argv
--crash-reporter-id a04519d1-c592-4914-985f-92a33cc48b8b

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

prettier-vscode
esb
10.4.0

code-runner
for
0.12.2

debugpy
ms-
2024.6.0

python
ms-
2024.6.0

vscode-pylance
ms-
2024.5.1

LiveServer
rit
5.7.9

errorlens
use
3.17.0

vscode-icons
vsc
12.7.0

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
tftest:31042121
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
vscrp:30673768
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
chatpanelt:31048053
dsvsc021:30996838
f3je6385:31013174
pythoncenvpt:31049070
a69g1124:31046351
dvdeprecationcf:31052040
pythonprt:31047983
dwnewjupytercf:31046870
26j00206:31048877

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

/needsMoreInfo

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Review changes to lvproj file related to unit tests PR

This PR #35  was approved but merged the project file, so this needs to be evaluated to ensure it is still valid.
https://github.com/ni/labview-icon-editor/commit/8aee6bd10f412af5743b4bfab3570cba0f9307d6#diff-3a8751d03b79009bf8285cf88190e13f3d6e6fac0bf3715d2c12d11cde9e82c2

Looks fine to me. Most changes are in dependencies which are recomputed on load anyway.

Looks fine to me. Most changes are in dependencies which are recomputed on load anyway.


CDPAM-3145: DataLake Creation Failed

To reach out to https endpoints, golang depends on the value in https_proxy variable. Earlier, golang used to fall back to http_proxy variable inn the absence of an https_proxy variable.
After a recent golang version update (1.16), the behavior was changed to stop the client falling back to http_proxy variable. This broke our NTP proxy support.
This change fixes the problem by setting the correct variable.

We have baked freeipa images from this branch and below are the image-UUIDs for different cloud providers.

AWS : 90fa3754-121d-4b08-88cd-39d7cc4080e2
Azure : bb13bbe6-8afc-454f-b370-aecb05cbb9fa
GCP : caf361ec-1089-4a4c-ab41-ca6e77dd95c6

We have tested this with our CCMv2 dev test suite and CCMv2 e2e test suite (with proxies). CCMv2 dev test runs and e2e tests run were successful.


WIP - IBC test branch

Do not merge*
This PR is simply to test CI against the following changes in the following branches:
https://github.com/anoma/anoma/tree/yuji/fix_header_hash
https://github.com/anoma/anoma/tree/yuji/ibc_ack_ftt_coding

pls update wasm


Image flickering when alert toggled - SwiftUI

I have read the wiki page and cheat sheet, but there is no information I need.

I have searched in existing issues, but did not find a same one.

I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
Flickering images.
What
Using SwiftUI Alerts and Menu's whilst view contains KFImage's can cause the images to flicker.
Reproduce
Place a couple of KFImage's and an Alert inside of a scrollView, that's inside of a navigationView. Toggle the alert and the images should flicker.
Other Comment
This is my first time opening an issue on GitHub, so please let me know if you require more information.
Thanks to everyone working on Kingfisher, it's a beautiful piece of kit! 😊

Hi, @DrinkCupboard
To help us dig into this issue faster and get synced with your situation better, can you please paste some code snippet (maybe the View code you have this problem), so we can reproduce and try a fix?
Thanks!

Should be fixed in 5.15.6.

Sorry I didn't get to your previous message earlier! Thanks for the fix! 🙏


Fix: Pick ytmusic authenticated channel if channel_id is not configured

This is a small patch related to the idea of auto-picking authenticated channel if one is not already configured.
It is better than a blank playlist, since most probably, user with single channel will likely want to see his own playlists as a default action.
/cc @natumbri

Thanks @codeasashu - I was actually thinking about this myself, and have done it in a different way.
I also wanted to keep the list_channelplaylists method in the APIs general, but to have the method in the ytmusicapi version return both public and private playlists if authenticated, and only public playlists if not authenticated.
I think I like your way better for auto picking the authenticated channel, but I like the other functionality of what I did.  Have a look and see what you think.  I'm not much good at github, so I just commit the code that I come up with to the branch, rather than doing a pull request - I guess that's an advantage (/disadvantage) of running the repo.  But I am certainly not opposed to reverting and trying something else!

@natumbri Thanks, your implementation looks better. It will have the ability for multiple channels as well!!
Just one request though. With the github flow, I am fan of rebasing things. But doing things early stages on the feature
branch (feature/yt-playlist) will not be good for a healthy rebasing, considering there are 2 PRs going to be merged.
It will be a headache when something gets reverted in the feature branch, all the history of PRs wiil change.
Will it work for you to open a PR to the feature branch? This has certain benefits, such as:

None of us have to worry about rebasing, until things are finalised to be merged into feature branch
We can discuss/change implementations without worrying about squashing things on the feature branch
you can pick how to architect things better, without worrying about things doing directly to feature branch, giving us a change to revert easily, if something changes?

I just like to keep feature/yt-playlist as a base clean branch to test things that are finalised and take it from there?

I don't really have a workflow for github - I'm very much an amateur when it comes to coding and managing a repo.  But is what I've done with the proposed fix for #185 what you mean?  Put changes in a new branch then merge into feature/yt-playlist?

I don't really have a workflow for github - I'm very much an amateur when it comes to coding and managing a repo.
Is what I've done with the proposed fix for #185 what you mean? Put changes in a new branch then opened a pull request to merge into feature/yt-playlist, instead of just pushing commits directly? If that is better, I am happy to do it that way, or if you had something else in mind, let me know.

Yes, that will work :)

great - should we close this pr?

@natumbri Yes, we can close this PR since your work is already covering this


[Typography] add "component" property to typescript types

[x] I have followed (at least) the PR section of the contributing guide.

Please open an issue first and fill out the template.


fix review comment

play differnt audio for ringing and failed call
fontsize smaller for settings page
remove text capture to open call dialog


Safely stop(close replication-producer) and remove replicator

Motivation
Based on #152 (creating patch to branch-1.15) - Safely close replication-producer while disconnecting replicator

While deleting replication-cluster of the topic: Sometime broker fails to delete replicator-cursor and it tries to restart even after closing the cursor. It causes broker to retries cursor-recovery for already deleted replicator-cluster.

Modifications

On replicator-disconnect: close producer even it's not connected with remote yet.
Avoid restarting of replicator when get error while deleting cursor.

Result

It will prevent producer to reconnect event after replicator disconnection
It will prevent broker to keep retrying cursor recovery for already deleted replication-cluster.

CLA is valid!

CLA is valid!


[Ready for Review] Fix faulty error message logic in _fangornDropzoneError

Purpose
Resolves: CenterForOpenScience/waterbutler#33 and perhaps others
Changes
All DropZone errors passed to _fangornDropzoneError were getting "Unable to reach the provider..."
Fixed so that logic for alternate messages, including for 507, are not overwritten.
Side Effects
None. However there were two different "default" messages. This might be a good opportunity to choose which one to use, or perhaps update it to something else.

Logic looks correct. As mentioned above, just change the default message.
There's a lot of noise in the history for this PR. @TomBaxter would you mind sending a new PR branched of the latest develop, containing a commit with only your changes?
Thanks for your help with this!

Thanks @sloria . I created a new PR #4850 . However this file was updated quite a bit since the original PR and it looks like the logic was fixed in the mean time. The new PR just contains an update of the error message, no logic changes.


Add AMP validation features to support literal attribute value, e.g [].

When inspecting the attributes for p, the "[text]" attribute is returned as "text", when these are distinct values. We are requesting a change or some feature that can return the literal value of the attribute. This is necessary for AMP validation.

At the moment, tagchowder is sanitizing Unicode characters by replacing with "_". For example, a tag that looks like,
'html ⚡4email' would be returned at the handler level as, 'html _4email'

Can you also change README.md to reflect latest package version 2.0.18 and also add one line in CHANGES file displaying
Changes from tagsoup 2.0.18

Add AMP validation features to support literal attribute value such as 'html ⚡4email' and [text]

Once you finish, please squash all commit into one

Done

Can you also change README.md to reflect latest package version 2.0.18 and also add one line in CHANGES file displaying
Changes from tagsoup 2.0.18

Add AMP validation features to support literal attribute value such as 'html ⚡4email' and [text]

Done

Looks good. @lafa please review.

Looks good. based on discussion with luis and nirmal, no need to check for bracket balance


DASHBUILDE-66: NPE data set lookup contains a function with no args

+1 Reviewed Tested the console dataset queries.

-1 i think this is missing some tests for the changes. one example: test equals

+1

failing tests https://gist.github.com/porcelli/dce02febedc691fa7b42

https://github.com/dashbuilder/dashbuilder/commit/2a4aacff45d5387a3fa50529838243e5b8cf7325


Rename Sidecars->Sidecar as it is singular

This change just renames the type so it is singular since it represents a single sidecar

Just realized, is there any implication for Capi since this is a change to the models they might use to generate code from?

@sunjayBhatia Hey these changes look great. Wondering if there was any resolution about the Capi depending on this model?

@dwillist I believe the thread in slack was resolved with the capi team saying they don't actually import the golang code anywhere

Merged into develop here as master is protected.


Fix: Setting the topbar to invisible didn't correctly resize the view

This also preps codebase for immediate release as 0.8.1

:+1:


mixed/heterogeneous builds across different operating system?

Is it possible to have a BUILD step automatically run on a remote host if the local OS is not target_compatible without having to use --fake-host?
E.g I want to make something like this to work:
genrule(
    name = "hello_windows",
    out = "hello_windows.txt",
    cmd = "echo Hello from Windows >> $OUT",
    target_compatible_with = ["config//os:windows"],
)

genrule(
    name = "hello_linux",
    out = "hello_linux.txt",
    cmd = "sha1sum $(location :hello_windows) >> $OUT",
    target_compatible_with = ["config//os:linux"],
)

This is similar to the following bazel issues:

https://github.com/bazelbuild/bazel/issues/19587
https://github.com/bazelbuild/bazel/issues/19209
https://github.com/bazelbuild/bazel/issues/5309

buck2 build root//:from_linux --out=- --prefer-local does now work with the following example but I hoped that buck2 would fallback to local execution if the remote_execution_properties could not be satisfied.
For now I am required to use --prefer-local.
buck2 build root//:from_linux --out=- --prefer-local
File changed: root//BUCK
Build ID: f7875f28-00da-483e-82e9-1d5e1e5bc5b8
Network: (GRPC-SESSION-ID)
Jobs completed: 14. Time elapsed: 0.2s.
Cache hits: 0%. Commands: 2 (cached: 0, remote: 1, local: 1)
BUILD SUCCEEDED
Hello from Windows!!!

Microsoft Windows [Version 10.0.22000.2538]
Linux 6.6.1-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 08 Nov 2023 16:05:38 +0000

genrule(
    name = "hello_from_windows",
    out = "hello_from_windows.txt",
    cmd = "echo H3llo from Windows! >> $OUT & ver >> $OUT",
    exec_compatible_with = ["config//os:windows"],
)

genrule(
    name = "from_linux",
    out = "hello_linux.txt",
    cmd = "cat $(location :hello_from_windows) >> $OUT; uname -svr >> $OUT;",
    exec_compatible_with = ["config//os:linux"],
)

def _platforms(ctx: AnalysisContext) -> list[Provider]:
    name = ctx.label.raw_target()

    constraints_windows = dict()
    constraints_windows.update(ctx.attrs.os_configuration_windows[ConfigurationInfo].constraints)

    platform_windows = ExecutionPlatformInfo(
        label = name,
        configuration = ConfigurationInfo(
            constraints = constraints_windows,
            values = {},
        ),
        executor_config = CommandExecutorConfig(
            local_enabled = host_info().os.is_windows,
            remote_enabled = True,
            use_limited_hybrid = True,
            remote_execution_properties = {
                "OSFamily": "Windows",
            },
            remote_execution_use_case = "buck2-default",
            use_windows_path_separators = True,
        ),
    )

    constraints2 = dict()
    constraints2.update(ctx.attrs.os_configuration_linux[ConfigurationInfo].constraints)
    platform1 = ExecutionPlatformInfo(
        label = name,
        configuration = ConfigurationInfo(
            constraints = constraints2,
            values = {},
        ),
        executor_config = CommandExecutorConfig(
            local_enabled = host_info().os.is_linux,
            remote_enabled = True,
            use_limited_hybrid = True,
            remote_execution_properties = {
                "OSFamily": "Linux",
            },
            remote_execution_use_case = "buck2-default",
            use_windows_path_separators = False,
        ),
    )

    return [
        DefaultInfo(),
        ExecutionPlatformRegistrationInfo(platforms = [platform_windows, platform1]),
    ]

platforms = rule(
    impl = _platforms,
    attrs = {
        "use_windows_path_separators": attrs.bool(default = False),
        "os_configuration_windows": attrs.dep(
            providers = [ConfigurationInfo],
            default = "config//os:windows",
        ),
        "os_configuration_linux": attrs.dep(
            providers = [ConfigurationInfo],
            default = "config//os:linux",
        ),
    },
)

So this does work and it is a feature that bazel does not have today.
I am keeping this issue open for now because this feature deserves a bit more documentation / examples:

exec_compatible_with
ExecutionPlatformRegistrationInfo with more that one platform

CC @lmvasquezg who is looking at documentation


Omit browserify-preprocessor from dependencies

This reverts a previous change to add @cypress/browserify-preprocessor to this package's dependencies.  It also clarifies usage in the README for Clojurescript-only and CLJS + JS environments.
⚠ I had trouble testing this locally.  I could not discern if my troubles were related to this change or just with npm linking.

Sorry, have been a bit lazy with this :/ Seems that since last summer when hacking on this, Cypress was on version 4.x, now it's on version 6.x (!). Also seems that version 5.0.0 switched to using Webpack preprocessor by default: https://docs.cypress.io/guides/references/changelog.html#5-0-0

Cypress no longer supports file paths with a question mark ? or exclamation mark ! in them. We now use the webpack preprocessor by default and it does not support files with question marks or exclamation marks. Addressed in #7982.

So it makes even more sense to remove the dependency to browserify preprocessor I guess :)
If I remember correctly, the problem was that if one does not delegate to the default preprocessor, the file is not preprocessed at all, which is a problem for even the sample code of a fresh cypress install, since the samples use code that requires preprocessing. So if a custom preprocessor doesn't handle a file, the fallback has to be explicitly written.
The makeBrowserifyPreprocessor() reference in the readme in this PR relies on makeBrowserifyPreprocessor being available. The original readme had a more full example, on installing the cypress/browserify-preprocessor dependency and making the helper available via
const makeBrowserifyPreprocessor = require('@cypress/browserify-preprocessor');

What is a bit funny that I now don't remember how one could fallback to use the default preprocessor bundled inside Cypress installation. Might be good to look if there is an instruction for that (maybe I missed) or if not, hop onto the Cypress 6.x time and even use the webpack preprocessor (https://github.com/cypress-io/cypress/tree/master/npm/webpack-preprocessor), since this is what new projects would probably use.

Sorry, have been a bit lazy with this :/ Seems that since last summer when hacking on this, Cypress was on version 4.x, now it's on version 6.x (!). Also seems that version 5.0.0 switched to using Webpack preprocessor by default: https://docs.cypress.io/guides/references/changelog.html#5-0-0

Cypress no longer supports file paths with a question mark ? or exclamation mark ! in them. We now use the webpack preprocessor by default and it does not support files with question marks or exclamation marks. Addressed in #7982.

So it makes even more sense to remove the dependency to browserify preprocessor I guess :)
If I remember correctly, the problem was that if one does not delegate to the default preprocessor, the file is not preprocessed at all, which is a problem for even the sample code of a fresh cypress install, since the samples use code that requires preprocessing. So if a custom preprocessor doesn't handle a file, the fallback has to be explicitly written.
The makeBrowserifyPreprocessor() reference in the readme in this PR relies on makeBrowserifyPreprocessor being available. The original readme had a more full example, on installing the cypress/browserify-preprocessor dependency and making the helper available via
const makeBrowserifyPreprocessor = require('@cypress/browserify-preprocessor');

What is a bit funny that I now don't remember how one could fallback to use the default preprocessor bundled inside Cypress installation. Might be good to look if there is an instruction for that (maybe I missed) or if not, hop onto the Cypress 6.x time and even use the webpack preprocessor (https://github.com/cypress-io/cypress/tree/master/npm/webpack-preprocessor), since this is what new projects would probably use.

Hmm, haven't looked how other preprocessors work that much, but this made me wonder that is the conditional check even necessary, assuming that each preprocessor checks if a file should be processed: https://github.com/cypress-io/cypress/issues/5832#issuecomment-771142359


#317 consistent folder structure for tests

css lint fails with these errors.

><EMAIL_ADDRESS>lint:css /Users/bsr/tmp/react-boilerplate
> stylelint ./app/**/*.css

app/components/A/styles.css
 2:10  ✖  Expected "ADDD" to be "addd"      unit-case
 2:10  ✖  Unexpected unknown unit "ADDD"    unit-no-unknown
 6:10  ✖  Expected "CC0E5" to be "cc0e5"    unit-case
 6:10  ✖  Unexpected unknown unit "CC0E5"   unit-no-unknown

app/components/Button/styles.css
 24:21  ✖  Expected "ADDD" to be "addd"     unit-case
 24:21  ✖  Unexpected unknown unit "ADDD"   unit-no-unknown
 25:10  ✖  Expected "ADDD" to be "addd"     unit-case
 25:10  ✖  Unexpected unknown unit "ADDD"   unit-no-unknown
 29:15  ✖  Expected "ADDD" to be "addd"     unit-case
 29:15  ✖  Unexpected unknown unit "ADDD"   unit-no-unknown

but, tests run fine without it.
~/t/react-boilerplate ❯❯❯ NODE_ENV=test ./node_modules/.bin/karma start internals/testing/karma.conf.js --single-run                                                             317 ✖ ◼

START:
18 05 2016 12:14:10.216:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
18 05 2016 12:14:10.253:INFO [launcher]: Starting browser Chrome
18 05 2016 12:14:13.469:INFO [Chrome 50.0.2661 (Mac OS X 10.9.5)]: Connected on socket /#z6V0UfqlpUkxhxKwAAAA with id 16770893
ERROR: 'Warning: Failed propType: Required prop `href` was not specified in `A`.'

    ✔ should render its children
ERROR: 'Warning: Failed propType: Required prop `children` was not specified in `A`.'
    ✔ should adopt the className
    ✔ should adopt the href
    ✔ should adopt the target
  <Button />
    ✔ should render its children
ERROR: 'Warning: Failed propType: Required prop `children` was not specified in `Button`.'
    ✔ should adopt the className
    ✔ should render an  tag if no route is specified
    ✔ should render a button to change route if the handleRoute prop is specified
    ✔ should handle click events

    ✔ should render the copyright notice
    ✔ should render the credits

    ✔ should render its text

    ✔ should render its text

    ✔ should render its text

    ✔ should render an  tag
    ✔ should have an alt attribute
  <IssueIcon />
    ✔ should render a SVG
  <List />
    ✔ should render the component if no items are passed
    ✔ should render the items
  <ListItem />
    ✔ should adopt the className
    ✔ should render the content passed to it
  <LoadingIndicator />
    ✔ should render 14 divs
  App Actions
    loadRepos
      ✔ should return the correct type
    reposLoaded
      ✔ should return the correct type and the passed repos
    repoLoadingError
      ✔ should return the correct type and the error
ERROR: 'Warning: Failed propType: Invalid prop `src` of type `object` supplied to `Img`, expected `string`.'
  <App />
    ✔ should render the logo
    ✔ should render its children
    ✔ should render the footer
  appReducer
    ✔ should return the initial state
    ✔ should handle the loadRepos action correctly
    ✔ should handle the reposLoaded action correctly
    ✔ should handle the repoLoadingError action correctly
  selectGlobal
    ✔ should select the global state
  selectCurrentUser
    ✔ should select the current user
  selectLoading
    ✔ should select the loading
  selectError
    ✔ should select the error
  selectRepos
    ✔ should select the repos
  selectLocationState
    ✔ should select the route as a plain JS object
  <FeaturePage />
    ✔ should render its heading
    ✔ should link to "/"
  Home Actions
    changeUsername
      ✔ should return the correct type and the passed name
  <HomePage />
    ✔ should render the loading indicator when its loading
    ✔ should render an error if loading failed
    ✔ should render the repositories if loading was successful
    ✔ should link to /features
  homeReducer
    ✔ should return the initial state
    ✔ should handle the changeUsername action correctly
  getGithubData Saga
    ✔ should dispatch the reposLoaded action if it requests the data successfully
LOG: undefined
    ✔ should call the repoLoadingError action if the response errors
  selectHome
    ✔ should select the home state
  selectUsername
    ✔ should select the username
  <NotFound />
    ✔ should render the Page Not Found text
    ✔ should render a button
    ✔ should link to "/"
  <RepoListItem />
    ✔ should render a ListItem
    ✔ should not render the current username
    ✔ should render usernames that are not the current one
    ✔ should render the repo name
    ✔ should render the issue count
    ✔ should render the IssueIcon
  hooks
    getHooks
      ✔ given a store, should return all hooks
    helpers
      injectAsyncReducer
        ✔ given a store, it should provide a function to inject a reducer
      injectAsyncSagas
        ✔ given a store, it should provide a function to inject a saga
  request
    stubbing successful response
      ✔ should format the response correctly
    stubbing error response
      ✔ should catch errors

Finished in 0.491 secs / 0.262 secs

SUMMARY:
✔ 65 tests completed

please make the necessary changes for css lint

Coverage remained the same at 98.417% when pulling ec2eec46f32ddbbb7ff44e3fac4c5d96904bbdd2 on bsr203:317 into e18a3bcc3ed55f55a0217b6d6be88b64f6c89425 on mxstbr:master.

Awesome, thanks!