Screen reader not announcing when setting breakpoints

VSCode Version: 1.1.0-alpha
OS Version: Windows 10

Steps to Reproduce:
Using NVDA

Open a file
Set a breakpoint

Nothing is being read by NVDA when hovered over or when setting a breakpoint.

Hovering over should not announce anything since hover is not accessible anyways.
Setting a breakpoint is an explicit user action, and to be concise we do not repeat to the user what action he just executed.
Closing this as designed.
@zersiax can correct me if I am wrong and I can change the behavior

@vsccarl let me see if I understand you correctly because I think there's two things you could be meaning here:

You want a verbal confirmation right after you have set the breakpoint, something like 'Breakpoint set'. There's two sides of this one, @isidorn thinks to not give any representation at the moment of setting a breakpoint. While I do understand the reasoning, I'm wondering if being concise is in this case impeding user experience. Setting a breakpoint is indeed an explicit action, but how easy is it to fat-finger? E.G., how easy is it to press either the wrong hotkey for it, or pressing it by mistake?  ALso, what happens visually when you set a breakpoint, will a visual indicator be shown briefly or will it appear to the left of the line, in the margin?
My questions have to do with the second thing you could be meaning, that is, somehow detecting  while going through the code where breakpoints have actually been set.  If there is no message about a breakpoint having been set, and there is no way to check if a line has a breakpoint on it, it is indeed an accessibility problem that a blind developer cannot see where breakpoints are in the code.  Checking for the existence of a breakpoint, if a breakpoint shows up as a visual icon next to a line, is part of a bigger issue that encompasses all visually apparent live information being unavailable to screenreaders. Think of squiggles for errors as well, for example. Would like to hear more thoughts on this one.

@zersiax thanks a lot for the feedback!
When you set a breakpoint there is a visual indicator shown on the left of the line, in the margin. Due to the reasons you mentioned I am reopening this bug and we will announce once a user sets a breakpoint.
Currently a user can check the state of his breakpoints by navigating all the way to the breakpoint pane inside the debug viewlet - and he can navigate all the breakpoint items in the tree.
I agree that we should improve more on making the ux state accessible. Pinging @stevencl so he can read your comment.

I thought it would be something like that. I recommend creating a new issue to report visual indicators on a per-line basis to assistive technology. Ramifications of this would be huge, major accessibility improvement if we pull this off. Proposed flow (feel free to copy to separate issue):

use code for spawning visual indicator next to line for assistive technology logic to determine what lines to flag. Guessing medium difficulty.
Create short, descriptive strings  to indicate the function of the indicator. 'has breakpoint' ;has error' 'has warning', 'has monkey'...whatever other indicators exist within Code. I'd be the last person to know which ones exist ;) This isn't all that difficult, but don't make them longer than 2, maybe 3 words.

Now this is where it gets interesting, because there's a number of things we can do here. What comes to mind, from most favorable to least favorable. Please chip in if anyone has other ideas:

Append the string to the end of the line being read by the screenreader. I don't know if this is even possible since you are going to somehow have to track focus within the multiline edit field the code is in and do some ARIA magic to append the string to the end of what is being read, maybe through an invisible live region of some kind.
Play a short sound when a particular indicator is required. A click, a short blip or ding, not entire symphonies please. We are trying to stay productive here :) Again, not sure how technically feasible this is. My JS isn't that advanced yet ;) For this approach the short strings as I suggested above would not be required
Add a hotkey that cycles between the various visual indicators that are present, speak the type of indicator and add a third hotkey to query what for example the error contents are. Perhaps the hotkey for querying error messages is a universal concept to all these ideas, I don't know what the visual flow for this is.  The reason this is lower down the list is because we would lose the 'live' aspect. Ideally this is added in after idea 1 or 2 has already been implemented.
Modify the line's formatting and make clear on the accessibility documentation page that screenreaders need to be set to read formatting changes. A lot of users have these settings disabled, and for good reason because it can get quite spammy. Screenreaders can query a line or character's formatting with a hotkey but only do so if they know some useful info might be gleaned from this. This will of course affect sighted users as well though, this is therefore an 'if all else fails' solution.

What are your thoughts on all this? Implementing one of these solutions would fix this issue and a myriad of others,  while shooting Code's accessibility up into the stratosphere.

Thanks a lot for feedback! For clearity , I have created a seperate issue #6583

Reopened: on OS X I see correct VoiceOver messages when setting and clearing a breakpoint for the first time. If I set a previously removed breakpoint again, the "Removed Breakpoint..." message stays.

This is the bug with VoiceOver, they are trying to be concise by not reading the same message multiple times. However in this case the message should be re-read.
I already I correctly call aria.status. I get the same behavior if I do aria.alert so there is nothing we can do here

@isidorn just to be clear: I'm not expecting the same message multiple times. I'm expecting that it toggles between "Added Breakpoint..." and "Removed Breakpoint..." messages.

@weinand yes, but voice over api does not support toggling. It just supports that I report a message to it. I report message A which has already been reported and for some mysterious reason(bug on their side) message A is not read out because it was read out some time ago

@weinand does the message actually get spoken multiple times? As in ...does it say Removed again? Or do you come across it when navigating around?

@isidorn aha, now I understand. Thanks for clarification.

@isidorn  I'm actually surprised you got VoiceOver to read things on OS X at all, I heard someone say they had a lot of trouble making things read on the latest OS X, where an older version apparently worked fine

@zersiax it works, but there are many bugs :)

@zersiax I'm doing the following:

set a breakpoint in the editor gutter
remove the breakpoint in the editor gutter
set breakpoint again
remove it again
etc.

In VoiceOver I hear exactly two message:

Breakpoint added in line...
Breakpoint removed in line....

So I do not hear messages for the second add/remove.
Only if I set a breakpoint in a different line and then come back to the original line, I hear messages again.


Typo "a Azure Database"→"an Azure Database"

https://learn.microsoft.com/en-us/azure/mysql/flexible-server/how-to-manage-firewall-cli
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/mysql/flexible-server/how-to-manage-firewall-cli.md
#PingMSFTDocs

Thanks @hyoshioka0128!


remove deprecated lemmas and simp tags

This PR is stacked on top of #14644. See #14745 for the total PR against master.

LGTM to me.


build: migrate from commonjs to esmodules

Proposed changes
Migrate from CommonJS to ESModules
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

/create-rc


next/86/20241217/v1

Staging:

#2180
#2192

By the way, https://github.com/OISF/suricata-verify/pull/2190 is also a SV PR passing without other changes


Promote integration-service from staging to production

Included PRs:

https://github.com/konflux-ci/integration-service/pull/760
https://github.com/konflux-ci/integration-service/pull/768
https://github.com/konflux-ci/integration-service/pull/766

/test appstudio-e2e-tests

/approve
/lgtm


perf: merging constraints in plonk

In plonk, when one creates a new variable like this for instance
z := api.Add(api.Mul(x,y), 4)
2 constraints are created, even if the intermediate result api.Mul(x,y) is not reused.

I have an idea, which will be I think efficient to implement. (it accidentally solves #242 ).
For a R1CS, idea is when you add a new constraint, if it’s in the form 1 * X == Y,  then, you always replace X by its original expression .
2 cases:

a * b == X

X * a == b

we end up with a * b == Y

we end up with Y * a == b

You keep a map of “orphans” constraints (ie a “new internal wire” is created, you add it to the map. When it’s referenced in any subsequent constraint, you remove it from the map.
In a post compile phase, you delete all orphans and shift the ids accordingly (yet to figure out how to do that efficiently).
This approach make more sense for the Plonkish cs, since it avoids recursively “packing” linear/quadratic constraint into one. Currently with our api, if you write
y = x*x
-3y + yx + 2x == 0
it is going to create 4 constraints;

y = x *x
y * x = z
2x - 3y = a
a + z == 0

with this proposition, it would be

y = x*x
y * x = z —> orphan
2x - 3y = a —> orphan
2x - 3y + y*x = 0

The idea is similar to R1CS, except, our API mostly creates either “linear” or “quadratic” plonkish constraints now.
Note that since the parallel solver PR, we build a map of wire -> constraint (ie which constraint solved which wire) at post compile phase, and this data structure may be useful sooner 👍 .

closing, superseded by plonk+custom gates wip.


Can't edit settings

For some reason I can't edit the settings.  Could be a problem with the latest nightly build? 0.6.4+nightly20220322 (Mac version.) Even editing the JSON file and restarting doesn't help?

There’s a current issue with logseq, i’ve reported it on github in the main repo. The interim solution is editing it by giong to the plugins page -> find the custom workflows plugin -> and click the gear button and then “edit settings"
On 23 Mar 2022, 12:12 PM +0400, P. Kerim Friedman @.***>, wrote:

For some reason I can't edit the settings. Could be a problem with the latest nightly build? 0.6.4+nightly20220322 (Mac version.) Even editing the JSON file and restarting doesn't help?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

That seems to work.


[stable/prometheus-operator] PSP and RBAC for webhooks

What this PR does / why we need it:
Adds global.config.rbac checks and Pod Security Policy to the new admission webhooks.
Which issue this PR fixes

fixes #16013

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ X ] DCO signed
[X ] Chart Version bumped
[X ] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/lgtm
Thanks for taking care of this one!

/retest


TypeError: 'NoneType' object is not subscriptable

Expected Behavior
Please describe the behavior you are expecting.
Installed using install.bat
Downloaded model via browser option
Converted this model.
Install completed.
opened Run.bat
it works?
Current Behavior
Please describe the behavior you are currently experiencing.
open run.bat
gets error
HHHHHHHHHHHHH.##  HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHHH#.HHHHH/*,*,*,*,*,*,*,*,***,*,**#HHHHHHHHHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHHHHH.*,,***,***,***,***,***,***,*******HHHHHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHHH*,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,*,,,,,HHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHH.,,,***,***,***,***,***,***,***,***,***,***/HHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHH*,,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*HHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHH#,***,***,***,***,***,***,***,***,***,***,***,**HHHHHHHHHHHHHHHHH                                        HHHHHHHHHHHHH.##  HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHHH#.HHHHH/*,*,*,*,*,*,*,*,***,*,**#HHHHHHHHHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHHHHH.*,,***,***,***,***,***,***,*******HHHHHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHHH*,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,*,,,,,HHHHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHH.,,,***,***,***,***,***,***,***,***,***,***/HHHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHH*,,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*HHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHH#,***,***,***,***,***,***,***,***,***,***,***,**HHHHHHHHHHHHHHHHH
HHHHHHHHHH..HHH,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,*#HHHHHHHHHHHHHHHH
HHHHHHH,,,**,/H*,***,***,***,,,*,***,***,***,**,,,**,***,***,***H,,*,***HHHHHHHH
HHHHHH.*,,,*,,,,,*,*,*,***#HHHHH.,,*,*,*,*,**/HHHHH.,*,*,*,*,*,*,*,*****HHHHHHHH
HHHHHH.*,***,*,*,***,***,.HHHHHHH/**,***,****HHHHHHH.***,***,***,*******HHHHHHHH
HHHHHH.,,,,,,,,,,,,,,,,,,,.HHHHH.,,,,,,,,,,,,.HHHHHH,,,,,,,,,,,,,,,,,***HHHHHHHH
HHHHHH.,,,,,,/H,,,**,***,***,,,*,***,***,***,**,,,,*,***,***,***H***,***HHHHHHHH
HHHHHHH.,,,,*.H,,,,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,***H*,,,,/HHHHHHHHH
HHHHHHHHHHHHHHH*,***,***,**,,***,***,***,***,***,***,***,***,**.HHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHH,,,,,,,,*,,#H#,,,,,*,,,*,,,,,,,,*#H*,,,,,,,,,**HHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHH,,*,***,***,**/.HHHHHHHHHHHHH#*,,,*,***,***,*HHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHH,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*,*HHHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHH**,***,***,***,***,***,***,***,***,***,***,*.HHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHH*,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,*HHHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHHH**,***,***,*******/..HHHHHHHHH.#/*,*,,,***,***HHHHHHHHHHHHHHHH
HHHHHHHHHHHHHHHHH*,*,*,******#HHHHHHHHHHHHHHHHHHHHHHHHHHHH./**,,,.HHHHHHHHHHHHHH
Checking discussions database...HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH.*#HHHHHHHHHHHH
llama_model_load: loading model from './models/gpt4all-lora-quantized-ggml.bin' - please wait ...
llama_model_load: n_vocab = 32001
llama_model_load: n_ctx   = 512
llama_model_load: n_embd  = 4096
llama_model_load: n_mult  = 256
llama_model_load: n_head  = 32
llama_model_load: n_layer = 32
llama_model_load: n_rot   = 128
llama_model_load: f16     = 2
llama_model_load: n_ff    = 11008
llama_model_load: n_parts = 1
llama_model_load: type    = 1
llama_model_load: ggml map size = 4017.70 MB
llama_model_load: ggml ctx size =  81.25 KB
llama_model_load: mem required  = 5809.78 MB (+ 2052.00 MB per state)
llama_model_load: loading tensors from './models/gpt4all-lora-quantized-ggml.bin'
llama_model_load: model size =  4017.27 MB / num tensors = 291
llama_init_from_file: kv self size  =  512.00 MB
Traceback (most recent call last):
  File "E:\Git_repos\gpt4all-ui\app.py", line 441, in <module>
    bot = Gpt4AllWebUI(app, args)
  File "E:\Git_repos\gpt4all-ui\app.py", line 86, in __init__
    self.prepare_a_new_chatbot()
  File "E:\Git_repos\gpt4all-ui\app.py", line 102, in prepare_a_new_chatbot
    self.condition_chatbot()
  File "E:\Git_repos\gpt4all-ui\app.py", line 118, in condition_chatbot
    if self.db.does_last_discussion_have_messages():
  File "E:\Git_repos\gpt4all-ui\db.py", line 153, in does_last_discussion_have_messages
    last_discussion_id = self.select("SELECT id FROM discussion ORDER BY id DESC LIMIT 1", fetch_all=False)[0]
TypeError: 'NoneType' object is not subscriptable

Steps to Reproduce
Please provide detailed steps to reproduce the issue.
Installed using install.bat
Downloaded model via browser option
Converted this model.
Install completed.
opened Run.bat
Possible Solution
If you have any suggestions on how to fix the issue, please describe them here.
Context
Please provide any additional context about the issue.
Screenshots
If applicable, add screenshots to help explain the issue.

Was just about to post this as well. At first I thought it was from doing a git pull of latest code, so I uninstalled & deleted everything then started over, still get same error as you got, no errors on install, only this one when running run.bat
It was working fine before, so its recent changes that did this.

i just installed this, i have no notion of previous versions :(

I am on windows 10, what OS are you using?
It worked great before so hopefully someone will figure which recent commit caused the bug, or some way to resolve it.
Looking at the error is not apparent to me yet what the fix might be.

I am on windows 11. Few hours ago i tried to install this on debian 11 but got different error with illegal action or some sore of that type of error.
I really have no idea how to debug this. Wanted to see how smooth this works compared to GPT3.5

It works really surprisingly well, very impressive, for me its also very fast on my CPU an AMD ryzen 5900x YMMV.
I will keep tinkering, but not sure im capable of fixing it lol
I just noticed in the releases page there's a release from 4 days ago, I will test installing that instead to see if it fixes it, perhaps using git clone on the main branch was not best way lol.

i tried that release, it gives me error check internet connection, cant even download the packages it needs when running install.bat.
I got 5900x too and 3090 :), also i wanted to test other models too, given that they need more ram/vram

I think this ai is far more reliant on CPU than others tend to be, except perhaps for training that is, ive not tried to train anything with it yet so I dunno.
Hopefully others are hitting this bug now & will report it too, or someone might guess at a fix, I was all excited to sit and chat with it again.

I saw a video on youtube and was interested to toest it. It failed to install for me on debina, then when i got home, it even failed to install on windows :(. Oh well, gotta wait for devs to fix this. Gonna try out tomorrow

I can see the errors are being thrown by this recent commit. The lines in question are new.
https://github.com/nomic-ai/gpt4all-ui/commit/a431586f053f80965aa13f5d53c442acf2bfeb7e

Exactly the same issue on macOS (M1 Pro):
Traceback (most recent call last):
  File "/Users/hermes/Developer/gpt4all-ui/app.py", line 441, in <module>
    bot = Gpt4AllWebUI(app, args)
          ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hermes/Developer/gpt4all-ui/app.py", line 86, in __init__
    self.prepare_a_new_chatbot()
  File "/Users/hermes/Developer/gpt4all-ui/app.py", line 102, in prepare_a_new_chatbot
    self.condition_chatbot()
  File "/Users/hermes/Developer/gpt4all-ui/app.py", line 118, in condition_chatbot
    if self.db.does_last_discussion_have_messages():
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hermes/Developer/gpt4all-ui/db.py", line 153, in does_last_discussion_have_messages
    last_discussion_id = self.select("SELECT id FROM discussion ORDER BY id DESC LIMIT 1", fetch_all=False)[0]
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
TypeError: 'NoneType' object is not subscriptable

Same issue qq

Ok so thats Windows & Mac, could it be something in that commit I posted is linux specific?
Perhaps thats why they didnt notice the bug when testing.

Found this, but not sure how to remedy, seems it could be the fetch_all=False)[0] on line 153 of db.py
" In general, the error means that you attempted to index an object that doesn't have that functionality. You might have noticed that the method sort() that only modify the list have no return value printed – they return the default None. This is a design principle for all mutable data structures in Python.
This TypeError is the one thrown by python when you use the square bracket notation object[key] where an object doesn't define the getitem method . You can reproduce TypeError that you get in your code if you try this at the Python command line:"
https://net-informations.com/python/err/nonetype.htm

ok but how do you fix it? im no python expert.

I have no idea either, have never worked with python before, fetch_all=False)[0] is used several times in db.py & is coming from def select starting at line 76 which returns the cursor object.  But I havnt a clue how to " define the getitem method" or if thats even the reason we're getting a nonetype error. 😅

the way i see it someone forgot to initiate db with empty data. thats why it cant pull from db.

Ahh that seems possible, would explain why they didnt notice anything because their db had stuff so the if self.current_discussion is None:  never fired for them.
I did have it installed and working though, when I did a git pull then started again it was no longer working with other issues, so I scrapped it and started fresh which lead me here.  I might try reverting the commit I linked above & see if it actually is that commit that caused the troubles.

Ok so not a fix but it does get it working, just resetting your local code to the commit before the Enhanced Ui commits.  I tested and its working, chatting and all.
git reset --hard 32a45fc2c5f14bba551e63d70826775ae3c70697

Ok so not a fix but it does get it working, just resetting your local code to the commit before the Enhanced Ui commits. I tested and its working, chatting and all.
git reset --hard 32a45fc2c5f14bba551e63d70826775ae3c70697

thanks, this worked for me :)

Hi gues. I understand the error. Mybad. I have made this update to the database without testing the case where the database is empty.
I'll correct the problem and commit the update.

It should work now.
Sorry, I made too many changes and didn't test all cases. I need to add some unit tests for this all once it is stable.
Bare with me as I still wait the updates from the python bindings team to accelerate the generation process. Now when you post a message, I have to wait fror the model to first spit out your prompt then start spitting the model output, which, as you may expect makes it really slow to the end user. You can see data coming on the terminal but in the UI I only start updating once the model output starts pooring.
One this is corrected, the application will be way more easy to use.

Cheers!
Yea I noticed that it was going thru the whole text again so slower than before, seemed to also hit a prompt limit since its counting all of previous prompts in the character limit, I thought that might have been due to my doing the reset to previous commit though. I will test again with your latest changes. Thanks again for working on this!

Ok I tested again, everything loaded up fine, so I think you've sorted the issue with empty db.
I went ahead & also tested the token limit & it did hit that after a handful of prompts, but thats unrelated to this particular issue with the empty db of course.

Thank, you. I'll close the issue then.
As of the token limit it is a parameter ctx_size that you can pass to the run script or the app.py scrpipt. by default it is 512.


v1.9 backports 2020-10-21

v1.9 backports 2020-10-21

[x] #13630 -- contrib: match commit subject exactly when searching for upstream commit (@tklauser)
[ ] #13376 -- ci: run baseline perf tests nightly (@nebril)
[ ] #13639 -- images: Fix handing of dev suffix when tag is used (cilium/image-tools#76) (@errordeveloper)
[x] #13604 -- k8s/watchers: fix data race in (*K8sWatcher).addK8sServiceV1 (@tklauser)
[ ] #13299 -- Add log when allocate nodecidr failure (@konghui)
[x] #13295 -- test: Debug RuntimeConntrackInVethModeTest flake (@pchaigno)
[x] #13612 -- eni: Fix data race during multiple updates at once (@christarazi)
[ ] #13640 -- docs: Document some caveats of kube-proxy replacement (@brb)
[ ] #13638 -- bpf: fix up lrp for v4-in-v6 sockets (@borkmann)
[ ] #13424 -- Expose operator azure-user-assigned-identity-id flag to its chart (@ombre9)
[ ] #13632 -- docs/gettingstarted: Update AKS instructions (@twpayne)
[ ] #13646 -- bpf: redirect fixes and follow-ups (@borkmann)
[x] #13643 -- docker: update Hubble CLI to v0.7.0 (@Rolinh)
[x] #13642 -- checkpatch: switch to an external container image (@qmonnet)
[ ] #13620 -- vendor: pin yaml.v2 to v2.2.8 (@twpayne)
[ ] #13550 -- operator: Fix CEP owner type (@jrajahalme)
[ ] #13651 -- docs: fix minor issue in cilium support with external etcd gsg (@fristonio)
[x] #13644 -- Fixes for troubleshooting guide re. Hubble/Hubble Relay (@tklauser)
[ ] #13645 -- docs: GKE - fix some indentation, specify bash code segments (@ti-mo)
[x] #13665 -- docs: NodePort XDP on GCP is not supported (@gandro)
[ ] #13654 -- k8s: update k8s libraries to 1.19.3 (@aanm)
[x] #13661 -- docs: Fix broken formating and link (@pchaigno)
[x] #13607 -- helm: Remove hardcoded port check for hubble, etc (@nathanjsweet)
[ ] #13677 -- helm: keep encryption interface value undefined (@kkourt)
[x] #13684 -- install/kubernetes: remove nodePort.device from values (@tklauser)

Once this PR is merged, you can update the PR labels via:
$ for pr in 13630 13376 13639 13604 13299 13295 13612 13640 13638 13424 13632 13646 13643 13642 13620 13550 13651 13644 13645 13665 13654 13661 13607 13677 13684; do contrib/backporting/set-labels.py $pr done 1.9; done

My commit looks good!

test-backport-1.9

test-backport-1.9

tldr; checkpatch is to be ignored
make -C bpf checkpatch is being overly pedantic about the commit message. I tried fixing it once and was able to reduce the error to a warning, but the checkpatch script still exits > 0 even on warnings. I decided to go back to the original commit message structure, because it seemed important. All the other bpf checks are successful, and checkpatch is only complaining about the commit messages not the code in anyway.

tldr; checkpatch is to be ignored

@nathanjsweet I noticed the same and added one error I think would be worth ignoring at https://github.com/cilium/cilium/issues/12467.


compilemessages: Use a consistent ordering for the languages list.

This makes the generated data more consistent.
Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Backported to 5.x as 214df3ea1fca196726dd42e3d7eb7519663f0874.


Feature/cldn 797

Caps the number of columns and metrics in the data set explore window to 50 initially before a user clicks a show more button that displays the rest.

Code looks good to me. Now might be the time to start chatting on the upstream ticket about what they want the UI to look like. I have a feeling this button might not jive super well with Superset's style.


[FLINK-17257][yarn][test] Fix AbstractYarnClusterTest not compiling with hadoop 2.10.

What is the purpose of the change
In AbstractYarnClusterTest, we create ApplicationReport with the static method ApplicationReport.newInstance, which is annotated as private and unstable. This method is no longer compatible in Hadoop 2.10.
As a workaround, we can create ApplicationReport with its default constructor and set only the fields that we need.
Verifying this change
This is a pure testing change which does not affect the production codes. Manually tested with Hadoop 2.4, 2.8, 2.10 and 3.2.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @zhuzhurk


add config order

Pull Request Test Coverage Report for Build 42

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 96.041%

Totals

Change from base Build 41:
-0.04%

Covered Lines:
1892

Relevant Lines:
1970

💛  - Coveralls


WIP: Module mapping file and corresponding command line option

Closes #76

It's still needed a fix on load_mapping_from_file to consider the case when there is a space between two modules instead of a coma:
m0: m1 m2

@rsarm We will need to document this feature, too.


Enable "Claim Rewards" button on the Staking Contract

A new YIP passed that allows governance stakers to claim rewards without having voted recently. The rewards can be claimed directly from etherscan, but the button on the UI is still greyed out. Can this button be enabled?

@DeFiGod1
That functionality is on the ygov repository.
A PR was submitted for this and it was merged in 4 days ago.
https://github.com/iearn-finance/ygov-finance/pull/23
I don't control deployments, so not 100% sure when it will go live.


v0.0.16 does not delete an outdated Rule in a Listener it manages, breaks the Service

We've upgraded the Controller from v0.0.15 to v0.0.16 and now one of the Lattice Services the Controller manages has an extraneous Rule not described in any K8S resources. I think what's happening is that the naming conventions of the resources created by the Controller changed and it doesn't recognize the rules its former self-created before the upgrade. Regardless of the mechanism, the issue is that the v0.0.16 Controller does not ensure that the Lattice resources correspond to their K8S resource counterparts.
The first rule (Priority 1) below is the extraneous rule -- nowhere to be found in the K8S resources for this Lattice Service. The resulting service does not work because the Lattice Target Groupk8s-traffic-exemplar-traffic-exemplar is no longer even managed by the Controller and thus contains stale IPs.
Listener: traffic-exemplar-traffic-exemplar-4433-https
Routing:

k8s-1693522631-rule-1:

Condition: Path (Prefix): / (case sensitive)
Action: Forward to k8s-traffic-exemplar-traffic-exemplar: 1 (100%)
Priority: 1

k8s-1693522637-rule-1:

Condition: Header (Exact): target-group-type Value: staging-health-aws (case insensitive), Path (Prefix): / (case sensitive)
Action: Forward to k8s-traffic-exemplar-health-aws-traffic-exemplar-https-http2: 1 (100%)
Priority: 3

k8s-1693522633-rule-1:

Condition: Path (Prefix): / (case sensitive)
Action: Forward to k8s-traffic-exemplar-traffic-exemplar-https-http2 : 1 (100%)
Priority: 2

K8S Services:
apiVersion: v1
kind: Service
metadata:
  name: traffic-exemplar
  namespace: traffic-exemplar
spec:
  clusterIP: None
  ports:
  - port: 4433
    protocol: TCP
    targetPort: 4433
  selector:
    app: traffic-exemplar
    envoy-target-group-type: staging
---
apiVersion: v1
kind: Service
metadata:
  name: traffic-exemplar-health-aws
  namespace: traffic-exemplar
spec:
  clusterIP: None
  ports:
  - port: 4433
    protocol: TCP
    targetPort: 4433
  selector:
    app: traffic-exemplar
    envoy-target-group-type: staging-health-aws

K8S HTTPRoutes:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: traffic-exemplar
  namespace: traffic-exemplar
spec:
  parentRefs:
  - name: square
    namespace: lattice
    sectionName: http
  - name: square
    namespace: lattice
    sectionName: https
  rules:
  - backendRefs:
    - kind: Service
      name: traffic-exemplar-health-aws
      port: 8080
      weight: 1
    matches:
    - headers:
      - name: target-group-type
        type: Exact
        value: development-health-aws
      path:
        type: PathPrefix
        value: /
  - backendRefs:
    - kind: Service
      name: traffic-exemplar
      port: 8080
      weight: 1
    matches:
    - path:
        type: PathPrefix
        value: /

K8S TargetGroupPolicies
apiVersion: application-networking.k8s.aws/v1alpha1
kind: TargetGroupPolicy
metadata:
  name: traffic-exemplar
  namespace: traffic-exemplar
spec:
  targetRef:
    group: ""
    kind: Service
    name: traffic-exemplar
  protocol: HTTPS
  protocolVersion: HTTP2
  healthCheck:
    enabled: true
    intervalSeconds: 10
    timeoutSeconds: 5
    healthyThresholdCount: 3
    unhealthyThresholdCount: 2
    path: "/_status"
    protocolVersion: HTTP2
    statusMatch: "200,403"
---
apiVersion: application-networking.k8s.aws/v1alpha1
kind: TargetGroupPolicy
metadata:
  name: traffic-exemplar-health-aws
  namespace: traffic-exemplar
spec:
  targetRef:
    group: ""
    kind: Service
    name: traffic-exemplar-health-aws
  protocol: HTTPS
  protocolVersion: HTTP2
  healthCheck:
    enabled: true
    intervalSeconds: 10
    timeoutSeconds: 5
    healthyThresholdCount: 3
    unhealthyThresholdCount: 2
    path: "/_status"
    protocolVersion: HTTP2
    statusMatch: "200,403"

we need to investigate it more, thank you for filling issue

The controller is likely stuck at target registration here - backendRef port 8080 on your HTTPRoute means that you are only using targets that belong to the service port 8080, yet the services I see do not have any port on 4433. Have you tried changing backendRef ports to 4433 and check if it is happening?
The controller being stuck is being addressed in #386

Thanks. Unfortunately, I deleted that broken Lattice Service after filing this ticket. So, I cannot reproduce without downgrading the Controller which I'd rather not do. In the end, I think regardless of whether ports are correct, there should be at most 2 Rules in any Listener(s) the above setup creates. Why would there be more than 2?

In your case the controller cannot reach "the end state" - because of the issue mentioned above.
Our intended process of handling target group name change is:

New TGs with new naming schemes created
New rules created with new TGs
Stale rules are deleted
Stale TGs are deleted

What we are seeing here is most likely a state between 2 and 3.

I tried a few setup to reproduce the issue but I was mostly stuck between step 1 and 2 instead. Along with the bugfix, I will continue to explore if there is any other chance of rule mismatch.

This should be resolved by our upcoming v0.0.18 release.

This should be resolved with PR #457 which will be available in our next release.


Beckn Onix PRD Documentation with Functional Use Cases v0.1

Description
Develop a comprehensive PRD (Product Requirements Document) for Beckn Onix, detailing functional use cases and outlining key requirements for the project of Phase 1.
Goals

[ ] Draft the PRD document.
[ ] Include functional use cases specific to Beckn Onix.
[ ] Ensure clarity and completeness of requirements.

Expected Outcome
A finalized PRD document for Beckn Onix, providing a clear and detailed reference for functional use cases.
Acceptance Criteria

[ ] PRD document is completed and reviewed.
[ ] Functional use cases are clearly described.
[ ] Document is approved by stakeholders.

Mockups / Wireframes
NA
Product Name
Beckn
Domain
TBD
Tech Skills Needed

Requirements documentation
Functional analysis
Technical writing

Complexity
Medium
Category
Documentation
Sub Category
Requirements

Hey !  I Do this task

@viraj89, Please update the issue ticket with specific details, which we need from SidB

@viraj89, Please update the issue ticket with specific details, which we need from SidB

Based on this PRD link, issue ticket is updated.


Languages overlay: Flags for Khmer and Limburgish added

Description
Khmer (Cambodian flag) and Limburgish (Belgian flag) added to overlays/languages yml and md
Issues Fixed or Closed

Missing flags added to overlays

Type of Change
Please delete options that are not relevant.

[] New feature (non-breaking change which adds functionality)
[] Documentation change (non-code changes affecting only the wiki)

Checklist
Please delete options that are not relevant.

[] Updated Documentation to reflect changes

You have some conflicts, and can you add Limburgish to .github/.wordlist.txt


Change current simulator coreir.mem to have semantics of read before write instead of read after write

Just to clarify: In this test of simultaneous read and write to one memory location on this line would you like the value of self.getBitVec("self.read_data") to be BitVec(width, 0) (its value before the last call to state.execute()) or BitVec(width, 23) ?

I think it should be 23. You are setting the write value, then causing a rising edge of the clock, then checking the read value. If you checked the value of self.read_data before the execute statement, it should be 0.

Maybe we misunderstood each other yesterday. That is what the memory currently does.
I have added some more tests that show that memory read is combinational (changing raddr changes rdata on each execute call, regardless of whether a high clock edge arrived).
Could you send me a test case where the coreir.mem node is not doing what you would like?


docs(readme): link to @excalidraw/excalidraw npm package to give more visibility

Adding link to the main readme to increase the visibility of the package since it resides in the same repo

What about adding it before Development?

We could create a sample project using it..

We could create a sample project using it.

We already have code sandbox example no, we can extend that if needed? or you are talking about hosting it ourselves completely?

oh... didn't know.. I was thinking about a separate repo or something.. excalidraw-app, excalidraw-example-app, excalirdraw-starting-pack-using-npm..

oh... didn't know..

That gives a signal we might need to improve the readme :D

I was thinking about a separate repo or something.. excalidraw-app, excalidraw-example-app, excalirdraw-starting-pack-using-npm..

yep, I was thinking of having an example in our repo itself so it will also help in testing/ developement as well.

yep, I was thinking of having an example in our repo itself so it will also help in testing/ developement as well.

We could have example for every feature that it offers.. it makes sense to have a dead simple example.


Support named "special" operations in WebIDL

This commit adds support for two different features of the "special" operations
in WebIDL.
Second it implements the distinction between two different types of getters in
WebIDL, described as:

Getters and setters come in two varieties: ones that take a DOMString as a
property name, known as named property getters and named property setters, and
ones that take an unsigned long as a property index, known as indexed property
getters and indexed property setters.

The name get is given to DOMString arguments, and the name get_idx is given
to index property getters.

r? @afdw

Thanks for taking a look! It's true yeah the main motivation for doing this at all was mostly for consistency in that we want to support getter DOMString(DOMString name) as well as getter foo DOMString(DOMString name) so this was applying the desugaring the spec recommended.
For handling name collisions I like your idea better though, I'll plumb these into the overloaded map.

Ok updated!

OK, so now there are mostly readability changes.
I am not sure why there is even a vector of specials instead of 1 special. Grammar from the spec:

SpecialOperation ::
    Special RegularOperation

Special ::
    getter
    setter
    deleter

But here the spec says that there can be multiple keywords:

interface interface_identifier {
  /* special_keywords... */ return_type identifier(/* arguments... */);
  /* special_keywords... */ return_type (/* arguments... */);
};

But I believe that it is an another mistake that is not fixed after https://github.com/heycam/webidl/pull/562 and https://github.com/heycam/webidl/pull/573.

Ah seems reasonable to fix upstream in weedle! You mentioned some readability changes though, perhaps a comment that wasn't submitted?

No, I meant that now the diff on this PR is mostly changes that are aimed to increase the readability of the code.

Ah true yeah, it also handles though multiple getter methods with different types as well as the expansion of a getter+name into two methods


[Feature request] Add Starship prompt and customizations

The title! My Starship prompt and its customizations are available in my https://github.com/derekturtleroe/dotfiles repo, add them here and apply them. 😄

ebbb0320cfb038ae6bfd570588c327ae5e484f4c adds this to the script. 😄


Add provision to add the custom icon

Now, I can't change the zoom in and zoom out icon, Can you give configuration options for change the zoom in and zoom out icons.

I'm not sure what you are asking for here. Could you please fill out the description?

Sure, replace fullscreen.png (and<EMAIL_ADDRESS>with the icons you want.


Add Electron to Linux Debian packager

@oconnor663 This adds Electron to your Debian build, putting the GUI binary at:
/opt/keybase/Keybase
It doesn't do autostart yet.  So to test it you run keybase service &; /opt/keybase/Keybase.

Thanks!  Responded to every comment in 7c545db, PTAL?

Looks great, with the single optional nit above.


Write a C# program to find the smallest two elements in an array

Description
Write a C# program to find the smallest two elements in an array
Input  : arr[] = {12, 13, 1, 10, 34, 1}
Output : 1 1

Input  : arr[] = {10, 5, 10}
Output : 5 10

How to contribute

Comment !assign to assign this issue to yourself
Fork this repository
Create a new branch
Save the solution in program/program/find-the-smallest-two-elements-in-an-array/FindTheSmallestTwoElementsInAnArray.cs
Commit the changes
Create a pull request

!assign


wrong cd command in makefile

Current Behavior

The cd.. command in makefile, here is wrong.
Expected Behavior

It should be cd ..
Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Though it is not a "wrong" command, since there's no behavioral change in the outcome, it's better to follow the code conventions, you can go ahead and provide a quick fix.
Additionally,

Update the "Layer Community Welcome Guide" link to Newcomers' Guide in Readme.md
Update the play website preview image, (the toggle button was in the center earlier, the website is updated now) in Readme.md

incorporate these changes in a single PR and mention the changes made


feat: support passing query to loader

Summary
resolves https://github.com/web-infra-dev/rspack/issues/4396

Test Plan

Added
Require Documentation?

[X] No
[ ] Yes, the corresponding rspack-website PR is __

I don't suggest modify test under webpack-test, even if there are errors/warnings didn't match, this didn't mean we need to align all of these with webpack, this is only for tracking those mismatch
I made some change on this PR (revert changes under webpack-test and copy it into our test dir, and enable more webpack-tests which blocked by this)


fix issue #894

Summary
When I use this lib for excel exporting, I found that the issue with image exporting.
When add image with none integer coordinates, I get the wrong position in result file. I found others also facing this problem in issues like #894.
I make some test and lookup the data affter unziping the drawing.xml file. I found that the error is caused by the wrong colwidth and rowheight. The tl and br are set to float number, if the col and row are not resized, the result is ok. But when width or height of the cell, in which tl or br defined, were resized, the result were still calculated with the standard cell width and row. So we got the wrong result.
Test plan
I read the code related with this problem. Finally, I found the reason occured in anchor.js. There is my fix below.
Put the following code in the first line in constructor function. After this we can get the real column width and row height in worksheet.
this.worksheet = worksheet;
Then, modify the colWidth and rowHeight getters methods to get the correct number. As the default height or width can be undefined in worksheet properties, so we can add some protection code for below sample. We can check if the default heigth or width defined, if not, use constant value instead. (for example, height is 15, width is 9.14XXXXXX.)
Math.floor(this.worksheet.getRow(this.nativeRow + 1).height/this.worksheet.properties.defaultRowHeight * 180000) Math.floor(this.worksheet.getColumn(this.nativeCol + 1).width/this.worksheet.properties.defaultColWidth * 640000)
as the following code we put the image in xlsx with correct positions.
worksheet.addImage(imageId, { tl: {col: 1.1, row: 5.83 }, br: {col: 8.85, row: 10.2 } });
testimage

The master code can not pass npm test successfully with node 8.17.0 on ubuntu. So it seems that not mine modification causing this problem.
And, I got the successful result with node 12.22.1 on local.
My local os is ubuntu 20.04.2 LTS


I tried render, but the library is missing

I tried the render command, but I got the following error and couldn't execute it.
takuya@DESKTOP-NUC4BCK:~/game_of_life$ terminalizer render demo
Error:
  Error: /home/takuya/.config/yarn/global/node_modules/electron/dist/electron: error while loading shared libraries: libXcursor.so.1: cannot open shared object file: No such file or directory

I followed this information(How do I install libXcursor.so.1 on Debian? - Unix & Linux Stack Exchange) and tried to install libxcursor1 with apt.
takuya@DESKTOP-NUC4BCK:~/terminalizer$ sudo apt install libxcursor1
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer required:
  gyp javascript-common libc-ares2 libhttp-parser2.7.1 libjs-async libjs-inherits libjs-jquery libjs-node-uuid libjs-underscore libpython-stdlib libpython2.7-minimal libpython2.7-stdlib libssl1.0-dev libuv1-dev nodejs-doc
  python python-minimal python-pkg-resources python2.7 python2.7-minimal
Use 'sudo apt autoremove' to remove them.
The following NEW packages will be installed:
  libxcursor1
0 upgraded, 1 newly installed, 0 to remove and 7 not upgraded.
Need to get 19.8 kB of archives.
After this operation, 60.4 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu bionic/main amd64 libxcursor1 amd64 1:1.1.15-1 [19.8 kB]
Fetched 19.8 kB in 1s (22.1 kB/s)
Selecting previously unselected package libxcursor1:amd64.
(Reading database ... 40598 files and directories currently installed.)
Preparing to unpack .../libxcursor1_1%3a1.1.15-1_amd64.deb ...
Unpacking libxcursor1:amd64 (1:1.1.15-1) ...
Setting up libxcursor1:amd64 (1:1.1.15-1) ...
Processing triggers for libc-bin (2.27-3ubuntu1.2) ...

However, there still seems to be some libraries missing.
Is there any way I can resolve these dependencies at once?
takuya@DESKTOP-NUC4BCK:~/game_of_life$ terminalizer render demo
Error:
  Error: /home/takuya/.config/yarn/global/node_modules/electron/dist/electron: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory

My environment is as follows.
takuya@DESKTOP-NUC4BCK:~/game_of_life$ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.4 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.4 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic
takuya@DESKTOP-NUC4BCK:~/game_of_life$ uname -a
Linux DESKTOP-NUC4BCK 4.19.104-microsoft-standard #1 SMP Wed Feb 19 06:37:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build Instructions (Linux) | Electron
sudo apt-get install build-essential clang libdbus-1-dev libgtk-3-dev \
                       libnotify-dev libgnome-keyring-dev \
                       libasound2-dev libcap-dev libcups2-dev libxtst-dev \
                       libxss1 libnss3-dev gcc-multilib g++-multilib curl \
                       gperf bison python-dbusmock openjdk-8-jre

I solved this problem by installing electron's dependency library.
However, the render command is not yet working. There is no output.
I will look into this problem and if necessary, I will set up a new Issue.
Thank you.


⚠ AGEG website (prod) has degraded performance

In 1318375, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 4068 ms

Resolved: AGEG website (prod) performance has improved in f98ea98.


keychain failed with error 'Encryption failed'

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.64.2
OS Version: Windows 11

Steps to Reproduce:

Tried logging into github account for settings sync

Can you provide the contents of the GitHub Authentication output pane:

(like the picture, except GitHub instead of Microsoft)
And also anything that shows up in Dev Tools:

ctrl + shift + P
"Dev Tools"

I have been able to solve it

There was a credential manager error

@C-distin could you give me some more details so I can help future folks who end up in this state?


Remove valid4j

There are still references to it in the codebase even thought most usages were moved to jaffirm.

This is being pulled in via http://github.com/io7m/jpuddle


Not correct owner for tables when running dbt ingestion and similar team/user names

Affected module
I believe that this issue is due to the ingestion.
Describe the bug
I have few departments:

data-engineering
data-analytics

When I run dbt ingestion, the correspondent owner for tables that have dbt owner set to data-engineering is  DataInsightsApplicationBot. I expect that no owner is set, or one of the 2 department is set.
To Reproduce

add owner meta tag to few dbt models containing data-engineering for example
run the dbt-ingestion
check the owner assigned to those models

Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: Debian and MacOs
Python version: 3.11
OpenMetadata version: 1.4.7
OpenMetadata Ingestion package version: openmetadata-ingestion[dbt]~=<IP_ADDRESS>

Additional context
After a chat with Pablo Takara/Sriharsha Chintalapani/Onkar Ravgan looks like that data-engineering cannot be assigned as an owner because it's a departement, which is fine, but no owner should be assigned at all.
Seems like that  the issue is due to name_search_query_es where a fuzzy matching it's performed, leading to match DataInsightsApplicationBot (the closest to data-engineering).
I expect that:

an full equality match it's performed
bots are excluded from the matching

Here some findings regarding this issue.
In my understanding the issue seems related to the fact that - is used on the dbt_owner, therefore when name_search_query_es run, it evaluates as search for data without engineering, in my understanding the - is evaluated as a operator to tell Opensearch/Elasticsearch that should exclude some terms.
But what is weird, is that if I use data.engineering, therefore a . separator, seems to behave as -, and the bot is returned datainsightsapplicationbot
Also, worth to mention, that I tested this beavior in 1.4.7 and 1.5.0 dbt ingestion.
One of the solution that I'm adopting is to use "names" without a separator, because anyhow the Display name of a team can show what I want.
In my case therefore the team name will be dataengineering or dataanalytics.

fixed by https://github.com/open-metadata/OpenMetadata/pull/18645


ImportError cannot import name ‘rendering‘ from ‘gym.envs.classic_control‘

When I using ding  to deploy the agent with gym-hybrid env，I got the error
ImportError cannot import name ‘rendering‘ from ‘gym.envs.classic_control‘

my code is
from ding.bonus import PPOF

def hybrid_moving_deploy():
    agent = PPOF(env='hybrid_moving', exp_name='./hybrid_moving_demo')
    agent.deploy(enable_save_replay=True)

if __name__ == "__main__":
    hybrid_moving_deploy()

I found the problem is that ding  requires gym=0.25.1 which doesn't include rendering, but in gym_hybrid_env.py, it use env.render
def step(self, action: Dict) -> BaseEnvTimestep:
        if self._act_scale:
            if self._env_id == 'HardMove-v0':
                action = [
                    action['action_type'], [affine_transform(i, min_val=-1, max_val=1) for i in action['action_args']]
                ]
            else:
                # acceleration_value.
                action['action_args'][0] = affine_transform(action['action_args'][0], min_val=0, max_val=1)
                # rotation_value. Following line can be omitted, because in the affine_transform function,
                # we have already done the clip(-1,1) operation
                action['action_args'][1] = affine_transform(action['action_args'][1], min_val=-1, max_val=1)
                action = [action['action_type'], action['action_args']]
        if self._save_replay:
            self._frames.append(self._env.render(mode='rgb_array'))
        obs, rew, done, info = self._env.step(action)
        self._eval_episode_return += rew
        if done:
            info['eval_episode_return'] = self._eval_episode_return
            if self._save_replay:
                if self._env_id == 'HardMove-v0':
                    self._env_id = f'hardmove_n{self._cfg.num_actuators}'
                path = os.path.join(
                    self._replay_path, '{}_episode_{}.gif'.format(self._env_id, self._save_replay_count)
                )
                self.display_frames_as_gif(self._frames, path)
                self._frames = []
                self._save_replay_count += 1

Notice:
my python version is 3.9, and I install ding by git clone  and pip install -e .
I found conda install only support python3.7, but also wrong.
I just want to get the video result of gym-hybrid, how should I do?
And if I can keep using python3.9 is the best.

What is the gym version in your environment? For some compatibility problem, you need to train gym-hybrid with gym==0.25.1 and visualize replay videos with gym==0.22.0.

What is the gym version in your environment? For some compatibility problem, you need to train gym-hybrid with gym==0.25.1 and visualize replay videos with gym==0.22.0.

How to realize this process?
I found that the reason for the error mentioned mentioned

https://github.com/thomashirtz/gym-hybrid/issues/9
https://github.com/opendilab/DI-engine/pull/434
https://github.com/openai/gym/issues/2656

But I don't know the quickly and right way to deal with it.
If you can provide an official way to deal with the confict between the training gym version and the visualize one, I will be very appreciate it.
What's more, I think you also can put the solution in the FAQ or somewhere(like the README.md for the gym-hybrid env) to help more users.

OK, we will prepare a detailed demo for the visualization of gym-hybrid in one week.

Thanks a lot!


Action never times out if the target web app does not exist

Workflow File (sensitive info redacted)
name: Build and deploy Python app to Azure Web App - web-app

on:
  push:
    branches:
      - master
  workflow_dispatch:

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2

      - name: Set up Python version
        uses: actions/setup-python@v1
        with:
          python-version: '3.9'

      - name: Create and start virtual environment
        run: |
          python -m venv venv
          source venv/bin/activate

      - name: Install dependencies
        run: pip install -r requirements.txt

      # Optional: Add step to run tests here (PyTest, Django test suites, etc.)

      - name: Upload artifact for deployment jobs
        uses: actions/upload-artifact@v2
        with:
          name: python-app
          path: |
            .
            !venv/
  deploy:
    runs-on: ubuntu-latest
    needs: build
    environment:
      name: 'Env'
      url: ${{ steps.deploy-to-webapp.outputs.webapp-url }}

    steps:
      - name: Download artifact from build job
        uses: actions/download-artifact@v2
        with:
          name: python-app
          path: .

      - name: 'Deploy to Azure Web App'
        uses: azure/webapps-deploy@v2
        id: deploy-to-webapp
        with:
          app-name: 'web-app'
          slot-name: 'production'
          publish-profile: ${{ secrets.PUBLISH_PROFILE }}

Web App environment

Linux Web App
Python 3.9
P1v2 ASP

Steps to reproduce the issue

Create an Azure Web App
Export the publish profile and import it as a secret into GitHub
Create a workflow that uses this secret as a publish profile for the action
Delete the Web App created in the first step
Run the workflow, the workflow will hang trying to publish it but will timeout after 6 hours (GitHub's hard cap on workflows)

Expected behavior
The action should report a fail when the publish profile is invalid.
Actual behavior
The deploy job using this action hangs until killed by GitHub or the user.

@surenderssm -- In the immediate term it would be good to set a more reasonable timeout for this (such as 1 hour). An optional parameter would also be a nice addition:
      - name: 'Deploy to Azure Web App'
        uses: azure/webapps-deploy@v2
        id: deploy-to-webapp
        with:
          app-name: 'web-app'
          slot-name: 'production'
          timeout: '30m'  # or '1h' or '60s', etc.
          publish-profile: ${{ secrets.PUBLISH_PROFILE }}

Hi @8osm,
We have reproduced this issue and will be fixing this issue soon.

@8osm I tried deploying after deleting the app and it's not stuck for me. Can you please check if it's happening with your workflow?

@8osm do let us know if it's happening for you?

@8osm do let us know if it's happening for you?

Unfortunately, I am not able to try and reproduce this issue right now because I no longer work with Azure.

@8osm I understand. Would you help us with some feedback and the reason behind not using Azure anymore?

I have tried with APPs from ANT99 and ANT100 both, I am not able to repro. It's failing for me within 2 minutes and not hanging up. Adding one instance of the runs here.
Closing this issue.


Provide API to get a list of users and their ID's

Refer to existing implementation within facebook and skype for potential way of doing this

resolved by https://github.com/concierge/Kassy/commit/573909343333724779a08d9b2b687411d45f03fb


Try to remove OnFailure from ignition-complete.target

ignition-diskful.target is (sometimes) pulled in by ignition-complete.target, which is pulled in by initrd.target.  If any unit fails which is required by either of those Ignition targets, we would like to fail the boot and drop to an emergency shell.
initrd.target has:
OnFailure=emergency.target
OnFailureJobMode=replace-irreversibly

But relying on that doesn't work.  If we do, and a unit fails, we loop indefinitely in the initramfs.  That doesn't seem possible within the systemd depsolver, so it seems plausible that, as @jlebon suggested, initrd-switch-root.service is involved in the loop.
We're currently avoiding this by putting our own OnFailure clause in ignition-complete.target:
OnFailure=emergency.target
OnFailureJobMode=isolate

This fixes the problem for everything chaining up to ignition-complete.target.  (Note the isolate; the problem can also be fixed by putting OnFailureJobMode=isolate in a drop-in for initrd.target.)  But it'd be nice to track this down and conclusively determine why we need it, or whether this should be fixed upstream.
Note that the test case in the above bug no longer works on F30/F31.

I also can't provide a solution, but it seems that (with systemd 243) the boot loop is only triggered when the error is happening between initrd-root-fs.target and initrd-parse-etc.service (which is exactly where ignition-files.service is running).
This can be verified with the following modified service file from the original bug report:
[Unit]
Description=Foobar
DefaultDependencies=false
After=initrd-root-fs.target
Before=initrd-parse-etc.service
ConditionKernelCommandLine=foobar.fail=1

[Service]
Type=oneshot
ExecStart=/usr/bin/false

Unfortunately the currently implemented workaround using OnFailureJobMode=isolate will not work on openSUSE (and probably neither on any distribution not using ostree), as systemd will end up in the following ordering loop if sysroot.mount is present:
local-fs.target: Found ordering cycle on systemd-tmpfiles-setup.service/stop
local-fs.target: Found dependency on sysinit.target/stop
local-fs.target: Found dependency on basic.target/stop
local-fs.target: Found dependency on ignition-fetch.service/stop
local-fs.target: Found dependency on ignition-disks.service/stop
local-fs.target: Found dependency on sysroot.mount/stop
local-fs.target: Found dependency on sysroot-mnt.mount/stop
local-fs.target: Found dependency on local-fs.target/stop
local-fs.target: Unable to break cycle starting with local-fs.target/stop
Requested transaction contains an unfixable cyclic ordering dependency: Transaction order is cyclic. See system logs for details.
ignition-complete.target: Failed to enqueue OnFailure= job, ignoring: Transaction order is cyclic. See system logs for details.

https://github.com/coreos/ignition-dracut/pull/188


[BUG] Console not accessible when VM is still in status "not ready"

Describe the bug
The "Open in Web VNC" and "Open in Serial Console" buttons are not accessible when the VM is in status "not ready"

To Reproduce

create a VM with a Kubernetes readiness probe
start the VM
when the VM left the status "starting", while the VM is in status "Not Ready" and before the VM is in status "Running", try to open the console. Observe that the drop-down menu does not open.

Expected behavior
The console should be accessible.
Support bundle
(none)
Environment:

Harvester ISO version: 1.0.0
Underlying Infrastructure: VM on CentOS on bare-metal hetzner.com server

Additional context
In case it is technically possible to have the console already while the VM is still in "starting", that would be more awesome.
I'm filing this as a bug because if no readiness probe is configured, the consoles can access the VM. Consequently, a workaround for this bug is to remove the readiness probe.
This bug is hurting me atm because I have a failing readiness probe and I can't access the console output to analyze why it's failing.

Thanks for filing this!
My impression is that it's the dashboard web UI blocking users from accessing the dropdown menu. KubeVirt indeed supports accessing non-running VMs, so IMHO Harvester should provide the same functionality.
To circumvent this issue before the fix landed, you can use virtctl, a client tool to operate virtual machine, and execute virtctl console <vm> to access serial console. Otherwise, you can watch kubernetes event to check probe failures by running command like kubectl get events --watch.
Ref: https://github.com/kubevirt/kubevirt/blob/v0.50.0/docs/probes.md

Hello, @WuJun2016. Is it possible to relax the criteria of disabling the VMConsoleBar dropdown? I've tested preserving the web VNC window when the VM is stopped. And it shows only "This Virtual Machine is down" without breaking anything.

@DaiYuzeng   Please help to see in what state websocket can connect.

Verified this bug should be fixed.
Base on weihang's comment: https://github.com/harvester/harvester/issues/1938#issuecomment-1055098118 and Dai's change: https://github.com/harvester/dashboard/pull/293, I only test the console is able to start up.
I'm not sure it is fully fixed the bug, so if you still encountered it, feel free to reopen this issue.
(and please attach more information for us to reproduce it, thanks.)
Test Information

Environment: qemu/KVM single node
Harvester Version: master-b20a3b47-head
ui-source Option: Auto

Verify Steps:

Install Harvester with Any nodes
Create the Image for VM creation
Create a VM a
When VM is not in stop state, console of Open in Web VNC and Open in Serial Console should be accessible


Migrate CI to Github Actions

Description

Migrate CI to Github Actions cc @Andrew-Chen-Wang @arnav13081994
Checklist:

[x] I've made sure that tests/test_cookiecutter_generation.py is updated accordingly (especially if adding or updating a template option)
[x] I've updated the documentation or confirm that my change doesn't require any updates

This doesn't aim at adding any sort of caching but just to keep feature parity with Travis for now.
Rationale

Travis recently changed their pricing with hard limits to open source projects, Github actions have a higher allowace at the moment.
Fixes #2928

It LGTM. Just regarding 46a0b60a29d34d3b8654382408541a0c52b890e6, does pydanny commit directly to master? There might be a way to remove branches: [master] and add if github.actor == pydanny (example?) to prevent pyup from triggering but still allow pydanny to commit wherever.

I -and all core contributors- can commit directly to master as well.

@browniebroke Why do we need the 46a0b60a29d34d3b8654382408541a0c52b890e6 change?
From what I understand, this will disable ci on all pull-requests...
at least it was the conclusion I got testing this pr with (https://github.com/luzfcb/cookiecutter-django/pull/4) and without (https://github.com/luzfcb/cookiecutter-django/pull/5) the 46a0b60a29d34d3b8654382408541a0c52b890e6 commit

@browniebroke Why do we need the 46a0b60 change?
From what I understand, this will disable ci on all pull-requests...

I think that is fine. The pull requests CI will be just fine. Plus with pull_request it listens to reopen event as well.

I've recently moved 20+ repos from Travis CI to Github Action for my organization, let me know if you need help with this PR

@luzfcb Pyup uses several branches itself in this repository. That would mean pyup is running the CI in a branch here and in a PR.

@browniebroke Why do we need the 46a0b60a29d34d3b8654382408541a0c52b890e6 change?
From what I understand, this will disable ci on all pull-requests...
at least it was the conclusion I got testing this pr with (https://github.com/luzfcb/cookiecutter-django/pull/4) and without (https://github.com/luzfcb/cookiecutter-django/pull/5) the 46a0b60a29d34d3b8654382408541a0c52b890e6 commit

Hum, that's really odd. I was trying to avoid the duplicated status that you have in https://github.com/luzfcb/cookiecutter-django/pull/5 where each job run twice, once for the push event and once for the pull_request event. I mean, it's fine in this pull request as far as I can tell. I don't mind removing this last commit...

but I suspect it's because actions aren't run on forks

I suspect too, but again, it's strange that both run fine in the other case...


fix: Input batch to ShuffleRepartitioner.insert_batch should not be larger than configured batch size

Which issue does this PR close?

Closes #498.
Rationale for this change

What changes are included in this PR?

How are these changes tested?

cc @andygrove @sunchao

cc @huaxingao @kazuyukitanimura

Thank you @sunchao


Remove workspace chats on delete even if they are pinned

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/10355
Tests / QA Steps

Create a new workspace in Newdot if you don't have one:

It will create some default rooms:

Choose the Admins or Announce one and pin it. Then, move to a different chat.

Delete the Workspace:

The Pinned chat should disappear from the list (It may take a refresh, as that list doesn't auto-refresh that often)

@Gonals if this isn't newsletter urgent, I think it'd be a good PR to try out the ContributorPlusReview process to have them test your PR on all devices, etc.

@Gonals if this isn't newsletter urgent, I think it'd be a good PR to try out the ContributorPlusReview process to have them test your PR on all devices, etc.

Sounds good!

Hmmm. Doesn't the label tag anyone? Should I follow the process or tag someone from contributor management?

All the tests did pass Melv.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Is there a way to trigger an event of some sort to cause the chats to refresh instantly after deleting the workspace?

🚀 Deployed to staging by @puneetlath in version: 1.1.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Duplicate catch block is redundant and bloats the exception/catch stack

1. Why is this change necessary?
Small code quality improvement.
2. What does this change do, exactly?
Removes a redundant catch.
3. Describe each step to reproduce the issue or behaviour.
Debug through a request and get caught twice due to an uncaught exception.
4. Please link to the relevant issues (if any).
None
5. Which documentation changes (if any) need to be made because of this PR?
None.
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfill them.

Hey, würde das nicht das Rendern der Fehlermeldung deaktivieren? (die "Es ist ein Fehler aufgetreten"-Seite)
http://community.shopware.com/Fehlermeldungen-in-Shopware-debuggen_detail_1880.html#Frontend_Error_Reporter
Gruß Heiner

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-20736
Please use this issue to track the state of your pull request.

Thank you for the PR. I have reviewed the PR and it will be merged soon.


[WIP] Add table footer

Fix #2
Trying to add a footer for the table, this is a early PR just to ask if I'm in the right track.

Any dates? This will be great!

😂


Unable to download terraform from behind corporate proxy

By setting the environment variables REQUESTS_CA_BUNDLE to a suitable certificate and HTTPS_PROXY to our proxy url:port I was able to get the terraform init task to work, however the terraform installer task failed with:
019-03-13T02:41:23.8946531Z Terraform not installed, downloading from:  https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip
2019-03-13T02:41:23.8946531Z Terraform file name as:  terraform-0.11.13-c991dd85-d1a0-4f80-acf5-5787e2bd95ec.zip
2019-03-13T02:41:23.9102780Z Downloading: https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip
2019-03-13T02:41:26.2696371Z ##[error]Error: Terraform download from url 'https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip' failed with exception 'Error: tunneling socket could not be established, cause=getaddrinfo ENOTFOUND 80 80:80'
2019-03-13T02:41:26.2852608Z ##[section]Finishing: Use Terraform 0.11.13

@andrew-sumner
I am assuming that you are self-hosting the build agent to keep it behind the corporate proxy. When you configured the agent, did you specify your proxy as specified here?
The installer is using a library provided by the Azure Devops team to download terraform. This library will respect a configured proxy. This is done by looking at agent pipeline variables that, I believe, are set by providing the arguments in the article I referenced above.
Please check the article and see if that helps with the issue. Lastly, if it does not help can you set the system.debug build variable to true. This should emit the values of all agent variables in the log. Can you check if AGENT_PROXYURL and, AGENT_PROXYUSERNAME are being set to the appropriate proxy?
To set expectations, this may end up being more of an issue with the Azure DevOps self-hosted agent than this task specifically. It wouldnt make sense for each pipeline task to own the responsibility of being able to work behind a corporate proxy as all tasks would need this. However, I will make sure the task is using the expected means of downloading terraform the Azure DevOps product team expects.

Yes, I am using a self hosted TFS Agent (and TFS)  both latest versions.
I followed the guide for configuring the proxy but that hasn't helped the tool download issue:
2019-03-13T23:21:13.5570245Z ##[debug]Evaluating condition for step: 'Use Terraform 0.11.13'
2019-03-13T23:21:13.5570245Z ##[debug]Evaluating: succeeded()
2019-03-13T23:21:13.5570245Z ##[debug]Evaluating succeeded:
2019-03-13T23:21:13.5570245Z ##[debug]=> (Boolean) True
2019-03-13T23:21:13.5570245Z ##[debug]Expanded: True
2019-03-13T23:21:13.5570245Z ##[debug]Result: True
2019-03-13T23:21:13.5570245Z ##[section]Starting: Use Terraform 0.11.13
2019-03-13T23:21:13.5882789Z ==============================================================================
2019-03-13T23:21:13.5882789Z Task         : Terraform Installer
2019-03-13T23:21:13.5882789Z Description  : Installs a specific version of terraform
2019-03-13T23:21:13.5882789Z Version      : 0.4.1
2019-03-13T23:21:13.5882789Z Author       : Charles Zipp
2019-03-13T23:21:13.5882789Z Help         :
2019-03-13T23:21:13.5882789Z ==============================================================================
2019-03-13T23:21:13.8851509Z ##[debug]agent.TempDirectory=E:\TFSAgents\ProdTFS-agent\_work\_temp
2019-03-13T23:21:13.8851509Z ##[debug]loading inputs and endpoints
2019-03-13T23:21:13.8851509Z ##[debug]loading ENDPOINT_AUTH_PARAMETER_SYSTEMVSSCONNECTION_ACCESSTOKEN
2019-03-13T23:21:13.8851509Z ##[debug]loading ENDPOINT_AUTH_SCHEME_SYSTEMVSSCONNECTION
2019-03-13T23:21:13.8851509Z ##[debug]loading ENDPOINT_AUTH_SYSTEMVSSCONNECTION
2019-03-13T23:21:13.8851509Z ##[debug]loading INPUT_TERRAFORMVERSION
2019-03-13T23:21:13.8851509Z ##[debug]loading SECRET_AGENT_PROXYPASSWORD
2019-03-13T23:21:13.8851509Z ##[debug]loading SECRET_ARTIFACTORY_PASSWORD
2019-03-13T23:21:13.8851509Z ##[debug]loaded 6
2019-03-13T23:21:13.8851509Z ##[debug]Agent.ProxyUrl=my.proxy:80
2019-03-13T23:21:13.8851509Z ##[debug]Agent.ProxyUsername=INFNZ\srv-crm-tfsservice
2019-03-13T23:21:13.8851509Z ##[debug]Agent.ProxyPassword=********
2019-03-13T23:21:13.8851509Z ##[debug]Agent.ProxyBypassList=["\\*\\.company\\.co\\.nz"]
2019-03-13T23:21:13.8851509Z ##[debug]Agent.TempDirectory=E:\TFSAgents\ProdTFS-agent\_work\_temp
2019-03-13T23:21:13.8851509Z ##[debug]expose agent proxy configuration.
2019-03-13T23:21:13.8851509Z ##[debug]Agent.CAInfo=undefined
2019-03-13T23:21:13.8851509Z ##[debug]Agent.ClientCert=undefined
2019-03-13T23:21:13.8851509Z ##[debug]Agent.SkipCertValidation=undefined
2019-03-13T23:21:13.9320237Z ##[debug]Agent.ProxyUrl=my.proxy:80
2019-03-13T23:21:13.9320237Z ##[debug]Agent.ProxyUsername=INFNZ\srv-crm-tfsservice
2019-03-13T23:21:13.9320237Z ##[debug]Agent.ProxyPassword=undefined
2019-03-13T23:21:13.9320237Z ##[debug]Agent.ProxyBypassList=["\\*\\.company\\.co\\.nz"]
2019-03-13T23:21:13.9320237Z ##[debug]check path : E:\TFSAgents\ProdTFS-agent\_work\_tasks\TerraformInstaller_11645770-d18e-11e8-8f5b-1b8b62612b3b\0.4.1\node_modules\vsts-task-tool-lib\lib.json
2019-03-13T23:21:13.9320237Z ##[debug]adding resource file: E:\TFSAgents\ProdTFS-agent\_work\_tasks\TerraformInstaller_11645770-d18e-11e8-8f5b-1b8b62612b3b\0.4.1\node_modules\vsts-task-tool-lib\lib.json
2019-03-13T23:21:13.9320237Z ##[debug]system.culture=en-US
2019-03-13T23:21:13.9320237Z ##[debug]terraformVersion=0.11.13
2019-03-13T23:21:13.9320237Z ##[debug]cleaning: 0.11.13
2019-03-13T23:21:13.9320237Z ##[debug]isExplicit: 0.11.13
2019-03-13T23:21:13.9320237Z ##[debug]explicit? true
2019-03-13T23:21:13.9320237Z ##[debug]Agent.Version=2.122.1
2019-03-13T23:21:13.9320237Z ##[debug]Agent.ToolsDirectory=E:\TFSAgents\ProdTFS-agent\_work\_tool
2019-03-13T23:21:13.9476465Z ##[debug]checking cache: E:\TFSAgents\ProdTFS-agent\_work\_tool\terraform\0.11.13\x64
2019-03-13T23:21:13.9476465Z ##[debug]not found
2019-03-13T23:21:13.9476465Z Terraform not installed, downloading from:  https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip
2019-03-13T23:21:13.9476465Z Terraform file name as:  terraform-0.11.13-3806d1e9-6760-40c8-a021-f61386b761e1.zip
2019-03-13T23:21:13.9476465Z ##[debug]terraform-0.11.13-3806d1e9-6760-40c8-a021-f61386b761e1.zip
2019-03-13T23:21:13.9476465Z ##[debug]Agent.Version=2.122.1
2019-03-13T23:21:13.9476465Z ##[debug]Agent.TempDirectory=E:\TFSAgents\ProdTFS-agent\_work\_temp
2019-03-13T23:21:13.9476465Z ##[debug]testing directory 'E:\TFSAgents\ProdTFS-agent\_work\_temp'
2019-03-13T23:21:13.9476465Z Downloading: https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip
2019-03-13T23:21:13.9476465Z ##[debug]destination E:\TFSAgents\ProdTFS-agent\_work\_temp\terraform-0.11.13-3806d1e9-6760-40c8-a021-f61386b761e1.zip
2019-03-13T23:21:13.9476465Z ##[debug]downloading
2019-03-13T23:21:16.2289186Z ##[debug]task result: Failed
2019-03-13T23:21:16.2289186Z ##[error]Error: Terraform download from url 'https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip' failed with exception 'Error: tunneling socket could not be established, cause=getaddrinfo ENOTFOUND 80 80:80'
2019-03-13T23:21:16.2289186Z ##[debug]Processed: ##vso[task.issue type=error;]Error: Terraform download from url 'https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip' failed with exception 'Error: tunneling socket could not be established, cause=getaddrinfo ENOTFOUND 80 80:80'
2019-03-13T23:21:16.2445136Z ##[debug]Processed: ##vso[task.complete result=Failed;]Error: Terraform download from url 'https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_windows_amd64.zip' failed with exception 'Error: tunneling socket could not be established, cause=getaddrinfo ENOTFOUND 80 80:80'
2019-03-13T23:21:16.2445136Z ##[section]Finishing: Use Terraform 0.11.13

I discovered that if I add the below script before using any of the terraform tasks then the terraform installer task will download and install terraform, and the terraform client task can download providers.
It's odd that the offical proxy setup didn't work.  However one advantage of this script is that the proxy is only configured for the current release as setting the HTTPS_PROXY environment variable ended up breaking one of our other builds.
I'm happy with this solution so feel free to close this issue :-)
$proxyurl = ([System.Net.WebRequest]::GetSystemWebproxy()).GetProxy("https://releases.hashicorp.com")

if ($proxyurl) {
  # For tool installer to download Terraform
  Write-Host ("##vso[task.setvariable variable=VSTS_HTTP_PROXY]${proxyurl}")

  # For Terraform client to download providers
  Write-Host ("##vso[task.setvariable variable=HTTPS_PROXY]${proxyurl}")
}

Thats great you were able to find a solution @andrew-sumner. Thanks for posting the solution here as I am sure it will help others.


Shrink login page background

Right now as @itzg noted, it takes 1.45mb. That's pretty heavy.
Do we have a preferred resolution?

I'm not sure actually. Under 1mb?


Latest version?

I'm using<EMAIL_ADDRESS>(it supports CC by default)
Is there any difference with https://cdn.jsdelivr.net/clappr/latest/clappr.min.js?
What's the difference between min,js and normal?

As stated in #1504 , it is recommended to use<EMAIL_ADDRESS>"npm" url format.
You get more info on jsDelivr homepage about url format.

Loading animation freezes with the latest
<EMAIL_ADDRESS>


ml2 end to end machine learining

Hello there,
I could not understand this piece of code.
def indices_of_top_k(arr, k):
return np.sort(np.argpartition(np.array(arr), -k)[-k:])
Can't we just use argsort() instead?
Thanks for your help.

It will work fine, argpartition just performs better.
In case of you have 1million feature and if we want to identify first 500 important feature, using argpartition we dont need to sort the entire array. Algortithm will stop sorting, once it identified the last 500 (in case of negative indexing).

argsort will work fine. argpartition just performs better.
In case of you have 1million feature and if we want to identify first 500 important feature, using argpartition we dont need to sort the entire array. Algortithm will stop sorting, once it identified the last 500 (in case of negative indexing).
Hope it helps.


Add custom engine to config

Fixes CLI-35

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #287

PR #288

PR #291

PR #292   👈

This stack of pull requests is managed by Graphite.

Merge activity

Dec 23, 2:51 PM: @@NathanFlurry started a stack merge that includes this pull request via Graphite.


Direct Memory can't free

I find the a same problem of djl pytorch inference api  which also exist in libtorch_java_only api. The memory of JVM is stable， but the whole memory of server increased several days until crashed， it seems like caused by direct memory. I found this issue of   libtorch_java_only api, so I try to use djl pytorch inference api , but it can't be solved .
My predict part code such as:
Predictor<FeatureValDO, float[][]> predictor = createPredictor();
        try{
            float[][] score = predictor.predict(featureValDO);
        }catch (Exception e){
            infoLogger.error("predict error:",e);
        }finally {
            predictor.close();
        }

@yjmwolf
The issue you described usually caused by native memory leak. If all the resources are closed properly, you should not see crash. We have many customer run continuously inference with pytorch, and they didn't notice memory leak.
Can you create a minimal reproducible project, so we can look into it.

Feel free to re-open this issue if you can provide an reproducible project.


Suggest stays small when using arrow left/right

trigger suggest in front on an identifier
use arrow right to narrow down
use arrow left to widen
🐛 the widget stays small

doesn't work yet probably because it's unreleased at this point


Update 'First-order Logic'

This change removes the need for special eigenvalue constants. In fact,
they are not necessary as we can have the same without them if we
modify the definitions of satisfiability, entailment and validity of a
sequent and change the inference rules, so that a eigenvariable is
just an ordinary variable (of course with the same eigenvariable
condition). As of now, the introduction of these special eigenvalue
constants is not done properly, for example: how a sentence with such
an constant were to be evaluated if it contains a constant not in the
language? As it is in fact very unnatural to extend the language, the
proposed approach seems to be preferred.
Also this change fixes some proof trees and other small things, and
includes rewrites of some proofs, most notably the soundness proof.
The proofs should be revised, though, as the phrasing is clumsy and the
case analyses should be made clearer.
The change only includes the sequent calculus; the remaining chapters
would need to be adjusted as well.

Thanks for this.  The choice to use constants instead of free variables was made deliberately. Although it may be formally cleaner, it's conceptually more difficult since the provability relation then no longer just involves sentences. Also, once we allow free variables, we have to adjust the semantics to get a nice correspondence. So there will also have to be (substantial) changes to the semantics chapter.  This is something that's been on my radar, since the incompleteness chapter (from a different source) uses open formulas (issue #18 ).  Perhaps the best way to do it would be to have parallel treatments, or set it up as a choice that results in alternative output.

The changes in the semantics chapter do not break anything. I just do not understand what the benefit of these constants are. I mean, you disallow free variables since you since sentences have meaning something without variable assignments. But then you notice that, in order to get the proof system working, we need some kind of unbound variables. So we introduce these constants, thus extend the language. But we really do not want these constants in our sentences either. So we need to change the definition of sentences. Also, every model needs now a mapping that assigns each of these constants an element of the domain. So we have to add that to all the models what should not really be any part of a model. Otherwise, we could not evaluate the sentences with these constants.
In fact, you could have used the free variables and the variable assignment to get exactly the same without adding new symbols, the languages, the sentences, changing the model definition. Everything you needed was already there. These constant behave just like the free variables. You just created those constants because you just wanted to have sentences, but realized you needed unbound variables and instead of using the free variables, you introduced these constant that do exactly the same.
You cannot get around open formulas (why would you really want to?) and you should not restrict yourself to sentences everywhere.
I do not see what the the advantage is over the free variable approach. It is just unnatural as it pollutes all the definitions/notions.

Sure you can restrict yourself to sentences, and that's what students who've taken a (non-mathematical) logic class are familiar with. It's conceptually simpler because entailment/conseuence is more naturally understood as a relation between sentences. I'm not sure why you think it "pollutes" definitions.  Which definitions are polluted, andhow?

For example, if you want to evaluate: M |= phi(a), where 'a' is a such a constant. What value is 'a' assigned to? In this notation it can only come from the model M. Hence M must have another assignment function for these special constant. But you do not really want these constants in you model do you as there are just helpers to get the proof system working?

You have exactly the same question when you have free variables instead, don't you?  Also, why do I have to worry about structures when doing derivations?
Also, completeness is slightly easier as you don't have to prove generalization on constants; it's just a rule.

No, free variables we cover by definition: M |= phi iff M,s |= phi is true for all variable assignments s. Derivations transform formulas of the language. So, since 'a' is not in the language, we have to include it. So when you want to talk about G |= phi iff G |- phi, you have the same language on both sides. So the models have to know about 'a'. Even if you restrict yourself to sentences not including 'a', how do you do the proof of soundness? The proof that is currently in the book uses that 'a' is part of the model; otherwise the induction step would fail since the induction hypothesis could contain an 'a'.
We cannot get around variable assignment anyway because we have to start somewhere with the evaluation even with closed formulas. So why not use them further and get with free variables exactly that what we trying to achieve with these constants, but in a very natural and non-ugly way? Everything is already there, there is no need for these constants, they are quasi one and the same. It does get cleaner with these constants. These constants are essentially another set of free variables.

I just noticed that with the way a language in the book we do not need to create another set of constants because we have already infinitely many. For me a language has a signature of not necessary infinitely many constants, function and predicate symbols. Hence I would have to add infinitely many extra constants to get it working with the approach in the book. So as long as we have just the one language this is not a problem.
I will look into the completeness proof to see if we would have to do much more work.

Modified my master branch and therefore messed up this pull request.


Feature: event fallthrough for keydown and click

This PR addresses #627
As mentioned in my last comment on the above issue, event bubbling from an iframe to the container does not work in Javascript, thus injectables do not solve the problem at hand.
Since the IFrameNavigator is handling the iframes themselves, and can be configured by the upper component, it makes sense that it allows for event redirection.
The clickThrough functions were already there, but not exposed. I added a new API field for this, and i had to change a few things to correctly handle the popup clicks, so that the events are not sent in the clickThrough API if they already had an effect in the iFrame. For instance when clicking to reduce the image/footnote popup, the click event will not be falling through.
I implemented something similar for keyboard events, where any keydown event that was not being handled in the Navigator will be falling through to the containing component.
IMHO this is an elegant solution, which allows for out of the box customization without having to resort to injectables.

@gotson i will run this locally to better understand and test the PR

@gotson can you please resolve the conflict and also make sure linter is run , thank you , i'll merge it once you have an updated PR

will have a look when time allows

@aferditamuriqi rebased and linted 👍🏻


Wolf's One Shot

BTW Version: 2.1.4
Multiplayer (yes/no): Yes
Issue (be as specific as possible): Wolfs are oneshoting
Steps to Reproduce (even if obvious): Sometimes if you are mining wood a wolf with likely teleport/run fast as speed of light and kill you
Addons (with versions): Craft Guide, Dynamic light, Map Marker, Progresive Item SpeedUp Addon.
Crash Log (if there was a crash):

Tick-debt, related to speedup either via the Progressive Item Speedup Addon or sleeping.
Already fixed for next release.


requires sendgrid/sengrid 2.*

Hello -
I just installed sendgrid-php 5.1.2 and when I tried to install your code, I got this:
Problem 1
- Installation request for fcosrno/sendgrid-report 1.* -> satisfiable by fco                                                 srno/sendgrid-report[v1.0.0].
- fcosrno/sendgrid-report v1.0.0 requires sendgrid/sendgrid 2.* -> satisfiab                                                 le by sendgrid/sendgrid[2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.1.0, 2.1.1,                                                  2.2.0, 2.2.1] but these conflict with your requirements or minimum-stability.
I'm assuming I can still use fcosmo outside composer without creating any conflicts, correct?
Thanks,
-R

Sure, you can try installing outside composer. Check out the last paragraph in the Installation section of the documentation.


link not displaying with link color in tab component

This is a Bug Report
Links within the tab component are not displaying using the site link color.
Problem:
The color of links within tab components is defaulting to #222.
The link is inheriting the color value from jquery-ui-min.css.
Proposed Solution:
Update the style for ui-widget-content -> a
Page to Update:
Start with website/assets/scss/_base.scss.
Here is an example page with a number of tab components.
Search for the "Flatcar Container Linux" in the page:
https://deploy-preview-23435--kubernetes-io-master-staging.netlify.app/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#installing-kubeadm-kubelet-and-kubectl

Related to PR #23435.

/kind bug
/priority backlog
/area web-development
Feel free to reprioritize @kbhawkey

/assign


[Request] Set dark theme as the default

Description
The dark theme is no longer displayed if you use another browser or delete the browser data, because only stored in the browser cache.
Motivation
I have integrated the dashboard into a website with iframe. There it is always loaded in the light theme.
Requirements
Is it possible to make an entry in the config.json, in which the dark theme is set as default?
Thanks

Add support for setting the default theme through an env variable defaultTheme.


Feedback for: Introduction to Progressive Web App Architectures [en]

https://github.com/google/WebFundamentals/blob/master/src/content/en/ilt/pwa/introduction-to-progressive-web-app-architectures.md
These links go to Gitbook instead of the docs on /web:

Nick will fix in source


Null-safety Support

This is a simple package but could still benefit from a quick transition to sound null safety.

There is a pending pull request which provides sound null safety, amongst other things.
I maintain a similar package, so I figured I could lend a hand on what I have learned so far; but feel free to pick 'n' choose or leave it aside! 👍


[BUG] 1.6.0 Seems to break everything?

I upgraded to 1.6.0 and all BlueprintTweaks functionality was gone.  I'm using DSP <IP_ADDRESS>47 and I installed via Thunderstore.  Downgrading to 1.5.11 restores the functionality.  The game I loaded was an existing save in Sandbox mode.  Same thing happens with a new game and it seems to happen with or without Sandbox mode enabled.
It seems like the mod isn't being loaded at all because even basic functionality like remembering which folder you were in when you open the blueprint screen doesn't work.

Some

Fixed by upgrading CommonAPI to 1.6.3


Does shazamio work with audio playing from URL instead of a file?

I want to detect the music playing on some URL (an IceCast stream for example), is there a way to do that? Running the following code gives FileNotFoundError: [Errno 2] No such file or directory: 'http://' :
async def main():
    shazam = Shazam()
    out = await shazam.recognize_song('http://<URL>')
    print(out)```

Currently you can either transfer the bytes or download the file and transfer the file path.


Added running statistics

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #114   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         115    116    +1
  Lines        2257   2266    +9
  Branches      394    396    +2
=====================================
+ Hits         2257   2266    +9

Impacted Files
Coverage Δ

src/algorithms/math/statistics/welford.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79fc05...a9dd5b8. Read the comment docs.

@Bruce-Feldman thank you for your PR.
I would like to ask you to make it more focused though. We need to have exact name of the algorithm or calculation you're trying to implement with its description in README.
Instead of just "statistics" link in main README it should be something like "Welford Algorithm - it deals with this and that...". If it is "Welford" then the class name need to be named something like "Welford" instead of "RunningStatistics". On contrary if you're implementing "RunningStatistics" than file should be name also "RunningStatistics.js" (the same as class name inside). The README file should have a description of what is "Welford Algorithm" or what is "Running Statistics".