Make sure the JVM stop hook works

To avoid the agent stopping JVM shutdown elegantly, we need to add the JVM stop hook, and make sure every service stopped when the stop callback invoked.

Provided


Visibility label and Radio Buttons

reword the header for the section "Choose Visibility" instead of "Visibility." Also we have combo boxes inside of radio buttons for lease and embargo that need to be reevaluated. They weren't expected when reading the screen. We need to pull inputs outside of the label elements.

During the edit or create new work change the visibility heading, move the input outside of the label and make sure to use label for, and also make sure the embargo and lease read properly when selected.


Add txn log to Admin page

Done in https://github.com/macterra/artx-market/commit/4855981861d4706981c9cabedcadea7a0026824e


[labs/ssr] URL is missing in the dom-shim

Which package(s) are affected?
SSR (@lit-labs/ssr)
Description
The global browser URL is not available in the vm module when using the renderModule technique.
Reproduction
Any component that used the URL global class from browsers.
Workaround
I tried adding it in dom-shim using the global URL from Node.js and it works!!
It would be great if it were enabled by default.
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
"@lit-labs/ssr": "^2.2.2"
Browser/OS/Node environment
Node version: 18.0.0
npm version: 8.6.0

I'd be careful about how URL is actually used by the component in what's passed into its constructor since something like window.origin is unavailable server-side but it could very well be used as a utility for formatting urls or query params to render so it seems sensible to expose the classes that already would be normally available in Node into the VM context.


cmd/go2go: run command fails

Hi, I have a simple main package, which works if I do
go tool go2go translate main.go2
go run main.go
But it fails if I try to run immediately with command
go tool go2go run main.go2
Getting error:
cannot find package "run" in any of:         C:\Users\justast\Desktop\Go\go\src\run (from $GOROOT)         C:\Users\justast\AppData\Local\Temp\go2go1730022865\src\run (from $GOPATH)         C:\Users\justast\Desktop\Go\go2\src\run C:\Users\justast\Desktop\Go\go\bin\go [run run main.go] failed: exit status 1

cc @ianlancetaylor
broken in CL 303275

Closing as no longer relevant


[WIP] Add sections to Virtual Custom Attributes

VCA = Virtual Custom Attributes
When there are more custom_attributes with same name we were not able to distinguish them.
In this PR I distinguish them by column CustomAttribute#section
and I am extending format of virtual custom attributes to
virtual_custom_attribute_NAMEOFATTR:SECTION:docker_labels
and thanks to that it has a format in UI
Docker Labels: NAMEOFATTR and
when there is no section it looks like:
Custom Attribute: NAMEOFATTR so it
means that this also works with origin form. (part :SECTION: is not mandatory)
Images
let's assume that we have 3 different custom attributes with name com.redhat.component
but with different sections
on the report:

columns in report definition

expression

Links
follow up https://github.com/ManageIQ/manageiq/pull/14391
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434077
UI PR:
@miq-bot add_label enhancement,core, fine/yes, euwe/yes
@miq-bot assign @gtanzillo
cc @zeari @simon3z

Great @lpichler! One question: the already existing reports will continue to work? Or it's required for the user to go and re-select the newly named fields?

@miq-bot add_label wip

@simon3z

Great @lpichler! One question: the already existing reports will continue to work? Or it's required for the user to go and re-select the newly named fields?

It will work but it is strongly recommended to re-select them because then you can use #section for distinguishing. without re-selecting, we are not able to determine wich attribute is which.
I hope, this is acceptable for existing reports.

WIP: I am going to split it out to smaller PRs

It will work but it is strongly recommended to re-select them because then you can use #section for distinguishing. without re-selecting, we are not able to determine wich attribute is which.
I hope, this is acceptable for existing reports.

@gtanzillo I suppose this should go in the release notes and somehow reach the users. cc @Loicavenel

closing, I split it to PRs:
https://github.com/ManageIQ/manageiq/pull/14835 (core repo)
https://github.com/ManageIQ/manageiq-ui-classic/pull/1099  (UI repo)
https://github.com/ManageIQ/manageiq/issues/14837 (core repo)


docs:  Add link to well-known labels from spec.requirements section

So that they are more easily found!

Fixes #
Description
How was this change tested?

Used the preview link from the bot!

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[X] No

Release Note

docs:  Add link to well-known labels from spec.requirements section

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We codegen docs from the /preview/ folder. Can you copy these changes there, as well?

We codegen docs from the /preview/ folder. Can you copy these changes there, as well?

Done


support postrges

Would be nice to support postgres as an alternative to mysql.

This should not be too difficult:

In phplib/Persistence.php set the PDO url to a postgres one
Use pgloader to migrate the schema (or modify schemas/* to be postgres compatible or create a postgres version of these)


About the results?

Could you report the final results on FDDB or other face detection database? What about the final loss? Thank you very much!

This project is not for dataset ranking board, quite a lot of publications can generate much better result.
Final loss is around 4 or something.


All chat bubbles are currently gone

Description

(Emotes, whispers, talking)
All players are currently reporting they can no longer see chat bubbles.
Reproduction

Speak on a live server or watch any player

bug of the year 2024 candidate(?)

was told this was fixed.


Application command localization

See #268 for more history, I need this functionality, and so I took the PR as it looks like unmaintained anymore.

You can ignore the mypy failure that is because of hikari dev112


Improvements to pre-commit

As discussed in #2

Proceeding to make some changes to Markdownlint – there are many errors that are not useful in this case


Updating emissary to 3.6.0 dev bundle

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


feat: pagination

Support page and page_size URL parameters on all endpoints.
The underlying DB access is NOT optimized.

can you expand on what you mean by

The underlying DB access is NOT optimized.

can you expand on what you mean by

The underlying DB access is NOT optimized.

We're not fetching pages from the DB. The query to the DB is still the same as before. We're simply filtering the result to return pages.


Added mocks mail receiver reset

no issue

opening this as a draft for now to see if it helps the failing tests.
initiates the mail receiver reset to ensure it clears the mock inbox.
potential cause for current failing tests, will remove PR if not.

Not the cause.
Fixed here


Recklessly change and fix everything

This brings this repository back into a reasonable state.
Caveats:

It does not yet allow scala-js/scala-js#3040 to work since nothing is thread safe yet.
The build still seems to be flaky. However, it is possible to work with it again.

One question: what's really the difference between close() and stop()?

Practically none. close() is supposed to close the communication channel stop() is supposed to stop the VM. But in a world where there is no "smart-termination" (i.e. terminate if nothing ever can be put on the event-loop again), these two are essentially the same thing.
This is why in the future API (scala-js/scala-js#3033), there is no close() anymore.
Also, updated.


SLI supported ?

great work indeed !
I am encoding using NVIDIA 265 with several hundered fps, fantastic !
Sadly just one of my 2 cards (GTX 970 SLI x 2) is utilized (VE Load > 90 %). The other card is idle (VE Load 0%), even when I have 2 instances of StaxRip running.
What could be done to utilize both cards ?

The test build has a 'Device' option on the 'Other' tab, you can also find it by entering device in the search input box at the bottom.
https://github.com/stax76/staxrip/blob/master/md/test-build.md


failures of the telemetry system should be alerted to the user

Presently, if a fault occurs in the telemetry system, this results in a warning which is invisible unless you have the developer tools enabled (Help > Toggle Developer Tools).
Failures of this system should be reported to the user with guidance as to the setting responsible.

telemetry.enableCrashReporter
telemetry.enableTelemetry

Can you provide reproducible steps to generate such a warning?

Do a standard install, block internet access. Like most corporations we use a fairly restrictive firewall.

I only see this

Do you see anything else?


fix(router): update scope_key_builder when srds config is updated

Commit Message: fix(router): update scope_key_builder when srds config is updated
Additional Description:
When SRDS is used and scope_key_builder in HCM is updated, the ScopedConfigImpl's scope_key_builder is not updated.
I found the reason is when ConfigProvider is created in https://github.com/envoyproxy/envoy/blob/aac7cc259417a0c1d5b19b91bd34ac3800123a02/source/common/router/scoped_rds.cc#L619 cache is used in getSubscription and the cache key is scoped_rds. So if only scope_key_builder is updated when HCM is updated via LDS, the previous ScopedRdsConfigSubscription is used directly, its scope_key_builder is not updated and ScopedConfigImpl's scope_key_builder is not updated in worker threads either.
My solution is adding a method ScopedRdsConfigSubscription::updateScopeKeyBuilder to update scope_key_builder in createXdsConfigProvider. This may be redundant in the first time, but it's seems okay for now.
As the unit test shows, without this fix, the new test will fail:
[----------] 1 test from ScopedRdsTest
[ RUN      ] ScopedRdsTest.OnScopeKeyBuilderUpdate
external/envoy/test/common/router/scoped_rds_test.cc:1781: Failure
Value of: config
Expected: isn't NULL
  Actual: 16-byte object <00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>

Risk Level: Low
Testing: unit test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

I'm not super familiar with SRDS, but I have a general question: shouldn't the key be calculated separately from the subscription? I wonder if we have two HCMs pointing to the same SRDS config source with different scope keys, what happens then?

I'm not super familiar with SRDS, but I have a general question: shouldn't the key be calculated separately from the subscription? I wonder if we have two HCMs pointing to the same SRDS config source with different scope keys, what happens then?

From what I know, I guess the two HCMs will share the same ScopedRdsConfigSubscription. All scoped route configs will be used by the two HCMs. But they will use the same scope_key_builder to calculate the scope key, so only one HCM will get the correct result. The difference for the current code and my changed code is which one will get the correct result(earliest or latest updated).
So yes, we may need to separate the key calculation and the subscription. Let me think more about this.

/wait

/retest

@kyessenov Hi, I separated the scope key builder to HCM from SRDS configuration. Please take a look if this is okay.
btw, is there an integration test using two Listeners as an example? So that I can try to add an integration test to test the two HCMs case.

I looked over the code and it looks like the right approach to me. It would be good to have a test with two listeners with different scope keys if you can add it - not sure if there's one with scoped routes already.

@kyessenov OK. It would be better to have an example using two listeners, even without scoped routes. Or I'll find one or try to figure out how to add one.

@kyessenov I added an integration test and it's ready to review. Thanks!

/assign-from @envoyproxy/senior-maintainers

Could you update the PR description since the implementation strategy changed?

Also assigning @adisuissa to look over the code

Could you update the PR description since the implementation strategy changed?

@kyessenov Done.


Fixed #27518 -- Avoid password reset link leak on password reset confirm page

On password reset confirm page, if the user has included some links to external sources, the HTTP header Referer sent to these sources will contain the full password reset URL.
That can allow external systems to reset password in behalf of the concerned user, if he doesn't
reset his password immediately after landing on password reset confirm page.
To avoid that, the user is redirected to the same page, but we remove the token and save it in the
user session instead.
The issue and the solution are detailed in related ticket.

Looks good so far, will try to review the tests later this week and then see that I can get a second core dev to look at it since it touches security sensitive stuff.

Reviews applied.

@romgar I simplified the code even further (I hope): https://dpaste.de/xEnC/raw -- What do you think?

Hey @apollo13 ! I ticked the box when I created the PR (I think). I just checked, it seems to be activated.
Few comments on your diff:
+ if not all([user, token]):
+            return False

It changes the current behaviour of PasswordResetTokenGenerator.check_token, which means that somebody that has subclassed it and for example caught some exceptions (like the one we try to avoid to raise by adding this code) will have his code maybe broken. But I guess it's acceptable?
+        # Store the token in the session, to not leak it in a referer
+        # and redirect to a token-free URL.

Wouldn't it be nice to add a link to the post talking about it? Would make it clearer for people to understand that bit in the future?
+        del self.request.session[INTERNAL_RESET_SESSION_TOKEN]

Why deleting this token? To make it clean and not leave unnecessary data in the session?
+        self.assertNotIn(INTERNAL_RESET_SESSION_TOKEN, self.pr_client.session)

Have you checked if this test was passing? If I remember correctly, the client session is not the same as the request session, so something you add in the request session won't appear at the end in the client (not completely sure about that though).

@romgar: Pushed my changes, it did indeed work. As for your comments:

As for the token issue: In the worst case you get a 500 error, since the token interface is not really defined, we should be safish (it is not documented)
Added a link to the blogpost from the ticket
The deletion of the session data is done to keep it clean (this is especially important for cookie based sessions where more data means more data every roundtrip with the client)
The tests did pass locally, lets see what jenkins says :D

Note: while I did update and push the patch, it seems as if github doesn't know about it in the "files" tab (nor does it show it here in the comments)

It seems updated for me.

Misses the comment I added at https://github.com/django/django/pull/7623/files#diff-c571286052438b2e3190f8db8331a92bR457 with the link to the blog post. And https://github.com/django/django/pull/7623/commits/8304fb9cd4f91dc9a0a3a3acc378010bcd40e4db also doesn't show it hmm

Force pushed, now everything is there.

Any documentation changes and/or release notes needed (i.e. could it be backwards-incompatible in any way -- I guess if someone is simulating password reset workflow in tests, they'll be affected as our tests our)?

Hey @timgraham. I will update the MR regarding your comments. Available mostly all day (GMT+0 timezone)

Not yet sure about this self.client and self.pr_client definition. PasswordResetTest needs a mix of default Client and custom PasswordResetConfirmClient calls. If we set the custom one to be self.client, we will still need another variable name for the default client.

How about client = Client() in the one (as far as I see) test that needs it?

@timgraham Not sure to fully understand your last comment. In auth_tests.test_views.PasswordResetTest, there are 10+ calls to self.client and 10+ calls to self.pr_client.

I did a find/replace self.pr_client to self.client and only saw one test failure.

But then, we are using the custom client where it doesn't need to. I don't think that's a good idea to use this custom client in other situations than the one it has been built for.
By reading current tests, you understand where you have this redirect logic. I can make this change, but in my mind, reducing the diff is not a great advantage compared to making the tests less understandable.
And fixing the only test failing is resolved an issue introduced by using this client in a context that it has not been designed for, which add more complexity in the global test understanding.

I can squash every commit, but then @apollo13 contribution will be lost :'(

The custom client only processes certain URLs, otherwise it uses the existing behavior so I don't see why it's a problem to use it in other places. If an opt-out is needed for the reset URL, how about adding a kwarg option to the get() / post() such as handle_reset (or some other name)? Anyway, that's just my opinion about what would be simplest... other opinions welcome.
You can thank Florian in the commit message for contributing to the patch.

No sure to understand the flake8 error, as I can't reproduce it locally (and I don't see indentation issue, maybe line too long, but I thought it was a different error message?)
About the client, I will be glad to change it to what you think is best for the project, as both choices haven't any major impact anyway.

Looks like the branch just needed to be rebased. I did that and made a few other updates. I'll continue looking at this tomorrow.

Okay, I'm happy with this for today. To be decided whether or not to keep the "Renamed pr_client" commit. Hope to merge this tomorrow. :-)

Thanks for your updates @timgraham !!

@romgar beacuse these values are hardcoded we have now https://github.com/django/django/pull/9337
Do you mind writing documentation for these values? I have no idea about how them actually work...

Hey @bukowa !
The idea of this MR is to switch the reset token from the URL to the user session.
In that regard, INTERNAL_RESET_URL_TOKEN is used as a placeholder for the reset token in the URL, INTERNAL_RESET_SESSION_TOKEN is the key used to be able to retrieve the internal token from the session.
To summarize:

A user access /password/reset/<reset_token>/
We redirect him to /password/reset/<INTERNAL_RESET_URL_TOKEN>/ and save the <reset_token> in the session[INTERNAL_RESET_SESSION_TOKEN],
We then avoided on that way to leak the reset token in the HTTP Referrer, while keeping backward compatibility.


Hotfix/issue 258

Resolves #258

Hi, @lukewrites! Thanks for opening this PR!

In the file tdvt/tdvt/config_gen/datasource_list.py:

Line 436:53: W292 no newline at end of file
Line 167:121: E501 line too long (145 > 120 characters)
Line 166:121: E501 line too long (149 > 120 characters)

In the file tdvt/tdvt/config_gen/tdvtconfig.py:

Line 10:121: E501 line too long (245 > 120 characters)

In the file tdvt/tdvt/config_gen/test_config.py:

Line 257:109: W291 trailing whitespace

In the file tdvt/tdvt/tdvt.py:

Line 281:121: E501 line too long (127 > 120 characters)
Line 267:56: E226 missing whitespace around arithmetic operator
Line 216:51: F405 'get_root_dir' may be undefined, or defined from star imports: .tabquery
Line 213:48: F405 'get_root_dir' may be undefined, or defined from star imports: .tabquery

For reference: Error Code Reference, PEP8, Python code style


<EMAIL_ADDRESS>decompress error

I have this issue since yesterday, I tried too way to install, with power shell with administrator mode and with power shell without administrator mode. Can you help me? I need to do some work for my employee. Thank you a lot!
The error message: https://github.com/twilio/scoop-twilio-cli/issues/new?title=twilio%404.2.0%3A+decompress+error

Hi @damasiorafael , Thanks for reaching out. I am guessing you're using scoop install twilio on Powershell as an admin.
Can you help us with a screenshot of the error ?
Meanwhile, to unblock you, you can also download the exe file directly, from here .


10 to 100  train/val features

can u guys download the 10 to 100  train/val features?
I can't download it,maybe the data is broken can u update the data ?

The free

can u guys download the 10 to 100 train/val features?
I can't download it,maybe the data is broken can u update the data ?

I am able to download the features in both linux (using simply wget) and windows. Just did 2 days back.

can u guys download the 10 to 100 train/val features?
I can't download it,maybe the data is broken can u update the data ?

I am able to download the 10-100 features using the provided link, in both linux (using simply wget) and windows. Just did 2 days back.

I can't download it either. Could you please tell me how to solve it or share it with me


network port after proxy

hi
i dont face any errors
i just have a problem i noticed that there is a hight usage in network port for target server after i linked the proxy
the desitnation server becomes use more from network port

Is it possible to fill the issue on the basis of https://github.com/NginxProxyManager/nginx-proxy-manager/issues/898 ?


Allow frame in BrowserWindow

Hi there,
LOVE this project! I was able to get your example going really quickly.
I was attempting to get this working in verminal which is a theme for hyper but hit a snag.
It looks like in your example:
    mainWindow = new BrowserWindow({
        height: 500,
        width: 800,
        transparent: true,
        frame: false
    });
    mainWindow.loadURL('file://' + __dirname + '/index.html');

    electronAcrylic.setAcrylic(mainWindow, 0xFFFFFF);

if you remove the frame: false the acrylic is no longer present 😢

For reference, I was working off of:
https://github.com/electron/electron-quick-start

Hey @tylerl0706, thank you for opening an issue. Honestly, I wasn't thinking about this, I've always used frame: false and designing my own title bar. I'll look into it when I get home, that'll be in like 2 hours.

This is not an issue of this package. This is a known issue of Electron. There is currently no way to enable transparency with resizable set to true or with frame set to true.
A fix for this should be discussed on the Electron repository itself, and an open op for it does exist
This issue issue be safely closed :D
/AG

The initial background of the body element is white I believe, try setting a rule in CSS to body element as so:
body {
    background: transparent !important;
}

I'll try this once I get home. Will keep you updated.
Regards,
Oliver

As you can see here, all the content area has the background acrylic.

But there's a slight render but, or this is intentional because of the window shadows? I really have no clue.
The same was asked https://github.com/arkenthera/electron-vibrancy/issues/15, but with blur behind.

Yes, I noticed this issue. This was also mentioned somewhere in a discussion about Acrylic/Vibrancy on Hyper. It may be to do with the way Electron handles transparency with a frame?
Is there any way you can confirm that the box with frame: false is the exact same size as the framed content (excluding the overflow)
And i seriously doubt that its window shadows, as they exist on the top too, and the left side is way to large to be it.
It would be worth a try adding overflow: hidden in the body, or creating a wrapper for the background effect, and not touching body, and if same thing happens - trying overflow on body (which should be the parent of the wrapper)
I cannot test this myself until Monday.
/AG


New Chat layout patch

Fixes #20
Sry bout the wait for all you early adopters trynna keep those Inbox memories alive 🙃

@deepfriedfilth I have not I will try and make some time to look at this today if I have time!


Checksum Error

While my friend is downloading the mod, there was an error on the checksum, and the mod wasn't downloaded because of it

FYI this fork is still a big work in progress and doesn't even have a permanent server at this time. I currently don't publicize when I update the server, which would end runs prematurely. If you're just trying to play Noita Together you should still use Soler's original fork (https://github.com/soler91/noita-together) for the time being.
That being said though, this issue should be resolved now :)

fixed by https://github.com/SkyeOfBreeze/noita-together/commit/7e4fad3a6dc5af12f819414326564438fa633080


[Content item horizontal] Web Component: Update styles and layout of Content item horizontal with media to better align with Content item horizontal - DDS consulting

User Story

As a [user role below]:
Carbon for ibm.com developer

I need to:
create/change the Content item horizontal

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Story within Storybook with corresponding knobs
Utilize Carbon
Create with Shadow DOM and Custom Elements standards
See the Epic (#7256) for the Design and Functional specs information
Web Components Visual QA testing issue (#7272)
Web Components Prod QA testing issue (#7278)

Engineering info:

HC engineer: @andy-blum
HC Jira Ticket: https://jsw.ibm.com/browse/HC-2237
DDS consulting engineer:  Kenny

Requested updates to Content item horizontal with media

Requested updates to Content item horizontal

Acceptance criteria

[ ] Include README for the web component and corresponding styles
[ ] Create Web Components styles in styles package
[ ] Do not create knobs in Storybook that include JSON objects
[ ] Break out Storybook stories into multiple variation stories, if applicable
[ ] Create codesandbox example under /packages/web-components/examples/codesandbox and include in README
[ ] Minimum 80% unit test coverage
[ ] Update the Carbon for ibm.com website component data file to be sure the web site Component Status and Storybook links are correct
[ ] Use the Visual QA checklist to verify design quality
[ ] If a design is provided, the Designer is included as a Reviewer in the Pull Request
[ ] Provide a direct link to the deploy preview for the designer in the Pull Request description
[ ] A comment is posted in the Prod QA issue, tagging Praveen when development is finished

@andy-blum Here's the link to the updated design specs for the "Content item horizontal" component. ttps://ibm.box.com/s/j0qac86mtybri4qpljg6ax04da0ra2wh
The designs should be on the third page of the sketch file. Also, @kirbyevans is the designer of this component, please reach out to him if you have any design-related questions.


Explore numpath (numpy path) structure for data storage.

First, this might be too dramatic of a change to implement at this point. It may be better off to skip or ignore push things down the road, at least until 0.8.x is finished up. Or to implement it but then don't switch everything over very quickly or at all if it's not that needed. It may be excessive to recode a lot of the plotplanning, for example, to use the newer structure. Though the two-opt code is already adapted. But, for something like scanline_hatch algorithm, or the eulerian (if we ignored these things) we could do significantly better with a data structure that allows for gaps.

The idea behind numpy laser paths is to define a common structure that could replace the whole of cutcode and do so in a way that could be both be faster and more compact for other data structures commonly used throughout Meerk40t.

Some drivers can use direct circular arcs, lines, and bezier curves. We should also avoid prematurely interpolating our data prior to knowing what types of data the driver might want or accept.
Some drivers accept and use pure step versions of our code. Rather than using lines we would more directly use  individual orthogonal steps.
Some drivers can and do use dwell points, in that, they can go to a particular location and turn the laser on for a period of time.
Rasters are converted into a series of tiny steps that are either on or off but are so plentiful that attempting to render them results in an unusably slow program.
We should/must optimize our pathing such that we can minimize travel time.
Some hatch operations result in many disjointed paths similar to what we get with rasters. The current selection of objects to capture this data requires many node objects and is very inefficient.

For these reasons, I introduce the numpath class which uses numpy to define these geometric objects, as well as some highly laser specific ones, with enough generalization to capture considerable other forms.
Each segment consists of 5 complex values, these are:
Start, Control1, Type/Power, Control2, End
Every type of geometric connection is defined by these elements:

Line: Start, NOP, Type=0, NOP, End
Quad: Start, C0, Type=1, C0, End -- Note C0 is duplicated and identical, only one needs to be read.
Cubic: Start, C0, Type=2, C1, End
Arc: Start, C0, Type=3, C0, End -- Note C0 is duplicated and identical (circular)
Dwell: Start, NOP, Type=4/Time, NOP, Start -- Note, Start and End are the same point.
Wait: Start, NOP, Type=5/Time, NOP, Start -- Note, Start and End are the same point.
Ramp: Start, PStart, Type=6, PEnd, End -- Power ramp line.

Note: the Arc is defined by 3 points. Start, End, and a single control point, this is a circular-arc only and does not do elliptical arcs since they are weird/complex and no laser appears to use them.
Additional extensions can be added by expanding the type parameters. Since each set of values is a complex, the points provide x and y values (real, imag). The type parameter provides the power, except for Dwell where it provides the time for the dwell.
At first glance the structure may seem somewhat unusual but the Position, Position, Type, Position, Position structure  serves a utilitarian purpose. All paths are reversible. We can apply a flip of these parameters. The start and end points swap as well as the control points for the cubic, and the power-start and power-end for Ramp. Whereas the types of parameter remains in the same position.
If we want to reverse any number of segments the numpy flip operation can be done over the x and y axis. This provides the list of segments in reverse order while also reversing all the segments themselves. This is the key to doing 2-opt travel minimization which are provided in the example code.
Ruida has some segments which start at one power and ramp up to a second amount of power. In this case, the reverse of this should attenuate power over that length rather than ramp it up. In such a case the C0 and C1 places are adapted to set the power, and a flip would attenuate the power in the other direction. In some cases there's just not enough information such as a segment that would need to do a power-ramping cubic-bezier segments. But, the same rules apply for any geometric segments, they should be written such that the reversed-form is the reverse of that segment.
This class is expected to be able to replace many uses of the Path class as well as all cutcode, permitting scaling and other transformations, which would serve as a laser-first data structure. Many of the element nodes have their own utilities for example a path that looks like a circle couldn't have its radius changed in a coherent manner, or a hypothetical barcode object would need to change types of text etc. However, a faster laser-centric path-like code which could work as simpler transformable cutcode could do a lot to simplify many operations.

Drat. If I ever want to do proper closed paths I actually do need close operations. Since there's not really a way to easily do that without them.

Double drat. Proper Close events still need an initial Move to clearly indicate the structural parts of paths. But, doing that is asymmetric. You cannot sort the structural parts within the path, while maintaining the structure. And close paths occur at the end which creates a distinction between the beginning and the end.

Added in breaks that got renamed end because "break" is a reserved word. This appears to work well enough and corrected the display code to show numpaths fairly well.
While the goal here is still to stop, I'm going to go ahead and merge this code in, and simply not use it. You can create a numpath with element* numpath and see that there's elements of bounding box that still don't work quite right yet. But, the core of the code works and it's a good enough stopping point. The data structure might be useful for hatches to return heavily disjointed data without creating new nodes for everything.


Add default config and builder

@jimblackler, thank you for creating this library. This is probably the only open source random Json object generator available in Java.
Description
Currently the Configuration is just an interface, and each time the user needs to implement it. One downside of this approach is that whenever there are new options added to the configuration, all the implementations will be updated. The example is that many of the test files cannot compile, because their implementation of the Configuration lacks the two newly added options from https://github.com/jimblackler/jsongenerator/pull/3.
Implementation
The solution proposed in this PR is to

Add a default implementation of this interface.
Add a builder with default values of all the options.

There are two ways to create a DefaultConfig, both of them are much more concise:
Configuration config = new DefaultConfig(false, false, false, true, false, 0.5f);

or
Configuration config = DefaultConfig.build()
    .setGenerateMinimal(false)
    .setNonRequiredPropertyChance(0.5f)
    .get();

The builder approach is recommended because new options won't affect existing use cases.
Also I add an example of how to use this library in the README.

Thanks, looks good.


Doesn't work anymore

Doesn't work anymore

@adefaria, sorry to hear you are having trouble with the extension.
Can you provide more detail as to what's not working? I'm assuming you are not able to paste something on some site, can you provide the site? Have you enabled the extension for the site in question? If so, when you are on the site, what color is the extension's button icon (blue or grey)?

@gulfecom, first, that's one of the most bizarre forgot password forms I've ever seen. You are correct that they do block pasting into their password field, but this extension does get around their blocking.
You do need to configure the extension in order for it to be active on any particular sites, please see https://github.com/jswanner/DontFuckWithPaste#usage. You do not want to configure the extension to be active all on sites, as their can be undesired consequences for doing so (such as not being able to paste an image here on GitHub and having it turn into a file upload).

Closing due to inactivity. @adefaria, you are welcome to reopen, if you can provide me with more information.


Depending on how you define the function, typecheck is behaving differently even if is the same.

TypeScript Version:  3.7.2
Code
const a1: () => { a: string } = () => {
  return {a: '', b: ''} // not erroring!?
}

const a2 = ():{ a: string } => {
  return {a: '', b: ''} // is erroring as expected
}

const a3: () => { a: string } = () => {
  return {b: ''} // is erroring as expected
}

Expected behavior:
a1 should error
Actual behavior:
a2 doesnt error
Playground Link: https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=11&pc=2#code/MYewdgzgLgBAhgRgFwwBQEoYF4B8MDe8K0ATgJZgDmMAvtmprgQFAwwkCmUAriWAXBQByIQBoYAI2FC6AelkwwIWBxIkQ5KgEIA-MxrNmoSLDgAmehiSFBMUhWp0m+Vuy69++WyPFSYIuQUyCBhVdU1qOBCOAA8ABw5gKA4AE31DY2h4AGYUDGw8G2IoCNpLRkLXTh4+Aj8AmHkYYNC1DQd4aPjE5LSaIA

Excess property checks are only performed on fresh object literals.
In cases a1 and a3 return types of functions are compared - no fresh literals therefore no excess property checks.
In case a2 excess properties check is triggered because you return object literal.
Similar
const obj = {a: '', b: ''};
const c1: {a: string} = obj; // no error
const c2: {a: string} = {a: '', b: ''}; // error

const a22 = ():{ a: string } => {
  const tmp = {a: '', b: ''};
  return  tmp; // no error
}

Playground


Ruby 3.2 removed Object#=~, making writing Time objects impossible

Reproduction script:
require 'write_xlsx'

workbook = WriteXLSX.new(StringIO.new)
worksheet = workbook.add_worksheet
worksheet.write(0, 0, Time.new)

Since ruby 3.2 this will fail with the following error:
/Users/grk/.asdf/installs/ruby/3.2.0/lib/ruby/gems/3.2.0/gems/write_xlsx-1.09.4/lib/write_xlsx/worksheet.rb:905:in `write': undefined method `=~' for 2023-01-17 21:46:17.891978 +0100:Time (NoMethodError)

I guess this means that there should be a should check if token respond to =~ somewhere in the if statement in Worksheet#write, but I'm not sure what the correct spot would be. I could work on a PR with a solution if someone could provide some pointers.

thank you for your report!
I'll try to fix.

Awesome, thanks!


Upgrade Theme of the App...

Could you please tell in what way to upgrade the theme like do we just only have to make changes in themes.xml or something else ?

Yes....just make some custom themes in themes.xml and make changes in settings tab that user can control theme from settings tab.

Any Update?

Hello there can I contribute to this project for hactoberfest 2023

@AdityaKumdale ofcourse....


Debug print show up during build

There's an eprintln!() at
https://github.com/ModProg/attribute-derive/blob/058deac81bcce9091773fe8b2d28acaba756975f/macro/src/lib.rs#L197
that appears to show up in my builds.
I have an attribute like this:
#[derive(FromAttr)]
#[attribute(ident = field_list)]

which is the only place in my project where ident = field_list appears, and it shows up in my builds like this
   ...
   Compiling attribute-derive v0.10.0
   Compiling leptos_meta v0.6.14
   Compiling ff-macros v0.1.0 (C:\Users\Me\projects\rust\fusta-femas\ff-macros)
ident = field_list
   Compiling sea-schema v0.14.2
   ...

Attribute in full project for context in case it helps: https://github.com/tyoeer/fusta-femas/blob/main/ff-macros/src/field_list.rs#L12

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

that is definitely me forgetting to removing debug prints :D


WIP - Add Filter to return s3 resources that Custodian has limited/no access to

Returns S3 resources that have c7n:DeniedActions that match the actions parameter in the policy.yml.
c7n:DeniedActions is defined by the actions that result in AccessDenied when augmenting the S3 resource:
S3_AUGMENT_TABLE = (
    ('get_bucket_location', 'Location', None, None),
    ('get_bucket_tagging', 'Tags', [], 'TagSet'),
    ('get_bucket_policy', 'Policy', None, 'Policy'),
    ('get_bucket_acl', 'Acl', None, None),
    ('get_bucket_replication', 'Replication', None, None),
    ('get_bucket_versioning', 'Versioning', None, None),
    ('get_bucket_website', 'Website', None, None),
    ('get_bucket_logging', 'Logging', None, 'LoggingEnabled'),
    ('get_bucket_notification_configuration', 'Notification', None, None),
    ('get_bucket_lifecycle', 'Lifecycle', None, None),
    #        ('get_bucket_cors', 'Cors'),
)

@kapilt running a policy like so:
policies:
        - name: s3-no-access-test
          resource: s3
          filters:
                  - type: value
                    key: "c7n:DeniedAccess"
                    value_type: swap
                    value: get_bucket_location
                    op: in

results in the following
2017-08-07 16:04:08,359: custodian.commands:ERROR Error while executing policy s3-no-access-test, continuing
Traceback (most recent call last):
  File "/cloud-custodian/c7n/commands.py", line 213, in run
    policy()
  File "/cloud-custodian/c7n/policy.py", line 691, in __call__
    resources = PullMode(self).run()
  File "/cloud-custodian/c7n/policy.py", line 305, in run
    resources = self.policy.resource_manager.resources()
  File "/cloud-custodian/c7n/query.py", line 299, in resources
    return self.filter_resources(resources)
  File "/cloud-custodian/c7n/manager.py", line 88, in filter_resources
    resources = f.process(resources, event)
  File "/cloud-custodian/c7n/filters/core.py", line 352, in process
    return super(ValueFilter, self).process(resources, event)
  File "/cloud-custodian/c7n/filters/core.py", line 165, in process
    return list(filter(self, resources))
  File "/cloud-custodian/c7n/filters/core.py", line 339, in __call__
    matched = self.match(i)
  File "/cloud-custodian/c7n/filters/core.py", line 388, in match
    r = self.get_resource_value(self.k, i)
  File "/cloud-custodian/c7n/filters/core.py", line 365, in get_resource_value
    self.expr[k] = jmespath.compile(k)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/__init__.py", line 8, in compile
    return parser.Parser().parse(expression)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/parser.py", line 88, in parse
    parsed_result = self._do_parse(expression)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/parser.py", line 96, in _do_parse
    return self._parse(expression)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/parser.py", line 115, in _parse
    "Unexpected token: %s" % t['value'])
ParseError: Unexpected token: :: Parse error at column 3, token ":" (COLON), for expression:
"c7n:DeniedAccess"
    ^

It appears that : is an illegal character for JMESPath even though the JSON spec itself does not consider : illegal. Filtering with the following policy does return the correct resources, however:
policies:
        - name: s3-no-access-test
          resource: s3
          filters:
                  - type: no-access
                    actions:
                          - get_bucket_location

yeah. there's an ability to make the key a literal string in jmespath which make it valid, but it needs effectively double quoting in the config file. i'm open to alternatives on the annotation prefix, but for some of the state diffing we need to be able to unambigiously determine any custodian annotations, we also need it to behave well with some of the indexing tools we use (elasticsearch has issues with .) and .. the alternative i've considered is c7n-

c7n-DeniedActions ends up resulting in the same issue:
Traceback (most recent call last):
  File "/cloud-custodian/c7n/policy.py", line 305, in run
    resources = self.policy.resource_manager.resources()
  File "/cloud-custodian/c7n/query.py", line 299, in resources
    return self.filter_resources(resources)
  File "/cloud-custodian/c7n/manager.py", line 88, in filter_resources
    resources = f.process(resources, event)
  File "/cloud-custodian/c7n/filters/core.py", line 352, in process
    return super(ValueFilter, self).process(resources, event)
  File "/cloud-custodian/c7n/filters/core.py", line 165, in process
    return list(filter(self, resources))
  File "/cloud-custodian/c7n/filters/core.py", line 339, in __call__
    matched = self.match(i)
  File "/cloud-custodian/c7n/filters/core.py", line 388, in match
    r = self.get_resource_value(self.k, i)
  File "/cloud-custodian/c7n/filters/core.py", line 365, in get_resource_value
    self.expr[k] = jmespath.compile(k)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/__init__.py", line 8, in compile
    return parser.Parser().parse(expression)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/parser.py", line 88, in parse
    parsed_result = self._do_parse(expression)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/parser.py", line 96, in _do_parse
    return self._parse(expression)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/parser.py", line 109, in _parse
    self._tokens = list(self.tokenizer)
  File "/cloud-custodian/lib/python2.7/site-packages/jmespath/lexer.py", line 80, in tokenize
    message="Unknown token '%s'" % buff)
LexerError: Bad jmespath expression: Unknown token '-':
c7n-DeniedActions
   ^

As it stands right now it seems like the way forward is to fix the way we're resolving the key with JMESPath, which should live inside another pull request

thats fair, re key resolution. to be clear jmespath literals is how we deal with this today.

wrt to literal expressions and double quoting. here's an example
$ custodian run -c policies.yml -s out -v
2017-08-12 07:37:16,282: custodian.cli:DEBUG using default region:us-east-1 from boto
2017-08-12 07:37:16,780: custodian.commands:DEBUG Loaded file policies.yml. Contains 1 policies
2017-08-12 07:37:16,859: custodian.output:DEBUG Storing output with <DirectoryOutput to dir:out/s3-no-access-test>
2017-08-12 07:37:16,859: custodian.policy:DEBUG Running policy s3-no-access-test resource: s3 region:us-east-1 c7n:<IP_ADDRESS>
2017-08-12 07:37:19,830: custodian.resources.s3:DEBUG Filtered from 5 to 0 s3
2017-08-12 07:37:19,831: custodian.policy:INFO policy: s3-no-access-test resource:s3 region:us-east-1 count:0 time:2.97
2017-08-12 07:37:19,831: custodian.output:DEBUG metric:ResourceCount Count:0 policy:s3-no-access-test restype:s3 scope:policy
(custodian) bash-3.2$ cat policies.yml
policies:
  - name: s3-no-access-test
    resource: s3
    filters:
      - type: value
        key: '"c7n:DeniedAccess"'
        value_type: swap
        value: get_bucket_location
        op: in

i'd like to get this functionality in the next release, which i'm cutting shortly, i'm going to merge it and yank the filter, see my previous comment for how to filter on this.


[Feature Request]FancyDesktop

📝Create different virtual desktops with different TaskBar configurations
When adding a new virtual desktop, an option is added to pin the VD so it is persistent after rebooting or logging out. (Maybe even an option to label each one)
These Virtual Desktops can have different app icons pinned for different workflow environments. I.E. having one desktop for school, one for video/photo editing, one for general use, one for work.
This could be a very powerful workflow enhancement for power users, especially users with multiple monitors.
If you'd like to see this feature implemented, add a 👍 reaction to this post.

Duplicate of #6602


Bug in PseudoAttribute equality in Python 3

There's an error in the way PseudoAttribute tries to do equality in Python 3. Specifically, the approach uses attribute names that changed in Python 3. This is causing problems in #712.
Try the following complete test file:
import os
import openpathsampling as paths
from nose.tools import assert_equal

import logging
logging.getLogger('openpathsampling.initialization').setLevel(logging.CRITICAL)
logging.getLogger('openpathsampling.ensemble').setLevel(logging.CRITICAL)
logging.getLogger('openpathsampling.storage').setLevel(logging.CRITICAL)
logging.getLogger('openpathsampling.netcdfplus').setLevel(logging.CRITICAL)

def test_problem():
    cv = paths.FunctionCV(name="x", f=lambda s: s.xyz[0][0])
    max_cv_func = lambda x, cv_: max(cv_(x))
    max_cv = paths.netcdfplus.FunctionPseudoAttribute(
        name="max x",
        key_class=paths.Trajectory,
        f=max_cv_func,
        cv_=cv
    )
    storage = paths.Storage("test_file.nc", 'w')
    storage.save(max_cv)
    storage.close()

    read_storage = paths.Storage("test_file.nc", 'r')
    read_max_cv = storage.attributes['max x']

    assert_equal(max_cv, read_max_cv)

    read_storage.close()
    if os.path.isfile("test_file.nc"):
        os.remove("test_file.nc")

Runs fine in Python 2. Fails in Python 3 (3.6, although based on errors in Travis, will get the same problem in 3.5) with:
Traceback (most recent call last):
  File "/Users/dwhs/miniconda3/lib/python3.6/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/dwhs/Dropbox/msm-tis/openpathsampling/tests/test_problem.py", line 27, in test_problem
    assert_equal(max_cv, read_max_cv)
  File "/Users/dwhs/miniconda3/lib/python3.6/unittest/case.py", line 821, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/Users/dwhs/miniconda3/lib/python3.6/unittest/case.py", line 811, in _baseAssertEqual
    if not first == second:
  File "/Users/dwhs/Dropbox/msm-tis/openpathsampling/netcdfplus/attribute.py", line 331, in __eq__
    if hasattr(self.cv_callable.func_code, 'op_code') \
AttributeError: 'function' object has no attribute 'func_code'

Didn't we have equality check based on name of the CV? Isn't that why names are required for CVs? It looks like you're looking for the op_code, which, IIRC, was renamed in Py3k.

I think we used equality using a byte-code comparison, so in same python version the same code will be equal. The name is not really necessary, it used to be, when you wanted to save the cache, but I think even that is not really the case anymore. If I remember correctly, then I still use it in the cache name inside netcdf to make it easier to find the table.
Hmmm, either we

use UUIDs as we do for most other objects, or
compare using the pickling algorithm we recently fixed
compare by name and kwargs (as we do now, but without the bytecode)

The fix is easy...

I think we used equality using a byte-code comparison, so in same python version the same code will be equal.

Just to be clear: the problem here isn't with the algorithm; it's with code that isn't compatible with Python 3. This isn't an assertion that isn't passing; the code will actually crash if you try to save a FunctionPseudoAttribute while running Python 3!
But it is worth considering the algorithm too:

Hmmm, either we....

I don't think that it's totally obvious which approach is best. So here are my thoughts.
First, I think it is really important to distinguish between three types of objects:

data (snapshots, trajectories, move changes, etc.)
"how you are sampling" (path movers, etc.)
"what you are sampling" (CVs, ensembles, volumes, etc.)

Data object equality should always be UUID, because there should only ever be one instance of a snapshot with a specific set of values for all its features. That's easy.
"How" objects, are, I think, checked with UUID as well, although I think this is as much a matter of an inability to create good alternative check, short of overriding __eq__ in every class (which may eventually be worth doing).
For several other "what" objects, such as volumes and ensembles, equality is determined based on creating a unique string describing that object. In this case, let's call the equality test on of "equivalence" (where the UUID-based approach is one of "identity"). This should make it easier to work with multiple simulations based on the same system, even if you recreate these objects (instead of reloading them from storage). This, by the way, is something else we might want to continue to make easier (in particular, by making sure that __hash__ and __eq__ use the same criteria.)
The thing that makes CVs different from ensembles/volumes is that the dictionaries associated with them mean that you can have difference (performance) behavior from two "equivalent" instances (e.g., if one has diskcache on and the other doesn't). That said, I would still lean toward considering "equivalence" as the basis of equality (which I think can be done with the pickling approach? is that correct?) and try to avoid duplication at the storage level. We already have a test to prevent multiple objects with the same name; is it possible to raise a warning if a user tries to save an CV with a different name, but the same bytecode/kwargs?

Also, it sounds like that name is not as required for CVs as it once was. Anything we can do to get rid of the requirement that CVs have a name would be good. When teaching how to use OPS, that part is always a bit awkward. "Many objects in OPS can have names, but CVs must have names. And other objects, the name is added with .named(), but CVs, it's the first argument for initialization. Why do CVs require names? Storage."

Another related thing to fix at the same time. Error message is misleading:
  File "/Users/dwhs/Dropbox/msm-tis/openpathsampling/netcdfplus/stores/attribute.py", line 131, in add_diskcache
    'Need either at least one stored snapshot or a '
RuntimeError: Need either at least one stored snapshot or a template snapshot to determine type and shape of the CV.

Specifies "stored snapshot or a template snapshot," but what is needed is a template of whatever the key_class is (not always snapshot!)

@jhprinz : Any progress on this? It's been a month, and this is blocking #712.

Data object equality should always be UUID, because there should only ever be one instance of a snapshot with a specific set of values for all its features. That's easy.

Thinking about this more -- this is still reasonable, but we would need to create conveniences in testing that check whether the fields of a snapshot are equal and whether the items of a trajectory are equal.

Okay, I will fix this tomorrow (cannot get my computer right now which runs pycharmm). But let me quickly summarize, that we want to keep the attempt to identify equivalence for CVs using the pickling approach. Basically just fix the code so it works in 3.6 and not alter the equivalence __eq__ behavior.
Sounds good. I will use the fixed code pickling and that should do it. Of course if you implement the same function with different code then this will still fail. But that is another topic.
About the name. I will think of this, but I believe this is the case. It used to be needed for the variable naming of the cache and I think to be human readable in the netCDF file it still is used, but could be replaced by the UUID of the object.


command blocks AND OTHER also a option

to make the song more accurate using diffrent types redstone  that does differnet activation and differnet  tics and command blocks

Duplicate of #29

this is not a duplicate

What you described seems to be using other kinds of redstone contraptions to make playback more accurate, as well as using command blocks to be able to play custom sounds and out-of-range notes.
Although these are not mentioned in the issue above, both of those features are planned for the upcoming schematic rewrite.
If I misunderstood your request, feel free to clarify it!

I'm sorry, this would've been better flagged as a duplicate of #53!


added the new url format for Gronkh and tests [Issue #5531]

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

Gonkh.tv switched to a new url format. I have updated the regex to include both the new scheme and the old one. I have added new tests. However the tests will fail because view_count field is required and it is a dynamic value. I have tested it with the current accurate value and it works.
Fixes #5531
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Don't overwrite the old test, keep the old and add the new

However the tests will fail because view_count field is required and it is a dynamic value

'view_count': int,

Don't overwrite the old test case, keep the old and add the new. We want tests for both URL formats

However the tests will fail because view_count field is required and it is a dynamic value

'view_count': int,

Thanks. The tests are passing


Complication error for R package installation

I followed the instruction in website to install updated R packages, and I got the following error during complication.
In file included from xgboost_custom.cc:6:
src/common/random.h:32: error: ‘constexpr’ does not name a type
src/common/random.h:36: error: ‘constexpr’ does not name a type
xgboost_custom.cc: In member function ‘xgboost::common::CustomGlobalRandomEngine::result_type xgboost::common::CustomGlobalRandomEngine::operator()()’:
xgboost_custom.cc:62: error: ‘max’ is not a member of ‘xgboost::common::CustomGlobalRandomEngine’
make: *** [xgboost_custom.o] Error 1
ERROR: compilation failed for package ‘xgboost’

Yes, I have the same problem on a linux server. I have no issues installing from CRAN at all, but installing from /dmcl/drat returns error like this.

That "complication" is because of the old gcc compiler version which doesn't support the C++11 constexpr specifier. If it's Redhat or CentOS 6.x, you can install devtoolset-3 or 4 that has newer gcc.

@khotilov You are right. A compiler with C++11 support is required for the latest version of xgboost.


Glassmorphism Effect on the Navbar of Reading Therapy page

Can I work on the Navbar of Reading Page Therapy?

@myhacktech i have already made a PR regrading this you can check out #221
And actually this issue is on talking therapy page

@SahilDahekar @MohitNamdev22 wants to do it on Reading Therapy and not Talking therapy. Don't quarrel with each other.


Being able to set values like 0.001 in the editor

Godot version:
Godot Beta 4
OS/device including version:
Ubuntu 16.04
Feature description:
Pretty self explanatory, for setting up materials it's really handy to have that precision.

Please be more explicit, there are several values where you can already use 0.001. Some are limited to a range of 0.01 as common values don't need to go below. If you have a use case that needs to go below, you need to be explicit about which one.

Oh, sorry.
For example, if y want to add to a material a second pass to do an outline, the 'Grow Amount' cant be set like that.

I personally want that precision for Camera near and far planes - I think it could be very useful for simulate really small environments

Related: #19242

I think this commit addresses it: #29835

And further fixed for all properties without a range by #30776.


updated readme file and solved a katta Problems.

I hope you like the documentation. It is October don't forget to contribute on Git Hub. Let's Code together

Thanks for the invitation.


Generate CLI library from gen_rust.sh script

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #293

PR #294   👈

This stack of pull requests is managed by Graphite.

Merge activity

Dec 23, 10:17 PM: @@NathanFlurry started a stack merge that includes this pull request via Graphite.


feat: Qdrant storage connector

Description of changes:
This PR introduces a new storage connector for adding documents to Qdrant - https://qdrant.tech/.
Associated docs and tested example templates have been added.

Amazing work! I've fixed a few formatting issues, and removed the AWSCLIV2.pkg which remained in the qdrant storage connector and was seemingly unused. Let us know if you have any issue with the merge. Thanks !!

Thanks @HQarroum.
It's all good.


Library release notes

Hi,
Have you published anywhere the library release notes?
I think it'd be useful to understand any potential impact of new versions.

There are some here : https://github.com/confluentinc/confluent-kafka-dotnet/releases
Major change though is the binding to librdkafka 0.9.5 instead of 0.9.4.
You can find the release note of it here: https://github.com/edenhill/librdkafka/releases/tag/v0.9.5

@treziac great, thanks.


feat: createMockFactory()

WIP

Codecov Report

Merging #9 (77cba25) into main (21b882c) will decrease coverage by 5.44%.
The diff coverage is 68.82%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   88.63%   83.19%   -5.45%
==========================================
  Files          78       82       +4
  Lines         915     1071     +156
  Branches      204      272      +68
==========================================
+ Hits          811      891      +80
- Misses         80      140      +60
- Partials       24       40      +16

Impacted Files
Coverage Δ

src/lib/buildEmbedField.ts
66.66% <0.00%> (-16.67%)
:arrow_down:

src/lib/buildImageFieldImage.ts
80.00% <0.00%> (-6.67%)
:arrow_down:

src/lib/generateCustomTypeId.ts
80.00% <0.00%> (-20.00%)
:arrow_down:

src/lib/generateTags.ts
85.71% <0.00%> (-14.29%)
:arrow_down:

src/lib/getMockImageData.ts
80.00% <0.00%> (-20.00%)
:arrow_down:

src/model/sliceZone.ts
100.00% <ø> (ø)

src/value/richText/list.ts
41.66% <0.00%> (ø)

src/value/richText/oList.ts
83.33% <0.00%> (-8.34%)
:arrow_down:

src/value/richText/paragraph.ts
83.33% <0.00%> (-8.34%)
:arrow_down:

src/value/richText/preformatted.ts
83.33% <0.00%> (-8.34%)
:arrow_down:

... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b882c...77cba25. Read the comment docs.


Style and Improve Faqs Sections

Feature Title
Improve UX when exploring FAQ section

Description
Added

Transition, so that description will appear smoothly.
Animation
Re - design the UI for Better UX.

Tested for all Screen size and optimised

Issue Type
Frontend
Screenshot of the feature if done ?

Are you taking this fetaure implementaion

Yes

Checklist

[ ] I have Made this contribution as per the CONTRIBUTING guide in this repo
[ ] I have tested in local Environment.
[ ] I have made the fix as per issue converstaion
[ ] I have starred the repository ⭐

We have some errors in deployement @AmanJain18 , can you check vercel logs. Seems issue with jquery

I can't see anything on Vercel Gives Error 404

Will have a look. Meantime check for any bugs in website.
Also check for https://github.com/jsvigneshkanna/leetcode_solved_programs

For using font awesome remove cdn linl as it is  outdated and install its package

@AmanJain18 ,please raise issue for that

@AmanJain18 ,please raise issue for that

Fixed all issue and errors...

Will review and let you know @AmanJain18
Thank you

Did u check ?
If found any issues, let me know... @jsvigneshkanna

@AmanJain18 , can you please make the text and bg color in sync with website. New blue, yellow, green colors look odd

And also check why closing faq section isnt working

And also check why closing faq section isnt working

You Means Individual ques and ans section is not closing ?

Yes, the close/minus icon not working

@AmanJain18 , can you please make the text and bg color in sync with website. New blue, yellow, green colors look odd

Ya i will fix color scheme...

Yes, the close/minus icon not working

Ya, i was trying to implement that functionality but i couldn't
because in pure css we can toggle any class on click
but how to toggle tailwind css class directly.
if you know that let me know

You can check whether the class is there in the element and remove or add it right. Another way of toggling
Just try to implement it. If not I will look for the way. Am away from system, may take a day to merge
Appreciate that

https://user-images.githubusercontent.com/89217032/200136286-f3e6b196-c6b7-4137-9c5e-467f537028e2.mp4
Is this Color Scheme Ok ?

@AmanJain18 this looks perfect

Implemented Functionality as required...🙂

Done the rerquired changes... Of FAQs Section...

Great @AmanJain18


Update tr.json

Turkish translation

Thanks for the PR.
I just modified a few lines to prepare for the v5 update, if you don't mind, can you also translate those?
https://github.com/tabarra/txAdmin/blob/develop/locale/tr.json


Unity Editor Crash with realtime database emulator.

Please fill in the following fields:
Unity editor version: 2019.3.13f1
Firebase Unity SDK version: 6.14.0
Source you installed the SDK (.unitypackage or Unity Package Manager):Unity Package Manager
Firebase plugins in use (Auth, Database, etc.):Database
Additional SDKs you are using (Facebook, AdMob, etc.): Nothing
Platform you are using the Unity editor on (Mac, Windows, or Linux): Macbook Pro
Platform you are targeting (iOS, Android, and/or desktop): Android
Scripting Runtime (Mono, and/or IL2CPP): Mono
Please describe the issue here:
Unity Editor Crash with realtime database emulator. Doesn't unity sdk support the realtime database emulator?
Unity seems to work well with functions emulator.
Please answer the following, if applicable:
Repro steps:

Create a new empty project.
setup firebase unity sdk. https://firebase.google.com/docs/unity/setup
setup firebase local emulator. https://firebase.google.com/docs/emulator-suite
add below script to GameObject (I changed "YOUR_DATABASE_NAMESPACE" to my project id. Is it correct?)

public class Test : MonoBehaviour
{
    // Start is called before the first frame update
    void Start()
    {
        var database = Firebase.Database.FirebaseDatabase.GetInstance("http://localhost:9000?ns=YOUR_DATABASE_NAMESPACE");
        database.GetReference("test").GetValueAsync().ContinueWith((task) =>
        {

        });
    }

    // Update is called once per frame
    void Update()
    {

    }
}

run preview
crash!

What's the issue repro rate? (eg 100%, 1/5 etc)
100%

@unace

Did you call Firebase.FirebaseApp.CheckAndFixDependenciesAsync() before using any database APIs?
Could you take a look if Editor.log and post the crash callstack?
For even more precise callstack, could you try to use Xcode to attach to the Unity instance and capture the the callstack of all threads (You can use bt all when Xcode breaks after Unity crash)

Thank you,
Shawn


Auto Light / Dark Theme switch based on time of day

Description of the new feature / enhancement
Make Windows switch to light or dark mode based on time of day like the blue light filter.
Scenario when this would be used?
This would be especially useful to reduce eye strain when using Windows at night, while having bright colors during the day.
Supporting information
No response

due of #23621


First ping from a VM can take over 1s

E.g. typical ping from a VM:
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=63 time=725 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=63 time=0.094 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=63 time=0.084 ms
64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=63 time=0.145 ms
64 bytes from <IP_ADDRESS>: icmp_seq=5 ttl=63 time=0.890 ms
64 bytes from <IP_ADDRESS>: icmp_seq=6 ttl=63 time=0.087 ms

We've also seen this on in the docker prototype so it's not a VM issue.  I managed to capture a PCAP of the issue and it looks like it's the ARP that is taking the additional time.

Investigated further, looks like this is simply a tuneable sysctl: net.ipv4.neigh..proxy_delay.  The value is described here: http://man7.org/linux/man-pages/man7/arp.7.html
proxy_delay (since Linux 2.2)
          When an ARP request for a known proxy-ARP address is received,
          delay up to proxy_delay jiffies before replying.  This is used
          to prevent network flooding in some cases.  Defaults to 0.8
          seconds.

I tried adjusting that value to 0 and my ARP response times dropped to <1ms.  I tried increasing it to 150 and the first ping packet time doubled to 1500ms.
I'll see if I can put up a pull req.


Improve user messages for deadline & related predicate

Summary of Changes:

Change the error message displayed for invalid deadline input
Add an additional check in FindCommandParser.java such that range with a start date that's later than then end date is no longer allowed.

resolves #230
resolves #257

Codecov Report

Merging #262 (fd9fa90) into master (7b9c48f) will decrease coverage by 0.07%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##             master     #262      +/-   ##
============================================
- Coverage     48.54%   48.46%   -0.08%
- Complexity      382      383       +1
============================================
  Files            89       89
  Lines          1786     1791       +5
  Branches        219      221       +2
============================================
+ Hits            867      868       +1
- Misses          821      823       +2
- Partials         98      100       +2

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/FindCommandParser.java
62.50% <0.00%> (-5.69%)
:arrow_down:

...c/main/java/seedu/address/model/task/Deadline.java
90.90% <ø> (ø)

...u/address/model/task/DeadlineInRangePredicate.java
46.15% <33.33%> (-3.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9c48f...fd9fa90. Read the comment docs.


Add TypeScript React Support

Add '.tsx' to tagger
Add option to GeneralOptions
Add tests for '.tsx' extension
Update CHANGELOG
Update README

Closes #57

Looks good @mklosterboer!
However I'm currently at work where I have no ability to test this change. I'll have to do it this afternoon.
I'll let you know once I've released this new change to the Visual Studio Marketplace!
Thanks for your contribution 😸

@jwldnr
No problem!
Thanks for being open to changes and responding quickly!

Changes work exactly as you thought they would. Good work @mklosterboer! I'll go ahead and release this to the Visual Studio Marketplace. I'll post back here with the new version number shortly. 👍

Version 1.1.104 will soon be available! Again, thanks for your contribution @mklosterboer

Thanks again for making it painless. I was not anticipating resolving this issue in 24 hours. Thanks @jwldnr!


Error inspektor-gadget.yml

Description
Encountering an error "Missing property 'matrix'" within the GitHub Actions YAML configuration file. Specifically, the error occurs under the "strategy: fail-fast: false" section, indicating a potential issue with the nesting or structure of the matrix property.
Impact
The workflow fails to execute properly due to the missing matrix property, preventing the CI/CD pipeline from running the specified jobs.
Environment and steps to reproduce

Go to .github\workflows\inspektor-gadget.yml

Expected behavior
The workflow should correctly recognize and utilize the matrix property within the strategy section.

Hello  @mauriciovasquezbernal  @burak-ok
I encountered an error in the workflow. If you find this issue valuable, please assign it to me, and I will try to fix it
Thank you

Hi @andoriyaprashant, I'm not sure I follow this issue. Could you please point to the specific line in the workflow definition where this issue is?

Hi @andoriyaprashant, I'm not sure I follow this issue. Could you please point to the specific line in the workflow definition where this issue is?

Here Sir

Oh right, good catch! I think we need to remove those two lines. Happy to review a PR fixing it.


Refresh Sentinel topology after full connectivity outage

Bug Report

Current Behavior

Lettuce 6.1.6 RELEASE implementation of SentinelConnector updates sentinel topology when it is first connect or failover event is occurred.
Let's suppose failover event is occurred when all of sentinel psubscribe connection has been disconnected(because of network issue like network partition between lettuce client and sentinel, etc..)
There is no available sentinel psubscribe connection. So it has no idea to receive failover event.
After sentinel psubscribe connections are reconnected by ConnectionWatchDog, ConnectionProvider still has stale node information until new failover event is occurred.
Because ConnectionWatchDog just reconnects sentinel connections and executes psubscribe * command.
Input Code
https://github.com/cprayer/lettuce-sentinel-topology-issue.git
Current configuration of StatefulRedisMasterReplicaConnection is below.
    @Bean
    public StatefulRedisMasterReplicaConnection<byte[], byte[]> masterReplicaConnection() {
        RedisClient redisClient = RedisClient.create();
        redisClient.setOptions(ClientOptions.builder()
                .socketOptions(SocketOptions.builder()
                        .keepAlive(SocketOptions.KeepAliveOptions.builder()
                                .idle(Duration.ofSeconds(3))
                                .interval(Duration.ofSeconds(3))
                                .count(3)
                                .build())
                        .build())
                .build());

        StatefulRedisMasterReplicaConnection<byte[], byte[]> connection = MasterReplica.connect(redisClient, ByteArrayCodec.INSTANCE, RedisURI.builder()
                        .withSentinel("<IP_ADDRESS>", 26379)
                        .withSentinelMasterId("mymaster")
                .build());

        connection.setReadFrom(ReadFrom.MASTER);
        return connection;
    }

It uses one sentinel connection for reproducing issue.

Run jibDockerBuild gradle task
Run docker run -p 8080:8080 -d demo:0.0.1-SNAPSHOT (if you are using m1, run docker run --platform linux/amd64 -p 8080:8080 -d demo:0.0.1-SNAPSHOT)
Run curl <IP_ADDRESS>:8080/stop (It stops redis sentinel that has 26379 port)
If you found Connection refused: /<IP_ADDRESS>:26379 message in application log(docker logs ${CONTAINER_ID}), Run curl <IP_ADDRESS>:8080/failover
(It sends manual failover event to redis sentinel that has 26380 port, sentinel topology is not refreshed because there is no available sentinel psubscribe connection)
Run curl <IP_ADDRESS>:8080/start (It starts redis sentinel that has 26379 port, sentinel psubscribe connection is reconnected by ConnectionWatchDog)
Run curl <IP_ADDRESS>:8080 (It sends SET HELLO WORLD command to redis master, but it failed with READONLY You can't write against a read only replica. Because ConnectionProvider has stale node information)

Expected behavior/code
I think sentinel topology also should be refreshed when sentinel psubscribe connection is reconnected by connectionWatchDog.
Environment

Lettuce version(s): 6.1.6.RELEASE
Redis version: 6.2.6

Topology discovery is based on Pub/Sub after the initial connect. The case above is pretty specific to an entire outage and we haven't considered that case. Instead, the underlying assumption is that we have connectivity to at least one Sentinel node.
Supposedly the most difficult bit could be identifying a full outage and then triggering a topology refresh upon connection activation.

@cprayer , you can disable auto reconnection
client.setOptions(ClientOptions.builder()    .autoReconnect(false)    .build());
and run validateConnection() as self-healing:
lettuceConnectionFactory.validateConnection()
to validate/recreate the connection.
Be aware of the side effects: https://github.com/spring-projects/spring-data-redis/issues/2179

Moving this to the Icebox as it is very specific.
If you are hitting this please let us know so we can consider reprioritizing.


fix(maxscale): correct usage of maxskew

I forgot to add the key for configuring the maxSkew.
Ref.: https://github.com/4ALLPORTAL/helm-charts/pull/177#discussion_r1275450362

Very Good. Thank you. @marvinWolff
Since the automation does not work from your branch, please manually edit the version in README.md?
Example:

Done :+1:


How to parse Dates in Api with zod

Hi, Great wrok with zod. maybe i'm using it wrong but how would i parse a date in Api params i would get a string of Date and Zod expects a Date object. Should i  use the zod.string() and parse the date in the backend?

Yes, I'd recommend using a string field. If you want to verify that the string is, say, a valid ISO date string, then use a custom validator  in combination with something like validator.js to enforce that. 👍

Thanks Awesome


Restore a deployed schema scrip to original form

V9__premium_list_currency_type.sql has already been deployed
to sandbox when its todo line is removed. Flyway refuses to
push it because file checksum does not match.
Lessons learned:

Do not put TODO in flyway scripts
Need presubmit check for change to deployed scripts.

This change is

Abandoning this change.
Manually fixed flyway metadata in sandox.


Add lsv to V's Coreutils (ls)

Are you going to add lsv to V's coreutils?

 That said, if folks want it I'll submit a pull request.


Set state to provider

Hi Tanmoy,
I have completed the Set state to provider #25 issue and I also refactored the package architecture.
Do well to review and test.
I will be expecting to hear from you soonest.

Looks great. Thanks for contributing with this issue. If you have any ideas how to improve this package please inform me.

Yeah, sure.
I am going to reach out to you when I have an idea.

Can you close the issue?
I realize the issue is still open.


Feature/google auth

Title and Issue number
Title :Login Page Improvement Request
Issue No. : #18
Code Stack :
Close #<#18>

Video (mandatory)
https://github.com/user-attachments/assets/c339f5f1-8c7f-4cad-88f6-e416a62a216e
Checklist:

[ x] I have mentioned the issue number in my Pull Request.
[x ] I have commented my code, particularly in hard-to-understand areas
[x ] I have created a helpful and easy to understand README.md if its a new page/tech stack
[x ] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?

[x ] I'm a GSSOC-EXT contributor
[ x] I'm a HACKTOBERFEST contributor

@samriddhitiwary, can you send PR again? The previous one is fails in deploy.

@jeevan10017 Ok

@jeevan10017 thank you for merging could please add all the label in the PR also otherwise it won't count it

I have already labeled in #73

@jeevan10017 Thank you soo much


Closing error channel can panic

If the callback returns an error (without having a fallback) an error is sent here: https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L96.
If a timeout in timer.C occurs, an error will be sent here: https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L125
Both errors can be triggered on the same call (i.e. if a timeout occurs and later the callback returns an error without a fallback function).  If the error channel is closed after the caller receives the first error, the second error won't be able to be sent on a closed channel and panic.  If this is expected behavior, should we document it here: https://github.com/afex/hystrix-go#waiting-for-output ?  The workaround is not to close the channel and let it GC the second error.

Another side effect of this is that the fallback function is called twice.

where are you seeing the error channel being closed? channels should not be closed by receiving code, only by senders: http://golang.org/pkg/builtin/#close
you are right that there are some nuances around timeouts since go does not offer (afaik) a way to kill an in-progress goroutine. the behavior you identified is also seen if you have non-buffered response channel, and a command which times out but doesn't fail.  your run function will eventually attempt to send to the channel, blocking indefinitely since you are likely no longer selecting on it.  this causes goroutine leaks.
you do highlight a great point that we have nothing that will block the fallback from executing twice which is clearly an error. i'm going to use this issue to track that we need to change that behavior

[ ] prevent post-timeout errors from triggering fallback

fixed by #29


count_touching_cells reports self touching self

A user reports, "the count_touching_cells function does not properly work when asked to compute with the same phenotype. It accounts that a cell is touching itself."

The count touching cells algorithm does not correctly handle this case. A request for self touching self is detected and ignored with a warning.


Color Browser Version2

There are conflicts from what I see.
Please help me. I have never fixed conflicts.

Today I learned how to resolve conflicts.
Thanks.


Animated.event() with useNativeDriver returns an object, not a function

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS:  macOS Sierra 10.12.6
Node:  7.8.0
Yarn:  1.0.1
npm:  4.2.0
Watchman:  4.7.0
Xcode:  Xcode 9.0 Build version 9A235
Android Studio:  Not Found
Packages: (wanted => installed)
react: 16.0.0-beta.5 => 16.0.0-beta.5
react-native: 0.49.1 => 0.49.1
Target Platform: iOS (11)

Steps to Reproduce

I just hit https://github.com/facebook/react-native/issues/13377 but with onScroll on a ScrollView. This line checks if I have used useNativeDriver, and if so, returns the AnimatedEvent object, not a function. Therefore, any prop expecting a function – onScroll, onPanResponderMove or any other – will throw an error.
Is this a bug or expected behaviour? If useNativeDriver cannot be used with any prop expecting a function, this should be documented.

This is expected behaviour, as the PanResponder doesn't support native animations yet, because it's implemented in pure JS - hence it can't generate native events, as it has to pass the JS to native bridge to update the animations (because it handles touches in JS). Furthermore it even has to pass the bridge twice and performs worse than standard JS animations (which already can be pretty laggy), due to the fact, that the touch also has to be passed to the JS side, making it like this:
Native                 |   JS
Touch Event ->  |   handle touch
|   adjust animation
Animate               | <- new animated value
Problem: The communication over the JS - native bridge is pretty expensive. You could try using something like https://github.com/wix/react-native-interactable (it says experimental, but in my experience it's quiet stable - don't quote me on that tho), which has native implementations with animations, callbacks and configurable physics so you can do quiet a lot with it.

@DragonRaider5 Thanks for your reply, but I think this is still unexpected behaviour. My use case doesn't involve PanResponder at all.
Animated.event() with useNativeDriver doesn't work with onScroll either, and the docs specifically say here that:

The native driver also works with Animated.event. This is specially useful for animations that follow the scroll position as without the native driver, the animation will always run a frame behind the gesture due to the async nature of React Native.

Just to be totally clear: the bug I am reporting is that useNativeDriver cannot currently be used with any prop expecting a function, including onScroll.

Hi,
are you using an Animated.ScrollView?

Amazing, that fixed it! Thanks so much. I had no idea I had to use an Animated component on the source of the event as well as the target of the animation (I am not animating the ScrollView itself).
I think maybe this should be highlighted in the docs? The docs currently say "Only animatable components can be animated", they don't mention that the source of onScroll events should also be Animated.

You're welcome 👍  it already says so in the docs, look closer at the given example - but you're right, it's a tiny detail easy to overlook. Highlighting might help there.
Happy to have helped 😃

Same issue same solution; thanks @DragonRaider5

@DragonRaider5 If I use Flalist for animated then can I use Animated.FlatList ?  Is this Animated.FlatList  supported fully with others features of FlatList?


Swaps

I was having problems with the other pull request, I think due to the private to public transition. This is a continuation of #654.
Should be ready for review now. I'm working on adding more extensive testing using random sets of operations.
@kevinsung Checkout out executor_test.py for an example usage of the whole shebang.

@Strilanc Any thoughts on how to make mypy happy?

When you want to make a large chance, you should make a "train" of changes that each depend on the last with the final one being the full PR you have here. Alternatively, you can create totally independent PRs and a "glue" PR that links them together.
Putting everything in one PR slows the reviewing process down, because doing a proper review takes an hour every time. You'll get this change in faster if you pull off small pieces.

Okay, I'll split it up.

@Strilanc After #781, should I split out strategy into a separate PR, or should we do it together with executor here?

If it's around 500 lines or less total, we can do it here I think.

I don't know what's up with the pytest failures in Travis. Everything passes simple_check on my machine.

By the way, this PR is ready for review again. I'm sure exactly in how many lines it differs from master, but I think subtracting the others that have already been merged, it's at most not much more than 500. In any case, executor and strategy make much more sense together.

Okay, when I switch to 3.5 I can replicate the test failures sometimes. strategy_test fails sometimes and passes others. There is no randomness in strategy_test. This is weird.

@Strilanc any thoughts on what could cause this behavior?

Are you sure you're not iterating over the items of a dictionary or a set? Older versions of python do not define an order for this iteration, and it can change from execution to execution.

strategy_test is still failing; I don't see anything that depends on a consistent ordering of dict elements.

Hey Bryan, just checking to see if this needs a review right now or you are still working on fixes.  If so let me know and I will move to top of stack.

It needs a review.

Done.

Thanks for reviewing!


“CMOS Gate-Level Netlist” example segfaults on abc step

This was done by following the example on http://yosyshq.net/yosys/screenshots.html precisely.
…
yosys> abc -liberty cmos_cells.lib

13. Executing ABC pass (technology mapping using ABC).

13.1. Extracting gate netlist of module `\counter' to `<abc-temp-dir>/input.blif'..
Extracted 14 gates and 22 wires to a netlist network with 6 inputs and 4 outputs.

13.1.1. Executing ABC.
Running ABC command: <yosys-exe-dir>/yosys-abc -s -f <abc-temp-dir>/abc.script 2>&1
ABC: ABC command line: "source <abc-temp-dir>/abc.script".
ABC:
ABC: + read_blif <abc-temp-dir>/input.blif
ABC: + read_lib -w /home/alex/project/cmos_cells.lib
ABC: Parsing finished successfully.  Parsing time =     0.00 sec
ABC: Warning: Templates are not defined.
ABC: Libery parser cannot read "time_unit".  Assuming   time_unit : "1ns".
ABC: Libery parser cannot read "capacitive_load_unit". Assuming   capacitive_load_unit(1, pf).
ABC: Scl_LibertyReadGenlib() skipped sequential cell "DFF".
ABC: Library "demo" from "/home/alex/project/cmos_cells.lib" has 3 cells (1 skipped: 1 seq; 0 tri-state; 0 no func).  Time =     0.00 sec
ABC: Memory =    0.00 MB. Time =     0.00 sec
ABC: Warnings: genlib library reader cannot detect the buffer gate.
ABC: Some parts of the supergate-based technology mapper may not work correctly.
ABC: + strash
ABC: + ifraig
ABC: + scorr
ABC: Warning: The network is combinational (run "fraig" or "fraig_sweep").
ABC: + dc2
ABC: + dretime
ABC: + strash
ABC: + &get -n
ABC: + &dch -f
ABC: + &nf
ABC: Segmentation fault
ERROR: ABC: execution of command "/usr/local/bin/yosys-abc -s -f /tmp/yosys-abc-sXUWiw/abc.script 2>&1" failed: return code 139.

Not sure what's going on there, it could be an issue in abc itself. In any case, examples in the documentation should not segfault I think.

Going over old tickets, it looks like the original issue (ABC segfaulting on the example) is long gone. I will go ahead and close the ticket.


Replace *_HOST and *_PORT env variables with *_URL variable

To be consistent with the other APIs

(removed auto-merge in case you want to address the comment before merging)


ADOTDIR where is it used?

export ADOTDIR=$HOME/.zsh/bundle

is it safe to delete this env variable? is it needed anywhere?

It defines where antigen stores it's stuff. If you remove it, antigen will fall back to it's default location.


tests: add test for bug 5197

This test should fail on all branches as of now.

Merged in #898, thanks!


How to debug the "You need to include some adapter that implements karma.start method!" error?

Expected behavior
I expected that karma is still working after update from 0.13.9 to 1.1.0. If karma is not working properly anymore i would like to have some more information how to fix this problem myself
Actual behavior
07 07 2016 08:36:13.016:INFO [karma]: Karma v1.1.0 server started at http://localhost:8080/
07 07 2016 08:36:13.019:INFO [launcher]: Launching browser PhantomJS with unlimited concurrency
07 07 2016 08:36:13.087:INFO [launcher]: Starting browser PhantomJS
07 07 2016 08:36:14.570:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)]: Connected on socket /#kR-iedk86tRVJxHqAAAA with id 89582790
PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
You need to include some adapter that implements karma.start method!
Enviroment Details
https://github.com/C3-TKO/junkan/blob/update-karma-to-1.0.0/karma.conf.js
https://github.com/C3-TKO/junkan/blob/update-karma-to-1.0.0/package.json
Steps to reproduce the behaviour

Checkout branch https://github.com/C3-TKO/junkan/tree/update-karma-to-1.0.0
npm install
npm run test

I would be glad if you could tell me hoy debug this issue myself. I already checked other issues with the same error and most of the times this is an error regarding a dependency but i failed at recognizing how to debug this myself and how to find out where the adapter fails. It should be the one of karma-mocha.

This is related due to some plugins not being updated and ready for karma 1.0. See #2194 for details and workarounds.


Converting Datetime to Natural Language produces TextFeaturizer error during pipeline fit

Reproducer
import evalml
import pandas as pd
import woodwork as ww
import pytest

df = pd.read_csv('/Users/dylan.sherry/Downloads/fraud_detection_cleaned_v2_2500rows.csv')
dt = ww.DataTable(df)
y = dt.pop('fraud')
assert str(dt.logical_types['datetime']) == 'Datetime'

# manually change datetime to natural language. strange thing to do but it is possible.
dt = dt.set_types(logical_types={'datetime': 'NaturalLanguage'})
assert str(dt.logical_types['datetime']) == 'NaturalLanguage'

# define a pipeline _without_ a datetime featurizer, since there's no datetime-typed features in the data
pipeline = evalml.pipelines.BinaryClassificationPipeline([
    'Imputer', 'One Hot Encoder', 'Text Featurization Component', 'Elastic Net Classifier'])

# get error during pipeline fit
with pytest.raises(TypeError, match='invalid type promotion'):
    pipeline.fit(dt, y)

Root Cause
In our TextFeaturizer, we normalize to woodwork DataTable, get a pandas dataframe, run featuretools to compute some features, then run our LSA component to produce more features.
When we run the LSA component, we should be passing along the woodwork DataTable, because that contains the information that the "datetime" column happens to be NaturalLanguage-typed. However, instead we currently pass the pandas dataframe. This means the LSA component will run woodwork type inference, determine that "datetime" is a Datetime-typed feature, try to use that feature to generate TF-IDF features and error out.
Here's the line which causes the problem.
Fix
Short-term: update that line to provide the woodwork DataTable instead of the pandas dataframe, to preserve the user-specified feature types.
Long-term: hey @freddyaboulton does your woodwork accessor feature branch fix this problem? If not, we should definitely make a fix on there as well.

@dsherry I think there are two issues here! The issue you pointed out with the TextFeaturizer implementation is valid but I don't think it's what's causing the error in your repro. If I instantiate a TextFeaturizer and run it with your data, I get a different stacktrace (using fraud cause I don't have your dataset):
import evalml
import pandas as pd
from evalml.pipelines.components import TextFeaturizer
import pytest

X, y = evalml.demos.load_fraud(1000)

assert str(X.logical_types['datetime']) == 'Datetime'

X = X.set_types(logical_types={'datetime': 'NaturalLanguage'})

with pytest.raises(AttributeError, match="'Timestamp' object has no attribute 'lower'"):
    TextFeaturizer().fit_transform(X, y)

I think the other sneaky thing is that the ComponentGraph calls pd.concat and then infer_feature_types so the woodwork info gets nuked! link
I think that's what actually happening in your repro because the TextFeaturizer doesn't even know there are text features in the data:
import pytest

X, y = evalml.demos.load_fraud(1000)

X = X.set_types(logical_types={'datetime': 'NaturalLanguage', 'card_id': "Double", "store_id": "Double",
                               "amount": "Double"})
assert str(X.logical_types['datetime']) == 'NaturalLanguage'

# define a pipeline _without_ a datetime featurizer, since there's no datetime-typed features in the data
pipeline = evalml.pipelines.BinaryClassificationPipeline([
    'Imputer', 'One Hot Encoder', 'Text Featurization Component', 'Elastic Net Classifier'])
with pytest.raises(TypeError):
    pipeline.fit(X, y)

assert pipeline._component_graph[2]._text_columns == []

The first issue you bring up will be fixed by #2181 ! But the second issue is trickier. I'm hoping https://github.com/alteryx/woodwork/issues/884 will help. The other thing we can do is not use concat if there is only one .x input in the ComponentGraph but using ww.concat seems like the best thing to do.

@freddyaboulton is gonna pick this up. Thank you @freddyaboulton !
Acceptance criterion: make sure each component in the graph is given the "right" feature types. In particular, if custom types were set which differ from woodwork's default inferences, those custom types should be what each component is given for that feature, not woodwork's default inference. Add unit test coverage which proves this.
We were just chatting about the code changes in #2297 . I think the woodwork accessor work fixed some of the issues there, which is good news. In particular, the text featurizer code looks much better now.


Add github actions CI

Add a simple CI to check the format and lint of the code. Will have a follow-up PR for running tests.
https://github.com/ray-project/ray_beam_runner/issues/5

cc @pabloem


DICOMweb server

🚀 Feature Proposal
Integrate a DICOMweb server. As a reference we can use https://github.com/dcmjs-org/dicomweb-server that is almost 1:1 spec compliant implementation in Fastify and CouchDB.
We need to make it a plugin that we can register on our own Fastify's instance.
Motivation
We are going to integrate https://github.com/OHIF/Viewers on the HospitalRun FE.

👋 I thought y'all would find this interesting: @pieper, @emelalkim, @jamesapetts, @swederik


Selection isn't properly applied if items haven't been realized yet.

When getting the container for an item, make sure we create it if it hasn't been created yet.
Description
When setting the MenuItemSource or FooterMenuItemsSource in the Loaded event, selection isn't updated properly as none of the repeater children have been created.
Motivation and Context
YourPhone is running into bugs like these as we set the items in the Loaded event and it causes the selection to not be updated properly.
How Has This Been Tested?
Added test case for this scenario.

The other option is to check if the item should become selected in OnElementPrepared. That might be cleaner and more correct.

/azp run

@jlaanstra the merge conflict is a little too hard to do in the web browser I think, could you take a look?

Yeah I'll have a look at the merge conflict.

/azp run

/azp run

@jlaanstra some tests are failing, can you take a look?

/azp run

@jlaanstra would you be able to take a look at the test failures?

@ojhad I might have some time to next week to revisit.

Closing this PR since these fixes ported from WinUI3 address the scenario of selecting unrealized items.


MM-8694: Add PostgreSQL support

Add PostgreSQL support, and allow to configure it throug values. This would be the first step for other options like patroni backend.
To test it, is easy, you simply create a values.yaml file with the content:
global:
  dbBackend: "postgresql"

mysqlha:
  enabled: false

postgresql:
  enabled: true

and then run:
make package
helm install dist/mattermost-helm-0.2.4.tgz -f values.yaml

This is for a single postgresql server.

looks good, i will review later this week

Is there any existing postgres charts that have replication?

@jwilander Yes, that will be my next step. In incubator exists a chart call "patroni" which is the Postgresql cluster from Zalando. My plan is to add that soon.

No longer needed, because the decision has been to support only one database included directly in the chart


MinSdkVersion 21

Hello guys! Is it possible to work with viro using minSdkVersion = 21? I cannot use 24 cause of another kit.

Hi @ruzrulit, unfortunately we cannot support under SDK 24. Some of the ViroCore dependencies require us to be at this minimum version.


🚀 Feature: Add wrong answer message to graph exercise

When given correct input to the graph exercise, we see the next exercise. However, nothing happens when there are incorrect inputs. We want to add the "That's not quite right. Try again! " message when incorrect input is submitted, like it is with the other exercises.
Proposed Solution

add a wrongMessage function in GraphInput.tsx similar to the one in AxisInputs.tsx
edit the checkCorrect() function in GraphInput.tsx, such that it would handle incorrect input
Add the wrong message text element in the return
We want to copy what is being done in AxisInputs.tsx

[ ] :wave: I may be able to implement this feature request

This is a :rocket: Feature Request

#108 closes this issue


Control Format (width/height)

Is there a way to configure the width/height of the control?
in the following screenshot, the control is always limited to a certain size, just wondering if it can be adjusted.
Thanks

Hi,
Thanks for your feedback :) I managed to make the textbox look as if it was out of the box , with same behavior. Please install the latest solution in the solution directory :)
Here's a sample:

the issue is resolved?

it worked beautifully - thanks for your quick actions!