Revise and simplify NodePool's KubeVirt platform API

Overview
Previously, the KubeVirt platform's NodePool api consisted of the entire KubeVirt VM spec. We started with that because it gave us the freedom to quickly adapt our configurations as we experimented with various network and storage tunings. This does not provide a reasonable user experience though.
Now that we've gained more experience with the project, we feel comfortable pairing down the KubeVirt platform API to a small handful of tunings that are more approachable to end users.
API Structure
The goal of this api revision is to provide a simplified api for configuring KubeVirt VMs within a Hypershift NodePool that only exposes the bare minimal tuning users need to be aware of when using the KubeVirt platform. We've also attempted to structure this API in a way that allows us to expand easily in the future, which is why there is some nested structure patterns that might not seem optimal at first glance.
For now, the API only has two top level structs compute and rootVolume. The compute structure lets users define things like the number of cores and amount of memory to give the guest. The rootVolume structure is where users define where the rhcos images comes from and the type of storage to use (only persistent is supported right now, but this can be expanded to ephemeral storage in the future)
In the future we might have a new top level struct dedicated to network configurations once more advanced tunings are supported there. Also, the compute struct might get the addtion of a VM flavor to define the mem/cpu usage for the guest once Openshift Virtualization officially supports flavors.
More info related to the api structure can be found in this document.
Notable Changes
With this api change, we've transitioned the kubevirt platform to only use persistent storage (VM's backed by PVCs). As a result, we've introduced two new hypershift CLI options, --root-volume-size and --root-volume-storage-class. Neither values have are required, but offer users the ability to customize the root volume size and the storage class that will provision the volumes.
None of these new options are required for the hypershift cli though. Using arguments that previously worked with hypershift cli will continue to work even after this change.
Example NodePool with KubeVirt Platform
spec:
    clusterName: example-6thkl
    management:
      autoRepair: false
      replace:
        rollingUpdate:
          maxSurge: 1
          maxUnavailable: 0
        strategy: RollingUpdate
      upgradeType: Replace
    nodeCount: 5
    platform:
      kubevirt:
        compute:
          cores: 2
          memory: 4Gi
        rootVolume:
          diskImage:
            containerDiskImage: quay.io/dvossel/rhcos:4.11-pre-release
          persistent:
            size: 16Gi
      type: KubeVirt
    release:
      image: quay.io/openshift-release-dev/ocp-release:4.11.0-0.nightly-multi-2022-04-19-151226-x86_64

/cc @nirarg

/retest

/lgtm

/retest

/lgtm

nit: could we include the PR desc as the commit desc as well?

@enxebre thanks for the review. I updated the PR to more clearly communicate the api defaults. I also made the API fill in most of the defaults using the kubebuilder markers.
I left the backend defaults in the code though. Here's my reasoning.

Some of the defaults are difficult to express on the API regarding storage. In the future i plan on expanding the storage types to ephemeral and persistent. Someone would choose persistent or ephemeral storage by defining the struct they want to use. So the type of storage used would be defined as either the storage value that isn't nil, or use persistent storage (default) if both ephemeral and persistent are nil.
I feel uneasy about the crd api defaulting. It's unclear to me if someone can force a value to nil in a way that won't result in a default being set on the object itself. Unless the backend knows how to handle that gracefully, we'd have to make the reconcile loop treat that as an error, which i'd rather avoid.

Someone would choose persistent or ephemeral storage by defining the struct they want to use. So the type of storage used would be defined as either the storage value that isn't nil, or use persistent storage (default) if both ephemeral and persistent are nil.

For this you'll want to use a union discriminator to signal the type and  expectations
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#automatic-resource-allocation-and-deallocation
https://github.com/kubernetes/kubernetes/issues/35345
Then the nodePool backend should validate the input is valid as defined above and fail in a condition otherwise.

@enxebre thanks for the feedback. I think I've addressed everything in the latest round. Below are the big items i changed

Compute and RootVolume are now required and both are pointers with defaults
I transitioned to using a unionDiscriminator for the kubevirt volume types now... even though we only support persistent at the moment.
I cleaned up usage of optional and omitempty... pretty much everything is required right now other than StorageClass in the persistent volume struct.
I introduced some basic validation similar to what we have for aws and other platforms that ensures the union types and structs line up like we expect. example, type=kubevirt and kubevirtplatform is != nil,  type=Persistent and persistent!=nil. A validation error condition is set explaining why the nodepool is invalid if this occurs.
no more backend defaulting. All defaulting is handled at the api level.

@enxebre  update, ptal, thanks!

thanks @davidvossel lgtm other than https://github.com/openshift/hypershift/pull/1314#discussion_r865960814

thanks @davidvossel!
/approve
/lgtm

/retest-required

/hold cancel


make: use more portable syntax for STDERR redirect to keep OSX happy

fixes https://github.com/istio/istio/issues/4058

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
dd5ea4159974889d281c0deceebef70441214b4e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
dd5ea4159974889d281c0deceebef70441214b4e
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
dd5ea4159974889d281c0deceebef70441214b4e
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
dd5ea4159974889d281c0deceebef70441214b4e
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

/retest

I'd really like to see at least the unit tests pass on prow...

(waiting to see which prow things fail before submitting)

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
dd5ea4159974889d281c0deceebef70441214b4e
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6200ba37224a5e1dbdfb69ace0f88853c3e223af
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Enable ilbs for gcp shoots

What this PR does / why we need it:
Enables internal loadbalancer on gcp shoots.
Adds an internal field to the gcp-shoot spec network section similar to the aws-shoot, where the CIDR range for the cluster can be specified.
To create an ilb set cloud.google.com/load-balancer-type: Internal annotation on svc of type loadbalancer.
Which issue(s) this PR fixes:
Fixes #716
Release note:
Gardener does now support internal load balancers for GCP shoot clusters. In order to enable internal load balancers you need to define a network range for the subnet into which the load balancers should be placed, see [this](https://github.com/gardener/gardener/blob/master/example/90-shoot-gcp.yaml#L17) for an example. After that, you can order an internal load balancers by annotating the respective `Service` object of type `LoadBalancer` with `cloud.google.com/load-balancer-type=Internal`.

 Can you please check the logs of the CI/CD build?

LGTM, please squash the commits so that we can this PR merged.


Support prompt in addition to auth-prompt

Support to send OAuth v2 prompt instead the v1 auth_prompt.
Expected Behavior
Being able to include e.g. &prompt=login in the login-url and no auth_prompt (or neither of the two).
Current Behavior
No way to set the prompt query parameter in the login URL.
Possible Solution
Adding a new config option for prompt together with not sending auth_prompt if empty (provided by #316) would fix this.
Context
I am using an Auth2 provider that expects the prompt request param.
Your Environment

Version used: 5

cc'ing myself as I am having the same behaviour.


Remove section restriction and switch sort order

Switch the sore order to ascending and remove the section restrition on the pmg event query.

 Events: Divide events page into PMG and Non-PMG events


EmbeddingFunction should work across device

Currently the embedding function does not explicitly move the input to device or the output back to CPU. So if created with device != cpu (the default), then an exception is encountered complaining that the weights and the data must be on the same device

I think this one needs to be handled separately by each embedding function implementation. Most of the ones that we have implemented call .tolist() on tensors which move them back to cpu before ingestion. The error will occur on because the serialised embedding fcn has device="cuda" and it'll try to use cuda on a cpu device.
It kinda makes sense to error out in such cases to let the user know that cuda isn't active, rather than leave them to guess why their processing is so slow?


Add basic readme and content.

Add content! Specially in README.md, big whole tutorial is big then fragment it.

done, #2


Fix an issue with getting latest status of master

We currently get the commit status by hitting this endpoint https://api.github.com/repos/cucumber/cucumber-jvm/commits/master/status
But REF master does not always return the status and errors in 404.
 Will you assign me this one?

@sumitsawant Go for it, let me know if you need a hand with anything.

Sure @haroon-sheikh thanks a lot :smile: .Will let you know if I need any help !

Hey @haroon-sheikh I have pushed the changes .Please review them and let me know if there are any changes needed.


Guestbook-Go example - redis slave pods are not able to connect to redis master pod when running the deployment on 2 worker nodes

Hi there,
I deployed the "Guestbook-Go example" deployment on a K8S cluster, consists of a master node and 2 worker nodes.
In this case the "redis-master" pod was deployed on "node-1" worker node and the 2 "redis-slave" pods were deployed on each worker node respectively. Please see below:
[root@master-node ~]# kubectl get pods --all-namespaces -o wide
NAMESPACE     NAME                                  READY   STATUS    RESTARTS        AGE     IP                NODE          NOMINATED NODE   READINESS GATES
default       guestbook-8w7ld                       1/1     Running   0               36h     <IP_ADDRESS>         node-2
default       guestbook-bk8zn                       1/1     Running   0               36h     <IP_ADDRESS>         node-1
default       guestbook-pvh77                       1/1     Running   0               36h     <IP_ADDRESS>         node-2
default       redis-master-sgbch                    1/1     Running   0               36h     <IP_ADDRESS>         node-2
default       redis-slave-r7kbk                     1/1     Running   0               36h     <IP_ADDRESS>         node-1
default       redis-slave-sxqfm                     1/1     Running   0               36h     <IP_ADDRESS>         node-2
Everything seems to be working, but the problem that I am facing now is that the "redis slave" pods are not able to connect to the "redis master" pod.
[root@master-node ~]# kubectl logs -f redis-slave-r7kbk
[8] 04 Jan 08:40:01.708 # Unable to connect to MASTER: Connection timed out
[8] 04 Jan 08:40:02.711 * Connecting to MASTER redis-master:6379
[8] 04 Jan 08:40:22.732 # Unable to connect to MASTER: Connection timed out
[8] 04 Jan 08:40:23.734 * Connecting to MASTER redis-master:6379
[root@master-node ~]# kubectl logs -f redis-slave-sxqfm
9] 04 Jan 08:40:29.719 * Connecting to MASTER redis-master:6379
[9] 04 Jan 08:40:49.736 # Unable to connect to MASTER: Connection timed out
[9] 04 Jan 08:40:50.739 * Connecting to MASTER redis-master:6379
[9] 04 Jan 08:41:10.759 # Unable to connect to MASTER: Connection timed out
This is while, I can see that the "redis-master" pod seems to be up and running and listening to port 6379:
[root@master-node ~]# kubectl logs -f redis-master-sgbch
.
.-__ ''-._       _.- .  .  ''-._           Redis 2.8.19 (00000000/0) 64 bit
.- .-```.  ```\/    _.,_ ''-._  (    '      ,       .-`  | `,    )     Running in stand alone mode  |`-._`-...-` __...-.-.|'_.-'|     Port: 6379  |   -. ._    /     _.-'    |     PID: 1   -._    -._  -./  .-'    .-'
|-._-. -.__.-'    _.-'_.-'|  |    -.-._        _.-'_.-'    |           http://redis.io   -._    -._-..-'.-'    .-'
|-._-. -.__.-'    _.-'_.-'|  |    -.-._        _.-'_.-'    |   -._    -._-..-'_.-'    _.-'
-._    -..-'    _.-'
-._        _.-'               -..-'
[1] 02 Jan 20:02:41.291 # Server started, Redis version 2.8.19
[1] 02 Jan 20:02:41.292 # WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with Redis. To fix this issue run the command 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. Redis must be restarted after THP is disabled.
[1] 02 Jan 20:02:41.292 # WARNING: The TCP backlog setting of 511 cannot be enforced because /proc/sys/net/core/somaxconn is set to the lower value of 128.
[1] 02 Jan 20:02:41.292 * The server is now ready to accept connections on port 6379
I followed the exact instructions and used the configuration files to deploy the services, but yet I can't figure out what is wrong:
Here is the output of the "get svc":
[root@master-node ~]# kubectl get svc
NAME           TYPE           CLUSTER-IP      EXTERNAL-IP       PORT(S)          AGE
guestbook      LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>   3000:30508/TCP   36h
kubernetes     ClusterIP      <IP_ADDRESS>                   443/TCP          2d11h
redis-master   ClusterIP      <IP_ADDRESS>                6379/TCP         36h
redis-slave    ClusterIP      <IP_ADDRESS>                  6379/TCP         36h
[root@master-node ~]# kubectl describe svc redis-master
Name:              redis-master
Namespace:         default
Labels:            app=redis
role=master
Annotations:
Selector:          app=redis,role=master
Type:              ClusterIP
IP Family Policy:  SingleStack
IP Families:       IPv4
IP:                <IP_ADDRESS>
IPs:               <IP_ADDRESS>
Port:                6379/TCP
TargetPort:        redis-server/TCP
Endpoints:         <IP_ADDRESS>:6379
Session Affinity:  None
Events:
While trying to troubleshoot it, I also tried to telnet to the "redis-master" pod's internal IP and port (<IP_ADDRESS>:6379) from both worker nodes. The port is reachable from the worker node, where the "redis-master" pod is running:
[root@node-2 ~]# telnet <IP_ADDRESS> 6379
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
But not reachable from the second worker node:
[root@node-1 ~]# telnet <IP_ADDRESS> 6379
Trying <IP_ADDRESS>...
telnet: connect to address <IP_ADDRESS>: Connection timed out
^]
telnet> q
Connection closed.
Even ping to the "redis-master" pod's internal IP address from worker node-1 doesn't work:
[root@node-1 ~]# ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
4 packets transmitted, 0 received, 100% packet loss, time 3051ms
I also disabled the internal CetnoOS firewall from both worker nodes, but yet with no success.
Any idea what can be wrong? Or what I am missing?
Thanks,
Idan

@idankish I proposed a temporary fix.
I hope it helps. See #437


Update beyond-low-glucose-suspend.md

few suggestions to change max iob from 0 to desired amount

Will do
On 8 Dec 2016 16:43, Scott Leibrand<EMAIL_ADDRESS>wrote:
@scottleibrand commented on this pull request.
Looks good. One minor nit.
You can fix that by editing your patch branch, and it will automatically update the PR.

In docs/docs/walkthrough/phase-3/beyond-low-glucose-suspend.mdhttps://github.com/openaps/docs/pull/469#pullrequestreview-12063565:

+To change your max iob in your preferences.json file:
+
+Firstly you need to change directory:
+
+cd to
+
+Use the nano text editor:
+
+nano preferences.json
+
+Then amend the "max_iob": 0 to the figure you want.
+
+To check that you have done this successfully run the following:
+
+Cat preferences.json
cat needs to be lowercase.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/openaps/docs/pull/469#pullrequestreview-12063565, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANCLfwsetgxcZG5sGk_whL42vy41Ih0Oks5rGDOggaJpZM4LHvj-.


Copying content in problem hover is extremely painful

I was trying to copying a new setting in the problems hover and it was extremely painful to do so:
https://user-images.githubusercontent.com/35271042/148260276-749293ec-9c9b-461b-8875-1fbaf3733c67.mp4

This is editor hover and hence assigning to @alexdima

FWIW this works fine for me on Windows.


experiment_label consistently for sorting and filtering

while fixing broken integration tests introduced with #133, I made the behaviour for pagination and filtering more consistent by always using experiment_label instead of experiment_name.

Coverage remained the same at 64.274% when pulling eecb2bd75f69c35562830b90c66aaac12ff323b0 on fix/pagination-by-exp-label into 305a88c66c52346d1eaf439c2e90bdcc6c18ec78 on develop.

Looks good @shoeffner - thanks for fixing this! 👍  :shipit:


Draw effect animation

Hello, I'm using this libary and let me tell you it's awesome, thank you so much.
I'm trying to use the showEffectName method and the 'draw' keyword so that whenever I create the line, it has that effect, but I'm struggling to do that.
let line = new LeaderLine(
            button,
            point,
            {
              startPlug: 'behind',
              endPlug: 'disc',
              startPlugColor: '#00B7F1',
              endPlugColor: '#007AFF',
              gradient: true,
              size: 4.5,
              startSocketGravity: 0,
              endSocketGravity: 0,
              dash: {animation: true},
              path: 'fluid',
              animOptions: {duration: 500, timing: [0.58, 0, 0.42, 1]}
            }
          );

This is how I tried to do it, but it's not working, could someone explain me how to do it?

Hi @RodrigoMtz10, thank you for the comment.
The showEffectName method doesn't exist.
https://anseki.github.io/leader-line/#show-hide
I consider that this issue was already solved.


parameters

Hi, can you share all the parameters of the clinical finetuned model? thank you !

The parameters are shared in the clinical model download. Look in your
~/.cache directory.
Andriy
On Mon, Dec 30, 2019, 3:26 AM WinnaYuan<EMAIL_ADDRESS>wrote:

Hi, can you share all the parameters of the clinical finetuned model?
thank you !
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AndriyMulyar/semantic-text-similarity/issues/5?email_source=notifications&email_token=ADJ4TBXSLMBZTAKV4N6AZJ3Q3GWCZA5CNFSM4KBKFLTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDJUE6A,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJ4TBUVGH3RHABJAYPKCHLQ3GWCZANCNFSM4KBKFLTA
.

The parameters are shared in the clinical model download. Look in your ~/.cache directory. Andriy
…
On Mon, Dec 30, 2019, 3:26 AM WinnaYuan @.***> wrote: Hi, can you share all the parameters of the clinical finetuned model? thank you ! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=ADJ4TBXSLMBZTAKV4N6AZJ3Q3GWCZA5CNFSM4KBKFLTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDJUE6A>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJ4TBUVGH3RHABJAYPKCHLQ3GWCZANCNFSM4KBKFLTA .

thanks for your reply, I just saw these parameters which doesn't contain learning rate and epoch and others, or you use the default parameters? and another question,  where can I download the MED data? Thank you very much!
{
"attention_probs_dropout_prob": 0.1,
"hidden_act": "gelu",
"hidden_dropout_prob": 0.1,
"hidden_size": 768,
"initializer_range": 0.02,
"intermediate_size": 3072,
"max_position_embeddings": 512,
"num_attention_heads": 12,
"num_hidden_layers": 12,
"type_vocab_size": 2,
"vocab_size": 28996
}

I never got around to publishing the training parameters due to not having time to clean it up. The training parameters were identical to the pytorch transformers sentence pair CLS finetuning parameters.


Model Builder | Updates to environment and compute

Add information on compute priority
Preview Link (Compute Priority) - https://review.docs.microsoft.com/en-us/dotnet/machine-learning/resources/azure-training-concepts-model-builder?branch=pr-en-us-18731#what-is-an-azure-machine-learning-compute
AB#1725142

@beccamc can you take a look what you get a chance. Once you approve, I'll get someone from the team to approve. Thanks

@dotnet/docs this PR has been approved. Can I get an additional approval please. Thanks


Wrong orientation at starting time with Gear VR

Sometimes app starts in wrong orientation if I launch app with Gear VR (not in developer mode).
No problems with in developer mode (without GearVR) or running in Cardboard/Daydream mode.
I'm using GearVRf prebuilt .aar libraries (v3.1), Galaxy S6 edge, and Android 6.0.
My ViewManager is like this (nothing special):
class SampleViewManager extends GVRMain {

    @Override
    public void onInit(GVRContext gvrContext) {

        GVRScene scene = gvrContext.getMainScene();
        scene.getMainCameraRig().getLeftCamera().setBackgroundColor(Color.WHITE);
        scene.getMainCameraRig().getRightCamera().setBackgroundColor(Color.WHITE);

        GVRTexture texture = gvrContext.loadTexture("mylogo.png");
        GVRSceneObject sceneObject = new GVRSceneObject(gvrContext, 4.0f, 2.0f, texture);
        sceneObject.getTransform().setPosition(0.0f, 0.0f, -7.0f);

        scene.addSceneObject(sceneObject);
    }

    @Override
    public void onStep() {
    }
}

I didn't check with latest master branch sources.

I check with latest master sources. It was fixed.
Sorry.

@niusounds Hi. Actually this is not a known problem with 3.1. It would be nice if you could share logcat output with us. If possible please specify the device model number (Settings->About device->Model number). Thanks.


Slow ipfs add on storage host

https://github.com/ipfs/go-ipfs/pull/1324
https://github.com/ipfs/go-ipfs/issues/1616


Implement the altair spec

The altair spec, e.g. here: https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/beacon-chain.md
We will want to leverage as much of the phase 0 spec code as possible and this may require some care to make sure we can leverage multiple types etc. like an apply_block function that can take either spec's state, block types, or various functions that take a Context for each version of the spec

An overview of what's to be included:

custom types

[ ]  ParticipationFlags

constants

[ ]  TIMELY_SOURCE_FLAG_INDEX
[ ]  TIMELY_TARGET_FLAG_INDEX
[ ]  TIMELY_HEAD_FLAG_INDEX
[ ]  TIMELY_SOURCE_WEIGHT
[ ]  TIMELY_TARGET_WEIGHT
[ ]  TIMELY_HEAD_WEIGHT
[ ]  SYNC_REWARD_WEIGHT
[ ]  PROPOSER_WEIGHT
[ ]  WEIGHT_DENOMINATOR
[ ]  DOMAIN_SYNC_COMMITTEE
[ ]  DOMAIN_SYNC_COMMITTEE_SELECTION_PROOF
[ ]  DOMAIN_CONTRIBUTION_AND_PROOF
[ ]  PARTICIPATION_FLAG_WEIGHTS

preset

[ ]  INACTIVITY_PENALTY_QUOTIENT_ALTAIR
[ ]  MIN_SLASHING_PENALTY_QUOTIENT_ALTAIR
[ ]  PROPORTIONAL_SLASHING_MULTIPLIER_ALTAIR
[ ]  SYNC_COMMITTEE_SIZE
[ ]  EPOCHS_PER_SYNC_COMMITTEE_PERIOD

config

[ ]  INACTIVITY_SCORE_BIAS
[ ]  INACTIVITY_SCORE_RECOVERY_RATE

containers

[ ]  BeaconBlockBody → add sync_aggregate
[ ]  BeaconState

[ ]  add inactivity_scores, current_sync_committee, & next_sync_committee
[ ]  modify previous_epoch_participation & current_epoch_participation

[ ]  SyncAggregate
[ ]  SyncCommittee

helper fns

misc

[ ]  add_flag
[ ]  has_flag

Beacon state accessors

add

[ ]  get_next_sync_committee_indices
[ ]  get_next_sync_committee
[ ]  get_base_reward_per_increment
[ ]  get_unslashed_participating_indices
[ ]  get_attestation_participation_flag_indices
[ ]  get_flag_index_deltas

modify

[ ]  get_base_reward
[ ]  get_inactivity_penalty_deltas

Beacon state mutators

modify

[ ]  slash_validator

block processing

add

[ ]  process_sync_aggregate (added to process_block)

modify

[ ]  process_operations
[ ]  process_attestation
[ ]  process_deposit

epoch processing

add

[ ]  process_inactivity_updates
[ ]  process_participation_flag_updates
[ ]  process_sync_committee_updates

modify

[ ]  process_justification_and_finalization
[ ]  process_rewards_and_penalties
[ ]  process_slashings

initialize state (for testnets & test vectors)

modify

[ ]  initialize_beacon_state_from_eth1

I'll hold off on starting anything for now -- I'll need to make sure I'm aligned on how to structure these within the context of the overall project. For example, Lighthouse separates "phase 0" and "altair" into their own modules but puts them under epoch_processing, presets, etc....aka lower in the hierarchy.
At least in its current structure, it looks like this project aims to keep phase0 and altair entirely separated at the top level, similar to how Lodestar organizes their implementation. Thus:

The altair module should follow a similar layout as phase0 (configs, presets, state transition, etc.), import phase0 where needed, and then modify/add new features?
crypto, domains, and primitives are common types (as in, these are at the same level as altair and phase0 within src). If something needs to be added/modified here for Altair (e.g., adding ParticipationFlags to primitives.rs), should the change take place within the altair module or in the existing file under src?

i wanted to think about how to best implement both specs without having to duplicate all of the shared functionality.
lighthouse basically wraps each variant in an enum which is what is passed to each function.
each function can then match on the state to get the relevant information/data it needs....
we can for now go ahead w/ defining the new stuff, like an altair.BeaconState along w/ the new functionality that uses it fn process_sync_committee_updates(state: &mut altair.BeaconState, context: &Context) and i'll think about how best to unify everything

hing needs to be added/modified here for Altair (e.g., adding ParticipationFlags to primitives.rs), should the change take place within the altair module or in the existing file under src?

i'm fine putting the common stuff in the common places without separating by phase

note: will want custom serialization for the flags which are sent over the API as individual u8 encoded as decimal strings


Question about attention calculation

Upon reviewing the OANet paper, I noticed the equations for attention. However, when checking the code, it uses multi-head attention (MHA). Could you provide additional explanation on how MHA is implemented?

If you give the number of heads in a multi-head attention function class to one, the result is the same as a normal attention class. I wrote the code so that it would be easier to modify in case of further improvements to the model later.


smerge

Would it be possible to provide the standard smerge alias for SublimeMerge? It is described here.

A temporary workaround to this might be to use a manual snap alias. You can create one by running:
sudo snap alias sublime-merge smerge
Read more about commands and aliases here.

Any chances this can be provided out of the box without having to create an alias?

@rojosinalma Yes, though this requires acceptance through Snapcraft. I've opened a request for this alias here.

The smerge alias has been added in commit d0734f1.

The smerge alias has been added in commit d0734f1.


[WIP] Visualization plugin development (slides)

@shiltemann, would it be desired to add interactive environments too or would this be sufficient?

You explain that display HTML is not secure but it's sometime convenient.
Futhermore, you can now manage a whitelist directly within the admin panel: Manage Display Whitelist
My question is: do you plan to add somthing about generate HTML in a tool or do you want to exclude that in the Tool Integration slides?

Hi @lecorguille,

You explain that display HTML is not secure but it's sometime convenient.

I know this is now possible, but I still see this as a kind of hack, probably as result of the slow progression in the development of the visualization system supposed to do it. And in terms of security, static tool visualizations are essentially not less secure than the visualization plugins. However, they implementations of static visualization tools are unnecessarily redundant and the interface can not be subject to proper functional tests.
Please have a look at the discussion over here: https://github.com/galaxyproject/tools-iuc/pull/958
For those reasons I want to focus my talk on the visualization plugins and not the static tools used for visualization as I believe they are the way to do it.
The second half of the talk is up to my collegue @shiltemann, who I suspect is going to focus on interactive environments in combination with visualizations.

My question is: do you plan to add somthing about generate HTML in a tool or do you want to exclude that in the Tool Integration slides?

It is not in the planning, but you can always add to the slides of course!
Thanks :)
Youri

sorry for the slow replies, I am still on holiday for couple more days, but yes, think interactive environments would be nice to mention in the slides, but focus on regular viz for the hands-on part.

@yhoogstrate @shiltemann great work, can't wait for next week!
See you all there!


Add gradle support

The authentication details must be filled by the user in build.gradle.

Add a build.gradle file
Add Gradle wrappers

LGTM

We might update API E2E test applications related to this. https://github.com/konveyor/go-konveyor-tests/pull/127


Added undefined defaults in default.vcl.j2 template

Adapting this: http://docs.ansible.com/ansible/playbooks_filters.html#defaulting-undefined-variable

I think it's better to keep defaults in defaults/main.yml so they are more easy to find (instead of going through all the templates etc.)

All defaults need to be in defaults/main.yml but we should also add those fallback defaults to templates to avoid problems when those are not defined in project playbooks.

I think it's better to keep defaults in defaults/main.yml

Right now, they are. Or did you mean only in defaults? Only downside I can think here is that we need to maintain defaults in two places..

we should also add those fallback defaults to templates to avoid problems when those are not defined in project playbooks

I agree on this too especially on this case where in some projects we have varnish variable object set for the project, but missing these error_header* properties in that specific project configuration.

Both is better, but in defaults  is a must.
Also missing properties in dictionaries is no longer a problem (when they are in defaults) because of the hash_behaviour=merge default in ansible.cfg.


Support marking service dependencies for the jetty service.

This change makes it possible to address a long-standing shutdown issue—if a misk application has web action handlers that interact with a database, the misk service coordinator has no idea that the actions depend on the database transacter service being available. During shutdown, this can lead to the DB connection being closed while web actions are still in progress, triggering intermittent errors and risk of data loss.
Because the Jetty service is private to Misk, and the application DB is defined in the application, making the Jetty service aware of this dependency is convoluted. This PR makes it possible for the application to pass down a list of other services that the Jetty service should depend upon, which will enforce a consistent shutdown order.

Yep, this is long overdue. Thanks for doing this.


Adding Tair or VPDleaf to the required survey variable

Documentation reference (URL): https://github.com/ess-dive-community/essdive-leaf-gas-exchange/blob/main/docs/requiredVariables.md
Submitter:
Justification (why is this change necessary?):
The aim of survey gas exchange measurements is often to calibrate stomatal conductance models. See for example: Lamour et al. 2023 or Wu et al. 2020. VPDleaf is needed in many stomatal conductance models, including Medlyn et al. 2011 which is used in most vegetation models. With the current required variables, it is not possible to estimate the parameters of the Medlyn model.
*I suggest the following changes: I suggest to add VPDleaf to the required variables for the survey measurements. Or Tair so VPDleaf can be calculated using the other required variables.

Lamour, J., Souza, D.C., Gimenez, B.O., Higuchi, N., Chave, J., Chambers, J. et al. (2023) Wood-density has no effect on stomatal control of leaf-level water use efficiency in an Amazonian forest. Plant, Cell & Environment, 46, 3806–3821.
Wu J, Serbin SP, Ely KS, et al. The response of stomatal conductance to seasonal drought in tropical forests. Glob Change Biol. 2020; 26: 823–839.

Hi Julien,
Thanks for your suggestion. Do you think for simplicity it is worth adding both VPDleaf and Tair as required variables? Or if it were only one, which would be more useful?
We are in the process of updating this reporting format, including restructuring of the layout on GitHub to improve accessibility, and some alignment with ESS-DIVE standards. This change to required variables for Survey measurements can be made as part of that update.

Kim

Although, I just want to check that Tleaf is not enough to calculate VPDleaf. On the 6400 VPDleaf is calculated with Tleaf, not Tair. If that is the case, then the required variables of Tleaf, RH and Patm allow calculated of VPDleaf.

Hi Kim,
The leaf to air vapour pressure deficit needs Tair if it is calculated using RH, otherwise you need an estimate of the water pressure at the leaf surface.
I think Tair doesn't appear directly in the Licor calculation because they use the air vapor pressure using Patm and H2Os. Since H2Os is not a required variable, I think we always miss one variable to be able to calculate VPDleaf.
You can follow the calculations made with the licor but I dont think you ll be able to calculate VPDleaf with the "required variables". Tell me if I am wrong.
Cheers
Julien

Ah, yes, you are correct, H2OS is used in the LI-COR calculation. I was focused on the T part!
In thinking about which variable would be best to include, I see they have different "pros". Tair is measured directly by the instruments, rather than calculated, and may be used for other things. However VPDleaf can be used directly for the parameter estimates. Do you have any preference for one, or both? Thanks again for your input on this.

I will add both as required variables for survey. It's essentially no additional burden, and may allow more flexible uses in the future. I will keep this issue open until this is executed (I need to have some broader conversation with ESS-DIVE before releasing V2 as it has been on hold due to staff changes).


PSR-4

From documentation
In PHP, you can place code in any file, without a specific structure. In Zephir, every file must contain a class (and just one class). Every class must have a namespace, and the directory structure must match the names of the classes and namespaces used. (This is similar to PSR-4 autoloading conventions, except it’s enforced by the language itself.)

How about organize class autoload in config.json like composer.json ?
Composer can provide classes from any path:
    "autoload": {
        "psr-4": {
            "VendorName\\ProjectName": "lib"
        },

So why not do something like this:
{
    "extension-name": "my_ext_name",
    "namespace": "VendorName\\ProjectName",
    "[ext|base|extension|etc...]-path": "lib", // don't reserved paths(ext), optional param default use
namespace

     // OR like composer
     "extension-name": "my_ext_name",
     "autoload": {
          "VendorName\\ProjectName": "lib",
          "VendorName\\ProjectName2": "lib2" // https://github.com/phalcon/zephir/issues/1883
     }

Pretty project folder structure
my-lib:
    - ext
    - lib
        class.zep
    config.json

Exist project folder structure
my-lib:
    - ext
    - vendorname
        - projectname
            class.zep
    config.json

If you approve this, i can provide request for this issue in future

/cc @phalcon/zephir-team

I'd probably call the key namespace-paths instead of autoload, since we're not actually implementing an autoloader. But I like this approach:
{
     "extension-name": "my_ext_name",
     "namespace-paths": {
          "VendorName\\ProjectName": "lib",
          "VendorName\\ProjectName2": "lib2" // https://github.com/phalcon/zephir/issues/1883
     }
     ...
}

Any PR should, of course, add the namespace-paths key and logic, not replace the existing namespace key and logic. That probably means refactoring the existing logic to support either convention, but as long as both the new and old ways are supported simultaneously, that's perfectly fine.

I agree with @danhunsaker

Something like that ?
./vendor/bin/zephir init Mylib\\First lib
    "namespace": "",
    "namespace-paths": {
        "Mylib\\First\\": "lib"
    },
    "name": "mylib_first",

But which solution would be good for the name of the extension if there are several?
    "namespace": "",
    "namespace-paths": {
        "Mylib\\First\\": "lib",
        "Mylib\\Second\\": "lib2"
    },
    "name": "mylib_first",

in this case will be created two or one extension?

Always one extension, no matter how many namespaces.

Yep, but how about this issue #1883 ?
I thought that they wanted to make two extensions from one project

Also, if namespace-paths is used, namespace should not be.

I thought something like thaе for compatibilityt:
    private function checkDirectory()
    {
        $namespace = $this->config->get('namespace');
        $namespaces = $this->config->get('namespace-paths');
        if (empty($namespaces) && !empty($namespace)) {
            if (is_string($namespace) === false) {
                throw new Exception(
                    sprintf('Invalid namespace config param, expected string, got %s',
                        is_object($namespace) ? get_class($namespace) : gettype($namespace)
                    )
                );
            }
            $namespaces[$namespace] = $namespace;
        }

Ah. Missed that detail, somehow. In that case, I have a slightly different idea.
{
    "extensions": {
        "mylib_first": {
            "namespace": "Mylib\\First\\",
            "path": "lib"
        },
        "mylib_second": {
            "namespace": "Mylib\\Second\\",
            "path": "lib2"
        }
    },
    ...
}

And of course if extensions is used, name and namespace are not. Or maybe anything in extensions is used to override values in the root level of the structure? Allowing most/all settings available in the root to be overridden for any one extension, but otherwise apply to everything? Hard to think of a scenario where name and namespace wouldn't need to be unique across extensions...

Hard to think of a scenario where name and namespace wouldn't need to be unique across extensions...

Yep, but it is possible. The simple solution is refuse to using name and namespace on root level. Or we add path on root level too...
    "namespace": "Mylib\\First\\",
    "name": "mylib_first",
    "path": "lib",

    // if extensions not empty then root level was ignored

    "extensions": {
        "mylib_first": {
            "namespace": "Mylib\\First\\",
            "path": "lib"
        },
        "mylib_second": {
            "namespace": "Mylib\\Second\\",
            "path": "lib2"
        }
    },

I'd prefer not adding path to the root options; we can auto populate the value using the current logic internally, if we need to, but it shouldn't be configurable by the user at that level.

and what to do with the configuration of dependencies?
such as constants-sources, prototype-dir, extra-sources, requires and etc...
they may be different for extensions

What say we support all config options in extensions.* the same as we do at the root, except of course for the few that don't make sense nested (extensions itself, for example), and use the top-level versions as defaults that propagate down unless overridden? And then, just for the sake of conciseness, allow each extensions value to either be an object ({...}) or a string path to the additional config file for that extension ("lib-first/config.json").


Extend finding components to plugins and executables distributed by forc (#652)

When checking if a component is distributed by forc, we currently only look at forc's direct executables. This needs to be extended to resolve components, plugins, and executables.
This fixes a few issues found while investigating #665.

LCOV of commit 2abac56 during CI #2044
Summary coverage rate:
  lines......: 81.3% (2315 of 2846 lines)
  functions..: 44.0% (363 of 825 functions)
  branches...: 58.4% (277 of 474 branches)

Files changed coverage rate: n/a

perhaps we could consider adding 2 more tests here.

Nice!


This has been implemented in 765792bdf32a27312a82ec553b4db3a663f185c5.


Remove reclaim and preempt in deployment

What this PR does / why we need it:
Remove Reclaim and Preempt from deployment Conf
Which issue(s) this PR fixes
Fixes https://github.com/kubernetes-sigs/volcano/issues/770

/lgtm
/approve

/lgtm cancel

we also need to update the configuration in deployment; and we need a copy for CI.

Have made changes in deployment/volcano/config and the same is being is used by CI

We have reclaim/preemption test in CI; how can we pass those CI with depoloyments?

/lgtm
/approve


Understanding pipeline capabilities.

I'm working on a beta implementation of a DAG pipeline with wallaroo and I'm having a hard time understanding if my task is outside the scope of this project.
My problem:

TCP stream produces event A and B
Step 1 (parallel): A cpu intensive parallel parsing of A and B.
Step 2: combines stats A and B to produce state C (A+B=C)
Step 3: Partition state C into D/E/F
Step 4 (parallel): A cpu intensive parallel parsing of D, E, and F
Step 5: send event with state D/E/F to external service.

I'm understanding that wallaroo makes it very convenient to partition states for parallelism. But with regards to merging states, its not clear at all how to do this. If the partitioned state is not global, how can I reference both state A and B inside the same computational step (step 2 in my case)?
Thanks to the team @Wallaroo, it looks like a very promising project.

Hi @jerry-pca,
Thanks for your kind words.
Couple things I'm not clear on.
When you say TCP stream produces event A and B, is that two different types of events coming on over the same TCP channel or is it two different tcp connections, 1 for event A and one for event B?
another question that I know I will have later, how do you now that A should be added to B?
is there a key that they are being joined on?
perhaps you could give a contrived example that explains the flow and I might be able to better understand.

Thanks for the quick reply. Happy to provide more detail:

When you say TCP stream produces event A and B, is that two different types of events coming on over the same TCP channel or is it two different tcp connections, 1 for event A and one for event B?

Both events come over the same stream, but we could probably split them into multiple streams one day.

another question that I know I will have later, how do you now that A should be added to B?
is there a key that they are being joined on?

Yes, due to network jitter the events might come in out of order, so we have a simple window that holds a max of 3 latest events.  So an event order 99, 90, 110, 4, becomes 90, 99, 110 (we drop 4).

perhaps you could give a contrived example that explains the flow and I might be able to better understand.
To give more detail on the pipeline:

Unordered events of type A and B come in over a stream. We perform very cpu intensive parsing on every event so we want to parallelize this:
Event structure is:
A = {id:1, type:"A", body:"Hi do you sell a blue dress in small?"}
A2 = {id:2, type:"A", body:"I mean large?"}
B = {id:3, type:"B", body:"Hello, yes we sell a blue dress in size lg?"}
After parsing we sort and retain 3 latest events, and perform a cpu intensive scoring of the group
C = {score:100, events:[A1, A2, B]}
We split the event C into more parallel ops.

Although we think of our pipeline as a compute DAG but we can reshape it into a map/reduce task.
So then we have about 10 steps all pretty much alternating between parallel map ops (parse, score) and various reduce ops  (window of sorted last 3, group by score, group by dynamic id).
Would it make sense to chain multiple pipelines feeding data to each other? Like map pipeline -> reduce pipeline -> map pipeline -> reduce pipeline. Or would this introduce overhead that can be avoided by doing these ops inside one pipeline?

@jerry-pca  If I haven't understood your problem correctly, we'd love to jump on a short call and learn more about your use case.

@jerry-pca  If I haven't understood your problem correctly, we'd love to jump on a short call and learn more about your use case.

@SeanTAllen Yes, there is one window joiner after every parallel op for us. Its ok for us that "to_stateful" is not paralleled since its a relatively low overhead join. I think it wasn't clear at first glance how to config a pipeline that alternates between parallel ops and window joins. I think I've got all the pieces figured out so I'll try implementing and might follow up if I encounter any issues.
Thanks for clearing it up!
PS. Excited for python3 support!

Awesome @jerry-pca.


How to subscribe to the events from the client side so that periodic update will get notified to the client's callback function?

Sorry for the lack of reply. (Also, not sure you deleted your explanatory comment.)
For the sake of other people finding this question: simpleservice is already set up to send out notifications every second (interval=1): https://github.com/afflux/pysomeip/blob/b08a17260e934afa4c2f150023be690b25f9add9/tools/simpleservice.py#L21
The reason you are not seeing these is that you used tools/get.py, which is using the SOME/IP RPC, not the PubSub mechanism. You want tools/find-subscribe.py.


Allow building off a Git Tag

What App Center service does this feature apply to?
Build
Describe the solution you'd like
We use Gitflow as our branching strategy, and in Gitflow every release is tagged on the master branch. I would like to be able to build off those tags, rather than always building off the HEAD of the branch.
Describe alternatives you've considered
A workaround is creating a new branch off each tag you want a build config for and setting it up as a new build config in AppCenter, which is time consuming.
Additional context
We have multiple customers on different versions of our (white label) app, so being able to build different versions is a must for us.

Hi @talsemgeest, thanks for this feature request! I can see how this would help in your workflow. We'll keep this request open to track additional interest.

I came looking for app center support for tagged releases, so it's a +1 from here.

I'm also looking forward to seeing this feature in App Center. Being able to build multiple versions of an application from the same numbered GitHub tagged release in AppCenter would be a high-value feature.

Hi! we are a customer of app center and are in dire need of this feature! Any help would be appreciated

👍

this would be an amazing feature if we can get this!

+1

:+1: yes need this!

I really need this.

We need this!

This would be a nice addition

Please, add this!

+1

+1

any update on this one?

There is API support for building off a specific commit: https://openapi.appcenter.ms/#/build/builds_create
Would that work as a workaround?

+1000 Being able to go to an application, build and then being able to either build from:
a) branch
b) tag
c) commit hash
is mega important! At the moment we only have option a) whereas a lot of other CIs offer all three.

+1

+1 Not being able to build from a tag has been forcing us change our workflow

+1 for this feature. Thank you.

+1. Is this feature being worked on at all?

+1

@tindn, we post our iteration plan each month. This issue is not being worked on in this month's plan.

+1

how did this happen!

+1

+1

+1

+1

+1 the same with git flow.

👍

Another +1

+1

+1

+1

+1

yes please

another yes please

+1

+1

+1 more

For a specific use-case, I use lerna to version two react-native apps and would like to be able to build only on tags that match the format<EMAIL_ADDRESS>

+1

I would very much like to see this feature implemented as well.

+1

+1

this is my hacky workaround incase it helps others until this feature is implemented. for context my infra pushes tags on master, so there is also a corresponding commit message i.e. "master: v1.0.9" and the tag would be "v1.0.9" and we have a package.json with a corresponding "version": 1.0.9 in the root of the project
what i am doing is in my post-checkout script
PACKAGE_VERSION=$(cat package.json \
  | grep version \
  | head -1 \
  | awk -F: '{ print $2 }' \
  | sed 's/[",]//g' \
  | tr -d '[[:space:]]')

## if build filter and last commit doesnt contain filter cause failure
if [ "${BUILD_FILTER}" != "" ]; then
  if [ "$(git log -1 | grep -u $BUILD_FILTER)" == "" ]; then
      exit 1;
  else
      git checkout v${PACKAGE_VERSION};
  fi
fi

where BUILD_FILTER is a param provided to the appropriate release branch you would like to enforce a tag checkout, so in my case BUILD_FILTER="master: v"
An FYI though exit 1; only stops the majority of the build process, the rest of your custom build scripts still run, i am accounting for this in each build. The proper way to address is found here https://stackoverflow.com/questions/60329968/how-to-fail-a-appcenter-build-on-script-exit-code
Now this is far from perfect..... but itll do for now
hope it helps someone else :)
good luck!

+1

+1

+1

+1

I thought for sure AppCenter would have this by now. I too want to be able to trigger a Build only when the commit has a tag that matches a regex. While a post-clone script could be used to work around this limitation, it would mean nearly all commits would trigger a build that would fail, wasting hundreds of build minutes a month.

+1

+1

+1

+1

+1

+1

+1

+1

Any updates on this?

It's weird they cannot add such small and so desired feature 😕

waiting for 2 years for this feature.

are we there yet?

We absolutely need this! please make it happen :(

+1

+1

Hi there! Thanks for your interest in the feature! Please use reactions instead of +1.

🤘
Let's add some reactions with 👍 on the main message!!@!

Yeah, but we're using +1 to beat the evil @msftbot 🤖

+1

Hi there! Thanks for your interest in the feature! Please use reactions instead of +1.

3 years and this is still pending, many workflows depend on tag releases.

I made my own CI/CD with Circle CI
Because if it depends on this lib here, we die and it won't be done

I know numerous companies that have this within their CI/CD process. It's really surprising we can't get this with App center

+!

+1

Not stale

Glad to say I'm the 200th to be sad to chose Microsoft

Not stale. Still needed

+1

+1

+1

This is one of the most high impact features you could ask for.
This is almost a requirement if AppCenter wants to provide better build support for monorepos


ng serve not pushing changes to browser in Angular 10.1.0 with --project usage

🐞 Bug report
Command (mark with an x)

[ ] new
[ ] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

I believe that an angular 9.1.x version (not sure which) worked, but numerous changes have been made.
Description
When I run 'ng serve --project ' or 'ng serve --prod --project ' commands, the code is compiled but not pushed to the browser. The running code is the same code as prior to the build.
The same issue also occurs when I change code. After the code is changed, the 'ng serve' command detects the changes and recompiles but no changes are pushed to the browser.
To see if the error was transient, I have done the following with limited success:

forced a reload (ctrl-f5) of the web page (did not work)
restarted the browser (did not work)
toggled the 'Disable cache' option under the Network view in Devtools in case caching was issue(did not work)
Ran 'ng serve' from a newly created project that is not in a subdirectory (works)

Thus, it looks like the current revision of the tool does not work with projects structured in subdirectories, but without error output, it is hard to determine exactly what is happening.
🔬 Minimal Reproduction
I am unable to create a repo to reproduce as this is a fundamental tool issue. The tool does not indicate when it is pushing code or if it has encountered an error. The tool should indicate when it is pushing code or if encounters errors that prevent pushing the code.
🔥 Exception or Error
No error occurs, no output is generated.
🌍 Your Environment
Angular CLI: 10.1.0
Node: 10.13.0
OS: win32 x64
Angular: 10.1.0
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, language-service, localize
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes
Package                            Version
@angular-devkit/architect          0.1001.0
@angular-devkit/build-angular      0.1001.0
@angular-devkit/build-ng-packagr   0.1001.0
@angular-devkit/build-optimizer    0.1001.0
@angular-devkit/build-webpack      0.1001.0
@angular-devkit/core               10.1.0
@angular-devkit/schematics         10.1.0
@ngtools/webpack                   10.1.0
@schematics/angular                10.1.0
@schematics/update                 0.1001.0
ng-packagr                         10.1.0
rxjs                               6.6.3
typescript                         4.0.2
webpack                            4.44.1
Anything else relevant?
No

Hi @lonerzzz,
Thanks for reporting this issue, however without a reproduction it's hard to tell what is happening, which errors are not reported, if it's an OS specific issue etc...
Also, does this happen for all type of changes?, IE when modifying a .css,.html and .ts file.
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

I understand that the problem is hard to reproduce. However, the real issue here is not the need for a reproduction, the issue is that the ng tool is not describing what it is doing to even check for deltas in operation between two scenarios. I cannot provide my entire setup and I would have to spend many more hours of trial and error to create a repo that has the exact characteristics that cause the failure .That is not really viable.
Is there no end user visible debug mode for the tool to provide details of what it is doing? If not, one should be added for situations like this. I tried running with --build-event-log and all that it contained was the following with each entry in the log arising from a change made to a file in my code repo proving only that change detection was happening:
{"id":{"started":{}},"started":{"command":"serve","start_time_millis":1599667857078}}
{"id":{"finished":{}},"finished":{"finish_time_millis":1599667887943,"exit_code":{"code":0}}}
{"id":{"started":{}},"started":{"command":"serve","start_time_millis":1599667923843}}
{"id":{"finished":{}},"finished":{"finish_time_millis":1599667923844,"exit_code":{"code":0}}}
I saw that people have requested a debug node for the ng tool previously (https://github.com/angular/angular-cli/issues/5030).
I also confirmed that changes to any .css, .html or .ts file resulted in builds being performed but no changes being pushed to the browser.

Hi @loganmzz, under the hood Angular CLI uses Webpack, while there is a way to print debugging information the logs are very limiting because most of Webpack's plugins don't use this logger infrastructure.
I have created a PR to print more verbose output when running ng serve --verbose. https://github.com/angular/angular-cli/pull/18749,, that said, I doubt that you will find any extra logs useful in the issue you are experiencing.

@alan-agius4 Thanks for the PR. I launched 'ng serve' with the node debugger and in the webpack configuration enabled 'trace' level output. I agree that the logging is sparse even in trace mode, but it pointed me in the direction of some areas to investigate. Even some logging is often more helpful than none. I continue to investigate.

@lonerzzz, if you need any assistance let me know.

@lonerzzz, is there anything that we can take action related to this issue? Thanks.

I'm sorry, but we can't reproduce the problem following the instructions you provided.
Remember that we have a large number of issues to resolve, and have only a limited amount of time to reproduce your issue.
Short, explicit instructions make it much more likely we'll be able to reproduce the problem so we can fix it.
If the problem persists, please open a new issue following our submission guidelines.
A good way to make a minimal repro is to create a new app via ng new repro-app and add the minimum possible code to show the problem. Then you can push this repository to github and link it here.


Add agentchat_oai_assistant_groupchat.ipynb

Why are these changes needed?
Add agentchat_oai_assistant_groupchat.ipynb

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report

Merging #656 (67c43a3) into main (6d621a9) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   28.70%   28.49%   -0.21%
==========================================
  Files          27       27
  Lines        3383     3383
  Branches      760      760
==========================================
- Hits          971      964       -7
- Misses       2341     2347       +6
- Partials       71       72       +1

Flag
Coverage Δ

unittests
28.49% <ø> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


setup jest with first basic jest tests

setup jest for https://github.com/Yes-Theory-Fam/yesbot-ts/issues/235
add first tests

https://github.com/Yes-Theory-Fam/yesbot-ts/issues/235

After the additions from #231, the tests don't run anymore since jest cannot resolve type-graphql anymore. I just published<EMAIL_ADDRESS>that allows direct referencing of the client through the import @yes-theory-fam/database/client. Replacing all @yes-theory-fam/database imports with that makes jest run as expected.

The test never terminates and appears to hang infinitely, not sure about the cause here
I'm trying to find a solution for that. But currently I dont find where the DiscordjsError: Request to use token, but token was unavailable to the client. is thrown, because the test is successful. But I will look further into this.

did a new PR for the new structure (https://github.com/Yes-Theory-Fam/yesbot-ts/pull/278) so this will be closed.


Testing: CollectionGroup features

The GroupCollection and GroupCollectionUser models are used to enable use of the WHG place collection feature in classroom and workshop scenarios. The workflows from group_leader and user perspective are below. The most critical elements that need testing are (some actions are not yet coded):

[ ] add members via csv upload
[ ] submission to group adds to group_leader list
[ ] notification to user collection page, "received"
[ ] email to editor upon nomination to gallery
[ ] group_leader email message to members

The CollectionGroup workflow
** failed

if user in group_leaders

create CollectionGroup
fields :: title, description, type (class, workshop), keywords, start, due date,
gallery? (class gallery), gallery required? (all accepted work goes to class gallery),
file, links
post save

add members from a csv file: email, name
** - if existing, add; if new, create user and add
add links
add pdf course/workshop description
TODO: email to added students

post collection-submitted

appears on Submitted Collections list (#coll_list)
option to

view (navigate to its view page)
nominate it for a site Student Gallery

user member of a CollectionGroup

create PlaceCollection
:: title, description, keywords
post save -> build screen

add image, pdf essay, up to 3 links
add data from datasets
option to submit to a CollectionGroup user belongs to

add data from Place Portals and dataset browse screens
annotate places

note, image, timespan, sequence
TODO: needs display parameter(s) incl. temporal control [sequence, timespans, no order]; ant trails?

submit collection to group

(appears in leader's list)
** - withdraw by selecting none -> needs cancel

CollectionGroups and related functionality all in place for v3


Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper

This fixes #335

I fixed the comment and now RemoteGcsHelper uses default auth credentials.
This should not be merged until we fix default auth credentials NPE.

#344 is now merged in, which fixes the default auth credentials NPE

I realized now that using default authentication credentials causes signUrl method to fail (see here) and consequently also signUrl IT tests fail.
We can manually pass a ServiceAccountAuthCredentials to signUrl but that is the same as explicitly creating ServiceAccountAuthCredentials from the env variables in RemoteGcsHelper.
I suggest that we do not use default lookup in RemoteGcsHelper unless you know a way to workaround the signUrl problem

I realized now that using default authentication credentials causes signUrl method to fail (see here) and consequently also signUrl IT tests fail.

We could also support it when GoogleCredentials is instanceof ServiceAccountCredentials. There are various ways we could deal with it.

In 82ebc71 I fixed the comment and:

Added a method to convert ApplicationDefaultCredentials to ServiceAccountAuthCredentials if GoogleCredentials object is an instance of ServiceAccountCredentials
Add type check and conversion to Storage.signUrl to work with ApplicationDefaultCredentials

Great! Looks good to me. Any reason you still have the "don't merge" label?

I just forgot to remove :)


Add requirements that tie together Server SoC requirements and BRS behavior listed as optional

Good example is existing issue #2

So it's unclear #2 is a good example and that we really need anything to tie things together. We've debated this pattern before with the BRS and decided that requirements that point to other requirements in other specs is silly.
Perhaps downgrade this to non-normative text?


unable to create template from Root Volume Disk

ISSUE TYPE

Bug Report

COMPONENT NAME

Management-server-component

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

Template
OS / ENVIRONMENT

RHEL 9, VMWare
SUMMARY

I just created template from windows 10 root volume and it's working fine but when i create from Linux it's not working and show like below screenshot. Can anyone suggest me.
STEPS TO REPRODUCE

EXPECTED RESULTS

A

CTUAL RESULTS

@thorzinaung please share the complete management server log

@kiranchavala hi, here is the mgmt server log
management-server.zip

@thorzinaung please check if the vm has any iso attached,
Please detach the iso and then try to create a template from volume again

@kiranchavala
I am curious why create template fails when vm has attached ISO . is it a bug ?
cc @DaanHoogland

@weizhouapache @DaanHoogland the error is coming from vcenter , the create template from volume will fail if there is a iso attached
https://pricklytech.wordpress.com/2021/02/13/vmware-vsphere-deploy-ovf-errorvim-fault-filenotfound/


allow php8

i'm going to create a series of pr all over related packages to https://github.com/contentful/contentful-laravel
prs:

https://github.com/contentful/contentful-core.php/pull/44
https://github.com/contentful/contentful-laravel/pull/40
https://github.com/contentful/rich-text.php/pull/56
https://github.com/contentful/contentful.php/pull/296

Hi @marvinosswald ,
I've put the features into their own PR (#47) for review by Contentful and to add the CI integration etc. 3.1.0 should release any moment; the other libraries will follow soon. Thank you for contributing, though!


Lock row never removed causing failures

Which version and edition of Flyway are you using?
7.4.0 Community
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Haven't tried
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using? (Type & version)
CockroachDB 20.2.6
Which operating system are you using?
Amazon Linux
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
I have situation that is similar to #2932.
I see logs that say:
Waiting for lock on Flyway schema history table. Application may be deadlocked. Lock row may require manual removal from the schema history table.
In my schema table it looks like:
select * from flyway_schema_history;
  installed_rank |             version              | description  | type |         script         | checksum  |   installed_by    |           installed_on           | execution_time | success
-----------------+----------------------------------+--------------+------+------------------------+-----------+-------------------+----------------------------------+----------------+----------
            -100 | 5f995812f7cf53c59ba74f742898730a | flyway-lock  |      |                        |         0 |                   | 2021-03-25 21:07:22.840323+00:00 |              0 |  true
               1 | 1.0                              | create-table | SQL  | V1.0__create-table.sql | 588152650 | serv_int_svc_user | 2021-03-25 00:01:25.349565+00:00 |           7154 |  true
(2 rows)

I had to manually delete the flyway-lock row to make that error go away. Based on reading the referenced issue, it seems that the process that sets up the lock will delete it after the 10 minute timeout for Cockroachdb. However, if that process got killed, wouldn't that leave that row around causing this issue to happen at any time?
What did you expect to see?
Maybe at startup if the time is longer than the timeout, it should delete the row lock and proceed with migration?
What did you see instead?
Stuck indefinitely.

Flyway already deletes locks older than the timeout
If you run Flyway with debug level logging, you should see messages from a task running every 5 minutes indicating that the lock's timer is being updated. In this case it means your application hasn't fully shut down
If not, then you probably have entered a deadlock state and deleting the lock manually as per the message is the correct way to go as Flyway can't reasonably detect every user's case, unless you are able to provide a reproduction for this?
That being said, we will consider switching from Timer to Executor as it is generally considered better


Fixes overridden status of dosomething_campaign_run and dosomething_fact_page features

Synchronizes DoSomething Features codebase with production.

The only Feature left is overridden dosomething_search, but it requires individual change. I'd recommend first to update the Solr module.

:+1:


the documented ready pjax:end does not work with Jquery 3.4.1 or 2.2.4

The documented code does not work as mentioned
$(document).on('ready pjax:end', function(event) {
  $(event.target).initializeMyPlugin()
})

The above code does not call the initializeMyPlugin() on the first page load with jquery 3.4.1 or jquery-2.2.4,
i am using the following piece of of code
function loader(){
        $('.page-loader-wrapper').fadeOut();

        //assign respective values to the associated hidden fields
        $("#rco,#dco").on('click',function(e){
            var buttonId = $(this).attr('id');
            $("#"+buttonId+"_input").val(1);
        });
    }

    $(document).on("pjax:beforeSend",function(e){
        $('.page-loader-wrapper').fadeIn();
    }).on("ready pjax:end",function(){
        loader();
    });

and the loader() function is never called on the first page load, only called on pjax:end . i am using this code in Yii2 framework and the output is like below
</script><script src="/assets/9f3f0907/jquery.js"></script>
<script src="/assets/b6f73355/yii.js"></script>
<script src="/assets/b6f73355/yii.gridView.js"></script>
<script src="/assets/e0e575b7/jquery.pjax.js"></script>
<script src="/assets/27eba27c/js/bootstrap.js"></script>
<script>jQuery(function ($) {

    function loader(){
        $('.page-loader-wrapper').fadeOut();

        //assign respective values to the associated hidden fields
        $("#rco,#dco").on('click',function(e){
            var buttonId = $(this).attr('id');
            $("#"+buttonId+"_input").val(1);
        });
    }
    $(document).on("pjax:beforeSend",function(e){
        $('.page-loader-wrapper').fadeIn();
    }).on("pjax:end",function(){
        loader();
    });
jQuery('#w0').yiiGridView('setSelectionColumn', {"name":"selection[]","class":null,"multiple":true,"checkAll":"selection_all"});
jQuery('#w0').yiiGridView({"filterUrl":"\/site\/test","filterSelector":"#w0-filters input, #w0-filters select","filterOnFocusOut":true});
jQuery(document).pjax("#pjax-container a", {"push":true,"replace":false,"timeout":10000,"scrollTo":false,"container":"#pjax-container"});
jQuery(document).on("submit", "#pjax-container form[data-pjax]", function (event) {jQuery.pjax.submit(event, {"push":true,"replace":false,"timeout":10000,"scrollTo":false,"container":"#pjax-container"});});
     setTimeout(function () {
        $('.page-loader-wrapper').fadeOut();
    }, 50);
});</script></body>
</html>

Hi there,
You can try using the jQuery Migrate Plugin to add in support for any missing jQuery methods or properties that were removed as jQuery was developed into newer versions.
In my case, I was receiving errors regarding event.props being undefined.
jQuery Migrate Plugin

@drewminns  i aint getting any errors on console i dont think jquery migrate could work in this situation other than the one you pointed out you were facing

Just dealt with this myself - $(document).on('ready') was deprecated in jQuery 3.0, and even before that, the handler wouldn't run anyway if the DOM is ready before the event is attached: discussed in the documentation here: https://api.jquery.com/ready/ under the list of ways to attach a function that will run when the DOM is ready. (Deprecation note here: https://jquery.com/upgrade-guide/3.0/#breaking-change-on-quot-ready-quot-fn-removed)
I wound up doing something like this:
handler = function() { ... }
$( handler )
$(document).on('pjax:end', handler)

I went to file a PR to the README here, but realized the ready event handler has never received any arguments (as shown in the jquery pjax README), so I'm not sure what event.target in the documentation refers to in the case of the ready event firing.

Just dealt with this myself - $(document).on('ready') was deprecated in jQuery 3.0, and even before that, the handler wouldn't run anyway if the DOM is ready before the event is attached: discussed in the documentation here: https://api.jquery.com/ready/ under the list of ways to attach a function that will run when the DOM is ready. (Deprecation note here: https://jquery.com/upgrade-guide/3.0/#breaking-change-on-quot-ready-quot-fn-removed)
I wound up doing something like this:
handler = function() { ... }
$( handler )
$(document).on('pjax:end', handler)

I went to file a PR to the README here, but realized the ready event handler has never received any arguments (as shown in the jquery pjax README), so I'm not sure what event.target in the documentation refers to in the case of the ready event firing.

Could you explain a little more on this with your fix.  I wasn't sure how to implement what your fix

I found this to be the easiest option
$(document).on('pjax:end', function(event) {
    // my code here
}).trigger('pjax:end');

basically triggers the events attached to pjax:end

I found this to be the easiest option
$(document).on('pjax:end', function(event) {
    // my code here
}).trigger('pjax:end');

basically triggers the events attached to pjax:end

Thank you thank you thank you <3


Add: ObinsKit.ObinsKit version 1.1.6

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

In my case it happens all the time that the YamlCreate script writes the first of several installers twice in the installer file. I always have to remove one of them.

Whaaaat? I've submitted 20+ PR's today and none have created a duplicate installer o_O

I will send you some screenshots if it happens again. It is really weird because it only happens sometimes. I haven't figured out under which circumstances this occurs...

The only thing i can think of is a lagspike at the perfect time, but i'm not even sure if that can cause it lmao, every time you finish a Installer Metadata part it adds it to the Installs variable (right after you select UpgradeBehavior), it also adds the metadata line by line...
At the end of the script it also just adds the $Installers variable (not for each installer), so there is no way it duplicated there..


TestHalfFloat crashed with NoSuchElementException

With current master branch:
Enter float to convert or 'x' to exit:
Exception in thread "main" java.util.NoSuchElementException: No line found
	at java.util.Scanner.nextLine(Scanner.java:1540)
	at jme3test.math.TestHalfFloat.main(TestHalfFloat.java:43)

Probably not much what we can do there when Netbeans Input Wrapper is odd,
maybe Netbeans 11 fixes things


Update uBar to 3.1.1

Thank you for the contribution. It was merged directly as dfaee1ec95a0ce263a29d65981a96b08b57e1c2d to keep commit history cleaner. Your contribution is still credited to you.


could not introspect binary

go version :  go1.23.0 darwin/arm64
> go-global-update --dry-run
could not introspect binary actionlint: could not get latest version of github.com/rhysd/actionlint: exit status 1
could not introspect binary air: could not get latest version of github.com/air-verse/air: exit status 1
could not introspect binary asmfmt: could not get latest version of github.com/klauspost/asmfmt: exit status 1
could not introspect binary dlv: could not get latest version of github.com/go-delve/delve: exit status 1
could not introspect binary errcheck: could not get latest version of github.com/kisielk/errcheck: exit status 1
could not introspect binary fillstruct: could not get latest version of github.com/davidrjenni/reftools: exit status 1
could not introspect binary go-global-update: could not get latest version of github.com/Gelio/go-global-update: exit status 1
could not introspect binary go-outline: could not get latest version of github.com/ramya-rao-a/go-outline: exit status 1
could not introspect binary godef: could not get latest version of github.com/rogpeppe/godef: exit status 1
could not introspect binary goimportcycle: could not get latest version of github.com/samlitowitz/goimportcycle: exit status 1
could not introspect binary goimports: could not get latest version of golang.org/x/tools: exit status 1
could not introspect binary golangci-lint: could not get latest version of github.com/golangci/golangci-lint: exit status 1
could not introspect binary golint: could not get latest version of golang.org/x/lint: exit status 1
could not introspect binary gomodifytags: could not get latest version of github.com/fatih/gomodifytags: exit status 1
could not introspect binary gopls: could not get latest version of golang.org/x/tools/gopls: exit status 1
could not introspect binary gorename: could not get latest version of golang.org/x/tools: exit status 1
could not introspect binary gotags: could not get latest version of github.com/jstemmer/gotags: exit status 1
could not introspect binary gotestdox: could not get latest version of github.com/bitfield/gotestdox: exit status 1
could not introspect binary guru: could not get latest version of golang.org/x/tools: exit status 1
could not introspect binary iferr: could not get latest version of github.com/koron/iferr: exit status 1
could not introspect binary impl: could not get latest version of github.com/josharian/impl: exit status 1
could not introspect binary keyify: could not get latest version of honnef.co/go/tools: exit status 1
could not introspect binary ko: could not get latest version of github.com/google/ko: exit status 1
could not introspect binary motion: could not get latest version of github.com/fatih/motion: exit status 1
could not introspect binary revive: could not get latest version of github.com/mgechev/revive: exit status 1
could not introspect binary scc: could not get latest version of github.com/boyter/scc/v3: exit status 1
could not introspect binary staticcheck: could not get latest version of honnef.co/go/tools: exit status 1
could not introspect binary swag: could not get latest version of github.com/swaggo/swag: exit status 1
could not introspect binary task: could not get latest version of github.com/go-task/task/v3: exit status 1
could not introspect binary tomlv: could not get latest version of github.com/BurntSushi/toml: exit status 1

go is installed via brew
❯ brew config
HOMEBREW_VERSION: 4.3.16
ORIGIN: https://github.com/Homebrew/brew
HEAD: f930795c36aea910a39866a131374b4b237cdc58
Last commit: 24 hours ago
Core tap JSON: 17 Aug 07:26 UTC
Core cask tap JSON: 17 Aug 07:26 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.zmmZ5WqiYz/org.xquartz:0
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 3.3.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/bin/ruby
CPU: 10-core 64-bit arm_blizzard_avalanche
Clang: 15.0.0 build 1500
Git: 2.46.0 => /opt/homebrew/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 14.6.1-arm64
CLT: <IP_ADDRESS>.1.1708646388
Xcode: 15.4
Rosetta 2: false

Hey there, thanks for the bug report!
I cannot reproduce it locally - running go-global-update --dry-run works for me.
Could you help me discover the root problem of this error?
I would appreciate it if you ran the following command and told me the output:
go list -m -f "{{.Version}}" github.com/BurntSushi/toml@latest

For me, it prints v1.4.0, which seems to be correct given https://github.com/BurntSushi/toml/releases

same
> go list -m -f "{{.Version}}" github.com/BurntSushi/toml@latest
v1.4.0

That's awkward. The logs in the initial message say that this command failed previously when ran by go-global-update.

could not introspect binary tomlv: could not get latest version of github.com/BurntSushi/toml: exit status 1

Does the problem still persist when you run go-global-update --dry-run? If you still see the same errors (exit status 1), then please run go list -m -f "{{.Version}}" github.com/BurntSushi/toml@latest again, and then echo ?! to also capture the last exit code so we can see if it was 1 (as when run inside go-global-update) or 0.

❯ go-global-update --dry-run
could not introspect binary actionlint: could not get latest version of github.com/rhysd/actionlint: exit status 1
could not introspect binary air: could not get latest version of github.com/air-verse/air: exit status 1
could not introspect binary asmfmt: could not get latest version of github.com/klauspost/asmfmt: exit status 1
could not introspect binary dlv: could not get latest version of github.com/go-delve/delve: exit status 1
could not introspect binary errcheck: could not get latest version of github.com/kisielk/errcheck: exit status 1
could not introspect binary fillstruct: could not get latest version of github.com/davidrjenni/reftools: exit status 1
could not introspect binary go-global-update: could not get latest version of github.com/Gelio/go-global-update: exit status 1
could not introspect binary go-outline: could not get latest version of github.com/ramya-rao-a/go-outline: exit status 1
could not introspect binary godef: could not get latest version of github.com/rogpeppe/godef: exit status 1
could not introspect binary goimportcycle: could not get latest version of github.com/samlitowitz/goimportcycle: exit status 1
could not introspect binary goimports: could not get latest version of golang.org/x/tools: exit status 1
could not introspect binary golangci-lint: could not get latest version of github.com/golangci/golangci-lint: exit status 1
could not introspect binary golint: could not get latest version of golang.org/x/lint: exit status 1
could not introspect binary gomodifytags: could not get latest version of github.com/fatih/gomodifytags: exit status 1
could not introspect binary gopls: could not get latest version of golang.org/x/tools/gopls: exit status 1
could not introspect binary gorename: could not get latest version of golang.org/x/tools: exit status 1
could not introspect binary gotags: could not get latest version of github.com/jstemmer/gotags: exit status 1
could not introspect binary gotestdox: could not get latest version of github.com/bitfield/gotestdox: exit status 1
could not introspect binary guru: could not get latest version of golang.org/x/tools: exit status 1
could not introspect binary iferr: could not get latest version of github.com/koron/iferr: exit status 1
could not introspect binary impl: could not get latest version of github.com/josharian/impl: exit status 1
could not introspect binary keyify: could not get latest version of honnef.co/go/tools: exit status 1
could not introspect binary ko: could not get latest version of github.com/google/ko: exit status 1
could not introspect binary motion: could not get latest version of github.com/fatih/motion: exit status 1
could not introspect binary revive: could not get latest version of github.com/mgechev/revive: exit status 1
could not introspect binary scc: could not get latest version of github.com/boyter/scc/v3: exit status 1
could not introspect binary staticcheck: could not get latest version of honnef.co/go/tools: exit status 1
could not introspect binary swag: could not get latest version of github.com/swaggo/swag: exit status 1
could not introspect binary task: could not get latest version of github.com/go-task/task/v3: exit status 1
could not introspect binary tomlv: could not get latest version of github.com/BurntSushi/toml: exit status 1
Binary      Current version      Status
ais         (devel)              cannot upgrade
❯ go list -m -f "{{.Version}}" github.com/BurntSushi/toml@latest
v1.4.0
❯ echo ?!
zsh: no matches found: ?!
❯ echo $!
82420
❯ echo $!
82420
❯ echo $?
0

ignore ais one

Looks like I made a mistake. It should have been echo $? directly after go list -m -f "{{.Version}}" github.com/BurntSushi/toml@latest to report the status code of that go list command. Could you rerun that again?
Also, can you include the output of go version?

> go list -m -f "{{.Version}}" github.com/BurntSushi/toml@latest echo $?
go: list -m cannot be used with GO111MODULE=off

i tried go env -w GO111MODULE=auto but same error , it is set to auto
❯ go env | grep "GO111MODULE"
GO111MODULE='auto'

oh it's go list , ran it inside a package using that toml lib
❯ go list -m -f "{{.Version}}" github.com/BurntSushi/toml@latest
v1.4.0
❯ echo $?
0

Thanks for that information. That's really weird, since if you run the command yourself, it works just fine, but when go-global-update runs the same command, it fails with exit code 1 😕
I am using the same go version myself and I don't have any problems with this tool.
Can you run go-global-update --dry-run --debug and paste the output?
It will be large, so you can do that with just a single binary, like go-global-update --dry-run --debug actionlint

xyz
❯ go-global-update --dry-run --debug actionlint
2024-08-22T19:55:14.818+0530    DEBUG   gocli/cmd_runner.go:28  go command output       {"args": ["env", "GOBIN"], "output": "/Users/xyz/go/bin\n"}
2024-08-22T19:55:14.818+0530    DEBUG   updater/updater.go:46   found GOBIN path        {"GOBIN": "/Users/xyz/go/bin"}
2024-08-22T19:55:14.829+0530    DEBUG   gocli/cmd_runner.go:28  go command output       {"args": ["version", "-m", "/Users/xyz/go/bin/actionlint"], "output": "/Users/xyz/go/bin/actionlint: go1.22.5\n\tpath\tgithub.com/rhysd/actionlint/cmd/actionlint\n\tmod\tgithub.com/rhysd/actionlint\tv1.7.1\th1:WJaDzyT1StBWVKGSsZPYnbV0HF9Y9/vD6KFdZQL42qE=\n\tdep\tgithub.com/fatih/color\tv1.17.0\th1:GlRw1BRJxkpqUCBKzKOw098ed57fEsKeNjpTe3cSjK4=\n\tdep\tgithub.com/mattn/go-colorable\tv0.1.13\th1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA=\n\tdep\tgithub.com/mattn/go-isatty\tv0.0.20\th1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY=\n\tdep\tgithub.com/mattn/go-runewidth\tv0.0.15\th1:UNAjwbU9l54TA3KzvqLGxwWjHmMgBUVhBiTjelZgg3U=\n\tdep\tgithub.com/rivo/uniseg\tv0.4.7\th1:WUdvkW8uEhrYfLC4ZzdpI2ztxP1I582+49Oc5Mq64VQ=\n\tdep\tgithub.com/robfig/cron/v3\tv3.0.1\th1:WdRxkvbJztn8LMz/QEvLN5sBU+xKpSqwwUO1Pjr4qDs=\n\tdep\tgolang.org/x/sync\tv0.7.0\th1:YsImfSBoP9QPYL0xyKJPq0gcaJdG3rInoqxTWbfQu9M=\n\tdep\tgolang.org/x/sys\tv0.20.0\th1:Od9JTbYCk261bKm4M/mw7AklTlFYIa0bIp9BgSm1S8Y=\n\tdep\tgopkg.in/yaml.v3\tv3.0.1\th1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=\n\tbuild\t-buildmode=exe\n\tbuild\t-compiler=gc\n\tbuild\tDefaultGODEBUG=httplaxcontentlength=1,httpmuxgo121=1,netedns0=0,panicnil=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1\n\tbuild\tCGO_ENABLED=1\n\tbuild\tCGO_CFLAGS=\n\tbuild\tCGO_CPPFLAGS=\n\tbuild\tCGO_CXXFLAGS=\n\tbuild\tCGO_LDFLAGS=\n\tbuild\tGOARCH=arm64\n\tbuild\tGOOS=darwin\n"}
2024-08-22T19:55:14.835+0530    DEBUG   gocli/cmd_runner.go:28  go command output       {"args": ["list", "-m", "-f", "{{.Version}}", "github.com/rhysd/actionlint@latest"], "output": "go: list -m cannot be used with GO111MODULE=off\n", "error": "exit status 1"}
could not introspect binary actionlint: could not get latest version of github.com/rhysd/actionlint: exit status 1
Binary      Current version      Status

2024-08-22T19:55:14.835+0530    DEBUG   gocli/cmd_runner.go:28  go command output       {"args": ["list", "-m", "-f", "{{.Version}}", "github.com/rhysd/actionlint@latest"], "output": "go: list -m cannot be used with GO111MODULE=off\n", "error": "exit status 1"}

"output": "go: list -m cannot be used with GO111MODULE=off\n", "error": "exit status 1"

Looks like this is the culprit. I have no clue why there is GO111MODULE=off for you. I presume this is something related to your system configuration. You also mentioned similar problems in https://github.com/Gelio/go-global-update/issues/27#issuecomment-2303947877 and then solved it in https://github.com/Gelio/go-global-update/issues/27#issuecomment-2303955097.
I don't know how I can help further

i tried  :  go env -w GO111MODULE=on and it worked . it won't work with GO111MODULE=auto (https://go.dev/ref/mod#mod-commands)

Thanks for sharing the fix, I appreciate it 👍


Migrations with custom provider don't work properly if Migrations are instances of classes, implementing Migration interface.

If the migrator is created with the custom MigrationProvider, that delivers a record of class instances, the migration fails.
This interface is suited for defining a list of migrations as services to be injected as list into custom migration provider:
export interface XchangeMigration extends Migration {
  readonly name: string;
}

Custom migration provider injects a list of in IoC container registered custom migrations:
@injectable()
export class XchangeMigrationProvider implements MigrationProvider {
  constructor(@multiInject(MIGRATION) private readonly migrations: XchangeMigration[]) {}
  async getMigrations(): Promise<Record<string, Migration>> {
    const migrations = this.migrations.reduce(
      (prev, curr) => {
        prev[curr.key] = curr;
        return prev;
      },
      {} as Record<string, Migration>
    );
    return migrations;
  }
}

Custom migration service injects custom migration provider and starts migration:
@injectable()
export class XchangeMigrationService {
  constructor(
    @inject(DB) private readonly db: DB,
    private readonly migrationProvider: XchangeMigrationProvider
  ) {}

  async migrateUp() {
    await this.createMigrator().migrateToLatest();
  }

  private createMigrator(): Migrator {
    return new Migrator({
      db: this.db,
      provider: this.migrationProvider,
    });
  }
}

Custom migration implements extended Kysely Migration interface and defines "up" method.
@injectable()
export class InitialMigration implements XchangeMigration {
  name = '2024-06-01T12:00:00.initial.migration';

  async up(db: Kysely<unknown>): Promise<void> {
    await db.schema
      .createTable('releaseGroup')
      .addColumn('id', 'serial', (builder) => builder.notNull())
      .addColumn('name', 'varchar(75)', (builder) => builder.notNull())
      .addColumn('description', 'varchar(200)')
      .addColumn('artifactType', 'varchar(50)', (builder) => builder.notNull())
      .addColumn('artifactName', 'varchar(50)', (builder) => builder.notNull())
      .addColumn('owners', sql`varchar[]`, (builder) => builder.notNull())
      .addColumn('createdAt', 'timestamp', (builder) => builder.notNull())
      .addColumn('createdBy', 'varchar(50)', (builder) => builder.notNull())
      .addColumn('modifiedAt', 'timestamp')
      .addColumn('modifiedBy', 'varchar(50)')
      .addPrimaryKeyConstraint('release_group_pk', ['id'])
      .addUniqueConstraint('release_group_name_uq', ['name'])
      .execute();
  }
}

When a migration is called it fails with an exception:
TypeError: migration.up is not a function
    at #migrateUp (/Users/romansmushkevich/Dev/xchange/node_modules/kysely/dist/cjs/migration/migrator.js:479:33)
    at run (/Users/romansmushkevich/Dev/xchange/node_modules/kysely/dist/cjs/migration/migrator.js:352:49)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /Users/romansmushkevich/Dev/xchange/node_modules/kysely/dist/cjs/kysely.js:418:32
    at async DefaultConnectionProvider.provideConnection (/Users/romansmushkevich/Dev/xchange/node_modules/kysely/dist/cjs/driver/default-connection-provider.js:12:20)
    at async #migrate (/Users/romansmushkevich/Dev/xchange/node_modules/kysely/dist/cjs/migration/migrator.js:199:20)
    at async XchangeMigrationService.migrateUp (/Users/romansmushkevich/Dev/xchange/packages/xchange-backend/dist/index.cjs:1227:9)
    at async XchangeStartupService.startup (/Users/romansmushkevich/Dev/xchange/packages/xchange-backend/dist/index.cjs:1512:9)
    at async eval (webpack-internal:///./src/platform/index.ts:56:51)

I suppose, that the problem is in a spread operator, that is used in method
#resolveMigrations. Unfortunately it doesn't copy the up method of instance of Migration class.

Don't. Keep it simple.


Add PSP support to fake event generator

Fixes #128
Signed-off-by: Christian Zunker<EMAIL_ADDRESS>What type of PR is this?
/kind bug
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
The enabled the fake generator deployment in a PSP enabled cluster.
Which issue(s) this PR fixes:
Fixes #128
Special notes for your reviewer:
Checklist

[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] CHANGELOG.md updated

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign bencer
You can assign the PR to them by writing /assign @bencer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

falco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

falco/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 305e14e2add42d8581cab42358ab20883cef6836


feat: allow changing fader levels from -Infinity dB

Adding dB values to -Infinity dB resulted in no change. This was fixed by assuming -100 dB as the minimum value for calculation.

originally reported by @Fred-DTV – thanks!


[Finishes #164829196 setup heroku pipeline

What does this PR do?
adds necessary configuration for deployment on Heroku
Description of task to be completed
Deploy base application to heroku using heroku pipelines
How can this be manually tested?
Visit app url using HTTP client

ensure application is deploying,
you can use $ heroku logs --tail

@ValerieRono , the application deploys successfully. We just need to implement the JWTAuthentication
This is the error that you will get when you try accessing the endpoints
NotImplementedError at /api/users .authenticate() must be overridden.

ensure application is deploying,
you can use $ heroku logs --tail

@ValerieRono , the application deploys successfully. We just need to implement the JWTAuthentication
This is the error that you will get when you try accessing the endpoints
NotImplementedError at /api/users .authenticate() must be overridden.

okay well noted


add NoOp command in repl

add NoOp command in repl and avoid escaping in regex where possible

@djspiewak I was busy with repl code & remembered your feature (or rather revision) request :)


Enable overriding diagnostic symbols and highlights

As per https://github.com/nvim-neo-tree/neo-tree.nvim/commit/245457a9d1074b190793add27629cc37fc2974c7.

Closed as of #20.