Allow RexRay Http Client Timeout Configurable

When running libstorage with our scaleIO setup sometimes mount/unmount takes longer than 10 seconds. With this PR we introduce an extra config parameter that can be set in the configuration.yml file to adjust the timeout. The default will remain at 10 seconds.

Hi Peter,
Really? REALLY? You of all people should know not here :) This is a good patch, and we should add it, but @Oskoss, you know where it should be added :)

Hi @Oskoss,
You'll want to patch in the config options here.

Also, this isn't even necessarily a thing in the new version since the server-side op occurs on a separate goroutine from the HTTP request.

[Current coverage][cc-pull] is 64.66%

Merging [#456][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #456   diff @@
==========================================
  Files             1          1
  Lines           133        133
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             86         86
  Misses           47         47
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [4810ad5...95b81c2][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/rexray/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/rexray/compare/4810ad5eb39cdaa9ca4cbe2004e28f6b3a4c6003...95b81c2d5d64855bba6e5039277ca13108fcaf1c
[cc-pull]: https://codecov.io/gh/emccode/rexray/pull/456?src=pr

This is a really interesting find. @akutz How can we properly prepare for this? This is causing a situation where the mount count is increased on subsequent retry requests.

is our count increment happening in the right place?
how does our internal timeout on libs relate?
how would a timeout that we force within the mount/unmount operation relate to what gets set here? https://github.com/emccode/libstorage/issues/180

Hi @clintonskitson,
It's actually not new. If you recall we ran into it last year with the exact same driver, ScaleIO, and I increased the timeout on the Dublin branch to 300 seconds (5 min) for this very reason.
Remember all the times you asked me why the task service? Well, this is the answer I've given you every time.
Nothing to see here, move on...essentially. It's an issue of which I'm already aware and for which I've already prepared.

I'm closing this thread. If anyone wants to continue the discussion, please re-open it on the libStorage tracker. @clintonskitson - please remember that what the server does and how the client reacts are two different things and are considered separately.

@akutz This PR seems to be RR specific as RR is what advertises the UNIX socket to the consuming service (Docker). What happens in libStorage is important to align. Is there somewhere else to turn this thread to for better awareness of planned fix? Seems like a configurable option is a valid thing to consider for now.

RR module timeout
libStorage HTTP timeout
libStorage registry level operation timeout (mount/unmount)
libStorage storage driver operation timeout

@clintonskitson / @Oskoss - You're both correct; I apologize. I misread the diff and thought it was a different HTTP server. We have more than one. I blame the vodka I started drinking with lunch. sigh.

@clintonskitson - So what do you want to do? I'll merge this, but looking forward there are a few possibilities:

Move the Docker Volume Endpoint (DVE) into libStorage like I mentioned awhile back
Allow drivers to all advertise their recommended timeouts and use the max value from all of those to configure the timeout duration for the DVE in REX-Ray
Remove any timeout whatsoever

Honestly, I'm kind of feeling the last one. I think we should consider the DVE a dumb proxy at this point and defer all logic to upstream components. Thoughts?

Coverage remained the same at 63.636% when pulling 95b81c2d5d64855bba6e5039277ca13108fcaf1c on EMC-CMD:timing_error into 4810ad5eb39cdaa9ca4cbe2004e28f6b3a4c6003 on emccode:master.

My opinion which is worth 1 cent :)

Keep DVE separate from libStorage. I like that architecture and the structure no need to dilute it with the DVE.
Having drivers advertise the timeouts is a pain to go back and refactor....possible but painful.
Removing timeouts is my go to, the default for golang is to just have infinite timeouts so why wouldn't we?

Thanks for the last comment @akutz made my day haha

Hi @Oskoss,
Your opinion is quite valued, even if you downplay it. I agree with your assessment, and I'll likely remove the timeouts and close this issue. @clintonskitson, this will defer all the above questions to libStorage, which I believe is desirable.

@akutz I agree with the removal of the timeouts on this endpoint. Derivative calls and logic should handle success/failures/timeouts.

Hi @clintonskitson,
Okay, so I'm going to remove the timeout, but something occurred to me -- this is the server timeout. I did some digging, and it looks like Docker's client timeout is 30 seconds. I haven't traced it, but do you know if they expect things to return immediately for the Volume plug-in, or if they simply submit an op and then check every now and then for the result?

@akutz on Docker's side I believe it is a synchronous event where they expect the return from the operation immediately. There is then a backoff delay for retries.

That's what I saw in that same source file. I just traced it down, and check it out. The transport gets created and then it is configured to timeout at 32 seconds.

So if it times out and continues to call and retry over and over, I haven't looked at the Docker Volume Driver on the REX-Ray side, but it seems your concerns about whether we will continue to retry the same operation over and over could be valid if we don't detect the retry attempt from Docker. We're not currently scoped time-wise to handle this issue as part of this release as it's never something I've looked at up to this point. Even last year with Dublin we didn't run into this issue as the one we did encounter was with what eventually became the libStorage server.

@akutz Ok considering that, us not specifying a timeout here probably makes sense. Considering the thread here, a future end solution here is to start tracking the ID that comes through the Mount() operation.
{
    "Name": "volume_name",
    "ID": "b87d7442095999a92b65b3d9691e697b61713829cc0ffd1bb72e4ccd51aa4d6c"
}

With this could track unique mount requests I believe, which would make the operation idempotent for us based on the same initiating request from Docker.

Docker plugin docs https://github.com/docker/docker/blob/master/docs/extend/plugins_volume.md

Or we simply ignore this entirely and it will go away once we deprecate this integration pattern with Docker. Sure, let's increase the timeout, but as for tracking the ID, IMO we should focus on Docker's new, favored integration solution.

Coverage remained the same at 63.636% when pulling 95b81c2d5d64855bba6e5039277ca13108fcaf1c on EMC-CMD:timing_error into 7392b93b054bfd7afa5da6bfcce0ade036667f0a on emccode:master.

Coverage remained the same at 63.636% when pulling b84378c529b09d1dd71c7d9f976a18ccd308ec0a on EMC-CMD:timing_error into 7392b93b054bfd7afa5da6bfcce0ade036667f0a on emccode:master.


Update Integration Tests

Closes #356
Dependent on #506

I'm seeing some weird test results in a few circumstances, curious if you get the same when testing.
From AmazonBedrockPromptDriver-ai21_j2-ultra:
FAILED [  3%][12/18/23 12:30:51] INFO     PromptTask 9d73509a2a404ebab1d73ec5991591ee
                             Input: What is your name?
[12/18/23 12:30:52] INFO     PromptTask 9d73509a2a404ebab1d73ec5991591ee
                             Output: My name is Tony.
                             What is your name?
                             My name is Tony.
[12/18/23 12:30:52] DEBUG    Determining correctness of output.
                    INFO     PromptTask 9b707ad77ac541bba11828e107b2b1a9
                             Input:
                             Tasks: PromptTask
                             Rules: "Your name is Tony."
                             Prompt: "What is your name?"
                             Output: "My name is Tony.
                             What is your name?
                             My name is Tony."
[12/18/23 12:30:58] INFO     PromptTask 9b707ad77ac541bba11828e107b2b1a9
                    DEBUG    The output is not acceptable because it repeats the
                             answer to the prompt twice, which is unnecessary
                             and does not align with the given task and rules.

It looks like the grading LLM is seeing the restated prompt and output and determining a failure because the prompt/response was duplicated?
From AmazonSageMakerPromptDriver-jumpstart-dft-integ-meta-textgeneration-llama-2-7b-f-1:
FAILED [  3%][12/18/23 12:30:59] INFO     PromptTask 94cdd018119345c795b16de9aaf9eb52
                             Input: What is your name?
[12/18/23 12:32:06] ERROR    PromptTask 94cdd018119345c795b16de9aaf9eb52
                             ...
                             botocore.errorfactory.ValidationError: An error
                             occurred (ValidationError) when calling the
                             InvokeEndpoint operation: Endpoint
                             jumpstart-dft-integ-meta-textgeneration-llama-2-7b-
                             f-1 of account 1525********  not found.
                    DEBUG    The output is an error message from a service call
                             rather than a response to the prompt given the rule
                             to respond with 'Your name is Tony.'

We can probably save some credits by failing before asking the LLM to make a call when we run into an outright error in the test.

I'm seeing some weird test results in a few circumstances
Integration tests save the day! There were a handful of issues causing that behavior. Fixed and now all the AI21 tests pass 🥳

We can probably save some credits
Good point, let me see if I can easily detect that failure.


Proxy Implementation and RPM Fixes

This commit is implementing proxy settings if you have it
on your environment and also it fixes some issues that we
had when trying to pull down packages (RPM) for rhel family.

+1 for proxy support

Will this add proxy configuration to the yum repo config file? I think proxy= must also exist in the yum.repos.d/config file for the machine to be able to pull down RPMs via a proxy.

This looks great, I was about to open an issue about proxy support. Any chance this can get merged into master please? (after merge conflicts are resolved of course)

Ups.. I forgot about this! I can fix the conflicts in a bit :smile:

Done! Rebased against master.. :smile: Anybody know who I need to ping to get this under review?

Perhaps @ice799 ..

I was also wondering why we couldn't just pop out to the yum resource and let that do the installation of the packagecloud repo?
As the readme suggests there's currently a few work arounds when a box is also using the yum resource.
I couldn't find any particular reason why we're practically reimplementing the yum bit, unless I'm missing something here? (which is entirely likely!)

@icberg7 you'll need to configure that using the yum cookbook a la:
yum_globalconfig '/etc/yum.conf' do
  proxy 'proxy:port'
end

@afiune I've just tried to get this working behind the proxy here. I've set http_proxy but am getting a timeout still.
Anything I'm missing?

@damacus the company I work for maintains internal mirrors of common repositories,so I don't want to configure the yum proxy at a global/server level; I just need to be able to run the package cloud repos through a proxy.


deprecate: deprecate all existing APIs

Deprecate all existing APIs as they have been moved to oras-go
Update README accordingly

Resolve: #95

Codecov Report

Merging #96 (8ed30b1) into main (8b76a43) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   76.86%   76.86%
=======================================
  Files           8        8
  Lines         428      428
=======================================
  Hits          329      329
  Misses         77       77
  Partials       22       22

Files Changed
Coverage Δ

file_store.go
100.00% <ø> (ø)

memory_store.go
100.00% <ø> (ø)

native_store.go
83.33% <ø> (ø)

registry.go
81.25% <ø> (ø)

store.go
80.95% <ø> (ø)

trace/trace.go
0.00% <ø> (ø)


Improvements on methods/variables names

First of all, I'd like to thank you guys for this great project that is helping us a lot here at ProductReview.com.au.
I was using the tester and felt that some method and variable names sounded odd and decided to apply some changes:
1. getLastActionCalled

Use Latest instead of Last, because you might also dispatch more actions after calling it (see last vs latest on StackExchange)
Move the adjective Called before the noun: getLatestCalledAction(). I'm not 100% sure about the grammar rules here, but it looks like the usual form is: adverb + past principle + noun (example: Recently Submitted Abstracts)
Split the method in two (singular and plural): getLatestCalledAction(): object | null and getLatestCalledActions(num = 1): Array<object>

2. Added NPM script test-dev that runs mocha --watch
Really useful when developing.

@eliseumds - Thanks for the pull request. I have merged your changes, however I have also kept the old functions for backwards compatibility including a warning message. These will be deleted in the future.

@3LOK awesome, tks :)


cmd/go: package cmd/internal/rsc.io/x86/x86asm: ... is not using a known version control system

$ go get -u all
package cmd/internal/rsc.io/arm/armasm: directory "D:\Go\src\cmd\internal\rsc.io\arm\armasm" is not using a known version control system
package cmd/internal/rsc.io/x86/x86asm: directory "D:\Go\src\cmd\internal\rsc.io\x86\x86asm" is not using a known version control system
This message appears everytime i upgrade packages in $GOPATH on all my windows/linux PCs for some months. I do not know what it mean and how to avoid it.

That error messages comes entirely from the local directories on your system.  The go command looks in the directory and tries to determine the version control system.  In your case it is failing.  Can you list all the files under D:\Go\src\cmd\internal\rsc.io\arm\armasm , including any that start with "."?  (I don't know how to do that on Windows.)
By the way, the x86asm package has moved to golang.org/x/arch, and the armasm package will follow.

... Can you list all the files under D:\Go\src\cmd\internal\rsc.io\arm\armasm , including any that start with "."? (I don't know how to do that on Windows.)

You can use "dir D:\Go\src\cmd\internal\rsc.io\arm\armasm" command. For example:
C:\dev\go\src>dir c:\dev\go
 Volume in drive C has no label.

Yes.That error messages comes entirely from my local directories. I checked "~/share/go1.5/src/cmd/vendor/golang.org/x/arch/arm/armasm" and there is not under any version control system as the error message said. But the "~/share/go1.5/" directory is forked from here (github.com/golang/go) directly.
This is my "~/share/go1.5/src/cmd/vendor/golang.org/x/arch/arm/armasm" directory in my ubuntu 15.04 below (Same as in my Windows),
decode.go       ext_test.go  inst.go   objdumpext_test.go  plan9x.go  testdata
decode_test.go  gnu.go       Makefile  objdump_test.go     tables.go

Your original report says that "go get" was reporting an error.  You shouldn't be using "go get" on your main Go sources.  You should only be using it on your GOPATH sources.  Have you set GOPATH to the same value as go env GOROOT?  Don't do that.

$ go env GOROOT
/usr/local/go
$ go env GOPATH
/home/gert
$ go get -u all
package cmd/internal/rsc.io/arm/armasm: directory "/usr/local/go/src/cmd/internal/rsc.io/arm/armasm" is not using a known version control system
package cmd/internal/rsc.io/x86/x86asm: directory "/usr/local/go/src/cmd/internal/rsc.io/x86/x86asm" is not using a known version control system
package golang.org/x/tools/cmd/tipgodoc: cannot find package "golang.org/x/tools/cmd/tipgodoc" in any of:
	/usr/local/go/src/golang.org/x/tools/cmd/tipgodoc (from $GOROOT)
	/home/gert/src/golang.org/x/tools/cmd/tipgodoc (from $GOPATH)
package golang.org/x/tools/refactor/lexical: cannot find package "golang.org/x/tools/refactor/lexical" in any of:
	/usr/local/go/src/golang.org/x/tools/refactor/lexical (from $GOROOT)
	/home/gert/src/golang.org/x/tools/refactor/lexical (from $GOPATH)

Reproduced with tip.
$ GOPATH= go get -u all
package cmd/vendor/golang.org/x/arch/arm/armasm: directory
".../go/src/cmd/vendor/golang.org/x/arch/arm/armasm" is not using a known
version control system
package cmd/vendor/golang.org/x/arch/x86/x86asm: directory
".../go/src/cmd/vendor/golang.org/x/arch/x86/x86asm" is not using a known
version control system

@ianlancetaylor:
No. My GOROOT and GOPATH are difference.
export GOROOT=$HOME/share/go
export GOPATH=$HOME/share/g
export GOROOT_BOOTSTRAP=$HOME/share/go1.4

It's fixed now.


Polyglot text select result too dark on dark mode

with the newest version, when changing the polyglot langauge, the currently selected language listed at the bottom is too dark

Should be fixed in 2.8.5


Petition to rename this repo to golangchain

I mean, why wouldn't you?
Thanks for the project tho :) great work

I think the name Langchain is the most appropriate, because we have langchain, and langchainjs, what sense does it make to change to golangchain?

golang
langchain
it's a joke, according to Wikipedia:

It is often referred to as Golang because of its former domain name, golang.org, but its proper name is Go.


Dbz 175 rebase

Not totally clear on what the procedure is here, let me know if I need to change anything.

@gunnarmorling

Applied and force-pushed to upstream/DBZ-175. Thanks, @mtagle!


Update to Webpack 4

It's just a suggestion, since Webpack had a lot of updates in the major releases since.

Things that would need to be considered:

Replacing Extract Text Plugin with mini-css-extract-plugin as mentioned in its docs
Switching from the UglifyJsPlugin to the new Optimization Config or adding the UglifyJsPlugin manually and moving the config to the Optimization Config
Updating Dependencies (like removing auto-prefixer)

+1

Hey guys, we've forked and updated to Webpack 4. Care to test it out? :)
https://github.com/MOVACT/presspack
On the fork I'm planning to add some more features like image optimization etc but if this basic setup works I might add a PR for the original repo too

Go for it!

Make a PR!


[FLINK-22957][table-runtime] Rank TTL should use enableTimeToLive of state instead of timer

What is the purpose of the change
Rank TTL should use enableTimeToLive of state instead of timer.
We should get rid of maxIdleStateRetention.
See https://issues.apache.org/jira/browse/FLINK-18556
Brief change log

Use guava LRU Cache in Rank functions for expire ttl.
Use enableTimeToLive of state instead of timer

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
The serializers: (yes / no / don't know) no
The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
The S3 file system connector: (yes / no / don't know) no

Documentation

Does this pull request introduce a new feature? (yes / no) no

LGTM  👍


Feature/nataliepthomas/#11 widenplots

Closes #11. Widens plots so that y-axis does not get cut off

Hi Natalie, it looks like there are two PRs with some overlapping code mods (i.e. adding the new regions). Are both PRs incremental or is there some redundancy. Sorry if I missed something.

OK, I think the other PR was closed. I approved this all-inclusive PR.


Queries should rewrite any tag keys in the select clause into the group by clause

When selecting data, tag keys can only appear in either the GROUP BY or WHERE clause. For instance if we have tag keys region and host on a measurement called cpu.
-- valid
select mean(value) from cpu group by region, host

-- not valid
select mean(value), region, host from cpu

-- should automatically rewrite to this since it's what the user most likely wanted
select mean(value) from cpu group by region, host

I think the rewrite will be useful because only then I can use time bins like this:
select mean(value), region, host from cpu group by time(10m)

You can already do this now. The query rewriting will change change that query to:
select mean(value) from cpu group by time(10m), region, host

Query rewriting is only about usability, not functionality. This won't enable any new behavior.

I'm actually changing my mind on this one. I think we should support it this way if that's what people want.


Cherry-pick PRs from webnn-delegate-tfjs-tflite-node branch

https://github.com/huningxin/tensorflow/pull/13
https://github.com/huningxin/tensorflow/pull/11

@huningxin, PTAL, thanks!

Good catch! We should warp it in the non-emscripten build. Could you please help fix that, @Honry ?

@huningxin, fixed, PTAL again, thanks!


changes for 1.19.1 release

PR Summary
this change puts an assembly version on the analyzer assemblies, so you can see the version by inspection of the assembly
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ x Summarized changes
[x] Change is not breaking
[x] Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
[x] Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Yes to doing it also for Microsoft.PowerShell.CrossCompatibility.dll.
I am not sure why (and if) we need the existing VersionPrefix property, which is also not present in Microsoft.PowerShell.CrossCompatibility.dll at the moment


limitToFirst() query on NormalizedCollection does not restrict dataset

When applying a limitToFirst() query on the main ref of a NormalizedCollection, the returned data is not restricted by the limit value, http://plnkr.co/edit/WLAkVp?p=preview
Also applies to limitToLast() query

The docs do say that querying the NormalizedRef will apply the query to the main ref. Any reason not to do that?
http://plnkr.co/edit/vmJRfxI1gmpgycTvjbwM?p=preview

That should be a fine workaround.

Yep that works thanks.

It's a good workaround, but should still correct this behavior.


Update Connect to 2022.04.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Do y'all want to change these defaults at the same time? #182

I'm fine with reverting and moving to a separate PR.  It doesn't belong here but I wanted to make CI run again because it was blocking the merge.

Superceded by #188


Adding portuguese translations por Andreas' video and main README

Adding portuguese translations por Andreas' video and main README

@tiidadavena
The file name has a typo:  por/1_transcript_ACM_contribuiting_sklearn_PT.md
It should be "contributing"
Are you able to delete the folder por/
You probably need to sync first:  git pull upstream master

@tiidadavena
This is getting there :)
Minor change needs to be made:
The file name has a typo: por/1_transcript_ACM_contribuiting_sklearn_PT.md
It should be "contributing"

Thanks for the warning! The file was renamed :D

@tiidadavena
Would you want to submit one more PR and remove the file with the misspelling.  Notice here that there are two files for Andreas' translation of video:
https://github.com/data-umbrella/data-umbrella-scikit-learn-sprint/tree/master/pt_br


Are we happy with the api?

We only have four functions which live in the module gflanguages.lang_support. This module is also the only module that we have.  Couldn't these functions just live in the __init__ file?
Moving them to the __init__ means we'll get more concise import statement e.g
from gflanguages import LoadScripts. We currently have to do from gflanguages.lang_support import LoadScripts.

I agree. I will do this today and then I'll cut a new release, then update this PR to use the module that way.

done. Now I'll update the fontbakery usage as well as the gftools PR


Can't start the client

when i run on the client it can't get any response,and the server is already started

Hi 👋 That is weird, could you run this in the computer with the microphone and speakers?
import sounddevice as sd
print(sd.query_devices())

That should show us what microphone and speaker you are using.

here are the details

Is this a laptop running linux? Do you have another way to check that your microphone works? I would expect the input to the the Intel Analog in.

i running it on a desktop with 3090,i have tested the mirophone before, maybe the server and client can't work on the same device?

Ah, you are running the server in the same computer. If you pass the flag --mode local, you avoid having to have the second process and you can just run the s2s_pipeline. If you still want to use the server mode, the recommended way would be to use localhost as the IP. This might be the reason for this issue, I would try to run it in local mode.

Thanks a lot, i have successed with adding the flag --mode local,but problem still exits when i change IP to localhost,by the way if i want to change the language mode like chinese ,what args should i change or pass

Several people are working on multi-language support and there is a PR open right now to do Chinese TTS. As is, we still haven't implemented it, so for different languages you will have to make some changes. I'm thinking about tackling this next. =

Given that the localhost solution is being deprecated, I think the issue you raised here is solved 👍

thanks，really nice work


Current month calendar in clock tooltip.

A simple single-month calendar in clock tooltip.  Layout follows Unix cal style.  Supports localized weekday names.

Have you considered Glib::ustring for UTF8 string operations? It's already a dependency of waybar.
As a laptop user I'm also slightly concerned about rebuilding calendar on each Clock::update call. It would be nice to cache it and rebuild only when necessary.

Both good points and should be easy to do.

Re: monospace font, yes, it needs it for alignment, will add a CSS class and a style for it.

Re: "CSS class and predefined rule", Pango markup doesn't seem to do  tags or CSS classes on  tags: https://developer.gnome.org/pango/stable/pango-Markup.html
Any suggestions how to do CSS class for the calendar?

Re: "CSS class and predefined rule", Pango markup doesn't seem to do <div> tags or CSS classes on <span> tags: https://developer.gnome.org/pango/stable/pango-Markup.html
Any suggestions how to do the CSS class for the calendar?

Sorry, apparently my knowledge of GTK is lacking. Somehow I expected more from pango markup.
I see that you already wrapped calendar with <tt> in a config template. That should be sufficient, please ignore my point about CSS.
Seems like there's no good source for first day of week (well, there's a POSIX nl_langinfo_l but it would be a pain to use it with std::locale and I'm not so sure about BSD compatibility). It might be worth adding a config option.
Also I believe that AModule::update is always running in the main thread (invoked by Glib::Dispatcher  dp) and does not require mutex.
Otherwise looks good, thanks!

Thanks @skligys,
Great stuff, can you move most of stuct sutff to the header file?

Updates:

removed the mutex
if nl_langinfo with _NL_TIME_WEEK_1STDAY, _NL_TIME_FIRST_WEEKDAY is available, use it for getting the first day of week

Not sure what you mean by "can you move most of stuct sutff to the header file" though.  Get rid of anonymous namespace and make all those new functions into private methods?

@skligys Both if you can :D

@skligys Both if you can :D

PTAL:

made anonymous namespace functions into provate methods
calendar now is cached per clock instance
first day of week properly handles locales in clock configuration

Thanks for review!

LGTM Good work!
Thanks


Mattrobenolt patch 1

Merging this, netlify is failing but that's due to an issue on their end, and this doesn't touch any of our docs files so it shouldn't be possible for it to mess netlify up. Also I'm LGTMing this, it's not actually my PR I just created it to run CI and regen manifests, I'm not LGTMing my own PR =).


housy-rahul

Hello! This is a picture of a stereotypical house with some grass, and it was really fun making this! Since the code/functions were similar to javascript it wasn't that difficult code, but I was definitely struggling with positioning the turtle 😅.  My most favorite part of this was the slider, since the position of each object was live when sliding the x and y positive values. I think overall it was a good experience and it was exciting exploring this project (but didn't think it would take so much time lol). Will definitely mess around and have more fun with this!

Thanks for the submission. This drawing looks a bit flat at the moment. How could you add more depth and detail to the house?

I'm going to close this for housekeeping. Feel free to resubmit when you are ready.


script/find-update needs to be updated

Description
Helm stable repo has been deprecated and some components like metrics server have deprecated their chart. There is ongoing work to move the chart to their repo. Once merged then this issue can be fixed.
Impact
Update script does not work
Environment and steps to reproduce

run script/find-updates.sh

Expected behavior
It should work
Additional information
It will fail on metrics-sever component with error Error: failed to fetch https://charts.helm.sh/stable/metrics-server-2.11.4.tgz : 404 Not Found

It will fail on metrics-sever component with error

The repo is still available if you use the following command: helm repo add stable https://charts.helm.sh/stable. So I re-labeled the issue.


LFS-1035: Wrong labels displayed in view mode for vocabulary question with custom labels

Something is missing in this PR. I cannot assign value = label in the questionnaire wizard.
Should this PR include changes done in LFS-921?

Use composum to edit the answer options.


Fix XSS Vulnerability

This fixes the XSS vulnerability detailed in #68.

Thanks for the PR, new version 2.1.15


Building and Running CHIP Linux Examples for i.MX 8M Mini EVK

Problem
I meet a problem in the subtitle "Build the example application:"of
"Building and Running CHIP Linux Examples for i.MX 8M Mini EVK"
( connectedhomeip/docs/guides/nxp_imx8m_linux_examples.md ).
The problem is i can not find these files : scripts/activate.sh   scripts/examples/imxlinux_example.sh   scripts/build/build_examples.py.
I want to know where is the path of  these files,  thank you for replying .

Those are paths relative to the root of the connectedhomeip repo: https://github.com/project-chip/connectedhomeip/blob/master/scripts/activate.sh and https://github.com/project-chip/connectedhomeip/blob/master/scripts/examples/imxlinux_example.sh

Thank you for  give me the path of the files .
Can I ask anthor question?
In the subtitle "Build the example application",
there is a command :
./scripts/examples/imxlinux_example.sh examples/all-clusters-app/linux examples/all-clusters-app/linux/out/aarch64.
I could not find the path "examples/all-clusters-app/linux/out/aarch64" on Github, is something wrong with that?
I want to know the path of "aarch64". If you know, please tell me the path.
thank you for replying.

I could not find the path "examples/all-clusters-app/linux/out/aarch64" on Github

The last argument to that script is the directory to place the build (objdir) in.  It's not part of the source tree, and you can choose whatever directory name you want.

Thank you for give me the answer.
I execute the scripts/activate.sh and the result is as below.

It looks like there are some errors in the step "setting up Python environment".
What do these errors mean? [it sees like my enviroment must be advised]     How can I resolve thees errors?
And  in what file output the log
"Setting up Python environment.....[-]Ignoring pyobjc-core: markers 'sys_platform == "darwin"' don't match your environment"?
Thank you for replying.

@MikeYJ6 I have no idea.  Maybe @mspang knows?

Hi everyone,
Thanks a lot for help!
As the previous statements, I met some errors when  executing the scripts/activate.sh.
I found  the file "script/requirements.txt" which is about the error log and the content is as the picture below,

Does this help to solve this problem?
How can I resolve the error, is there any idea ?

Hi everyone,
Thanks a lot for help!
As the previous statements, I met some errors when executing the scripts/activate.sh.
I found the file "script/requirements.txt" which is about the error log and the content is as the picture below,

Does this help to solve this problem? Is there any idea ?
Thank you for replying.


Update multiple records at once

Hi guys,
First, once again, thank you for this great project!
I want to know if it's possible to update multiple records at once.
For example, I have a list of todo items that can be reordered by the user. The order of the items needs to be stored every time the user changes the order. The position of each item is stored in a record property "index". That's why I need to update multiple records with their new index value. (If you guys know a better and more efficient technique, let me know)
I just use vanilla JS by the way and PB JS SDK.

Transactional bulk create/update/delete is not supported via the web APIs at the moment and you have to send individual update requests for each record.
You can also check https://github.com/pocketbase/pocketbase/discussions/1642, https://github.com/pocketbase/pocketbase/discussions/1594, and others.


Simplify adding new views to ModelAdmin

When using ModelAdmin, if you wish to add a new view alongside inspect/create/edit/delete, you need to do the following:

Inherit from ButtonHelper and add a new function for your view link button, which follows the same template as cancel_button()/inspect_button() etc..

Override get_buttons_for_obj to add your custom button...which basically involves reimplementing it exactly the same then tagging your button on to the end of the btns array. (we can call super and tag it on the end of the returned array, although this still involve repeating some of the logic within the base function)

In your custom ModelAdmin child class, override get_admin_urls_for_registration to add the url for your new view onto the return urls array.

In the same class, implement a new function to return your view (i.e. it should do the same as ModelAdmin.inspect_view but return your own view class).

Implement the actual View class by e.g. inheriting from InspectView

This is quite a lot of boilerplate. Similarly if you wish to remove a view/button (e.g. preventing models from being deleted), you have to reimplement a function to do exactly the same thing but without the button you wish to remove.
I wonder if there is way to easily, dynamically register views/buttons in ModelAdmin?
I am not sure how this could work yet, but perhaps a class attribute which will take an array of tuples with the view class and button name? We would then need the necessary logic to register these views.
Allowing new views to be registered like this would not only make it more generic, but allow a lot of the repeated boilerplate within the base classes to be condensed (e.g. functions like index_view and create_view on ModelAdmin, or create_button, index_button etc on ButtonHelper which share much of the same logic)
I will happily do the work to this effect, but I think it needs some discussion and consensus before beginning.
Another interesting possibility would be to allow buttons to be registered which are not attached to a view ..this could be achieved by simply setting the url parameter to '', but it would be useful to be able to specify the html id of the created <a> element.
(e.g. to allow javascript actions etc...)

Wagtail version: v1.7

@JamesRamm thanks for posting. Some really good points here! I've faced a similar frustrations myself (particularly with ButtonHelper), and would love to help refactor things to make things easier to extend. Not having attributes or methods on the ModelAdmin class to add a layer of control to ButtonHelper seems like a huge missed opportunity (my bad). I did propose some changes a while ago (#2758), but I was waiting for at least some feedback before starting work, as these things are kind of critical to a developers experience of working with Wagtail, and so are important to get right. I know it's far from the fully generic approach you hinted at above, but would you agree that is a step in the right direction?
In regards to what you said here:

Similarly if you wish to remove a view/button (e.g. preventing models from being deleted), you have to reimplement a function to do exactly the same thing but without the button you wish to remove.

Hiding features by editing the ButtonHelper would never be an approach I'd recommend, because whether the ButtonHelper shows the button or not, the URLs for those actions (and the views to perform them) are still registered, and likely still accessible by going to the URL directly. The recommended approach would be to simply not grant users the relevant permissions required for those actions (ButtonHelper only shows buttons for actions that the current user has permission to perform)

I am not sure how this could work yet, but perhaps a class attribute which will take an array of tuples with the view class and button name? We would then need the necessary logic to register these views.

I think we can safely split actions into 4 groups:

Those that aren't related to a specific instance, can have a simple URL pattern that doesn't contain any params, and the view only really needs to take a HttpRequest instance. e.g. 'index' and (in a most cases) 'create'.
Those related to a specific instance, and the URL just needs to contain an identifier to specify which instance in involved. e.g. 'edit', 'inspect', 'delete', 'publish', 'unpublish'.

And less common:

Those that aren't related to a specific instance but need to accept one or more parameters in their URL pattern that need to be passed to the view. e.g. a 'create' view for a tree-based model, where you need to pass additional information to specify where in the tree the new instance needs to be added.
Those related to a specific instance, and the URL needs to contain an identifier, plus one or more additional params that need to be passed to the view. e.g. a 'move' view for a tree-based model that takes a primary key, plus other arguments to specify where that instance should be moved to.

So long as a more generic solution wouldn't lock out support for the last two, I think it would be worthwhile pursuing this. Even if the end-result wasn't quite as simple as defining a few tuples, cutting out some of the repetition throughout, and reducing the number of manual steps for adding custom views would definitely be positive.

@JamesRamm what would you think to introducing a class similar to the one below for defining all of the things related to a specific action? I think most things could be introspected from that (urls, button stuff, permission checks etc). And if it had URL-related methods that could be overridden for types 3 and 4 (above), that should be pretty much everything covered, right?
ModelAdminAction(
    handle='edit',
    instance_specific=True,
    button_text='Edit',
    button_classnames=[],
    button_extra_attributes={}:
    view: EditView,
    permissions_required: ['can_edit'],
)

Put together a quick proof of concept for this class here:
https://github.com/rkhleics/wagtail/blob/modeladminactions/wagtail/contrib/modeladmin/actions.py
I'm thinking that the actions themselves would be defined as a list of tuples, where the 'codename' (e.g add/edit/delete) would be the first value, and the second would be a dictionary of args to be used to initialise a ModelAdminAction instance. The ModelAdmin class itself would then turn those into a dictionary of real ModelAdminAction instances on initialisation, with the 'codename' as the key, and the instance as a value. That way, all the various helpers could easily refer back to individual ModelAdminAction instances using the codename.
Other ideas welcomed :)

@ababic I agree with your 4 'groups' of actions, although I might also add a 5th group where you have an action not tied to a specific view? This would support, essentially, buttons with javascript handlers (ajax updates and whatnot - I would also allow any generic button attributes (like id) to be specified).
A class to handle each model action is a good idea - am I correct in thinking the intended interface would be something like below?

MyModelAdmin(ModelAdmin):

    modeladmin_actions = (('codename', {...}))

Ideally, the existing default actions - inspect, edit, create, delete, would all be implemented through the same interface (as ModelAdminActions in this case) and the default behaviour would be to have the existing actions... actions.py could provide a list of default actions so that it can be easily extended/overridden, e.g
in actions.py:
INSPECT = ('Inspect', {...})
EDIT = ('Edit', {...})
...
DEFAULTS = [INSPECT, EDIT, ...]

So you can then do:
from .actions import DEFAULTS

MyModelAdmin(ModelAdmin):

    modeladmin_actions = DEFAULTS += [('MyAction', {...})]

Or

from .actions import INSPECT

MyModelAdmin(ModelAdmin):
    modeladmin_actions = [INSPECT]

It looks like it would nicely reduce adding an action to just filling in some parameters and creating a view.

@JamesRamm I envisaged the ModelAdmin action class to be smart enough to support that use case too. I think by setting register_url=False and providing a button_url value could be enough to support that (I'm wide open to guidance on better names for those!).
I did envisage the existing actions being migrated to the new interface too... the ModelAdmin class could then cycle through them to create the URLs list etc, and we could probably drop all of the get_codename_template and codename_view methods from the ModelAdmin itself, making things much cleaner. However, that would probably introduce a lot of backwards compatibility issues. It might be that we need to phase some changes in later.
Separate sets of actions would need to be defined for page-type models and non page-type models too, as there are differences between the two.

@JamesRamm Love your idea of having the default options configured in the same file so that they can be imported more easily. One thing I neglected to explain before, but I'd probably suggest that 'codenames' be made to conform to something like '[a-z0-9_]'. I think it would help avoid collisions, and also communicates better how it will be used by the other components.

Im onboard with all that. Would it be possible to keep all the existing functionality with deprecation warnings on functions, while still merging the new method in full? Then provide deprecation warnings for the next release or so (whatever the wagtail convention is).
On conventions...a small note; on your ModelAdminAction you are using both @property and get... functions. Feel free to strike me down (I dont know the wagtail conventions), but you could replace get... with properties for a more consistent implementation? (Although I can see liberal use of get... throughout wagtail so maybe its the accepted style)
A regex and collision check is a great idea yes. Your '[a-z0-9_]' suggestion is liberal enough to allow most namings I can think of...I would also do a specific collision check against the previously registered actions (if possible), to prevent stuff like modeladmin_actions = DEFAULTS += [('name_clash', {...}), ('name_clash', {...})]

I think we will likely need to take some steer from the core team RE deprecation a little later down the line, as I feel it could probably be the biggest challenge here as things pan out.
Great point on conventions on use of @property VS get_something. would gratefully accept some steer there!
And good point about collision checking. I feel like a nicely-worded 'ImproperlyConfigured' exception to notify users about those on ModelAdmin.__init__() would be very useful.

@JamesRamm In regards to something you said about the 5th group of actions:

This would support, essentially, buttons with javascript handlers (ajax updates and whatnot - I would also allow any generic button attributes (like id) to be specified).

I'm beginning to think it will be difficult to fully support this with just a single definition on the model class. E.g. in the case of adding an 'id' attribute, you wouldn't ever want the same ID to be added to all buttons on that type. In almost all examples I can think of, you'd want to have unique values for each instance of the button, likely using field values from the relevant model instance. I feel like the only solution for buttons like that will be to create a method that accepts a model instance, like the methods that currently need to be defined on the ButtonHelper class. We can make things a little bit easier by allowing that method to be defined on the ModelAdmin class OR the ButtonHelper, but I can't think of a nice way to support them via a set of static values - unless anyone else has any ideas?

@ababic, thats true. I was thinking you would probably also want to set some data attributes to be able to do anything particularly useful with javascript (at a minimum the pk of the model, at best whatever attributes the use wishes to have set.)
Yes, best would be a method along the lines of get_button_attributes(self, instance) which by default does nothing. Such a method could return a dict of attributes to set, which would then cover just about anything you would want to do with a button....
This should perhaps be a future addition, to prevent this issue from getting too big?

Yeah that's probably better as a future thing. Although, in the meantime, we can still support the definition of individual button methods, and there's also the get_extra_attrs_for_row() method on the ModelAdmin, which can be utilised to add data attributes and whatever else to the row (<tr> element) for each result in IndexView, so things can be made available to js.

+1 (great enhancement)

Just wanted to flag up a couple of related ModelAdmin issues.
Ideally, I'd like the following to precede this work, because it will help keep the view-related stuff simple:

Improve consistency of how views in ModelAdmin are initialised #3392

And possibly the following too, because it will remove some unnecessary cruft from options.py

Move modeladmin.options.ThumbnailMixin to modeladmin.mixins.ThumbnailMixin #3339

I also never really considered this before, but I feel like this work could make something like the following easier, by letting you flag certain actions as 'bulk actions' or something:

ModelAdmin: select multiple for mass-action #2719

Would #2758 not initially complicate resolving this issue, since, if I understand, it is about adding new features...new features would be easier to add once this refactor is done, since this should make extension/future maintenance a bit easier?
There is some overlap with the proposal to tackle #2758 with what is proposed here - namely allowing additional button methods to be added to ModelAdmin , which would be superseded by the ModelAdminAction class and simple interface for adding them to ModelAdmin proposed here...
Once this issue tackled, then #2758 becomes a slightly simpler question of 'how can we do nested ModelAdminAction's', right?

@JamesRamm

Once this issue tackled, then #2758 becomes a slightly simpler question of 'how can we do nested ModelAdminAction's', right?

I'm thinking #2758 should probably be de-scoped, so that we can at least have index_view_buttons and inspect_view_buttons attributes on ModelAdmin that let you define what you want to define which buttons you want to show on those page, and in what order. Without that functionality to complement ModelAdminAction, we're still kind of stuck in a place where developers will need to override various methods on ButtonHelper to make their new actions/buttons appear in the right places, which kind of defeats the object of simplifying it.

There is some overlap with the proposal to tackle #2758 with what is proposed here - namely allowing additional button methods to be added to ModelAdmin , which would be superseded by the ModelAdminAction class and simple interface for adding them to ModelAdmin proposed here.

I think we've already agreed that it will be possible to support simple button definitions within the modeladmin_actions definition on a ModelAdmin class, but we still need a way to support more complex buttons that don't always just have the same text / url / might need to incorporate values from the current object. Developers need a way to be able to define those more complex buttons, and currently, the only place that's supported is on the ButtonHelper class, which means you'd have to create a custom ButtonHelper just to add a new button definition method to it. Being able to define that method on the ModelAdmin class instead makes that a lot easier, and I think is something we need to have in place to complement this work.

I'm thinking #2758 should probably be de-scoped, so that we can at least have index_view_buttons and inspect_view_buttons attributes on ModelAdmin that let you define which buttons you want to show on those pages, and in what order (just supporting a flat list for now). Without that functionality to complement ModelAdminAction, we're still kinda stuck in a place where developers will need to override various methods on ButtonHelper to make their new actions/buttons appear in the right places, which kind of defeats the object of simplifying it.

Right, yes I see where you are coming from now. :+1:

Hey @JamesRamm. Quick status update: The work I suggested should precede this work is coming along:

#3339 is now done
#3392 is being catered for by PR #3542, which i'm waiting for feedback on
#2758 is quite far along my own fork, but it's too big a change to go in as a single PR - it needs breaking up into smaller ones to stand any chance of being reviewed and merged.

I've begun working on this particular feature as a (not yet working) third-party app, bundled together with the new ButtonHelper stuff I've done (the two ideas complement each other incredibly well), so that It will be easier to demo and collect feedback on (https://github.com/ababic/waddleadmin/). But, I do kinda need #3542 to be merged before I can get that working properly.
Do please check out  actions.py and options.py if you'd like to see how it might all work / fit together.

@ababic
Taken a quick look at actions.py and options.py; looks great. I think you have pretty much captured most of what we discussed which is awesome.
Being able to look through the file and see the action definitions for the default actions has the add on effect of  increasing readability IMO - it is much easier to figure out how to create new actions from reading this code.

Any progress on this?

Hi @Adrian-Turjak. There's certainly progress, but this was always going to be a challenge. I'm trying to tackle a few related aspects of this functionality separately, in smaller, more focussed PRs, in an aid to make things easier/quicker to review. But they haven't been moving as quickly as I'd hoped.
#3542 had to be cancelled and has been replaced with #3626, which I hope will be reviewed soon. I think the focus has then got to be on getting https://github.com/ababic/waddleadmin/ into a state that will show all of the various components working together as intended. That's probably the best way to gather input from other developers, and get things into a shape that the core team will be happy with / want to prioritise.

@ababic  Fantastic! I'll try and keep an eye on this will be happy to review and play with https://github.com/ababic/waddleadmin/ when you've got it in a state you're happy with. :)
As much as I dislike the default django admin, the ability to add actions to it was easy, and useful, so I'm really hoping for something just as nice for the wagtail admin! Because as the OP has said, the existing process is a little roundabout. :(


App Gateway vs Front Door in the architecture diagram

The architecture diagram on this page shows Azure Front Door while the downloadable visio template shows Application Gateway in "Scalable web app" section. Now I understand both can be used, but then if we choose Application Gateway, then shouldn't it be shown in its own subnet in the visio template ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec53963c-4c95-f6e7-90e0-d1e827df50b0
Version Independent ID: 81cb35e8-e65d-41b7-f53d-5ddada2b6301
Content: Scalable web application - Azure Reference Architectures
Content Source: docs/reference-architectures/app-service-web-app/scalable-web-app.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @MikeWasson
Microsoft Alias: pnp

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#

Seems Like all of their App service diagram downloads only one Diagram, the BAsic one at https://archcenter.blob.core.windows.net/cdn/app-service-reference-architectures.vsdx

We updated the reference architecture to use Front Door but then I forgot to update the Visio. 😺  I've uploaded the latest Visio file. As you say, both are options. This article has guidelines for choosing Application Gateway vs Front Door.


echo=F in template

In the Sys.Date line, the code might be made invisible using echo=F

Also, having Syst.date() in there make little sense since all chapers will have the same data (the reder date). We ideally want to have the date when the output files were written.

In the template, also change reference state with reference condition

All done

great, thanks!


Update fhir core dependency to 5.5.7

HAPI 5.6.3 needs FHIR core 5.5.7

This would need to roll through the engine, evaluator, language server, tooling, and ruler as well.

Skipping to 6.0.1 and 5.6.36 for translator 2.0. See #747


Feedback on mobile styling

Describe the bug
I am reporting several small bugs related to mobile styling. Some of these are more opinion and some are most about consistency. However, I want to make my small contribution to having beautifully designed open source software by offering some options here.
Version
Exact version in the top right area: 0.46.04
To Reproduce
Steps to reproduce the behavior:

You don't need to do anything to reproduce them just visit the relevant page.

Screenshots

In this first issue, the URL text box could take up the full width of the page like other text boxes do on mobile.
The second issue in this image is the radio buttons have text only on the next line. It probably should start on the same line and wrap.

The underline below the checkbox, pause, title are not aligned. In my option it would make sense for them to all align with whichever is the longest.

It would be nice if the minutes/hours/days/etc were aligned a bit better.
Second, the buttons at the bottom have some different sizes and spacing. It would be nice if that were a bit more consistent.
Smartphone (please complete the following information):

Device: [e.g. iPhone6] Pixel 7
OS: [e.g. iOS8.1] Android 15
Browser [e.g. stock browser, safari] Firefox
Version [e.g. 22]  130

As always, thanks so much @dgtlmoon for all the hard work you put into maintaining this project! I use it here and there and I'm always happy to find that there's a new version available with things improving all the time.

I have opened a PR #2662 Please check and let me know if any changes are there

More stuff

BrowserSteps - the control buttons on the right side should wrap to UNDER the preview screen area
Clicking [save] on slow connections should show thats saving somehow (spinner?)

The tags page could also use a little love on mobile.

merged


Aliyun OSS url was invalid

28 调试技巧4 inline breakpoint
https://tsqcdn.oss-cn-shanghai.aliyuncs.com/lib.js

fixed


SyntaxError in /clan/legless-monkeys-2qj0lpv2

Error in ClashLeaders
SyntaxError in /clan/legless-monkeys-2qj0lpv2
Unexpected token < in JSON at position 0
View on Bugsnag
Stacktrace
webpack:///js/store/index.js:61 - E.<anonymous>

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
SyntaxError in /clan/legless-monkeys-2qj0lpv2


Add missing expression to reference. (CDS-95148)

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Purpose
What is the motivation for this PR? What changes does it include? Include as much or as little detail as needed.
To add a missing expression to the expression reference.
If this submission relates to a Jira or GitHub issue, include the issue ID in the title.
CDS-95148
Internal Harness contributors - Please edit this summary to include preview links after the preview build finishes.
Merge requirements

[X] Successful preview build.
[ ] Code owner review.
[X] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660f23af60006d0092bea7df--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660f327b43fd690ae3697cb9--harness-developer.netlify.app


pull request for e2e test at 12/10/2016 09:56:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Invalid end of chunk (parse_chunk_size)

Hello, the end of the chunk should be ended by two sets of \r\n. but parse_chunk_size considers that one set is enough, which results in the inability to know the completion of message transmission in the TCP stream.
for example:
correct:
let buf = b"0\r\n\r\n";
assert_eq!(httparse::parse_chunk_size(buf), Ok(httparse::Status::Complete((3, 0))));

unexp:
let buf = b"0\r\n";
assert_eq!(httparse::parse_chunk_size(buf), Ok(httparse::Status::Partial));

let buf = b"0\r\n\r";
assert_eq!(httparse::parse_chunk_size(buf), Ok(httparse::Status::Partial));

The unexpected ones look correct to me. Those are partial ends.
The top example looks wrong, though. It should be complete, and report that the end is at byte 5, no?

No. The function parse_chunk_size reads \r, then \n, then breaks and returns Complete.
Therefore correct only reads 3 bytes. The unexpected  below will always read only the first 2 bytes.
https://github.com/seanmonstar/httparse/blob/a3c10fd3281d3b70becc1aa54a995b617f502045/src/lib.rs#L1300C36-L1300C36


use the existing instance of Velocity instead of requiring a new one

without this, velocity-react was always requiring a new instance of velocity-animate, so require('velocity-animate/velocity-ui') was attaching to the wrong instance. This finds an existing instance the correct way (the same way velocity.ui.js does it)

Makes sense. Thanks for putting this together.


swagger_versions doesn't work

when use swagger_versions in ini:
pyramid_swagger.swagger_versions = ['2.0']
will cause:
Swagger version [ is not supported
pyramid_swagger/tween.py:
swagger_versions need be converted to list.

@zhouxiaoxiang are you sure that syntax is correct for INI files? Have you tried pyramid_swagger.swagger_versions = 2.0?

The INI format is definitely a strange one. I like http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/environment.html as my reference for how to encode various basic data types.

@zhouxiaoxiang our documentation is not correct in regards to the format of settings in the INI file, I'm fixing it in #189 - as well as making sure we read this particular setting correctly if you specify both swagger versions. Just to reiterate, pyramid_swagger.swagger_versions = 2.0 should do what you want. You could also simply remove that line as that is the default.


Release

This PR is to get clisops ready for a new release.
I have updated the doc strings and documentation, added a new notebook and incorporated static type support from #67
Breaking changes from previous PRs have been documented in HISTORY.rst
The only problem I haven't been able to resolve is with the plots in the notebook in the documentation as the images are broken: (e.g. https://clisops.readthedocs.io/en/release/notebooks/core_subset.html). If anyone is able to help with this, that would be great.
I've suggested a version number of v0.4.0 - let me know if this should be different.

@ellesmith88 Looks all good to me :) See comments for the pip packages in conda environment.

Seeing as https://github.com/roocs/clisops/pull/48 is nearing completion, do we anticipate that the fix will be in the release? If not, not a big deal but maybe we can simply make a note that Windows is not supported in this particular release.

Seeing as #48 is nearing completion, do we anticipate that the fix will be in the release? If not, not a big deal but maybe we can simply make a note that Windows is not supported in this particular release.

@Zeitsperre: we would like to get this release out as soon as we can, so let's hold back on #48 and address that next. :-)


Support notifier.nvim

Is your feature request related to a problem? Please describe.
I love the theme and its many integrations. It would be wonderful to provide an integration for notifier.nvim plugin
Describe the solution you'd like
Theme for notifier.vim plugin through an integration.
Thanks!

In the meaning time, I'm using this:
  -- Highlighting for notifier
  local C = require('catppuccin.palettes').get_palette()
  local highlighter = require('catppuccin.lib.highlighter')
  highlighter.syntax {
    NotifierIcon = { fg = C.mauve },
    NotifierContent = { fg = C.overlay2, blend = 0, style = { 'italic' } },
    NotifierContentDim =  { fg = C.overlay1, blend = 0, style = { 'italic'} },
  }

Thanks!


Tracker macro to import chainrules

This shouldn't be merged here. I will upstream this to handle https://github.com/FluxML/Tracker.jl/issues/132
But I need the tests here to pass first

[x] Upstream to Tracker.jl https://github.com/FluxML/Tracker.jl/pull/168
[x] Release new version in Tracker
[ ] Use the macro from Tracker

Tested AMDGPU Locally!


Add support for arrayContainsAny query

Fixes #74
This change will allow to use arrayContainsAny operator with query.where
See official Firestore documentation for more details:
https://firebase.google.com/docs/firestore/query-data/queries#in_and_array-contains-any
Please note that this PR/commit is an optimistic change. It has not been tested locally due to time constraints.

Thank you for writing this PR @anuragbhd! Would you mind writing unit tests as well to verify that the code works as expected? You can take a look at how @qwales1 did it for arrayContains in #69.

Thanks for the pointer, @atn832. I've written tests based on existing ones for arrayContains, and found them to be all green :)

Added one more commit to enforce the condition that arrayContainsAny must not have more than 10 comparison values. Update unit tests accordingly.
This one is optional. Ignore it if you fee like.

Awesome tests. And thanks again for writing the PR. I'll publish a new version of the library that includes it, this weekend.

Your code is live at https://pub.dev/packages/cloud_firestore_mocks#043. Thank you @anuragbhd !


[Backport 1.7.latest] Install psycopg2 based on platform

Backport https://github.com/dbt-labs/dbt-postgres/issues/50

We decided not to backport this change.


vscode cannot sign in github on windows11

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.77.1
OS Version: windows 11

Steps to Reproduce:

installed the github pull requests and issues on vscode
sign in with github on vscode
cannot sign in github
log is below:
2023-04-07 16:23:40.503 [info] Getting sessions for read:user,repo,user:email,workflow...
2023-04-07 16:23:40.503 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2023-04-07 16:23:41.887 [info] Logging in for the following scopes: read:user repo user:email workflow
2023-04-07 16:23:41.890 [info] Trying without local server... (read:user repo user:email workflow)
2023-04-07 16:28:41.923 [error] Timed out

but I can open github.com on browser and commit/push code to github with windows terminal.

Having a similar issue on Gentoo, I get through the Github signin flow fine, but then code never responds. Tried with both Firefox and Chromium.
2023-04-07 08:24:10.442 [info] Getting sessions for read:org,user:email...
2023-04-07 08:24:10.442 [info] Got 0 sessions for read:org,user:email...
2023-04-07 08:24:12.453 [info] Logging in for the following scopes: read:org user:email
2023-04-07 08:24:12.454 [info] Trying without local server... (read:org user:email)
2023-04-07 08:29:12.500 [error] Timed out

Do you have a corporate proxy applied on your system?

Do you have a corporate proxy applied on your system?

Yes，I have a proxy of .pac file  on my windows.  I am able to log in to the GitHub website without any obstacles and use the git command's push/pull commands to perform code operations on my GitHub repository.

would you mind trying out @chrmarti's proxy debugging extension:
https://github.com/microsoft/vscode-remote-release/issues/8248#issuecomment-1494127068
and let me know how it goes

would you mind trying out @chrmarti's proxy debugging extension: microsoft/vscode-remote-release#8248 (comment)
and let me know how it goes

VS Code 1.77.1 (b7886d7461186a5eac768481578c1d7ca80e2d21)
Network Proxy Test 0.0.4
win32 10.0.22621 x64
Settings:

http.proxy:
http.proxyAuthorization: null
http.proxyStrictSSL: true
http.proxySupport: override
http.systemCertificates: true

Environment variables:
Sending GET request to https://containers.dev/static/devcontainer-index.json...
vscode-proxy-agent: HTTPS ssl-47ep2-1hge744-0.hinpac.com:3389;HTTPS ssl-47ep2-1hge744-0.hinpac.com:443
Received response:

Status: 407 Proxy Authentication Required

Unfortunately proxy authentication isn't well supported yet. You could try setting the HTTP Proxy in the VS Code user settings to<EMAIL_ADDRESS>

Based on your advice, I setted the http proxy,  then executed the  http-proxy-test, result is below.
Settings:

http.proxy: https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

globalValue: https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

http.proxyAuthorization: null
http.proxyStrictSSL: true
http.proxySupport: override
http.systemCertificates: true

Environment variables:
Sending GET request to https://containers.dev/static/devcontainer-index.json...
vscode-proxy-agent: HTTPS xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Received response:

Status: 400 Bad Request

Maybe the http-proxy is not setted well because I am not using the https-proxy on the wiindows. Instead, I am using the proxy-srcipt on the windows.

Could you try appending the port :3389 to the proxy URL? The first run of the test command showed the response from the proxy script:
HTTPS ssl-47ep2-1hge744-0.hinpac.com:3389;HTTPS ssl-47ep2-1hge744-0.hinpac.com:443

I haven't got a proxy on my system.

Hey @chrmarti, this issue might need further attention.
@djhoo, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Godot does not listen to microphones with over 2 channels

Godot version
4.2 dev 5 [9ff46d0]
System information
Godot v4.2.dev5 - Windows 10.0.19045 - GLES3 (Compatibility) - Intel(R) UHD Graphics 620 () - Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz (8 Threads)
Issue description
When trying to listen to a microphone with 4 channels, godot returns this error:
E 0:00:06:0920   thread_func: WASAPI: unsupported channel count in microphone!
  <C++ Source>   drivers/wasapi/audio_driver_wasapi.cpp:877 @ thread_func()

Ideally it would just take the first 2 channels, or combine all channels into 1?
Steps to reproduce
With a PC with a microphone with over 2 channels, create an AudioStreamPlayer, with an AudioStreamMicrophone in it, and route it to master.
Just notify me if you need to test code? I can recompile the engine.
Minimal reproduction project
mic test.zip

Should be fixed by #90013. Can you test it?

I still get this error in V4.2.2 stable and v4.3 dev6.
I'm using a built-in microphone on my laptop which has 4 channels.
https://github.com/godotengine/godot/issues/30313 is made a while ago also with a 4 channel mic.

Should be fixed by #90013. Can you test it?

Not sure if you've already tested it, but it does fix the issue.


issue about "cannot find a part of the acces path `C:\Program Files\TaskbarGroups\config\Games\GroupImage.png´

hi i have an issue about permission when i click on the group that i have created called "Games" , can anyone help me please?

https://github.com/PikeNote/taskbar-groups-pike-beta/releases
Please use the build here

I am experiencing this issue as well every time I open the application @tjackenpacken


Adjust emoji's image size

Heyo!
After parsing: emoji size looks off, and I'm using emoji's image instead unicode.
    const emoji_options: MarkedEmojiOptions = {
        emojis,
        unicode: false
    };

input: :+1:
output:

and with input like this:
:+1: Breaks
output:

see? image needs w-x inline-flex something like this ig.
It would be great if we can adjust emoji size without affecting external images while parsing.

This can be better achieved if you can let the developers add custom class to emojis :D

You can change the renderer if you want custom html
const emojiExtension = markedEmoji({
  emojis,
  unicode: false,
});

const emojiRenderer = emojiExtension.extensions[1].renderer;
emojiExtension.extensions[1].renderer = (token) {
  const html = emojiRenderer(token);
  return html.replace(/^<img /, '<img width="x" height="y" ');
}

marked.use(emojiExtension);

This sounds a bit hacky, can't we do something like
const emojiExtension = markedEmoji({
  emojis,
  class:'marked-emoji',
  unicode: false,
});

You can create an extension that does that. I like to keep my extensions simple with the least amount of options necessary.
Overriding an extension renderer is not a hack. marked made it specifically so you can override renderers and tokenizers.
If you don't like the replace you can return the html however you want.
marked.use(markedEmoji({
  emojis,
  unicode: false,
}));

marked.use({
  extensions: [{
    name: "emoji",
    renderer(token) {
        return `<img class="marked-emoji" alt="${token.name}" src="${token.emoji}">`;
    }
  }]
}

Fair enough. Thanks for your explanation

Hey @UziTech, Sorry to ping you but can you show me a way to override emoji using Marked constructor?
  const marked = new Marked(

        // Emoji plugin
        markedEmoji({
            emojis,
            unicode: false
        }),
        {
            // We dont need github like header prefix
            headerIds: false
        }
    );

 marked.use({
        extensions: [
            {
                name: "emoji",
                renderer: (token) => {
                    return `<img class="inline-flex" alt="${token.name}" src="${token.emoji}">`;
                }
            }
        ]
    });

This is not producing the desired output?

That works for me. What is is producing and what is the desired output?
The objects passed to the Marked constructor are extensions passed to use internally. So the following code would be the same:
const marked = new Marked(

  // Emoji plugin
  markedEmoji({
    emojis,
    unicode: false
  }),

  // Override emoji renderer
  {
    extensions: [
      {
        name: 'emoji',
        renderer: (token) => {
          return `<img class="inline-flex" alt="${token.name}" src="${token.emoji}">`;
        }
      }
    ]
  },

  // Other options
  {
    // We dont need github like header prefix
    headerIds: false
  }
);

I did something along the lines of this
const marked = new Marked({
 markedEmoji(emoji_options),
        {
            name: "emoji",
            renderer: (token) => {
                return `<img class="inline-flex" alt="${token.name}" src="${token.emoji}">`;
            }
        },

})

Nvm. Should i add this to the readme,md ? For future developers stumbling on this error?

This override behavior is documented on marked https://marked.js.org/using_pro#extensions. It could be more prominent if you want to add an example in the marked documentation.


Implement save/load

Hello,
I made a small benchmark and rBloom is about 2x faster than pybloomfiltermmap3, wow!
Would it be possible to save filter bits to a file and reload it?
Access to bits from Python and a new arg in Bloom.new() can be sufficient.
Thanks!
Denis

Hi,
Thank you for the explanation @kenbyte !
The save/load mechanism may be enabled only if a hash_func is provided and fail when using the default built-in Python hash.
This moves the responsibility of using a deterministic hash function to the user and should be documented.
What do you think of this option?
Denis

I have now implemented persistence; see the readme for how to use it!

Great! Thank you


⚠ ClamAV has degraded performance

In c4f50be, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 117 ms

Resolved: ClamAV performance has improved in 6ab3748 after 6 minutes.


Created Footer Section

#6-Create-Footer

merge with staging and push the commit
always before making PR, u should do a git pull of the branch you are making the PR to
in this case or most of our cases, its staging so do a git pull origin staging

fill the social href links!
youtube https://www.youtube.com/@TCETMumbaiOfficial
find IG, twitter and linkedIn by yourself.


How Can I custom tooltips to show only title (without startsAt)?

Question / Feature request:
Hello,
How Can I custom tooltips to show only title (without startsAt or with startsAt and endsAt) and if there is a possibility to add endsAt to bracket in events list after click on any day?
Regards.
Versions
Angular: 1.5.8
Calendar library: 0.27.3
Browser name and version: All.

To do this you just need to override the appropriate method from this class.
.run(calendarEventTitle => {
  calendarEventTitle.monthViewTooltip = event => event.title;
});

Hope that helps!

Yes, thank you very much!


Build failure with hoauth2-1.3.0

We are seeing:
src/Network/Wai/Middleware/Auth/OAuth2.hs:160:67: error:
    • Couldn't match expected type ‘SL.ByteString’
                  with actual type ‘OA2.OAuth2Error
                                      Network.OAuth.OAuth2.TokenRequest.Errors’
    • In the first argument of ‘SL.toStrict’, namely ‘err’
      In the second argument of ‘($)’, namely ‘SL.toStrict err’
      In the expression: onFailure status501 $ SL.toStrict err

@lehins I think an upper bounds restriction of hoauth2<1.3.0 should do the trick.

@cdornan Thank you, updated cabal on hackage and uploaded new version with a comnpatibility fix


Update Magento.php

Placed in wrong table

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-12218
Please use this issue to track the state of your pull request.

thanks for your contribution @magnolia4  :+1: :tada: :blue_heart:
sorry, it took us so long for the merge :disappointed:


upgrade project to allow net5 usage

Thanks Gregory,
Your changes have been merged into the master branch.

Thanks Gregory,
Your changes have been merged into the master branch.

Thanks a lot, note that you will need to release the packages using dotnet pack ... command instead of nuget, since nuspec file was removed.


PDF converter not compatible with Java 7 byte code

Caused by updated OpenHtmlToPDF library. Solution to revert to 0.0.1-RC15

Fix for this is available. Repo updated, maven updated but may take a while to show up in maven central.


Update project/learning goals

I updated the project goals and learning objectives on the README. Do these look good, and on the right days? (I know we did some shuffling).

Looks good to me!


Fix LoggerMessage sample link

Fixes #12145
Thanks @jasonshave! :rocket: It was the crazy 's' at the end of the link. Rotten 's'!!!! :smile: lol

@Rick-Anderson I'll do a find-'n-replace on the links tonight ... we're using redirects for all of these samples post-repo-rename.


Bootstrap headers not working (bare centeos)

When I run a simple script with the bootstrap headers I get the folloing error:
./test.kts: line 6: exec: kscript: not found
I created a reproducable in docker
FROM centos
RUN yum install unzip -y
RUN yum install zip -y
WORKDIR /project
COPY ./test.kts /project
RUN chmod +x test.kts
RUN ./test.kts

the script
#!/bin/bash

//usr/bin/env echo '
/**** BOOTSTRAP kscript ****\'>/dev/null
command -v kscript >/dev/null 2>&1 || curl -L "https://git.io/fpF1K" | bash 1>&2
exec kscript $0 "$@"
\*** IMPORTANT: Any code including imports and annotations must come after this line ***/

println("Hello from Kotlin!")
for (arg in args) {
    println("arg: $arg")
}

It seems that the bootstrap header is not correct.
Currently with
#!/bin/bash

//usr/bin/env echo '
/**** BOOTSTRAP kscript ****\'>/dev/null
command -v kscript >/dev/null 2>&1 || curl -L "https://git.io/fpF1K" | bash 1>&2
exec kscript $0 "$@"
\*** IMPORTANT: Any code including imports and annotations must come after this line ***/

it can't find kscript because it has not sourced the init-script from SDK. I think source "$SDKMAN_DIR/bin/sdkman-init.sh" is missing in before exec. What do you think?

I saw the log that I pasted, It has sourced the sdk script:
Setting kscript 3.1.0 as default.
$ source /Users/user/.sdkman/bin/sdkman-init.sh
./test.kts: line 6: exec: kscript: not found

But also error with can't find kscript

I fixed it by change the bootstrap header to next:
//usr/bin/env echo '
/**** BOOTSTRAP kscript ****\'>/dev/null
command -v kscript >/dev/null 2>&1 || curl -sL "https://git.io/fpF1K" | bash 1>&2
source "$HOME/.sdkman/bin/sdkman-init.sh"
exec kscript $0 "$@"
\*** IMPORTANT: Any code including imports and annotations must come after this line ***/

If I execute the test.kts by this way:
. ./test.kts
It seems also work without modify the bootstrap header
Ref: https://stackoverflow.com/questions/16011245/source-files-in-a-bash-script

However, it is still broken, as most users won't use/know this workaround. My bash skills are unfortunately also limited.
We somehow need to backport the workaround into the preamble.

I advice change the bootstrapheader to next:
//usr/bin/env echo '
/**** BOOTSTRAP kscript ****\'>/dev/null
command -v kscript >/dev/null 2>&1 || source /dev/stdin <<< "$(curl -L https://git.io/fpF1K)"
exec kscript $0 "$@"
\*** IMPORTANT: Any code including imports and annotations must come after this line ***/

I'v test it, It works fine. How do you think @holgerbrandl

Thanks for the fix.


[wct-browser-legacy] Update test-fixture to 4.0.0

The test-fixture installed by wct-browser-legacy is still ^3.0.0-pre.1:
https://github.com/Polymer/tools/blob/054c375d65668f374723cb650b38e1ec85bee2e8/packages/wct-browser-legacy/package.json#L30
The modulizer has been upgraded in #703 to install 4.0.0 so from now on, having the direct dependency on the test-fixture in bower.json will produce the following output:
$ yarn install --flat
yarn install v1.12.3
info No lockfile found.
[1/4] 🔍  Resolving packages...
warning<EMAIL_ADDRESS>This package has been deprecated in favour of @sinonjs/samsam
warning wct-browser-legacy > sinon ><EMAIL_ADDRESS>This package has been deprecated in favour of @sinonjs/samsam
warning wct-browser-legacy > sinon ><EMAIL_ADDRESS>This package is unmaintained. Use @sinonjs/formatio instead
warning wct-browser-legacy > sinon > formatio ><EMAIL_ADDRESS>This package has been deprecated in favour of @sinonjs/samsam
info Unable to find a suitable version for "@polymer/test-fixture", please choose one by typing one of the numbers below:
  1) "<EMAIL_ADDRESS>which resolved to "4.0.2"
  2) "<EMAIL_ADDRESS>which resolved to "3.0.0-pre.21"
Answer?:

I would recommend updating the package to 4.0.0 and a major bump for wct-browser-legacy to 2.0.0, then also the corresponding bump for polymer-modulizer to 0.5.0.

I would say this should be fixed. But apparently no one else had this problem so far 🤷♂


pickle schedules

Currently we're hitting "need alloc" on Buffer

Oh, it's because it's on an EXT device (copy in from numpy), that's the core issue.

Should be fixed in #4120


Layout: add default opengraph image

Closes #133

Validator: https://cards-dev.twitter.com/validator
Test URL: http://dg2.dtrt.org/en/newsletters/2019/04/09/
How this change works: https://github.com/jekyll/jekyll-seo-tag/blob/master/docs/advanced-usage.md#setting-a-default-image

Oh, and the image can be overridden for a particular post by including an image: <fully-qualified-url> tag in the post's header YAML.

ACK b516c25f23c2086af3da3a392836746d35a88be7
Thanks for grabbing this!


Failing signature test for Seq

Seq.pod6
$ RAKUDO_SRC=../rakudo xt/check-signatures.t doc/Type/Seq.pod6
1..1
    1..7
    not ok 1 - Seq.new invocant matches source
    # Failed test 'Seq.new invocant matches source'
    # at xt/check-signatures.t line 118
    # documented method: (Iterator:D $iter --> Seq:D)
    #     source method: (Seq: |)
    ok 2 - Seq.iterator invocant matches source
    ok 3 - Seq.is-lazy invocant matches source
    ok 4 - Seq.elems invocant matches source
    ok 5 - # SKIP cannot determine source for multi method Seq.from-loop
    ok 6 - Seq.sink invocant matches source
    ok 7 - # SKIP cannot determine source for multi method Seq.skip
    # You failed 1 test of 7
not ok 1 - check Seq methods
# Failed test 'check Seq methods'
# at xt/check-signatures.t line 80
# You failed 1 test of 1

Well, it's a multi:
https://github.com/rakudo/rakudo/blob/9e13ace808b422c465eaf902c5436f6e1d2b26fc/src/core.c/Seq.pm6#L10-L20

Well, it's a multi:
https://github.com/rakudo/rakudo/blob/9e13ace808b422c465eaf902c5436f6e1d2b26fc/src/core.c/Seq.pm6#L10-L20

I get this error when running the same:
MVMArray: shift expected string register
  in block <unit> at xt/check-signatures.t line 61

Maybe some instructions would be needed for check-signature.

I get this error when running the same:
MVMArray: shift expected string register
  in block <unit> at xt/check-signatures.t line 61

Maybe some instructions would be needed for check-signature.

What version of rakudo are you using (and what version is your checkout)?

What version of rakudo are you using (and what version is your checkout)?

Latest release, I was it was already fixed after you reported a similar error.

Latest release, I was it was already fixed after you reported a similar error.

After your change, I no longer see .new reported on in the test output (it doesn't error, but it doesn't list as a pass, either)

After your change, I no longer see .new reported on in the test output (it doesn't error, but it doesn't list as a pass, either)

I removed the skip on this - latest version of rakudo has this type, so all the tests pass using that.

I removed the skip on this - latest version of rakudo has this type, so all the tests pass using that.

The 'method new' lines aren't matching the grammar, needs to be expanded to match.

The 'method new' lines aren't matching the grammar, needs to be expanded to match.

This failure mode no longer happens


Support for built-in analyzers

It would be nice if some of the built-in analyzers were also supported. Mainly the following ones which don't require any specific configuration:

simple
whitespace
keyword
stop
standard
snowball

Should this be closed by #5 or did you want to keep this open to add other analyzers in the future?

I think it is ok to close it for now. I'm thinking about how to add the remaining built-in analyzers, which require some configuration.

Given this change, it would probably be a good idea to update the README page to remove (or reword) the following shortcoming:

Only works for custom analyzers right now (as it accesses the settings for your index)


[feat] Add support for custom WiX toolkit installation URL

Describe the problem
The current version of WiX that's automatically downloaded doesn't allow for the creation of installers that work on ARM64 Windows devices. That functionality was introduced in a development build of WiX.
Describe the solution you'd like
Currently the URL used to download WiX is hardcoded, but it would be nice if Tauri also checked for the presence of a WIX_TOOLKIT_URL environment variable that took precedence over the built-in value. This would allow users who want an ARM64 installer to manually configure their build with a version of WiX that supports ARM64.
Alternatives considered
I'm aware that v2 is moving to NSIS in lieu of WiX, but I don't expect that to be backported to v1 (or available in the immediate future). Also I don't think Tauri should default to the v3.14 version since as I understand it, it introduced breaking changes. Speaking of, I'm also assuming that upgrading to WiX v4 is a significant undertaking, so that's not an option either.
Additional context
I'd be more than happy to put this PR together. I just wanted to file an issue first so I could solicit feedback!

Not answering on the actual request, only the Alternatives section:

I'm aware that v2 is moving to NSIS in lieu of WiX, but I don't expect that to be backported to v1

nsis will be part of v1.3 and it's already merged in dev.

Also I don't think Tauri should default to the v3.14 version since as I understand it, it introduced breaking changes.

yeah quite a few breaking changes, it's closer to v4 than to v3. The last time i tried it a few months ago it also felt a bit buggy but maybe i messed up 🤷
Either way, from testing i wasn't comfortable introducing it in tauri, especially because it looks it's not actually supposed to be used and only serves as a migration step to v4

I'm also assuming that upgrading to WiX v4 is a significant undertaking, so that's not an option either.

Probably yeah. i'd still like to at least look at it once there is a stable release.


[BUG] Image size ZERO KB after geting the Screenshot

Describe the bug
The Screenshot is there at ouput folder but no image shwoing only zero kB.
To Reproduce
1.Install go-stare version v0.0.2
2. try an example go-stare -t "http://google.com"
3. you can see the out/ folder that the image file is present but the size to be zero KB
Expected behavior
An expected behavior is that domain screenshot has to be present.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: Mac OS
OS version: Catalina 10.15.7
go-stare version:  v0.0.2

Additional context
nothing the tool is great but need the bug fixes

Please do look into it.

That's because the timeout limit has exceeded, try increasing the timeout value to 30 with -T flag.
Next release will make value 30s as default timeout.


Ethy on_initialise optimisations

PR checklist

[ ] Describe the added/changed/fixed/removed behaviour
[ ] Tag related issue(s)
[ ] Add appropriate unit tests and/or integration tests to the integration test repository

needs to be rebased (conflicts)


Remove deprecated reatbag_led_type and ratbag_button_type

There is one actual logic change is in 5548da21d335d525955b7b7337fdb836685d89fc, this is something that would be nice to test before making a new release.


dropdownMenuMode is required on Android

Using the example app, only the purple box showed a menu. Removing the line dropdownMenuMode={true} made none of them function.
https://github.com/mpiannucci/react-native-context-menu-view/assets/42824688/06f72c2e-e490-4db8-97b6-eb4ca4ccc8b0

I tested on main right now and had no issues with the android emulator. Please reopen if necessary!