Please consider adding Password-based encryption!

In our use case, we want to explicitly set the bytes of a symmetric key to a specific set of bytes (we have come up with two kludgy ways of accomplishing this with the existing library) but having a first-class password based encryption will be useful.  In our particular use case, passwords will be generated by the system (not the user) so that the traditional fears of passwords being "weak", etc. do not apply (if that helps).

Would you mind sharing the workaround you found in the meantime ?

@evalsinca I imagine that you're alluding to writing code that uses AesGcmJce along those lines.

I was looking for a simple way to encrypt a short text message with a Password Based Encryption (PBE) and use Google Tink for the cryptographic part and found that Tink doesn't provide PBE natively. To solve this problem I made a simple class that does all the work with PBE, keyhandling and encryption/decryption.
The usage in a program is very simple and you need only 4 lines of code to use it:
AeadConfig.register(); // tink initialisation
TinkPbe tpbe = new TinkPbe(); // tink pbe initialisation
String ciphertextString = tpbe.encrypt(passwordChar, plaintextString); // encryption
String decryptedtextString = tpbe.decrypt(passwordChar, ciphertextString); // decryption

On my Github you find two sample programms to show how to implement the class (with and without GUI): https://github.com/java-crypto/H-Google-Tink/tree/master/H Tink Textencryption PBE
package tinkPbe;

/*
*
* Diese Klasse gehört zu diesen beiden Hauptklassen
* This class belongs to these main classes:
* TinkPbeConsole.java | TinkPbeGui.java
*
* Herkunft/Origin: http://javacrypto.bplaced.net/
* Programmierer/Programmer: Michael Fehr
* Copyright/Copyright: frei verwendbares Programm (Public Domain)
* Copyright: This is free and unencumbered software released into the public domain.
* Lizenttext/Licence: <http://unlicense.org>
* getestet mit/tested with: Java Runtime Environment 8 Update 191 x64
* getestet mit/tested with: Java Runtime Environment 11.0.1 x64
* Datum/Date (dd.mm.jjjj): 20.11.2019
* Funktion: verschlüsselt und entschlüsselt einen Text mittels Google Tink
*           im Modus AES GCM 256 Bit. Der Schlüssel wird mittels PBE
*           (Password based encryption) erzeugt.
* Function: encrypts and decrypts a text message with Google Tink.
*           Used Mode is AES GCM 256 Bit. The key is generated with PBE
*           (Password based encryption).
*
* Sicherheitshinweis/Security notice
* Die Programmroutinen dienen nur der Darstellung und haben keinen Anspruch auf eine korrekte Funktion,
* insbesondere mit Blick auf die Sicherheit !
* Prüfen Sie die Sicherheit bevor das Programm in der echten Welt eingesetzt wird.
* The program routines just show the function but please be aware of the security part -
* check yourself before using in the real world !
*
* Das Programm benötigt die nachfolgenden Bibliotheken (siehe Github Archiv):
* The programm uses these external libraries (see Github Archive):
* jar-Datei/-File: tink-1.2.2.jar
* https://mvnrepository.com/artifact/com.google.crypto.tink/tink/1.2.2
* jar-Datei/-File: protobuf-java-3.10.0.jar
* https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java/3.10.0
* jar-Datei/-File: json-20190722.jar
* https://mvnrepository.com/artifact/org.json/json/20190722
*
*/

import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.nio.charset.StandardCharsets;
import java.security.GeneralSecurityException;
import java.security.NoSuchAlgorithmException;
import java.security.spec.InvalidKeySpecException;
import java.util.Base64;
import javax.crypto.SecretKeyFactory;
import javax.crypto.spec.PBEKeySpec;
import com.google.crypto.tink.Aead;
import com.google.crypto.tink.CleartextKeysetHandle;
import com.google.crypto.tink.JsonKeysetReader;
import com.google.crypto.tink.KeysetHandle;
import com.google.crypto.tink.aead.AeadFactory;

public class TinkPbe {

	public static String encrypt(char[] passwordChar, String plaintextString)
			throws GeneralSecurityException, IOException {
		byte[] keyByte = pbkdf2(passwordChar);
		String valueString = buildValue(keyByte);
		String jsonKeyString = writeJson(valueString);
		KeysetHandle keysetHandleOwn = CleartextKeysetHandle.read(JsonKeysetReader.withString(jsonKeyString));
		// initialisierung
		Aead aead = AeadFactory.getPrimitive(keysetHandleOwn);
		// verschlüsselung
		byte[] ciphertextByte = aead.encrypt(plaintextString.getBytes("utf-8"), null); // no aad-data
		return Base64.getEncoder().encodeToString(ciphertextByte);
	}

	public static String decrypt(char[] passwordChar, String ciphertextString)
			throws GeneralSecurityException, IOException {
		byte[] keyByte = pbkdf2(passwordChar);
		String valueString = buildValue(keyByte);
		String jsonKeyString = writeJson(valueString);
		KeysetHandle keysetHandleOwn = CleartextKeysetHandle.read(JsonKeysetReader.withString(jsonKeyString));
		// initialisierung
		Aead aead = AeadFactory.getPrimitive(keysetHandleOwn);
		// verschlüsselung
		byte[] plaintextByte = aead.decrypt(Base64.getDecoder().decode(ciphertextString), null); // no aad-data
		return new String(plaintextByte, StandardCharsets.UTF_8);
	}

	private static byte[] pbkdf2(char[] passwordChar)
			throws NoSuchAlgorithmException, InvalidKeySpecException, UnsupportedEncodingException {
		final byte[] passwordSaltByte = "11223344556677881122334455667788".getBytes("UTF-8");
		final int PBKDF2_ITERATIONS = 10000; // anzahl der iterationen, höher = besser = langsamer
		final int SALT_SIZE_BYTE = 256; // grösse des salts, sollte so groß wie der hash sein
		final int HASH_SIZE_BYTE = 256; // größe das hashes bzw. gehashten passwortes, 128 byte = 512 bit
		byte[] passwordHashByte = new byte[HASH_SIZE_BYTE]; // das array nimmt das gehashte passwort auf
		PBEKeySpec spec = new PBEKeySpec(passwordChar, passwordSaltByte, PBKDF2_ITERATIONS, HASH_SIZE_BYTE);
		SecretKeyFactory skf = SecretKeyFactory.getInstance("PBKDF2WithHmacSHA512");
		passwordHashByte = skf.generateSecret(spec).getEncoded();
		return passwordHashByte;
	}

	private static String buildValue(byte[] gcmKeyByte) {
		// test for correct key length
		if ((gcmKeyByte.length != 16) && (gcmKeyByte.length != 32)) {
			throw new NumberFormatException("key is not 16 or 32 bytes long");
		}
		// header byte depends on keylength
		byte[] headerByte = new byte[2]; // {26, 16 }; // 1A 10 for 128 bit, 1A 20 for 256 Bit
		if (gcmKeyByte.length == 16) {
			headerByte = new byte[] { 26, 16 };
		} else {
			headerByte = new byte[] { 26, 32 };
		}
		byte[] keyByte = new byte[headerByte.length + gcmKeyByte.length];
		System.arraycopy(headerByte, 0, keyByte, 0, headerByte.length);
		System.arraycopy(gcmKeyByte, 0, keyByte, headerByte.length, gcmKeyByte.length);
		String keyBase64 = Base64.getEncoder().encodeToString(keyByte);
		return keyBase64;
	}

	private static String writeJson(String value) {
		int keyId = 1234567; // fix
		String str = "{\n";
		str = str + "    \"primaryKeyId\": " + keyId + ",\n";
		str = str + "    \"key\": [{\n";
		str = str + "        \"keyData\": {\n";
		str = str + "            \"typeUrl\": \"type.googleapis.com/google.crypto.tink.AesGcmKey\",\n";
		str = str + "            \"keyMaterialType\": \"SYMMETRIC\",\n";
		str = str + "            \"value\": \"" + value + "\"\n";
		str = str + "        },\n";
		str = str + "        \"outputPrefixType\": \"TINK\",\n";
		str = str + "        \"keyId\": " + keyId + ",\n";
		str = str + "        \"status\": \"ENABLED\"\n";
		str = str + "    }]\n";
		str = str + "}";
		return str;
	}
}

Please keep in mind that using a plaintext-String means that your plaintext is inmutable and undeletable in your heap until the Garbage Collector destroys them.
A more detailed description is vailable on my website: http://javacrypto.bplaced.net/h-tink-string-encryption-using-pbe-and-gui/

Per @thaidn you can also use the subtle api directly (the AesGcmJce class) - see his response to the thread I had first created.
https://stackoverflow.com/questions/52171198/how-to-create-symmetric-encryption-key-with-google-tink

@evalsinca Just letting you know that the link you pasted (above) that is supposed to go to stackoverflow actually goes to github. I'm going to provide the link with what I think your intention was:
=> https://stackoverflow.com/questions/52171198/how-to-create-symmetric-encryption-key-with-google-tink

Today I have encountered the discussion on stackoverflow and the suggestion to use AesGcm directly...
Can anyone (who is more familiar with cryptography and tink than me :) ) please, have a look as to whether this C++ implementation of the suggestion makes sense?

Visibility for aead.subtle is not public in bazel files. Is that why I can't import it to use AesGcmFactory? This is preventing me from interoperating with a Go program that uses the same.
I'm also a bit confused about that class. The visibility is private, but it's only ever used by tests? Is this intentional?
$ grep -r AesGcmFactory | grep -v Test.java
java_src/src/main/java/com/google/crypto/tink/aead/subtle/BUILD.bazel:    srcs = ["AesGcmFactory.java"],
java_src/src/main/java/com/google/crypto/tink/aead/subtle/AesGcmFactory.java:public final class AesGcmFactory implements AeadFactory {
java_src/src/main/java/com/google/crypto/tink/aead/subtle/AesGcmFactory.java:  public AesGcmFactory(int keySizeInBytes) throws GeneralSecurityException {

in the code above by java-crypto new PBEKeySpec(...) it takes bits not bytes as input... though I guess 256 bit, not byte what he wanted... and 1 byte = 8 bits (128 byte != 512 bit)
i am not sure you should publish crypto code if you are not precise...

+1
Please add this feature in the near future. It would be a great improvement for Tink.

We currently do not have plans to design or implement password based encryption.

(Closed)


[BUG] Install on Mac Big Sur 11.2 fails to find neuron dependency (NEURON all caps)

Stack trace:
(mnedev) Alexs-MBP:hnn-core alexrockhill$ sudo -H python setup.py develop
Password:
running develop
running egg_info
writing hnn_core.egg-info/PKG-INFO
writing dependency_links to hnn_core.egg-info/dependency_links.txt
writing requirements to hnn_core.egg-info/requires.txt
writing top-level names to hnn_core.egg-info/top_level.txt
reading manifest file 'hnn_core.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*' under directory 'hnn_core/mod/x86_64'
warning: no files found matching '*' under directory 'hnn_core/mod/x86_64/.libs'
warning: no previously-included files found matching 'Makefile'
warning: no previously-included files found matching 'pytest.ini'
warning: no previously-included files found matching '.circleci'
warning: no previously-included files matching '*.pyc' found under directory 'hnn_core'
warning: no previously-included files matching '*' found under directory 'doc'
writing manifest file 'hnn_core.egg-info/SOURCES.txt'
running build_ext
Creating /Users/alexrockhill/software/anaconda3/envs/mnedev/lib/python3.9/site-packages/hnn-core.egg-link (link to .)
Adding hnn-core 0.2.dev0 to easy-install.pth file

Installed /Users/alexrockhill/projects/hnn-core
Processing dependencies for hnn-core==0.2.dev0
Searching for NEURON>=7.7
Reading https://pypi.org/simple/NEURON/
No local packages or working download links found for NEURON>=7.7
error: Could not find suitable distribution for Requirement.parse('NEURON>=7.7')
(mnedev) Alexs-MBP:hnn-core alexrockhill$ pip install neuron -U
Collecting neuron
  Downloading NEURON-7.8.2-cp39-cp39-macosx_10_9_x86_64.whl (11.5 MB)
     |████████████████████████████████| 11.5 MB 3.8 MB/s
Requirement already satisfied: numpy>=1.9.3 in /Users/alexrockhill/software/anaconda3/envs/mnedev/lib/python3.9/site-packages (from neuron) (1.20.1)
Installing collected packages: neuron
Successfully installed neuron-7.8.2

It works when I pip install manually though.

it's a problem with the develop install that i've noticed too. cc @cjayb does the .pyproject.toml trick not work for the develop install?

Not sure, I think it pyproject.toml might be in play when using pip+setuptools. I think this will work for a development-install (in the folder containing setup.py):
pip install -e .

Ah, yes, looking at the trace more closely, this is exactly what pyproject.toml is doing: making sure NEURON is installed before trying to build_mod in the setup of hnn_core.


reference to template

the README.md references link to templates. link results in 404, is this the correct link?

The link is correct. The repo referenced isn't public yet.


Arrow function not compatible with IE11

It seems like you are using an arrow function in one place in the code.
In the getBirthplace function: personalNumber/parse.js@156
I tried to replace it with a normal function and then your code works in IE11. I would be nice if you could fix that or maybe run it through babel before publish it on npm?
Thank you!

So sorry about this! It has been fixed now with version 1.1.6.


Updated expected curl exit codes

allowing this merge with a failing check, due to the failure being beyond the scope of the current change


Use mock service worker (msw) to intercept API requests

To make tests more efficient, you can use the https://mswjs.io/docs/integrations/node to mock the API requests.
I can try to implement it

Thanks for your comment @drosi94.
I can't wait to welcome your PR for it 🚀


virtualization: unguarded-availability-new to error

The unguarded-availability-new warning to the error.
Currently, can compile even if the host OS is Canalina. define -Werror=unguarded-availability-new will warning to error.
virtualization.m:45:5: warning: 'VZLinuxBootLoader' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]

@zchee Thanks for your contribution. If you don't mind, can you also update in the README how to compile with Canalina?
Because I have written "REQUIREMENTS" section.
https://github.com/Code-Hex/vz#requirements


Internal: improve release process by pushing a master up to date

Currently, I always forget to update master branch, and master generate
the docs via travis. So this “trick” should help to avoid this
oversight.

Are you sure about git rebase next ?
I think it must be git merge next

I am using rebase for a few versions.
Since nothing has changed on master, it just add commits.  No?   (I do this all the time, but you should double check this)
Using rebase can change the commit hash if we aren't careful

Ok, will try by hand for the next release and will see.

I used merge and it is good.


How to open another user's mailbox in Exchange 365?

Hello,
I cannot find a way to use mfcmapi to open another user's mailbox after I migrate from on-premise Exchange server to Exchange 365 online.
I used to open another user's mailbox in on-premise Exchange server like following:

Create a outlook profile for the Exchange administrator in Organization Management group.
Logon the profile in mfcmapi.
Use the "MDB->Open other mailboxes" to open another user's mailbox. I just need to input the right value in "Server Name" and "User DN". Then the mailbox can be opened correctly.
The administrator's profile can open all mailboxes in the on-premise Exchange server environement by default without granting any extra permission.

However for Exchange 365 mailbox, I cannot open another mailbox with an administrator's profile.

In open other mailboxes dialog, I have tried input outlook.office365.com in "Server Name" with the mailbox dn in "User DN". But it shows mapi_e_no_access.

Is it possible at all to use mfcmapi to open other users' mailboxes in Exchange 365? (i.e. use the administrator profile to open all mailboxes in the organization with mapi) This is important for my company because the Exchange admin cannot create a separate profile for each mailbox in the organization to use mfcmapi to check things in the mailbox.
Thanks a lot
Simon

I finally got the answer. I need to grant permission for the admin user to access other user's mailbox. In on-premise Exchange server the default admin has the permission to access other user's mailbox by default. But in Exchagne 365 the admin has no permission by default.


COST SP Analysis lab, query update

Issue #, if available:
Description of changes: Update the pricing table creation query - there's new columns in the pricing data - so needs to be adjusted.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Good @natbesh


DHCP may not work fine

When I tackled to realize https://github.com/mROS-base/mros2-mbed/pull/42, I found RTPS communication with DHCP seems not to be working fine. The network configuration can be successfully completed and ping to the IP by DHCP is surely communicated, but the RTPS communication does not seem to be working. We need to observe this issue deeply.

I've added the caution in source code (and README)
https://github.com/mROS-base/mros2-mbed/pull/42/files#diff-8cf627ca3235825bac03faf3e92dca57b645af866b118cefe9b6c8138305b944R9-R14
/*
 * Caution:
 *  We have not confirmed the operation using DHCP setting yet.
 *  So you cannot comment out the below line to assign static IP address.
 */
#define MROS2_IP_ADDRESS_STATIC

As described below, It appears that the issue stems from insufficient system resources for sockets.
https://github.com/mROS-base/mros2-mbed/pull/54
I've tested the PR on my environments (ARC_MAX, F429ZI) and found that it functions properly in a DHCP environment.

fixed by #54


如何注册取消不同的事件

您好，我想问一下，链接websocket之后，如何订阅和取消不同的事件呢？多谢

Instead of using "subscriptions" you create a subclass of WebSocketServer or WebSocketClient and define your callbacks by overriding the methods "onMessage", "onOpen", "onStart" and "onClose". You can cancel them either by shutting down the whole socket or using your own logic (by toggling a variable, etc.).  If you're still not sure, take a look at the examples.
I hope I understood your issue correctly.

Hello @jayronlou,
is this issue solved for you?
Best regards,
marci4


[docs] Fix index

Fixes misaligned Supported models header:

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Added new files for Sprint 3

BEFORE MERGE - Secret key uploaded to github in config file.
Readability and Code Quality
Data cleansing code is clear for cleansing work done so far.
Sphinx documentation is informative and readable, in code.
Additional documentation in the web app section would be useful, through inline comments for example.
Design
Structure for interfacing with rds well set up.
Could perhaps separate model training portion from web application, in the folder structure to help manage clutter.
Testing
Additional testing can be added for user inputs that go into the prediction.
Documentation
ReadMe files could be more comprehensive.
commit statements are easy to follow. Multiple commits with separate comments very useful.


_exit_tree is called when switching scenes in tool mode

Godot version:
3.2
OS/device including version:
PopOs 19.04
Issue description:
Switching scenes in the Godot Editor causes _exit_tree() to execute in tool scripts. This is very bizarre considering the same doesn't happen when closing a scene. I use _exit_tree() to clear up my plugin's meta data* whenever my plugin node is moved or deleted and _exit_tree being called whenever scenes are switched is very bad because it ends up resetting that meta data when it was still needed. It would be very helpful if _exit_tree is not called when switching tabs or if there were some way to tell the difference between the node being moved, the node being deleted, and the scene being switched.
*My plugin node needs to set meta data in a node higher in the tree and the meta data needs to be removed whenever my plugin node is moved or deleted.
Steps to reproduce:

Add a tool script to a node.
In that script, override the _exit_tree function.
Add a print statement (or any other means of telling when _exit_tree is called) to _exit_tree.
Switch to a different scene and check the Output terminal for if the print statement was called.

Minimal reproduction project:
Exit Tree Error.zip

On a side note, my plugin node needs to add meta data to a node higher in the tree because of this issue #12990.

This is not a bug. I think switching causes that because Godot internally removes your scene from the tree and then adds the other one. And indeed _exit_tree may also be called if you reparent your node, not just when switching scenes. Closing a scene not calling _exit_tree is quite weird though.

I'll try the notification thing, I haven't really used them before because they seemed to be the same as signals. If it doesn't end up working I have written the two paragraphs below explaining what my code does.
 I'm essentially recreating the logic engine from that game to make level design easier. If you had a button scene and you wanted the button to work with this system you would add an IOHub as a child of that button scene, then set up an Output node as a child of that IOHub that activates whenever the button is pressed. You would then be able to connect the Output of that button to the Input of something that you set up earlier, like a door, and whenever the button's Output is activated the Input would be triggered and run a function that does something, like open the door.
*If you aren't familiar with Little Big Planet this short video demonstrates the idea: https://www.youtube.com/watch?v=0o9ADwmJwJQ
The problem is getting the engine to save the state of when an Output is connected to an Input. Variables inside an instanced scene aren't saved when changed so I have to store the information somewhere else. The best answer I could come up with is to save that information to the parent of the button as meta data. It works pretty well, except for when you delete or move the button in the tree. The information would stay in the button's old parent cluttering the scene file with data that isn't being used. The user of the engine can't even remove the clutter manually because meta data is not shown to them. To fix this I decided to override _exit_tree() in the Output node to delete the meta data from the button's old parent, but _exit_tree() is also called whenever you switch scenes so it ends up deleting all the connections you make between Inputs and Outputs.

Notifications wouldn't work because the notifications that would be relevant to Outputs or even to the IOHub would be received by the IOHub's parent (which would be the button from my previous example) with no way for the IOHub or Output to receive that information without manually adding code to the button that gives it to them. I would prefer if I could get the IOHub or Output to handle everything without having to manually write new code for every case they would be used in.

Closing, because this isn't a bug. Also

This is very bizarre considering the same doesn't happen when closing a scene.

seems to be no longer true.


[Image watermark target detectiont]

Can we add object detection function to recognize objects or watermark logos in the image, dynamically identify the watermark position in the image, automatically remove it, or pass in a watermark logo to recognize the position and automatically remove it

i also want to know.


Add Architecture of Open Source Applications (AOSA) Books

There exists public free book series under the name "Architecture of Open Source Applications", I think it will be great if we added them to this repo. The official website for the books buy them but some some of them such as "500 lines or less" are open source and can be built as a pdf file from the source code.

Good Idea

PUMP


Playlist function not fully intergrated.

#Notes
The playlist function exists but has not been implemented yet due to unprocessed links being sent to play causing crashes

Moving this to discord notes.


rabbitmq-ha: Fix regressions in README.md

What this PR does / why we need it:
customConfigMap was renamed to existingConfigMap in #4401, so update README.md accordingly.

/assign @foxish

/assign @unguiculus

I've resolved the conflicts. Any chance we can get this merged?

/ok-to-test

/lgtm

I've resolved the conflicts. Personally, I find the table easier to edit when it's formatted this way. I've also added a couple of potentially helpful links (configmap.yaml).
With that said, I agree with @steven-sheehy in that one of this PR and #7161 should be merged.

/lgtm

/retest

Fixed the version.

/lgtm


KeyError: 'glasbey_category10' -

With hvplot version : and colorcet version 0.9.1
I have a KeyError :
KeyError: 'glasbey_category10'
I check in https://github.com/pyviz/hvplot/blob/master/environment.yml
After update, it runs OK.

It looks like some of the hvplot options default to glasbey_category10 from colorcet, so yes, I do think colorcet is now a dependency.

Closed by #356


How to scan real scenes

How can I scan the 3D model of the environment?

Below is a brief answer, but please note that in Gibson our goal is turning some already scanned and processed places into a virtual perceptual environment. Our focus is not providing a streamlined tool for scanning new buildings, as that's a sufficiently separate problem. We recommend using the hundreds of spaces already included in Gibson database, as its scale should (hopefully) be sufficient for developing agents that generalize to novel spaces.
However, Gibson's format of the asset data of a space (i.e. each folder in gibson/assets/dataset/) is straightforward. As long as you scan a new space and store it following the same format, Gibson will be able to open it. Some of the requirements are listed below. You can scan the space using one of the existing scanning devices, e.g. Paracosm, DotProduct, Matterport, etc. Gibson is agnostic to scanning hardware.

you need to store the RGB images of the space as equirectangular panoramas in panos/rgb folder. Note the resolution and aspect ratio.
For each RGB panorama, you need a corresponding depth panorama saved in pano/mist folder.
you need a mesh containing the 3D geometry of the space in obj format saved as mesh.obj and a 90 degree rotated version of it saved as mesh_z_up.obj. The first one is used for image rendering and the second in physics engine.
you need to save the camera pose information for each image in camera_poses.csv and in individual files in panos/points folder.
you need to preserve the naming convention of the existing asset folders.

Hi, thank you for your answer. I want to know if there is a depth factor for the corresponding depth panorama ?
https://github.com/StanfordVL/GibsonEnv/issues/139


load HTTP Prompt environment from command line

It would be convenient to be able to load a HTTP Prompt environment from the command line so as to launch http-prompt with a predefined context without requiring any manual input within http-prompt. Currently the only way to fully load such an environment is to execute exec /path/to/project.hp interactively.
Loading an environment in such a way would allow the creation of aliases
I'm thinking of 2 different ways to do this:

Option 1:
add a --env cli parameter to would take the environment file to load as parameter
http-prompt --env /path/to/project.hp
Option 2:
support receiving data from stdin
cat /path/to/project.hp | http-prompt

Each of these option would make it possible to create aliases:

Option 1
alias http_project_prod='http-prompt --env /path/to/project_prod.hp
alias http_project_test='http-prompt --env /path/to/project_test.hp
Option 2
alias http_project_prod='cat /path/to/project_prod.hp | http-prompt'
alias http_project_test='cat /path/to/project_test.hp | http-prompt'

Please let me know what you think of it
I'm willing to implement it myself if

I did a bit of research already and the option 2 might turn to be more tricky.
The prompt-toolkit doesn't support piping (see https://github.com/jonathanslenders/python-prompt-toolkit/issues/502) and will actually "crash" in such a case
We could surely use the snippet mentioned in that previous issue
if not sys.stdin.isatty():
    data = sys.stdin.read()

and load the context from this data but the prompt still exits (from  https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/prompt_toolkit/input.py#L67), unless we overwrite stdin afterwards sys.stdin = sys.stdout
It looks hacky and I don't know if that would cause issues...
Probably the other option would be not to use the prompt shortcut but to build our own CommandLineInterface instance (as mentioned in http://python-prompt-toolkit.readthedocs.io/en/master/pages/reference.html#module-prompt_toolkit.shortcuts)
So if you're ok with the option 1 of the --env cli parameter, it should be much easier to implement I believe

I tried it before, receiving data from stdin in a prompt-toolkit app is indeed not an easy thing to do. So I think we can add a --env option in the cli. Free feel the implement it. Thanks!


Implement retry for user deletion

Implementing retry for user deletion due to Graph API inconsistency when deleting a user right after creating it.
The API will return a 200 status code on the GET request indicating that the user has been created. However if you call the DELETE endpoint right after, it will return a 404 because it did not have time to spread user creation on API nodes.
After discussion with @manicminer, implementing retry here seems to be the cleaner way to handle this.
Maybe we should try to implement a proper retry mechanism in the future in the performRequest function as it only handles retries on rate-limiting related status codes for now.

I was passing by out of curiosity and have the following question/observation. (not a critique, but curious to get your opinion).
Short version:
Does it have to be an SDK responsibility to handle such kinds of scenarios or end-user responsibility? i.e., a user is aware of the eventual consistency model of Azure AD and has prepared retries/failover on his/her side?
Long version:
We have a similar situation. We are using hamilton to create a service principal, and right afterward, we call azure-sdk to create role assignments. Unfortunately, we often get 404, as the service principal write hasn't been replicated to all read replicas. So we need to perform a retry on our side for a couple of seconds. Following the suggested approach in this PR, it would be nice to have a similar retry in the CreateRoleAssignment() in azure-sdk. But does it have to be an SDK responsibility?

Hello @tsologub, thanks for giving out your opinion.
For me, this need to be implemented at the SDK level for couple reasons:

A SDK is designed to be the interface between an existing API and an end-user (go developer in our case). To me, its role is to deliver consistent and viable services or functions to the end-user so that he/her does not have to handle specific problems caused by the API itself.
The SDK is often developed by people either working on the API or knowing it pretty well to identify where the weaknesses are. I would guess that these people are in the best position to fix these problems.
If this was an end-user responsibility, these kinds of problem would have to be fixed on every app that is using the SDK. I'd rather fix them upstream so that we don't have to think about these issues. I reckon this SDK is mostly used by the azuread terraform provider so we could fix it there, but I'm also thinking about other people wanting to use this SDK directly in their app.

I think you pointed out the real problem we both encountered. On most cases, operations are not spread on Azure read replicas quick enough or at least the API is not making sure that they have been properly replicated before responding. What is really awkward to me is that if you execute a GET right after the CREATE one has been executed, the Graph API will always return a 200 while the information is not clearly spread on enough nodes. I guess the proper way would be to fix this at the Graph API level but since we don't have control over it, to me this needs to be fixed here.
More generally, I think we need to have the choice to implement a client with or without a retry mechanism so that it will cover most use cases.
I would love to here @manicminer 's take on this since this SDK is developed by him and maybe he does have a better idea.

Unfortunately or luckily, depends on how you look, the Azure AD team went with the eventual consistency model instead of strong consistency.

On most cases, operations are not spread on Azure read replicas quick enough

They will be spread eventually.

the API is not making sure that they have been properly replicated before responding

This would call strong consistency. And every interaction would work much slower. i.e., AD would have to ensure that every read replica gets an update before responding to the client.

What is really awkward to me is that if you execute a GET right after the CREATE one has been executed, the Graph API will always return a 200

For that node, where your request landed, the write was successful; that is why AD responds as 200.

I guess the proper way would be to fix this at the Graph API level, but since we don't have control over it, to me, this needs to be fixed here.

I believe it is not the API level problem; it is Microsoft's deliberate decision. To achieve this, Microsoft must completely redesign the Active Directory.

I am getting your point. It would be nice to have such retries on the SDK level, especially in the GET scenarios. i.e., if the first response is 404, try a couple of times more. But I can't imagine how this could be implemented for the GET but with lists.
An example. I have a group, I delete this group, and now I want to list all deleted groups. Will my deleted group be on that list? - It depends on which node my ListeDeleted() request will hit, the updated one or not?
Maybe the retries that you are talking about don't have to be implemented for every GET, only for some. I don't know, simply thinking out loud.


Pub install fails with 'Could not find source named sdk'

This issue was originally filed by @butlermatt

I just recently did a fresh install on my system. Importing one of my old projects (https://github.com/butlermatt/dart_koans) I tried to do a "pub install" and received the following error:
~/src/dart_koans$ pub install
Could not find a source named sdk.
Dart Editor version 0.4.5_r21094
Dart SDK version <IP_ADDRESS>_r21094
Pubspec looks like this:
name: dart_koans
version: 0.0.1
author: Matthew Butler
dependencies:
  unittest: any

This issue has been moved to dart-lang/pub#509.


Add support for expr_options field

Google provider recently fixed bug that caused all rules to be recreated - https://github.com/hashicorp/terraform-provider-google-beta/pull/8622
That seems to work fine. However this module still wants to recreate all rules to remove all expr_options which look to be added automatically
For example our plan shows
It will delete this rule
      - rule {
          - action      = "deny(403)" -> null
          - description = "Node JS attack" -> null
          - preview     = true -> null
          - priority    = 10 -> null

          - match {
              - expr {
                  - expression = "evaluatePreconfiguredWaf('nodejs-v33-stable', {'sensitivity': 4})" -> null
                }
              - expr_options {
                  - recaptcha_options {
                      - action_token_site_keys  = [] -> null
                      - session_token_site_keys = [] -> null
                    }
                }
            }
        }

And replace it with
      + rule {
          + action      = "deny(403)"
          + description = "Node JS attack"
          + preview     = true
          + priority    = 10

          + match {
              + expr {
                  + expression = "evaluatePreconfiguredWaf('nodejs-v33-stable', {'sensitivity': 4})"
                }
            }
        }

These are essentially the same
Can we add support for expr_options fields? Or ignore them so these dont get recreated every time
This only seems to affect the pre_configured_rules rule type

Have the same issue. Just fixed the perma diff upgrading google-beta provider to v6.11.1 but have been caught by this expr_options. I my case affects "custom_rules".

@tknodell-recurly according to the documentation expr_options is an optional variable. Issue #18596 was created for it. Seems like they fixed preconfigured_waf_config issue but they havnt fixed recaptcha_options


Can't  upgrade to dbeaver-ce 5.1.3 on  ubuntu 18.04

Hi, i tried to upgrade  to dbeaver-ce 5.1.3 on ubuntu 18.04,  i have installed 5.1.2,  but   i only got dbeaver-ce is already the newest version (5.1.2~ubuntu16.04).
i did  apt update; apt upgrade

Hi,
Same issue. The PPA doesn't seem to be up to date with dbeaver-ce 5.1.3 for Ubuntu 18.04 (bionic beaver).
Regards.

Sorry, indeed we didn't update PPA for all series. Fixed.
Thanks for report


e2e arbitrary passthrough fix

Testing https://github.com/cosmos/ibc-apps/pull/71 PFM fix

My only question is if we really do need complex PFM test for examples with ictest?
I would feel its better to test this complexity in just in ibc-apps, and have a single hop transfer to show it works here, to eliminate flakey test (maybe using Juno's repo vs gaia is better, will see)

I'm actually all in favor of removing some of these examples that have now moved into other repos closer to the code bases that they seek to exercise. Providing links to complicated interchaintest examples in the wild somewhere in the docs should be sufficient

Per the above comment and #772, closing


[Ember-Migration] Fix Navbar

Issue: Closes https://github.com/Real-Dev-Squad/website-www/issues/727
What is the change?

fixed the height of navbar

Before / After Change Screenshots
Before :

After :
Added shimmer effect
https://github.com/Real-Dev-Squad/website-www/assets/107163260/b50b500c-190b-4c1a-a8de-74d3bdc5c0a7
"sign-in button horizontally align and dropdown clickable"
https://github.com/Real-Dev-Squad/website-www/assets/107163260/f5ccc29e-df66-46f6-a7c1-bfee26584460
https://github.com/Real-Dev-Squad/website-www/assets/107163260/dfae7507-5393-40bc-b129-eda163fee4ae

Reference PR - #749


The scaning doesn't look like ending anytime soon.

The scaning doesn't look like ending anytime soon...
Scan finished as soon as I deleted node_modules with many files.
But I need it...
I created .imdoneignore but it did not improve...
the file content
node_modules/

Thanks you!

Try version 2.3.0.  I moved the file watcher to a background process.

#234


Fix get_class_at

Description
get_class_at is implemented but wants to return a Sierra Program. We do not deal with sierra yet so it returns a default value.
Acceptance criteria

get_class_at returns an actual contract class.

Let me try something for this one !

You need to wait for #307 to be merged

can i try this one?

can i try this one?

Already taken by @0xEniotna sorry!


Create utility Node type guard checks class

This should be done using code generation. It's easy to forget to add methods for these.

Code generate a mixin that contains all the isX() methods.
Apply the mixin to Node.
Write a script that ensures all the mixins return true for these methods.

Edit: I'm having second thoughts about this because it would spam the auto-complete. I'm thinking it might be better to put this on a utils class.

import Ast, {TypeGuards} from "ts-simple-ast";

// ...

if (TypeGuards.isEnumDeclaration(node)) {
    // node is EnumDeclaration in here
}

if (TypeGuards.isBodiedNode(node)) {
    // node is Node & BodiedNode in here
}

This class should be completely code generated so that no unit tests are required (code generation is low risk for mistakes) and so that it doesn't need to be maintained (because maintaining it would be a pain!)

Make sure to search the code for this issue to find places that should be updated once implemented.

Maybe https://github.com/ajafff/tsutils could be used here?

@frederikschubert that could be used in conjunction with this library on the wrapped node's compilerNode properties.
I managed to implement this by code generating this file based on having it look at the structure of the existing code:
https://github.com/dsherret/ts-simple-ast/blob/ce0c36e80798d0c689a99d67b7f4baa2311bc86b/src/utils/TypeGuards.ts
...so the file will automatically be updated based on changes to the library.
Anyway, this is implemented in 0.62.0.


[FLINK-18356][Azure] Enforce memory limits for docker containers

What is the purpose of the change
I took over after #15509.
This PR imposes hard limits on the memory available to docker containers. With the limits in place in case of an increased memory consumption docker will kill the java process, instead of the system killing the docker container, which should result in more insights into what is really going on.
Brief change log

Added hard memory limits to docker containers (6GB + no swap)
Decreased the number of forks for table tests (Table tests & flink-tests fail reliably with the limits in place. It is worth investigating separately if we can do anything about that)

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

@flinkbot run azure


Tensorboard logging

Earlier versions you could do logging like this:
python train.py --num-workers 2 --env-id PongDeterministic-v3 --log-dir /tmp/pong
then starting Tensorboard and monitor progress.
It's probably just me, but with baselines.run I can't find a kwarg to specify the log directory/name or activate logging. And I haven't found any recent posts on Tensorboard / openai either.
There is a logger.py file, and a results_plotter.py. Probably I activate the logger with some kwarg, but how?
And is Tensorboard totally out of the picture now?
Kind regards

you need to set the OPENAI_LOG_FORMAT and OPENAI_LOGDIR environment variables, e.g.,
export OPENAI_LOGDIR=....your_path...

exactly as @jramak has said :) I'll keep this open to add instructions on that into README

Thanks. That would be very helpful!
I really appreciate the approachability and helpfulness of you guys!
On 4 September 2018 at 22:33:32, pzhokhov<EMAIL_ADDRESS>wrote:
exactly as @jramak has said :) I'll keep this open to add instructions on that into README
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

nevermind, got it :)


remove subquery overhead for non-subqueries

Scope & Purpose
Improve performance of all AQL queries that are not making use of subqueries.
Previously, all AqlItemBlocks stored the current subquery depth in register 0, regardless of whether subqueries are used or not. This is wasteful for multiple reasons:

initialization and destruction of AqlItemBlocks takes longer than necessary
more memory is required than necessary
the subquery depths were stored as AqlValue, which can have any type, but in fact only small numeric values will be used

This PR moves the management of subquery depths in an AqlItemBlock into a private helper class of AqlItemBlock. Storage for subquery depths is acquired lazily and only when needed. The _data attribute of an AqlItemBlock now has the correct sizes again (_nrItems * _nrRegs), without an additional column for subquery registers. That also slightly simplifies the arithmetic for fetching AqlItemBlock contents at a certain position.
Subquery depths are currently stored as uint16_t values, allowing for a nesting of 65,534 subqueries. That seems to be more than enough, and we may even reduce this to a uint8_t-based storage.
Initial performance tests I ran show about 10% performance improvement for some non-subquery queries, so this looks very promising.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as shell_server_aql, gtest.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11322/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11329/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11338/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11344/

Tests blue


support for line numbers

Is there any support in this module to print line numbers in the output? If not this is a feature request.

Can you be more specific as to where you are looking for line numbers? Do you mean line numbers in a source listing? Or something else?

Office Writer and MS Word and LaTex have an option to number non-blank lines in the left margin of a page. It could even reset the count to 1 with each page. Another goode is to print the line number only at n lines (like 3 or 5). My particular need is just a straight number from the first to the last line.

I've never seen or used line numbering used in the output document. Is this for review/auditing/reference purposes?
In theory this is possible, but it's extremely difficult given how the Prawn API works. It doesn't provide a per-line callback when writing text. (A better PDF library would surely make this a lot simpler, as I've learned from experience using Prawn).

Yes, it is for review purposes.
I failed with asciidoc -b odt (broken output), now trying asciidoctor-latex. Not sure if docbook could do the trick, inital research showed no hint.

I would suggest to do the review on the source instead of the rendered output. I do PR and code review of asciidoc files every day. The rendered output is available for reference and convenience of reading but the feedback is given in the github pull request based on the source..

I have been arguing for this in a number of working groups an communities, but most people just do not take up text/guthub based workflows, sticking to word/excel/pdf/email. This is all work in the IT sector.

I know... so sad. If you are in the tech sector... just learn to use the proper tools. But alas..  good luck @rhoerbe

@rhoerbe: I am using Python to pre-process the text before using ascii-doctor.
Let me know if you need such a script as I have not needed it in the past.
I use coderay though and I agree that it is good to have this function available for the whole text or specific blocks of text.

I would appreciate if you would share your script.

https://github.com/nvdl/pyasciidoc
We can add more functions as scripts.
The concept is to have modules chained by asciidoc directives to pre-process the text before it is converted to PDF.
Now, there is only one module.
I have done some basic testing.

Hi guys. Let me vote for this feature.
In some cases, it is very useful to have line numbers every 5 lines for documentation, for the purposes of easily referencing to specific parts.
One example can be seen here: https://www.nmra.org/sites/default/files/s-9.2.1_2012_07.pdf

Unfortunately, I'm nowhere near as compenent in this field as is required...

I understand. That was a general invitation for anyone following this thread.

I have documented how to add line numbers to paragraphs using an extended converter. You can find the example code at the following location: https://github.com/asciidoctor/asciidoctor-pdf/blob/main/docs/modules/extend/examples/pdf-converter-numbered-paragraphs.rb This example, as well as numerous others, will be included in the documentation for Asciidoctor PDF 2.0.0 when it is released.
Given that the rules for where to add line numbers can vary widely, I think this is best left up to an extended converter. If it becomes clear that a majority of users agree on what should be numbered and how, we can consider bringing that code into the primary converter.

@mojavelinux
I have read through the documentation. Adding numbers to a block is possible and trivial.
Applying this to the whole document is not supported upstream.
A solution does not seem trivial, but possible. There is a link to an extended converter in the mentioned issue. Normally that would be trivial to call with something like  asciidoctor-pdf -r ./extended.rb file.adoc
But we do not call the program directly. It is automated after site generation. I tried adding this option to the antora-assembler.yml file, but it does not work. It might be due the fact that it is called with bundle exec.
How can the extended converter be used with the antora pdf extension? How can the antora assembler be configured for this? This does not seem to be covered in the current documentation. Please refer to me the relevent source if I am missing something.

I've offered what information I can offer here. If you need further assistance, please direct your questions to the project chat. Since you are taking about Antora, I think the Antora chat at https://chat.antora.org is the most appropriate place.


Retain comments

I'm not sure how this would work but, since the distinguishing aspect of jsonc is the comments, it would be nice if the comments would be retained when reading in a jsonc file.  That way, you could read in a jsonc file, change some data, and write it back out.  As is, you lose the comments.

ive looked at like 5 different ones for python and none of them preserve the comments :<


How i can get auto selected coming from database

Hello, Is there any options to selected automatically coming from database .
I passed my single select key as an array but it is not being selected. Should i need to trigger once i pass the value to state ?

When i pass direct value to state then it get selected but when i pass in multiselect selected items then it didn't being selected

Thanks

how do you fix it?

how do you fix it?

You can add unique id as a string
eg. if you have multiple id in a array oldids= [{id:1,name:'x'},{id:2,name:'y'}]
just get all ids as a string in a array =
let newIds = oldIds.map(item=>item?.id.toString())
now pass newIds in selected props
and it works


Getting  AuthorizationPermissionMismatch issue while migration

While running the application I am getting the following Exception x-ms-error-code: AuthorizationPermissionMismatch.
I have given the Storage Blob Data Contributor role myself. I also have an owner role. I am putting just 2 assets for testing in the Media Service Account. Please have a look at the attachment for detailed information on Exception.
Azure Migration Issue.txt

Hi @rajeshspherex2021 , i got the same issue.  Any suggestion here?  Thanks!


rspec fails in assignment 3

When running this command rspec fails. I think this is unintentional.
 |23:30:29| jh |preparation ✗| → docker container run -it your_docker_id/rails_app:v1 rspec
...........F.............

Failures:

  1) ProgressUpdateJob#peform sets the progress to 100 if there are more read pages than pages
     Failure/Error: expect { described_class.new.perform(book.id) }.to change { book.reload.progress }.from(nil).to(100)
       expected `book.reload.progress` to have changed to 100, but is now 115
     # ./spec/jobs/progress_update_job_spec.rb:18:in `block (3 levels) in <main>'

Finished in 1.46 seconds (files took 2.65 seconds to load)
25 examples, 1 failure

Failed examples:

rspec ./spec/jobs/progress_update_job_spec.rb:13 # ProgressUpdateJob#peform sets the progress to 100 if there are more read pages than pages

Oh okay, it fails up until you request it passes in assignment 8. I thought something was wrong intiially, perhaps we should make all specs green at the beginning so that things feel correct initially.
Then again, if you present it to people clearly that there is one failing spec to be expected, perhaps it will be okay during the workshop!

Good call - added it to the assignment.


Only close Step Detail on selecting Step if it's the same Step

Describe the bug
When you click on a Step it opens the Step Detail. If you click it again, it closes the Step Detail. This was meant to be a convenience for the user, however, if the Step Detail is open and I click on a different step, it closes the Step Detail.
To Reproduce
Steps to reproduce the behavior:

Create or upload an KameletBinding with at least two Steps.
Click on one Step. The Step Detail opens.
Click another Step.
The Step Detail closes.

Expected behavior
It should a) keep the Step Detail open, and b) update the data in the Step Detail to show the selected Step's details instead.
Screenshots
No thank you.
Desktop (please complete the following information):
Everywhere
Additional context
For the first part of the problem (the Step Detail closing when it shouldn't), this should be fixable from the /src/components/StepViews.tsx and Dashboard.tsx components, particularly the isPanelExpanded flag. Check the selectedStep state. If it changes and is a different Step, the panel should not collapse. Or, it should only close if the Step clicked is the same as the selectedStep.
The second part should be fixed automatically once the first part is fixed, but this would need to be verified.

Hi @kahboom, could it be possible that this issue is no longer relevant?
At the time of the writing, KaotoUI version v0.6.1-dev has a slightly different behavior as follows:

The user clicks on a step.
The Step Detail opens.
The user clicks on the same step.
The Step Detail stays open.
The user clicks on another step.
The Step Detail stays open, now showing the details relevant for the selected step.

Also, I've prepared the following screencast to showcase the behavior:
Screencast from 2023-02-08 16-59-49.webm
That being said, I kinda like this behavior, and probably would make sense to close the Step Details upon clicking on an empty area of the canvas as well :thinking:


Fixed authority ids being displayed on search page instead of their display value

References

Fixes #2804
Fixes #2813

Description
This PR fixes the problems with authorityKeys being displayed in the facets and the labels. Previously the selected FacetValues in the search sidebar were defined by going over all the FacetValues that were received from the backend and looping over all of them and checking if they were present in the url. This has now been simplified by simply using the appliedFilters array instead. The labels were also refactored, since they displayed the filter values from the url, which meant that they always showed authority ids instead of their display value/label.
Instructions for Reviewers
List of changes in this PR:

RouteService & SearchConfigurationService : These services have been updated to return an Observable of all the route Params except for a certain filter/value/operator combination. This logic was previously implemented in slightly different ways on multiple places: Search facet values, search facets applied filters, search facet suggestions and in the search labels. Moving this from the components into a common service will now ensure that they all behave in the same way and it results in less duplicate code.
SearchFacetFilterComponent#applyFilterValue: This method has been simplified and the wrong return type has been fixed (it was never a PaginatedList<FacetValue>[] but actually a FacetValues). It will now also emit the AppliedFilters to the SearchComponent.
SearchComponent: With the changes in SearchFacetFilterComponent#applyFilterValue it is now possible to pass along all the AppliedFilters to the labels (by doing it this way it also simplifies the way the search labels work since now the only need to display the given @Input()).
SearchLabelLoaderComponent & SearchLabelRangeComponent: Currently the backend still uses equals as the operator for range filters, because this new PR uses the AppliedFilters returned from the backend instead of the parameters who start with an f. in the url, the label would have looked like this: Date: [2020 TO 2024]. By setting the operator of range filters to range I was able to make the loader render the SearchLabelRangeComponent which can correctly split the [2020 TO 2024] value into 2 separate labels. The quick fix for this was to override the operator with range in Angular in the SearchRangeFilterComponent. This should however ideally be fixed in the backend but I first wanted to get feedback on this
https://github.com/DSpace/dspace-angular/blob/10dfedd0a2ac5ced99086335f06d8895fe5c4c09/src/app/shared/search/search-filters/search-filter/search-range-filter/search-range-filter.component.ts#L123-L126

Guidance for how to test or review this PR:

Enable authority for dc.contributor.author by:

Uncommenting these lines in authority.cfgplugin.named.org.dspace.content.authority.ChoiceAuthority = \
org.dspace.content.authority.SolrAuthority = SolrAuthorAuthority

choices.plugin.dc.contributor.author = SolrAuthorAuthority
choices.presentation.dc.contributor.author = authorLookup
authority.controlled.dc.contributor.author = true
authority.author.indexer.field.1=dc.contributor.author

Add authority to the list of consumers (event.dispatcher.default.consumers) in dspace.cfg

Create an item and fill in the dc.contributor.author with a text value
Create a second item and select the value you filled in in the previous item (you need to create a second item in order for that author to be displayed in the search facets, this is a backend bug I think)

Now test the following things:

Check that the label is now used in both the search facets & the search labels
Check that the pagination still works correctly in the facets
Check that selecting multiple authority values is possible and that you can correctly unselect them too
Check that the date facet & it's labels still work
This PR also fixes a performance bug, when you select the last date range in the date facet, currently the facets & results are retrieved twice, this is now also fixed

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem : Did you still want this considered for 8.0?  If so, could you update this PR to remove the merge conflicts?


[KYUUBI #1867] Support PlanOnlyStatement operation like Spark SQL engine

Why are the changes needed?
Support PlanOnlyStatement operation like Spark SQL engine.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

@SteNicholas Please check the CI?

@SteNicholas Please check the CI?

@yanghua, sorry for the failure of the CI. I have fixed the problem for the failure. Please review this pull request.

Codecov Report

Merging #1891 (29ba3dd) into master (216dd66) will increase coverage by 0.12%.
The diff coverage is 62.50%.

:exclamation: Current head 29ba3dd differs from pull request most recent head 12dcf76. Consider uploading reports for the commit 12dcf76 to get more accurate results

@@             Coverage Diff              @@
##             master    #1891      +/-   ##
============================================
+ Coverage     59.70%   59.83%   +0.12%
- Complexity      269      341      +72
============================================
  Files           282      292      +10
  Lines         13978    14301     +323
  Branches       1781     1812      +31
============================================
+ Hits           8346     8557     +211
- Misses         4924     5008      +84
- Partials        708      736      +28

Impacted Files
Coverage Δ

...ubi/engine/flink/operation/PlanOnlyStatement.scala
55.76% <55.76%> (ø)

...ine/flink/operation/FlinkSQLOperationManager.scala
85.00% <76.47%> (-6.67%)
:arrow_down:

...ine/spark/operation/SparkSQLOperationManager.scala
83.33% <100.00%> (+0.40%)
:arrow_up:

.../org/apache/kyuubi/engine/trino/TrinoContext.scala
83.33% <0.00%> (-16.67%)
:arrow_down:

...ache/kyuubi/engine/spark/events/SessionEvent.scala
79.16% <0.00%> (-7.79%)
:arrow_down:

...kyuubi/engine/spark/events/EngineEventsStore.scala
80.00% <0.00%> (-6.67%)
:arrow_down:

...uubi/engine/spark/events/SparkOperationEvent.scala
86.48% <0.00%> (-2.41%)
:arrow_down:

...g/apache/spark/kyuubi/SparkSQLEngineListener.scala
86.27% <0.00%> (-1.87%)
:arrow_down:

...src/main/scala/org/apache/spark/ui/EngineTab.scala
70.73% <0.00%> (-1.69%)
:arrow_down:

...rg/apache/kyuubi/engine/trino/TrinoStatement.scala
65.06% <0.00%> (-0.83%)
:arrow_down:

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216dd66...12dcf76. Read the comment docs.

@yaooqinn @yanghua, thanks for your review. I have addressed above comments. Please help to review again.

@pan3793, thanks for your detailed review. I have addressed above comments. Please help to review again.

@pan3793, thanks for your detailed review. I have addressed above comments. Please help to review again.

@pan3793, thanks for your detailed review. I have addressed above comments. Please help to review again.

@yaooqinn, thanks for your review. I have addressed your comments and bugfix the FlinkSQLSessionManager#operSession. Please help to review again.

@yaooqinn @pan3793, could you please help to merge?


fix: delete branch tests

Description
Adding jest and cypress tests for git delete branch feature
Fixes #13616
Type of change

Tests

How Has This Been Tested?
Attached tests.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=318d59eb660c58a9358972c1d45a1b5c55ae8bca

Failing tests

Failing tests


[bug] before*Command env vars use host triple for mobile

Describe the bug
When building for mobile, the provided environment variables will reflect the host OS, not the target OS (e.g. on macOS build for iOS TAURI_PLATFORM will be macos and not ios)
Reproduction

Create a mobile setup
Log the TAURI_TARGET_TRIPLE env var from the vite build config

Expected behavior
No response
Platform and versions
Environment
› OS: Mac OS 13.1.0 X64
› Node.js: 18.12.1
› npm: 8.19.2
› pnpm: 7.24.3
› yarn: 1.22.19
› rustup: 1.25.1
› rustc: 1.66.0
› cargo: 1.66.0
› Rust toolchain: stable-aarch64-apple-darwin
Packages
› @tauri-apps/cli [NPM]: 2.0.0-alpha.1
thread 'main' panicked at 'called Result::unwrap() on an Err value: Error("unexpected character 't' while parsing major version number")', src/info.rs:566:67
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
› @tauri-apps/api [NPM]: tauri-apps
Stack trace
No response
Additional context
No response

Fixed by #6116


Naming: getPath() and getUrl()

I noticed in https://github.com/Laravel-Backpack/basset/pull/20 that we have:
Basset::getAssetPath()
Basset::getAssetUrl()

Wouldn't it make more sense to have
Basset::getPath()
Basset::getUrl()

I mean... Basset reads like asset, right? Everything you do using Basset:: is for one asset.

Yes, I agree!
Will change it 👌

Fixed by https://github.com/Laravel-Backpack/basset/pull/22.


Add FerriteCore and previously used game enhancement mods

What is the problem you're trying to solve with this change?
fix the various performance and memory problems
What do you propose as a solution?
add FerriteCore and other mods from the Austere Caves pack

I know I got a bunch of them already, but it's worth double-checking.  Here are all the performance-enhancing mods from Austere Caves.  I'll double-check to make sure they all make it into Blocky Go Round.

AI Improvements
BetterFPS
Clumps
DynamicView
FerriteCore
FPSReducer

Just reviewed the mod list, that seems to be all of them. Thanks!


Bugfix/change updates

Fix #5 Not handling updates from Facebook Webhooks.
This PR resolves the above issue by implementing the ChangeUpdateEvent and integrating it with the MessageQuickly::CallbackParser to handle the change updates.
Note: I couldn't figure out how the spec/dummy plays into the specs, so I'm not sure the integration is fully tested, although I did add the new event handling into the specs for MessageQuickly::CallbackParser

Let's merge this. 😀
🚀

Right sorry, I forgot 😅


Include ids and types when reading binary

This PR extends OutputReader so ids and types are returned as part of the results. This helps us interpreting the results, since we can easily match with what the result corresponds, by its id or by its type.
We forked the project to be able to get this working and we think it may be interesting to incorporate it upstream and use it from an official npm package from this project.
To make the change we added a test suite for OutputReader.
Note: The CI fails because of this other issue https://github.com/modelcreate/epanet-js/pull/38 All tests pass with that patch applied.

Seems there is a minor linting error but otherwise all looks good.
The Output reader class was created pretty quickly and may not be the greatest for large models as you are extracting everything to a single object.
I'm open to any suggested changes to the way this is approached.

Seems there is a minor linting error but otherwise all looks good.
The Output reader class was created pretty quickly and may not be the greatest for large models as you are extracting everything to a single object.
I'm open to any suggested changes to the way this is approached.

Ups, sorry for the linting error. We assumed the failure was due to the docker image issue and didn't check further. We must have been running the tests in the last commits but not the linter.
I see husky is configured. Do we need to follow any manual steps to have it setup? If that is the case it may help to have them in the README.
Thanks for having this reviewed (and merged) so quickly. :)

Ups, sorry for the linting error. We assumed the failure was due to the docker image issue and didn't check further. We must have been running the tests in the last commits but not the linter.
I see husky is configured. Do we need to follow any manual steps to have it setup? If that is the case it may help to have them in the README.
Thanks for having this reviewed (and merged) so quickly. :)

I forgot to mention the reason why we use OutputReader. We encountered this issue #36 and didn't know what the right workaround was at the time. We may try running steps again with your suggestion. Still, it was interesting (and a bit of a life saver) to work on OutputReader.
Thanks again.

I forgot to mention the reason why we use OutputReader. We encountered this issue #36 and didn't know what the right workaround was at the time. We may try running steps again with your suggestion. Still, it was interesting (and a bit of a life saver) to work on OutputReader.
Thanks again.

@alvarobp-qatium it looks like husky came as part of tsdx which I used as a boilerplate to speed up the development of the library, I will review and add something to the readme so its clearer for everyone.
Issue #36 should be fixed now and it will output as a console warning though I've left it open because there should be a better way of dealing with warnings and returning them to the users.
Happy the OutputReader class was helpful, it was a bit of work initially understanding the binary but once it was done it makes its much simpler to just run the simulation and get all the results in one go.
I'm always open to questions or if you want to discuss further you can also contact me here or by email<EMAIL_ADDRESS>Best of luck with the development of Qatium!

@alvarobp-qatium it looks like husky came as part of tsdx which I used as a boilerplate to speed up the development of the library, I will review and add something to the readme so its clearer for everyone.
Issue #36 should be fixed now and it will output as a console warning though I've left it open because there should be a better way of dealing with warnings and returning them to the users.
Happy the OutputReader class was helpful, it was a bit of work initially understanding the binary but once it was done it makes its much simpler to just run the simulation and get all the results in one go.
I'm always open to questions or if you want to discuss further you can also contact me here or by email<EMAIL_ADDRESS>Best of luck with the development of Qatium!


[Shadowbane Inquisition] Update v 0.1.2

Changes / Comments
v 0.1.2

Degrees of Failure have learned the correct Math
Psykana Powers now have damages options in a list
Psykana Powers now have a choice to roll hit location
you can now put a '+' in the modifier without breaking the roll
all Rolls will take unnaturals into account for Degrees of Success
all Rolls buttons can now be dragged into the Macro Bar

PS: @johnmoney-code have a look at how I did the unnat bonuses
PPS: how do I get the "Sheet Author" badge on my Roll20 Profile?
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Character Sheet Info Roll20 Internal Use only.

Hey there @ChtiKenny , in regards to the badge I will forward your question to the right people. Thanks for all the work you do ;)

Hey @ChtiKenny, just got the answer you were looking for:

~24 hours after a sheet is accepted and merged, if they put their user ID into the sheet.json, your badge should appear. If your haven't received it after a couple of days, you should check your sheet.json, and if it's properly inputted, your should open a ticket.

Cheers,
Miguel

Thanks @mperes, guess I'll have to open a ticket then.
By the way, for approving the sheet, you have the thanks of around ~150 people who use it (possibly more but I couldn't count them all)

That's terrifying, thanks for sharing


Adding Ore Timers in MLM

Someone in my clan chat was complaining that there weren't ore timers on the rocks they've mined in mother load mine.
What could happen is on top of every empty mined vein, we could set a timer and display it like an empty dial getting fuller and fuller until the vein is restored.
Issues that could arise is it may get a bit crowded with a bunch of dials.
EDIT:
Possibly related #4392

Duplicate of #3097


ascii_cmp reads bits in reverse order

in String.v, the function ascii_cmp gives in correct results. For instance it says "a" > "b" but "b" < "c".
This appears to be because it is reading bits from the ASCII representation in the reverse order. The representation stores the least-significant bit first, but ascii_cmp treats the first bit as if it were the most-significant.

Fixed in 876e099

Fixed in 8.4 2caa401


New package: BinomialGPU v0.2.0

Registering package: BinomialGPU
Repository: https://github.com/simsurace/BinomialGPU.jl
Created by: @simsurace
Version: v0.2.0
Commit: a582a7d524632c0f6e3d3bb4f29d6fa73c0369d4
Reviewed by: @simsurace
Reference: https://github.com/simsurace/BinomialGPU.jl/commit/a582a7d524632c0f6e3d3bb4f29d6fa73c0369d4#commitcomment-48363839

@simsurace thanks for your package!  Please, see the message above.  It looks like your package has some syntax errors.
[noblock]

@simsurace Can you delete the https://github.com/simsurace/BinomialGPU.jl repo and register https://github.com/JuliaGPU/BinomialGPU.jl instead?

Yes, that's what I'm planning to do. I will register version 0.2.1 from the new repo. The package should then be passing all tests from BuildKite.

The concern is that if we first register BinomialGPU at https://github.com/simsurace/BinomialGPU.jl, and then we have to change the URL from https://github.com/simsurace/BinomialGPU.jl to https://github.com/JuliaGPU/BinomialGPU.jl, we have to make sure that https://github.com/JuliaGPU/BinomialGPU.jl contains all of the Git tree SHAs that were registered from https://github.com/simsurace/BinomialGPU.jl.
It would be far easier to just register 0.1.0, 0.2.0, and 0.2.1 all from https://github.com/JuliaGPU/BinomialGPU.jl

Superseded by #32298

So do I need to run the registrator again in the respective commits, or what action is required on my part?

Nothing :slightly_smiling_face:  Unless you really want to have also this revision registered

Great, thanks for confirming!


LogoutId/PostLogoutRedirectUri always null in AccountController.Logout after implementing a custom ProfileService and ProfileService.IsActiveAsync returns False

Implementing a Custom ProfileService causes the logoutId and as such the PostLogoutRedirectUri to be null in the AccountingController.Logout methods using IdentityServer4 v<IP_ADDRESS>
When I logout of my MVC project the logoutId, and hence the PostLogoutRedirectUri, is always null if the custom ProfileService.IsActiveAsync method sets context.IsActive = false. However, if I update the code to set the context.isActive = true even when the user has been logged out the logoutId and PostLogoutRedirectUri gets properly and the user is given the option to navigate back to the login form. Nothing else in my code has changed.
public async Task IsActiveAsync(IsActiveContext context)
{
	var userName = context.Subject.Identity.Name?.ToLower() ?? "";
	var user = await _identityDbContext.User.FirstOrDefaultAsync(x => x.UserName.ToLower() == userName);

	//works if I use this code. When this is called at logout it still returns true
	context.IsActive = user?.IsActive ?? true;

	//does not work as expected
	//context.IsActive = user?.IsActive ?? false;
	}

See logs below for the difference when I only change IsActive from false to true at logout. I spent the better part of a day trying to figure out why it was not sending the logoutId.
Logs when context.IsActive = true on logout in custom ProfileService class
----------------
2020-01-01 10:51:58.851 -07:00 [DBG] Processing signout request for 3769914A-7139-479C-8CA2-8EBBA94E7311
2020-01-01 10:51:58.857 -07:00 [DBG] Start end session request validation
2020-01-01 10:51:58.863 -07:00 [DBG] Start identity token validation
2020-01-01 10:51:58.873 -07:00 [DBG] client configuration validation for client 8110a66b-f124-4466-9d4a-b9ef8034916d succeeded.
2020-01-01 10:51:58.873 -07:00 [DBG] Client found: 8110a66b-f124-4466-9d4a-b9ef8034916d / CVRCS MVC Client
2020-01-01 10:51:58.887 -07:00 [DBG] Calling into custom token validator: IdentityServer4.Validation.DefaultCustomTokenValidator
2020-01-01 10:51:58.888 -07:00 [DBG] Token validation success
{"ClientId":"8110a66b-f124-4466-9d4a-b9ef8034916d","ClientName":"CVRCS MVC Client","ValidateLifetime":false,"AccessTokenType":null,"ExpectedScope":null,"TokenHandle":null,"JwtId":null,"Claims":{"nbf":1577901116,"exp":1577901416,"iss":"https://localhost:44379","aud":"8110a66b-f124-4466-9d4a-b9ef8034916d","nonce":"637134979068987676.Zjk0MDYzMTItNGExNy00OTJlLTlhZjctZGQ5YzU2NzRmMmU1Nzg4MTA3NjEtODBiZS00Mzg1LWI1OGMtZmRiZTVjNjViMWI5","iat":1577901116,"at_hash":"8JbHqTl-SpI5Qhlx7yXIyQ","sid":"4bdbcb287299990153b6c96a7439cb6f","sub":"3769914A-7139-479C-8CA2-8EBBA94E7311","auth_time":1577901115,"idp":"local","Permissions":"юёҲҵԖ","amr":"pwd"},"$type":"TokenValidationLog"}
2020-01-01 10:51:58.892 -07:00 [INF] End session request validation success
{"ClientId":"8110a66b-f124-4466-9d4a-b9ef8034916d","ClientName":"CVRCS MVC Client","SubjectId":"3769914A-7139-479C-8CA2-8EBBA94E7311","PostLogOutUri":"https://localhost:44309/signout-callback-oidc","State":"CfDJ8PCdu4DRUCpBiiq5PfHG3ppnFrZUvvdJtlcsPPGAAshrV6rACfRAZTSORX1nCstYFNiKH2mG3sIic6snF5a3aC7klP-Iyd3u2yRzujWcLwQg8nWu1MmyEEivYxL6DRD_dqvLY2AzQ57XfNdefXCwOkRg-RSATB5I3BSeA5ijXC-U","Raw":{"post_logout_redirect_uri":"https://localhost:44309/signout-callback-oidc","id_token_hint":"***REDACTED***","state":"CfDJ8PCdu4DRUCpBiiq5PfHG3ppnFrZUvvdJtlcsPPGAAshrV6rACfRAZTSORX1nCstYFNiKH2mG3sIic6snF5a3aC7klP-Iyd3u2yRzujWcLwQg8nWu1MmyEEivYxL6DRD_dqvLY2AzQ57XfNdefXCwOkRg-RSATB5I3BSeA5ijXC-U","x-client-SKU":"ID_NETSTANDARD1_4","x-client-ver":"<IP_ADDRESS>"},"$type":"EndSessionRequestValidationLog"}
2020-01-01 10:51:58.893 -07:00 [DBG] Success validating end session request from 8110a66b-f124-4466-9d4a-b9ef8034916d
2020-01-01 10:51:58.941 -07:00 [INF] AuthenticationScheme: idsrv signed out.
2020-01-01 10:51:58.993 -07:00 [DBG] Request path /connect/endsession/callback matched to endpoint type Endsession
2020-01-01 10:51:58.997 -07:00 [DBG] Endpoint enabled: Endsession, successfully created handler: IdentityServer4.Endpoints.EndSessionCallbackEndpoint
2020-01-01 10:51:58.997 -07:00 [INF] Invoking IdentityServer endpoint: IdentityServer4.Endpoints.EndSessionCallbackEndpoint for /connect/endsession/callback
2020-01-01 10:51:59.003 -07:00 [DBG] Processing signout callback request
2020-01-01 10:51:59.012 -07:00 [DBG] client configuration validation for client 8110a66b-f124-4466-9d4a-b9ef8034916d succeeded.
2020-01-01 10:51:59.012 -07:00 [DBG] Client front-channel logout URLs: https://localhost:44309/signout-oidc?sid=4bdbcb287299990153b6c96a7439cb6f&iss=https%3A%2F%2Flocalhost%3A44379
2020-01-01 10:51:59.012 -07:00 [DBG] No client back-channel logout URLs
2020-01-01 10:51:59.012 -07:00 [INF] Successful signout callback.
2020-01-01 10:51:59.012 -07:00 [DBG] Client front-channel iframe urls: ["https://localhost:44309/signout-oidc?sid=4bdbcb287299990153b6c96a7439cb6f&iss=https%3A%2F%2Flocalhost%3A44379"]
2020-01-01 10:51:59.012 -07:00 [DBG] No client back-channel iframe urls
2020-01-01 10:51:59.043 -07:00 [DBG] Request path /connect/authorize matched to endpoint type Authorize
2020-01-01 10:51:59.044 -07:00 [DBG] Endpoint enabled: Authorize, successfully created handler: IdentityServer4.Endpoints.AuthorizeEndpoint
2020-01-01 10:51:59.044 -07:00 [INF] Invoking IdentityServer endpoint: IdentityServer4.Endpoints.AuthorizeEndpoint for /connect/authorize
2020-01-01 10:51:59.044 -07:00 [DBG] Start authorize request

Logs when context.IsActive = false on logout in custom ProfileService class
----------------
2020-01-01 10:44:34.633 -07:00 [DBG] Processing signout request for 3769914A-7139-479C-8CA2-8EBBA94E7311
2020-01-01 10:44:34.638 -07:00 [DBG] Start end session request validation
2020-01-01 10:44:34.642 -07:00 [DBG] Start identity token validation
2020-01-01 10:44:34.652 -07:00 [DBG] client configuration validation for client 8110a66b-f124-4466-9d4a-b9ef8034916d succeeded.
2020-01-01 10:44:34.652 -07:00 [DBG] Client found: 8110a66b-f124-4466-9d4a-b9ef8034916d / CVRCS MVC Client
2020-01-01 10:44:34.667 -07:00 [ERR] User marked as not active: 3769914A-7139-479C-8CA2-8EBBA94E7311
2020-01-01 10:44:34.672 -07:00 [INF] End session request validation failure: Error validating id token hint
{"ClientId":null,"ClientName":null,"SubjectId":"unknown","PostLogOutUri":null,"State":null,"Raw":{"post_logout_redirect_uri":"https://localhost:44309/signout-callback-oidc","id_token_hint":"***REDACTED***","state":"CfDJ8PCdu4DRUCpBiiq5PfHG3pqnankM-o-AzLLzYpQZdz9oIj_pD-0AHnS0VOAKIu5r0i-3ZjDrOCWdOZ4ZrYiRSHMvWoo6mnqqSvJgnmwvr1OPN9sND_lOMhbK8NOHX_K5l3ayD1wwicUZLR98AQzBxF1iMKu_9W8Gjzy4MDMRED0D","x-client-SKU":"ID_NETSTANDARD1_4","x-client-ver":"<IP_ADDRESS>"},"$type":"EndSessionRequestValidationLog"}
2020-01-01 10:44:34.673 -07:00 [ERR] Error processing end session request Invalid request
2020-01-01 10:44:36.344 -07:00 [DBG] CORS request made for path: /Account/Logout from origin: null but was ignored because path was not for an allowed IdentityServer CORS endpoint
2020-01-01 10:44:36.362 -07:00 [INF] AuthenticationScheme: idsrv signed out.
2020-01-01 10:44:36.388 -07:00 [DBG] Request path /connect/endsession/callback matched to endpoint type Endsession
2020-01-01 10:44:36.390 -07:00 [DBG] Endpoint enabled: Endsession, successfully created handler: IdentityServer4.Endpoints.EndSessionCallbackEndpoint
2020-01-01 10:44:36.390 -07:00 [INF] Invoking IdentityServer endpoint: IdentityServer4.Endpoints.EndSessionCallbackEndpoint for /connect/endsession/callback
2020-01-01 10:44:36.394 -07:00 [DBG] Processing signout callback request
2020-01-01 10:44:36.414 -07:00 [DBG] client configuration validation for client 8110a66b-f124-4466-9d4a-b9ef8034916d succeeded.
2020-01-01 10:44:36.415 -07:00 [DBG] Client front-channel logout URLs: https://localhost:44309/signout-oidc?sid=54f0cebae9eb43ef1f7c91d91aee54f1&iss=https%3A%2F%2Flocalhost%3A44379
2020-01-01 10:44:36.415 -07:00 [DBG] No client back-channel logout URLs
2020-01-01 10:44:36.415 -07:00 [INF] Successful signout callback.
2020-01-01 10:44:36.415 -07:00 [DBG] Client front-channel iframe urls: ["https://localhost:44309/signout-oidc?sid=54f0cebae9eb43ef1f7c91d91aee54f1&iss=https%3A%2F%2Flocalhost%3A44379"]
2020-01-01 10:44:36.415 -07:00 [DBG] No client back-channel iframe urls

Not sure it's your issue but I had a similar one because I use AddSigningCredentials extension witch replace the EndSessionEndpoint by AutoRedirectEndSessionEndpoint and this endpoint implementation requires a client's Profile property to set the post logout uri as redirect result.
So I set a Profile property in my client configuration and it's back to work.
Properties = new Dictionary<string, string>
{
    [ApplicationProfilesPropertyNames.Profile] = ApplicationProfiles.IdentityServerSPA
}

I opened the issue #22170 in dotnet/aspnetcore in case of it's a AutoRedirectEndSessionEndpoint's bug.


llamacpp tests failing in main

Describe the issue as clearly as possible:
Failures:
tests/generate/test_integration_llamacpp.py .FF.x......FFFFFFFFFFFFFF

All failures have a similar traceback.  Instead we should ensure the tokenizer passed to fsm/guide.py / create_states_mapping() is pickle-able similar to models/transformers.py / TransformerTokenizer

Tests are now passing in main. https://github.com/lapp0/outlines/actions/runs/9281048868/job/25536358249?pr=23
It's not obvious to me which library being changed fixed this. These are the libraries which have new releases since this issue was opened:
2024-05-27T08:30:16: huggingface-hub
2024-05-27T21:45:06: triton
2024-05-28T17:32:52: pydantic_core
2024-05-28T18:38:48: pydantic

Please re-open if you'd like a retrospective analysis.

Issue is occurring again, will investigate a fix.


Drawing sprites with custom alpha values

Good morning,
I have a small question about texture rendering. I want to create a fading effect where a texture get more transparent the more you zoom in to it. Sadly I can't find a function for that. Is it currently possible to draw a texture with a set alpha value?
I've also taken a look at some other tickets and I found this one: #1. Would it maybe be possible to add a fading effect with the color attribute if it would be implemented?
Keep up the good work this is an awesome crate :)

Hey @xFrednet, thank you!

I've also taken a look at some other tickets and I found this one: #1. Would it maybe be possible to add a fading effect with the color attribute if it would be implemented?

That is correct. This is very basic functionality that is currently missing. It should be quite easy to implement, but I haven't got to it because adding color and rotation to each quad instance will potentially affect performance and I want to explore different implementations.

Thank you for the quick response @hecrj. I was hoping that to hear something like that :).
Just out of interest what is the current state on the implementation? Have you already explored some ways?

@xFrednet I haven't really started. I am currently focusing heavily on iced. I will come back to Coffee soon! Most likely once the new winit minor version is properly released.
The easiest way to implement this is to change the quad pipelines in the different graphics backends. Specifically, the instance definitions here and here. Then, it should be a matter of updating the shaders, doing a bit of compiler-driven development and exposing the new attributes in theQuad struct.


Fix konnectivity issue

Fix that context was cancelled before the proxy connection setup
completely which cause by GH-229

Codecov Report
Patch coverage: 66.66% and project coverage change: +0.17% :tada:

Comparison is base (255e6d8) 32.10% compared to head (a25ef3f) 32.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   32.10%   32.27%   +0.17%
==========================================
  Files          41       41
  Lines        6411     6411
==========================================
+ Hits         2058     2069      +11
+ Misses       4064     4052      -12
- Partials      289      290       +1

Flag
Coverage Δ

unittests
32.27% <66.66%> (+0.17%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

pkg/csi/nodeutils.go
41.25% <50.00%> (ø)

pkg/csi/controllerserver.go
57.64% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add useMaxVersion semantics to ConfigrableVersionStrategy

Setting useMaxVersion causes to search for max version visible from current HEAD and use that verion
as base version for calculations instead of just using first version found

thanks I'll review it in the coming days.

Thank you for your contribution and sorry for the delay.
I only removed the sneaky 'compiler' trick in favor of a more standard RuntimeException.


httplib2 dependency needs to be updated to latest version

I ran into https://github.com/google/google-api-python-client/issues/135 today when testing https://github.com/GoogleCloudPlatform/cloud-vision/pull/28. Pip installed an old version of httplib2 when I installed the google-api-client-python (and recursively oauth2client). Upgrading my local httplib2 version fixed the issue.
$ python3 label.py ../../data/label/cat.jpg
Traceback (most recent call last):
  File "label.py", line 78, in <module>
    main(args.image_file)
  File "label.py", line 67, in main
    response = service_request.execute()
  File "/usr/local/lib/python3.4/dist-packages/oauth2client/util.py", line 137, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/usr/local/lib/python3.4/dist-packages/googleapiclient/http.py", line 755, in execute
    method=str(self.method), body=self.body, headers=self.headers)
  File "/usr/local/lib/python3.4/dist-packages/googleapiclient/http.py", line 93, in _retry_request
    resp, content = http.request(uri, method, *args, **kwargs)
  File "/usr/local/lib/python3.4/dist-packages/oauth2client/client.py", line 622, in new_request
    redirections, connection_type)
  File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 1120, in request
    headers = self._normalize_headers(headers)
  File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 1088, in _normalize_headers
    return _normalize_headers(headers)
  File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 194, in _normalize_headers
    return dict([ (key.lower(), NORMALIZE_SPACE.sub(value, ' ').strip())  for (key, value) in headers.items()])
  File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 194, in <listcomp>
    return dict([ (key.lower(), NORMALIZE_SPACE.sub(value, ' ').strip())  for (key, value) in headers.items()])
TypeError: sequence item 0: expected str instance, bytes found

$ pip3 install --upgrade google-api-python-client
Requirement already up-to-date: google-api-python-client in /usr/local/lib/python3.4/dist-packages
Cleaning up...

$ sudo pip3 install --upgrade httplib2
[sudo] password for swast:
Downloading/unpacking httplib2 from https://pypi.python.org/packages/source/h/httplib2/httplib2-0.9.2.tar.gz#md5=bd1b1445b3b2dfa7276b09b1a07b7f0e
  Downloading httplib2-0.9.2.tar.gz (205kB): 205kB downloaded
  Running setup.py (path:/tmp/pip_build_root/httplib2/setup.py) egg_info for package httplib2

Installing collected packages: httplib2
  Found existing installation: httplib2 0.8
    Not uninstalling httplib2 at /usr/lib/python3/dist-packages, owned by OS
  Running setup.py install for httplib2

Successfully installed httplib2
Cleaning up...

$ python3 label.py ../../data/label/cat.jpg
Found label: cat for ../../data/label/cat.jpg

@dhermes @jonparrott Please take a look.

The version is required to be >=0.9.1 in setup.py (that was the version that finally made Python 3 work). That's literally all we can do.

Seems like we should bump it to >=0.9.2 instead of >=0.9.1 ?
On Thu, Feb 25, 2016 at 10:17 AM Danny Hermes<EMAIL_ADDRESS>wrote:

The version is required to be >=0.9.1 in setup.py
https://github.com/google/oauth2client/blob/4b0a5edd47142a02e5bf585d8009195a29036449/setup.py#L35
(that was the version that finally made Python 3 work). That's literally
all we can do.
—
Reply to this email directly or view it on GitHub
https://github.com/google/oauth2client/issues/441#issuecomment-188916026
.

It won't prevent whatever caused httplib2 0.8 in the report though. It's fine with me to upgrade to the latest version, but the only difference between 0.9.1 and 0.9.2 is to "Fix incorrect ResponseNotReady exceptions, retry on transient errors." (there were also README changes between the releases).

Interesting. I'm wondering how he ended up with 0.8 in this case.
On Thu, Feb 25, 2016 at 10:25 AM Danny Hermes<EMAIL_ADDRESS>wrote:

It won't prevent whatever caused httplib2 0.8 in the report though. It's
fine with me to upgrade to the latest version, but the only difference
between 0.9.1 and 0.9.2 is to "Fix incorrect ResponseNotReady exceptions,
retry on transient errors." (there were also README changes between the
releases).
—
Reply to this email directly or view it on GitHub
https://github.com/google/oauth2client/issues/441#issuecomment-188918712
.

I feel like pip install just says "meh" when already installed? Solution: always use pip install --upgrade.
The google-api-python-client says httplib2>=0.8,<1 is cool so --upgrade should've given 0.9.2?

But shouldn't oauth2client's requirement of >=0.9.1 have been enough for
pip to upgrade it?
On Thu, Feb 25, 2016 at 10:31 AM Danny Hermes<EMAIL_ADDRESS>wrote:

I feel like pip install just says "meh" when already installed? Solution:
always use pip install --upgrade.
The google-api-python-client says
https://github.com/google/google-api-python-client/blob/e8ed9ea1aa4e93ccef9afc8483818df43f78ddc8/setup.py#L66
httplib2>=0.8,<1 is cool so --upgrade should've given 0.9.2?
—
Reply to this email directly or view it on GitHub
https://github.com/google/oauth2client/issues/441#issuecomment-188920272
.

I don't know ¯_(ツ)_/¯

As long as we're all on the same page. Hah.

@tswast Can you reproduce this in a virtual environment? (I'm going to try too.)

I went out of my way to try to make it work and it still doesn't:
$ virtualenv venv
$ source venv/bin/activate
(venv) $ pip freeze
wheel==0.29.0
(venv) $ pip install httplib2==0.8.0
(venv) $ pip freeze
httplib2==0.8
wheel==0.29.0
(venv) $ pip install oauth2client
(venv) $ pip freeze
httplib2==0.9.2
oauth2client==2.0.0.post1
pyasn1==0.1.9
pyasn1-modules==0.0.8
rsa==3.3
six==1.10.0
wheel==0.29.0
(venv) $ pip install --ignore-installed httplib2==0.8.0
(venv) $ pip freeze
httplib2==0.8
oauth2client==2.0.0.post1
pyasn1==0.1.9
pyasn1-modules==0.0.8
rsa==3.3
six==1.10.0
wheel==0.29.0
(venv) $ pip install --upgrade google-api-python-client
(venv) $ pip freeze
google-api-python-client==1.5.0
httplib2==0.9.2
oauth2client==2.0.0.post1
pyasn1==0.1.9
pyasn1-modules==0.0.8
rsa==3.3
simplejson==3.8.2
six==1.10.0
uritemplate==0.6
wheel==0.29.0

@tswast maybe you have an old version of pip?

Yeah, maybe. I'm using the one bundled with Ubuntu 14.04.

Hmmm... Looks like this is the same pip version within the virtualenv. I'm not sure why I can't reproduce the issue in a virtualenv.
$ pip --version
pip 1.5.4 from /usr/local/google/home/swast/src/vision/python/label/env/lib/python3.4/site-packages (python 3.4)

I'm trying to reproduce on a new GCE instance, but can't either.
$ sudo apt-get -qqy update
$ sudo apt-get -qqy upgrade
$ sudo apt-get -qqy install python3-pip git
$ git clone https://github.com/GoogleCloudPlatform/cloud-vision.git vision
$ cd vision/python/label

$ cat requirements.txt
google-api-python-client>=1.3.1
$ sudo pip3 install -r requirements.txt

$ pip3 freeze
chardet==2.2.1
colorama==0.2.5
command-not-found==0.3
google-api-python-client==1.5.0
html5lib==0.999
httplib2==0.9.2
language-selector==0.1
oauth2client==2.0.0-post1
pyasn1==0.1.9
pyasn1-modules==0.0.8
pycurl==7.19.3
pygobject==3.12.0
python-apt==<IP_ADDRESS>ubuntu2
requests==2.2.1
rsa==3.3
simplejson==3.8.2
six==1.10.0
ufw==0.34-rc-0ubuntu2
unattended-upgrades==0.1
uritemplate==0.6
urllib3==1.7.1
wheel==0.24.0

Maybe I just had an old version sitting around and pip install --upgrade decided not to update it (even though I thought that was supposed to be recursive)? Feel free to close as not reproducible.

I think we can close this one but we should bump it in google-api-python-client.


Focus trap does not trap focus

Tested this with the <Modal /> component, where <FocusTrap /> is used. It's possible to reverse tab into the main.

It happened the same to me and I finally ended up adding focus-trap-react. Hope this helps

Moving to focus-trap-react worked well.

Hey there! Thank you for opening this issue. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: https://github.com/vercel/commerce/pull/966


 This is necessary to compile cargo without warnings under https://github.com/rust-lang/rust/pull/62262.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

I'd like to understand more about the impetus for this change before merging, so I commented there.

Ok so sounds like this is for now just temporary until more data is gathered. In that case let's go ahead and merge and get the upstream PR testing.
@bors: r+

:pushpin: Commit 829fd71129bbdcff71a892f017070efa5e9e97aa has been approved by alexcrichton

:hourglass: Testing commit 829fd71129bbdcff71a892f017070efa5e9e97aa with merge d9ff5762fe2a08d329fd869c6bb6b073796666cc...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing d9ff5762fe2a08d329fd869c6bb6b073796666cc to master...


FormSelect doesn't allow setting value

I've been trying to programmatically set the value for the <FormSelect /> component but have been having trouble doing so.
My first instinct is to the the value prop:
<FormSelect options={ [...] } value={ selectedValue } />

Unfortunately this doesn't seem to do anything. I noticed in the source that value is blacklisted from the props for handing down to the select element. If I remove this from the blacklist, the value of the select gets appropriately updated.
Am I doing something wrong or is this a bug?

Thanks for the heads up @dmsnell, I'll try to get a patch out today

thanks @jossmac !

I just released v0.4.5 with this parch in it

Cheers @JedWatson


General comments

I found this project just as I was about to start something pretty much exactly the same, I have a few comments which I'd like to see your reasoning behind.
42600d1 Why is the xhyve source in this tree? There's so many files here now which are irrelevant.
8317d31 Err. Why do you have binary files which aren't required by the program in the repo?
I'd love to help you with fixing this, and further development.

Sorry for the late response; I've been quite busy with other projects.
The xhyve source shouldn't be in this tree, you're right. I'm working on refactoring the codebase a bit to fix these issues.
The binary files will be removed in a next release.


Add is_dir check to build workspace

closes https://github.com/CosmWasm/rust-optimizer/issues/68
I tried to make "smarter" map, by changing it to .filter_map() like:
.filter_map(|path| path.unwrap().is_dir().then(|| 0))

but it resulted in double reference which would have to be extra handled later on, so I decided that adding simple .filter() is good enough.
(this .then() trick is something I found to make bool into Option<T> link)

Ah, could you add a CHANGELOG entry to the Unreleased section for this?


Code does not build on 1.48.0

I am getting:
error[E0658]: use of unstable library feature 'array_methods'
   --> src/lib.rs:165:64
    |
165 |             Rotate::RotNone => arr.extend_from_slice(self.leds.as_slice()),
    |                                                                ^^^^^^^^
    |
    = note: see issue #76118 <https://github.com/rust-lang/rust/issues/76118> for more information

error[E0308]: mismatched types
   --> src/lib.rs:165:54
    |
165 |             Rotate::RotNone => arr.extend_from_slice(self.leds.as_slice()),
    |                                                      ^^^^^^^^^^^^^^^^^^^^ expected `u8`, found struct `RGB`
    |
    = note: expected reference `&[u8]`
               found reference `&[RGB<u8>]`

error: aborting due to 2 previous errors; 2 warnings emitted

See Pull Request #10 for a fix.


List the container image location in the Readme

You have a Dockerfile in your repository. Are you pushing new images somewhere? If so, please mention where in the readme.

Yes, that sounds like a good idea. I actually had to look it up myself to confirm where we store the image:
https://github.com/observatorium/token-refresher/blob/master/Makefile#L17