set motor limits ends up swapped

See: https://github.com/APS-USAXS/ipython-usaxs/issues/341

(original message posted here)
note this behavior (which should NOT happen):
In [16]: waxsx.set_lim(-5,5)

In [17]: wa motor
motor
  Positioner                     Value       Low Limit   High Limit  Offset
  camy                           0.301       -12.5       273.5       841.151
  tcam                           -4.0        -70.36      39.54       -52.155
  tens                           29.428909   -17.0       45.0        7.880409
  waxsx                          0.001       5.0         -5.0        257.897

  Local variable name                    Ophyd name (to be recorded as metadata)
  camy                                   camy
  tcam                                   tcam
  tension                                tens
  waxsx                                  waxsx

In [18]: waxsx.high_limit_travel.pvname
Out[18]: '9idcLAX:m58:c0:m4.HLM'

In [19]: !caget 9idcLAX:m58:c0:m4.DIR
9idcLAX:m58:c0:m4.DIR          Neg

Since high < low now, the motor cannot move and this lovely error dump distracts us (the problem is motor limits and the NoneType is the distraction) from the real problem:
In [14]: RE(move_WAXSOut())
I Wed-11:08:19 - Moving WAXS out of beam
Run aborted
Traceback (most recent call last):
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/run_engine.py", line 1355, in _run
    msg = self._plan_stack[-1].send(resp)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 1307, in __call__
    return (yield from plan)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 1162, in baseline_wrapper
    return (yield from plan_mutator(plan, insert_baseline))
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 170, in plan_mutator
    raise ex
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 123, in plan_mutator
    msg = plan_stack[-1].send(ret)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 803, in monitor_during_wrapper
    return (yield from plan2)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 170, in plan_mutator
    raise ex
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 123, in plan_mutator
    msg = plan_stack[-1].send(ret)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 170, in plan_mutator
    raise ex
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 123, in plan_mutator
    msg = plan_stack[-1].send(ret)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 861, in fly_during_wrapper
    return (yield from plan2)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 170, in plan_mutator
    raise ex
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 123, in plan_mutator
    msg = plan_stack[-1].send(ret)
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 170, in plan_mutator
    raise ex
  File "/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py", line 123, in plan_mutator
    msg = plan_stack[-1].send(ret)
  File "/home/beams/USAXS/.ipython/profile_bluesky/startup/instrument/plans/move_instrument.py", line 69, in move_WAXSOut
    terms.WAXS.x_out.get() + terms.WAXS.x_limit_offset.get())
TypeError: 'NoneType' object is not iterable
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-14-41f0bc0c5e30> in <module>
----> 1 RE(move_WAXSOut())

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/run_engine.py in __call__(self, *args, **metadata_kw)
    795             self._task_fut.add_done_callback(set_blocking_event)
    796
--> 797         self._resume_task(init_func=_build_task)
    798
    799         if self._interrupted:

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/run_engine.py in _resume_task(self, init_func)
    919                     if (exc is not None
    920                             and not isinstance(exc, _RunEnginePanic)):
--> 921                         raise exc
    922
    923     def install_suspender(self, suspender):

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/run_engine.py in _run(self)
   1488             exit_reason = str(err)
   1489             self.log.exception("Run aborted")
-> 1490             raise err
   1491         finally:
   1492             if not exit_reason:

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/run_engine.py in _run(self)
   1353                     else:
   1354                         try:
-> 1355                             msg = self._plan_stack[-1].send(resp)
   1356                         # We have exhausted the top generator
   1357                         except StopIteration:

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in __call__(self, plan)
   1305         plan = monitor_during_wrapper(plan, self.monitors)
   1306         plan = baseline_wrapper(plan, self.baseline)
-> 1307         return (yield from plan)
   1308
   1309

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in baseline_wrapper(plan, devices, name)
   1160         return (yield from plan)
   1161     else:
-> 1162         return (yield from plan_mutator(plan, insert_baseline))
   1163
   1164

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    168                     continue
    169                 else:
--> 170                     raise ex
    171         # if inserting / mutating, put new generator on the stack
    172         # and replace the current msg with the first element from the

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    121             ret = result_stack.pop()
    122             try:
--> 123                 msg = plan_stack[-1].send(ret)
    124             except StopIteration as e:
    125                 # discard the exhausted generator

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in monitor_during_wrapper(plan, signals)
    801     plan1 = plan_mutator(plan, insert_after_open)
    802     plan2 = plan_mutator(plan1, insert_before_close)
--> 803     return (yield from plan2)
    804
    805

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    168                     continue
    169                 else:
--> 170                     raise ex
    171         # if inserting / mutating, put new generator on the stack
    172         # and replace the current msg with the first element from the

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    121             ret = result_stack.pop()
    122             try:
--> 123                 msg = plan_stack[-1].send(ret)
    124             except StopIteration as e:
    125                 # discard the exhausted generator

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    168                     continue
    169                 else:
--> 170                     raise ex
    171         # if inserting / mutating, put new generator on the stack
    172         # and replace the current msg with the first element from the

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    121             ret = result_stack.pop()
    122             try:
--> 123                 msg = plan_stack[-1].send(ret)
    124             except StopIteration as e:
    125                 # discard the exhausted generator

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in fly_during_wrapper(plan, flyers)
    859     plan1 = plan_mutator(plan, insert_after_open)
    860     plan2 = plan_mutator(plan1, insert_before_close)
--> 861     return (yield from plan2)
    862
    863

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    168                     continue
    169                 else:
--> 170                     raise ex
    171         # if inserting / mutating, put new generator on the stack
    172         # and replace the current msg with the first element from the

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    121             ret = result_stack.pop()
    122             try:
--> 123                 msg = plan_stack[-1].send(ret)
    124             except StopIteration as e:
    125                 # discard the exhausted generator

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    168                     continue
    169                 else:
--> 170                     raise ex
    171         # if inserting / mutating, put new generator on the stack
    172         # and replace the current msg with the first element from the

/share1/bluesky/conda_envs/bluesky_2020_5/lib/python3.7/site-packages/bluesky/preprocessors.py in plan_mutator(plan, msg_proc)
    121             ret = result_stack.pop()
    122             try:
--> 123                 msg = plan_stack[-1].send(ret)
    124             except StopIteration as e:
    125                 # discard the exhausted generator

~/.ipython/profile_bluesky/startup/instrument/plans/move_instrument.py in move_WAXSOut()
     67     yield from waxsx.set_lim(
     68         waxsx.low_limit_travel.get(),
---> 69         terms.WAXS.x_out.get() + terms.WAXS.x_limit_offset.get())
     70
     71     logger.info("Removed WAXS from beam position")

TypeError: 'NoneType' object is not iterable

It's a simple case setting high to high and low to low.  As-is, it does the opposite (ouch!):   https://github.com/bluesky/ophyd/blob/980154632b1cfa8c4cf02e42a93a521142aefcc0/ophyd/epics_motor.py#L350-L351

At the same time, it's great to add a logger message that reports if limits could not be set and perhaps why.  https://github.com/APS-USAXS/ipython-usaxs/commit/8d7b02c3e23a861291bfbfc34740f5ed9a98fe1b#diff-7e36c833bd50a819cf4cd8392606345fR52-R57
I see there is a logger defined but not used in this module.  https://github.com/bluesky/ophyd/blob/980154632b1cfa8c4cf02e42a93a521142aefcc0/ophyd/epics_motor.py#L14
Suggestions?

self.log

Yes I ran into this swapped limit issue today.

Thanks for reminding.
On Mon, Jul 20, 2020, 9:47 PM stmudie<EMAIL_ADDRESS>wrote:

Yes I ran into this swapped limit issue today.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/bluesky/ophyd/issues/874#issuecomment-661588929, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARMUMFSLPDJNZKBHLCCK63R4T6TTANCNFSM4N4NU4TQ
.


upgrade message-tags and msgid to non-draft versions

message-tags and msgid should be out of draft by the time we get to 1.1; let's support them. I'm leaning towards a strategy where we just cut over, no backwards compatibility with the draft names.

Yeah let's just cut those ones over as soon as they're taken out of draft, no need to support the older aliases.

slingamn: what would be involved in us supporting unprefixed message-tags? iirc there was a minor behavior change?
jwheare: slingamn: probably just increasing the server max tag length.
slingamn: oh neat
slingamn: hmm, we don't implement ERR_INPUTTOOLONG either
dan-: slingamn: yeah we should take a look at the client vs server part stuff inside the message-tags spec as well
dan-: iirc we don't pay attention to any of that at all, might be a consideration we need to make
dan-: and/or do our own custom parsing/etc a liiiittle bit before pushing messages to/from ircmsg

Follow-on note: ircmsg just silently truncates if input is too big. We should resolve that in the lib / in Oragono with some length checks. Thinking within Oragono, should just be a case of comparing the input tag string length in incoming client messages before sending it through the process

The default size for tags in the oragono.io/maxline cap will probably need upping to 8191 too when switching over to the ratified message-tags

Maxline should no longer support negotiating a tag length.


dropwizard 2.1.1

Description
snyk alert for jackson performance issue
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4546
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future

damn it bitbucket


Normalize letter cases in URL

What problem does this feature solve?
If the user visits the URL /path/example/view, and a route /Path/Example/mode(View|Edit) is registered in the router, and router uses case insensitive matching, (and maybe if a flag is set on the route/globally), router should replace the current URL with /Path/Example/View.
Why: to have the best of both case sensitive and insensitive matching - a canonical URL for a single resource, users won't have to remember letter cases, and aesthetic preference of /Path/Example/View to /pAtH/eXaMpLe/ViEw.
What does the proposed API look like?
If this should be behind a flag, I see two ways to do that:

A new boolean option, eg. normalizeLetterCases in RouteConfig interface, or
Since 0. would be non-orthogonal with the caseSensitive option, they could be merged into a single letterCase option of type 'strict'|'normalize'|'ignore'

Unfortunately, there are quite a few edge cases we wouldn't be able to handle like properly changing params or being inflexible by always forcing an option and this being a very specific need that can be solved in user land by doing the needed string manipulation in an afterEach + replace, I would rather keep it that way


Sample Generation Refinement

Due to some default library version conflicts (between librosa and fastai_audio), we needed to find a stable combination -- now updated in requirements.txt file (read by training notebooks).

Added script to sample generation notebook to clear out empty *.wav files. The model training notebook, 2_FastAI_StarterScript.ipynb, assumes that all *.wav files are non-empty. I had to manually delete these files to unblock training.

Cleared notebook output/metadata from checkin to keep future additions small and readable

@bnestor
Regarding Point 1: I'll test and update. Nice callout
Regarding Point 2: I'll provide the directory structure in a zipfile of data for quick start. I'll create / track an issue regarding all of the hardcoded paths. Existence of these file paths should be passed in as args and validated at beginning of script or script should gracefully fail.


Gradle task for :ballerina-cli:test does not build all tests locally

Description:
When building the :ballerina-cli locally, the test task executes tests inconsistently. RunCommandTest doesn't get executed along with a few others. On some occasions, tests don't execute at all.
This makes it difficult to write new tests and verify that the feature works properly. Running with 'no build cache' or 'rerunning all tasks' does not rectify this issue.
Steps to reproduce:
Run gw build on ballerina-cli
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Does not reproduce locally. Hence, closing.


[ENHANCEMENT] Permit manual input of RGB Number Values + Maybe a field to input a hex code instead

cant add labels lol anyways hi eu
am I seriously opening a suggestion 2 month after the last update? yea lol (i dont expect this to be added)
Anyways, I think this would make editing style bonuses far easier, and would make Multi-Colored edits significantly easier to do

This is a plugin configurator feature so I will transfer it over there when I start working on it

thanks eu
closing issue


Add seconds freq_subday_type

Missing possible value 2 to @freq_subday_type, like defined in sysschedules

@rrg92 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


is it Angular 4 the last version ?

Hey!
I wonder if you use the last version of Angular 4.
Also i ask if we can use angular 4 with laravel 5.5
Thank you in advance

Hi @c1t1zen
With this package, you have the freedom to use whichever Angular version you'd like. So yes you can use the Angular-cli (as mentioned in the documentation) in order to scaffold your new Angular (4) app.
Laravel 5.5 should work, but right now it's tested with 5.4

Hi @jadjoubran
thank you for reply
the documentation only talk about AngularJs no mention how to use Angular 4 with
and where can i install or setup Angular app in laravel project root?

Hi @c1t1zen
Sorry I should've mentioned, the new documentation is solely on https://laravel-angular.io/ (rather than on the old website readme.io)
It's not recommended to setup the Angular app in the laravel project root as you'll end up with way too many files and it becomes unmanageable.. I'd recommend you use the Angular CLI in a different project
I'll be working on a screencast soon!

Thank you @jadjoubran


chore: change all Angular-CLI occurrences to Angular CLI

As @cacogr noticed in https://github.com/angular/angular-cli/pull/4398#issuecomment-277251743, there's been one angular-cli (the package) reference left in README; I fixed that in a second commit (it's not strictly related to the project name change so I separated it).


[requirements.bazel.txt] updating wheel package to 0.38.1 to fix the vulnerability

[requirements.bazel.txt] :updating wheel package to 0.38.1 to fix the vulnerability
input: lang/python
release notes: no
settings: release notes:no
updating wheel package to 0.38.1 to fix the vulnerability

#python
please do fix it quickly

The dependencies listed in requirements.bazel.txt are just used for testing, but we're fine to merge this PR after it passed all tests.
Thanks for the contribution!

hey , can someone review this small change , so that we can merge this PR


SocialLoader loads tweets

I wrote a Twitter proxy that's running on AWS to fetch and cache tweets linked within posts. Thanks to @electroly's stellar advice it uses the Winchatty api to monitor new posts so they should be cached before a user clicks the link in 99% of cases.

Any reasons this shouldn't default to enabled?
I've seen some Chromeshack HTTPS support here and there, is that something I need to worry about?
Anything else, let me know.

Here's a catastrophe of a thread with a bunch of twitter links for testing: http://www.shacknews.com/chatty?id=33005406#item_33005406

Merging this and #58 later today unless there are objections!


merge generated hosts file with the system one

containerlab deploy should merge the generated hosts file with the system's hosts file.
containerlab destroy should remove the entries specific to the deleted fabric

closed via #89


lint and fix the code

golangci-lint is a good static analysis tool. There seems to be lot of issues. All to be fixed,

golangci-lint issues /warnings were resolved.


add layername/desc to dct:references

Overview
A convention used by some catalogues to advertise the layername of a wms as an attribute on dct:references, a catalogue client, like terriajs builds on this convention
Related Issue / Discussion
#1046
Additional Information
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
[x] I have already previously agreed to the pycsw Contributions and Licensing Guidelines

this leads to invalid xml according to http://schemas.opengis.net/csw/2.0.2/CSW-discovery.xsd... closing...


chkservice: init at 0.3

Description of changes
Introduce chkservice, a TUI for managing systemd services.
/cc done with @infinisil who apparently accepts to maintain this package :-)
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 178727 run on x86_64-linux 1

1 package built:

chkservice

Checked on aarch64-linux, built and ran just fine.


coap: change it to handle payload in sol_buffers [v2]

This is the 1st iteration of trying to use less memory on CoAP buffers.
sol_coap will now, on packet creation, use a sol_buffer to handle all
the payload, and not allocate a blob with COAP_UDP_MTU bytes right away
anymore. This way, the user is able to append on that buffer to make the
user payload, so that less data hangs around at least on the sending
side. All places where a minimum amount of sending bytes could be
assured now do so.
We still have to think on how to proceed on some of the OIC/cbor paths,
since the involve users callbacks appending cbor data to a packet's
buffer (and issuing the callback twice just to have the cbor
phony-size-calculating calls to take place would be bad). At the
receiving side, we still allocate COAP_UDP_MTU bytes to the buffer. We
can make this better from here as well. On Linux, at least, we have the
MSG_TRUNC recvmsg() flag.
Also, the next iteration of this work will be to change de
sol_coap_packet_new() to receive a possible user-allocated buffer to use
as payload (at the receiving side this could be used as well). So, on
small OSs the direct network buffers could be passed around -- we'll
surely evolve from here.
Signed-off-by: Gustavo Lima Chaves<EMAIL_ADDRESS>
Changes since #1531:

We now ensure buffers on all coap header setters
Payload in coap ctx is now a scalar
Bug fixed on oic path
Logs on noisy paths removed

I did some tests with the oic client and server and they are working fine. The bugs I reported were fixed.

There's a patch on top of that already, dealing with the packets receiving part. Any more comments on this?

v3 coming


Add larger app ex

I chose the wrong base: https://github.com/pallets/flask/pull/2130
Original PR message:

Addresses: #1902 (comment)
Confirms that the larger application as outlined in the docs, works as expected. For the sake of less confusion, for those working through this example, having src might be helpful. Not everyone will want to work along with the docs. If there are parts of the docs that are not clear, we should fix that as well. (They seemed clear to me).

Thiefmaster's response:

The weird commits in this PR aside (rebase to upstream/master and force-push to fix), I'm not sure how useful this is to have in the repo... Especially since having a "large" app without an app factory is somewhat questionable...

My response:

@ThiefMaster Sorry about that. I didn't choose correct base. I was thinking that in order to debug issues that people are having with code examples in the docs, it would be useful to have those examples on-hand.
I agree. But maybe until we can put something better together for #2027, this addition could just be temporary and we could deprecate this "larger applications" example at later time.

This example doesn't work because it contains a circular import and precisely shows why you need app factories.
To separate views from the main app you should use blueprints.

I think it works since the views import is at the bottom, after app has been defined. Still a very good point though.

Ah, I overread that this is from the docs, and yes, that actually works. I don't think we need to test this in any way though (I'd reserve examples/ for more "complete" applications, not just patterns).

I'm not by any means saying this is best practice. Just that having the hardcoded example accompanying the docs, might lead to less confusion for those reading it. (And a sanity check that what's in the docs works as it should.)

Fair enough though this doesn't test anything. We should add a test stub as well that just imports and install the package in tox.ini.

A week ago I got confused by circular imports when adding models.py to flaskr example that I was modifying to work as a large application. I think that the large app example should also showcase how to use models.

Would like to see a rewrite of flaskr with flask-sqlalchemy

While this PR isn't for flaskr and neither was the comment that prompted me to work on this, I do agree. flaskr could be overhauled to show current best practices; i.e. app factories, blueprints, flask-sqlalchemy and the CLI, which also helps with #2027. Maybe at that point this whole larger app portion of the docs can be written with respect to flaskr.

Fair enough though this doesn't test anything because pytest doesn't import the package. We should add a test stub as well that just imports and install the package in tox.ini.

@untitaker assuming you want to go forward with this, would tox.ini change as below? and what else needs to change/be added? I don't follow what you are saying. (not familiar with tox.)
commands =
    # We need to install those after Flask is installed.
    pip install -e examples/flaskr
    pip install -e examples/minitwit
    pip install -e examples/patterns/largerapp
    py.test --cov=flask --cov-report html []

@wgwz Yes exactly, it's just about installing the application in the virtualenv (otherwise you can't import it in the tests)

@untitaker OK I understand now. Should I add some basic tests for it under tests/test_apps?

The other example apps had their own testfolders iirc
On 31 December 2016 17:53:14 CET, Kyle Lawlor<EMAIL_ADDRESS>wrote:

@untitaker OK I understand now. Should I add some basic tests for it
under tests/test_apps?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/flask/pull/2131#issuecomment-269873161

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

should this be closed?

I think it's fine as is, thanks :)


Support for new regions: ECR repo

Describe the bug
When we deploy [AWS Amazon EKS add-ons] to the cluster, Terragrunt modules are not able to pull & push images from Amazon ECR private registry in newer regions. This is because the newer regions are not added to the supported list in https://github.com/gruntwork-io/kubergrunt/blob/main/eks/sync.go
To Reproduce
Terragrunt version: v0.36.10
Kubergrunt version: v0.9.3
Steps to reproduce :
Try to install an add on eks cluster in region: ap-southeast-3
resource "aws_eks_addon" "vpc-cni" {
  cluster_name = var.cluster_name
  addon_name   = "vpc-cni"
  addon_version  = var.vpc_cni_addon_version
  resolve_conflicts = "OVERWRITE"
}

Expected behavior
The Add Ons should be installed without any issues. Terragrunt should pick the correct ECR repo id for new regions

Will be resolved in https://github.com/gruntwork-io/kubergrunt/pull/192


Support new InsurancePackage tag

Add and modify unit tests, and modify InsurancePackage class.
Adding a compulsory tag breaks many existing unit tests.
Changes:
Add unit tests for tag, modify all existing constructors for Person, update dummy values to include dummy insurance package
values, and other changes to existing tests.

Codecov Report

Merging #27 (7bb42f5) into master (f42999a) will increase coverage by 0.44%.
The diff coverage is 88.23%.

@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
+ Coverage     72.15%   72.60%   +0.44%
- Complexity      399      410      +11
============================================
  Files            70       71       +1
  Lines          1232     1274      +42
  Branches        125      132       +7
============================================
+ Hits            889      925      +36
- Misses          311      313       +2
- Partials         32       36       +4

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <ø> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...a/seedu/address/model/person/InsurancePackage.java
70.00% <70.00%> (ø)

...c/main/java/seedu/address/model/person/Person.java
95.74% <83.33%> (-1.88%)
:arrow_down:

...java/seedu/address/logic/commands/EditCommand.java
95.94% <88.88%> (-1.07%)
:arrow_down:

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
85.71% <100.00%> (+2.38%)
:arrow_up:

.../seedu/address/logic/parser/EditCommandParser.java
93.10% <100.00%> (+0.79%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
97.56% <100.00%> (+0.33%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33a46f...7bb42f5. Read the comment docs.

LGTM nicely yiheng


Pulseaudio Network Sink

I am on Arch Linux and I'm using Pulseaudio 14.2. Balena sound is running on a Rapberry Pi 3b+ that's equipped with a Hifiberry Amp+. I tried setting up Airplay on my Arch Linux laptop but was unsuccessful. When reading around I saw that Pulseaudio has the option to be used as a network-wide sink.
I think exposing the Pi as a Pulseaudio as a network sink could be benefitial because it uses free protocols native to both my laptop and balena sound, since from what I understand it heavily uses Pulseaudio already. This would allow me to keep the stack simpler and, by using only wifi-based protocols, also potentially avoid bluetooth issues present on the Pi 3.

i think what you want is what you will get by using the below command on your arch laptop if you have pulseaudio installed(replace the italic names with your information):
pacmd load-module module-tunnel-sink-new server=[yourBalenaHostnameOrIP]:4317 sink=balena-sound.input format=s16le channels=2 rate=44100 sink_properties=device.icon_name=computer sink_name=YourDesiredNameForTheSinkItWillCreate channel_map=front-left,front-right
The above command will create a new audio tunnel (device) which you can select afterwards. You could call this command whenever you want it or when your laptop starts so that it will be always available.

That works great! Thanks. Maybe this could be added to the docs? It's an unmentioned method of playing audio that seems to come for free and for me it's a big plus over for example bluetooth, which is flaky at best on my laptop.


Add language for compliance requirements around platforms

Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

I'd rather not use both “one of the platforms” and “for the protocols
it implements”.  If we want to split this spec into “protocols” we
should stick to the protocols language with the new addition.  If we
want to switch to “platforms” language, we should update the existing
compliance language to use “platforms”.
The “platforms” phrasing is nice and specific for the current spec,
but discussion in #513 included “what if we support ‘at least one of
the following APIs’?” 1, so we may want to stick with the
less-specific “protocols” phrasing to cover both platforms and APIs.
In that case I think it makes sense to make the mapping between
protocols and MUST/SHOULD/… requirements clear.  For example:
An implementation is not compliant if it fails to satisfy one or
more of the MUST or REQUIRED requirements for the protocols it
implements.  An implementation that satisfies all the MUST or
REQUIRED and all the SHOULD requirements for its protocols is said
to be "unconditionally compliant".  Protocols defined by this spec
are:

Linux containers: runtime.md, config.md, config-linux.md, and
runtime-linux.md.
Solaris containers: runtime.md, config.md, and config-solaris.md.

And once we land an API spec, it would look something like:

Linux containers: runtime.md, config.md, config-linux.md,
runtime-linux.md, and an API.
Solaris containers: runtime.md, config.md and config-solaris.md,
and an API.

APIs include at least one of:

The command line API

@wking I like your wording but we want to avoid repeating the line for each platform if we can. The only thing that will be different is config-platform.md.

On Wed, Aug 10, 2016 at 01:40:45PM -0700, Mrunal Patel wrote:

The only thing that will be different is config-platform.md.

That's not true now, although it would be if you can roll
runtime-linux.md into other places.  #513 moves the standard-streams
stuff into the command line API and you could move the dev links into
config-linux.md.  If we do get a consistent pattern for which files
are part of which “protocols”, I'm fine just explaining the pattern
instead of listing them all out.

I like most of @wking 's wording but not the part about conditionally vs unconditionally compliant.

As discussed on the call @mrunalp please add language around "system architectures (ARM, x86-64, etc)" as well as OSes.

OSes are platforms, by architecture, we usually mean x86_64, ARM etc.. I think we need language about architectures.

Updated.

Pushed update.

On Wed, Aug 17, 2016 at 10:45:36AM -0700, Mrunal Patel wrote:

Pushed update.

6a5b144 looks good to me.
We probably want to remove wiggles like “The Solaris specification is
entirely optional” 1 now that we have this centralized definition of
what requirements belong to which protocols.  I'm fine discussing that
as part of this PR if folks want, or punting it to follow up work.

@opencontainers/runtime-spec-maintainers  PTAL

de3f1af looks good to me too.  I'm not aware of anything else that
should change to match this new compliance language, but we can find
and fix other issues (if any) later on.

LGTM, I thought we might need some CPU architecture specific fields in spec, but we need to figure out what fields and if they exist.

On Thu, Aug 18, 2016 at 08:14:54PM -0700, Qiang Huang wrote:

LGTM, I thought we might need some CPU architecture specific fields
in spec, but we need to figure out what fields and if they exist.

The current PR has “for a given CPU architecture” and similar language
and the spec has a platform.arch field.  What more are you looking
for?  Are you talking about #39 and #69?

The current PR has “for a given CPU architecture” and similar language
and the spec has a platform.arch field.  What more are you looking
for?  Are you talking about #39 and #69?

Yeah, something like that, and I think the problem described in #39 is not resolved yet, GOARCH from golang is not sufficient for all architectures, maybe we should reopen it and discuss more.

On Fri, Aug 26, 2016 at 08:12:09AM -0700, Qiang Huang wrote:

… I think the problem described in #39 is not resolved yet, GOARCH
from golang is not sufficient for all architectures…

#441 brought over some language from opencontainers/image-spec#60 that
says “If you need something that's not in GOARCH, please let us know”.
I think that allows us to patch holes in GOARCH as they arise.

@wking Maybe for architecture itself, GOARCH would be sufficient, but we might need some information like byte order, variant, abi etc.. which might be considered out of architecture name, so argue with GOARCH may not be a wise move.

On Fri, Aug 26, 2016 at 08:45:34AM -0700, Qiang Huang wrote:

… so argue with GOARCH may not be a wise move.

Maybe not, I don't know.  But I still think the “for a given CPU
architecture” covers the current non-OS portion of ‘platform’.
If/when we land language for platform.byte-order (or whatever), we can
amend the architecture-ish scoping here.

LGTM


How do I mark a template token as a link?

I use Hugo to write my blog posts in Markdown. Hugo has shortcodes which are simply expressions evaluated at compile-time and then injected with the appropriate value. Currently, marksman thinks the link is invalid and gives the following diagnostic message:

Here is how I have defined links:
[rtems]: https://www.rtems.org/
[zsh]: https://www.zsh.org/
[hooks]: https://man.archlinux.org/man/zshcontrib.1.en#Manipulating_Hook_Functions

[gsoc]: {{< relref "/posts/gsoc" >}}

How do I get marksman to interpret that these shortcodes are valid links?

@UtkarshVerma thanks for asking! These short-codes are not valid markdown, that's why the parser doesn't accept them. I'd be open to accept a PR that adds this functionality but personally won't have time for this any time soon.


WIP: Optionally use neovim's api-highlights

Fixes #1274
Took a stub at it and it seems to work well. Highlights are indeed being
adapted to line instertions so we see less stalled highlights.
I'm going to use it for a while to see how it works.

Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!
Seriously, read :help ale-development and write tests.

This is how it looks:

Please check linter errors. Unfortunately, I'm not sure what to do about the errors with the outdated neovim. There's not much we can do about that unless the linter gets updated, I think?

Have a look at some existing tests. You have to make sure the file is loaded first with runtime, replace it, and then load it again in an After block.

@w0rp is there a way to execute tests "locally" w/o docker and only a subset of tests? I find it very hard to iterate (I'm vimscript beginner!) when tests take so much time to run. I really want to finish my PRs to ALE and bring more.

If you install Vader, you can run tests for a Vader file with the :Vader command. You can run subset of tests with the Docker image with a glob like ./run-tests test/directory/*.vader. Use --help or check the documentation to see how you can limit the Vim versions to run some tests more quickly. Make sure to install Docker for running all of the tests locally.

This is ready for review.
AppVeyor task should be cancelled as I froze it with leaving :echo in test code in past commit.
For some reason tests fail locally on my neovim 0.4.0 due to not being able to override functions (I suspect neovim 0.4.0 has problems with Vader) but it's ok on CI.

Hi, this commit somehow needs let g:ale_set_signs = 1 to work correct, let me explain:
Without commit 114198e:
With let g:ale_set_signs = 0 (good):

With let g:ale_set_signs = 1 (good):

With commit 114198e:
With let g:ale_set_signs = 0 (bad, send error highlight to next line):

With let g:ale_set_signs = 1 (good):

@davidsierradz indeed, thanks for catching that, it's off by one error. Should be fixed with #2475


Issue with k8s.io/docs/getting-started-guides/ubuntu/local/

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
It is required for the user to be part of the lxd group.
Otherwise conjure won't see the localhost cloud.
Proposed Solution:
Specify that the user should be part of the lxd group.
or
Add the following line in the install instructions:
$ sudo usermod -a -G lxd $(whoami)
Page to Update:
https://kubernetes.io/docs/getting-started-guides/ubuntu/local/

/assign


OPENSSL_NO_DSO doesn't exist

If you configure with "no-dso", then the macro "OPENSSL_NO_DSO" doesn't get defined. However it is used nonetheless:
https://github.com/openssl/openssl/blob/master/crypto/init.c#L114
https://github.com/openssl/openssl/blob/master/crypto/init.c#L679
https://github.com/openssl/openssl/blob/master/include/internal/dsoerr.h#L16
This issue affects 1.1.0 as well.

Note that the effect of "no-dso" is to use the NULL DSO method, so you still get all the DSO symbols - they just don't do anything.

That was an intentional change of methodology. At the time, some of us felt that the "don't even provide stubs" was an unnecessary burden on the users, that it was better to simply return an error when the functionality isn't available.

The RSA library was created in a different time and with a different mindset...

I know.  I think the change was a mistake and I'd like us to reconsider.

OPENSSL_NO_DSO is defined but it is not used anywhere anyway in the current master. Closing.


Service Fabric deploy broken if Application Type is still registered

Environment

Server - VSTS
Account Name: mongoose-r
Team Project Name: sms
Release Definition: service-fabric-dev (ID: 15)
Example build number: service fabric dev - 673 (ID: 2678)

Agent - Hosted
Name: Hosted Agent

Issue Description
Service fabric app deploy version 1.7.5
We created a repeatable task group with a single task for deploying service fabric apps. They all share the same general setup and configuration. All of them fail with the same error (see error logs below).
The general steps to reproduce are:

Deploy an app to a fresh service fabric server cluster with no existing application types registered
See that the app is deployed and working under its associated application type
Delete the app, but dont unregister the application type
Run the deploy again and see it fail

Error logs
2018-04-19T19:59:01.0498928Z Successfully connected to cluster. 2018-04-19T19:59:01.1202649Z Searching for path: D:\a\r1\a\**\drop\...\Dev.xml 2018-04-19T19:59:01.3225545Z Found path: D:\a\r1\a\service-fabric-dev\drop\...\Dev.xml 2018-04-19T19:59:01.3233143Z Overriding application parameter file specified in publish profile with 'D:\a\r1\a\service-fabric-dev\drop\...\Dev.xml' specified in the VSTS task. 2018-04-19T19:59:01.3249986Z Overriding upgrade settings specified in publish profile with the settings specified in the VSTS Task. 2018-04-19T19:59:04.5358410Z ##[error]A parameter cannot be found that matches parameter name 'ApplicationTypeName'. 2018-04-19T19:59:04.6007338Z ##[section]Finishing: Deploy Service Fabric Application

@nforysinski Unable to repro the failure scenario by following the steps mentioned by you.
Please share your task's debug logs.

@kuvinodms got an email I can mail you the full log zip with all associated tasks?

Yes, please mail it to<EMAIL_ADDRESS>

@kuvinodms just emailed the logs to you. let me know if you need anything else.

Got the mail. Expect an update on it by tomorrow EOD.

@nforysinski
Please add following debug variable in your release definition and re-initiate the release. Forward/attach the generated logs.
Name - system.debug
Value - true

We're also seeing this.
(I'd love to give you these logs but when I'm downloading it I get a: "typeName":"Microsoft.TeamFoundation.Framework.Server.UnauthorizedRequestException, Microsoft.TeamFoundation.Framework.Server","typeKey":"UnauthorizedRequestException","errorCode":0,"eventId":3000)

I think it was this issue.
@nforysinski have you tried using Hosted VS2017 as your agent?

@NickDarvey Thanks for providing the issue link and your debug logs.
I was going through your logs and have 1 thing to confirm. Did you delete the application before triggering the release?

@NickDarvey we changed to Hosted VS2017 yesterday and everything went fine this morning. I don't yet have a failing log with System.Debug turned on, so I am watching that carefully.
@kuvinodms I can't speak for @NickDarvey but I can say we definitely we did not delete the application as we expected the non-upgrade deployment task to take care of that.

@NickDarvey @nforysinski Service fabric tasks will most probably run into problems with Hosted agent pool - as the installed SF SDK (on which the task takes dependency) is quite old.
I would strongly recommend using Hosted VS2017 pool which gets updated often. Please let us know if you see same issue with Hosted VS2017.

Feel free to reopen if you still face this issue.


Set Proper width and Placeholder Quality for Queried Sanity Images

No longer needed -- handled in previous PR.

No longer needed -- handled in previous PR.


Fix unit tests

Changelog

Correct an issue with unit test fixtures for compliance reports
Add a new docker-compose-test.yml file as an example of how to run unit tests in a container
Remove dependency on Minio for tests

@plasticviking
looks like minio is not in docker-compose-test.yml, is the volume minio_data still needed?


English translation

This UX Framework is awesome. It would be great to have an English-first approach. Today, even the demo is not usable for most people from outside China.

Indeed, multilingualism was not planned from the beginning vue ecology  There are relatively mature solutions and I believe it is easy to integrate myself

@jekip - Yes, for Vue there is https://vue-i18n.intlify.dev/ available. Would be great of the demo app would support that and the project documentation would be translated to English as well.

@jekip - Yes, for Vue there is https://vue-i18n.intlify.dev/ available. Would be great of the demo app would support that and the project documentation would be translated to English as well.

#222


Allow to create untitled document with specific language id

Is it possible to create an untitled document using 'workbench.action.files.newUntitledFile' command for specific language id? I'm using openTextDocument passing the vscode.Uri.parse('untitled:' + filePath) which filePath has the extension I want but I have to give it a full path which is different than the Untitled documents using the newUntitledFile command.

No, currently not possible.

@llali I am not sure I understand the use case actually, if I look at https://github.com/Microsoft/vscode-mssql/blob/dev/src/controllers/untitledSqlDocumentService.ts#L29 you seem to create a untitled resource and open it with a path. Why can you not set the extension of that path in a way that maps to the mode you want? Once you save the file and open it, the mode is also picked based on the extension, so I find it weird to set a different mode first for the untitled and then later you would get a different mode.

@bpasero the path I created the untitled resource for has an extension which is .sql, so the mode changes to what I want and that's the scenario I needed. Now user can use a command "New SQL query" to create a new untitled document with SQL language mode. I couldn't do that with the untitled document command. Not sure if I did the right way but that was the solution I came up with. Please let me know if there's a better way for it.

@llali no I think what you do is totally fine, the command you are pointing to is not even an official supported command. I am closing this since you seem to have found a working solution.

@bpasero  my solution works but the result is different than VS code untitled documents, the first difference is that I have to specify a valid path but vs code untitled document doesn't have a path and user can specify the path to save it later. Also I have to do the same logic as vs code does to figure out the name of the file. it would be nice it there's an open API which both can use.

Got it, valid request.

After discussion in https://github.com/Microsoft/vscode/pull/18591 one idea is to:

allow to open an untitled file without path by calling openTextDocument(Uri.parse('untitled:'))
add a new optional options bag to the method that allows to set a language to use for the document to open (e.g. openTextDocument(uri, options?: { language?: string }))

Continues in https://github.com/Microsoft/vscode/issues/12283


Write a Kotlin program to find sum of squares of numbers

Description
Write a Kotlin program to find sum of squares of numbers
Suppose you have a list of numbers, and you want to find the sum of the squares of those numbers. For example, if you have the list [1, 2, 3], you want to find the sum of the squares of those numbers, which is 1^2 + 2^2 + 3^2 = 14.
Input  : 1 2 3 4 5
Output : 55

How to contribute

Save the solution in FindSumOfSquaresOfNumbers.kt file
Add FindSumOfSquaresOfNumbers.kt file in program/find-sum-of-squares-of-numbers folder

!assign


Feat/processing modal

[Feature]:

Add the ConfirmStartProcessing component with the unit-test file.

[Changes]:

Change 'any' types in code with related types.

[Fix]:

Fix the issue in jest.config file and update package.JSON

branches should be based on main (master). Right now you are committing all the code from the sentry issue too.


Provide package file download api

All the logic is apparently available, we're only missing it in the API

@dang03, @shuaibsiddiqui, @felipevicens
Since packages can be big files, I was thinking of connecting directly from the API to the Catalogue (i.e., without using the Package micro-service); what do you think?

@dang03, @shuaibsiddiqui, @felipevicens
...and we should improve later 'cause we have currently 3 calls:

call to get package's meta-data (gives the son_package_uuid)
call to get package file's name
call to get the package file

At least #1 and #2 could be merged, no?


hotfix for develop: bug fix for Tb fore-minus-aft stats check

(partly) addresses issue #322
this hotfix is for "develop";   see also #323 (hotfix for v17.9.0)
still needs 0-diff testing (incl GNU tests)

Are you sure this is to merge to main branch ? @gmao-rreichle

So this is draft and I cannot approve @gmao-rreichle

Branch is tested its 0diff.
@gmao-rreichle  @weiyuan-jiang


I also did some of your helper functions back in bootcamp... very neat code :D


DR -  Dynamo DB multi region

User Story
Change the  Dynamo DB,  modernisation-platform-terraform-state-lock table in the mod-platform account to be multi regional, copied to eu-west-1.
Value / Purpose
Required for DR.
Useful Contacts
No response
Additional Information
No response
Proposal / Unknowns
No response
Definition of Done

[ ] Another team member has reviewed
[ ] Dynamo DB is multi regional

do we need this - or would we just recreate it?


ZEPPELIN-1562 updated api doc

What is this PR for?
The URL for running a paragraph synchronously using REST api is mistakenly given  as "http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] "
Changed the doc as per code
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?

ZEPPELIN-1562

How should this be tested?
Hit the url in below format for asynchrnous
http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]
the same in synchronous
http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId]
Screenshots (if appropriate)
Questions:

Does the licenses files need update? NO
Is there breaking changes for older versions? NO
Does this needs documentation? NO

Nice catch! Can you rebase please? I will merge this one as soon as conflict is resolved :)

Resolved conflict and raised another PR

https://github.com/apache/zeppelin/pull/1560


[C++] Scanner -> ScanNode

This is going to be a parent issue for a number of changes I'd like to make to the scanner.

I'd like to remove the concept of the scanner from the public API
Related to that, ScanOptions will probably break into two classes.  QueryOptions will be the public facing half while ScanOptions will be options sent to the ScanNode.  Most users won't see ScanOptions as it will be internal.
For example, QueryOptions will have batch_readahead which represents how many "query engine batches" to readahead.  Since files & the query engine have different ideas of what constitutes a "batch" the related property in ScanOptions will be rows_to_readahead.
Another example is projection, in QueryOptions projection is column selection as well as custom projection expressions that a user wants to run.  In ScanOptions "projection" is the desired list of columns and the output type for each column, which controls casting and inference.
Partially related (and partially unrelated) to the above two items I would like to move the scanner away from AsyncGenerator and recast it as an execution engine node.
The Scanner class will become deprecated and eventually go away.  Some methods like Scanner::ToTable may move into a new QueryBuilder or Query object.

Reporter: Weston Pace / @westonpace
Related issues:

[Python][R] Expose (hide?) ScanOptions (depends upon)
[C++] Add support for Future (depends upon)
[C++] Migrate scanner logic to ExecPlan, remove merged generator (depends upon)
[C++][Python][R] Deprecate "scanner" (but keep "scan node") from public API (depends upon)

Note: This issue was originally created as ARROW-16410. Please see the migration documentation for further details.

Is it still the plan to remove the Scanner, particularly in the Python API? Thanks.
I'm using the Acero engine for out-of-core grouping, but it doesn't support scanners as a source, and its API is still documented as experimental.


Upgrade nodejs resolver

This PR upgrade the version of nodejs_resolver, it brings two change:

Optimized handling of extendsions, which reduces content usage and optimizes execution speed.  relative: https://github.com/web-infra-dev/nodejs_resolver/issues/157
Fixed the paths map match in tsconfig, some test: https://github.com/web-infra-dev/nodejs_resolver/pull/172/files#diff-9bfc51173c154df5ab54a96fc510a2c449c578905e2b9be080b19450792d5236R193

!canary

!canary

!canary

!canary

!canary


Is is possible to join on multiple casted fields?

Example:
  SELECT
    p.date::TEXT AS date,
    p.sku::TEXT AS sku,
    p.customer_id::TEXT AS customer_id
  FROM table_pre p RIGHT JOIN diff_rows df ON
    p.date::TEXT = df.date::TEXT
    AND p.sku::TEXT = df.sku::TEXT
    AND p.customer_id::TEXT = df.customer_id::TEXT

OR...
  SELECT
    CAST(p.date AS TEXT) AS date,
    CAST(p.sku AS TEXT) AS sku,
    CAST(p.customer_id AS TEXT) AS customer_id
  FROM table_pre p RIGHT JOIN diff_rows df ON
    CAST(p.date AS TEXT) = CAST(df.date AS TEXT)
    AND CAST(p.sku AS TEXT) = CAST(df.sku AS TEXT)
    AND CAST(p.customer_id AS TEXT) = CAST(df.customer_id AS TEXT)

Nevermind, I figured it out, I can built the single criterion using '==' and '&'


Bicep sample for private endpoint

Please provide a bicep sample for private endpoint configuration.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c95686d6-5fbc-9466-ec62-ebbc8ca6c99f
Version Independent ID: d82df904-94bd-47fc-5029-75babc6d36b0
Content: Azure Cache for Redis with Azure Private Link - Azure Cache for Redis
Content Source: articles/azure-cache-for-redis/cache-private-link.md
Service: cache
GitHub Login: @flang-msft
Microsoft Alias: franlanglois

@chitturs
Thanks for your feedback! We will investigate and update as appropriate.

Hi @flang-msft,
Could you please look into this, thanks.

@chitturs -
Thanks for the doc suggestion! I've added it to our documentation backlog for a future consideration. According to our usual policy, I'll now proceed to close this issue. If you have further information or would like to continue the discussion, please tag me and or reopen the issue. Thank you!
#please-close


DispatcherFlusher using the Replicator for DELETE actions results in slow performance with big repositories.

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: <IP_ADDRESS>
[ ] ACS AEM Commons Version: 3.17.4
[ ] Reproducible on Latest? yes

Clearing a big repository from the cache based on the dispatcher flush rules takes a long time. This can be resolved by avoiding to use the Replicator for delete actions.
A suggestion for improving speed is to avoid the Replicator for DELETE operations and instead use a HTTP request to the dispatcher to clear the cache. This avoids the Replicator calculating all paths to deactivate, and instead just removes the entire section of the repository from the cache.
In the process of trying this out, I ran into difficulties in getting my own DispatcherFlusher service bound to the DispatcherFlushRulesImpl component because of the reluctant Reference Policy Option. It may be a good idea to make that greedy.

@jasper-s making this greedy sounds fine - can you provide a PR?

Making this greedy is good for allowing custom implementations.
Still seems like a good idea to allow using a HTTP client to issue DELETE requests. Something like
CloseableHttpClient httpClient = HttpClients.createDefault();
HttpResponse response = Executor.newInstance(httpClient).execute(Request.Post("UrlHere").addHeader("CQ-Action", "DELETE").addHeader("CQ-Handle", path)).returnResponse();
Any thoughts on that?

@jasper-s are all those values derivable from the flush agents themselves?
I dont think its a good idea to maintain the Dispatcher connection info in 2 places (Agent and elsewhere??).
Im not 100% clear your ask, are you asking:

If the ACS Commons existing Delete handling be updated to make a direct call?
If the ACS Commons should ADD a new "DIRECT DELETE" action that can be used to make a direct call?
Are you asking about this for a custom implementation that wouldnt ever go into ACS Commons?

@davidjgonzalez I'll try to be more precise.
These values are derivable from the Agents and their respective AgentConfig. It is indeed not a good idea to keep the info in seperate places.
I'm certainly asking for a solution in ACS Commons. This could be either with a config on the existing DispatcherFlusher, determining the delete type, or with an extra action like you say.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 10:39:29 on 2023.06.03
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 0, errors out: 0
Original problem ID: 23213
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=23213

Problem has been resolved in 3m 0s at 10:42:29 on 2023.06.03
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 23213


Rewrite/improve Pan Zoom Library

Currently using a homemade panzoom library duct-taped together. It generally works, but is hard to work with. There's some other libraries for similar behavior, but none seemed to fit these needs:

[x] Use a DOM element (not <Canvas>)—we need to render interactable websites with Webview, not static images of a website
[x] Drag/pan objects around the container
[x] Zoom in/out of the container (which should scale the objects)
[ ] Center + scale objects to fit the container
[ ] Center + scale the container on a specific object
[x] Set the x, y, and scale through a public API
[x] Zoom in/out towards pointer

Event handlers:

[x] Trackpad: Zoom
[x] Trackpad: Pan
[x] Mouse: Zoom
[x] Mouse (DblClick): Zoom
[x] Mouse: Pan

Nice-to-have:

[ ] Smooth zooming (animated)
[ ] Drag inertia

Will track some of the progress & changes here: https://github.com/nwittwer/reflex/projects/20

Reverted to using external panzoom library


new(content/en/docs): better diagram in the getting started page

Signed-off-by: Leonardo Di Donato<EMAIL_ADDRESS>What type of PR is this?
/kind content
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
This PR introduces a new architectural diagram for the Getting Started page of the Falco website.
The diagram I put here was created by me for my KubeCon NA 2020 talk  and already shown during that talk.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
Thanks @leodido !!!

LGTM label has been added.  Git tree hash: a1b6205cf6c5bb5c399a7ee9910a6cde14a580fc

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Rajakavitha1
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Rajakavitha1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Rajakavitha1
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Rajakavitha1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


0.3.741 - fit_markdown flag not recognized and not set

Hi @unclecode - Just did some testing on 0.3.741, and I noticed that even when fit_markdown is set, the results.fit_markdown will always return Set flag 'fit_markdown' to True to get cleaned HTML content.
Here's how I'm calling it:
async def main(url: str):
    async with AsyncWebCrawler() as crawler:
        result = await crawler.arun(
            url=url,
            verbose=True,
            headless=True,
            fit_markdown=True,
            bypass_cache=True,
            word_count_threshold=1
        )
        if result.success:
            print(result.fit_markdown)
            return result
        else:
            print(f"Crawl failed: {result.error_message}")

I've tried adjusting a few settings, such as headless=False, but that doesn't seem to affect it.

Hi @chanmathew I made some changes, and release it in 0.3.743 tonight, then you follow this code:
from crawl4ai import AsyncWebCrawler, CacheMode
from crawl4ai.content_filter_strategy import BM25ContentFilter

async def main():
    async with AsyncWebCrawler(
            headless=True,  # Set to False to see what is happening
            verbose=True,
    ) as crawler:
        result = await crawler.arun(
            url="https://en.wikipedia.org/wiki/Apple",
            cache_mode=CacheMode.BYPASS,
            markdown_generator=DefaultMarkdownGenerator(
                content_filter=BM25ContentFilter(user_query=None, bm25_threshold=1.0)
            ),
        )
        print(len(result.markdown))
        print(len(result.fit_markdown))
        print(len(result.markdown_v2.fit_markdown))

if __name__ == "__main__":
    asyncio.run(main())

If you only need clean markdown, there’s no need to pass a content filter, just DefaultMarkdownGenerator() would be enough. But if you want fit markdown, you’ll need to provide a content filter. I’m planning to build multiple document filter algorithms tailored for different types of websites and content, along with new approaches for generating markdown.
Here’s how it works: if you don’t pass a user query and the website already has text, meta descriptions, and keywords, the algorithm will use that data. It then crawls the page, applies a clustering algorithm to analyze the connections between different sections, and generates a key based on the title, descriptions, and keywords. Only the relevant parts of the page are retained as the main content.
If you do pass a user query, it will use your query instead, allowing you to selectively extract just the portion of the page you want in your markdown. This adds more flexibility. Keep in mind, this is still an experimental feature.

Thanks @unclecode - got it, will test again once the release is out!

@chanmathew Dear Matthew, I already released the version so you can try it. It's 0.3.744 and it will be 0.3.745 very soon, Haha  Check it, please let me know.

Had the same issues, v0.3.745 is working smooth so far @unclecode.

@jtha glad to hear that, plz let me know anything goes wrong


[Suggestion] Generated Curl does not work with Postman import

Overview

Insomnia Version: (e.g. 5.0.2)
Operating System: (e.g. MacOS 10.12.4 (16E195))
Summary:  (A few sentences describing the issue. Try to include as much detail as possible.)

although I use insomnia,  colleague use postman.
postman not support the curl text export from insomnia (the url must put at first, not as a param)
and if there many request, I can not export many curl text
thanks~

I appreciate the suggestion @xinshangshangxin.
This seems like an issue that should be fixed on Postman's end. The --url http://myurl.com flag is perfectly valid and should be handled properly by Postman.
Insomnia's Curl requests are generated by httpsnippet so there isn't much I can do here, unfortunately.

if there many request, I can not export many curl text
is there any export json postman format to reimport to postman?


Add three requested mods

Fixes #7398.
Need to acquire authors' permission.

The modules that do not have author permission have been moved to .frozen so we can index them easily if permission is acquired in the future.


Shine Toolbox:

Apply the shine toolbox to the all the images.

Toolbox, in the emotional faces paper

Social Media:

Check Buttons

Blind Dating:

Words, color should be the same 'brightness'

Shine toolbox to match luminence for the social media task recommends rgb(126,126,126) colors for both buttons.
Attached image is how it looks. very dull imo.


Channel callbacks [connected, disconnected , received & rejected ] not trigging?

Hi @kesha-antonov,
I am new to action cable with react native. could you help to fix this issue? My Channel callbacks it not triggered so I don't is my APP connected or not?

ActionCable.startDebugging() Logs are

I do logs actionCable.connection.isActive()
it prints true and if i do actionCable.disconnected() it will print false.
Thanks.

@abdulwahabcs Hi!
Are you sure you setup server correctly? There's error with something about unsupported protocols

@kesha-antonov  Thanks for replying i think you are right i had issue on my server side. Can you shar something to setup server?

+1

Did anybody find a solution for this ? My server setup seems to be wrong so I can't connect to the channel.

For those who encounter a similar issue, I have figured out the reason that the client could not connect to the server.
In my development.rb file, I had a configuration line specifying config.reload_classes_only_on_change = false
After removing this line, my mobile app could finally connect to the backend.
Thanks again @kesha-antonov for the lib !

For those who encounter a similar issue, I have figured out the reason that the client could not connect to the server.
In my development.rb file, I had a configuration line specifying config.reload_classes_only_on_change = false
After removing this line, my mobile app could finally connect to the backend.
Thanks again @kesha-antonov for the lib !

Thanks for sharing your solution!


Remove meta info from top of notes exported

Is it possible to remove the extra meta data from the top of exported notes?
color: White
deleted: false
id: xxxxxxxxxxxxxxxxxx
parent_id: root
pinned: false
sort: '0'
timestamps:
created:<PHONE_NUMBER>.261
edited:<PHONE_NUMBER>.851
trashed: -3600.0
updated:<PHONE_NUMBER>.947
title: xxxx
trashed: false
type: List
url: https://keep.google.com/u/0/#LIST/xxxxxxxxxxxxxxxxxxxxxxxxx
Other than this, it worked perfectly! Many thanks

I can make excluding metadata an optional flag, I'll put that on my TODO

I can make excluding metadata an optional flag, I'll put that on my TODO

Awesome, thanks so much. My wife and I are currently in the process of de-googling and this is the last hurdle.
Moving all my notes to Joplin instead., hosted on Joplin

Awesome, thanks so much. My wife and I are currently in the process of de-googling and this is the last hurdle.
Moving all my notes to Joplin instead., hosted on Joplin

I have added a --header/--no-header flag that includes/excludes the frontmatter. In your case, add --no-header to the command, it defaults to including it.

I have added a --header/--no-header flag that includes/excludes the frontmatter. In your case, add --no-header to the command, it defaults to including it.


Backport #175 Change test server version from to 3.7.1-SNAPSHOT.

Changed test server version from 3.6.4-SNAPSHOT to 3.7.1-SNAPSHOT.

Test PASSed.


Simplify command override decisions

Just cutting down on some redundant code with a simpler structure for overriding commands

Current coverage is 76.50% (diff: 100%)

Merging #2993 into master will increase coverage by 0.01%

@@             master      #2993   diff @@
==========================================
  Files           426        426
  Lines         21812      21802    -10
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          16684      16678     -6
+ Misses         5128       5124     -4
  Partials          0          0

Diff Coverage
File Path

•••••••••• 100%
st2client/st2client/commands/resource.py

Powered by Codecov. Last update 9329a60...6463dc5

LGTM.

Nice :+1:
There are definitely quite many other places in st2client which need similar (refactoring) love :)


iOS 14 thumbnail don't appear in gallery when user chooses "Select Photos" permission

In iOS 14, when users are prompted to give an app permission to access their photos, users have the option to "Select Photos" where the app will only have access to the photos selected by the user, as opposed to the user's entire Photo Library (see first screenshot).
On our app, when we prompt the user to allow access to their photos, and given the user chooses the "Select Photo" option, once the user has selected the photos they want our app to have access to, the thumbnails of the selected photos don't show up (see second screenshot below).

Following are the errors I see while debugging the issue:
Jun 10 02:22:04 backboardd(CoreBrightness)[63] <Error>: invalid parameters Jun 10 02:22:04 nearbyd[126] <Error>: onHIDEvent HIDServiceClient is nil Jun 10 02:22:04 CAReportingService[197] <Error>:     CAReportingSession.mm:309   no backends found, this session won't get sent to the server Jun 10 02:22:04 backboardd(CoreBrightness)[63] <Error>: invalid parameters Jun 10 02:22:04 nearbyd[126] <Error>: onHIDEvent HIDServiceClient is nil Jun 10 02:22:04 securityd(CoreFoundation)[119] <Error>: attempt to set <private> for key in <private> in non-persistent preferences domain CFPrefsPlistSource<> (Domain: securityd, User: kCFPreferencesCurrentUser, ByHost: No, Container: (null), Contents Need Refresh: Yes) Jun 10 02:22:04 kbd(KeyboardServices)[259] <Error>: -[_KSUserWordsSynchroniser accountDidChange:]_block_invoke  Disabling syncing if necessary as no compatible account found Jun 10 02:22:04 tccd[42] <Error>: -[TCCDAccessIdentity initWithMessage:]: self.bundle=0x0, bundle:(null); for: com.apple.sensorkit.dummy-bundle-id Jun 10 02:22:04 itunescloudd[187] <Error>: Received unsupported darwin notification com.apple.tcc.access.changed Jun 10 02:22:04 amsaccountsd[85] <Error>: CKContainer: [F636E922] accountInfo.accountStatus == CKAccountStatusCouldNotDetermine Jun 10 02:22:04 SpringBoard(KeyboardArbiter)[60] <Error>: HW kbd: Failed to set keyboard focus pid: (com.apple.mobileslideshow.photo-picker) scene:(null) Jun 10 02:22:04 (AXRuntime)[4287] <Error>: Unknown client: <myapp> Jun 10 02:22:04 searchpartyd[139] <Error>: iCloud Account not available! Jun 10 02:22:04 cloudpaird[67] <Error>: iCloud Account not available! Jun 10 02:22:04 accountsd(AccountsDaemon)[111] <Error>: "Cannot check access to a private account type: <private>" Jun 10 02:22:04 accountsd(AccountsDaemon)[111] <Error>: "Client (<private>) attempted to access restricted account type: <private>" Jun 10 02:22:04 accountsd(AccountsDaemon)[111] <Error>: Unentitled access by client 'PhotoPicker' (selector: <private>) Jun 10 02:22:04 PhotoPicker(Accounts)[4296] <Error>: "Error returned from daemon: Error Domain=com.apple.accounts Code=7" Jun 10 02:22:04 amsaccountsd[85] <Error>: AMSDHomeKitDataSource [] Failed to fetch the device's homes. HomeKit isn't ready. status = 0 Jun 10 02:22:04 amsaccountsd[85] <Error>: AMSDHomeKitDataSource [] Failed to fetch the device's homes. HomeKit isn't ready. status = 0 Jun 10 02:22:04 amsaccountsd[85] <Error>: AMSDMultiUserController: [] The refresh failed. error = { Error domain=AMSErrorDomain, code=13 } Jun 10 02:22:04 tccd[42] <Error>: -[TCCDAccessIdentity initWithMessage:]: self.bundle=0x0, bundle:(null); for: com.apple.sensorkit.dummy-bundle-id Jun 10 02:22:04 PhotoPicker(DataDeliveryServices)[] <Error>: Error for queryMetaDataSync: 2 Jun 10 02:22:04 PhotoPicker(DataDeliveryServices)[] <Error>: Error for queryMetaDataSync: 2 Jun 10 02:22:04 PhotoPicker(DataDeliveryServices)[] <Error>: Error for queryMetaDataSync: 2 Jun 10 02:22:04 PhotoPicker(DataDeliveryServices)[] <Error>: Error for queryMetaDataSync: 2 Jun 10 02:22:04 PhotoPicker(libCoreFSCache.dylib)[] <Error>: Errors found! Invalidating cache... Jun 10 02:22:04 homed(HomeKitBackingStore)[198] <Error>: [com.apple.homekit.camera.clips] [] Manatee is not currently available; waiting for CKAccountChangedNotification to check again Jun 10 02:22:04 siriactionsd(WorkflowKit)[99] <Error>: -[WFDatabase(Sync) clearTombstonesAndSyncState]_block_invoke Failed to perform batch deletion of non-visible workflows: Error Domain=NSCocoaErrorDomain Code=134060 "A Core Data error occurred." UserInfo={Reason=Delete rule is not supported for batch deletes, Relationship=ShortcutActions.shortcut} Jun 10 02:22:05 PhotoPicker(libCoreFSCache.dylib)[] <Error>: Errors found! Invalidating cache... Jun 10 02:22:05 PhotoPicker(libCoreFSCache.dylib)[] <Error>: Errors found! Invalidating cache... Jun 10 02:22:06 kbd(KeyboardServices)[] <Error>: -[_KSUserWordsSynchroniser accountDidChange:]_block_invoke  Disabling syncing if necessary as no compatible account found
Appreciate any help on this.
Thanks in advance.

Same problem here. It happened to me when I called "getPictures()" and then "Select Photos" and then hit cancel. Every time after that it will open with just a blank image gallery.

I'm also facing  the same issue. Please give update on this?

How do you solve it

I'm facing the same issue on iOS 15 too.


Make Rsp a unit struct

No need for dummy data—a struct with no fields is a unit-like struct, which is I think what you tried to do onstream but forgot the syntax for.

Yep, that's definitely what I was trying to do! The time pressure of my laptop dying didn't help with the "forgetting the syntax" part either :) I'll accept this when I stream again tonight; thanks!


DO NOT MERGE! Fast Forward stable to 6c8cc2056c14b8574bb2f626d9b5c25122163019.

This PR will be merged automatically once checks are successful.

Jenkins job auth/postsubmit passed


borgbackup: 1.1.10 → 1.1.11

Motivation for this change
New upstream release. https://github.com/borgbackup/borg/blob/1.1.11/docs/changes.rst#version-1111-2020-03-08
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Poking @flokli @globin @dotlambda


Change README with latest changes in IDE and etc.

[x] removing information about vscode-insiders because all features now already shipped to stable version of VSCode
[x] information about running example of integration tests using jest-puppeeter.
[x] Move EN section to top

Now readme contains all changes inside project, example of running integration tests for example of bot + mad-fake-slack + few info about test api


⚠ Mobitopup has degraded performance

In 75d33e4, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 4541 ms

Resolved: Mobitopup performance has improved in f5efb0c.


chore: Add issue-template, pull request template and contributing guide

@jagyugyaerik please check. Note that some sections are labeled as TODO


Call forge build as part of kontrol build

This way users only have to remember the kontrol command.
The flow should not break if the user calls forge build themselves.

@tothtamas28 where does this fall in the overall priority spectrum? I think this is a good UX improvement, but not sure if I would classify it as customer impacting or a performance improvement, so I am thinking I would classify it as a UX improvement and move to to Medium High. Your thoughts on this?

I would classify it as a UX improvement

I agree.

and move it to Medium High

Maybe Medium even, this is not high priority (though easy to implement and thus clear from the board).

Confirmed by Hao on 28 Sep. Closing Issue.


fix: safe batch write

Context
We faced with value missing error sometimes. I think it is related to recent works of nodekey refactoring and batch flusher.

Before batch flusher, we have one atomic batch write but now there can be several batch writes, so some batch data can be away when the app is in panic.
Originally, we stored the root in the last order but now it is stored at first after nodekey refactoring

As a result, there may be a situation that has only a root node, not entire nodes storing.
Action
Refactored the storing nodes order to save the root at last

were you able to test the issue berachain ran into here?

It should be possible to prove the theory in this PR as to the cause of value missing error.  Can you create a failing test case which is then fixed by this patch?

It should be possible to prove the theory in this PR as to the cause of value missing error. Can you create a failing test case which is then fixed by this patch?

The main reason of this issue is due to batch writing breaks, I have no idea of how to break the batch writing in test

@elias-orijtech  @odeke-em
This is a PR that was mentioned before. I struggle to add test cases since the issue concerns low-level API (batch writing).
The failure case is triggered by loading the broken tree. To break the tree state, the app should panic while writing the batch.

@cool-develope I don't have any comments apart from what @kocubinski said about needing a test case to make sure this PR fixes what it claims.

@cool-develope I don't have any comments apart from what @kocubinski said about needing a test case to make sure this PR fixes what it claims.

That's what I struggle now, could you help me add a test case?

Thanks @cool-develope and @tac0turtle for the ping, I am working on helping out with the test for this.

Admittedly, it's a bit hard to provide a thorough test case give we'd need to work with the internals of go leveldb batching.  I think I'm OK merging this as-is; moving the creation of the batch from pre-order to post-order should move the entire SaveVersion batch to behave like a transaction.

@mergifyio backport release/v1.x.x


LinearGradient and RadialGradient do not exist in scenegraph

Please adjust names of these classes as it doesn't work now.
https://forums.adobexdplatform.com/t/what-namespace-is-lineargradientfill/942/2
https://github.com/AdobeXD/plugin-docs/issues/179

Please see https://github.com/AdobeXD/typings/pull/41. I'm regularly pinging Adobe staff about this (among other places, in the forum post you've mentioned). Same reasoning as in https://github.com/AdobeXD/typings/issues/61...


[Table] Expand/Collapse icon can we allow the checkbox to the far left of the twisty.

Carbon, the Carbon team and Amy to define this visual style.
Assigning to Amy for clarification.
I think the design is already set in the visual UX library.
@amymillett please clarify and close.

@scottdickerson Just to clarify, we're talking about moving from something like this:
To this?

I don't think I would recommend switching the position of the checkbox and the twisty. I've never seen that pattern before and the current positioning is outlined by Carbon. It might also be a little confusing to a user.

when we have nested rows the checkboxes get stair steppy @stuckless mentioned that perhaps the checkboxes should be vertically aligned.   The checkboxes will behave differently based on the level of the hierarchy that they're within.  The child checkboxes will actually impact the parent checkbox according to the spec.


Actor w/ async method does not propagate exceptions, and hangs forever

What happened: When an Actor raises an exception within an async method, its result hangs indefinitely.
What you expected to happen: The exception to be propagated to the Future resulting from the method being called.
Minimal Complete Verifiable Example:
import dask.distributed as d
import time

class Actor:
    async def something(self):
        raise ValueError('beep')

def main():
    c = d.Client()
    a = c.submit(Actor, actor=True).result()

    p = a.something()
    time.sleep(0.1)
    print(f'About to resolve')
    print(p.result())

if __name__ == '__main__':
    main()

Anything else we need to know?:
Environment:

Dask version: 2021.04.1
Python version: 3.8.1
Operating System: Ubuntu
Install method (conda, pip, source): pip

Thanks for raising an issue @wwoods. @martindurant does https://github.com/dask/distributed/pull/4232 close this?

Yes!
ValueError: beep

Cool! Any idea when that change set might make it into a dask release?

@jrbourbeau , do you want to take this opportunity to review and maybe merge?

Ping, any reason not to merge this?


Is there a way to open the dateRangePickerWrapper without the dateRangePicker ?

Hi guys,
I would love to have a button that can open / close the actual dateRangePickerWrapper without having the dateRangePicker (that preview the dates)
What would be the best way to do it ? I read the documentation, and didn't find anything about it.
Thanks in advance

NVM, I was just tired : I just figured out the DayPickerRangeController component, that I can use directly
Sorry about that
👋


proposal: SHARED_INTERFACES documentation effort

"JavaScript Shared interfaces" is a documentation effort to explain how cross-environment ("isomorphic") JavaScript code can be written. My hope is that this can help convergence between different platforms over time.

I think this is a good example of the kind of activities that would be great to sheppard under the merged foundation.


tmux ctrl+b not working

can't seem to do ctl+b then d to shut windows in tmux anymore

I remapped ctrl-b to screen-like ctrl-a (https://github.com/deathbeam/awesomedotrc/blob/master/dotfiles/tmux.conf#L7)

So I want to delete everything before before line 36 to have default bindings but the UI changes and plugins?

Yes exactly. Also, if you really want to stick to tmux defaults, remove tmux-sensible on this line too.

Ok thanks! It looks like sensible mostly adds new commands so I might keep that.
Just too use to ctl+d at this point.


Enhancement pressure control

Adding pressure control has ended up being a bigger project than expected. Below are the improvements so far.

Overhauled auto brew library with reference styles (i.e. is the leg tracking a power settings, a flow, or a pressure?) ending triggers, and timeouts. This was merged during a previous "cleanup".
Updated the local_ui library to provide action folders with a caller defined integer data field. This made it much easier to know which folder was calling the callback and, therefore, which setting to update.
Overhaul of machine_setting library. Instead of an internally managed array linked to an externally visible struct, a getter function is now used to retrieve values using an enumerated list of setting ID's. I also added settings for 9 auto brew legs requiring a total of 63 new setting values.
How the auto brew routine is built in espresso_machine.c has been updated to use all the new changes above. Instead of a rigid structure, it now loops through the settings for the 9 possible legs and constructs a new leg if they have a non-zero timeout. This lets the user have much greater flexibility (though, I will admit, it is a pain setting it up using the local_ui, but this will be fixed when a mobile UI is added).

Overall, these changes make the firmware more flexible, both for future extensions and operations.

This branch hasn't been extensively tested, but I am waiting on my grinder and have some other things I want to work on. It'll be easiest to merge this and then make new branches from development.


Remove engine requirement from package.json

Investigate if exists an engine reuiqrement specific for electron

See https://github.com/sindresorhus/electron-debug/issues/17


fix: add no_log: true for tasks that can log secret data

Cause: Some tasks handle secret data and log the contents.
Consequence: The logs can show secret data if verbose logging
is used.
Fix: Add the no_log: true directive to tasks that can log
secret data.
Result: Secret data is not logged with verbose logging.
Some of the tests use Ansible vault for passwords.
Signed-off-by: Rich Megginson<EMAIL_ADDRESS>

[citest]


TDR-3178 - Show back link and "Start a new transfer" link if the user doesn't have any consignments

need to work for judgment users too

Thanks for raising this point. I forgot to do it for the judgment user. I have added it now, thanks.


How to fix files on a directory recursively? ( WIN 10 )

.\nerdfix.exe check --recursive "C:\Program Files\Neovim"
Does checking on a directory but
.\nerdfix.exe fix --recursive "C:\Program Files\Neovim"
gives error
←[33m WARN←[0m Output path is ignored when --recursive: \Program Files\Neovim
←[31mERROR←[0m Failed when traversing directories, IO error for operation on C: The system cannot find the file specified. (os error 2)

ahhh, that’s a bug: nerdfix supports save fixed file to a different path through the nerdfix fix input:output syntax, so C:\Program Files\Neovim is considered as two paths, C and \Program Files\Neovim. I will fix this later. Currently, you can cd C:\Program Files\Neovim and nerdfix fix —recursive . for a workaround.


"msg": "Failed to import the required Python library (openshift) advice required.

Hi
Quick bit of advice required to get past error msg.
Don’t really want to be installing anything other than what is required, I have run the required scripts ,, all dependencies are satisfied but hit this error
},
"msg": "Failed to import the required Python library (openshift) on slavmpoc01's Python /usr/bin/python2. Please read module documentation and install in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"

}
PLAY RECAP ***********************************************************************************************************************************************************************************************************************
localhost                  : ok=27   changed=3    unreachable=0    failed=1    skipped=32   rescued=0    ignored=0
azureuser@slavmpoc01:~/sas/viya4-deployment$ sudo -H  pip3 install openshift
Requirement already satisfied: openshift in /root/.local/lib/python3.6/site-packages
Requirement already satisfied: six in /usr/lib/python3/dist-packages (from openshift)
Requirement already satisfied: jinja2 in /usr/lib/python3/dist-packages (from openshift)
Requirement already satisfied: ruamel.yaml in /root/.local/lib/python3.6/site-packages (from openshift)
Requirement already satisfied: python-string-utils in /root/.local/lib/python3.6/site-packages (from openshift)
Requirement already satisfied: kubernetes~=12.0 in /root/.local/lib/python3.6/site-packages (from openshift)
Requirement already satisfied: ruamel.yaml.clib>=0.1.2; platform_python_implementation == "CPython" and python_version < "3.10" in /root/.local/lib/python3.6/site-packages (from ruamel.yaml->openshift)
Requirement already satisfied: certifi>=14.05.14 in /usr/lib/python3/dist-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: google-auth>=1.0.1 in /root/.local/lib/python3.6/site-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: urllib3>=1.24.2 in /root/.local/lib/python3.6/site-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: pyyaml>=3.12 in /usr/lib/python3/dist-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: requests in /usr/lib/python3/dist-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: python-dateutil>=2.5.3 in /root/.local/lib/python3.6/site-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: requests-oauthlib in /root/.local/lib/python3.6/site-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: websocket-client!=0.40.0,!=0.41.,!=0.42.,>=0.32.0 in /root/.local/lib/python3.6/site-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: setuptools>=21.0.0 in /usr/lib/python3/dist-packages (from kubernetes~=12.0->openshift)
Requirement already satisfied: rsa<5,>=3.1.4; python_version >= "3.6" in /root/.local/lib/python3.6/site-packages (from google-auth>=1.0.1->kubernetes~=12.0->openshift)
Requirement already satisfied: pyasn1-modules>=0.2.1 in /usr/lib/python3/dist-packages (from google-auth>=1.0.1->kubernetes~=12.0->openshift)
Requirement already satisfied: cachetools<5.0,>=2.0.0 in /root/.local/lib/python3.6/site-packages (from google-auth>=1.0.1->kubernetes~=12.0->openshift)
Requirement already satisfied: oauthlib>=3.0.0 in /root/.local/lib/python3.6/site-packages (from requests-oauthlib->kubernetes~=12.0->openshift)
Requirement already satisfied: pyasn1>=0.1.3 in /usr/lib/python3/dist-packages (from rsa<5,>=3.1.4; python_version >= "3.6"->google-auth>=1.0.1->kubernetes~=12.0->openshift)
azureuser@slavmpoc01:~$ sudo ansible --version | grep "python version"
python version = 2.7.17 (default, Feb 27 2021, 15:10:58) [GCC 7.5.0]

OK started with 20:04,, went through and installed all requirements, set env variables etc.
some minor issues with component installs. im about 99% there now.. Hit the following bug during the install ,,
],
"delta": "0:00:00.056882",
"end": "2021-10-31 07:31:13.878246",
"invocation": {
    "module_args": {
        "_raw_params": "kustomize build /home/azureuser/viya4-deployment/slazsas-aks/viya --load_restrictor='none' -o /home/azureuser/viya4-deployment/slazsas-aks/viya/site.yaml\n",
        "_uses_shell": false,
        "argv": null,
        "chdir": null,
        "creates": null,
        "executable": null,
        "removes": null,
        "stdin": null,
        "stdin_add_newline": true,
        "strip_empty_ends": true,
        "warn": true
    }
},
"msg": "non-zero return code",
"rc": 1,
"start": "2021-10-31 07:31:13.821364",
"stderr": "Error: unknown flag: --load_restrictor",
"stderr_lines": [
    "Error: unknown flag: --load_restrictor"
],
"stdout": "",
"stdout_lines": []

Resolved and installed
Thank you for your help thomas..
kustomize version was incorrect 4.X rather than 3.7.0


Default Language in config file

HI! Thank you so much for making this, it saved me a bunch of work and it looks amazing!
Two really small nitpicks that threw me off at first

The plugin.cfg file does not have a default language set of C# (Godot seems to thing the plugin should be added as GDScript)
The README file steps don't mention that you have to build your project after you add it to the addons folder

Again, thank you so much for this!

This should be fixed now.


added: Data section, Forker's Shoes section

Combined several items into one section about data.
A "design thinking" section for things specifically about helping your forker get into your head when you aren't there to help. Inline comments about code. Whatever you have about users, uses, usage.
a few small edits too, for spelling, punctuation, readability.

:couplekiss: great stuff, thank you!


Big Rock: URL generation for pages

I have a proposal after spending some time with this. It feels very complimentary to what we have elsewhere in the system.
I know that this proposal can work because it's just a small twist on what we already have implemented. Doing something as simple as what's proposed here is beneficial because it doesn't require a lookup table or any custom logic for pages, it's just routing.
Proposal - Page Names
Conceptually, each page has a name that uniquely identifies it.
By default, the page name will be it's relative path based at the pages root directory, with unnecessary noise like the leading slash and file extension trimmed. This means that for a site with the root path of /Pages, then /Pages/Index.cshtml is Index, /Pages/Account/Signup.cshtml is Account/Signup and so on. Again, these are the defaults, and they are the way they are so that each page has an intuitive, typable name, and so that there are no collisions.
Overriding Page Names
You can customize a page name by giving a logical name either through application model, or as an additional token in the @page directive.
@page Directive
@page "{id}" "GetWidget"

Application Model
.AddRazorPagesOptions(options => options.SetPageName("/Account/Login", "Login"))

Generating URL UX
Now for the fun stuff. This just works.
Tag Helpers
...

HTML Helpers
@Html.RouteLink(new { page = "GetWidget", id = 17 }) { ... }

IUrlHelper
@Url.Route(new { page = "GetWidget", id = 17 });

This is all just basic routing using the existing APIs. We can make it a lot nicer by adding some convenience APIs.
Tag Helpers
...

HTML Helpers
@Html.PageLink("GetWidget", new { id = 17 }) { ... }

IUrlHelper
@Url.Page("GetWidget", new { id = 17 });

What I like about it
I like this model because there's no ceremony if you want to just do the default, but you can give a logical name to the things that you commonly deep link to.

I think the most obvious reaction is to look at a mapping like /Pages/Account/SignUp.cshtml -> Account/SignUp and say something like

😲 That's it? That doesn't abstract away the URL.

Yeah. That's it. Pages is low ceremony, what's simpler than files on disk and URLs in a hierarchy?
I think that 80% of the value that our URL generation system provides is in how we're able to parameter substitution in the URL and dynamically build the query string. Basically getting you out of the concatenation game.
For the other 20% think about defining a logical name for your pages that support deep linking. If it's worth it, it's worth it. I had some similar thought here this week so it's in my brain right now. For someone looking to abstract away the physical URL from the logical unit of a linking, we don't have a lot of tools right now. This is something that I think this proposal actually does better than controllers with conventional routing, and about the same as controllers with attribute routing.

/cc @DamianEdwards @Eilon @davidfowl

Appendix A: Additional Convenience Methods
We might also want to consider an additional set of convenience methods for when you want to link to a sibling. This makes it easier to rename a folder without breaking the world.
Names intentionally awful
Imagine you want to link from /Pages/Blog/Index.cshtml to /Pages/Blog/Edit.cshtml?id=17
Tag Helpers
...

HTML Helpers
@Html.PageSiblingLink("Edit", new { id = 17 }) { ... }

IUrlHelper
@Url.PageSibling("Edit", new { id = 17 });

This isn't a new routing system, it's just transformations on a string. The page name of the current page is Blog/Index. These apis would pull that out of route data and then generate a link using the page name Blog/Edit by removing the last segment and concatenating Edit.

I love all of this, and it's absolutely required. We can't ship without something like this, as URL generation is one of the most painful parts of linking and redirecting between pages. Let's do it.

@pranavkm - please start on this after we resolve all of the tooling/VSIX/build/signing, Let's ignore everything in Appendix A for now

By default, the page name will be it's relative path based at the pages root directory, with unnecessary noise like the leading slash and file extension trimmed.

Should we do that for the ViewEnginePath too? With this change, we'll have one way to refer to a page in Startup e.g. options.Authorize("/Pages/Admin/Home"), but an ever so slightly different way (sans leading slash) when using it in routing e.g. @Url.Route(new { page = "Pages/Admin/Home" }). I think it might be better to not have the leading slash in both.


LINT-10: Upgrade curly spacing

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword WEBAPP.

Sorry for the late review. Forgot about it :/