[Feature] Implement a new architecture SVG image for OpenDigger

Is there an existing issue for this?

[X] I have searched existing issues, it hasn't been reported yet

Use case description
Since after the refactor of documentation, we will move each part of the documentation into different pages like metrics and applications. So we should have an interactive architecture SVG in top level README for users to better understand OpenDigger.
Proposed solution (optional)
We can refer to the architecture SVG of Hypertrons: https://blog.frankzhao.cn/images/arch.svg , the SVG file contains elements layouts, styles and interactive script, so it can be interactive and can support multiple languages at once.
Although this SVG file can not be properly rendered in GitHub markdown file due to security reason, we can embed the image in the website

We can have two variants of the same SVG image, one for ZH (default) and the other EN, and we can conditionally render either of them as per the currentLocale of the website. Curious, is the image of the architecture SVG of Hypertrons updated?

The image is just an experiment SVG image and not updated now. But actually the image also accepts parameters which can effect the behavior of the image like you can use this URL (https://blog.frankzhao.cn/images/arch.svg?lang=zh&bg_color=green) to get an image with zh language by default and set the background color to green. So pass parameter to SVG image is also feasible.


Skip any files with no abis

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (449d977) to head (06013c6).

Files
Patch %
Lines

pypechain/main.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   63.71%   63.69%   -0.03%
==========================================
  Files          49       49
  Lines        2555     2556       +1
==========================================
  Hits         1628     1628
- Misses        927      928       +1

Flag
Coverage Δ

unittests
63.69% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Indian Flag using python

@sakshigupta08 Please first fetch from original repo then send PR.

See you don't have recent update repo with you.

@sakshigupta08 Please first fetch from original repo then send PR.

See you don't have recent update repo with you.

Hi @sakshigupta08
I can help you if you still stuck
If you still have a problem with fetching the repository:

After forking it, Open CMD or git bash and type : git clone <forked-repo-link>
then cd to the repository directory and type: git remote add upstream <original-repo-link>
then type : git fetch upstream
then type: git merge upstream/main

After that make your changes and push them and open a PR.
I hope this helps you @sakshigupta08
If I am wrong, please correct me @Kushal997-das  @SamarpanCoder2002
Thanks

Hi @sakshigupta08
I can help you if you still stuck
If you still have a problem with fetching the repository:

After forking it, Open CMD or git bash and type : git clone <forked-repo-link>
then cd to the repository directory and type: git remote add upstream <original-repo-link>
then type : git fetch upstream
then type: git merge upstream/main

After that make your changes and push them and open a PR.
I hope this helps you @sakshigupta08
If I am wrong, please correct me @Kushal997-das  @SamarpanCoder2002
Thanks

Hi @sakshigupta08
I can help you if you still stuck
If you still have a problem with fetching the repository:

After forking it, Open CMD or git bash and type : git clone <forked-repo-link>
then cd to the repository directory and type: git remote add upstream <original-repo-link>
then type : git fetch upstream
then type: git merge upstream/main

After that make your changes and push them and open a PR.
I hope this helps you @sakshigupta08
If I am wrong, please correct me @Kushal997-das @SamarpanCoder2002
Thanks

@TawfikYasser 👍

Hi @sakshigupta08
I can help you if you still stuck
If you still have a problem with fetching the repository:

After forking it, Open CMD or git bash and type : git clone <forked-repo-link>
then cd to the repository directory and type: git remote add upstream <original-repo-link>
then type : git fetch upstream
then type: git merge upstream/main

After that make your changes and push them and open a PR.
I hope this helps you @sakshigupta08
If I am wrong, please correct me @Kushal997-das @SamarpanCoder2002
Thanks

@TawfikYasser 👍

Are you gonna change this ? @sakshigupta08

Hi @Kushal997-das ,Can I help @sakshigupta08 by uploading the project?

Hi @Kushal997-das ,Can I help @sakshigupta08 by uploading the project?

Yes please

Hi @Kushal997-das ,Can I help @sakshigupta08 by uploading the project?

Yes please

Okay i will do that tomorrow @sakshigupta08

Hi @Kushal997-das ,Can I help @sakshigupta08 by uploading the project?

No because if you help then she is unable to learn the things like how to do work in open source.
What project guidance motive is we want to help people in open source and also help them by providing projects ideas as well.
I hope it make sense.
P. S. You can tell her what to do but you can't do her work.

Okay @Kushal997-das Thanks


[Dev-tool] After booting by weex run ios, run through xcode debugging, and occasionally crash where weex CLI version 2.0.0-beta.25!

Describe the bug

After booting by weex run ios, run through xcode debugging, and occasionally crash, the prompt is as follows
To Reproduce

Environment
模拟器  mac os 10.14.4
weex CLI version 2.0.0-beta.25!
Screenshots

Hotreload server is actived, enjoy your develop Type Ctrl+C to exist Error: WebSocket is not open: readyState 3 (CLOSED)     at WebSocket.send (/Users/dt/.wx/modules/node_modules/_ws@6.2.1@ws/lib/websocket.js:329:19)     at FSWatcher.filesWatcher.fs.watch (/Users/dt/.wx/modules/node_modules/_@weex-cli_run@2.0.0-beta.21@@weex-cli/run/lib/base/runner.js:82:20)     at FSWatcher.emit (events.js:189:13)     at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:131:12) Error: WebSocket is not open: readyState 3 (CLOSED)     at WebSocket.send (/Users/dt/.wx/modules/node_modules/_ws@6.2.1@ws/lib/websocket.js:329:19)     at FSWatcher.filesWatcher.fs.watch (/Users/dt/.wx/modules/node_modules/_@weex-cli_run@2.0.0-beta.21@@weex-cli/run/lib/base/runner.js:82:20)     at FSWatcher.emit (events.js:189:13)     at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:131:12) Error: stdout maxBuffer exceeded     at PassThrough.stream.on (/Users/dt/.wx/core/node_modules/_get-stream@3.0.0@get-stream/index.js:30:12)     at PassThrough.emit (events.js:194:15)     at addChunk (_stream_readable.js:284:12)     at readableAddChunk (_stream_readable.js:261:13)     at PassThrough.Readable.push (_stream_readable.js:220:10)     at PassThrough.Transform.push (_stream_transform.js:151:32)     at PassThrough.afterTransform (_stream_transform.js:92:10)     at PassThrough._transform (_stream_passthrough.js:42:3)     at PassThrough.Transform._read (_stream_transform.js:190:10)     at PassThrough.Transform._write (_stream_transform.js:178:12)     at doWrite (_stream_writable.js:410:12)     at writeOrBuffer (_stream_writable.js:394:5)     at PassThrough.Writable.write (_stream_writable.js:294:11)     at Socket.ondata (_stream_readable.js:667:20)     at Socket.emit (events.js:189:13)     at addChunk (_stream_readable.js:284:12)

@jakswa

As this is a problem of weex-toolkit, you should ask in their repo, not here.
Thanks for your cooperation.


java.io.IOException when vendored tarfile uses path that's not relative to workspace root

This is a bug report in the form of a failing test.
The existing e2e/vendored_tarfile tests dependencies of the form file:<path>.tgz. The path it uses happens to be relative to the workspace root. Bazel supports such file: URLs. Bazel does not support file: URLs with paths that are relative to any other location, as may occur when package.json is not at the workspace root. Attempting to use such a package.json with npm_translate_lock produces a java.io.IOException attempting to download the file.
To reproduce, run bazel clean --expunge && bazel test --repository_cache= //... in e2e/vendored_tarfile. The expunge and --repository_cache= ensure that no cached repository or download artifact is used.
Expected result: completes successfully.
Actual result:
ERROR: An error occurred during the fetch of repository 'npm__lodash__4.17.21':
   Traceback (most recent call last):
	File "/private/var/tmp/_bazel_john/d601fbcd5200d602e76906b7acaddff2/external/aspect_rules_js/npm/private/npm_import.bzl", line 494, column 38, in _npm_import_rule_impl
		_download_and_extract_archive(rctx)
	File "/private/var/tmp/_bazel_john/d601fbcd5200d602e76906b7acaddff2/external/aspect_rules_js/npm/private/npm_import.bzl", line 452, column 18, in _download_and_extract_archive
		rctx.download(
Error in download: java.io.IOException: Error downloading [file:../a/lodash-4.17.21.tgz] to /private/var/tmp/_bazel_john/d601fbcd5200d602e76906b7acaddff2/external/npm__lodash__4.17.21/package.tgz: ../a/lodash-4.17.21.tgz (No such file or directory)

The generated repositories.bzl in the npm repository contains:
        url = "file:../a/lodash-4.17.21.tgz",

Instead, this URL should be relativized to the workspace root, i.e.
        url = "file:a/lodash-4.17.21.tgz",

Can you reproduce it without removing the existing test case? Probably just add a second pnpm-lock in a subdir?

If there are two lockfiles that both reference lodash-4.17.21.tgz, then the bug might not reproduce reliably due to caching effects. Specifically, if the download cache already contains the tarball, then Bazel won't try to download it from the file:../a/lodash-4.17.21.tgz URL. That's why my repro instructions include bazel clean --expunge and --repository_cache=.
I don't necessarily expect this PR to be merged, I just wanted to demonstrate the bug.


Cannot excute foreman start

When i follow the pos of " How to: running a stand alone worker "
And i excute ' foreman start'  then got errors:
/Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/gems/foreman-0.77.0/lib/foreman/process.rb:54:in `spawn': Permission denied - bin/myworker (Errno::EACCES)
	from /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/gems/foreman-0.77.0/lib/foreman/process.rb:54:in `block in run'
	from /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/gems/foreman-0.77.0/lib/foreman/process.rb:53:in `chdir'

So I excute ' sudo foreman start' then got errors:
Users/fancy/.rvm/rubies/ruby-2.0.0-p598/lib/ruby/site_ruby/2.0.0/rubygems/dependency.rb:315:in `to_specs': Could not find 'foreman' (>= 0) among 13 total gem(s) (Gem::LoadError)
Checked in 'GEM_PATH=/Users/fancy/.gem/ruby/2.0.0:/Users/fancy/.rvm/rubies/ruby-2.0.0-p598/lib/ruby/gems/2.0.0', execute `gem env` for more information
	from /Users/fancy/.rvm/rubies/ruby-2.0.0-p598/lib/ruby/site_ruby/2.0.0/rubygems/dependency.rb:324:in `to_spec'
	from /Users/fancy/.rvm/rubies/ruby-2.0.0-p598/lib/ruby/site_ruby/2.0.0/rubygems/core_ext/kernel_gem.rb:58:in `gem'
	from /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/bin/foreman:22:in `<main>'
	from /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/bin/ruby_executable_hooks:15:in `eval'
	from /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/bin/ruby_executable_hooks:15:in `<main>'

I am on Mac OS X 10.9.5

Hi, please verify that bin/myworker is runnable (chmod +x bin/myworker).
The reason sudo isn't working, probably because your sudoer user doesn't have Foreman installed.

@jondot  Thx, you are right.
However i have a new question now
 $ foreman start
18:24:44 myworker.1 | started with pid 91607
18:24:44 myworker.1 | bin/myworker:13:in `<main>': uninitialized constant Sneakers::Metrics (NameError)
18:24:44 myworker.1 | exited with code 1
18:24:44 system     | sending SIGTERM to all processes

Can U help me please ? :)

@jondot
Here's my 'myworker' file's content
#!/usr/bin/env ruby
require 'bundler/setup'
root = File.expand_path('../lib',File.dirname(__FILE__))
$: << root
require 'myworker'
require 'sneakers/runner'
require 'logger'
require 'statsd-ruby'

statsd = Statsd.new('localhost', 9125)

Sneakers.configure( :daemonize => false, :log => STDOUT, :metrics => Sneakers::Metrics::StatsdMetrics.new(statsd))
Sneakers.logger.level = Logger::INFO

r = Sneakers::Runner.new([ Myworker ])
r.run

@jondot Hi, i am back.
Here is my new question and i have tried many time...
Can U help me ? Thx
The code:
#!/usr/bin/env ruby
require 'bundler/setup'
root = File.expand_path('../lib',File.dirname(__FILE__))
$: << root
require 'myworker'
require 'sneakers/runner'
require 'logger'
require 'statsd-ruby'

statsd = Statsd.new(ENV['STATSD_HOST'], 9125)

Sneakers.configure( :amqp => ENV['AMQP_URL'], :daemonize => false, :log => STDOUT, :metrics => Sneakers::Metrics::StatsdMetrics.new(statsd))
Sneakers.logger.level = Logger::INFO

r = Sneakers::Runner.new([ Myworker ])
r.run

And got errors:
 $ foreman start
20:27:20 myworker.1 | started with pid 9883
20:27:20 myworker.1 | bin/myworker:13:in `<main>': uninitialized constant Sneakers::Metrics (NameError)
20:27:20 myworker.1 | exited with code 1
20:27:20 system     | sending SIGTERM to all processes

Sure, try require 'sneakers/metrics/statsd_metrics'

@jonot yeah, i require it  and next step got errors:
 $ foreman start
11:28:32 myworker.1 | started with pid 8447
11:28:33 myworker.1 | /Users/fancy/ruby_projects/myworker/lib/myworker.rb:3:in `<top (required)>': Myworker is not a class (TypeError)
11:28:33 myworker.1 | 	from bin/myworker:5:in `require'
11:28:33 myworker.1 | 	from bin/myworker:5:in `<main>'
11:28:33 myworker.1 | exited with code 1
11:28:33 system     | sending SIGTERM to all processes

So i require 'sneakers' and got new errors :
unner.rb:12:in `run'
11:29:36 myworker.1 |   bin/myworker:19:in `<main>'
11:29:36 myworker.1 | Unexpected error undefined method `new' for Myworker:Module
11:29:36 myworker.1 |   /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/gems/sneakers-1.0.1/lib/sneakers/workergroup.rb:22:in `block in run'
11:29:36 myworker.1 |   /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/gems/sneakers-1.0.1/lib/sneakers/workergroup.rb:22:in `map'
11:29:36 myworker.1 |   /Users/fancy/.rvm/gems/ruby-2.0.0-p598@rails4/gems/sneakers-1.0.1/lib/sneakers/workergroup.rb:22:in `run'

Here is myworker.rb :
require "myworker/version"

module Myworker
  # Your code goes here...
end

Now i just want to add a worker like this :
class MyWorker
  include Sneakers::Worker
  from_queue 'dashboard.posts'

  def work(msg)
    logger.info "hello #{msg}"
    manual_ack!
  end
end

What should i do please ?


Adding the ability to get basic information about the monitor

This pr adds the ability to get basic information about the primary monitor through the function win.GetPrimaryMonitor() which returns a new struct monitor. This is more a proposal of a feature that should be added than a pull request that should be immediatly merged as theres probably a way to do this that fits much better with the library however I do not have the programming skills or familiarity with this project to do it. Please note this runs glfw.init() when called which means the functions probably do bad things if called after the window is created and theres probably some sneaky side effects.

Thanks! Something like this definitely wants to be in. I'll think about it and let you know the exact API I'd like to have.
Sorry for taking so long to respond, I've been onto some other things the last few days.

Hi, I thought about this, and I don't think I'm going to add this feature, at least not yet. This package is so far only for creating windowed applications, so the utility of this isn't very high. It would also complicate the question of initialization. Sorry, perhaps later.


Bump redis dependency version

This pull request adresses several issues:

https://rubygems.org/gems/rollout - redis gem is not listed as Runtime dependency which leads to lots of problems :)

redis gem version is too old. 0.1 version was released on October 28, 2009. It throws RuntimeError: -ERR Unknown Command and tests fail.

Make it easier to install locally and run specs

A note about redis gem versions(https://github.com/ezmobius/redis-rb):
Versions 1.0.x target all versions of Redis. You have to use this one if you
are using Redis < 1.2.

Version 2.0 is a big refactoring of the previous version and makes little
effort to be backwards-compatible when it shouldn't. It does not support
Redis' original protocol, favoring the new, binary-safe one. You should be
using this version if you're running Redis 1.2+.

Redis database release schedule:
http://code.google.com/p/redis/downloads/list

I don't want to merge this because you removed jeweler. I don't understand why you removed jeweler in a pull request that you titled "Bump redis dependency version".
Also, I'm willing to change the redis dependency version to >= 0, but not to as specific a version as you put here. Lots of people are still on old redis versions and this would prevent them from using rollout, which makes no sense.


Add Support for User-Defined Gateway Addresses

#352 adds support for managing gateway status addresses. However, this PR does not support user-defined Gateway addresses. Therefore, EG should compare the status address of the Gateway's associated service against the user-defined address and surface the proper Gateway status condition.

hi, is this issue still available? i'd like to working on it.

Great, thanks @shawnh2

@shawnh2 the Gateway API allows the user to define a custom address at the Gateway level
https://github.com/kubernetes-sigs/gateway-api/blob/a78e09220feec7947eb1a08b658b45f3b4182d7f/apis/v1beta1/gateway_types.go#L142
we need to first figure out if we / Envoy Gateway can support this feature or not i.e. can we set these addresses on the K8s Service or not.
If that is possible, we will also need to read those values and update the status https://github.com/envoyproxy/gateway/blob/f81c0118ca0c487db16ee3d54ae21e94a705a348/internal/status/gateway.go#L25

as @tommie suggested, the user defined gateway addresses might need to be set in service.Spec.ExternalIPs https://kubernetes.io/docs/concepts/services-networking/service/#external-ips in the infra mgr layer and also used to update Gateway Status

I codified a PoC in https://github.com/envoyproxy/gateway/compare/release/v0.3...tommie:envoyproxy-gateway:external-ips?expand=1
It only cares about IPAddress addresses, there are no tests, etc.
Based off of v0.3 because of #1307.

I codified a PoC in https://github.com/envoyproxy/gateway/compare/release/v0.3...tommie:envoyproxy-gateway:external-ips?expand=1
It only cares about IPAddress addresses, there are no tests, etc.
Based off of v0.3 because of #1307.

hi, looking great, mind i merge it into my branch first? and i will complete the rest.

@shawnh2 go for it!

I see this issue is still open but was referenced by PR https://github.com/envoyproxy/gateway/pull/1322
which implemented support for Service.spec.ExternalIPs. However, this doesn't work for all clouds, AFAIK.
I can confirm what was mentioned here: https://github.com/envoyproxy/gateway/issues/1405#issuecomment-1538727725
is true for GKE. In GKE, it leverages the Service.spec.loadBalancerIP  field and the GKE admission controller actually
fails to create the service if ExternalIPs is filled in. https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer-parameters#spd-static-ip
Looking at the K8s docs, it says the Service.spec.loadBalancerIP was deprecated in 1.24 https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer but it doesn't say to use the ExternalIPs but rather use Gateway which is weird because all cloud vendors don't have Gateway support. When I look at the docs for the ExternalIPs it has a note saying that K8s does nothing with it and it is up to cluster administrator.
So, my questions are:

Is this issue still open? If so what is missing?
Has there been any other discussions on how to handle the Cloud Vendors that currently support the loadBalancerIP field of a service?

On 2, I'm happy to create a new issue if it is off topic but curious to see if there was any thought put into this.

@LanceEa Id prefer if we close this issue and create a new one, if we believe the feature has not been implemented correctly.
Here is the current implementation

When a user sets Gateway.Spec.Addresses , EG sets that value to the generated managed Envoy Proxy Service's ExternalIPs field which also sets (not appends)  the  value in Gateway.Status.Addresses field


How to download video and audio combined?

I tried this on my php, but the audio and video are separated in direct link.
<?php
$url = $_POST['video_link'];
$cmd ='youtube-dl -g --all-formats ' . escapeshellarg($url);
 exec($cmd, $outputsd);

https://github.com/ytdl-org/youtube-dl#format-selection


Mnefun firstgo

@ilogue pls review

Acceptance tests are failing on this. (See the Travis "details" link). Not sure why. I'll look into it.
======================================================================
FAIL: test_Attach_provenance_string_in_file_based_on_config (acceptance.test_contextAPI.ContextApiTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ilogue/niprov/acceptance/test_contextAPI.py", line 54, in test_Attach_provenance_string_in_file_based_on_config
    self.assertEqual(img.get_header().extensions.count('comment'), 1)
AssertionError: 0 != 1
----------------------------------------------------------------------

I am not even going to pretend what that means, but I see a lot of traces on Travis concerning nibabel.


feature request: batch-file to continue past errors

Checklist

[x] I'm reporting a feature request
[x] I've verified that I'm running youtube-dl version 2020.03.24
[x] I've searched the bugtracker for similar feature requests including closed ones

Description

Currently when using --batch-file, if any of the sources encounter an error, the remainder of the batch file will not be attempted.
This feature request is to allow --batch-file to continue attempting all sources, regardless of any errors encountered for any individual sources.

Read FAQ?
-i, --ignore-errors              Continue on download errors, for example to
                                 skip unavailable videos in a playlist

Yikes -- my apologies. I read the whole section surrounding --batch-file, didn't see it nearby. Should've grepped entirety for "error".


Add color to the gender label

Add symbol and color to the gender

If the gender is male, the font color will be light blue.
If the gender is female, the font color will be pink.

Generally Look good to me, I think just need to add the test cases to Person card to pass the code ev requirement then OK

@Jianwen0451 I think i have same issue with Isaac because the person card is a Ui and it is not tested at the beginning.


update-text-to-english

Landing page has 2 words in spanish.
This updates those 2 to English for consistency.

Thoughts: If we want to add localization may be good to track it.
Todo tech-spike/priority.
✅ By submitting this PR, I have verified the following
Guidelines
Copy

If adding new copy, made sure the content is clear for people to read.

[X] I used a tool like Grammarly was utilized to check for spelling and grammar.

Adding yourself as a contributor

[X] I added my name to the bottom of the list under the Credits section in the README.md with a link to my website or GitHub profile 👥

cc @EllaCodes4 FYI

Interesting point, @latinadeveloper! This was an intentional choice on my part at first, however, as LatinaDev grows, I realize our community will actually be multilingual (not limited to just Spanish but may also include Portuguese, etc.) Great point!


AttributeError: module 'gorilla' has no attribute 'track'

When preparing the ImageNet data as instructed by the readme.md inside the imagenet/ folder, I receive the error AttributeError: module 'gorilla' has no attribute 'track'. I downloaded the gorilla==0.4.0 package from https://github.com/christophercrouzet/gorilla and it seems that it doesn't have an attribute named track. Would you please provide the gorilla package you are using? Thanks!

The gorilla package is here: https://github.com/Gorilla-Lab-SCUT/gorilla-core.
You should install it by pip install gorilla-core.

It worked! Thanks!


activitypub.Collection.items incorrect logic?

The first and next variables are compared to None and set to a bool value. The isinstance(..., str) looks like it will never succeed (based on my testing).
    def items(self) -> Iterator[AnyObject]:
        items = self._delegate.json_field('orderedItems' if self.is_ordered() else 'items')
        if items is not None:
# ...
        elif first := self._delegate.json_field('first') is not None: # <-- first will always be a bool
            if isinstance(first,str): # <-- is never true?
                first_collection = AnyObject(first).as_collection()
                yield from first_collection.items()
            else:
                raise Exception(f'Cannot process yet: {first}')
        elif next := self._delegate.json_field('next') is not None:
            # similar issue for next ...

Code currently commented out, but leaving this here.


Add cosh SparkSQL function

Spark's docs: cosh

@myandpr Would you rebase so I could merge?

@myandpr Would you rebase so I could merge?

@mbasmanova Sorry for taking so long to reply due to some personal reasons.
I have rebased.

@myandpr No problem. Thank you for the contribution.


Integrate JHipster OIDC authentication type

Current generator code supports session authentication type. This issue is a placeholder to track integration with OIDC authentication type

I'd be willing to sponsor this feature if I'm given the ability to add a bug bounty.

@pascalgrimaud can you help over here?

@mraible : you should be admin of this repo, like @vishal423

@pascalgrimaud Thanks! It looks like this repo is missing bug bounty labels.

@mraible , I have added respective bug bounty labels. Let me know if you still see any discrepancies.

@vishal423 Looks good! I added a bounty. Let me know if you need more $$ or bug bounties on other issues.

Thanks @mraible . You may want to check if  #46 #172 #464 #470, #471 qualify the bounty criteria 😄

Following @deepu105 email, can we add some bounty on #46 #172 #464 #470 #471 ?
cc: @pascalgrimaud @jdubois

@vishal423 done, let me know if the amount is enough

thanks @deepu105


Move the history tab on right hand side of calculator

Fixed here: https://github.com/Ayush-Kaushik/calculator/commit/091a641d4e3401e1cb9a06ad00d9dc001b70eb46


Rewrite REPL implementation

The REPL I implemented for PhantomJS is showing loads of limits. This issue aims at being a "grab all" issue where REPL issue should be redirected.
The aim of this is to do the work once, as I believe the overall "architecture" of the REPL should be revamped (it can't just be "patched").
I take ownership for this, but feel free to beat me to it.
I'll go around the repo and link them to this and close those issues.
What's the issue
The "evaluation" of JS code is broken. I should rewrite that and the fact that we are moving to Qt5 and (I hope) to QJSEngine should make for a much better implementation.
The REPL history endling and the auto-completion I think are NOT broken and that, at least, will not need to be rewritten :)

Ditto on Alec's comment.

Dito

Unfortunately this issue is still around.

As far as I know, no one is working on this right now.  We would be glad to collaborate with anyone who has the time to tackle it.

Is there any workaround? Really hope someone would fix this, thanks!

Still in an issue in 2017


Export network as PNG/SVG for browser version

It would be very useful option to export PNG/SVG images in the browser version.

CmdOrCtrl+Shift+E - Save as PNG
CmdOrCtrl+Shift+Alt+E - Save as SVG

In my case my Firefox wasn't grabbing the shortcuts. Tried several add-ons for different browsers, but only the visible part of the graph was getting printed. At some point I looked into the code, and this related line gave away the solution:
https://github.com/lutzroeder/netron/blob/9d94068c7e1df438aec4546e2ef3b6d98046509c/src/view-browser.js#L429
So this fixed it for me:

Open the firefox console
Type this.__view__.export("my_net.svg")

Hope it helps someone!  thanks for Netron is amazing


fix: handle an ICE resulting from a dangling pointer

This fixes https://github.com/EmbarkStudios/rust-gpu/issues/209 . It follows this logic from the comments in the issue. It also creates an ignored test for another issue

Thank you for your PR, and congrats on your first contribution! 🎉

Thank you for your PR, and congrats on your first contribution! 🎉


How to docker ubuntu

Description
Added How To Guide for creating Docker containers for Moveit2 in Ubuntu
Checklist

[ ] Required by CI: Code is auto formatted using clang-format
[ ] While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

Please run the local checks pre-commit and htmlproofer as explained here to get this to pass CI: https://moveit.picknik.ai/main/doc/how_to_contribute/how_to_contribute_to_site.html


Line 1 breakpoint locations may no longer be accurate after 10.16+

A failing test (testing setting line-1 breakpoints) that is the cause of #729 highlights a potentially breaking change for us in Node 10.16: scripts are now parsed slightly differently. Consider the following code:
module.exports = function foo(n) { return n; }

In Node 10.15 and below, getting the above script via Inspector's Debugger.getScriptSource yields:
(function (exports, require, module, __filename, __dirname) { module.exports = function foo(n) { return n; }
});

In Node 10.16+, it yields the original source:
module.exports = function foo(n) { return n; }

This almost certainly affects line-1 breakpoints.

This issue should not be closed until the test skipped in #738 is re-enabled.

@kjin interesting, I remember when this was introduced, compileFunction is now used:
https://github.com/nodejs/node/blob/master/lib/internal/modules/cjs/loader.js#L856
rather than source being pre-wrapped with a wrapper, this should ultimately help ensure slightly more accurate information, but it does mean that prior to Node.10.16 the wrapper exists afterwords it does not.

@bcoe Thanks, I found the PR that caused this change: https://github.com/nodejs/node/pull/21573


[Bug]: Latest release does not include apache/kafka KafkaContainer despite docs referencing it

Module
Kafka
Testcontainers version
1.19.7
Using the latest Testcontainers version?
Yes
Host OS
Ubuntu 22.04.3 LTS
Host Arch
6.5.0-28-generic #29~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Apr  4 14:39:20 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Docker version
Client: Docker Engine - Community
 Version:           24.0.7
 API version:       1.43
 Go version:        go1.20.10
 Git commit:        afdd53b
 Built:             Thu Oct 26 09:07:41 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          24.0.7
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.10
  Git commit:       311b9ff
  Built:            Thu Oct 26 09:07:41 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.24
  GitCommit:        61f9fd88f79f081d64d6fa3bb1a0dc71ec870523
 runc:
  Version:          1.1.9
  GitCommit:        v1.1.9-0-gccaecfc
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

What happened?
I wanted to use a KafkaContainer in an integration test which uses the official apache/kafka Image. However, I was unable to find an import of the following class:
https://github.com/testcontainers/testcontainers-java/blob/main/modules/kafka/src/main/java/org/testcontainers/kafka/KafkaContainer.java
In the docs, this is referenced as being one of the supported images for the Kafka Testcontainers (the other being the confluentinc/cp-kafka image).
However, this class is not included in the 1.19.7 release: https://github.com/testcontainers/testcontainers-java/tree/1.19.7/modules/kafka/src/main/java/org/testcontainers
Either this was mistakenly not included in the release or the docs were merged prematurely.
Additionally, it would be nice to have support for e.g. bitnami/kafka images as well, since the official apache/kafka images only seem to support Kafka >=3.7.0. For legacy applications still using Kafka 2.x, there is currently no recourse besides using a custom image or using asCompatibleSubstituteFor, which is error-prone.
Relevant log output
java.lang.ExceptionInInitializerError
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.IllegalStateException: Failed to verify that image 'apache/kafka:2.8.0' is a compatible substitute for 'confluentinc/cp-kafka'. This generally means that you are trying to use an image that Testcontainers has not been designed to use. If this is deliberate, and if you are confident that the image is compatible, you should declare compatibility in code using the `asCompatibleSubstituteFor` method. For example:
   DockerImageName myImage = DockerImageName.parse("apache/kafka:...").asCompatibleSubstituteFor("confluentinc/cp-kafka");
and then use `myImage` instead.

Additional Information
No response

Unfortunately, mismatch between the docs and the implementation is a well-known issue. Also, we are not planning to support bitnami images.


Improve test coverage somewhat

Coverage increased (+4.9%) to 79.691% when pulling 87dbd2fca78217304a8d62dd40f91278283c03df on improve-coverage into b42da4bc36860538c14e2ac8517bce85e7b5af31 on develop.

Coverage increased (+4.9%) to 79.691% when pulling 4a62410bbf5a692c1409d8a81146ad322a20346a on improve-coverage into b42da4bc36860538c14e2ac8517bce85e7b5af31 on develop.

Well, yellow is better than red

Coverage increased (+3.3%) to 78.071% when pulling 702ae614336fa7a41511abf78d2ec8e599dc4102 on improve-coverage into b42da4bc36860538c14e2ac8517bce85e7b5af31 on develop.

Coverage increased (+3.3%) to 78.071% when pulling 702ae614336fa7a41511abf78d2ec8e599dc4102 on improve-coverage into b42da4bc36860538c14e2ac8517bce85e7b5af31 on develop.


Add Aqua.jl testing

Aqua docs: https://juliatesting.github.io/Aqua.jl/dev/

I am not 100% sure if we want or need this, but adding Aqua tests seemed like not such a big issue to add. Also, testing time is hardly affected (<1 min). There are a lot of imho false-positive method ambiguities. There's also a legit piracy warning, thanks to buccaneer-in-chief @jlchan. I added an exception such that tests pass, but we could also think about moving the relevant function to StartUpDG.

I am not 100% sure if we want or need this, but adding Aqua tests seemed like not such a big issue to add. Also, testing time is hardly affected (<1 min). There are a lot of imho false-positive method ambiguities. There's also a legit piracy warning, thanks to buccaneer-in-chief @jlchan. I added an exception such that tests pass, but we could also think about moving the relevant function to StartUpDG.

I didn't add that function, but I'm happy to move it StartUpDG.jl. @ranocha, any thoughts?

I didn't add that function

err... I beg to differ, good sir! 🧐
https://github.com/trixi-framework/Trixi.jl/pull/1010/files#diff-9818bc7a206dbb756a2d8aed9f30baf2bd1cc2eaf9b115e667375da1b69e639bR347-R351

Ohh right, I did add that function - the DGMulti solvers using SummationByPartsOperators.jl were super slow without it. I must have forgotten because @ranocha added the other SummationByPartsOperators.jl solver features.
IMO it doesn't make sense to move it to StartUpDG.jl without moving the rest of the specialization of RefElemData and MeshData from SummationsByPartsOperators.jl, but we can merge this first and open an issue. Any preference @sloede?

IMO it doesn't make sense to move it to StartUpDG.jl without moving the rest of the specialization of RefElemData and MeshData from SummationsByPartsOperators.jl, but we can merge this first and open an issue. Any preference @sloede?

I agree, opening an issue would be a good idea 👍 Can you do it, such that you know what would be to do?

Wait, I'm a little confused - why is https://github.com/trixi-framework/Trixi.jl/blob/92dedde81e12f8ac2259785a9eab40f475d82251/src/solvers/dgmulti/sbp.jl#L62-L64 not considered type piracy then? It's extending a StartUpDG.jl function to a SummationByPartsOperators.jl abstract type, neither of which is owned by Trixi.jl

Wait, I'm a little confused - why is
https://github.com/trixi-framework/Trixi.jl/blob/92dedde81e12f8ac2259785a9eab40f475d82251/src/solvers/dgmulti/sbp.jl#L62-L64
not considered type piracy then? It's extending a StartUpDG.jl function to a SummationByPartsOperators.jl abstract type, neither of which is owned by Trixi.jl

I believe that, yes, this too is 🏴☠ and it's just that Aqua did not catch it 😅

@sloede done https://github.com/trixi-framework/Trixi.jl/issues/1639
Can you add Aqua exceptions for the other StartUpDG functions in https://github.com/trixi-framework/Trixi.jl/blob/92dedde81e12f8ac2259785a9eab40f475d82251/src/solvers/dgmulti/sbp.jl? The ones which commit type piracy should all be prefaced by function StartUpDG.__function_name__

@sloede done #1639

Thanks!

Can you add Aqua exceptions for the other StartUpDG functions

I don't think it is necessary, since all tests have passed so Aqua does not complain about the others.

Can you add Aqua exceptions for the other StartUpDG functions

I don't think it is necessary, since all tests have passed so Aqua does not complain about the others.

Yes, but I was thinking that new versions of Aqua might not skip over these other pirated functions.

Can you add Aqua exceptions for the other StartUpDG functions

I don't think it is necessary, since all tests have passed so Aqua does not complain about the others.

Yes, but I was thinking that new versions of Aqua might not skip over these other pirated functions.

Then I would tackle them once the new Aqua version complains about them 🙂


i18n(fr) Update french translation for aws.mdx and content.mdx

Description (required)
Update french translation for aws.mdx and community-ressources/content.mdx files with PR #7902 #7991 and and a few omissions.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
community-resources/content.mdx
Localization changed, will be marked as complete.

fr
guides/deploy/aws.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Un panier ou un seau ?

Je laisserai l 'mot en Anglais, merci pour tes suggestions


"toggle()" method usable outside and visible parameter for the main toggler icon

Hello,

I made the toggle method usable outside the main "toggler" icon. For example, now we can use the toggle() method on any screen button or in an onPressed parameter of an Icon in an app bar.
I add a visible parameter for the main toggle icon to hide it if we use the toggle method outside the main "toggler".
I add an example of the new "toggler" in the main.dart example.
SideNavigationBarItem is now a custom Material widget because the ListTile caused a faded widget color.

Hey @regisandre
Thanks for the effort! Will have a look at it once I have some time left.


Add lifecycle hooks to EventSource

The class io.javaoperatorsdk.operator.processing.event.EventSource does not provide any lifecycle method, so there is a chance a watch is registered and an event is received before an EventHandler is registered.
As example, the memcached example register a watcher before registering the EventSource.
I think it would be nice to have some sort of start/stop hook the implementors can use to safely start watch.

Hi @lburgazzoli , yes this seems to be reasonable.
Not sure what you mean by " event is received before an EventHandler  is registered ".
But the current intention is that the EventSources are registered in the init method of the controller. At this point when an event would be produced it won't be missed by the system. Have to check , but you might be right that if the instantiation of the event source happens before (for some reason) and it would produce an event, this would lead to an undefined behavior.
So this is a good point.
I was thinking also in other events for the event source, like when for example a custom resource is first time processed, an event source could be notified or things like that. But the plan is to add these events ad-hoc, based on some real use-cases.
(FYI see init call: https://github.com/java-operator-sdk/java-operator-sdk/blob/112a8268155a9f6262e1238b592e9813b09e1557/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java#L150 )

Not sure what you mean by " event is received before an EventHandler is registered ". You mean the controller?

So usually when an EventSource is created, you do something like:
    client.apps().deployments().inAnyNamespace().withLabels(labels).watch(this)

But if the resource changes (in this case a deployment) before the eventHandler is set to the event source, there is a change either to miss the event or trigger an NPE (at least the memcached example would trigger an NPE). To solve this, in my code I do override AbstractEventSource::setEventHandler and I start watching only after the event handler has been set, like:
    @Override
    public void setEventHandler(EventHandler eventHandler) {
        super.setEventHandler(eventHandler);
        watch();
    }

Having some lifecycle method would make it clear when it is possible to start watching.

Ahh I see how do you mean it, yes this seems to be a valid point, to avoid doing such workarounds.

I started having a look at this but I found that it is quite easy to add a start method but adding a stop one does not seems very simple as I do not see a clear shutdown process (i.e. there is a Operator.start but not Operator.stop/close).
@csviri how does the operator handle shutdown logic ?


Camera2D doesn't get set as current when reloading scene

Godot version
4.0.beta17
System information
Windows 10, GTX 1050 mobile, Compatibility renderer
Issue description
I have one Camera2D in my scene. When I first run the game, it gets set as the main (current) camera, but when I run get_tree().reload_current_scene(), it doesn't reset to the new camera and just stays in the same position. It worked fine in beta16, so this is probably due to the new Camera2D changes
Quick video:
https://user-images.githubusercontent.com/16920817/216381041-3b90b84a-f3af-4146-b842-2d599d69bd99.mp4
Steps to reproduce

Add a Camera2D to the scene
Move the camera
Run get_tree().reload_current_scene()
The reset camera isn't set as current

Or just download the project below, run level 1, and hold 'R'
Minimal reproduction project
Platformer Quickstart.zip

Duplicate of #72074

Duplicate of #72074

I think you may have linked the wrong issue, this issue has nothing to do with renaming nodes


same token generated every time for same user

HI I'm using drf-social-oauth2 in one of my project to generate an auth token for social login users. but after logout and blacklisting the old token. when I again generate auth token i'm getting same token as old.

Right, that is the correct behavior of the application flow. How are you exactly blacklisting the token?
So, the flow works as follows, the token is generated with a certain expiry date. If you request a new token and the new old token is still valid, the application will give you the old token (as there is no need to create a new token).


CI: ConformanceKind1.19: Install Cilium with Encryption: Unable to execute "kubectl port-forward ..."

CI failure
https://github.com/cilium/cilium/actions/runs/3578781557/jobs/6019299792
cilium-sysdump-out.zip (30).zip
Run cilium hubble port-forward&
  cilium hubble port-forward&
  sleep 10s
  [[ $(pgrep -f "cilium.*hubble.*port-forward|kubectl.*port-forward.*hubble-relay" | wc -l) == [2](https://github.com/cilium/cilium/actions/runs/3578781557/jobs/6019299792#step:16:2) ]]
  shell: /usr/bin/bash -e {0}
  env:
    kind_version: v0.11.1
    kind_config: .github/kind-config.yaml
    cilium_cli_version: v0.12.7
    QUAY_ORGANIZATION: cilium
    QUAY_ORGANIZATION_DEV: cilium

❌ Unable to execute "kubectl port-forward -n kube-system svc/hubble-relay --address <IP_ADDRESS> --address :: [4](https://github.com/cilium/cilium/actions/runs/3578781557/jobs/6019299792#step:16:4)24[5](https://github.com/cilium/cilium/actions/runs/3578781557/jobs/6019299792#step:16:5):[8](https://github.com/cilium/cilium/actions/runs/3578781557/jobs/6019299792#step:16:8)0":
Error: Unable to port forward: unable to execute "kubectl port-forward -n kube-system svc/hubble-relay --address <IP_ADDRESS> --address :: 4245:80": exit status 1
 error: unable to forward port because pod is not running. Current status=Pending

Error: Process completed with exit code 1.

Hit in #22411

hubble-relay pod logs:
2022-11-29T23:29:27.701322872Z level=info msg="Starting gRPC server..." options="{peerTarget:hubble-peer.kube-system.svc.cluster.local:443 dialTimeout:5000000000 retryTimeout:30000000000 listenAddress::4245 metricsListenAddress: log:0xc00010ed20 serverTLSConfig:<nil> insecureServer:true clientTLSConfig:0xc000010d08 clusterName:kind-chart-testing insecureClient:false observerOptions:[0x11347a0 0x11348a0] grpcMetrics:<nil> grpcUnaryInterceptors:[] grpcStreamInterceptors:[]}" subsys=hubble-relay
2022-11-29T23:29:27.718422353Z level=info msg="Received peer change notification" change notification="name:\"kind-chart-testing/chart-testing-worker\" address:\"<IP_ADDRESS>\" type:PEER_ADDED tls:{server_name:\"chart-testing-worker.kind-chart-testing.hubble-grpc.cilium.io\"}" subsys=hubble-relay
2022-11-29T23:29:27.718445753Z level=info msg="Received peer change notification" change notification="name:\"kind-chart-testing/chart-testing-control-plane\" address:\"<IP_ADDRESS>\" type:PEER_ADDED tls:{server_name:\"chart-testing-control-plane.kind-chart-testing.hubble-grpc.cilium.io\"}" subsys=hubble-relay
2022-11-29T23:29:27.718487054Z level=info msg=Connecting address="<IP_ADDRESS>:4244" hubble-tls=true peer=kind-chart-testing/chart-testing-control-plane subsys=hubble-relay
2022-11-29T23:29:27.718939962Z level=info msg=Connecting address="<IP_ADDRESS>:4244" hubble-tls=true peer=kind-chart-testing/chart-testing-worker subsys=hubble-relay
2022-11-29T23:29:27.726185181Z level=info msg=Connected address="<IP_ADDRESS>:4244" hubble-tls=true peer=kind-chart-testing/chart-testing-worker subsys=hubble-relay
2022-11-29T23:29:27.726203181Z level=info msg=Connected address="<IP_ADDRESS>:4244" hubble-tls=true peer=kind-chart-testing/chart-testing-control-plane subsys=hubble-relay

Everything looks healthy, maybe startup just took a little longer? I can't tell when the test failed out because the workflow doesn't have any timestamps. I filed #22436 to follow up on that.

Here's the corresponding timestamps from GitHub:
Tue, 29 Nov 2022 23:29:26 GMT
Run cilium hubble port-forward&
Tue, 29 Nov 2022 23:29:26 GMT   cilium hubble port-forward&
Tue, 29 Nov 2022 23:29:26 GMT   sleep 10s
Tue, 29 Nov 2022 23:29:26 GMT   [[ $(pgrep -f "cilium.*hubble.*port-forward|kubectl.*port-forward.*hubble-relay" | wc -l) == 2 ]]
Tue, 29 Nov 2022 23:29:26 GMT   shell: /usr/bin/bash -e {0}
Tue, 29 Nov 2022 23:29:26 GMT   env:
Tue, 29 Nov 2022 23:29:26 GMT     kind_version: v0.11.1
Tue, 29 Nov 2022 23:29:26 GMT     kind_config: .github/kind-config.yaml
Tue, 29 Nov 2022 23:29:26 GMT     cilium_cli_version: v0.12.7
Tue, 29 Nov 2022 23:29:26 GMT     QUAY_ORGANIZATION: cilium
Tue, 29 Nov 2022 23:29:26 GMT     QUAY_ORGANIZATION_DEV: cilium
Tue, 29 Nov 2022 23:29:27 GMT
Tue, 29 Nov 2022 23:29:27 GMT ❌ Unable to execute "kubectl port-forward -n kube-system svc/hubble-relay --address <IP_ADDRESS> --address :: 4245:80":
Tue, 29 Nov 2022 23:29:27 GMT Error: Unable to port forward: unable to execute "kubectl port-forward -n kube-system svc/hubble-relay --address <IP_ADDRESS> --address :: 4245:80": exit status 1
Tue, 29 Nov 2022 23:29:27 GMT  error: unable to forward port because pod is not running. Current status=Pending
Tue, 29 Nov 2022 23:29:27 GMT
Tue, 29 Nov 2022 23:29:36 GMT Error: Process completed with exit code 1.

So, yes it looks like a race condition where the workflow attempts to execute the port-forward before Hubble-Relay is ready. We should be able to resolve this by adding a retry or delay in either the CLI or the workflow.


Support Laravel v6

Laravel 6.0 is released
See PR #7 😄

PR accepted :+1:

@nunomazer can you also create a new release?

Sorry, done  :man_facepalming:


Image guard moved to per-deployment

Now, as we collect the build artifact (= image name) for proposed
deployments, we also e.g. check for advisories and strip out undeployable
deployments before they're sent to the deployer.
This kind of exploded in scope. The idea was to push the guard for the
availability of images from the top level (and blocking the whole
rectification if it fails) to a per-deployment scope. We need to resolve
the image name to do that, and since that can involve a docker-registry
roundtrip, I wanted to store the retrieved value.
The result is that the deployer now works on "Deployables" as opposed to
"Deployments" - a Deployable is a pair of a Deployment and a BuildArtifact.
The top level "resolver" farms out the resolution of the BuildArtifacts.
One very nice result is that the Singularity Deployer is now decoupled from
the Docker NameCache.

Current coverage is 59.51% (diff: 57.14%)

Merging #236 into master will decrease coverage by 0.38%

@@             master       #236   diff @@
==========================================
  Files           128        129     +1
  Lines          6804       6867    +63
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4076       4087    +11
- Misses         2367       2416    +49
- Partials        361        364     +3

Powered by Codecov. Last update 357f4b9...d5e1717

@samsalisbury - I've just improved the tests covering this change (and not coincidentally that code itself). With this merged and server redeployed, I think we're ready to take another run at getting webhooks deployed.

I'm just waiting for Travis to pass the tests before merging. For some reason it failed overnight, but the integration + unit tests all passed on my machine.

#238 supersedes this, fixing travis build.


When the segment is used by the toggle that is analyzing the indicator, add a risk prompt when changing the segment


configuration ROOMS_DATA in heroku

This project is very nice and I go start test, but I don't how to set default rooms data environment, because in Setup is only in JSON/JS format

Hi @enieber I didn't understand your question. but I'll try to help you :)
in This documentation we have an exemple:

In heroku go to settings and click in Reveal config Vars:

And config like this:

dont forguet to pul ROOMS_SOURCE = ENVIRONMENT

I'm checking the setup documentation and ROOMS_SOURCE = ENVIRONMENT is not documented. @enieber Could you document this and open a PR for us?


Steel Furnace is creating error of height!

In the furnace-mk2.lua at the 136 you write 75, it's shoud be fixed with 74.

Hello, thanks for opening the issue. Since I haven't played Factorio in the long time I didn't knew. I will fix it right away!

It should be fixed.

k thanks


Shuotao vcu118 rebased

Rebased https://github.com/xushuotao/connectal branch master and imported XilinxVirtex7PCIE.bsv

Using DataBusWidth=256 with this branch compiled and synthesized for the vcu118 target, and worked in simulation for the verilator target.
I am yet to push the synthesized version onto the FPGA and will confirm later that it works in hardware, but so far so good!

@RadhikaG thank you for testing! I do not currently have access to any vcu118s.


Add src/core header files to PRETTY_FILES.

#1568 removed header files from being included in the pretty and pretty-check targets.  This PR brings those back in.  This PR also fixes code style issues that have crept in since.

Codecov Report

Merging #1632 into master will increase coverage by 0.43%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
+ Coverage   68.42%   68.86%   +0.43%
==========================================
  Files         159      159
  Lines       20310    20310
  Branches     2489     2489
==========================================
+ Hits        13897    13986      +89
+ Misses       5505     5416      -89
  Partials      908      908

Impacted Files
Coverage Δ

src/core/thread/network_diagnostic_tlvs.hpp
0% <ø> (ø)
:arrow_up:

src/core/meshcop/meshcop.hpp
100% <100%> (ø)
:arrow_up:

src/core/thread/mle_tlvs.hpp
95.67% <50%> (+0.02%)
:arrow_up:

src/core/coap/coap_client.hpp
73.33% <0%> (-20%)
:arrow_down:

src/core/coap/coap_client.cpp
52.97% <0%> (-19.22%)
:arrow_down:

src/core/thread/lowpan.hpp
86.84% <0%> (-13.16%)
:arrow_down:

src/core/coap/coap_server.cpp
81.48% <0%> (-7.41%)
:arrow_down:

src/core/coap/coap_server.hpp
88.88% <0%> (-3.97%)
:arrow_down:

src/core/thread/lowpan.cpp
92.47% <0%> (-1.44%)
:arrow_down:

src/core/thread/mle_router.cpp
77.61% <0%> (-0.33%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358ca8e...573d198. Read the comment docs.


Fix infinite loop in file inferencing

Fixes #2573

re: Issue https://github.com/Unidata/netcdf-c/issues/2573
The file type inferencer in libdispatch/dinference.c has a simple forward inference mechanism so that the occurrence of certain mode values in a URL fragment implies inclusion of additional mode values. This kind of inference is notorious for leading to cycles if not careful. Unfortunately, this occurred in the one in dinference.c.
This was fixed by providing a more complicated, but more reliable inference mechanism.
Misc. Other Changes

Found and fixed a couple of memory leaks.
There is a recent problem in building HDF4 support on github actions. Fixed by using the internal HDF4 xdr capability.
Some filter-related code was not being properly ifdef'd with ENABLE_NCZARR_FILTERS.

I'm seeing some test failures with this patch applied to 4.1.4:
FAIL: run_purezarr.sh
=====================
findplugin.sh loaded
final HDF5_PLUGIN_DIR=/builddir/build/BUILD/netcdf-c-4.9.0/build/plugins/.libs
*** Test: pure zarr write then read; format=file
*** Test: xarray zarr write then read; format=file
*** Test: pure zarr reading nczarr; format=file
6c6
< 		v:_FillValue = -1 ;
---
> 		v:_FillValue = -1b ;
10,17c10,17
<   _, _, _, _, _, _, _, _,
<   _, _, _, _, _, _, _, _,
<   _, _, _, _, _, _, _, _,
<   _, _, _, _, _, _, _, _,
<   _, _, _, _, 0, 1, 2, 3,
<   _, _, _, _, 4, 5, 6, 7,
<   _, _, _, _, 8, 9, 10, 11,
<   _, _, _, _, 12, 13, 14, 15 ;
---
>   -1, -1, -1, -1, -1, -1, -1, -1,
>   -1, -1, -1, -1, -1, -1, -1, -1,
>   -1, -1, -1, -1, -1, -1, -1, -1,
>   -1, -1, -1, -1, -1, -1, -1, -1,
>   -1, -1, -1, -1, 0, 1, 2, 3,
>   -1, -1, -1, -1, 4, 5, 6, 7,
>   -1, -1, -1, -1, 8, 9, 10, 11,
>   -1, -1, -1, -1, 12, 13, 14, 15 ;
FAIL run_purezarr.sh (exit status: 1)

Are there additional patches I need to apply?

What underlying version of netcdf-c are you using, 4.9.0?

Sorry, yes - 4.9.0

The diff error you show is because there was a fix for handling fill values
in some other PR.
But I cannot find which one it was.

So, not quite sure what I should do here.  I'd like to release a patched version on 4.9.0 in Fedora ( assuming 4.9.1 with this fix is a ways off - is it?) but am worried that this test failure indicates that it may be breaking something else.

That "error" you is technically not an error since it is just showing the
fillvalue instead of "_". The problem was probably with ncdump.

A number of changes were made in 4.9.1 to fix JSON constant handling.
Among other things, this affected the type of _FillValue for certain tests.
So, to fix this in 4.9.0, do the following:

only use the following changed files from this PR:

dinfermodel.c
nclist.c
ncbytes.c

Edit nczarr_test/ref_quotes.cdl and change the following line:

		fractional_snow_cover:ID = 68b ;
to
		fractional_snow_cover:ID = 68 ;

Edit the file zsync.c and replace the function mininttype with the following:

static int
mininttype(unsigned long long u64, int negative)
{
    long long i64 = (long long)u64; /* keep bit pattern */
    if(!negative && u64 >= NC_MAX_INT64) return NC_UINT64;
    if(i64 < 0) {
	if(i64 >= NC_MIN_INT) return NC_INT;
	return NC_INT64;
    }
    if(i64 <= NC_MAX_INT) return NC_INT;
    if(i64 <= NC_MAX_UINT) return NC_UINT;
    return NC_INT64;
}

Edit the file dap4_test/Makefile.am and change this line:

TESTS += test_hyrax.sh test_thredds.sh
to
#TESTS += test_hyrax.sh test_thredds.sh

Note that this change is independent of the other changes.
It may not be needed unless the dap4_test/test_thredds.sh fails.

Thank you very much.  That seems to build fine and resolve the issue.

Merged into v4.91-wellspring.wif in preparation for the v4.9.1 release.  It will be backported into main when the release is made.


rename express server to sfwd

In the comments for pull request 98, Ward mentioned:

Nick is looking to rename "server/express/bin/server". Is there a problem with that name? The name "sfw-express" seems to encode information already present in the path to the file.

Seems to me, following typical web server naming idioms, the server should be named "#{thing-it-serves}d".  So sfwd would be the name.
Or perhaps since there are two servers, it should be called one of:

sfwd-express
sfw-expressd
???

I think I like that first one.  When the day comes when there is a single reference server, we can rename whichever that is to sfwd
Also, we should look at adding a bin entry to the package.json, so that when folks do an npm -g install, it will install the binary in a nice place.  See, for example, https://github.com/jashkenas/coffee-script/blob/master/package.json

I'm starting to think that just adding the .js back to server/express/bin/server.js may be the way to go.  The name of the file doesn't have to be same as the global command when installed with npm -g, see https://github.com/substack/node-browserify/blob/master/package.json#L7
I've been waiting on finishing up the package.json with a bin entry and real package versions ranges, etc. until the server/express code stops changing so much.  I'm hoping it will have calmed down some in 2 weeks or so.


Module reported error during install: 1293 Incorrect table definition

Version Info:

ProcessWire: 3.0.62
Jumplinks: 1.5.48
PHP: 7.0
MySQL: 5.5

Details:
During installation of the module, ProcessWire reports the following error:

Module reported error during install (ProcessJumplinks): SQLSTATE[HY000]: General error: 1293 Incorrect table definition; there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause

and also

Failed to init module: ProcessJumplinks - SQLSTATE[42S02]: Base table or view not found: 1146 Table 'db692315716.process_jumplinks' doesn't exist

Therefore the module cannot be used after installation.
I previously used the module on other sites (on other servers with other PW versions) and it always worked fine. But this time – in the given environment – there is this error mentioned above.

Duplicate of #18. Is there any chance you can upgrade to at least MySQL 5.6.5?

Unfortunately no :-(
It's a shared server from 1&1 and currently all new databases runnning MySQL 5.5
Source: https://community.1und1.de/php-composer-bei-1und1-verwenden/#comment-145682

Wir bieten im Shared Hosting nur MySQL 5.5 an.

That is terrible of them, seriously. 5.6 has been around for a considerable amount of time, and it is very stable, so I don't see why they're not doing this. I have never heard good stories come from 1and1.
That aside, I will fix the issue in a few hours.

Please see above commit on the dev branch. You'll need to install using this ZIP file through the module installer: https://github.com/rockettpw/jumplinks/archive/dev.zip
Let me know if it works, please.

@mikerockett Just tested aaaand: It works great! Thank you very much – this saved my day!

I'm actually being silly here... MySQL 5.7 does not allow zero dates without the definition being set to NULL. So I'll need to add that in as well before I fast-forward this to master.

I've made the commit - please check again to make sure it works on your end.
Truly hope I'm not breaking anything for those with 5.6...

You did the commit on the dev branch, right?
I uninstalled and deleted the module and did a new install from https://github.com/rockettpw/jumplinks/archive/dev.zip. Ran flawless! Than i imported my redirects CSV and all redirects work properly. Can't see any error, looks good!
BTW: How do i update the module once that changes found their way to the master branch?

Yep, with these kinds of possible breaking changes on some setups, I had to create a dev branch for these changes. If everything looks stable, then I will commit to master.
Glad to know it works on your end. Going to leave it in dev for the time being - perhaps more people could test it out to make sure nothing breaks. This MySQL timestamp issue has been doing the rounds for a while.
Regarding the update: When it makes its way into master, the version will be bumped to 1.5.49. If you're using the ProcessWireUpgrade, it will automatically pick it up. Otherwise, you can just keep the module installed, go to Modules > New > Install and enter the location of the master ZIP. But you won't need to do any of that as it does work on your end - truthfully, it doesn't matter if you're using the dev branch or the master.

@mikerockett You are great, thank you very much!


python3Packages.aiohue: 4.6.2 -> 4.7.0

Diff: https://github.com/home-assistant-libs/aiohue/compare/refs/tags/4.6.2...4.7.0
Changelog: https://github.com/home-assistant-libs/aiohue/releases/tag/4.7.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Combined with #257679 and picked as 44b5dd6f3ca0bf47d39e0d135e5e3df402f2004e.


[Feature]: atomicAdd() to support half and bfloat16

Suggestion Description
It is similar to the "atomicAdd() to support half2 and bfloat162.
Could bf16.h and bfloat16.h be combined into a single file ?
Operating System
Ubuntu
GPU
MI200
ROCm Component
HIP

Hi @jinz2014, internal ticket has been created to assist with your question. Thanks!

I think we can close this one: https://github.com/ROCm/clr/commit/bb52d9ed62e8953dc9673b7e4d0fd13608a4dbf6

Hi @jinz2014. This is fixed in ROCm 6.3. Closing ticket. Thanks!

I didn't see the function in /opt/rocm-6.3.0/lib/llvm/bin/../../../include/hip/amd_detail/amd_hip_atomic.h


Add nightly builds for snapshot docker images

IMO it would make sense to add nightly build for the kubebuilder/controller:snapshot image.

I agree that having a snapshot image based on master would be really helpful

@github removed a critical action, we need to re-do this :grimacing:

Pls see #918

Latest master builds now land in docker.pkg.github.com/kudobuilder/kudo/controller:master


Add class for CLIPVisionModel

Model description
The transformersjs equivalent of https://huggingface.co/docs/transformers/v4.41.3/en/model_doc/clip#transformers.CLIPVisionModel
Prerequisites

[x] The model is supported in Transformers (i.e., listed here)
[X] The model can be exported to ONNX with Optimum (i.e., listed here)

Additional information
We could use optimum to export the entire CLIP model to ONNX and then use transformersjs to use the CLIPVisionModel from the exported CLIP model. Since CLIPVisionModelWithProjection is already in place I believe we could use it's class to obtain the CLIPVisionModel as well.
Your contribution
Given access to relevant resources, I'd be more than happy to contribute to this repo by creating a class for this model type!

I suppose we have to make a class very similar to this: https://github.com/xenova/transformers.js/blob/30720089c6215f71b519c17369404cdfd14c32e0/src/models.js#L3164, but what other changes do we need to make in order to load the equivalent of CLIPVisionModel instead of CLIPVisionModelWithProjection
@xenova please help

Hey there! 👋 That's right, you need to do two things:

Modify/create a custom ONNX export like this
Define a new class called CLIPVisionModel like the code you linked to.

If you have example python code for running the models, feel free to post here and I can show you the equivalent JS code 👍

Thanks for the help! I think the ONNX export class for this model would look like:
class CLIPVisionOnnxConfig(ViTOnnxConfig):
    @property
    def outputs(self) -> Dict[str, Dict[int, str]]:
        outputs = {"pooler_output": {0: "batch_size"},}
        for i in range(self._normalized_config.num_hidden_layers + 1):
            outputs[f"hidden_states.{i}"] = {0: "batch_size", 1: "sequence_length"}
        return outputs

And I suppose that the CLIPVisionModel class would be identical to the CLIPVisionModelWithProjection class except for the name.
And here's the python code we need to run the models:

import torch
from transformers import CLIPVisionModel

model = CLIPVisionModel.from_pretrained("openai/clip-vit-base-patch16")

outputs = model(pixel_values=torch.randn(1, 3, 224, 224))

print(outputs.pooler_output.shape)

Hi @xenova, please let me know if the following looks good, I could open a PR if the following code is alright:
Code for transformersjs/scripts/extra/clip.py:
class CLIPVisionModelOnnxConfig(CLIPVisionOnnxConfig):
    @property
    def outputs(self) -> Dict[str, Dict[int, str]]:
        outputs = {"pooler_output": {0: "batch_size"},}
        for i in range(self._normalized_config.num_hidden_layers + 1):
            outputs[f"hidden_states.{i}"] = {0: "batch_size", 1: "sequence_length"}
        return outputs

for transformersjs/sc/models.js:
export class CLIPVisionModel extends CLIPPreTrainedModel {
    /** @type {PreTrainedModel.from_pretrained} */
    static async from_pretrained(pretrained_model_name_or_path, options = {}) {
        // Update default model file name if not provided
        options.model_file_name ??= 'vision_model';
        return super.from_pretrained(pretrained_model_name_or_path, options);
    }
}

Hi @xenova, thanks a lot for building such a fantastic repository and I truly appreciate all the hard work you've put in! I understand that it must be difficult to stay on track with such an active repository, I would humbly like to request you to help me understand whether I'd be good to go with the code above.
I understand that it's not a really good thing to ask for quick but I require this feature for a project the deadline of which is just around the corner, so it would be very kind of you if you could help me get there speedily. Thanks again.

Hi again 👋 Sure that looks like it will work - have you tried exporting a model with that config? The usage will be similar to https://github.com/xenova/transformers.js/issues/799#issuecomment-2171410970.
To use from javascript, you can literally just import CLIPPreTrainedModel and extend the class yourself in your code. That said, I might as well add the default configs to the library, since they are defined in transformers (python) already.

Hi again, thanks for your response! I was able to run the model by extending the class. However, I'm observing large deviation in output values when I run the model in javascript. After porting the model to onnx, I tested the model outputs, the fp32 and fp16 models are giving an average deviation of ~10^-5, which is very good but the quantized model is having a very large deviation, which is expected. However, when I tried to run the model in javascript, it is giving the same deviated output even when I explicitly add quantized: false in the parameters. I am attaching the code as:

import { AutoProcessor, ViTModel, RawImage, CLIPPreTrainedModel, PreTrainedModel } from '@xenova/transformers';
import fs from 'fs';

export class CLIPVisionModel extends CLIPPreTrainedModel {
    /** @type {PreTrainedModel.from_pretrained} */
    static async from_pretrained(pretrained_model_name_or_path, options = {}) {
        // Update default model file name if not provided
        options.model_file_name ??= 'vision_model';
        return super.from_pretrained(pretrained_model_name_or_path, options);
    }
}

const processor = await AutoProcessor.from_pretrained('mrsarthakgupta/onnx_test_repo_3');
const vision_model = await CLIPVisionModel.from_pretrained('mrsarthakgupta/onnx_test_repo_3', {
    device: 'webgpu',
    dtype: 'fp32',
    quantized: false
},
);

// Read image and run processor
const image = await RawImage.read('F-VF8LyaEAAF0s9.jpg');
const time_start = performance.now();
const image_inputs = await processor(image);

const outs = await vision_model(image_inputs);
console.log(outs);

const jsonString = JSON.stringify(outs.pooler_output.data, null, 2);

fs.writeFile('pooleroutjs.json', jsonString, (err) => {
    if (err) {
        console.error('Error writing file:', err);
    } else {
        console.log('File has been written successfully');
    }
});

Interestingly, running the model with node and on the browser are also giving different results

@xenova thanks for the clarification, however, the outputs being different for the browser and node.js was just a side note. The primary problem as mentioned here is that the outputs while using node.js are very different from what they are while using python and onnx. The following are the cosine similarities between the following methods:

torch vs onnx cosine similarity: 0.9999999999743225
torch vs js cosine similarity: 0.7655750265496857
torch vs browser cosine similarity: 0.7689434867346924
js vs browser cosine similarity: 0.9673279176110128

Can you confirm you are using the unquantized/fp32 version?

Yes, I am using unquantized/fp32 version, here's the code I'm using with nodejs:
import { AutoProcessor, ViTModel, RawImage, CLIPPreTrainedModel, PreTrainedModel, CLIPVisionModel } from '@xenova/transformers';
import fs from 'fs';
import path from 'path';

const processor = await AutoProcessor.from_pretrained('mrsarthakgupta/onnx_test_repo_4');
const vision_model = await CLIPVisionModel.from_pretrained('mrsarthakgupta/onnx_test_repo_4', {
    model_file_name: 'vision_model',
    device: 'cpu',
    cache_dir: null,
    dtype: 'fp32',
    quantized: false
},
);

// Read image and run processor
const image = await RawImage.read('FzwU9WMaAAAiaug.jpg');
const time_start = performance.now();
const image_inputs = await processor(image);

console.log('Image inputs:', image_inputs);
const outs = await vision_model(image_inputs);

The original model ID is: mrsarthakgupta/openclipvisionmodel, the model repo is hosted here: https://huggingface.co/mrsarthakgupta/openclipvisionmodel

Did the issue replicate on your end too @xenova ?

Hi @xenova , did this difference in outputs replicate on your end too?

seems like this is an issue with onnxruntime-web itself. I've raised an issue here: https://github.com/microsoft/onnxruntime/issues/21275
just wondering if any of the other converted models also faced an issue like this @xenova


Does App Gateway V1 Support Zonal?

We know App Gateway V1 is not across multiple AZ, but how about zonal? can we create App Gateway V1 in a specific zone?
If yes, potentially I can create App Gateway V1 in each zone to achieve Zone redundancy.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: faa5b8a2-11a1-6a2d-07cb-ffcf39643ed4
Version Independent ID: 298a134e-fb27-f16d-bff2-d43eb0f766fd
Content: Autoscaling and Zone-redundant Application Gateway v2
Content Source: articles/application-gateway/application-gateway-autoscaling-zone-redundant.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@RonnieQuan, Thanks for reaching out. We will investigate and update this thread.

@RonnieQuan, Thanks for reaching out. We will investigate and update this thread.

@RonnieQuan, Appreciate your patience. Availability zone/Zone redundancy concept is not supported in APPGW V1 (standard{small,medium,large} & WAF V1) sizes. This feature is only available for standard V2 for now.
Screen shot of the lab,

We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

@RonnieQuan, Appreciate your patience. Availability zone/Zone redundancy concept is not supported in APPGW V1 (standard{small,medium,large} & WAF V1) sizes. This feature is only available for standard V2 for now.
Screen shot of the lab,

We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Fix #9750: Refactor interfaces into openmetadata-spec module

Describe your changes :

I worked on the ..... because ...

Type of change :

[x] Bug fix
[x] Improvement
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

to be merged after 0.13.2 freeze


update to version <IP_ADDRESS> to allow dark_strip_mean to allow negative values

    <IP_ADDRESS> (2020-06-29)
    P. Geissler: allowed dark_strip_mean to be negative for CDRs

this addresses #1

@toddking @paulgeissler please review. Note I have not user LDDTool to build. I'm not sure if you want to stick with 1.B.0.0 or a newer version.


Compare basic NNs

Write a file to fit and compare basic DNN with GRU, LSTM...

Wrote the first draft of this as a single file \flashiness2016\tf_code_compareRNNs.R


Added support for CSP nonce when secure_headers.gem is used.

The script_tag method in Rollbar::Js::Middleware hardcoded the

Hey @ajgon, thanks for this PR! It's awesome. I just left some comments about the style and minor issues. If you can change it'd be perfect.
Thanks!!

Hey @jondeandres, I'm glad you liked it :smile_cat: I fixed all the stuff you asked for, but if you have any additional remarks, just let me know!
Cheers!

This is closed with https://github.com/rollbar/rollbar-gem/pull/437. Thanks @ajgon!


Chore upgrade phmap to 1.3.8

Proposed changes
upgrade phmap to 1.3.8
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.09 seconds
load time: 489 seconds
storage size:<PHONE_NUMBER>1 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221209095827_clickbench_pr_61010.html


Validates that an apple_framework_packaging's minimum_os_version is n…

…ot lower than those of its deps
Swiftc has already enforced it at compile time, while objective-c doesn't. Adding this validation to ensure it apply to objective-c frameworks, too.

should we include other reviewers to make sure they are aware of the change? This one can potentially break other ppl's build

Is there a reasonable way to unit test this functionality?
Also, would it be worth perf testing this, or is it not substantial compared to the amount of time compiling? You might be able to leverage the work Dimitris did on Uber Poet to have a substantially sized demo repo.

We've already had positive test cases, but I'm not sure how to add negative test cases. Others also ask about this in this issue: https://github.com/bazelbuild/bazel/issues/2751
Performance should not be an issue at all. Everything is in memory. We also iterate deps and transitive_deps multiple times in apple_framework_packaging. Also note that apple_framework_packaging's transitive_deps is its transitive deps. It only includes the various intermediate libraries and the corresponding apple_framework's deps.


Introduce configuration global defaults

Global defaults will be applied to all of the configurations of the same class
within the same Guice context.

Merged, thanks!


Add polygonal models support

[x] Triangle collision detection (barycentric coordinates?).
[x] Triangulated mesh support.

It is possible to render meshes but right now it's ridiculously slow due to the fact that we perform too many hit tests inside of the mesh object itself. Need to further optimize that and subdivide internal components into different lists.

I forgot that I had BVH :( Now mesh automatically uses BVH tree to balance triangles.

Need to check the UV-mapping of the mesh.

UV mapping for individual triangles work great although I will need to add support for proper UV maps for meshes. This will require re-work of the mesh-triangle relationship, e.g. triangle cannot exist without mesh with UV map and normal map.


onlyoffice-bin_latest: 7.4.1 -> 7.5.0, improve inclusion of noto fonts

Description of changes
Bump version. The wlroots bug is still happening, so only the _latest package is being updated.
OnlyOffice gathers system fonts from /usr/share/fonts, so I moved Noto CJK fonts into the FHS instead of using the custom packaging as previously done. This is better because updates follow the main package instead of having to be done manually here, and we get all CJK fonts instead of just Simplified Chinese.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

It starts for me but I can't click on anything. It seems unresponsive. Using it on Wayland

@onny are you using a wlroots-based window manager? If so, this is an upstream bug. The package has been broken up into onlyoffice-bin (working on wlroots, outdated) and onlyoffice-bin_latest (broken on wlroots, up to date).

Should we also implement something like https://github.com/NixOS/nixpkgs/pull/259216 to un-vendor libcef? I can't think of any reason why OnlyOffice would need its own version, and it will improve security and space usage.

7.5.1 has been released, but they seem to have neglected non-MacOS packaging. An issue (https://github.com/ONLYOFFICE/DesktopEditors/issues/1404) was filed, but after a week I'm going to guess it just won't happen. So, we can only go to 7.5.0.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2890

Result of nixpkgs-review pr 262126 run on x86_64-linux 1

1 package built:

onlyoffice-bin_7_5 (onlyoffice-bin_latest)

Noto seems to work, LGTM. Thanks!


[W6.1H][F09-B3]Justin Tan Kun Jie

@justintkj Good job attempting the LO. Some comments added. Please look at them and close the PR once you are done!


Fail from browser status checks more forvigingly.

Data consistency is important, so the hard fail would be correct here until we have a better way of assessing the health of the input data. The issue you had locally was probably caused by an outdated cache; which we should fix by reacting correctly to HTTP cache headers.


Minesweeper Game

I want to add the Minesweeper game using javascript. Please assign it to me.

You can add tour any open-source project in "Other projects" folder.


Add llvm-tools-<maj> on windows as well

Or couldn't we compile our own wrapper-exe (per binary) that just calls the versioned one from C

I just tried that now. It's not as light as a symlink, but waaaay lighter than copying. Each binary takes ~12kb; for 80 binaries in llvm-tools, that amounts to less than 1 MB, which I think is negligible (certainly compared to 300MB if we copied).
https://github.com/conda-forge/llvmdev-feedstock/pull/285/commits/590f8d1c7ad87202771734861715525433ab7a74 is obviously not meant for merge/review, but it shows that the forwarder is robust enough to replace %LIBRARY_BIN%\cmake during the build and have all the rest work out.
Would appreciate your thoughts @isuruf


🐛 Focus not working on some Android devices when setting FPS

What's happening?
If i set my fps in the camera to fps={15} and tap to focus on certain android devices, i get a crash or error where the camera eventually recovers but it leads to a 3 o 4 seconds of UI freezed. If i remove the fps prop, the error does not happen.
Just to clarify, the current camera device indicates focusing is supported and although on my use case im setting fps to 15, i can reproduce it on the ShadowLens and on the example app for that same device.
This happens only on some Androd devices (Pixel 2 and Pixel 5), this does not happen on my iPhone  15 Pro or other android devices (Xiaomi 13c with Android 14 works fine for example).
This same crash happens on the ShadowLens app while recording and tapping to focus.
This is the error on the js side:
{ [session/recoverable-error: An unknown error occurred while creating the Camera Session, but the Camera can recover from it.]
name: 'session/recoverable-error',
_code: 'session/recoverable-error',
_message: 'An unknown error occurred while creating the Camera Session, but the Camera can recover from it.',
_cause: undefined }
Reproduceable Code
<Camera
              fps={15}
              photo={true}
              photoQualityBalance="quality"
              video={true}
              photoHdr={true}
              outputOrientation="device"
              enableZoomGesture={true}
              device={currentDevice}
              format={format}
              torch={torchOn ? 'on' : 'off'}
              isActive={cameraActive}
              audio={audioEnabled}
              photoQualityBalance={'quality'}
              onInitialized={onCameraReady}
              exposure={exposure}
              aspectRatio={aspectRatio}
              videoMode={videoMode}
              enableHighQualityPhotos={highQualityPhotos}
              style={cameraStyle}
              codeScanner={codeScanner && scanCodes}
              videoStabilizationMode={videoStabilization}
              onError={processCameraError}
            ></Camera>

Relevant log output
E  Unable to access camera: CAMERA_ERROR (3): createDefaultRequest:1618: Camera 0: Error creating default request for template 3: Function not implemented (-38)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  java.lang.Exception: Stack trace
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.lang.Thread.dumpStack(Thread.java:1529)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.CaptureSession.issueBurstCaptureRequest(CaptureSession.java:796)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.CaptureSession.issuePendingCaptureRequest(CaptureSession.java:659)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.CaptureSession.issueCaptureRequests(CaptureSession.java:546)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.Camera2CameraImpl.submitCaptureRequests(Camera2CameraImpl.java:1645)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.Camera2CameraImpl$ControlUpdateListenerInternal.onCameraControlCaptureRequests(Camera2CameraImpl.java:2363)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.Camera2CameraControlImpl.submitCaptureRequestsInternal(Camera2CameraControlImpl.java:640)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl.cancelAfAeTrigger(FocusMeteringControl.java:527)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl.cancelFocusAndMeteringInternal(FocusMeteringControl.java:828)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl.cancelFocusAndMeteringWithoutAsyncResult(FocusMeteringControl.java:815)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl.lambda$executeMeteringAction$10$androidx-camera-camera2-internal-FocusMeteringControl(FocusMeteringControl.java:790)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl$$ExternalSyntheticLambda6.run(Unknown Source:4)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.core.impl.utils.executor.SequentialExecutor$QueueWorker.workOnQueue(SequentialExecutor.java:231)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.core.impl.utils.executor.SequentialExecutor$QueueWorker.run(SequentialExecutor.java:173)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
2024-06-26 12:46:18.701  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.lang.Thread.run(Thread.java:923)
2024-06-26 12:46:18.702  8783-8847  UseCaseAttachState      com.mrousavy.camera.example          D  Active and attached use case: [androidx.camera.video.VideoCapture-5d589c8b-abae-4cdb-bb29-e961f854f21e137680087, androidx.camera.core.Preview-1694c683-ccda-428d-bcc2-a294807f7b4e261039729, androidx.camera.core.ImageCapture-c30a4f7f-1d88-4457-af5a-a206df9de3b4168819798] for camera: 0
2024-06-26 12:46:18.703  8783-8847  CaptureSession          com.mrousavy.camera.example          D  Attempting to submit CaptureRequest after setting
2024-06-26 12:46:18.703  8783-8847  CaptureSession          com.mrousavy.camera.example          D  Issuing request for session.
2024-06-26 12:46:18.703  8783-8847  Camera2Cap...estBuilder com.mrousavy.camera.example          D  createCaptureRequest
2024-06-26 12:46:18.704  8783-8847  CaptureSession          com.mrousavy.camera.example          E  Unable to access camera: CAMERA_ERROR (3): The camera device has encountered a serious error
2024-06-26 12:46:18.704  8783-8847  System.err              com.mrousavy.camera.example          W  java.lang.Exception: Stack trace
2024-06-26 12:46:18.704  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.lang.Thread.dumpStack(Thread.java:1529)
2024-06-26 12:46:18.704  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.CaptureSession.issueRepeatingCaptureRequests(CaptureSession.java:644)
2024-06-26 12:46:18.704  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.CaptureSession.setSessionConfig(CaptureSession.java:185)
2024-06-26 12:46:18.704  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.Camera2CameraImpl.updateCaptureSessionConfig(Camera2CameraImpl.java:1399)
2024-06-26 12:46:18.704  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.Camera2CameraImpl$ControlUpdateListenerInternal.onCameraControlUpdateSessionConfig(Camera2CameraImpl.java:2357)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.Camera2CameraControlImpl.updateSessionConfigSynchronous(Camera2CameraControlImpl.java:569)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl.cancelFocusAndMeteringInternal(FocusMeteringControl.java:835)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl.cancelFocusAndMeteringWithoutAsyncResult(FocusMeteringControl.java:815)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl.lambda$executeMeteringAction$10$androidx-camera-camera2-internal-FocusMeteringControl(FocusMeteringControl.java:790)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.camera2.internal.FocusMeteringControl$$ExternalSyntheticLambda6.run(Unknown Source:4)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.core.impl.utils.executor.SequentialExecutor$QueueWorker.workOnQueue(SequentialExecutor.java:231)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at androidx.camera.core.impl.utils.executor.SequentialExecutor$QueueWorker.run(SequentialExecutor.java:173)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
2024-06-26 12:46:18.705  8783-8847  System.err              com.mrousavy.camera.example          W  	at java.lang.Thread.run(Thread.java:923)
2024-06-26 12:46:18.706  8783-8847  DeferrableSurface       com.mrousavy.camera.example          D  use count-1,  useCount=1 closed=false androidx.camera.core.SurfaceRequest$2@23e2706
2024-06-26 12:46:18.706  8783-8847  DeferrableSurface       com.mrousavy.camera.example          D  use count-1,  useCount=0 closed=false androidx.camera.core.impl.ImmediateSurface@afe1b60
2024-06-26 12:46:18.706  8783-8847  DeferrableSurface       com.mrousavy.camera.example          D  Surface no longer in use[total_surfaces=5, used_surfaces=2](androidx.camera.core.impl.ImmediateSurface@afe1b60}
2024-06-26 12:46:18.706  8783-8847  DeferrableSurface       com.mrousavy.camera.example          D  use count-1,  useCount=1 closed=false androidx.camera.core.SurfaceRequest$2@13bc404
2024-06-26 12:46:18.707  8783-8847  Camera2CameraImpl       com.mrousavy.camera.example          D  {Camera@1db0428[id=0]} Camera receive onErrorCallback
2024-06-26 12:46:18.707  8783-8847  Camera2CameraImpl       com.mrousavy.camera.example          D  CameraDevice.onError(): 0 failed with ERROR_CAMERA_DEVICE while in OPENED state. Will attempt recovering from error.
2024-06-26 12:46:18.707  8783-8847  Camera2CameraImpl       com.mrousavy.camera.example          D  Attempt to reopen camera[0] after error[ERROR_CAMERA_DEVICE]
2024-06-26 12:46:18.708  8783-8847  Camera2CameraImpl       com.mrousavy.camera.example          D  {Camera@1db0428[id=0]} Transitioning camera internal state: OPENED --> REOPENING
2024-06-26 12:46:18.708  8783-8847  CameraStateRegistry     com.mrousavy.camera.example          D  Recalculating open cameras:
                                                                                Camera                                       State
                                                                                -------------------------------------------------------------------
                                                                                Camera@1db0428[id=0]                         OPENING
                                                                                Camera@e956fc3[id=1]                         UNKNOWN
                                                                                -------------------------------------------------------------------
                                                                                Open count: 1 (Max allowed: 1)
2024-06-26 12:46:18.709  8783-8847  CameraStateMachine      com.mrousavy.camera.example          D  New public camera state CameraState{type=OPENING, error=StateError{code=3, cause=null}} from OPENING and StateError{code=3, cause=null}
2024-06-26 12:46:18.709  8783-8847  CameraStateMachine      com.mrousavy.camera.example          D  Publishing new public camera state CameraState{type=OPENING, error=StateError{code=3, cause=null}}
2024-06-26 12:46:18.709  8783-8783  CameraSession           com.mrousavy.camera.example          I  Camera State: OPENING (has error: true)
2024-06-26 12:46:18.709  8783-8847  Camera2CameraImpl       com.mrousavy.camera.example          D  {Camera@1db0428[id=0]} Resetting Capture Session
2024-06-26 12:46:18.709  8783-8847  SyncCaptureSessionImpl  com.mrousavy.camera.example          D  [androidx.camera.camera2.internal.SynchronizedCaptureSessionImpl@7d91285] Session call close()
2024-06-26 12:46:18.709  8783-8783  CameraView              com.mrousavy.camera.example          E  invokeOnError(...):
2024-06-26 12:46:18.709  8783-8783  System.err              com.mrousavy.camera.example          W  com.mrousavy.camera.core.RecoverableError: An unknown error occurred while creating the Camera Session, but the Camera can recover from it.

Camera Device
{"hardwareLevel": "full", "hasFlash": true, "hasTorch": true, "id": "0", "isMultiCam": false, "maxExposure": 12, "maxZoom": 7, "minExposure": -12, "minFocusDistance": 10, "minZoom": 1, "name": "0 (BACK) androidx.camera.camera2", "neutralZoom": 1, "physicalDevices": ["wide-angle-camera"], "position": "back", "sensorOrientation": "landscape-left", "supportsFocus": true, "supportsLowLightBoost": false, "supportsRawCapture": false}

Device
Google Pixel 2 Android 11
VisionCamera Version
4.1.0
Can you reproduce this issue in the VisionCamera Example app?
Yes, I can reproduce the same issue in the Example app here
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

So this is definitely a CameraX bug then.
Can you report it in the CameraX issue tracker?

(thanks for the detailed testing & logs btw)

Did you post a CameraX issue? If yes, please link it here for visibility.

Hi, I was quite busy I'll try to do it today. I'll paste the link here as soon it's done. Thanks!

Hi, I was quite busy I'll try to do it today. I'll paste the link here as soon it's done. Thanks!


Update "person" to "patient" on static site

Related Issue or Background Info
Issue #4660
Changes Proposed
Replace mentions of "people" with "patients" (including images) to reflect recent update on SimpleReport app on the following pages:

Conduct and submit tests
Add a new person
Archive a person
Update someone's profile

Additional Information
Static site audit

Currently deployed on dev4