Unable to build on Windows - SCons Error

Godot version: e47915f7cd9336a37d08891a046a4bd778572a73
OS/device including version: Windows 10
Issue description:
When trying to build with SCons, I get the following error:
scons: *** SDK version '10.0A' is not supported
File "./platform/windows\detect.py", line 146, in setup_msvc_auto

Additional Info:
scons --version output:
SCons by Steven Knight et al.:
        script: v<IP_ADDRESS>a41ed6b288cee8d085373ad7fa02894e1903864, 2019-01-20 22:51:36, by bdeegan on kufra
        engine: v<IP_ADDRESS>a41ed6b288cee8d085373ad7fa02894e1903864, 2019-01-20 22:51:36, by bdeegan on kufra
        engine path: ['c:\\program files (x86)\\python\\python37-32\\lib\\site-packages\\scons\\SCons']

Are you using MSVC 2017?

Yeah, Visual Studio 2017.

SCons explicitly lists suported versions of MSVC and SDK. 10.0A isn't in the list.
You can try this patch to see if that is sufficient.
in SCons/Tools/MSCommon/sdk.py
line 181 change 10.0 to 10.0A
Let me know if that works.
Did you separately install SDK or as part of your MSVC install?
Also run vswhere and paste the output here.

Hmmm, it seems to me scons is working okay with a 10.0A installed, maybe it's picking a different one instead.  I have a system which has these directories in Program Files (x86)/Microsoft SDKs/Windows: v10.0A, V7.0A, V8.0, V8.1, v8.1A.  Possible the scons section on SDKs needs a bit of rework as the only one in that list that appears in the scons "supported" list is 7.0A (there are no 8.x's at all).  If @bdbaddog agrees maybe this should move over to the scons issue tracker?

Changing that line in SCons/Tools/MSCommon/sdk.py does seem to solve the issue (although I can't say for 100% certain as I now have a different error, but I'm fairly sure it's unrelated).
I installed the SDK as part of the Visual Studio 2017 installer.
I did try manually installing Windows 10 SDK separately after getting this to see if it solved the error, but it seems to have made no difference.
In Program Files (x86)/Microsoft SDKs/Windows I have only v10.0A even though in the Visual Studio Installer it lists Windows 8.1 SDK as installed. Does the new installer put them somewhere else?
Output of vswhere:
Visual Studio Locator version 2.5.2+gebb9f26a3d [query version 1.17.1230.42073]
Copyright (C) Microsoft Corporation. All rights reserved.

instanceId: d91334f6
installDate: 15/10/2018 15:12:43
installationName: VisualStudio/15.8.7+28010.2046
installationPath: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community
installationVersion: 15.8.28010.2046
productId: Microsoft.VisualStudio.Product.Community
productPath: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\devenv.exe
isPrerelease: 0
displayName: Visual Studio Community 2017
description: Free, fully-featured IDE for students, open-source and individual developers
channelId: VisualStudio.15.Release
channelUri: https://aka.ms/vs/15/release/channel
enginePath: C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service
releaseNotes: https://go.microsoft.com/fwlink/?LinkId=660692#15.8.7
thirdPartyNotices: https://go.microsoft.com/fwlink/?LinkId=660708
updateDate: 2018-10-15T14:12:43.7052585Z
catalog_buildBranch: d15.8
catalog_buildVersion: 15.8.28010.2046
catalog_id: VisualStudio/15.8.7+28010.2046
catalog_localBuild: build-lab
catalog_manifestName: VisualStudio
catalog_manifestType: installer
catalog_productDisplayVersion: 15.8.7
catalog_productLine: Dev15
catalog_productLineVersion: 2017
catalog_productMilestone: RTW
catalog_productMilestoneIsPreRelease: False
catalog_productName: Visual Studio
catalog_productPatchVersion: 7
catalog_productPreReleaseMilestoneSuffix: 1.0
catalog_productRelease: RTW
catalog_productSemanticVersion: 15.8.7+28010.2046
catalog_requiredEngineVersion: 1.17.1230.42073
properties_campaignId:
properties_channelManifestId: VisualStudio.15.Release/15.8.7+28010.2046
properties_nickname:
properties_setupEngineFilePath: C:\Program Files (x86)\Microsoft Visual Studio\Installer\vs_installershell.exe

O.k. I'm guessing V10.A is installed with a VS 2017 update.
I'll see if I can repro and fix it in master.

Looks like a fair bit has changed in the registry and the values it's looking for don't match up well with setups that never had any older versions in place.

in SCons/Tools/MSCommon/sdk.py
line 181 change 10.0 to 10.0A

Did a fresh install today and was getting the 10.0A not supported error. The above method edits enabled compilation on my system.

So when can we expect this 3.0.5 update of scons? This is a critical bug affecting every up to date windows machine and I won't build the buildsystem from source because of some bad design choices on their side.

So when can we expect this 3.0.5 update of scons? This is a critical bug affecting every up to date windows machine and I won't build the buildsystem from source because of some bad design choices on their side.

Hopefully later today. Note there is a test build available on testpypi
pip install --index-url https://test.pypi.org/simple/ scons==3.0.5a3

I tried the test build and am still getting the same error message.
`scons --version
SCons by Steven Knight et al.:
script: v3.0.5.alpha.yyyymmdd.387e1f36f19d7a1e5f06cad4d6e87d84893c3ac2, 2019-03-15 22:17:20, by bdbaddog on Williams-MacBook-Pro
engine: v3.0.5.alpha.yyyymmdd.387e1f36f19d7a1e5f06cad4d6e87d84893c3ac2, 2019-03-15 22:17:20, by bdbaddog on Williams-MacBook-Pro
engine path: ['...local\programs\python\python37-32\lib\site-packages\scons\SCons']
Copyright (c) 2001 - 2019 The SCons Foundation
PS D:\Portable\Godotengine\godot> scons platform=windows
scons: Reading SConscript files ...
Configuring for Windows: target=debug, bits=default
scons: *** SDK version '10.0A' is not supported
File "./platform/windows\detect.py", line 146, in setup_msvc_auto`

With the sdk.py fix mentioned above it works perfectly

Try again with 3.0.5a4 I didn't realize the V10.0A didn't make it into the last test package.

Seems to work :+1:

I am experiencing the same issue as OP, except I am on Win7 64-bit.  Will try recommended solutions now.

3.0.5 was recently release and should fix this issue
On Sat, Mar 30, 2019 at 1:53 PM Den Vorontsov<EMAIL_ADDRESS>wrote:

I am experiencing the same issue as OP, except I am on Win7 64-bit. Will
try recommended solutions now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/26485#issuecomment-478288475,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFBNFC2VQCFxnkm1JUwL89pTulBoby-ks5vb87YgaJpZM4baZvn
.

Indeed it is fixed !


style : pagination on comment section is broken

Fixes #3231
Screenshots of the changes (If any) -

After

Before

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage remained the same at 81.836% when pulling d1244687223b3ae075cf5aabd46bd55acef248b0 on issue3231 into 1ddf72cbb47dbea45d722942ad8dc65ba5998381 on master.


Fix: fireExceptionCaught from HttpRuntime

Codecov Report

Merging #1326 (c16a95b) into main (90a26a9) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   60.45%   60.38%   -0.07%
==========================================
  Files          71       71
  Lines        2526     2527       +1
  Branches       82       80       -2
==========================================
- Hits         1527     1526       -1
- Misses        999     1001       +2

Impacted Files
Coverage Δ

...ttp/src/main/scala/zhttp/service/HttpRuntime.scala
79.48% <66.66%> (-2.10%)
:arrow_down:

...io-http/src/main/scala/zhttp/service/Handler.scala
65.21% <0.00%> (-8.70%)
:arrow_down:

...http/service/server/ServerChannelInitializer.scala
78.26% <0.00%> (-4.35%)
:arrow_down:

zio-http/src/main/scala/zhttp/http/HttpData.scala
81.81% <0.00%> (-1.52%)
:arrow_down:

zio-http/src/main/scala/zhttp/http/Response.scala
84.28% <0.00%> (+1.42%)
:arrow_up:

...ain/scala/zhttp/service/ServerResponseWriter.scala
88.37% <0.00%> (+4.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a26a9...c16a95b. Read the comment docs.


Adds a check for an empty response to FindById()'s scanJob

Fixes #18
Note this doesn't seem to fix it for all transactions but it works for scanJob. Feel free to close if you want to fix it at a higher level.

@albrow This should be good now. It's also passing the tests. I switched my error to ErrJobNotFound which is just an exported var. So users can easily check it like you said.

@epelc thanks for this. I would like to include the job id in the error message. Could you add that?
As described in CONTRIBUTING.md jobs uses a specific branching model and pull requests should request to be merged into develop, not master. Would you mind closing this and submitting a new PR to merge into develop?


No README data

When I npm install this package I get the error:
npm WARN package.json<EMAIL_ADDRESS>No README data

Normally I only see that when a package doesn't have a README.md file, but this one has one, so I'm not sure what the problem is. You'll notice that it doesn't have any README.md data on the package listing on npmjs.org. But I'd really like to get rid of this warning as it clutters up my warnings and makes it difficult for me to find real issues.

Seems problem in .npmignore here


Wrong JPEG library version

Hello! I'm running on mac OS X El Capitan 10.11.2
I tried to install neural-stype following the instructions here
But when I try to run th neural_style.lua -gpu -1 -print_iter -1, I got these errors:

[libprotobuf WARNING google/protobuf/io/coded_stream.cc:569] Reading dangerously large protocol message.  If the message turns out to be larger than<PHONE_NUMBER> bytes, parsing will be halted for security reasons.  To increase the limit (or to disable these warnings), see CodedInputStream::SetTotalBytesLimit() in google/protobuf/io/coded_stream.h.
[libprotobuf WARNING google/protobuf/io/coded_stream.cc:81] The total number of bytes read was 574671192
Successfully loaded models/VGG_ILSVRC_19_layers.caffemodel
conv1_1: 64 3 3 3
conv1_2: 64 64 3 3
conv2_1: 128 64 3 3
conv2_2: 128 128 3 3
conv3_1: 256 128 3 3
conv3_2: 256 256 3 3
conv3_3: 256 256 3 3
conv3_4: 256 256 3 3
conv4_1: 512 256 3 3
conv4_2: 512 512 3 3
conv4_3: 512 512 3 3
conv4_4: 512 512 3 3
conv5_1: 512 512 3 3
conv5_2: 512 512 3 3
conv5_3: 512 512 3 3
conv5_4: 512 512 3 3
fc6: 1 1 25088 4096
fc7: 1 1 4096 4096
fc8: 1 1 4096 1000
/Users/lesley/torch/install/bin/luajit: /Users/lesley/torch/install/share/lua/5.1/image/init.lua:219: Wrong JPEG library version: library is 90, caller expects 62
stack traceback:
[C]: in function 'load'
/Users/lesley/torch/install/share/lua/5.1/image/init.lua:219: in function 'loader'
/Users/lesley/torch/install/share/lua/5.1/image/init.lua:367: in function 'load'
neural_style.lua:82: in function 'main'
neural_style.lua:500: in main chunk
[C]: in function 'dofile'
...gqiu/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: at 0x010f8c0bc0

I have spent much time on this issue, I uninstalled torch and loadcaffe , then installed them again for twice, but I still get this error, I really need some help :(

I've never seen that one before. I don't think it's a problem with loadcaffe; maybe try reinstalling the image package?

@jcjohnson Thanks for the advice, I'll try it and report the result.

Hi, I tried to reinstall the image package,but still have this error.
I ran the error through google and found someone else met the same error, according to some of the solutions, this may caused by having two versions of libjpeg. So I tried to delete libjpeg 9 , and run th neural_style.lua -gpu -1 -print_iter -1 .Then I run into a different error:

conv1_1: 64 3 3 3
conv1_2: 64 64 3 3
conv2_1: 128 64 3 3
conv2_2: 128 128 3 3
conv3_1: 256 128 3 3
conv3_2: 256 256 3 3
conv3_3: 256 256 3 3
conv3_4: 256 256 3 3
conv4_1: 512 256 3 3
conv4_2: 512 512 3 3
conv4_3: 512 512 3 3
conv4_4: 512 512 3 3
conv5_1: 512 512 3 3
conv5_2: 512 512 3 3
conv5_3: 512 512 3 3
conv5_4: 512 512 3 3
fc6: 1 1 25088 4096
fc7: 1 1 4096 4096
fc8: 1 1 4096 1000
/Users/heqingqiu/torch/install/share/lua/5.1/trepl/init.lua:384: ...eqingqiu/torch/install/share/lua/5.1/luarocks/loader.lua:117: error loading module 'libjpeg' from file '/Users/heqingqiu/torch/install/lib/lua/5.1/libjpeg.so':
dlopen(/Users/heqingqiu/torch/install/lib/lua/5.1/libjpeg.so, 6): Library not loaded: libjpeg.8.dylib
Referenced from: /Users/heqingqiu/torch/install/lib/lua/5.1/libjpeg.so
Reason: image not found
warning:  could not be loaded (is it installed?)
/Users/heqingqiu/torch/install/bin/luajit: /Users/heqingqiu/torch/install/share/lua/5.1/dok/inline.lua:738: <image.loadJPG> libjpeg package not found, please install libjpeg
stack traceback:
[C]: in function 'error'
/Users/heqingqiu/torch/install/share/lua/5.1/dok/inline.lua:738: in function 'error'
/Users/heqingqiu/torch/install/share/lua/5.1/image/init.lua:216: in function 'loader'
/Users/heqingqiu/torch/install/share/lua/5.1/image/init.lua:367: in function 'load'
neural_style.lua:82: in function 'main'
neural_style.lua:500: in main chunk
[C]: in function 'dofile'
...gqiu/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: at 0x0104358bc0

I did install libjpeg 6 , but it seems that it cannot be loaded. If I install libjpeg 8, I will have another 'wrong JPEG library version' said:

library is 80, caller expects 62

At the end I still cannot solve this problem, so I tried to install neural-style on my mac mini , it worked well, but relatively slow , because I cannot use gpu on my mac mini . Anyway, thanks for your great work!  @jcjohnson

I had the same issue (OSX 10.9) and found the solution here:
https://github.com/torch/image/issues/16

I'm still having this issue, and tried everything I could think of.  I pulled any copies of libjpeg floating around and dumped 'em, I've reinstalled luarocks image, brew jpeg, relinked brew jpeg, reinstalled torch... Still always get the error:
/Users/mushoo/torch/install/share/lua/5.1/image/init.lua:219: Wrong JPEG library version: library is 80, caller expects 62
Not sure where or why it's looking for version 62, and not really sure how I would go about force-installing 62 over 80.  Any ideas?

what fixed it for me was:

uninstall torch
sudo apt-get install libjpeg-dev libpng12-dev
I'm running Ubuntu 14.04, you might have to find the appropriate "lib" packages for your OS

I tried to remove all duplicated libjpeg.dylib files in my computer, but couldn't make it work.
In the end, I tried to use PNGs instead, and it works

Try using libjpeg dev instead of libjpeg, it should be a bit more compatible(pretty much what randomrandom said)

Have anyone solved this? I am getting the following error
Wrong JPEG library version: library is 80, caller expects 90
I have tried to install version nine using instructions here:
http://mac-dev-env.patrickbougie.com/libjpeg/
but it doesn't work
It also doesn't work with PNG images

I got same error, nothing helps, waiting for advice please.

I found a solution by manually install the right libjpeg binary version. In my case I got this error:
Wrong JPEG library version: library is 80, caller expects 62

So I found an old libjpeg v62 binary from searching the internet: https://gitlab.com/xonotic/xonotic/raw/e81fb5aafb41d70897cafab7dcd5ceae17d13160/misc/buildfiles/osx/Xonotic.app/Contents/MacOS/libjpeg.62.dylib
Then you can copy to appropriate directory using:
cp /Users/tan_vachiramon/Downloads/libjpeg.62.dylib /usr/local/lib/

Now neural_style.lua runs fine :)

Thanks a lot tanvach, but now I got another error:
> th -limage -e "image.lena()"
~/torch/install/share/lua/5.1/image/init.lua:220: JPEG parameter struct mismatch: library thinks size is 632, caller expects 600

Hey romkrl, what is the exact error you are getting?

> th -limage -e "image.lena()"
.../torch/install/share/lua/5.1/image/init.lua:220: Wrong JPEG library version: library is 80, caller expects 62
that was before using old dlyb that you suggest me.
Thanks a lot for your help @tanvach!
And after I do:
`

rm /usr/local/lib/libjpeg.dylib
rm /usr/local/lib/libjpeg.a
rm /usr/local/lib/libjpeg.8.dylib
cp ~/Downloads/libjpeg.62.dylib /usr/local/lib/libjpeg.dylib
cp ~/Downloads/libjpeg.62.dylib /usr/local/lib/libjpeg.dylib
luarocks install image
`

And I got this error:
`

th -limage -e "image.lena()"
...rs/romkri/torch/install/share/lua/5.1/image/init.lua:220: JPEG parameter struct mismatch: library thinks size is 632, caller expects 600
`

Hello, I have the same issue.
I have tried to install the libjpeg version 62, as suggested, but I have error libjpeg not found.
Any plan to update neuras_style to use version 80? I think it would be the definitive solution
Thank you very much.

Hi all! I'm also getting this same error (on OS X 10.10.5)
For example:
$ th -limage -e "image.lena()"
/usr/local/torch/install/share/lua/5.1/image/init.lua:220: Wrong JPEG library version: library is 90, caller expects 62

I then tried to specify the version of libjpeg to use by doing:
mkdir samy-libs
ln -s /usr/local/lib/libjpeg.62.dylib samy-libs/
ln -s /usr/local/lib/libjpeg.62.dylib samy-libs/libjpeg.dylib
export CMAKE_LIBRARY_PATH=`pwd`/samy-libs
luarocks install image

Now I get:
$ th -limage -e "image.lena()"
/usr/local/torch/install/share/lua/5.1/image/init.lua:220: JPEG parameter struct mismatch: library thinks size is 632, caller expects 600

Any suggestions? I tried tanvach's suggestion (which is the same library that I have, verified via md5) and getting the same issue.

I was able to solve this, though with a big hack. Running:
git clone https://github.com/torch/image
mkdir image/build
cd image/build
cmake .. && make
grep * -re jpeglib

The grep spit out:
CMakeFiles/jpeg.dir/C.includecache:/Library/Frameworks/SpeakerPhonePublicSupport.framework/Headers/jpeglib.h

Since I don't use that framework (SpeakerPhone) for anything anymore, I backed it up and copied all the jpeg-6b .h files into it (after downloading jpeg-6b from sourceforge):
cp /tmp/jpeg-6b/*.h /Library/Frameworks/SpeakerPhonePublicSupport.framework/Headers/
luarocks install image

And now
$ th -limage -e "image.lena()" && echo yay yay

I recently faced this problem because brew still has libjpeg version 80. The following procedure worked for me.

Uninstall image  (luarocks remove image)
Remove libjpeg version 80(brew unlink libjpeg) and install libjpeg version 90 by following the procedure from here: http://mac-dev-env.patrickbougie.com/libjpeg/ (link mentioned previously by morienor)
Install image (luarocks install image)

The key is to uninstall image and then install it after the libjpeg update so that it links against the newer version of libjpeg.

Frameworks with headers cause CMake to produce an incorrect build.
CMake has this funny parameter called CMAKE_FIND_FRAMEWORK which is set by default to FIRST. This means that CMake will first look for files first in all framework directories, and only then in regular include directories. Funnily enough frameworks (in my case it was Mono) may contain the headers for libjpeg and libpng. So, CMake finds the headers in Mono, but the library in the regular install location, e.g. /usr/local/lib and therefore a version mismatch happens.
Mono is a known menace (for some time brew doctor warned if Mono is installed that builds may fail). You can see this behavior if you create a CMakeLists.txt file with the single line find_package(JPEG), run cmake . and take a look at the paths in the generated CMakeCache.txt file.
The fix that definitively worked for me was to check out the project manually, add set(CMAKE_FIND_FRAMEWORK LAST) to CMakeLists.txt before the find_package calls and then run luarocks make. This way CMake found the headers in the right folder.

@noamlerner How did you install the correct version there?

@NightMachinary I had the right version on my computer somewhere, I just copied (cp) it

Ok I after trying without luck for more than a few hours, this is what worked for me, macOS Sierra 10.12.6.

I downloaded the version 62 of the library as showed by @tanvach (huge thanks for the link) !
ls /usr/local/lib/libjpeg.*.dylib to show all of my libjpeg libraries, then copied them to a backup place
ln -s ~/Desktop/TEMP/libjpeg.62.dylib /usr/local/lib/libjpeg.dyli to create a symlink to version 62
luarocks remove image --force
luarocks install image

To test if it works:
th -limage -e "image.lena()" && echo "ok"
just prints ok!
Now I've got another error (Couldn't load models/nin_imagenet_conv.caffemodel) but the libjpeg stuff works! Huge thanks to everybody that posted here! 🥇


While it runs great with invoking the command docker exec -it gphotos-uploader run from host - I cannot get the container to run the command from cron within the container. It is running gphotos-uploader-cli command from cron in the container - which does not upload photos.
Any clues on how to fix this?
Thanks

Can you please try the preview version (instead of latest or a fixed version) I just uploaded to DockerHub and see if that solves the issue for you? Let me know how it goes. Thanks.

That fixed it! Thanks!!

Great, will make a new production release and tag latest :)


[Feature Request] Include group-level done fields in the VMAS environment

Motivation
In the current implementation of the VMAS environment, the done fields are only available on the root of the tensordict. However, for training, it is useful to have them in the group-level.
This is also an issue for the TorchRL tutorial scripts multiagent_ppo.py and multiagent_competitive_ddpg.py, which have to manually add the done and terminated at group-level with the right shape
https://github.com/pytorch/rl/blob/main/tutorials/sphinx-tutorials/multiagent_ppo.py#L655
https://github.com/pytorch/rl/blob/main/tutorials/sphinx-tutorials/multiagent_competitive_ddpg.py#L732
The PettingZoo env implementation does include the group-level done fields.
So, can we also include these fields in the VMAS code? If so, I'd be willing to work on this feature.
Checklist

[x] I have checked that there is no similar issue in the repo (required)

Tagging @matteobettini, as you also worked on the VmasEnv.

Hey thanks for opening this.
So the idea is that the location of the done keys of a multiagent env will tell you how the env operates. For example:

in PettingZoo, the done and the rewards are per-agent, so this keys are in the group tds (we also have the global done as this allows to decide when to reset)
in VMAS, the done is global (thus in the root of the td) and the reward is per-agent (in the subgroups). This is the reason why, before training, we expand the done to match the reward shape and make torch happy
in SMAC both rewards and done are global (this in the root), so potentially we could avoid expanding them for computations

In general the rationale is that, if some of the keys need to be expanded later, this can be done at the time you need it in a lazy way.
Pre-adding this extra keys and creating new entries in the env tds regardless of whether you will need it could lead to extra computation, due to the fact that torchrl will track a larget done_spec and so on.
Another motivation is: Now, by looking at the td coming from a vmas env, you immediatly know that there is not a per-agent done.
If instead we add this, a user would not immediately know that it is just a copy of the global that is useful to have for some training operations.
Let me know what you think

So the idea is that the location of the done keys of a multi-agent env will tell you how the env operates.

That makes sense! And I agree that it is more intuitive this way instead of having the fields everywhere.
However, IMO it is suboptimal to have to manually patch the data so that it is compatible with the trainer. I'd expect the TorchRL environments and the TorchRL trainers to be plug and play compatible.
Or at least to have a default solution for this. I see some options for such a solution:

Adding an env transform to patch the data (I don't think that such a transform exists?).
Adding a postproc for the collector to patch the data (IMO the preferred approach).

What do you think of this?

Yeah 2 is the best.
we actually already have that transform in our implementations https://github.com/pytorch/rl/blob/997d90e1b4e497707903801addee64a199f1ce1a/sota-implementations/multiagent/utils/utils.py#L21
We could consider extending it and adding it to the lib!
@vmoens

Oh, this is great! Should we move this transform to the main lib and also use this in the tutorials? I'm open to working on this.

I'm open to it, @matteobettini do you remember why it's not part of the core lib?
The doc strings are a bit dull and the name of the transform is a bit too generic to my taste but it'd fit nicely in the lib!

I don’t remember.
Yes, agreed, we need to extend it and test it a bit bit it would be v useful to have

We could also consider having a “multiagent” file in the transforms to avoid clutter

Ofc if the usage is only in MARL settings that makes sense


Computing train metrics at a given frequency

🚀 Feature Request
Add the possibility to compute metrics on the train dataset with a given frequency and avoid computing these every steps
Motivation
Having the possibility to compute training metrics is great and allow a good control on what is happening at this stage. Some metrics can be quite compute intensive and we might want to compute these on a lower frequency to reduce to compute needed.
This should come with a default behaviour falling back to the current one: evaluating the training metrics for each batch.
Implementation
There is a eval_interval argument for the when to run evaluation and I propose to keep the same logic with a train_metric_interval to decide when to compute training metrics.
Happy to have a look and propose an implementation.

Hm... this is a bit tricky since this would affect all metrics...
Two proposed workarounds:

Store metric separately in callback, which easily gives control over frequency
Have code in metric to control frequency and ignore some calls (not ideal)

What do you think of alternatives? Not strongly opposed to proposal, but my regularizer is to avoid adding trainer args as much as possible


Switch failed code quality check comment to workflow_run

What does this PR do?

The workflow used for posting a comment when the code quality check failed is currently a workflow_call, which doesn't have more permissions than the caller workflow (i.e. pull_request) and thus cannot post a comment in a PR from a fork.
This PR updates this workflow switching to workflow_run to fix that.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[README.md] Create a readme.md for Guide to new contributors

Detailed description
For new contributors that would like to add one more ideas to this web app need a readme document for guide to run the app locally on there machine. I was able to run the web-app on locally  base on my knowledge about open source.

Context

Easy to run the web app locally
As Guide for improvement
Gives other to contribute to the project

Possible implementation
If Permission Granted I can provide a ReadMe Document for the web app.
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

hey! I would love to work on this , could I please be assigned  this issue, if someone isnt already working on it ? :D


[DOCS] Using >>> in documentation is incorrectly formatted on website

URL(s) with the issue:
https://www.tensorflow.org/api_docs/python/tf/constant_initializer
Description of issue (what needs changing):
The example code uses >>>, but on the website, this is incorrectly converted to >>>
TF docs link: https://www.tensorflow.org/api_docs/python/tf/constant_initializer
Submit a pull request?
This is more of a problem with how documentation is generated from comments in the python file. I don't mind taking a look if someone can point out where to get started.

This looks fixed in nightly: https://www.tensorflow.org/api_docs/python/tf/constant_initializer?version=nightly


Verify there are no new sources of evidence string duplication after migrating to v2.0

The new algorithm for generating evidence strings should not allow any duplicates. Confirmed there are no duplicate evidence strings in the latest generated set (2021-04-alpha). An upcoming PR will add a check in the evidence string generation protocol to ensure this is always the case.


added deep modify test

Ok I've added a test.
What is strange is that I'm not seeing the behaviour about mutating of child fields but I am seeing that the parent container field isn't mutating.
I'll look more at a fix, just getting my head around the code.

This passes with v4.1.15.


FR translation

Hello,
here you go the french (FR) translation (imho it can also suit for the BE, CA and CH French speaking langage).
Have a nice day, regards.
LeafView_FR_translate.zip

@BackSpace54
Je vous remercie beaucoup.
I have merged your request.


refactor connection limits and throttling

This doesn't fix any actual races, because there weren't any :-) Instead, this:

Moves the locks protecting ConnectionLimits and ConnectionThrottler inside the structs/methods, so they don't have to be managed externally by Server
Moves them into their own package, irc/connection_limiting
Adds INFO-level loglines anytime they block a connection. (Maybe it should be WARNING?)

Nice, this is awesome!
I'd like to rename the package to irc/connection_limits rather than connection_limiting. I dunno why, having limiting in the package name just feels weird to me.
Could we name the two creation functions NewLimiter and NewThrottler, and at the same time rename the actual classes themselves Limiter and Throttler? (LimitConfig, ThrottleConfig, etc)

Nice! I originally picked connection_limiting to avoid the ambiguity between a connection_limits package and a ConnectionLimits struct, but this new scheme kills all the birds with one stone.

Nice. I'm happy to merge this in no problems if you're happy with it :)

I just did some quick testing on my stage instance (triggering both the Limiter and Throttler thresholds) and everything looks good, merge away :-)


Bug - Focus cannot be seen for radio buttons and checkboxes in Windows High Contrast Mode

Describe the bug

In Windows High Contrast Mode, it is impossible to tell which of the big checkboxes or radio buttons (https://design.canada.ca/common-design-patterns/checkboxes-radio-buttons.html) is focused.
To Reproduce

Steps to reproduce the behaviour:

Turn on Windows High Contrast Mode (see https://support.microsoft.com/en-us/windows/use-high-contrast-mode-in-windows-10-fedc744c-90ac-69df-aed5-c8a90125e696)
Visit a page that contains big checkboxes or radio buttons, e.g. https://design.canada.ca/common-design-patterns/checkboxes-radio-buttons.html
Use the tab key to navigate through the page

Expected: for checkboxes and radio buttons, you can see which one is focused
Observed: you cannot see which one is focused

This leads to a violation of https://www.w3.org/TR/WCAG21/#focus-visible for any web sites or applications using this feature.

This may be useful? https://sarahmhigley.com/writing/whcm-quick-tips/


[FX-4559] Align labels in forms

FX-4559
Description
This pull request aligns labels to the top of the column according to BASE.
How to test

Temploy
Check visual changes https://happo.io/a/675/p/1189/compare/308d42dbd75e4452727e654178ca370b52e0df58/e0bbcc5e05b6b4aa8bd1fa1ab9877f1eec6da27a

Screenshots

Before.
After.

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[N/A] Annotate all props in component with documentation
[N/A] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers


make program id flexible

Recently the program ID for Scylla switched from 15891 to 16235 so the code needs to be made more flexible to accommodate the two program IDs.
Also, the RA coordinate system ("RA" vs "RA_J2000") is now determined by looking through the column names rather than the whole table.

thanks, Christina! this looks great.


feat: support extraction of MJPEG video frames

This commit adds support for extracting MJPEG files out of
.vraw-files.
The generated files are playable in ffplay, but not VLC. This might
be because MJPEG is not a standardized format and therefore not
documented where it is easily found.
To do something interesting with the extracting MJPEG files it needs
to be converted with for instance ffmpeg.

Hello Voysys! We needed to extract some MJPEG video data from our cameras (which stream in MJPEG), so I thought I'd add some support in vraw_convert. I've added a start here and am happy to change it according to your requests, or just hand it over to you directly if you want to take it and adapt it.
One thing that I looked into, but did not invest enough time in, is to convert the MJPEG video data using ffmpeg crates and then generate some standard-conforming MP4 file. The crates I found seemed to assume a lot of domain knowledge about ffmpeg libraries, which I do not have.


[stdlib] Unable to compile for riscv64-unknown-linux-gnu

Description
The Swift Std library fails to compile for RISCV64, with the error /workspaces/buildroot/output/build/swift-6.0.3/include/swift/ABI/Metadata.h:85:50: error: 'swift_context' parameter can only be used with swiftcall or swiftasynccall calling convention
Reproduction
Compile the Swift Std Library for riscv64-unknown-linux-gnu. I have Buildroot scripts setup to cross compile, but it should be reproducible building on host as well.
Expected behavior
The Swift Std library should compile for RISCV64
Environment
Swift version 6.0.3 (swift-6.0.3-RELEASE)
Target: x86_64-unknown-linux-gnu
Additional information
swift-6.0.3-riscv64-compile.log

@futurejones, are you seeing this too?

This patch applied to LLVM seems to resolve that specific error
0001-clang-Added-Swift-support-for-RISCV64.patch

Now I am getting another error with those patches applied.
cannot guarantee tail call due to mismatched parameter counts
  musttail call swiftcc void @"$ss23withCheckedContinuation9isolation8function_xScA_pSgYi_SSyScCyxs5NeverOGXEtYalF.1"(ptr @"$ss23withCheckedContinuation9isolation8function_xScA_pSgYi_SSyScCyxs5NeverOGXEtYalFTY0_", i64 %39, i64 %40, ptr %1)
<unknown>:0: error: fatal error encountered during compilation; please submit a bug report (https://swift.org/contributing/#reporting-bugs)
<unknown>:0: note: Broken function

riscv64-tail-call-crash.log


Minor bugfix for CountryField in MangopayBankAccount model

Country field has a code property to get country code
Backwards compatibility with older bankaccounts that didnt have a country associated with them

@flaviamissi Ping! :)


Request for Addition of Sign Up Method in Asgardeo React SDK

Is your feature request related to a problem? Please describe.
The Asgardeo React SDK does not offer a specific method to directly navigate the user to a Signup page. As a developer working on the Grama Check Application, the two-week intern project, I encountered this limitation. My intention was to create separate buttons for the Signup and Login functionalities as shown below.

However, the useAuthContext() provided by Asgardeo does not include a separate method for signing up.

I was expecting to create two separate buttons for the purposes of Signup and Login in our Grama Check Application. However, I was unable to do so since the useAuthContext() in Asgardeo does not provide a method for Sign Up.
To work around this limitation, I had to modify the UI by removing the "Sign Up" button and replacing it with a single button that serves both the purposes of signing up and logging in.

Describe the solution you would prefer
I would like to have a dedicated method or functionality within the Asgardeo React SDK that allows developers to navigate the user to the Signup Page directly.
In the existing implementation, the SDK offers a signIn method which redirects the user to the login page. On this page, there is an option available to create a new account. However, it would be more convenient for new users if they could directly navigate to the signup page instead of going through the login page first and then proceeding to the signup page.
This would enable the creation of separate buttons for Signup and Login, enhancing the user experience and providing a more intuitive flow for new users.
Additional context
The absence of a signUp method in useAuthContext() hampers the development process, as it limits the ability to provide a clear distinction between the Signup and Login functionalities. I believe that having separate buttons for these actions is a common practice in user authentication flows, and it would greatly benefit developers utilizing the Asgardeo React SDK.

If your requirement is to just provide a direct link to the signup page, https ://accounts.asgardeo.io/t/<your-org-name>/accountrecoveryendpoint/register.do will do the job, but that wouldn't provide the auto login and some oter capabilities, due to the technical limitations we currently have. Therefore, we haven't exposed a signupmethod through SDK.
However, this is already on our roadmaps and currently being actively worked on. We will update this issue once the feature lands in.


AzureWebJobsStorage in local.settings.json is required... but it's right there...

What can I do to move forward with local development of my azure function?
This worked when I used the VS Code Function Extension, but doesn't work when I use mvn tools to build one from scratch.
Would love to build a service bus triggered function from an IDE other then VS Code. Any thoughts?

We were able to get it working, but we had to very methodical about the process. Here's a nice simple repo for Service Bus to an HTTP endpoint with instructions on how to get developing locally without the VS Code niceties.


Add Finnish address

Adding Finnish address format into contact widget. Hasn't yet been added.
Screenshots

Documentation
To use: go to params.toml in config folder.
Change address_format = "en-us" into address_format = "fi"

Thanks for contributing 😃


[HUDI-5196]spark sql 3.2+ query support

Change Logs
For spark with version greater than 3.2+, the query of hudi table using spark sql supports reading parameter configuration.
Previously, when we used Spark SQL to read the hudi table, we could only read the rt table or the ro table, or use timestamp as of for time travel. However, for incremental data reading, some personalized reading parameter configurations cannot be used.
on this pr, can query hudi table :
// query snapshot table
select id, name, price, ts from $tableName1 ['hoodie.datasource.query.type'=>'snapshot','as.of.instant'=>'$instant1']
// query incremental table
select id, name, price, ts from $tableName1
   |[
   |'hoodie.datasource.query.type'=>'incremental',
   |'hoodie.datasource.read.begin.instanttime'=>'$instant1',
   |'hoodie.datasource.read.end.instanttime'=>'$instant2'
   |]
// query read_optimized table
select id, name, price, ts from $tableName1 ['hoodie.datasource.query.type'=>'read_optimized']
// table union
select id, name, price, ts from $tableName1 ['hoodie.datasource.query.type'=>'snapshot','as.of.instant'=>'$instant1'] where id=1
union
select id, name, price, ts from $tableName2 ['hoodie.datasource.query.type'=>'snapshot','as.of.instant'=>'$instant2'] where id>1

// Insert into static partition
 insert into $tableName2 partition(dt = '2022-02-15')
 select 2 as id, 'a2' as name, price, ts
 from $tableName1 ['hoodie.datasource.query.type'=>'snapshot','as.of.instant'=>'$instant1']

// Insert into dynamic partition
 insert into $tableName2
 select id, name, price, ts, '2022-02-14' as dt
 from $tableName1 ['hoodie.datasource.query.type'=>'snapshot','as.of.instant'=>'$instant1']

Impact
spark sql query.
Modify the spark3.2x .g4 file & ExtendedSqlAstBuilder.
Modify the spark3.3x .g4 file & ExtendedSqlAstBuilder.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[x] CI passed

@hudi-bot run azure

@hudi-bot run azure

@scxwhite
Spark support Table-valued Function: https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-tvf.html.
Maybe Hudi can extend this syntax to implement query of hudi table in different query mode. SQL looks like this:
// query snapshot table
select id, name, price, ts from hudi_tvf("tableName1', "snapshot", "instant1");

// query incremental table
select id, name, price, ts from hudi_tvf("tableName1', "incremental", "instant1", "instant2");

// query read_optimized table
select id, name, price, ts from hudi_tvf("tableName1', "read_optimized");

In it, hudi_tvf is a table-valued function we need to define.

@YannByron @XuQianJin-Stars  query with tvf has been done. https://github.com/apache/hudi/pull/7415。
I plan to close this pr.


[NEW] KeyDB FLASH Support - release date

Support for KeyDB FLASH using the RocksDB engine will become available September 2022
do you still plan to release this month the RocksDB engine  ? thanks

Hi, @JohnSully can we know anything about this? Thanks!

I'm also interested in this I can add leveldb support, rocksdb can act as example. I found some files indicating rocksdb support but since you're planning release of rocksdb support I don't see a reason of implementing it on my own.

We are currently planning on introducing this to the unstable (Main) branch on Friday (Sept 30) where you can view/build/try. We will publish this to the Docker 'unstable' image at that time as well.
We will be planning a larger 6.4 release at a later date which will include the FLASH build in all distributions.

Hi Folks, sorry for the delay, we are waiting on a final validation but hope to have this out in the next few days :) We will keep you posted as soon as soon as its available

I'm really looking forward to this version, which will allow me to save a lot of data on disk instead of in memory

It's much more powerfull to use nvme 2.0 's key value storage interface than RocksDB. Hope there be such a version in future.

As stated in specification nvme key-value storage is implemented in RocksDB compatible library see page 27. I'm willing to do this as I'm in need all I'm waiting is flash storage to be available.

always use nvme 2.0 key-value storage.
It cut down disk io to 1/6, compared with other db according to samsung's early study.
It reduce flash write amplification to 1.0, while redis rdb has a  write  amplification ratio over 1000.
It's fast, typically, it can provide more than 2M+ iops with lowest latency. Some studies shows one nvme key-value disk can relace 50 xeon kernels that running rocksdb, using about 1/100 power and zero system memory.
it never lost data,once data send to disk.
It won't create a db file like rocksdb which always expanding its size, and awkward to shrink size.
It's cheap and easy available when time comes to 2023.

Just a heads up the code is out in the OSS_RELEASE_SEP branch. @benschermel will be prepping the release images.
To avoid a repeat of problems with 6.3 even though this has been deployed successfully with customers in the past we will mark the flash feature as Beta.

By the way integrating with Snap has been a learning experience and I’ve gained a bigger appreciation for the issues on the control plane side. I apologize for how much time this has taken with me away from the project.

@JohnSully @benschermel Great thanks I'll proceed with flash testing and adding nvme support.

@yangkequn @pr4u4t Very interesting this native NVMe K/V. It seems a different issue though, but wow what a potential!

Any news on this?

https://github.com/Snapchat/KeyDB/releases/tag/v6.3.2


Equal sign hidden

On the 4 row setting, it seems to take 3 different presses on different buttons, to make one of the most frequent signs: =
I see tons of lesser used ones on the pop up menu of the period, like & and @
I suggest to make the equals sign accessible in that menu, instead of the & or @ sign.
For programmers specifically, is this highly important.
How can I code without the equals key?

For coding, it doesn't really make sense to use anything else besides the full 5-row layout, which has 1-tap access to almost every standard key.  Try that from HK's settings.

The 4 row layout provides all, other than the equals key.
Why adding clutter, if it can be done simple.

@ShalokShalom The 4-row layout is based on the default Android Gingerbread keyboard. The developer made this keyboard with the intention using the 5-row layout. Which is why the developer didn't modify the 4-row layout.


terraform apply show diff of empty annotations

When running terraform apply, each of the resources without annotations show a diff from an empty annotations to null.
  # kustomization_resource.p1["apps/Deployment/my-namespace/my-deployment"] will be updated in-place
  ~ resource "kustomization_resource" "p1" {
        id       = "f9db08d4-34e8-4693-94a0-d3efd4487ca3"
      ~ manifest = jsonencode(
          ~ {
              ~ metadata   = {
                  - annotations = {} -> null
                    name        = "my-deployment"
                    # (2 unchanged elements hidden)
                }
                # (3 unchanged elements hidden)
            }
        )
    }

Setting commonAnnotations: {} inside kustomization.yml give the same result.
I currently set an annotation to avoid this but I'm wondering if the terrafirn provider should ignore this change?
Thanks!

How does the manifest that generates this diff look like?

I removed other resources to only keep the API:
kustomization.yml
namespace: my-app
commonLabels:
  app.kubernetes.io/part-of: my-app

resources:
  - api.yml

api.yml
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: my-app-api
  namespace: default
  labels:
    app: my-app-api
    app.kubernetes.io/name: my-app-api
    app.kubernetes.io/part-of: my-app
spec:
  replicas: 2
  minReadySeconds: 5
  strategy:
    type: RollingUpdate
  selector:
    matchLabels:
      app: my-app-api
  template:
    metadata:
      labels:
        app: my-app-api
        app.kubernetes.io/name: my-app-api
        app.kubernetes.io/part-of: my-app
      annotations:
        some-annotation: 'content'
    spec:
      serviceAccountName: something
      terminationGracePeriodSeconds: 10
      imagePullSecrets:
        - name: dockerhub
      containers:
      - name: my-app-api
        image: company/my-app/api
        resources:
          requests:
            memory: 500Mi
            cpu: 0.1
          limits:
            memory: 500Mi
            cpu: 0.2
        env:
          - name: ENV
            valueFrom:
              configMapKeyRef:
                name: my-app
                key: env
        ports:
          - containerPort: 8000
            name: http
        livenessProbe:
          httpGet:
            path: /health
            port: http
          timeoutSeconds: 3
        startupProbe:
          httpGet:
            path: /health
            port: http
          timeoutSeconds: 3
          periodSeconds: 5
          failureThreshold: 15
---
apiVersion: v1
kind: Service
metadata:
  name: my-app-api
  namespace: default
  labels:
    app: my-app-api-svc
    app.kubernetes.io/name: my-app-api-svc
    app.kubernetes.io/part-of: my-app
spec:
  selector:
    app: my-app-api
  ports:
    - protocol: TCP
      port: 80
      targetPort: http

I can not reproduce this. Repeatedly applying the resources based on the provided manifests does not show any diffs.


fix: Minor fixes to config

Codecov Report

Merging #11 (f01be34) into main (ce829e8) will decrease coverage by 0.76%.
The diff coverage is 7.40%.

@@             Coverage Diff              @@
##               main      #11      +/-   ##
============================================
- Coverage     50.32%   49.55%   -0.77%
  Complexity      245      245
============================================
  Files            73       73
  Lines          1230     1247      +17
  Branches        100      101       +1
============================================
- Hits            619      618       -1
- Misses          582      598      +16
- Partials         29       31       +2

Impacted Files
Coverage Δ

...acter/server/user/public_user/PublicUserService.kt
6.06% <0.00%> (-0.61%)
:arrow_down:

...n/delta/codecharacter/server/match/MatchService.kt
51.53% <6.25%> (-3.44%)
:arrow_down:

...echaracter/server/config/WebSocketConfiguration.kt
83.33% <50.00%> (-16.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce829e8...f01be34. Read the comment docs.


Clarification for Registration Form Step 64

Describe the Issue
I just discovered that step 64 requires the user to edit both the HTML and CSS. I don't think I have seen this before in the RWD curriculum. Has it always been like this? If not, how long ago did this change occur? I tried to find a PR for it but didn't.
Update: I think this was changed last week with PR #51567.
Regardless, if we intend to keep it this way then I think we need to make it clear in the instructions that both files need to be edited. I've already seen people in the forums trying to add the CSS in the HTML because they didn't realize they needed to open the styles.css editor and add it there.
And to be honest, when I was trying to figure out why they weren't passing this step it took me a good minute to realize that both editors needed to be used, and I didn't believe it at first.
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-html-forms-by-building-a-registration-form/step-64
Your code
N/A
Expected behavior
Possible updated instructions:

Last, but not least, make the input for the terms and condition inline by adding the appropriate class in the HTML. Then change the text color of the terms and conditions link to #dfdfe2 by adding a new selector in the CSS.

This is my attempt at minimal wording but I'm not sure if it is clear enough. I wonder if we might need to add a reference to the editors? Or at least the styles.css editor since only the index.html editor is showing by default.

Last, but not least, make the input for the terms and condition inline by adding the appropriate class in the HTML. Then open the styles.css editor and change the text color of the terms and conditions link to #dfdfe2 by adding a new selector in the CSS.

Screenshots
No response
System
N/A
Additional context
No response

Maybe split it into two steps?

Yeah, I think two steps would be simpler

I'm all on board for splitting this into two steps. I don't know the reasoning for having this step involve two editors. It would be interesting to know why this was done.

I'm starting to see more people get stuck on this step. It is just not clear to them that they need to edit both files. Hopefully we can come to a decision on this soon and open it up for help.

I think splitting this into two steps is acceptable. In general, I do not like doing this when nothing is learnt in one of the lessons, but I think we can count this as a lesson to improve muscle memory.
I was close to wanting the instructions to just be more explicit, but, as this is only the 4th project, let us play it safe.

An issue with the https://github.com/freeCodeCamp/freeCodeCamp/labels/help wanted label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute, and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum
To close, step 64 of the Registration Form project needs to be split into two steps:
64: Input to inline
65: Text colour change

Is this fine what is required in this issue?
Then, I can proceed to create PR request.

Is this fine what is required in this issue?

What is required to close this issue: https://github.com/freeCodeCamp/freeCodeCamp/issues/51944#issuecomment-1770391125

The checkbox was required to be made inline and colour of terms-and-conditions had to be changed.

To close, step 64 of the Registration Form project needs to be split into two steps:
64: Input to inline
65: Text colour change


Support Dry Run & No Github Issues Interaction if repo doesn't use issues

Support Dry Run & No Github Issues Interaction if repo doesn't use issue

Thanks for putting this together! I should have time to review tomorrow morning.

@crs-k Hey! What are the chances this might be approved this week?

@crs-k Hey Chris!
Hope you are doing well!
Take a look, plz.
We all need DRY RUN support)))

@PavelKuprinTDH Please don't nag maintainers.  Someone already asked for an update just a few days earlier.  This is all volunteer effort.

@PavelKuprinTDH Please don't nag maintainers.  Someone already asked for an update just a few days earlier.  This is all volunteer effort.

Calm down. I'm not forcing the maintainer. It was just a polite ask.


Country capital plugin

brief description of changes

Hello @beldcode! Thanks for opening this PR.


can't have a MultiProvider with mvt tiles

I'm on an old Tilestache branch created by the now-defunct Mapzen, and things work fine. It used to be that their branch was the only one that created vector tiles.
When I try to upgrade to the current Tilestache, I can't produce my vector tiles, because MultiProvider doesn't work. I combine tiles to include multiple layers in my tiles.
There are many other functions named getTypeByExtension that do handle mvt as an extension, but for some reason, the one in MultiProvider does not.
If I try to just edit that function to return what I expect it would do, I get an error later on:
AttributeError: MultiProviderWithTileserverParameters instance has no attribute 'ignore_cached_sublayers'
This is the error trace (from the unedited code):

  File "/opt/emp_eng/empower_engine/tilestache/TileServer.py", line 73, in __call__
    response = self.tile_server.__call__(environ, start_response)
  File "/home/ee/.virtualenvs/tiles/local/lib/python2.7/site-packages/TileStache/__init__.py", line 393, in __call__
    status_code, headers, content = requestHandler2(self.config, path_info, query_string, script_name)
  File "/home/ee/.virtualenvs/tiles/local/lib/python2.7/site-packages/TileStache/__init__.py", line 266, in requestHandler2
    status_code, headers, content = layer.getTileResponse(coord, extension)
  File "/home/ee/.virtualenvs/tiles/local/lib/python2.7/site-packages/TileStache/Core.py", line 375, in getTileResponse
    mimetype, format = self.getTypeByExtension(extension)
  File "/home/ee/.virtualenvs/tiles/local/lib/python2.7/site-packages/TileStache/Core.py", line 634, in getTypeByExtension
    return self.provider.getTypeByExtension(extension)
  File "/home/ee/.virtualenvs/tiles/local/lib/python2.7/site-packages/TileStache/Goodies/VecTiles/server.py", line 261, in getTypeByExtension
    raise ValueError(extension)
ValueError: mvt

Thanks for reporting this. Would you be able to provide a pointer to the branch code that you're running? I’m curious about ignore_cached_sublayers but not sure where that’s coming from.

The lines from my requirements.txt file are:
-e git://github.com/mapzen/TileStache.git@9f867b7d6c8cec3c8e5aa3571e65bfea22cf019f#egg=TileStache-integration-1
-e git+https://github.com/mapzen/tilestache-providers.git@b1b76c71f498bfb56be50633e316eae56089ffc4#egg=tilestache_providers-master

TileStache-integration-1 was a branch that Mapzen assured me a few years back that they kept up to date. Obviously they went out of business a year ago, so it's even more important to get back on the standard system.

@migurski Is this something that's likely to be fixed soon? Or is there anything you need beyond the lines from my requirements code?
The ignore_cached_sublayers error is what I saw when I tried to use the master branch instead of the Mapzen branch.
I need both points and shapes in my tiles, so I make two tiles and glue them together using the MultiProvider. But that doesn't work for MVT tiles in the master branch. If there's a different way to glue them together, I'm happy to change to that.
Thanks!

@JulieGoldberg thanks for providing that additional detail! I will try to give this a deeper look during the week. I am unlikely to attempt to merge the Mapzen changes back to TileStache because so many of them are specific to Mapzen’s internal needs. I need to determine where ignore_cached_sublayers is being used and what it’s for to give you a better answer, but I do agree that supporting vector tiles is valuable.

@migurski  Thanks in advance. I totally see why you'd use their code as a reference, not just merge it in. I look forward to hearing more later in the week.
FWIW, I am the one that opened the issue. I just accidentally did so on our generic company account instead of my own and don't see how to swap it over.

@migurski Did you have a chance to look at this last week? If so, any update on the timeframe for a fix?

Hi Julie, not yet!

It does seem like the changes in question are just in the TileStache.Goodies.VecTiles package. TileStache has a well-defined way of pulling in external packages, so one approach you might take would be to isolate the VecTiles portion of the Mapzen fork and import it as a 3rd-party provider using the Module:Class syntax described in the docs.

That did actually work. I had to copy in some of their code, adjust paths, etc, but that was it. I'll email you the pieces of their Goodies:VecTiles that I needed to pull out in the hopes that you can integrate it into the main Tilestache down the road. But in the mean time, I can use this workaround. Thanks


Paper details page should list the authors

Scenario
Given a paper with an author
When a user visits the paper's show page
Then it should show the author's full name
Error

Expected to find text "alan turing" in "title: computing machinery and intelligence\nvenue: mind 49: 433-460\nyear: 1950\nedit | back"

39 exercise tests have passed. There are 44 in total. You will solve multiple at once towards the end.

Sorry, it's not working for me yet:
Scenario
Given a paper with an author
When a user visits the paper's show page
Then it should show the author's full name
Error

Expected to find text "alan turing" in "title: computing machinery and intelligence\nvenue: mind 49: 433-460\nyear: 1950\nauthor(s): #author::activerecord_associations_collectionproxy:0x0000555edd1706d8\nedit | back"

If you have problems solving this task, please don't hesitate to contact the teaching team!

Sorry, it's not working for me yet:
Scenario
Given a paper with an author
When a user visits the paper's show page
Then it should show the author's full name
Error

Expected to find text "alan turing" in "title: computing machinery and intelligence\nvenue: mind 49: 433-460\nyear: 1950\nauthor(s):\nauthor.name [#<author id: 2, first_name: "alan", last_name: "turing", homepage: "http://wikipedia.de/alan_turing\", created_at: "2021-11-15 22:19:10", updated_at: "2021-11-15 22:19:10">]\nedit | back"

If you have problems solving this task, please don't hesitate to contact the teaching team!


Remove uglify-es/uglify-js, use terser

It looks like uglify-es has been deprecated on NPM. Further, terser seems to a more common tool used for compressing JS assets, so we should replace uglify-js with it.
Hopefully this may also resolve issues seen with newer syntax such as top-level await (https://github.com/cdnjs/packages/runs/5103276658?check_suite_focus=true), and issues with bad compression of libraries (https://github.com/cdnjs/packages/issues/1363).

There are other examples of bad compression with uglify-js resulting in broken libraries: see, e.g. https://github.com/firebase/firebase-js-sdk/issues/5962#issuecomment-1035597821


feat(tier4_autoware_utils): add twist library

Description
Add twist library functions for tier4_autoware_util.
These functions will be used for radar sensing package and radar fusion perception package.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

There are too many change files, is that correct?

When I fixed at DCO, I miss the operation.
So I close this PR


React & Redux Group Project

Here is the summary of what I and my partner @lugard1 did in this group project,

[x] Fetched data from the API

[x] Use React props, React Router, Hooks, map & filter method

[x] Connect React and Redux

[x] Use store, actions, and reducers in React

[x] Apply React best practices and language style guides.

[x] Perform code reviews for my team member and vice-versa

[x] Write unit tests with React Testing Library for components and functions

[x] Write a Professional ReadMe file

[x] Use Linter for error check

[x] Follow Gitflow

Hi @eric2umeh, @lugard1 😊,
While you made a great effort in this project, I cannot proceed to review your code.
Invalid Code Review Request 🛑 💀
You have submitted a project, that has incorrect gitflow, you suppose to open a pull request from the dev branch into the main branch and include all the changes.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Suggestion: Integrate with Ageing Pages report

Wagtail now comes with an "Aging pages" report (/admin/reports/aging-pages/), which feels like it would benefit from integration from this package - i.e. perhaps wagtail-periodic-review could add a filter or label/badge to the report list view to identify pages needing review?

We'd need to basically override the Aging pages report. I am not entirely sold on it (yet) due to needing to keep up with any changes to it (all potential, of course)

Having thought more about this, we either:
a. replace the "Aging pages" report
b. do nothing.
Ultimately they serve different purposes, so I say we do nothing. Thank you for the suggestion, though


[BUGS]Cannot register replacer, PlaceholderAPI error and reload error

When plugin starts, have this error
http://hastebin.com/kaqituloki.txt
When i reload it:
http://hastebin.com/ojunuhudaz.txt
And PlaceHolderAPI not working for me

What's your SimpleClans version?

Legacy, i will try update simpleclans


chore: fix docs build

Description:
For some reason, remark-html with version 13 doesn't generate code examples and some guide files correctly. I tried increasing remark version to 12, 13 and 15, but it didn't work for multiple reasons, so I had to lower the remark-html from version 13 to version 12.
For example, this is how a code example looked like (without fix from this PR):

And this is the blank page from /api route:

This PR fixes these issues.
Related issue (if exists):
None

I managed to upgrade remark version to v12 and to keep remark-html at v13. To do this, I had to copy some stuff from Angular.
Related: angular/angular#24000 and angular/angular#41721


Make static rendered routes servable and provide context to static_params

This removes the .static from file names for static routes. Some cleanup methods no longer made any sense and were removed, too. With this change, the build output from static routes can be served as a static website without any file renaming (see discussion in #1594).
Additional context is provided for the static_params closures.

These changes work fine using only static routes and StaticMode::Upfront. I have not tested them with Incremental yet!


#217: Add support for html special chars in titles

https://github.com/DivanteLtd/vue-storefront/issues/217

Yes would be better, I though we can trust the service

from https://lodash.com/docs/4.17.4#unescape:

this method converts the HTML entities &, <, >, ", and ' in string to their corresponding characters. No other HTML entities are unescaped.

this might not be enough imo
they say this (https://github.com/mathiasbynens/he) should be what we want


Temporarily handle failure for emptyDrops

Closes #90. This PR temporarily handles failures in either emptyDrops or emptyDropsCellRanger by implementing a hard cutoff for filtering. I am setting a default value for the hard cutoff at a total UMI count of greater than 100. I think this is fairly reasonable, but let me know if others have differing opinions.
In doing this, I added a parameter for the umi_cutoff to the filter_counts function which is only invoked in the event of a failure of one of the DropletUtils methods. I also added to the metadata of the SCE, the filtering type being used as either emptyDrops, emptyDropsCellRanger, or UMI cutoff. I also added the umi_cutoff that was used to the metadata (e.g. 100 as default), in the case of that being the method used.
For the QC report, I added in a line in the Cell Statistics table that has the filtering method that was used. In doing this, I chose to change the line in the Pre processing information that previously had Filtering method to be Alevin fry droplet detection. This refers to using the unfiltered permit list or using a knee method. I was unsure on this name but thought filtering method didn't fit with how we describe it in the docs, since we talk about filtering more in the context of emptyDrops.
I also added a warning statement below that table that if the filtering method is UMI cutoff to let the user know that there may be a low number of droplets. Are we okay with this? or would we prefer a different warning message or no message at all?
Finally, I adjusted the test functions slightly to test the different types of filtering we can do in filter_counts and in order to get the test for generating the QC report to pass, I needed to actually perform filtering using filter_counts as that adds in the metadata that we now need to access to add into the QC report.
Next Steps:
In response to these changes we will also need to update the documentation and incorporate the filtering type to the metadata.json file that is produced as part of scpca-nf. If we are okay with this approach then I will go ahead and file those issues.
I can imagine that we will want to further tweak this, but I think this general approach will solve the problem of failing because of filtering until we can explore this issue further.
I've included an example of what the new QC report looks like for a sample that is unable to pass filtering and would have to be filtered with a hard cutoff.
SCPCL000018_qc_report.html.zip

Thanks for taking a look at this and for the refactoring help @jashapiro. I went ahead and incorporated those changes here. I had struggled trying to find a less repetitive way of doing this, so I like this a lot better and I really like the warning statement changes too!


securityinsights-track2-release

release for issue: https://github.com/Azure/sdk-release-request/issues/2794

@praveenkuttappan  why this PR only changes mgmt plane file but it requests review from @bterlson @xirzec and @jeremymeng


AzureResourceManagerTemplateDeployment fails authentication using a Bicep module registry.

Task name: AzureResourceManagerTemplateDeploymentV3
Description: Fixing ARM task
Documentation changes required: (Y/N) N
Added unit tests: (Y/N)
Attached related issue: (Y/N) https://mseng.visualstudio.com/DefaultCollection/AzureDevOps/_workitems/edit/2042790
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run


feat(ios): support for databases that are not visible to iTunes and are not backed up by iCloud

Is your feature request related to a problem? Please describe.
The iOS databases are currently stored in the documentDirectory, which is visible to iTunes and backed up to iCloud.
Describe the solution you'd like
I would like to be able to specify that the database is stored in a location that is not visible to iTunes and not backed up to iCloud.
As far as I know, the libraryDirectory is not visible to iTunes. For this reason I suggest to save the databases under the following path: Library/LocalDatabase.
To prevent the database from being backed up by iCloud, it is necessary to set NSURLIsExcludedFromBackupKey for the folder, i.e. LocalDatabase, to true (example: https://stackoverflow.com/a/32807331/6731412).
This could be implemented via the plugin configuration to avoid breaking changes.
An example implementation can be found here: https://github.com/robingenz/capacitor-badge#configuration and https://github.com/robingenz/capacitor-badge/blob/b2a4256c77a4cac251104478d007757ef8de21e4/ios/Plugin/BadgePlugin.swift#L114
Config Interface Example capacitor.config.json:
{
  "plugins": {
    "Sqlite": {
      "iosDatabaseLocation": "Library/LocalDatabase"
    }
  }
}

I'm ready to help with the implementation.

@robingenz thanks for making the PR. I think the capacitor databases should be stored in a different folder than others cordova plugins are storing their databases. I will suggest Library/CapacitorDatabase i will have a look at your suggestion for the capacitor.config.json. i wish you an Happy New Year

@jepiqueau Thanks for your quick reply! Please let me know as soon as I can help. I wish you a happy new year too! Keep up the great work!

@chriswep Hi Chris i wish you first an Happy New Year.  Can you comment this request and agree on it and tell me the impact on the typeOrm driver

@robingenz it will come soon. I have still to update the doc and to look at some others issues before to publish a  new release

@robingenz this is fixed in 3.3.3-2 this has been tested in [react-sqlite-app-starter](https://github.com/jepiqueau/react-sqlite-app-starter)

@jepiqueau Thank you very much! I'll test it and let you know.

@jepiqueau I am currently encountering a strange problem with version 3.3.3-3.
I get the following error message when running the db migration:
2022-01-03 19:02:02.468814+0100 ENGINE4[987:77715] open on /var/mobile/Containers/Data/Application/768E7DC9-3B74-4382-99EB-3E80BFB58100/Library/CapacitorDatabase/mfapp.globalSQLite.db: No such file or directory
Error: Error Domain=NSCocoaErrorDomain Code=4 "Die Datei „mfapp.global“ existiert nicht." UserInfo={NSSourceFilePathErrorKey=/var/mobile/Containers/Data/Application/768E7DC9-3B74-4382-99EB-3E80BFB58100/Library/LocalDatabase/mfapp.global, NSUserStringVariant=(
    Copy
), NSDestinationFilePath=/var/mobile/Containers/Data/Application/768E7DC9-3B74-4382-99EB-3E80BFB58100/Library/CapacitorDatabase/mfapp.globalSQLite.db, NSFilePath=/var/mobile/Containers/Data/Application/768E7DC9-3B74-4382-99EB-3E80BFB58100/Library/LocalDatabase/mfapp.global, NSUnderlyingError=0x283660f00 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Error: copyFile Failed

My code:
private async migrateCordovaSqliteDb(): Promise<void> {
    const folderPath = 'Library/LocalDatabase';
    const result = await this.sqlite.getMigratableDbList(folderPath);
    const dbNames = (result.values || []).filter(
        (value: string) => !!value && value.includes('mfapp.'),
    );
    if (dbNames.length < 1) {
        return;
    }
    await this.sqlite.addSQLiteSuffix(folderPath, dbNames);
    await this.sqlite.deleteOldDatabases(folderPath, dbNames);
}

"CapacitorSQLite": {
    "iosDatabaseLocation": "Library/CapacitorDatabase"
}

I am currently still debugging and trying to find the reason.
The following file exists: Library/LocalDatabase/mfapp.global
I checked this before by downloading the app container in XCode.
It seems that the problem only occurs when the file CapacitorDatabase/mfapp.globalSQLite.db does NOT exist.
If I skip the migration first and create the CapacitorSQLite database via createConnection and execute the migration only afterwards, then it works.
Do you have any idea what could be the reason for this?

@robingenz Yes the point in the database name is not supported mfapp.global

Okay, but it worked in the previous version. I have been using the migration with this names for a few weeks now.
So there was a breaking change in a minor version? Was that intentional?

@robingenz OK i will have to look back on this. No it was not intentional. I had to make so many changes and this was not part of m'y tests

@robingenz in the Library/LocalDatabase the database mfapp.global has not .db as extension?

@robingenz if the mfapp.global does not have the extension .db, the .global is taken as the extension  and the not copied

@robingenz forget all what i said above i tested it and it works fine
i add two databases in the Library/LocalDatabase
mfapp.global , mfapp.test.db
one without the db extension and one with the db extension
        const testMigrateIssue = async(): Promise<Boolean>  => {
            setLog((log) => log.concat("* Starting testMigrateIssue *\n"));

            try {
                const folderPath = 'Library/LocalDatabase';
                const result = await sqlite.getMigratableDbList(folderPath);
                const dbNames = (result.values || []).filter(
                    (value: string) => !!value && value.includes('mfapp.'),
                );
                if (dbNames.length < 1) {
                    errMess.current = `NO "mfapp. " database`;
                    return false;
                }
                console.log(`dbNames: ${JSON.stringify(dbNames)}`)
                await sqlite.addSQLiteSuffix(folderPath, dbNames);
                const listDB = await sqlite.getDatabaseList();
                console.log(`listDB: ${JSON.stringify(listDB)}`)
//                await sqlite.deleteOldDatabases(folderPath, dbNames);

                return true;
            } catch (err: any) {
                errMess.current = `${err.message}`;
                return false;
            }

and the output
  To Native ->  CapacitorSQLite addSQLiteSuffix 9265317
⚡  [log] - dbNames: ["mfapp.global","mfapp.test.db"]
⚡  TO JS undefined
⚡  To Native ->  CapacitorSQLite getDatabaseList 9265318
⚡  TO JS {"values":["testListenersSQLite.db","myDBSQLite.db","db_issue9SQLite.db","testfromfileSQLite.db","mfapp.testSQLite.db","mfapp.globalSQLite.db","NoEncryptionSQLite.db","test-updversionSQLite.db","testSetSQLite.db","stewardSQLite.db","testcopySQLite.db","tes
⚡  [log] - listDB: {"values":["testListenersSQLite.db","myDBSQLite.db","db_issue9SQLite.db","testfromfileSQLite.db","mfapp.testSQLite.db","mfapp.globalSQLite.db","NoEncryptionSQLite.db","test-updversionSQLite.db","testSetSQLite.db","stewardSQLite.db","testcopySQLite.db","testNewSQLite.db","testListenersImportedSQLite.db","dbForCopySQLite.db"]}

@robingenz in the Library/LocalDatabase the database mfapp.global has not .db as extension?

Yes

@robingenz for me it is working as shown above

@robingenz is it working for you ? if yes can you close the issue

Unfortunately, I didn't have time yesterday. I will test it again today and let you know.
Thanks for your help!

@robingenz i will be travelling today so nt accessible. I wish you good luck

@jepiqueau I have found the problem: In my case, the CapacitorDatabase folder was not yet created at the time of migration.
The reason for this is that class func copyFile(pathName: String, toPathName: String, overwrite: Bool) throws -> Bool is called which, unlike class func copyFile(fileName: String, toFileName: String, databaseLocation: String) throws -> Bool, does not call the getFilePath/createDirCopyDB method which creates the folder.
This also fits with my description of the problem, that it works after restarting the app with an empty database.
I added the following code locally to test my assumption:
Update init method in CapacitorSQLite:
init(config: SqliteConfig) {
    self.config = config
    if let iosLocation = config.iosDatabaseLocation {
        self.databaseLocation = iosLocation
+        UtilsFile.tryCreateIosDatabaseLocation(location: iosLocation)
    } else {
        self.databaseLocation = "Documents"
    }
    super.init()
}

Added tryCreateIosDatabaseLocation method to UtilsFile:
class func tryCreateIosDatabaseLocation(location: String) {
    do {
        var dirUrl: URL = try UtilsFile
            .getFolderURL(folderPath: location)
        let dirPath: String = dirUrl.path
        if !UtilsFile.isDirExist(dirPath: dirPath) {
            // create the directory
            try FileManager.default
                .createDirectory(at: dirUrl, withIntermediateDirectories: true)
            // exclude the directory from iCloud Backup
            try UtilsFile.setExcludeFromiCloudBackup(&dirUrl,
                                                     isExcluded: true)
        }
    } catch let error {
        var msg: String = "tryCreateIosDatabaseLocation command failed :"
        msg.append(" \(error.localizedDescription)")
        print(msg)
    }
}

With this code change it works again.
Unfortunately this is not a fix yet, as then the createDirCopyDB method does not work anymore, as the folder always exists (as it is created directly at startup).

@robingenz that is strange as for me it works does not matter if the directory exists or not

@jepiqueau As far as I know, in order to use FileManager.copyItem you have to make sure that the directories exist.
So as a fix I would suggest that before copying the database you always check if the folder exists and if not you create it.
Is the moveAllDBSQLite method really needed? After all there are already methods for migration (getMigratableList, addSQLiteSuffix).
Then you could create the folder like in my example directly at the start of the app and avoid such problems from the beginning.

@robingenz OK i will have a look

@robingenz You are right, i did not see it in my test app as i create a database earlier in the index.tsx file. So when i tested the addSQLiteSuffix the Library/CapacitorDatabase was created. So i will fix it. Thanks for your patience and temerity

Great!
Thank you very much for your efforts.

@robingenz fix in 3.3.3-5

@jepiqueau Thank you!


nix-prefetch-git: print commit date

The commit date can be used as a version number in packages that don't
have proper releases.

nix-prefetch-git prints some messages to stdout and some to stderr. I don't see the pattern (not only error messages are printed to stderr), so I've added this new printout to stdout.
Should fix half of https://github.com/NixOS/nixpkgs/issues/6479.

Thank you!
Merging?

Seems good to me. Runs nice. Pushed to 14.12 as well.


Improve Meetings GUI

Changes:

Remove border line of meeting list
Make the style of selected item the same as Contacts
Apply light theme to StatusBar

The link becomes white when the meeting is selected. Does anyone know how to change the color of links?

Codecov Report

Merging #237 (3fac87b) into master (be4780b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #237   +/-   ##
=========================================
  Coverage     53.35%   53.35%
  Complexity      746      746
=========================================
  Files           133      133
  Lines          2999     2999
  Branches        407      407
=========================================
  Hits           1600     1600
  Misses         1266     1266
  Partials        133      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4780b...3fac87b. Read the comment docs.


[Feature Request] Add option to isolate uncommited branch changes per user

Hello!
Currently lakefs has a feature called "uncommited changes" for branch. But two (or more) users can upload and change files in this area. I propose a feature that will allow different users to have separate "uncommited changes" spaces with following requirements:

Feature has a toggle to keep it compatible
Each user will have his own private uncommited changes area for each branch that he is working
Other users won't be able to access private user uncommited changes (unless they are admins?)
Uncommited changes will be removed upon branch deletion

I see this feature as a kind of git philosophy -> when using ordinary git a user is feeling safe with his changes unless he explicitly pushes them to remote. For now in lakefs two users may collide in shared branch "uncommited changes" which may be inconvenient.

Thanks @StoneToken for the suggestion. lakeFS resemblance to git is what makes it UX so intuitive IMO. There are some capabilities that make less sense for object store versioning, like having a local copy.
In your opinion, what does separate staging area for the same branch allow the user to do, that creating another branch, working on it in isolation and deleting/merging don't?

Technically you are right - one can accomplish the same goal by means of branches. My story is that when we started playing around with lakefs for our project we stumbled that users first believed that when they pushed their data to branch uncommited changes area they believed that area was private to them, and it was a kind of surprise that it was not. Perhaps this expectation was derived from working on local git repo, but anyway - it feels safe to work with data if you know that your changes won't affect anyone unless commited \ pushed to branch.

Hi @StoneToken ,
tl;dr: lakectl local might be a good fit for your needs.
Thanks for opening this issue!  I believe that it goes to the heart of what lakeFS is, so it is not easy in any direction.  Here is my opinion, which perhaps expands on @itaiad200 .
lakeFS needs to be a cross between Git -- for versioning semantics -- and an object store -- for storing objects.  So it supports versions like Git does, and it supports objects access like S3 does.
But both Git and S3 are more than just versioning and object storage.  Git is also a tool for distributed software development.  A Git repository can push changes to other repositories and pull changes from them.[^1]  Users never interact with a shared repository, every user has their own clone.  One side-effect of working on a clone is that it is typically private.
[^1]: The popular workflow uses GitHub as the upstream, and all repositories only go there.
lakeFS cannot go there: ease of use as an object store means some centralization, because data tools such as Spark live on the network.  There is also the matter of the size of data.
One way of re-introducing Git-like local capabilities is provided by lakeFS local checkouts.  lakectl local creates a local copy of a repository commit; you can edit it locally and privately, and upload it back to the repository on demand.
On the server, we intend lakeFS branches to be used for isolation.  As you rightly point out, lakeFS does not support per-branch visibility.  We have no good semantics for this, even adding per-branch ACLs yields surprising results as soon as you add merging.

Hi, @arielshaqed ! Thanks for feedback, I revised my issue and I think that your proposed way suits better for our needs.

Hi, @arielshaqed ! Thanks for feedback, I revised my issue and I think that your proposed way suits better for our needs.

Cool!  It's always a fine line between solving as many use-cases as possible and not making things too complicated.  I'm glad if in this case we managed both.


Removed exec permissions from Dockerfile.windows

Very simple change: Dockerfile.windows is with exec permission, which, since it is a Dockerfile, is probably not needed.
tl;dr: I just chmod -x Dockerfile.windows 🍺

LGTM

LGTM


Controlling generation of CancellationToken in interface

Added CancellationTokenParameterOption with has 3 vaild value:

Both.
This is the default option and has same behavior as before. Generate both method in interface. If GenerateOptionalParameters, generate single method with CancellationToken being optional.
Yes.
Generate the overload with CancellationToken only.
No.
Generate the overload without CancellationToken only. This option force it to generate a implementation method without CancellationToken in class.

Hello Rico,
Did you already find the time to review the PR?  I need this feature too.

It makes sense to add this option, but i dont like the yes/no/both enum - but i dont know yet a better solution/api. Any idea?

The other way is divide this into two bool argument but one combination don't make sense, so I still prefer the Y/N/B enum. Actually it's a nullable bool? before but I found that will reduce readability so I extracted an 3-option enum.

A boolean is sufficient for me; Either ignore the cancellation token or not. I can't see a use case to render the function twice once with and once without cancellationToken.

I can't see a use case to render the function twice once with and once without cancellationToken.

Isnt this the current behavior? Or is it with ct and with default value?

Otherwise I’d probably agree that a setting like GenerateCancellationTokens would be fine - but need to check the scenarios first

Could this also be added to the CSharp Client?

I see this hasn't been looked at in quite a while and has conflicts with the main branch now...  Was looking for a way to remove the "no CancellationToken" methods from generated clients and this would do the trick.  Any chance the merge conflicts could be fixed and this feature merged in?

I think instead of adding more configs, we should just add the cancellation tokens with default value (CancellationToken cancellationToken = default(CancellationToken)) in the templates and all is fine, no?

Thinking about it more, even with a mandatory CancellationToken parameter developers could still just pass CancellationToken.None into methods anyway.  Seems like code reviews are the only way to force a "don't use CancellationToken.None convention.

I think instead of adding more configs, we should just add the cancellation tokens with default value (CancellationToken cancellationToken = default(CancellationToken)) in the templates and all is fine, no?

This is sufficient.

You can generate both (with and without ct) so this can be closed.


Add account cleanup

• Minor tweaks to the iCloud icon
• Consistent footers on add account sheet
• Consistent alignment
• Old functionality removed when the accounts tableview has no selection

I can’t wait for the new iCloud Sync between devices in this new app version!
After the release, it will be the moment when I get rid of Feedly sync!


Helm Repo: https://woodpecker-ci.org/index.yaml : 404 Not Found

Component
other
Describe the bug
When trying to add the Helm repo as described in the docs, it doesn't work:
$ helm repo add woodpecker https://woodpecker-ci.org/
Error: looks like "https://woodpecker-ci.org/" is not a valid chart repository or cannot be reached: failed to fetch https://woodpecker-ci.org/index.yaml : 404 Not Found

System Info
Helm: version.BuildInfo{Version:"v3.5.4", GitCommit:"1b5edb69df3d3a08df77c9902dc17af864ff05d1", GitTreeState:"clean", GoVersion:"go1.15.11"}

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server.

We havent't releases a version based on the refactored code of the current master yet, but the documentation for this next version is already online. For now you have to use the helm-chart from the repo directly and wait for the 0.15.0 version to be releases to use the hosted chart. Sorry for the inconvenience which came from those huge refactorings.

v0.15.0-rc1 got released manually based on #715 so it should work now & is automated for future tagging events


FedEx meter value

Where in the setup for FedEx credentials is the meter number used?
I get
response = fedex.find_rates(origin, destination, packages)
ActiveShipping::ResponseError: ERROR - 803: Meter number is missing or invalid.

I had the same problem but looking in the code I see that 'login' in the fedex module is actually your meter number. Of course, for some reason I am getting the '1000 failed authentication error' back...so maybe I have the other values wrong!

It worked for me with the login and meter number. I did the same thing, reviewed the code and found that generated the right call.

@philsmy thanks for clearing that out!
"FEDEX LOGIN:" is actually FEDEX METER:


New branch for english corpus

Hey, I've been using your library for dataset generation for my ocr project.
I think it would be useful to have a branch dedicated to English, also adding an English corpus file in the data directory.
While using your code I have added some features like random subset selection(from a sentence selected to be the text), which can be useful while training in applications where not all sentences are of fixed length.
Do you suggest I make a Pull Request containing these features?

Hey, I've been using your library for dataset generation for my ocr project. I think it would be useful to have a branch dedicated to English, also adding an English corpus file in the data directory. While using your code I have added some features like random subset selection(from a sentence selected to be the text), which can be useful while training in applications where not all sentences are of fixed length.
Do you suggest I make a Pull Request containing these features?

May I ask you to send your English version to my mailbox? I want to use it for study, not for commercial use.Thank you!
My Email<EMAIL_ADDRESS>


Add user agent header to luis calls

ref: https://github.com/Microsoft/BotBuilder-V3/issues/58

@EricDahlvang hold on this one, we are not going to use the slashes. As you say we want to stay inside the rules and we want to use the built-in support... there is no need to hack this... you should be 😃
@vishwacsena just wants to be sure all the data can be gathered unambiguously.
I'll update this with details.

@johnataylor
Sounds good.  Closing this PR.
For consistency, we will need to go back through some of these others that have been completed, and update to whatever format you determine.
ref: https://github.com/Microsoft/BotFramework-Emulator/pull/1092


Note on Supported Generations

Hi,
Can you note the version of Azure SQL Database where support for AAD started?  E.g. "All versions past version 11 support AAD?"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 55747c48-5caa-3234-f978-a667aed13352
Version Independent ID: c18a4db6-71e3-a539-1e7f-2f49662f4bbc
Content: Azure Active Directory authentication - Azure SQL Database
Content Source: articles/azure-sql/database/authentication-aad-overview.md
Service: sql-db-mi
Sub-service: security
GitHub Login: @GithubMirek
Microsoft Alias: mireks

@PrometheusRising1 Thank you for the feedback. We are actively investigating and will get back to you soon.

@PrometheusRising1 This is being assigned to the content author to evaluate and update as appropriate

We do not provide dates for when a feature is supported in our docs.
#please-close


'click()' method uses different visibility test from '.visible' property?

Test Scenario
I have a navigation menu which dynamically pops out from the left of the page.
On the menu elements, the .visible property passes ok(), but the click method on the same element complains "the element that matches the specified selector is not visible".
The element is visible (to me!), but the left of its container element is set to a negative value, which may be confusing the visibility test?
Web application
Website URL: https://www.movable-type.co.uk/test/testcafe-menu/test.html
Test result:

Complete test files
test.html:
<!doctype html>

    <meta charset="utf-8">
    <title>TestCafé Menu Test</title>

TestCafé Menu Test

            My 1st 1

            My 2nd 2

test.js:
import { Selector } from 'testcafe';

fixture('TestCafé menu bump test')
    .page('https://www.movable-type.co.uk/test/testcafe-menu/test.html');

test('test', async t => {
    await t
        .expect(Selector("#menu1").visible).ok() // <- passes
        .click(Selector('#menu1'));              // <- fails with "not visible"
});

Environment details

testcafe version:                   1.3.2
node.js version:                    v12.4.0
command-line arguments:  testcafe chrome test.js
browser name and version: Chrome 77.0.3833
platform and version:         Linux Mint 18 / Ubuntu 16.04

Thank you for the simple example. I've reproduced this behavior. We need some time to research this issue and will inform you about our progress as soon as we have any.

I've simplified the example: it has nothing to do with the container element having a negative left.
I've removed the left on the left-nav container, and made .menu-left (#menu1 / #menu2) width: 350px, left: -290px, with .menu-left:hover setting left: -155px.
The test behaviour is still the same, so it must just be the fact that the target element is only partially visible (with -ve left)?

test.html
<!doctype html>

    <meta charset="utf-8">
    <title>TestCafé Menu Test</title>

TestCafé Menu Test

            My 1st 1

            My 2nd 2

@chrisveness
Thank you for your cooperation. You are right, the Selector(...).visible command just checks that the element exists in the document and does not contain the display: none or the visibility: hidden rules. The click method is more complex. It tries to calculate the middle of the element (by default) to click on it. The middle of the element is hidden, and this is confusing the test.
While the issue exists, I recommend using the following workaround:
await t.click(Selector('#menu1'), { offsetX: -5 });

Here I am using the offsetX option to help the test to click an element on the visible part.

Thank you! That's sufficient work-around to enable me to progress.
Would it be difficult to make the visibility test that any part of the element is visible? The centre seems somewhat arbitrary... Anyway, I'll leave that with you, I can now move on, thx.

You can check if the element is fully visible by using your own custom code. To create it, use TestCafe's ClientFunctions mechanism.
You can implement your own ClientFunction and add your custom logic to it. Use the How to test if an element is in the viewport with vanilla JavaScript article as a basis.

Thanks for that – for the moment, the offsetX trick is sufficient, but I'll bear that in mind.

Running into the same issue I believe.
The element is visible to me, and in the chrome dev console, when running $('elementSelector).checkVisibility(); the response is true - but when trying to do a click event on the element in testcafe, I get the following error: {elementSelector} is invisible. The value of its 'visibility' property is 'hidden'.

Please use this template to create a separate ticket and share a Minimal Working Example in that ticket so that the TestCafe team can research the issue and help you.


Enforce triple equals in eslint

Coverage decreased (-11.2%) to 70.27% when pulling 0f87e2d8e5c07f628fbdc3e8146c5e5673d9df64 on eqeqeq into e705bb56cf6723e77e8eb6b39d8f7a4141c40685 on dev.


When Saving Moderator Settings Fields Required Even if Not Moderator

You are prevented from saving Moderator settings if you don't fill out the fields even if moderation is set to Off. It should only validate and require the moderator fields if you are choosing to be a moderator.

We could do what we do for SMTP settings where, when moderation is set to Off, we only validate fields that you enter a value in for. That way you can't save bad data, but if you omit a field, we don't force you to enter a value.