Newbie doubt about plugin usage.

Hi friends. How are you? I hope you are fine.
First, sorry about my English, it doesn't perfect :).
So I've started to use this project at work, and this is the most easy to use I've ever seen until now. But today I've met a problem during my code sessions. I have a project based on YEOMAN generator and I'm a beginner guy in MEAN world. Well, I have a Angular Module, and I'm passing the angular-chartist as follows:
'use strict';

import angular from 'angular';
import uiRouter from 'angular-ui-router';
import config from './dashboard.config';
import angularChartistModule from 'angular-chartist.js';
import DashboardController from './dashboard.controller';

export default angular.module('myDashboard', [uiRouter, angularChartistModule])
  .controller('DashboardController', DashboardController)
  .config(config)
  .name;

At My dashboard.controller I have a function to create data and config for my chart:
limitChartBuilder() {
    this.limitChartData = {
      // A labels array that can contain any sort of values
      labels: ['Usado %', 'total %'],
      // Our series array that contains series objects or in this case series data arrays
      series: [60, 40]
    };

    this.limitChartOptions = {
          donut: true,
          donutWidth: 60,
          startAngle: 270,
          total: 200,
          showLabel: true,
          plugins: [
            //How can I put plugin here?
          ]
    };

And the question is How can I put a Legend plugin there in plugins array: I try to put as mentioned in Chartist documentation, but I've got  an error: "angular.js:14195ReferenceError: Chartist is not defined
at DashboardController.limitChartBuilder "
Mybe I'm forgetting some kind of injection or import.
In my HTML is everything ok with directive if I didn't inform plugin session in controller:

Utilização Geral do Limite

        <chartist
          class="ct-text-size"
          chartist-chart-options="vm.limitChartOptions"
          chartist-data="vm.limitChartData"
          chartist-chart-type="Pie"/></chartist>

Thank you in advance for the help

Chartist is a peerDependency of this project, so you need to install it explicitly:
npm install chartist --save
Let me know if that fixes the problem for you.

Thanks paradox41, I've installed chartist after install angular-chartist and in my controller I've just imported the resources:
import Chartist from 'chartist';
require('chartist-plugin-legend');
And it works gracefully
Thanks.

Great!
FWIW, you shouldn't need to import Chartist into your code (unless some plugin needs it / you need it). My library just expects it to be available.


HHH-11769: mariadb 10.0 - 10.3 dialects

I hope that i haven't missed any features that appeared in these version.
Also i have a question regarding json functions in 10.2: https://mariadb.com/kb/en/library/json-functions/. Lot's of them return and work with arrays. How should i define these functions correctly.  There's a nice article by @vladmihalcea https://vladmihalcea.com/the-hibernate-types-open-source-project-is-born/, which describes how user should work with it. But isn't it done in hibernate yet? Should we do it in this commit or in the other? And what's better to do with these array\json functions in 10.2?

Awesome!  Thanks for that @bdshadow

WRT support for JSON and other JDBC types... IIRC we decided to wait for supporting this until 6.0.
@vladmihalcea you remember?
Other than that, +1 from me

And I'll let others answer wrt how to best handle JSON type.  I've never worked with it

@bdshadow Adding ARRAY and JSON types is not very difficult as demonstrated by this project I've contributing too:
https://github.com/vladmihalcea/hibernate-types
At some point, we can integrate them directly into Hibernate Core. By then, this project will be thoroughly tested and we can make sure that we get them right from the very beginning.

@vladmihalcea ok, i see. So should this PR wait till it is implemented and then rebase?
Or is it ok to merge it and then change the MariaDB array functions when json and array function are ready? Should then other functions be implemented additionally to json_valid?

Applied upstream, thanks


feat: Allow to use >> and << binary operators in Generic dialect (#553)

Hello!
Thanks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.07%) to 89.835%

Files with Coverage Reduction
New Missed Lines
%

tests/sqlparser_postgres.rs
1
98.6%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
8528

Relevant Lines:
9493

💛  - Coveralls


Change license types filter

Change the license types filter, mentioned at #295
Here's the old vs new changes:

Old
New

All License Types
I want something that I can...

CC-licensed works only (no PD)
use for commercial purposes

All Public Domain (PD)
modify or adapt

Commercial use permitted
"use for commercial purposes" includes all PD content + non-NC licenses

Modifications permitted
"modify or adapt" includes all PD content + non-ND licenses

Sorry I meant only two options should be available for this new filter:

use for commercial purposes
modify or adapt

"use for commercial purposes" would return content under PD tools (cc0 + PDM) and non-NC licenses
"modify or adapt" would return content under PD tools (cc0 + PDM) and non-ND licenses
they are not additional options in the drop-down.

@elharony I made the changes requested by Jane. Thank you for starting the work on this 👍

Thanks, @brenoferreira . I was a little bit confused and worry about updating the code after your merge! 😄


client: implement callback protocols

This implements support for the callbacks in the underlying client, so that when put_file() is used it will pass the callback within it's **kwargs and it will just work like normal. I wasn't sure about deprecation policy, so supporting for both of the callback options required a bit of typing magic (casts), hopefully it is OK.

Codecov Report

Merging #44 (c2e6a02) into main (e9b57e9) will decrease coverage by 0.09%.
The diff coverage is 89.65%.

@@             Coverage Diff             @@
##              main      #44      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%
===========================================
  Files           28       29       +1
  Lines         3248     3264      +16
  Branches       187      188       +1
===========================================
+ Hits          3248     3261      +13
- Misses           0        3       +3

Impacted Files
Coverage Δ

src/webdav4/fsspec.py
100.00% <ø> (ø)

src/webdav4/types.py
0.00% <0.00%> (ø)

src/webdav4/callback.py
100.00% <100.00%> (ø)

src/webdav4/client.py
100.00% <100.00%> (ø)

tests/test_callback.py
100.00% <100.00%> (ø)

src/webdav4/stream.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b57e9...c2e6a02. Read the comment docs.


Adjusts tile xy value when coordinates are out of bounds

Ref #77
This adds a private function from Leaflet that adjusts the coordinate values whenever they are out of bounds (i.e. outside of -90:90/-180:180), which we were missing in _addTilesFromCenterOut.
Right now this doesn't mean it will display Torque data when the viewport is out of bounds. @javisantana do we want that to be its behaviour?

Torque tiles are now being drawn out of bounds as discussed.

@javisantana

:es:
keep in mind there is a google maps implementation but for the moment let's do it only for leaflet

Dismiss this PR, using the wrong branch, moving to #84 !!


nom 5.0 internal design

After some thought, I reached a satisfying new design for nom 5.0, that I tried in the nomfun repository.
This design uses functions instead of macros, with the same signature as macros combinators, mostly having I -> IResult<I,O,E> functions as arguments, and returning other functions, or applying them directly on some input.
As an example, here is how the pair combinator would be written:
pub fn pair<I, O1, O2, E, F, G>(first: F, second: G) -> IResult<I, (O1, O2), E>
  where F: Fn(I) -> IResult<I, O1, E>,
        G: Fn(I) -> IResult<I, O2, E> {

  move |input: I| {
    let (input, o1) = first(input)?;
    second(input).map(|(i, o2)| (i, (o1, o2)))
  }
}

pub fn pairc<I, O1, O2, E, F, G>(input: I, first: F, second: G) -> IResult<I, (O1, O2), E>
  where F: Fn(I) -> IResult<I, O1, E>,
        G: Fn(I) -> IResult<I, O2, E> {

  pair(first, second)(input)
}

This way we have two versions, one that combines two parsers and makes another one, and another that can take some input.
The macro version can then be rewritten that way:
macro_rules! pair(
  ($i:expr, $submac:ident!( $($args:tt)* ), $submac2:ident!( $($args2:tt)* )) => (
    pair!($i, |i| $submac!(i, $($args)*), |i| $submac2!(i, $($args2)*))
  );

  ($i:expr, $submac:ident!( $($args:tt)* ), $g:expr) => (
    pair!($i, |i| $submac!(i, $($args)*), $g);
  );

  ($i:expr, $f:expr, $submac:ident!( $($args:tt)* )) => (
    pair!($i, $f, |i| $submac!(i, $($args)*));
  );

  ($i:expr, $f:expr, $g:expr) => (
    $crate::pairc($i, $f, $g)
  );
);

As we can see currently in the 5.0 branch, most combinators are easy to replace:

extract the macro's code
put it in a function
add the proper trait bounds to the function
replace the macro's code with a function call

The resulting code is functionally equivalent, has less type inference issues and is much faster when built with link time optimization (I have seen results like 20% faster with the new design on some benchmarks).
Another benefit of this system is that it benefits from better import behaviour. Right now, even in edition 2018, macros that are exported are put at the top level (so the module import like macros use is actually a lie). So I cannot make variants of macros 'except by changing their name, to do stuff like separated_list and separated_list_complete.
This was an issue because we expect slightly different behaviour in streaming parsers (where we're not sure we'll get the whole data at once) or in complete parsers (where we're sure we have the whole input). In nom 4, I tried to solve this by introducing the CompleteByteSlice and CompleteStr input types, that would behave differently, so you could use the same macros but have different parsers depending on the input. This proved difficult to use, especially considering that we might want to switch back and forth between behaviours (streaming parsers using TLV will know that they have the complete data inside the TLV, complete parsers might want to use methods that work directly on &[u8] and &str. Also, most people did not bother reading the documentation about it and started directly using &[u8] and &str as input when they expected the other behaviour, which resulted in quite some time spent explaining it.
So with functions, we can actually make specialized versions of combinators. We could imagine having streaming and complete versions of many0, tag, etc. And we would let people use those versions by importing them directly (use nom::multi::streaming::many0, etc), and they could even use both versions in the same file.
The downside is that there's an enormous amount of work for this:

for most combinators (that are not affected by streaming or not), two functions to add:

a function returning a closure
a function that is called directly

for combinators affected by streaming, multiply that by 3:

a legacy function to keep backward compatibility inside the macro (although I'm not yet sure we should keep the old behaviour, I might just remove CompleteByteSlice and CompleteStr)
a function that works in streaming
a function that does not work in streaming

These functions will also require their own documentation and tests, and all of nom's documentation and examples should probably be adapted to this.
I'm making steady progress on converting the combinators, but there's still a lot to do. (TODO: make a checklist of which combinators were ported over or not)
Questions I have to solve now:

do I keep nom 4's behaviour with CompleteByteSlice and CompleteStr ?
do I keep macros related to streaming backward compatible with nom 4?
if not, which behaviour should I go with? Streaming or not?
do I make two versions of each combinators, or can I assume people will be able to write pair(first, second)(input) without any issues?
how do I port combinators that have a variable number of arguments, like do_parse (this one could probably be written directly with the ? syntax like this: https://github.com/Geal/nomfun/blob/master/benches/http.rs#L93-L102 ), tuple, permutation, alt, switch?
how do I reimplement ws?
should I extract method and ws in their own crates? They're not strictly necessary to nom and would make sense as separate libraries

Methods was marked as deprecated and reference to nonexistent nom-methods crate, so sad

I have not pushed the crate yet. This major version will be a big cleanup, and it's a good occasion to extract things that are not as closely maintained as the rest

How what about compatibility around a macros and function moved to different crate?
BTW, in my opinion  CompleteStr is useful, but not described on the documentation main page, in a cause many people try use &str directrly.

do I make two versions of each combinators, or can I assume people will be able to write pair(first, second)(input) without any issues?
My vote is definitely on having only one version. It keeps the amount of duplicate code to a minimum and encourages first building a parser and then parsing some input later.
If there are some clear examples given in the docs then I feel like this won't be too confusing for new users. Especially when the alternative is: "Why are there two versions of everything? Which one should I use?" I think that'd be much more confusing.

I don't fully understand marking a macro as deprecated on the latest version, without a proper replacement crate existing. I can just roll back to 4.1.1 but as someone that wants to port a decently sized hand written parser to nom, it doesn't instill much confidence in that this library will be maintained with some stability in the long run. Don't want this to sound overtly critical, I'm a happy user of nom :smile:

After working a while on nom 5 (cf https://github.com/Geal/nom/compare/5.0 ), I have some answers to these questions:

keeping CompleteByteSlice and CompleteStr means keeping backwards compatibility with nom 4 in macros. Unfortunately, keeping that compatibility means having 3 versions of some functions (nom 4, streaming and complete). I'd rather change the combinators back to nom 3 behaviour, and push users of those types to use the new functions instead
most combinator functions will return a impl Fn(I) -> IResult<I, O, E>, and there's no need for the second version, except for some macros combinators which have type inference issues
combinators like do_parse can be written directly as imperative code (lots of combinators can be written directly, like cond or map and don't need to be rewritten). Others could be implemented on tuples of parsers, maybe?
method and ws will be extracted in other crates

@0X1A if you've followed nom for a few versions, you should have seen that I care a lot about backward compatibility, and major version upgrades should always try to minimize breaks. But this is also a good occasion to clean things up, and there's also a limit to the quantity of code I can maintain. So I'd rather have nom's core be clean and stable, and have external crates with their own release cycles (they should be easier to maintain than nom itself)

Will the macro syntax be kept for 5.0 or is it gonna be only the new function based combinators?
Also, I'd really like to write a (procedural) macro for nom 5 that accepts PEG syntax and converts it to the regular nom combinators under the hood. I feel like that would add a really nice middle ground between parser combinators and parser generators and might speed up writing parsers for simple syntaxes a lot. Especially if you can use previously defined regular nom parsers as a component in the PEG parser.
Is this something you'd be interested in?
A quick example:
(syntax is a combination of standard PEG and the lalrpop angle bracket syntax for assigning (sub)results to temporary variables)
parser = peg!(
    Expr = <l: Product> ("+" <r: Product>)* => { r.fold(l, |a, i| a + i) }
         | <l: Product> ("-" <r: Product>)* => { r.fold(l, |a, i| a - i) }

    Product = <l: Value> ("*" <r: Value>)* => { r.fold(l, |a, i| a * i) }
            | <l: Value> ("/" <r: Value>)* => { r.fold(l, |a, i| a / i) }

    Value = <s: [0-9]+> => { s.parse::<u64>() }
          | "(" <e: Expr> ")" => { e }
)
// and using the (sub) parsers
result: u64 = parser.Expr("2 + 2 * (3 - 5)") // should return -2

the macros will stay in nom 5, but they will use the functions under the hood. A PEG generator sounds nice :)

Great!
I have a simple version working, but it's a bit of a mess right now. I'll clean it up a bit and put it online as soon as I can.

combinators like do_parse can be written directly as imperative code (lots of combinators can be written directly, like cond or map and don't need to be rewritten).

I needed to do some stuff in a parser that would've been difficult or impossible to do with do_parse, and wrote it as a function. It was annoying to have to update the input every time I used a parser. This is untested, but something like this would've been useful:
pub fn replace_buf<B, T>(input: &mut B, tuple: (B, T)) -> T {
    *input = tuple.0;
    tuple.1
}

This would be called like:
replace_buf(&mut input, le_u8(input)?);

personally, I don't think it's too complex to do this:
let (input, val1) = parser1(input)?;
let (input, _) = parser2(input)?;
let (input, val3) = parser3(input)?;

Ok((input, MyStruct { val1, val3 }))

But I'm planning to add a tuple based version, so you could do it like that:
let (input, (val1, _, val2)) = parse((parser1, parser2, parser3))(input)?;

Ok((input, MyStruct { val1, val3 }))

That doesn't work in loops.

Use many0 then
On Sun, Apr 14, 2019, 19:14 leo60228<EMAIL_ADDRESS>wrote:

That doesn't work in loops.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Geal/nom/issues/878#issuecomment-483020359, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHSAGUR0pQBV2Aqk_WtN8zP7SSodQWvks5vg2IQgaJpZM4bheuz
.

My specific code was:
    let (mut buf, child_count) = le_u16(buf)?;
    for _ in 0..child_count {
        let (child_buf, child) = take_element(buf, &lookup)?;
        buf = child_buf;
        binel.insert(child);
    }

BinEl is a struct that gets returned from the parser and lookup is an argument to the parser. I suppose I could use a parser that returns a Vec and iterate over it, but that seems like it would have a performance penalty.

That does not look very complex to me, I have a lot of code that looks like
that, especially in nom. I guess you could use fold_many_m_n for this, to
avoid allocations.
The switch to functions also mean we can now integrate parsers more easily
with iterators. I have not explored it in detail yet, but I guess some
interesting patterns could appear.
On Sun, Apr 14, 2019, 19:20 leo60228<EMAIL_ADDRESS>wrote:

My specific code was:
let (mut buf, child_count) = le_u16(buf)?;
for _ in 0..child_count {
    let (child_buf, child) = take_element(buf, &lookup)?;
    buf = child_buf;
    binel.insert(child);
}

BinEl is a struct that gets returned from the parser and lookup is an
argument to the parser. I suppose I could use a parser that returns a Vec
and iterate over it, but that seems like it would have a performance
penalty.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Geal/nom/issues/878#issuecomment-483021656, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHSALO3t7-qubGaapn-eWrWXHKCqrCrks5vg2N2gaJpZM4bheuz
.

It doesn't matter too much, it was just that buf = child_buf; felt somewhat cumbersome. Great job on nom, by the way!

the nom 5 rewrite is now done


[HUDI-2855] Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload'

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
When the new data is earlier than the current value, we do not update the historical data. And this is consistent with the logic of Spark SQL
Brief change log
(for example:)

Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload'*

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run azure

@hudi-bot run azure


update for PopOS bash profile file Update Homebrew-on-Linux.md

[ x] Have you followed the guidelines in our Contributing document?
[ x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ x] Have you successfully run brew typecheck with your changes locally?
[ x] Have you successfully run brew tests with your changes locally?

Updating proper install file for PopOS install of Homebrew. PopOS uses ~/.bashrc and not ~/.profile or ./bash_profile

Thanks for the PR here but would rather we didn't articulate every Linux distro here.


React 0.30 update; Cross-platform Linking, Android support, Promises

This branch does the following:

Updates to react-native 0.30+
Replaces the deprecated LinkerIOS with the new cross-platform Linker and handles the api changes
Adds support for android, now that the linker is cross-platform
Switches to a Promise based API to match the Linker's change to a Promise based API
Fixes some bugs in package.json causing errors or warnings (missing repository, invalid license value, peer deps not included in dev deps for testing)

looks good to me

When will be this PR submitted? We're waiting for Android support :D

Hi !
Is this still planned or what ? :)

Can it be merged?


Compliance Report | Floating windows block report data when viewing a submitted report |1|

Current State:
When viewing a submitted compliance report, the floating windows in the different schedules block a portion of the last row entry. See attached screenshots.
Desired State:
Provide enough blank space below the last row entry to fit the floating windows without blocking any data.
https://trello.com/c/0jwsnmt0/1969-compliance-report-floating-windows-block-report-data-when-viewing-a-submitted-report-1

 Compliance Report | Floating windows block report data when viewing a submitted report |1|

resolved in sprint vulcan


8312.2 Update db status

Shippable/pm#8312

Create Admiral's PUT /api/systemConfigs route
Call this route to set the db as initialized

after discussion we decided to directly set the flag in the POST api/db/ route instead of a separate systemConfigs PUT route.

this is complete.


"Remove legacy gossip" rebased onto current develop

The original commit by @seancribbs is 1205ea4976 (#541).
Conflicts:
src/riak_core.erl
src/riak_core_console.erl
src/riak_core_gossip_legacy.erl
src/riak_core_ring.erl
src/riak_core_ring_handler.erl

We need PRs for both the 2.0 and 2.1 branches as well.

Oops, disregard.  Previous comment was meant for another PR.

Per Jon's comment, this is 2.next, hence not relevant to 2.0/2.1.

Do you mind amending this commit (2bada68) to have a better commit message?  No need to say in the commit it's been rebased, just clearly specify the changes.
I'll :+1: once commit message is cleaned up.

@cmeiklejohn pity @seancribbs was himself not particularly verbose in his commit.. But I'll try to give it a description as I understand it.

Just do what you can to make it a bit clearer for future you.

:+1: 727fa77

@borshop merge


Proposal for two new functions for the GUI in fixing mask mistakes.

Cellpose has been working very well in segmenting my cell images. Sometimes though there are small mistakes - like a cell is divided into two or two cells are merged into one. Instead of clearing the incorrect masks completely and redrawing the mask by hand, it would be much easier to have a function that can merge two (or more) adjacent masks into one, and a function that will divide a mask into two pieces (by drawing a line through the existing mask).

the github version now has merging -- click on one cell then left click while holding ALT to merge it with the current cell. I don't plan to add splitting because that's more complicated. please comment if it's not working.


More flexible Host configurations

presently, I must put https://MYHOST.com/sholi/api.php exactly. I cannot omit the https:// and I cannot omit the api.php. The sub-text of the item says "the location of api.php", which makes me think that I should put the folder in which api.php resides, not to put the exact path in.
It should not care whether https://, http://, or whatever is preceding the address, and it should be clearer as to whether it expects an exact path or not.

There is no differentiation between http and ssl. However, you should really use https. But I guess, it is because you don't have a commercial certificate.
I will try to include a way to use self-signed certificates.
About the location: I will add DirectoryIndex api.php to the .htaccess so the address we need can omit the api.php --> example.com/sholi/

No, no, what I meant was that I have to manually type it in to the address field. It should be agnostic so it would work with https://MYHOST.com/sholi/api.php or just MYHOST.com/sholi/api.php
By all means, don't allow self-signed certs.

Ah, get it now!
You are absolutely right.
Well, about self-signed, the is a great library which allows adding a cert to the trusted keystore for just that app. Accepting all certs without check is of course out of the question:D

Done :)


[ALLUXIO-2735] Mark class MaxFreeAllocatorTest as a final class

https://alluxio.atlassian.net/browse/ALLUXIO-2735

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15055/
Test PASSed.

Merged build finished. Test PASSed.


Provide application-level control over dispatch error logging

Currently we log all errors that occur in the dispatch pipeline. This can be noisy especially if there is a client that is submitting a lot of bad data. Consider allowing applications to determine which exceptions get logged and at what error level; we might want to (for example) log IllegalArgumentExceptions and other client generated errors as warnings, or suppress them altogether.

Design goals

Clients should be able to control the log level for any type of Exception
Misk provides configurable defaults for the general range of Client (4xx) and Server (5xx) Exceptions
Type Hierarchy should be used to evaluate the correct the mapping, not install order. e.g given MyNotFoundException : NotFoundException, the MyNoFoundExceptionMapper should be used.

Changes

Create ClientException : ActionException, with the proper code restriction. Update the existing ActionExceptions of 4xx to extend the proper ones.
Split out a separate ExceptionLogLevel interface from ExceptionMapper#loggingLevel. I think this makes it easier for clients to reuse the general Response building code when needing to suppress a log message.
Add an ExceptionLogConfig that allow configuring an client_exception_level and server_exception_level. These values are used by a ClientExceptionLogLevel and ActionExceptionLogLevel respectively.
Change ExceptionHandlingInterceptor#mapperFor to search by Type Hierarchy instead of the first matching that is installed by Guice.

Examples
my-app-prod.yaml
exception_log_levels:
  client_exception_level: INFO
  server_exception_level: ERROR

my-app-development.yaml
exception_log_levels:
  client_exception_level: ERROR
  server_exception_level: ERROR

class MyBuggyNotFoundException : NotFoundException

/** Known issue that we silence until clients can be fixed upstream */
class MyBuggyNotFoundExceptionMapper : ExceptionMapper<MyBuggyNotFoundException> {
  fun loggingLevel(th: MyBuggyNotFoundException): Level = Level.OFF
}

IllegalStateException is ERROR in all envs
NotFoundException is INFO in prod, ERROR in development
MyBuggyNotFoundException is OFF in all envs

What's the distinction between client and server here? Client exceptions are from requests made by the app and server are from requests made to the app?

ClientException is intended for situations in which the error seems to have been caused by the client (4xx)
ServerException is the server failed to fulfil a request, for whatever reason. Not the clients fault. (5xx)

I think we should just stick with the status codes as the mechanism for determining what is a client error and what is a server error vs having distinct exception classes. It's too easy to screw up and create the wrong exception sub-type with the wrong status code


unrecognised option 'ligand_folder'

Hi,
the example files from the binary distro 2.1.4 all work, the ones in the current repo all have
ligand_folder = ../../../ligands/ANP
which leads to
unrecognised option 'ligand_folder'
Solution:
replace
ligand_folder = ../../../ligands/ANP
with
input_folder = ../../../ligands/ANP
I also noticed that some of the examples from the master-branch and the binary distro are different.
Cheers
Tobias

Hi,
The master branch is for developing a brand new version v3.0.0, which supports GPU computing using CUDA/OpenCL. It is currently under development and anything is subject to change. Do not use the master branch at the moment. Instead, the v2.x branch is for stable releases.

Hi Tobias,
Now the previous ligand_folder and input_folder options are changed to ligand in conformance of AutoDock Vina, but the ligand option of idock allows the user to specify a single ligand file or a folder of ligand files.


Structured load api

This now replaces the discussion PR on the "feature branch" in my repo : https://github.com/pp-mo/iris/pull/27
NOTE NOT READY YET : documentation changes still need to be reviewed/finalised/agreed.
from notes there:

As everything else was already agreed + merged to here, I've merged the outstanding pp-mo/iris#31 "Revised documentation, whatsnew and deprecations."  here, as that is all that remains to discuss.
So I closed this and opened a new PR to the main Iris master instead : #2241
We can discuss what remains to be discussed there.

I think I've now addressed all the outstanding stuff we noted down.
Please re-review @marqh .

thank you for all the hard work @pp-mo
I agree that this is good to go, we have captured a few 'nice to have' elements in #2243
this code belongs on master now
any further changes will be additive


GSLUX-700: Fix splitter

JIRA issue
https://camptocamp.atlassian.net/browse/GSLUX-700
Description
Rendering glitch due to inverted coordinated
Screenshots
(only if the final render is different)

Did not test but ok, thx for the fix.
(don't forget to npm run build:lib:prod)


Some Armors don't render as intended

Certain armor, such as the armor from bewitchment, doens't render correctly or just don't render at all. I think it's proably any armor that uses custome models

Immersive Armors also fail to render properly when equipped in a vanity slot; don't change appearance when another armor is equipped in a vanity slot, when wearing armor from IA.

This seems related to #6, but I'll keep this open for now.

This should be fixed now!


Fixing "Undefined global" warnings

Hi (again 😄) 👋 and thanks for making this nice adapter!
I'm just wondering, what is your recommendation on getting these symbols to not cause linting issues, and making it possible to perform e.g. gd (goto def) on them?

I'm not 100% sure, but I was thinking I could perhaps somehow use neodev to fix this, by adding a .neodev.json with the following contents to the repo root:
{
  "neodev": {
    "library": {
      "enabled": true,
      "plugins": true
    }
  },
  "neoconf": {
    "plugins": {
      "lua_ls": {
        "enabled": true
      }
    }
  }
}

On my end this works for the most part really well, but there are still some warnings:

What do you think would be the best solution here?
And if you're curious, here's my neovim config: https://github.com/fredrikaverpil/dotfiles/tree/main/nvim-fredrik

I'm afraid I don't have a good solution. It is not highlighted for me because I have [plenary.nvim](https://github.com/nvim-lua/plenary.nvim] installed, which places its own describe into the global namespace. Jumping to the definition takes me to that describe as well. The culprit is lua/plenary/busted.lua, which is a an ad hoc, informally-specified, bug-ridden, slow implementation of half of busted.
For the record, I consider this a mistake, I hate it when a plugin pollutes my global namespace with its own symbols for no reason. But it does keep the language server quiet, so there's that. I mean, if TJ wants to make Telescope depend on his grab-bag of Lua code then fine, but I don't like that a library is inserting code into the _G variable.
If you don't have plenary.nvim installed you could try adding the busted definitions to your language server configuration. Adding ${3rd}/busted/library to your workspace.library should be enough.

Ok, no worries - thanks for having a look at this 😄 👍

Did you try adding ${3rd}/busted/library to your settings? I think it would be useful for people who come across this thread in the future to know if it works.

No, I didn't try that - I had to move on and used neotest-plenary instead as I was constantly finding myself in a rabbit hole with busted, unfortunately.


gfxrecon-replay: Use infinite timeout for 3 Vulkan api calls

When replaying:
vkAcquireProfilingLockKHR
vkWaitForPresentKHR
vkWaitSemaphores
use an infinite timeout if the expected result is VK_SUCCESS.

CI gfxreconstruct build # 3147 running.

CI gfxreconstruct build # 3147 passed.

CI gfxreconstruct build queued with queue ID 33915.

CI gfxreconstruct build # 3161 passed.

CI gfxreconstruct build queued with queue ID 34079.

CI gfxreconstruct build # 3162 running.


Change owner: Add to Admin page a function that enables a  change in item ownership

When an admin selects "Change item owner" from dropdown menu on the admin page, they should see a box to search by work ID.
Search result should return a table with the following:

item title for item found in search, linked to item view page
collection title, linked to collection view page
work status (i.e. work state)
work ID
Item owner (SUNet of depositor or other current owner) with pencil icon

Mockup: https://projects.invisionapp.com/share/EQXC9CLKCR2#/screens/467473856

Clicking on the pencil icon changes the item owner listed into an entry box for another SUNet ID.
This should be a SUNet ID search just like we have implemented for adding collection participants except that instead of an "Add" button it should say "Select."  Clicking this should update the displayed table with the new owner.
Mockup: https://projects.invisionapp.com/share/EQXC9CLKCR2#/screens/467692517

Background
We need to be able support use cases where the depositor of an item no longer needs access to the item and wants another user to be able to manage it.
This should be a "current owner" field (i.e. a new field in the database) so that we can retain the information about who the original depositor was. The "current owner" should have all the same permissions that the original depositor had with respect to that item.
The original depositor (or other previous owners) should no longer see the item on their dashboard or be able to perform any actions with the item, and they should no longer receive any email notifications about the item.
We should be able to accommodate more than one change of ownership, i.e. item is deposited by Person A, then Person B becomes the current owner, and sometime later Person C becomes the current owner.

We also want to display an error message to the user if the work ID is not found:
Work ID not found. Please try searching for another work ID number.

This feature will go on the item view page along with two other features. This is the what that page looks like before this feature is selected:

And this is what the change owner function looks like. The admin will perform the same kind of SUNet ID search that we are using on the collection form to make sure they are entering a valid SUNet and that it is for the correct person. When they identify the correct person, they will click the Add button. And then the "change owner" button.

All additional work related to this ticket has been split into additional tickets.


ZeroDivisionError: float division by zero

Traceback (most recent call last):
298   File "../../src/bin/feature_extract.py", line 400, in
299     main()
300   File "../../src/bin/feature_extract.py", line 395, in main
301     logging.info(str(arr[0])+" "+str(arr[1])+" "+str(arr[1]/arr[0])+" "+str(arr[2])+" "+str(arr[2]/arr[0]))
302 ZeroDivisionError: float division by zero
If you delete this line of code, the feature can still be extracted, and the training process can be trained. However, there are some differences between the synthesized feature samples and the speech published by the author. Is it the reason of feature extraction?

That line was actually only for monitoring the number of frames and samples of audio in the dataset.

However, there are some differences between the synthesized feature samples and the speech published by the author. Is it the reason of feature extraction?

Could you explain more about the differences?
If you look into the details of the values, there might be slight differences due to the floating values precision.


Store responses to problems

WIP
What are the relevant tickets?
Fixes #3
What's this PR do?
Adds a model to store problem submission events and changes the logger to use it
How should this be manually tested?
TBD

Codecov Report

Merging #6 into master will increase coverage by 46.84%.
The diff coverage is 84.25%.

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage   35.29%   82.14%   +46.84%
===========================================
  Files           4        8        +4
  Lines          17      112       +95
  Branches        3        3
===========================================
+ Hits            6       92       +86
- Misses         11       19        +8
- Partials        0        1        +1

Impacted Files
Coverage Δ

setup.py
0% <ø> (ø)
:arrow_up:

...nse_datastore/migrations/0001_problem_submitted.py
0% <0%> (ø)

rapid_response_datastore/apps.py
100% <100%> (ø)

tests/test_events.py
100% <100%> (ø)

rapid_response_datastore/settings.py
100% <100%> (ø)

rapid_response_datastore/logger.py
63.15% <63.15%> (ø)

rapid_response_datastore/models.py
92.3% <92.3%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358bae2...fa000fa. Read the comment docs.

Ok, I think that should do it for the first round of review

Should be ready for review again


Firefor Profile Service in wdio.conf

Referring to:
http://webdriver.io/guide/services/firefox-profile.html
The following conf snippet doesn't work either locally or with some other service say Sauce Labs:
services: ['firefox-profile'],
firefoxProfile: {
'media.navigator.streams.fake': true,
'media.navigator.permission.disabled': true
}

Can you try the following to see if it works?
    firefoxProfile: {
        extensions: [path.join(__dirname, '/fixtures/WebdriverIOTestExtension.xpi')],
        'browser.startup.homepage': 'http://webdriver.io'
    },

Nopes! It doesn't work.

Not sure if its related, but I've taken it for a spin and I found two things confusing...
It works if you use browser.... like in the examples in this repo.
but if you init a new client (like with upstream wdio examples) the profile is not passed to it.

Nopes! It doesn't work.

A passing build tells me otherwise.

but if you init a new client (like with upstream wdio examples) the profile is not passed to it.

Do you mean using WebdriverIO in standalone mode? In this case yes it doesn't work, this service is only working for wdio testrunner. In standalone mode you don't need this service.
@sajidchingchong just tried with latest version and it works properly. Make sure to wait till page has loaded as the page load timeout seems to have no affect in this scenario.

I have put the following in my wdio.conf.js:
capabilities: {
firefox: {
desiredCapabilities: {
browserName: 'firefox',
}
}
}},
services: ['firefox-profile'],
firefoxProfile: {
'media.navigator.streams.fake': true,
'media.navigator.permission.disabled': true
}
baseUrl: 'https://appr.tc',
And the following in my test file:
browser.url('/r/' + Math.round(Math.random() *<PHONE_NUMBER>00));
appr.tc asks for camera and microphone access from the user. 'media.navigator.streams.fake' and 'media.navigator.permission.disabled' doesn't allow the pop up to come and uses fake media instead.
For me this thing is not working using webdriverio test runner.
Any help would be appreciated.

@sajidchingchong the capabilities should be an array

Thanks christian. It's a little bit late here, but we will test tomorrow morning first thing.

I have tried turning it into an array. Now it looks like:
capabilities: [
{firefox: { desiredCapabilities: { browserName: 'firefox'} }}
],
It is spawning four firefox instances, closing 3 of them down but the profile attributes are not taking any effect.
The following says that the default browser name is firefox: http://webdriver.io/guide/getstarted/configuration.html
I assume that since the capabilities as an array is not the accepted format, thats why is is behaving like that since it is spawning firefox even if I am trying the following:
capabilities: [
{firefox: { desiredCapabilities: { browserName: 'chrome'} }}
],
My earlier configuration was actually based on the following example:
https://github.com/webdriverio/webdriverrtc/blob/master/examples/wdio/wdio.conf.js
where capabilities is specified as a dictionary.
Awaiting feedback ...

@sajidchingchong the fact that you are using multiremote was not clear. I took a look into that and indeed there was a bug that I just fixed and released

Should the capabilities be an array or an object?

if you use multiremote, then an object


Set another language as default?

When using Fullscreen Grab, it will let me choose use which language like below:

I want to always use zh-Hans-CN so i have to switch it again and again.
Also when using Grab Frame, i can't switch it and it always use en-US
I read the source code and found that, it lists all input languages, and using first one when using Grab Frame.
https://github.com/TheJoeFin/Text-Grab/blob/d3dd4cd2410406f16637e9c8af9e3be94e0011d2/Text-Grab/Utilities/ImageMethods.cs#L373
Can it be given an setting to choose a default value?
Thank you.

For the Fullscreen Grab, you can press the number keys to quickly change which language is selected, 1 for the first, 2 for the second, etc.
I have been hesitant to include a setting for choosing a default language which is different than the keyboard option because there is no API to detect changes and it is another layer of settings checking and complexity.
For changing the language on the Grab Frame, if you change your keyboard language (Win + Space) it will change the language Text Grab uses for OCR. But since there is a drop down for the Fullscreen Grab, there should be one for Grab Frame as well.

Can you make it remember the last language i used, which will save my mind to switch the language before start capture. It always ignore CJK chars before i realize i haven't switch the language.
Nearly all CJK users have two language installed, one is US keyboard (en_US) which used to typing URL, coding, gaming, and the other one is CJK input method used to type CJK chars. You can see one example in wikipedia https://en.wikipedia.org/wiki/File:TypingChineseCharactersWithCangjieGedit383Ubuntu1310Screencast.webm
So usually it's in en_US language when using Text-Grab, and it is very annoying to remember switch language to let Text-Grab use CJK engine but not english engine.

Saving the last set language is a good idea. I'll do that.


Update README.md

[中文版模板 / Chinese template]
🤔 This is a ...

[ ] New feature
[ ] Bug fix
[ ] Site / documentation update
[ ] Demo update
[ ] Component style update
[ ] TypeScript definition update
[ ] Bundle size optimization
[ ] Performance optimization
[ ] Enhancement feature
[ ] Internationalization
[ ] Refactoring
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self Check before Merge
⚠ Please check all items below before review. ⚠

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@79b608d). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master        #3   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?       394
  Lines             ?      7518
  Branches          ?      2150
==========================================
  Hits              ?      7518
  Misses            ?         0
  Partials          ?         0

Impacted Files
Coverage Δ

components/_util/transButton.tsx
100.00% <ø> (ø)

components/_util/type.ts
100.00% <ø> (ø)

components/alert/index.tsx
100.00% <ø> (ø)

components/auto-complete/index.tsx
100.00% <ø> (ø)

components/avatar/avatar.tsx
100.00% <ø> (ø)

components/breadcrumb/BreadcrumbItem.tsx
100.00% <ø> (ø)

components/calendar/index.tsx
100.00% <ø> (ø)

components/card/index.tsx
100.00% <ø> (ø)

components/checkbox/Group.tsx
100.00% <ø> (ø)

components/checkbox/index.tsx
100.00% <ø> (ø)

... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b608d...09a1688. Read the comment docs.


Incomplete Syntax definition

ENDM;;

non-Terminal
Definition

;;
([\x9\x20]*;[\x0-\x9\xB-\xFF]*)?\xA

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 068f2079-1f35-749c-fc2b-aed4a72937a2
Version Independent ID: d3022747-d98c-6ce9-eeac-93d7aa876c02
Content: ENDM
Content Source: docs/assembler/masm/endm.md
Product: visual-cpp
Technology: cpp-masm
GitHub Login: @corob-msft
Microsoft Alias: corob

@Player1UK thanks! See comment for #1123.


GetIndexedProperty docs have wrong argument

The docs for GetIndexedProperty shows this signature:
    o.GetIndexedProperty(loInstance, lcProperty)

It looks like lcProperty should be lnIndex.

Fixed in the Web Connection docs, and will be updated in the Client docs next update. Thanks.


[Feature]: task executor module

Is your feature request related to a problem?
task running in separated process
Describe the solution you'd like
task executor  module with responsibility for odc task to run
Additional context
No response

Duplicated with #784


SQL Batch: make the random sleep configurable

Random sleep has been applied to sort out high-load of transactions. Noe it's 100ms, we should make this configurable.

Issue has been resolved , Please close.

Hi @SatishAMP
Thank you very much, closing


i want to remove my log from your site i have used the plug in to do this and it said deleted but is still on site

i feel very uncomfortable having my logs on your site and makes me feel like a target please please remove my info

Removed

thank you very much very prompt response you are amazing


Tab indentation

Describe the Bug
When editing a page in WYSIWYG, the Tab key is being used as a browser navigation key therefore, there is not an option to have tab indentation in the text.
Steps to Reproduce

Edit a page
Use Tab, the cursor will disappear and it wont create a tab indentation

Expected Behaviour
When the cursor is in the editing page and when the tab key is pressed the cursor dissapears and instead it navigates to the next browser control.
It should instead keep the indentation like any other text editor would do.
It works fine with bulleted lists for some reason but not if I want to create a single tab
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
v22.02.3
PHP Version
No response
Hosting Environment
Ubuntu Server installed using the Docker image

Thanks for the request @Ismael034,
I think this is really a matter of expectations and opinion instead of a bug.
We support tabs within code blocks which is the common primary use-case for them.
Outside of that tabs are not so common in the content formats we support and can act inconsistently. In addition we'd need to consider how we're affecting accessibility and current user flows in changing the behaviour.
Due to the above, and since this has not been strongly requested in the last 6 years, I'd look to keep the existing functionality instead of changing to your expected behaviour.
Note, there is an option to indent an entire block if that's what you need. This can be found in the editor toolbar overflow within the same sections as the list blocks.

Hi @ssddanbrown
Thanks for the quick and derailed answer! It's indeed more like a request depending of what you are expecting when writing.
So my main issue is when I want to structure my writting. For example, sometimes I just want tabs instead of bulleted list and it would be more comfortable for me to have tabs but I completely understand that you want to keep the existing behavior as this is what most users are expecting to be.
Also I didn't know about the block indenting feature. Haven't tried it yet but it seems to more less solve my issue
As of this I think I am closing this issue if you are ok with it and thank you for creating this amazing tool!


Change cursor up/down behavior for the first/last line

Currently, pressing up/down while on the first/last line does nothing.
This PR changes that so the cursor goes to the start/end of the line, as is common in other editors.

Codecov Report

Merging #1971 (e59c508) into master (acf1de5) will increase coverage by 0.04%.
The diff coverage is 0.00%.

 Learn more

Thank you :)

Thank you for putting this in!


can we use this in react ? or does react has similar library like this ?

Can we use this in react ? or does react has similar library like this ?
If there is no library like this in react i think we should start an open source project.

There is no similar project AFAIK. Please feel free to start, but I must say that the lib has a lot of vue-specific tricks.

I have never used Vue (I use Stencil and other web tech, though) and have been trying to find this exact kind of lib.
My first searches say no... Can anyone shed light on if I can run these charts inside web components? It's worth asking!
Anyways, awesome lib :)

You can export the chart as a custom element. See: https://github.com/karol-f/vue-custom-element
Then you can embed your custom element anywhere! 😃

@JohannesHoppe Thank you for the resource. I am going to give this a shot. This will be my first time ever working in Vue. If anyone has experience and wants to throw together a working example before I can please do 😁

First time Vue here, too! 😆
Great progress so far. I did something very similar on top of a plain Vue CLI project. In my version you can use properties to hand over data, too. I could prepare another demo in some hours, if you are still interested?

@NorthMcCormick Check out this demo. This should provide you with everything you need. Have fun with it! 😃
Source:
https://github.com/JohannesHoppe/trading-vue-js-web-component-example
Demo:
https://johanneshoppe.github.io/trading-vue-js-web-component-example/


Use root element to handle focus, clicks and keyboard interactions

#34986

[x] I have followed (at least) the PR section of the contributing guide.

@michaldudak , could you take a look?

Since there are no updates after Michał's review, I am closing this PR.


site: determine example features

https://codesandbox.io/docs/importing#import-from-github
Figma File

closing: i created additional issues to track smaller tasks

#1154
#1155
#1156


🐞 ERROR HttpErrorResponse with the proxy + ssr-dev-server + SSL

🐞 Bug report
What modules are related to this issue?

[x] builders (ssr-dev-server)
[ ] common
[ ] express-engine

Is this a regression?
No idea.
Description
When using the proxy (proxy.conf.js + "proxyConfig": "proxy.conf.js") with @nguniversal/builders:ssr-dev-server and ssl enabled (ssl + cert + key), it seems that I cannot take advantage of the proxy when rendering the page on the server.
Works fine without SSL.
I'm getting an error when trying to access https://localhost:4200/ because of the call to the API that require the proxy to work.
With ng serve everything works perfectly even with SSL.
Maybe there's something I'm missing or don't understand.
🔬 Minimal Reproduction
On the HomeComponent, I'm making 2 requests to the same API, the first one directly calling the real full url, the second request that need the proxy to "redirect" the call (this one fail with SSR + SSL).
There's an API interceptor to rewrite the url in Platform Server. (src\app\core\interceptors\api.interceptor.ts)

Clone this repo: https://github.com/Yberion/Angular-SSR-Common-Engine
Switch to branche feature/ssr-dev-ssl
npm i
npm run start:ssr:fastify:development or npm run start:ssr:express:development

SSL is enabled on the branche

You can disable SSL on serve-ssr-express / serve-ssr-fastify and test that it works.
 The proxy only effect requests coming from the browser.

Let me take another look.

I think some NodeJS versions will work fine. I've the same issue but I also couldn't find any solution. NODE_TLS_REJECT_UNAUTHORIZED didn't work for me. My working nodejs version:  16.15.1

I have got the same error angular ssr when request to localhost

Same error when use certificated auto seft i solve use NODE_TLS_REJECT_UNAUTHORIZED  set to 0.
Addicionally also usage the previous , change my httpClient to fetch in Angular 17 , and fixed the error.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.


[ISSUE #392] fix no need clear the queue

What is the purpose of the change
https://github.com/apache/rocketmq/issues/392
to fix this isuue
Brief changelog
there is no need to clear the queue anymore, because the tasks in the queue will be processed after shutdown.
Verifying this change
verify the logic correction use unit test
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.04%) to 42.302% when pulling 5576708cea0310dc2127d4a324b3602769f4e2a0 on tianliuliu:ROCKETMQ-0001 into 289f0d2ed85d598a7bc84f7fee39c374d55b816d on apache:master.


Incorrect/Incomplete Search Results

I entered the following keywords:
soundscapes
atmospheric
ambient
and I see few albums in the search results. But I believe this is not the complete list. For example, I know an album that has the above three keywords for sure but it did not show up in the results on campexplorer
Ex: https://maxcorbacho.bandcamp.com/album/breathstream
Can you please check and fix this?

Yeah, this is a known issue because of the fact that the data source I'm getting albums from has a limit on number albums returned for each tag/keyword. So it's impossible for me to get a complete list sadly, there isn't anything I can do until Bandcamp makes their API public.


little problem

Description of the bug
hi!, hope you are doing great. Im a newbie so i dont understand a lot about how this can work, but could you please help me with this, i think it's just a little thing. this is what im getting:
so, how could i download the database into this directory  /home/bioren/mdavid/mettaannotator/ ?????
if it's just too stupid of a question then dont bother an answer, i'll try to figure it out.
Thanks in advance,
Cheers from Chile, South America.
Command used and terminal output
(base) [mdavid@mapudungun-frontend ~]$ nextflow run ebi-metagenomics/mettannotator/main.nf -r main --dbs home/bioren/mdavid/mettaannotator
Nextflow 23.10.4 is available - Please consider updating your version to it

 N E X T F L O W   ~  version 24.04.4

Launching `https://github.com/ebi-metagenomics/mettannotator` [backstabbing_lalande] DSL2 - revision: 5fe9266f47 [main]

ERROR ~ ERROR: Validation of pipeline parameters failed!

 -- Check '.nextflow.log' file for details
The following invalid input values have been detected:

* Missing required parameter: --input
* Missing required parameter: --outdir

 -- Check script '.nextflow/assets/ebi-metagenomics/mettannotator/main.nf' at line: 31 or see '.nextflow.log' file for more details
(base) [mdavid@mapudungun-frontend ~]$ nextflow run ebi-metagenomics/mettannotator --dbs /home/bioren/mdavid/met
metagenomics_snakemake/ mettaannotator/
(base) [mdavid@mapudungun-frontend ~]$ nextflow run ebi-metagenomics/mettannotator --dbs /home/bioren/mdavid/met
metagenomics_snakemake/ mettaannotator/
(base) [mdavid@mapudungun-frontend ~]$ nextflow run ebi-metagenomics/mettannotator --dbs /home/bioren/mdavid/mettaannotator/
Nextflow 23.10.4 is available - Please consider updating your version to it

 N E X T F L O W   ~  version 24.04.4

Project `ebi-metagenomics/mettannotator` is currently stuck on revision: main -- you need to explicitly specify a revision with the option `-r` in order to use it
(base) [mdavid@mapudungun-frontend ~]$ nextflow run ebi-metagenomics/mettannotator/main.nf --dbs /home/bioren/mdavid/mettaannotator/
Nextflow 23.10.4 is available - Please consider updating your version to it

 N E X T F L O W   ~  version 24.04.4

Project `ebi-metagenomics/mettannotator` is currently stuck on revision: main -- you need to explicitly specify a revision with the option `-r` in order to use it
(base) [mdavid@mapudungun-frontend ~]$ nextflow run ebi-metagenomics/mettannotator/main.nf -r main --dbs /home/bioren/mdavid/mettaannotator/
Nextflow 23.10.4 is available - Please consider updating your version to it

 N E X T F L O W   ~  version 24.04.4

Launching `https://github.com/ebi-metagenomics/mettannotator` [prickly_gautier] DSL2 - revision: 5fe9266f47 [main]

ERROR ~ ERROR: Validation of pipeline parameters failed!

 -- Check '.nextflow.log' file for details
The following invalid input values have been detected:

* Missing required parameter: --input
* Missing required parameter: --outdir

 -- Check script '.nextflow/assets/ebi-metagenomics/mettannotator/main.nf' at line: 31 or see '.nextflow.log' file for more details
(base) [mdavid@mapudungun-frontend ~]$

Relevant files
No response
System information
The hardware is a linux server

Hi @davidmadariaga ,
There is currently no separate database download step. The databases will be downloaded automatically into the folder you specify in the --dbs parameter as long as the annotation command is correct and complete. Your execution failed because the input and the output folders were not specified. Instead, try running something like this:
nextflow run ebi-metagenomics/mettannotator -profile <docker/singularity/...> --input <path to input file> --outdir <folder to save results to> --dbs /home/bioren/mdavid/mettaannotator
The format of the input file is described here. You could also use our example if you don't yet have genomes to annotate.
Hope this helps.
Best wishes,
Tanya

thanks a lot!!!!


It doesn't load youtube shorts

Be sure to search for your issue before opening a new one.
Current Behavior
I put the link from youtube short video and it does not work.
Expected Behavior
Steps to Reproduce

Environment

URL attempting to play:
Browser:
Operating system:
jsFiddle example: https://jsfiddle.net/sv5x3ug1

Other Information

I don't see any YT url in the example


Adds ability to set explicit null value

Hi there,
The YAML spec allows for multiple ways to specify when a value is "null" - https://yaml.org/type/null.html
In your current implementation, it always defaults to an empty string, which I think is a sensible default. However, one of our downstream systems is unfortunately failing to handle empty strings.
This PR adds a new CLI argument --null-value, where you could specify how null values should be represented (typically ~, null, NULL).
Implementation was inspired by:

https://stackoverflow.com/a/65692753/31506
https://github.com/jumanjihouse/pre-commit-hook-yamlfmt/commit/a80e5f11469f8463c528fca26ea1b821746ac56f

I've added a single test to ensure all null representations are handled.
I also have a separate test (not part of this PR) that ensures that the default behavior hasn't changed, if the --null-value flag is left off. Unfortunately, the test data (specifically the after file) would have trailing spaces, which currently gets rejected by existing tests, and I don't really know how to add an exception to for these. Here's the commit for this one extra test - https://github.com/jackgene/pre-commit-hook-yamlfmt/commit/e2dae703e40b97441ce16fe921c70e5ff3b0357a

I was just looking for this option! :) Hopefully it'll get released soon.


chore(bundle-analyzer): change event again

It seems like pull_request_target not only uses the workflow from the target branch but the code too. So I changed the event back to pr with the pull_request: write permission so actions can add label/write comments on the pr. content: read is needed for checkout. I've also tried using replace syntax in the name, this might work, if it doesn't then please use the previous bundle-${{ matrix.package == 'docs' && 'docs' || 'swr-site' }} name
fixes: https://github.com/shuding/nextra/pull/2245#issuecomment-1947543568
the ci is failing due to fa83af93bd751fbd21455fcedbc28857cd55ee61 change

if it doesn't then please use the previous bundle-${{ matrix.package == 'docs' && 'docs' || 'swr-site' }} name

It didn't worked, it works in terminals only. So please change it to the above syntax and wait for main branch to finish uploading artifacts then merge with v3

I'm sorry I just realized I placed keya in wrong place. I'll create a pr to fix the file properly. Hopefully this will be the last pr to fix bundle analyzer


Angular-app-rewired

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request

I understand that the Angular team does not have the ability to provide configurations for easy manipulation of development and full control over extensions:
Pin: https://github.com/angular/angular-cli/issues/9657#issuecomment-367250883
But many need: Rewire Your App as it is done in React
https://github.com/timarney/react-app-rewired

Note that react-app-rewired is not maintained by the React team, and you are more than welcome to build such a thing and support it yourself. We will not support such a thing, for all the same reasons the React team does not support it: we cannot guarantee the ability to evolve the CLI without breaking everyone if we expose the underlying machinery.
Per the warning from the README:

By doing this you're breaking the "guarantees" that CRA provides. That is to say you now "own" the configs. No support will be provided. Proceed with caution.

Again, per https://github.com/angular/angular-cli/issues/9657#issuecomment-367250883, your best option currently is to maintain your own webpack config, and use our @ngtools/compiler plugin. In the future, the  https://github.com/angular/devkit project may offer the ability to override the ng commands, but again, you'd be responsible for maintaining such overrides.
To be clear: If you want access to the Webpack configuration, you will need to eject, or use your own Webpack setup. Repeatedly asking will not change this.
In any case, this repo is the wrong place for this request. Closing as a duplicate of https://github.com/angular/angular-cli/issues/9657


Error while processing presence map inside optional group

mFast fails to decode EUREX Reference Data stream.
Running sample data with the appropriate XML template gives the following error:
./performance_test/mf_generic_decode -t ../example.xml -f ./example.dat
/opt/mfast/src/mfast/coder/decoder/fast_istream.h(324): Throw in function typename boost::enable_if<boost::is_integral, bool>::type mfast::fast_istream::decode(T&, bool) [with T = int]
Dynamic exception type: boost::exception_detail::clone_implmfast::fast_dynamic_error
std::exception::what: std::exception
[mfast::tag_error_code*] = D2
We have a suspicion that the optional groups which are present in the XML template are processed incorrectly. The debug output shows that mFast tries to decode 0xC0 byte as a value of the field called "TransactTime", whereas 0xC0 in this case is a presence map inside the group called "ComplexInstrumentDescriptorGroup".
Below is the link to the message example and the XML templates.
https://www.dropbox.com/s/zoxs4p5aykx7qp0/mfastBug.zip?dl=0

fixed in commit 9ec02ec4f4fd2614b8e5056443963b28559bb91c


Microsoft Docs

@PRMerger18  why tho

Hi @UnsnappedKhan8 - Thanks for your pull request submission. A member of the content team will review it shortly.

@SyntaxC4 - Could you review the proposed workflow addition or recommend someone suitable to review it? Thanks.


Added the missing backticks around variables

This commit fixes the issue #47687
Signed-off-by: Chandra Prakash<EMAIL_ADDRESS>Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #47687

Hey @leviathanaxeislit
This PR seems to make similar changes as the existing PR #47692 . As such, we are going to close this as duplicate.
If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.
Thanks again! 😊

If you have any questions, feel free to ask questions on the "Contributors" category on our forum or the contributors chat room.


Broken link

LC_ALL=C grep -Fr 'Since the former term is also used to refer to' ef1p/
ef1p/pages/email/email.md:Since the former term is also used to refer to [email delivery vendors](#reputation),

Clicking on "email delivery vendors" link I end up to
https://explained-from-first-principles.com/email/#one-click-unsubscribe

Thanks for your report, I cannot reproduce your issue, though. "email delivery vendors" at https://explained-from-first-principles.com/email/#provider links to https://explained-from-first-principles.com/email/#reputation for me, which is what I intended. Do other green (internal) links for you? I will check tomorrow if expanding and closing boxes could interfere the correct scroll offset to the target location. If it's a JavaScript issue, it would be valuable to know what browser you are using.


fix: Prevent user from sending message when file is being uploaded

Pull Request Template
⚠ Before Submitting a PR, read the Contributing Docs in full!
Summary
This was discussed on discord. When a file is being uploaded, if you hit the Enter key you'd get an error message. This PR will display a notification at the top if you press the Enter key while a file is being uploaded
Change Type
Please delete any irrelevant options.

[ x] Bug fix (non-breaking change which fixes an issue)

Testing
I ran both rpm run test:client and npm run test:api
Test Configuration:
Checklist

[x ] My code adheres to this project's style guidelines
[ x] I have performed a self-review of my own code
[x] I have commented in any complex areas of my code
[ ] I have made pertinent documentation changes
[x ] My changes do not introduce new warnings
[ ] I have written tests demonstrating that my changes are effective or that my feature works
[ x] Local unit tests pass with my changes
[ x] Any changes dependent on mine have been merged and published in downstream modules.

I've fixed the merge conflicts again.
LMK if you want me to re-submit this PR with a clearer git history


The python files that gpt-engineer generated are named incorrectly.

So my prompt was the following . .
We are creating a tool that can talk to Chat GPT using openai-python . It reads log files that are generated during software builds. When it comes across any messages that indicate failure due to missing libraries, etc., it will suggest a Linux command for the user to execute in his terminal. That should fix the whole software build process

Keep in mind I know that cut-off date for gpt's knowledge is 2021.  However, I wanted to experiment with it.
Although it couldn't really complete the project for us, it generated some neat class-based abstractions. But the filenames are invalid and it appears to me that it is an easy problem to fix. IDK...I'm yet to dive into the codebase
Here's a screenshot

Why can't the regex remove backticks

Yes. Please add a regex to remove backticks from the filename, to the function chat_to_files. Leave everything else the same.

Please note that this is not only happening with python files. I also see this happening with .js files

I think we already had this check. Surprised you got this error, maybe you weren’t on the latest release.

With the latest release 0.0.7. PHP files generated have same naming issue:


Interface Tags Not Showing in meta_data.json

What happened:
Tagged interfaces, but no tags in meta_data.json
What you expected to happen:
Tagged interfaces, tags in meta_data.json
How to reproduce it (as minimally and precisely as possible):
VMI with SRIOV
...
      interfaces:
      - name: default
        masquerade: {}
      - name: sriov-1
        tag: "1"
        sriov: {}
      - name: sriov-2
        tag: "2"
        sriov: {}
...
  networks:
  - name: default
    pod: {}
  - name: sriov-1
    multus:
      networkName: default/enp1s0f1
  - name: sriov-2
    multus:
      networkName: default/enp1s0f1

Additional context:
Perhaps it's because it's an SRIOV interface the tags don't work?
Environment:

KubeVirt version (use virtctl version):

Client Version: version.Info{GitVersion:"v0.58.1", GitCommit:"3951090bffaf56814889bcf44ec8db53a4e0b24e", GitTreeState:"clean", BuildDate:"2023-02-10T20:08:40Z", GoVersion:"go1.17.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{GitVersion:"v1.0.0", GitCommit:"579bb66545630d93b29d0399219aaa51c3f0a00b", GitTreeState:"clean", BuildDate:"2023-07-06T18:46:13Z", GoVersion:"go1.19.9", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4", GitCommit:"fa3d7990104d7c1f16943a67f11b154b71f6a132", GitTreeState:"clean", BuildDate:"2023-07-19T12:20:54Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4", GitCommit:"fa3d7990104d7c1f16943a67f11b154b71f6a132", GitTreeState:"clean", BuildDate:"2023-07-19T12:14:49Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/amd64"}

OS (e.g. from /etc/os-release):

NAME="Ubuntu"
VERSION="20.04.5 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.5 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Looks like this was supposedly fixed:
https://github.com/kubevirt/kubevirt/pull/6458
I'm confident I'm not doing anything wrong. I'm glancing at the code and I don't see where sriov is a hostdev. Perhaps that's why it's not getting picked up. Don't quote me on that.

@EdDev @ormergi
I found the root cause of the bug and verified a fix. I haven't fully tracked the broader architectural issue.
taggedInterfaces[netsriov.AliasPrefix+devAliasNoPrefix]
here:
https://github.com/kubevirt/kubevirt/blob/6364802a86d5a933fe7f5de8ca9f0cb73ae7c455/pkg/virt-launcher/virtwrap/manager.go#L1883C27-L1883C27
Fixes the issue. devAliasNoPrefix just comes out as 1, 2 etc.

ha, it might be that I use the same name as it does under the hood for the dom

edit: Yeah, I think it's stripping it weird with the replace because I use sriov-1, sriov-2 etc. Since interfaces come from vmi spec and the cloud init comes from the dom spec when it cleans up the name it butchers it.

I posted a suggested fix to this issue.
@ns-rlewkowicz , if you manage to confirm it works, please comment on the PR.

/assign


TST: fix py35 on Travis

I think this will fix the issue: found the fix here: https://github.com/pytest-dev/pytest/issues/744

Whoo! All passed!


Eliminate column

Two test and body for method eliminate_column added. It may be necessary to add more tests later .

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 14 (85.71%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.004%) to 84.76%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/transpiler/synthesis/permrowcol.py
12
14
85.71%

Files with Coverage Reduction
New Missed Lines
%

qiskit/extensions/quantum_initializer/squ.py
2
79.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.004%

Covered Lines:
61967

Relevant Lines:
73109

💛  - Coveralls


Doesn't work in modal window

I have a dropdown component that works well on a normal page. And I have a modal window where I use the same dropdown component. The dropdown close happens outside of the modal click, but not within the modal. Help solve this problem? Perhaps you need to include the directive globally, since the modal window component does not know about this directive? Although, why then does it work just on the page? I will be grateful for any help.

use a timeout for the click event

i had the same issues on one of my dropdowns
Check @vueuse/onClickOutside on this vueuse docs
https://vueuse.org/core/onClickOutside/
it has same functionality without these kinda bugs


Add helper function for changing impact of individual filters

This pull request fixes issues #37 and #40.  In adding the helper function, I found an error in the code of getFilterData, and fixed that as part of #40

Good find, and nice work. My only change would be to lowercase "$Filter" to make it consistent with the rest of the FilterCollection.

Hey guys - just checking in.  It's the holidays, so I imagine everyone is busy, but I wanted to check and make sure I did things correctly. :)

Very sorry about that Tim. For some reason github never emailed me that you had responded last month. Thanks for keeping us on target!


[CZID-2177] ERCC filter separation

CZID-2177

Unfortunately have to just copy the bowtie2 function due to limitations of the pipeline viz

Hmmm...the test failure appears to be exactly the same thing I hit in https://github.com/chanzuckerberg/czid-workflows/pull/233/files#diff-08d41ce59ff9cc87950f240373fedfc37efbf67a2f89db58a40226b9e3cc90c3 which I'd thought was unrelated. A specific taxid we had hard-coded in the unit test for years (1273712) no longer shows up.
The same thing popping up here seems to suggest some common "environmental" change, a database version upgrade or smth, rather than something directly caused by either diff? cc @katrinakalantar @ovalenzuela19

Hmmm...the test failure appears to be exactly the same thing I hit in https://github.com/chanzuckerberg/czid-workflows/pull/233/files#diff-08d41ce59ff9cc87950f240373fedfc37efbf67a2f89db58a40226b9e3cc90c3 which I'd thought was unrelated. A specific taxid we had hard-coded in the unit test for years (1273712) no longer shows up.
The same thing popping up here seems to suggest some common "environmental" change, a database version upgrade or smth, rather than something directly caused by either diff? cc @katrinakalantar @ovalenzuela19

I think this is likely just an instability caused by some randomness in the ordering operations. The taxid had a very low presence in the sample.


Hotfix: Fix for Youtube Player on Desktop IE/Safari

Fix for Youtube Player on Desktop IE9/Safari. This sets the Youtube host to use https which resolves an issue allowing control of the Iframe on IE9 and Safari ( what a weird combo ).
Testing

Visit http://localhost:8000/about-us/the-bureau/ on Safari or IE9. Click the play button.  Click the close button.  The video should start from the beginning.

Review

@anselmbradford
@KimberlyMunoz
@jimmynotjim

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Working :+1:


Perfect Scrollbar jQuery Compatibility/Documentation

The documentation for integrating Perfect Scrollbar v1.4.0 shows jQuery based interactions.
See here
However, when I attempt to use the following code:
$('.scroll-window').perfectScrollbar();
I get the following error:
Uncaught TypeError: $(...).perfectScrollbar is not a function.
However, this code works:
const ps = new PerfectScrollbar(".scroll-window");
Despite the included file being called /perfect-scrollbar.jquery.min.js it seems they've discontinued jQuery support.

Hi @Okomikeruko,
Thank you for working with our products.
The plugin has been updated and now this has to be initialized this way:
const container = document.querySelector('#container');
const ps = new PerfectScrollbar(container);

// or just with selector string
const ps = new PerfectScrollbar('#container');

We will change our documentation for the perfect scrollbar in our next update.
I hope it helps.
All the best,
Rares


Improvement of lint metrics

Closed into https://github.com/ocriado91/alfred/commit/51362bd2fa134b14677d4b6d66ddd56f9663ab33


Fixed missing formatting

@olvlvl for alternative, you can use Roave/BetterReflection or goaop/parser-reflection libraries.

Hi @lisachenko, I was going for nikic/PHP-Parser, but both your suggestions looks really interesting. Thanks.

@olvlvl Basically, both previous packages uses nikic/PHP-Parser under the hood, so you can rely on them )


only attempt to convert and add push token if present

cc: @amitayfeder1
Right now addPushDeviceToken blindly attempts to call pushDeviceTokenToString which returns nil if deviceToken isn't present. Passing nil to NSDictionary causes a crash. This change checks if there's actually a push token before attempting to convert to a string.
We used to handle this scenario in 2.9.9 via the logic here: https://github.com/mixpanel/mixpanel-iphone/blob/v2.9.9/Mixpanel/Mixpanel.m#L2093-L2095

@wgins let's check the response of pushDeviceTokenToString instead of the token itself. In case something else goes wrong.


[Snyk] Security upgrade python from 3.8.5-slim-buster to 3.10.9-slim-buster

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to python:3.10.9-slim-buster, as this image has only 71 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

714
Directory Traversal SNYK-DEBIAN10-DPKG-2847944
No Known Exploit

714
Out-of-bounds Read SNYK-DEBIAN10-LIBTASN16-3061094
No Known Exploit

714
Buffer Overflow SNYK-DEBIAN10-OPENSSL-1569403
No Known Exploit

714
OS Command Injection SNYK-DEBIAN10-OPENSSL-2807585
No Known Exploit

714
OS Command Injection SNYK-DEBIAN10-OPENSSL-2933515
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal

duplicated


Review/update data at MELD endpoint

Create second profile for Patricia Noelle to support Con 29 testing

Handle data duplication
Handle recurrent data

Dave will create separate files for different parts of Patricia's data; Emma can then edit data in file to add into her full profile.

Dave uploaded SDOH data for Connectathon 29 scenarios; loaded into server.


Remove version: qBittorrent.qBittorrent version 4.3.2

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/qbittorrent-4.3.2/qbittorrent_4.3.2_x64_setup.exe/download
OK
(Automated message - build 923)

Close with reason: Package still available;


Document user installation

We should explain how to setup the resources in an existing *-cd namespace to get going. It should also contain an example how to adopt Bitbucket repos.

Next to this, we also need to document admin installation (creating cluster tasks and building images)

Closed in #126. Admin installation docs are tracked in #128 now.


Update tree sitter and rust library

@harrysarson this exchanges the custom written rust package for the automatically be tree-sitter generated ones.
Could you test if this breaks anything for you?

The error seems to be due to the parser.lib, parser.exp and parser.obj somehow colliding in windows, as we try to call compile on "parser".


update to the most recent master version

This includes updates from all other groups and will remove the TeamC folder in temp. @thast , @sannatti , @prhjiajie : are you guys good if we merge this? Please archive the TeamC folder somewhere locally if you want to keep a copy.

Good for me!


CT terminology governanceDate type [CT]

The governanceDate.type relationship has a preferred name "Protocol Approval Date Type". A governance date might be applicable to a study version or a study document version now. So "protocol" is too specific.

@BSnoeijerCD @dih-cdisc @czwickl This terminology change has been completed in the 3-6-0 deliverables. This ticket can be moved to the QC column in Zenhub.

@dih-cdisc
Reviewed: Preferred term for GovernanceDate.type changed from "Protocol Approval Date Type" to "Study Governance Date Type".
This is in alignment to other preferred terms for attributes of the GovernanceDate class.
So approved and moved to Done.

@BSnoeijerCD
Should there not be a corresponding UML and API ticket?

@dih-cdisc It was a small change and only concerned the CT. No changes in attribute names or relationships were involved.


npm run dev --> SyntaxError: Unexpected token '.'

I've followed the steps in 1. Set up the project, and everything worked fine.
But executing npm run dev causes this error:
[webpack-cli] Failed to load '/home/username/webpack-monkey-test/webpack.config.js' config
[webpack-cli] /home/username/webpack-monkey-test/node_modules/webpack-monkey/lib/node/monkey.js:10
    const userDefinedRuntimeChunk = config?.optimization?.runtimeChunk;
                                           ^

SyntaxError: Unexpected token '.'
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/username/webpack-monkey-test/node_modules/webpack-monkey/lib/index.js:18:14)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

What other information do you need to debug the error?

It looks like your environment does not recognize the ?. operator, which requires Node.js > 14. Please check if your Node.js version meets the requirement.

Sorry about the late reply.
You're right, my Node.js version was very outdated.
Linux Mint 21.2 still offers version 12.22.9 via the package manager.
Upgrading to 21.5.0 with NVM fixed the problem, and now everything works perfectly!
One small thing I noticed:
When I follow your quick start guide, Tampermonkey 5.0.0 on Firefox 121.0 complains that match: ["*://example.com"] isn't a valid match pattern, because there's no path.
Changing it to match: ["*://example.com/"] fixed the problem.

Fixed the docs, thank you for reporting!


Move woqlview warning somewhere else

Move woqlview warning somewhere else so it won't show if the user import other stuff form terminusdb_client.

Implemented here: https://github.com/terminusdb/terminusdb-client-python/commit/375d137cd6ddf39016a25e93f54c4214f2643f8e


POC for WebSocket message handler.

Adds handler class WSMessageHandler and alias ws_message.
reimplements WebSocket.{send_json,receive_json}() methods so we use orjson.
Adds WSMessageRoute type - the socket connection is maintained in handle()

Updated to keep in touch with main, still a long way off being an actual implementation, but have addressed most of the initial review points.


[Bug] 0.32.0 Regression: setModelLanguage no longer works with mime types

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
const editor = monaco.editor.create(document.getElementById('container'), {
	value: "function hello() {\n\talert('Hello world!');\n}",
	language: 'plaintext'
});

monaco.editor.setModelLanguage(editor.getModel(), 'text/javascript');

Note that this works and has always worked (using mime as language):
const editor = monaco.editor.create(document.getElementById('container'), {
	value: "function hello() {\n\talert('Hello world!');\n}",
	language: 'text/javascript'
});

Actual Behavior
Language does not change / syntax not highlighted
Expected Behavior
Language changes and syntax highlighting updates
Additional Context
I've wrapped Monaco in a component and use the language prop in the monaco.editor.create call. When the language prop changes I call monaco.editor.setModelLanguage(editor.getModel(), language);. This was working until 0.32.0.
Do I need to use updateOptions? I think I went with this approach because I wasn't trusting updateOptions to only do minimal work (e.g. not create a new model just because I update the language).

Do I need to use updateOptions? I think I went with this approach because I wasn't trusting updateOptions to only do minimal work (e.g. not create a new model just because I update the language).

NVM, doesn't work either. In fact it seems like updateOptions with a mime type as language didn't even work before 0.32.0. So there's definitely an inconsistency here and something is broken. Maybe that's why I didn't use updateOptions back when I wrote this code.

I debugged the code and verified that it does not use the language id to lookup in the mime type registry.
I cannot verify the regression though.
@alexdima did something change here?

I cannot verify the regression though.

I can easily reproduce this in isolation as well, not just in my project. I followed the instructions to launch the official samples. Then I edited the browser-amd-editor to the follwing:
                        require(['vs/editor/editor.main'], function () {
                                var editor = monaco.editor.create(document.getElementById('container'), {
                                        value: ['function x() {', '\tconsole.log("Hello world!");', '}'].join('\n'),
-                                       language: 'javascript'
+                                       language: 'plaintext'
                                });
+
+                               monaco.editor.setModelLanguage(editor.getModel(), 'text/javascript');
                        });
                </script>
        </body>

There is no syntax highlighting.

Then I changed samples/package.json to
                                "file-loader": "^6.2.0",
                                "glob": "^7.2.0",
                                "html-webpack-plugin": "^5.5.0",
-                               "monaco-editor": "^0.32.1",
+                               "monaco-editor": "^0.31.1",
                                "monaco-editor-webpack-plugin": "^7.0.1",
                                "style-loader": "^3.3.1",
                                "terser-webpack-plugin": "^5.3.1",

npm i and restart npm run simpleserver

Thanks for the fix! It's great to see movement again.

I'm not sure how to verify- is there a way to run the latest code in the monaco playground?

I'm not sure how to verify- is there a way to run the latest code in the monaco playground?

Unfortunately not yet, @hediet is working on a playground that would allow that. Given this is difficult to verify, I will optimistically mark it verified until our infrastructure in the editor is better.


[AMQ-8409]  Unexpected \r instead of \r in header property in incoming messages when using STOMP 1.2

FYI-- I kicked off new test run on Jenkins

@fscrec thanks!

@mattrpav I've created a new pull request #736 for the main branch containing only three commits contained here (but from the main branch as the origin as opposed to 5.16.x I used in this PR). Should this PR be closed?

For the record, you can squash the commits in one and focus only on main branch (then we cherry pick on other branches).

@fscrec yep, I'll close this one. Thanks for the PR!


The finder page display last message text is different from LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727421902555249
Action Performed:

Open any report
Send a message with h1 tag and image tag. i.e. # Business? Personal? Now it's both. Are you here to track business expenses or personal spend? Or maybe both? Expensify lets you track it all together on a chat-based platform. Collaborate with colleagues, friends, or your accountant, and keep all your financial management needs in one app! [Try it now](https://new.expensify.com/track-expense) and see for yourself. ![1707757682096-1_ChatDM_v2_10fps_600w_256color.gif](https://s3-us-west-1.amazonaws.com/concierge-responses-expensify-com/uploads/1707757682096-1_ChatDM_v2_10fps_600w_256color.gif)
Notice the last message text in LHN
Click on the search icon in the top bar
Notice the last message text of the report in step 1

Expected Result:
In the finder page, the last message text should be the same that is displayed in LHN
Actual Result:
In the finder page, the last message text contains the HTML tag.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/d9573773-fb19-4469-8358-6d8cb55752ed
https://github.com/user-attachments/assets/5161b430-234e-4f4d-b020-41f316aa19c0

Add any screenshot/video evidence

View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
The last message text in the finder page contains the HTML tag
What is the root cause of that problem?
When we send the message like the step, lastMessageText of the report contains HTML tag and we don't convert it to text here that cause the bug happens in the finder page
https://github.com/Expensify/App/blob/4c768583e0df33b5f087a5b7f91d471a6b1b7bac/src/libs/OptionsListUtils.ts#L531-L555
This doesn't happen in LHN because we've used htmlToText here and here
What changes do you think we should make in order to solve the problem?
We should create a new variable that is the converted message of the option. lastMessageText by using the same approach that we used in SidebarUtils. Then we can use this variable to replace the option. lastMessageText.
const formattedLastMessageText = ReportUtils.formatReportLastMessageText(Parser.htmlToText(option.lastMessageText ?? ''));

https://github.com/Expensify/App/blob/4c768583e0df33b5f087a5b7f91d471a6b1b7bac/src/libs/OptionsListUtils.ts#L531-L555
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
The last message text in the finder page contains the HTML tag
What is the root cause of that problem?
When we send the message like the step, lastMessageText of the report contains HTML tag and we don't convert it to text here that cause the bug happens in the finder page
https://github.com/Expensify/App/blob/9e72084a2d46980e0f9c894654db251fb2db6ed0/src/libs/OptionsListUtils.ts#L545-L580
This doesn't happen in LHN because we've used htmlToText here and here
What changes do you think we should make in order to solve the problem?
We should create a new variable that is the converted message of the option. lastMessageText by using the same approach that we used in SidebarUtils. Then we can use this variable to replace the option. lastMessageText.
const formattedLastMessageText = ReportUtils.formatReportLastMessageText(Parser.htmlToText(option.lastMessageText ?? ''));

https://github.com/Expensify/App/blob/9e72084a2d46980e0f9c894654db251fb2db6ed0/src/libs/OptionsListUtils.ts#L545-L580
What alternative solutions did you explore? (Optional)

I can replicate but again, more of a polish here so reducing the price

@nkdengineer proposal looks good. Thank you @dukenv0307, let's move forward.

@adelekennedy Can you please update the price to 125 since the PR isn't a simple one-line change

Reopening for @dukenv0307 and @adelekennedy to complete the regression checklist

QA issue created!


fix: remove unnecessary parentheses from coloryiq warning

:tada: This PR is included in version 21.0.0-alpha.33 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 22.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Typo in C-Plus-Plus readme file in Search Section

🐛 Bug Report
The Name of The Search Algorithm Should be "Ternary Search" but it is written as "Tenary Search"
Have you read the Contributing Guidelines on Pull Requests?
Yes.

you can assign me this issue, I would be happy to fix this issue

/assign

@siddharth25pandey can you review my pull request?