fix: code comments going out of bounds

Fixes gleam.toml code comments going out of bounds on Mobile displays.
Before:

After:

Better picture of issue:

Thanks!
Could we actually put this in code blocks in general? There is a chance of long lines that are not comments in future too

It targets .hljs-comment as of now, but I can make it target .code-comment too.

fwiw, the more common way I usually see this fixed is to make the code blocks horizontally scrolling


An app update is required - failed verification

Happened to me overnight. Seems Blink changed the API (again)
**[Blink System] Error authenticating with blink API Error: Authentication problem: An app update is required((
    at Request.request.post [as _callback] (/opt/node/lib/node_modules/homebridge-blinkcameras/node_modules/node-blink-security/lib/blink.js:396:25)
    at Request.self.callback (/opt/node/lib/node_modules/homebridge-blinkcameras/node_modules/request/request.js:185:22)
    at Request.emit (events.js:198:13)
    at Request.<anonymous> (/opt/node/lib/node_modules/homebridge-blinkcameras/node_modules/request/request.js:1154:10)
    at Request.emit (events.js:198:13)
    at IncomingMessage.<anonymous> (/opt/node/lib/node_modules/homebridge-blinkcameras/node_modules/request/request.js:1076:12)
    at Object.onceWrapper (events.js:286:20)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js```

Same here I’m now getting the same error

https://github.com/MattTW/BlinkMonitorProtocol/commit/99a27109e6c06a37cd36422ebad766febaa4496a
Looks like MattTW has documented that the URL has changed?

Looks like the region information in the response to the authenentication has changed and is now:
{
    account: { ... },
    client: { ... },
    authtoken: { ... }
    region:
    {
        tier: 'prod',
        description: 'United States',
        code: 'us'
    },
    ...
}

I hacked blink.js (around line 450) to get something that works and we'll see how that goes. So far I can get the list of networks but can't get past that stage as they have probably changed too much other stuff.

Even if you can get past authentication...
https://rest-prod.immedia-semi.com/network/nnn/homescreen

Gives you an app upgrade required response.

I found some of the api source code here to be useful while hacking last night.
i think maybe the URL for getSummary() needs to drop the "/homescreen" and simply reference this.urls.network_url + networkId. But then the response parser needs to be updated as well.
Once authenticated, i had success receiving system state with
https://rest-prod.immedia-semi.com/api/v3/accounts/{blink.account_id}/homescreen
but again, the parser in getSummary() expects a different format and would need to be changed. i didn't take the time to try and rewrite the parser.

I don't own the system anymore. Will gladly make someone else a maintainer.

If I have time I can look to see if I can fix the code. I wish Blink (AKA: Amazon) would stop doing this, or at least just publish the specs because they know they are going to be easily reverse engineered anyway.

Well many hours later I have some stuff working, but I can't arm a sync module because they have changed the api endpoints again. I'm giving up for today.

Gonna take a stab at refreshing the API doc later today.  In lieu of that:
arm/disarm:  https://rest-prod.immedia-semi.com/api/v1/accounts/{accountID}/networks/{networkID}/state/arm ordisarm
Commend status URL format does not appear changed at this time.

Can confirm that that arm / disarm End-point still works.

Currently I don’t have the enable / disable of activity triggers on a camera by camera basis working but have everything else. If I can get that to work I’ll clean it up and submit a set of changes for somebody to review.

you guys are absolute legends, please let us all know once you have this fixed.

@yphoenix If you want to share a patch of your current status, perhaps others can help finalize it?

Is anyone able to confirm if this is still being worked on?

I can update what I have, it's a hack and it only half works but it is enough to turn on / off my system from HomeKit / Siri which is what I wanted.

Based on the files I changed and the ample console.log's as I debugged these are the files I changed...
homebridge-blinkcameras changes.zip

Yes, this worked! The logging is a bit out of control though. Are you also seeing all of the API responses in your HB logs?

I can update what I have, it's a hack and it only half works but it is enough to turn on / off my system from HomeKit / Siri which is what I wanted.

Can you say which "half" doesn't work? I've got your update running and not seeing any deficiencies yet, other than the logging.

Often I see the status of the system in Home as off when I know full well it is on. There was something else but I’ve forgotten what that was now. The logging is easy to turn off and I purposely didn’t indent the console.log calls to make them easy to find. Once I had something working I stopped and clean everything up and it really needed fixing correctly and I don’t have the time.

I see the first issue now. This occurred in previous versions as well. You turn it on in Home but it will show as off not too long after. Thanks again for sharing your work.

@madshall @rcoletti116 @yphoenix  Will there be PR for the current fix?

I seem to have figured out what the issue is.
First of all, you need 2FA to make it work. Seems like that's mandatory now, at least for API calls.
Second, the 2FA URL is statically set at 'rest-prod.immedia-semi.com' whereas to verify the PIN it needs to go to a region-specific URL like 'rest-u001.immedia-semi.com'. Beyond that it will also need to use the region-specific API to make this work. The region is sent in response to the initial authentication request.
If I have time this week I'll see if I can make it work and create a PR. So far I've been doing REST API calls from Insomnia to see what's what.

I've been digging deeper into this and there have been some substantial changes to the API, meaning parts of this will have to be rewritten. Certain API calls have been deprecated and others have had their response (heavily) altered, meaning anything might work or be broken.
Time permitting I'll work through the script to see what I can do. I'll be submitting pull requests for those changes that I will be able to make successfully, like 2FA, which is mandatory and now works - as long as there's a way to input the PIN.
Blink is definitely not making this easy for third-party developers.
@yphoenix I've been looking at your changes and it seems they have been made before the API changed documented here: https://github.com/MattTW/BlinkMonitorProtocol/commit/a999b0fca3b051e47823f66e63a5715b3a26da80. Listing of networks and sync modules do no longer work and this script seems to rely on them.

@madshall I've gone through the code and updated to the latest API changes thanks to the info on @MattTW page.  They are substantial as @mpkossen indicates.  Happy to share if anyone is interested.

Hi folks, ended up here after a big search on nodejs and blink, is there any plans to fork and proceed or is everyone waiting here for the merges? @djboulia did you ever get this working in your own forks? TIA


Fix order of xyzz fields in memory

Cusnark expects the ZZ field to be before the ZZZ field in memory.

It actually was a breaking change, because some places in cusnark interpret blocks of contiguous memory as points, so the order of the fields in memory does matter in some places. Niall's code assumed the ZZ field comes prior to the ZZZ field in memory.


Open market showing as expired

On the expired markets tab is a market not set to close until Feb 29 (screenshot taken on Feb 27th). Also not shown in the picture, but there are three markets listed as expired, but the page reads "1-2 of 2"

Fixed in 77dd2ed19b3d38e0d610b3756f2b2914ad1561ca.


fix tiny typo

Signed-off-by: Dan Kenigsberg<EMAIL_ADDRESS>NONE

One of the failures now is
  /root/go/src/kubevirt.io/kubevirt/tests/operator_test.go:840
    [test_id:3149]should be able to create kubevirt install with image prefix
    /root/go/src/kubevirt.io/kubevirt/tests/operator_test.go:939
------------------------------
• Failure [533.702 seconds]
Operator
/root/go/src/kubevirt.io/kubevirt/tests/operator_test.go:56
  [rfe_id:2291][crit:high][vendor:cnv-qe@redhat.com][level:component]infrastructure management
  /root/go/src/kubevirt.io/kubevirt/tests/operator_test.go:840
    [test_id:3150]should be able to update kubevirt install with custom image tag [It]
    /root/go/src/kubevirt.io/kubevirt/tests/operator_test.go:1005
     Timed out after 300.000s.
    Unexpected error:
        <*errors.errorString | 0xc00182aec0>: {
            s: "Waiting for conditions to indicate deployment (conditions: [{Type:Available Status:True LastProbeTime:2020-05-23 11:26:18 +0000 UTC LastTransitionTime:2020-05-23 11:26:18 +0000 UTC Reason:UpdateInProgress Message:Transitioning from previous version devel with registry registry:5000/kubevirt to target version devel_alt using registry registry:5000/kubevirt} {Type:Progressing Status:True LastProbeTime:2020-05-23 11:26:18 +0000 UTC LastTransitionTime:2020-05-23 11:26:18 +0000 UTC Reason:UpdateInProgress Message:Transitioning from previous version devel with registry registry:5000/kubevirt to target version devel_alt using registry registry:5000/kubevirt} {Type:Degraded Status:True LastProbeTime:2020-05-23 11:26:18 +0000 UTC LastTransitionTime:2020-05-23 11:26:18 +0000 UTC Reason:UpdateInProgress Message:Transitioning from previous version devel with registry registry:5000/kubevirt to target version devel_alt using registry registry:5000/kubevirt}])",

It is obviously unrelated to this PR, but I think that this test should be improved to give a bit more information for the reason we fail to deploy KubeVirt operator. The assertion should at least collect the status of the KubeVirt cr.

/lgtm

/approve

• Failure [122.602 seconds]
[rfe_id:273][crit:high][vendor:cnv-qe@redhat.com][level:component]VMIlifecycle
/root/go/src/kubevirt.io/kubevirt/tests/vmi_lifecycle_test.go:75
  [rfe_id:273][crit:high][vendor:cnv-qe@redhat.com][level:component]Creating a VirtualMachineInstance
  /root/go/src/kubevirt.io/kubevirt/tests/vmi_lifecycle_test.go:97
    when virt-handler is responsive
    /root/go/src/kubevirt.io/kubevirt/tests/vmi_lifecycle_test.go:491
      [test_id:1633]should indicate that a node is ready for vmis [It]
      /root/go/src/kubevirt.io/kubevirt/tests/vmi_lifecycle_test.go:492
       Timed out after 120.000s.
      Nodes should be schedulable
      Expected
          <string>: false
      to equal
          <string>: true
       /root/go/src/kubevirt.io/kubevirt/tests/vmi_lifecycle_test.go:511

I see in https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3459/pull-kubevirt-e2e-k8s-1.17/1265054010600067072/artifacts/1_nodes.log that node01 was indeed non-schedulable, but it would require a lot more digging to find out why.

[rfe_id:694][crit:medium][vendor:cnv-qe@redhat.com][level:component]Networking
/root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:50
  Multiple virtual machines connectivity using bridge binding interface
  /root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:115
    with a service matching the vmi exposed
    /root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:301
      [test_id:1547] should be able to reach the vmi based on labels specified on the vmi [It]
      /root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:321
       Expected
          <v1.PodPhase>: Failed
      to equal
          <v1.PodPhase>: Succeeded
       /root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:330
------------------------------
STEP: starting a pod which tries to reach the vmi via the defined service
STEP: waiting for the pod to report a successful connection attempt
{"component":"tests","level":"info","msg":"++ head -n 1\n+++ nc myservice.kubevirt-test-default 1500 -i 3 -w 3\nNcat: Connection timed out.\n+ x=\n+ echo ''\n+ '[' '' = 'Hello World!' ']'\n+ echo failed\n+ exit 1\n\nfailed\n","pos":"vmi_networking_test.go:71","timestamp":"2020-05-27T00:54:44.065079Z"}

I fail to find anything of value in the logs https://gcsweb.apps.ovirt.org/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3459/pull-kubevirt-e2e-k8s-1.16/1265414392770465792/artifacts/pods/ which are mostly empty. https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3459/pull-kubevirt-e2e-k8s-1.16/1265414392770465792/artifacts/1_vmis.log shows 4 seemingly-well VMs, one exposed.
https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3459/pull-kubevirt-e2e-k8s-1.16/1265414392770465792/artifacts/pods/1_kubevirt-test-default_netcatv5qbn-netcat.log indeed has Ncat: Connection timed out. but I cannot really tell why.

Relevant test results are good. Going to merge some trivial PRs alongside with some stabilization PRs for CI.


Add issue forms and pull request template

We need issue forms, bug forms and other templates to facilitate smoother workflow

Can I work on this ? @AbhijithGanesh

Feel free to, I think this issue was created for the community members. Work on this and we'll review.
Have a great day😄
@Panquesito7 and coding species, please note : I have asked Zain-Muiz to work on this.

This will help, as it will make it clearer in workflows, and how the maintainers, and others will understand each issue, as they are categorically listed, easier to navigate and sort.
Thank you for working on this @Zain-Muiz


logout doesn't work

I branched from master [2cf0d232b78ac011473b6c2b1ac63b91442f236a] and logout doesn't work.  I see that the logout code looks for 'username' in sessions but the key, i believe, should be 'userId' and the value shouldn't be the username it should be userId: user._id.toString()
Whats with the session being created on signup with the userId set to the username?

Thanks for opening an issue. Yup, this is an artifact from using the user.username instead of the user._id for session look-ups.
And it looks like this was fixed in Aqua:
https://github.com/jedireza/aqua/blob/master/server/api/signup.js#L161
Would you like to create a PR and submit the fix?

Will do [after the holiday].


[HUDI-4441] Log4j2 configuration fixes and removal of log4j1 dependencies

What is the purpose of the pull request
The repo recently upgraded to start using log4j2 instead of log4j. There are a few configuration and dependency changes that needed to happen to make sure all logging was working properly.
Brief change log
(for example:)

Used the maven enforcer plugin to ensure that the log4j dependencies are no longer being included in any of our modules or transitive dependencies since this can cause issues at runtime
Added dependency exclusions to satisfy the enforcer rules
Replaced log4j properties files with their log4j2 equivalents

Verify this pull request
This change added tests and can be verified as follows:

Validate that logging works as expected - I validated that the log levels are properly set when looking at our test outputs.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run azure


multiplexingDebugService for the web

Migrated the multiplexingDebugService to the web, for #9665
This PR gets us closer to the meatier section of the migration of the variable views. The highlight in this case is making the IJupyterDebugService optional in the multiplexingDebugService.
Feedback appreciated!

@rchiodo can do! thank you for the feedback 👍

Codecov Report

Merging #10070 (afee658) into main (e6f523d) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #10070   +/-   ##
======================================
  Coverage     64%      64%
======================================
  Files        216      216
  Lines      10060    10060
  Branches    1613     1613
======================================
+ Hits        6508     6513    +5
+ Misses      3028     3021    -7
- Partials     524      526    +2

Impacted Files
Coverage Δ

src/platform/errors/errorHandler.ts
62% <0%> (-1%)
:arrow_down:

...tform/debugger/debugLocationTrackerFactory.node.ts
96% <0%> (+3%)
:arrow_up:

...rc/platform/common/dataScienceSurveyBanner.node.ts
70% <0%> (+5%)
:arrow_up:

@IanMatthewHuff @rchiodo thank you so much for your kind and thoughtful reviews! I will polish this up on Monday. 🙏 thanks again!


added img2ascii app

requirements:
pip install pillow==7.2.0
usage:
http://<IP_ADDRESS>:8000/img2ascii/main

Resolve conflicts, and make a  decision on MIT license violation

make a decision on MIT license violation
Does everyone agree that my code is not on MIT license violation. I am not so sure, if I can use cite it like that.


Fix test failures in .teamcity

@bot-gradle test and merge

OK, I've already triggered a build for you.


Summarize statistical batteries

Description

Try out available test batteries (at least NIST STS, Diehard, Dieharder, TestU01, maybe more).
Find out the easiest way to run them ("getting the original Diehard is complicated, we will use its reimplementation in Dieharder").
Get performance estimates (how long does it take to test the data in various batteries).

Outputs

Choose one/two data sizes for data streams that will be used as a standard for testing.
Briefly summarize all test suits in crcs wiki -- how many tests, reimplementations ("Dieharder has NIST STS as subset"), data size needed for tests, performance.

Pages added at http://crcs.cz/wiki/doku.php?id=internal:research:eacirc:statistical-testing&#statistical_baterries_on_centaur

The crucial information about the individual tests is how much data do they require (this info is necessary to choose a right filesize for experiements).
Dieharder provides this information in test description, NIST STS can be configured (if I remember correctly), no idea about TestU01. Ideally create a table in the appropriate overview section.
Sidenote: Does TestU01 support running individual tests? Can this be used to determine how much data do the individual tests require (as opposed to the whole sets)?
Performance (time) estimates can wait for later, when we choose a file size.

Page with stream lengths for individual tests in batteries added at http://crcs.cz/wiki/doku.php?id=internal:research:eacirc:statistical-testing:stream-lengths


Invalid mon addr config option warning during execution of ceph-mon

Following warning is shown when ceph-mon command is run within micro-osd.sh script:
2023-03-16T10:42:00.522+0000 7f7aff4fd880 -1 WARNING: invalid 'mon addr' config option
         continuing with monmap configuration

Relevant doc: https://docs.ceph.com/en/latest/rados/configuration/mon-config-ref/#minimum-configuration


Let rfl close iffs as well as equalities

I saw this todo: https://github.com/hhu-adam/NNG4/blob/7ecd27ead91a4255ac78ee3f928f92a0ed2e2457/Game/Tactic/Rfl.lean#L24
Here is some mildly tested code to implement being able to close iffs as well as equalities. The Lean.MVarId.iffRefl function is adapted from Lean.MVarId.refl with some simplifications (for example, no need for kernel defeq checking).
/--
Close given goal using `Iff.refl`.
-/
def Lean.MVarId.iffRefl (mvarId : MVarId) : MetaM Unit := do
  mvarId.withContext do
    mvarId.checkNotAssigned `iffRefl
    let targetType ← mvarId.getType'
    let some (lhs, rhs) := Expr.app2? targetType ``Iff
      | throwTacticEx `iffRefl mvarId m!"iff expected"
    unless ← isDefEq lhs rhs do
      throwTacticEx `iffRefl mvarId
        m!"lhs{indentD lhs}\nis not definitionally equal to rhs{indentD rhs}"
    mvarId.assign (.app (mkConst ``Iff.refl) lhs)

@[tactic MyNat.rfl] def evalRfl : Tactic := fun _ =>
  liftMetaTactic fun mvarId => withReducible do
    let targetType ← mvarId.getType'
    match targetType.getAppFn with
      | .const ``Eq .. => mvarId.refl
      | .const ``Iff .. => mvarId.iffRefl
      | _ => throwTacticEx `rfl mvarId "expecting an equality or iff"
    pure []

I decided to create an issue rather than submitting a PR since I'm being lazy and didn't test this in the full environment (sorry). I was just looking at how rfl worked in NNG4 since Kevin Buzzard mentioned something about it on Zulip.

Thank you Kyle! I will have a look at this next week and incorporate your code.

Thanks again @kmill ! Finally got around to add this


requirements_update_strategy is String not Symbol

From an example stack trace
Parameter 'requirements_update_strategy': Expected type T.nilable(Symbol), got type String with value "widen_ranges"
Caller: /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:135
Definition: /home/dependabot/common/lib/dependabot/update_checkers/base.rb:61

I like this approach of leaving it as a String instead of needing to remember to turn it into a symbol!
Looks like there are some Python spec failures still?


flowchart - styling of edges via css overrides specific styles set in the graph definition

If styles are to be set via css !important needs to be applied to override style tags in the svg. This unfortunately also overrides any specific styles set in the graph definition.

I am closing issues and see this one as closed. Let me know if you feel differently!


Created the doctor's info page on the client app and created the proper route.

Code looks good, fix the className to be the convention I mentioned.
Also, although you followed the UI prototype that Sam created, I would say the green in the infobox looks very odd. We don't have green anywhere else. The UI can be adjusted after.
Plus with the teal color, it's hard to see the text "INFO".


fix(open-id-connect): do not embed polyfills with script

This results in babel-polyfill is already defined warnings and page bloat.
Instead let implementors apply polyfills as wanted/needed.
/cc @jgribonvald @mrapczynski @jonathanmtran

Thanks @ChristianMurphy this will help a lot !


permission denied when goBuild on mac

sr/local/Cellar/go/1.12/libexec #gosetup
GOPATH=/Users/mine/work/temp/go #gosetup
/usr/local/Cellar/go/1.12/libexec/bin/go list -m -json all #gosetup
error writing go.mod: open<EMAIL_ADDRESS>permission denied

I think this is related to #280


add type=button to button elements

Fixes issue #123
Add type=button to  elements

Thanks to the PRs! Just an fyi that I'll take a look and merge the PRs later this week

Thanks! Merged this one manually


⚠ WSINGRESOS - GENERICO has degraded performance

In 20fa856, WSINGRESOS - GENERICO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsGenericoPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 6191 ms

Resolved: WSINGRESOS - GENERICO performance has improved in e5b23dc.


Fix receiving and sending percentages

Something's wrong, and sometimes they go above 100%, at least in Dynamo, maybe in GH too.

After a quick chat with Dim, this is what we think is going on:

totalChildrenCount of objects does not include chunks, which is BAD
on receiving the progress report is handled incorrectly (or emitted by transports incorrectly)
(optional¿?) when receiving, for correct progress reports, one should always use the first object's total children count, not the commit's.

Linked to #260


SecurityContext of Deployment Should Be Used For Pods/Containers

Description of the feature or enhancement:
I'm not entirely sure, but shouldn't the security context of a Deployment object be used in its pods?
Use Case:
Let's say we have a Deployment object like below:
    const deployment = new Deployment(this, "deployment", {
      // some stuff here
      securityContext: {
        ensureNonRoot: false,
      },
    });

    // and
    deployment.addContainer({
      image: "foo",
      port: 8080,
    });

If you generate the manifest using the above, the pod still gets ensureNonRoot: true. Is that intended?
Currently you have to set the property to false in both places; i.e. in Deployment and Container.
Proposed Solution:
Does it make sense to use the deployment security context as a default value for its pods?
Other:
N/A

[x] :wave: I may be able to implement this feature request
[ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

👋

The problem here is that we generate a default security context for containers, regardless of whether the deployment has its own context - thus overriding it. I think its reasonable to first check if the deployment has a security context, and only set a default if it doesn't. This will allow k8s to apply the correct hierarchal context behavior.


Misc bugfixes + bump version

Fix error caused by InventorySlots somehow not calling Awake()
Fix dragging inventory items
Bunch of random Unity meta file updates
Some misc code formatting stuff
Bump version 0.3.1 -> 0.4.0

we're so back baby


Resident Dashboard > Show Helpful Links

User Story:
As a Resident, I want the ability to see the most recent helpful links on my dashboard so that I can easily see what new content has been added to the system.
Description:
This task involves creating or updating the existing dashboard component to show the 5 most recent links instead of the previous Resource Management collections and links.
Tasks:

[ ]  Create/update a Resident Dashboard component to show 5 most recent helpful links.

The component should display up to 5 most recent helpful links.
Each link shows the title and navigates the resident to the URL when they click on it.
When a resident clicks on a link their click is tracked as activity.

[ ]  If no helpful links are available, hide the component in the dashboard.

Closed by #571


Uncaught stacktrace when checking a swarm service image from AWS ECR

Received this error when checking a swarm service.
I'm investigating the cause but @DirtyCajunRice asked to report the stacktrace so it can be handled.
2019-04-10 16:52:07 : DEBUG : dockerclient : Checking tag: xxxx.dkr.ecr.us-west-2.amazonaws.com/xxxx:develop-latest
2019-04-10 16:52:07 : DEBUG : auth : Looking for auth config
2019-04-10 16:52:07 : DEBUG : auth : No auth config in memory - loading from filesystem
2019-04-10 16:52:07 : DEBUG : config : Trying paths: ['/root/.docker/config.json', '/root/.dockercfg']
2019-04-10 16:52:07 : DEBUG : config : No config file found
2019-04-10 16:52:07 : DEBUG : auth : Looking for auth entry for 'xxxx.dkr.ecr.us-west-2.amazonaws.com'
2019-04-10 16:52:07 : DEBUG : auth : No entry found
2019-04-10 16:52:07 : DEBUG : auth : No auth config found
2019-04-10 16:52:07 : DEBUG : connectionpool : http://localhost:None "POST /v1.35/images/create?tag=develop-latest&fromImage=xxxx.dkr.ecr.us-west-2.amazonaws.com%2Fxxxx HTTP/1.1" 500 146
2019-04-10 16:52:07 : ERROR : base : Job "Interval container update for unix://var/run/docker.sock (trigger: interval[0:01:00], next run at: 2019-04-10 16:53:07 UTC)" raised an exception
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job
retval = job.func(*job.args, **job.kwargs)
File "/usr/local/lib/python3.7/site-packages/pyouroboros/dockerclient.py", line 426, in update
latest_image_sha256 = get_digest(latest_image)
File "/usr/local/lib/python3.7/site-packages/pyouroboros/helpers.py", line 35, in get_digest
digest = image.attrs.get(
AttributeError: 'NoneType' object has no attribute 'attrs'

Confirming the problem was lack of auth details causing the POST to the docker API to return 500 rather than image details.
So I think this ticket is to catch the 500 and/or the null image before trying to check its attributes.

Interesting... it shouldnt even get that far with a 500. Ill look into it when i get a chance. Good find.


对qwen2-72b-instruct-awq进行qlora微调之后，如何进行merge?

Describe the bug
What the bug is, and how to reproduce, better with screenshots(描述bug以及复现过程，最好有截图)
微调qwen2-72b-instruct-awq之后，使用命令merge lora信息，报错：
命令：
swift export --ckpt_dir 'checkpoint-1168' --merge_lora true

报错信息：

AssertionError: qwen2-72b-instruct-awq is a quantized model and does not support merge-lora.

Your hardware and system info
Write your system info like CUDA version/system/GPU/torch version here(在这里给出硬件信息和系统信息，如CUDA版本，系统，GPU型号和torch版本等)
os: ubuntu 16.04
cuda: 12.1
torch: 2.1.2
Additional context
Add any other context about the problem here(在这里补充其他信息)

The quantized model's qlora fine-tuning version cannot be merged and will result in significant accuracy errors. It is recommended to train the original model using lora first, then merge-lora before quantization.
To save GPU memory during training, you can use zero3 or zero3-offload.

The quantized model's qlora fine-tuning version cannot be merged and will result in significant accuracy errors. It is recommended to train the original model using lora first, then merge-lora before quantization.
To save GPU memory during training, you can use zero3 or zero3-offload.

Thanks a lot

Does it mean that we can't finetune using qlora?


incompatibility with identity

it crashes on start

Correct, both mods modify the shadow offset. Not fixable without the cooperation of Identity.

Also duplicate of #353


Fix rounding issue in OUSD redeemAll unit test

To get the unit test passing, the last assertion in the redeemAll unit tests has been commented out. This issue is to get to the bottom of the following error.
  1) Vault Redeem
       Should have redeemAll result in zero balance:

      AssertionError: Expected "1" to be equal 0
      + expected - actual

       {
      -  "_hex": "0x00"
      +  "_hex": "0x01"
         "_isBigNumber": true
       }

      at Proxy.<anonymous> (test/helpers.js:56:28)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at runNextTicks (node:internal/process/task_queues:64:3)
      at listOnTimeout (node:internal/timers:538:9)
      at processTimers (node:internal/timers:512:7)
      at Context.<anonymous> (test/vault/redeem.js:431:5)

This is happing as a result of the resolution change in test cases.
This probably means that it's happening live as well.


Update instructions because RawGit is EOL

The instructions for this project need to be updated to use another CDN in front of GitHub. From the RawGit web site:

October 8, 2018
RawGit is now in a sunset phase and will soon shut down. It's been a fun five years, but all things must end.
GitHub repositories that served content through RawGit within the last month will continue to be served until at least October of 2019. URLs for other repositories are no longer being served.
If you're currently using RawGit, please stop using it as soon as you can.

Of the choices suggested on the RawGir page, jsDelivr seems to work for this purpose. It has a  migration applet that can help update references to use jsDelivr URLs instead of RawGit.
E.g<EMAIL_ADDRESS>

Thanks for catching this up.
This may even require a warning in the home README that it changed.


Since 3.2.41, devtools spends a lot of time in cleanupBuffer during component unmounts

Vue version
3.2.45
Link to minimal reproduction
https://sfc.vuejs.org/#eNp9UstugzAQ/JWtL02kgJM+LhGJqPoJvfqSgClugm3ZC6mE+PeucUtJKvUEOzM7Y4/csxdr066VbMsyXzhlEbzE1u6FVo01DqGHTjqvjF6BkxUMUDnTwD3t3E+aV0NfLTV+kymfkGBOwsJoj6D8W20usAtOC3StXAqd8ZhLiTSgbOz5gJImgKze7Gk976czwDBknNCRPbaIBOXFWRWnnWCLyf4u/i0F2/uLwqLOeBTHxZ8Q6BJV0WJUkziwxP9ep0sq44JCl/ITlIbNer0WDHg04rPjzga2YrGYpDnY9MMbTfX2YYOcRsILtoURCRjdMcyC1YjWbzlvtT29p4VpeE4cd61G1cikNE3+mD6kT8+8VB7neCp9kxyduXjpKFGw1cycE0gFJk7SNZx0/4bdaK8Cb7g/oSFzEHqgAq4eQHhds6oEZqXqxgoFXgljq5GcFzp8AVvZ64o=
Steps to reproduce

Click the switch button to uninstall the components on the page
Compare version 3.2.40 and version 3.2.45

What is expected?
Component uninstallation time is consistent with the performance of version 3.2.40
What is actually happening?
There is a significant time difference between version 3.2.45 and version 3.2.40 when components are unmount
System Info
No response
Any additional comments?
No response

For me the slowdown happened when going from 3.2.37 and 3.2.38 but feels like it is the same as this issue...
The difference in my case is going from 100ms page update to 70s page update, thus changing developer experience to complete rubbish.
https://profiler.firefox.com/public/jw0yrsbxf8zccyf5qgapyp01h9smh0ztfnkd0g0/flame-graph/?globalTrackOrder=01&implementation=js&thread=1&v=8

This problem bothered me for a long time, and I eventually found that downgrading the vue version to 3.2.40 improved it, but it was not a good solution.

Any chance of a beta release soon?

@LinusBorg @Akryum is there any progress about this issue? Devtools are not usable due to this bug, the performance slowdown is to much to handle any development (nuxt 3).

In m understanding this issue was solved (and this this issue closed) with devtools 6.5.
Are you on that version?
I personally saw good performance aftrr updating to 6.5

I was on 6.5, however after your comment I disabled Performance monitoring and Update tracking in settings.
I can observe performance upgrade, however it's still not the DX I remember while developing on Vue 2.
But disabling these options helped a lot and it seems that it can be finally usable.
Issue is still open so I assumed it wasn't implemented.

I'll close this for now, but we will keep an eye on general performance anyway going forward. This particual area has been made more performant so we will need to look into other things from here on out.


Output repository URLs for easy adding of remotes

Currently, the script (only) creates remote repositories, but the user still has to type in the URLs of these repos to add them as remotes.
To make the user's life easier, the script should print the URLs to the console (in both SSH and HTTPS format for now; in a next step, the user could possibly define a preferred URL format and then have the script only print out URLs using this format).

This can relatively easily be done for GitHub and Bitbucket but not for GitLab, as the GitLab user name isn't stored in the .gitlab credentials file.

Turned out to not be that easy after all - required quite a bit more bash scripting than initially thought. Done, anyway.


Can we integrate client side with Angular ?

Hi @mikuso,
We are working with the integration of ocpp in our project.
My question is can we use client side with angular using webSocket ?
Thanks.

Sorry, this module is not suitable for browsers.
I don't believe there is currently a compelling use-case for writing this module to work with browsers (aside from performing some superficial testing).
Here are a few reasons why a browser implementation wouldn't be very good:

Browser websockets cannot use HTTP auth or custom client-side certificates, so is not compatible with any OCPP security profile.
Browser websockets cannot send any custom headers with their opening handshake.
CORS prevents using browser websockets with non-cooperating OCPP servers.
Browser websockets give no control over pings/pongs (unable to listen for, or set their frequency).
A server implementation is impossible.

Instead, I would recommend you to implement your OCPP client in Node.js and then use something like socket.io to communicate between your angular app and the OCPP client.


drop jsonp support?

Either document that we dropped jsonp support (and remove the remaining code) or implement it fully again after the dropwizardification.

In favor of dropping it from this code, and if we really really want to keep it on the production API, somehow implement it "from outside".

Yes, let's remove it.


Wrong example code

Instead of
const { parser } = require('.')

it should be
const { parser } = require('@exodus/schemasafe')

Good catch; PR welcome.


Wondering how to launch this map

Hey, my friends and I were trying to find the slayers trading map to look back at the good times, how exactly do I open this in csgo?

Hey there!
The easiest way for you to use these is to open the files individually and click "Download", here:

https://github.com/isaac-underwood/csgo-maps/blob/master/trade-maps/trade_slayers_v12a.bsp
https://github.com/isaac-underwood/csgo-maps/blob/master/trade-maps/trade_slayers_v12a.nav

Once you have downloaded them, move/copy them to the PATH_TO_WHERE_YOU_INSTALLED_CSGO\Counter-Strike Global Offensive\csgo\maps folder, here you should see a bunch of other maps that also have the .bsp and .nav versions.
If you don't know how to load it, once in game, from memory I believe you just start a custom game and then in console type map trade_slayers_v12a and it should load the map.
I haven't run this map in a couple of years so I'm unsure if all of the textures are still there. Let me know! Have fun!


⚠ ClamAV has degraded performance

In 45c3042, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 535 ms

Resolved: ClamAV performance has improved in e62daf1.


🐛 Memory leak on batch insert

No duplicates 🥲.

[X] I have searched for a similar issue in our bug tracker and didn't find any solutions.

Database
MySQL
What happened?
I use DatabaseInterface::execute to batch insert. I detect a huge memory leak if queryCache: true.
The problem is that the number of VALUES may differ, and each time the request is cached.
I create demo-project with demo of issue: https://github.com/gam6itko/spiral-app-sandbox/blob/cb97213a8c12f7e98ae4186d3e90f2d8b2b09bea/src/app/app/src/Command/CycleMemoryLeakCommand.php#L49

Version
database 2.5.2
PHP 8.1

Now it is available to disable driver query cache before any request.
We are thinking about automatic disabling cache in batch insert case but I'm not sure that it will be implemented.

We decided not to add heuristics to the execute method. Therefore, simply use the $driver->withoutCache() method before executing queries that do not need to be cached.


Support for Minimal UI with other modules

Please list any modules that need support:

Unnoficial Card Support
Quick Insert
Search Anywhere
Simple Dice Roller
Combat Carousel

Calendar/Weather (not incompatible but maybe there is a way to hide it as well, maybe binding it to the left sidebar or something)
Custom Hotbar (this is very important for me)

Ernie's Modern UI

Ernie's Modern UI

That will be a tough one :) Compatibility across UI modules can be quite painful. Going to give it a chance though. Thanks

[ ] Monks Scene Navigation or Navigation Presets (whatever is easier to do) compatibility would be great. =)

The Monster Blocks module (https://foundryvtt.com/packages/monsterblock) doesn't work correctly with the minimize functionality. It doesn't minimize correctly (the title bar is twice as high sort of), and it doesn't restore properly.

Thanks @plutoneld glad that you found some interest in the minimize functionality! will check out that module

The Monster Blocks module (https://foundryvtt.com/packages/monsterblock) doesn't work correctly with the minimize functionality. It doesn't minimize correctly (the title bar is twice as high sort of), and it doesn't restore properly.

This fix is fixed as part of the next release :D

Tidy UI game settings.
Not sure if the issue is in that module or this one.
With Tidy UI turned on, I could not have the left icons saved as "Always visible". when I saved changes, it still went into auto hide mode.

Tidy UI game settings.
Not sure if the issue is in that module or this one.
With Tidy UI turned on, I could not have the left icons saved as "Always visible". when I saved changes, it still went into auto hide mode.

Thanks @Mushie1 ! I really love that module, and it should work fine and actually encouraged.
I cannot however reproduce the issue you mention.
Here on my side it works fine:

Could you please discard any other issues and make sure you are on Minimal UI 0.8.8?

Just updated to 0.8.8 and I could not reproduce the bug.  So all good, thanks for the quick response!!


Downloaded .yes files no longer work

Some files that QuickBible used to accept now only show "No" or "Delete" as options after the latest update.
What happened? How do we fix?

Wait, I found the problem.
If the .yes files are stored on internal storage, then "show internal storage" needs to be enabled before re-adding the .yes files on the new version of Quickbible.
Since there is an easy fix, I'll close this issue. Such a change could have used documentation though.


How to import a stub package in a Nuxt project?

Hi! I encountered an issue when trying to import a workspace package (built by unbuild stub mode) in my Nuxt project during development.
The error occurs in devtools:
The requested module '/_nuxt/@fs/xxxxxx/node_modules/.pnpm/jiti@2.4.0/node_modules/jiti/dist/jiti.cjs?import&v=87bf46ed' does not provide an export named 'default' (at jiti.mjs?v=87bf46ed:2:8)
Environment:
Nuxt 3
unbuild for workspace package
jiti 2.4.0
pnpm workspace
If you have time, could you please take a look at my project: https://github.com/jojotechs/grey-parrot-i18n/blob/c4ee88da28f383f0fde70a6b1669e9b215e56e15/packages/dashboard/package.json#L17
Is this a known issue with jiti's ESM interop? Any suggestions would be appreciated.
URLs
No response
Additional information

[ ] Would you be willing to help?

normally "runtime" output (such as vue components) should be built in mkdist mode, in this mode, stub is identical to source tree and jiti is not involved.
If you still have issues, I suggest to raise a question in nuxt module builder repo since it is more specific to there.


Update Developer Guide documentation

Codecov Report

Merging #97 (9db7a1c) into master (aac1385) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #97   +/-   ##
=========================================
  Coverage     68.44%   68.44%
  Complexity      444      444
=========================================
  Files            79       79
  Lines          1423     1423
  Branches        151      151
=========================================
  Hits            974      974
  Misses          411      411
  Partials         38       38

Impacted Files
Coverage Δ

...eedu/address/logic/parser/FilterCommandParser.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix file truncation on Windows with bash

When a file is opened with FILE_OPEN_IF with Dokan and the file
exists it should be returned, but additionally ErrObjectNameCollision
should be returned.
Fixes KBFS-2812 and Fixes #1494
This ended up requiring quite a lot of restructuring code since
we need to pass up whether a file was created or an existing
one is returned. Doing this on all the return sites would have
been even more messy.

Addressed review, rebased to master for CI-passing and handle also FileSupersede and FileOverwriteIf similarly.


Guice Binder hasBind functionality

I tried to get some feedback from stackoverflow, maybe I get some here.
http://stackoverflow.com/questions/37092065/guice-binder-hasbind-functionality
Is there any way to check if an implementation exists for an interface?
For example, the method "hasBind" below does not exist:
public class MyModule extends AbstractModule {
    @Override
    protected void configure() {
        // do something like this:
        if (!hasBind(SomeInterface.class)) {
            bind(SomeInterface.class).to(MyOtherSomeInterface.class);
        }
    }
}

Thanks!

There's no way to do this while configuring, because the binding may be added after this method finished and another module is installed.  You could theoretically use the SPI and process the elements of every module before passing them off to the injector, though.


fix(behavior_path_planner): reset candidate uuid when activated

Description
Sometimes, the rtc status which is already activated is removed by removeCandidateRTCStatus()
I fixed it.
https://user-images.githubusercontent.com/59680180/186399892-d9af6e3b-9d77-4e5f-8423-40f68b19b68d.mp4

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

How do you think?
it's good!
I followed it.


Possible to keep data updated and continuously update the figures?

Is it possible to produce daily reports using this model to show how estimates of post-intervention transmission and total percentage of population vary with data up to a certain day, and to update the data to be current?
I see many people citing the percent infected as of March 28 and post-intervention R figures, so I think there's a value in making sure the estimates are informed by the most recent data, and seeing how the estimates change as new data is added.

This is being implemented using a CI pipeline via GitHub pages. Expected deployment of v1 is within hours.

Awesome -- thanks!

@zach-hensel slight delay in the deployment - within days now

We have deployed a website now lol at #v2.0


Support defining ClusterLogForwarding filter list as an object

I need to define logforwarding filters in multiple places in the hierarchy, and so would like to have a nice easily-mergeable dict instead of the list - similar to how we define the pipelines, inputs and outputs as well.
I built this feature in a backwards-compatible way - if filters are already defined as a list, they are kept as-is.
Of course, it is only possible to use either lists or objects within the entire hieararchy of a single cluster - if they are mixed, reclass will fail. Still, this allows us to migrate "legacy" filter lists as we find them.
Alternatively, I could change the implementation to be analogous to the other fields where we perform this kind of processing. Then we would have to update all existing filter definitions in our hierarchy, as it'd be a breaking change. I only know of the filters for loki central audit logging; I don't know in how many other places this is used.
Checklist

[x] The PR has a meaningful title. It will be used to auto-generate the
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
[x] PR contains a single logical change (to build a better changelog).
[ ] Update the documentation.
[x] Categorize the PR by adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.

Documentation is TBD. I would like to hear your opinions on whether this is preferable or whether it's better to go with the breaking change.

Some other components use filters: [] + map(_filters: {}) which I personally think is the way to go.
I don't know tho if that fits the component here.


Log errors or exceptions into .keep file

In order to effectively manage a web server, it is necessary to get feedback about the activity and performance of the server as well as any problems that may be occuring

Please review our contribution guidelines and follow them before reopening your PR.
A few issues here off the top off my head:

Tests don't pass
Your PR mixes 3 different things and there's no explanation as to what you're trying to change
Deleted the PR template instead of filling it in
Not sure the changes themselves make sense. Adding French is cool but 1. it breaks our tests and 2. it's only the demo app so it doesn't really add anything useful.


ROX-16935: Make PolicyConfigurationTest multi-arch compliant

This PR intends to fix failures on P/Z with PolicyConfigurationTest. Changes in the test would make it multi-arch compliant.
Changes are verified manually using ./gradlew test --tests=TestName
This PR intends to fix ROX-16935

/test ocp-4-10-qa-e2e-tests
/test ocp-4-12-qa-e2e-tests

/test gke-qa-e2e-tests
/test ocp-4-12-qa-e2e-tests

/test ocp-4-10-qa-e2e-tests
/test ocp-4-12-qa-e2e-tests

/test ocp-4-10-qa-e2e-tests
/test ocp-4-12-qa-e2e-tests

/test ocp-4-10-qa-e2e-tests

/test ocp-4-10-qa-e2e-tests

/test ocp-4-13-qa-e2e-tests

/test ocp-4-10-qa-e2e-tests
/test ocp-4-13-qa-e2e-tests

@gavin-stackrox  @robbycochran kindly review this PR

thanks @gavin-stackrox.
merging since all tests are passing.


Sync code with a running instance?

floyd run starts a new instance every time. Is it possible to sync code without starting a new instance?

Hi, we have this feature in our product roadmap! Also, you can use FloydHub Forum to post new feature requests.
Since this is not an issue with the cli itself, I'll close this for now.


Updated for minitest current version

Minitest::Test

I'm closing out old PRs as part of #283 . I'm sorry I was never able to help get this to a point to be merged.


French translation

I use a R36S and RG10Max and i see the French translation is not finish yet, here my trad but some word can't change in the console... maybe u can fix it...
emulationstation2 fr par Chronoss.zip

Use this for translation: https://github.com/christianhaitian/arkos/issues/1011#issuecomment-2032672947

Ok thanks, i will work on it !!!

Other question, in the release page, wich file i need for R36S update ?

Hi !!!
Can u explan this line : 216 msgid "A,AN,THE"

ah ok, so i need to repeat samething for french langage ?

Correct

ok thanks !!!

Lign 544 and 560 are samething, not a mistake ?

Hi Christian, @chronoss09,
A better example maybe:
For the game "The Great Giana Sisters" on Amiga - Users search for G for 'Great', not T for 'The'. The idea is to ignore those articles when sorting.
By the way, Christian are you sure articles are translatable ?
Because that means you should also have all the game names translated, which may not be common.
Maybe French articles should be appended to the existing English ones, in case some game gets translated.

"GOVERNOR" refers to CPU Performance Governor, which I believe tries to find a balance between power saving and performance on demanding titles.

"GOVERNOR" refers to CPU Performance Governor, which I believe tries to find a balance between power saving and performance on demanding titles.

So, i mean "Puissance" is the best thing instead of "GOUVERNEUR" in French !!!

Meaning 'CPU Frequency Scaling' .... maybe you can find a translation inspired in 'Auto CPU Performance'

Yeah, i think it's more better...

Only menu items are translated with this, not game names.

@christianhaitian
Here is the French trad. I have add more lines that missing in your official file, it begins at 1315 but other don't work. maybe u can do something... I put a note on ones that don't work...
emulationstation2 fr par Chronoss.zip

How to use your update file on R36S console for exemple ?

Until it comes as part of the next update, you can manually load that file to /usr/bin/emulationstation/resources/locale/fr/ in the OS via ssh.

Until it comes as part of the next update, you can manually load that file to /usr/bin/emulationstation/resources/locale/fr/ in the OS via ssh.

I talk about your update file on this github "arkosupdate07042024.zip", it's the last file you have released...

Oh that may not work for the R36S since I don't support the R36S units.  The updates are meant to be applied over the air.  If you're using the AeolusUX fork of ArkOS, just wait for the update there.

Oh that may not work for the R36S since I don't support the R36S units. The updates are meant to be applied over the air. If you're using the AeolusUX fork of ArkOS, just wait for the update there.

ok i see, thanks !!!
have u fixe line that not work ?

This has been accommodated with today's update.

This has been accommodated with today's update.

There is new line on new file ?
On last Arkos update, i see new line on setting like :

File Extention and more...


Add a help extensions for setting up OIDC with Cookie sign in

To setup OIDC with cookie sign in you have to do three things: 1. add OIDC, 2. add Cookies, 3. configure default auth schemes. We should add an help extension that does these three things for you.
Currently we have this code in the template that we should replace with an API in the framework:
        public static IServiceCollection AddWebApplicationAuthentication(this IServiceCollection services)
        {
            services.AddAuthentication(sharedOptions =>
            {
                sharedOptions.DefaultSignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
                sharedOptions.DefaultAuthenticateScheme = CookieAuthenticationDefaults.AuthenticationScheme;
                sharedOptions.DefaultChallengeScheme = OpenIdConnectDefaults.AuthenticationScheme;
            });

            services.AddOpenIdConnectAuthentication();
            services.AddCookieAuthentication();
            return services;
        }

Alternative names: AddOpenIdConnectWithCookies, AddOpenIdConnectWithCookieSignIn, AddDefaultOpenIdConnectAuthentication, ...

Doesn't sound like a good idea to me.
If you do that for OIDC, people will want the same thing for all the OAuth1/OAuth2 providers (Facebook, Google, Twitter, MS Account, etc.) and you'll end up with multiple extensions that all update the shared authentication options and replace the schemes set by the previous calls, which won't have the result you expect.

Well the better way to think of this is probably more like AddIdentity which does a lot of opinionated auth setup as well that you have to override if you don't like.  i.e. Identity sets the DefaultSIgnInScheme to its External cookies scheme.  Its an extension for the templates to use, where we don't have that with the other Oauth providers.
That said, Identity is being refactored a bit into Microsoft.Extensions + Microsoft.AspNet, so there will likely end up with AddIdentityCore() [non auth], with AddIdentity calling AddIdentityCore + configuring auth similar to what this method is doing.

In terms of naming, I think something like AddDefault[Something]Authentication is good since the default will help signal that its opinionated.

Well the better way to think of this is probably more like AddIdentity which does a lot of opinionated auth setup as well that you have to override if you don't like. i.e. Identity sets the DefaultSIgnInScheme to its External cookies scheme.

I'm not sure adding more magical stuff is the right answer. The fact Identity does this in a totally non-obvious way is already problematic. Since you can't combine 2 automatic handlers, people will have to find how they can combine cookies + bearer authentication in their applications. If they have to override the default schemes in multiple places, it will be a total mess.

Sure, this isn't solving that problem (shared options being used), this is just the equivalent/replacement for AddIdentity's auth logic for the new templates that aren't using AddIdentity to setup auth.
We can certainly revisit that if you have any specific ideas for improvement to include in Auth 2.0 for this, but there's only a single default authenticate (automatic) scheme in 2.0 now, last one wins in terms of setting that.

Also specifically for "combine cookies + bearer authentication". shared options and defaults can pick either cookies or bearer, but in reality those apps should fully specify the schemes so there's no magic or confusion.

Sure, this isn't solving that problem (shared options being used)

True, it just makes the situation worse :smile:

We can certainly revisit things if you have any specific ideas for improvement to include in Auth 2.0 for this

A possible approach would be to stop relying on automatic authentication in the templates and make that something devs would have to explicit enable by registering themselves the right schemes in the shared options. At least, it would make the "am I using cookies or bearer authentication when I register both?" answer way more obvious.

How much of this is an attempt to squash template/sample code? How often do developers actually write this vs have it handed to them?

I think Cookies, JWT Bearer and OIDC are special in that they are the three most common active authentication schemes. We wouldn't provide extensions that set the default schemes for things like social logins.

How often do developers actually write this vs have it handed to them?

In all the projects I consult on, I'm configuring all this stuff manually so they can see what's what. Perhaps I'm in the minority, and they might not know what all the little settings do, but they see that there are all these settings so they know it's all in front of them and they see what properties they might need to go read up on.

We should add a new AddOpenIdConnectCookieAuthentication method, but we need to figure out where it can go.
The purpose of this API it to have a scenario-focused helper API. It's higher-level than the low-level "atom" methods that are needed by more complex scenarios.

We should add a new AddOpenIdConnectCookieAuthentication method, but we need to figure out where it can go.

Not in the core packages, please.

The purpose of this API it to have a scenario-focused helper API. It's higher-level than the low-level "atom" methods that are needed by more complex scenarios.

It's so "scenario-focused" that it can't be used to configure an OIDC provider as an external provider in an app using ASP.NET Core Identity (it will spawn an additional cookies handler instead of using the external cookies handler configured by Identity). Yet, it's an extremely frequent scenario, and not low-level at all.

@PinpointTownes do you have some thoughts on what would be a useful scenario-focused helper, but wouldn't be too restrictive? It's always a challenge to balance out the two. I think for a lot of developers having a nicely-named method that "does exactly what I want" is very useful. And, I also agree that we want to make sure it isn't a "pit of failure" where the moment you want to do something even slightly more advanced, you have to go down a completely different path.

@Eilon I don't believe adding generic helpers is the right answer to this problem, because there's really no "unique way" to use OIDC in ASP.NET Core. Adding new extensions would also make the situation more confusing than it is already (most people have no idea if/when/how they should use app.UseJwtBearerAuthentication() or app.UseOpenIdConnectAuthentication()).
IMHO, it would be much better to concentrate the effort on documentation and explain how things work in the different scenarios (do you want to treat your OIDC as the single source of truth or just like any other social provider? Do you use Identity or the cookies middleware as-is?).

per discussing @danroth27 we will keep this in the template code

Let's discuss with the B2C and Org auth stuff next week.

We decided not to do this.


Test_profile sometimes fails

Periodically I see Test_profile_func fail because Foo1() and Foo2() both have zero run time, so they sort in a different order than expected:
	Found errors in Test_profile_func():
	function RunTheTest[40]..Test_profile_func line 69: Pattern '^\\s*1\\s\\+\\d\\+\\.\\d\\+\\s\\+Foo2()$' does not match '    2   0.000000             Foo1()'
	function RunTheTest[40]..Test_profile_func line 70: Pattern '^\\s*2\\s\\+\\d\\+\\.\\d\\+\\s\\+Foo1()$' does not match '    1   0.000000             Foo2()'
	function RunTheTest[40]..Test_profile_func line 74: Pattern '^\\s*1\\s\\+\\d\\+\\.\\d\\+\\s\\+Foo2()$' does not match '    2              0.000000  Foo1()'
	function RunTheTest[40]..Test_profile_func line 75: Pattern '^\\s*2\\s\\+\\d\\+\\.\\d\\+\\s\\+Foo1()$' does not match '    1              0.000000  Foo2()'

any idea why both would have a zero runtime? I could imagine this for Foo1(), but Foo2() does something so it shouldn't have a zero runtime.

If it still fails, please try increasing the sleep time until it passes.


/buy command interferes with other commands.

We have a command known as /buyfeature
The buycraft /buy command intereferes with that.
/buy123
/buyfeature
etc.... all goes directly to /buy
This should not be the case.

Was already fixed in 8ecdfff but we need to do a re-release
@LeeMcNeil

I'm on build 47
http://ci.ecocitycraft.com/job/BuycraftX/
So fixed in 48?

Yes

On Jun 13, 2016, at 10:57 PM, Andrewkm<EMAIL_ADDRESS>wrote:
I'm on build 47
http://ci.ecocitycraft.com/job/BuycraftX/ http://ci.ecocitycraft.com/job/BuycraftX/
So fixed in 48?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/BuycraftPlugin/BuycraftX/issues/58#issuecomment-225767010, or mute the thread https://github.com/notifications/unsubscribe/AA7z9KqGIO8Wv5UGTTmr1y3Vgwcg3yqNks5qLhh_gaJpZM4I02kk.


Unexpected token with webpack after upgrade to 2.0.0

I have a project with a mostly working refresh setup using prefesh and webpack and hooks, and a test upgrade to the last version no longer functions. Instead throws a parse error during build.
Changes made
In package.json:
-    "@prefresh/webpack": "^1.0.2",
+    "@prefresh/babel-plugin": "^0.2.0",
+    "@prefresh/webpack": "^2.0.0",
...
-    "react-refresh": "^0.8.3",

In babel.config.js:
...
   const plugins = [
     '@babel/plugin-proposal-nullish-coalescing-operator',
     '@babel/plugin-proposal-optional-chaining',
     '@babel/plugin-transform-react-jsx',
     ['@babel/plugin-transform-runtime', {useESModules: true}],
   ];
-  if (api.env('development-watch')) {
+  if (api.env('development')) {
     /* Add plugin for @prefresh/webpack hook support */
-    plugins.push('react-refresh/babel');
+    plugins.push('@prefresh/babel-plugin');
   }
  const presets = [
    '@babel/preset-env',
    ['@babel/preset-typescript', {
      'allExtensions': true,
      'isTSX': true,
    }],
  ];
...

(note the env change is to stop the complaint about "React Refresh Babel transform should only be enabled in development environment." which should probably say "Preact Refresh Babel)
No meaningful changes to webpack.config.babel.js but does have some other plugins as well as new PreactRefreshPlugin().
Error message
  ERROR in ./src/context/assets.tsx 37:10
  Module parse failed: Unexpected token (37:10)
  File was processed with these loaders:
   *<EMAIL_ADDRESS>   * ./node_modules/babel-loader/lib/index.js
  You may need an additional loader to handle the result of these loaders.
  | }
  | export const AssetsContext = Object.assign(createContext._16jwu9b$AssetsContext || (createContext._16jwu9b$AssetsContext = createContext(), {
  >   __: ({} as Assets)
  | }));
  |
   @ ./src/modeledit/mapeditor/core.js 11:0-74 332:31-50 345:7-20
   @ ./src/modeledit/app.js
   @ ./src/entry/oldedit.js
   @ multi<EMAIL_ADDRESS>./src/entry/oldedit.js

Might be the tsx, or the context, or something else that's causing the unhappiness?

Could you show the original code? This seems like an issue in the transform

Looks like this reduced version fails:
import {createContext} from 'preact';

export interface Assets {}

export function assetsFromModelData(mapData: unknown): Assets {
  return {};
}

export const AssetsContext = createContext({} as Assets);

And this does not:
import {createContext} from 'preact';

export interface Assets {}

export function assetsFromModelData(mapData: unknown): Assets {
  return {};
}

export const AssetsContext = createContext({});

@bz2 Got a fix lined up for you

@JoviDeCroock Thanks for having a look! I tried hacking you change in locally, which got babel through compiling but then lead to a complaint from createElement() at runtime, so will have another try with your final version. It would be fine to run all this with any tsnodes ignored wholesale I suspect.

Found another potential bug so I'll be releasing 0.2.2 in a bit

Yup, unfortunately looks like I reduced the real code down a bit to far, the actual line is:
export const AssetsContext = createContext<Assets>({} as Assets);

So, the AST also has a TSTypeParameterInstantiation node at higher up, which still upsets things, just at runtime somehow.

Looks like it should be sensible to leverage @babel/helper-skip-transparent-expression-wrappers as the code added in https://github.com/babel/babel/pull/11404 looks similar to yours, but may not be easy to adjust?

It doesn't seem to give me any exceptions since these are stripped out by @babel/typescript normally. Tried in my own example and no issues.

I may be wrong on the cause, will make a proper standalone reproduction.

@JoviDeCroock I can confirm that 0.2.2 works for me.

@bz2 Awesome, very glad to hear that!


The "choose file' buttons is unresponsive

Describe the bug
When clicking the "Choose File" button, nothing happens.
To Reproduce
Steps to reproduce the behaviour:
Go to contractors admin.
Click ‘App Settings’ in the sidebar navigation menu.
Scroll down to 'Graphics'
Click on "Choose file" button
Button does not respond.
Expected behaviour
After clicking the "Choose File" button, page will appear and the user can choose documents or files that he/she can upload.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: MacOS
Browser Safari
Version 17.1
Smartphone (please complete the following information):
Device: iPhone 14
OS: iOS1
Browser Safari
Version 17.1

Working on it @loriemangubat.
Will provide you the update soon.


Error 404 when I try create a new field.

I trying to create a new computed field, but the page throw the error 404 "the page doesn't exist".
My redmine version is this:
Environment:
Redmine version                3.0.4.stable
Ruby version                   2.1.4-p265 (2014-10-27) [x86_64-linux]
Rails version                  4.2.3
Environment                    production
Database adapter               Mysql2
SCM:
Git                            2.7.4
Filesystem
Redmine plugins:
computed_custom_field          1.0.6
redmine_bootstrap_kit          0.2-devel
redmine_git_hosting            1.1.1
I don't know how fix that error, i need this plugins because is very usefull for the implementation in my company.
Can you help me, please?

Hi! I fixed it!
It was my fault, because I didn't renamed the clone of git to “computed custom_field”.
But now, I need this:
A "TOTAL COST" field in the root project that sums the total cost (of float value) of subprojects hanging from it first, if any, and the cost of the activities and / or requests. Could it be done?
I am looking forward to your response.

Hi. Maybe this will help you #27


fixed layout of page 2 #136

Closes #136

[ ] wider margins
[ ] wider quiz display
[ ] larger space between boxes
[ ] consistent border on boxes

looks good


Moves all the phone number test stubs in ManageControllerTests to new class and implements them

Ref issue #1736
I have created a new ManageControllerPhoneNumberTests class and moved all the phone number test stubs from ManageControllerTests to that new class. Then all tests have been implemented.

Thanks @DavidArno for all this work. It's a big help.
This looks great.  :shipit:


Incomplete README.MD Instructions

The Readme is Incomplete and missies the instruction on how to setup the project on your local machine,
Also the contributing Instructions are missing, along with the necessary information

Assigned @AskitEndo

I would like to work on this project. Please assign it to me


Project mutation guard is necessary during maven publication

@ghale commented on Thu Sep 27 2018
We have a place in maven publication where we step across to other projects and grab the classifier of the artifacts of that project.  Doing so can cause the the underlying task object to be realized at execution time (i.e. this is project mutation).  We need to wrap the project mutation guard around this access.

Doing so can cause the the underlying task object to be realized at execution time

This also seems like a problem that needs to be addressed.

Here's what the operation trace says:
    Task :baseServicesGroovy:install {"taskPath":":baseServicesGroovy:install","taskClass":"org.gradle.api.tasks.Upload","taskId":76250,"buildPath":":"} {"cachingDisabledReasonCategory":"NOT_ENABLED_FOR_TASK","actionable":true,"originExecutionTime":null,"upToDateMessages":["Task has not declared any outputs despite executing actions."],"originBuildInvocationId":null,"cachingDisabledReasonMessage":"Caching has not been enabled for the task","skipMessage":null} [75ms] (221527)
    - {loggingHeader=:baseServicesGroovy:install, description=Task :baseServicesGroovy:install, progressOperationId={id=221527}, buildOperationStart=true, buildOperationCategory=TASK, buildOperationId={id=221527}, logLevel=LIFECYCLE, totalProgress=0, parentProgressOperationId={id=220104}, category=class org.gradle.internal.buildevents.TaskExecutionLogger, status=:baseServicesGroovy:install, timestamp=1538098891549} [0]
      Snapshot task inputs for :baseServicesGroovy:install {} {"outputPropertyNames":null,"inputHashes":null,"actionClassNames":null,"inputValueHashes":null,"buildCacheKey":null,"inputPropertiesLoadedByUnknownClassLoader":null,"classLoaderHash":null,"inputFileProperties":{},"actionClassLoaderHashes":null} [0ms] (221529)
      Execute upload for :baseServicesGroovy:install [74ms] (221531)
        Realize task :internalTesting:jar {"taskPath":":internalTesting:jar","eager":false,"replacement":false,"taskId":77701,"buildPath":":"} {} [1ms] (221533)
    Task :baseServices:install {"taskPath":":baseServices:install","taskClass":"org.gradle.api.tasks.Upload","taskId":76203,"buildPath":":"} {"cachingDisabledReasonCategory":"NOT_ENABLED_FOR_TASK","actionable":true,"originExecutionTime":null,"upToDateMessages":["Task has not declared any outputs despite executing actions."],"originBuildInvocationId":null,"cachingDisabledReasonMessage":"Caching has not been enabled for the task","skipMessage":null} [2ms] (221528)
    - {loggingHeader=:baseServices:install, description=Task :baseServices:install, progressOperationId={id=221528}, buildOperationStart=true, buildOperationCategory=TASK, buildOperationId={id=221528}, logLevel=LIFECYCLE, totalProgress=0, parentProgressOperationId={id=220104}, category=class org.gradle.internal.buildevents.TaskExecutionLogger, status=:baseServices:install, timestamp=1538098891549} [0]
      Snapshot task inputs for :baseServices:install {} {"outputPropertyNames":null,"inputHashes":null,"actionClassNames":null,"inputValueHashes":null,"buildCacheKey":null,"inputPropertiesLoadedByUnknownClassLoader":null,"classLoaderHash":null,"inputFileProperties":{},"actionClassLoaderHashes":null} [0ms] (221530)
      Execute upload for :baseServices:install [1ms] (221532)
        Realize task :internalTesting:jar {"taskPath":":internalTesting:jar","eager":false,"replacement":false,"taskId":77701,"buildPath":":"} [0ms] (221534)

So we do have concurrent realization of :internalTesting:jar.

This happens for me about every other gradle install, so it's fairly repeatable. Maybe we have something funkier in our build than most, but this seems serious.
It looks like any place that's using ProjectAccessListener and org.gradle.api.artifacts.ProjectDependency#getDependencyProject (public API) are potential suspicious cross-project accessors.

PR https://github.com/gradle/gradle/pull/7035


hocr syntax errs

Current Behavior
I used tesseract 5.4.1 in WSL/Win10 and  tesseract 5.0.1 in GImagereader/Win10 with different image files (fraktur newspaper and latin/Libreoffice dokument, 2 columns, all images in German language), and let the tesseract versions create both OCR-pdf and hocr output. The OCR pdf was ok and searchable and was displayed in PDF viewers with no errors.
After permanently failing to create a searchable OCR pdf with hocr-pdf from the hocr tools I've checked the syntax of the created hocr files with hocr-check and hocr-spec: numerous syntax errs were reported, explaining the failure of hocr-pdf. The created pdf displayed the image only, but didn't contain any text layer (pdftotext produced empty files). The pdf viewer displayed warnings, that the pdf structure is corrupted (streams missing or premature ending of streams)
Expected Behavior
correct syntax of created hocr files, which allows creation of searchable OCR pdfs by hocr-pdf
Suggested Fix
no idea
tesseract -v
tesseract -v  (instance in WSL)
tesseract 5.4.1
leptonica-1.82.0
libgif 5.1.9 : libjpeg 8d (libjpeg-turbo 2.1.1) : libpng 1.6.37 : libtiff 4.3.0 : zlib 1.2.11 : libwebp 1.2.2 : libopenjp2 2.4.0
Found AVX
Found SSE4.1
Found OpenMP 201511
Found libarchive 3.6.0 zlib/1.2.11 liblzma/5.2.5 bz2lib/1.0.8 liblz4/1.9.3 libzstd/1.4.8
Found libcurl/7.81.0 OpenSSL/3.0.2 zlib/1.2.11 brotli/1.0.9 zstd/1.4.8 libidn2/2.3.2 libpsl/0.21.0 (+libidn2/2.3.2) libssh/0.9.6/openssl/zlib nghttp2/1.43.0 librtmp/2.3 OpenLDAP/2.5.18
Operating System
Windows 10
Other Operating System
see above: 2 different tesseract versions on the same PC:
tesseract 5.4.1 in WSL/Win10 and  tesseract 5.0.1 in GImagereader/Win10
uname -a
No response
Compiler
No response
CPU
i5-3570 @3.4 GHz - 8 GB Ram
Virtualization / Containers
WSL/Win10
Other Information
hocr-check let me suspect, that the hocr output from tesseract has syntax errs, which might be responsible for the failure of hocr-pdf
sample hocr files could be supported

I produced a hOCR file from hocr-tools/test/testdata/alice_1.png and checked it with hocr-check. No errors were reported.
Please provide more details how the reported issue can be reproduced, ideally the image and the command line which produced the hOCR file with syntax errors.

While hocr-check does not complain, hocr-spec reports several errors which occur rather often Most of them are already discussed in issue #3303: x_size, x_ascender and x_descender are not part of the standard, but extensions introduced by Tesseract. In addition, Tesseract does not add all supported and used capabilities.

Meanwhile the capabilities issue was fixed in PR #4301.
The remaining errors which are reported by hocr-spec for x_size, x_ascender and x_descender are not hOCR syntax errors, because the standard allows such implementation-specific parameters. So this is an incomplete implementation of hocr-spec which should not complain.


Disable minecraft modal

And fix typo in locale

Coverage remained the same at 56.177% when pulling 4ca838ebe64c8450453db410e8bef99b491c48b0 on Zerrien:clean-up into 6250cf21436f6f48432fd65e5cb5bfd2ba50c780 on codecombat:master.

Coverage remained the same at 56.177% when pulling 4ca838ebe64c8450453db410e8bef99b491c48b0 on Zerrien:clean-up into 6250cf21436f6f48432fd65e5cb5bfd2ba50c780 on codecombat:master.


Data on Datatables in string form

There is a bug where datatables uses strings instead of integers or floats

The data is no longer downloadable. This rendering this issue obsolete


lxd/apparmor/qemu: Allow some more files

This allows NSS related files:

nsswitch.conf
passwd
group

As well as /proc/version which QEMU apparently accesses sometimes.
Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

@tomponline good to go (will fix broken VMs in our CI)

Testsuite passed


Update to Checker dataflow 3.13.0

Helps out with #462.  Should land after #469
I needed to adjust to some API changes, and re-implement some deprecated functionality that we want to keep.  Also, it looks like a try-finally false negative got fixed!  I filed https://github.com/typetools/checker-framework/issues/4612 on the need to add the explicit plume-util dependence.
Before landing, this should be tested internally, both for perf and also to check if new errors are reported.  Nothing urgent on my end.

Pull Request Test Coverage Report for Build #503

0 of 0   changed or added relevant lines in 0 files are covered.
12 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 89.159%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/com/uber/nullaway/NullabilityUtil.java
5
94.12%

src/main/java/com/uber/nullaway/dataflow/AccessPathNullnessPropagation.java
7
91.05%

Totals

Change from base Build #502:
-0.01%

Covered Lines:
3479

Relevant Lines:
3902

💛  - Coveralls

Unfortunately clicking the links in that @coveralls comment doesn't show me the actual lines where the coverage changed...

Let's hold off on landing this.  There are some issues with the new dependency I'd like to think through / work out first.

So I think this one is good for review / internal testing.  The one risk here is that currently the dataflow-shaded artifact used by Error Prone includes some unshaded classes from the plume-util library that could hypothetically conflict with plume-util classes that this latest version of dataflow depends on.  I've run NullAway tests on all supported versions of Error Prone and they work, so things are fine for now.  Also, the issue with dataflow-shaded is getting fixed (see https://github.com/typetools/checker-framework/issues/4615) so this will most likely not be a problem moving forward.  I think the worst case is that some future update of dataflow that we want to do would be blocked due to a conflict with Error Prone, but that's independent of this PR and could likely be addressed by asking Error Prone to update their dataflow-shaded dependence.
So, TL;DR most likely we are fine 🙂 Mostly just wanted to write the above to document it somewhere.

Ok, will go over it tomorrow and try to test it internally asap on both our repos and let you know!

Seeing the following error internally:
     error-prone version: 2.6.0
     BugPattern: NullAway
     Stack Trace:
     com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: org/checkerframework/dataflow/qual/TerminatesExecution
        at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2049)
        at com.google.common.cache.LocalCache.get(LocalCache.java:3951)
        at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3974)
        at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4958)
        at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4964)
        at com.uber.nullaway.dataflow.DataFlow.dataflow(DataFlow.java:146)
        at com.uber.nullaway.dataflow.DataFlow.finalResult(DataFlow.java:222)
        at com.uber.nullaway.dataflow.AccessPathNullnessAnalysis.getNonnullFieldsOfReceiverAtExit(AccessPathNullnessAnalysis.java:143)
        at com.uber.nullaway.NullAway.guaranteedNonNullForConstructor(NullAway.java:1588)
        at com.uber.nullaway.NullAway.checkConstructorInitialization(NullAway.java:1565)
        at com.uber.nullaway.NullAway.checkFieldInitialization(NullAway.java:1424)
        at com.uber.nullaway.NullAway.matchClass(NullAway.java:1154)
        at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:450)
        at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:548)
        at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:151)
        at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
        at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
        at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
        at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
        at com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)
        at com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:113)
        at com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:144)
        at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:561)
        at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:151)
        at com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:591)
        at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
        at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
        at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
        at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:152)
        at com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:120)
        at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1404)
        at com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1353)
        at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:946)
        at com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:100)
        at com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:142)
        at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:96)
        at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:90)
        at com.facebook.buck.jvm.java.plugin.adapter.JavacTaskWrapper.call(JavacTaskWrapper.java:100)
        at com.facebook.buck.jvm.java.plugin.adapter.BuckJavacTask.call(BuckJavacTask.java:52)
        at com.facebook.buck.jvm.java.plugin.adapter.BuckJavacTaskProxyImpl.call(BuckJavacTaskProxyImpl.java:134)
        at com.facebook.buck.jvm.java.Jsr199JavacInvocation$CompilerWorker.lambda$startCompiler$2(Jsr199JavacInvocation.java:424)
        at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:127)
        at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
        at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:80)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
  Caused by: java.lang.NoClassDefFoundError: org/checkerframework/dataflow/qual/TerminatesExecution
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.visitMethodInvocation(CFGTranslationPhaseOne.java:1350)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.visitMethodInvocation(CFGTranslationPhaseOne.java:198)
        at com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1644)
        at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.visitExpressionStatement(CFGTranslationPhaseOne.java:2314)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.visitExpressionStatement(CFGTranslationPhaseOne.java:198)
        at com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1454)
        at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.visitBlock(CFGTranslationPhaseOne.java:2062)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.visitBlock(CFGTranslationPhaseOne.java:198)
        at com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1026)
        at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.process(CFGTranslationPhaseOne.java:428)
        at org.checkerframework.dataflow.cfg.builder.CFGBuilder.build(CFGBuilder.java:91)
        at com.uber.nullaway.dataflow.DataFlow$2.load(DataFlow.java:130)
        at com.uber.nullaway.dataflow.DataFlow$2.load(DataFlow.java:97)
        at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529)
        at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278)
        at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155)
        at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
        ... 46 more
  Caused by: java.lang.ClassNotFoundException: org.checkerframework.dataflow.qual.TerminatesExecution
        at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
        ... 66 more

Which seems correct in that org.checkerframework.dataflow.qual.TerminatesExecution is not part of org.checkerframework:dataflow:jar:3.13.0.
See:
% unzip -l ~unzip -l ~/Downloads/dataflow-3.13.0.jar | grep TerminatesExecution
% [no output]

The corresponding org.checkerframework.shaded.dataflow.qual.TerminatesExecution is however part of org.checkerframework:dataflow-shaded:jar:3.13.0
% unzip -l ~/Downloads/dataflow-shaded-3.13.0.jar | grep TerminatesExecution
      492  05-03-2021 12:33   org/checkerframework/shaded/dataflow/qual/TerminatesExecution.class

However, keep in mind that EP 2.6.0 pulls in dataflow-shaded:3.11.0

Yikes, that looks like a Checker Framework packaging issue.  Will look into it.  @lazaroclapp any chance of producing an open-source test case that repros the error?

@lazaroclapp that annotation is inside the checker-qual 3.13.0 artifact, which is a dependence of dataflow.  Do you need to update the version of checker-qual used in the internal build?

Closing in favor of #485


Bug/Feature? - WebUI Ace editor shortcuts not working

My Environment
ArangoDB Version: 3.3.13
Deployment Mode: Docker
Operating System:  Ubuntu 16.04
Affected feature: Web UI
Problem:
Would like to be able to use the Ace Editor shortcut CMD-L for toggling comments on and off in the Web UI Query editor.  It looks like you are using the Ace editor (from inspecting the code), but the shortcut is not working.  I did try the shortcut on the Ace Editor editor website (https://ace.c9.io/demo/keyboard_shortcuts.html), and it works perfectly there.
Expected result:
Ability to use the Ace Editor keyboard shortcuts - especially the togglecomment shortcut.
Awesome feature (the Web UI) - I use it a LOT - just want to use it even more :)

Hi @wshayes,
The available keyboard shortcuts can be viewed by clicking on the keyboard icon which is at the bottom left corner of the Web UI - just beside the version. The shortcut to toggle on and off comments is Ctrl/Cmd + Shift + C

Thanks!

Thanks!


weird null exception error

I was wondering if anyone else has seen this and what the cause would be(threading?)
java.lang.NullPointerException: null
	at org.redisson.RedissonList.size(RedissonList.java:53) ~[redisson-1.2.0.jar:na]
	at org.redisson.RedissonList.isEmpty(RedissonList.java:63) ~[redisson-1.2.0.jar:na]
	at org.redisson.RedissonQueue.peek(RedissonQueue.java:89) ~[redisson-1.2.0.jar:na]

connection issue with pool set up, Solved


Water Sensors: XTS Indigo Brooke (1084053)

Site is completely offline as of 5/30

have to visit farm and reset. download data and most likely set to data only!

R1C offline as of 6/13. Poking Brooke today.

When the device came back online online 6/6. Device reset by Brooke - tagged in this issue for this farm, and confirmed via email. Did not take devices offline. They are sending data 6/6 to 6/16.
@elhenriq why do you suggest set to receiver mode only as the default solution when the nodes go offline? Do they not collect data when attempting and failing a cellular send cycle?
Where are people putting or sending manually downloaded node and gateway data? @brianwdavis can this data get parsed during this season? Let's put a priority on parsing the downloaded files.
Open the files to confirm full node collection @elhenriq @kldriver when requesting this receiver mode from users.
Issue can be closed after putting in receiver mode AND confirming all nodes operate by opening downloaded files. Issue stays open when files are not downloaded or collected and stored.

Rep 1 C deep sensor is offline
Rep 2 B top sensor is offline

Site online.

@brianwdavis @kldriver Bare rep 2, the top sensor was replaced at some point but broke used a sensor from a different treatment for it and the letter is lowercase instead of uppercase, so the dashboard is not plotting that line. can you change that one, so it reads of the letter and not the depth, so it can plot it?

no data for a while, asking to download soon

Available data downloaded at end of season.


Initial plumbing to support Encrypt, and KeyID (KMS Encryption)

Initial plumbing to support the following options on S3:

Encrypt - Enable or disable KMS encryption on S3
KeyID - The KMS Key ID for the S3 bucket

fixes https://github.com/openshift/cluster-image-registry-operator/issues/161

/refresh

@bparees @dmage @legionus This is ready for another look (if you want to even though CI is down)

/close
/reopen

/reopen

/refresh

@bparees ptal

/close

/reopen

/retest

AWS limit issues
/retest

@coreydaley squash and lgtm
/approve

@bparees squashed.

/lgtm

/retest

had to rename testframework to framework in aws_test.go, weird

/retest

/retest

/retest

/retest

/retest

/retest

/retest

Forgot that these only exist if set now, fixed in current push:
aws_test.go:307: unable to find environment variable: wanted REGISTRY_STORAGE_S3_REGIONENDPOINT
	aws_test.go:307: unable to find environment variable: wanted REGISTRY_STORAGE_S3_KEYID

/lgtm

@bparees thanks, i was going to tag you after the tests passed

/retest

/retest

/retest

/retest


Vic rego

Add vic notice
Update some jekyll stuff

Deploy preview for voteflux processing.
Built with commit 5f94b99205f047ddd9a2d9617cb5e8a4a985dd58
https://app.netlify.com/sites/voteflux/deploys/5a94aa2bfd0efa3961092a41

fyi @TomSesselmann


User nobody should be excluded from ownership and uid does not equal gid

Describe the Issue
When user nobody (UID 65534) is included in setting ownership the role will manipulate / causing severe problems for the target system. Also, there is a variable rhel8cis_int_gid being used for comparison with uid. While this works since all newer systems use same gid and uid for normal users it may differ on some systems.
Expected Behavior
System should not be rendered unusable by running the role.
Actual Behavior
The root folder (/) gets chown to user nobody by the role causing severe problems.
Environment (please complete the following information):

Ansible Version: 2.9.27
Host Python Version: Python 3.6.8
Ansible Server Python Version: Python 3.6.8
Additional Details:

Additional Notes
The proposed solution has been tested and found to work
Possible Solution
Introduce two new variables, rhel8cis_int_uid and rhel8cis_int_uid_max. Set rhel8cis_int_uid to be 1000 and rhel8cis_int_uid_max to 65533. Use rhel8cis_int_uid when comparing with UIDs, this includes tasks for 6.2.x and templates for 4.1.9, 4.1.10, 4.1.12, 4.1.13 and 4.1.14.
Use rhel8cis_int_uid_max to prevent chown on / for user nobody in section 6.2.8. This has been fixed in 6.2.7 using a slightly different approach.

Hi @areh
Thank you for taking the time to highlight this issue and we can see how this may cause problems on running systems. We only test as noted on clean new systems, so this feedback helps to to try and minimise any potential disruption that may occur.
We will look at how this could be adopted aware that it will affect a number of controls and the related auditing components.
regards
uk-bolly

Hi @areh
Thank you again for the feedback.
An update the latest devel branch has now been released and this should address the issues you have seen here.
Please feel free to close the issue if all is working as expected or feedback accordingly.
Thanks again
uk-bolly

hi @areh
Thank you for your patience and the time you take raisin the issues.
I have added this in a slightly different way to the rhel9-cis role. This is the same currently as the rhel8 role but with some alternative ways of doing things. Hopefully speed and logic improvements. In this case a discovery of the IDs takes place or can be overridden in defaults/main
If this works for you i can add this into rhel8-cis role also?
Many thanks
uk-bolly

hi @areh
I have added this to a new release hoping to be pushed to devel in the next week.
This should resolve the issue you have raised.
regards
uk-bolly

This was addressed in release 2.1.0


Missing name parameter in chat completion message parameters.

According to the documentation we should be able to specify the name for each of the base message types/roles (system, assistant, and user) to provide the model with additional information to differentiate between participants of the same role (useful for few-shot prompting).

cc @nknj – thoughts on adding this?

@rattrayalex @nknj  any more information on this? I came upon this issue when migrating from version 3.x.x and it seems like this parameters are not deprecated.

It looks like they're deprecating name support, but it would be nice to get an official explanation.

Can you confirm what the issue is? We document these in the API, are you saying they are not supported here in the SDK?

Yes, they are not supported in the SDK - types ChatCompletionSystemMessageParam,  ChatCompletionUserMessageParam, and ChatCompletionAssistantMessageParam should all include the name parameter but the usage of these types would result in the following error: Object literal may only specify known properties, and ''name'' does not exist in type.
I am using the node library v4.18.0.

This should be fixed soon! Hang tight.

https://github.com/openai/openai-openapi/pull/126 includes the fix, so, when merged, https://github.com/openai/openai-openapi/pull/119 can be closed

Same (?) issue here. I'm using 4.20.1 and am getting this error when calling openai.chat.completions.create(...)
  Types of property 'messages' are incompatible.
        Type '{ role: ChatCompletionRole; content: string; }[]' is not assignable to type 'ChatCompletionMessageParam[]'.
          Type '{ role: OpenAI.Chat.Completions.ChatCompletionRole; content: string; }' is not assignable to type 'ChatCompletionMessageParam'.
            Property 'name' is missing in type '{ role: OpenAI.Chat.Completions.ChatCompletionRole; content: string; }' but required in type 'ChatCompletionFunctionMessageParam'.
            ```

Sorry about this! A true fix has merged on this repo and should go out on the Node SDK shortly.

Still seems to be broken?

@shamoons where do you see name missing that you would have expected it?