CSS import breaks webpack 5 compilation

Pasting issue from Semantic-UI-React as this is a Semantic-UI-CSS issue.
https://github.com/Semantic-Org/Semantic-UI-React/issues/4287#issue-1008071742
Bug Report
With Webpack 5 and css-loader 6, the CSS imports break the compilation.
Steps
Start a new react app with webpack 5 and css-loader v6. Import Semantic UI css in the root component and it should stop working.
Expected Result
CSS should import correctly and the app should run as expected
Actual Result
An error occurs in
TypeError: Cannot read property 'get' of undefined
during rendering of asset asset/inline|data:application/x-font-ttf;charset=utf-8;;base64,AAEAAAAOAIAAAwBgT1Mv...
Version
2.0.4
Fix
The main reason for this is an extra ";" at line 19990 of semantic.css
If removed, everything goes fine.
@font-face {
font-family: 'Step';
src: url(data:application/x-font-ttf;charset=utf-8;;base64,AAEAAAAOAIAAAw... // this line
}
Code permalink
https://github.com/Semantic-Org/Semantic-UI-CSS/blob/fc9f8bd7e4f5934756ec60c0423f77d1c7be7c6f/semantic.min.css#L155

The fix may work in development but how to get around it in development. My build in continuous deployment is failing because of this

I worked around it using the manual deployment(uploading the build folder as it was building locally fine) on netlify

I'm having the same issue. I chose to use Webpack 4.44 and it works fine. Planning on using this until the issue is fixed.

Any chance this can get packaged up into 2.4.2 and released its been in Master for a few months and breaks any apps with create-react-app using latest react-scripts css-loader 6 !

Temporary fix:
Add this to the rules of your webpack config.
      {
        test: /\.css$/,
        use: [
          'style-loader',
          {
            loader: 'css-loader', options: {
              url: {
                filter: (url) => {
                  // Semantic-UI-CSS has an extra semi colon in one of the URL due to which CSS loader along
                  // with webpack 5 fails to generate a build.
                  // Below if condition is a hack. After Semantic-UI-CSS fixes this, one can replace use clause with just
                  // use: ['style-loader', 'css-loader']
                  if (url.includes('charset=utf-8;;')) {
                    return false;
                  }
                  return true;
                },
              }
            }
          },
        ],
      }

Temporary fix: Add this to the rules of your webpack config.
      {
        test: /\.css$/,
        use: [
          'style-loader',
          {
            loader: 'css-loader', options: {
              url: {
                filter: (url) => {
                  // Semantic-UI-CSS has an extra semi colon in one of the URL due to which CSS loader along
                  // with webpack 5 fails to generate a build.
                  // Below if condition is a hack. After Semantic-UI-CSS fixes this, one can replace use clause with just
                  // use: ['style-loader', 'css-loader']
                  if (url.includes('charset=utf-8;;')) {
                    return false;
                  }
                  return true;
                },
              }
            }
          },
        ],
      }

I tried this fix which cleared the one error but produced another.
Failed to compile.

Syntax error: D:\dev\repos\electron\astromodconsole\node_modules\semantic-ui-css\semantic.min.css Unknown word (2:7)
  1 |
> 2 |       import API from "!../style-loader/dist/runtime/injectStylesIntoStyleTag.js";
    |       ^
  3 |       import domAPI from "!../style-loader/dist/runtime/styleDomAPI.js";
  4 |       import insertFn from "!../style-loader/dist/runtime/insertBySelector.js";
asset static/js/bundle.js 3.68 MiB [emitted] (name: main) 1 related asset
asset index.html 1.72 KiB [emitted]
asset asset-manifest.json 190 bytes [emitted]
cached modules 3.9 MiB (javascript) 28.3 KiB (runtime) [cached] 884 modules
javascript modules 117 bytes
  ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[2]!./node_modules/style-loader/dist/cjs.js!./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[2].use[1]!./node_modules/source-map-loader/dist/cjs.js!./src/index.css 39 bytes [built] [1 error]
  ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[2]!./node_modules/style-loader/dist/cjs.js!./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[2].use[1]!./node_modules/source-map-loader/dist/cjs.js!./node_modules/semantic-ui-css/semantic.min.css 39 bytes [built] [1 error]
  ./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[2]!./node_modules/style-loader/dist/cjs.js!./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[2].use[1]!./node_modules/source-map-loader/dist/cjs.js!./src/App.css 39 bytes [built] [1 error]

ERROR in ./node_modules/semantic-ui-css/semantic.min.css (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[2]!./node_modules/style-loader/dist/cjs.js!./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[2].use[1]!./node_modules/source-map-loader/dist/cjs.js!./node_modules/semantic-ui-css/semantic.min.css)
Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
SyntaxError

(2:7) D:\dev\repos\electron\astromodconsole\node_modules\semantic-ui-css\semantic.min.css Unknown word

  1 |
> 2 |       import API from "!../style-loader/dist/runtime/injectStylesIntoStyleTag.js";
    |       ^
  3 |       import domAPI from "!../style-loader/dist/runtime/styleDomAPI.js";
  4 |       import insertFn from "!../style-loader/dist/runtime/insertBySelector.js";
 @ ./node_modules/semantic-ui-css/semantic.min.css 8:6-312 22:17-24 26:7-21 58:25-39 59:36-47 59:50-64 63:6-73:7 64:54-65 64:68-82 70:42-53 70:56-70 72:21-28 83:0-282 83:0-282 84:22-29 84:33-47 84:50-64 61:4-74:5
 @ ./src/index.tsx 11:0-42

ERROR in ./src/App.css (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[2]!./node_modules/style-loader/dist/cjs.js!./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[2].use[1]!./node_modules/source-map-loader/dist/cjs.js!./src/App.css)
Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
SyntaxError

(2:7) D:\dev\repos\electron\astromodconsole\src\App.css Unknown word

  1 |
> 2 |       import API from "!../node_modules/style-loader/dist/runtime/injectStylesIntoStyleTag.js";
    |       ^
  3 |       import domAPI from "!../node_modules/style-loader/dist/runtime/styleDomAPI.js";
  4 |       import insertFn from "!../node_modules/style-loader/dist/runtime/insertBySelector.js";
 @ ./src/App.css 8:6-368 22:17-24 26:7-21 58:25-39 59:36-47 59:50-64 63:6-73:7 64:54-65 64:68-82 70:42-53 70:56-70 72:21-28 83:0-338 83:0-338 84:22-29 84:33-47 84:50-64 61:4-74:5
 @ ./src/App.tsx 6:0-19
 @ ./src/index.tsx 7:0-24 16:35-38

ERROR in ./src/index.css (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].oneOf[5].use[2]!./node_modules/style-loader/dist/cjs.js!./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[2].use[1]!./node_modules/source-map-loader/dist/cjs.js!./src/index.css)
Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
SyntaxError

(2:7) D:\dev\repos\electron\astromodconsole\src\index.css Unknown word

  1 |
> 2 |       import API from "!../node_modules/style-loader/dist/runtime/injectStylesIntoStyleTag.js";
    |       ^
  3 |       import domAPI from "!../node_modules/style-loader/dist/runtime/styleDomAPI.js";
  4 |       import insertFn from "!../node_modules/style-loader/dist/runtime/insertBySelector.js";
 @ ./src/index.css 8:6-370 22:17-24 26:7-21 58:25-39 59:36-47 59:50-64 63:6-73:7 64:54-65 64:68-82 70:42-53 70:56-70 72:21-28 83:0-340 83:0-340 84:22-29 84:33-47 84:50-64 61:4-74:5
 @ ./src/index.tsx 6:0-21

webpack 5.65.0 compiled with 3 errors in 2280 ms

Pretty sure ya can’t touch the webpack config of a create-react-app unless ejecting from it or running a hot patch. It just needs to be fixed for the latest webpack (at least at whatever level stable create react app is released with… I assume there’s quite a few folks using react-scripts without ejecting)

The solution I found the most convenient was to apply a patch via patch-package.

Don't forget to clear webpack cache (node_modules/.cache) after you apply the fix locally.

I am seeing the same error mentioned above (Module build failed: UnhandledSchemeError: Reading from "data:application/x-font-ttf;charset=utf-8;;base64...) and wondering if there will be a fix for this soon that doesn't require a local patch? Seems like there is just an extra semicolon that needs to be removed, although I could be mistaken. Thanks in advance!

I assume nobody will keep using Semantic-UI if they don't fix this quite soon? At least I will rather find an alternative than having to hack around with patches to npm packages.

Switching to CDN worked for us.
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.4.1/semantic.min.css" integrity="sha512-8bHTC73gkZ7rZ7vpqUQThUDhqcNFyYi2xgDgPDHc+GXVGHXq+xPjynxIopALmOPqzo9JZj0k6OqqewdGO3EsrQ==" crossorigin="anonymous" referrerpolicy="no-referrer" />

This has been open for some time. Anyone got news on when it'll be fixed?

¿Alguien sabe si van a solucionarlo o no?

Vengo de tus cursos con la misma pregunta XD

¿Alguien sabe si van a solucionarlo o no?

Vengo de tu curso preguntandome lo mismo :(

This has been open for some time. Anyone got news on when it'll be fixed?

The issue has been fixed and merged in the repository but the fix has not made to npm packages yet...
Try a local fix and remove webpack cache node_modules/.cache before building again.

It looks like the double semi-colon issue was merged in the codebase but a new package hasn't been released yet. I pointed my dependency file (package.json) directly to build from the git-repo like this
"semantic-ui-css": "git+https://github.com/Semantic-Org/Semantic-UI-CSS.git"

Any progress in this?

Webpack 4.44

how can i use it please can u explain im newbe

Think resolved in 2.5.0


Smooth color interpolation between item value tiers and Stackable item value scaling for coloring

Summary
Two QoL and eye-candy I thought would be nice and simple additions to the Ground Items plugin.

Toggleable via plugin settings.
Leaves existing behavior fully intact if not enabled.
Little to no extra maintenance needed if implemented.

Disclaimer
I'm new to Runelite development and not the freshest on Java so there may be some syntactical oddities to iron out. I also erred on the side of verbose code to keep things readable but if code size is a concern I can slim things down. If this functionality is something that the maintainers think fits well into the Ground Items plugin then we can make whatever adjustments needed.
Smooth Item Value Color Interpolation
Functionality enabled with default item price and color values.

Implementation Notes

I added a small non-linearity in the color blending towards the high-end. Colors will blend until 70% of the higher-tier color and then snap to the new tier all at once when an item's value crosses the threshold. This is something subjective that I think helps maintain the meaning in setting your own price brackets. It also helps keep loot beams looking good without needing to implement the same behavior for them.

If a tier is "green" then while the color will shift towards the next tier color as value increases, it'll still be a "greenish" color until that value crosses to the next tier entirely (and the loot beam with it).
The specifics of this can be adjusted or it can be removed entirely or made toggleable if desired.

Why
I found myself pretty annoyed while doing some slayer tasks and wishing there was a visual distinction between the garbage items and the stackable/alchable items I actually want to pick up. I didn't want to mess with highlighting specific drops or changing my "Low value" price often so I thought something like this would be nice to have.
With the default value and color settings, see before and after:

This makes it a lot easier to pick out the stuff I want to pick up while still letting the higher value drops stand out by blending into the next color tier (like the dragon med).

Possible Issues

Not integrated with loot beams currently. I think it's debateable whether it'd be better to keep discrete lootbeam color tiers or have them matched to text color.
Might work better if the default item color was a bit darker than #FFFFFF but that's something the user can customize to their liking.

Stackable Item Value Scaling

Why
For the same reason as above, I found myself wanting the smaller-but-valuable stackables (runes, coins, darts/javelin heads, etc.) to stand out more than the other garbage items. These drop in low-valued amounts but take up only one inventory slot so you often want to pick them up throughout a trip.
See before (no scaling+color smoothing) and after (2.0 scaling factor+color smoothing)

Possible Issues

A bit more subjective in terms of utility. Some people wouldn't like this to be on or would like their own custom scaling factor tailored to their personal setup.
Current implementation just scales the stack value linearly, so it'll have a more noticeable effect on higher value stacks than lower value ones (e.g. a 9m cash stack will be colored like a 13.5m cash stack if the scaling factor is 1.5). The implementation could be adjusted to use some form of logarithmic scaling instead.
Not integrated with loot beams currently (should be simple to add though). A high value stackable drop might have a color tier that doesn't match its lootbeam tier.
Not as useful on it's own without smooth color interpolation enabled

Field example!

I don't really understand the point of scaling stackable items if you are already lerping the value between colors.

I don't really understand the point of scaling stackable items if you are already lerping the value between colors.

The goal was to make small yet desirable stackables still stand out visually compared when compared to trash items with the same value. For example, I might pick up 2k worth of coins or blood runes on the ground but I wouldn't pick up an adamantite bar cause it takes up inventory space. So having this option to scale up stackables means the 2k stackable on the ground can stand out visually against the addy bar when it otherwise wouldn't.
It's something I find useful and nice to have but I also acknowledge it's subjective and if bloating the config menu is a concern I can remove it.

You can already use qty highlights for that

What are qty highlights? I've looked through the config menu for something like that but I'm not sure what you're referring to.

Ex: in your item highlights blood rune>50

Ah ok, didn't know that was a thing. Still, I think there's value in having an option that just works everywhere without having to manually configure each item. I've done some slayer and other content with this functionality enabled on my own compiled client and it's worked quite well without any extra configuration necessary.

I removed the value scaling on stackables as it's not the main focus of this PR.


Tests improv

Codecov Report

Merging #15 (6f88e7d) into main (4d9bf31) will decrease coverage by 0.48%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main      #15      +/-   ##
============================================
- Coverage     81.06%   80.57%   -0.49%
- Complexity     3087     3101      +14
============================================
  Files           145      148       +3
  Lines          7905     7924      +19
============================================
- Hits           6408     6385      -23
- Misses         1497     1539      +42

Impacted Files
Coverage Δ

src/Blameable/Traits/BlameableDocument.php
0.00% <ø> (ø)

src/Blameable/Traits/BlameableEntity.php
100.00% <ø> (ø)

src/Mapping/Annotation/Blameable.php
60.00% <60.00%> (ø)

src/Mapping/Annotation/IpTraceable.php
60.00% <60.00%> (ø)

src/Mapping/Annotation/SoftDeleteable.php
60.00% <60.00%> (ø)

src/AbstractTrackingListener.php
94.59% <100.00%> (+0.97%)
:arrow_up:

src/Mapping/Driver/AttributeReader.php
0.00% <0.00%> (-89.48%)
:arrow_down:

src/Mapping/Driver/AttributeAnnotationReader.php
0.00% <0.00%> (-50.00%)
:arrow_down:

src/Mapping/ExtensionMetadataFactory.php
91.17% <0.00%> (-1.48%)
:arrow_down:

src/Tree/Hydrator/ORM/TreeObjectHydrator.php
87.50% <0.00%> (-1.14%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9bf31...6f88e7d. Read the comment docs.


Developer fee inactive state

https://github.com/adeptio-project/adeptio/blob/master/src/masternode-payments.cpp#L569

Fixed with new mandatory release:
https://github.com/adeptio-project/adeptio/releases


Add support for overplotting a ocean/land mask with GeoMakie

This commit adds support for applying land/sea masks to GeoMakie plots. The masks are obtained directly from GeoMakie as a collection of polygons. For the ocean mask, we use bathymetry data at 0 elevation. Data is provided by
NaturalEarth.jl. (I had to bump the minimum compat for GeoMakie to 0.7 because support NaturalEarth.jl was introduced in that release.)
This new option is only aesthetics: it does change the underlying data (we simply overplot something else). This also means that the colorbar will include values under the mask. Applying the mask directly to the data is left for future work.
Thanks @haakon-e for help with this feature.

oooh that's cool!!

"Applying the mask directly to the data is left for future work"
we could make it a clear outlier and use lowclip or highclip in the heatmaps, then build the colorbar without outlier (by building it independently), e.g.
ax, hm = heatmap(fig[1, 1], xs, ys, zs, colormap = :something,
    colorrange = (-x, y), lowclip = :blue)
Colorbar(fig[1, 4], limits = (-x, y), colormap=:something)

https://docs.makie.org/stable/reference/blocks/colorbar#colorbar

"Applying the mask directly to the data is left for future work"
we could make it a clear outlier and use lowclip or highclip in the heatmaps, then build the colorbar without outlier (by building it independently), e.g.
ax, hm = heatmap(fig[1, 1], xs, ys, zs, colormap = :something,
    colorrange = (-x, y), lowclip = :blue)
Colorbar(fig[1, 4], limits = (-x, y), colormap=:something)

https://docs.makie.org/stable/reference/blocks/colorbar#colorbar

My plan is to create an OutputVar from a land/sea mask so that it can be used beyond plotting.


Rename default branch master to main

Since GitHub renamed its default branch name to main, the default branch of this repository could also be main, since all newly created projects have the default name main but any project created from this template is still master - which can be confusing for people new to this.

Honestly I hated this part from GitHub because git still uses master when you init a repo, so it's just a lot of confusion regardless. For now though, I haven't seen anyone complain about it, and it's actually easier to submit repos with master to our releases database since master is assumed by default so one does not have to add the additional "branch": "main" to the JSON file.
Will leave this issue open if anyone else runs into this. Feel free to leave a comment.

Makes sense! I read a while ago that the Git maintainers are trying to switch to main as well, but it seems that the current version just adds a global switch to change the default branch<EMAIL_ADDRESS>Feel free to close it if you like, or we can wait for someone else to chime in :)

Yeah, thanks for the awareness, let's keep watching the situation as well.

Just chiming in, I feel like one of Obsidian's true strengths is being platform agnostic. It's your data, and it doesn't care where you put it or how you manage it. In my opinion, creating fragmentation in order to be consistent with the decisions of the GitHub platform goes against that ethos.
The discussion around the default branch name has been covered thoroughly elsewhere and I'll leave that conversation to those participants, but I do think it's fair to say that main is the deviation from the norm, not master.

Thank you for the comment. Fortunately, Obsidian can work with both master and main branches, so developers can choose whichever they prefer!

When you install Git now, it actively encourages you to set the init.defaultBranch option to main. Keeping the original default branch name takes more effort, since you have to explicitly opt out.
I think at this point main is the norm, and given the reasons for the change, Obsidian probably ought to follow the trend.

Thank you, that is a great data point. Looking at the docs, For now, it seems that the default value is still master. Once git decides to permanently change defaultBranch's default value to main we will consider switching over.

For GitHub, the default branch has been main since 2020-10-01

I stand with master, this is my GitHub settings:

which can be confusing for people new to this.

This is unlike other technical details that are necessary to know, it's a proof of how politics changes our life.
I think people should understand this, this is a proof of

I stand with master, this is my GitHub settings:

which can be confusing for people new to this.

This is unlike other technical details that are necessary to know, it's a proof of how politics changes our life.
I think people should understand this, this is a proof of

I created a meme about this:

main as convention has broad adoption. Please rename the main branch to be called ... main.


Disabling a model Entity with Clustered lighting gives errors

Related thread: https://forum.playcanvas.com/t/solved-cannot-read-properties-of-null-reading-device/29128/
Project: https://playcanvas.com/project/1025290/overview/clustered-lighting-disable-bug
Launch project
Press 1 to disable the cube
Errors appear:
Uncaught TypeError: Cannot read properties of null (reading 'width')
    at LightsBuffer.addLightData (lights-buffer.js:400:61)
    at WorldClusters.updateClusters (world-clusters.js:389:31)
    at WorldClusters.update (world-clusters.js:440:14)
    at ForwardRenderer.updateClusters (forward-renderer.js:1913:29)
    at RenderPass.execute (forward-renderer.js:1969:22)
    at RenderPass.render (render-pass.js:215:14)
    at FrameGraph.render (frame-graph.js:127:29)
    at Application.renderComposition (app-base.js:1240:25)
    at Application.render (app-base.js:1228:14)
    at app-base.js:2201:29

Test project not public?

Made public now


Add tests derived from RFC 3720, section B.4.

@tseaver Is there a plan to do more re-factoring once these tests are in place?

Is there a plan to do more re-factoring once these tests are in place?

Yes, I plan to make the args explict for value and extend, and add in the hashlib-like wrapper.

@tseaver I just noticed that AppVeyor decided to run for this (because it needed to build wheels).
Care to add a test run in AppVeyor? It should be easy since each environment already builds the wheels.
%PYTHON3X%/python \
  -m pip \
  install \
  --no-index \
  --find-links . \
  py_crc32c

Can you add a test that breaks iscsi_scsi_read_10_command_pdu into a few chunks and calls extend() multiple times, then compares against value() output?

Added in e8bbd2b

Could you add a test to see how much cffi freaks out if the wrong types are passed in?

I don't know how useful a test would be for asserting this traceback:
>>> import crc32c
>>> crc32c.value('', 0)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tseaver/projects/agendaless/Google/src/py-crc32c/src/crc32c/__init__.py", line 24, in value
    return crc32c._crc32c_cffi.lib.crc32c_value(*args, **kwargs)
TypeError: initializer for ctype 'uint8_t *' must be a bytes or list or tuple, not str

TypeError: initializer for ctype 'uint8_t *' must be a bytes or list or tuple, not str

is a very helpful error message though!


Upgraded aws sdk to remove deprecation warning

Fixes issue 102.
AWS has deprecated the constructors of AmazonSNSAsyncClient in preference for a builder pattern. The builder returns an async client which no longer exposes the underlying executor, AmazonSNSAsync. This means that awaitTermination() can no longer be used for a graceful shutdown. However, this seems to be okay as the client is only used to publish synchronously thus the executor isn't used.

Coverage increased (+0.03%) to 74.881% when pulling 2b8f4b83587e8b823e38239d6da28fa21b90153e on issue-102 into 8a85646428594dc5155f11ea922a8a74fa6dd224 on master.


Thoughts on API changes

I've faced with the several strange API changes when upgrading micro-eth-signer from version 0.6.4 to 0.9.1 https://github.com/CoinSpace/cs-evm-wallet/commit/7f0e6c7bdeb571bae0fcef92fb96f5a1fcead789
Thoughts on API changes:

It is much easier to use and maintain if the library uses values in a single scale, such as cryptocurrency atoms (wei for Ethereum). In version 0.9.1  the library returns wei and humanized formats in calcAmounts() method. It complicates the library internally, but in the application it is most likely required to format number again (for example if trailing zeros needed).
The reason for adding calcAmounts() method is unclear. It seems much clearer for the end user to use getters such .fee, .amount.
Precalculation of amountWithFee may be easy calculated (fee + amount) and may not be required by the consumer at all.

The rest of the changes between version in the library seem quite logical.

yeah, humanized is not ideal and can likely be dropped because >the application it is most likely required to format number again

It seems much clearer for the end user to use getters

I've dropped all getters except for hash, sender and v, because it had too many getters and it was hard to reason about the transaction: which fields are auto-calculated; which fields are not. After the update:

The transaction can now be easily inspected in console.log where it always has humanized representation, instead of JSON-stringified crap like before
v is rarely used, so doesn't matter
sender is also rarely used - it's just an alias for recoverSender().address

if you need a public key, then it doesn't work: do recoverSender().publicKey
so just a small convenience function

hash is more common. It can't be made pre-computed, because it would consume too much resources

getHash() is weird name
toHash() is also not great

Precalculation of amountWithFee may be easy calculated (fee + amount)

It's maximum amount that the transaction would consume. All fee estimations are "miscalculated", because gas price can't be known in advance — unless you set priorityFee = fee.

may not be required by the consumer at all

You're sending 0.5 eth with 20 gwei fee. Then you're actually spending 0.500042 eth (MAX) and not 0.5. That seems like a useful thing to know.

As multi currency wallet app developer I can say that almost all open source wallet applications has almost the same architectecture:

Underlying cryptocurrency library
Wallet abstraction
UI application

For example edge-currency-accountbased and cs-evm-wallet
It is better if underlying library keep the balance between full featured and simplicity. It is easy to use, easy to audit and of course much easy to find a bugs.
As I already mentioned, we don't know exactly the use case, for example

The application can show 5 transactions and that's it. Then there is no sense for caching and precomputation.
In opposition, the application can juggle thousands of transactions. Then, in my opinion, caching and precomputation can be implemented in the wallet abstraction, not it underlying library to keep it simple.
Displaying the amount is the responsibility of the UI application. amount, fee, and amountWithFee can be shown in wei and humanized form. Or even gasLimit can be shown. The need for a specific UI application is unknown for us.

My opinion is that it was more convenient to have a separate getter .fee (or getter function .getFee()) for each value without caching and precomputation.
For pretty console.log inspection toString() method can be implemented: https://github.com/CoinSpace/cs-common/blob/master/lib/Transaction.js#L58-L65
Of course it is better to have helpers like ethDecimal and gweiDecimal.

ce727bb


Support widgets in redash connector

In continuation to Issue 995,
we would like to support importing  the metadata of widgets in the redash connector.
I can do it, but it will take me some time :)

Thanks @avignd . Let us know if you can help anywhere or answers any questions. We are available on https://slack.open-metadata.org

done [here](https://github.com/open-metadata/OpenMetadata/pull/1177
@harshach can we close the issue?


GNU Fortran compilers misidentified as Cray compilers on Cray machines

I work primarily on the NERSC Cori and Perlmutter machines, which are maintained by Cray but offer compilers from several different vendors. The recent PR #3712 added support for Cray compilers, but on Cray machines it incorrectly identifies standard GNU compilers as Cray compilers. This causes compilation errors when flags intended for Cray compilers are passed to gfortran.
In more detail, when the f_check script performs a test compilation on ftest.f using GNU Fortran 11.2.0, the output on the NERSC machines is
        .file   "ftest.f"
        .text
        .p2align 4
        .globl  zhoge_
        .type   zhoge_, @function
zhoge_:
.LFB0:
        .cfi_startproc
        pxor    0mm1, 0mm1
        movapd  0mm1, 0mm0
        ret
        .cfi_endproc
.LFE0:
        .size   zhoge_, .-zhoge_
        .ident  "GCC: (GNU) 11.2.0 20210728 (Cray Inc.)"
        .section        .note.GNU-stack,"",@progbits

Importantly, both the words GNU and Cray appear, and because Cray is checked first in f_test the compiler is identified as a Cray compiler. This causes several compilation issues, including no -fopenmp flags even when USE_OPENMP = 1 and no additional libraries identified as necessary when linking FORTRAN code.

Could you please check if reordering the two cases in f_check does fix this ? Unfortunately I do not have access to these systems, and while misidentifying vendor would almost certainly break library detection I do not see how the -fopenmp would get suppressed.

After reordering the two cases I can compile with no issues.
I'm not familiar with Cray compilers, but based on the Makefiles it seems that OpenBLAS handles Cray + OpenMP as follows
https://github.com/xianyi/OpenBLAS/blob/667d0e0b48ee1170ef0e918545cc31cc30a910c1/Makefile.system#L1287-L1298
The only action is to add -O noomp when OpenMP is NOT requested, which is not sufficient if the underlying compiler is actually gfortran.


Remove redundant type parameters and enforce some other style and inspection rules

Various changes about druid-services module:

Fix calling to toArray() with pre-sized array argument for better performance;
Use lambda to complete the initialization of Module / Runnable / Accumulator;
Remove unuesed import;
Improve if-return clause;
Use Set#addAll instead of for loop;
Use Collections.<...>singletonList instead of Arrays.<...>asList for single element situation;
Use file.toURI().toURL() instead of file.toURL();
Remove unnecessary unboxing;
Put the string object in front of the equals method;
Use Collections.<StorageLocationConfig>emptyList() instead of Arrays.<StorageLocationConfig>asList();
Add a few coding inspection rules, includes ArraysAsListWithZeroOrOneArgument, RedundantTypeArguments and ToArrayCallWithZeroLengthArrayArgument;
Add a few regexps about String#equals and toArray(new Object[0]) into checkstyle config file.

job-402722329 and job-402722330 both failed...
job-402722329:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project druid-processing: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /home/travis/build/apache/incubator-druid/processing && /usr/lib/jvm/java-8-oracle/jre/bin/java -Xmx768m -Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8 -Duser.timezone=UTC -Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager -Ddruid.indexing.doubleStorage=double -jar /home/travis/build/apache/incubator-druid/processing/target/surefire/surefirebooter678641966742689650.jar /home/travis/build/apache/incubator-druid/processing/target/surefire/surefire1266228946009469426tmp /home/travis/build/apache/incubator-druid/processing/target/surefire/surefire_14722988346361641729tmp

It seems that -Xmx768m is not enough, may we should add -Xmx2048m -Xms512m for maven-surefire-plugin in druid-processing module?
job-402722330:
CuratorDruidCoordinatorTest.testMoveSegment:369 »  test timed out after 60000 ...

After PR#5978, sometimes the timeout value is still not enough.

The last commit is not related to this PR. Please make it as another one.

@asdf2014 sure, I'll restart failed jobs if they're transient. BTW, the size of this PR looks suddenly increased. What commit has increased the size?

These commits are a bit large.. :sweat_smile:

Under the advice of @leventov . After adding ToArrayCallWithZeroLengthArrayArgument & ArraysAsListWithZeroOrOneArgument & AliEqualsAvoidNull into intellij inspection profile, I automatically fix the entire project's coding inspection problems through the intellij idea tool.

@asdf2014 thanks. I'll take another look.

@leventov You are welcome. The amount of code is large and very troublesome. May have to trouble you. :+1:

Hi, @jihoonson . jobs-403482349 failed again.. Could you please rebuild it?

@asdf2014 restarted the test. Will take a loot again.

@jihoonson Thanks a lot :D

@jihoonson It works. Thx again. :+1:

@asdf2014 CI build fails: https://teamcity.jetbrains.com/viewLog.html?buildId=1522741&tab=Inspection&buildTypeId=OpenSourceProjects_Druid_InspectionsPullRequests

Sorry, i didn't notice it. I will fix it. Thanks for your comments. @leventov

Hi,  @leventov . It has been fixed. BTW, jobs-405249198 failed because vm crashed. Would you please help me rebuild it once?

@leventov It seems that both travis and teamcity have succeeded. Any other good suggestions?

Hi, @leventov . Thanks for your review. The RedundantTypeArguments has been added as an ERROR level check and teamcity has also been passed. PTAL.

@asdf2014 would you update the PR description to include additional changes? E.g., Added new inspection/checkstyle rules.

Hi, @jihoonson . Thanks for you comments. Added.

Thanks @asdf2014! The latest change looks good to me.
One side comment: usually, you can expect your PR can be reviewed faster as your PR contains less changes because it's much easier to review. It would be great if you can split your PRs if possible in the future.

@jihoonson Thanks for your suggestion about the PR stuff. This is very helpful for me. I will notice it. :+1:


chore: release 4.0.1

:robot: I have created a release *beep* *boop*
4.0.1 (2021-05-28)
Bug Fixes

bad temporary directory path (3d7d9f1)
cannot run loader when run mili init (1b4bda9)
cannot run without hooks config (240e59b)
mili.extends cannot set as string (58da479)

Performance Improvements

increase the running speed and add the progress bar (f6c9281)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mili-project-manager/mili/releases/tag/v4.0.1 :sunflower:


Equation for the Scalar Length l_i in the Actuator Transmission for Hinge Joints

Hi,
I'm an engineer, and I'm trying to use MuJoCo for a research project.
I'm looking for some help with the model behind the actuation model for a hinge joint, to be precise.
In https://mujoco.readthedocs.io/en/stable/computation/index.html#force-generation, there is a reference to a function $l_i(q)$ (scalar legnth) and it's derivative $\dot{l}_i(q,v)$  in the scalar force $p_i$.  Can someone give me or point me into an equation for that function?
Besides, I would interest the correspondence of the XML parameters to that equation.
I would guess that parameters described here https://mujoco.readthedocs.io/en/stable/XMLreference.html#body-joint somehow affect this equation, is this correct?
Here is a model which explains my question:

minimal XML
This is xml-snippet out of the Sawyer model within https://github.com/google-deepmind/mujoco_menagerie and I think we could do some model identifaction for Sawyer or have done some model identification in the past, so I could be able to dig up our parameters.
However, I don't really understand the below parameters affect the model in MuJoCo. Thus, I can compare them to our models.
<mujoco>
  ...
      <default class="large_joint">
        <joint frictionloss="0.3" armature="1" damping="0.1"/>
        <general gainprm="800" biasprm="0 -800 -80" forcerange="-80 80"/>
      </default>
</mujoco>

The length of a joint transmission is just the joint angle. Read the function mj_transmission for details regarding this and all other transmissions.

For other details regarding actuation, (e.g. bias/gainprm), read mj_fwdActuation.


Snap filter feGaussianBlur?

Can Snap do blurs with a stDeviation instead of just with x, y?
If not is there a conversion or a slightly different method that snap uses?
http://snapsvg.io/docs/#Snap.filter.blur

x,y is the stdDeviation in this case to my understanding (not quite sure if that answers your question).

Ok, my question then is how do they correlate to one another? Because std is a single number and x,y are two.
(Might be a dumb question, sorry if I'm missing something obvious.)

stdDeviation can be a single number or two numbers.
If it's 2 numbers, the blur will vary in how much it blurs horizontally or vertically. Eg stdDeviation of 0,10 would pretty much only blur in the vertical iyswim.

@ibrierley Ok, that makes sense. But does Snap default to applying the stDeviation, if it's a single number, in the x direction or does it apply the std to both x and y?

So here's the code...
        if (x == null) {
            x = 2;
        }
        var def = y == null ? x : [x, y];
        return Snap.format('\<feGaussianBlur stdDeviation="{def}"/>', {
            def: def
        });
    };

So looks like if there is no x, a default of 2 is applied. If there is no y then a single x is applied. But if a single x has applied, then that is actually applied to both (that bits not in the code, just in how stddeviation works)
So blur() would effectively be 2,2
blur(0,3) would effectively be 0,3
blur(3) would effectively be 3,3
blur(3,0) would effectively be 3,0
I think (not tested)

Closing as no further issue raised


How I can change size on input?

Hello
I want change size for input element when it not include in form because not want focus element left on input.
Thank You! Awesome frameworok

I also wish to be able to set the width of an input element. Setting the font size affects the height, too, which is not desired. The reasoning behind this is I have a longer placeholder text than the current width allows for.
Would be great to have a variable the input.less file like @width that we can override in our site or theme files.

Do you need the input size to be responsive?
If not, you can try using the size option:
<input type="text" placeholder="placeholder" size="50">

If you just want to specify width on an individual field i recommend oldschool
<input type="text" placeholder="placeholder" size="50">

.my.input {
  width: 400px; /* arbitrary amount */
}


Allow restore to actually exec/create the libcontainer

Right now, you can restore any image into a container, so long as that container has been started and then checkpointed. This patch lets you restore an image into a brand new container, without first requiring you to start and checkpoint it.

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "restore-unstarted-container" git@github.com:boucher/libcontainer.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

LGTM


Release 1.9.1

Haha, there is no rule that one has to go from 1.9 to 2.0, we can just continue with 1.10.
But perhaps we should just claim "2.0" at some point 😄

I do not get why the tests are suddenly failing...

I do not get why the tests are suddenly failing...

Code unnaturally breaking for no reason? That's a sign from the Code gods that it's time for a break.


Improve Breadcrumb with microdata

Current Breadcrumb component works great, but it isn't recognized by any search engines.
To fix that, we need to use microdata or JSON-LD (so it might be related to https://github.com/LotusTM/Kotsu/issues/84)
Though, both will work, I'm yet unsure about best approach.
Example of JSON-LD:

Microdata allows to keep data with relevant html-code, but it will result in additional attributes:

        Books

    <meta itemprop="position" content="1" />

  ›

      Science Fiction

    <meta itemprop="position" content="2" />

  ›

      Ancillary Justice

    <meta itemprop="position" content="3" />

There is no big difference for us — it will generate approximately similar amount of code. However, working with microdata might be slightly easier, because breadcrumb already generated and we can simply embed that data inside already existing component. However, will mix of JSON-LD (we will need one anyway for whole site) work well with microdata?..

After a brief search I came up with this info:

JSON-LD is preferred by google and helps create rich snippets (see)
JSON-LD don't have schema for Breadcrumbs (see the same link)
Combining both JSON-LD and microdata should not have any negative impact (a dude from Google said it's OK, see)

More info:

microdata, RDFa, JSON-LD best usage
you can use different syntaxes (and vocabularies) in the same document

Google and Yandex works with both of those perfectly well, and functionality is very similar, because JSON-LD was developed just as an alternative syntax for same vocabularies.
I understand that having both doesn't hurt, but maintaining few different systems at same time does. Some people says that it's "possible" to parse Microdata and output it as JSON-LD, and that for most cases it will be valid JSON-LD, but it's hard to tell how real it is.

JSON-LD don't have schema for Breadcrumbs (see the same link)

JSON-LD is just a syntax for displaying properties based on vocabulary. Schema.org does have breadcrumb property, and it can be expressed as JSON-LD. The other thing that few years have passed, but Google still didn't add support of JSON-LD fully (including those breadcrumbs) despite aggressive advertisement of standard, which rises some concerns...
Also worth mention that probably we should talk not about Microdata, but about RDFa syntax, since it seems to be more popular nowadays (not sure, though).

Actually, Google seems to support JSON-LD breadcrumbs, see example here: https://developers.google.com/search/docs/data-types/breadcrumbs
Also there seems to be some libs which can parse Microdata or RDFa and output JSON-LD, like this one https://github.com/Janpot/microdata-node or https://github.com/scienceai/jsonld-rdfa-parser

After consilium, we decided to go with RDFa syntax and Schema.org as vocabulary.
Reasons:

Microdata officially terminated by W3C thus will eventually die. RDFa is current replacement for it.
Microformats almost dead.
JSON-LD only partially supported by Yandex (for Yandex Mail), this making it ineffective choice when working with not only Google as search provider.
JSON-LD can be generated by parsing RDFa markup, thus eliminating the need to support both formats manually. With relevant plugin, we can receive JSON-LD as a bonus.
Schema.org is the most popular vocabulary by now and widely supported by search providers, so it will be used as base vocabulary.

JSON-LD part related to #84

Useful docs about validation: https://habrahabr.ru/company/yandex/blog/265965/

List of Kotsu elements that should be represented as RDFa structure:

Breadcrumb
?

Right now we're covering pretty extensive list of structured data supported by Google.
Here marked embedded into Kotsu out of box structured data from Google structured data list:

Everything else seems to be too opinionated (Reviews, Products).
Those few entries seems to be useful quite often:

https://developers.google.com/search/docs/data-types/corporate-contacts
https://developers.google.com/search/docs/data-types/local-businesses

But still sounds like a bit too opinionated, since good portion of website might not have local address or phone numbers (Google seems to not care about emails, only numbers)
Besides, Local Business structure data seems to be slightly useless, since Google prefers driven through pointed on Google Map method.
Still, have to check Yandex, since they support slightly extended data structures, but, on other side, it isn't that clear when and how do they.

[ ] Check Yandex structured data: https://yandex.com/support/webmaster/supported-schemas/address-organization.html

Nicely done 👍

Okey, managed to write some documentation about Kotsu Structure data: https://github.com/LotusTM/Kotsu/wiki/Structured-data

[ ] Question to myself: should blog posts be marked as BlogPosting or NewsArticle? Unfortunately, Schema.org doesn't clarify difference between them.

Made some additions to tasklist from last post.

Okey, it seems that there is nothing new Yandex structure data brings to table, except some specific data types which we can't add to Kotsu.

Like what?

Well, from what Yandex lists, we implementing only following:

Everything else seems to be opinionated.
ImageObject for each image is questionable, since it will force slightly harder markup.


Attempt #2 to implement a working newsletter

Changelog:

Built newsletter via SendStack
Built contact form via Formspree
Added Google Analytics
Added support for Bing IndexNow
minor SEO optimisation
minor content edit


#6223 Added test proofs working dynamiclly added drivers.

@scottdraves
Probably the reason of failure build was missing library in os which runs jenkins. To avoid installing additional libraries I changed implementation of embedded database from mysql to postgresql.


Add delta_scan function

Summary
Similar to csv_scan and parquet_scan, just instead for reading delta tables. Initial pass will probably just be for local files, then follow on for gcs/s3.
Specifications

Rationale

Impact

Tasks

add support for gcs, s3 in the other _scan functions (handling credentials etc)
then implement delta_scan

Do #1249 first or with this

This should no longer be blocked with @vrongmeal's creds works.


Fix temporally disable array inverted index case

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


DNS zone import creates absolute names instead of relative

Environment summary
Install Method: curl -L https://aka.ms/InstallAzureCli | bash
CLI Version:
azure-cli (2.0.2)

acr (2.0.0)
acs (2.0.2)
appservice (0.1.2)
batch (2.0.0)
cloud (2.0.0)
component (2.0.0)
configure (2.0.2)
container (0.1.2)
core (2.0.2)
documentdb (0.1.2)
feedback (2.0.0)
find (0.0.1b1)
iot (0.1.2)
keyvault (2.0.0)
lab (0.0.1)
monitor (0.0.1)
network (2.0.2)
nspkg (2.0.0)
profile (2.0.2)
redis (0.1.1b3)
resource (2.0.2)
role (2.0.1)
sql (2.0.0)
storage (2.0.2)
vm (2.0.2)

Python (Linux) 2.7.13 (default, Jan 13 2017, 10:15:16)
[GCC 6.3.1 20161221 (Red Hat 6.3.1-1)]

OS Version: Linux Fedora 24 (4.9.13-101.fc24.x86_64)
Shell Type: bash
Description
When running a zone import e.g.:
az network dns zone import -g my-rg -n mydomain.com -f mydomain-zonefile.txt

where mydomain-zonefile.txt has the following content:
@     600     IN      SOA     ignored.com. hostmaster.mydomain.com. (
<PHONE_NUMBER>
                                28800
                                7200
                                604800
                                600
                                )

test    3600    IN      A       <IP_ADDRESS>

The relative domain record "test" is imported into Azure DNS as absolute value test.mydomain.com instead of relative value test, meaning that lookup test.mydomain.com.mydomain.com works and test.mydomain.com fails.

Thanks for flagging, will take a look

@jtuliani I've taken a look at this. The CLI expands these entries to their fully qualified form when it parses the zone file. Then, to create the record sets, it strips the trailing dot. This is why his entry resolves to "test.mydomain.com.mydomain.com". If I try to create the record set with the trailing dot, I get a service error.
I could strip the origin back off (making them relative again), which would fix the user's original issue, but then how would you handle something like:
@     600     IN      SOA     ignored.com. hostmaster.mydomain.com. (
<PHONE_NUMBER>
                                28800
                                7200
                                604800
                                600
                                )

test    3600    IN      A       <IP_ADDRESS>
$ORIGIN somethingelse.com
other

Now other would not resolve to other.somethingelse.com.  Thoughts?

Hi Travis. The logic should be something like:

Parse the record name
If the record name is relative, add on the current value of $ORIGIN (which can change from time to time), to get the FQDN
Remove the zone name (which stays constant throughout the import)
Remove trailing dot
Use the result as the record name (or if you have an empty name at this point, use '@' instead).

At step 3, the FQDN should always end with the zone name. If not, then there was an error earlier, either in the record name or in the value of $ORIGIN.

Yes, but what happens in step 2 when the record name is not relative?

If the record name is not relative, then it IS the FQDN so step 2 just uses it as-is. The value of $ORIGIN is not used in this case. The FQDN must end with the zone name, otherwise an error will occur at Step 3.

So if you have a full qualified name that doesn't end with the zone name, that's an error?

So if you have a full qualified name that doesn't end with the zone name, that's an error?

@tjprescott The CLI is explicitly importing into that zone. So if the import file contains unrelated zone information, I would say you could just ignore it, with a warning to the user that it was skipped due to a zone mismatch.

@rocketraman that's what it currently does after I merged #2825.

Yup, warn+skip is OK


Error when try to remove youtube watermarks

Environment details

OS: Windows 10
PHP version: PHP 7.2.19 (cli) (built: May 29 2019 13:58:59) ( ZTS MSVC15 (Visual C++ 2017) x64 )
Package name and version: "google/apiclient": "^2.7"

Code example
<?php

require_once __DIR__ . '/vendor/autoload.php';
$client = new Google_Client();
$client->setScopes([
    'https://www.googleapis.com/auth/youtube.force-ssl',
]);

$credentialsFile = './client_secret.json';
$client->setAuthConfig($credentialsFile);
$client->setAccessType('offline');

// Request authorization from the user.
$authUrl = $client->createAuthUrl();
printf("Open this link in your browser:\n%s\n", $authUrl);
print('Enter verification code: ');
$authCode = trim(fgets(STDIN));

// Exchange authorization code for an access token.
$accessToken = $client->fetchAccessTokenWithAuthCode($authCode);
$client->setAccessToken($accessToken);

// Define service object for making API requests.
$service = new Google_Service_YouTube($client);
try{
$service->watermarks->unset('UCiBfuUreTbKvBKtQbb6SIWQ');
}catch(Exception $e){
	echo ($e->getMessage());
}

Error
Fatal error: Uncaught Error: Call to undefined method Google_Service_YouTube_Resource_Watermarks::unset() in C:\laragon\www\How-to-remove-Youtube-watermarks-using-php-\main.php:26
Stack trace:
#0 {main}
thrown in C:\laragon\www\How-to-remove-Youtube-watermarks-using-php-\main.php on line 26
Thanks!

The method name is unsetWatermarks().

Thanks its work .  but can you put it back to unset the youtube api tell that use unset not unsetWatermarks().
fell free close this thanks you .

Unset is a reserved word in PHP versions prior to PHP 7.0. It cannot be used as a method name.


Open API Docs for /application endpoints

Signed-off-by: Aditya Chaterjee<EMAIL_ADDRESS>Description
Added swagger docs to Application endpoint.
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Heads-up: a conflict - https://github.com/meshery/meshery/pull/3658/conflicts

Heads-up: a conflict - https://github.com/meshery/meshery/pull/3658/conflicts

Oh no.

This has the same PR subject as #3643. Is this a duplicate? // @sayantan1413

@leecalcote no, actually @sayantan1413 and I are working on this together so these are different than the ones he's done.

Yes @leecalcote this is for a different endpoint.😃

Hey @warunicorn19 can we be a bit quick here??

Yes sorry, I'll put in the PR tonight.

hey @piyushsingariya, I've tried a lot to understand the handler, but couldn't understand it, i still think it is not returning anything. I'm really stuck😬.

Heads-up: a merge conflict.

hey @piyushsingariya, I've tried a lot to understand the handler, but couldn't understand it, i still think it is not returning anything. I'm really stuckgrimacing.

That handler is a GET handler for applications, so of course, this may be returning some application struct. @sayantan1413 would you help @warunicorn19 here.

Hey @warunicorn19 in the doc.go file add this

// Returns all meshery applications
// swagger:response mesheryApplicationsResponseWrapper
type mesheryApplicationsResponseWrapper struct {
	// in: body
	Body models.ApplicationsAPIResponse
}

and use the mesheryApplicationsResponseWrapper in the GET response.
Also please resolve the merge conflict .
// @piyushsingariya  I think this is the required solution for the GET response for the Applications API .

cool @sayantan1413 I'm closing this PR and creating a new one, because i sort of messed up on this branch


support for Silabs EFM8BB2

Hi Oskar and all,
I think it would be useful, sometime in the future, to software support Silabs EFM8BB2 (and other) family of CPUs. The case is that this CPU is used for many ESCs for copters that now run bheli firmware and all these ESCs can be reprogrammed with your firmware! For example, DYS XSD 30A is such ESC (about 15USD on banggood). This means that there will be plenty cheap hardware from various manufacturers that will be able to drive any brushless motor for robotics. The immediate availability of the HW, will greatly accelerate the development of this project!
Thanks for the great project!
Spiros

Hey papage, thanks for your input.
I think the class of 8-bit processors commonly used on hobby ESC's don't really have the computational power required to run the algorithms I am using for the ODrive.
Also, I run FOC control, which requires phase current feedback sensors. I don't think I have seen any ESC's that have that kind of hardware.
Nevertheless, thanks for the tip!


Add Python 3.8 to be tested as well

There is no Python 3.8 on Azure... That is funny...
Let's wait a couple of weeks to see if they are going to add it

Related to https://github.com/microsoft/azure-pipelines-image-generation/issues/1317

ok!

It's landed on Github Actions, and is rolling out on Azure; I would expect it soon.

Well, now we have Python 3.8. However, we do not have the whole dependencies on conda-forge for python 3.8 :sweat_smile:

yeah, I think we need to wait until the dependencies are there too

It seems there is a bug on xonsh which needs to be addressed or we can pin an older version of xonsh.

Yeah, I should release a new version of xonsh.  Hopefully I can get to that today.

Or rather @marcelotrevisani - what do you think the bug is?

Or rather @marcelotrevisani - what do you think the bug is?

I didn't investigate it much further (because I'm still at my work), but it seems the shell object was not created and it is returning a None object. The reason behind it I still don't know.
So, basically it calls the print_color
def print_color(string, **kwargs):
    """Prints a string that may contain colors. This dispatched to the shell
    method of the same name. Colors will be formatted if they have not already
    been.
    """
    builtins.__xonsh__.shell.shell.print_color(string, **kwargs)

However, builtins.__xonsh__.shell is returning None


[FLINK-27088][BP-1.15][Documentation] Fix the example of using StringDeserializer for deserializing Kafka message value as string

This is a 1.15 backport of PR https://github.com/apache/flink/pull/19375
[FLINK-27088][Documentation] Fix the example of using StringDeserializer for deserializing Kafka message value as string

What is the purpose of the change
This pull request fixed the example of using StringDeserializer for deserializing Kafka message value as string.
Brief change log

Replacing StringSerializer with StringDeserializer

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

This is a 1.15 backport of PR https://github.com/apache/flink/pull/19375

@flinkbot run azure


React-geosuggest with react-formsy

Hi,
Would be nice to integrate it with react-formsy:
https://github.com/christianalfoni/formsy-react
Regards!

What would this look like? I haven’t heard of formsy-react before.

Reopen with information on what would be needed to make it compatible.

I'm also interested in this:
https://github.com/mbrookes/formsy-material-ui/issues/122


Replace Alpine Nginx Container with Chainguard Caddy Container

This is a relatively large PR for this repo. All changes are in a bulleted list below.

Changed from Nginx to Caddy, which is easier to configure and maintain.

Updated the README with new installation instructions and removed obsolete files related to Nginx and Certbot.

Moved from an Alpine docker container to a Chainguard docker container. This reduces the attack surface, number of dependencies, and guarantees nightly rebuilds to keep up with the latest security updates.

Reduced the total number of containers required for Signal's TLS proxy from 3 to 1

Marked volumes as ro for read-only and Z to support SELinux support

[x] Contributor licensing agreement has been signed

Thanks for the PR. We're not looking to migrate off of nginx in this project. Same with alpine — I'm sure chainguard would be fine, but we think alpine gets us the best tradeoff of stability, maintainability, and security. Likewise, we're not going to suggest a malloc fork as part of this project. Advanced users are welcome to customize their configuration as they see fit. If you'd like to discuss any of your smaller changes, please open a new PR.
While we don't think this project is the right place for some of your proposed changes, folks are free to run their own compatible proxy configurations. We're looking at adding some test cases to this repo to help folks validate their custom proxies.


Update semanticdb-scalac to 4.4.22

Updates org.scalameta:semanticdb-scalac from 4.4.21 to 4.4.22.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "semanticdb-scalac" } ]

labels: library-update, semver-patch

Superseded by #540.


align Private Cluster PE limitations

align Private Cluster PE limitations with PE Limitations

@TomGeske : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mlearned @laurenhughes - Could you review the proposed updates? Thanks.

#sign-off

@laurenhughes: I'm sorry - only the author of this article, @mlearned, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Thanks for your review, @laurenhughes


Caused by: java.net.BindException: Address already in use

I have a microservice development environment.  I have 3 services: A, B, C
A is the one I am currently doing local development, and will run Java Spring Boot as gradle bootRun to run it locally.
A needs services B, C to function.
How do I use kubefwd to only forward B and C, but not A, so I won't get the following error when running bootRun on service A locally.
Caused by: java.net.BindException: Address already in use

You can use selectors to choose what services you wish to bind to.
However, you can avoid the error you see if your local service listens on <IP_ADDRESS> and not <IP_ADDRESS> (all interfaces). kubefwd sets up separate internal interfaces 127.1.x.x so it can forward multiple services using the same port.

@cjimti Can kubefwd forwards to localhost or <IP_ADDRESS> by defaults?
in my chase, it forwards to hostname curl B:10007/api/foobar

kubefwd uses many 127 addresses and leaves <IP_ADDRESS> (localhost) for you to bind your local services to. I don't know Java Spring Boot but you should look into how to start you service on a specif IP like <IP_ADDRESS>. <IP_ADDRESS> is probably the default.

@cjimti quick question for you
Does kubefwd has something for .kubefwdconfig that stores in global and local path? We can set it in a config file which lets us use selector to choose what it can be exclude/include for the address to forward.

Check out the kubectl examples using selectors. Kubefwd uses the same -l argument https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#list-and-watch-filtering

Check out the kubectl examples using selectors. Kubefwd uses the same -l argument https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#list-and-watch-filtering

Got it, thanks.
Do kubefwd team plans to implement something like .kubefwdconfig in the future?

Sounds like you could just create command aliases such as:
alias fwdx=sudo kubefwd svc -n project_ns -l "app in (B, C)"

Sounds like you could just create command aliases such as:
alias fwdx=sudo kubefwd svc -n project_ns -l "app in (B, C)"

The reason I asked is, we can check in the per project .kubeconfig file, and share with our teams too.
Just a thought.

Thanks for the suggestion, if I understand the request right I think it's out of scope for kubefwd. Higher-level tooling would do a better job, like shell scripts make, etc..


Fix duplicate path navigation

Bug/issue #, if applicable: 89718125
Summary
Allows navigating to items in the navigator, that have the same path as the currently open item.
Dependencies
NA
Testing
You need a doccarchive that has duplication in the children, inside the tree. You can use the attached one.
SlothCreator.doccarchive.zip
Steps:

Serve the app using the above doccarchive
Navigate to Sloth > Sloth Generator > func generateSloth
Assert item is highlighted, and its parents
Navigate to Sloth Generator > func generateSloth
Assert item is highlighted and its parents. The previous item is not collapsed.
Navigate back/forward and assert they are properly highlighted
Refresh the page
Assert highlighting continues
Assert that open items are kept open
Assert that when navigating links in the page content, the sidebar properly highlights them.
Assert that links that are in the viewport and dont need scrolling to get highlighted, do not cause the navigator to adjust scroll position.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

@swift-ci test

@swift-ci test


Add awesome list of software tools and resources

Add a new Markdown file with an awesome list of software tools and resources.

@leouieda @indiauppal I created a small Markdown file with some tools that might be interesting for anyone in the lab. The file lives in the root of this repo, but feel free to propose another home for it.

Thanks @santisoler! Great stuff and I already opened some of those links to read later 🙂
How about renaming the file to just resources.md to make the URL a bit shorter?
@indiauppal feel free to comment and make suggestions before we merge this (look at the "Files changed" tab where you can leave comments on individual lines). Also feel free to add things to the list later after it's merged.

Thank you @santisoler for creating this!!!
I'm happy for you to merge. As I come across useful resources I'll add them.
I've made a comment about Overleaf - a LaTeX editor. It has lots of templates, the UG dissertation students might find it useful because they have less time to learn LaTeX.

I've just renamed the file to resources.md after @leouieda suggestions.
I've added Overleaf, as @indiauppal pointed out, but moved it under "Online services".
I've also added the guide for writing commit messages that @SAskevold shared on Slack.


Sort the Protofiles to have deterministic order in surface

One approach to fix https://github.com/googleapis/gapic-generator/issues/2319.
Order the enum messages (classes) by name, and then order the enums inside those messages by name.

Codecov Report

Merging #2453 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2453      +/-   ##
============================================
+ Coverage     86.53%   86.54%   +0.01%
- Complexity     5289     5291       +2
============================================
  Files           458      458
  Lines         21055    21058       +3
  Branches       2298     2298
============================================
+ Hits          18219    18225       +6
+ Misses         2011     2008       -3
  Partials        825      825

Impacted Files
Coverage Δ
Complexity Δ

.../google/api/codegen/config/GapicProductConfig.java
71.76% <100%> (+0.08%)
53 <0> (ø)
:arrow_down:

.../transformer/py/PythonGapicSurfaceTransformer.java
99.56% <100%> (+1.27%)
43 <0> (ø)
:arrow_down:

...a/com/google/api/codegen/config/ProtoApiModel.java
93.02% <100%> (+0.91%)
19 <2> (+2)
:arrow_up:

...transformer/py/PythonImportSectionTransformer.java
98.44% <100%> (ø)
69 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1add5a8...ba18685. Read the comment docs.

Waiting for https://github.com/googleapis/gapic-generator/pull/2443 to get merged so we can test all artman targets.

See https://github.com/googleapis/google-cloud-python/pull/6707 for what happens when this PR is used to generate logging.

output lgtm


Failed prop type: Invalid prop 'component' supplied to 'Route': the prop is not a valid React component

I have a reference to an object containing getComponent(...) method for obtaining a React component.
I try to render this component inside a nested route like so:
const component = React.cloneElement(object.getComponent(...), {...});
<Route path={`home/${object.route}`} component={component}/>;

and I get the following error:
Failed prop type: Invalid prop 'component' supplied to 'Route': the prop is not a valid React component.
I've seen similar issues like 6741
where the issue is resolved by upgrading the library version to<EMAIL_ADDRESS>but my dependencies are up-to date:
"react": "^16.4.2",
"react-dom": "^16.4.2",
"react-router-dom": "^5.0.0"

Any ideas on how can I solve this problem ?

Do you also have react-is installed? That needs to be the same version as React for it to work.


Fixes #32429 Added PICS guard to steps in TC_EEM_2_1

Fixes #32429

[x] TC_EEM_2_1 Adds PICS guard to steps in
[x] TC_EEM_2_2 Corrects top level PICS guard
[x] TC_EEM_2_3 Corrects top level PICS guard
[x] TC_EEM_2_4 Corrects top level PICS guard
[x] TC_EEM_2_5 Corrects top level PICS guard
[x] TC_EEVSE_2_4 Small comment description fix for test plan reference
[x] TC_EEVSE_2_5 Small comment description fix for test plan reference & added check for StartDiagnostics PICS
[x] TC_EPM_2_2.py - added PICS guard check for specific attributes ActiveCurrent and Voltage

Note:
TC_EPM_2_1 already has PICS guard checks for supported Attributes.
TC_EEVSE_2_2 already has a PICS guard check for the only optional attribute, all others are mandatory.

@raju-apple is this needed for SVE?

@woody-apple yeah want this to be in the SVE branch so that the final image for 1.3 includes it


Wordpress Issue 403 - Forbidden. Your domain is probably not allowed on Codapi.

When attempting to embed within my WordPress site (sqlshortreads.com), I receive the following error:
403 - Forbidden. Your domain is probably not allowed on Codapi.
See the image below.

The Codapi cloud is in private beta. I think you've never applied, hence the "403 Forbidden" error. Now I've enabled your domain, so the snippets should work.
If you don't want to depend on the Codapi cloud, you can use in-browser playgrounds.

Thank you.
I haven't been able to get the PostgreSQL in-browser playground to work with WordPress. Keep in mind, this could entirely be user error but I've simply pasted what was provided in the example code. If I switch up the order of the scripts, then I get no result.


enable testing with python 3.6 (do not merge)

Enable running tests against python 3.6

@purificant: we'll merge this once several known issues for Python 3.6 are resolved, and we can check progress by getting the CI server to retest this PR, without needing to merge just yet.
https://github.com/nltk/nltk/labels/python3

Thanks for explaining @stevenbird

Anyone working on #1659 ?

[CI: retest]

[CI: retest]

@stevenbird Do we need to setup extra workflow on Jenkins to run Py36 tests?

@alvations: happy to do this, and see how we get on...

@stevenbird looks like the configuration wasn't set up correctly: https://nltk.ci.cloudbees.com/job/nltk/TOXENV=py34-jenkins,jdk=jdk8latestOnlineInstall/763/console =(

@alvations - yes, trying to work out what I did wrong

It looks like Python 3.6 is not available, cf https://repository-cloudbees.forge.cloudbees.com/distributions/ci-addons/python/fc17/
I submitted a support request.

Cloudbees is working on setting up 3.6 but might not be right away. ttps://support.cloudbees.com/hc/requests/56274

c.f. https://github.com/nltk/nltk/pull/1942

Thanks @purificant for starting this PR!
The Jenkins server with tox should work on Py3.6 now =)

Thanks for the merge, glad to see tests running on py3.6 !


Update offlineaa.mdx

🚀 Deployed on https://634879f28393900c4c686e9d--cozy-fox-0defec.netlify.app


#46 change i32 to u32: perf

Status
Implementation done
Description

fixes #46
Ran cargo check to assure no breaking changes

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[x] 🗑 Chore

Hey @nachiketkanore, thanks for your PR, I have run tests on your PR and its working perfectly fine,
thank you again to contribute to gitfetch


Can't modify the meta

Same issuse as #5314 . But still exist in version 1.14.0.

Thanks for pointing us here, we discuss it with our engineering team.


workbox-background-sync should allow SyncManager.register options to be set

Library Affected:
workbox-background-sync
Browser & Platform:
All supporting browsers (currently only Chromium-based)
Issue or Feature Request Description:
The options for SyncManager.register used by workbox-background-sync are currently left to defaults. However, I would like to be be able to change these options.
The interface could look like this:
export interface QueueOptions {
  onSync?: OnSyncCallback;
  maxRetentionTime?: number;
  syncRegistrationOptions?: {
      id?: never;
      allowOnBattery?: boolean;
      idleRequired?: boolean;
      maxDelay?: number;
      minDelay?: number;
      minPeriod?: number;
      minRequiredNetwork?: 'network-any' | 'network-offline' | 'network-online' | 'network-non-mobile';
  };
}

Where id is forced by the plugin to be ${TAG_PREFIX}:${this._name}, as is the current tag value. I'd re-use the typings from lib.dom.ts but it doesn't include the types for these options yet.

I am not sure that the MDN documentation is correct; the specification says that the register() method of a SyncManager only takes a single string parameter representing the tag, which is what workbox-background-sync passes:
https://github.com/GoogleChrome/workbox/blob/03055e64014a46f6cc977a3a50ad814c6409d36a/packages/workbox-background-sync/src/Queue.ts#L352-L354
Given that some of those options look like they're associated with PeriodicSyncManager, I think there was a mix-up when these MDN docs were created. I'll follow up with the MDN folks.

C.f. https://github.com/mdn/content/issues/8893

O wow, guess there's a first time for everything :-D
Thanks for looking into it!


DCO Sign Off: Fix broken link

Fixes https://github.com/cert-manager/website/issues/652.

Thank you for spotting the issue and for submitting the fix!
/approve
/lgtm

/ok-to-test


Further ahead

[Enter feedback here]
Hi, please could you publish more dates, our customers need to plan the next 12 months and we only have the next 6 months listed. Even if they are subject to change.
thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e7dcb285-f32c-c92e-fe49-1617f213066b
Version Independent ID: 8f28c1a0-9da5-f853-90ee-d82a4c32df7e
Content: Service update availability - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/fin-ops/get-started/public-preview-releases.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @hmahl
Microsoft Alias: hmahl

Bug 834384 has been logged to address this issue.

@jimwillsher, thank you for your feedback. This article has been updated.


Transactions don’t leave the mempool

Hey there!
We detected that sometimes transactions hang in the mempool for quite a long time, often they do not leave at all. We set the commission slightly higher than the recommended one.

@abdelhamidbakhta to provide stress test tool

https://github.com/ConsenSys/eip1559-tx-sender

we have made changes in the tx pool, can you let us know if you still have this problem with the most recent version.

cc @wetryingtodorock can you confirm if the latest updates have solved your issue?

Hey @wetryingtodorock, closing this issue for now but please reopen if you see it reappear!


Add Distribution class

This PR adds a functional Distribution class, to be used for collecting stats.

Codecov Report

Merging #196 into master will increase coverage by 0.15%.
The diff coverage is 98.07%.

@@             Coverage Diff             @@
##             master    #196      +/-   ##
===========================================
+ Coverage     94.44%   94.6%   +0.15%
- Complexity      380     401      +21
===========================================
  Files            53      54       +1
  Lines          1189    1241      +52
  Branches         75      85      +10
===========================================
+ Hits           1123    1174      +51
  Misses           45      45
- Partials         21      22       +1

Impacted Files
Coverage Δ
Complexity Δ

...instrumentation/stats/DistributionAggregation.java
100% <ø> (ø)
9 <0> (ø)
:arrow_down:

...ation/stats/DistributionAggregationDescriptor.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...com/google/instrumentation/stats/Distribution.java
98.07% <98.07%> (ø)
21 <21> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e16e06...3fdd434. Read the comment docs.

Looks good. Is there an associated proto or otherwise wire format yet?
On 8 Apr 2017 4:21 am, "Alistair Veitch"<EMAIL_ADDRESS>wrote:

This PR adds a functional Distribution class, to be used for collecting
stats.
You can view, comment on, or merge this pull request online at:
https://github.com/google/instrumentation-java/pull/196
Commit Summary

Add Distribution class

File Changes

A core/src/main/java/com/google/instrumentation/stats/
Distribution.java
https://github.com/google/instrumentation-java/pull/196/files#diff-0
(235)
M core/src/main/java/com/google/instrumentation/stats/
DistributionAggregation.java
https://github.com/google/instrumentation-java/pull/196/files#diff-1
(1)
M core/src/main/java/com/google/instrumentation/stats/
DistributionAggregationDescriptor.java
https://github.com/google/instrumentation-java/pull/196/files#diff-2
(1)
A core/src/test/java/com/google/instrumentation/stats/
DistributionTest.java
https://github.com/google/instrumentation-java/pull/196/files#diff-3
(111)

Patch Links:

https://github.com/google/instrumentation-java/pull/196.patch
https://github.com/google/instrumentation-java/pull/196.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/instrumentation-java/pull/196, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAD616SPwbUnepluFwzcoeRiwk-mIWFMks5rtprSgaJpZM4M3WOo
.

@adriancole This class represents part of the DistributionAggregation proto: https://github.com/google/instrumentation-proto/blob/cc428c7bc049175ce677d910bbc3a23461c306a1/stats/census.proto#L149.  I think we should also refactor that proto so that it has two fields, distribution and tags.

Subsumed by #198.


Add missing sandbox to ContextTarget constructor

There was no way to set the sandbox

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
3984

Relevant Lines:
3984

💛  - Coveralls

Counterproposal: maybe we make the Sandbox property writable?

Counterproposal: maybe we make the Sandbox property writable? It being not settable is most assuredly an oversight in the class. (I worry about the explosion of arguments in constructors.)

Sure! I'm not strong here.

Awesome. Let’s do that, then. If you update the PR, I can update the PR pretty quickly.


Roser Vento - Endometrium across menstrual cycle

Primary Wrangler:
@ESapenaVentura
Secondary Wrangler:
TBD

Associated files:
Google Drive:  https://drive.google.com/drive/folders/19JgmlhKOnQFE3wtmgJ2wVa2-TGD3pASU
Key Events

[ ] Send initial instructions about contributing, including questionnaire and T&Cs
[ ] Receive project questionnaire
[x] Assign the Primary Wrangler
[ ] Receive T&C form filled out by at least 1 representative of group/project
[ ] Send custom metadata template spreadsheet, how-to guide and directions for submitting data files
[x] Receive spreadsheet (to a sufficient standard to submit dataset)
[x] Receive data (to a sufficient standard to submit dataset)
[x] Curate metadata spreadsheet with ontologies
[x] Upload sheet to validate metadata
[x] Run graph validator
[x] Check linking
[x] Validate data files
[x] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[x] Get final approval of submission including metadata spreadsheet and data files
[ ] Submit to production and inform ingest-devs the project is ready for archiving
[ ] Email UX to inform that they're ready to send survey

Please track the below as well as the key events:

Track date first spreadsheet received and final spreadsheet sent by editing ticket to include
date next to event.
Track spreadsheet iterations by placing asterisks next to receive spreadsheet event.
Track any metadata issues/tickets made for dataset with a bulleted list of links under
received spreadsheet event. Links should be to the ticket in the metadata repo.

This is now a HCA publication, see email:
Dear Roser
Thank you for submitting your recent paper entitled “Mapping the temporal and spatial dynamics of the human endometrium in vivo and in vitro [biorxiv.org]” for consideration by the HCA Publications Committee.

The HCA publication email links to a preprint, but there's an actual publication in the Circulation journal: Integrated Single Cell Atlas of Endothelial Cells of the Human Lung
Raw data is in GSE164829

Data can be found here https://www.ebi.ac.uk/arrayexpress/experiments/E-MTAB-10287/
Preprint is here https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>5073v1
This is an MRC + WSSS dataset

https://www.ebi.ac.uk/arrayexpress/experiments/E-MTAB-10287/ is undergoing maintenance to add the new file so will work on this when available

@Wkt8 about your review!
Donor organism tab:

I got it from inferring from the name of the samples (MRC_Endo). Good eye catching the third donor, I mislabelled it!

Dissociation protocol:

I have moved that part of the protocol to enrichment :)

I'm going to create the submission!

Looks great in the browser
Closing!

Updated metadata of 3 of the donors (E1, E2, E3) to normal

@ESapenaVentura updated and sent import form for Release 12

Update looks good in the browser

@ESapenaVentura this is now published as peer reviewed paper.
DOI: 10.1038/s41588-021-00972-2
PMID: 34857954
https://www.nature.com/articles/s41588-021-00972-2


Expired access token makes calls fail silently

When a request has failed due to token expiration, user should be logged out.

Similar issue here: https://community.spark.io/t/cli-produces-error-of-invalid-token/10723
We might need a never-expiring token : http://docs.spark.io/api/#authentication-configure-when-your-token-expires


Overriding the port is not applied on CWK App level

cwk run --port 9001 works, but the CWK app is connecting on the old port 8000. Looks like the CWK app is not receiving the correct port from the backend.

Fixed


Wrong viewport is restored after returning to map from offline area selector

@shobhitagarwal1612 @JSunde  FYI in case you have ideas

What is the expected behavior?

Currently, we only persist the camera position of home screen to preferences.

So, if we pan/zoom on offline fragment or map based tasks, the position won't be persisted to the disk.

So, if we pan/zoom on offline fragment or map based tasks, the position won't be persisted to the disk.

Presently, the home map viewport should be restored to its original location when returning from the offline areas screen. It currently doesn't do that; it returns to another previously saved location.

This also happens when closing and reopening the app. It appears not all pan/zoom actions cause the last active viewport to be saved.

The issue is happening because of this line
https://github.com/google/ground-android/blob/8700520a8ce0e46f24a15ded4c5a20116bd2eda8/ground/src/main/java/com/google/android/ground/ui/common/AbstractMapContainerFragment.kt#L60

Just observed this after data collection flow; map was zoomed out to initial state instead of position before data collection.


WIP Test/app

app.js test

https://github.com/ethereumproject/explorer/projects/1#card-14891329

no bandwidth, will reopen at later date


Parametrize color of the svg arrow (stroke attribute)

Currently we can apply css style to the popover box, but cannot change the color of svg arrow.
This PR fixes it

Thanks for your PR :-)
Note: We went one step further and applied this color to the entire popover border as the name popover-border-color suggests.


Differences in cloudfront between 4.0.11 and 4.0.12+

Hi all,
I've got 4 unit tests in my code which leverage the @mock_cloudfront decorator.  They work just fine under 4.0.11, but fail under 4.0.12+
As best I can tell, moto isn't intercepting calls to Cloudfront, but I can't figure out why.
The call that fails is cloudfront.update_dstribution(). The diff between 4.0.11 & 4.0.12 seems benign enough:
$ git diff 4.0.11 4.0.12 -- models.py
diff --git a/moto/cloudfront/models.py b/moto/cloudfront/models.py
index 737b7d3d..52903a13 100644
--- a/moto/cloudfront/models.py
+++ b/moto/cloudfront/models.py
@@ -113,6 +113,7 @@ class Origin:
     def __init__(self, origin: Dict[str, Any]):
         self.id = origin["Id"]
         self.domain_name = origin["DomainName"]
+        self.origin_path = origin.get("OriginPath") or ""
         self.custom_headers: List[Any] = []
         self.s3_access_identity = ""
         self.custom_origin = None
@@ -329,8 +330,14 @@ class CloudFrontBackend(BaseBackend):
         dist = self.distributions[_id]

         aliases = dist_config["Aliases"]["Items"]["CNAME"]
+        origin = dist_config["Origins"]["Items"]["Origin"]
         dist.distribution_config.config = dist_config
         dist.distribution_config.aliases = aliases
+        dist.distribution_config.origins = (
+            [Origin(o) for o in origin]
+            if isinstance(origin, list)
+            else [Origin(origin)]
+        )
         self.distributions[_id] = dist
         dist.advance()
         return dist, dist.location, dist.etag

But, there is some added code there regarding Origins, which might be my issue, since the error I'm getting back from botocore is:
botocore.errorfactory.InvalidOrigin: An error occurred (InvalidOrigin) when calling the UpdateDistribution operation: The specified origin server does not exist or is not valid.

Since things work with 4.0.11< but not with 4.0.12+, I'm guessing I need to fix my code. But I'm not sure how.
Any help would be appreciated. Thanks!
--
Paul

Looking into this more, I'm very confused about line 333 in moto/cloudfront/models.py:
        aliases = dist_config["Aliases"]["Items"]["CNAME"]
        origin = dist_config["Origins"]["Items"]["Origin"]     <---

That line was added in 4.0.12. And looking at the boto3 docs, I don't actually see an "Origin" key to the ["Origins"]["Items"] dict:
response = client.update_distribution(
    DistributionConfig={
        'CallerReference': 'string',
        'Aliases': {
            'Quantity': 123,
            'Items': [
                'string',
            ]
        },
        'DefaultRootObject': 'string',
        'Origins': {
            'Quantity': 123,
            'Items': [
                {
                    'Id': 'string',
                    'DomainName': 'string',
                    'OriginPath': 'string',
                    'CustomHeaders': {
                        'Quantity': 123,
                        'Items': [
                            {
                                'HeaderName': 'string',
                                'HeaderValue': 'string'
                            },
                        ]
                    },
                    'S3OriginConfig': {
                        'OriginAccessIdentity': 'string'
                    },
                    'CustomOriginConfig': {
                        'HTTPPort': 123,
                        'HTTPSPort': 123,
                        'OriginProtocolPolicy': 'http-only'|'match-viewer'|'https-only',
                        'OriginSslProtocols': {
                            'Quantity': 123,
                            'Items': [
                                'SSLv3'|'TLSv1'|'TLSv1.1'|'TLSv1.2',
                            ]
                        },
                        'OriginReadTimeout': 123,
                        'OriginKeepaliveTimeout': 123
                    },
                    'ConnectionAttempts': 123,
                    'ConnectionTimeout': 123,
                    'OriginShield': {
                        'Enabled': True|False,
                        'OriginShieldRegion': 'string'
                    },
                    'OriginAccessControlId': 'string'
                },
            ]
        },
...

I could be misunderstanding what's going on there, but both lines 332 & 333 seem to be attempting to copy dicts at locations which are lists according to the docs on Distribution Configs. (not saying this is the cause of my problems, just that I'm confused about what's going on in these lines!)
Thanks.
Paul

Hi @pll!
dist_config["Origins"]["Items"]["Origin"] points to this object:
{
   'Id': 'string',
   'DomainName': 'string',
   'OriginPath': 'string',
    ....

So the origin variable refers to either one dict containing those values, or a list containing multiple dicts.

The InvalidOrigin error is thrown if the origin-dict does not have the S3OriginConfig or the CustomOriginConfig-field. If I read the docs correctly, either one of those fields is required in the CreateDistribution-action.
In addition, the UpdateDistribution states that:
The new configuration replaces the existing configuration. The values that you specify in an UpdateDistribution request are not merged into your existing configuration. Make sure to include all fields: the ones that you modified and also the ones that you didn't.

Which indicates that the S3OriginConfig or CustomOriginConfig-field also has to be part of the UpdateDistribution call.

Hi Bert,
Thanks for the reply. I guess I missed that part about S3OriginConfig or CustomOriginConfig being required.
I create my mock CF distro with the following:
            "Items": [
                {
                    "Id": Id,
                    "DomainName": "asdf.s3.us-east-1.amazonaws.com",
                    "S3OriginConfig": {"OriginAccessIdentity": ""},
                }
            ],

However, when I call get_distribution(Id=self.dist_id) the structure I get back is:
[
    {
        "Id": "foo-a",
        "DomainName": "asdf.s3.us-east-1.amazonaws.com",
        "OriginPath": "",
        "CustomHeaders": {
            "Quantity": 0,
            "Items": []
        },
        "ConnectionAttempts": 3,
        "ConnectionTimeout": 10,
        "OriginShield": {
            "Enabled": false
        }
    }
]

So, I think I'm creating the distro correctly, but the dist-config I get back isn't what I created.  When updating the config, I'm creating a copy, then simply updating one of the fields (Aliases), but because what I get back from get_distribtion() is lacking the S3OriginConfig and/or CustomOriginConfig, I guess that's why I'm getting the error.
Any ideas on why the dist config I create isn't what I'm getting back?
Thanks again!

    "S3OriginConfig": {"OriginAccessIdentity": ""},

Effectively makes that null, which means it no longer exists in the config. Making that a non-empty string fixes everything :)
Sorry for the bother, but thanks for being a sounding board! I'm happily running 4.1.0 now!
Paul

I'm happily running 4.1.0 now!

Happy to hear that! I'll close this, but us know if you run into any other issues.


feat: dynamic flow control for bulk mutation batcher

Implementation of go/veneer-dynamic-flow-control
Will split this PR into smaller chunks. And it depends on https://github.com/googleapis/gax-java/pull/1288.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕

Changes are merged into dynamic_flow_control branch.


how to use this project

I am nodejs newer that I don't know how to run this repository code。
Would you mind give me a da client demo like 'hello word'  that can  run simply  on the linux platform to connect remote server.
help, thanks.

You can make some test with matrikon simulation server. If you install the matrikon server and make right settings, you can directly connect from this node.

how to run this project？i dont konw how to open ui like other


test: optimise test with chai custom method overwrite

The lodestone is maintaining currently, which broke the test always.

 29 passing (3m)
 1 failing

you can trigger the ci test by clicking the re-run button.


[NT-1938] UI comment card with threads

📲 What
View replies CTA is added to the Comment UI Card. The View replies CTA is only enabled for successful comments.
🤔 Why
Every root comments can be replied. User needs to be able to navigate to all replies to a comment with a CTA
👀 See

✅ Acceptance criteria

Navigate to the comment section of a project

Validate that only successful comments have a View Replies CTA

Validate that Reply button is hidden if you are not a backer.

The ticket mention that:

Also, we need to support yet another variation of the Comment Card design, to display replies:

This speaks to Comment Card  being reusable.

Note
This PR does will not include

Left indentation – should this be part of the card or the view it sits in?

Will be closing this as it's already included here https://github.com/kickstarter/ios-oss/compare/NT-1939-thread-view-navigation


Test launch pause resume feature

Fixed Issues
#22920, #22921
Files Changed
TestRepository.cs - PauseResumeTest() method added to pause resume the test
ITestRepository.cs
TestController.cs - PauseTest() method is added to change the settings of test
tests.service.ts- updateTestPauseResume() added to call server side api
test-view.component.ts
test-settings.component.ts
test-view.html
test-settings.html
create-test-footer.component.ts
create-test-footer.html
HomeController.cs
TestConductRepository.cs
ITestConductRepository.cs
test-launch-dialog.component.ts
test.model.cs
tests-dashboard.html
Checks

[X] Naming Conventions
[X] Server side code comments (proper English, grammar and no spelling mistakes)
[X] Client side code comments (proper English, grammar and no spelling mistakes)
[X] Unused variables, methods, blank spaces and name spaces.
[X] Optimal Code and code formatting
[X] Commit History is proper, no merge is done.
[X] Commit/pull request messages should be proper to justify your feature
[ ] All test cases are executed provided by tester.

Known Issues

issue 1
issue 2

Comments
NA

This change is

SonarQube analysis reported 1 issue

 1 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 TestConductRepository.cs#L90: Remove the unnecessary Boolean literal(s).

SonarQube analysis reported 1 issue

 1 minor

Watch the comments in this conversation to review them.


feat(plugins): add initial boolean

Adds a boolean called initial to the vd plugin object that's true if the plugin was loaded on startup, or false if it was enabled by the user afterwards

whuh


JIT mode

Can you add the possibility of adding a labeled group in the code?

Yes, you can do that without this plugin if you are using Tailwind 3.1+.
You need to use an arbitrary variation as follows:

Lorem ipsum

This will generate the following CSS:
/* Base CSS... */

.group-my-custom:hover .\[\.group-my-custom\:hover_\&\]\:text-pink-800 {
  --tw-text-opacity: 1;
  color: rgb(157 23 77 / var(--tw-text-opacity));
}

This means you can use any class name for the group. For example you could use banana and in the child [.banana:hover_&]:bg-pink-800.
This solution is cool if you don't want to change the Tailwind config, but it does the drawback that you have to use your own selector which can make you code less readable.
Examples:

Basic example
Complex example


Use GATs for View::Key

Closes #284
This pull request aims to add support for GATs on View::Key, which will allow the ViewSchema::map() and ViewSchema::reduce() functions to returned borrowed data from the document.
This will require updating the Connection/AsyncConnection view query types to return Key::Owned. Part of the complexity arises from type erasure in SerializedView.

This PR is being abandoned in favor of #288