New provider attribute: fallbacks

Feature Description
This feature would introduce a fallbacks field within the provider configuration to simplify the setup.
To add an external source like lazydev, you need to also tweak the lsp provider fallback_for property, but it might be more easy and intuitive to set up if we had a fallbacks field:
lazydev = {
  ...,
  fallbacks = { "lsp" },
},

Compared to
lazydev = {
  ...,
},
lsp = {
  fallback_for = { "lazydev" },
},

No, this would replace fallback_for.
crates = {
  ...
  -- if the `lsp` "tree" returns 0 items, we reach `othersource`, so order matters here
  fallbacks = { "lsp", "othersource" },
},

The lsp provider has buffer as a fallback, but lsp is a fallback of crates, so the priority is crates -> lsp -> buffer -> othersource. If we added lazydev and lsp as its fallback, lsp would run if crates or lazydev return 0 items, which is the current behavior
crates = {
  ...
  fallbacks = { "lsp" }, -- lsp will run only if crates has 0 items OR if lazydev has 0 items too
},
lazydev = {
  fallbacks = { "lsp" },
},

I have a feeling this is like managing dependencies, but its probably worth it 😅

actually, this is managing dependencies

:joy: Good point, it's currently defined from the bottom up, and you're proposing top down which I like much more

crates = {
  ...
  fallbacks = { "lsp" }, -- lsp will run only if crates has 0 items OR if lazydev has 0 items too
},
lazydev = {
  fallbacks = { "lsp" },
},

How would we allow the ALL case here, instead of ANY, since I think that would be the desired behavior. Would you do crates.fallbacks = { 'lazydev' } and then lazydev.fallbacks = { 'lsp' }?
I think the hypothetical we would want to support is:
crates/lazydev -- ALL -> lsp --> buffer + ripgrep
so, for that last buffer + ripgrep bit, rather than this:

crates = {
  ...
  -- if the `lsp` "tree" returns 0 items, we reach `othersource`, so order matters here
  fallbacks = { "lsp", "othersource" },
},

We could instead run all of the fallbacks listed

crates = {
  fallbacks = { "lsp" },
},
lazydev = {
  fallbacks = { "lsp" },
},
lsp = {
  fallbacks = { "buffer" },
},
buffer = {
  fallbacks = { "ripgrep" },
},

To reduce complexity, we could just make it ALL. lsp would run if crates AND lazydev returns 0 items, and buffer would run if lsp returns 0 items and so on with ripgrep. aditionally we can have another field
crates = {
  fallback_when = "all"/"any",
  fallbacks = { "lsp", "buffer" },
},

but this is getting complex because if lsp doesn't return items, it will fallback to buffer and then, we call buffer too, what would be a use case for ANY?

This approach looks like it would solve having LSP and Snippet completions when I'm typing out a Path.


How to get the memory cell gate activations in LSTM ?

Hi,
I want to train a LSTM that learns given a frame of video, predict the next frame of the video. I extracted 20 frames from each video and each frame is passed through a CNN to get a 512 dimensional feature embedding for the frame i.e., each frame is now represented by a 512 dimensional feature vector and I have 20 frames for each video.
So my input has shape of X_train = (no_videos, 20, 512) and similarly my output has shape of Y_train = (no_videos,20,512) which are the shifted frames.
After training, I pass each video frame by frame for the network to predict the next frame and I want to extract the memory cell gate activations after the final frame is predicted for that video. This means I want the memory cell gate activations for each video after predicting the final frame (so that the information of the entire video is embedded).
Could someone please help how to do this ?
Thanks in advance.

If an LSTM is trained to predict the next frame, it is going to forget any information not relevant to that. So your memory cell at the end of the video might not have anything meaningful in it. They way an LSTM is normally used to encode a sequence is to train the LSTM such that its final output can be used to reconstruct the entire sequence. That way you are training the LSTM to actually learn an embedding that reconstructs the sequence.
On the other hand, if you wanted to get all of the memory cells, you are looking at extremely redundant data.
If you really want to get to the states without writing a ton of code, you could modify LSTM.call to store states as some attribute and then get it from your code.
If you want to be able to embed an entire video, you might want to try a different approach. Have you found any papers on the topic?

I don't want all the memory cells. I just need a single embedding for each video. I thought of getting that by training the LSTM to predict the next frame given the current frame. Then for each video, by passing each frame, the LSTM predicts the next frame and finally I'll take the memory cell activation after predicting the last frame of that video. This way I've the memory cell activation as embedding for that video. I'll repeat the same for each video. This way I have an embedding for each video as the memory cell activation of the last predicted frame of that particular video.
I don't know how to this in keras. Is it possible to do this in keras ?

From what you are saying, what i understand is that you want the LSTM outputs for each timestep, not the memory cells.  Also you are saying that you want the memory cell activations. That confuses me even more. I can't imagine what useful information this will give you, as @bstriner said.
Anyway you can get the LSTM outputs (or hidden states) like this:
Sequential API
...
model.add(LSTM(100, return_sequences=True))
...

Functional API
states = LSTM(100, return_sequences=True)(frames)

I don't want the LSTM outputs for each timestep. My main aim here is to get a single embedding for each video (which represents the entire information present in the video).
I want to extract the memory cell activation after passing the final frame of the video to the LSTM. Like in my example as I said initially, my X_train = (no_videos, 20, 512) and Y_train = (no_videos, 20, 512). Here 20 represents I extract 20 frames from the video and 512 is the CNN feature embedding of each frame. Now I train a LSTM giving it the current frame as input (X_train[:,I,:]) and the next frame as it's target (Y_train[:,i,:]). Once this training is done, I will now pass each video frame by frame and extract the memory cell activation when final frame has been given.
I apologize if I have confused before.
Or is there any way of learning a single embedding for a video which captures the entire information in the video ?

Run the LSTM over the entire video and get the final output of the LSTM. Train that final output of the LSTM to recreate the entire video. That is the only way the output of the LSTM will be representative of the entire video.
If the LSTM only tries to recreate the next step, then it isn't going to learn to store information.
If you're trying to predict only the next frame, you could pass in the first frame and hallucinate what might happen next, but your accuracy is going to be terrible.

Sorry but can you please elaborate how to do what you are suggesting that is run the LSTM over the entire video. I mean what should be the training data and target data ? And also how to use the final output to recreate the entire video. Sorry if I'm asking a basic question since I'm new to LSTM.
Thank you in advance.

Usage questions should go to stackoverflow, slack or the google group. Github is really for bugs and feature requests. Please close this issue and continue the discussion there if you have further questions.
Basically, you are trying to make an autoencoder. Create 2 LSTMs.

encoder LSTM: return_sequences = False. This will go through your training data and output a single embedding vector
decoder LSTM: return_sequences = True, depth=20. This will go through the embedding vector and try to output your original frames.

The input should be your original frames, and the target should be the same set of frames (pass the same array as input and target).

One popular variation is denoising autoencoders, where you add some noise to the input but not the target
Another popular model is to reverse the frames in the target. So inputs are frames 1-20, and the target is frames 20-1.

If you want to do something more advanced, use a convolutional autoencoder for the frames. Apply this encoder and decoder using TimeDistributed.

Input is some frames, lets say (batch_size, 20, 64, 64)
TimeDistributed frame encoder converts frames, so the output is (batch_size, 20, 256)
LSTM encoder combines the frames, so the output is (batch_size, 512)
LSTM decoder decodes the frames back to (batch_size, 20, 256)
TimeDistributed frame encoder decodes frames back to (batch_size, 20, 64, 64)

After fully training the model, with encoder and decoder, the embedding you want is just the output of the encoder. It is normally easiest to build two models in your code, an encoder and a decoder, then create an autoencoder that uses both models. Run autoencoder.fit then use encoder.predict to get embeddings.
encoder = Model(...)
decoder = Model(...)
autoencoder = Model(encoder.inputs, decoder(encoder(encoder.inputs)))

Cheers

@bstriner Hey there, I'm getting an odd error trying to implement something like that model you described that I thought I throw in here
seq_in = Input(shape=(MAX_WORDS, ), dtype='int32', name='seq_in')
seq_emb = Embedding(input_dim=vocab_size,
                     output_dim=WORD_EMBED_SIZE,
                     weights=[e_weights],
                     mask_zero=True,
                     trainable=False)(seq_in)
seq_emb = Masking(mask_value=0.0)(seq_emb)

sen_enc = LSTM(SENT_EMBED_SIZE, return_sequences=False, name='LSTM_enc')(seq_emb)

dec_in = Input(shape=(None, SENT_EMBED_SIZE), name='dec_in')
sen_dec = LSTM(MAX_WORDS, return_sequences=True, name='LSTM_dec')(dec_in)
onehot_out = Dense(vocab_size, activation='softmax')(sen_dec)

encoder = Model(seq_in, sen_enc)
decoder = Model(dec_in, onehot_out)
encoder.summary()
decoder.summary()
autencoder = Model(encoder.inputs, decoder(encoder(encoder.inputs)))

Getting the following error:
InvalidArgumentError: Invalid reduction dimension 2 for input with 2 dimensions. for 'model_28/LSTM_dec/Sum' (op: 'Sum') with input shapes: [?,200], [2] and with computed input tensors: input[1] = <1 2>.

regardless of the size of my decoder LSTM.
Using a pre-trained word embedding spices up the problem here, but I don't think that's necessarily the issue. Can't quite figure it out, would welcome any suggestions, good chance I'm doing everything wrong

Hold up, solved the above by adding
sen_enc = Reshape((1,SENT_EMBED_SIZE))(sen_enc)
Again, I fear I may be straying from the desired model though

The above can be solved by adding
sen_enc = RepeatVector(MAX_WORDS)(sen_enc)
But does that have the desired effect?


[Build] Split Python "internal" tests into "module" and "bridge" tests

Closes #739.
A little refactoring sneaked in, especially the first few commits.
In particular, there's an update to the Conan generator we use, so that the frustrating pybind11 Conan package bug, which prevents use of pybind11 when embedding a Python interpreter (see commit message and https://github.com/OpenAssetIO/OpenAssetIO/issues/528), is fixed.

Converted to draft to address CI failures.

Quick Q - whilst we're rejigging things here - what do people think about module -> cmodule to middle disambiguate that we have module and package dirs (as package technically also contains other "modules")?

Quick Q - whilst we're rejigging things here - what do people think about module -> cmodule to disambiguate that we have module and package dirs (as package technically also contains other "modules")?

Added a commit at the end (512ed5a) to do this, but can move it to the beginning if you think the git wrangling is worthwhile.

Quick Q - whilst we're rejigging things here - what do people think about module -> cmodule to disambiguate that we have module and package dirs (as package technically also contains other "modules")?

Added a commit at the end (512ed5a) to do this, but can move it to the beginning if you think the git wrangling is worthwhile.

Im happy for this to go later. I was wondering what the final commit granularity was here too, happy to squash some of the "similar" cmake tweaks together too.

happy to squash some of the "similar" cmake tweaks together too.

I've squashed a few of the later commits together (renaming module/internal to cmodule and moving the test config to its own CMakeLists.txt).  How does that look?


Adding entity after delay causes entities to not display

Entities do not appear if an entity is added after a short delay following viewer creation.  If an entity is added after a delay of 5ms or so, it causes one or all of the other entities to not appear.  With a very large delay (like 5000ms), things seem to work correctly.
In our environment, the delay happens because we make an AJAX request to the server to retrieve additional data points.
Paste the following code into sandcastle.  We’re simulating our scenario by adding a delay with setTimeout to the creation of one of the polylines.  We’ve been able to elicit this problem on Windows/Chrome, Mac/Chrome, and Mac/Firefox.
Vary the delay variable.  The results we get are:
delay = 0  ---- both lines appear
delay = 5 (or so) --- no lines appear
delay = 5000 --- both lines appear
var viewer = new Cesium.Viewer('cesiumContainer');

// zero delay: both lines show
// small delay (5 or so), none
// large delay (5000 or so), both
var delay = 5;

// a zero value: both lines are shown
if (delay == 0) {
    line(30, Cesium.Color.RED);
    line(37, Cesium.Color.BLUE);
}

// a >0 value: none, one, or both
else {
    window.setTimeout(function () {
        line(30, Cesium.Color.RED);
    }, delay);
    line(37, Cesium.Color.BLUE);
}

viewer.zoomTo(viewer.entities);

function line(lat,color) {
    viewer.entities.add({
        polyline : {
            positions : Cesium.Cartesian3.fromDegreesArray([-75, lat, -125, lat]),
            width : 5,
            material : color
       }
    })
}

Thanks for the report.  This is definitely a bug and related to a similar issue I cam across recently that involves updating static data in quick succession.  I'll try and see if I can fix it for the next release (but I can't garuantee anything until I look more into it).  (But I'm leaning towards a simple fix).
In the mean time, if you know when your updates are about to start and finish, then you should call     viewer.entities.suspendEvents(); and the beginning and viewer.entities.resumeEvents(); at the end, this will avoid the race condition and everything should work.
Here's a slightly modified version of your example that does this.  Comment out the two calls and the problem reappears.
var viewer = new Cesium.Viewer('cesiumContainer');

function line(lat,color) {
    viewer.entities.add({
        polyline : {
            positions : Cesium.Cartesian3.fromDegreesArray([-75, lat, -125, lat]),
            width : 5,
            material : color
       }
    });
}

// zero delay: both lines show
// small delay (5 or so), none
// large delay (5000 or so), both
var delay = 5;

// a zero value: both lines are shown
if (delay === 0) {
    line(30, Cesium.Color.RED);
    line(37, Cesium.Color.BLUE);
    viewer.zoomTo(viewer.entities);
}

// a >0 value: none, one, or both
else {
    viewer.entities.suspendEvents();
    window.setTimeout(function () {
        line(30, Cesium.Color.RED);
        viewer.entities.resumeEvents();
        viewer.zoomTo(viewer.entities);
    }, delay);
    line(37, Cesium.Color.BLUE);
}

@asimps thanks again for the report.  The fix will be in Cesium 1.7, which will be released shortly.

Many thanks to you guys!


Add output types example

To see the rendered version:
https://github.com/bufbuild/buf-examples/tree/lperkins/restricted-types/limit-output-types

@robbertvanginkel Okay, I've refined the jq queries and changed up the narrative a bit. Lemme know what you think.


migrate to new architecture

part of https://github.com/hoodiehq/hoodie/issues/458

[x] rename to hoodie-store-client
[x] in package.json, set "name" to "@hoodie/store-client", and add "publishConfig": {"access": "public"}
[x] find hoodie-client-store and replace with hoodie-store-client
[x] do commits as in https://github.com/hoodiehq/hoodie-log/issues/31

Once merged

[x] deprecate hoodie-client-store in the npm registry
[x] enable coveralls for new repo name (run COVERALLS_REPO_TOKEN=... npm run test:coverage & npm run test:coverage:upload, then on coveralls.io require 100% coverage for success)
[x] update branch protection: re-enable coveralls

https://www.npmjs.com/package/@hoodie/store-client


LaunchBuddy unresponsive upon loading an account.

It seems with each update to the game, LaunchBuddy is taking longer and longer to load accounts.  I try to load up 1 account, and even after the account is loaded.   LaunchBuddy still isn't responding until at least 30 seconds to a minute after.  I clear my gw2cache folders out daily, but even that doesn't help with the situation.

The issue has returned with the latest update, but the pattern it happens in is a bit different.
When loading an account.  LB goes unresponsive, until the client fully loads onto the character screen.  At that point you can choose another client to load if you wish.

@TheCheatsrichter Being that this topic got buried, and not sure if mentioning you alerts you or whatever, but thought worth a shot..


Fixup book CI

mdbook now has binary releases: https://github.com/rust-lang-nursery/mdBook/releases

r? @adamgreig
(rust_highfive has picked a reviewer for you, use r? to override)


More documentation for WASM loader.

Resolves #3577.

@wdbaruni It looks like the complex functionality that I thought needed documenting was deliberately broken by #2675. Given that there the feature doesn't exist anymore, there isn't much to do here.
However, it looks like the module loading is actually fundamentally broken. I don't think, for example, it would work to upload multiple WASM modules as input, alongside some input data, despite it advertising that this is meant to be supported. What would you like to do about that? So far I have just left a comment about the bug; a bigger change would be to try to fix it (and test it properly) or remove the ability to have multi-module WASM jobs completely (I actually estimate both are about the same amount of work).
Let me know if you'd like me to pick up either of those tasks. I would guess that this being broken won't cause an issue for any real user for quite some time, maybe longer than the lifetime of the whole WASM feature.


Unsupported commands in Viewer

Hi,
I'm trying to generate a label image with viewer but it renders incorrectly with the following error

this is not an error it informs you that these commands cannot be interpreted in our viewer.

Hi, yes but because of it, it is rendering it incorrectly, is there a possibility to add these or any short tutorial which i can read and add these?

hi, this is the documentation of the zebra protocol https://www.zebra.com/content/dam/zebra/manuals/printers/common/programming/zpl-zbi2-pm-en.pdf

First we analyze the zpl code with the CommandAnalyzers
after that we render the ElementDrawers


relation "users" does not exist

On a fresh install, if the database is not managed by helm, we must create the users table manually. Otherwise we get an error
  + Exception Group Traceback (most recent call last):
  |   File "/usr/local/lib/python3.12/site-packages/starlette/_utils.py", line 87, in collapse_excgroups
  |     yield
  |   File "/usr/local/lib/python3.12/site-packages/starlette/middleware/base.py", line 190, in __call__
  |     async with anyio.create_task_group() as task_group:
  |   File "/usr/local/lib/python3.12/site-packages/anyio/_backends/_asyncio.py", line 680, in __aexit__
  |     raise BaseExceptionGroup(
  | ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
  +-+---------------- 1 ----------------
    | Traceback (most recent call last):
    |   File "/usr/local/lib/python3.12/site-packages/uvicorn/protocols/http/httptools_impl.py", line 399, in run_asgi
    |     result = await app(  # type: ignore[func-returns-value]
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py", line 70, in __call__
    |     return await self.app(scope, receive, send)
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/fastapi/applications.py", line 1054, in __call__
    |     await super().__call__(scope, receive, send)
    |   File "/usr/local/lib/python3.12/site-packages/starlette/applications.py", line 123, in __call__
    |     await self.middleware_stack(scope, receive, send)
    |   File "/usr/local/lib/python3.12/site-packages/starlette/middleware/errors.py", line 186, in __call__
    |     raise exc
    |   File "/usr/local/lib/python3.12/site-packages/starlette/middleware/errors.py", line 164, in __call__
    |     await self.app(scope, receive, _send)
    |   File "/usr/local/lib/python3.12/site-packages/starlette/middleware/base.py", line 189, in __call__
    |     with collapse_excgroups():
    |   File "/usr/local/lib/python3.12/contextlib.py", line 158, in __exit__
    |     self.gen.throw(value)
    |   File "/usr/local/lib/python3.12/site-packages/starlette/_utils.py", line 93, in collapse_excgroups
    |     raise exc
    |   File "/usr/local/lib/python3.12/site-packages/starlette/middleware/base.py", line 191, in __call__
    |     response = await self.dispatch_func(request, call_next)
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/app/sender.py", line 190, in proxy
    |     user = await verify_token(token_parts[1])
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/app/sender.py", line 103, in verify_token
    |     result = await connection.fetchrow(query, token)
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 749, in fetchrow
    |     data = await self._execute(
    |            ^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 1794, in _execute
    |     result, _ = await self.__execute(
    |                 ^^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 1892, in __execute
    |     result, stmt = await self._do_execute(
    |                    ^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 1925, in _do_execute
    |     stmt = await self._get_statement(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 433, in _get_statement
    |     statement = await self._protocol.prepare(
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   File "asyncpg/protocol/protocol.pyx", line 166, in prepare
    | asyncpg.exceptions.UndefinedTableError: relation "users" does not exist
    +------------------------------------

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/uvicorn/protocols/http/httptools_impl.py", line 399, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py", line 70, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/fastapi/applications.py", line 1054, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.12/site-packages/starlette/applications.py", line 123, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.12/site-packages/starlette/middleware/errors.py", line 186, in __call__
    raise exc
  File "/usr/local/lib/python3.12/site-packages/starlette/middleware/errors.py", line 164, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.12/site-packages/starlette/middleware/base.py", line 189, in __call__
    with collapse_excgroups():
  File "/usr/local/lib/python3.12/contextlib.py", line 158, in __exit__
    self.gen.throw(value)
  File "/usr/local/lib/python3.12/site-packages/starlette/_utils.py", line 93, in collapse_excgroups
    raise exc
  File "/usr/local/lib/python3.12/site-packages/starlette/middleware/base.py", line 191, in __call__
    response = await self.dispatch_func(request, call_next)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/sender.py", line 190, in proxy
    user = await verify_token(token_parts[1])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/sender.py", line 103, in verify_token
    result = await connection.fetchrow(query, token)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 749, in fetchrow
    data = await self._execute(
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 1794, in _execute
    result, _ = await self.__execute(
                ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 1892, in __execute
    result, stmt = await self._do_execute(
                   ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 1925, in _do_execute
    stmt = await self._get_statement(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/asyncpg/connection.py", line 433, in _get_statement
    statement = await self._protocol.prepare(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "asyncpg/protocol/protocol.pyx", line 166, in prepare
asyncpg.exceptions.UndefinedTableError: relation "users" does not exist

I close the issue as it is now documented in the README


[WIP] Operating System incompatibility of tools and actions

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ ] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context
...
Description
reverse to #11893 - gives an output if an action is specifically marked as "does not work on this OS".

          1 Warning

:warning:
Pull Request is Work in Progress

  Generated by :no_entry_sign: Danger


Automated cherry pick of #9564: Hotfix/baremetal pxe net alloc

Cherry pick of #9564 on release/3.6.
#9564: Hotfix/baremetal pxe net alloc

Codecov Report

Merging #9565 (9f2b137) into release/3.6 (b9d30c0) will increase coverage by 2.93%.
The diff coverage is 2.66%.

@@              Coverage Diff               @@
##           release/3.6   #9565      +/-   ##
==============================================
+ Coverage         5.86%   8.79%   +2.93%
==============================================
  Files              828     443     -385
  Lines           129133   53409   -75724
==============================================
- Hits              7577    4699    -2878
+ Misses          120876   48242   -72634
+ Partials           680     468     -212

Flag
Coverage Δ

aFlag
8.79% <2.66%> (+2.93%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apis/input.go
0.00% <ø> (ø)

pkg/apis/list.go
0.00% <ø> (ø)

pkg/cloudcommon/db/apply_manager_method.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/archs.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/models.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/errors.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/handler.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/register.go
11.11% <0.00%> (-2.41%)
:arrow_down:

... and 413 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d0502...9f2b137. Read the comment docs.

/lgtm

/approve

/approve


Pressing the End key to jump to the end of the line does not work.

Usually I can jump to the beginning or end of the line by pressing Home and End. In nvui it only jumps to the beginning.

I've added the End key on the main branch, can you check it out and see if it works?

Yep, it works now! Thanks!


Pressing enter should skip the option

Describe the bug
ackee-report asks to input a few values when you use it for the first time. I don't have an email host, username and password as I wanted to use the RSS generator. It would be great if there's a way to skip them.
Expected behavior
Pressing enter should skip the option.
Screenshots
I've entered a space in order to skip them.

You are right, that should totally be an option now that ackee-report supports different outputs!
Going to fix this tomorrow👍

This was fixed in v0.6.2.


Install Issue

I have installed webmin as described and i have copied the config file and delete to sample file.
But the page shows me the same message.
Your WebMUM installation is still using the old deprecated config style!Please update your config to the new style (an example config can be found in config.php.example)and delete your old config.inc.php and config.inc.php.example.'.$content;
}

echo Router::loadAndBufferOutput(
	'include/php/template/layout.php',
	array(
		'content' => $content,
	)
);

I have no idea what i have to change to use webmum

Well this is easy, looks like your webserver is not telling php to process the .php file, so the code of the index.php was returned, not the result. Please go ahead and configure your webserver and php combination correctly and it should be fine :)


Context-menu to "Open in Integrated Terminal" doesn't respect terminal.integrated.defaultProfile

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.60.0
OS Version: Windows_NT x64 10.0.19042

Steps to Reproduce:

Set a default terminal profile to one that is NOT PowerShell: https://code.visualstudio.com/docs/editor/integrated-terminal#_configuring-profiles
Right-click in the working directory in the Explorer tab on the left, and choose to Open in Integrated Terminal.

The terminal should respect your default profile, but instead it will always open PowerShell. This doesn't happen when using CTRL + ` .

/duplicate of #132150 and will be fixed in upcoming recovery release.


Zhytomyr Polytechnic State University

Institution/School Name
Zhytomyr Polytechnic State University
Instiution/School Website
https://ztu.edu.ua
Email Users
Please place an x between the square brackets if yes

[x] Students
[x] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[x] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

@AndriyMorozov I am sorry, I have to close the request without merging, because you made a mistake in a request and requested to merge too many files, most of them do not relate to the organization which you would like to add to this repository. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for the understanding!


no colours for chunk list in git bash when using yarn start on a new project

Bug Report or Feature Request (mark with an x)
- [*] bug report
- [ ] feature request

Command (mark with an x)
- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
Angular CLI: 7.0.6
Node: 11.1.0
OS: win32 x64
Angular: 7.0.4
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package                           Version
@angular-devkit/architect         0.10.6
@angular-devkit/build-angular     0.10.6
@angular-devkit/build-optimizer   0.10.6
@angular-devkit/build-webpack     0.10.6
@angular-devkit/core              7.0.6
@angular-devkit/schematics        7.0.6
@angular/cli                      7.0.6
@ngtools/webpack                  7.0.6
@schematics/angular               7.0.6
@schematics/update                0.10.6
rxjs                              6.3.3
typescript                        3.1.6
webpack                           4.19.1
Repro steps
ng serve
Desired functionality
Build speed should be at least reasonably normal
Built chunks list should be coloured in git bash
Mention any other details that might be useful
Build speed is painfully slow, even with a brand new Angular Cli project
Built chunks list is monochromatic.
My hardware is very fast, btw, with I7 CPU, SSD HDD, 8GB RAM.
I excluded project directory from NOD32 antivirus.
I even tried ember-cli-windows tool, but with no success.

Hi, Can you please provide the output of ng version?
When you say it's painfully slow can you please elaborate a bit more regarding the timings that you are seeing?
Also, the command you are running is npm start? as there is no such command as ng start.
Thanks.

Sorry for the typo. I updated the comment with additional info.

The last time I checked the built times were pretty close between Windows and Mac. (I usually work on a Mac though).
@filipesilva do you have any insights on this since you usually work on a Windows?
Also, one of the community members today mentioned that built times were better when using PowerShell though when using WSL https://github.com/angular/angular-cli/issues/5775#issuecomment-440249887, might be worth to give it a shot :)

WSL will always be very, very slow. @micobarac are you sure you are using Git Bash and not WSL?
You should be able to check by running cat /proc/version.
I use git bash and see this:
kamik@RED-X1C6 MINGW64 /d/sandbox
$ cat /proc/version
MINGW64_NT-10.0 version 2.9.0(0.318/5/3) (@41cac4138e17) (gcc version 6.4.0 (GCC) ) 2018-01-12 23:37

I work on Windows as my primary machine. A new project builds in 9.8s and rebuilds in 200ms:
kamik@RED-X1C6 MINGW64 /d/sandbox/latest-project (master)
$ ng serve
Your global Angular CLI version (7.0.6) is greater than your local
version (7.0.4). The local Angular CLI version is used.

To disable this warning use "ng config -g cli.warnings.versionMismatch false".
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **

Date: 2018-11-20T17:34:59.507Z
Hash: a7c779b399674e00c600
Time: 9811ms
chunk {main} main.js, main.js.map (main) 12.7 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 223 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.08 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 16.2 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 3.55 MB [initial] [rendered]
i ｢wdm｣: Compiled successfully.
i ｢wdm｣: Compiling...

Date: 2018-11-20T17:35:14.197Z - Hash: abb5496f946efb3b5575 - Time: 2370ms
4 unchanged chunks
chunk {main} main.js, main.js.map (main) 12.7 kB [initial] [rendered]
i ｢wdm｣: Compiled successfully.
i ｢wdm｣: Compiling...

Date: 2018-11-20T17:35:15.638Z - Hash: 1de83e10d0f98ab03969 - Time: 249ms
4 unchanged chunks
chunk {main} main.js, main.js.map (main) 12.7 kB [initial] [rendered]
i ｢wdm｣: Compiled successfully.
i ｢wdm｣: Compiling...

Date: 2018-11-20T17:35:16.857Z - Hash: 0ea8cec92fc14091f190 - Time: 265ms
4 unchanged chunks
chunk {main} main.js, main.js.map (main) 12.7 kB [initial] [rendered]
i ｢wdm｣: Compiled successfully.
i ｢wdm｣: Compiling...

Date: 2018-11-20T17:35:18.939Z - Hash: 7d7bb19bc8fb9b945173 - Time: 179ms
4 unchanged chunks
chunk {main} main.js, main.js.map (main) 12.8 kB [initial] [rendered]
i ｢wdm｣: Compiled successfully.
i ｢wdm｣: Compiling...
i ｢wdm｣: wait until bundle finished: /vendor.js.map

Date: 2018-11-20T17:35:20.494Z - Hash: 661aee6ad93ece6b3add - Time: 267ms
4 unchanged chunks
chunk {main} main.js, main.js.map (main) 12.8 kB [initial] [rendered]
i ｢wdm｣: Compiled successfully.

Milan@MARS MINGW64 ~
$ cat /proc/version
MINGW64_NT-10.0 version 2.10.0(0.325/5/3) (@8d059672d1f9) (gcc version 7.3.0 (GCC) ) 2018-07-25 13:06

$ yarn start
yarn run v1.12.3
$ ng serve --open
** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **

Date: 2018-11-20T18:15:42.183Z
Hash: 2b3d9d3fb20cd18e6fca
Time: 11744ms
chunk {main} main.js, main.js.map (main) 26.8 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 223 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.08 kB [entry] [rendered]
chunk {scripts} scripts.js, scripts.js.map (scripts) 155 kB  [rendered]
chunk {styles} styles.js, styles.js.map (styles) 1.23 MB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 3.54 MB [initial] [rendered]
i ｢wdm｣: Compiled successfully.
i ｢wdm｣: Compiling...

Date: 2018-11-20T18:32:37.616Z - Hash: 2b3d9d3fb20cd18e6fca - Time: 290ms
6 unchanged chunks
i ｢wdm｣: Compiled successfully.
i ｢wdm｣: Compiling...

Date: 2018-11-20T18:34:26.049Z - Hash: 2b3d9d3fb20cd18e6fca - Time: 317ms
6 unchanged chunks
i ｢wdm｣: Compiled successfully.

Initial build with pure git bash is faster (Time: 11744ms) than (Time: 16243ms) ConEmu.

What about no colors in chunks list?

@micobarac your build times look similar to mine really. I don't the 20s rebuilds you mentioned in those logs. I'll edit the issue name to reflect that.
Your console seems to show some colors in the output and not others. I'm using gitbash on windows too and can see it when running ng serve but not when running yarn start.

Seems to be a bad interaction between yarn and the colors.

@filipesilva I think this bad interaction only occurs on Windows. I use zsh on two different terminals.
iTerm on mac and urxvt on Linux (Gentoo). None of those environments present the problem.

I don't think this is a CLI problem.

I recognized this issue of the colorless chunk list too. Anyone knows a fix for it?

Hi @valentinstn, which Angular CLI version are you using?

@alan-agius4 I'm using 9.1.4

Hi @valentinstn,
A lot of things has changed since version 9 and we haven't received similar reports. Please update to the most recent version to resolve the problem.
If the problem persists in your application after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use ng new repro-app to create a new project where you reproduce the problem.


Cannot edit the posted user response on Chromioum

I observe that I can edit my response on Firefox but not on Chromium. I don't know if it is about my browser specifically, but I like to let you know.

@erogol Thanks for letting us know. I am not aware of any issues. Can you provide console log message or the a link to where I can try it out for myself?


Create Open Banking Certs for customer release environments to do MTLS

Will need OB Test Directory issued ASPSP certificates for the customer release env software statement. See https://github.com/SecureApiGateway/SecureApiGateway/issues/781

https://manager.openbankingtest.org.uk/participants/PSD2/0015800001041REAAY/software-statements/YfxeCuxENNVSwUiJbS0LIH
However, I believe that the DNS name for the environment has changed. We also now have the concept of the mtls domain. The certs need to be re-created using the mtls domain for the customer release env.

Also need to review the Software Statement's Client URI and Redirect URI. These may need to be updated.


Bad performance with many hosts in one subnet

The performance of NIPAP is bad when having many hosts (~1100 in my case) in one subnet. The issue appears when you search for the subnet, and expand the list of hosts. Towards the end it's very slow to list the hosts. I've done a bit of troubleshooting and there seems to be two separate problems that I can find.

PREFIX_BATCH_SIZE optimization not working as intended
An expensive sort-operation in the actual SQL query when searching

PREFIX_BATCH_SIZE
PREFIX_BATCH_SIZE is set to 50 in the GUI, as far as I understand this is some kind of optimization to not query all the entries at once. When having one subnet with 1000 hosts, this results in something like 22 SQL queries, which might not be an issue. However, each additional query is slower than the previous one. By the end of it each query is around 8 seconds, and the time to complete all 22 queries is something like 2 minutes. It seems like if this optimization were to work, each additional query would have to take roughly the same time as the previous instead of always being slower and slower.
Search Query
When analyzing the actual search query there seems to be some issues:
https://explain.depesz.com/s/AXwp
For example this one:
Sort (cost=192.40..192.41 rows=7 width=289) (actual time=139.898..144.258 rows=25,138 loops=1)
Sort Key: (vrf_rt_order(vrf.rt)), p1.prefix, (CASE WHEN ((p1.prefix)::inet = (p2.prefix)::inet) THEN 0 ELSE 1 END)
Sort Method: quicksort Memory: 10116kB
I don't know much about Postgres but that's a very long time, 25000 rows and 10MB of data to sort I think? And this is with the query limit of 50 results. Maybe this can be optimized somehow?

This is one especially bad case of the search query:
https://explain.depesz.com/s/gQos
To return a list of 49 entries, Postgres has to sort through over 1.2 million entries using 300MB of space.

The query runs much faster when I remove this part:
OR
-- Join in all neighbors (p1) of matching prefixes (p2)
(true = """ + include_neighbors + """ AND iprange(p1.prefix) << iprange(p2.display_prefix::cidr) AND p1.indent = p2.indent)

The sort only has to go through 2000 rows instead of 1.2million+ in my case. New explain analyze with "neighbors" removed:
https://explain.depesz.com/s/B9xd
Maybe it should be optional to search with neighbors since it seems to slow everything down quite a lot?

I think there are other ways of speeding up the query without loosing functionality. "neighbors" is quite important to give context to searches. Back-in-the-day we didn't have it and users were confused about the result they got ;)

I'm running into similar issue.
I have multiple VRFs, on average about 400 addresses per VRF. Total of 30 VRFs. It seems that if I just scroll down and try to expand subnet in on of the lower VRFs, request takes over 40 seconds (and keeps getting longer as I add VRFs). The subnets in VRFs on the top of the screen do not seem to be affected, taking less than a second to expand.
If I filter by VRF, then the same expansion takes about 1 second. Also searching for VRF name seems to fix the issue.


Support Marathon readiness checks

Readiness checks are a means to prevent Marathon tasks from being taken into LB rotation prior to them being ready to serve traffic. The idea is that applications define a readiness check HTTP endpoint along with a number of parameters in the Marathon specification, which will cause Marathon to only mark a task as ready during the deployment of the associated application if that endpoint returns a successful response.
Traefik already vendors a copy of the go-marathon that brings readiness check support. The only thing left to do in Traefik is to filter out tasks whose readiness check result is not positive.

Internally, I have already implemented the necessary logic for Bamboo. It should be fairly trivial to port it to Traefik, which I'm going to do.


Update fluent-plugin-google-cloud to 0.8.4

This is significantly outdated, not sure as to the reason.
This does need to be tested.

Does anyone test this version?

I actually tested this out and it fails. They require an older version of fluentd, so the gems don't install.


Dynamic pipeline

The concept on this branch is to make the previously hard-coded steps in pipeline.Pipeline.run(), dynamic, so that new steps can be added, and their names modified externally (i.e. modifying the steps at the level of the examples here: https://pyopia.readthedocs.io/en/latest/pyopia.pipeline.html#a-holographic-processing-pipeline ).
I am not sure if this is a good idea (conceptually), or a sensible implementation.
Adding code here for easy comparison with main.
The main problems are:

we need to pass around a common dictionary of data that is shared between steps in the pipeline, and updated by the pipeline steps (I have done this as a dict that is passed around the pipeline).
pipeline steps need knowledge of the common data (i.e. the keys in the common dict) available from the previous steps in order to work, and this is not defined as 'easy to read inputs' to the __call__ methods in the pipeline classes (maybe this is OK, since the pipeline code should not need updating often once we land on a good solution; but it makes the pipeline harder to debug). Example, see ImagePrep.__call__ here: https://github.com/SINTEF/pyopia/blob/dynamic-pipeline/pyopia/instrument/silcam.py
The implementation I have put together here feels like a long winded way of achieving what we want, and I feel as though there might be a smarter way to do this (perhaps with decorators).

@dbuscombe-usgs @nepstad @WillRNaylor You might have some opinions on this. What do you think?
(let me know if the above notes don't make sense and I'll try to explain differently)

So going through this I am starting to get the feeling that this dict we are passing around should actually be a custom class. Maybe the class has an attribute which is the steps dict, and another attribute that is the "data" dict (alternatively a attribute which is the steps, and then each piece of data would be a seperate attribute). And then it could have a method which is your function steps_to_string().
You can do things like the following if you have seperate attrs. per piece of data (although it might be better with just a dict of all data, to save this kind of "code-nerd" type code.

class A(object):
pass

a = A()
setattr(a, 'z', 5)
a.z
5

This might be just an added complication though, as it may lead to people putting "step classes" into this "common-like" class.

yea - i read a blog on doing this yesterday, but also thought that a dictionary would be 'easier' for people interacting with the code, even though perhaps less 'proper'.

Ahh, now that I see the next PR, I think I understand that "classifer comment" above better. Although I'm not 100% sure, I believe your statement was correct actually.


Shared decoding for opcode 'a' field

Decode the 'a' opcode field right after instruction fetching. This has the benefit of removing duplicate decoding in opcode case clauses, but also has potential downsides for spilling and performance.
In concrete testing this seems to have footprint benefits but a very slight negative performance impact. As such this might be useful for reducing footprint if it could be worked in an easy to maintain option.

No longer relevant, only two call sites which decode 'A' into a variable now.


revert: v1.1.0 release

This reverts commit 239b192378944f37a4d082adb88e9fcffdb8ce04.

Still need to remove this tag

I think we each closed each other's identical PR. Re-opening this one...

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Please add Immortal Updates back to extension list

Source name
Immortal Updates
Source link
https://immortalupdates.com/
Source language
English
Other details
NSFW: No
Acknowledgements

[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

An extension with the provided URL (https://immortalupdates.com/) already exists with the name of Immortal Updates, under the English section: https://keiyoushi.github.io/extensions/extensions/#en.immortalupdates


Does Bevy Egui Need the Bevy PBR Dependency?

Hey there!
I'm using bevy_egui in my 2D game and I noticed that Bevy Egui is causing it to depend on Bevy PBR. Is this dependency necessary?
Would you be open to removing the dependency if possible?

Sorry for the noise, I was mistaken and notice now that that's only for the examples!

No worries! Glad it was figured out :)


fix(MeasurementTools): Check for widget focus

:tada: This PR is included in version 3.5.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Option to ignore whitespace differences?

Please consider adding an option to ignore differences in whitespace.
I have to compare files where one uses tabs and the other uses a combination of spaces and tabs  Doing the preliminary find-and-replace gets pretty tedious and I think incorporating such a change shouldn't be too hard... ?
Thanks for the best comparison tool I've found!

Good idea.
Looking into it, the diffing library that I'm using behind the scenes doesn't appear to support ignoring whitespace. I have however figured out a somewhat hacky workaround that seems to work alright, though it will need some testing before making it live.
If you're still interested and would like to try it out for yourself, you can download a zip of the experimental branch here. Please let me know how this works for you, and if you happen to notice any unintentional side effects that I may have missed. Once we can be sure these changes are stable, I'll release the update.
Thanks! Glad you like the plugin.

@DougTy
should it be enough to just throw it into the packages folder?
No new option for this added? (I would prefer that)

No new option for this added?
option is available in the branch experimental

@Razzeee Yes, you should be able to just stick it in your packages folder. If that doesn't work, try removing the package from package control first. A new ignore_whitespace option (defaults to false, so be sure to change that in your user settings) has been added in the experimental branch, downloadable here.

Works as advertised thanks.

Oops, forgot about this! As it seems to be working without issue, I've merged into master.

Just adding "ignore_whitespace":true to the user settings doesn´t seem to do the trick.
How exactly do I have to add it?
Using Sublime Text 3.
Thanks


Highest Supported OS module

Lists the highest supported OS version for a machine

Where are the conditions coming from? They look far more simple than the comparison thing @ hjuutilainen set up here:
https://github.com/hjuutilainen/adminscripts/blob/master/check-10.12-sierra-compatibility.py
I think the whole conditions part should be moved to config.php in an array of some sorts. This should help people that cannot update munkireport, but need to report on newer models.

The conditions are all within the model. It takes the machine ID, iMac7,1, and turns it into a string "iMac71". It then checks for the machine family, iMac, and removes the machine family from the string. It then checks the resulting int, 71, to see if it is in the range of supported OSes starting with the highest and working down.
I thought this method would be better than hard coding in every single Mac model ID or logicboard ID. If a new machine, such as iMac20,1, was to check it it would fall into the range that would set its highest OS as the most recent.

I like the idea, but not so sure on the implementation 😄
At the moment, maintaining this would require quite some effort. It would be easier if the module could pull the data from some external source (or even an internal source if that exists).
If that's not possible, I would change the whole 'if then' comparison thing into a big array like:
$max_version = [
    'iMac' => [
        '71' => '10.11.6',
    ]
];

And process that, so that it's easy for people to add new datapoints.

I don't know how to do the array thing without hard coding in every single known Mac model. I'd prefer to have the data source within MR to prevent the module from breaking if the external source changes or goes offline.


Crash on startup

Hello,
since this morning I am not able to build the canarytokens docker containers for switchboard and frontend anymore. I tried:

Clone canarytokens-docker repository again
Copy .env-Files
docker stop $(docker ps -q)
docker system prune -a
docker-compose -f docker-compose.yml up

Here is the error message:
switchboard    | Unhandled Error
switchboard    | Traceback (most recent call last):
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/application/app.py", line 674, in run
switchboard    |     runApp(config)
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/scripts/twistd.py", line 25, in runApp
switchboard    |     runner.run()
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/application/app.py", line 381, in run
switchboard    |     self.application = self.createOrGetApplication()
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/application/app.py", line 453, in createOrGetApplication
switchboard    |     application = getApplication(self.config, passphrase)
switchboard    | --- <exception caught here> ---
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/application/app.py", line 464, in getApplication
switchboard    |     application = service.loadApplication(filename, style, passphrase)
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/application/service.py", line 416, in loadApplication
switchboard    |     application = sob.loadValueFromFile(filename, 'application')
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/persisted/sob.py", line 177, in loadValueFromFile
switchboard    |     eval(codeObj, d, d)
switchboard    |   File "switchboard.tac", line 8, in <module>
switchboard    |     from twisted.application import service, internet
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/twisted/application/internet.py", line 54, in <module>
switchboard    |     from automat import MethodicalMachine
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/automat/__init__.py", line 2, in <module>
switchboard    |     from ._methodical import MethodicalMachine
switchboard    |   File "/usr/local/lib/python2.7/dist-packages/automat/_methodical.py", line 7, in <module>
switchboard    |     from inspect import getfullargspec as getArgsSpec
switchboard    | exceptions.ImportError: cannot import name getfullargspec
switchboard    |
switchboard    |
switchboard    | Failed to load application: cannot import name getfullargspec
switchboard    |
frontend exited with code 1
switchboard exited with code 1

The error is identical for both frontend and switchboard.
Any ideas?
Kind Regards
Gearanach

This is a bug caused by an update from 29.10.2022 to a dependency for one of the packages listed in requirements.txt.
Fix: Add Automat==20.2.0 to the requirements.txt.

Hi @gearanach,
Thanks for reporting this. We are looking into it now


[Map] CTF-FSW-Hotel-FreakShow2021

Hash: 93d7bb5e04108ef736b9c5f882f730d0f0004e67
Current name: CTF-FSW-Hotel-FreakShow2021
For some reason there are things incorrect in, or missing from, Map Information :
a) No screenshots though there are several specified in LevelInfo and included in MyLevel;
b) Player Count = Unknown, though in the LevelInfo this is given as 2 - 24;
c) AI/Bot Support = No, though the map does indeed have bot support (it is pathed).

Looks like the author name had some values which broke the reader.
The problem was fixed in a change to the package parser a little while ago so I re-indexed it.
I did simplify the author name too.


Door collision fixes

Fixed some door issues:

collideable is now set after doing the last door crushing/safety check

Previously would lead to doors visually opening when aborting close, but still being impassable.

Make the client's state handling copy the list of colliding entities, rather than copy the reference.
Make get-colliding use collision layers.

I just pilfered the collision mask check from SharedMoverController.IsAroundCollider()
Should stop ghosts from blocking doors. Windoors & tables still seem to work fine.

:cl:

fixed: Fixed some door bugs that resulted doors that were impassable despite being open.

Fixed by #6836


Rename explorer as details

Some page refactoring:

Rename explorer page as details
Update page titles
Rename overview directory

Codecov Report

Merging #28 (1f4fa7b) into main (c87fb02) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main     #28   +/-   ##
=====================================
  Coverage   1.08%   1.08%
=====================================
  Files         26      26
  Lines        552     552
  Branches      78      78
=====================================
  Hits           6       6
  Misses       546     546

Impacted Files
Coverage Δ

src/Routes.tsx
0.00% <0.00%> (ø)

src/components/FeatureFlags/FeatureFlags.tsx
0.00% <0.00%> (ø)

src/components/PageTitle/PageTitle.tsx
0.00% <0.00%> (ø)

src/components/UserAccess/Permissions.tsx
0.00% <0.00%> (ø)

.../routes/state/NotAuthorized/NotAuthorizedState.tsx
0.00% <0.00%> (ø)

src/routes/views/details/Details.tsx
0.00% <0.00%> (ø)

src/routes/views/overview/Overview.tsx
0.00% <0.00%> (ø)

...ws/overview/components/ActualSpend/ActualSpend.tsx
0.00% <0.00%> (ø)

...ents/ActualSpendBreakdown/ActualSpendBreakdown.tsx
0.00% <0.00%> (ø)

...rview/components/CommittedSpend/CommittedSpend.tsx
0.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87fb02...1f4fa7b. Read the comment docs.


SetState Progress Logging

Don't name public branches this way. Should just be setstate-progress-logging

Stephen had pointed that out to me yesterday. I changed the PR name, should I go ahead and change the branch name as well? @tst-basilhuffman

Stephen had pointed that out to me yesterday. I changed the PR name, should I go ahead and change the branch name as well? @tst-basilhuffman

At this point, it may not really matter. @tst-lsavoie ?


Remove sdx-common logging

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   55.99%   55.99%
=======================================
  Files           8        8
  Lines         609      609
=======================================
  Hits          341      341
  Misses        268      268

Impacted Files
Coverage Δ

app/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb542e...7b138db. Read the comment docs.


Add DELETE /v1/networks/{networkId}/views/{viewId}/{objectType}/{visualProperty}/bypass

Basically a generic version of the network delete method you have already:
DELETE /v1/networks/{networkId}/views/{viewId}/network/{visualProperty}/bypass

Replacing network with {objectType}. I would like to use this to remove all bypasses for nodes and edges, for example. This is needed for basic operations like unhideAll(), which currently must DELETE for each node (very slow) or toggle the bypass value (which will continue to override any mappings).

@dotasek Do you prefer tracking CyREST issues here or at Jira?

Thanks!
http://localhost:1234/v1/swaggerUI/swagger-ui/index.html?url=http://localhost:1234/v1/swagger.json#!/Network32Views/deleteSingleVisualPropertyValueBypass

Ah, I spoke too soon. Looks like this one is not the new one. Reopened.

This is a difficult one, because of the data model. I think the correct way to handle this and other bulk updates is through the PATCH method.
If you follow the issue thread for #88, Google has a method for updating which could work:
PATCH /v1/networks/{networkId}/views/{viewId}/{objectType}?matches=ALL&bypass=true

with the content either being a value to create or update:
{
    "visualProperty": "COMPOUND_NODE_SHAPE",
    "value": "ROUND_RECTANGLE"
}

or a null value to delete
{
    "visualProperty": "COMPOUND_NODE_SHAPE",
    "value": null
}

I have to check if null is usable, because bypass might treat that as a valid value instead of a signal to delete.

Should we try to implement PATCH in RCy3 and py4cytoscape per your tip above? Or is there more checking needed first, i.e., regarding null?


Fix PageView throws Null check error

Description
This PR fixes a null check error in PageView.
The null check was added by the following PR : https://github.com/flutter/flutter/pull/65015
Flutter 3.0 is the first stable release where the null check error surfaces.
It surfaces due to the following PR : https://github.com/flutter/flutter/pull/97971
which added a call to MediaQuery in SrollableState.didChangeDependencies (line 462) :
  @override
  void didChangeDependencies() {
    _mediaQueryData = MediaQuery.maybeOf(context);
    _updatePosition();
    super.didChangeDependencies();
  }

During startup, especially in release mode, MediaQuery.of(context).size might return (0,0). The size will be updated when the native platform reports the actual resolution (several milliseconds later). This seems to be by design for performance reasons (see https://github.com/flutter/flutter/issues/25827#issuecomment-571804641).
For PageView, it means that the Viewport dimensions are updated during startup which was not expected with the previous code.
Related Issue
Fixes https://github.com/flutter/flutter/issues/101007
Tests
Adds 1 test.

Hey， this issue is similar to this #103328,
We should override absorb when the _PagePosition was replaced.
  @override
  void absorb(ScrollPosition other) {
    super.absorb(other);
    assert(_cachedPage == null);

    if (other is! _PagePosition) {
      return;
    }

    if (other._cachedPage != null) {
      _cachedPage = other._cachedPage;
      other._cachedPage = null;
    }
  }

Anyone knows when is this landing on stable branch>

The issue still exist in the flutter version 3.0.5.
Anyone knows when the patch will be released?

Yes still happening in version 3.0.5

Is this expected to be fixed in 3.0.5 and it's an issue again or it wasn't included in 3.0.5?

@tonyshkurenko
It was not included in 3.0.5.
For the moment, this fix is available in the master channel and in the 3.3 beta channel.

I confirm, issue fixed in 3.3.0 release.


Trailing where clause for extension of non-generic type

I produced this error both all of the default JSON Mapping libraries (Himotaki, Argo, Unbox) which refers in this link
trailing where clause for extension of non-generic type 'LoginRequest'
extension LoginRequest where Response: Marshaling {
    func response(from object: Any, urlResponse: HTTPURLResponse) throws -> Login {

    }
}

Hi, @ttuygun.
I guess your LoginRequest is a struct or a class. If you want to provide implementation of response(from:urlResponse:) for a single request type, just remove the where clause or move the method into type declaration.
The guide you mentioned assumes type to extend is a protocol. It demonstrates how to provide implementation of response(from:urlResponse:) for multiple request types which conforms to the common request protocol (GitHubRequest in the example).
To follow this way, make a common request protocol and let LoginRequest to conform to the protocol like this:
protocol YourServiceRequest: Request {
    ...
}

extension YourServiceRequest where Response: Marshaling {
    func response(from object: Any, urlResponse: HTTPURLResponse) throws -> Login {
        fatalError("To be implemented.")
    }
}

struct LoginRequest: YourServiceRequest {
    ...
}

Wow, thank you for information. It really helps to understand about protocols and solving problem.

🎉


Ability to right-click rename bank tags

Short version below.
I use bank tags for everything I do. I have tags for every slayer assignment, every daily... Pretty much, if I ever need to have the same gear at some point in the future, I'll make a tag for it. I've just ran into the following issue. I have a fire_giants tag for Fire Giants. These are usually pretty AFK-able, so I use ranged in the Waterfall dungeon. I now want to slay them using melee in the Catacombs of Kourend. Now, optimally, I'd rename fire_giants to fire_giants_ranged and make a new tag fire_giants_melee, but unfortunately, I have to take out each item from the fire_giants tag, make a new tag fire_giants_ranged, then mass-add them all there by right-clicking the Deposit Inventory button and clicking Tag-inventory fire_giants_ranged. I'd like to see the option to rename a tag on the right-click menu of a tag. This would allow the user to change the name, and all items with that tag would have the old tag removed and the new tag applied to them.
Short version: Right-click rename bank tag tabs.

You can export the tab and edit it in notepad, re copy it, and import it.

That's an interesting workaround, I'll use that for now. Thanks for the suggestion!


Issue when running migration

I am using Django-2.1 with last release of django-multitenant and I am writing a migration on a model which inherits from TenantModel. But when I run the migration, I get error that
AttributeError: type object 'Shipment' has no attribute 'tenant_id'
The model that I have is:
class Fulfillment(TenantModel):
  ....
  shipment = TenantForeignKey('Shipment', on_delete=models.CASCADE)
  tenant_id = 'store_id'

  class Meta:
       unique_together = ('id', 'store')

But if I set the tenant_id = 'store_id' explicitly in migration, it works fine. I am not sure why is it complaining and what is the right way to fix this. Any help is appreciated.

Hello,
I have a few questions:

When you say you are using the latest release, is it the one on pypi? We haven't released on pypi the current master.
Is the Shipment table distributed?
What did you add in the migration exactly?

Thank you

@louiseGrandjonc. Thanks for your response. Please find questions to your answers below:

When you say you are using the latest release, is it the one on pypi? We haven't released on pypi the current master.

No I meant the actual release not what is on the master branch.

Is the Shipment table distributed?

You mean in split across shards? No it is a single database for now.

What did you add in the migration exactly?

My migration looks something like this:
from django.db import migrations

def set_subscription_on_fulfillment(apps, schema_editor):
    """
    Sets the subscription on fulfillment
    """
    Customer = apps.get_model('cratejoy', 'Customer')
    Fulfillment = apps.get_model('cratejoy', 'Fulfillment')
    Shipment = apps.get_model('cratejoy', 'Shipment')
    Subscription = apps.get_model('cratejoy', 'Subscription')
    Customer.tenant_id = 'store_id'
    Fulfillment.tenant_id = 'store_id'
    Shipment.tenant_id = 'store_id'
    Subscription.tenant_id = 'store_id'

    for fulfillment in Fulfillment.objects.all():
        if not fulfillment.subscription:
            fulfillment.subscription = fulfillment.order.subscriptions.last()
            fulfillment.save()

class Migration(migrations.Migration):

    dependencies = [
        ('cratejoy', '0032_fulfillment_subscription'),
    ]

    operations = [
        migrations.RunPython(set_subscription_on_fulfillment),
    ]

If I don't set model.tenant_id = 'store_id', it fails with the error that I mentioned in my original post.

Hi @divick,
sorry for the delay. I actually ran into a similar issue when creating a new feature.
The way django works, the models are initialized after running Migrations, during migrations, you have access to a fake model with only the models.fields, which explains why tenant_id is not accessible.
To be able to access the tenant_id, here was my solution:
https://github.com/citusdata/django-multitenant/blob/master/django_multitenant/db/migrations/distribute.py#L31


[Modification Request] Update the icon in Bento.Item to appear the same as Card (with a background)

Summary
Currently the Bento's LeadingVisual is an Octicon with no background.
There are now new design directions about how icons should render in Bento boxes, the same way they appear in cards. (c.c. @nsolerieu):

Corresponding issue: https://github.com/github/marketing-platform-services/issues/3553
Requested update:
There be an option for the circular icon as a child of Bento.Item

Hey @rfearing 👋
Following on from the discussions in yesterday's Primer Brand Office Hours, @danielguillan and I think the best way to proceed is with a dedicated Icon component.
Adding a new component to the library typically comprises of a few steps:

API exploration
Figma implementation
React implementation

If you're still happy to work on the implementation of this yourself — which we'd be very grateful for — then here's some information on each of those steps.
API exploration
The purpose of an API Exploration is to flesh out the API of new components with the Primer Brand maintainers. This is where we can discuss component naming, what props the component will accept (and the types of those props), and highlight anything that is out-of-scope for this component.
As a starting point, you might want to take a look at the Card.Icon component as that already implements some props (icon, color, hasBackground) that we'll likely want to support in this new component.
Typically these API explorations take place in a FigJam, however we can do it any way you prefer. If you'd like, you can instead share your proposed types for the props that the component will accept as a comment in this issue. I've got some initial thoughts on this, so let me know if you'd like some support with this 🙂
Figma implementation
After speaking with @danielguillan, I believe there is already a private component in Figma which is used in the Card component. This will need to be made into a public-facing component so it can be consumed alongside other Primer Brand components in Figma.
@danielguillan is the best person to speak to for support on this.
React implementation
Once we've got the API of the component firmed-up, and the component is in Figma, then the component is ready to be implemented. By this point most of the decisions relating to this component will have been made will have been made, so building the component shouldn't be too big of a job. We'll also need to ensure that the component is tested, and that it has accompanying documentation.
I'd be happy to support with this.
Next steps
Thanks again for offering to help with adding this component to the library. The process above might sound like a lot when it's all written out like this, but in practice it shouldn't be too big of a job. Of course, we're here to help with all stages too.
If you're happy to kick off the API exploration in this issue then we can get the ball rolling! ⚽ 🚀

@joshfarrant Thank you so much for the super awesome explanation! Let's do it!
I really like the API of the Card.Icon. I believe they could be identical (or nearly identical):
type IconProps = BaseProps<HTMLSpanElement> & {
  icon: Icon // from @primer/octicons-react
  color?: (typeof IconColors)[number] // same as CardIconColors?
  hasBackground?: boolean
  ['aria-hidden']?: boolean // For Bento this would be true
}

(Note, I'm happy to start a figjam if that's what's best for Brand worfklow)

That looks good to me @rfearing! 🚀
My only suggestions would be to maybe have it extend HTMLAttributes<HTMLSpanElement> (or HTMLDivElement if you think a div is more appropriate). If we do that then we can remove the explicit aria-hidden in the type as it will be covered by HTMLAttributes.
We also don't really need the BaseProps as this component doesn't support the animate prop, which BaseProps would suggest it does. There's a wider conversation to be had around the utility of BaseProps as a whole I think, so feel free to drop it / keep it as you like.
I'd be keen to get @danielguillan's thoughts on the supported colours, but keeping it consistent with CardIconColors makes sense to me 👍
type IconProps = {
  icon: Icon
  color?: (typeof IconColors)[number]
  hasBackground?: boolean
} & HTMLAttributes<HTMLSpanElement>

The only other thing to think about is the default values of color and hasBackground. Keeping those the same as Card.Icon works for me too 🙂

@joshfarrant I just realized the Primer Icon has a size prop. Do you think we should include that?

Good spot @rfearing. For now, I'd lean towards not adding it. We can bring that in as an enhancement in the future, but to keep things consistent my leaning would be to not add it for now

Hey @rezrah + @joshfarrant 👋
After PB OH, I took a look at our icon instances, and I think we could approach it this way:
Icon with background:
One size - Icon is 20px x 20px itself; full dimensions with the background included are 44px x 44px.
Icons without backgrounds:
Small - 20px x 20px
Medium - 32px x 32px (used on pillars)
Large - 44px x 44px (used on bentos)
The last three are suggested sizes we could apply to each of those existing scenarios. Let me know what you think.


Create job for recreating graph build image

also parallelize ec2 validation checks
Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[ ] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
This PR does the following:

refactors the validation of ec2 config to be parallelized and accessible from other classes
adds a validation check to make sure the graph build instance name that should be recreated has a unique name
adds a validation check to AMI IDs to make sure they have an available state
adds validation of ec2 config to the beginning of a deploy job
adds a new job of RecreateBuildImageJob that happens asynchronously from the rest of the deploy job

Codecov Report

Merging #330 into dev will decrease coverage by 0.34%.
The diff coverage is 1.04%.

@@             Coverage Diff              @@
##                dev     #330      +/-   ##
============================================
- Coverage     24.38%   24.03%   -0.35%
  Complexity      538      538
============================================
  Files           167      168       +1
  Lines          8657     8786     +129
  Branches       1192     1219      +27
============================================
+ Hits           2111     2112       +1
- Misses         6338     6466     +128
  Partials        208      208

Flag
Coverage Δ
Complexity Δ

#unit_tests
24.03% <1.04%> (-0.35%)
538.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

...ools/manager/controllers/api/ServerController.java
3.66% <0.00%> (-1.25%)
1.00 <0.00> (ø)

...com/conveyal/datatools/manager/jobs/DeployJob.java
20.08% <0.00%> (+0.16%)
14.00 <0.00> (ø)

.../datatools/manager/jobs/RecreateBuildImageJob.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...nveyal/datatools/common/status/MonitorableJob.java
80.99% <100.00%> (+0.15%)
12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa648a...f0241a2. Read the comment docs.

I just did a little refactor, but have some open ideas on how to address some other comments. See this one in particular: https://github.com/ibi-group/datatools-server/pull/330#discussion_r465246478.

Herzlichen Dank an Euch,
habe mich 1mal abgemeldet.
LG

@landonreed , I went ahead and made the RecreateBuildImageJob use a new SingleThreadExecutor that is internal to the DeployJob. The DeployJob already starts its own thread pools anyways when running MonitorServerStatusJobs. Choosing the right number of threads to create is always a balancing act of trying to figure out how much CPU/Memory each thread will need to utilize, but as long as the threads are just sitting there waiting for stuff and then making a check-in HTTP request every once in a while, it shouldn't be much of an issue. In this StackOverflow answer, people have been saying they can get Java 8+ to handle over 400,000 threads.

:tada: This PR is included in version 3.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add MIT license

Hello!
I noticed this repository doesn't have a license. Of course there is ISC in the package.json license field, but I don't think that's intentional as it's just the default option when running npm init and I'm also not sure it's sufficient. I looked through some of your (@gvergnaud) other repositories and it seems like you prefer the MIT license, so I chose it here.
You may not be aware of this, but legally, without a license, no one can use your code.
https://choosealicense.com/no-permission/

Since this repository also has some contributors, I'm fairly certain they have to give permission to a full license addition/change. Sorry for pinging you guys but AFAIK this PR can't move forward without your approval.
@ecyrbe @frankie303 @sno2 @un4uthorized @Beraliv @eloytoro @ggrandi @adamsuskin @AeRo8 @jessekelly881

@nnmrts @Sardonyx001 I only contributed a small number of features, therefore it's not up to me to decide on the license. If it comes back to me, I'm happy to make it MIT or a more secure license
Based on number of contributions, the decision comes to @gvergnaud and @ecyrbe

a-ok with me :)


Support bool fields in serialization/deserialization

@shanemhansen: thanks for this contribution. I fixed the test it broke -- please remember to run the test suite too -- make at the top level will do this, or "make test".


Fix C source files compilation

The current flags break C compilation when building with --asmjs, because emscripten doesn't understand why C++-specific flags are used with the C compiler. This commit fix this by splitted the flags as cflags and cflags_cc.

Thank you for the PR!


Better error handling

Hi, this pull request validates that json data received from server exists before setting last error, because in some cases, it doesn't return the xdebug_message, also this code centralizes error handling.
BTW, if this pull is accepted, could you please update composer? We need to have latest commit in composer repo.

Hi Skatox and thanks for the PR!
I will try to review your code in a timely manner. I am not very happy with the implementation which catches exceptions inside the library. I want to give the user of the library the possibility to catch exceptions. See issue #3.
Any feedback is welcome.

Ok, I agree. It should be better to let the user control the exceptions.

@Skatox I started working in the development branch on a new version of this library.
https://github.com/vdespa/Vtiger-Web-Services-PHP-Client-Library/tree/development
It is a complete redo of the library, still in a very alpha state. It is possible to do CRUD operations on the Account entity.
Feedback is welcomed. Let me know what you think.

Thanks for the info, as soon as I have time, I'll check it.
El 11/15/15 a las 11:41, Valentin Despa escribió:

@Skatox https://github.com/Skatox I started working in the
development branch on a new version of this library.
https://github.com/vdespa/Vtiger-Web-Services-PHP-Client-Library/tree/development
It is a complete redo of the library, still in a very alpha state. It
is possible to do CRUD operations on the Account entity.
Feedback is welcomed. Let me know what you think.
—
Reply to this email directly or view it on GitHub
https://github.com/vdespa/Vtiger-Web-Services-PHP-Client-Library/pull/7#issuecomment-156824724.

--
Miguel Ángel Useche
<EMAIL_ADDRESS>http://skatox.com/
@skatox


CEL-898. Update chorus to actual state. Without git history saving

Feel free to merge after testing this PR.

Feel free to merge after testing this PR.
This is a fork of Chorus Enterprise. It was tested by Oleksandr Molchanov.


feat: add new logo to storybook

This PR implements #389

Codecov Report

Merging #392 (6cad3e1) into main (f44e2d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   97.90%   97.90%
=======================================
  Files          61       61
  Lines         667      667
  Branches      106      106
=======================================
  Hits          653      653
  Misses         12       12
  Partials        2        2

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Bug] [dolphinscheduler-service] NPE was raised when i open Workflow Definition UI after saving one Workflow Instance without selecting syncDefine

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
As the issue title said，steps as list:

Define a Workflow and run it , then i got a Workflow Instance

Edit the Workflow Instance then saving it without selecting 'update definition' check-box .

Return to the Workflow Definition UI , i got a error

and i found an NPE in the backend logs

The direct cause is THE VAR processDefinitionLog IS NULL

i check records in the meta-database(mysql style) and find that records accidentally lost in table t_ds_process_definition_log
There should be two records, their version column values are 1 and 2 respectively
(直接原因是t_ds_process_definition_log表丢失了一条version列值为1的记录)

What you expected to happen
No exception occurred
How to reproduce
The steps are listed in the paragraph What happened above
Anything else
I analysis the codes and i think the root is in method org.apache.dolphinscheduler.service.process.ProcessServiceImpl#saveProcessDefine:
it query the log obj which according to the ID of the definition obj , then updating the log obj to set a new version .
The t_ds_process_definition_log table should keeps all records of definition's changes and the record should not be overwritten or updated, which may be against the design
(根本原因是更新工作流实例时，根据工作流定义的ID查找了 LOG 对象 并修改了 version值 , Log表应该保留所有定义变更的历史记录，不应该把version=1的记录更新掉。况且用定义对象的ID去查询更新LOG对象就不对。)

Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This bug should be quite obvious
I'm confused why no one mentioned it, has anyone else meeted this bug???

This bug should be quite obvious I'm confused why no one mentioned it, has anyone else meeted this bug???

This bug should be quite obvious I'm confused why no one mentioned it, has anyone else meeted this bug???

Maybe , I THINK , this bug only happens with brand new meta-database

it have been fixed by Ruan.


The number of messages from the dropped is not matched after publish.

The number of messages from the dropped is not matched after publish.
The WS.SEND is a dropped message of the same number of dropped messages as the counter 2 of the return results, and Publish seems to be missing.
Testing is a method of send 100000 sync(not async) messages from another processor and testing a message that the server cannot handle.
uWebsockets.js version=20.43.0

publish
proc1 send message * 100,000 -> proc2(uWebsockets.js) publish -> proc1 check receive Count
->return true=100,000,      dropped callback count 13,000, echo receive 28,000, proc2 drain 1(buffer length=0)

ws.send
proc1 send message * 100,000 -> proc2(uWebsockets.js) ws.send -> proc1 check receive Count
->return result 2=72,000, dropped callback count 72,000(same), echo receive 28,000, proc2 drain 1(buffer length=0)

*There are detailed numbers, but omitted
In addition to the same message, the number of eco -response has been checked, so it can be seen that Publish was not successful. For reference, the Drain callback came once(1) out of 100,000 times in both publish and ws.send.
Publish is automatically managed by the backpressure value, but it seems that the MISSED must have a message. It is a test that sends the same message as WS.SEND. If Publish is a design that doesn't care much about missing messages, it is inevitable. Since Publish is aimed at multiple topic users, it is a problem because it is not structurally like GetBufferedamount, so I want to create something like Topicws = {} that manages the topic separately. Please let me know if I missed. thank you
ps. I turned a language translator. Please understand

Can you make this into a integration test? Can run it in CI.

In other words; can you provide the code that you based your conclusion on?

uWebsocket Server (proc2)
`
var droppedCnt=0, droppedCnt2=0, doneCnt=0;
var usp=uws.App()
.ws('/*', {
idleTimeout:0,
open:(ws)=>{
ws.subscribe('node')
},
message:async (ws, msg, isBinary)=>{
let data;
try{
data=JSON.parse(Buffer.from(msg).toString());
let res=await db.get(data.query);
// res is object {...}
// ws.send
res['uuid']=data.uuid;
let sendRes=ws.send(JSON.stringify(res), true, true);
if(sendRes==2)droppedCnt2++;
     // publish
     // usp.publish('node', JSON.stringify(res), true, true);

     doneCnt++;
}catch(e){
    console.error('message', data, e)
}},
drain:(ws)=>{
    console.log('drain:', ws.getBufferedAmount().length)
},
dropped:(ws)=>{
    droppedCnt++;
}
close:async (ws, code)=>{try{
}catch(e){

}}

})
`
In Proc1, WS turns for loops and sends a 100,000 DB request message. recognize the request response in the WS message by putting UUID in the message.
Because I test like this
In WS.SEND(Proc2 uWebsockets server side), DROPP Callback(droppedCnt) and ws.Send's Result: The result 2(droppedCnt2) is exactly matched, so handling is possible.
Publish comes only 13,000 messages to Dropped, and only 28,000 messages come to the WS side(proc 1).
doneCnt is well -driven by 100,000 when doing send or public. In other words, the DB query was no problem. no Crash, no error
Of course, I will check the buffer if I use WS.SEND in the production code, but the problem is that the publish is not controlled by the dropped.

I don't think the code function is not good in the GitHub editor ... I can't modify it. Anyway, the server side code is conceptually everything.

message:async (ws, msg, isBinary)=>{
let data;
try{
data=JSON.parse(Buffer.from(msg).toString());
let res=await db.get(data.query);

uWebSockets.js cannot handle asynchrony correctly and cannot be treated as node environment code. It is only suitable for underlying network forwarding. It will block your asynchrony and cause code problems: it makes sense that its official cases do not include basic database connection operations.


Clarify authentication certificate and probe relationship

Added additional note in Step 7 to clarify the usage of the authentication certificate and how it correlates with the default probe's behaviour (in lieu of working custom HTTPS probes) in the event that the back-ends host multiple sites with SSL bindings and/or SNI. Since the probe only reaches the default SSL binding; if there is no default SSL binding, the back-end would not be whitelisted. If there is a binding and the public key does not match the authentication certificate, the back-end would not be whitelisted. Therefore, the public key of the default SSL binding of the back-end(s) must match the provided authentication certificate. In many cases this would mean that the same authentication certificate is used for ALL host-header/SNI enabled SSL sites hosted on the same back-end.

Hi @lwsrbrts, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@lwsrbrts : Thanks for your contribution to the Azure documentation! The author, @georgewallace, has been notified to review your proposed change.

@lwsrbrts thanks for your contribution. Your contributions are greatly appreciated. I an reviewing your changes.

#sign-off


Android Java: 13.01 How to start an activity using animation?

Description :scroll:

Give a step-by-step tutorial in Java along with a brief and clear explanation.
Required Documentation or Video or Audio.

Domain of Contribution :bar_chart:

[x] Android Dev (java)

References :
https://developer.android.com/training/transitions/start-activity?authuser=3

Please Read it Carefully Before Contributing

Changes should be made in Android_Development_With_Java/ directory under Android_Development_With_Java branch.
Inside Android_Development_With_Java directory/ creates a directory and names it according to the topic
Inside Topic Name directory/ add your task with subtopic number and name and make changes accordingly.
You have to push your PR to the Android_Development_With_Java branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Java pending then please first complete them.

Supervisor @VikasPandey121

/assign


Bug: Tweet deletion broken

It seems tweets are not being deleted. I need to look into whats happening, maybe twitter changed their API without notifying us.

could not reproduce, will see if the new commit helps finding the source of the issue


BUG: Mixed period cannot be displayed with ValueError

[x] closes #xxxx (not reported)
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

# we can create Series contains Periods with mixed freq
s = pd.Series([pd.Period('2011-01', freq='M'), pd.Period('2011-02-01', freq='D')])

# print the created Series raises ValueError
print(s)
# ValueError: Input has different freq=D from PeriodIndex(freq=M)

I would change the exception that PeriodIndex raises to maybe: IncompatbileFrequency(ValueError) and catch that. Its a more informative error I think. (its in src/periods.pyx/extract_ordinals)

Current coverage is 88.64%

Merging #12615 into master will not affect coverage as of b12fd75

@@            master   #12615   diff @@
=======================================
  Files          275      275
  Stmts       133688   133716    +28
  Branches         0        0
  Methods          0        0
=======================================
+ Hit         118511   118539    +28
  Partial          0        0
  Missed       15177    15177

Review entire Coverage Diff as of b12fd75

Uncovered Suggestions

+0.07% via ...s/io/sas/sas7bdat.py#30...121
+0.03% via ...s/io/sas/sas7bdat.py#531...569
+0.03% via ...as/tools/plotting.py#633...664
See 7 more...

Powered by Codecov. Updated on successful CI builds.

OK, changed to raise IncompatibleFrequency and fixed corresponding tests.

lgtm. let me know if you want to change the import now or later.

lgtm. ping on green

thanks @sinhrks


No packages found error with Jamf Cloud JCDS despite log showing non-empty JCDS Packages list after "checking Jamf Cloud" message

Tested with jamfcpr 0.9.7 and a Jamf Cloud DP
After clicking "List" and error message "Attention: No packages found.  Please verify server, username, and password are correct." is displayed.
Looking at the jamfcpr log following the "checking Jamf Cloud" label there is a list of all available packages following the log statement "JCDS Packages:"
Additional data point: Prior to the "checking Jamf Cloud"  label there are many occurrences of the following for some, but not all, of the files that are in the JCDS
20210321_223109 [ListCloudPackages-casperJxmlGet] entry: FileServer(ip: "", share: "", type: "", domain: "", , ...
20210321_223109 [betweenTags] Nothing found between https:// and //.

Wondering if you also have file distribution points in addition to the JCDS and which is the primary.  What version of Jamf Pro are you running?
On Mar 21, 2021, at 10:45 PM, Steve Dagley<EMAIL_ADDRESS>wrote:
Tested with jamfcpr 0.9.7 and a Jamf Cloud DP
After clicking "List" and error message "Attention: No packages found. Please verify server, username, and password are correct." is displayed.
Looking at the jamfcpr log following the "checking Jamf Cloud" label there is a list of all available packages following the log statement "JCDS Packages:"
Additional data point: Prior to the "checking Jamf Cloud" label there are many occurrences of the following for some, but not all, of the files that are in the JCDS
20210321_223109 [ListCloudPackages-casperJxmlGet] entry: FileServer(ip: "", share: "", type: "", domain: "", , ...
20210321_223109 [betweenTags] Nothing found between https:// and //.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/BIG-RAT/jamfcpr/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJYQF5VMMWH27SU5ZLSSHDTE2VMRANCNFSM4ZSH5WQA.
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/BIG-RAT/jamfcpr/issues/2", "url": "https://github.com/BIG-RAT/jamfcpr/issues/2", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

No File Share DPs, only JCDS. Jamf Pro 10.27.0

Any chance I could see, at least part of, what is returned for packageData in the log (after removing specific download directory and token)?  Something like:
20210322_081023 [ListCloudPackages-casperJxmlGet] packageData: <packages><package><id>274</id><checksum>eeb620e2752290b8912dd5bf567864c5</checksum><size>7498747</size><lastModified>1588195848000</lastModified><fileURL>https://use1-jcds.services.jamfcloud.com//download/directorystring/JamfConnectSync-1.4.3.pkg?token=somelongstring</fileURL></package><package><id>223</id><checksum>571abaa9d6775a972f4605ab6e4b97c4</checksum><size>5405</size><lastModified>1569355241000</lastModified><fileURL>https://use1-jcds.services.jamfcloud.com//download/directorystring/Cylance2.0.1500-2018-11-28.pkg?token=somelongstring</fileURL></package><package><id>336</id><checksum>7e953202951cbd2ff2b13c3984501ee7</checksum><size>15514</size><lastModified>1615908045000</lastModified><fileURL>https://use1-jcds.services.jamfcloud.com//download/directorystring/JamfConnectLaunchAgent-2.2.2.pkg?token=somelongstring</fileURL></package><package><id>342</id><checksum>1b202f8b6d5a7d757c8ff737d71b51ca</checksum><size>17667</size><lastModified>1611677704000</lastModified><fileURL>https://use1-jcds.services.jamfcloud.com//download/directorystring/WeWorkEnroll.pkg?token=somelongstring</fileURL></package><package><id>279</id><checksum>13af77d60614608bcbd8d1a5d0173edb</checksum><size>24348</size><lastModified>1588715387000</lastModified><fileURL>https://use1-jcds.services.jamfcloud.com//download/directorystring/dockutil.pkg?token=somelongstring</fileURL></package><package><id>337</id><checksum>8eda3a98aae03605984b222112baf407</checksum><size>5154379</size><lastModified>1604436614000</lastModified><fileURL>https://use1-jcds.services.jamfcloud.com//download/directorystring/DEPNotify_1.1.5_signed.pkg?token=somelongstring</fileURL></package>

Should be resolved with v0.9.8

Verified that the v0.9.8 build available from the Releases page resolves the issue.


update to 3.3, rm use of AuthStatus error code

see core-bentley breaking change

this looks good to me. Let's wait until the current release is through that bumps the patch version. Then we can do this and bump the minor.


Design and Deploy Your First Integration Flow

Tutorials: https://developers.sap.com/tutorials/cp-starter-integration-cpi-design-iflow.html
Step 2: Create an integration package and integration flow : substep-2 : New option 'Export' is displaying in the Artifacts tab
Expected:

Actual:

Note : The same screenshot need to update for substep-3

hi @NidhiMurkute - changes are made. will be published soon.


Multiple css file

We have the button.css and style.css in both the cas folder amd the primary folder.
Delete the outer css files so as to follow the tree diagram specified in the project.

Ok

can i fix this  @Dhavisco

can i fix this @Dhavisco

You can ask @divyanshudhruv

I think let @Dhavisco fix this, as he opened the issue.. @Thanush19 you can try to fix other bug if present

Noted. I will work on it too

Good luck

Hello, please visit here

When will you open the pr ? @Dhavisco

Yes. Happy Hacktoberfest

Pls add the hacktoberfest logo

Ok


Add Preemption to Glossary page

#5993
I need a review on the content and the tags which I added for preemption, please!
Thank you.

@neolit123 I addressed the changes and squashed the commits.

@Rajakavitha1 Thank you for the review :) I updated the doc as pointed. Please let me know if I need to add any more in the preemption docs.

Thanks for all of your contributions, @daminisatya!
Preemption Preview: https://deploy-preview-12460--kubernetes-io-master-staging.netlify.com/docs/concepts/configuration/pod-priority-preemption/#preemption
Glossary Preview: https://deploy-preview-12460--kubernetes-io-master-staging.netlify.com/docs/reference/glossary/?all=true#term-Preemption
/approve