Visa CVN22 support

Codecov Report

Merging #10 (b25461e) into master (f7e6ab9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          508       533   +25
  Branches        80        81    +1
=========================================
+ Hits           508       533   +25

Flag
Coverage Δ

3.9
100.00% <100.00%> (ø)

ubuntu-latest
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pyemv/cvn.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e6ab9...b25461e. Read the comment docs.


Introduce JSX mode for CodeMirror

This PR introduces a JSX mode for CodeMirror and hopefully closes #3122.
Because of JSX' idiomatic syntax, I preferred implementing this as a completely different mode, than interfering with any of the existing JavaScript or XML modes, despite this was one of @marijnh's proposals at #3122 (https://github.com/codemirror/CodeMirror/issues/3122#issuecomment-77818075).
Most of the language features should be supported without any issues.
More info on JSX at:

https://facebook.github.io/jsx/
http://facebook.github.io/react/docs/jsx-in-depth.html

Hi guys. I had an unfortunate mid-air collision with this PR... but I'm putting my PR up as well. It's not 100% finished, but in terms of correctness I think it's very accurate. I originally attempted something like this approach, but found it drastically simpler and less error-prone to add a jsx flag to javascript mode and extend javascript mode directly. I think the closely-coupled-with-js approach will be easier to maintain... but would also understand if you guys don't want to go that route, since it's code that most JS users won't need.
I put more notes in the PR.
Have a look here: https://github.com/codemirror/CodeMirror/pull/3744

@dabbott great job seems to have been done on your PR! I see that it doesn't apply XML highlighting though on the XML expressions. Do you think that this is something that we could work out? I could try out contributing that on your PR.

@parisk For sure! Actually, I haven't looked into how to do that stuff at all yet, so that would be great.
Also, bracket matching. And possibly tagname matching. I'm probably styling some stuff with the wrong styles too.

Can you clarify what you mean by XML highlighting?

Hi @dabbott I took a look at your first screenshot that does not highlight the tag names, but then found out that you are highlighting them as JavaScript entities after taking a better look at your second one.
After I finish some final touches here, I could try giving some help with what's left.

Hmmm, yeah, I see what you mean. Logically I think they should be highlighted as JS variables/properties... but at the same time, they give the impression of not being highlighted, since it's relatively uncommon to have locally defined JSX elements or property access in element names.

In my opinion @parisk is correct: An JSX mode should

Highlight all the known HTML elements
Highlight all the custom HTML elements
Highlight all declared JSX-elements

Consider something along these lines:
import FooComponent from "./foo";

const BarComponent => (props) => {
  return
Bar {props.bar}
;
}

class Biz extends React.Component {
  render() {
  return (

This is a foo component

      <x-my-component custom-attribute="foo" />
      <FooComponent>
        <BarComponent bar="is Bar" />
        <BazComponent />
      </FooComponent>

   )
  }
}

In that example:

h1 and div should be highlighted as XML-tags as they are known HTML elements
x-my-component should be highlighted as it's a custom element (see JSX gotchas @ facebook.github.io
FooComponent and BarComponent should be highlighted as XML-tags as they:

Are wrapped in a <
Are declared in the file (one as a stateless component, one as imported component)

BazComponent should not be highlighted as it's not declared anywhere

HTML allows any tag names, not just the ones in the standard. As such, I don't think highlighting tag names differently is a very accurate or productive approach.

@marijnh Actually you are correct, I remembered that React would throw went it didn't understand the element but this doesn't seem to be the case, at least anymore.

Well, I suppose if three people are working on one, the need for this mode is pressing. And it looks like it's going to be less work to write one myself rather than to keep hinting and reviewing and pushing people in the right direction. You can find my version in b3f9487046e37facd64196380ebdd8639ef. Please test it and submit failing test cases. If this helps you in a financial way, a donation to cover the morning spent on this is much appreciated.

:tada: really happy to see this implemented at all. I hope that our contributions helped you implement it faster and better.

Great! Glad to have this in. We sent you an email re: donation and buying a support plan.

http://codemirror.net/mode/jsx/index.html
some self closed tags /> show up red (errors?)


⚠ Bofrost.lu has degraded performance

In 68a4882, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1841 ms

Resolved: Bofrost.lu performance has improved in bd1f46b after 6 minutes.


ErrorLogHandler: use strict comparison

otherwise null and false get accepted as valid types:
$handler = new Handler\ErrorLogHandler(null, $level);

note: this is somewhat backward incompatible, as previously null and false and "" would be converted to 0, but now they are rejected.
also, maybe it would make sense to allow null to be "use default value self::OPERATING_SYSTEM"?

Seems fine to me as is, no reason to give anything else than a valid value I guess. Thanks


Simplify the test

The test currently runs bitters install, which outputs Bitters' Sass files to
compile against, but it's doing so by using whatever local version of Bitters
you have installed, not what is represented in the current state of the repo. So
if you make a breaking change to the Sass, this test will not capture that.
This commit removes the bitters install command and instead points directly to
the Sass partials locally within the repo. The test will then try to compile
Bitters' Sass and if it doesn't compile, the test fails.
In the future, we should add more robust tests to specifically test the Bitters
CLI.

Good catch on the differing Bitters versions. Test looks good :+1:

but it's doing so by using whatever local version of Bitters you have installed,

This isn't actually true. It would be using bitters which is provided by the gem. For example. if you don't even have the bitters gem installed, it's still using the correct executable.
I agree that the test suite should be improved. However, I think until a larger set of changes to the test suite exists this test provides a lot of value. For example, it found that the executable for bitters was not working since the last version.

@dgalarza Great point. Let’s wait on this until we have the proper tests for the CLI.

I’m closing this until we have a chance to further improve the test suite.


TIMESTAMP Watermark type with milliseconds

The TIMESTAMP watermark type works fine when JDBC column type is defined with format yyyy-MM-dd HH:mm:ss. However, when working with a column with timestamp with fraction of seconds, yyyy-MM-dd HH:mm:ss.ffffff for instance, some data between previous high watermark and current low watermark.
Is there any suggestion to workaround this?
If this type of source cannot be processed yet, we suggest a new type of watermark that accepts a timestamp format yyyy-MM-dd HH:mm:ss.ffffff.
I already implemented this and tested with mysql source.
If no one else is working on this, can I make a review request?

Shouldn't the TIMESTAMP type support milliseconds? I don't think that introducing another type is necessary.

TIMESTAMP type supports only upto seconds, as I mentioned above.
I think it is necessary to create another type to support upto milliseconds(6) just like DATE or HOUR watermark type.
The only issue is size of the watermark value. The watermark should be compatible with Long type, but yyyyMMddHHmmssffffff format is too long for Long type. In order to fit in to Long type, we need to merge two fields. For example, we can merge the year and the month fields by making it number of months from 1970/01. That format should be fit into Long type.
The final format would be [#month from 1970/01]ddHHmmssffffff

We had added a new watermark type with name TIMESTAMP_MS few months ago and we are using it until now.
To explain what we've done, to be clear,
As I mentioned in the earlier comment, TIMESTAMP watermark can only take care of a watermark column with value up to second. Timestamp value with fractions of second is too large to store in 'long' type. So, we added a new watermark type that translates timestamp value with fractions of second to some long value, and vise versa.
We had to modify Partitioner, QueryBasedExtractor, JdbcExtractor, and some more classes as well.
Now we are happy to apply this feature to the develop/master branch.
Can someone verify that this work is nesseccery?
If this modification is acceptable, please assign this job to me. Otherwise, please guide me to a correct way.
Thank you.

Related PR was merged


Error when running multiagent_highway.py

When running the new version of flow(0.5.0.dev), there is an error:
Traceback (most recent call last):
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/tune/trial_runner.py", line 498, in _process_trial
result = self.trial_executor.fetch_result(trial)
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/tune/ray_trial_executor.py", line 342, in fetch_result
result = ray.get(trial_future[0])
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/worker.py", line 2247, in get
raise value
ray.exceptions.RayTaskError: ray_PPO:train() (pid=6330, host=sk)
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/agents/trainer.py", line 369, in train
raise e
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/agents/trainer.py", line 358, in train
result = Trainable.train(self)
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/tune/trainable.py", line 171, in train
result = self._train()
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/agents/trainer_template.py", line 126, in _train
fetches = self.optimizer.step()
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/optimizers/sync_samples_optimizer.py", line 52, in step
for e in self.workers.remote_workers()
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/utils/memory.py", line 33, in ray_get_and_free
result = ray.get(object_ids)
ray.exceptions.RayTaskError: ray_RolloutWorker:sample() (pid=6329, host=sk)
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/evaluation/rollout_worker.py", line 453, in sample
batches = [self.input_reader.next()]
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/evaluation/sampler.py", line 56, in next
batches = [self.get_data()]
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/evaluation/sampler.py", line 97, in get_data
item = next(self.rollout_provider)
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/evaluation/sampler.py", line 313, in _env_runner
soft_horizon)
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/evaluation/sampler.py", line 451, in _process_observations
episode.batch_builder.check_missing_dones()
File "/home/shaokun/projects/py3.5-ray0.7.3/lib/python3.5/site-packages/ray/rllib/evaluation/sample_batch_builder.py", line 187, in check_missing_dones
"Please ensure that you include the last observations "
ValueError: The environment terminated for all agents, but we still don't have a last observation for agent rl_highway_inflow_1.1 (policy av). Please ensure that you include the last observations of all live agents when setting 'all' done to True.

Ooh, good catch. This is going to be a bug with the most recent rllib version. We will try to fix this quickly. This occurs when there are crashes, you can temporarily fix this by removing the check that sets done = True if there is a crash.

Hi @nanxintin we currently have a developer working to fix this now. Sorry for the delay.

@eugenevinitsky  Thanks for your work.

Hi @eugenevinitsky , I have another question about the multiagent_highway example. At present, we use one PPO policy shared among all the agents to control the acceleration of each vehicle. Can we use two or more different policies during training ? In other words, can we apply different policies for each vehicle or part vehicles ? If so, could you give me some suggestions to achieve that ? Thanks.

Oh man, I'm sorry I missed this. This bug is resolved in #767. As for your other question, you can have as many policies as you want! You just need to instantiate an additional policy and add it to the policy graphs.


Add project level dictionary for suppress typo

Issue

close #242

Overview (Required)

Android Studio detects many typo in Dep.kt.
But I think, almost words are correct.
I added project level dictionary for suppress typo.

Screenshot
Run inspection by Name -> Typo -> Dep.kt
(Android Studio needs restart for apply dictionary)

Before
After

LGTM 🔡  Thanks!


Correctly parsing passwords containing @ and ?

We're using testinfra to verify that automated software installs occur as planned. It's great so far, thank you!
However, AWS will often generate windows passwords that contain @ and ?, which confuses testinfra's argument parsing.
For reference, our current host string looks like this:
winrm://username:password@ip_address:port?no_verify_ssl=true

We'd like to help -- is there a suggested way to approach this?
The parsing algorithm we had in mind would be: .split("?") on the last occurrence of a ? in the string in order to identify arguments like no_verify_ssl.
We'd use the same approach for @ -- splitting the string only on the last occurrence of that character to correctly identify passwords vs ip_address.

I think the right way to handle this is to urlencode your password. p@assword? -> p%40ssword%3F.
But I'm pretty sure testinfra will not decode it back, this is a bug, thanks for reporting it!


Cross-linking to additional guidance

Folks, if I might ask a slightly more philosophical question, does the SDK team believe it would be valuable to cross-link between SDK Docs and the other learn.microsoft.com content?

Folks, if I might ask a slightly more philosophical question, does the SDK team believe it would be valuable to cross-link between SDK Docs and the other learn.microsoft.com content?

Hi Udi.   Apologies for the delay; generally speaking, it's situational and depends on the doc.  Conceptual docs with general information about an Azure service are something we try to cross-link, as they fill in valuable context at a higher level than SDK documentation.
Where docs with code samples and quick-starts are concerned, we're usually more cautious, as those have the potential to not be updated regularly and use stale versions, not follow recommended patterns, and not be at the same level of code quality that we'd like.  We do our best to work with the content authors that own them to address issues as we see them, but the cross-team ownership can add some time to the process and makes awareness of issues more difficult to keep on top of.

Hi @udidahan.  Thanks for your patience as we talked this over and coordinated with the folks over at MS Docs.   Given that the linked document is full "getting started" sample which overlaps with the local content, we'd prefer not to link this from the README.  While the additional examples for manually creating resources would complement our ARM deployment, the additional code snippets from the article introduce a potential drift with the content and samples in the repository and which we cannot directly control the evolution of.   Further rationale can be found in my earlier response.
I'm going to close this out but am happy to continue the discussion.  Thank you, again, for your contribution and your efforts to improve the Azure SDK developer experience.

OK, thanks. I'll try to keep all that in mind when I'm considering other improvements I can make.


Mixlib::ShellOut::ShellCommandFailed: execute[request git key]

Hi guys,  hope someone can help me. I recently purchased Rapid Application Development
with CakePHP 2.0 by Jose Diaz-Gonzalez and I have been struggling to set up vagrant.
I am using the latest version of virtual-box, vagrant and chef and I am following the instructions to the letter, hower I am receiving the following error:
==> default: [2015-03-12T07:46:39+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
==> default: [2015-03-12T07:46:39+00:00] ERROR: execute[request git key] (/tmp/vagrant-chef/bd885c961fe7ceaf386b7954711e7941/cookbooks/apt/providers/repository.rb line 2) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '2'
==> default: ---- Begin output of gpg --keyserver keyserver.ubuntu.com --recv-keys E1DF1F24 ----
==> default: STDOUT:
==> default: STDERR: gpg: keyring `/root/.gnupg/secring.gpg' created
==> default: gpg: requesting key E1DF1F24 from hkp server keyserver.ubuntu.com
==> default: gpg: keyserver timed out
==> default: gpg: keyserver receive failed: keyserver error
==> default: ---- End output of gpg --keyserver keyserver.ubuntu.com --recv-keys E1DF1F24 ----
==> default: Ran gpg --keyserver keyserver.ubuntu.com --recv-keys E1DF1F24 returned 2
==> default: [2015-03-12T07:46:39+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
Chef never successfully completed! Any errors should be visible in the
output above. Please fix your recipes so that they properly complete.
My Stack trace shows the following:
Generated at 2015-03-12 08:06:25 +0000
Mixlib::ShellOut::ShellCommandFailed: execute[request git key] (/tmp/vagrant-chef/bd885c961fe7ceaf386b7954711e7941/cookbooks/apt/providers/repository.rb line 2) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '2'
---- Begin output of gpg --keyserver keyserver.ubuntu.com --recv-keys E1DF1F24 ----
STDOUT:
STDERR: gpg: keyring `/root/.gnupg/secring.gpg' created
gpg: requesting key E1DF1F24 from hkp server keyserver.ubuntu.com
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
---- End output of gpg --keyserver keyserver.ubuntu.com --recv-keys E1DF1F24 ----
Ran gpg --keyserver keyserver.ubuntu.com --recv-keys E1DF1F24 returned 2
I have googled the error but I am brand new to vagrant and chef and just trying to gain proficiency in cakephp, can anyone help?
[EDIT] Just noticed I posted under phlipper's issue, apologies for that. New to github

Found out the port was blocked after telnetting into the sever "keyserver.ubuntu.com" using the pgp port 11371 and 80 respectively.


Opentelemetry initializer

I thought of adding an opentelemetry initializer in the locos extras. Where should i add documentation for this initializer? Because in order for this one to work we need to have to turn off the init_logger

@dinosath thanks for this! looks really great!
For now, you can include a README.md right next to your initializer folder. We'll include links to all of the README.md's in the docs eventually.

Done

Looks good -- can you run fmt on the code?


[BUG] Value after * must be an iterable, not NoneType

2023-01-05T15:10:30.503250+00:00 app[worker.1]: 2023-01-05 15:10:30,502 - ERROR - pyrogram.client - MainThread - Value after * must be an iterable, not NoneType
2023-01-05T15:10:30.503262+00:00 app[worker.1]: Traceback (most recent call last):
2023-01-05T15:10:30.503263+00:00 app[worker.1]:   File "/usr/lib/python3.10/site-packages/pyrogram/client.py", line 922, in get_file
2023-01-05T15:10:30.503264+00:00 app[worker.1]:     r = await session.invoke(
2023-01-05T15:10:30.503264+00:00 app[worker.1]:   File "/usr/lib/python3.10/site-packages/pyrogram/session/session.py", line 389, in invoke
2023-01-05T15:10:30.503265+00:00 app[worker.1]:     return await self.send(query, timeout=timeout)
2023-01-05T15:10:30.503266+00:00 app[worker.1]:   File "/usr/lib/python3.10/site-packages/pyrogram/session/session.py", line 337, in send
2023-01-05T15:10:30.503266+00:00 app[worker.1]:     await self.connection.send(payload)
2023-01-05T15:10:30.503266+00:00 app[worker.1]:   File "/usr/lib/python3.10/site-packages/pyrogram/connection/connection.py", line 69, in send
2023-01-05T15:10:30.503266+00:00 app[worker.1]:     await self.protocol.send(data)
2023-01-05T15:10:30.503267+00:00 app[worker.1]:   File "/usr/lib/python3.10/site-packages/pyrogram/connection/transport/tcp/tcp_abridged_o.py", line 61, in send
2023-01-05T15:10:30.503267+00:00 app[worker.1]:     payload = await self.loop.run_in_executor(pyrogram.crypto_executor, aes.ctr256_encrypt, data, *self.encrypt)
2023-01-05T15:10:30.503267+00:00 app[worker.1]: TypeError: Value after * must be an iterable, not NoneType

Probably an internal issue from Pyrogram
not impacting anything


⚠ Bofrost.be has degraded performance

In 6846962, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1500 ms

Resolved: Bofrost.be performance has improved in 9c8cb62 after 57 minutes.


update config doc for neovim

Looks good. I just read a bit about the change to mason, and I see that the nvim-lsp-installer repo has been archived. This change makes sense to me. Thanks for keeping this up to date!


Just requesting the artifacts from the most recent 3.0.0 test build.

Using macOS to try to run 2.0.1, no matter what I try I get java errors. When I get past the javafx issue by using a version of java that has fx bundled, I still get the error: "Error: Could not find or load main class io.github.dylmeadows.eontimer.AppLauncher". I saw in other closed issues a link to a test build of 3.0.0, but it looks like all the artifacts have been deleted since the test build was run over 6 months ago.
Thanks for your time and your help!

I'll run another build so the artifacts repopulate. I'll message you when it's ready

The macOS portion of the build is failing, so I'm going to need to look at the CI/CD pipeline this weekend to figure that out. I'll keep you updated in this thread.

Sounds good. Thanks for looking into it, I really do appreciate it!

@ShilohBeeler I'm going to close this since it's no longer relevant. I recently rewrote the application in python with PySide6. You can find the alpha release artifacts here


Feature Request: Separate special HUD for Twitch chat

I play in multiplayer and I would like the chat of our SMP players not to merge with the chat of my stream. It would be very convenient if, instead of searching through the chaos for messages from players or stream chat participants, you could simply look at a special HUD element.

I'll be looking into this on next weekend along with other feature requests, this sounds like a good idea for sure! I honestly didn't even consider this, since I usually play singleplayer :D

Thanks a lot! I didn't expect such a quick response!

How is the work going?

I've spent my last weekend figuring out custom colors, so probably this week or next one, depends on my free time


Add repeating testing utility

This PR adds a testing utility for repeating an action a number of times.
It is test-only utility to avoid such constructs in a production code because cycles should have domain-specific semantics.

@dmdashenkov, PTAL.


proposal: recipe based reportcard custom controller

ProblemStatement: A report card that provides various results w.r.t Recipe custom resources will be helpful. This report card can have passed, failed count. It can optionally have the detailed fail messages. This report card should be able to opt in or out Recipes based on label / annotation / name selectors.

kind: RecipeReportCard
metadata:
  name:
  namespace:
spec:
  selector:
    matchLabels:
    matchLabelExpressions:
  reportDetailsOn:
  - path: status.phase
  - path: status.taskResults.[*].warning
  - path: status.taskResults.[*].error


Move to built-in dependabot

PTAL @kr-project/model-and-backend-epic-area

Good call - mind sending a PR to clean that up?
On Tue, Aug 25, 2020 at 2:03 PM Adam Ginzberg<EMAIL_ADDRESS>wrote:

@aginzberg commented on this pull request.
In .github/dependabot.yml
https://github.com/kr-project/helper-date/pull/1#discussion_r476735541:

@@ -0,0 +1,11 @@
+# https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates

+version: 2
+updates:

package-ecosystem: "npm"

directory: "/"
schedule:

 interval: "daily"

open-pull-requests-limit: 50
reviewers:

 - "kr-project/model-and-backend-epic-area"

Actually @chrisleck https://github.com/chrisleck should we move this to
@kr-project/ecosystem https://github.com/orgs/kr-project/teams/ecosystem?
This fork is some utility only used by the API
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kr-project/helper-date/pull/1#pullrequestreview-474892449,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKW5K2OWA4D5Z2BLERB3KLSCQRJXANCNFSM4QK65UPQ
.

--
Christopher Eck
Head of InfoSec & Infrastructure | Coda
<EMAIL_ADDRESS>https://coda.io
...

https://github.com/kr-project/helper-date/pull/4


configurable line colour and opacity for groupings

When groupings overlap with other elements it is sometimes not easy to pick up readable opacity levels. Please provide a way to control line colour and control line opacity independently of fill opacity for groupings. A grouping with no fill - just a frame, will work too.

Initially I assumed this issue to be a feature request, but actually Archimate specifications explicitly state that groupings may overlap ( http://pubs.opengroup.org/architecture/archimate3-doc/chap04.html#_Toc489945986 ) which with grouping line transparency being linked to fill transparency is not easy at all, so this issue should probably be treated as a bug.

The ArchiMate specification doesn't really stipulate presentation of figures in terms of things like opacity. In fact it may be the case that a tool might not support opacity, so I regard this as a feature request.
As with all feature requests with open source software it may get implemented depending on time and resources. Contributions are welcome.

Hi,

so this issue should probably be treated as a bug.

No. What ArchiMate means by "overlap" is simply that an element can be part of several Grouping.
So comming back to you original comment, I agree that it would be good to separate border color and fill color so that a user could decide to have a transparent element while still keeping a border.
I wonder what would be the best way to manage border:

Add border opacity,
or, add a "border visible" flag ?

As border is a bit more than border (it also includes some internal drawing for some figures like business object), I would assume "border opacity" is the best option.

Clearly such a feature should, if implemented, apply not only to the Grouping figure but to all figures. As some figures have lines inside the figure the change would require to draw those lines separately using the current opacity setting. So, this would mean re-doing the current drawing routines to separate out the lines that form the outline and those inside the figure. A few days work probably. Perhaps someone will contribute the initial work...

Something like this perhaps:

So are agreed that it is all lines in the figure that should have separate opacity?

So are we agreed that it is all lines in the figure that should have separate opacity?

Yes, let's keep it simple: border opacity should be for border but also all lines inside a figure.
On question though: how to manage existing models ? Maybe something like: if border opacity is not set and fill opacity is, use the same value ?

On question though: how to manage existing models ? Maybe something like: if border opacity is not set and fill opacity is, use the same value ?

Good question.
There has to be a default value for border opacity in the Ecore model, as there is for fill opacity, and this should be 255. However, there is no way to know if border opacity is not set because EMF returns the default value if it doesn't exist in the model.
Therefore users will get a surprise if this is implemented.

Can this be implemented before loading the model in EMF. I think you have similar things happening for conversions from previous model version.
Maybe we don't even need this pre-EMF thing: we "simply" have to run a code once when an old model is opened: set borderOpacity = fillOpacity

Maybe we don't even need this pre-EMF thing: we "simply" have to run a code once when an old model is opened: set borderOpacity = fillOpacity

Could be one of those Compatibility Handlers. I'll investigate.

The current opacity Ecore attribute is "alpha" so we have getAlpha() and setAlpha(int). We need another one. Suggestions for Ecore attribute name?

Beta ;-)

Beta ;-)

(headbang emoji)

Joking. In fact "alpha" should be used for transparency, not opacity. So I suggest "borderOpacity" (and someday rename "alpha" to "fillOpacity"

Internally it actually is alpha. This is what is set in Draw2D and also what we set in the exchange format. I chose "opacity" in the UI because it was better than "alpha".
I would like to keep the naming consistent.

"borderAlpha" ?

I'm going with "lineAlpha".

Maybe we don't even need this pre-EMF thing: we "simply" have to run a code once when an old model is opened: set borderOpacity = fillOpacity

Could be one of those Compatibility Handlers. I'll investigate.

Before I investigate this let's examine the case where we don't convert line opacity to fill opacity. Do we think that not converting is unacceptable?

Do we think that not converting is unacceptable?

Well, it is, but maybe providing a jArchi script for this is enough...

Actually, the Compatibility Handler for this is trivial. I'm just making sure that we agree that a conversion must take place. And I'm trying to keep these handlers to a minimum to avoid slow load times.
(A Compatibility Handler to do this adds about 100ms to load time on a model with 400 views on my machine)

So, IMHO, this is needed.

Fine.

With figures that display the icon, should the icon also be drawn with an alpha value? If so, which one? Line or Filll alpha? I suggest Fill alpha as it's part of the fill. This will affect figures in older models where the existing alpha has been set.

The text in the figure can also have its alpha set.

I'm going with "lineAlpha".

After some experiments in the UI menus and property sections, I feel that "Fill Opacity" is unambiguous but "Line Opacity" is not as one might think of connection lines. "Border Opacity" is not accurate either because this setting affects also the internal lines of the figure.
I think "Outline Opacity" in the UI and "outlineAlpha" for the Ecore attribute might be better.

Issues outstanding:

Do we agree that line/outline opacity affects not only the outer edge border but internal outlines (as seen for example in Application Component, Node, Device, Contract, etc?
Should text in figures inherit the fill opacity?
Should the icon in figures inherit the fill opacity?

Examples of figure with fill opacity of 75:
Text and Icon has fill opacity:

Icon has fill opacity:

Text and Icon no opacity:

Should text in figures inherit the fill opacity?

IMHO, no. This is not related to fillColor but textColor, so if we want to implement such feature; it would be best to have a different attribute.

Should the icon in figures inherit the fill opacity?

Maybe. But in the future I would suggest a boolean attribute to show/hide icon, so this might conflict a bit.

After some experiments in the UI menus and property sections, I feel that "Fill Opacity" is unambiguous but "Line Opacity" is not because one might think it is for connection lines. "Border Opacity" is not accurate either because this setting affects also the internal lines of the figure.
I think "Outline Opacity" in the UI and "outlineAlpha" for the Ecore attribute might be better.

The term used in drawing apps for lines is "Stroke". Would "Stroke Opacity" work, or is that too weird?
https://stackoverflow.com/questions/4125152/difference-between-stroke-and-fill

For sure "stroke" would be too weird. Outline is best IMHO


QAT interface update

This PR increases the customisability of QAT allowing users to deactivate various instances of the standard LLVM pipelines.
Dependencies
This PR depends on #1175 .
Changelog

Refactor of how LLVM passes are loaded.
Added interface support for --disable-default-pipeline
Added interface support for --no-simplify-prior-transform

In the ConstArray example it seems a few empty .ll files may have been included in the commit by mistake, but perhaps they are placeholders. I have one other question below about the repeated pattern of setting up the default passes, but otherwise this seems ready to merge to the feature branch. Disabling the auto-merge just to make sure you have the chance to see and respond, but feel free to merge if you'd rather address this in the next PR.

Thanks - I've deleted ll files.


Apply flake8 linting & Black formatting.

Will also add .gitignore and .vscode/settings.json.

Also, one more change.  Sorry, is it okay to sneak this one in also?  (Refactors from generate.py):
Add:
    def getStatsData(self) -> str:
        return (
            f"{self.score}, {self.lines}, {self.level}, {self.pace_score}, "
            + f"{self.tetris_line_count}"
        )

to player.py.

This is done 🎉


Compositing a webview with an opengl context

I am have a webview in one window and a 3d opengl view in another window.
But I would like to composite them into the same window OR dock one window to the other.
Wondering if SDL can help or if I should keep trying with glfw.
I have not used SDL

Hi @gedw99, I believe it isn't possible to do that if you're not using SDL for creating the windows. If you created the windows using SDL, you could use window.GetSurface() to get the pixels of the windows and blit one of the surfaces to another.

Thank you the the thorough answer.
Any examples of this that you know of. Its a bit specialised.
Boy i wish i used SDL :)

i see now that what i need to do is edit each of the programs i want to composite into SDL and give them a SDL "Veneer" on top so that the Main SDL windows can plug into them.
Correct ?
Here are the two systems i want to combine

https://github.com/zserge/webview
https://github.com/g3n/engine

what about this ?
http://lazyfoo.net/tutorials/SDL/09_the_viewport/index.php
Its using SDL_RenderSetViewport.

this looks like the way to get it working !!!
https://github.com/golang-ui/nuklear/blob/master/cmd/nk-example-sdl2/main.go
that gets me a opengl context with a SDL window managing it.

I'm not familiar with how webview works.
But you can either create separate windows in SDL, or do rendering inside one window.
I couldn't get separate windows to follow each other as you drag them around since window movement event occurs only after the window was moved. If that's ok you can just use event to move the other window to the side of new windows position.
Pressing 1 or 2 selects Renderer or OpenGL.
Pressing R, G, B changes it's background color.
Q exits.
package main

import (
	"log"
	"runtime"

	"github.com/go-gl/gl/v2.1/gl"
	"github.com/veandco/go-sdl2/sdl"
)

var winWidth int32 = 320
var winHeight int32 = 480

func main() {
	runtime.LockOSThread()

	err := sdl.Init(sdl.INIT_EVERYTHING)
	if err != nil {
		panic(err)
	}
	defer sdl.Quit()

	window1, err := sdl.CreateWindow("Renderer Window", sdl.WINDOWPOS_CENTERED, sdl.WINDOWPOS_CENTERED, winWidth, winHeight, 0)
	if err != nil {
		panic(err)
	}
	defer window1.Destroy()

	renderer, err := sdl.CreateRenderer(window1, -1, 0)
	if err != nil {
		panic(err)
	}
	defer renderer.Destroy()

	window2, err := sdl.CreateWindow("GL Window", sdl.WINDOWPOS_CENTERED, sdl.WINDOWPOS_CENTERED, winWidth, winHeight, sdl.WINDOW_OPENGL)
	if err != nil {
		panic(err)
	}
	defer window2.Destroy()

	x, y := window1.GetPosition()
	w, _ := window1.GetSize()
	window2.SetPosition(x+w, y)

	context, err := window2.GLCreateContext()
	if err != nil {
		panic(err)
	}
	defer sdl.GLDeleteContext(context)

	err = gl.Init()
	if err != nil {
		log.Fatalln(err)
	}

	w1ID, err := window1.GetID()
	if err != nil {
		panic(err)
	}
	w2ID, err := window2.GetID()
	if err != nil {
		panic(err)
	}

	isGL := false
	running := true
	for running {
		draw := false
		for event := sdl.PollEvent(); event != nil; event = sdl.PollEvent() {
			switch t := event.(type) {
			case *sdl.WindowEvent:
				if t.Event == sdl.WINDOWEVENT_MOVED {
					switch t.WindowID {
					case w1ID:
						window2.SetPosition(t.Data1+w, t.Data2)
					case w2ID:
						window1.SetPosition(t.Data1-w, t.Data2)
					}
				}
			case *sdl.KeyboardEvent:
				if t.Type == sdl.KEYDOWN {
					switch t.Keysym.Sym {
					case sdl.K_q:
						running = false
						break
					case sdl.K_1:
						isGL = false
					case sdl.K_2:
						isGL = true
					}
					if isGL {
						switch t.Keysym.Sym {
						case sdl.K_r:
							gl.ClearColor(1, 0, 0, 1)
							draw = true
						case sdl.K_g:
							gl.ClearColor(0, 1, 0, 1)
							draw = true
						case sdl.K_b:
							gl.ClearColor(0, 0, 1, 1)
							draw = true
						}
						if draw {
							gl.Clear(gl.COLOR_BUFFER_BIT)
							window2.GLSwap()
						}
					}
					if !isGL {
						switch t.Keysym.Sym {
						case sdl.K_r:
							renderer.SetDrawColor(255, 0, 0, 255)
							draw = true
						case sdl.K_g:
							renderer.SetDrawColor(0, 255, 0, 255)
							draw = true
						case sdl.K_b:
							renderer.SetDrawColor(0, 0, 255, 255)
							draw = true
						}
						if draw {
							renderer.Clear()
							renderer.Present()
						}
					}
				}
			case *sdl.QuitEvent:
				running = false
			}
		}
	}
}

The other option is to render into one window and manage where each item is rendered by yourself.
This example will create SDL window with OpenGL rendering context that you can use with OpenGL and sdl.Renderer at the same time.
Pressing R, G, B changes background color, Q exits.
package main

import (
	"log"

	"github.com/go-gl/gl/v2.1/gl"
	"github.com/veandco/go-sdl2/sdl"
)

var winWidth int32 = 320
var winHeight int32 = 240
var angle float32
var x float32 = 50.0
var y float32 = 50.0

func main() {
	runtime.LockOSThread()

	err := sdl.Init(sdl.INIT_EVERYTHING)
	if err != nil {
		panic(err)
	}
	defer sdl.Quit()

	window, err := sdl.CreateWindow("Renderer/GL Window", sdl.WINDOWPOS_CENTERED, sdl.WINDOWPOS_CENTERED, winWidth, winHeight, sdl.WINDOW_OPENGL)
	if err != nil {
		panic(err)
	}
	defer window.Destroy()

	context, err := window.GLCreateContext()
	if err != nil {
		panic(err)
	}
	defer sdl.GLDeleteContext(context)

	err = gl.Init()
	if err != nil {
		log.Fatalln(err)
	}

	glIdx := -1
	nrd, err := sdl.GetNumRenderDrivers()
	if err != nil {
		panic(err)
	}
	rndInfo := sdl.RendererInfo{}
	for i := 0; i < nrd; i++ {
		_, err := sdl.GetRenderDriverInfo(i, &rndInfo)
		if err != nil {
			panic(err)
		}
		if rndInfo.Name == "opengl" {
			glIdx = i
			break
		}
	}

	renderer, err := sdl.CreateRenderer(window, glIdx, 0)
	if err != nil {
		panic(err)
	}
	defer renderer.Destroy()

	sdl.GLSetAttribute(sdl.GL_DOUBLEBUFFER, 1)
	gl.MatrixMode(gl.MODELVIEW)
	gl.LoadIdentity()

	running := true
	for running {
		draw := false
		for event := sdl.PollEvent(); event != nil; event = sdl.PollEvent() {
			switch t := event.(type) {
			case *sdl.KeyboardEvent:
				if t.Type == sdl.KEYDOWN {
					switch t.Keysym.Sym {
					case sdl.K_q:
						running = false
						break
					case sdl.K_r:
						renderer.SetDrawColor(255, 0, 0, 255)
						draw = true
					case sdl.K_g:
						renderer.SetDrawColor(0, 255, 0, 255)
						draw = true
					case sdl.K_b:
						renderer.SetDrawColor(0, 0, 255, 255)
						draw = true
					}
					if draw {
						renderer.Clear()
						renderer.Present()
					}
				}
			case *sdl.QuitEvent:
				running = false
			}
		}
		gl.Clear(gl.COLOR_BUFFER_BIT)
		gl.PushMatrix()
		gl.Translatef(float32(winWidth)/2, float32(winHeight)/2, 0)
		gl.Rotatef(angle, 0.0, 0.0, 1.0)
		gl.Begin(gl.QUADS)
		gl.Color3f(1.0, 0.0, 0.0)
		gl.Vertex2f(x, y)
		gl.Color3f(0.0, 1.0, 0.0)
		gl.Vertex2f(-x, y)
		gl.Color3f(0.0, 0.0, 1.0)
		gl.Vertex2f(-x, -y)
		gl.Color3f(1.0, 1.0, 1.0)
		gl.Vertex2f(x, -y)
		gl.End()
		gl.PopMatrix()
		renderer.Present()
		sdl.Delay(16)
		angle++
	}
}

@malashin thank you soooo much for the sample of docking windows. that is as good as it gets.
will give this a whirl now and see how it goes !

any progress @gedw99???

Hey @malashin
your example with the docking windows is exactly what I was looking for thanks a lot.
In the first window I create a WebView using :
https://github.com/zserge/webview
This also works so far, except for a few slight delays when moving a window. The other window will follow after a short time.
I just wonder if it is possible to put these two into one main(parent) window?


Getting error when using JSONDictionary

Hello Team,
I am using Tailor for parsing the JSON.
I am getting very wiered error "Use of Undecleared type of 'JSONDictionary'  "

Hey @salimgcet, it seems like the README was a bit outdated. JSONDictionary was a type alias that came from Sugar (a previous dependency). Tailor no longer depends on Sugar so instead of using JSONDictionary, you can just use [String : Any].

I'm gonna go ahead and close this one but feel free to re-open it if this is still causing issues for you somehow.


Incorrect Redirection

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Description
When a user clicks on the Twitter icon in the footer (or wherever it's located), it leads to an incorrect landing page instead of the official Twitter profile page. The expected behavior is that clicking the Twitter icon should redirect users to the corresponding Twitter account of the website/company.
Steps to Reproduce
Open the website in your browser.
Navigate to the section where the Twitter icon is displayed (typically in the header or footer).
Click on the Twitter icon.
Observe the behavior:
The page redirects to an incorrect or unexpected landing page instead of the correct Twitter profile.
Screenshots
Screencast from 2024-10-10 01-56-14.webm
Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this

Open the source code of the project in your code editor (VSCode, Sublime, etc.).
Navigate to the file where the Twitter icon is implemented. This will typically be a footer component
Search for the section containing the Twitter icon. The icon is usually embedded inside an anchor () tag that controls the URL redirection.
Replace the incorrect URL with the correct Twitter profile URL in the href attribute.

did you fixed it

I would like to contribute to it, assign this task to me.

ok i am assign to you @w0wayush


Python3 Fix for dict ordering

You are definitely going to want to test this in python2!!
I will continue to test with python3, but it no longer errors and appears to return valid values.

Thanks brookesy2,  I didn't know about that change in dict sorting between python 2 and 3!  I've tested your fix and it seems to work with both versions, but your commit history looks a little bit garbled, would you mind pulling from my master, making your one line change in fuzzymatch.py, and resending the pull request?  I want to give you the credit in the history for the fix but the additional 4 commits shown above seem odd.

Sure, there was an issue merging the first time. Hence the odd commit history. I will kill this fork and remake it :)

Thanks :)


Example dataset usage in downstream machine learning modeling

Notebook example reproducing a yield regression model of the Perera dataset, pulling from ord-data.
PTAL and let me know if you have any suggestions!
(This will automatically become available on the binder repo, is that right?)

Looks like the notebook test is failing?


Prepare high-level executive summary PowerPoint

Not needed for this study

UX Weekly Meeting Notes: Tuesday, December 15, 2020
High-Level Executive Summary not requested/required for this study.
@areighar   @tlageman-epa


Contexts folder at feature level

Shouldn't we be "able" to have contexts for specific features?
Like:
src/features/awesome-feature
|
+-- api         # exported API request declarations and api hooks related to a specific feature
|
+-- assets      # assets folder can contain all the static files for a specific feature
|
+-- components   # components scoped to a specific feature
|
+-- hooks       # hooks scoped to a specific feature
|
+-- routes      # route components for a specific feature pages
|
+-- stores      # state stores for a specific feature
|
+-- types       # typescript types for TS specific feature domain
|
+-- contexts       # react context to this specific feature <-------------- THIS
|
+-- utils       # utility functions for a specific feature
|
+-- index.ts    # entry point for the feature, it should serve as the public API of the given feature and exports everything that should be used outside the feature

We could have a context folder at the root too.

No, if you decide on that path, it should probably be in the same file, unless your file grows huge, in that case you should split it.

Yes, that's what I was referring to

Oh cool, looks like I misread your message :)


How to select dates on gesture(drag)

Hi
I want to be  able to drag start date and end date. Is there any way to achieve this?
Thanks

I have been putting this off as I hoped I'll eventually get the chance to maybe add support for it. But unfortunately, this will not be supported in the near future. I'll close this for now and reopen if I happen to start working on it.

Hey guys. I know it's been long. But is there any plans to support this drag-to-select ? Or can you let me know where to start in compose ?
Or maybe do you know any other calendar libraries that support this ?


Character types

WHEN asked for character types to include in the password
THEN I confirm whether or not to include lowercase, uppercase, numeric, and/or special characters

there is a selection of character types


Clarify self-hosted docs

What content needs to be created or modified?
In the RC1 documents on self hosting, https://v1-rc1.docs.dapr.io/operations/hosting/self-hosted/self-hosted-with-docker/, you have omitted the not-slim self hosting option presented in V 0.11.0 which I am using and is very, very easy to install and use.  Please put this back.
Describe the solution you'd like
The self hosting option I am talking about is being able to run multiple services+1DaprSidecar each as stand alone processes using dapr run ..... dotnet run myService for each one, with them using the DaprPlacement Service, Redis, and Tracing containers which were automatically installed in Docker Desktop (for Windows in my case).  This requires that Docker Desktop be started before launching dapr run.
The RC1 documentation does not support this and seems to force me to put my services into containers, which is currently out of scope for my situation.  But, in my eyes, even more important from a useability perspective to get a newby (like me) up and coding using Dapr, the V 0.11 not-slim self-hosted developer experience is quick and easy to both install and use.  Please include this development experience in the install and in the documentation.
Summary -- To sell devs on Dapr you need a way they can quickly get going without climbing up the learning curves of containers and K8s, and yet being able to use most if not all the capabilities of Dapr programatically in their language of choice.  There will be many, many devs, sr devs, and architects doing exploratory coding and PoCs using the SDKs who haven't the time to climb the container or K8s learning  curves right now.  Save that learning curve climb for AFTER they have determined that Dapr is useful for them by doing PoCs with small self-hosted services using containers only for placement, Redis, and Tracing.  Those 3 containers are behind the scenes for the most part and require no config or setup other than what is provided by the install scripts.
Where should the new material be placed?
Within operations.  And also put this in some sort of quick start, referencing operations.
Additional context
Add any other context or screenshots about the feature request here.

Hmmm... The v 0.11 versions of the above mentioned documents have changed substantially since I printed copies and setup my system around 11/17/20.  Indeed, the .11 docs seem the be the same as RC1 docs.  Sorry I cannot furnish you with the previous content that I am referring to.

One more thing that you may not be aware of -- When installing Docker you should also install WSL2, which emulates Linux much better than WSL1 and allows one to do what I described above I believe.
I am trying to prove the concept that using dapr is worth the investment in time and money for a certain set of microservice usage scenarios. When doing a fast-lane PoC as I am doing (and have done many times before) I typically do not spend the time to fully understand the supporting infrastructure as long as it "just works", as is the case with Docker Desktop for Windows and WSL2.  I believe this is what allows the placement service, Redis, and tracing containers to run in Docker with the MyServices (each having a locally hosted side car, as they would in real life but within containers) running as individual processes  on my dev system as described above.  This is a VERY fast way of producing a quick PoC using the SDKs to make a simulation of a real life microservice architecture, since I can omit the steps of containerizing the PoC microservices and then writing compose scripts, etc.  In these PoCs people are generally better off with the minimal setup up that produces a mostly real-life interaction between microservices.  I hope you provide the many "lookie lous" with this fast was to get their PoC running, and therefore convert a high percentage of the from "looker" into customers!  Thanks.

Learn more about WSL2 and Docker here

See https://docs.dapr.io/operations/hosting/self-hosted/self-hosted-with-docker/ and https://docs.dapr.io/operations/hosting/self-hosted/self-hosted-no-docker/

The new and updated docs look quite good.  Thanks.
On Tue, Jul 6, 2021 at 6:04 PM Aaron Crawfis @.***>
wrote:

Closed #960 https://github.com/dapr/docs/issues/960.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dapr/docs/issues/960#event-4985715440, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRXHHPUMJMYK5HSCMFKDXDTWN4W5ANCNFSM4UHYXNRA
.


[🐞] Props spreading

Which component is affected?
Qwik Runtime
Describe the bug
When spreading props in a component, any prop that comes after the spreading does not override the prop values as expected, e.g. {...props} class={['button', props.class]} and button will be overridden by props.class.
Expected behavior
<button {...props} class={['button', props.class]}>...</button>
// Assume props.class contains `a b`
// The final value of class should be `button a b`

Actual behavior
<button {...props} class={['button', props.class]}>...</button>
// Assume props.class contains `a b`
// The final value of class will be `a b`

Reproduction
https://qwik.builder.io/playground/#v=1.2.13&f=7VdNT8JAEP0ra0woh7JWo4mWDxMSbxqN0RMhobRFiKRtAAOG9L%2F7Zmb7DcSriRwoOzudnZl9M%2FOogObOyeLhe9mj92G2U8M8hZwDQLMVYd8uTbnSbzPlToJRskYhD5ltIHeF9R6OIsfu3cLBrkoH7TZTkjzHjbk64fC1EBhWoQ%2FiR6vyMHBclHAUdo0cvQReVWUzlJuLljlHoW8yoR8vY%2BjVpMVQ6hxRMPYvk51Ci18E6txxnOpuZ%2BUFiy%2BA9jrZZTuJFwSAp6tuC5k5YRUGIknxPcEN44Fx%2Bx6ZgclzfYbeGG%2BJjBkp%2BADYCjrthshFCHLE%2BaG%2BYkoCGmj69OCDtJiVSzKXQURwbSutdYKb7Qs7JGegWAI7VoRUPiFbKrWn18hns2aL%2Ff3IEkXLJuPjXIHgazR7BDSBuZjO6KkI8hS8vD4PHx%2BeXJk1QYxoI7y4jVefZ41yzN3LfaNg6PjDzvG2Zjk7KR7W3Kv6RtVHzv2m65a4IiFYewa6BMbOGtPGVVeOYCGlcPW0rLANFx9zgPZGsCUavtFogtT%2F9iLRIwSR8pFWVZ8BmbxUtHmmPCRpNPOW4CmtlrKmWDIvooVvjcfp4A3szPyVIMLYuyjM1JvW%2F6T5k5PmBw
Steps to reproduce

Go to the reproduction URL.
You will see a rendered page with a button
Comment/ uncomment the code to see the result
Expected behavior is that .button should be applied but it is not due to missing button after props spreading.

System Info
System:
    OS: macOS 14.0
    CPU: (10) arm64 Apple M1 Max
    Memory: 7.84 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.8.0 - ~/Library/Caches/fnm_multishells/15262_1696916828039/bin/node
    npm: 10.1.0 - ~/Library/Caches/fnm_multishells/15262_1696916828039/bin/npm
    pnpm: 8.8.0 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 117.0.5938.149
    Safari: 17.0
    Safari Technology Preview: 17.4
  npmPackages:
    @builder.io/qwik: ^1.2.13 => 1.2.13
    @builder.io/qwik-city: ^1.2.13 => 1.2.13
    undici: 5.25.4 => 5.25.4
    vite: 4.4.11 => 4.4.11

Additional Information
No response

I will look at it

I think this is an optimizer bug. In the posted playground, go to the SSR Module tab, and you'll find the button code at the top.
Now move the {...props} to after the class and observe nothing changed in the _jsxS() call. (you need to switch tabs for it to update the code!).
So by splitting into mutable and immutable props, the optimizer can't handle ...props properly. I think it needs to mirror the class prop in the mutableprops at the correct location, and the renderNode function needs to be careful about mutable props overwriting immutable props.

The problem is in the Rust function internal_handle_jsx_props_obj which is indirectly called by
handle_jsx. It sees that there's a ...prop and sets dynamic_props and then when is_fn || dynamic_props it copies the correct structure into mutable_props, but then later it does some things only when is_fn.
This eventually results in the handle_jsx picking _jsxS instead of _jsxC, with the wrong mutable props structure.
Note: if you do the spread on a component$ it works correctly, you can inspect the SSR module to see the difference in code:
https://qwik.builder.io/playground/#v=1.2.13&f=7VddSwJREP0rtwI10FW3pFg%2FgoXeiiLqSQRXV3NJdhc1NGT%2Fe2dm7n76QUQ9BO2Dy52dnZ0798ycYxY0rYureD98LlvMPnA7DcxjyNkDtKoi7FczLHcUelIj2qDN2gKVSmN1EJjSuLHSdNoq6lUqLECSimYYdcjbNESo8EO6sE%2BMJAfEYqFV%2FUlb2zEzkE%2FeNkVbWRiNMzT0KjaOg3kAv4I1JZ%2FaAQcdvxluFEa556qzRqORf1pbOK73DnBehpv4Sei4LmBoqevUpr%2BwmLhiifA7xEniBlp98TUxMn9PMQODNYkubQXvQ5Vgoq5IREwggrg%2BND809OGB4U43%2FpAhYeV49DGQ4FtWlWEYIc60KyqQkoFjBtRYESL5C%2FFSqS29RjnrNUfsbvtlcSxXKfggcSCYas8OAUrgLKFjGSqGpASPTw%2F23e29JZziBtitjxfXweLtZKftkvTo8tzu6TQImqd6zbnS5iid%2FcnyY4PtnLRkXEg3nyt1HSUrNbXzSIcgI1gzpHVyumQ9DljvJaHOd5rG%2FFbX5Ati52th%2FkYt7GwZvkI6hcY2HN3R1KO1JcjWUmZDWiQiFBijrMN64r3O0MstaTnxGGuP3d4dfzi%2B%2BFFjkfOBSV2kwNiemWJJkRzUpz915pBppZIqj7BkWUiLcXkwiHrPEKf6nxTp5U49DbMnsvlDoc0iH%2FyT%2BJ8k8U8

As a workaround, you can do const Button = 'button'; <Button ..., which will trick the optimizer into doing the right thing


Remove Metadata from ActivationTx and Ballot

Motivation
Activation Transactions contain redundant data that doesn't need to be broadcasted but is required for signature creation & malfeasance proofs.
Changes

Remove ATXMetadata from ActvationTx

It is still used to create the msg that is signed for ATX signatures and is part of a Malfeasance proof

Renamed to ATXSigMsg with the fields ID and PublishEpoch

Test Plan

existing tests pass

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

The types.HareMetadata could theoretically also be removed from a hare.Message, since the MsgHash contained is also data that doesn't need to be broadcasted.
That seems to be a bigger change and I would like to tackle this in a separate PR.

bors merge

bors merge


bump raw_window_handle to 0.5.0

hi! i made some changes so that raw_window_handle can be updated to 0.5.0 (this because im using it in conjunction with softbuffer for a personal project).
i only made the changes necessary for this pull request to work on macos since i don't have any access to another machine/os at the moment, but i'll leave this pr here in case there's initiative to update raw_window_handle in the future.

This is a duplicate of #134 (which also covers Windows and Linux).

my bad, didn't saw that pr


make password work with other auth types

rebased version of PR-86

PTAL @losipiuk

Can you explain what you achieve with this change. Preferably in commit message.

When a Trino cluster is configured to work with multiple authentication types through server.config.authenticationType key (e.g PASSWORD,OAUTH2), the password-authenticator.properties key is not configured in coordinator configmap because its template expects that authenticationType must equals to "PASSWORD". This prevents password authentication type to work and cluster coordinator to start.

@losipiuk, rephrased commit message to make it more self explanatory

Thanks. There is a typo. Please make summary
Allow password authentication to be used with other authentication types

And put https://github.com/trinodb/charts/pull/124#issuecomment-1898841283 as commit message body.
LGTM otherwise

Amended


VSCode renderer crashes when running tests with xvfb-run

Does this issue occur when all extensions are disabled?: Yes
I have a Jenkins CI setup to run tests for my VS Code extension. I setup the container as is detailed in the Continuous Integration page in the VS Code documentation https://code.visualstudio.com/api/working-with-extensions/continuous-integration.
apt update
apt install -y libasound2 libgbm1 libgtk-3-0 libnss3 xvfb

I then run tests as follows
xvfb-run -a npm run test

This was working fine up until very recently when my tests starting taking a little longer than they did before. I now get the following error messages half way through my test run.
16:27:34 [main 2023-02-06T15:27:34.720Z] CodeWindow: renderer process gone (reason: crashed, code: 133)
16:27:34
16:27:34 [main 2023-02-06T15:27:34.723Z] [UtilityProcess id: 1, type: extensionHost, pid: 413]: waiting to exit...
16:27:34
16:27:34 [main 2023-02-06T15:27:34.736Z] [UtilityProcess id: 1, type: extensionHost, pid: 413]: received exit event with code 0
16:27:34 [main 2023-02-06T15:27:34.737Z] Extension host with pid 413 exited with code: 0, signal: unknown.
16:27:34
16:27:34 Error sending from webFrameMain:  Error: Render frame was disposed before WebFrameMain could be accessed
16:27:34     at s.send (node:electron/js2c/browser_init:173:631)
16:27:34     at g.send (node:electron/js2c/browser_init:169:2657)
16:27:34     at E.send (/tmp/code/.vscode-test/vscode-linux-x64-1.75.0/VSCode-linux-x64/resources/app/out/vs/code/electron-main/main.js:16:77328)
...

and the test run fails. This doesn't seem related to the tests as it can occur at slightly different times in the test run. It just seems like running VS Code tests will fail if they take too long.

		const launchArgs = [
			'--disable-extensions',
			'--disable-gpu',
			'--disable-workspace-trust',
			'--no-xshm',
			extensionDevelopmentPath
		];

My arg setup for bulletproofing the electron test runner.. I believe there was some kind of --no-sandbox argument as well but for some reason that I forget, it no longer became necessary. Just Electron-Unix GPU weirdness..

Some explanation - your CI environment is probably starved of resources in a specific way, most likely via missing GPU support. CPUs that are capable of some graphical grunt are now coming. However, it will take extensive time for those upgrades to percolate to your free CI instance. In the meantime, you can run VS Code with these args (definitely not meant for manual testing!) and fingers crossed it should work okayish in your CI.

VS Code team: this one's a duplicate of #101069, please close!

@deepak1556 this one's a duplicate of #101069, please close!

Your suggestions do not work, so I'm not sure this is the same issue. Interestingly it claims it doesn't recognise xshm as a valid option.

1035803 - Browser window does not render on remote X server - chromium
That's a middleman (maybe Electron) claiming it doesn't recognise xshm but it still passes it through to Chromium.
Dud you pass the args to runTests in @vscode-test/electron?

"running VS Code tests will fail if they take too long" definitely does sound like a rendering process crash. Especially if test closure speeds deterioriate before the final crash, as compared to a local run.
I suppose you would be sharing the logs of the Travis run here now.. not sure I can help further.

Ok the code running the test is here
https://github.com/swift-server/vscode-swift/blob/967dc49f1bcdcd4b6276fdd9e0776f692f4a904b/test/runTest.ts#L36
You can find a log of a failed run here https://ci.swiftserver.group/job/swift-vscode-swift56-prb/379/console

I think --disable-extensions and --install-extension might conflict so I'd remove --disable-extensions

Yeah I've tried removing --disable-extensions and it doesn't make any difference

Ok I noticed I wasn't passing the argument to the correct process. I added the arguments to the install vscode-lldb process. So I changed this to include the arguments in the runTests call instead and it still made no difference.

Can you provide the crash dumps following the steps at https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-a-crash-report

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


test a celebhq

Hi dear friend
I want to use your HINT project to test an image of celeba. I followed the github steps, but what folder should I put the test image in? And what should I do after that? I would be grateful if you could guide me.

Hi dear friend I want to use your HINT project to test an image of celeba. I followed the github steps, but what folder should I put the test image in? And what should I do after that? I would be grateful if you could guide me.

Hi there,
It does not matter where you put the test image, just use the generate the .flist file, basically it is a list for the paths of all testing images/masks. Please use the flist.py to generate the .flist file, and complete your config.yml by changing the path of 'TEST_INPAINT_IMAGE_FLIST' and 'TEST_MASK_FLIST'. That should be working.


disk.go: Return the correct data for action result

The code accidentally overwrote the contents of the outer data variable (containing a serialized ActionResult protobuf) with the bytes from the last Tree protobuf processed from the ActionResult's OutputDirectories.
The server then returned the Tree protobuf to Bazel via the return in the last line. However, Bazel was expecting the ActionResult protobuf of course. This caused the weirdest things to happen, most notably builds mysteriously failing due to output files not existing or Bazel complaining that some file names are not valid UTF-8.
This was an accidental regression introduced by https://github.com/buchgr/bazel-remote/commit/b2e2f705f43d20e12dd8139f1719e7bd9c40a9b2.

nice catch. thanks!

Sorry, there was a build error due to a missing var - I'll send a follow-up! (Shouldn't CI catch this? 🤔)

Shouldn't CI catch this?

Looks like it did, but the change was merged before the CI failed.


VirtualMachineInstanceMigrationState is not set until after a migration completes

What happened:
When trying to understand progress of a migration, I wanted to see some information from the VirtualMachineInstanceMigrationState. However during the migration this field was empty, so I could not get the information I wanted.
What you expected to happen:
During an active migration the VirtualMachineInstanceMigrationState is populated with information indicating the status of the migration.
How to reproduce it (as minimally and precisely as possible):
Attempt a storage live migration by enabling the following feature gates:
      - VolumesUpdateStrategy
      - VolumeMigration
      - VMLiveUpdateFeatures

and set the vmRolloutStrategy: LiveUpdate
Now modify a running VM with a new DataVolume disk, and appropriate volumeUpdateStrategy. This will cause a disk live migration. But the state is never updated in the migration resource.
Additional context:
Add any other context about the problem here.
Environment:

KubeVirt version (use virtctl version): main
Kubernetes version (use kubectl version): 1.29
VM or VMI specifications:

apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  labels:
    kubevirt.io/vm: vm-fedora-datavolume
  name: vm-example
spec:
  running: false
  template:
    metadata:
      creationTimestamp: null
      labels:
        kubevirt.io/vm: vm-fedora-datavolume
    spec:
      architecture: amd64
      domain:
        devices:
          disks:
          - disk:
              bus: virtio
            name: datavolumedisk1
          - disk:
              bus: virtio
            name: cloudinitdisk
          interfaces:
          - masquerade: {}
            name: default
        ioThreadsPolicy: auto
        machine:
          type: q35
        resources:
          requests:
            memory: 1Gi
      networks:
      - name: default
        pod: {}
      terminationGracePeriodSeconds: 0
      volumes:
      - dataVolume:
          name: fedora-dv2
        name: datavolumedisk1
      - cloudInitNoCloud:
          userData: |-
            #cloud-config
            password: fedora
            chpasswd: { expire: False }
        name: cloudinitdisk
---
apiVersion: cdi.kubevirt.io/v1beta1
kind: DataVolume
metadata:
  name: fedora-dv2
spec:
  source:
    registry:
      url: docker://quay.io/containerdisks/centos-stream:9
  storage:
    resources:
      requests:
        storage: 30Gi

Cloud provider or hardware configuration: N/A
OS (e.g. from /etc/os-release): N/A
Kernel (e.g. uname -a): N/A
Install tools: N/A
Others: N/A

@alicefr Not sure if this is purely a storage live migration issue or if any live migration has this issue.

/assign

@awels do you mean the status of the vmim right not the migrationState in the VMI object? Was the migration running?

ok what I got while the VMIM running is that only the source pod is populated:
status:
  migrationState:
    sourcePod: virt-launcher-vm-dv-b77cz
  phase: Running
  phaseTransitionTimestamps:
  - phase: Pending
    phaseTransitionTimestamp: "2024-07-15T17:14:51Z"
  - phase: Scheduling
    phaseTransitionTimestamp: "2024-07-15T17:14:51Z"
  - phase: Scheduled
    phaseTransitionTimestamp: "2024-07-15T17:14:54Z"
  - phase: PreparingTarget
    phaseTransitionTimestamp: "2024-07-15T17:14:54Z"
  - phase: TargetReady
    phaseTransitionTimestamp: "2024-07-15T17:14:54Z"
  - phase: Running
    phaseTransitionTimestamp: "2024-07-15T17:14:54Z"

@vladikr is this a design decision or a bug?

In general, I wouldn't consider it a bug. For a long time the VMIM object was only tracking phases of the migration controller - migration itself is the Running phase.
At this point, virt-controller hands off the VMI to virt-handler for the actual migration.
Virt-handler maintains its own migrationState.
When the migration is over this state will be reflected on the VMIM object.
That was the logic so far. We can, of course, continuously update the VMIM MigrationState based on the VMI status, but we need to look into the performance impact of this.
I'm also not sure what value would this change bring as one can simply watch the VMI object.

In general, I wouldn't consider it a bug. For a long time the VMIM object was only tracking phases of the migration controller - migration itself is the Running phase. At this point, virt-controller hands off the VMI to virt-handler for the actual migration. Virt-handler maintains its own migrationState. When the migration is over this state will be reflected on the VMIM object.
That was the logic so far. We can, of course, continuously update the VMIM MigrationState based on the VMI status, but we need to look into the performance impact of this. I'm also not sure what value would this change bring as one can simply watch the VMI object.

Maybe a good compromise is to set only certain information which doesn't periodically change like the startime stamp or the node. @awels which part is interesting for you?

@awels are you fine in watching the VMI? Or would you prefer to have certain info synchronized on the VMIM?


Change case-insensitive Json default in SignalR

Fixes #10774

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=214210&view=logs

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2625


CreateVmWizard Networking step - Fix saving new nic error

Fixes: #1299 .
The previous syntax includes bug.
I changed Iterator's syntax, now vnic saved successfully

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.


Fixed implode(): Passing glue string after array is deprecated warning

@sahil-cb Can we merge this pr please? 😊

please merge this.

Can this be tagged in a new version?

@Fossil01 done. Tagged as release 1.0.11

@oa-coinbase Thanks, but the package is not updated on Packagist yet. Seems auto update is also turned off:
https://packagist.org/packages/coinbase/coinbase-commerce


ID type feild is empty in the downloaded VC

Describe the bug
ID type feild bar is fully empty in the downloaded VC in both card state and detailed state
Steps To Reproduce

Open app and head to home page
click on add ID and download VC
Go back to home

Expected behavior
in VC above the VC holders  image it should contains ID type values
Current behavior
in the downloaded VC above the VC holder image the whole feild is empty in both card state and detailed state
Screenshots

Smartphone (please complete the following information):
Device: android
MOSIP Version: 121
MOSIP server: qa-121.mosip.net
APK link : https://github.com/mosip/inji/suites/8476299188/artifacts/376688868

verified as fixed in the build with commit id in the below screenshot.
https://drive.google.com/file/d/15uWjasH2tRj0qCau8Ljj8YFEoSXi6mfd/view?usp=drivesdk


browserify exited with code 1

Thanks for creating this service! I haven't been able to get a request from requirebin to work today, I've tried with various versions of React set but always seems to be variations of the following or a 504 Gateway Timeout.
Request
{
  "options":{"debug":true},
  "dependencies":{"react":"*","react-dom":"*","emojione-picker":"2.2"}
}

Response
---FLAGRANT SYSTEM ERROR---

--- error #0: ---

(logs uuid: 98e00ea0-32cb-11e7-8cb0-132801c92ed4 )

Error: "browserify exited with code 1"

code: 1
stderr: Error: Cannot find module 'react/lib/ReactDOM' from '/tmp/react-dom11747-27730-1txvb55/node_modules/react-dom'
    at /home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:82:15)

dirPath: /tmp/react-dom11747-27730-1txvb55

--- error #1: ---

(logs uuid: 98e05cc0-32cb-11e7-8cb0-132801c92ed4 )

Error: "browserify exited with code 1"

code: 1
stderr: Error: Cannot find module 'prop-types' from '/tmp/emojione-picker11747-27730-3ucrs6/node_modules/emojione-picker/lib'
    at /home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /home/admin/browserify-cdn/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:82:15)

dirPath: /tmp/emojione-picker11747-27730-3ucrs6

This sounds like a peerDependencies issue. Those don't work. I'll find the issue.

https://github.com/jfhbrook/wzrd.in/issues/130

Basic testing, ie https://wzrd.in/standalone/concat-stream@latest suggests this isn't a regression.
Closing as a dupe, barring proof that this is different.
Sorry :/

I understand you have to keep the issues under control! The package I'm importing has no peerDependencies though: https://github.com/tommoor/emojione-picker/blob/master/package.json
Unless you're suggesting that React / ReactDOM does and those can't be used with wzrd.in ? Seems like that would disallow quite a lot of usecases nowadays.

Yes, that is indeed the case--react modules effectively treat each other as peer dependencies.

It's a fairly major limitation, I agree! But it would require a pretty big refactor to support this, due to a deep-seated design assumption (that peerDeps are rare).
If you're interested in fixing this, try to find me in irc (#node.js is as good a place as any) and we can talk about next steps.

emoji-picker, fwiw, succeeds for me.


Please tidy up old releases

To reduce the load on the ASF mirrors, projects are required to delete old releases [1]
Please can you remove all non-current releases from the mirror source area at:
https://dist.apache.org/repos/dist/release/mynewt/
i.e. please remove:
apache-mynewt-1.3.0/
apache-mynewt-1.4.0/
apache-mynewt-1.4.1/
apache-mynewt-1.5.0/
apache-mynewt-1.6.0/
apache-mynewt-1.7.0/
apache-mynewt-1.8.0/
apache-nimble-1.0.0/
apache-nimble-1.1.0/
apache-nimble-1.2.0/
apache-nimble-1.3.0/
It's unfair to expect the 3rd party mirrors to carry old releases.
However you can still link to the archives for historic releases.
Please also update your release procedures to note that old releases should be removed.
This is best done after a new release has been announced.
Thanks!
[1] http://www.apache.org/dev/release.html#when-to-archive

Thanks very much for dealing with this promptly.


Some of our CI jobs that run in PRs do not run in Insiders Pipeline

E.g. running Notebook tests

Probably makes sense to wait for #4175 before doing this

Probably makes sense to wait for #4175 before doing this

Validated. This looks legit to me now in the new main file running.

Validated. This looks legit to me now in the new main file running.


File rules documentation config snippet incorrect

Hi all,
I've been reading about file rules and decided to modify the ACES 1.2 config to include the file rules from OCIO documentation:
files_rules:
  - !<Rule> {name: LogC, extension: "*", pattern: "*LogC*", colorspace: ARRI LogC}
  - !<Rule> {name: OpenEXR, extension: "exr", pattern: "*", colorspace: ACEScg}
  - !<Rule> {name: TIFF, regex: ".*\.TIF?F$", colorspace: sRGB}
  - !<Rule> {name: ColorSpaceNamePathSearch}
  - !<Rule> {name: Default, colorspace: default}

I've also changed the config version to v2, since that config is v1.
However, after using ociocheck on that config I've discovered that there are two problems with it:

Typo: files_rules instead of file_rules
Error because of the unknown escape character : . This one I fixed by deleting the backslash (\) from the TIFF rule.

I was thinking of submitting a pull request to fix this. Is this something that should be fixed via pull request or is it something that OCIO devs would fix internally, since it's a really small and simple fix?

Error because of the unknown escape character : . This one I fixed by deleting the backslash (\) from the TIFF rule

If the intention is to represent a literal . dot before the extension,  I think we might actually need to add a second backslash  to escape YAML's own parsing of the backslash character: ".*\\.TIF?F$"

Yes, you're probably right. That's probably supposed to match files with the .TIF extension, as well as other similar to that.

Closing as fixed by PR #1738.


Shared workspaces

Hi, guys!
Seems, that "Execute concurrent builds if necessary" option is useless (and often harmful), when building on different slaves (containers), but on one physical server, when workspace is persistent and mounted into container.
How did you solve this issue?

@fragpit You might want to check out docker volume plugin with which you can attach/detach a volume for your build

Also, I found, that docker supports such keys:
docker run -v /jenkins_home:/jenkins_home -v /jenkins_home/workspace
but mesos plugin is not. Container can't start.
So the problem is that I need to have jenkins_home mounted, but I want workspace folder to be temporary. Now I use workaround, and don't mount jenkins_home for concurrent builds.

@fragpit, does it work with the newest plugin?

@jeschkies  sorry, I'm not using mesos anymore.

Sad to hear that. Is there a special reason why you dropped Mesos?

Well, at first, my team switched to gitlab. And as for me k8s infrastructure  seems more interesting for build agents

Thanks for the reply. So you are not using Jenkins anymore or did you switch to Jenkins X?


FFT: avoid creating opencl/cuda contexts when not needed

(see #3439 discussion)
This PR fixes opencl/cuda contexts being created unnecessarily.
Changelog: FFT: avoid creating opencl/cuda contexts when not needed

LGTM

Yes, thanks

could you rebase so CI works better?

Sorry missed the last answer. The PR was rebased on latest master.


container not starting, error in kubelet "Failed to mount device /dev"

What happened:
Pod is not starting up, I am seeing errors as below:
on the node /var/log/blobfuse-driver.log :
Thu Jun 11 08:06:32 UTC 2020 INFO: tmp-path not specified, use default path: /tmp/blobfuse/
Thu Jun 11 08:06:32 UTC 2020 EXEC: mkdir -p /var/lib/kubelet/pods/56e9105e-06fb-4a8a-8b1b-57b3ba7f8687/volumes/azure~blobfuse/pv-blobfuse-flexvol
Thu Jun 11 08:06:32 UTC 2020 INF: AZURE_STORAGE_SAS_TOKEN is set
Thu Jun 11 08:06:32 UTC 2020 INF: export storage account - export AZURE_STORAGE_ACCOUNT=azeuwstotestingkuber01
Thu Jun 11 08:06:32 UTC 2020 EXEC: blobfuse /var/lib/kubelet/pods/56e9105e-06fb-4a8a-8b1b-57b3ba7f8687/volumes/azure~blobfuse/pv-blobfuse-flexvol --container-name=azeuwstotestingkuber01 --tmp-path=/tmp/blobfuse/ -o allow_other
Thu Jun 11 08:06:32 UTC 2020 ERROR: { "status": "Failure", "message": "Failed to mount device /dev/ at /var/lib/kubelet/pods/56e9105e-06fb-4a8a-8b1b-57b3ba7f8687/volumes/azure~blobfuse/pv-blobfuse-flexvol, accountname:azeuwstotestingkuber01, error log:Thu Jun 11 08:06:32 UTC 2020 EXEC: blobfuse /var/lib/kubelet/pods/56e9105e-06fb-4a8a-8b1b-57b3ba7f8687/volumes/azure~blobfuse/pv-blobfuse-flexvol --container-name=azeuwstotestingkuber01 --tmp-path=/tmp/blobfuse/ -o allow_other " }

kubectl describe show this output:
Events:
  Type     Reason       Age               From                                       Message
  ----     ------       ----              ----                                       -------
  Normal   Scheduled    <unknown>         default-scheduler                          Successfully assigned default/nginx-flex-blobfuse to aks-prodnode-29454676-vmss000001
  Warning  FailedMount  3s (x5 over 11s)  kubelet, aks-prodnode-29454676-vmss000001  MountVolume.SetUp failed for volume "pv-blobfuse-flexvol" : invalid character 'F' looking for beginning of value

In my case, too, /tmp/blobfuse did not exist and I created it manually on all nodes.
PV and PVC are created as required:
NAME                  CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                          STORAGECLASS   REASON   AGE
pv-blobfuse-flexvol   100Gi      RWX            Retain           Bound    default/pvc-blobfuse-flexvol                           50m
NAME                   STATUS   VOLUME                CAPACITY   ACCESS MODES   STORAGECLASS   AGE
pvc-blobfuse-flexvol   Bound    pv-blobfuse-flexvol   100Gi      RWX                           50m

What you expected to happen:
How to reproduce it:
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): 1.16.9
OS (e.g. from /etc/os-release): Ubuntu 16.04
Kernel (e.g. uname -a): 4.15.0-1083-azure
Install tools:
Others:

same issue as https://github.com/Azure/kubernetes-volume-drivers/issues/58

Except for the fact, that the reporter of issue #58 was able to get it working. In my case, creating the host volume did not help.

I would suggest use https://github.com/kubernetes-sigs/blobfuse-csi-driver, this flexvolume driver is now in maintenance mode since we are switching to csi driver.

I'd love to do that but I've read that the status for the csi driver is beta. Do you have any timeline for this to change? We have policies in place that keep us from using beta flagged software.

I'd love to do that but I've read that the status for the csi driver is beta. Do you have any timeline for this to change? We have policies in place that keep us from using beta flagged software.

GA time for blobfuse CSI driver could be late this year.
For this flexvolume issue, follow troubleshooting tips here: https://github.com/Azure/kubernetes-volume-drivers/tree/master/flexvolume/blobfuse#tips

after rebuild from scratch, driver is working as expected. can’t reproduce error any more. must have been something odd on the first try.


Add AWS Graviton with Nvidia : G5g

[ ] Implement the dockerfile
[ ] Implement Compute Env, Queue, Jobs, API

https://towardsaws.com/cpu-vs-gpu-for-video-transcoding-challenging-the-cost-speed-myth-b5e0726ce3e8

FYI : https://docs.aws.amazon.com/batch/latest/userguide/gpu-jobs.html

Only instance types that support a NVIDIA GPU and use an x86_64 architecture are supported for GPU jobs in AWS Batch. For example, the G4ad and G5g instance families aren't supported.

Please contact AWS Support, if you need G5g with AWS Batch

@gmarchand Does this mean it is possible to get G5G instances with AWS Batch by contacting support? Or does this mean it's not available and we should contact support to tell them we'd like that as a feature in the future?

Hello Please, contact support  to indicate you would like this feature in AWS Batch

Unfortunately I don't have a support plan that lets me contact AWS Support (I'm on the Basic tier). If it's helpful internally, feel free to reference this github issue though. I would like to use the G5g instances with AWS Batch for ffmpeg processing.


A few notes on the clarity of the page

in the section for launching the surface fabric explorer, it would be nice to have the URL spelled out along with the link. I was using ssh with X to connect to my Linux box.  so the direct link did not work.  Yea I know not a big deal to right click and copy link, but it would be nice.
Second one:  in the install eclipse section, it is a bit vague on what IDE for Eclipse to choose.  I chose the IDE for Java developers but was unsure if it should be that one, or the Java EE version.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 867a5a41-6a54-7c92-6bb3-65eec3159076
Version Independent ID: f83a57ba-66fc-96a4-9f69-6bb299a51001
Content: Set up your development environment on Linux
Content Source: articles/service-fabric/service-fabric-get-started-linux.md
Service: service-fabric
GitHub Login: @mani-ramaswamy
Microsoft Alias: subramar

@masnider  F.Y.I.  the couple of things we talked about

@roddw2  You can actually use either IDE, it doesn't matter which.  We updated the text to make this more clear:  https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-get-started-linux#set-up-a-local-cluster Thanks for the feedback.  #please-close


minikube: init at 0.13.1

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[x] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

duplicate of https://github.com/NixOS/nixpkgs/pull/20819, but this one is newer.

Question, I see you don't do patchelf, is minikube statically built?

@offlinehacker Yes, it does not require patchelf.

OK, I will test it tomorrow and then we can merge your pull request.
On Wed, Dec 7, 2016, 2:45 AM Rommel M. Martinez<EMAIL_ADDRESS>wrote:

@offlinehacker https://github.com/offlinehacker Yes, it does not
require patchelf.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/20937#issuecomment-265330954, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjvS0dgb4HGdtI_FReo01W5SRjondzFks5rFg_FgaJpZM4LE7XX
.

Ok!


[FR]: Allow clicking on the parts input to directly create a text part

for user-friendliness, it'd be very nice if clicking into an unpopulated  ``bb-llm-input` created a text part so you could just start typing.

I really like this idea. We've gone back and forth on it a few times because the default block is where we normally need to create any placeholder type inputs. But your suggestion is great because it augments that.


Use unversioned clang/clang++ if versioned binaries don't exist.

Depending on the platform, there might not be a versioned binary
such as clang-12 available. Fall back to simply clang then.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Codecov Report

Merging #1390 (9ba30f6) into master (1f7c2d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1390   +/-   ##
=======================================
  Coverage   92.90%   92.90%
=======================================
  Files         340      340
  Lines       23832    23832
=======================================
  Hits        22141    22141
  Misses       1691     1691

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[FEATURE] Skip List

Data Structure
I couldn't find skip list data structure
Possible Implementation
I can contribute if it's possible

Please create a PR if you think it fits well here.
We will review your PR as soon as you submit it.
Please review the contributing guidelines.
Thank you for your contribution. 🙂


Is it possible to print out the results for a single image or video?

I want to do a single image test with learned weights. I want to see the result of the completed image, what should I do?

Thanks for your interest in our work.
We will provide the video and the video process code soon.

Thank you for your patience. For reference, you can see this demo, HOI_detection_demo.ipynb.


updated landing page and email content

Updated email content and landing page content:

Signed-off-by: wadeking98<EMAIL_ADDRESS>

The admin email is requested by the override scripts at deployment time, it should not be included in the param files.

change completed


Document running Dagger on Tekton

One of Dagger's flagship features is the ability to run on almost any CI environment. This includes Tekton, a popular option in the Kubernetes community. There should be a documentation page explaining how to run Dagger on Tekton, similar to the page explaining how to run it on Github Actions.

So I don't understand why accessing fastly is a blocker for you, sorry.

No problem, not a blocker. It was more related to creating a Fastly account tied to a company vs an easier way for any developers to get access to the service.
I figured it out and will open a PR soon.

I opened https://github.com/dagger/dagger/pull/2097 as a first example.
There are a few improvements we could do to in the near future to make it better (less yaml 😄 )

use a dagger multi-arch container image instead of installing dagger
create a Dagger Tekton Task and publish it to Tekton Hub
have an example fully based on Buildkit to build a container image to remove the dind sidecar

I will keep you posted when I have time to work on it.

use a dagger multi-arch container image instead of installing dagger

Related to #1371


Hello (Autistic) World - I'm Katmuss!

Hey, I'm on Github!
I was involved in the website testing stage but I'm very very interested in the tech/coding side of things, as well as data collation.
I've been talking to Georgia, and I would love to know more about all things Data Anlytics, Modelling & Visualisation, so I might dip my toe into Data Story-Telling!
Thank you for letting me get involved!
Katmuss x

Summary

Deadline
What needs to be done?

[ ]
[ ]

Who can help?

Updates

Hi! Welcome! It's fab to have a new collaborator and we're excited to work with you! xx

Thank you - let's see if I don't get lost here on Github haha!
Looking forward to seeing the tech side of things!
@GeorgiaHCA (and anyone else who has thoughts) I meant to ask - do you think anyone would mind if I updated my LinkedIn profile with my involvement with the project? I know things haven't been released yet, and so I don't want to tread on any toes!
I just feel like even observing what happens on the tech side of things would be invaluable experience, especially if I'm eventually able to contribute (not there yet mind!).
Thanks for the lovely welcome <3
Kat x

That would be absolutely fine @kbrowningmusic ! And if there's something that would be especially useful to learn or an area which appeals most we can focus in on that.

This might be a useful course since you mentioned you're interested in data visualisations and sharing stories with data: https://www.turing.ac.uk/courses/data-visualisation-and-visual-analytics


VmService onTimelineEvent stream sending duplicate event blocks

Currently trying to workaround this in DevTools by storing a set of all the event block timestamps we have currently received, and not processing timeline events for a block if we have already seen a block of events with the same timestamp.
@bkonyi

Interestingly, even with removing duplicate blocks (matching on the timestamp of the block), we are still seeing duplicate traces.

I will add notes here as I discover things. I have noticed that events from the very first block tend to be repeated.

I'm unable to reproduce. Feel free to re-open if you start seeing it again.


feat: Show module status in busola view

Description

Changes proposed in this pull request:

added detail view for telemetry resource to indicate the status

Related Issues and Documents

Closes:
Related issues:
Traceability

[ ] The PR is linked to a GitHub Issue.
[ ] New features have a milestone label set.
[ ] New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
[ ] The corresponding GitHub Issue has a respective area label.
[ ] The follow-up issues (if any) are linked in the Related Issues section.

Testability
The feature is unit-tested:

[ ] Yes.
[ ] No, because unit tests are not needed.
[ ] No, because of ...

The feature is e2e-tested:

[ ] Yes.
[ ] No, because e2e-tests are not needed.
[ ] No, because of ...

Tests conducted for the PR:

Codebase

[ ] My code follows the Effective Go style guidelines.
[ ] The code was planned and designed following the defined architecture and the separation of concerns.
[ ] The code has sufficient comments, particularly for all hard-to-understand areas.
[ ] This PR adds value and shows no feature creep.
[ ] I have augmented the test suite that proves my fix is effective or that my feature works.
[ ] Adjusted the documentation if the change is user-facing.

/retest

/retest


manifests: Add a manifest for deploying the Cockpit Demo

The cockpit demo is hosted outisde of the core repository, but for
demonstration purpose it is still valuable to deploy it.
See also https://github.com/kubevirt/cockpit-demo

Rebased and verified that it works.


fix: approving tokens transfer when creating request

Closes #365

@emizzle Nice catch! But can you please give this PR Approve and I will fix it before merging?


Finish documentation

I've noticed that the Seidel fitting has been added to the examples in the docs. Shall we add the Zernike fitting to the examples, too?

Yes, we'll just need to turn it into a notebook like the Seidel example.

There should be already an existing notebook. It's possible that we only committed the .py, though. I will check and let you know.

Regarding the docs, is it possible to add some indents in the table of contents? E.g. have the PhaseMasks heading and then indent the subheadings (PhaseMask, SeidelAberrations, ZernikeAberrations etc.).

Regarding the docs, is it possible to add some indents in the table of contents? E.g. have the PhaseMasks heading and then indent the subheadings (PhaseMask, SeidelAberrations, ZernikeAberrations etc.).

Yes, this is definitely something I need to fix. We just have to setup mkdocs correctly to handle the headings from the docstrings.

There should be already an existing notebook. It's possible that we only committed the .py, though. I will check and let you know.

That's right, I think I only got the .py. But I did also update the style of the Seidel notebook a bit. Thanks for checking!

Regarding the docs, is it possible to add some indents in the table of contents? E.g. have the PhaseMasks heading and then indent the subheadings (PhaseMask, SeidelAberrations, ZernikeAberrations etc.).

So this should be fixed right now (might take some time/refreshing before it changes on readthedocs).


@react-email/components breaks with React 19 +<EMAIL_ADDRESS>

Describe the Bug
After updating React 19, @types/react and nextjs to stable 15.0.0 @react-email/components is breaking our application. The error is on every component exported from the package with a version of: 0.0.26-canary.4
'Section' cannot be used as a JSX component.

Its type 'ForwardRefExoticComponent<Readonly<Omit<DetailedHTMLProps<TableHTMLAttributes<HTMLTableElement>, HTMLTableElement>, "ref">> & RefAttributes<HTMLTableElement>>' is not a valid JSX element type.

We are on latest @react-email/components canary @ 0.0.26-canary.4
Which package is affected (leave empty if unsure)
No response
Link to the code that reproduces this issue
https://github.com/resend/react-email/blob/canary/packages/section/src/section.tsx#L5
To Reproduce
Upgrade to latest React + types
Expected Behavior
forwardRef should be removed for canary release as canary.
What's your node version? (if relevant)
22

Also happens with the Html component

Can you share a reproduction for the error?

You should use @types/react<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>when using react 19, maybe this already resolves your issue.

@luskin We are using the types for React 19 internally and there aren't any of the issues you mention. So that we can be sure, I'll repeat, can you share a reproduction of the error?

Simple temporary fix is to do as any btw

@elie222 Seems as that is another error, not the same one as on the original comment for the issue

@elie222 Seems as that is another error, not the same one as on the original comment for the issue

I fixed it in my case by updating React types for Resend package in my monorepo.

Closing this as stale, if anyone experiences this, please share a reproduction and I'll reopen.


Different package name on Android and IOs

Hi there.
I'm using different package names on Android and IOs for the same App, it did happend because I'm had to create another application on Android Play Store, after missed the keystone password.
Anyway, is there a problem in using the same license is this apps?
Or, should I try to change the package on IOs store?
Thanks in advice!

iOS is free.  Only Android consumes license keys.  The plugin doesn't care about your iOS package name.