NoUnused.Variable removes the following comment

In some cases (as the following example), the comment following a non-used top variable is removed.
SSCCE (Short Self-Contained Correct Example)
When running elm-review --fix on the following example (I simplified the real use case):
module Main exposing (main)

import Api
import AuthToken exposing (AuthToken)
import Html
import Id exposing (Id)
import Task exposing (Task)

main : Html.Html msg
main =
    Html.text "Hello World"

-- SINGLE

get : AuthToken -> Id -> Task Api.Error Event
get token id =
    let
        url =
            ApiUrl.event id

        decoder =
            Decode.field "event" Event.decoder
    in
    Api.get (Just token) url decoder

-- LIST

list : AuthToken -> Task Api.Error (List Event)
list token =
    let
        url =
            ApiUrl.events

        decoder =
            Decode.field "events" (Decode.list Event.decoder)
    in
    Api.get (Just token) url decoder

-- CREATE

We get the following proposition:

This proposition proposes to remove the following comment which I do not want. In other scenarios, this does not happen.
Expected behavior
I would expect only the lines 19-30 to be removed. (Ideally, I would want to remove line 16, but how can elm-review know that?)
Additional context
elm-review CLI version: 2.3.3
"jfmengels/elm-review": "2.3.8"
"jfmengels/elm-review-unused": "1.1.4"

Thanks for reporting this :)
It's a known issue, due to a bug in the parser (https://github.com/stil4m/elm-syntax/issues/63). We're going to try publishing a version of that library with a fix soon. I'll close this issue when that happens so you'll be notified :+1:

Thanks for reporting this :)
It's a known issue, due to a bug in the parser (https://github.com/stil4m/elm-syntax/issues/63). We're going to try publishing a version of that library with a fix soon. I'll close this issue when that happens so you'll be notified :+1:

Great, thanks!

Great, thanks!

elm-syntax v7.2.0 has been released, and elm-review v2.4.1 should support it well. The issue should be fixed now. Feel free to re-open/leave a comment if you encounter this problem again :blush:

Great, thanks for the work and for letting me know!
I tried the new elm-review with the new elm-syntax and here is what I got:

It should be working fine, but there is something weird about which newlines will be deleted.

Yeah, that's the diff algorithm that I'm using that does not optimize for "blocks" of code. I'm using https://package.elm-lang.org/packages/jinjor/elm-diff/latest.
I'll create an issue and see if some people would be interested in improving that :+1:


Roll Engine from c475288d9389 to e90ff67f6d77 (2 revisions)

https://github.com/flutter/engine/compare/c475288d9389...e90ff67f6d77
2021-03-04<EMAIL_ADDRESS>Guard metal rendering behind SHELL_ENABLE_METAL (flutter/engine#24727)
2021-03-04<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from _vRi_XkB7... to zPlM6iYY3... (flutter/engine#24782)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from _vRi_XkB7ZV5 to zPlM6iYY3N49
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


When will the code be released？

Hello,congratulations on being selected for ICRA2022.I noticed you said the code would be released in May，Now when can we see the code?look forward to hearing from you.

Hi @sien110 I am still working on the code. I just released the dataset TartanAir Shibuya. If you're interested, you may take a look.

I've been looking forward to your open source code. When will it be released?

@sien110 @running-snail-szj
thank you for your patience. I have uploaded the code. If you encounter any issues, please let me know by leaving a comment.


feat: add Storybook back to vite-ecosystem-ci

Supersedes https://github.com/vitejs/vite-ecosystem-ci/pull/307 and https://github.com/vitejs/vite-ecosystem-ci/pull/137.
Second attempt: I have provided some scripts for the ecosystem-ci in Storybook's monorepo. I had to introduce a before-test script on our side to copy over the resolutions field from the root's package.json to the package.json of the created sandbox: https://github.com/storybookjs/storybook/pull/27518/files, but this should be fine I guess.

storybook test passed in #322  so this is good to go


No CI included yet...

We need to investigate on some testing stuffs, like Travics for instance...

Add ci in #29


Add-dialects

Describe your changes
Adds Ika and Ikwere dialects to igbo api
Issue ticket number and link
n/a
Motivation and Context
Increases number of dialects available by 2

@Chinurum-Omenuko thank you for opening this PR! Are you able to rebase your changes on top of the latest commit in master so I can see only your changes?


No an issue: compatibility with earlier Kibana 7.1.1

That's not an issue, but if someone needs to make it work in earlier version of Kibana 7.1.1 (which is the latest atm available in AWS Elasticsearch) I've made a fork and migrated the config *.json
See https://github.com/kivanov82/micrometer-kibana-dashboard

Thank you for your comment.
We created a branch for 7.1.1, so please use it if you like.
https://github.com/acroquest/micrometer-kibana-dashboard/tree/elastic-7.1.1

@kivanov82
In this version, the setup procedure has changed. Please check the following link.
https://github.com/acroquest/micrometer-kibana-dashboard/tree/elastic-7.1.1#setup-kibana-dashboard


Stop embedbox.io animation if the user interacts with the demo

This should also help with the weird glitches

Maybe even just on hover?

Maybe pause on hover, stop on click/focus.


Recursive python symlinks in virtualenv

versions:
nox==2019.5.30
virtualenv==16.6.2
Trying to debug, I wanted to enter the virtualenv:
$ virtualenv .nox/session-XYZ
This resulted in
OSError: [Errno 40] Too many levels of symbolic links: 'ENV_DIR/bin/python'
Looking inside, looks like python -> python3.6 and python3.6 -> python.

$ ls-l .nox/session-XYZ/bin | grep python
lrwxrwxrwx 1 omry omry    9 Jul 17 15:32 python -> python3.6
lrwxrwxrwx 1 omry omry    6 Jul 17 15:37 python3 -> python
lrwxrwxrwx 1 omry omry    6 Jul 17 15:37 python3.6 -> python

Fellow user here. I tried to reproduce this, but couldn't. Is this behaviour reproducible when deleting and having .nox re-create the session virtualenvs?
I searched for the error and found nothing definitive, only some tentative indication that creating a virtualenv sometimes seems to create these recursive symlinks, possibly when it runs several times and/or with nonstandard interpreter paths (https://stackoverflow.com/questions/43853672/oserror-errno-40-too-many-levels-of-symbolic-links-home-ahmed-virtualenvs, /pypa/virtualenv/issues/1181) and/or spelling variations like upper-case or underscores vs hyphens (/pypa/virtualenv/issues/1006). Strange, and not sure how this happens. 🤷♂
Did deleting the session directory (or the whole .nox directory) fix it, or did the problem resurface again?

yeah, does not seem to repro now.
maybe it was something to do with reusing environments.
Thanks for looking.
closing  this for now, will re-open if I have a repro.


Resolve Google error/warning

Google We encountered an error loading live data. Trying to recover from cache! (
Error fetching results from Google! (could not convert string to float: 'c){var d=Ya;return Object.prototype.hasOwnProperty.call(d'))

I believe this has something to do with the Google API .. need to investigate

Google API is currently unstable, and they don't provide real-time prices.
Currently the code does a 4d moving average to compute the price.
I think it should not be used as source for a Bitshares price feed.
Also I have added here the retrival of stock prices (like AMAZON, FACEBOOK, ...) is someone want's to publish prices for AMAZONCOM, FACEBOOKCOM assets.


USB device recognized but not visible at /dev

RancherOS Version: v1.3
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
I'm running RancherOS virtually at a proxmox host. The proxmox host shows the usb device:
Bus 003 Device 002: ID 1a86:7523 QinHeng Electronics HL-340 USB-Serial adapter
Passthrough on proxmox host to RancherOS virtual machine seems to work: (dmesg output)
[   10.450093] usb 3-1: new full-speed USB device number 2 using uhci_hcd
[   10.878835] usb 3-1: New USB device found, idVendor=1a86, idProduct=7523
[   10.879762] usb 3-1: New USB device strings: Mfr=0, Product=2, SerialNumber=0
[   10.880767] usb 3-1: Product: USB2.0-Serial
But I can't see the device at /dev (devices listed are the same as before the passthrough)

@l-t-k  I don't have a proxmox environment, so I tested it with ESXI6.7 and it works fine in my ESXI environment.
I suspect that the wrong USB controller was selected when you created the virtual machine. If your interface is usb3.0, please set USB controller: 3.0 in proxmox.
dmesg logs:
[  125.896115] usb 2-1: new SuperSpeed USB device number 2 using xhci_hcd
[  125.917211] usb 2-1: New USB device found, idVendor=0781, idProduct=5591
[  125.917212] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  125.917214] usb 2-1: Product: Ultra USB 3.0
[  125.917214] usb 2-1: Manufacturer: SanDisk
[  125.917215] usb 2-1: SerialNumber: 4C530001261210102203
[  125.946040] usb-storage 2-1:1.0: USB Mass Storage device detected
[  125.946328] scsi host33: usb-storage 2-1:1.0
[  125.946375] usbcore: registered new interface driver usb-storage
[  125.947524] usbcore: registered new interface driver uas
[  126.948779] scsi 33:0:0:0: Direct-Access     SanDisk  Ultra USB 3.0    1.00 PQ: 0 ANSI: 6

[root@rancher opt]# ros -v
version v1.3.0 from os image rancher/os:v1.3.0

[root@rancher opt]# fdisk -l
Disk /dev/sda: 20 GiB,<PHONE_NUMBER>0 bytes, 41943040 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x93369112

Device     Boot Start      End  Sectors Size Id Type
/dev/sda1  *     2048 41940991 41938944  20G 83 Linux

Disk /dev/sdb: 28.7 GiB,<PHONE_NUMBER>0 bytes, 60062500 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0xcad4ebea

Device     Boot Start      End  Sectors  Size Id Type
/dev/sdb4  *       63 60062499 60062437 28.7G  7 HPFS/NTFS/exFAT

Close it.
If you still have doubts, please reopen it and let me know.


DateRangePicker PickerVariant.Static : Visual issue when setting date inside the code

Bug type
Component
Component name
DateRangePicker
What happened?

As you can see in this screenshot when setting date with code and not with a click event on the picker the litle dots at the begining and at the end are not shown.
Expected behavior

This is the expected behaviour, the litle dots should be shown when changing the date from the @code{}.
Reproduction link
https://try.mudblazor.com/snippet/cOwHOIvMIqFMnKXl
Reproduction steps

Open reproduction link
See the missing dots (already on load)

Change the date with click event on the datepicker

Click the button to set the date "from @code"

See the missing dots

Relevant log output
No response
Version (bug)
6.2.0
Version (working)
N/A
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @Tarru ,
The issue seems to be located at this location:
selectedRange=new();
selectedRange.Start = DateTime.Now;
selectedRange.End = DateTime.Now.AddDays(5);

If you use the following instead it works for me.
selectedRange = new DateRange(DateTime.Now.Date, DateTime.Now.AddDays(5).Date);

My guess is that if the selected binding only take changes to the DateRange into account.

Thanks @Tyme-Bleyaert ! Should I leave this openned for minor correction because it should also work the way i did it ? Or should I close it, as this "workaround" is working the way I want ?

@ScarletKuro What do you think?


Redesign _openassetio_test tests

What
Remove _openassetio_test in favour of extending _openassetio with test functions/types instead.
Why
Following on from https://github.com/OpenAssetIO/OpenAssetIO/pull/1234#discussion_r1440435303
The _openassetio_test Python extension module is used to exercise low-level Python binding code that is generic across all our bindings.  It defines and binds C++ functions and types that are only useful for test purposes and shouldn't be distributed.
Code in the main _openassetio Python extension module is designed to be entirely private, with no public headers and no symbols exported.
However, in order to re-use the same machinery in _openassetio_test that is used by _openassetio, we have to share code between them. This has led to compromises in project structure, and, most recently, exporting symbols (HybridException, see comment thread linked above) that should be hidden. This odd splitting of test functions/types yet sharing of internal machinery also means that tests are less representative of production scenarios.
Acceptance Criteria

Couple of ideas:

Concatenate the contents of _openassetio_test to _openassetio, or vice-versa, so the corresponding tests only use one module.

Using an #ifdef TESTING guarding a registerTestFunctions call in _openassetio, then using _openassetio exclusively in tests; or
Duplicating the contents of _openassetio in _openassetio_test and appending test functions/types, then using _openassetio_test exclusively in tests.

Perhaps we can split _openassetio_test into multiple Python extension modules, duplicating any subset of  _openassetio required for each mini module.


[RFR] File Picking [#OSF-5586]

Purpose
See:

https://openscience.atlassian.net/browse/OSF-5586?focusedCommentId=31673&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-31673
https://openscience.atlassian.net/browse/OSF-5586?focusedCommentId=31680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-31680
https://openscience.atlassian.net/browse/OSF-5586?focusedCommentId=31707&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-31707 (addressed in 8b3a4a2ecaf3ec25f38063edb7f1fd0f80f372cc)

Changes

Before we only check sha256 file file equivalence. Now also add a name check.

Improve spacing on file picker UI

Also merges and updates https://github.com/CenterForOpenScience/osf.io/pull/5494

Incorporates: https://github.com/CenterForOpenScience/osf.io/pull/5575

re-add Veer schema
tweaks to registrations UI

Looks good.
Created a new branch with this feature: samchrisinger-multi-files-veer . Also merged this into release/0.69.0 to get this onto staging.
👍 🐙


Name-error: not defined

Hi,
Trying to get my Sonos Connect to work, but get a name error after applying the UID to the sones-monitor.py. May be putting it in the wrong spot.
Discovering Sonos zones
   Slaapkamer (UID: RINCON_B8E937EE825401400)
   Badkamer (UID: RINCON_B8E937EE826401400)
   Woonkamer (UID: RINCON_000E58A4366201400)

The number of Sonos Connect devices found was not exactly 1.
Please specify which Sonos Connect device should be used by
using its UID as the first parameter.
Traceback (most recent call last):
  File "home/pi/sonos/sonos-monitor.py", line 117, in <module>
    connect_uid = RINCON_B8E937EE826401400
NameError: name 'RINCON_B8E937EE826401400' is not defined

Can you help? Thanks.
Geert

Just call the script with the name as the first parameter, don't try to tamper with the script itself.
E.g. call
python sonos-monitor.py RINCON_B8E937EE826401400


Revert "Merge pull request #63 from jpopelka/pre-commit"

This reverts commit 857f79554d471b64b4de6ce36df4f7b46a5334d1, reversing
changes made to 5ab2775556018fca67e69ae1848dd3c526c04870.
Zuul's ansible wasn't ready for these changes. We are reverting before they upgrade.
17:36 <mhu> are these changes compatible with ansible 2.9?
17:40 <mhu> ttomecek (IRC): I think Zuul uses a slightly modified version of ansible so I'm not sure the changes in the commit you linked are compatible with this
17:41 <mhu> could you possibly revert that change and retry?
17:43 <tdecacqu[m]> ttomecek (IRC): this is a zuul bug fixed by https://review.opendev.org/c/zuul/zuul/+/835662 . It should be fixed tomorrow when we upgrade zuul tomorrow, until then you can fix the issue by using the regular command module name

(tomorrow = May 4th)

@jpopelka please reopen your PR with the ansible-lint v6 changes


Wouldn't it be nice if this Context provider propaged component prop?

https://github.com/mui-org/material-ui/blob/2c8721ccf11740589c975eec46775f3a3ede830d/packages/material-ui/src/Table/Table.js#L49
It seems that to make make MUI build a table via div elements, you need to set the component prop to 'div' for ALL the table elements. Is this a design choice?
I think this context provider is a very good opportunity to automate this, it could propagate component type to all descendents.

@engina Why should we make it easy to render all divs?

@engina Why should we make it easy to render all divs?

Maybe I'm completely off. What's the typical use case of component property?
Personally, I wanted to try an all div table and I had to do it manually for each table element.
And I think, if you want a div table, you wouldn't go for tr, td elements either.

@engina Interesting. I'm closing as the use case seems too narrow to be worth spending time on

https://github.com/mui-org/material-ui/blob/2c8721ccf11740589c975eec46775f3a3ede830d/packages/material-ui/src/Table/Table.js#L49
It seems that to make make MUI build a table via div elements, you need to set the component prop to 'div' for ALL the table elements. Is this a design choice?
I think this context provider is a very good opportunity to automate this, it could propagate component type to all descendents.

I am asking just for the curiosity, why do you prefer div for creating tables instead of table?


Material 3 Navigation Drawer does not support scrolling or safe areas

The new Navigation Drawer widget that was introduced in #115668 is not scrollable. This easily becomes an issue when the navigation drawer contains many items or even just very few items, when viewed in landscape mode.
The user also cannot just add a ListView around the NavigationDrawerDestinations, like with the "old" drawer, because that will trigger an error:
Navigation destinations need a _NavigationDrawerDestinationInfo parent, which is usually provided by NavigationDrawer.
'package:flutter/src/material/navigation_drawer.dart':
Failed assertion: line 497 pos 7: 'result != null'

Along with implementing scrolling support, the Navigation Drawer should probably also automatically respect Safe Areas, because that will be hard for users to add theirselves with the current design, too.
Steps to Reproduce

Execute flutter run on the code sample
Resize the window / switch between portrait and landscape mode
The navigation is cut off

Expected results:
The NavigationDrawerDestinations are scrollable and also respect Safe Areas on devices with e.g. notches.
Actual results:
The items are cut off. Also, on an android device, the first element is behind the notch, because Safe Areas are ignored.

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        colorSchemeSeed: Colors.blue,
      ),
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Nav Bar Scrolling'),
        ),
        drawer: NavigationDrawer(children: [
          const SizedBox(height: 22),
          for (var i = 0; i < 30; i++)
            NavigationDrawerDestination(
              icon: const Icon(Icons.home_outlined),
              selectedIcon: const Icon(Icons.home),
              label: Text('Item $i'),
            ),
        ]),
      ),
    );
  }
}

Flutter Doctor
[✓] Flutter (Channel master, 3.7.0-4.0.pre.48, on Fedora Linux 37 (Workstation Edition) 6.0.9-300.fc37.x86_64, locale de_DE.UTF-8)
    • Flutter version 3.7.0-4.0.pre.48 on channel master at /home/marcus/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eefbe85c8b (vor 11 Stunden), 2022-12-08 22:32:07 -0600
    • Engine revision 8d83b98c55
    • Dart version 3.0.0 (build 3.0.0-0.0.dev)
    • DevTools version 2.20.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /home/marcus/Android/Sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /home/marcus/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8815526/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 15.0.4 (Fedora 15.0.4-1.fc37)
    • cmake version 3.24.2
    • ninja version 1.10.2
    • pkg-config version 1.8.0

[✓] Android Studio (version 2021.2)
    • Android Studio at /home/marcus/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8815526
    • Flutter plugin version 69.0.2
    • Dart plugin version 212.5744
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Android Studio (version 2021.3)
    • Android Studio at /home/marcus/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335
    • Flutter plugin version 71.0.3
    • Dart plugin version 213.7433
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.73.1)
    • VS Code at /usr/share/code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Fedora Linux 37 (Workstation Edition) 6.0.9-300.fc37.x86_64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Reproducible using the code sample provided above.

flutter doctor -v
[!] Flutter (Channel master, 3.7.0-5.0.pre.25, on macOS 13.0.1 22A400 darwin-arm64, locale en-GB)
    • Flutter version 3.7.0-5.0.pre.25 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 92aebc953d (70 minutes ago), 2022-12-11 22:24:23 -0500
    • Engine revision 922546c919
    • Dart version 3.0.0 (build 3.0.0-12.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.74.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.54.0

[✓] Connected device (3 available)
    • iPhone 14 Pro (mobile) • 4F72110C-F38B-4CF9-93C4-4D6042148D28 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.98

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


(Bug) Adds paste action, icon to trigger paste action and update error message

This PR closes #165529184, by:

Adding paste icon inside input to Who on send page
Updating error message in same page
Adding paste from clipboard action

For some reason Clipboard is not returning the real value from clipboard...(TO REVIEW)

For some reason Clipboard is not returning the real value from clipboard...(TO REVIEW)

This looks like the react-native-web support for the Clipboard component is limited to the setter and the getter will always return an empty string, see: Cliboard#L23-L25
  static getString(): Promise<string> {
    return Promise.resolve('');
  }

https://github.com/GoodDollar/GoodDAPP/pull/84/commits/30d75b1ab83755b63520f0925fd6072f11b61f37 :clap:


Cow: Watch getout.ae

Cow requests the watch of the watch_keyword getout\.ae. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

getout\.ae has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


added m1ultra cpu test result

Thanks for sending the results! I am actually quite surprised by the still very large runtime of 120 min! It's a 20-core CPU right? I expected it to be somewhat faster than the M1 pro CPU. Maybe there were several things running on the CPU already during the benchmark?

I was also pretty surprised by this. Yes 20 cores. Nothing else was running on the machine, as I turned it on just for this benchmark.

No idea! That's a bit strange 🤔

I got very similar results here - https://github.com/rasbt/machine-learning-notes/issues/12
Looks like there's a performance inversion on the CPU going from M1 Max to M1 Ultra. Maybe the die-to-die interposer used on the M1 Ultra is increasing the memory access latencies?

Yeah, it's a bit strange but  maybe it's because of the die-to-die interpose like you said. It's been a while and I don't remember much of the architecture keynote though.
This benchmark here is almost identical to the M1 Pro though, maybe another explanation is that it's the performance ceiling due to how many CPU cores are used


OpenCL program triggers kernel module crash for X399 + 2 VEGA10 GPUs

CPU: Threadripper 1900x
Memory: 64 GB
GPU: 2 x VEGA10(VEGA56/VEGA64)
X399 motherboard(stock setting + above 4G decoding enabled)
ROCm 2.2
OS: Both 16.04 and 18.04(kernel 4.15)

ROCm and OpenCL are installed with
$ sudo apt install rocm-dkms rocm-opencl-dev

I have encountered amdgpu kernel module crash when using OpenCL(e.g. /opt/rocm/opencl/bin/x86_64/clinfo) on 2 or more VEGA10 GPU installed on X399 motherboard. GPUs are connected with PCI-ex Gen3(x16 + x16 for 2 GPUs configuration)

Single GPU works fine on ROCm OpenCL.
OpenCL from AMDGPU pro driver(18.50) works fine for 2 VEGA10 GPUs configuration(clean install + amdgpu pro driver. No ROCm installed).

dmesg shows
BUG: unable to handle kernel NULL pointer dereference at<PHONE_NUMBER>000000

so something is not well handled in ROCm 2.2 amdgpu driver?
Here is a snippet of dmesg log.
Ubuntu 16.04
[ 4965.835972] amdgpu 0000:43:00.0: [gfxhub] no-retry page fault (src_id:0 ring:170 vmid:8 pasid:32771, for process  pid 0 thread  pid 0)
[ 4965.835976] amdgpu 0000:43:00.0:   in page starting at address 0x0000000000000000 from 27
[ 4965.835977] amdgpu 0000:43:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00840B54
[ 4965.835985] amdgpu 0000:43:00.0: [gfxhub] no-retry page fault (src_id:0 ring:154 vmid:8 pasid:32771, for process  pid 0 thread  pid 0)
[ 4965.835987] amdgpu 0000:43:00.0:   in page starting at address 0x0000000000000000 from 27
[ 4965.835988] amdgpu 0000:43:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00800B34
[ 4965.835992] Evicting PASID 32771 queues
[ 4974.837675] qcm fence wait loop timeout expired
[ 4974.837676] The cp might be in an unrecoverable state due to an unsuccessful queues preemption
[ 4974.837681] amdgpu 0000:43:00.0: GPU reset begin!
[ 4974.837682] Evicting PASID 32771 queues
[ 4975.045759] BUG: unable to handle kernel NULL pointer dereference at<PHONE_NUMBER>000000
[ 4975.045801] IP: soc15_baco_program_registers+0x6f/0x180 [amdgpu]
[ 4975.045802] PGD 467bff067 P4D 467bff067 PUD 45fd78067 PMD 0
[ 4975.045805] Oops: 0000 [#1] SMP NOPTI
[ 4975.045806] Modules linked in: rfcomm bnep arc4 iwlmvm edac_mce_amd mac80211 kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc snd_hda_codec_realtek iwlwifi snd_hda_codec_generic aesni_intel snd_hda_codec_hdmi aes_x86_64 crypto_simd glue_helper cryptd cfg80211 snd_hda_intel snd_seq_midi snd_seq_midi_event btusb snd_hda_codec snd_rawmidi btrtl btbcm btintel snd_hda_core snd_hwdep bluetooth snd_seq snd_pcm ecdh_generic snd_seq_device snd_timer snd ccp soundcore i2c_piix4 wmi_bmof k10temp shpchp mac_hid parport_pc ppdev lp parport autofs4 amdgpu(OE) amdchash(OE) amdttm(OE) amd_sched(OE) mxm_wmi amdkcl(OE) amd_iommu_v2 drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops igb drm dca i2c_algo_bit atlantic ptp ahci pps_core libahci gpio_amdpt wmi gpio_generic
[ 4975.045838] CPU: 14 PID: 1588 Comm: kworker/14:0 Tainted: G           OE    4.15.0-47-generic #50~16.04.1-Ubuntu
[ 4975.045839] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS XTREME/X399 AORUS XTREME-CF, BIOS F5c 10/25/2018
[ 4975.045872] Workqueue: events kfd_process_hw_exception [amdgpu]
[ 4975.045906] RIP: 0010:soc15_baco_program_registers+0x6f/0x180 [amdgpu]
[ 4975.045907] RSP: 0018:ffffad6b11ee3cd0 EFLAGS: 00010283
[ 4975.045908] RAX:<PHONE_NUMBER>000000 RBX:<PHONE_NUMBER>000000 RCX:<PHONE_NUMBER>000000
[ 4975.045909] RDX:<PHONE_NUMBER>000000 RSI: ffff9b2d545b0000 RDI:<PHONE_NUMBER>000005
[ 4975.045910] RBP: ffffad6b11ee3d18 R08:<PHONE_NUMBER>000000 R09:<PHONE_NUMBER>000139
[ 4975.045911] R10:<PHONE_NUMBER>000000 R11:<PHONE_NUMBER>00003a R12:<PHONE_NUMBER>000000
[ 4975.045911] R13: ffff9b2d545b0000 R14:<PHONE_NUMBER>000000 R15: ffffffffc080ab10
[ 4975.045913] FS:<PHONE_NUMBER>000000(0000) GS:ffff9b2d5e580000(0000) knlGS:0000000000000000
[ 4975.045913] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[ 4975.045914] CR2:<PHONE_NUMBER>000000 CR3:<PHONE_NUMBER>6b2000 CR4:<PHONE_NUMBER>3406e0
[ 4975.045915] Call Trace:
[ 4975.045949]  vega10_baco_set_state+0x75/0xe0 [amdgpu]
[ 4975.045982]  pp_set_asic_baco_state+0x5a/0x80 [amdgpu]
[ 4975.046010]  soc15_asic_reset+0xac/0x1a0 [amdgpu]
[ 4975.046034]  amdgpu_device_gpu_recover+0x403/0x900 [amdgpu]
[ 4975.046037]  ? __switch_to_asm+0x40/0x70
[ 4975.046067]  amdgpu_amdkfd_gpu_reset+0x20/0x30 [amdgpu]
[ 4975.046097]  kfd_process_hw_exception+0x18/0x20 [amdgpu]
[ 4975.046100]  process_one_work+0x14d/0x410
[ 4975.046101]  worker_thread+0x4b/0x460
[ 4975.046103]  kthread+0x105/0x140
[ 4975.046104]  ? process_one_work+0x410/0x410
[ 4975.046105]  ? kthread_destroy_worker+0x50/0x50
[ 4975.046107]  ret_from_fork+0x22/0x40
[ 4975.046108] Code: 8b 57 04 48 8b 75 c8 41 8b 5f 0c 41 8b 7f 18 45 8b 67 1c 45 8b 77 14 48 8d 04 40 48 8d 84 42 50 1a 00 00 41 8b 57 08 48 8b 04 c6 <03> 1c 90 41 83 7f fc 04 41 8b 47 10 89 45 d4 0f 87 dd 00 00 00
[ 4975.046155] RIP: soc15_baco_program_registers+0x6f/0x180 [amdgpu] RSP: ffffad6b11ee3cd0
[ 4975.046156] CR2:<PHONE_NUMBER>000000
[ 4975.046157] ---[ end trace e9fbabfbe54ce83a ]---
[ 5028.316832] [drm] schedpage0 is not ready, skipping
[ 5028.316835] [drm] schedpage1 is not ready, skipping
[ 5028.316894] [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-2)
[ 5028.316918] BUG: unable to handle kernel NULL pointer dereference at<PHONE_NUMBER>000008
[ 5028.316972] IP: amdgpu_vm_bo_update_mapping+0x100/0x430 [amdgpu]
[ 5028.316974] PGD 0 P4D 0
[ 5028.316978] Oops: 0000 [#2] SMP NOPTI
[ 5028.316980] Modules linked in: rfcomm bnep arc4 iwlmvm edac_mce_amd mac80211 kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc snd_hda_codec_realtek iwlwifi snd_hda_codec_generic aesni_intel snd_hda_codec_hdmi aes_x86_64 crypto_simd glue_helper cryptd cfg80211 snd_hda_intel snd_seq_midi snd_seq_midi_event btusb snd_hda_codec snd_rawmidi btrtl btbcm btintel snd_hda_core snd_hwdep bluetooth snd_seq snd_pcm ecdh_generic snd_seq_device snd_timer snd ccp soundcore i2c_piix4 wmi_bmof k10temp shpchp mac_hid parport_pc ppdev lp parport autofs4 amdgpu(OE) amdchash(OE) amdttm(OE) amd_sched(OE) mxm_wmi amdkcl(OE) amd_iommu_v2 drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops igb drm dca i2c_algo_bit atlantic ptp ahci pps_core libahci gpio_amdpt wmi gpio_generic
[ 5028.317026] CPU: 10 PID: 1134 Comm: Xorg Tainted: G      D    OE    4.15.0-47-generic #50~16.04.1-Ubuntu
[ 5028.317028] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS XTREME/X399 AORUS XTREME-CF, BIOS F5c 10/25/2018
[ 5028.317078] RIP: 0010:amdgpu_vm_bo_update_mapping+0x100/0x430 [amdgpu]
[ 5028.317080] RSP: 0018:ffffad6b11a1fac8 EFLAGS: 00010246
[ 5028.317082] RAX:<PHONE_NUMBER>000000 RBX: ffff9b2d52337800 RCX:<PHONE_NUMBER>000000
[ 5028.317084] RDX:<PHONE_NUMBER>000000 RSI:<PHONE_NUMBER>000000 RDI: ffffad6b11a1fb50
[ 5028.317085] RBP: ffffad6b11a1fb80 R08:<PHONE_NUMBER>102f7f R09:<PHONE_NUMBER>102f7f
[ 5028.317087] R10: ffff9b2d58e16798 R11: ffff9b2d545b0000 R12:<PHONE_NUMBER>000000
[ 5028.317088] R13: ffffad6b11a1fb18 R14:<PHONE_NUMBER>000000 R15:<PHONE_NUMBER>102f60
[ 5028.317090] FS:  00007f726a76fa00(0000) GS:ffff9b2d5e480000(0000) knlGS:0000000000000000
[ 5028.317092] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[ 5028.317094] CR2:<PHONE_NUMBER>000008 CR3: 0000000c5290e000 CR4:<PHONE_NUMBER>3406e0
[ 5028.317095] Call Trace:
[ 5028.317110]  ? add_hole+0xd3/0x100 [drm]
[ 5028.317114]  ? _cond_resched+0x1a/0x50
[ 5028.317163]  amdgpu_vm_clear_freed+0xbd/0x1b0 [amdgpu]
[ 5028.317211]  amdgpu_gem_va_ioctl+0x42e/0x560 [amdgpu]
[ 5028.317259]  ? amdgpu_gem_metadata_ioctl+0x1d0/0x1d0 [amdgpu]
[ 5028.317270]  drm_ioctl_kernel+0x6b/0xb0 [drm]
[ 5028.317281]  ? drm_ioctl_kernel+0x6b/0xb0 [drm]
[ 5028.317292]  drm_ioctl+0x3e4/0x450 [drm]
[ 5028.317339]  ? amdgpu_gem_metadata_ioctl+0x1d0/0x1d0 [amdgpu]
[ 5028.317343]  ? vfs_writev+0xb9/0x110
[ 5028.317387]  amdgpu_drm_ioctl+0x4c/0x80 [amdgpu]
[ 5028.317391]  do_vfs_ioctl+0xa4/0x600
[ 5028.317394]  ? __sys_recvmsg+0x80/0x90
[ 5028.317397]  SyS_ioctl+0x79/0x90
[ 5028.317401]  do_syscall_64+0x73/0x130
[ 5028.317404]  entry_SYSCALL_64_after_hwframe+0x3d/0xa2
[ 5028.317406] RIP: 0033:0x7f7268194f47
[ 5028.317407] RSP: 002b:00007fffa4977468 EFLAGS: 00003246 ORIG_RAX:<PHONE_NUMBER>000010
[ 5028.317410] RAX: ffffffffffffffda RBX:<PHONE_NUMBER>020fff RCX: 00007f7268194f47
[ 5028.317411] RDX: 00007fffa49774b0 RSI: 00000000c0286448 RDI:<PHONE_NUMBER>00000e
[ 5028.317413] RBP: 00007fffa49774b0 R08:<PHONE_NUMBER>f60000 R09:<PHONE_NUMBER>00000e
[ 5028.317414] R10:<PHONE_NUMBER>000002 R11:<PHONE_NUMBER>003246 R12: 00000000c0286448
[ 5028.317415] R13:<PHONE_NUMBER>00000e R14:<PHONE_NUMBER>000002 R15: 000055b142b384d8
[ 5028.317417] Code: 48 33 1c 25 28 00 00 00 0f 85 3c 03 00 00 48 81 c4 90 00 00 00 5b 41 5c 41 5d 41 5e 41 5f 5d c3 48 8b 83 d0 00 00 00 44 8b 45 80 <48> 8b 40 08 45 29 f8 45 8d 48 01 48 89 85 48 ff ff ff 48 8b 83
[ 5028.317495] RIP: amdgpu_vm_bo_update_mapping+0x100/0x430 [amdgpu] RSP: ffffad6b11a1fac8
[ 5028.317496] CR2:<PHONE_NUMBER>000008
[ 5028.317498] ---[ end trace e9fbabfbe54ce83b ]---

Ubuntu 18.04
...
[  326.326176] amdgpu 0000:43:00.0: [gfxhub] no-retry page fault (src_id:0 ring:170 vmid:8 pasid:32768, for process  pid 0 thread  pid 0)
[  326.326179] amdgpu 0000:43:00.0:   in page starting at address 0x0000000000000000 from 27
[  326.326181] amdgpu 0000:43:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00840B54
[  326.326190] amdgpu 0000:43:00.0: [gfxhub] no-retry page fault (src_id:0 ring:154 vmid:8 pasid:32768, for process  pid 0 thread  pid 0)
[  326.326192] amdgpu 0000:43:00.0:   in page starting at address 0x0000000000000000 from 27
[  326.326193] amdgpu 0000:43:00.0: VM_L2_PROTECTION_FAULT_STATUS:0x00800B34
[  326.326203] Evicting PASID 32768 queues
[  335.328342] qcm fence wait loop timeout expired
[  335.328345] The cp might be in an unrecoverable state due to an unsuccessful queues preemption
[  335.328352] amdgpu 0000:43:00.0: GPU reset begin!
[  335.328355] Evicting PASID 32768 queues
[  335.516507] BUG: unable to handle kernel NULL pointer dereference at<PHONE_NUMBER>000000
[  335.516549] IP: soc15_baco_program_registers+0x6c/0x180 [amdgpu]
[  335.516551] PGD ff4e3b067 P4D ff4e3b067 PUD 102e691067 PMD 0
[  335.516554] Oops: 0000 [#1] SMP NOPTI
[  335.516555] Modules linked in: cmac bnep arc4 nls_iso8859_1 amdgpu(OE) amdchash(OE) amdttm(OE) amd_sched(OE) snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi snd_hda_intel iwlmvm snd_hda_codec snd_hda_core snd_hwdep mac80211 snd_pcm snd_seq_midi snd_seq_midi_event snd_rawmidi amdkcl(OE) iwlwifi amd_iommu_v2 snd_seq joydev input_leds drm_kms_helper cfg80211 snd_seq_device drm snd_timer fb_sys_fops syscopyarea ccp wmi_bmof sysfillrect edac_mce_amd sysimgblt snd kvm mxm_wmi irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc btusb aesni_intel btrtl btbcm aes_x86_64 btintel crypto_simd glue_helper bluetooth cryptd soundcore k10temp ecdh_generic shpchp mac_hid wmi sch_fq_codel sunrpc parport_pc ppdev lp parport ip_tables x_tables autofs4 igb i2c_algo_bit i2c_piix4 dca atlantic
[  335.516588]  ptp ahci pps_core libahci gpio_amdpt gpio_generic hid_generic usbhid hid
[  335.516593] CPU: 11 PID: 181 Comm: kworker/11:1 Tainted: G           OE    4.15.0-47-generic #50-Ubuntu
[  335.516594] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS XTREME/X399 AORUS XTREME-CF, BIOS F5c 10/25/2018
[  335.516623] Workqueue: events kfd_process_hw_exception [amdgpu]
[  335.516653] RIP: 0010:soc15_baco_program_registers+0x6c/0x180 [amdgpu]
[  335.516654] RSP: 0018:ffffaecc074a3ce8 EFLAGS: 00010206
[  335.516655] RAX:<PHONE_NUMBER>000000 RBX:<PHONE_NUMBER>000000 RCX:<PHONE_NUMBER>000000
[  335.516656] RDX:<PHONE_NUMBER>000000 RSI: ffffa089106c0000 RDI:<PHONE_NUMBER>000005
[  335.516657] RBP: ffffaecc074a3d30 R08:<PHONE_NUMBER>0001aa R09:<PHONE_NUMBER>000000
[  335.516658] R10:<PHONE_NUMBER>000000 R11:<PHONE_NUMBER>3d0900 R12:<PHONE_NUMBER>000000
[  335.516659] R13:<PHONE_NUMBER>000000 R14: ffffa089106c0000 R15: ffffffffc0f7996c
[  335.516660] FS:<PHONE_NUMBER>000000(0000) GS:ffffa0893cac0000(0000) knlGS:0000000000000000
[  335.516661] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[  335.516662] CR2:<PHONE_NUMBER>000000 CR3: 0000000fff960000 CR4:<PHONE_NUMBER>3406e0
[  335.516663] Call Trace:
[  335.516692]  vega10_baco_set_state+0x7b/0xe0 [amdgpu]
[  335.516719]  pp_set_asic_baco_state+0x5a/0x80 [amdgpu]
[  335.516743]  soc15_asic_reset+0xac/0x1a0 [amdgpu]
[  335.516762]  amdgpu_device_gpu_recover+0x182/0x8a0 [amdgpu]
[  335.516766]  ? __switch_to_asm+0x40/0x70
[  335.516792]  amdgpu_amdkfd_gpu_reset+0x20/0x30 [amdgpu]
[  335.516819]  kfd_process_hw_exception+0x18/0x20 [amdgpu]
[  335.516821]  process_one_work+0x1de/0x410
[  335.516823]  worker_thread+0x32/0x410
[  335.516825]  kthread+0x121/0x140
[  335.516826]  ? process_one_work+0x410/0x410
[  335.516827]  ? kthread_create_worker_on_cpu+0x70/0x70
[  335.516829]  ret_from_fork+0x22/0x40
[  335.516830] Code: 8b 57 08 48 8b 75 c8 41 8b 5f 10 41 8b 7f 1c 45 8b 67 20 45 8b 6f 18 48 8d 04 40 48 8d 84 42 50 1a 00 00 41 8b 57 0c 48 8b 04 c6 <03> 1c 90 41 83 3f 04 41 8b 47 14 89 45 d4 0f 87 dc 00 00 00 41
[  335.516872] RIP: soc15_baco_program_registers+0x6c/0x180 [amdgpu] RSP: ffffaecc074a3ce8
[  335.516873] CR2:<PHONE_NUMBER>000000
[  335.516874] ---[ end trace ed08de0507622c04 ]---

I'm getting the same issue. Simply launching clinfo or any program that tries to read more than the first GPU results in an amdgpu crash (Page not present or...)
Ubuntu 18.04
Tried Kernels 4.15, 4.18, 5.0
ROCm 2.3, 2.4
Gigabyte Aorus Gaming 7 X399 (BIOS F12e)
Four Vega FEs
Disabling IOMMU in the BIOS seems to fix the issue, but I'd rather not have to resort to this.

@jamilbk Thanks you for the report.
I think IOMMU is optional for dGPUs configuration, thus we can disable IOMMU as a work around... > https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/issues/25
FYI, I have tested x299 + 2 VEGAs and it works well, thus the issue would be specific to x399.

Cannot really help, but only came here to report that 2x Vega works on my x399 platform with IOMMU enabled. So there is no fundamental problem with IOMMU + Vega + x399.
Ubuntu 18.04
Kernel 5.1 (no rock-dkms installed, probably also works with 5.0 and 4.20)
ROCm 2.4, 2.3 (probably works also with older)
TR 1950x
64GB RAM
MSI X399 SLI PLUS (Bios 7B09vA7, above 4G decoding and NUMA enabled)
2x Vega 10 XT [Radeon RX Vega 56]
# lspci -v
0c:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Vega 10 XT [Radeon RX Vega 64] (rev c3) (prog-if 00 [VGA controller])
        Subsystem: Micro-Star International Co., Ltd. [MSI] Vega 10 XT [Radeon RX Vega 64]
        Flags: bus master, fast devsel, latency 0, IRQ 91, NUMA node 0
        Memory at<PHONE_NUMBER>0 (64-bit, prefetchable) [size=8G]
        Memory at<PHONE_NUMBER>0 (64-bit, prefetchable) [size=2M]
        I/O ports at 1000 [size=256]
        Memory at e1d00000 (32-bit, non-prefetchable) [size=512K]
        Expansion ROM at e1d80000 [disabled] [size=128K]
 ...
44:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Vega 10 XT [Radeon RX Vega 64] (rev c3) (prog-if 00 [VGA controller])
        Subsystem: Advanced Micro Devices, Inc. [AMD/ATI] Vega 10 XT [Radeon RX Vega 64]
        Flags: bus master, fast devsel, latency 0, IRQ 92, NUMA node 1
        Memory at<PHONE_NUMBER>0 (64-bit, prefetchable) [size=8G]
        Memory at 47f00000000 (64-bit, prefetchable) [size=2M]
        I/O ports at 3000 [size=256]
        Memory at 8fc00000 (32-bit, non-prefetchable) [size=512K]
        Expansion ROM at 000c0000 [disabled] [size=128K]

I'm sure that my IOMMU is active since I suffer from NVMe AMD-Vi IO_PAGE_FAULT only with hardware IOMMU and fstrim/discard

@seesturm Thanks! So the problem may be related to rock-dkms(kernel 4.15) or  GIGABYTE x399 mobo, not IOMMU.
Currenly my x399 mobo is in operation with NVIDIA GPUs so I couldn't test X399 + VEGAs + upstream kernel configuration soon. Will check it at some point(June or July 2019 planned)

@seesturm Yeah that may be it. I've tried rocm-dkms on kernels 4.15 and 4.18 and having IOMMU on causes the issue for me. As soon as the 2nd (or higher) GPU is used, it crashes.
I've added amd_iommu=off to my kernel boot line so all my GPUs are working for now.
@syoyo What BIOS version are you running? Perhaps this is an issue with Gigabyte boards?

@jamilbk you can find it in dmes log
[ 4975.045839] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS XTREME/X399 AORUS XTREME-CF, BIOS F5c 10/25/2018

Has this issue been resolved?  If so, can we please close it?

Close the issue since its too old and cannot reprodce it.

Thank You!


Address Book list should use PanelItem component instead of having duplicated styles

Right now Address Book list has its own separate component to display each item. But these items has no "active" (click) effect and actually duplicates some common styles we have established in other components.

My suggestion is to reuse PanelItem component (the one used in "More" page to display Address Book list items.

@onvisions do you agree with this?

If you mean to reuse the "on click" animated effect, yes sure!

I see that spaces are bigger between Address Book list items than on prod. Is it correct?
https://github.com/user-attachments/assets/f0fa63a5-42be-46eb-bd8d-3514bfa41c28

The update implementation (tested at the link provided:https://refactor-address-book-items-use-panel-items.wallet.z52da5wt.xyz/) is approved on my side.

Fixed, LGTM


Spatie Translatable + FileUpload image won't work with RelationManager

Package
filament/spatie-laravel-translatable-plugin
Package Version
v3.2.80
Laravel Version
v11.7.0
Livewire Version
v3.4.12
PHP Version
PHP 8.3.0
Problem description
When I navigate to the edit page of a resource that uses a RelationManager, that inherits the activeLocale from the resource, in combination with the FileUpload('image)->image()->imageEditor() form schema I'm receiving the error:
Typed property Filament\Resources\RelationManagers\RelationManager::$table must not be accessed before initialization

Expected behavior
No error at all.
Steps to reproduce
Create 2 related models that both use the HasTranslations trait.
Set up a RelationManager that uses the Translatable trait in combination with the inheritance of the activeLocale described like here.
...
use Translatable;

#[Reactive]
public ?string $activeLocale = null;
...

This RelationshipManager will then be added to the relationships in the associated filament resource.
public static function getRelations(): array
   {
       return [
           RelationManagers\VariantsRelationManager::class,
       ];
   }

The parent resource that will use that RelationManger should have a FileUpload('image)->image()->imageEditor() field defined in the form schema.
 public static function form(Form $form): Form
    {
        return $form
            ->schema([
                Forms\Components\TextInput::make('title')->required(),
                Forms\Components\FileUpload::make('image')->image()->imageEditor(),
            ]);
    }

Then navigate to the EditPage of the parent resource and change the locale via the provided LocaleSwitcher action a few times. After that hit F5 to refresh the page and immediately get the error.
This error also occurs from time to time even without refreshing the page, just by navigation around different edit pages of the parent resource.
Reproduction repository
https://github.com/widdydev/filament-translatable-image-issue
Relevant log output
No response

I am posting this same message across all Spatie Translatable issues & PRs
Hey all! Wanted to update you on where we're at with the translatable plugin.
I really appreciate your patience while this issue has been active. While I created the plugin for the community, I've never actually had a project where I needed to use it, and that's the same for the rest of the Filament team. As such, it's the reason why the plugin hasn't had as much attention as the others, and is much more unstable: I just don't have the environment to test all the use cases, nor the motivation to make it truly great.
As such, I put out a post a month ago and asked who in the community uses the plugin and has knowledge of plugin development. Luckily, Lara Zeus and Mohamed Sabil stepped forward, who are both authors of popular Filament plugins and are trusted by the community.
We are strongly considering handing over maintenance of the plugin to those developers, for the good of the community. You can find their fork at https://github.com/lara-zeus/translatable.
Since the new developers have lots of experience with the plugin and active projects that use it, they should be able to help debug issues easier and make a much more stable experience for other users.
If their work goes well until v4 is released, we will likely retire the plugin at that point and recommend the fork as an official replacement. If it does not go as expected and the community is unhappy, then we will reconsider this decision. I am closing this for now, and if we decide to take maintenance back officially then we will probably reopen it.
The existing plugin will continue to receive security updates indefinitely. Please let me know if you have any further questions.
Many thanks,
Dan

this an attempt to fix the issue if anyone willing to test this PR I would appreciate the feedback.

this an attempt to fix the issue if anyone willing to test this PR I would appreciate the feedback.

Thanks @atmonshi for the attempt to fix.
I've used your fork with the latest version, but unfortunately the PR did not fix the issue.
Feel free to test/debug with my provided reproduction repository.

hey @widdydev,
can you check if this will fix your issue.
I cloned your repo and did get the error table must not be accessed before initialization
but after these changes it didnt appears, tried to refresh many times an go back and the error is gone :)

hey @widdydev, can you check if this will fix your issue. I cloned your repo and did get the error table must not be accessed before initialization
but after these changes it didnt appears, tried to refresh many times an go back and the error is gone :)

Hi @atmonshi , thanks for your effort so far.
You're right, by adding the LocaleSwitcher to the RelationManager, the error is gone. Unfortunately this is a different usecase and is not desired in that case.
In my scenario the user selects the locale on the top of the page and all the subsequent/nested models should inherit this locale and output the values in the same locale without the need to select the locale again.
According to the official docs, it is possible to achieve that by adding the reactive activeLocale attribute to the Relationship manager.


Some searches return empty price

Hi, at first: Thank you for this great API wrapper, it saved me a lot of time.
I have one issue:
I get no price for a product, when I lookup for the following products:
ASIN: B003UU6W04
https://www.amazon.de/Pak-Indien-Shop-Tilda-Basmati/dp/B003UU6W04?SubscriptionId=AKIAIXTEWKMROK5F7WEA
ASIN: B00B9B0AX6
https://www.amazon.de/Reishunger-Monster-Set-verschiedene-Getreidesorten/dp/B00B9B0AX6
ASIN: B00P07RLJ6:
https://www.amazon.de/CLAD-Shinode-Sushi-Reis-10er/dp/B007XUMWRY
"price_and_currency", "formatted_price" and "list_price" are all None. As you can see, the detail page URL shows a price, and I could order the  product.
While doing the search for getting the ASINs I call the lookup on later, I set "Availability" parameter to "Available".
Could this be a bug in the simple product api code?

I'm having this issue as well. But for me, list_price works but price_and_currency returns None None and formatted_price returns "Too Low To Display"

+1

I notice that these products are atypical for Amazon. FBM or long ship times.
2 things to consider.

If you are getting other data, then the issue is with Amazon, not the code.
Amazon may be considering these products as non-advertisable. This API is for affiliates that advertise and these products might not meet those requirements.

Did that answer your question?

Hi Jason,
not really, I get an empty price for example for that product:
https://www.amazon.de/VERO-MODA-Damen-Skinny-Vmflex/dp/B00UHA9V6W/ref=sr_1_1?s=apparel&ie=UTF8&qid=1509116857&sr=1-1&nodeID=11961464031&psd=1&keywords=damen%2Bhosen&th=1&psc=1
I get this product in the result if I search for products with the following params:
{'MerchantId': 'Amazon', 'Keywords': 'Damen Hose', 'SearchIndex': 'Apparel', 'Availability': 'Available'}
When I then do a lookup for the given ASIN, the price is empty. I do not understand, why I can`t get a price fot that prodict

Look at the following link:
https://www.amazon.de/dp/B00UHA9V6W/
When you do a lookup for that asin, this is the information you are going to receive. As you can see, there is not a specific price on the page.
I also loaded the style into Jungle Scout and they show $0 for the price.
It's not you, it's not the tool, it's Amazon.

The reason for this is because Amazon doesn't show a fixed for certain items like Clothes or Shoes. The fixed price depends on the size. You could find the price range in the 'VariationsSummary' attribute and each individual price for each size inside each item in the 'Variations' attribute.


Video

Im new to this, is there anyway someone could make a video?

please stop asking that. There are more important issues to solve

Like global warming right?


Switch iperf3 to generate a new client every time it runs a test

Description:
Generates a new Iperf3 client every time one is needed, rather than re-using the existing one. There is a race condition in the existing implementation because both the upload/download sensors start updating at the same time using the same client. Rather than saving and reusing two unique clients, it seems better to regenerate when we need to use one. Thanks to @dooz127 for tracing down the root cause.
I also added myself to CODEOWNERS for iperf3 since I have been maintaining it.
Related issue (if applicable): fixes #22163
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
iperf3:
  hosts:
    - host: bouygues.iperf.fr
  monitored_conditions:
    - download
    - upload

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Awesome. Works when I manually call the service and my latest update.


Fix leaks in HasPosition calls

Fixes #100.

Fix calls in the "HasXXX" position functions to AttributeValue without decreasing the reference of the returned object or adding it to the memory tracker which were leaking in a specific case

Added ugly warnings about the need to do that on Attribute and AttributeValue.

Added two new tests for memleaks covering the bug.

Updated the build to the latest libuast and changed URL.

Signed-off-by: Juanjo Alvarez<EMAIL_ADDRESS>

This is exactly the reason why Go does not allow type conversion of ints to bool.

And please squash commits before merging.

@dennwc not arguing that is a good feature to have, but the problem was not calling decref on the value returned by Attribute (the reason for the boolean wrapper is that I also dislike these type conversions).


Add Get Board configuration GET /rest/agile/1.0/board/{boardId}/configuration

Codecov Report

Merging #1 into master will decrease coverage by 0.86%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   68.55%   67.68%   -0.87%
==========================================
  Files           8        8
  Lines         283      294      +11
==========================================
+ Hits          194      199       +5
- Misses         49       53       +4
- Partials       40       42       +2

Impacted Files
Coverage Δ

boards.go
60.52% <45.45%> (-2.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ec16c...1722ef3. Read the comment docs.


Fix:  Composer top padding collapsed in room after scroll up

Details

If it's multi-user chatroom or concierge room composer top padding was collapsed in room after scroll up. I updated styling of ReportFooter and ReportActionsList components.
Fixed Issues

$ https://github.com/Expensify/App/issues/22389
PROPOSAL: https://github.com/Expensify/App/issues/22389#issuecomment-1625970966
Tests

Test 1

Go to a  private room with any user
add some chats until we can scroll up the screen
Scroll to the bottom and scroll up
Turn off your network connection
Scroll to the bottom and scroll up

Test 2

Go to the announce room of your workspace
add some chats until we can scroll up the screen
Scroll to the bottom and scroll up
Delete your workspace, this will mark announce room as archived
Go to the archived announce room.
Scroll to the bottom and scroll up
Turn off your network connection
Scroll to the bottom and scroll up

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as "Tests" Section above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/1360242/e1127573-4971-4ae6-8f82-33b48320787f

Mobile Web - Chrome

https://github.com/Expensify/App/assets/1360242/6fba3690-4f7c-4aa3-a425-dc8abc004e45

Mobile Web - Safari

https://github.com/Expensify/App/assets/1360242/9b21afec-b796-4cb3-a527-a1c29a465bd6

Desktop

https://github.com/Expensify/App/assets/1360242/630a7727-e56f-4090-8312-da1c3829d22d

iOS

https://github.com/Expensify/App/assets/1360242/cb8369b4-9192-4d39-a074-252856bf2805

Android

https://github.com/Expensify/App/assets/1360242/b927f0d4-530e-459c-a3e3-3d51933f9e18

@situchan @marcaaron #22389 . I will upload screencast for iOS, Android and mobile Chrome soon

Uploaded last videos for iOS, Android and web mobile Chrome. Ready for review

@situchan

Fixed MentionSuggestions position

Removed gap under report list with hidden composer

Thanks for review @mkhutornyi! So the ball is on your side @situchan ;)

@mkarkachov Not sure what to verify. Please add "Verify that ..." at the end of Tests step

Go to a private room with any user

This should be public room. Any user cannot access private room

@mkarkachov please add all possible cases in Tests step:

DM (which shows local time)
Any group chat
Public room where comment is allowed
Public room where comment is not allowed
Archived room
Anonymous user visiting public room

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/108292595/840c34ce-baa7-4c84-a71e-4694d17965c2
https://github.com/Expensify/App/assets/108292595/177f051a-ad8c-4319-bbbf-4cc418a182fc
https://github.com/Expensify/App/assets/108292595/6881c2d6-6dc5-4201-8fd0-91d045b46550

Mobile Web - Chrome
https://github.com/Expensify/App/assets/108292595/86d0a1a2-7e44-492b-ab48-9124edf79d34

Mobile Web - Safari
https://github.com/Expensify/App/assets/108292595/d0c62ff2-945e-4405-8916-a97e2eb8893f

Desktop
https://github.com/Expensify/App/assets/108292595/af4f580b-d386-42bf-811c-b271c405ce7a

iOS
https://github.com/Expensify/App/assets/108292595/fb1bf63c-6873-4c4e-93fd-beca0668dce1

Android
https://github.com/Expensify/App/assets/108292595/9f984078-f444-420e-ab79-d498f8770aab

@mkarkachov please update Tests steps as I request changes - https://github.com/Expensify/App/pull/23992#issuecomment-1663039092, https://github.com/Expensify/App/pull/23992#issuecomment-1663060093.
And then all good.

@mkarkachov please update Tests steps as I request changes - #23992 (comment), #23992 (comment).
And then all good.

@situchan Added more tests and edited old ones

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


On laravel 5.2

hi, please update it to laravel 5.2 .

Can pull in v3.0 for Laravel 5.2 support~

Can pull in v3.0 for Laravel 5.2 support~


gflops & params

Do u calculate your plainvit_base448 model for gflops and params?
I have calculated it, but I am not sure whether is it accuracy.

Hi please refer to issue #14


WIP: Replace maven_jar with maven_install

This should fix building this repo with Bazel@HEAD (and the upcoming Bazel 2.0 version).
Context: https://github.com/bazelbuild/bazel/issues/6799
Description

Replace native maven_jar rules with maven_install from https://github.com/bazelbuild/rules_jvm_external.
See https://github.com/bazelbuild/rules_jvm_external/blob/master/README.md

Motivation

Bazel 2.0 will remove support for the native maven_jar rule. Bazel@HEAD can no longer run bazel info in this repo because of the maven_jar rules in the WORKSPACE.

This breaks //third_party/dependency_analyzer/src/test:dependency_analyzer_test, haven't yet foudn out why.

Do you know @jin is already working on replacing maven jar here?

@laszlocsomor Hey, thanks for this PR! I'm working on extending the migration tooling in rules_jvm_external to target jvm_maven_import_external instead of maven_install instead. See https://github.com/bazelbuild/rules_scala/pull/871 for more details.

Thank you both, I wasn't aware. Thanks Jin for working on this! I'll revert this PR.


Is Swarm ready for production?

Hello.
The idea of Swarm is absolutely stunning, I can't wait for Swarm to become something like PouchDB from the user's point of view. The ideas behind Swarm is amazing, but PouchDB has tutorials, handy admin panel, great api and code examples.
Is Swarm stable and ready for production? Can I use it today for production apps?
Are there any tutorials or code examples?

Hi Miloslav!
Swarm.js is certainly not ready for production.
This particular repo contains abandoned code of historical value mostly.
But, thank you for the kind words!
We are working to improve the situation.

But why it's needed to abandon Swarm then? And where to look for the tool that might replace Swarm?

This particular codebase is abandoned.
We plan to replace it with the new code once the new js client is ready.
The new swarmdb server is golang anyway.


Create CI jobs for building & testing nikos

Note: the Build nikos job is expected to fail right now - the changes in https://github.com/DataDog/nikos/pull/7 will fix this


Update ciphersuites with old drafts + new AEGIS

Update the extract-inana-ciphers2.py script to include an old RFC + other old ciphers
Running that script again includes new TLS ciphersuites: TLS_{SHA256,SHA384} and AEGIS-based ones

Applied, thanks!


Error  when run jsc files

i compiled below code by bytenode CLI : bytenode --compile test.js
console.log("test!!!");
and when i run test.jsc output file by bytenode test.jsc in CLI i get below error:
C:\Users\saleh mosleh\AppData\Roaming\npm\node_modules\bytenode\index.js:179
    dummyCode = '"' + "\u200b".repeat(length - 2) + '"'; // "\u200b" Zero width space
                               ^

RangeError: Invalid string length
    at String.repeat (native)
    at Object.Module._extensions.(anonymous function) [as .jsc] (C:\Users\saleh mosleh\AppData\Roaming\npm\node_modules\bytenode\index.js:179:32)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:607:3

Works for me... please can you share

exactly what platform and version of Node.js you are using
exactly what version of bytenode you are using

@s100 , i'm using windows 10 with below  node and bytenode version:
E:\nodejs\organchart-elc>node -v
v8.6.0
E:\nodejs\organchart-elc>npm -v
6.14.4
E:\nodejs\organchart-elc>bytenode -v
bytenode 1.1.6

Yes, exactly same.

I have duplicated your issue. I think the problem you're having is very likely to be due to the mismatch between the levels of Node.js and npm you're using. Node.js v8.6.0 shipped with npm v5.3.0 - it actually took some effort for me to reproduce this environment since nvm won't do it. npm version 6.14.4, by comparison, shipped with Node.js 13.12.0, barely a month and a half ago. Your steps work for me with both of those combinations.
Additionally, Node.js v8.x.x ended long term support on 31 December 2019. So I suggest upgrading to a supported version of Node.js and trying again.

@s100 , thank you, i updated nodeJS and it works fine!


How to save map as an image?

From @Igor-Morozov on September 23, 2015 13:56
Is there a way to save the map as an image? Or how can I use leaflet-image plugin https://github.com/mapbox/leaflet-image?
Copied from original issue: tombatossals/angular-leaflet-directive#956

Has anyone been able to convert the map to an image?


Move debug stop at height to the zebrad start main loop

Motivation
Currently, the debug stop at height config is implemented in the state service. But this makes shutdown difficult.
It would be better if we checked the stop conditions as part of the start command run loop in zebrad.
Related Work
This change will be easier after we add a task that stops the full sync in:

#1592

Hey team! Please add your planning poker estimate with ZenHub @gustavovalverde @dconnolly @conradoplg @jvff @oxarbitrage @teor2345 @upbqdn

@jvff do you mind if I close this ticket?
The current code seems to work, and it's totally unrelated to the light wallet epic.

Yeah, I think we will probably not need this any time soon.


SSR with NEXT js 12.1.5 does not work

I have a NextJS application and I migrated to MUI5 just recently. Things worked really well with tss-react but I saw some slowness in client side rendered pages. I put in the StyledEngineProvider and that fixed it, but having CacheProvider and StyledEngineProvider together brought an FOUC page on load and SSR seems to be broken. I followed instructions on https://docs.tss-react.dev/ssr/next.js#mui-and-tss-use-different-caches but it seems to require NextJS 12.1.7 or higher. They have some middleware changes I cannot do now, so is there a way I can may MUI5 Work well with NextJS 12.1.5 and tss-react in my application? I have implemented all code changes and the application comes up with no errors, just that SSR does not work still.

Sorry it was my mistake.. It works fine

Does it?
It's to my surprise. But allright.


Visualize not working, when writing to csv file

Hello,
I want to visualize this execution graph.
import dask

df = dask.datasets.timeseries(freq="10min", partition_freq="5d")
tasks = list()
for name in ["Dan", "Victor"]:
    tasks.append(
        df[df["name"] == name]
        # .to_csv(name, compute=False)
    )
dask.visualize(tasks)

Unfortunately, when uncommenting the "to_csv"-function nothing shows up. The execution works fine. I'm using dask 2.14.0.
It is not just a visualization problem. When serializing the graph to a file, the file is empty. However it visualizes tasks[0] just fine.
Greetings
Julian

Thanks for the nice minimal example @JulianWgs, I'm able to reproduce the behavior you're describing. In your example, with the to_csv portion uncommented, tasks is a nested list of Delayed objects
In [1]: import dask
   ...:
   ...: df = dask.datasets.timeseries(freq="10min", partition_freq="5d")
   ...: tasks = list()
   ...: for name in ["Dan", "Victor"]:
   ...:     tasks.append(
   ...:         df[df["name"] == name].to_csv(name, compute=False)
   ...:     )
   ...: dask.visualize(tasks)
Out[1]: <IPython.core.display.Image object>

In [2]: tasks
Out[2]:
[[Delayed('_write_csv-98040538-07c5-48d8-a038-857e16ee1ac2'),
  Delayed('_write_csv-f281a022-a874-404a-81f9-8bbbdf04ad0b'),
  Delayed('_write_csv-45325d3b-b5fe-4761-b076-d04834c59b7e'),
  Delayed('_write_csv-cab7bba7-d633-4432-9240-23054277cdc7'),
  Delayed('_write_csv-d562a946-ba67-4bf3-847e-d099bd1497d1'),
  Delayed('_write_csv-49a8d34b-e32d-4d0c-9fa4-cc1dd396da42')],
 [Delayed('_write_csv-ef8fe226-5086-4f21-87fe-435daf2a2489'),
  Delayed('_write_csv-021dccd6-73f5-42d9-b0ab-6fe1d3363f1b'),
  Delayed('_write_csv-c6625f1c-7c75-4408-b523-0ab06255e3e6'),
  Delayed('_write_csv-2dfb00be-0bd7-4036-817e-f28ffe8f85e6'),
  Delayed('_write_csv-7ff9aa5e-f539-4fad-aa29-c978a8901301'),
  Delayed('_write_csv-458d603b-8a69-4718-8c8b-e5d6d2ea3eed')]]

But from the dask.visualize, the visualize function is expecting dask collection(s) passed in as *args arguments. So if you modify the visualize call to be dask.visualize(*tasks), then things should work.

When serializing the graph to a file, the file is empty.

I suspect this is from using compute=False in the to_csv call

You're welcome. The least I can do ^^ Thanks for the fast answer! You are correct, that this shows the graph.

But now there 12 single graphs (for the 2 names and 6 partitions). Comparing this to the graph without the to_csv, which has only 6 single graphs and shares the results of the previous computation. This is the same with optimize_graph turned on.

I haven't done any performance tests, but will check if the same compution is done twice.
Greetings
Julian

# little flatten function, which is more robust than "*tasks"
def flatten(nested_list, flattened_list=None):
    if flattened_list is None:
        flattened_list = list()
    # recursively call flatten if nested_list is a list
    if isinstance(nested_list, list):
        for item in nested_list:
            flattened_list = flatten(item, flattened_list)
    # append to flattened list, when nested_list is not a list
    else:
        flattened_list.append(nested_list)
    return flattened_list

%%timeit
import dask

df = dask.datasets.timeseries(freq="10min", partition_freq="1d")
tasks = list()
for name in ["Dan", "Victor", "Norbert", "Kevin", "Patricia", "Michael", "Charlie", "Ray"]:
    tasks.append(
        df[df["name"] == name]
        #.to_csv(name, compute=False)
    )
dask.compute(flatten(tasks), optimize_graph=True)

Without to_csv: 646 ms ± 145 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
With to_csv: 1.67 s ± 25 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
240 files had to be written with a total size of 592 KB on disk (For all runs).
I think, that this proofs, that the same compution is being done multiple times.

I could get correct the correct graph in my actual usecase by using dask.visualize(collections_to_dsk(flatten(tasks)), optimize_graph=True), but I can't reproduce it in the minimum working example. Also pandas has a flatten function for arbitrary nested lists: from pandas.core.common import flatten

I think the original issue of how to visualize has been resolved.  I am little confused issue of duplicate computation you are bringing up but from my reading of I think you want to be calling to_csv only once.  As it stand now you are calling it twice, once for each name.
Perhaps you want something like:

df[(df["name"] == 'alpha') | (df["name"] == 'beta')].to_csv(name, compute=False)

Where all the filtering is done prior to calling to_csv ?

@quasiben Thanks for the reply!
The use case is to save a csv file for every name (or more general filter operation). So the to_csv should be appended to every filtering operation in the graph, but it somehow splits it into several graphs. I know that this discussion does not resemble the original issue perfectly, but still the to_csv does something to the graph which any other non file related operation does not.
My benchmark might not proof the incorrect graph, but counting the number of tasks shows a difference in the amount of actual and theoretical tasks.
These are my calculation for the number of tasks
# (make-timeseries per partition) + getitem per npartion and len(names) + (additional getitem per partition)
print("Without to_csv:", df.npartitions + df.npartitions*len(names) + df.npartitions)
# just add a to_csv per partition and name
print("Theoretical to_csv:", df.npartitions + df.npartitions*len(names)*2 + df.npartitions)
# Having three operation per partition and name (make-timeseries, getitem, to_csv)
# make-timeseries should only be called once per partition
print("With to_csv:", df.npartitions*(len(names))*3)
# Use my flatten function
print(len(collections_to_dsk(flatten(tasks))))

Do you want me to rename the issue, open a new one or is it OK like it is?
Greetings

I suspect what you are seeing here is how dask is optimizing for both the creation of data and the to_csv call.  If you cut off the graph after creation (calling persist()) I believe you get a more reasonable graph:
In [8]: df = df.persist()

In [9]: for name in ["Dan", "Victor"]:
   ...:     tasks.append(
   ...:         df[df["name"] == name].to_csv(name+'.csv', compute=False)
   ...:         )
   ...:

In [10]: dask.visualize(*tasks, optimize_graph=True, filename='to-csv.png', verbose=True)

As a separate comment, this will create 6 CSVs per filter, not a single csv.  For that you will need to pass in single_file=True

Thank you for your help. This solves my problem :) Feel free to close this issue.
However I still think that this is not an obvious way to do it and the behavior is unexpected. For what reason should dask optimize if it is not told to do so? Also it is unexpected to have to switch the dask.visualize call in order draw the graph with or without the to_csv. I still think this is worth investigating.

Thanks for the feedback @JulianWgs .  If you have concrete thoughts on how to improve dask please come and share and of course if you have other problems please open up other issues


Need code for working example

We are currently in the final stages of adjustments for our demo and are excited to announce that we will be making our project available on Hugging Face Spaces next week. Stay tuned for the official release, and we appreciate your anticipation and support!

We have open-sourced the Demo Local Deployment Code with a Setup Guide.