skip_lines payload difference across verions

Hello.
In our project we are using following strategy to skip some lines having only , content.
CSV.open(file, 'r', skip_lines: /^,+$/)

During update to Ruby 2.7 some specs related to this failed since it wasn't skipping lines properly. I have found out the difference is that RegExp is matched against whole line now including newline character for example. I was able to bisect the problem to https://github.com/ruby/csv/commit/39da059c6d363136a80867a6cdb7f2ac42e48ecc using this reproducing script:
require 'test/unit'
require 'timeout'
require_relative '../../lib/csv'
class TestCSVRegress < Test::Unit::TestCase
  def setup
    super
    @sample_data = <<-CSV
line,1,abc
line,2,"def\nghi"

line,4,jkl
    CSV
  end

  def test_line_trash
    csv = CSV.new(@sample_data, :skip_lines => Class.new do
      $lines = []
      def self.match(line)
        $lines << line
      end
    end
                 )

    Timeout.timeout(0.1) do # this is needed to bandaid infinite loop bug in some csv versions
      csv.count # do something to iterate over the file

      assert_equal($lines, ["line,1,abc", "line,2,\"def", "ghi\"", "line,4,jkl"])
    end
  end
end

This spec is passing at v3.0.1 tag, but fails on current master with
[retro@retro  csv (master $%=)]❤ ruby -Itest test/csv/test_regress.rb
Loaded suite test/csv/test_regress
Started
F
==============================================================================================================================================================================================
test/csv/test_regress.rb:25:in `test_line_trash'
     22:     end
     23:                  )
     24:
  => 25:     timeout(0.1) do
     26:       csv.count # do something to iterate over the file
     27:
     28:       assert_equal($lines, ["line,1,abc", "line,2,\"def", "ghi\"", "line,4,jkl"])
/home/retro/.rubies/ruby-2.5.7/lib/ruby/2.5.0/timeout.rb:122:in `timeout'
/home/retro/.rubies/ruby-2.5.7/lib/ruby/2.5.0/timeout.rb:108:in `timeout'
/home/retro/.rubies/ruby-2.5.7/lib/ruby/2.5.0/timeout.rb:33:in `catch'
/home/retro/.rubies/ruby-2.5.7/lib/ruby/2.5.0/timeout.rb:33:in `catch'
/home/retro/.rubies/ruby-2.5.7/lib/ruby/2.5.0/timeout.rb:33:in `block in catch'
/home/retro/.rubies/ruby-2.5.7/lib/ruby/2.5.0/timeout.rb:93:in `block in timeout'
test/csv/test_regress.rb:28:in `block in test_line_trash'
<["line,1,abc\n", "line,2,\"def\n", "ghi\"\n", "\n", "line,4,jkl\n"]> expected but was
<["line,1,abc", "line,2,\"def", "ghi\"", "line,4,jkl"]>

diff:
? ["line,1,abc\n", "line,2,\"def\n", "ghi\"\n", "\n", "line,4,jkl\n"]
Failure: test_line_trash(TestCSVRegress)
==============================================================================================================================================================================================

Finished in 0.005389607 seconds.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 tests, 1 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
0% passed
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
185.54 tests/s, 185.54 assertions/s

For now I have introduced custom class to strip the "payload" and do the check on top of that.
class Skipper
  EMPTY_LINE = /^,+$/.freeze

  def match(line)
    line.strip.match?(EMPTY_LINE)
  end
end

CSV.open(file, mode, skip_lines: Skipper.new)

Anyway this seems like side-effect of mentioned change and unwanted behaviour change. I suggest to at least add spec for the payload, but I'm not sure which behaviour is intended (with/without newline character included).

/^,+$/ matches to both ",\n" and ",":
p(/^,+$/.match?(",\n")) # -> true
p(/^,+$/.match?(","))   # -> true

Are you really using /^,+$/?

@kou Yes.
Feel free to try with this testing file.
https://gofile.io/d/91CkpE
Using v3.0.1 CSV with Ruby 2.5.7 in csv repo root:
irb(main):001:0> require_relative 'lib/csv'
=> true
irb(main):002:0> CSV.open('test-organizations.csv', 'r', {headers: true, skip_blanks: true, skip_lines: /^,+$/}).map(&:itself).count
=> 16

Using v3.0.1 CSV with Ruby 2.7.2 in csv repo root:
irb(main):001:0> require_relative 'lib/csv'
=> true
irb(main):002:0> CSV.open('test-organizations.csv', 'r', {headers: true, skip_blanks: true, skip_lines: /^,+$/}).map(&:itself).count
/home/retro/code/work/FUGA/git/csv/lib/csv.rb:652: warning: Using the last argument as keyword parameters is deprecated
=> 16

Using master CSV with Ruby 2.7.2 in csv repo root:
irb(main):001:0> require_relative 'lib/csv'
=> true
irb(main):002:0> CSV.open('test-organizations.csv', 'r', {headers: true, skip_blanks: true, skip_lines: /^,+$/}).map(&:itself).count
=> 44

Using master CSV with Ruby 2.5.7 in csv repo root:
irb(main):001:0> require_relative 'lib/csv'
=> true
irb(main):002:0> CSV.open('test-organizations.csv', 'r', {headers: true, skip_blanks: true, skip_lines: /^,+$/}).map(&:itself).count
=> 44

Ah, you're using "\r\n".
Fixed.

@kou thanks for the fix. I can confirm it works now.


Test failure: CheckStdoutWithLargeWrites

This test fails occasionally with the following error:
System.AggregateException : One or more errors occurred. (dotnet publish exited with exit code : 1) (Object reference not set to an instance of an object.)
---- System.Exception : dotnet publish exited with exit code : 1
---- System.NullReferenceException : Object reference not set to an instance of an object.
----- Inner Stack Trace #1 (System.Exception) -----
   at Microsoft.AspNetCore.Server.IntegrationTesting.ApplicationPublisher.Publish(DeploymentParameters deploymentParameters, ILogger logger)
   at Microsoft.AspNetCore.Server.IntegrationTesting.CachingApplicationPublisher.Publish(DeploymentParameters deploymentParameters, ILogger logger)
   at Microsoft.AspNetCore.Server.IntegrationTesting.ApplicationDeployer.DotnetPublish(String publishRoot)
   at Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer.DeployAsync() in /_/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS/IISExpressDeployer.cs:line 60
   at Microsoft.AspNetCore.Server.IntegrationTesting.FunctionalTestsBase.DeployAsync(IISDeploymentParameters parameters) in /_/test/Common.FunctionalTests/Utilities/FunctionalTestsBase.cs:line 37
   at Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.StartupExceptionTests.CheckStdoutWithLargeWrites(String path) in /_/test/Common.FunctionalTests/Inprocess/StartupExceptionTests.cs:line 59
--- End of stack trace from previous location where exception was thrown ---
----- Inner Stack Trace #2 (System.NullReferenceException) -----
   at Microsoft.AspNetCore.Server.IntegrationTesting.ApplicationDeployer.CleanPublishedOutput()
   at Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer.Dispose(Boolean gracefulShutdown) in /_/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS/IISExpressDeployer.cs:line 419
   at Microsoft.AspNetCore.Server.IntegrationTesting.FunctionalTestsBase.Dispose() in /_/test/Common.FunctionalTests/Utilities/FunctionalTestsBase.cs:line 42
   at ReflectionAbstractionExtensions.DisposeTestClass(ITest test, Object testClass, IMessageBus messageBus, ExecutionTimer timer, CancellationTokenSource cancellationTokenSource) in C:\Dev\xunit\xunit\src\xunit.execution\Extensions\ReflectionAbstractionExtensions.cs:line 76
------- Stdout: -------
| [0.003s] TestLifetime Information: Starting test CheckStdoutWithLargeWrites-CheckOversizedStdOutWrites at 2018-08-23T00:24:37
| [0.004s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Information: Deploying [Variation] :: ServerType=IISExpress, Runtime=CoreClr, Arch=x64, BaseUrlHint=, Publish=True
| [0.004s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Information: Executing command dotnet publish  --output "C:\b\t\buildTmp\d852b0e9f9ab4cfd9a90369542598500" --framework netcoreapp2.2 --configuration Release --no-restore -p:VerifyMatchingImplicitPackageVersion=false
| [0.222s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Information: dotnet-publish stdout: Microsoft (R) Build Engine version 15.8.166+gd4e8d81a88 for .NET Core
| [0.222s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Information: dotnet-publish stdout: Copyright (C) Microsoft Corporation. All rights reserved.
| [1.615s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Information: dotnet-publish stdout:   TestTasks -> C:\b\w\33bdfc1cae7b2a38\modules\IISIntegration\test\TestTasks\bin\Release\netcoreapp2.2\TestTasks.dll
| [1.691s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Information: dotnet-publish stdout: C:\b\w\33bdfc1cae7b2a38\.packages\internal.aspnetcore.sdk\2.2.0-preview1-20180807.2\build\GenerateAssemblyInfo.targets(25,5): error MSB4062: The "Microsoft.AspNetCore.BuildTools.Sdk_GetAssemblyFileVersion" task could not be loaded from the assembly C:\b\w\33bdfc1cae7b2a38\.packages\internal.aspnetcore.sdk\2.2.0-preview1-20180807.2\build\..\tools\netcoreapp2.1\Internal.AspNetCore.Sdk.dll. Assembly with same name is already loaded Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\b\w\33bdfc1cae7b2a38\modules\IISIntegration\src\Microsoft.AspNetCore.Server.IIS\Microsoft.AspNetCore.Server.IIS.csproj]
| [1.725s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Error: dotnet publish exited with exit code : 1
| [1.725s] Microsoft.AspNetCore.Server.IntegrationTesting.IIS.IISExpressDeployer Warning: Host process already exited or never started successfully.

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
This test failed on 2.2.
CC @muratg
This issue was made automatically. If there is a problem contact ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

Is this actually a flaky test?

No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
Yes, proceed below...

Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

[ ] File a bug against the product (TODO: Link to other bug)
Is it possible to change the test to avoid the flakiness?

Yes? Go to the "Change the test!" section.
No?

[ ] Disable the test (TODO: Link to PR/commit)
[ ] Wait for other bug to be resolved
[ ] Wait for us to get build that has the fix
[ ] Re-enable our test (TODO: Link to PR/commit)
[ ] Close this bug

Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

Is there is a way to change our test to avoid this flakiness?

Yes? Change the test!

[ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
[ ] Run the test 100 times locally as a sanity check.
[ ] Close this bug

No?

Is there any logging or extra information that we could add to make this more diagnosable when it happens again?

Yes?

[ ] Add the logging (TODO: Link to PR/commit)

No?

[ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact ryanbrandenburg.

CheckStdoutWithLargeWrites failed with about the same error on 2.2.
This comment was made automatically. If there is a problem contact ryanbrandenburg.

CheckStdoutWithRandomNumber failed with about the same error on 2.2.
This comment was made automatically. If there is a problem contact ryanbrandenburg.

Gets500_30_ErrorPage failed with about the same error on 2.2.
This comment was made automatically. If there is a problem contact ryanbrandenburg.

CheckStdoutWithLargeWrites failed with about the same error on 2.2.
This comment was made automatically. If there is a problem contact ryanbrandenburg.


expired urls for WIT retrieval dataset

Hi,
I use the img2dataset tool to download the WIT images, some urls are expired and the corresponding images are not available. Can you provide the original image files of the WIT part for downloading? Thanks a lot.

Hi,
Thanks for pointing this out and reminding me of the missing images.
I will have some time to look into this next week.
If you don't want to wait for me, you can download all the data from the Kaggle competition and select the images based on the image_url field.

OK. Got it.
Many thanks.


Fixed links

:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/apps/apps-overview.md
:warning:Warning

Details

msteams-platform/concepts/bots/bots-context.md
:warning:Warning

Details

msteams-platform/concepts/bots/bots-create.md
:warning:Warning

Details

msteams-platform/concepts/bots/bots-test.md
:warning:Warning

Details

msteams-platform/concepts/cards-actions.md
:warning:Warning

Details

msteams-platform/concepts/compose-extensions.md
:warning:Warning

Details

msteams-platform/concepts/tabs/tabs-configuration.md
:warning:Warning

Details

msteams-platform/concepts/tabs/tabs-static.md
:warning:Warning

Details

msteams-platform/get-started/get-started.md
:warning:Warning

Details

msteams-platform/overview.md
:warning:Warning

Details

msteams-platform/publishing/apps-package.md
:warning:Warning

Details

msteams-platform/reference/general/debug.md
:warning:Warning

Details

msteams-platform/scenarios/bots-channel-conversations.md
:warning:Warning

Details

msteams-platform/scenarios/bots-personal-conversations.md
:warning:Warning

Details

msteams-platform/troubleshoot/troubleshoot.md
:warning:Warning

Details

msteams-platform/concepts/apps/apps-overview.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 29: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 30: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 30: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 31: [Warning] Invalid file link:(~/concepts/connectors).
Line 32: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 33: [Warning] Invalid file link:(~/concepts/custom-bot).
Line 41: [Warning] Invalid file link:(~/get-started/get-started-dotnet).
Line 42: [Warning] Invalid file link:(~/get-started/get-started-nodejs).
Line 48: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).
Line 85: [Warning] Invalid file link:(~/reference/design/framework/basics).
Line 87: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 88: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 89: [Warning] Invalid file link:(~/concepts/connectors).
Line 90: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 91: [Warning] Invalid file link:(~/concepts/activity-feed).
Line 93: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 94: [Warning] Invalid file link:(~/publishing/apps-publish).

msteams-platform/concepts/bots/bots-context.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 23: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#bot-or-user-added-to-a-team).
Line 119: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#bot-or-user-added-to-a-team).

msteams-platform/concepts/bots/bots-create.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 25: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 25: [Warning] Invalid file link:(~/publishing/apps-package).
Line 26: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 27: [Warning] Invalid file link:(~/publishing/apps-publish).

msteams-platform/concepts/bots/bots-test.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 13: [Warning] Invalid file link:(~/get-started/get-started).
Line 17: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 17: [Warning] Invalid file link:(~/publishing/apps-package).
Line 19: [Warning] Invalid file link:(~/concepts/bots/bots-notifications).
Line 59: [Warning] Invalid file link:(~/assets/images/bot/botdisable.png).
Line 77: [Warning] Invalid file link:(~/publishing/apps-publish).

msteams-platform/concepts/cards-actions.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 12: [Warning] Invalid file link:(~/concepts/cards-actions#hero-card).
Line 12: [Warning] Invalid file link:(~/concepts/cards-actions#hero-card).
Line 13: [Warning] Invalid file link:(~/concepts/cards-actions#thumbnail-card).
Line 13: [Warning] Invalid file link:(~/concepts/cards-actions#thumbnail-card).
Line 61: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 61: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 76: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 76: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 85: [Warning] Invalid file link:(~/concepts/connectors#using-office-365-connector-cards-in-microsoft-teams).
Line 85: [Warning] Invalid file link:(~/concepts/connectors#using-office-365-connector-cards-in-microsoft-teams).
Line 92: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 92: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).

msteams-platform/concepts/compose-extensions.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 31: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 37: [Warning] Invalid file link:(~/concepts/bots/bots-create).
Line 43: [Warning] Invalid file link:(~/reference/schema/manifest-schema#composeextensions).
Line 141: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 204: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#receiving-messages).
Line 273: [Warning] Invalid file link:(~/concepts/cards-actions).
Line 273: [Warning] Invalid file link:(~/concepts/connectors#using-office-365-connector-cards-in-microsoft-teams).
Line 410: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).
Line 414: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).

msteams-platform/concepts/tabs/tabs-configuration.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/publishing/apps-package).
Line 13: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).
Line 79: [Warning] Invalid file link:(~/reference/general/requirements).
Line 89: [Warning] Invalid file link:(~/concepts/tabs/tabs-context).
Line 89: [Warning] Invalid file link:(~/concepts/authentication).
Line 97: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 101: [Warning] Invalid file link:(~/concepts/deep-links).
Line 102: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 102: [Warning] Invalid file link:(~/concepts/tabs/tabs-update-remove).
Line 105: [Warning] Invalid file link:(~/reference/schema/manifest-schema).
Line 105: [Warning] Invalid file link:(~/reference/general/cross-domain).
Line 109: [Warning] Invalid file link:(~/concepts/tabs/tabs-update-remove#removing-a-tab).
Line 121: [Warning] Invalid file link:(~/troubleshoot/troubleshoot).

msteams-platform/concepts/tabs/tabs-static.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 17: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 21: [Warning] Invalid file link:(~/reference/schema/manifest-schema#statictabs).
Line 23: [Warning] Invalid file link:(~/publishing/apps-package).
Line 52: [Warning] Invalid file link:(~/concepts/deep-links).
Line 60: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).

msteams-platform/get-started/get-started.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 59: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 63: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 73: [Warning] Invalid file link:(~/concepts/apps/apps-overview).
Line 74: [Warning] Invalid file link:(~/get-started/design).
Line 75: [Warning] Invalid file link:(~/get-started/code).
Line 76: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 77: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 78: [Warning] Invalid file link:(~/concepts/connectors).
Line 79: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 80: [Warning] Invalid file link:(~/concepts/activity-feed).
Line 84: [Warning] Invalid file link:(~/publishing/apps-package).
Line 85: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 86: [Warning] Invalid file link:(~/reference/general/debug).
Line 90: [Warning] Invalid file link:(~/publishing/apps-publish).
Line 91: [Warning] Invalid file link:(~/concepts/deep-links).
Line 95: [Warning] Invalid file link:(~/troubleshoot/troubleshoot).

msteams-platform/overview.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 15: [Warning] Invalid file link:(~/get-started/get-started#1-set-up-your-office-365-tenant).
Line 26: [Warning] Invalid file link:(~/concepts/apps/apps-overview#scopes-in-microsoft-teams).
Line 40: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 54: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 62: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 68: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 72: [Warning] Invalid file link:(~/assets/images/composeextension/ceoverviewexample.png).
Line 76: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 84: [Warning] Invalid file link:(~/concepts/connectors).
Line 97: [Warning] Invalid file link:(~/concepts/custom-bot).
Line 103: [Warning] Invalid file link:(~/feedback).

msteams-platform/publishing/apps-package.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 20: [Warning] Invalid file link:(~/reference/schema/manifest-schema).
Line 58: [Warning] Invalid file link:(~/troubleshoot/troubleshoot).

msteams-platform/reference/general/debug.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 12: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 12: [Warning] Invalid file link:(~/publishing/apps-package).
Line 13: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 13: [Warning] Invalid file link:(~/publishing/apps-package).
Line 54: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).
Line 62: [Warning] Invalid file link:(~/publishing/apps-package).
Line 63: [Warning] Invalid file link:(~/concepts/apps-sideload).

msteams-platform/scenarios/bots-channel-conversations.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 11: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 11: [Warning] Invalid file link:(~/publishing/apps-package).
Line 21: [Warning] Invalid file link:(~/concepts/apps/apps-overview).
Line 31: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#teams-channel-data).
Line 71: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#team-member-or-bot-addition).
Line 73: [Warning] Invalid file link:(~/scenarios/bots-personal-conversations#starting-a-11-conversation).
Line 73: [Warning] Invalid file link:(~/concepts/bots/bots-context#fetching-the-team-roster).
Line 135: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 219: [Warning] Invalid file link:(~/concepts/bots/bots-context).

msteams-platform/scenarios/bots-personal-conversations.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations).
Line 21: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#team-member-or-bot-addition).
Line 21: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations).
Line 21: [Warning] Invalid file link:(~/concepts/bots/bots-context#fetching-the-team-roster).

msteams-platform/troubleshoot/troubleshoot.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 13: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 15: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 21: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).
Line 49: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).
Line 53: [Warning] Invalid file link:(~/concepts/authentication).
Line 65: [Warning] Invalid file link:(~/get-started/get-started#enable-sideloading-of-bots-and-tabs).
Line 69: [Warning] Invalid file link:(~/concepts/app-sideload).
Line 77: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations#mentions).
Line 93: [Warning] Invalid file link:(~/reference/schema/manifest-schema#developer).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/apps/apps-overview.md
:warning:Warning

Details

msteams-platform/concepts/bots/bots-context.md
:warning:Warning

Details

msteams-platform/concepts/bots/bots-create.md
:warning:Warning

Details

msteams-platform/concepts/bots/bots-test.md
:warning:Warning

Details

msteams-platform/concepts/cards-actions.md
:warning:Warning

Details

msteams-platform/concepts/compose-extensions.md
:warning:Warning

Details

msteams-platform/concepts/tabs/tabs-configuration.md
:warning:Warning

Details

msteams-platform/concepts/tabs/tabs-static.md
:warning:Warning

Details

msteams-platform/get-started/get-started.md
:warning:Warning

Details

msteams-platform/overview.md
:warning:Warning

Details

msteams-platform/publishing/apps-package.md
:warning:Warning

Details

msteams-platform/reference/general/debug.md
:warning:Warning

Details

msteams-platform/scenarios/bots-channel-conversations.md
:warning:Warning

Details

msteams-platform/scenarios/bots-personal-conversations.md
:warning:Warning

Details

msteams-platform/troubleshoot/troubleshoot.md
:warning:Warning

Details

msteams-platform/concepts/apps/apps-overview.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 29: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 30: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 30: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 31: [Warning] Invalid file link:(~/concepts/connectors).
Line 32: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 33: [Warning] Invalid file link:(~/concepts/custom-bot).
Line 41: [Warning] Invalid file link:(~/get-started/get-started-dotnet).
Line 42: [Warning] Invalid file link:(~/get-started/get-started-nodejs).
Line 48: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).
Line 85: [Warning] Invalid file link:(~/reference/design/framework/basics).
Line 87: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 88: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 89: [Warning] Invalid file link:(~/concepts/connectors).
Line 90: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 91: [Warning] Invalid file link:(~/concepts/activity-feed).
Line 93: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 94: [Warning] Invalid file link:(~/publishing/apps-publish).

msteams-platform/concepts/bots/bots-context.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 23: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#bot-or-user-added-to-a-team).
Line 119: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#bot-or-user-added-to-a-team).

msteams-platform/concepts/bots/bots-create.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 25: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 25: [Warning] Invalid file link:(~/publishing/apps-package).
Line 26: [Warning] Invalid file link:(~/concepts/apps/apps-overview#map-your-scenario-to-teams-capabilities).
Line 26: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 27: [Warning] Invalid file link:(~/publishing/apps-publish).

msteams-platform/concepts/bots/bots-test.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 13: [Warning] Invalid file link:(~/get-started/get-started).
Line 17: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 17: [Warning] Invalid file link:(~/publishing/apps-package).
Line 19: [Warning] Invalid file link:(~/concepts/bots/bots-notifications).
Line 59: [Warning] Invalid file link:(~/assets/images/bot/botdisable.png).
Line 77: [Warning] Invalid file link:(~/publishing/apps-publish).

msteams-platform/concepts/cards-actions.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 12: [Warning] Invalid file link:(~/concepts/cards-actions#hero-card).
Line 12: [Warning] Invalid file link:(~/concepts/cards-actions#hero-card).
Line 13: [Warning] Invalid file link:(~/concepts/cards-actions#thumbnail-card).
Line 13: [Warning] Invalid file link:(~/concepts/cards-actions#thumbnail-card).
Line 61: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 61: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 76: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 76: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#message-format).
Line 85: [Warning] Invalid file link:(~/concepts/connectors#using-office-365-connector-cards-in-microsoft-teams).
Line 85: [Warning] Invalid file link:(~/concepts/connectors#using-office-365-connector-cards-in-microsoft-teams).
Line 92: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 92: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).

msteams-platform/concepts/compose-extensions.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 31: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 37: [Warning] Invalid file link:(~/concepts/bots/bots-create).
Line 43: [Warning] Invalid file link:(~/reference/schema/manifest-schema#composeextensions).
Line 141: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 204: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#receiving-messages).
Line 273: [Warning] Invalid file link:(~/concepts/cards-actions).
Line 273: [Warning] Invalid file link:(~/concepts/connectors#using-office-365-connector-cards-in-microsoft-teams).
Line 410: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).
Line 414: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).

msteams-platform/concepts/tabs/tabs-configuration.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/publishing/apps-package).
Line 13: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).
Line 79: [Warning] Invalid file link:(~/reference/general/requirements).
Line 89: [Warning] Invalid file link:(~/concepts/tabs/tabs-context).
Line 89: [Warning] Invalid file link:(~/concepts/authentication).
Line 97: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 101: [Warning] Invalid file link:(~/concepts/deep-links).
Line 102: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 102: [Warning] Invalid file link:(~/concepts/tabs/tabs-update-remove).
Line 105: [Warning] Invalid file link:(~/reference/schema/manifest-schema).
Line 105: [Warning] Invalid file link:(~/reference/general/cross-domain).
Line 109: [Warning] Invalid file link:(~/concepts/tabs/tabs-update-remove#removing-a-tab).
Line 121: [Warning] Invalid file link:(~/troubleshoot/troubleshoot).

msteams-platform/concepts/tabs/tabs-static.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 17: [Warning] Invalid file link:(~/concepts/tabs/tabs-dynamic).
Line 21: [Warning] Invalid file link:(~/reference/schema/manifest-schema#statictabs).
Line 23: [Warning] Invalid file link:(~/publishing/apps-package).
Line 52: [Warning] Invalid file link:(~/concepts/deep-links).
Line 60: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).

msteams-platform/get-started/get-started.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 59: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 63: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 73: [Warning] Invalid file link:(~/concepts/apps/apps-overview).
Line 74: [Warning] Invalid file link:(~/get-started/design).
Line 75: [Warning] Invalid file link:(~/get-started/code).
Line 76: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 77: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 78: [Warning] Invalid file link:(~/concepts/connectors).
Line 79: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 80: [Warning] Invalid file link:(~/concepts/activity-feed).
Line 84: [Warning] Invalid file link:(~/publishing/apps-package).
Line 85: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 86: [Warning] Invalid file link:(~/reference/general/debug).
Line 90: [Warning] Invalid file link:(~/publishing/apps-publish).
Line 91: [Warning] Invalid file link:(~/concepts/deep-links).
Line 95: [Warning] Invalid file link:(~/troubleshoot/troubleshoot).

msteams-platform/overview.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 15: [Warning] Invalid file link:(~/get-started/get-started#1-set-up-your-office-365-tenant).
Line 26: [Warning] Invalid file link:(~/concepts/apps/apps-overview#scopes-in-microsoft-teams).
Line 40: [Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
Line 54: [Warning] Invalid file link:(~/concepts/bots/bots-overview).
Line 62: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 68: [Warning] Invalid file link:(~/concepts/compose-extensions).
Line 72: [Warning] Invalid file link:(~/assets/images/composeextension/ceoverviewexample.png).
Line 76: [Warning] Invalid file link:(~/reference/general/developer-preview).
Line 84: [Warning] Invalid file link:(~/concepts/connectors).
Line 97: [Warning] Invalid file link:(~/concepts/custom-bot).
Line 103: [Warning] Invalid file link:(~/feedback).

msteams-platform/publishing/apps-package.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 20: [Warning] Invalid file link:(~/reference/schema/manifest-schema).
Line 58: [Warning] Invalid file link:(~/troubleshoot/troubleshoot).

msteams-platform/reference/general/debug.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 12: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 12: [Warning] Invalid file link:(~/publishing/apps-package).
Line 13: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 13: [Warning] Invalid file link:(~/publishing/apps-package).
Line 54: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).
Line 62: [Warning] Invalid file link:(~/publishing/apps-package).
Line 63: [Warning] Invalid file link:(~/concepts/apps-sideload).

msteams-platform/scenarios/bots-channel-conversations.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 11: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 11: [Warning] Invalid file link:(~/publishing/apps-package).
Line 21: [Warning] Invalid file link:(~/concepts/apps/apps-overview).
Line 31: [Warning] Invalid file link:(~/concepts/bots/bots-conversations#teams-channel-data).
Line 71: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#team-member-or-bot-addition).
Line 73: [Warning] Invalid file link:(~/scenarios/bots-personal-conversations#starting-a-11-conversation).
Line 73: [Warning] Invalid file link:(~/concepts/bots/bots-context#fetching-the-team-roster).
Line 135: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 219: [Warning] Invalid file link:(~/concepts/bots/bots-context).

msteams-platform/scenarios/bots-personal-conversations.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 9: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations).
Line 21: [Warning] Invalid file link:(~/concepts/bots/bots-notifications#team-member-or-bot-addition).
Line 21: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations).
Line 21: [Warning] Invalid file link:(~/concepts/bots/bots-context#fetching-the-team-roster).

msteams-platform/troubleshoot/troubleshoot.md

[Warning] Ignore metadata: search.ms_sitename, search.ms_product, search.ms_docsetname. They are generated by open publish.
Line 13: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 15: [Warning] Invalid file link:(~/concepts/apps-sideload).
Line 21: [Warning] Invalid file link:(~/reference/schema/manifest-schema#validdomains).
Line 49: [Warning] Invalid file link:(~/reference/library/client-sdk-javascript).
Line 53: [Warning] Invalid file link:(~/concepts/authentication).
Line 65: [Warning] Invalid file link:(~/get-started/get-started#enable-sideloading-of-bots-and-tabs).
Line 69: [Warning] Invalid file link:(~/concepts/app-sideload).
Line 77: [Warning] Invalid file link:(~/scenarios/bots-channel-conversations#mentions).
Line 93: [Warning] Invalid file link:(~/reference/schema/manifest-schema#developer).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Install all dependencies on macOS using Homebrew

Closes #53.
This PR adds a Brewfile which, when used with Homebrew's brew bundle command, will install all the tools needed to build intermezzOS. I've also updated the documentation to match.

I can also open a similar PR for https://github.com/intermezzOS/bare-bones, if you'd like?

Well, the build broke, but I don't think it has anything to do with the changes in this PR – my Rust OS project's build broke on Travis with the same error. Looks like something changed upstream, maybe in xargo?

Nice! @ashleygwilliams , maybe give this a try on your mac later to double check?
@hawkw I agree the failures seem strange; I'll try to investigate soon.

oh look https://users.rust-lang.org/t/compile-failures-with-1-15-0-nightly-2016-11-14/8032

cool- will take a look in a second!

@ashleygwilliams thanks! I've got everything working on my machine, but of course that doesn't mean that it'll work everywhere – I'm eager to hear if it'll work for you, too.
N.B. that if you're not installing from the Brewfile, you need to pass the flags --with-x86_64-pc-elf --HEAD to brew install grub; the formula isn't 100% complete and won't install successfully unless you're on HEAD.

Hey @hawkw , thanks again for this! Hoping to have some time for intermezzOS soon; it's been a busy few months.

@steveklabnik, you're quote welcome! Do let me know if you hit any trouble.

hey! just ran this on my mac, running 10.11.6
is full xcode a dependency of this brew script? previously it did not require full xcode. lemme know! thanks! and sorry the review has taken so long
Tapping hawkw/grub
Installing grub formula. It is not currently installed.
==> Installing grub from hawkw/grub
grub: A full installation of Xcode.app is required to compile this software.
Installing just the Command Line Tools is not sufficient.
Xcode can be installed from the App Store.
Error: An unsatisfied requirement failed this build.
Installing grub has failed!
Homebrew Bundle failed! 1 Brewfile dependencies failed to install.
Kernel.exit
Error: Kernel.exit
Ashleys-MacBook-Pro:kernel ag_dubs$

hey! just ran this on my mac, running 10.11.6
is full xcode a dependency of this brew script? previously it did not require full xcode. lemme know! thanks! and sorry the review has taken so long
Tapping hawkw/grub
Installing grub formula. It is not currently installed.
==> Installing grub from hawkw/grub
grub: A full installation of Xcode.app is required to compile this software.
Installing just the Command Line Tools is not sufficient.
Xcode can be installed from the App Store.
Error: An unsatisfied requirement failed this build.
Installing grub has failed!
Homebrew Bundle failed! 1 Brewfile dependencies failed to install.
Kernel.exit
Error: Kernel.exit
Ashleys-MacBook-Pro:kernel ag_dubs$

@ashleygwilliams: there is a CI build set up for the x86-64-pc-elf-binutils tap: https://travis-ci.org/hawkw/homebrew-x86_64-pc-elf; I'll see about setting one up for grub as well.

@ashleygwilliams: there is a CI build set up for the x86-64-pc-elf-binutils tap: https://travis-ci.org/hawkw/homebrew-x86_64-pc-elf; I'll see about setting one up for grub as well.

https://docs.travis-ci.com/user/multi-os/#Example-Multi-OS-Build-Matrix is probably a better link; @hawkw , we were thinking about the intermezzOS build itself, not just the sub-components. We don't have any testing so far, so in my opinion, doing that here isn't required, but it'd be a good thing to have.
I tried looking at your brew scripts and it wasn't obvious to me why it required the full XCode Tools...

https://docs.travis-ci.com/user/multi-os/#Example-Multi-OS-Build-Matrix is probably a better link; @hawkw , we were thinking about the intermezzOS build itself, not just the sub-components. We don't have any testing so far, so in my opinion, doing that here isn't required, but it'd be a good thing to have.
I tried looking at your brew scripts and it wasn't obvious to me why it required the full XCode Tools...

Oh, okay; I think I misunderstood what @ashleygwilliams meant. I'll see
about adding an OS X build to the PR.
As for the XCode requirement, if I recall correctly, it was about the only
way I could get Homebrew to use a version of gcc that could actually
compile Grub. There might be a better way, but I believe this was the only
way I could get it to work.
On Sun, Jan 1, 2017 at 4:19 PM Steve Klabnik<EMAIL_ADDRESS>wrote:

https://docs.travis-ci.com/user/multi-os/#Example-Multi-OS-Build-Matrix
is probably a better link; @hawkw https://github.com/hawkw , we were
thinking about the intermezzOS build itself, not just the sub-components.
We don't have any testing so far, so in my opinion, doing that here isn't
required, but it'd be a good thing to have.
I tried looking at your brew scripts and it wasn't obvious to me why it
required the full XCode Tools...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/intermezzOS/kernel/pull/101#issuecomment-269920113,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACqrskqnP3md_vYOiJLGOn-uKfoLYu6aks5rOBhtgaJpZM4KzOTO
.
--
Eliza Weisman
Allegheny College, Class of 2017
Computer Science/Studio Art
President, Gender and Sexuality Alliance (GSA)

Oh, okay; I think I misunderstood what @ashleygwilliams meant. I'll see
about adding an OS X build to the PR.
As for the XCode requirement, if I recall correctly, it was about the only
way I could get Homebrew to use a version of gcc that could actually
compile Grub. There might be a better way, but I believe this was the only
way I could get it to work.
On Sun, Jan 1, 2017 at 4:19 PM Steve Klabnik<EMAIL_ADDRESS>wrote:

https://docs.travis-ci.com/user/multi-os/#Example-Multi-OS-Build-Matrix
is probably a better link; @hawkw https://github.com/hawkw , we were
thinking about the intermezzOS build itself, not just the sub-components.
We don't have any testing so far, so in my opinion, doing that here isn't
required, but it'd be a good thing to have.
I tried looking at your brew scripts and it wasn't obvious to me why it
required the full XCode Tools...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/intermezzOS/kernel/pull/101#issuecomment-269920113,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACqrskqnP3md_vYOiJLGOn-uKfoLYu6aks5rOBhtgaJpZM4KzOTO
.
--
Eliza Weisman
Allegheny College, Class of 2017
Computer Science/Studio Art
President, Gender and Sexuality Alliance (GSA)

Okay, 02901a02874a710928c3f09269d1e4054a45c295 adds a macOS build to your .travis.yml.
The first macOS build will take within sigma of forever - building gcc is slow – but I've set it up to cache the Homebrew package directories so future builds shouldn't take quite so long.

@steveklabnik I suspect there might be another way to make Homebrew use a gcc that Grub's makefile doesn't balk at, but I don't know enough about Homebrew to make it work. Using Xcode's gcc is definitely not ideal, but it works for now...

Two different people on twitter (one private) told me that setting HOMEBREW_CC= might be the answer

So https://github.com/hawkw/homebrew-grub/blob/master/Formula/grub.rb#L25 is the line that requires it.
You had said that

it was about the only way I could get Homebrew to use a version of gcc that could actually compile Grub.

Do you remember the errors you got? Maybe we can fix them...

@steveklabnik hmm, it was a while ago...there were a couple of checks in the configure script that were going wrong, depending on which CC it was getting - I don't remember precisely, sorry.

The problem, as I remember it, is that "gcc" on the Mac is not unlike a box of chocolates...you never really know what you're gonna get. Stuff will claim to be gcc and actually be symlinked to clang, and so on, and Homebrew has a big wad of shims it injects into the build environment that just confuses this.
Tomorrow, I'll see if I can extract anything useful from the formula's commit history?

hawkw/homebrew-grub@c9c0cc2cc4d43ad01abb661f801b73b18586fead removes the Xcode requirement to build grub – I tested it on my machine and it seems to work fine.

guh. sorry that i am the worst and let this sit for over a year. I feel terrible. I'm trying to get back to a clean slate here, so sadly, i need to close this. I hope you got something out of this, sorry for failing you :(

That's fine, don't worry about it --- I'm in more or less the same place with my hobby OS project. I think the homebrew taps are out of date anyway, but if you try using them again and have any issues, please let me know!


edc update: token-auth-key can be stored in vault

Closing this PR as it would introduce dependencies to the EDC, that are currently not solveable.


Check for command arguments

It would be great if this plugin checked for arguments, so that you can answer the prompts without being prompted.
My use case is mainly for continuous integration, where prompts cannot be used.
For example
Without arguments:
$ grunt getMeSomeLunch
What would you like for lunch?
> Sushi
Getting you a sushi for lunch

With arguments
$ grunt getMeSomeLunch --iWant=burrito
Getting you a burrito for lunch

You could just use
when: function() {
						return grunt.option('host') === undefined;
					}

@mrjackdavis  did you come up with a solution to this - I'm encountering the same need?

I ended up turning away from grunt-prompt. And grunt altogether for that matter.

I created a pull request that addresses this and will skip the prompt if config/name is provided on the command line via grunt.option
https://github.com/dylang/grunt-prompt/commit/33faf122c62323a93ad110fd17db1f070779968f


Disabling machine ID locks up settings

Describe the bug
Enabling the 'Disable machine ID' flag triggers a response from chrome which blocks the browser's settings.
To Reproduce
Steps to reproduce the behavior:

Go to 'chrome://flags/'
Scroll down to 'Disable machine ID'
Select 'Enabled"
Go to Settings
See error

Screenshots

Environment (please complete the following information):

OS/Platform and version: Windows 10 desktop 1903
ungoogled-chromium version: 88.0.4324.150

Additional context
Also everything downloaded is seen as suspicious by Chromium requiring you to click 'keep' after each download.

Is this still an issue? If so, please file this issue with the corresponding platform repo: ungoogled-software/ungoogled-chromium-windows


URL Parser benchmark

fixes #501
Benchmark results
[info] Benchmark                                Mode  Cnt     Score     Error  Units
[info] URLParserBenchmark.benchmarkURLParser   thrpt   10  1795.675 ? 142.343  ops/s
[info] URLParserBenchmark.benchmarkURLParser2  thrpt   10  2131.620 ?  71.715  ops/s
[info] URLParserBenchmark.benchmarkURLParser3  thrpt   10  1930.228 ?  83.573  ops/s

Codecov Report

Merging #846 (53fe1ff) into main (dfd11ac) will decrease coverage by 0.61%.
The diff coverage is 7.40%.

@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   52.64%   52.02%   -0.62%
==========================================
  Files          69       69
  Lines        2120     2145      +25
  Branches       57       57
==========================================
  Hits         1116     1116
- Misses       1004     1029      +25

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/http/Scheme.scala
42.85% <0.00%> (-17.15%)
:arrow_down:

zio-http/src/main/scala/zhttp/http/URL.scala
64.51% <0.00%> (-33.05%)
:arrow_down:

...io-http/src/main/scala/zhttp/http/PathModule.scala
78.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd11ac...53fe1ff. Read the comment docs.

One thing we can do @ShrutiVerma97 here is to convert URL to a sum type.
sealed trait URL

final case class FromString(string: String) extends URL
final case class Cons(
  path: Path,
  kind: URL.Location = URL.Location.Relative,
  queryParams: Map[String, List[String]] = Map.empty,
  fragment: Option[Fragment] = None,
) extends URL

So this way we will keep an unparsed version as string, and parse it only when its truly needed.

Benchark results URL vs URL2
[info] Benchmark                                Mode  Cnt     Score     Error  Units
[info] URLParserBenchmark.benchmarkURL2Parser  thrpt    5  2122.770 ? 302.008  ops/s
[info] URLParserBenchmark.benchmarkURLParser   thrpt    5  2033.823 ?  51.423  ops/s
[info] URLParserBenchmark.benchmarkURLParser2  thrpt    5  2315.495 ?  53.017  ops/s
[info] URLParserBenchmark.benchmarkURLParser3  thrpt    5  2060.433 ?  68.606  ops/s


test typescript code directly

close #21

Coverage decreased (-8.9%) to 60.616% when pulling f1519da8fea4541b1c5e9a29387faeda3e31f703 on 21-update-ava-settings-test-typescript into 76e8347bfdf047f3dac48ae47d7f66f87daa8df8 on master.


Coverage is slow on large projects

Corresponds to internal bug b/179848548
See also https://github.com/flutter/flutter/issues/81803
Getting coverage from the VM service involves multiple RPC calls that transfer megabytes worth of data per test. This becomes untenable for larger projects with lots of source files and lots of tests.
It seems like we could get a lot of mileage out of a single VM call (or flag) that would generate a more streamlined coverage file (perhaps even just an lcov file).
This bug blocks Flutter from being able to reasonably run coverage on CI without timing out or using a very very powerful machine.
/cc @twobitunicorn fyi
/cc @liamappelbe @a-siva

This might also block adding function and branch coverage, as I understand this also would require adding new RPC calls (at least for branch coverage).
See https://github.com/dart-lang/coverage/issues/141 for more information.

@liamappelbe is more work expected on this issue ?

No. https://github.com/flutter/flutter/pull/90142 halves the time it takes to gather coverage. And isolate groups have also helped because we only need to gather coverage once for the whole group. There's no other low hanging fruit I'm aware of, so we should close this and reopen if users are still having problems.

@liamappelbe did you consider cherry-picking this into Flutter stable?


pov: why is root not in leaves or otherwise used?

The sequence is:
graph := New()
for _, l := range leaves {
    graph.AddNode(l)
}
for _, p := range arcPairs {
    graph.AddArc(p.from, p.to)
}

No where in there is the value for "root" added. So when AddArc is called the value of from is unknown.
The singleton test which is the first test has one leaf which matches the value of root. Most of the others use "parent" which is never explicitly defined.
The comments in the test file say that to will always exist but is quiet on from. It seems odd that the expectation is to create missing from. Or did I missed something?

If it is unclear to you than it is probably unclear and we should fix.

@shaleh do you have a fix for this?
I have to admit I don't fully understand what the issue is, would you be able to expand on it so we can outline what a fix for this might look like. Thanks.

Actually, every node is root. IMHO, it's the point of the exercise. It changes according to where you're looking from.
However, you're right. Current implementation has hidden assumptions and isn't aligned with problem canonical data
Anyway, we will need to write a generator for it so we can rework. @shaleh do you want to give a try ?

I could write a generator for this. I am at least a week out from having time for that. If that is ok, then yes consider it assigned to me.

Assigned it to you. Thanks!


I have issue in my Flutter omegle clone app

I can video call randomly but issues is that i can't see other people video also
after video disconnected audio still working
https://github.com/Ayushpanditmoto/Flutter_Omegle

It would be great if you can contribute to this project as i m using peerdart package and its amazing


bugfix using light pool to do transmit block

Proposed changes
Sometimes transmit block function is the last owner of PlanFragmentExecutor
It will release the object. And the object maybe a JNIContext.
JNIContext will hold some TLS object. It could not work correctly under bthreadContext. So that put the logic into pthread.
But this is rarely happens, so this config is disabled by default.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Translation

Hi,
I want to add Romanian language support and push it here.
I'm thinking of adding to Translations.js something like I18n_language_code:
..............................
I18n_ro = {};
I18n_ro.title = "Mobile ...(OL3)";
I18n_ro.search = {
header: "Caută adrese",
................................
And then in the config.js:
I18n=I18n_ro;
Do you have any suggestion/comment?
Nice work!
Tudor

Hi
My suggestion ist to copy src/translations.js to src/translations_ro.js and store the romanian terms in the new file.
Then you have just to change the reference in index.html to src/translations_ro.js.
 <script src="src/translations_ro.js"></script>

Hope this helps.

Ty


Native certificate validation issues in tests for GetTime()

GetTIme() relies on TLS connections returning certificate expiration errors.  However, tracing on multiple systems (AMD64, ARM32; different versions of Go) seem to indicate acceptable of a certificate despite giving an invalid usable time:
NetTime Using custom time:0001-01-01 00:00:00 +0000 UTC
NetTime Time usable for connection:0001-01-01 00:00:00 +0000 UTC
NetTime Time from server:2019-03-10 21:45:42 +0000 GMT

This is making tests pass while on systems without real time, things fail.  For testing purposes it is not practical to set the test system's actual clock a few years behind to test this.
Need to dig deeper and see if Go runtime is taking local system time somewhere rather than our suggested time.

This was fixed in assorted commits.


Race condition in update

Currently there's a race condition in the processUpdates function that occurs when consumers simultaneously access the update and stop endpoints.
This happens because maps in Go aren't concurrency safe. A RWMutex can be used to solve this problem.

Fixed in last commit.


Update dependencies and regenerate docs

Also re-format, re-generate docs and split lint script.

I don't have any opinions here, so punting to @justinfagnani

I updated the dependencies in the JS version to match these and they seem to work fine.
On the formatting, I defer to @justinfagnani

@arthurevans this JS version is private :)
And about the formatting, I just run your npm run format task (https://github.com/PolymerLabs/lit-element-starter-ts/pull/18/commits/eb3be067b92dab552ed6b83eb2a593dede71cdde).

LGTM, although IMO it's probably not a great idea to bump the lit-element dependency. There's nothing in the starter kit that requires 2.3.1, and you generally want to have the lowest lower bound that's compatible to avoid incompatible versions across multiple dependents.


importing jetson.inference is depreciated.  Please 'import jetson.inference' instead

Following Hello AI world on jetson nano 2GB,
Trying to write the my-recognition.py example in python, and am told that:
"importing jetson.inference is depreciated.  Please 'import jetson_inference' instead"
and
"importing jetson.utils is depreciated.  Please 'import jetson_utils' instead"
When I update the imports, I also update the call to load an image
from => jetson.utils.loadimage()
to     => jetson_utils.loadimage()
but receive the error message:
"jetson_utils has no attribute 'loadimage'"
Where might I find the updated attributes to call for the new import?

Hi @Michael-EVOL, it's jetson_utils.loadImage()  (note the capitalization)

Aha, that is what I thought it was going to be a capitalized version of the one I was using.
Also I found that the function imagenet() became imageNet() in the new package.
Thank you @dusty-nv very much for your help with this issues.

No problem - the function names haven't changed (i.e. it was always imageNet)


fix: use global URL

Codecov Report

Merging #28 (868e2dd) into main (dc1e59b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           21        20    -1
  Branches         2         2
=========================================
- Hits            21        20    -1

Impacted Files
Coverage Δ

src/index.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1e59b...868e2dd. Read the comment docs.


add csi cinder driver

Add csi cinder driver.
Mainly including following interfaces:

CreateVolume
DeleteVolume
ControllerPublishVolume
ControllerUnpublishVolume
NodePublishVolume
NodeunPublishVolume

@chakri-nelluri Thanks your review. I will add unit test with driver later.

TODO:

use config file
add unit tests

@edisonxiang Thanks for quick update. Please fix the TODO. There is a strong push back to stop accepting any new drivers with TODO's. We are also adding unit tests for existing drivers.

Hi @chakri-nelluri @lpabon , unit tests have been added. PTAL, Thank you!

please add license block in files that don't have yet.

@rootfs I will add it at once. Thanks.


Add option to build with IAD for composite device serial port

This provides a quick solution to build a serial-port class with an interface association descriptor.  So if the device is composite, Windows will work with the serial-port. #3
// for composite devices
let serial = usbd_serial::SerialPort::new_composite(usb_bus);

// for serial-port only devices
let serial = usbd_serial::SerialPort::new(usb_bus);

Tested working on Windows.

Thank you for the pull request, IADs are a good addition. However I'm going to go with PR #13, because it's not a breaking change (this adds a new required argument for a public constructor), and it's closer to what the next version of usb-device will do (it can auto-detect whether you need IADs or not).


Update 1password extension

Description

Screencast

Checklist

[ ] I read the extension guidelines
[ ] I read the documentation about publishing
[ ] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

@kjeldahl Are you able to test this PR?

@kjeldahl Are you able to test this PR?

I am not sure how to do it. I found a way to fork the extension but how do I change it to your fork / pull request?

I am not sure how to do it. I found a way to fork the extension but how do I change it to your fork / pull request?

@Luk4h I just ended up forking it and copying your changes in by hand :-) It works just fine. 🎆
One thing you could add is clearing the entries right away after switching account, as the old entries are show for about ~3 seconds while the new ones are loading.
Thanks a lot for the good work 👍

@Luk4h I just ended up forking it and copying your changes in by hand :-) It works just fine. 🎆

Sorry got into how to do it as well...
The command is:
git clone -n --depth=1 --filter=tree:0 \
  -b ext/1password git@github.com:Luk4h/raycast-extensions.git
cd raycast-extensions
git sparse-checkout set --no-cone extensions/1password
git checkout

This should clone my fork and you can install and run in dev.
About the 3s Cache I thought about clearing it as well. I just pushed a fix to it, do you mind trying it?

I tested this branch for the issue mentioned in https://github.com/raycast/extensions/pull/12492#issuecomment-2125205104.
Still have the same problem.

Command failed: /usr/local/bin/op signin --account xxx
[ERROR] 2024/05/22 10:46:56 found no accounts for filter "xxx"

The problem is account.account_uuid is undefined when setting the Form.Dropdown.Item value.
The command op account list --format=json returns something like this:
[
  {
    "url": "my.1password.com",
    "email"<EMAIL_ADDRESS>    "user_uuid": "UUID"
  }
]

There is no account_uuid there and that seems consistent with the 1Password CLI Docs.
If I use either url or user_uuid for the value, signing in works.

I tested this branch for the issue mentioned in #12492 (comment).
Still have the same problem.

Command failed: /usr/local/bin/op signin --account xxx
[ERROR] 2024/05/22 10:46:56 found no accounts for filter "xxx"

The problem is account.account_uuid is undefined when setting the Form.Dropdown.Item value.
The command op account list --format=json returns something like this:
[
  {
    "url": "my.1password.com",
    "email"<EMAIL_ADDRESS>    "user_uuid": "UUID"
  }
]

There is no account_uuid there and that seems consistent with the 1Password CLI Docs.
If I use either url or user_uuid for the value, signing in works.

Never mind, the problem was I was using an older version of the 1Password CLI (2.0.0). With v2.29.0 everything works! Thank you!


Adjust modulefile according to the latest requirements (#2823)

The PR aims to adjust modulefile according to the latest requirements

/intelci: run


Default ingress gateway loadBalancerSourceRanges to empty value

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
If they are not already assigned, you can assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @dstockton. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @gyliu513
/assign @ymesika
/assign @sdake
Raising instead of https://github.com/istio/istio/pull/9327 as I've signed the CLA

/ok-to-test

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@dstockton: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dstockton: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dstockton: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dstockton: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dstockton: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test istio-unit-tests

prow/e2e-mixer-no_auth-mcp.sh
ba706b397d6c3438ecdca5dfb7bb8adfe73a9ca7
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS
galley/OWNERS
install/OWNERS [gyliu513]
istioctl/OWNERS
mixer/OWNERS
pilot/OWNERS
pkg/OWNERS
security/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dstockton: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
35d10b3720b01999d346a017c3a62e0d5a7c7722
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Maintain changedVariablesStack from DPath VRef

DAFFODIL-2565

I actually believe the "fix" in this PR is wrong. The code was correct before. Just a little confusing.
PState contains the changedVariablesStack, which must be maintained whenever variables are set or read or newInstances created.
The variableMap.readVariable method was doing a callback to PState to maintain this changedVariablesStack. That means all uses of readVariable, including from DPath VRef, were doing this maintenance.
However, variableMap.setVariable does no such callback.
Instead, code that is setting variables is supposed to call the PState.setVariable method. which does this changedVariablesStack maintenance.
The reality: There's more state to maintain having to do with variables than just the variableMap, so all manipulation of variables SHOULD go by way of PState/UState methods, and those should delegate things to the VariableMap object, and maintain other things like changedVariablesStack.
So the change so that nobody uses variableMap directly, and instead uses variables by way of PState/UState is the way to go, and the uses of variableMap directly need to go away, and the callback from variableMap to PState also should go away.


Enable Release Drafter

Allows the app to draft release when pushing to master
This PR is created automatically by Matks PrestaShop Repositories Bulk Editor

Thanks  @matks


refactor: Use AtomicUsize instead of AtomicU64

Closes #283 @jonassmedegaard, I've added you as a co-author. Are you fine with this? :-)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

1 of 3 (33.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.757%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/handle.rs
1
3
33.33%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
1021

Relevant Lines:
1219

💛  - Coveralls


Issue #201: Improve recently merged suites

Also, reorder test cases in one_node_two_pods_ldpreload_iperf.
Signed-off-by: Vratko Polak<EMAIL_ADDRESS>

We can add one more test to show host to pod works on first try.

Coverage increased (+0.05%) to 59.152% when pulling 388d939bef75912455c19fcdc3195a4cf8f64592 on vrpolakatcisco:contiv201_17 into d0cb18a910a95ecd767e0fc90ba6042cb5c6fb16 on contiv:master.


Firebase Phone Auth (Android) Instant Verification Problem

Readme stated I have to call my endpoint to get a custom token and sign in. I implemented according the guide provided and able to sign in now.
From my understanding, isn't when Firebase auth return me instant verification is true, I should get signed in directly instead of request a custom token from my endpoint to sign in with custom token?
Is the method stated in readme a temporary workaround solution or permanent fix?

I am facing the same dilemma, and while going through the Firebase Docs, I found some points can be used to reach a permanent fix.
Link to Firebase Docs: - Authenticate with Firebase on Android using a Phone Number
Quoting the docs: -

onVerificationCompleted(PhoneAuthCredential)
This method is called in two situations:

Instant verification: in some cases the phone number can be instantly verified without needing to send or enter a verification code.
Auto-retrieval: on some devices, Google Play services can automatically detect the incoming verification

SMS and perform verification without user action. (This capability might be unavailable with some carriers.)
In either case, the user's phone number has been verified successfully, and you can use the PhoneAuthCredential object that's passed to the callback to sign in the user.

onCodeSent(String verificationId, PhoneAuthProvider.ForceResendingToken)
Optional. This method is called after the verification code has been sent by SMS to the provided phone number.
When this method is called, most apps display a UI that prompts the user to type the verification code from the SMS message. (At the same time, auto-verification might be proceeding in the background.) Then, after the user types the verification code, you can use the verification code and the verification ID that was passed to the method to create a PhoneAuthCredential object, which you can in turn use to sign in the user. However, some apps might wait until onCodeAutoRetrievalTimeOut is called before displaying the verification code UI (not recommended).

If you focus on the italicized text, the PhoneAuthCredential can be used to sign in the user.
In the onCodeSent() case, we create the PhoneAuthCredential ourselves and then sign in using the following code:
signInWithOTP(verificationId: string, otpCode: string): Promise<firebase.User> {
        return firebase.auth().signInWithCredential(
            firebase.auth.PhoneAuthProvider.credential(verificationId, otpCode)
        );
}

But in onVerificationCompleted() case, the PhoneAuthCredential is passed to the callback...
The implementation of this in the Plugin is as follows where PhoneAuthCredential is passed to the callback: -
https://github.com/arnesson/cordova-plugin-firebase/blob/c53bd4aa04e83e37009ecfb1fd4342ac2cc78618/src/android/FirebasePlugin.java#L937-L962
So, if we could expose this PhoneAuthCredential outside the plugin, returned along the pluginResult or maybe implement a signIn() function within the plugin as quoted from the firebase docs: -

Sign in the user
After you get a PhoneAuthCredential object, whether in the onVerificationCompleted callback or by calling PhoneAuthProvider.getCredential, complete the sign-in flow by passing the PhoneAuthCredential object to FirebaseAuth.signInWithCredential:
private void signInWithPhoneAuthCredential(PhoneAuthCredential credential) {
    mAuth.signInWithCredential(credential)
            .addOnCompleteListener(this, new OnCompleteListener<AuthResult>() {
                @Override
                public void onComplete(@NonNull Task<AuthResult> task) {
                    if (task.isSuccessful()) {
                        // Sign in success, update UI with the signed-in user's information
                        Log.d(TAG, "signInWithCredential:success");

                        FirebaseUser user = task.getResult().getUser();
                        // ...
                    } else {
                        // Sign in failed, display a message and update the UI
                        Log.w(TAG, "signInWithCredential:failure", task.getException());
                        if (task.getException() instanceof FirebaseAuthInvalidCredentialsException) {
                            // The verification code entered was invalid
                        }
                    }
                }
            });
}

By adding returnResults.put("credential", credential); to these lines, we may return the PhoneAuthCredential to be used further, as being done in onCodeSent() : -
https://github.com/arnesson/cordova-plugin-firebase/blob/c53bd4aa04e83e37009ecfb1fd4342ac2cc78618/src/android/FirebasePlugin.java#L948-L951
Maybe the Instant Verification could also be handled using the plugin this way.
I am no expert in this and am just making some deductions from the available information. Kindof brainstorming, but if someone could take it forward from here, it would be great.

@YaMo97 : Your solution is correct 👍. I will try to implement it.
I think it's a bad idea to call the backend server with phone number to get the token. It's a big security breach. Anyone can access this URL, pass any phone number as parameter and get a token to get access on the app.

you are right @placha433 - I never thought about this hack while I was trying to fix this issue. So this is on me and the readme should be changed. We stopped using firebase at this project, as it didn't do the job right like we wanted.
Love to see you guys push out a fix for this

this has been fixed in v2.0.3 via https://github.com/arnesson/cordova-plugin-firebase/pull/861


i have windows 10 and im missing Segoe Chess i need it im the first one to need it and it do

Segoe Chess came with Office 2007 and Office 2010. So if you have an old CD you can find it there.
It is also sold on the MyFonts and Monotype websites.
The same characters are in Segoe UI Symbol - which does come with Windows 10.
Similar symbols are also in Noto Sans Symbols 2.

Appreciate it, kenmcd! Segoe Chess is no longer included with any of the current Microsoft products. As kenmcd pointed out, Segoe UI Symbol, accessible on all Windows 10 and 11 devices, would be your top free alternative.


What's a valid email address when creating account?

I wanted to set up an account using LDAP instead of Shib, to see what an unaffiliated user looks like. I entered my gmail acct, but am told "You must enter a valid email address." Perhaps I'm triggering some other error because I have another account or something, but the error message is not helpful.

I see you already have an account with this email address. Yes, we need to amend the error message accordingly...

after testing it seems that we need to provide the correct error message here. there's a test account InstRev123 registered with this email address. so the error should say "That email address is already registered." i get the correct error message if I try to create an account with this email and the registered First and Last name, but not if the names are different as in the screenshot above. this may be an edge case to just be aware of. i don't imagine many users will try to create a new account with an existing email and a different name - thoughts @briri ?

The first and last names are not relevant here. The email address is the only thing that must be unique. I think something else is going on. In Perry's original screenshot, the 'Password' field is in error but displaying a message about the email address. That error message is triggered by JS on the page before the submit button is clicked. My guess is that the password was not valid and its just displaying the wrong message.

that makes more sense @briri - in which case can you just update the error message to say "you must enter a valid password or reset your password?"

the message has been updated and is already out on the production server. Going to close this one out


rm -rf udp

This has been gone for years
:skull::skull::skull::skull::skull::skull::skull::skull::skull::skull:
@LewisJEllis @benvinegar

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add playsInline attribute on the video element

The main PR was closed because we renamed the master branch to main.
For more infos look into: #7364
Fixes #7357

re https://github.com/Leaflet/Leaflet/pull/7364#issuecomment-738780363:

I'd rather not merge until it has been tested (and I don't have a iOS device either)

I think this should be good to merge. playsinline would simply allow videos to play without automatically going into fullscreen mode, in browsers where they otherwise would.
Without playsinline:
https://css-tricks.com/what-does-playsinline-mean-in-web-video/#:~:text=what it looks like without playsinline
With playsinline:
https://css-tricks.com/what-does-playsinline-mean-in-web-video/#:~:text=what it looks like with playsinline

We should setup a demo, so that we can easy share a link to check if it works.
We can set it up in leafletjs.com/edit.html and then I can upload it to my server, because on phones the plunk doesn't work.

Here a link to test on a mobile device: http://falke-design.bplaced.net/leaflet/video/videooverlay.html

@Falke-Design could you rebase this on main? I'd like to see if Bundlemon reports the file size increase properly.

@jonkoops does it work?

Strangely enough it reports a smaller size, which seems impossible. I'll wait for some more PRs so we can see is this is a persistent problem.


Problem adding new packages on poetry 1.5

Hi all!
I have a problem with the plugin, after the installation, if I launch poetry add <newpackage> the package will be installed but the pyproject.toml will not register the change in the file.
Also If I launched another package installation with poetry add <second_new_package poetry remove the old <newpackage> with all the dependencies.
I think this problem it's related to some pyproject configuration in the plugin, like this open issue in Poetry project: https://github.com/python-poetry/poetry/issues/7230

Poetry version: Poetry (version 1.5.1)
Python version: Python: 3.9.16
OS version and name: macOS 13.4.1 ARM

Has anyone experienced the same problem?

Thanks for the patience with my reply! :sweat_smile:
I just marked this project as deprecated, I'm currently not using it and I think these ideas can be achieved in better ways: https://github.com/tiangolo/poetry-version-plugin#-warning-deprecated-
Given that I'll close this one, but thanks for the interest! :coffee:


Clean up ResourceInfo class

Warning
DON'T MERGE THIS PR UNTIL SCRIPTS ARE UPATED

Description
This PR unifies all classes storing resource info into a single generic class. The attributes common to all (or at least most) resource info classes were preserved in ResourceInfo, and the differing attributes were pushed to a separate extra field. Type of the extra field is the generic parameter of ResourceInfo.
For instance, for AzureResourceInfo, there exists a AzureExtra class storing things like raw data, and AzureResourceInfo is just equal to ResourceInfo[AzureExtra].
The PR also fixes Azure tests and applies several minor style improvements.
Please verify that you have completed the following steps

[x] I have self-reviewed my code.
[x] I have included test cases validating introduced feature/fix.
[x] I have updated documentation.

This PR looks good! There's just one thing that bugs me here. Why not just use an inheritance structure for the ResourceEstimates? Then you can expose parameters directly and not have to write .extra everywhere.

This PR looks good! There's just one thing that bugs me here. Why not just use an inheritance structure for the ResourceEstimates? Then you can expose parameters directly and not have to write .extra everywhere.

There are two reasons why I didn't use inheritance to expose parameters directly.
The most important one: this is what the DTA2-127 is about - splitting resource info so that we have a clear distinction between estimated resources and extra information specific to the estimation and/or compilation method. I deviated from the original description in that I didn't place the resources part in a separate resources field, but I felt like it would make the whole data structure more cumbersome to use.
The second reason is that generally composition tends to lead to a looser coupling and cleaner architectures.


update kvproto

Signed-off-by: husharp<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #14063
What's Changed:

make sure kvproto compatibility

Check List
Tests

Unit test

Release note
None

/merge


Tiny fix: correct byte length

When trying to write non-English characters to the packets, it will get an incorrect length.
Incorrect length will cause the osu! client to not display some packets normally (such as notifications)
len("h") -> 1 √
len("嗨") -> 1 ×
len("嗨".encode()) -> 3 √

Thanks for the fix :D


ci-automation/test.sh: remove PARALLEL_TESTS passing (move to CI)

Remove passing of PARALLEL_TESTS because it really should be done by the CI. Add documentation in ci-config.env on how to pass variables into the SDK container.
Should be cherry-picked to 3033, 3139, 3185.

Merged &  cherry-picked to 3033, 3139, 3185.


Configure Travis CI, add badge to readme

I don't have access to enable the Travis CI commit hook, are you keen to do this?

Thanks! I've been meaning to figure out Travis CI so thanks for the kick in the pants :) Way easier than I thought... will have to enable on other projects.


GetSceneList disconnect socket

The connection works normally, other commands are working normally, when I make the GetSceneList request the socket disconnects in the code, in the obs it still shows the connection if I try to connect again, instead of replacing the previous connection it creates a new connection and the previous one does not close even with the disconnect command.
const obsWs = new OBSWebSocket()
const [scenesList, setSceneList] = useState<Array<any>>([])

const connectWebSocket = () => {
  obsWs.connect(`ws:${device?.ip}:${device?.port}`).then(() => {
    alert('conectado')
  })
}

const disconnectWebSocket = () => {
  obsWs.disconnect().then(() => {
    alert('desconectado')
  })
}

const showScenesList = () => {
  obsWs.call('GetSceneList').then(async (res) => {
    alert(JSON.stringify(res))
    setSceneList(res.scenes)
  }).catch(err => {
    alert(err)
  })
}

const setCurrentScenes = (scene: any) => {
  alert(scene.sceneName)
  obsWs.call('SetCurrentProgramScene', {sceneName: scene.sceneName}).then(async (res) => {
    alert(JSON.stringify(res))
  }).catch(err => {
    alert(err)
  })
}

Description:
Versions Used (if applicable):

obs-websocket-js version: LTS
obs-studio version: LTS
node version: LTS

const obsWs = new OBSWebSocket()
when declared within the body of a rendering function such as the function that returns the react component, when updating a list it generates a new socket


Description of EXPOSE instruction is unclear

Problem description
I can't figure out when I would ever need to EXPOSE a port. the docs say:

The EXPOSE instruction informs Docker that the container listens on the specified network ports at runtime.

But why do I need to inform Docker about which network ports a container will listen to at runtime? I apparently don't need to expose a port to publish it at runtime (or do I?). I also apparently don't need to expose a port to have Docker containers communicate over a Docker network (or do I?).
Apparently, it was once required for legacy Docker links, but those have been deprecated, so should this be deprecated? If not, why not?
Problem location

I couldn't find the information I wanted. I expected to find it near the following URL: https://docs.docker.com/engine/reference/builder/#expose

Suggestions for a fix
As best as I can tell, the only real purpose EXPOSE has is to document in the Dockerfile which port the service is listening on. If that is the case, I would suggest something like:

Currently, the EXPOSE instruction's only purpose is to document in the Dockerfile which port the service will listen on. The instruction is also required for the deprecated legacy container links feature.

If that's not true, please clarify!

dibs for the hackathon

No action for two days, so this is up for grabs!
However, this may have been addressed by #2882

Thanks @clocklear

Doc here: https://docs.docker.com/engine/reference/builder/#expose is still very misleading. This issue should be re-opened.

@sarusso sorry, the doc you reference is actually sourced straight from the docker/cli repository so is you think that the file should be changed, the issue needs to be raised there.
@johndmulhausen can we re-fix it so that the "Report an issue" for these external topics goes to the right place again?

Is it? The readme of this repository states on the first line that "this is the source for https://docs.docker.com", which is the source of the document I referenced. Why this inconsistency then?

If you look in our repository you will see that we don't have the corresponding Markdown file in our repository at all. We fetch it as part of our build process (see the script). Also, if you look at the source of the file in the docker/cli repository, you will see the following comment:
<!-- This file is maintained within the docker/cli Github
     repository at https://github.com/docker/cli/. Make all
     pull requests against that repo. If you see this file in
     another repository, consider it read-only there, as it will
     periodically be overwritten by the definitive file. Pull
     requests which include edits to this file in other repositories
     will be rejected.
-->

@mstanleyjones Look, I saw a issue with the doc, wanted to help/contribute, found this issue here (which was started as an issue referencing the same doc I did by the way), I double-checked on the readme if I were in the right place, and discovered after commenting that I was actually in the wrong one. I did not dig into the repo to triple-check, and I honestly don't think that it should have been my responsibility to do so. There is no need to prove me wrong, just take it as a feedback from a user (me): it is not clear.


Include clients testing in CI

We should include the JS script: https://github.com/onflow/flow-evm-gateway/blob/main/integration/web3js/index.js utilizing web3.js, in our CI workflow

Fixed by https://github.com/onflow/flow-evm-gateway/pull/203


Add support for detecting release of a button

What problem does this solve or what need does it fill?
Currently we detect when a button is being hovered, or clicked, but not released.
pub enum Interaction {
    /// The node has been clicked
    Clicked,
    /// The node has been hovered over
    Hovered,
    /// Nothing has happened
    #[default]
    None,
}

In this case Clicked is true when the user presses down on the button.
What solution would you like?
Add a Released variant to the Interaction enum, then add whatever logic necessary to correctly detect it.
What alternative(s) have you considered?

Not supporting it is not really an option. Most applications (and games) only trigger the button's action on release.

#5378  handles this by sending an event on release. Also handles nicely when you hold down the mouse button, but slide the mouse off the button before releasing it.

This is now complete due to bevy_picking's creation and integration with bevy_ui.


[BUG] - Create space gets stuck after clicking on getting started on demo website

Briefly describe the bug.
In create space page, the sites stops with an error.
How can we reproduce the bug?

Go to snapshot demo.
Connect with your wallet. My wallet is MetaMask and I'm on Georli test network.
Click on the three dots on upper right corner, and then click on "Create a space".
Click on "Get started".

What is the expected behaviour?
It should go the ENS page.
Can you attach screenshots?

Can you provide your device specific details below?

Device Type - Laptop
Device OS - Ubuntu / Windows
OS Version - Ubuntu 22.10 / Windows10
Browser - Chrome / Opera
Browser Version - Chrome 95.0.4635.46 / Opera 95.0.4635.46
Wallet - MetaMask
Space - ENS
Demo website is not working, not the main one.

I'm unable to replicate the issue at the moment. However, please feel free to reopen the issue if it persists.