update coupled set_surface_albedo

Purpose
Currently, ClimaCoupler.jl overwrites the set_surface_albedo! function defined in ClimaAtmos (see here). However, both functions have exactly the same type signature so this produces a warning. I'm moving the version we want to use into ClimaAtmos so we can remove it from ClimaCoupler.
To-do

Content

[ ] I have read and checked the items on the review checklist.

here

It will set surface albedo there only at time t=0 for coupled simulations. Otherwise it doesn't do anything. Maybe there's a better way to do this where we just initialize the value at 0.38?

If we do this, will it set surface albedo to 0.38 here during radiation callback when running a coupled simulation?

It will set surface albedo to 0.38 there only at time t=0 for coupled simulations. Otherwise it doesn't do anything. Maybe there's a better way to do this where we just initialize the value at 0.38?

Oh right I didn't realize there is a check for t=0. How about restarting simulations? Maybe we don't have to worry about it for now as I don't think the restart in the coupler is exactly correct anyway.

If we do this, will it set surface albedo to 0.38 here during radiation callback when running a coupled simulation?

It will set surface albedo to 0.38 there only at time t=0 for coupled simulations. Otherwise it doesn't do anything. Maybe there's a better way to do this where we just initialize the value at 0.38?

Oh right I didn't realize there is a check for t=0. How about restarting simulations? Maybe we don't have to worry about it for now as I don't think the restart in the coupler is exactly correct anyway.

After t=0, the albedo gets updated in ClimaCoupler with an hourly callback of water_albedo_from_atmosphere!. I think this would make restarts correct, unless t resets to 0 in a restart (I assumed it just resumes from whatever it was at when the previous simulation ended)

If we do this, will it set surface albedo to 0.38 here during radiation callback when running a coupled simulation?

It will set surface albedo to 0.38 there only at time t=0 for coupled simulations. Otherwise it doesn't do anything. Maybe there's a better way to do this where we just initialize the value at 0.38?

Oh right I didn't realize there is a check for t=0. How about restarting simulations? Maybe we don't have to worry about it for now as I don't think the restart in the coupler is exactly correct anyway.

After t=0, the albedo gets updated in ClimaCoupler with an hourly callback of water_albedo_from_atmosphere!. I think this would make restarts correct, unless t resets to 0 in a restart (I assumed it just resumes from whatever it was at when the previous simulation ended)

I think t is reset to 0 in a coupled restarting simulation, but I'm not sure.

I think t is reset to 0 in a coupled restarting simulation, but I'm not sure.

I just took a look - it's controlled by a config variable restart_t, which has a default value of 0 but is overwritten in our one restart test (which isn't the most reliable piece of code). We need to make sure that when we run a restart simulation, we set restart_t to the t_end of the simulation we're restarting from.
Since this PR is using the same code that was previously in ClimaCoupler, just moving it to ClimaAtmos, I think it's okay to keep as-is (and, like you said, keep this in mind as we work out restarting coupled simulations)

I think t is reset to 0 in a coupled restarting simulation, but I'm not sure.

I just took a look - it's controlled by a config variable restart_t, which has a default value of 0 but is overwritten in our one restart test (which isn't the most reliable piece of code). We need to make sure that when we run a restart simulation, we set restart_t to the t_end of the simulation we're restarting from.
Since this PR is using the same code that was previously in ClimaCoupler, just moving it to ClimaAtmos, I think it's okay to keep as-is (and, like you said, keep this in mind as we work out restarting coupled simulations)

Sounds good, feel free to merge it.


noproxying happening

I've set container envs PROXY_SUBDIR=/tracker , VIRTUAL_PORT=8999
the containers port works fine but the proxy subdirectory comes up as 404
2017/05/09 00:17:17 Generated '/etc/nginx/conf.d/default.conf' from 20 containers
2017/05/09 00:17:17 Running '/usr/sbin/nginx -s reload'
2017/05/09 00:17:17 Watching docker events
2017/05/09 00:17:17 Contents of /etc/nginx/conf.d/default.conf did not change. Skipping notification '/usr/sbin/nginx -s reload'
2017/05/09 00:17:27 [error] 18#18: *1 "/etc/nginx/html/index.html" is not found (2: No such file or directory), client: <IP_ADDRESS>, server: , request: "GET / HTTP/1.1", host: "<IP_ADDRESS>:9090"
2017/05/09 00:17:27 [error] 18#18: *1 open() "/etc/nginx/html/favicon.ico" failed (2: No such file or directory), client: <IP_ADDRESS>, server: , request: "GET /favicon.ico HTTP/1.1", host: "<IP_ADDRESS>:9090", referrer: "http://<IP_ADDRESS>:9090/"
2017/05/09 00:18:47 [error] 18#18: *1 "/etc/nginx/html/index.html" is not found (2: No such file or directory), client: <IP_ADDRESS>, server: , request: "GET / HTTP/1.1", host: "<IP_ADDRESS>:9090"
2017/05/09 00:23:38 [error] 18#18: *7 "/etc/nginx/html/index.html" is not found (2: No such file or directory), client: <IP_ADDRESS>, server: , request: "GET / HTTP/1.1", host: "<IP_ADDRESS>:9090"
any help would be appreciated, this docker would make my life SOOO much simpler!

Thank you for reporting.
Which path did your backend service be deployed? I think you have to run your backend service under /tracker directory.
The example below would be help to solve this issue:

A backend service: https://github.com/hrektts/docker-nginx-proxy/blob/master/test/backend/Dockerfile
Compose file: https://github.com/hrektts/docker-nginx-proxy/blob/master/docker-compose.yml

well my backend is a docker container running on port 9090 ->80, if I have to modify the container to run in a sub aswell, it kind of defeats the purpose. Is there a way we can have it perform the same function as apache2 rewrite/proxypass accomplishes?

Nginx has a similar feature like below. However, this container does not have the feature currently...

https://serverfault.com/questions/379675/nginx-reverse-proxy-url-rewrite


Split brave module into brave5 and brave6

Motivation:
As Zipkin's core library has been removed from the dependencies in Brave 6, some libraries that use Brave 5 are incompatible without additional modifications. Instead of forcing users to use Brave 6, let them choose between versions 5 and 6.
Modifications:

Add brave5 module and share the code with brave6
brave module was modified to depend on Brave 5 for backward compatibility.

Result:
Armeria now supports both Brave 5 and Brave 6.

Oops, could you check this failure?
BraveClientTest > testEmptyEndpointTags() FAILED
    java.lang.AssertionError:
    Expected size: 1 but was: 0 in:
    [{"traceId":"b91f5a44e271f65b","id":"b91f5a44e271f65b","kind":"CLIENT","name":"GET","timestamp":170712172[3740](https://github.com/line/armeria/actions/runs/7781264638/job/21215387871?pr=5438#step:11:3741)627,"duration":11893,"localEndpoint":{"serviceName":"unknown","ipv4":"<IP_ADDRESS>"},"tags":{"http.method":"GET","http.path":"/","http.host":"UNKNOWN","http.url":"http:/","http.protocol":"http","error":"com.linecorp.armeria.client.endpoint.EmptyEndpointGroupException: Unable to select endpoints from: StaticEndpointGroup[]"}}]
        at com.linecorp.armeria.client.brave.BraveClientTest.testEmptyEndpointTags(BraveClientTest.java:221)

I guess linksOffline wasn't working since my PR 😓 Thanks for the analysis/fix

No worries. I make a lot of mistakes like that too. 😉

so this was done because brave no longer pins a zipkin-reporter dependency?

brave being dependent on brave 5 is a bad idea for new sites, as they won't think to use the version-qualified one.

next time, please mention me as I was online and we can talk through. this will cause tech debt for a while, and the root issue is that brave no longer pins a dependency on zipkin-reporter (required in order to keep java 6 compatible). armeria is not using any deprecated functions, so this is about dependencies not code. while maybe we would have come to the same conclusion, seems thinking could have happened.

for example, an alternative I would have mentioned would be to have armeria add a dependency on reporter, and even if that was a bad idea we could have discussed an option besides splitting and leaving people likely using old CVE accumulating code by default

so this was done because brave no longer pins a zipkin-reporter dependency?

One of our internal metric libraries that is heavily used depends on Brave 5. When they upgraded Armeria version, Gradle picked higher Brave version. That resulted in java.lang.NoClassDefFoundError: zipkin2/reporter/brave/ZipkinSpanHandler.
After discussing it with other folks at LINE, we decided to revert the breaking change because many teams were affected by it.

next time, please mention me as I was online and we can talk through.

Sure and sorry. I should've mentioned you before we go any further. 🙏

armeria is not using any deprecated functions

I also thought the upgrade would be done seamlessly. I was surprised when I was told that Brave 6 was a blocker of Armeria upgrade.

an alternative I would have mentioned would be to have armeria add a dependency on reporter

It was one possible solution to mitigate the problem. The reason we didn't do that was because the reporter dependency would bother Brave 6 users.

I'm glad you thought about it.. it is too bad there's no way to deprecate a dependency-only module, as the main issue is that "armeria-brave" will keep people stuck, because of the choice to pin to old brave instead of add the version management of zipkin-reporter and then also add brave6 without it. This is the main thing, and well it isn't the end of the world. Thanks for listening.

for people who don't know, basically the only thing needed is to add zipkin-reporter-bom as a dep, that's it. This change would have worked if this was backported and if given the choice when I made the change surely I would have vs the rushed decision that happened https://github.com/openzipkin/zipkin-reporter-java?tab=readme-ov-file#version-alignments

please add me to code owners for the brave stuff to avoid this again. I really think this was the wrong decision and rushed.

here's the PR https://github.com/line/armeria/pull/5453
I think critically thinking this is and was a simple matter, and we can address simple things in a simple way. If LINE internal strictness ends up making things like this, it is hard for me to advocate it as a serious project for the community. There must be some middle ground if it is really about community here.

If LINE internal strictness ends up making things like this

To be clear, I don't think there was a unique dependency issue within LINE.
The issue was simply that brave had a major version bump, while Armeria had a minor version up. Since we try to avoid breaking changes between minor versions, we wanted to find a solution that minimizes breaking changes.
Between using brave6 or brave5 for armeria-brave, I think it is fine (and probably better) to use brave6 since I assume it would contain the most up-to-date changes of brave6. (I assume brave5 won't be receiving as many updates as brave6)
I took a quick look at the pull request, and I think it makes sense.

please add me to code owners for the brave stuff

Thanks! It would be lovely if you can also pitch in about brave/zipkin related changes 👍

I believe we rushed into this decision, which wasn't ideal. Thanks for addressing it.

please add me to code owners for the brave stuff to avoid this again. I really think this was the wrong decision and rushed.

Here it is. 😉 https://github.com/line/armeria/pull/5458


Added serverside rendering and metadata generation to library pages

Added serverside rendering to user-facing library pages

Apart from the sidebar, which is now using SWR caching

Added metadata generation, including Open Graph metadata, for the aforementioned library pages
Made thumbnail optional in the admin when creating media content, and disabled unnecessary data fetches

@OlivierJM So can we merge it now?


Session.run () takes a long time

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:N/A
TensorFlow installed from (source or binary): source
TensorFlow version (use command below):1.9.0
Python version:3.6
Bazel version (if compiling from source):N/A
GCC/Compiler version (if compiling from source):6.4.0
CUDA/cuDNN version:9.0 / 7.0
GPU model and memory:GeForce GTX960
Exact command to reproduce:N/A

Describe the problem
Each time tensorflow performs session.run() for target detection, the detection time of the first image is very long (including some initialization operations, of course), while the detection time of other images is normal. Suppose I detect the image under a certain path (for example, there are ten images), the time of detecting the first image is relatively long, and the remaining nine images are relatively short (basically consistent). However, my operation in practical application is as follows: the session.run() is called every once in a while to detect a picture. I hope that the detection time after the first one is normal except for the long time. However, through my test (guess), after exiting the loop logic of detection, tensorflow redid a series of initialization operations the next time the detection was done, which puzzled me.
With other frameworks, such as mxnet, initial detection takes longer. And then the detection time is normal, as if it's not doing some initialization anymore. I thought, could tensorflow do the same thing?
Source code / logs
2018-09-04 14:48:59.111510: W tensorflow/core/common_runtime/bfc_allocator.cc:219] Allocator (GPU_0_bfc) ran out of memory trying to allocate 3.57GiB. The caller indicates that this is not a failure, but may mean that there could be performance gains if more memory were available.
time：5627.940655ms
0.9999423027038574
time：657.650471ms
0.9996843338012695
time：676.565170ms
0.9722122550010681
0.6320008635520935
time：667.881966ms
0.996504545211792

Each time tensorflow performs session.run() for target detection, the detection time of the first image is very long (including some initialization operations, of course), while the detection time of other images is normal. Suppose I detect the image under a certain path (for example, there are ten images), the time of detecting the first image is relatively long, and the remaining nine images are relatively short (basically consistent). However, my operation in practical application is as follows: the session.run() is called every once in a while to detect a picture. I hope that the detection time after the first one is normal except for the long time. However, through my test (guess), after exiting the loop logic of detection, tensorflow redid a series of initialization operations the next time the detection was done, which puzzled me.
With other frameworks, such as mxnet, initial detection takes longer. And then the detection time is normal, as if it's not doing some initialization anymore. I thought, could tensorflow do the same thing?

I met a similar problem. It seems to be caused by some lazy operations. That means some operations will be executed until the graph actually runs.

@bignamehyp Is there a way to solve this problem?

Nagging Assignee @bignamehyp: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @bignamehyp: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @bignamehyp: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @bignamehyp: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @bignamehyp: It has been 90 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@gulingfengze is this still an issue? Could you load TF 1.12 (stable) or latest version and check whether the issue persists? It is will be good if you can share a simplified code to reproduce the issue. If it was solved by newer version, please close the issue. Thanks!

@jvishnuvardhan The latest version still has this problem, and my guess is that the program did some initialization like gpu at the beginning of execution.

@jvishnuvardhan I work on XLA, so this is outside of my area of ownership.

my guess is that the program did some initialization like gpu at the beginning of execution.

Quite possibly.  To address this, when you run configure.py, you need to ensure that you tell TF to build for sm_XY corresponding to your machine's GPU.

@gulingfengze
Please confirm if this is still an issue, or if possible use later stable versions of tf and let us know.


CI: Travis ERROR: Could not find a version that satisfies the requirement PyYAML==6.0

CI failure
Travis is unable to fetch some of the docs tooling dependencies:
#7 8.190 Collecting PyYAML==6.0
#7 8.195   Downloading PyYAML-6.0.tar.gz (124 kB)
#7 8.405   Installing build dependencies: started
#7 12.07   Installing build dependencies: finished with status 'done'
#7 12.07   Getting requirements to build wheel: started
#7 12.39   Getting requirements to build wheel: finished with status 'error'
#7 12.39   ERROR: Command errored out with exit status 1:
...
#7 12.39 ERROR: Could not find a version that satisfies the requirement PyYAML==6.0
#7 12.39 ERROR: No matching distribution found for PyYAML==6.0
#7 12.41 WARNING: You are using pip version 21.0.1; however, version 23.2 is available.
#7 12.41 You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
#7 ERROR: executor failed running [/bin/sh -c pip install -r /tmp/requirements.txt]: runc did not terminate sucessfully

Observed on main here: https://app.travis-ci.com/github/cilium/cilium/builds/264564427 (PR https://github.com/cilium/cilium/pull/26869)
And on v1.13 here: https://app.travis-ci.com/github/cilium/cilium/jobs/606180933 (PR https://github.com/cilium/cilium/pull/26861)

I'm receiving similar problems when running locally with make test-docs.
I found this issue that may be related. There's very recent comments that suggest this is affecting many projects currently.
https://github.com/yaml/pyyaml/issues/601

https://github.com/cilium/cilium/pull/26874 should fix the issue. could you try rebasing


update enable_secret_backend function to support kv version 2

Hi there,
to enable K/V-Store v2 (https://www.vaultproject.io/docs/secrets/kv/kv-v2.html) there need to be options with version set.
So then you can use it like
result = vault.enable_secret_backend('kv', mount_point='secrets', options={'version': '2'})

Thanks
Sebastian
Please have a look and let me know if you need more information / updates to the code

Hi @jeffwecan,
thanks for your quick response. This is my first time writing integration tests. Let me know if this fits your needs. I rebased the branch against master.
PTAL
Thanks
Sebastian

Looks good, thanks again!

FWIW, I am tentatively planning to cut a new release of this package (that will include this change) once https://github.com/ianunruh/hvac/pull/158 is merged. Hopefully within the next week or so.


Build fails when I tried to disable exceptions with XTENSOR_DISABLE_EXCEPTIONS

When I tried to disable exceptions by setting the XTENSOR_DISABLE_EXCEPTIONS macro, I found that xtensor-blas` did not follow the rule. When I replace the statement:
throw std::runtime_error(
with
XTENSOR_THROW(std::runtime_error,
in all files, it works.

Thanks for reporting. That's indeed a feature we forgot to implement in xtenosr-blas.

Fixed in #172

Fixed in #172


add misprediction handling to ID stage

Unfortunately, some unit tests fail.
/home/yan/mipt-mips/simulator/modules/core/t/unit_test.cpp:33: FAILED:
  CHECK_NOTHROW( sim.run( 1) )
due to unexpected exception with message:
  Port error:	BRANCH_2_FETCH WritePort was not initializated

As I understood, we should create new ports for misprediction case, special for DECODE
All those
    wp_flush_all = make_write_port<bool>("BRANCH_2_ALL_FLUSH", PORT_BW, FLUSHED_STAGES_NUM);
    wp_flush_target = make_write_port<Target>("BRANCH_2_FETCH_TARGET", PORT_BW, PORT_FANOUT);
    wp_bypassing_unit_flush_notify = make_write_port<bool>("BRANCH_2_BYPASSING_UNIT_FLUSH_NOTIFY",
                                                                PORT_BW, PORT_FANOUT);

    wp_bp_update = make_write_port<BPInterface>("BRANCH_2_FETCH", PORT_BW, PORT_FANOUT);

As I understood, we should create new ports for misprediction case, special for DECODE

Yes, for each new interconnection there should be an additional port or bandwidth/fanout increase of the existing port. The manual on port is available on Wiki: https://github.com/MIPT-ILab/mipt-mips/wiki/Communication-between-modules-through-ports

Could you tell me please how can I avoid mentioning "merge" commits when I create a pull request?

That's quite tricky.
You have to rebase your commits instead of merging, and you then have to force-push the rebased commits:
git pull --rebase upstream master # upstream is mipt-ilab/mipt-mips
git push origin master -f # origin is yanlo/mipt-mips

But I'm ok with merge commits, as we squash or rebase commits when we approve pull requests, and there are only few merges in the baseline; GitHub code review tool also shows only the actual changes.
In the beginning of the year we did an enhanced traning on Git, I recall you was not here. It does not answer your question, but I might help you with understanding Git basic abstractions, like merge commits or rebases: https://github.com/MIPT-ILab/sd-lectures/blob/master/mipt-mips/2018/Lecture 1 - Introduction. Version Control System.pptx

I think it will be more logical to create another pull request with right solution


[New Snap] Kadena

Checklist
All items in the list below needs to be satisfied.

[x] Is the Snap repository publicly accessible and linked in this ticket: https://github.com/kadena-community/kadena.js/tree/main/packages/libs/snap
[x] Is the Snap distributed on npm and linked in this ticket: https://www.npmjs.com/package/@kadena/snap
[x] Has an audit been performed and the audit report attached or linked in this issue:
[x] Is a complete list of discovered vulnerabilities from the audit documented in this issue?
[ ] For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue?
[ ] For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue?
[ ] The corresponding pull request in this repo has been merged.

Audit review
Auditor : Veridise
Report : https://veridise.com/wp-content/uploads/2024/10/VAR_Kadena_240909_kadena_snap_V3.pdf
Summary of the findings :

V-KDS2-VUL-001: Bugs when deleting active network
•	Severity: Warning
•	Status: Fixed
•	Description: Issues related to deleting the currently active network, which could result in the active network pointing to an invalid network ID or deleting the last active network and putting the snap in an inconsistent state.

V-KDS2-VUL-002: Account management code duplication
•	Severity: Informational
•	Status: Fixed
•	Description: Duplication of code in account management logic (for hardware and non-hardware accounts), which could increase the risk of bugs if the code isn’t updated uniformly.

Regarding the directory field for npm provenance check. This is something requested by the audit firm, because with that they can show that the npm release was built without tampering.
I think it's a great addition, but I don't see why we should prevent them from allowlisting while no other snap are using this. I suggested to the builder to push a new package without the directory field so that we can proceed with allowlisting until this goes through the MM extension (https://github.com/MetaMask/metamask-extension/pull/27376).


Refs #28428 -- Added pathlib.Path support to django.utils.encoding.filepath_to_uri().

Refs ticket 28428.
This is needed to support pathlib.Path in FileSystemStorage.url().

@hramezani Thanks! I fixed release notes and docs.


Get rid of IDEA files generation & modification

Remove code related to setting IJ IDEA up in *.ipr / *.iml files
project.idea.project.ipr {
    withXml { provider ->
        ...
    }
}

QA
Check that projects are imported correctly and IJ doesn't show any excess files

Reopen. Not all code was removed. See:

CubaPlugin.groovy:523
CubaPlugin.groovy:539


Local pull request success status testing

Docs Build status updates of commit 79d9d58:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 79d9d58:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


update Chinese translation for Bravo

Dear SQL BI team,
big congratulation to see the Bravo v1.0 ! Sorry for the late thank U because I am now back to China. I was seeking a solution to continue to access GitHub and YouTube.
Recently, I figured out that some translation don't work any more. There are of course some new columns added in Date Template but I can not find some translation which were merged with my pull request #444 either. It is a little bit weird for me, is there some specific reason which I am not aware about ?
Anyway I try now again to adjust Date localization json file and make some slight changes for Bravo UI.
Would it still be possible for you to take a look and merge it ?  I realize now there is custom template function, but I still prefer to make the default date template translation correct.
Sorry for bothering again and greeting you guys again from China !
BR.
Adams Modi

Hi @adamsmodi, thanks for this PR and for updating Chinese translation! I hope you can find a solution to keep accessing GitHub!

I can not find some translation which were merged with my pull request https://github.com/sql-bi/Bravo/pull/444 either. It is a little bit weird for me, is there some specific reason which I am not aware about?

Thanks for pointing it out! I just checked and realized that the date localization changes were inadvertently overwritten with the merge of PR https://github.com/sql-bi/Bravo/pull/480. I will fix this as soon as I can.
Thanks Adams!


What is the API to clear the session in electangular

Hi ,
I am developing application in angularJs and convert it into client application by using electron packager.All the functionalities working fine except the session clear while i do logout.
I am using Shibboleth for authentication. I injected the 'electangular' dependency in app.js
My code:
angular.module('wepaUI')
  .directive('wepaHeader', function () {
    return {
      restrict: 'A',
      replace: true,
      templateUrl: 'header/header.html',
      scope: {},
      controller: function ($scope, $location, session, electron) {
        $scope.isAuthenticated = function () {
          return session.isAuthenticated()
        }

        $scope.signOut = function () {
          session.destroy()
          electron.clearStorageData([] , function(data) {
          console.log(data)
           })
          $location.path('/login')
        }
      }
    }
  })

I am using clearStorageData() API to clear the shibboleth session. I am getting error like: clearStorageData() is not defined .It is the rightway to clear the session?
Please help me out from this issue

I'll take a look. Thanks for reporting.


Print GA progress

This PR closes #455. It adds support for printing logs about the GA progress. This is enabled by default when solving through the Model interface, but not for GA itself.
Some notes about padding:

Time has length 7 to support thousands with two decimals, e.g., 1000.22
Iterations has length 7 to support million iterations, e.g., 1234567
Cost has length 7 to support million cost with two decimals, e.g., 1234567.89 (or 100 million for integer costs)
Size has length 4 to support thousands, but it's mostly because "Size" itself is four characters long.

The output looks like this now:
---------------------------------- PyVRP v0.8.0a0 ----------------------------------

Solving an instance with 1 depot, 1000 clients, and 250 vehicles.

--------------------------------- Solver progress ----------------------------------

        Statistics         |          Feasible          |         Infeasible
  Iters   T (s)       Best | Size        Avg       Best | Size        Avg       Best

    500   20.32     479443 |   35   485108.2     479443 |   63  962815.03     477490
   1000   38.39     476639 |   29  483689.69     476639 |   62  1145673.5     475795
   1500   57.67     473231 |   56  479492.73     473231 |   60  842477.15     473860
   2000   75.91     471745 |   54  475801.57     471745 |   52  788709.33     469761
   2500   93.25     469561 |   60  474159.37     469561 |   52  472674.92     468855

------------------------------------- Summary --------------------------------------

Search terminated after 2704 iterations and 100.00 seconds.
Best-found solution has cost 468716.

--------------------------------------- End ----------------------------------------

I've split off the logging from the GA itself for now. Next steps are thinking about what to print, the interface, and add tests.

I'm working towards Gurobi-style logs. That's still a while off, but this is what I have so far:
PyVRP v0.6.3

Solving an instance with 1 depot, 100 clients, and 100 vehicles.

                |        Feasible        |       Infeasible
  Iters    Time | Size      Avg     Best | Size      Avg     Best
    500      2s |   43   281315   277073 |   46   279403   276050
   1000      3s |   61   278378   276099 |   50   276280   275119
   1500      4s |   36   277659   276099 |   57   276414   274916
   2000      5s |   62   277619   276099 |   62   276234   274916
   2500      6s |   39   277060   275944 |   26   276911   274761
   3000      7s |   32   276762   275928 |   32   275768   274745
   3500      8s |   64   277310   275928 |   40   275843   274745
   4000      9s |   63   278314   275928 |   48   276433   274411
   4500     10s |   53   279372   275928 |   55   277023   274411

Search terminated after 4646 iterations and 10s.
Best-found solution has cost 275928.

I'm trying to make some space in the table for additional information.

I think this is a pretty reasonable first attempt. All that's left is to finalise the interface and write more tests.

@leonlan can you review this?

LGTM!


Move TuyaZBMeteringCluster to init

Two small code improvements

Move TuyaZBMeteringCluster to __init__.py to avoid duplicated code
rename  zhaquirks/tuya/TS011F_plug.py → zhaquirks/tuya/ts011f_plug.py to be consistent with other files (and this gave a pylint warning locally) already done in #1070

Isort failed

Thanks!


Display an blank at the bottom after dragging the Graph

OS: All
Build Version: 20190325.3
Regression: Not a Regression
Repro Steps:

F1--> Run "Graph(Gremlin): Open Graph Explorer".
Drag the Graph-: pull it up -->pull it down.
Check the result.

Expect:
The Graph displays well.
Actual:
Display an blank at the bottom.

Closing as wontfix


Note timezone for S3

🚀 Deployed on https://62cf07663953251e70e54d39--cozy-fox-0defec.netlify.app


Configuration settable from outside

Added config argument to DbusService.init() to set the config file to use from outside
This is necessary for SetupHelper installation method (config file is located in /data/conf/dbus-opendtu.ini to be preserverd during updates)

Yes, I tested it.
What du you mean with verification? Should I add a check for the instance like below?
def _get_config(self):
    '''return the cached configuration object, read it before if not already done'''
    if self._config is None or not isinstance(self._config, configparser.ConfigParser):
        self._config = configparser.ConfigParser()
        self._config.read(f"{(os.path.dirname(os.path.realpath(__file__)))}/config.ini")
    return self._config

Some plausibility check will be helpful for some users E.g. file is readably and contains more than x bytes... Maybe something more...

I didn't see any validation in the code before. So I just added the init() argument...
Since the configuration file is parsed in dbus-opendtu.py beforehand, I think there should be a check, if any.
Btw, the ConfigParser itself does not perform any checks; the documentation states: If none of the named files exist, the instance ConfigParser contains an empty data set.

That's right. Since you started editing this part of the code, it might be a good idea to have checks in it. Don't you agree? I was only asking for it. Our software does not run without a config. Just check if the file is there and readable. No content checks.

When SetupHelper updates a package, a release archive is downdloaded and the old directory gets renamed (and removed when extraction was successful). So, during last update I lost my config inside the /data/dbus-opendtu directory... That's why I wanted to move the config out of the code directory.
@stlorenz I don't know how to handle your case with two DTU's right now. May be we'll find a solution?

Did you read my comment above? SetupHelper removes the whole old version directory including your config.ini. Your PR is similar to one I did before I knew this behavior.
I'll see if there is a solution with SetupHelper.


Improvement: Make the CLI work on windows

I did't have windows in mind when I started this; and I have little to no experience on that matter, so any help on this matter would be greatly appreciated.
I think Windows user for the Pypi package (CLI or python module) will be more and more common, since it's often the platform of beginners who use gitingest to learn about codebases
From the few tests I did it seems that \ and things such as C: in paths are not handled
This should be easily solvable by using the proper os API  or maybe pathlib

Hummm...
It's a common and frustrating issue.
I think a good way to fix it would also be to write unit tests that cover all the CLI features that handle paths and other OS-specific details.
It would then be possible to test them across multiple operating systems (Windows, macOS, Linux) using a Matrix in a GitHub Action.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow


Update remote theme for docs

Description
trying to fix the problem generating GH page
Type of change

Documentation update

Testing steps
Let's see if it fixes it on master...
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #883 (fde4fca) into master (9cbbb8b) will increase coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   60.25%   60.91%   +0.66%
==========================================
  Files          22       22
  Lines        3029     3116      +87
==========================================
+ Hits         1825     1898      +73
- Misses        996     1004       +8
- Partials      208      214       +6

Impacted Files
Coverage Δ

content/content.go
82.17% <0.00%> (+0.86%)
:arrow_up:

server/server.go
61.48% <0.00%> (+2.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbbb8b...fde4fca. Read the comment docs.

closing because no activity in 1 year


Lab shouldn't store access credentials in .gitconfig

It's not uncommon for users to version control their dotfiles. A common file to version control is ~/.gitconfig.
Lab currently stores and retrieves a users access token from git config. Having my Gitlab access token stored in .gitconfig means that I can no longer version control this file, which it important to me as this file contains shared configuration for all of my projects on my system.
If I understand the documentation for Lab currently, I could add my access credentials to .git/config in each projects repository on my system, but this is a very tedious and cumbersome workaround to the issue.
github/hub Helps it's users in this case by storing access tokens in an application specific config file ~/.config/hub, which is a file that's less likely to be version controlled by users. I think Lab should use a similar solution, or at least provide it as an alternative credential store to the current git config system.
github/hubs implementation is here, if it helps.

Thanks @JoeNyland, this seems like a fair assessment of current situation and I appreciate that you have specific usecases in mind. I've been talking about adding a config file for a few different things now. I'll move the global credentials in there when the time comes.

No worries! Ok, that sounds great! 🎉

@JoeNyland Planning to implement these changes soon and I wanted to offer a possible workaround in the meantime.
It looks like git 1.7.10+ supports sourcing other files for your .git config.
Ref: https://stackoverflow.com/questions/1557183/is-it-possible-to-include-a-file-in-your-gitconfig
I do something similar with my .bashrc by referencing a .bashrc.local.
This works for me using
$ git version
git version 2.11.0
lab version 0.5.2

.gitconfig
[user]
        name = Zaq? Wiedmann
        email =<EMAIL_ADDRESS>[include]
        path = .gitconfig.local

.gitconfig.local
[gitlab]
        host = https://gitlab.com
        user = lab-testing

I think this has been solved. Closing it.

Not quite, it'll go out in 0.8.0


[Bug] Unable to select dates when including initial dates

Describe the bug
I am looking to implement a multi select. If I include a list of dates for when the widget loads they appear but I am then unable to select (or deselect) any dates. If I do not include an initial list of dates I can select and deselect dates.
Expected behavior
I am expecting to be able to select and unselect multiple dates.
Platforms (please complete the following information):

Platforms: Web

Minimum Reproduceable Example
import 'package:calendar_date_picker2/calendar_date_picker2.dart';
final today = DateUtils.dateOnly(DateTime.now());
class InstallerDatePickerV1 extends StatefulWidget {
const InstallerDatePickerV1({
Key? key,
this.width,
this.height,
}) : super(key: key);
final double? width;
final double? height;
@override
_InstallerDatePickerV1State createState() => _InstallerDatePickerV1State();
}
class _InstallerDatePickerV1State extends State {
List<DateTime?> _dates = FFAppState().installerAvailCallBack;
int convertDateTimeToIsoInt(DateTime date) {
int year = date.year;
int month = date.month;
int day = date.day;
return year * 10000 + month * 100 + day;
}
void _onValueChanged(dynamic value) {
if (value is List<DateTime?>) {
setState(() {
_dates = value;
List isoIntDates = _dates
.where((date) => date != null)
.map((date) => convertDateTimeToIsoInt(date!))
.toList();
FFAppState().installerAvailability = isoIntDates;
});
}
}
@override
Widget build(BuildContext context) {
return CalendarDatePicker2(
config: CalendarDatePicker2Config(
calendarType: CalendarDatePicker2Type.multi,
firstDate:
DateTime.now().subtract(Duration(days: 1)), // Updated this line
selectedDayHighlightColor: FlutterFlowTheme.of(context).primary,
),
value: _dates,
onValueChanged: (dates) {
_onValueChanged(dates);
},
);
}
}

I also have this issue.

Hi @adamrUK84 , I couldn't run your code. Have you tried out the example app?

Yes. It works for the example:
List<DateTime?> _dates = [
DateTime(today.year, today.month, 1),
DateTime(today.year, today.month, 5),
DateTime(today.year, today.month, 14),
DateTime(today.year, today.month, 17),
DateTime(today.year, today.month, 25),
];
But if you try to pass a list of dates it doesn't work.
On Sat, 8 Apr 2023 at 14:40, Neo Liu @.***> wrote:

Hi @adamrUK84 https://github.com/adamrUK84 , I couldn't run your code.
Have you tried out the example app?
—
Reply to this email directly, view it on GitHub
https://github.com/theideasaler/calendar_date_picker2/issues/98#issuecomment-1500894139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7BH5XRO7UOA4QT5R4DQEBDXAFTFLANCNFSM6AAAAAAWW6IGDQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This email may contain
confidential and/or legally privileged
information. If you are not the intended
recipient (or have received this
email in error) please notify the sender
immediately and delete this
e-mail. Any unauthorised copying, disclosure, or
distribution of the
material in this email is strictly forbidden.

@adamrUK84 I used the same values but I can select and deselect the values after firstDate without a problem

Yes it works for those values. But if you try and pass a list from say a
page parameter it doesn't work. For example like this:
import 'package:calendar_date_picker2/calendar_date_picker2.dart'; final
today = DateUtils.dateOnly(DateTime.now()); class InstallerDatePickerV1
extends StatefulWidget { const InstallerDatePickerV1({ Key? key,
this.width, this.height, required this.priorDates, }) : super(key: key);
final double? width; final double? height; final List<DateTime?>
priorDates; @override _InstallerDatePickerV1State createState() =>
_InstallerDatePickerV1State(); } class _InstallerDatePickerV1State extends
State { List<DateTime?> _dates; @override void
initState() { super.initState(); _dates = widget.priorDates; } @override
Widget build(BuildContext context) { return CalendarDatePicker2( config:
CalendarDatePicker2Config( calendarType: CalendarDatePicker2Type.multi,
selectedDayHighlightColor: Colors.blue, ), value: _dates, onValueChanged:
(dates) => setState(() => _dates = dates), ); } }
On Sat, 8 Apr 2023 at 16:40, Neo Liu @.***> wrote:

@adamrUK84 https://github.com/adamrUK84 I used the same values but I
can select and deselect the values after firstDate without a problem
—
Reply to this email directly, view it on GitHub
https://github.com/theideasaler/calendar_date_picker2/issues/98#issuecomment-1500917118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7BH5XUGDCUSU3BVAB45C7DXAGBG7ANCNFSM6AAAAAAWW6IGDQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
This email may contain
confidential and/or legally privileged
information. If you are not the intended
recipient (or have received this
email in error) please notify the sender
immediately and delete this
e-mail. Any unauthorised copying, disclosure, or
distribution of the
material in this email is strictly forbidden.

Sorry the above didn't format properly. Here it is again:
import 'package:calendar_date_picker2/calendar_date_picker2.dart';
final today = DateUtils.dateOnly(DateTime.now());
class InstallerDatePickerV1 extends StatefulWidget {
const InstallerDatePickerV1({
Key? key,
this.width,
this.height,
required this.priorDates,
}) : super(key: key);
final double? width;
final double? height;
final List<DateTime?> priorDates;
@OverRide
_InstallerDatePickerV1State createState() => _InstallerDatePickerV1State();
}
class _InstallerDatePickerV1State extends State {
List<DateTime?> _dates;
@OverRide
void initState() {
super.initState();
_dates = widget.priorDates;
}
@OverRide
Widget build(BuildContext context) {
return CalendarDatePicker2(
config: CalendarDatePicker2Config(
calendarType: CalendarDatePicker2Type.multi,
selectedDayHighlightColor: Colors.blue,
),
value: _dates,
onValueChanged: (dates) => setState(() => _dates = dates),
);
}
}

Sorry the above didn't format properly. Here it is again:
import 'package:calendar_date_picker2/calendar_date_picker2.dart';
final today = DateUtils.dateOnly(DateTime.now());
class InstallerDatePickerV1 extends StatefulWidget { const InstallerDatePickerV1({ Key? key, this.width, this.height, required this.priorDates, }) : super(key: key); final double? width; final double? height; final List<DateTime?> priorDates; @OverRide _InstallerDatePickerV1State createState() => _InstallerDatePickerV1State(); }
class _InstallerDatePickerV1State extends State { List<DateTime?> _dates; @OverRide void initState() { super.initState(); _dates = widget.priorDates; }
@OverRide Widget build(BuildContext context) { return CalendarDatePicker2( config: CalendarDatePicker2Config( calendarType: CalendarDatePicker2Type.multi, selectedDayHighlightColor: Colors.blue, ), value: _dates, onValueChanged: (dates) => setState(() => _dates = dates), ); } }

Created same widget and placed it inside the example app and I still don't have any issue with it.
InstallerDatePickerV1(
      priorDates: [
        DateTime(today.year, today.month, 1),
        DateTime(today.year, today.month, 5),
        DateTime(today.year, today.month, 14),
        DateTime(today.year, today.month, 17),
        DateTime(today.year, today.month, 25),
      ],
    );

I'm still having the issue. Here is some updated code. Using the dayWidget I can get a dot to be displayed for the days contained within the priorDates list (as well as dates to be not selectable for the dates contained in the bookedDates list - including decorations). When the widget loads the days are selected, however I still have the issue that these dates can not be deselected or any other days in the widget selected or deselected:
import 'package:calendar_date_picker2/calendar_date_picker2.dart';
final today = DateTime.now();
class InstallerDatePickerV1 extends StatefulWidget {
const InstallerDatePickerV1({
Key? key,
this.width,
this.height,
this.bookedDates,
this.priorDates,
}) : super(key: key);
final double? width;
final double? height;
final List<DateTime?>? bookedDates;
final List<DateTime?>? priorDates;
@override
_InstallerDatePickerV1State createState() => _InstallerDatePickerV1State();
}
class _InstallerDatePickerV1State extends State {
List<DateTime?> _dates = [];
@override
void initState() {
super.initState();
Set priorDatesSet = widget.priorDates
?.map((dateTime) =>
DateTime(dateTime!.year, dateTime!.month, dateTime!.day))
.toSet() ??
{};
_dates = priorDatesSet.toList();
}
int convertDateTimeToIsoInt(DateTime date) {
int year = date.year;
int month = date.month;
int day = date.day;
return year * 10000 + month * 100 + day;
}
void _onValueChanged(dynamic value) {
if (value is List<DateTime?>) {
setState(() {
_dates = value;
List isoIntDates = _dates
.where((date) => date != null)
.map((date) => convertDateTimeToIsoInt(date!))
.toList();
FFAppState().installerAvailability = isoIntDates;
});
}
}
@override
Widget build(BuildContext context) {
Set bookedDatesSet = widget.bookedDates
?.map((dateTime) =>
DateTime(dateTime!.year, dateTime!.month, dateTime!.day))
.toSet() ??
{};
Set<DateTime> priorDatesSet = widget.priorDates
        ?.map((dateTime) =>
            DateTime(dateTime!.year, dateTime!.month, dateTime!.day))
        .toSet() ??
    {};

final specialDateDecoration = BoxDecoration(
  borderRadius: BorderRadius.circular(5),
  color: FlutterFlowTheme.of(context).primary.withOpacity(0.5),
);

return CalendarDatePicker2(
  config: CalendarDatePicker2Config(
    calendarType: CalendarDatePicker2Type.multi,
    firstDate: DateTime.now(),
    selectedDayHighlightColor: FlutterFlowTheme.of(context).primary,
    selectableDayPredicate: (date) {
      return !bookedDatesSet.contains(date);
    },
    dayBuilder: ({
      required date,
      textStyle,
      decoration,
      isSelected,
      isDisabled,
      isToday,
    }) {
      Widget dayWidget = Container(
        decoration: decoration,
        child: Center(
          child: Text(
            MaterialLocalizations.of(context).formatDecimal(date.day),
            style: textStyle,
          ),
        ),
      );

      if (bookedDatesSet
          .contains(DateTime(date.year, date.month, date.day))) {
        dayWidget = Stack(
          alignment: AlignmentDirectional.center,
          children: [
            Container(
              decoration: specialDateDecoration,
              height: 38,
              width: 38,
            ),
            Padding(
              padding: const EdgeInsets.only(top: 27.5),
              child: Container(
                height: 4,
                width: 4,
                decoration: BoxDecoration(
                  borderRadius: BorderRadius.circular(5),
                  color: isSelected == true ? Colors.white : Colors.white,
                ),
              ),
            ),
            Center(
              child: Text(
                MaterialLocalizations.of(context).formatDecimal(date.day),
                style: textStyle?.copyWith(color: Colors.white),
              ),
            ),
          ],
        );
      }

      if (priorDatesSet
              .contains(DateTime(date.year, date.month, date.day)) &&
          !bookedDatesSet
              .contains(DateTime(date.year, date.month, date.day))) {
        dayWidget = Stack(
          children: [
            dayWidget,
            Positioned(
              top: 4,
              left: 24,
              child: Container(
                height: 4,
                width: 4,
                decoration: BoxDecoration(
                  borderRadius: BorderRadius.circular(5),
                  color: isSelected == true ? Colors.white : Colors.blue,
                ),
              ),
            ),
          ],
        );
      }

      return dayWidget;
    },
  ),
  value: _dates,
  onValueChanged: (dates) {
    setState(() {
      _onValueChanged(dates);
      // Do any additional operations with the dates if required
    });
  },
);

}
}

If you remove the below from the code all dates apart from the dates in bookedDates are selectable / deselectable. And the dates included in priorDates have the decoration (i.e. a dot) showing. What I am trying to achieve which I think the widget is able to do is load up any dates that have been previously selected by a user.
@OverRide
void initState() {
super.initState();
Set priorDatesSet = widget.priorDates
?.map((dateTime) =>
DateTime(dateTime!.year, dateTime!.month, dateTime!.day))
.toSet() ??
{};
_dates = priorDatesSet.toList();
}

@adamrUK84 Thanks for the updates. I think I can manage to repro this issue now. It will be fixed.

@adamrUK84 This issue should be fixed in the new release https://pub.dev/packages/calendar_date_picker2

Thank you. I'm sorry though I'm still getting the same issue in the new release.

@adamrUK84 Could you please create a minimum repo with the reproducible issue with the latest version v0.5.1?

Thanks. I've invited you to the test repository I've set up.

Issue closed due to lack of response


Add cli log flag

Added --log flag in cli arguments to set log level for issue #44

Thanks.

@jovanwongzixi I recently added a CLA, can you please sign it here - https://cla-assistant.io/codelion/optillm


Security scan on openzipkin/zipkin:2.23.2 (Zipkin Server --> zipkin-server-2.23.2-exec.jar) identified a vulnerability CVE-2021-22118. Needed a patch of zipkin server having 5.3.7 version of Spring Framework which will fix the vulnerability.

CVE-2021-22118 description.: -  In Spring Framework, versions 5.2.x prior to 5.2.15 and versions 5.3.x prior to 5.3.7, a WebFlux application is vulnerable to a privilege escalation: by (re)creating the temporary storage directory, a locally authenticated malicious user can read or modify files that have been uploaded to the WebFlux application, or overwrite arbitrary files with multipart request data. Currently the latest Zipkin Server 2 23.5v is using 5.3.2 version Spring Framework which is vulnerable.
Steps to Reproduce: - Run a security scan using security scanning tool.
Expected Behaviour
Needed a patch of zipkin server having 5.3.7 version of Spring Framework which will fix the vulnerability i.e. Update Zipkin Server to remove the vulnerability.

These should be addressed by 2.23.9 so going to close this ticket.


Fix cosmos pipeline

Description
Fix cosmos pipeline
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/check-enforcer override

Hi @alzimmermsft @srnagar @g2vinay @conniey, could one of you help approve the changes below '.vscode'?


Anti Afk mouse move Improve

can you add "small" mouse move every specific time instead spin your character 360 degrees bc is sus, if admin tp to you and if they see... you are bypassing anti afk then he ban you

The feature has been added let me know if find any bugs.


test: integration

[ ] #22
[ ] test: integration mapinf
[ ] test: integration multi unit

#24 and #23 motor debug and mesh updated with #20 and #16


Implement support for Awake command line arguments.

Thanks a lot, I'll check it out. However I'm on a trip will not get back before late Saturday, so it might take some time...

No rush, thanks!
On Thu, Dec 2, 2021 at 2:17 AM Philip Gerke @.***>
wrote:

Thanks a lot, I'll check it out. However I'm on a trip will not get back
before late Saturday, so it might take some time...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pgerke/streamdeck-awake/pull/2#issuecomment-984354701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYI7B4LWLA4PZOLY2C5SUDUO4MSFANCNFSM5JFZCYKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


gatewayclass does not reach Accepted: True state in AWS

Description:
After trying out Envoy Gateway, I have installed it on an EKS cluster in AWS (EKS).
However, when adding my first GatewayClass resource, the resource is not accepted and the control plane reports it as "not found" despite it being returned with a k get gatewayclass.
The log message seems incorrect and describing the resource provides no further clues on where to look.  I don't think this is a bug as identical GatewayClass resource works fine on a local kind cluster.  However, without any further information from the logs, it's unclear what has gone wrong.
Install was via helm in to a custom namespace a-envoy-gateway.  Envoy Gateway version = 0.6.0.  Control plane version is 1.26.
GatewayClass:
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
  name: aws-nlb-internal
spec:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
  parametersRef:
    group: gateway.envoyproxy.io
    kind: EnvoyProxy
    name: gatewayclass-config-aws-nlb-internal
    namespace: a-envoy-gateway

EnvoyProxy:
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: gatewayclass-config-aws-nlb-internal
  namespace: a-envoy-gateway
spec:
  provider:
    kubernetes:
      envoyDeployment:
        container:
          image:<PHONE_NUMBER>111.dkr.ecr.us-east-1.amazonaws.com/mymirror/index.docker.io/envoyproxy/envoy:distroless-v1.28-latest
      envoyService:
        annotations:
          service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip
          service.beta.kubernetes.io/aws-load-balancer-scheme: internal
          service.beta.kubernetes.io/aws-load-balancer-type: external
    type: Kubernetes

Envoy Gateway logs (relevant logs after GatewayClass is added):
2024-03-10T11:26:37.508Z        INFO    provider        kubernetes/predicates.go:37     gatewayclass has matching controller name, processing   {"runner": "provider", "name": "aws-nlb-internal"}
2024-03-10T11:26:37.508Z        INFO    provider        kubernetes/controller.go:154    reconciling gateways    {"runner": "provider"}
2024-03-10T11:26:37.508Z        INFO    provider        kubernetes/controller.go:1639   processing envoyproxy   {"runner": "provider", "namespace": "a-envoy-gateway", "name": "gatewayclass-config-aws-nlb-internal"}
2024-03-10T11:26:37.508Z        INFO    provider        kubernetes/controller.go:365    No gateways found for accepted gatewayclass     {"runner": "provider"}
2024-03-10T11:26:37.508Z        INFO    provider        kubernetes/controller.go:387    reconciled gateways successfully        {"runner": "provider"}
2024-03-10T11:26:37.509Z        INFO    provider        status/status.go:122    received a status update        {"runner": "provider", "namespace": "", "name": "aws-nlb-internal"}
2024-03-10T11:26:37.512Z        ERROR   provider        status/status.go:100    unable to update status {"runner": "provider", "name": "aws-nlb-internal", "namespace": "", "error": "gatewayclasses.gateway.networking.k8s.io \"aws-nlb-internal\" not found"}

GatewayClass status:
Name:         aws-nlb-internal
Namespace:
API Version:  gateway.networking.k8s.io/v1
Kind:         GatewayClass
Spec:
  Controller Name:  gateway.envoyproxy.io/gatewayclass-controller
  Parameters Ref:
    Group:      gateway.envoyproxy.io
    Kind:       EnvoyProxy
    Name:       gatewayclass-config-aws-nlb-internal
    Namespace:  a-envoy-gateway
Status:
  Conditions:
    Last Transition Time:  1970-01-01T00:00:00Z
    Message:               Waiting for controller
    Reason:                Waiting
    Status:                Unknown
    Type:                  Accepted
Events:                    <none>

And finally, a simple get of the gatewayclass object to show it does exist:
❯ k get gatewayclass
NAME               CONTROLLER                                      ACCEPTED   AGE
aws-nlb-internal   gateway.envoyproxy.io/gatewayclass-controller   Unknown    3m39s

I've tried simplifying the GatewayClass config by removing the parametersRef field but the result is the same.
I'm at a loss here and similar config has worked locally but the log message about not finding the aws-nlb-internal seems very suspicious.
I'd appreciate any pointers in where I should look next.

@wimnat maybe its a issue around RBAC, does the controller have access to write status into gatewayclass (cluster scoped resource) in this specific environment ?

It doesn't seem to be.  I tried a few things:

Tested with kubectl can-i.

❯ k auth can-i update GatewayClass --as=system:serviceaccount:a-envoy-gateway:envoy-gateway
Warning: resource 'gatewayclasses' is not namespace scoped in group 'gateway.networking.k8s.io'

yes

And checked the deployment is using that service account as expected.
❯ k get deployment envoy-gateway -n a-envoy-gateway -o yaml | grep serviceAccount
      serviceAccount: envoy-gateway
      serviceAccountName: envoy-gateway

Checked the k8s audit log.  I can see a message that relates to what the controller says (i.e. not found rather than not authorised):

@arkodg do you know what the update is supposed to look like?  I.e. I wonder if i could just recreate the HTTP PUT or PATCH via curl and try that via k proxy to see what happens.

I discovered the problem and it is now resolved.
The CRDs installed on to the cluster were missing the subresrouce.status fields.
The reason they were missing these fields is because I was rendering the helm chart using jsonnet.  When using the std.parseYaml library on the chart, it fails because there are empty objects defined in the chart.  You can see these empty objects if you download https://github.com/envoyproxy/gateway/releases/download/latest/install.yaml and check out all of the envoygateway CRDs.  The comment about the CRD is actually in a different yaml document (separated by ---) to the CRD itself.  This makes the yaml doc null.  Example in the screenshot below.

So to get around this error in jsonnet I used the std.prune function to drop those empty objects.  However, std.prune is recursive so it went through the whole CRD and dropped other empty objects like subresrouce.status: {}.
The fix was to switch to use std.filter instead so there is no recursion.  The CRDs are now rendered correctly.
In a perfect world, the rendering of the install.yaml could be fixed so the comment is in the correct place and not in its own empty yaml doc but for now things are working for me 👍

glad you got it to work @wimnat, can you raise a follow up GH issue with some prescriptive suggestions on how to improve the generated helm chart ?


New color painting/matching criterion

Do matching based on redshift alone, subject to further cuts:

ZSRC < 4.5
ZLENS < 3
200 < VELDISP < 300 (target matches to most massive galaxies)

Hey @drphilmarshall , I'm using my own naive redshift matching, which just finds the lens/qso in the sloan reference with the closest redshift to each simulated object and assigns the sim that color. Quasar painting looks good (there had been a bug before--on my end, not Adri's), but for the lenses there are a good number of color outliers at low redshift, especially in g-r for z < 0.2 -- any thoughts?

Looks like some blue galaxies, perhaps with spatially unresolved high
rotation velocities? I suggest cutting them out with a g-r plus i-r color
box (they seem to form a sequence at r-i ~ 0.0 and g-r >~ 0.2 or so) - what
do you think?
On Tue, Jul 14, 2015 at 6:33 AM, Mike Baumer<EMAIL_ADDRESS>wrote:

Hey @drphilmarshall https://github.com/drphilmarshall , I'm using my
own naive redshift matching, which just finds the lens/qso in the sloan
reference with the closest redshift to each simulated object and assigns
the sim that color. Quasar painting looks good (there had been a bug
before--on my end, not Adri's), but for the lenses there are a good number
of color outliers at low redshift, especially in g-r for z < 0.2 -- any
thoughts?
[image: image]
https://cloud.githubusercontent.com/assets/7607631/8674316/0ace2732-2a35-11e5-99ea-1baeb5366de0.png
—
Reply to this email directly or view it on GitHub
https://github.com/drphilmarshall/OM10/issues/25#issuecomment-121238469.

OK, I put in cuts demanding g-r < 3, r-i > 0, and i-z > 0. The plots look much better, but I think now we should discuss the issue of high-redshift colors (column 1 of attached plot).
Right now, my redshift matching is grabbing the colors of the object with the closest z, but for all objects with z > ~1, this is simply the highest redshift object in the reference catalog, meaning all lenses past z=1 have exactly the same color. This isn't ideal, but do you think it's ok for the first pass? I could put in some (true) variation by randomly choosing colors from the N closest reference redshifts or something...

In fact, for my needs I bypassed it because I was drawing from a distribution with interpolated mean and interpolated covariances. I think this alleviates the problem because it blurs things. If you want to improve on it, besides adding higher-z galaxies, you can try to draw from a sort of de-trended distribution:
-- use spectral templates (Mannucci; Kinney and Calzetti; ...) to set the average colour with redshift
-- use them to determine the average colour as fnct.of z
-- in the detrended colours (swarm-minus-template) at 0<z<1, check if the std.dev. in colour varies with z, extrapolate it to higher z
-- given a galaxy at z>1, draw its magnitudes/colours from the template plus a scatter given by the extrapolated std.dev.
Same goes for the i-band magnitude as fnct. of z and sigma (or whatever magnitude you're using as the reference one).

Let's go with Adri's first suggestion and investigate templates. I think we'll end up with a more flexible system.


cannot set PYTHONPATH?

This plugin seems to work well setting our environment variables.
There is one var in particular, however, which doesn't seem to be set when we put it in the env file. That is PYTHONPATH.
My test was to place PYTHONPATH in the run config env vars and print out the var to console. This worked.
When I placed PYTHONPATH in the .env file and printed the var out to console, this did not work. However, other vars did.

Hm, interesting, I will try that out.

Extending PYTHONPATH works for me in run configurations; intellij (with Python plugin) does not pick it up in editor for code completion, but I did not expect it to. One problem was that my .env file got somehow detected wrong, or something. I did not investigate why. I had to copy .env into my.env and add it again to run configuration, then it all worked

I was wondering why this issues sounds familiar to me but couldn't figure it out until you brought up PYTHONPATH.
PyCharm handles it in a special way and my personal rule of thumb is to avoid touching it as much as I can.
To the best of my knowledge it won't work with many (or any?) other envfile implementations, but you can leverage the EnFIle variable substitution as discussed in https://github.com/ashald/EnvFile/issues/88.


2 heaters, item shows, but no parameters shown

Prerequisite

[X] Yes, I've read the readme completely.

Cache

[X] Yes, I've cleaned accessory cache and the issue still exists.

Version
1.7.0-beta.51
Device Infomation JSON File
is attached, otherwise too big (max is 65536 characters

Device Control Mode
None
Logs
No response
Other Infomations
expect to see some details, even on/off... is totally blank.
can toggle on off by pressing on the left part of the device where all the devices in a room are listed, but that is all.
it's about these two devices:
[10/14/2023, 10:07:39 PM] [@0x5e/homebridge-tuya-platform] Restoring existing accessory from cache: Panel heater
[10/14/2023, 10:07:39 PM] [@0x5e/homebridge-tuya-platform] Restoring existing accessory from cache: LSC IR Panel Heater
Have 2 different small appliance heaters - nothing displays within the home app for device settings
TuyaDeviceList.eu1650895720019C93IQ.json
empty panel with no attributes or parameters.pdf

I have the same issue, no control options when clicking on a panel heater tile in the Home app - iPhone 14 Pro iOS 17.1.

Strangely, when using the macOS app (Ventura 13.6), the controls show up as expected...

interesting... on macOS Sonoma 14.1, it's the same as on the iPhone and iPad, no controls

Unfortuntaley I can't upgrade to Sonoma, Macbook isn't (officially) supported, so not able to see if that would be the same for me. Seems maybe it's an issue with the latest Home app?

In the plugin settings change category: "qn" (heater) to catergory: "wk" (thermostat).
This is working for me until this bug is fixed.

Yes! That's worked Bat-Maniac, cheers.

I tried this, but no change. I removed from cache, restarted...
"deviceOverrides": [
{
"id": "global",
"schema": [
{
"code": "qn",
"newCode": "wk"
}
]
}
],

@DolmensDude,
wrong code.
Try this:
"deviceOverrides": [
            {
                "id": "device_ID",
                "category": "wk"
            }
]

Or simply change category in plugin device settings:

thanks. I saw global override and thought it would work... workaround does work using the actual ID :-)


Added button + function for removing non-ens addresses

The function is still a bit slow, would filtering the ens names through the backend make this considerably faster?

The function is still a bit slow, would filtering the ens names through the backend make this considerably faster?

Have you tried running this against 40 or more signed in guests?
To improve the speed the optimal way would be to have an api that resolves an array of addresses.

This would require making a seperate api folder because the current backend is firebase


Updated dependency in composer.json to use guzzlehttp/guzzle instead of guzzle/guzzle

laravel/socialite and others depending on this package display

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

so I've update the guzzle dependency.
Tests seem to run just fine
gabriel@~:oauth1-client (git:master) $ phpunit
PHPUnit 4.8.26 by Sebastian Bergmann and contributors.
Warning:	The Xdebug extension is not loaded
		No code coverage will be generated.

.....................................

Time: 212 ms, Memory: 8.75MB

OK (37 tests, 114 assertions)

I'll need to test this - I have a feeling the 1.x tests are mocking a little too much and so we may. D seeing false positives.
I'll update you when I get a chance to either validate there are no false positives, or if there are, fix the tests and the code.
Sent from my iPhone
Please excuse my brevity

On 20 Jul. 2016, at 12:53 am, Gabriel Sosa<EMAIL_ADDRESS>wrote:
laravel/socialite and others depending on this package display
Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.
so I've update the guzzle dependency.
Tests seem to run just fine
gabriel@~:oauth1-client (git:master) $ phpunit
PHPUnit 4.8.26 by Sebastian Bergmann and contributors.
Warning:    The Xdebug extension is not loaded
No code coverage will be generated.
.....................................
Time: 212 ms, Memory: 8.75MB
OK (37 tests, 114 assertions)
You can view, comment on, or merge this pull request online at:
https://github.com/thephpleague/oauth1-client/pull/71
Commit Summary
updated dependency to use guzzlehttp/guzzle instead of guzzle/guzzle
File Changes
M composer.json (2)
Patch Links:
https://github.com/thephpleague/oauth1-client/pull/71.patch
https://github.com/thephpleague/oauth1-client/pull/71.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks.
I can go and check if you can guide me where to look into.
I just want to have a minor or some small release ASAP so we can remove
that ugly yellow banner that appears on every composer update ;)
Best regards
On Jul 19, 2016 11:52 PM, "Ben Corlett"<EMAIL_ADDRESS>wrote:

I'll need to test this - I have a feeling the 1.x tests are mocking a
little too much and so we may. D seeing false positives.
I'll update you when I get a chance to either validate there are no false
positives, or if there are, fix the tests and the code.
Sent from my iPhone
Please excuse my brevity

On 20 Jul. 2016, at 12:53 am, Gabriel Sosa<EMAIL_ADDRESS>wrote:
laravel/socialite and others depending on this package display
Package guzzle/guzzle is abandoned, you should avoid using it. Use
guzzlehttp/guzzle instead.
so I've update the guzzle dependency.
Tests seem to run just fine
gabriel@~:oauth1-client (git:master) $ phpunit
PHPUnit 4.8.26 by Sebastian Bergmann and contributors.
Warning: The Xdebug extension is not loaded
No code coverage will be generated.
.....................................
Time: 212 ms, Memory: 8.75MB
OK (37 tests, 114 assertions)
You can view, comment on, or merge this pull request online at:
https://github.com/thephpleague/oauth1-client/pull/71
Commit Summary
updated dependency to use guzzlehttp/guzzle instead of guzzle/guzzle
File Changes
M composer.json (2)
Patch Links:
https://github.com/thephpleague/oauth1-client/pull/71.patch
https://github.com/thephpleague/oauth1-client/pull/71.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thephpleague/oauth1-client/pull/71#issuecomment-233824974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADw6imgQO2FcX6jXG769H1UfgClV0VZks5qXY1RgaJpZM4JP0Bv
.

The issue here is nearly everybody requires guzzlehttp/guzzle with a constraint up in the ^6 arena. So, we'll need to make it compatible with a newer version to play nicely.

See this branch.
I'm still not happy with the amount of mocking we're doing here, but since a V2 release is imminent, I'll test the package myself tomorrow and validate I haven't made some silly error before releasing a patch update to end users.

Hi @bencorlett do we have an update on this?

No. I did not get time to look at it so I will on Monday

Hi  @bencorlett!
Were you able to test? Thank you!

Hey guys,
First of all, I know you are super busy and the whole community really appreciate your hard work. But how can we help in any way so you can release a new tag for this package?
Best Regards

Heya Gabriel,
I must apologise for this, I have been super under the pump (getting ready for a holiday), however I am going to set aside some time right now to look at this and get to some sort of resolution. Stand by :)

On 17 Aug 2016, at 3:25 AM, Gabriel Sosa<EMAIL_ADDRESS>wrote:
Hey guys,
First of all, I know you are super busy and the whole community really appreciate your hard work. But how can we help in any way so you can release a new tag for this package?
Best Regards
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/thephpleague/oauth1-client/pull/71#issuecomment-240174858, or mute the thread https://github.com/notifications/unsubscribe-auth/AALGn_rJNSnpi-Q4QN7ouCD0jp-TbFnUks5qgfKlgaJpZM4JP0Bv.

FWIW, I've been testing the branch update-v1-to-guzzle-v6 for a few days and it seems to work fine, at least with Twitter.

Thank you very much for your help @pendexgabo, I have combined both your code and @guss77's code (from #75) to combine and mega into master. I have released Version 1.7 which supports the latest version of Guzzle.
Enjoy! ✌

Thank you very much. Enjoy your holidays!


added resnet50 model

@sumitmamtani  Please add proper description next time. Let me know:

If any blockers
How to run the code
Overall objective and logic

Accepting PR now.


prompt template not found

prompt_template.md is not found

sorry for that, please go to this link to get template, thanks!


Add. __tostring methods to classes.

Coverage decreased (-0.1%) to 61.331% when pulling 479636f5bca9152c5670f766c5fc143b839f3c84 on moteus:master into 9ac72c75a4f915e25a309e2574c78814aa8c2fcb on Lua-cURL:master.


Default values not working

Checks

[X] I have checked for existing issues.
[X] This report is about the User-Community Airflow Helm Chart.

Chart Version
latest
Kubernetes Version
Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.3", GitCommit:"9e644106593f3f4aa98f8a84b23db5fa378900bd", GitTreeState:"clean", BuildDate:"2023-03-15T13:40:17Z", GoVersion:"go1.19.7", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.4", GitCommit:"f89670c3aa4059d6999cb42e23ccb4f0b9a03979", GitTreeState:"clean", BuildDate:"2023-04-12T12:05:35Z", GoVersion:"go1.19.8", Compiler:"gc", Platform:"linux/amd64"}

Helm Version
version.BuildInfo{Version:"v3.11.3", GitCommit:"323249351482b3bbfc9f5004f65d400aa70f9ae7", GitTreeState:"clean", GoVersion:"go1.20.3"}

Description
I was trying
helm install airflow airflow-stable/airflow -f values.yml
I also tried

sample-values-CeleryExecutor.yaml
sample-values-KubernetesExecutor.yaml
sample-values-CeleryKubernetesExecutor.yaml
None of them works, some pods keep restarting / init error as below

airflow-db-migrations-798dd7d674-kdxp7   0/1     Init:0/1                2 (41s ago)   110s
airflow-pgbouncer-5764575d7d-wjsrv       1/1     Running                 0             110s
airflow-postgresql-0                     0/1     Pending                 0             110s
airflow-scheduler-64877fbb44-76nb9       0/2     Init:0/2                2 (41s ago)   110s
airflow-sync-users-648f4dfb96-vmcbp      0/1     Init:CrashLoopBackOff   2 (26s ago)   110s
airflow-triggerer-85b85c4d64-wl7ks       0/1     Init:0/2                2 (42s ago)   110s
airflow-web-645fccd75b-khcqq             0/1     Init:0/2                2 (41s ago)   111s

Please give me some advice, thank you very much.
Relevant Logs
Describe pod

  Normal   Scheduled    104s                default-scheduler  Successfully assigned ebis/airflow-db-migrations-84b7f87494-4hc42 to k8s-fptidc-worker3
  Warning  FailedMount  102s                kubelet            MountVolume.SetUp failed for volume "scripts" : failed to sync secret cache: timed out waiting for the condition
  Normal   Pulled       73s (x3 over 101s)  kubelet            Container image "apache/airflow:2.5.3-python3.8" already present on machine
  Normal   Created      73s (x3 over 101s)  kubelet            Created container check-db
  Normal   Started      73s (x3 over 101s)  kubelet            Started container check-db
  Warning  BackOff      1s (x3 over 86s)    kubelet            Back-off restarting failed container check-db in pod airflow-db-migrations-84b7f87494-4hc42_ebis(a5363d98-30be-417c-8f81-671b8acb41b7)

### Custom Helm Values

_No response_

@jackchuong it looks like your postgresql Pod is not starting, I bet its because your Kubernetes cluster has no default StorageClass, so it cant create a PVC Volume.

@thesuperzapper thank for your reply, I have checked again, the reason is:
I installed airflow by Helm failed the first time and command helm uninstall airflow didn't clean up every things completely , there remains some PVC (pending) and secret , I deleted them manually and chart's values work fine with 2 PVC I created for postgresql and logs.
However I get another problem when trying to config git-sync sidecar for dags
sample-values-CeleryKubernetesExecutor.yaml
dags:
  ## the airflow dags folder
  path: /opt/airflow/dags

  ## configs for the dags PVC
  ## [FAQ] https://github.com/airflow-helm/charts/blob/main/charts/airflow/docs/faq/dags/load-dag-definitions.md
  persistence:
    enabled: false

  ## configs for the git-sync sidecar
  ## [FAQ] https://github.com/airflow-helm/charts/blob/main/charts/airflow/docs/faq/dags/load-dag-definitions.md
  gitSync:
    enabled: true
    repo<EMAIL_ADDRESS>    repoSubPath: ""
    branch: main
    revision: HEAD
    depth: 1
    syncWait: 60
    syncTimeout: 120
    submodules: recursive
    sshSecret: "airflow-ssh-git-secret"
    sshSecretKey: "id_rsa"
    sshKnownHosts: ""
    maxFailures: 0

gitlab.mydomain.com is a Gitlab CE on premise , it's working normally , I created repo myuser/airflow-dags , added ssh public key into myuser profile
I also created secret airflow-ssh-git-secret contains ssh private key
kubectl describe secret/airflow-ssh-git-secret
Name:         airflow-ssh-git-secret
Namespace:
Labels:       <none>
Annotations:  <none>

Type:  Opaque

Data
====
id_rsa:  1834 bytes

The status of pod after helm install
kubectl get pod
NAME                                     READY   STATUS                  RESTARTS     AGE
airflow-db-migrations-5bc7cbf67b-vtlpx   0/2     Init:CrashLoopBackOff   7 (3m13s ago)   14m
airflow-flower-85cfcf5c47-f9clm          0/2     Init:CrashLoopBackOff   7 (3m18s ago)   14m
airflow-pgbouncer-5f5944d598-cdlk9       1/1     Running                 0               14m
airflow-postgresql-0                     1/1     Running                 0               14m
airflow-redis-master-0                   1/1     Running                 0               14m
airflow-scheduler-d8fdbf78d-hqt8k        0/2     Init:CrashLoopBackOff   7 (3m10s ago)   14m
airflow-sync-users-857b457984-ntsc2      0/2     Init:CrashLoopBackOff   7 (3m18s ago)   14m
airflow-triggerer-bcb998dd7-8shhl        0/2     Init:CrashLoopBackOff   7 (3m17s ago)   14m
airflow-web-6f8cf6c875-fnh8w             0/2     Init:CrashLoopBackOff   7 (3m13s ago)   14m
airflow-worker-0                         0/2     Init:CrashLoopBackOff   7 (3m16s ago)   14m
spark-master-0                           1/1     Running                 0               27h
spark-worker-0                           1/1     Running                 0               27h
spark-worker-1                           1/1     Running                 0               27h

So I guess something wrong with pod airflow-sync-users-857b457984-ntsc2 ?
kubectl describe pod airflow-sync-users-857b457984-ntsc2
...
Init Containers:
  dags-git-clone:
    Container ID:   docker://0101410f3b17e17bf7490aacc5e5ccebd5a571def1f270912d156567b4b64a1a
    Image:          registry.k8s.io/git-sync/git-sync:v3.6.5
    Image ID:       docker-pullable://registry.k8s.io/git-sync/git-sync@sha256:7231f6c2284758b91caed71e4e596413df31ac4467de9b596dc6b386b82f624f
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       CrashLoopBackOff
    Last State:     Terminated
      Reason:       Error
      Exit Code:    1
      Started:      Sat, 01 Jul 2023 17:57:14 +0700
      Finished:     Sat, 01 Jul 2023 17:57:14 +0700
    Ready:          False
    Restart Count:  3
    Environment Variables from:
      airflow-config-envs  Secret  Optional: false
    Environment:
      GIT_SYNC_ONE_TIME:           true
      GIT_SYNC_ROOT:               /dags
      GIT_SYNC_DEST:               repo
      GIT_SYNC_REPO<EMAIL_ADDRESS>      GIT_SYNC_BRANCH:             main
      GIT_SYNC_REV:                HEAD
      GIT_SYNC_DEPTH:              1
      GIT_SYNC_WAIT:               60
      GIT_SYNC_TIMEOUT:            120
      GIT_SYNC_ADD_USER:           true
      GIT_SYNC_MAX_SYNC_FAILURES:  0
      GIT_SYNC_SUBMODULES:         recursive
      GIT_SYNC_SSH:                true
      GIT_SSH_KEY_FILE:            /etc/git-secret/id_rsa
      GIT_KNOWN_HOSTS:             false
      DATABASE_USER:               postgres
      DATABASE_PASSWORD:           <set to the key 'postgresql-password' in secret 'airflow-postgresql'>  Optional: false
      REDIS_PASSWORD:              <set to the key 'redis-password' in secret 'airflow-redis'>            Optional: false
      CONNECTION_CHECK_MAX_COUNT:  0
    Mounts:
      /dags from dags-data (rw)
      /etc/git-secret/id_rsa from git-secret (ro,path="id_rsa")
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-s2wtx (ro)
  check-db:
    Container ID:
    Image:         apache/airflow:2.5.3-python3.8
    Image ID:
    Port:          <none>
    Host Port:     <none>
    Command:
      /usr/bin/dumb-init
      --
      /entrypoint
    Args:
      bash
      -c
      exec timeout 60s airflow db check
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Environment Variables from:
      airflow-config-envs  Secret  Optional: false
    Environment:
      DATABASE_USER:               postgres
      DATABASE_PASSWORD:           <set to the key 'postgresql-password' in secret 'airflow-postgresql'>  Optional: false
      REDIS_PASSWORD:              <set to the key 'redis-password' in secret 'airflow-redis'>            Optional: false
      CONNECTION_CHECK_MAX_COUNT:  0
    Mounts:
      /opt/airflow/dags from dags-data (rw)
      /opt/airflow/logs from logs-data (rw,path="airflow-logs")
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-s2wtx (ro)
  wait-for-db-migrations:
    Container ID:
    Image:         apache/airflow:2.5.3-python3.8
    Image ID:
    Port:          <none>
    Host Port:     <none>
    Command:
      /usr/bin/dumb-init
      --
      /entrypoint
    Args:
      bash
      -c
      exec airflow db check-migrations -t 60
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Environment Variables from:
      airflow-config-envs  Secret  Optional: false
    Environment:
      DATABASE_USER:               postgres
      DATABASE_PASSWORD:           <set to the key 'postgresql-password' in secret 'airflow-postgresql'>  Optional: false
      REDIS_PASSWORD:              <set to the key 'redis-password' in secret 'airflow-redis'>            Optional: false
      CONNECTION_CHECK_MAX_COUNT:  0
    Mounts:
      /opt/airflow/dags from dags-data (rw)
      /opt/airflow/logs from logs-data (rw,path="airflow-logs")
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-s2wtx (ro)
...
Events:
  Type     Reason     Age                From               Message
  ----     ------     ----               ----               -------
  Normal   Scheduled  74s                default-scheduler  Successfully assigned ebis/airflow-sync-users-857b457984-ntsc2 to k8s-fptidc-worker2
  Normal   Pulled     27s (x4 over 71s)  kubelet            Container image "registry.k8s.io/git-sync/git-sync:v3.6.5" already present on machine
  Normal   Created    27s (x4 over 71s)  kubelet            Created container dags-git-clone
  Normal   Started    26s (x4 over 71s)  kubelet            Started container dags-git-clone
  Warning  BackOff    14s (x6 over 70s)  kubelet            Back-off restarting failed container dags-git-clone in pod airflow-sync-users-857b457984-ntsc2_ebis(f515be0b

Doesn't it work with Git repo on premise ? Or I did something wrong ?

@jackchuong you need to look at the logs for one of those failing pods, it is not possible to know what's failing otherwise.
BTW, I highly recommend k9s, a CLI tool for managing Kubernetes clusters, it's very easy to view things like pod logs. (You just press "L" when highlighting a pod to see its logs).


[Bug]: The dropdown menu for modelSpecs is behaving abnormally in the mobile view with Chinese language settings

What happened?
The text in this area is erroneously displayed vertically, obstructing both the text and buttons in the chat area during conversations
Steps to Reproduce

Switch to mobile device view (using phone or devtools)
Select language as Chinese

What browsers are you seeing the problem on?
Microsoft Edge
Relevant log output
No response
Screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thank you for your quick fix! But I've just noticed that this anomaly also occurs in the endpoint button region

Thanks, I'll apply the same styling soon


Remove Style/ExtendSelf cop

Style/ExtendSelf was introduced by #5108, but the cop duplicates with Style/ModuleFunction.
So this change reverts the commit (da69b88).

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

That's new. :rofl: Did you compare which one was implemented better?

I didn't compare them. I thought the new cop should be removed for compatibility, so I removed it. Maybe we should work on another pull-request to improve the cop's implementation.

Whoops! 😬

I didn't compare them. I thought the new cop should be removed for compatibility, so I removed it. Maybe we should work on another pull-request to improve the cop's implementation.

@Drenmi Can you look into this? I wonder how you didn't notice the existing cop. 😆

Style/ExtendSelf has an autocorrect method while Style/ModuleFunction does not, looks we should remove Style/ModuleFunction cop instead.

Style/ExtendSelf has an autocorrect method while Style/ModuleFunction does not, looks we should remove Style/ModuleFunction cop instead.

Maybe we can move the auto-correction to Style/ModuleFunction. 👍
And I think we can't remove Style/ModuleFunction, because some users configure the gem already. So if remove the cop, it's a breaking change.


Relationship with jade-runtime

AFAICS this module does the same thing as (and a little more than) jade.attrs. So, what's the relationship between these two? Is this module meant to replace the implementation in jade-runtime?

runtime.attrs does the job of taking an object that maps attribute keys to values and generating the html for those attributes.  This is used by the &attributes syntax.  jade-attrs deals with generating code to produce attributes objects (e.g. to be given to mixins) and producing html directly.  They're actually fairly separate jobs.
To sumarise
jade-attrs
Array from jade parser -> JavaScript -> HTML
Array from jade parser -> JavaScript -> Object mapping keys to values
runtime.attrs
Object mapping keys to values -> HTML

Alright, makes sense.


[3.0.0-beta1] build fails for darwin64-x86_64-cc with no-deprecated option

I have another one: Configuring with
$ uname -a
Darwin opensslmacbuild01 20.5.0 Darwin Kernel Version 20.5.0: Sat May  8 05:10:33 PDT 2021; root:xnu-7195.121.3~9/RELEASE_X86_64 x86_64
$ cc --version
Apple clang version 12.0.5 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin20.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
$ ./Configure darwin64-x86_64-cc --api=1.1.0 no-deprecated
Configuring OpenSSL version 3.0.0-beta1 for target darwin64-x86_64-cc
Using os-specific seed configuration
Creating configdata.pm
Running configdata.pm
Creating Makefile.in
Creating Makefile

[...]
Resulting in a configuration:
Configure-dump.txt
Leads to ...
$ make
/Library/Developer/CommandLineTools/usr/bin/make depend && /Library/Developer/CommandLineTools/usr/bin/make _build_sw
[...]
cc  -Iinclude -Iapps/include  -arch x86_64 -O3 -Wall -D_REENTRANT -DOPENSSL_BUILDING_OPENSSL -DNDEBUG  -MMD -MF test/pem_read_depr_test-bin-pem_read_depr_test.d.tmp -MT test/pem_read_depr_test-bin-pem_read_depr_test.o -c -o test/pem_read_depr_test-bin-pem_read_depr_test.o test/pem_read_depr_test.c
test/pem_read_depr_test.c:55:5: error: implicit declaration of function 'DH_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    DH_free(dh);
    ^
test/pem_read_depr_test.c:55:5: note: did you mean 'BN_free'?
include/openssl/bn.h:299:6: note: 'BN_free' declared here
void BN_free(BIGNUM *a);
     ^
test/pem_read_depr_test.c:76:5: error: implicit declaration of function 'DH_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    DH_free(dh);
    ^
test/pem_read_depr_test.c:99:5: error: implicit declaration of function 'DSA_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    DSA_free(dsa);
    ^
test/pem_read_depr_test.c:120:5: error: implicit declaration of function 'DSA_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    DSA_free(dsa);
    ^
test/pem_read_depr_test.c:141:5: error: implicit declaration of function 'DSA_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    DSA_free(dsa);
    ^
test/pem_read_depr_test.c:163:5: error: implicit declaration of function 'RSA_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    RSA_free(rsa);
    ^
test/pem_read_depr_test.c:184:5: error: implicit declaration of function 'RSA_free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    RSA_free(rsa);
    ^
7 errors generated.
make[1]: *** [test/pem_read_depr_test-bin-pem_read_depr_test.o] Error 1
make: *** [build_sw] Error 2

It compiles without no-deprecated option.

Without --api=1.1.0 but with no-deprecated the pem_read_depr_test wouldn't be compiled at all. So that's the reason why we do not see the problem in our CI.
But apparently the --api=1.1.0 still keeps the OPENSSL_NO_DEPRECATED_3_0 somehow defined??

This is not OS related.
A linux build will get warnings in pem_read_depr_test.c and sslapitest.c also.

For these files it just seems to be that the required headers have not been included in these tests


views.populate_image returns None

Describe the bug
After authenticating, identifying the correct workbook and the correct sheet, calling server.views.populate_image(sheet_view, image_req_option) I get None
Versions
Details of your environment, including:

Tableau Server version (via pip, 0.34)
Python version: 3.11

To Reproduce
# After authenticating correctly
server.workbooks.populate_views(workbook)
sheet_view = next((v for v in workbook.views if v.name == SHEET_NAME), None)
image_req_option = TSC.ImageRequestOptions(maxage=1)  # Set cache options if needed
image = server.views.populate_image(sheet_view, image_req_option)

Results
image is None

Expected behavior. Check the sheet_view.image attribute.

Oh yes, sorry, I think I misread the documentation, it all worked out!


CAP REQ from client to ZNC does not suspend registration

In the Client Capability Negotiation spec it says:

Upon receiving either a CAP LS or CAP REQ command during connection registration, the server MUST not complete registration until the client sends a CAP END command to indicate that capability negotiation has ended. This allows clients to request their desired capabilities before completing registration.

It seems that ZNC 1.8.2 suspends registration after CAP LS but not after CAP REQ.

Something along the lines of the following should do it.
diff --git a/src/Client.cpp b/src/Client.cpp
index 1fdb2aa4..ddb18016 100644
--- a/src/Client.cpp
+++ b/src/Client.cpp
@@ -716,6 +716,8 @@ void CClient::HandleCap(const CMessage& Message) {
             }
         }
     } else if (sSubCmd.Equals("REQ")) {
+        m_bInCap = true;
+
         VCString vsTokens;
         Message.GetParam(1).Split(" ", vsTokens, false);

Something along the lines of the following should do it.
diff --git a/src/Client.cpp b/src/Client.cpp
index 1fdb2aa4..ddb18016 100644
--- a/src/Client.cpp
+++ b/src/Client.cpp
@@ -716,6 +716,8 @@ void CClient::HandleCap(const CMessage& Message) {
             }
         }
     } else if (sSubCmd.Equals("REQ")) {
+        m_bInCap = true;
+
         VCString vsTokens;
         Message.GetParam(1).Split(" ", vsTokens, false);


Update version: Datadog.dd-trace-dotnet version 2.31.0

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Manifest Error: Invalid field value. [InstallerType]
Manifest Error: The specified installer type does not support ProductCode. [InstallerType] Value: unknown
Manifest Error: The specified installer type does not write to Apps and Features entry. [InstallerType] Value: unknown
Manifest Error: Invalid field value. [InstallerType] Manifest Error: The specified installer type does not support ProductCode. [InstallerType] Value: unknown
Manifest Error: The specified installer type does not write to Apps and Features entry. [InstallerType] Value: unknown

The InstallerType field appears necessary here as well.


Add note on Rails 5 default cache

I thought it would be useful to tell users about that issue that I faced myself

Hi, thanks for the pull. Merged.
I'll consider adding a warning or force a default cache store instead of NullStore.

That seems a sane solution. Thanks for the gem BTW


BLD: avoid using latest setuptools for building 1.8.x

The windows tests on maint-1.8 are currently failing since (I think) the latest setuptools release. That version has quite some changes to how editable installs work (see eg also https://github.com/shapely/shapely/pull/1475 that @mwtoews initially did).
Checking here if limiting ourselves to older setuptools versions fixes the problem (to confirm it is indeed triggered by setuptools 65 release). This wouldn't really be a good long-term solution, but for 1.8.x it might also be fine.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.836%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3012

Relevant Lines:
3509

💛  - Coveralls

@mwtoews thanks for catching that it needed to be <64 and not <65 for having the version without the new editable support! That seems to have done the trick.

I've fixed this in #1479, which I am looking to merge today.

@sgillies I think this PR is the better fix, we don't want to require for users to have to specify that env variable?

@jorisvandenbossche I went the other way for maint-1.8, use of the setuptools feature in combination with a fix in setuptools 65.0.1 works.

I went the other way for maint-1.8,

Regardless of what you merged in the other PR, we can still merge this, I think? (it doesn't conflict, I actually updated this PR after your PR was merged)

use of the setuptools feature in combination with a fix in setuptools 65.0.1 works.

As mentioned above, AFAIK this still only works if you specify that env variable? That means that users installing shapely (not using the wheel) should have to do that as well. While this PR limiting the setuptools version doesn't need any additional user action.
Of course, in practice it is only for editable installs I think, so the number of affected users might not be that big. But as @mwtoews mentioned above, putting a max setuptools version here also prevents from potential failures with a future setuptools release.

A different approach for the main branch would be fine with me.

The main branch doesn't seem to have this problem, there using the latest setuptools did work (https://github.com/shapely/shapely/pull/1475)

@jorisvandenbossche :pray: sounds good! Merging.


"Module with the Main dispatcher is missing" exception on Desktop build when using viewModelScope

Hello!
This is working fine on Android, but I've noticed that if I compile my app for Desktop, the following call inside a ViewModel:
viewModelScope.launch {
   _images.value = items
}

Will trigger the exception:
java.lang.IllegalStateException: Module with the Main dispatcher is missing. Add dependency providing the Main dispatcher, e.g. 'kotlinx-coroutines-android'

I've managed to fix the issue by updating the build.gradle.kts file to:
val jvmMain by getting {
  dependencies {
    dependsOn(commonMain)

    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:1.6.1")
  }
}

It seems that the JVM target requires adding the org.jetbrains.kotlinx:kotlinx-coroutines-swing  dependency, I will fix that.

Closing as fixed