C++ addon support for adapter-node

Describe the problem
I need to be able to bundle .node files (C++ Addons).
I'm fine if this is immediately closed because of #3733, but because adapter-node no longer uses esbuild I'm not sure if my comment on that issue is relevant.
Describe the proposed solution
My knowledge in rollup and esbuild are quite lacking, but here is an esbuild plugin that would theoretically solve the problem. Since adapter-node switched to rollup from esbuild this isn't exactly a solution, but I've included it for reference since I don't know what else to do.
Alternatives considered
I've gotten the C++ addon I'm using to work by putting it in dependencies so it gets skipped for bundling. Then you can simply run node build to run and it works just fine on my local machine. So theoretically, for deployment, one could produce the build (with C++ addons in dependencies so they aren't bundled) and then install the non-bundled dependencies wherever the build gets deployed.
Importance
would make my life easier
Additional Information
Specifically I'm using Azure's MSAL Node extensions for account caching.
The node-resolve rollup plugin docs state the default for the extensions configuration includes .node files. I don't know why .node files don't work out of the box since adapter-node uses this plugin.
Here is a reproduction repo. All I did was install adapter-node and @azure/msal-node-extensions as well as using it in src/routes/+page.server.js.

For the "Alternatives considered" here's what I did:

pnpm run build and copy the build directory out somewhere else on my local machine
In the directory build was copied to, also copy package.json (I deleted all the devDependencies but I doubt that's necessary)
pnpm i in the same directory to install dependencies
node build to run the application

Here's some example output:

The false coming through the console when I navigate to localhost:3000 is from this line and it is false, as expected, since I ran this on a mac.

The packages in question should go in dependencies — these will be ignored by esbuild. I'm not sure there's anything we need to do beyond that? Packages in dependencies (as opposed to devDependencies) are supposed to be installed wherever you run the deployment

I believe my error was in thinking C++ addons were somehow portable in a way they could be bundled in any node application to be deployed anywhere so I was searching for a way to make bundling work with them. But that's not the case since the addons are compiled for specific architecture which happens on installation with tools such as node-gyp. Due to my ignorance this is a best guess, anyway.
So to conclude - my "alternative" is the correct way of handling C++ addons and I just figured it out through roundabout trial and error 😆
Thanks for your time!


.NET Standard 2.0 Library Builds

Should document: .NET Standard 2.0 library projects need to have Build > Advanced > "Debugging information" changed from the default of "Portable" to "Full".  Discovered when building .NET Standard 2.0 libraries in combination with a UWP app. With "Portable", AppCenter build "mspdbcmf.exe" will exit with code 1106 from fatal error CMF1106 "input PDB file is not generated by /DEBUG:fastlinkW".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be2ace35-a6ef-349a-e009-ca55e3778602
Version Independent ID: 85a92e95-828a-54f8-b7e7-4f86b8e76abc
Content: Configure a C# UWP app in App Center - Visual Studio App Center
Content Source: docs/build/windows/uwp/first-build.md
Service: vs-appcenter
GitHub Login: @siminapasat
Microsoft Alias: siminap

@kburgoyne I'll have the SDK team and take a look.
App Center support is provided directly from within the App Center portal. Any time you need help, just click the blue chat button in the lower-right corner of any page and our dedicated support team will respond. For additional information, see the App Center Help Center.

@jwargo This is Build related as well.

@elamalani you're right, sorry.

Hi @kburgoyne, this is a known issue that was fixed in VS 15.9 Preview 3. The hosted agents don't currently have the preview versions on them.

Right-o. Thanks.


Performance

First meaningful paint speed is hella slow. Here's a performance test from Lighthouse on -testing / develop#8a2ea93:

(full report here)
In addition to this, as we're on Heroku's free plan, the site is often in sleep mode. In this case, the user has the burden of the site loading, which can take up to 10 seconds.
What can we do to improve performance? Thinking about code optimisations, server changes, etc.

The obvious main drag is the main component: the Google Maps embed and the map markers


Add go to reference

Hello again 😄
I’ve been using gd (go to definition), and it works like a charm. Could you also add gr (go to reference) to show all places where a translation is used?

@signature-development
Thank you for the suggestion.
Achieving fast search across all files does have some challenges, but I’m planning to implement it in the future.


Add meaningful names to steps and remove quasi-repetition

The workflow only shows "Runs action-rs/cargo@v1" which does not tell us much about what's actually being done.
The list and clean up done after each build varies by only the debug/release part of the path that is repeated several times (2).
This PR gives each step a more meaningful name and simplify the list & clean up step with a generic one liner that can be copy/pasted without modification.

Interestingly, git does not detect conflict between this PR and #120 and yield garbage result, so whichever comes first, the other will need to be updated.

You cannot be told what the Matrix is. You have to see it for yourself.


consul: 0.5.2 -> 0.6.4 (using go 1.6)

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

 Ball is in my court.

Not sure how to get Travis to rerun the test or how to get the mention bot to look at this, but I'll ping @cstrahan and @kamilchm for now.

I also wonder if it's time to change the default go compiler in pkgs/top-level/all-packages.nix:
-goPackages = go15Packages;
+goPackages = go16Packages

Doing so would let me remove some ugly hunks of this commit...
Thoughts?

Travis build failure appears to be network related. I ran nox-review wip --against master successfully on my machine.

Thank you


ocamlPackages.containers: 3.12 -> 3.13.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/ocaml:containers/versions.
meta.description for ocamlPackages.containers is: A modular standard library focused on data structures
meta.homepage for ocamlPackages.containers is: https://github.com/c-cube/ocaml-containers
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.13 with grep in /nix/store/xagnvjxmzq4bf3aakv3y4r2717380zz0-ocaml4.14.1-containers-3.13
found 3.13 in filename of file in /nix/store/xagnvjxmzq4bf3aakv3y4r2717380zz0-ocaml4.14.1-containers-3.13

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
soupault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xagnvjxmzq4bf3aakv3y4r2717380zz0-ocaml4.14.1-containers-3.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ocamlPackages.containers https://github.com/r-ryantm/nixpkgs/archive/0ec5b64396630e7d4608b4e4e448b4f0bae72a4f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0ec5b64396630e7d4608b4e4e448b4f0bae72a4f#ocamlPackages.containers

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xagnvjxmzq4bf3aakv3y4r2717380zz0-ocaml4.14.1-containers-3.13
ls -la /nix/store/xagnvjxmzq4bf3aakv3y4r2717380zz0-ocaml4.14.1-containers-3.13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

ocamlPackages.containers
ocamlPackages.containers-data
ocamlPackages.oseq
ocamlPackages.ppx_cstubs
ocamlPackages.tsort
soupault

Maintainer pings

Result of nixpkgs-review pr 273279 run on x86_64-linux 1

1 package built:

soupault

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_07.containers

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/ocaml:containers/versions.
meta.description for ocamlPackages.containers is: A modular standard library focused on data structures
meta.homepage for ocamlPackages.containers is: https://github.com/c-cube/ocaml-containers
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.13.1 with grep in /nix/store/21cjfjgw371yzqiv8b395dp14bqa8rsj-ocaml4.14.1-containers-3.13.1
found 3.13.1 in filename of file in /nix/store/21cjfjgw371yzqiv8b395dp14bqa8rsj-ocaml4.14.1-containers-3.13.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
soupault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/21cjfjgw371yzqiv8b395dp14bqa8rsj-ocaml4.14.1-containers-3.13.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ocamlPackages.containers https://github.com/r-ryantm/nixpkgs/archive/65d401f0b101a294dfd36ebcffa67375546ae586.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/65d401f0b101a294dfd36ebcffa67375546ae586#ocamlPackages.containers

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/21cjfjgw371yzqiv8b395dp14bqa8rsj-ocaml4.14.1-containers-3.13.1
ls -la /nix/store/21cjfjgw371yzqiv8b395dp14bqa8rsj-ocaml4.14.1-containers-3.13.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

ocamlPackages.containers
ocamlPackages.containers-data
ocamlPackages.oseq
ocamlPackages.ppx_cstubs
ocamlPackages.tsort
soupault

Maintainer pings

@ofborg build ocaml-ng.ocamlPackages_4_08.containers

@ofborg eval


doCheck = false doesn't have any effect

Setting doCheck = false; for both buildDepsOnly and buildPackage anyway results in cargo check invocation when building dependencies. Only workaround I found is to set cargoCheckCommand = "echo";

doCheck is a standard Nix command to run (or not) tests.
It's not about cargo check

Only workaround I found is to set cargoCheckCommand = "echo";

Yep this is the exact intended way to disable cargo check from within buildDepsOnly (you can replace that with cargoCheckCommand = ":"; if you want to suppress the log statement entirely). As @dpc mentioned, doCheck influences whether cargo test is invoked
Gonna close this as this is by design, but feel free to reopen if you have other questions!

What about adding flag like doCargoCheck then?

My advice: if some crane command doesn't do exactly what you want, just go straight to mkCargoDerivation and embrace doing everything yourself with it.

What about adding flag like doCargoCheck then?

Running cargo check is pretty benign for the majority of projects, and since cargoCheckCommand already allows for controlling it, I'm not sure the extra flag would add much benefit

What about adding flag like doCargoCheck then?

Running cargo check is pretty benign for the majority of projects, and since cargoCheckCommand already allows for controlling it, I'm not sure the extra flag would add much benefit

Yes but I feel like it takes significantly more time to build because of cargo check? Or am I wrong?

cargo check is generally much faster than cargo build, but yes, it takes some time. On the flip side, if you follow up with cargo clippy you do want to have cargo check done already.


updating to use optional

Coverage decreased (-0.02%) to 14.585% when pulling 6059a560df7991015a1eef1bfb08961f7939792f on hostname-helper into 716b4ef81fd7cd88160695c6850bed47084a5f60 on master.


switched to this project, dev works, but build doesn't

Before I was using prisma with nuxt directly, Dev was working fine, but to build a server bundle I had my own setup and some after build script
copy .env  .output\server

rem move myrpisma outside from node_modules
move .output\server\node_modules\myprisma .output\server\myprisma

Rem this file is not needed for linux
del .output\server\myprisma\client\query_engine-windows.dll.node

rem copy database file to dist folder
copy ..\prisma\dev.db .output\server\myprisma\client

powershell -Command "(gc .output\server\package.json) -replace '0.0.0', 'file:../myprisma' -replace 'win32-x64-msvc', 'linux-x64-gnu' | Out-File -encoding ASCII .output\server\package.json"

rem Replace inside `.output/server` all 'myprisma/client' to '../myprisma/client/index.js'
node fileReplacer.js

Obviously that was painful, so I switched to using nuxt-prisma module  to have smoother use. I managed to get dev working with
nuxi dev --dotenv .env.local

but can't even get local build running properly.
I get build completed with these warnings

then when i run with  node .output/server/index.mjs it can't find database, but if I copy sqlite database file to output folder and run like this it works:

Is there anything I am missing, i expect it to copy database file to output folder. Or is this as expected?

This is not expected. Could you check if this helps resolve the issue?

I have tried that and now get this error when running from build and it crashes completely in browser

Thanks for getting back.

I have tried that and now get this error when running from build and it crashes completely in browser

I haven't seen the exact message before. I'd appreciate it if you provide me with a small reproduction of the issue.

Thanks @husayt, could you kindly provide a reproduction I can use to replicate the exact errors? Additionally, is there any custom configuration I should be aware of?

Yes, you are right. I am trying to come up with a small reproduction and will let you know once it is ready.
Thank you


api: v2alpha1 TransactionList: Fix typo in EndLayer filter

EndLayer filter used Address field instead of Layer to prepare SQL query.

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge


execution context for managing/scheduling proc call

it's in working order, just wanted to get this up so people can see it before i finish some tweaks (there's a few TODOs about.)
sleep and spawn both work, but in a half-assed way that won't support -1 or 0 waits properly (and probably more.)
will fix https://github.com/wixoaGit/OpenDream/issues/94

DreamProc is a base class for any proc. We instantiate one per proc as it only contains static information such as Name, SuperProc, ArgumentNames.
NativeProc : DreamProc is an implementation that supports calling the native procs you had written previously (except for sleep, which is no longer one of those.)
DMProc : DreamProc is an implementation that contains the DM interpreter, so it is used for procs written in DM.
SleepProc : DreamProc is an implementation used only for sleep().
Each of the procs has an associated State type, an instance of the state will exist for each current call to those procs.

I've just pushed basic support for retrieving return values asyncronously in C# (for cases where you want the return value even if the proc has paused during execution.)
If you sleep in /client/New() before . = ..(), you'll see it works. Whether or not the rest of the code supports that isn't something I'd know.
I still want to write something a little more robust for situations like verbs where we need to wait on multiple procs to execute (such as when a verb has two prompts to show.)

probably not pushing this tonight, but i got this working by defining our own TaskScheduler and SynchronizationContext.

Ready for review, although it could use some documentation.
Async builtins are defined like this:
        [DreamProc("sleep")]
        [DreamProcParameter("Delay", Type = DreamValueType.Number)]
        public static async Task<DreamValue> NativeProc_sleep(AsyncNativeProc.State state) {
            float delay = state.Arguments.GetArgument(0, "Delay").GetValueAsNumber();
            int delayMilliseconds = (int)(delay * 100);

            // This is obviously not the proper behaviour
            await Task.Delay(delayMilliseconds);
            return DreamValue.Null;
        }

You can spawn a new thread (vm coroutine) for them using:
DreamProc proc = ...; // This can represent a sync/async native proc or a DM proc
DreamThread.Run(proc, src, usr, arguments);

You can also spawn a new thread with an anonymous async native proc:
DreamThread.Run(async (state) => {
    DreamProc proc = ...;
    var result = await state.Call(proc, src, usr, arguments);
    // We're always still on the main-thread here.
    // If the proc we called did not sleep, this whole operation has been synchronous!
    UseResult(result);
    return DreamValue.Null;
});

@wixoaGit ok i went a little overboard, hopefully it's ok, i moved a bunch of stuff around to get the code into a testable state
i'm not touching this for a while unless you want something changed

Ok those are sorted

Can I create a .editorconfig file to deal with the indentation? I'd prefer to not be changing the defaults of my editors.
https://editorconfig.org/
I'm going to bed now so don't expect any changes soon.

Can I create a .editorconfig file to deal with the indentation?

Yes, an editorconfig would be nice to have

anything else to do?

Beyond that, everything looks good.


Custom Permalink with custom routing?

So I was able to hook up some custom routing for my custom post type as follows:
Timber::add_route('neighborhood/:term/:name', function($params){

    //make a custom query based on incoming path and run it...
    $query = array(
        'post_type' => 'listing',
        'tax_query'     => array(
            'taxonomy'  => 'neighborhood',
            'terms'     => $params['term']
        ),
        'name' => $params['name']
    );
    //Check for the term and load the template, or 404
    if( term_exists($params['term']) ) {
        Timber::load_template('single.php', $query);
    } else {
        Timber::load_template('404.php');
    }

});

But my issue is that I want to utilize this new route with the default wordpress permalinking? I set up a means to make the change on the front-end but on the backend if you go to the custom post type post it's still shows the permalink as site.com/?listing=postname' which means the client would always be taken to that url instead of the custom route I setup.
Is there a means to go about handling this? I have permalinks enabled but it's not doing what I am used to which would be adding the taxonomy/post_type to the default permalink.

Sorry been away from wordpress awhile and was relying on this to do things for me: added this code to my rewrites and it's all good:
global $wp_rewrite;

// Neighborhood Guide Rewrites
$neighborhood_structure = '/listing/%listing%';

$wp_rewrite->add_rewrite_tag("%listing%", '([^/]+)', "listing=");
$wp_rewrite->add_permastruct('listing', $neighborhood_structure, false);


Fix doubled-up UseAuthorization

Fixes #17803.

Thank you for fixing this, @serpent5!

I was going to update to use
app.UseAuthentication();
app.UseAuthorization();

That's what i meant to do when I updated the article. I think there's at least on highlighted code off now.

I think there's at least on highlighted code off now.

Ugh, sorry. I've fixed that in #17806.


hold decrypted wallet key in secure memory

We currently hold the password in an input field and decrypt the wallet private key for each operation. Instead, we should decrypt it and hold it in secure memory (not shared, overwritten after use).

We missed the milestone here but this is still important, so I am pushing it to the next one.


Skip validating unused manifest fields in spin build

Fixes #473.
The approach taken here is that we don't care if other parts of the manifest are valid, as long as we have the info we need to do the build.  In terms of the original issue, the build won't fail because you have a missing field in your trigger.  The downside of this is that it results in some duplication of the parts of the manifest schema.
An alternative approach would be to keep the existing loader but just improve the error reporting around manifest load failures.  Despite the duplication, I prefer skipping validation, because if I'm in coding flow I don't want to have to take time out to fix some random other field.  But happy to have that discussion.
Signed-off-by: itowlson<EMAIL_ADDRESS>

Will accept any review with the word 'egregious' in it.  Thanks!


Added quarantine feature. Ported from Twister V1

This is only draft.
Done:

added args to pytest (--quarantine-list=FILENAME and --quarantine-verify)
quarantine implementation added as an additional filter, uses FilterPlugin
allowed multiple yaml files with quarantine lists
unit/component tests
quarantine yaml verification

Signed-off-by: Grzegorz Chwierut<EMAIL_ADDRESS>

Would it work with pytest test?
For example If I have such test:
# FILE: tests/foo_test.py
import pytest

@pytest.mark.platform('native_posix')
def test_foo():
    assert True

and quarantine file like:
- scenarios:
    - tests.foo_test::test_foo
  platforms:
    - native_posix

Thanks for reply. It can probably work in such a way; I will check it.
I rather thought about adding
pytest.mark.skip('reason')
to quarantined tests, like it is done in yaml_test_function.py. Then after running tests, we can find those tests in the output log:
tests/kernel/common/testcase.yaml::kernel.common[native_posix] <- ../../upstream_workspace/twister/src/twister2/yaml_test_function.py SKIPPED (Skipped in yaml specification) [ 50%]
I will update this PR soon.

You have right with pytest.mark.skip('reason'), it makes more sense for pytest tests and it is simpler to use. I guess quarantine is only way to skip tests from yaml file.

Added unittest:
$ pytest tests -k quarantine -v
============================================ test session starts =============================================
platform linux -- Python 3.8.10, pytest-7.2.0, pluggy-1.0.0 -- /home/grch/pyenvs/twister/bin/python3
cachedir: .pytest_cache
rootdir: /home/grch/upstream_workspace/twister, configfile: tox.ini
plugins: subtests-0.9.0, cov-4.0.0
collected 60 items / 53 deselected / 7 selected

tests/twister2_plugin_quarantine_test.py::test_if_pytest_use_quarantine_file PASSED                    [ 14%]
tests/twister2_plugin_quarantine_test.py::test_if_pytest_use_two_quarantine_files PASSED               [ 28%]
tests/twister2_plugin_quarantine_test.py::test_if_pytest_handle_quarantine_verify PASSED               [ 42%]
tests/twister2_plugin_quarantine_test.py::test_if_pytest_generate_testplan_with_quarantine PASSED      [ 57%]
tests/quarantine/quarantine_unit_test.py::test_quarantine_load_data PASSED                             [ 71%]
tests/quarantine/quarantine_unit_test.py::test_quarantine_load_data_from_two_files PASSED              [ 85%]
tests/quarantine/quarantine_unit_test.py::test_quarantine_raise_exception_if_data_empty PASSED         [100%]

Added skip mark to tests listed with --colect-only, when test should be skipped no matter if because of quarantine or skip keyword in testscace.yml). Also more --quarantine-list may be provided. Example usage:
$ pytest --zephyr-base=/home/grch/zephyrproject/zephyr --platform=native_posix --testplan-json=twister-out/testplan.json --results-json=twister-out/results.json --quarantine-list=test_quarantine.yml tests/kernel/common tests/kernel/queue --quarantine-list=test_quarantine2.yml --co
=================================================== test session starts ====================================================
platform linux -- Python 3.8.10, pytest-7.2.0, pluggy-1.0.0
rootdir: /home/grch/zephyrproject/zephyr
plugins: subtests-0.9.0, cov-4.0.0, twister-0.0.1
collected 7 items

<YamlFile tests/kernel/common/testcase.yaml>
  <YamlTestFunction kernel.common[native_posix]>
  <YamlTestFunction kernel.common.tls[native_posix]>
  <YamlTestFunction kernel.common.misra[native_posix]> skip
  <YamlTestFunction kernel.common.nano32[native_posix]> skip
  <YamlTestFunction kernel.common.nano64[native_posix]> skip
  <YamlTestFunction kernel.common.picolibc[native_posix]> skip
<YamlFile tests/kernel/queue/testcase.yaml>
  <YamlTestFunction kernel.queue[native_posix]>

-------------------- generated testplan file: /home/grch/zephyrproject/zephyr/twister-out/testplan.json --------------------

After running tests with --results-json=twister-out/results.json, filtered tests are listed in json output with "skipped" status and comment in message field:
        {
            "suite_name": "tests.kernel.common.testcase.yaml",
            "test_name": "kernel.common.picolibc[native_posix]",
            "nodeid": "tests/kernel/common/testcase.yaml::kernel.common.picolibc[native_posix]",
            "platform": "native_posix",
            "tags": "userspace base picolibc",
            "type": "integration",
            "platform_allow": "",
            "status": "skipped",
            "message": "('/home/grch/upstream_workspace/twister/src/twister2/yaml_test_function.py', 63, 'Skipped: Quarantine: NA')",
            "duration": 0.00010917196050286293,
            "subtests": []
        },

Next iteration:
Quarantine works as a separate plugin, not under FilterPlugin.
Quarantined tests receive marker quarantine and are skipped.
This marker is later used to prepare testplan and test results outputs.
Removed --quarantine-verify option. To verify quarantined scenarios, one can use marker as a filter: -m quarantine then only quarantined tests are collected and not marked to be skipped.
Removed 'skip' word from --collect-only output (added in previous commit), we can think about adding separate command to list-only collected tests.
Updated/added unit tests.

Codecov Report

Merging #29 (cea2b7d) into main (7d5ded7) will increase coverage by 4.91%.
The diff coverage is 96.03%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   75.49%   80.41%   +4.91%
==========================================
  Files          37       38       +1
  Lines        1355     1455     +100
==========================================
+ Hits         1023     1170     +147
+ Misses        332      285      -47

Impacted Files
Coverage Δ

src/twister2/report/test_results_plugin.py
30.70% <ø> (ø)

src/twister2/filter/quarantine_filter.py
95.50% <95.50%> (ø)

src/twister2/plugin.py
96.25% <100.00%> (+4.46%)
:arrow_up:

src/twister2/report/helper.py
84.84% <100.00%> (+53.81%)
:arrow_up:

src/twister2/report/test_plan_plugin.py
100.00% <100.00%> (+42.85%)
:arrow_up:

src/twister2/device/native_simulator_adapter.py
90.32% <0.00%> (-1.08%)
:arrow_down:

src/twister2/twister_config.py
89.36% <0.00%> (+6.38%)
:arrow_up:

src/twister2/report/base_report_writer.py
91.66% <0.00%> (+25.00%)
:arrow_up:

src/twister2/report/test_plan_json.py
87.50% <0.00%> (+31.25%)
:arrow_up:

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Fixes #23

fixes #23 has to be a part of the commit msg or the PR description to link automatic closing of the issue. Please amend the commit msg and then edit the PRs description to match the msg.


Refactor: Langchain v0.3

Updating requirements and imports for Langchain v0.3 . Should be able to install with requirements.txt

Tested /embed-upload with a small text file (800kb), short book. Tested getting all ids (/get). Tested /query the small text file returned relevant documents. Tested getting documents by id. Tested deleting documents by ID.

Used MongoDB with openAI "text-embedding-3-small".

Tested embedding upload multiple files to atlas vector collection
Tested querying one and multiple file_ids with relevant context
Tested deleting file by id
Tested pulling all ids


Unable to see list of detected CNBs for apps built by kpack

Issue
There's no way of viewing the list of CNBs used to build apps with a kpack lifecycle.
Context
For buildpack lifecycle apps, the buildpacks detected/used to build the app are observable via the cf curl /v3/apps/:guid/droplets/current endpoint. However, since kpack lifecycle apps are associated with docker lifecycle droplets containing the OCI image reference of the app image in the image registry, the buildpacks field is always returned as null. There needs to be a way to expose the CNBs used to build the apps by kpack.
Steps to Reproduce
[ordered list the process to finding and recreating the issue, example below]
Expected result
WHEN I cf push an app (i.e.: Go app) with a paketo-buildpack (i.e.: paketo-buildpacks/go)
AND I cf curl /v3/apps/:guid/droplets/current
THEN I expect to see a response that includes an array of hashes containing info on each buildpack used to build the app
i.e.:
"buildpacks": [
    {
      "name": "paketo-buildpacks/go",
      "detect_output": "go 0.1.0",
      "version": "0.1.0.",
      "buildpack_name": "paketo-buildpacks/go"
    }
  ]

Current result
WHEN I cf push an app
AND I  cf curl /v3/apps/821b06c1-b699-4cb6-8da6-28466b9fee31/droplets/current
THEN I get this response with a null list of buildpacks:
{
   "guid": "b48e7860-ddce-490c-9539-b3cc5adf5d2e",
   "created_at": "2020-09-17T21:48:16Z",
   "updated_at": "2020-09-17T21:49:07Z",
   "state": "STAGED",
   "error": null,
   "lifecycle": {
      "type": "docker",
      "data": {}
   },
   "checksum": null,
   "buildpacks": null,
   "stack": null,
   "image": "gcr.io/cf-capi-arya/cf-workloads/821b06c1-b699-4cb6-8da6-28466b9fee31@sha256:0d293bb0f01a0091c890d473ad19b0289cc3bc49403e3e032eb92981841a08d8",
...
}

Possible Fix

Make a new kpack lifecycle type for droplets such that a staged kpack droplet would have a non-null buildpacks and image field.
Have cf-api-controllers return list of CNBs used to build the kpack app back to CAPI

I think this doesn't work regardless of whether you specify a buildpack, and it likely should work with no buildpack specified.

@cwlbraa The only way specified buildpacks are viewable is through GET /v3/apps/:guid -- but those represent the requested, rather than the actual, state. So there's no way currently to see the list of buildpacks that were actually used to build kpack apps, regardless of whether they were specified by the user.

closing since cf-for-k8s is no longer under active development


add example4 - dmdarray adding

When running in system with Intel GPU (devcloud in particular) results in an error:
uab8f7faf7d5cc8a0d0c8bf0d3553a43@idc-beta-batch-head-node:~/work/tutorial-haichangsi$ I_MPI_OFFLOAD=0 mpirun -n 4 ./build/src/example4
[1699012212.351400] [idc-beta-batch-head-node:1845409:0]        ib_iface.c:1017 UCX  ERROR ibv_create_cq(cqe=4096) failed: Cannot allocate memory : Please set max locked memory (ulimit -l) to 'unlimited' (current: 4096 kbytes)
Abort(1615247) on node 0 (rank 0 in comm 0): Fatal error in PMPI_Init: Other MPI error, error stack:
MPIR_Init_thread(176)........:
MPID_Init(1548)..............:
MPIDI_OFI_mpi_init_hook(1632):
create_vni_context(2208).....: OFI endpoint open failed (ofi_init.c:2208:create_vni_context:Input/output error)

(tested with locally installed IMPI 2021.11). Please verify in different system/config. Maybe setting of some I_MPI_* env vars will help.

as we talked, I think it's because of your specific MPI configuration


thriftmac

Please fill out ALL ITEMS below before submitting a new issue. If this is a for an update to an existing site, please ensure "UPDATE" is in the issue title.
PLEASE PROVIDE THE UNCOMPRESSED SIZE ONLY
Link to GTMetrix results:
- domain:thriftmac.com
  url:https://thriftmac.com
  size:195.8

Example completed template for example.com with an UNCOMPRESSED size of 72.5KB:
- domain: example.com
  url: https://example.com
  size: 72.5

No GT Metrix link provided.

Now moved to a PR process. PLease see readme file for more info - https://github.com/kevquirk/512kb.club


feat(appeals-fo): add auth server

Pull Request Template
Describe your changes
https://pins-ds.atlassian.net/browse/AAPD-1195

Adds a new backend app service for appeals - auth server
Uses generated client id + secret, these will need to be added to clients as well later on

Useful information to review or test

Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] My code follows the style guidelines of this project
[x] My code changes do not include any hardcoded secrets or passwords
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My Tech Lead is aware of any infrastructure changes that will cost money

Looks good, my only comment is whether the secret definition could live in the appeals-app-services component instead of being duplicated in each stack?

Have removed from uk south as per discussion, key vault is geo replicated


Fix: CTS Next Event 502 Exceptions

Migrates CTS next event request to HTTP facade, which won't throw an exception for 400 or 500 HTTP errors.
Fixes #1839

:tada: This PR is included in version 5.8.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support for BTI-3583 gateway

Please add support for the BTI-3583 gateway:

For some reason, the OpenWebNet implementation on the above gateway does not work as expected. See bellow:
echo "*#13**15##" | nc <IP_ADDRESS> 20000
*#*1##*#*0##

Hi,
could you please provide more informations about your problem?
What's the meaning of the frame in your example and what should be the expected result?
Did you try to enable the debug feature from the app and send custom frame to your gateway? Do you have the same result?
The android client should work with any gateway. Keep in mind that if you need to provide credentials to access the gateway you probably need to send additional frames.
Let me know if you need more help,
Thanks

Obsolete


Added the Cursor Animation of INDIAN TRICOLOR Effect

Added the Cursor Animation of INDIAN TRICOLOR Effect
Before : Normal Cursor
After :
https://github.com/user-attachments/assets/4e08e69d-2c32-41fc-96fc-ed28bf8fca1b

@recodehive Please Review my Changes and Merge it by Assigning Labels to it !

i didnt assigne this


Fluid textures

Continuation from https://github.com/ISurrealI/ContentCreator/issues/3
Now I can get the script to generate fluids, awesome.
And again, a few new issues I've found using the following script:

#loader preinit

import contentcreator.fluid.Fluid;

var exampleFluid as Fluid = Fluid.create("example_fluid");
	exampleFluid.setColor(0x311b4a);
	exampleFluid.addBlock(<blockmaterial:lava>);
	exampleFluid.addBucket();
	exampleFluid.setUnlocalizedName("my_liquid");
	exampleFluid.setLuminosity(6);
	exampleFluid.setDensity(4000);
	exampleFluid.setTemperature(1000);
	exampleFluid.setViscosity(5000);

^ ^ By the way, on your example it says to use addBlock(<material:lava>); when it should be addblock(<blockmaterial:lava>);, or else it won't register that property.
There are no crashes or errors in the console log whatsoever.
The issue is that there is no texture rendered when:

The fluid's in any tank.
The fluid's placed in-world.
The texture/overlay ONLY appears when my head's inside the fluid block.

okay, this is weird it doesn't render when you set color idk why

Okay fixed it thanks for your feedback :)


Why T5 is used instead of GPT?

It seems GPT like llama2 is more popular.
But the paper still use T5.
Compared to GPT, does it have any special advantages to use T5?

Hi, the first language model that we used to build MotionGPTs is LLaMA-13B. However, it shows insufficient performance and low training efficiency. We assume the reason is the limited dataset size compared to the large parameters and language data of LLaMA.
Then, we thus choose T5-770M, a small but common language model, as our final backbone, because many previous vision-language multimodal works, like Unified-IO and BLIP, have chosen T5, this encoder-decoder architecture. It shows a strong power to address multi-modal tasks. In addition, the decoder-only model has the advantage for self-supervised without pair data while we have paired data which this advance is greatly weakened. We are still working on collecting a large motion dataset for larger motion-language models.
We have evaluated MotionGPT on GPT-2 and are working on LLaMA-2+LORA.  Please refer to the below.

Did you only do fine-tuning, or did you also perform pre-training?

Did you only do fine-tuning, or did you also perform pre-training?

Hello @ChangeNext
We employ both pre-training and fine-tuning processes for the T5 and GPT-2 models to ensure they are optimally adapted for our specific tasks.


ticdc(integration-test): use wget instead to curl to fetch binaries

What problem does this PR solve?
Issue Number: close #9056
What is changed and how it works?
use wget instead to curl to fetch binaries  and some minor fix for community binaries fetch
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
`None`.

/test all

/merge

/test all

/test cdc-integration-mysql-test


Update WS related to Employees without tax_id

Employees without tax_id also should be able to register. According to this must be changed: summary

[ ] Create employee request (no_tax_id) #1571
[ ] Update Employee request list and Employee request by id #1583
[ ] Create/Update employee (no_tax_id) #1572
[ ] Add filter GET/employees?no_tax_id to Get employees list apiary
[ ] Update WS Get employee details apiary
[ ] Sign Declaration (no_tax_id) #1575
[ ] WS related to Party (no_tax_id) #1577
[ ] Fraud Black list Users - block users by adding to black list 'tax_id' (only tax_id, not passport id)
[ ] Fraud replication - add field parties.no_tax_id to fraud_db

@danakonovalenko ready for test


projectileHitEntityHook doesn't work.

function projectileHitEntityHook(projectile,targetEntity){
clientMessage(projectile+'/'+targetEntity);
if(Entity.getEntityTypeId(projectile)==81){
Entity.setHealth(targetEntity,Entity.getHealth(targetEntity)-2);
}
}
If I different, I want to know how to use this function.

Had this issue too. Target entity is incorrect.

OH WOW THIS HAS GOT TO BE THE DUMBEST MISTAKE I EVER MADE WOW HOLEY LOL
Yeah, I forgot to call the method to get the entity ID in the code, so instead of the entity ID the function got the memory address of the entity instead.
I win the fail of the year award.
The fix will be in the next beta.


read should allow for files without .json extensions

Since all the fluid.dataset~ objects write files without extensions (by default), the corresponding read messages should let you load any file (sans extension).
and/or
The write command should bring up the file menu that allows you to select the filetype to be written (ala buffer~).

Basically working on a set of tools for beginner-ish use and it's an odd point of friction where the default files you can write are not the files you can then read.

Since all the fluid.dataset~ objects write files without extensions (by default), the corresponding read messages should let you load any file (sans extension).

I don't think this is the case.
On macOS you should see this:

Since all the fluid.dataset~ objects write files without extensions (by default), the corresponding read messages should let you load any file (sans extension).

I don't think this is the case.
On macOS you should see this:

I definitely don't see that. I get what you see in the first screenshot above.

What version of macOS?

Mojave.
Just checked on my laptop (Monterey) and it gives me the .json prompt.

If the same code from us (which goes through Max API calls) is resulting in different OS prompts, I don't hold out much hope for us being able to sway what it does


make Pwm generic

@homunkulus r+

:pushpin: Commit d52ec99 has been approved by japaric

:hourglass: Testing commit d52ec99 with merge d52ec99...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing d52ec99a4a9956e94ff93411798556e6846d87f6 to master...


Return storage safety information

Could the initialization inform the user of whether you're dealing with a "forgetful" key-store or not?
It would be helpful to streamline code/logic rather than dealing with platforms specifically in our own wrappers.
Especially seeing as WhenPasscodeSetThisDeviceOnly is forgetful too (wipes if passcode is changed).

Nope, this is your responsibility.


Update markdownlint-config.json to ignore confluent links

Changes
Adds cms confluence links to lint check ignore file do builds aren't blocked by intermittent false positives.

Closing for https://github.com/DSACMS/iv-cbv-payroll/pull/184

Jinx buy me a coke


Rancher lb-service-haproxy update to haproxy v1.8.8

Rancher versions:
rancher/server: 1.6.17
Rancher lb-service-haproxy was updated to version 1.8.4 earlier here: https://github.com/rancher/rancher/issues/10431
Since then there has been many important bugfixes to haproxy 1.8 branch, so haproxy should be updated to the latest upstream release (which is currently at v1.8.8).
Hopefully the updated haproxy version can get into rancher v1.6.18 :) Thanks!
Upstream changelog here: http://www.haproxy.org/download/1.8/src/CHANGELOG

Now there' 1.8.9 version available:
2018/05/18 : 1.8.9
- BUG/MINOR: pattern: Add a missing HA_SPIN_INIT() in pat_ref_newid()
- BUG/MAJOR: channel: Fix crash when trying to read from a closed socket
- BUG/MINOR: log: t_idle (%Ti) is not set for some requests
- BUG/MEDIUM: lua: Fix segmentation fault if a Lua task exits
- MINOR: h2: detect presence of CONNECT and/or content-length
- BUG/MEDIUM: h2: implement missing support for chunked encoded uploads
- BUG/MINOR: lua/threads: Make lua's tasks sticky to the current thread
- BUG/MINOR: config: disable http-reuse on TCP proxies
- BUG/MINOR: checks: Fix check->health computation for flapping servers
- BUG/MEDIUM: threads: Fix the sync point for more than 32 threads
- BUG/MINOR: lua: Put tasks to sleep when waiting for data
- DOC/MINOR: clean up LUA documentation re: servers & array/table.
- BUG/MINOR: map: correctly track reference to the last ref_elt being dumped
- BUG/MEDIUM: task: Don't free a task that is about to be run.
- BUG/MINOR: lua: schedule socket task upon lua connect()
- BUG/MINOR: lua: ensure large proxy IDs can be represented
- BUG/MEDIUM: http: don't always abort transfers on CF_SHUTR
- BUG/MEDIUM: pollers: Use a global list for fd shared between threads.
- BUG/MEDIUM: ssl: properly protect SSL cert generation
- BUG/MINOR: spoe: Mistake in error message about SPOE configuration

I can see a lot of http2 support fixes here.

Haproxy v1.8.10 released with more fixes:
2018/06/22 : 1.8.10
- BUG/MINOR: lua: Socket.send threw runtime error: 'close' needs 1 arguments.
- BUG/MEDIUM: spoe: Flags are not encoded in network order
- BUG/MEDIUM: contrib/mod_defender: Use network order to encode/decode flags
- BUG/MEDIUM: contrib/modsecurity: Use network order to encode/decode flags
- BUG/MINOR: ssl/lua: prevent lua from affecting automatic maxconn computation
- BUG/MEDIUM: cache: don't cache when an Authorization header is present
- BUG/MEDIUM: dns: Delay the attempt to run a DNS resolution on check failure.
- BUG/BUILD: threads: unbreak build without threads
- BUG/BUILD: fd: fix typo causing a warning when threads are disabled
- BUG/MEDIUM: fd: Only check update_mask against all_threads_mask.
- BUG/MEDIUM: servers: Add srv_addr default placeholder to the state file
- BUG/MEDIUM: lua/socket: Length required read doesn't work
- BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters
- BUG/MEDIUM: spoe: Return an error when the wrong ACK is received in sync mode
- MINOR: task/notification: Is notifications registered ?
- BUG/MEDIUM: lua/socket: wrong scheduling for sockets
- BUG/MAJOR: lua: Dead lock with sockets
- BUG/MEDIUM: lua/socket: Notification error
- BUG/MEDIUM: lua/socket: Sheduling error on write: may dead-lock
- BUG/MEDIUM: lua/socket: Buffer error, may segfault
- MAJOR: spoe: upgrade the SPOP version to 2.0 and remove the support for 1.0
- BUG/MINOR: contrib/spoa_example: Don't reset the status code during disconnect
- BUG/MINOR: contrib/mod_defender: Don't reset the status code during disconnect
- BUG/MINOR: contrib/modsecurity: Don't reset the status code during disconnect
- BUG/MINOR: contrib/mod_defender: update pointer on the end of the frame
- BUG/MINOR: contrib/modsecurity: update pointer on the end of the frame
- DOC: SPOE.txt: fix a typo
- DOC: contrib/modsecurity: few typo fixes
- BUG/MINOR: unix: Make sure we can transfer abns sockets on seamless reload.
- BUG/MEDIUM: threads: handle signal queue only in thread 0
- BUG/MINOR: don't ignore SIG{BUS,FPE,ILL,SEGV} during signal processing
- BUG/MINOR: signals: ha_sigmask macro for multithreading
- MINOR: lua: Increase debug information
- BUG/MAJOR: map: fix a segfault when using http-request set-map
- BUG/MINOR: lua: Segfaults with wrong usage of types.
- BUG/MAJOR: ssl: Random crash with cipherlist capture
- BUG/MAJOR: ssl: OpenSSL context is stored in non-reserved memory slot
- BUG/MEDIUM: fd: Don't modify the update_mask in fd_dodelete().
- BUG/MEDIUM: threads: Use the sync point to check active jobs and exit
- MINOR: threads: Be sure to remove threads from all_threads_mask on exit

This will be updated in the next release, we already have built test containers and those are currently at v1.8.12

@superseb could you link to corresponding PR updating haproxy to 1.8.12?

It's correlated to https://github.com/rancher/lb-controller/pull/119, where OS packages are updated on new image build.

@sangeethah to validate, just run haproxy --version, and validate that it's set to 1.8.12

Tested with v1.6.19-rc4 using rancher/lb-service-haproxy:v0.9.3
Uses 1.8.12 haproxy version:
root@e5f946854f68:/# haproxy -v
HA-Proxy version 1.8.12-1ppa1~xenial 2018/06/27
Copyright 2000-2018 Willy Tarreau<EMAIL_ADDRESS>
root@e5f946854f68:/#

All existing automated test cases for lb services succeeded.


Update drawFavicon to be compatible with Chrome

This immediately calls the onload function after it is defined, to ensure that changes are picked up.

fixed

Tinycon broke for us as well and this PR fixes it.


Russian characters in application names are not displayed correctly

I have been using RemoteAppTool for a long time. I decided to install raWeb today, but I got krakozyabry:

I attach the problem files:
remoteApps.zip

I'm sent pull request to fix it.
With normal encoding, it will look like this:

Looks good


Replace Black with Ruff as the Python formatter

Ruff now acts as a Black-compatible formatter. See https://astral.sh/blog/the-ruff-formatter
If it's anything like the rest of Ruff, it should be super fast, so I suggest we use it :rocket:
I moved the ruff binary from examples/ to examples/tools/, but I'm not really sure where these things should live when they're used as both linters and formatters. I also turned it into an alias, from a native_binary, because I didn't see why it should be a native_binary.
The existing versions of ruff complained that the format subcommand was experimental, so I bumped to the latest version as it does not say this.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Caching for list_accounts and list_tax_codes

Description:
I would like to request a feature that implements caching for the list_accounts and list_tax_codes methods in the CashCtrlClient class. This enhancement aims to reduce the number of API calls by caching the data on the first lookup and reusing the cached data for subsequent calls within a specified timeout period.
Proposed Solution:
A new class, CachedCashCtrlClient, extends CashCtrlClient and overrides the list_accounts and list_tax_codes methods to include caching functionality. The cache timeout can be configured during class initialization or adjusted later through a property.
In addition, I propose to provide lookup functions to map account numbers to account ids, or tax code names to tax ids, and vice versa.

account_to_id(account: float) -> int
account_from_id(id: int) -> float
tax_code_to_id(code: str) -> int
tax_code_from_id(id: int) -> str

A first implementation is available in the feat/cache branch and can be reviewed here:
CachedCashCtrlClient Implementation
Details:

Initialization: Accepts an optional cache_timeout parameter (default is 300 seconds).
Methods Overridden: list_accounts, list_tax_codes.
Caching Logic:

Data is cached on the first call.
Cached data is reused if the cache is not older than the specified timeout.
Cache expiration is checked using the _is_expired method.

Configuration: The cache timeout can be set during initialization or updated using the cache_timeout property.

Usage Example:
from cashctrl_api.cashed_client import CachedCashCtrlClient

# Initialize with a cache timeout of 600 seconds (10 minutes)
client = CachedCashCtrlClient(organisation='my_org', api_key='my_api_key', cache_timeout=600)

# Fetch accounts (data will be cached)
accounts = client.list_accounts()

# Fetch tax codes (data will be cached)
tax_codes = client.list_tax_codes()

# Lookup account ID by account number and vice versa
account_id = client.account_to_id(1000)
account = client.account_from_id(1)

Let's also add currencies to the cached objects. Currency lookup is also a frequent trigger for an (avoidable) API request.
Steps:

Add method CashCtrlClient.list_currencies(), similar to CashCtrlClient.list_tax_codes().
Extend CachedCashCtrlClient to include list_currencies() and the related mapping functions currency_from_id and currency_to_id.

Implemented as #29


chromephp shows messages twice on console

For some reason if I use chromephp it shows log messages twice. I also checked that log file contains that info just once and same with firephp.

What handlers do you have defined? Maybe you have two different ones doing the same? Or the same handler twice somehow? Because otherwise I don't see how this would happen.

here is my config for handlers:
monolog:
    handlers:
        main:
            type: stream
            path: "%kernel.logs_dir%/%kernel.environment%.log"
            level: debug
            channels: [!event]
            formatter: app.monolog_formatter
        console:
            type: console
            channels: [!event, !doctrine]
        firephp:
            type: firephp
            level: info
        chromephp:
            type: chromephp
            level: info

And if I remove that chromephp part, none of logs are coming to my chrome console.

So it's zero or duplicate? That's weird. If it was a bug in the code I'd assume we would see more similar reports, so I would guess it's something else but I can't think what.

Here is simple example of that.

So chrome shows those messages twice, firefox and tail -f dev.log file just once.

I wonder if it could be due to the JsonView extension or whatever you have there formatting the json, because they don't appear duplicate like A A, B B, C C but rather the whole sequence is duplicated, as if the response was handled twice.

Tried to disable chrome JSONView extension, no results

Any luck here?

nope still facing the same issue.

I think it is unrelated to monolog. I have the same issue with the Chrome Logger 4.1.0 extension and Chrome 51, but I'm not using monolog.
If you inspect the response from the application, and base64_decode() the contents of the X-ChromeLogger-Data header, it's clear that the data contains log entries only once. Yet, I have them duplicated too.
{
    "version": "4.1.0",
    "columns": [
        "log",
        "backtrace",
        "type"
    ],
    "rows": [
        [
            [
                "I should see this only once."
            ],
            "\/data\/public\/tests\/chromephptest.php : 3",
            ""
        ]
    ],
    "request_uri": "\/tests\/chromephptest.php"
}

I figured that (in my case) entries are duplicated in the console, if the response body is empty. If the PHP script has any output (beyond the headers), then the entries are not duplicated. It is not inline with your case, since you render a twig template but maybe comes from using an earlier version of Chrome?

same here. showing duplicated log entries when the response body is empty.

The browser is sending an additional request to get "favicon.ico" along with the web page request. If "favicon.ico" doesn't exist, then it would have a 404 and actually triggers the error. I had the same problem and I resolved it by adding favicon.ico to the web root.
You can test this by making a curl request to the same page on the console which would log once regardless if you have a "favicon.ico" or not (assuming the logging happens when the error or exception handled).
Hope this helps.

This is a chromelogger issue, see https://github.com/ccampbell/chromelogger/issues/64

There is src/monolog/Registry.php file have some option to "hasLogger". I will  try it.

Just to add my 5 cents worth on this subject.  I was seeing this behavior also and discovered that moving three header('') lines below include 'ChromePhp.php' made the duplication stop.  FWIW.


Draft: Test import helpers to reduce bundle size

testing import helpers: https://github.com/Microsoft/tslib

Because this can avoid duplicate declarations of things like __extends, __assign, etc., this means delivering users smaller files on average, as well as less runtime overhead. For optimized bundles with TypeScript, you should absolutely consider using tslib and --importHelpers.

not seeing a bundle size improvement. closing this.

@anthony-murphy - do you have insight into how this didn't improve bundle sizes? I was surprised FF didn't do this already to be honest and was logging on to create an issue actually

Also if we do this, please use tslib >v2


fix(api-spec): ensure api spec validates

closes https://github.com/go-vela/community/issues/432
depends on https://github.com/go-vela/types/pull/208 (/version endpoint returns a Version object)
contains:

various fixes to spec annotations (spelling, correctness, missing info, etc)
adds spec validation to validate workflow in GitHub Actions
consistent import sort in /api package

no code was changed, but theses edits should result in the automation producing a valid and more accurate API spec.
note: validate workflow will fail due to new spec validation until the dependent PR is merged and /types import is updated

pointing at HEAD of go-vela/types for now.. we'll cut one more RC with proper tagging after this is merged


How to use useHover and useFocus together without overriding the props returned by the first hook?

❔ Question

I need to read hover and focus state of a component and its descendants. How can I use useHover and useFocus together without overriding the props returned by the first hook?
E.g. in the example below, {...focusProps} will override (some of) the props in {...hoverProps}.
🔦 Context

I have carousel component with auto-play. It should pause if it is hovered (and continue playing if unhovered). On interaction (i.e. on focus), it should stop playing too.

💻 Code Sample

const { hoverProps } = useHover({/* ... */});
const { focusProps } = useFocus({/* ... */});

return (
  <div {...hoverProps} {...focusProps}>
    {children}
  </div>
)

You can use our utility function, mergeProps. This will chain together any handler functions so that they are all called
https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/utils/src/mergeProps.ts

You can use our utility function, mergeProps. This will chain together any handler functions so that they are all called
https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/utils/src/mergeProps.ts

Thank you very much! (And sorry for not reading the docs thoroughly.)

Thank you very much! (And sorry for not reading the docs thoroughly.)

@asterikx Can you provide some information on how you built a carousel using react-spectrum.


Difference between SUM and MEAN treatment of weights

When using iris.analysis.MEAN, the code calls numpy.ma.average - which normalizes the weights before the operation. When using iris.analysis.SUM, the code uses the private function _sum which doesn't normalize the weights. This means that the functions respond very differently when given normalized or not-normalized weights:
weights sum:     100.0
SUM aggregator
orig weights data sum:   180.713
normed weights data sum: 1.80708
MEAN aggregator
orig weights data sum:   0.488625122311
normed weights data sum: 0.488625114254

Is this intentional? I'm afraid I don't quite understand the target usage..

Yes it is intentional. The SUM aggregator is designed to be used for things like integration or filtering where the for each weight the magnitude as well as the relative fraction is important.

See #626 for background.

Thanks AJ, that's very informative.


[crash] GeoLocator WinPhone8.1 / Geolocator does not stop

Please take a moment to fill out the following (change to preview to check or place x in []):
This is a

[x ] Bug
[ ] Feature Request

Which plugin does this impact:

[ ] Battery
[ ] Connectivity
[ ] Contacts
[ ] DeviceInfo
[ ] ExternalMaps
[x ] Geolocator
[ ] Media
[ ] Permissions
[ ] Settings
[ ] Text To Speech
[ ] Vibrate
Other:

Version Number of Plugin:
Device Tested On:
Simulator Tested On:
Expected Behavior
That I can start and stop the Geolocator with the functions StartListeningAsync() and
StopListeningAsync()
Actual Behavior
The Geolocator does not stop after calling StopLiseningAsync. An exception is thrown in the Windows GeoLocator with the second start.
Steps to reproduce the Behavior
use the following code:
IGeolocator o = CrossGeolocator.Current;
o.StartListeningAsync(0,10).Wait();
o.StopListeningAsync().Wait(); // geolocator incon still active on screen
o.StartListeningAsync(0, 10).Wait(); // crash on loc.ReportInterval = (uint)minTime; in the public
// Task StartListeningAsync(int minTime, double minDistance, bool includeHeading = false) method.
Probable cause:
Both problems (does stop and crash) seam related to the fact to in the StopListeningAsync() there is no removal of the loc.StatusChanged event handler. When this event is unsubscribed everything seams to work fine.

Typo: loc.StatusChanged  should be locator.StatusChanged.

you should never call .Wait() on a async method, ever.
can you try:
await o.StartListeningAsync(1000,10);
await o.StopListeningAsync();
await o.StartListeningAsync(1000, 10);

Even with the await the problem remains the same. This problem has nothing to do with async behavior.

Are you Win Phone 8.1 RT or Silverlight?

Additionally you should do:
if(!o.IsListening)
  await o.StartListeningAsync(1000,10);

if(o.IsListening)
    await o.StopListeningAsync();

if(!o.IsListening)
    await o.StartListeningAsync(1000, 10);

Also, why are you calling them back to back like this? Is this just a sample or are you calling them all three in a row as that doesn't make a lot of sense.

I tried to investigate the problem and minimize the code to show the problem. I made the problem reproducible with only 4 lines of code. Just so that you don't need to read so much :)
To my shame:  I cannot tel you if I use RT or Siverlight. How can I see this?
I created a Xamarin shared forms project, and i'm using the windows phone 81. project, not the windows or the universal windows project. I cannot see a refrence to either WinRT or Silverlight in my project settings. But maybe i'm looging on the wrong place. :)
The tests of IsListening  are already handeled in your library (throwing an exception or return true). In this case they are beside the point, see example below. Futhermore:  The IsListening properties is controlled by your library and it will say that the geolocatoes is not listening even when the phone indicates that the location service is still active.
Actually I wrote a test program without your plug-in library that uses the winphone geolocator device directly and if a place there the code that is now in the start and stop method of your library it also reproduces:
Windows.Devices.Geolocation.Geolocator o = new Windows.Devices.Geolocation.Geolocator();
o.ReportInterval = 10; / this works fine
o.PositionChanged += PositionChangedHandler;
o.StatusChanged += StatusChangedHandler;
// do something
//o.PositionChanged -= PositionChangedHandler; // do not unsubscribe one of the events.
o.StatusChanged -= StatusChangedHandler;
//do something
o.ReportInterval = 10; //crash
And it goes wrong by multiple properties (ReportInterval, MovementThreshold)
Only6 when both events are unsubscribed, it is possible to change these properties, and the phone indicates that your appe is not using the GPS/location service.
In your library the Statuschanged event is not 'released', which causes the problem.
In my real application I want the location services only available when a certain page is active. That's why I activate and deactivate the geolocator. In android this works without problems, iOS I did not test yet, and winphone show the behavior as written above.

I tried it on Silverlight and on WinRT: only the winRT version crashes, in Silverlight it works as expected.

There was  PR to fix this in alpha2


small updates to visualizations tutorial

update some text to fit with new input dataset we're using and remove unrelated objectives from metadata

Thanks!


ALE prettier fixer not processing based on FileType

Information
VIM version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 13 2018 10:30:54)
macOS version
Operating System: macOS High Sierra 10.13.4
:ALEInfo
 Current Filetype:
Available Linters: []
  Enabled Linters: []
 Linter Variables:

 Global Variables:

let g:ale_cache_executable_check_failures = 0
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = 100
let g:ale_completion_enabled = 1
let g:ale_completion_max_suggestions = 50
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {'typescript': ['prettier'], 'markdown': ['prettier'], 'scss': ['prettier'], 'json': ['prettier'], 'javascript': ['prettier'], 'css': ['prettier']}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = 10
let g:ale_list_vertical = 0
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = 0
let g:ale_open_list = 0
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_info = '--'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = '--'
let g:ale_sign_warning = '--'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

What went wrong
I have g:ale_fixers  set:
let g:ale_fixers={
	\'css': ['prettier'],
	\'javascript': ['prettier'],
	\'json': ['prettier'],
	\'markdown': ['prettier'],
	\'scss': ['prettier'],
	\'typescript': ['prettier']
\}

It works on corresponding files of the respective types. However, if I start with an empty buffer and use :setfiletype, it seems that only 'javascript' and 'typescript' filetypes will be processed. Nothing happens for the rest.
Reproducing the bug
Steps for repeating the bug:

Start vim
:setfiletype css
Type in some CSS that isn't formattedbody{margin:0;padding:0;}

:ALEFix

Nothing happens. Let's try Javascript.

Open a new, empty buffer
:setfiletype javascript
Type in some Javascript that isn't formattedfunction test(){console.log('Test')}test()

:ALEFix

This gets formatted.

Gotcha. ALE did use the --parser option at some point, but someone removed the code for that. I'll add it back again.

prettier doesn't require the use of --parser anymore as it infers it now.

Both the babylon and flow parsers support the same set of JavaScript features (including Flow). Prettier automatically infers the parser from the input file path, so you shouldn't have to change this setting.

You need --parser based on the FileType if there's no filename (ie new buffer).
For example, if you grab compressed JSON output from an API and you want to format it for debugging.

Yep, --parser is needed where prettier can't figure out what type of file you have, but where Vim knows what type of file it is.

@w0rp PR available at #1620. I've only updated the existing tests to account for the --parser option. It would be nice to have specific tests against supported filetypes, but my VimFu is elementary level.


Fix Back Button Navigation in Help Doc.

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/22014
PROPOSAL: https://github.com/Expensify/App/issues/22014#issuecomment-1634835919
Tests
Note:
This task should be tested on the local dev environment because the Help tab in the Settings sidebar has hardcoded link to https://help.expensify.com. (See here)
Pre-condition: If testing on local dev environment please go to the following files and omit the hard coded hostname(https://help.expensify.com) such that the links become relative to the current host.
Files:

https://github.com/Expensify/App/blob/main/docs/articles/playbooks/Expensify-Playbook-for-Small-to-Medium-Sized-Businesses.md?plain=1#L8
https://github.com/Expensify/App/blob/main/docs/articles/playbooks/Expensify-Playbook-for-US-Based-Bootstrapped-Startups.md?plain=1#L7-L8

For Dev Environment:

In root run npm run createDocsRoutes
cd docs &&  bundle exec jekyll serve

Test Case 1:

Click Playbooks
Select Expensify playbook for small to medium sized business
Click the link US-based VS-backed Startups
Click the back button
Verify that user is navigated back to the previous page instead of the hubs page.

Test Case 2:

Click Playbooks
Select Expensify playbook for small to medium sized business
Click the link US-based VS-backed Startups and open it in a new tab
Click the back button
Verify that user is navigated back to the relevant hubs page.
Same behaviour should happen in case of deep link and bookmarked link.

[ ] Verify that no errors appear in the JS console

Offline tests
Same as above

QA Steps
This cannot be tested on staging because the Help Docs are only available on production. To test the changes once on production, follow the following steps:
Test Case 1:

Go to settings > help > Playbooks
Select Expensify playbook for small to medium sized business
Click the link US-based VS-backed Startups
Verify that user is navigated back to the previous page instead of the hubs page.

Test Case 2:

Go to settings > help > Playbooks
Select Expensify playbook for small to medium sized business
Click the link US-based VS-backed Startups and open it in a new tab
Click the back button
Verify that user is navigated back to the relevant hubs page.
Same behaviour should happen in case of deep link and bookmarked link.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/36226639/1653cce2-5efa-431d-8dc9-9c6f95ae14a8

Mobile Web - Chrome
https://github.com/Expensify/App/assets/36226639/93a14490-35c6-4c71-8e16-7bb7cee9fbaf

Mobile Web - Safari
https://github.com/Expensify/App/assets/36226639/5d7f24b1-d395-4888-be6c-405fe7a244e6

Desktop
Not Applicable as help docs are only web based

iOS
Not Applicable as help docs are only web based

Android
Not Applicable as help docs are only web based

recheck

I am facing errors in setting up the project. Any hints? I have M2 Pro.

Can you provide more details about the errors?I am also working on M2 Pro.

This is the error while, I am running serve command.
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
            Source: /..../Expensify.cash/docs
       Destination: /..../Expensify.cash/docs/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
       Jekyll Feed: Generating feed for posts
  Liquid Exception: undefined method `tainted?' for "2.8.0":String in /_layouts/default.html
jekyll 3.9.2 | Error:  undefined method `tainted?' for "2.8.0":String

Which ruby version are you using?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.42-0 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
cancelled 🔪

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


add a password generator

hello! can i work on this issue :)

do i need to add the password generator as a box  to the main index file?

@Alcadeus0 yes

done, let me know if any changes are needed


Fix syntax highlighting

Does this fix #11?

@fofr yes, I double checked and updated one of the colours slightly which was alllmost 4.5:1 so that is passes.


Support rest pattern in destructuring

Resolves #545.

One way ObjectRest could be improved is by passing a set-like object for usedProperties instead of an array that has to be manually searched:
const {a, b, ...rest} = {a: "A", b: "B", c: "C", d: "D"};

function __TS__ObjectRest(target, usedProperties)
    local result = {}
    for property in pairs(target) do
        if usedProperties[property] == nil then
            result[property] = target[property]
        end
    end
    return result
end

local ____ = {
    a = "A",
    b = "B",
    c = "C",
    d = "D",
}
a = ____.a
b = ____.b
rest = __TS__ObjectRest(____, {
    a = true,
    b = true,
    rest = true,
})


Add features to browse Task Sequences and dependencies

Add features to browse Task Sequences and dependencies

Basic properties are now viewable in build 2<IP_ADDRESS>


[CI] Commit package-lock.json

Fixes #5784
Contributes to #5786

Ah, more care will be needed in using this approach. Putting this in draft, I'll come back to it later.


CAS-516: Convert rebuild tests to Docker Compose tests

Rebuild test cases in nexus_rebuild.rs have been converted into Docker
Compose tests in rebuild.rs. The reason for this change is to make the
tests more representative of real world applications. As an example, the
new tests share replicas over NVMf.
One test (rebuild_lookup) remains in nexus_rebuild.rs. This test cannot
be converted to a Compose test as the functionality is not exposed over
RPC. However, the test is still useful and hence remains.

LGTM

bors merge


remove short-circuiting tests for R.any and R.all

This was discussed in #881. These tests assert left-to-right enumeration order, but nothing in the definitions of these functions requires a particular enumeration order. Rather than test for a specific implementation, let's consider short-circuiting part of the specification for each of these functions.

:cow2:

:+1:
@buzzdecafe and I discussed this today.  It really seemed like an important point at the time I wrote them, but the more I think about it, the less I like these tests.
I'm not sure about your distinction between test and specification here.  I think of unit tests as one way to write a decent (partial, to be sure, but useful) specification.

All I was saying is that the specification of a function can live anywhere. For example, we could include:
R.all stops performing tests as soon as a value disproves the hypothesis.
in the documentation.


[Networking] - AnswerClasses - AnswerContent update

Responds to this comment in
[Play/Networking] - Short Answer Response Base #875.
Adjusts AnswerClasses so that attributes in BaseAnswer and AnswerContent are more legible and organized. When approved, code will be updated to accomodate this.

This PR is replaced by https://github.com/rightoneducation/righton-app/pull/964. Closing this one.


ansible -m ping localhost is not working from ansible server

<IP_ADDRESS> | UNREACHABLE! => {
"changed": false,
"msg": "Failed to connect to the host via ssh: Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known<EMAIL_ADDRESS>Permission denied (publickey,password).",
"unreachable": true
}
I have added the IP <IP_ADDRESS> in /etc/ansible/hosts  file.

In host file just add "localhost" (without quotes).
Also have you copied ssh-key, if not then execute the following command on Ansible configuration machine:
ssh-copy-id localhost

In host file just add "localhost" (without quotes).
Also have you copied ssh-key, if not then execute the following command on Ansible configuration machine:
ssh-copy-id localhost

ssh-copy-id @localhost

hey rajesh
are you able to connect to node manually i.e from command line
ssh username@ip_address (change values accordingly)

please update this issue after doing this
don't forget to change and restart sshd before doing this

hey rajesh
are you able to connect to node manually i.e from command line
ssh username@ip_address (change values accordingly)
please update this issue after doing this
don't forget to change and restart sshd before doing this

it worked for me. Thanks and closing the issue.


🐁 add cursor

Hey! I wanted to solve this issue: https://github.com/BcRikko/NES.css/issues/2.
I saw how you did the icons with the pixelize mixin, however, as far as I know, the cursor property can only receive an URL. So I added the images folder and cursor-url variable which holds the url for the cursor.png. MDN Docs Reference for cursor.
Also, I wasn't very sure how to test this, I don't know how to build the project. I wanted either a .css file or a URL to import it. So I couldn't test this branch :slightly_frowning_face: .
Can you help me to do this? I am not that good in CSS at all hahha.

What a wonderful Cursor 😍
I'll confirm this PR. 🔍
Could you make SVG instead of PNG?
I think that it seems that usability is better. 🤔

Looks good 👍

I've also made the image to be a SVG. Are you ok with the name of the folder? If you have any other idea, please tell me!

Also, by looking at your usage GIF, I've questioned myself if this Pull Request shouldn't also include a cursor for the click too. What do you think?
Maybe something like this:

If you think it is a good idea, I can do it :slightly_smiling_face:

Thanks for  converting to SVG.
It's greate suggestion 👆
Please commit click cursor 😆

Are you ok with the name of the folder?

well... Could you rename /images to /assets.

I've done both the folder name change and added the click cursor :slightly_smiling_face:
Can you review this Pull Request again?
I wanted to test it, however I don't know how to build the project. Can you test it or teach me how I can test it?

Thanks 🎉
I will review your PR later.

Can you test it or teach me how I can test it?

Please read here 🙏  -> https://github.com/BcRikko/NES.css/blob/master/README.md#development

@IngwiePhoenix Thank you for complementing me 🙇
I'm using VSCode's Live Server extension.
Since you can easily start the HTTP server, if you are using VSCode try it. 👍

According to the MDN Docs, only Firefox is compatible with SVG, So PNG would have to be used instead.

Really? I'm very sorry that I failed to make sure. 🙇🙇🙇
I confirmed https://modalzmodalzmodalz.com/ using BrowserStack.
because this site uses SVG cursor.

Firefox63: OK
Chrome70: OK
Opera56: OK
Safari11.1: OK
IE11: NG
Edge17: NG

oh, IE... 😭

Oh that doc probably needs to be updated then. I was unable to get the SVG cursor to work (probably because the width and height weren't set correctly (docs).
I resized the PNG to a 32x32 image[1] however, and it works fine. I'm guessing the PNG would work better than the SVG here though since the size is smaller.
[1]

So, should I make both images png?

@otaviopace Yes, please 🙏
It is useful to have both images 😍
and don't worry about conflicting files 😊
I'll resolve it when I merge. 👍

I've added the images as png files :slightly_smiling_face:
I tried to test it locally, but my browser keep saying Invalid property value at the cursor property :thinking: .

I've searched on the web and I found this: https://stackoverflow.com/questions/37307284/cursor-invalid-property-value
However, even with the adicional properties suggested by Stack Overflow users, it didn't worked properly :confused: .
Can you check if it still works at your computer?

I've fixed the images! However some parts of the page still show the old cursor:

umm....Let me confirm later 🔍 👀

It looks great. 🎉

The problem was that the labels were with a cursor: default; for some reason

umm...I'm not sure for reason. 🤔
There's one thing that bothers me. 😖
so I'd like to read and study  W3C document. 📚

It was due to the user agent stylesheet 🤔
Could you add and remove the following code 🙏
// generics.scss

// ↓ remove code
// body:active {
//  cursor: $cursor-click-url;
//}

// ↓ add following code instead of `cursor: $cursor-url, auto;`
label {
  cursor: inherit;
}

then we can merge this PR 🎉

I've made the changes, however I have some problems :confused:
First one is that by doing a git rebase to update my branch with the new content, the command npm run build started to fail, so I've created an Issue, and a Pull Request fixing the problem. :slightly_smiling_face:
The second one is that on the top and bottom of the sample page, the cursor does not work. I've been able to fix the issue by changing this code:
// generics.scss

// ↓ add following code to work on the whole page
html {
  cursor: $cursor-url, auto;
}

// ↓ remove the cursor property
body {
  font-size: $font-size;
  color: $base-color;
  // cursor: $cursor-url, auto;
  background-color: $background-color;
  -webkit-font-smoothing: none;
}

Do you agree with this change? If you do I will push this code and then we can finally finish this Pull Request :tada:

Hey @otaviopace, make sure to merge the latest version of the develop branch so that our CI will run the required checks for this PR. 😉

@otaviopace yes, I agree 👍
Thanks 🎉

I've finally been able to pass the CI!! :tada:
I had to remove the :mouse: emoji from the commit because of the commitlint :slightly_frowning_face:

YESSSSSSS!!!! Thank you soooooo much for the help!!! :heart: :tada:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Question: discogan paired dataset

Hi! I don't quite understand why the dataset for discogan consists of paired images - the description claims that discogan can discover cross-domain identities in upaired data. Maybe I'm misinterpretig the dataset loader? I don't see how pairs would be mixed / randomized.

I agree, discogan is unpaired unsupervised and should be changed.


feat: saving tx_hash when settling certificate

Description
This PR is adding the support of saving the tx-hash generated by the ContractCall settlement on L1.
By default, the field is None, when the certificate is settled, it contains the tx-hash.
PR Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added or updated tests that comprehensively prove my change is effective or that my feature works

closing as it is outdated


Alfa Release

Basic Requirements should be complete, one last pass-through to make sure nothing is too wrong.

[x] Make sure there is nothing that sounds illegal (no references to scams, ponzis, etc)
[x] Check for broken links
[x] Flow is logical and complete (create token -> launch crowdsale -> view crowdsale)
[x] Looks reasonable on desktop and mobile
[ ] Home page "Events" -- replace with real coins?
[x] JSON file import has no unlock button
[x] Clarify what it means to open a wallet

Any other comments?

I cant unlock wallet from json using chrome on windows. No unlock button.

Except for the "events" box, i think we've covered all the alfa components. closing this out!


Fix shell default for Catalina, and uninstall bug

This addresses https://github.com/fabiomaia/linuxify/issues/23 as well as fixing a bug that was preventing it from completing an uninstall - script needs to run from /bin/bash to remove /usr/local/bin/bash

Thank you! <3


Concept of a tunnel?

Hi! I'm new to the set of tools here, and I'm pretty excited to try them out! I was wondering how this might relate to a tunnel - e.g., would it be that if I have  a wish app locally, I could connect to a server (with other apps) and continue as many levels as needed until I find what I need? What about something like a proxy jump (so I could see nested apps from two levels up, for example). Thanks!

Hey,
Not 100% sure I understood your question, but if I did: yes, you can SSH from one Wishlist instance to another, indefinitely (in theory, haven't tested more than 3 🤔).
ProxyJump is not supported though.

To give more context, the use case I'm interested in is high performance computing, where it's common to want to interact with a compute note via a login node from your local machine. E.g.,:
<local machine> -> <login node> <compute node>

and the compute node is isolated, meaning no ports can be opened and we typically have to use an ssh tunnel through the login node back to our host.  These tunnels can actually be done with ports or unix sockets!
So let's say I have an app (developed with this library maybe) running on the compute node - first  can I assume anything that is written in Go / able to be interacted with from Go is contender to be included in a wish app? and if so, could I theoretically interact with it from my local machine via wish? :thinking:

SSH port forward via wishlist is not supported, if thats the question.
Wishlist can SSH into any valid SSH host, it can be a wish app, another shell, pretty much anything really.
I'm still not sure if that's what you were asking though, sorry if its not.

It's ok, thank you for your help! I'm trying to figure out ways to make the chronically (kind of bad) experience of interacting with HPC resources slightly less so. It sounds like I couldn't easily do some of the harder stuff like tunneling, and I'm happy to close the issue.


add og and schema.org metadata

Motivation
DEVREL-851
Adds metadata for OpenGraph and schema.org, pulled from SEO metadata snippet on article, product and WSL homepage. Default metadata are pulled from homepage and used where not supplied from corresponding item.
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
Google structured data tester
OG tester

implemented into AppPage component
added support for 3 schema.org types

Article
WebPage
Product

All of the above share common properties defined in the SEO snippet, open graph support added as well.
SEO snippet is defined for WSL Root, Product and Article. For pages without SEO snippet or in case some snippet value is missing, default SEO is used. For that matter, each page now calls getDefaultMetadata method which loads the values from WSL root.


AddFieldWithIdArgumentIfExists no longer works if collection is paginated

AddFieldWithIdArgumentIfExists won't detect paginated lists with Ids properly and add a relative field.
eg this test fails
OffsetPagingTests

        [Fact]
        public void IdPropertyStillGenerated()
        {
            var schema = SchemaBuilder.FromObject<TestDataContext2>();
            Assert.NotEmpty(schema.Query().GetFields().Where(x => x.Name == "person"));
        }

but this passes
        [Fact]
        public void IdPropertyStillGenerated()
        {
            var schema = SchemaBuilder.FromObject<TestDataContext>();
            Assert.NotEmpty(schema.Query().GetFields().Where(x => x.Name == "person"));
        }

unsure this this would require AddFieldWithIdArgumentIfExists to somehow understand paginated lists, run before extensions are applied or if there's another good fix.

Added PR with attempt to fix this by moving AddFieldWithIdArgumentIfExists to before extensions are executed


build hevc codec string

@J1ng06 I've updated my PR to follow your advice on using bits.Reverse32 and changed the function name to CodecString, which is further away from the actual Mime parameter codecs, but is easier to understand. I see some advantage of keeping CodecString a function instead of a method of SPS.
So, I'll merge my PR and make a new release, so we can drop this one. But, it has been quite helpful to get it and I encourage you to submit PRs for other areas where you find holes. To avoid "double work" it may be good to file an issue and tell that you could contribute the corresponding fix or enhancement.
Thanks again for your submission!

@TobbeEdgeware thanks for the great work 🍺 .  I will file an issue first next time before I start working on it


[WIP] Support for go1.8

This will eventually close #141`

I think the 'WIP' suggests to do the code review only once the PR is complete, right?

@cznic not really, mostly each commit is independent, and you can review as new commits comes in. Only merging has to wait until it is complete.
It will be really helpful to me if we review as I add new features so that by the end I wont have duplicate efforts for the case when I make bad choices.
For Instance, your feedback on the commits which add NamedArg support, can help clear that feature. I intend to work on adding support for canceling queries, which will probably cover the rest of go1.8 features.

Okay, thanks for letting me know. The plan is to clear the codereview queue this evening.

Thanks. I will now see how I can introduce context.Context and enforce canceling of running queries.

I will now see how I can introduce context.Context and enforce canceling of running queries.

The row retrieving closure has to return more == false to stop the query: https://github.com/cznic/ql/blob/eb22df22d0ac223dcd91f16d6de0fc4cfdf768a5/ql.go#L225

@cznic  neat trick
[OFFTOPIC] effectively testing the query cancelation I have to slow down queries, in postgres they use pg_sleep.
I already laid out the groundwork for supporting something like pg_sleep just wondering what will be  a better name for the function sleep or ql_sleep?
I will submit a separate PR for the function

@cznic Can we just merge these changes?
I have hit a wall trying to make queries cancelable. When we come up with a way to halt execution maybe someone can pick it up from there.

Can we just merge these changes?

Yes.


RHIDP-1454: Document TechDocs plugin

Version:
1.2+
Jira:
RHIDP-1454
Preview link:
Admin guide - Configuring the TechDocs plugin in RHDH
Reviews:

[x] SME: @kadel
[x] QE: @Omar-AlJaljuli
[x] Docs: @abrennan89

Why is this in getting started? Should this be in the administering section?
I always thought that getting started should be just a quick installation procedure and everything else should be in the admin section.

Why is this in getting started? Should this be in the administering section? I always thought that getting started should be just a quick installation procedure and everything else should be in the admin section.

Can these procedures only be performed by an Admin? Or can other users perform these actions?
Also, this placement is temporary, as we are beginning to deconstruct the Getting Started guide into a series of smaller, journey-based guides.

Can these procedures only be performed by an Admin? Or can other users perform these actions?

everything that we have so far in our documentation is about deploying and configuring rhdh instance, those tasks are going to be done by admins

I had a call with @linfraze, and we agreed on a few minor changes and improvements. After those, this will be ready to be merged. The core part of the documentation is solid so, I don't need to do another round of review (and I won't be able to do that anyway as I'll be away for next 2 weeks 🏖 )

/cherrypick 1.2.x


Add new hooks tutorial by Eric Bishard

I think that this article can be very beneficial to the React community that follows this awesome repo.
This is a very good and in-depth article on React hooks. Eric has worked on it for a long time in order to make it very informative, so any new and experienced React developers can find it useful.
Eric has already made talks on a couple of conferences for React hooks including the latest one React Loop.
This is a sign that he has put a lot of effort into learning many details for the hooks and sharing them can be very useful for the community:
https://www.youtube.com/watch?v=HuCWWvgizDg

Looks good. The title of the article maybe has changed?
Going to https://www.telerik.com/kendo-react-ui/react-hooks-guide the title is "The Guide to Learning React Hooks (Examples & Tutorials)"

@aarongarciah Indeed the title has been changed, mostly to SEO reasons, as users tend to search more about tutorials.

Thanks!