no Issue - Request for a new Tank form

would it be possible to add a calculation for this kind of Tank?

Hi @dremeier,
I have nearly completed the calculations for those tanks.  Will try to update the documentation in the next days, so you can test it.
However I need to have a decent name for this type of tanks.  In many places (e.g. here) they call them oval tanks, but I have oval tanks already in this node for another tank type.  So not sure how to call them ...
Bart

Hi @bartbutenaers,
that sound very good.
This kind of tanks is called "Batterietank" in german. I don´t know if "battery tank" would be a decent name for it.

I think they call it battery tank, becaus you have a series of N identical tanks.  Like in a battery.  But this node only calculates a single of those tanks.  So need to know how these volumes are called...

I will go for the horizontal and vertical "stadium" tank.  Thanks to wikipedia (see stadium geometry).

very good, wiki is really very helpfull :-)
please let us know when you are ready with the stadium tank, I`ll test it.

Version 1.1.0 is available for testing.  Since it is not available on npm yet,  Therefore you need to install it from this Github repo.  After you have git installed, you can install this repo by executing following command (from within your .node-red folder!!!):
npm install bartbutenaers/node-red-contrib-tank-volume

After refreshing you flow editor browser screen, you should see the two "stadium" new tank types:

Would be nice if you could do some tests, e.g. by comparing my calculations with an online calculator.  For example this calculator offers a horizontal/vertical "oval" tank, which looks like our statium tank.  When you entire the tank dimension and the fluid height, you can calculate the total liters and liters filled:

You can compare those numbers with the one calculated via this node...
Note that you should do tests with all kind of measured heights: when only part of the bottom circle is filled, when it is filled somewhere until the rectangular part, and at the end if the tanks is filled until the upper half circle.
Note that you can set the parameters in the node's config screen, or inject the settings via the input message.
Here is an example flow:

[{"id":"fe6bdcd4d8bb26d3","type":"debug","z":"6063841c422bab25","name":"Volume","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","statusVal":"","statusType":"auto","x":940,"y":1120,"wires":[]},{"id":"fd5241ec19ad8ac5","type":"inject","z":"6063841c422bab25","name":"Horizontal stadium","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"{\"tankType\":\"horiz_stad\",\"width\":300,\"height\":100,\"length\":200,\"measuredHeight\":20}","payloadType":"json","x":530,"y":1120,"wires":[["79a8e5409d310365"]]},{"id":"79a8e5409d310365","type":"tank-volume","z":"6063841c422bab25","name":"","tankType":"none","inputField":"payload","outputField":"payload","measurement":"fluid","inputUnit1":"cm","inputUnit2":"l","outputUnit":"l","topLimit":0,"bottomLimit":0,"diameter":0,"length":0,"width":0,"height":0,"length2":0,"width2":0,"height2":0,"coneHeight":0,"cylinderHeight":0,"diameterTop":0,"diameterBottom":0,"customTable":[],"x":750,"y":1120,"wires":[["fe6bdcd4d8bb26d3"]]},{"id":"f02bbf975745d2f8","type":"inject","z":"6063841c422bab25","name":"Vertical stadium","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"{\"tankType\":\"vert_stad\",\"width\":100,\"height\":300,\"length\":200,\"measuredHeight\":280}","payloadType":"json","x":520,"y":1180,"wires":[["79a8e5409d310365"]]},{"id":"557755e58d359c59","type":"debug","z":"6063841c422bab25","name":"Volume","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","statusVal":"","statusType":"auto","x":940,"y":1300,"wires":[]},{"id":"d259c8493f0f8ecc","type":"inject","z":"6063841c422bab25","name":"Measured depth","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"20","payloadType":"num","x":520,"y":1300,"wires":[["20cde38e9079224f"]]},{"id":"20cde38e9079224f","type":"tank-volume","z":"6063841c422bab25","name":"","tankType":"horiz_stad","inputField":"payload","outputField":"payload","measurement":"fluid","inputUnit1":"cm","inputUnit2":"l","outputUnit":"l","topLimit":0,"bottomLimit":0,"diameter":0,"length":"200","width":"300","height":"100","length2":0,"width2":0,"height2":0,"coneHeight":0,"cylinderHeight":0,"diameterTop":0,"diameterBottom":0,"customTable":[],"x":750,"y":1300,"wires":[["557755e58d359c59"]]},{"id":"0bd9ceb998918e61","type":"debug","z":"6063841c422bab25","name":"Volume","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","statusVal":"","statusType":"auto","x":940,"y":1360,"wires":[]},{"id":"39c3681f5605f2e6","type":"inject","z":"6063841c422bab25","name":"Measured depth","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"280","payloadType":"num","x":520,"y":1360,"wires":[["0320e98773032d8e"]]},{"id":"0320e98773032d8e","type":"tank-volume","z":"6063841c422bab25","name":"","tankType":"vert_stad","inputField":"payload","outputField":"payload","measurement":"fluid","inputUnit1":"cm","inputUnit2":"l","outputUnit":"l","topLimit":0,"bottomLimit":0,"diameter":0,"length":"200","width":"100","height":"300","length2":0,"width2":0,"height2":0,"coneHeight":0,"cylinderHeight":0,"diameterTop":0,"diameterBottom":0,"customTable":[],"x":740,"y":1360,"wires":[["0bd9ceb998918e61"]]},{"id":"648a9291737b05f7","type":"comment","z":"6063841c422bab25","name":"Configure via input messages","info":"","x":520,"y":1060,"wires":[]},{"id":"60f66115b578fd6c","type":"comment","z":"6063841c422bab25","name":"Configure via the node config screen's","info":"","x":550,"y":1240,"wires":[]}]

That works fine! I´m very happy with this node.
Because the stadium tank comes often in a battery It could be helpful to have a multiplier of how many tanks you have. On the other hand it is easy to do that calculation by a function node.
Just as a thought, for the input units it would be nice to have mm instead of cm, so there is no need for a comma. makes it more simple?

I could add a multiplier, but then the config screen becomes more complex again.  Moreover some people will want to have the sum of all thanks while others want the result of a single tank, which means the output message will also become more complex.
Of course I could mention this on the readme page.  If you have a simple example flow, would be nice if your could share it so I can put it on the readme page...

The millimeters was an easy one:

Please install the node again from Github and test whether it is ok.  Note that both the tank dimensions and the measured depth need to be in mm!!
I understand your requirement about the comma, but I don't see why you want to work in millimeters.  Because do you have a sensor that is more accurate than 1 cm?  My ultrasonic transducers are not that accurate, so for me the millimeter option is useless (which is why I had never added it to this node).

I have added a tank battery section on the readme page.  Hopefully you don't mind that I have added your picture?  Have tried to find another one on the web, but couldn't find one (for domestic usage)...

That is absolutely fine to use my pic.
like to thank you very much for your work, it was very helpful for me.

Ok thanks!
As soon as you have tested the mm, I will publish it on npm

as expected, the mm version works like the other versions very well :-)

@dremeier,
Thanks for thinking out loud, and for testing!
Version 1.1.0 is now available in the palette:


[BUG] be-mu's noteskins permanent metric lane position when using wrong values

This happened while I was trying to make a be-mu noteskin.
On 4.14.0, putting wrong values for metrics like Single5LaneLocation or any LaneLocation metric can make all be-mu noteskins break and puts the game in a state that it can't load any other metrics (even when reloading them) with the only option to set the right values for the metric and restart the game. (Also it doesn't error)

Jous replaced the LaneLocation system with a better one where you can set the actual x position of the columns.


An attempt to improve configuration; a good amount of config class refactoring.

It's still a huge mess :)

Nope, still needs a bit more polish.


Rendering ignoring line breaks

Extension version: 0.49.2022082209
VSCode Version: 1.70.2
OS: linux

Steps to Reproduce:
Writing a comment with regular linebreaks (no double space at the end) will render wrong in vscode.

in github - the linebreak is rendered properly.

The actual content looks like this:

While the content is not proper markdown (which would require either an empty line or a double-space to render a linebreak) - i think this extension should align it's rendering to how github is rendering content.

The rendering of the markdown in the comment peek view is done by VS Code, not the extension, so we can't change how it's rendered from the extension.
What we can do is convert single new lines to double new lines before passing them to VS Code to render. Happy to try that out at the beginning of the next iteration to see if folks using the pre-release build of the extension notice anything different.

To verify:

Leave a comment with single new lines and double new lines in a PR.
Verify that the comment renders with the same new lines as on github.com
Edit the comment, but don't actually change anything. Verify that the editable comment looks the same as the same editable comment on github.com.
Verify that when you save you edited comment it renders the same as it did before editing.

For me this seems to work fine with v0.51.2022090509.

It doesn't work when there's a space before or after the new lines.

The "fix" for this also does bad things to code blocks. Reverting this change, and marking as upstream since this is how VS Code renders markdown.

@alexr00 how did we go from "this was implemented but causes a problem" to "not planned"?
i understand from the label it's upstream - but that'd at least imply a linked issue from upstream - no?

@xmatthias I don't think we make any change upstream in VS Code for this either given that the current behavior is more correct.
The change that I implemented here used a heuristic, and it was ultimately a bad heuristic.
The change that would be required in VS Code would make markdown rendering less correct, which isn't a change I would support making. I've just opened https://github.com/microsoft/vscode/issues/165727 in case it would be acceptable.


createQueries

Do you have any plan for createQueries() to support useQueries()?
https://tanstack.com/query/v4/docs/react/reference/useQueries

No, I think it does not make any mean. if u wanna using queries u can simply implement as belown
const queries = useQueries({
  queries: [
    { queryKey: usePost.getKey(), queryFn: usePost.queryFn },
    { queryKey: useProjects.getKey(), queryFn: useProjects.queryFn },
  ],
})

Makes sense. Thanks


Prompt dialog improvements

Use widget's type to set the type of dialog inputs. If it's a number, pass the min, max, and step options as well. From ComfyUI#1612

Switching those inputs to type="number" and adding step="0.05" would show the arrows, and allow keyboard up/down arrows and mouse wheel to change the value in 0.05 increments/decrements. Also, min and max attributes can limit the values whenever needed. Having to manually type values while you could use the mouse wheel to change them is rather cumbersome.

Close widget prompt dialogs by clicking canvas. From  ComfyUI#90

Allow closing with touch event. Currently if the dialog is rendered offscreen on touch device, there is no way to get rid of it other than refreshing

ComfyUI#1023 is also fixed

Maybe it's better if the original widget input popovers are replaced with Vue components, instead of changing them like this. Now that optional number inputs are being validated on the backend, I think it should be fine to use min/max/step for number inputs on the frontend.

Separated into #80 for closing prompt dialog and #81 for number inputs.


Update pagico.rb to latest, update url

Updated pagico.rb to latest, add sha256 no_check, updated url with latest path.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thanks but the the versioned url works correctly.


fix: set picture variable to point to avatarUrl

Summary
Default profile image is used even when the users crowdin profile is accessible
Fixes #55
Changes

update picture variable to point to users crowdin profile image

Codecov Report

Merging #56 (5789cea) into main (59a5c51) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   33.89%   33.51%   -0.38%
==========================================
  Files           5        5
  Lines         177      179       +2
  Branches       21       22       +1
==========================================
  Hits           60       60
- Misses        117      119       +2

Impacted Files
Coverage Δ

src/contributors.ts
0.00% <0.00%> (ø)


Feature #2834 - Added properties to Get-PnPUserProfileProperty cmdlet

Type

[x] Bug Fix
[x] New Feature
[ ] Sample

Related Issues?
Fixes #2834
What is in this Pull Request ?
Added additional properties parameter to retrieve specific data for a profile.

@EA12 Yes, this has been released in version 2.1.0.


Add telldus-core to homeassistant-base

telldus-core is needed for the tellstick component to work. Resolves home-assistant/hassio#225.
This builds a modified version of 2.1.3-beta1, adapted for Alpine, see https://github.com/bjorne/telldus/commit/687da09e5e09172204a98f5524ce737be196d0f9.
Please note that this is untested, and I've only tried building it for amd64 so far.

Hi @bjorne, @jeena,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

What we need future to work with that?
-> config need to be /config/telldus.conf or /share/telldus.conf ? (Do we need a config parameter for it?)
-> what we need start in background to make it working ?
-> Do we need any udev rules or other stuff ?

Hi @jeena,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@jeena I would love to do that, and I completely agree that a private fork is bad for several reasons. Will need to look into the process first, though. I should add that my C++ skills are limited, but I'll give it a try.

@bjorne maybe the tellstick developers can help you if you make a issue.
Anyway. What are the futures steps? Can you answer my question or we are not ready until next release...

I have a coupple of things:

We need a prepared /etc/tellstick.conf which works out of the box on the RPi
Wee need a way to be able to change /etc/tellstick.conf via ssh in hass.io
We need a way to start/stop the daemon tellstickusd (Arch has a systemd service file)
Is the documentation on https://home-assistant.io/components/tellstick/ sufficient?
The daemon will run in the homeassistant docker (if I understand the setup correctly) then it will need access to the USB device /dev/tellstick
We need to handle the udev rule which gets installed to /etc/udev/rules.d/05-tellstick.rules

Great list, @jeena 👍

We need a prepared /etc/tellstick.conf which works out of the box on the RPi
Wee need a way to be able to change /etc/tellstick.conf via ssh in hass.io

make install installs the default config to /etc/tellstick.conf already. Do you think that works on RPi?
Just an idea, what if we set SYSCONF_INSTALL_DIR to /config? That directory is already exposed via SSH.
Something like this: cmake -DSYSCONF_INSTALL_DIR=/config?

The daemon will run in the homeassistant docker (if I understand the setup correctly) then it will need access to the USB device /dev/tellstick

This device mapping worked for me locally when I tested with a simple docker image (Ubuntu host): --device /dev/bus/usb:/dev/bus/usb

I've opened a PR in the official telldus repo, if anyone wants to follow along or help out: https://github.com/telldus/telldus/pull/14

SYSCONF_INSTALL_DIR might work quite well because it's populated by CMake into the code https://github.com/telldus/telldus/search?utf8=✓&q=CONFIG_PATH&type=
I'm not sure if exposing the whole bus in necessary or if it would be enough just to expose the one tellstick device.

Jolly good work..

We need a prepared /etc/tellstick.conf which works out of the box on the RPi

The tellstick config generated by the build is sufficient to start with as a base for any user.
However, tellstick.conf out of the box is set up with a user parameter, in my testing i had to change the user from nobody to root otherwise the tdtool would not find the tellstick device. If you are aware of a better user to use on the homeassistant docker, feel free to adjust.

We need a way to be able to change /etc/tellstick.conf via ssh in hass.io

In the testing i compiled with defaults and simply moved tellstick.conf to /config and put a symlink in /etc to the file in config. This worked great..

We need a way to start/stop the daemon tellstickusd (Arch has a systemd service file)

While testing i simply ran the telldusd , i have not completed a systemd test with full start/stop/restart.
This can be added to the to-do list.

Is the documentation on https://home-assistant.io/components/tellstick/ sufficient?

We probably need to look in to making minor adjustments to point to the correct config settings.
The tellstick is also having a tool called tdtool which is invoked on the commandline, this is used to list, but most importantly to send the learning code to new devices tdtool --learn [deviceid].
I am not sure if we can call commandline in the homeassistant docker from the web ui, it needs to be clarified in the tellstick instructions on how to call tdtool.

The daemon will run in the homeassistant docker (if I understand the setup correctly) then it will need access to the USB device /dev/tellstick

I had no issues with device access while running the daemon in the homeassistant docker and having root as user in tellstick.conf.

We need to handle the udev rule which gets installed to /etc/udev/rules.d/05-tellstick.rules

As far as i can see, the udev rule simply handles plugging in and out of the device to call the helper if a usb with vendor id 1781 is plugged in?
Additional note/question:
Have you added full compilation in the dockerfile or simply added the armhf binaries? (just thinking of compatibility for any friends on other platforms :)

@bjorne you need to add libstdc++ in order to run telldus core.
In homeassistant/base/Dockerfile add libstdc++
RUN apk add --no-cache \
        confuse libftdi1 libstdc++ \

We probably need to look in to making minor adjustments to point to the correct config settings.
The tellstick is also having a tool called tdtool which is invoked on the commandline, this is used to list, but most importantly to send the learning code to new devices tdtool --learn [deviceid].
I am not sure if we can call commandline in the homeassistant docker from the web ui, it needs to be clarified in the tellstick instructions on how to call tdtool.

We can do that with a add-on. So you can use it inside home-assistant and for device handling you can access with a add-on like CEC/Bluetooth.

I compiled with defaults and simply moved tellstick.conf to /config and put a symlink in /etc to the file in config. This worked great.. mv /etc/tellstick.conf /config && ln -s /config/tellstick.conf /etc/tellstick.conf

We can't run that. We need fix set the path to /config or /share

We need a way to start/stop the daemon tellstickusd (Arch has a systemd service file)

We can only run a command, we have no systemd or sysv init system.
Do we need run the daemon inside home-assistant container or how they communicate with hass component?

We can do that with a add-on. So you can use it inside home-assistant and for device handling you can access with a add-on like CEC/Bluetooth.

Is it possible for the tdtool in an add-on to communicate with the daemon in the homeassistant docker?

We can only run a command, we have no systemd or sysv init system.

Then the command to run is telldusd & in order to start the daemon.

how communicate telldusd with others?

It's not quite easy to find out but I went on a hunt in the software and I think it creates named pipes in /tmp/ see https://github.com/telldus/telldus/blob/master/telldus-core/service/ConnectionListener_unix.cpp#L35
I found one call to this here https://github.com/telldus/telldus/blob/95f93cd6d316a910c5d4d2d518f772e43b7caa20/telldus-core/service/TelldusMain.cpp#L80 and https://github.com/telldus/telldus/blob/95f93cd6d316a910c5d4d2d518f772e43b7caa20/telldus-core/client/Client.cpp#L158 which calls it with the string "TelldusClient" in both the client and service so this one would have been /tmp/TelldusClient
That is my theory at least.

Solved: Fixed path for tellstick.conf to /config
edited telldus-core/services/CMakeLists.txt and changed config dir variable SYSCONF_INSTALL_DIR from /etc to /config.
Added proposed change in bjornes tellstick lib.
Verified to work in compilation and also when running telldus daemon and interacting with devices.
make install results:
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/sbin/telldusd
-- Installing: /config/tellstick.conf
-- Installing: /var/state/telldus-core.conf
-- Installing: /usr/local/lib/libtelldus-core.so.2.1.3
-- Installing: /usr/local/lib/libtelldus-core.so.2
-- Installing: /usr/local/lib/libtelldus-core.so
-- Installing: /usr/local/include/telldus-core.h
-- Installing: /usr/local/bin/tdtool
-- Set runtime path of "/usr/local/bin/tdtool" to ""
-- Installing: /usr/local/sbin/tdadmin
-- Set runtime path of "/usr/local/sbin/tdadmin" to ""
-- Installing: /etc/udev/rules.d/05-tellstick.rules
-- Installing: /usr/local/share/telldus-core/helpers/udev.sh

Other question, why we not make a add-on with https://github.com/p3tecracknell/tellprox/ and our work. With our work we can run now telldus inside a alpine add-on? Maybe that will be easy to setup at the end...

Not sure that tellprox would solve anything, it is an ui/scheduler rather than an replacement for the daemon. It still relies on telldus-core and the same daemon we are moving in on.
The learning of devices (ability to run tdtool) is not critical for publishing the telldus daemon in the homeassistant, this can be worked around by users until learning of devices is added/solved.
With the base we have now the users of hassio can add their info in the tellstick.conf and communicate with their devices.
Regarding communications from tdtool commandline, i have one thought.
tdLearn seem to be available in the API with an integer as input. Could it be possible to integrate this in the tellstick.py script to initiate sending of selflearning code to devices from web ui maybe..
It would probably need to visualise a button in the web ui for each selflearning* device.
And this would probably gain not only hass.io but all homeassistant users when using tellstick to avoid having to enter the console to send code to selflearning device.

I dug around a bit more and eventually found a slightly better build process, with inspiration from this Dockerfile. It builds the code from an already existing PR https://github.com/telldus/telldus/pull/13. That PR has fewer changes than ours, so I think it has a higher chance of getting merged into upstream.
The process has these three differences compared to the existing one:

Symlink ftdi1 -> ftdi (as it appears it's actually Alpine's fault to name them wrong?)
Clone from https://github.com/henriknil/telldus/tree/compiler_issues
Build without tdadmin; cmake [...] -DBUILD_TDADMIN=false

That way we entirely avoid maintaining our own fork.
@endor-force nice! doesn't it work to do cmake [...] -DSYSCONF_INSTALL_DIR=/config instead of updating CMakeLists?
I'll push my changes to get some feedback.

Nice findings @bjorne and yeah we should just use the -D option in CMake instead of changing the code, that is what it's for.

@bjorne
I have verified now and cmake [...] -DSYSCONF_INSTALL_DIR=/config works when compiling and make install, i will revert my suggestion for hardcoding =)

tellstick.conf
In my attempts i have not got it to work with any other value for user in tellstick.conf than root.
Tried with various other users without success.
Without user = "root" in tellstick.conf the telldusd will not connect to the hardware. It will fail with error that tellstick device is not found when trying to communicate (ex. with tdtool)
If we should not change default tellstick.conf in the source you can use sed to replace nobody with root. Otherwise we need to dig in to identify the root cause (pun intended) why nobody is not working on alpine.

I've updated the build with the latest wisdom in https://github.com/bjorne/hassio-build/commit/4452b1f28e9c8a7c2524e324ae124392f84b53aa.
@endor-force hmm, according to my testing "nobody" is working fine:
bash-4.3# telldusd
telldusd: telldusd daemon starting up
bash-4.3# ps | grep telldus
   13 nobody     0:00 telldusd
   21 root       0:00 grep telldus
bash-4.3# tdtool --list-devices
type=device     id=1    name=Example device     lastsentcommand=OFF

@bjorne yes, daemon starts and listing works but when you wish to interact with hw you will probably see the error.
Try tdtool --on 1 to see results.

So what we do:

We build only the library inside home-assistant to run the python module for telldus
We create a add-on they run the daemon and other stuff (maybe we add a small webinterface for pearing later)
We expose the unix socket over tcp for home-assistant
We add a system that allow run things before we start home-assistant and map the unixsocket back to /tmp

https://github.com/home-assistant/home-assistant/pull/10315

Any comments? I create a python library that allow to run telldus server/clients in diferent system/zones

Great!
I guess this will not affect regular homeassistant users with tellstick on their host?
How can we proceed and assist in testing & verification?

I noticed there is a folder in /config called deps. Can we put libraries there or is that intended for other purposes?
Just thinking if we could generate libraries via an add-on instead of compiling in homeassistant dockerfile?

Added proof of concept of addon. Used different approach for compiling using telldus master branch and unix patch to prepare compilation on alpine.
I'm fairly new to git, but i hope i did this the right way by forking hassio-addons and creating a branch called telldus-core?
https://github.com/endor-force/hassio-addons/tree/telldus-core/telldus_core
To-do:

Config file will not be put in to /config directory when compiling via dockerfile since it is not yet mapped, most likely a simple check will have to be added in run.sh to create a default tellstick.conf file if /config/tellstick.conf does not exist
Secure communication with homeassistant and python script to the telldus daemon in the add-on

Yeah, I think we can use the options to config telldus on UI without need modify any config files on any places.
We can create a core add-on. I think I have time on sunday for a draft:

Copy the compile part from base into a add-on docker file
Run.sh need convert the options into /dev/telldus.conf / After that we start the daemon and use socat to expose the interface to network. Now we wait on telldusd daemon to make the add-on runable

That is great.
If you compile in an add-on you need to also apk add the libstdc++ .
I've worked out the config part within the compilation and using the cmake variables as described has proven successful. -DSYSCONF_INSTALL_DIR=/config -DBUILD_TDADMIN=false
telldus daemon reads the config file from /config.
Parsing config from ui would be cool but not necessary.
I have solved the config file with the the add-on as well, and it compiles and loads, but when run.sh is processed and telldus daemon started, the docker is stopped, any idea why or how to find out why?
I have some thoughts about the compile process, is the current approach with using a fork of 2.1.3 beta the best way forward?
Suggested alternatives for compiling on alpine.

wget the latest stable 2.1.2 tar.gz from telldus and apply patch file before compilation on alpine - this will be more static and will also only limit the source to a stable telldus-core.

git clone telldus beta source from their master branch and apply patch file (see example in the add-on test)?

keep current approach with bjornes fork of telldus source?

This addon is now using the same approach as in the homeassistant dockerfile to compile in order to align.
https://github.com/endor-force/hassio-addons/tree/telldus-core/telldus_core
I have considered it a base to build on for further adding socat.
It is verified it to run and communicate with tellstick hardware. I hope it helps?


Allow more control over caching

When I .pipe() a file into an Express response object, the Cache-Control header will be set to public, with no max-age part. Also, the Expires header is set for 2 months.
In some cases, this might be undesirable. An option to control this behavior would be much appreciated :)

Hi @oliversalzburg, I'll fix it.

Please download this module from GitHub and try the cache.
I have fixed it. I'm waiting for your feedback

@petersirka Thanks a lot for the quick change! However, what I had in mind was to be able to specify for how long the file should be cached.
We're using node-filestorage to serve user avatars. They are currently cached for a very long time in the browser cache. Some caching is definitely desired, but we would prefer to set a max-age of like 5 minutes. So that users will see updated avatars in a reasonable time.

@petersirka We've combined your fix with a changed approach on our side and it's working great now. If you would make an npm release for 1.4.0 that would be awesome.
Thanks for your work :)

Hi @oliversalzburg,
so can I publish the module into the NPM? Or do you need some change? If yes, can you create a pull request? Thanks

@petersirka Seems to work fine. We're currently deploying your latest changes to our development servers for final testing. But a release to NPM would be great for us :)

Great. I have publish it into the NPM.
Thanks.


error if empty response

Codecov Report
Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.39%. Comparing base (043f151) to head (e5c39d6).

Files with missing lines
Patch %
Lines

src/hooks/useBackendAPI.js
20.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   85.51%   85.39%   -0.12%
==========================================
  Files         121      121
  Lines        3707     3712       +5
  Branches      798      729      -69
==========================================
  Hits         3170     3170
- Misses        507      512       +5
  Partials       30       30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New namespaces won't be created

Problem
New namespaces won't be created.
It must be created, explicitly.
In the current implementation, even if we specify a new namespace (excluding "default"), that new one won't be created.
References
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#create-namespace-v1-core
/kind bug

What's client did you use? I can create the namespace at least by kubectl
sanposhiho@C02H82E7Q05P kube-scheduler-simulator % kubectl get namespace --server=http://<IP_ADDRESS>:3131
NAME              STATUS   AGE
default           Active   15s
kube-node-lease   Active   19s
kube-public       Active   19s
kube-system       Active   19s
sanposhiho@C02H82E7Q05P kube-scheduler-simulator % kubectl create -f ./my-namespace.yaml  --server=http://<IP_ADDRESS>:3131
namespace/mynamespace created
sanposhiho@C02H82E7Q05P kube-scheduler-simulator % kubectl get namespace --server=http://<IP_ADDRESS>:3131

NAME              STATUS   AGE
default           Active   103s
kube-node-lease   Active   107s
kube-public       Active   107s
kube-system       Active   107s
mynamespace       Active   7s

It must be created, explicitly.
In the current implementation, even if we specify a new namespace (excluding "default"), that new one won't be created.

Okay, maybe you misunderstood about namespace. It's not bug.
/close

namespace support is tracked on https://github.com/kubernetes-sigs/kube-scheduler-simulator/issues/84


Toasty.js not loading

I downloaded the zip and extracted the code to my code base and added it to the main.php
`
`
I even tried importing the toasty.css and toasty.js.
But I keep getting the same error in the console:
Uncaught TypeError: Cannot read property 'childNodes' of null
Any help is much appreciated.

i set the javascript refrenece toast.min.js at end of the html file it working well


please update dio 5.0.3

Use this package instead: https://pub.flutter-io.cn/packages/dio_intercept_to_curl

I'm updating the package now.

I juste released 1.0.0 which requires dio 5.1.1


@hramos reproducible with RN 0.56. Reopen?

          @hramos reproducible with RN 0.56. Reopen?

If need, i can create repo or expo snack, but all info is here.
@remicoges @windev92 @TiagoCoelhoB
First of all, this is not a bug or metro bundler problem.
Real cause is that Image.resolveAssetSource (react-native/blob/master/Libraries/Image/resolveAssetSource.js) in android release builds returns resource identifier instead of file path (see react-native/Libraries/Image/AssetSourceResolver.js:80).
So that any non-native rendering (like webview / html) can't use resolved identifier "as is".
But there is a "workaround": assets and resources are accessible using file:///android_asset and file:///android_res (info from official android docs).
So in my case it worked as:
// ./utils/getAndroidReleaseImageURI.ts
// require'd image returns resource identifier in uri on android
// see react-native/Libraries/Image/AssetSourceResolver.js:80
const androidDrawableResPath = `file:///android_res/drawable`;
const getAndroidReleaseImageURI = (sourceURI: string) => `${androidDrawableResPath}/${sourceURI}`;

// ./Component.tsx
...
import { Image, Platform } from 'react-native';
import getAndroidReleaseImageURI from './utils/getAndroidReleaseImageURI';

const isAndroidRelease = (Platform.OS ==='android' && !__DEV__);
...
render() {
  const image = Image.resolveAssetSource(require('./rn-required-image.png'));
  const uri = isAndroidRelease ? getAndroidReleaseImageURI(image.uri) : image.uri;
  return (
    <Webview
      html={`<html><body><img src="${uri}"></body></html>`}
    />
  );
}
...

It doesn't work with run-android in release mode (set from rn android developer config), but production build is ok.
As fast fix for run-android - for example, check if resolved uri not to be url to remote file or file with extension from drawableFileTypes (react-native/local-cli/bundle/assetPathUtils.js:38) before call to getAndroidReleaseImageURI
const drawableFileTypes = new Set([
  'gif',
  'jpeg',
  'jpg',
  'png',
  'svg',
  'webp',
  'xml',
]);

But, of course, it could be much better, if it will work "out-of-the-box".
@hramos
As i see, it need to be fixed inside AssetSourceResolver.defaultAsset (react-native/Libraries/Image/AssetSourceResolver.js:80) but not sure, if it affects somewhere else.
Originally posted by @ponomarevv in https://github.com/facebook/react-native/issues/18216#issuecomment-412569517
Since it doesn't work in run:android release mode, is there any way to test this on a windows machine without making a eas build ? Since I have only can make 30 per month I'd hate to have to make 2 different build with 1h30+ queue time just to see which one of the "android_asset"/"android_res" is working...
Since the originial issue is dated in 2018, has there been any new developement for this ? I feel like this is really complicating things for no reason at all...

@axelmy318 - I don't think anyone can follow a bump of a 5+ year old ticket like this to be honest. I'd just recommend you submit a pull request if you spend this effort and tracked down an issue, since its too difficult to follow otherwise.

@axelmy318 - I don't think anyone can follow a bump of a 5+ year old ticket like this to be honest. I'd just recommend you submit a pull request if you spend this effort and tracked down an issue, since its too difficult to follow otherwise.

I don't have a fix for it though...
I'm just asking if anyone has found a workaround since it's been 5 years but I'm beginning to be kinda hopeless.

Since the originial issue is dated in 2018, has there been any new developement for this ? I feel like this is really complicating things for no reason at all...

As @iBotPeaches mentioned, please open a new issue and describe what's the expected behavior vs the intended behavior. Things have changed drastically since 2018 and is really complicated to follow over such a old conversation.


renovate: Don't remove images/cilium/download-hubble.sh yet

This file got removed in main branch, but we still need to keep it updated in v1.13, v1.14, and v1.15 branches.
Fixes: 5aec7f58af0e ("Move cilium/hubble code to cilium/cilium repo")

/test


Simplify MAINTAINERS.md

Remove the components breakdown. This is a small group, we know who is
good at what, and trust each other to consider our own limitations when
reviewing code.
Signed-off-by: Steven Danna<EMAIL_ADDRESS>

@chef/chef-server-maintainers We should probably all vote on this change.

I've gotten confirmation in chat from most people on this list.


Barcode Generator: Extension Fails to Load Due to Missing Icons in manifest.json

Describe the bug
The Barcode Generator extension fails to load due to missing icons specified in the manifest.json file. The error message indicates that the file images/icon-48.png could not be loaded, which results in the entire manifest failing to load.
To Reproduce
Steps to reproduce the behavior:
Go to the directory ~\Open source\GGExtensions\Barcode Generator
Attempt to load the Barcode Generator extension in the browser
Observe the extension failing to load
See error message indicating the missing icon and manifest load failure
Expected behavior
The Barcode Generator extension should load successfully without any errors. All icons specified in the manifest.json file should be present and accessible.
Screenshots

Additional context
Add any other context about the problem here.
The error indicates that the icon file images/icon-48.png specified in the manifest.json is missing. Ensure all files referenced in the manifest are correctly placed in the specified paths.

@Sulagna-Dutta-Roy Check this bug reports too.


CI/CD

GitHub should require passing tests and 85% test coverage to allow a PR merge.

Test passing is now required. Coverage requirement is uncertain, but will maintain a rule requiring 85% for merges from PRs.


pip: error: metadata generation failed

pip install -r requirements.txt
Collecting sentencepiece==0.1.83
  Using cached sentencepiece-0.1.83.tar.gz (497 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/private/var/folders/ls/yts6ydf52dq0fwy1vxxt84dm0000gn/T/pip-install-0rdt6yfl/sentencepiece_db31cde2488b47c78dda9cb03d7fbcec/setup.py", line 29, in <module>
          with codecs.open(os.path.join('..', 'VERSION'), 'r', 'utf-8') as f:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "<frozen codecs>", line 918, in open
      FileNotFoundError: [Errno 2] No such file or directory: '../VERSION'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

idk why it resolved but installing the latest solved it
verified on M1, python=3.9.19


Write new documentation

[x] Outline what documentation needs to be written
[x] Write documentation

[x] Getting started
[x] Code blocks
[x] Text formatting
[x] Images & Media
[x] Layout
[x] Fragments

[x] Basics
[x] Animated lists
[x] List of Fragments
[x] End-Fragments
[x] Advanced Fragments (fragmentNext, fragmentThen)

[x] Slide options

[x] Backgrounds
[x] Auto-animate

[x] Themes
[x] Speaker View
[x] Local Reveal.js installation
[x] Inline HTML
[x] Print / PDF Export
[x] Misc
[x] Automation (if-statements, for loops)
[x] Gotchas

[ ] In the index of the tutorials, write a table with the used commands in each tutorial.
[ ] Clean up README

[ ] Remove old docs
[ ] Check links
[ ] Clean up roadmap

New features implemented:

fitImage: size an image such that it takes up the remaining space of a slide.
slideAutoAnimate: alias for slide(slideOptions(autoAnimate=true))
disableVerticalCentering: disables Reveal's vertical centering of all slides.
You can now use fadeIn in combination with other fragments!

Now all the tutorials are written. It's just some cleaning and summing up that's left.
And I have finally figured out how to get fadeIn in to behave as all the other fragments! :partying_face:
Now you can mix it with the others like you'd expect:
fragment(@[fadeIn, grows]):
  nbText: "Fade in and grow at the same time"

Previously, it would ignore the fadeIn and only grow. But now it works!


advanced trainer fails with mixed_precision error

I wonder if cog.yaml isn't up-to-date with changes in lora - or if this is a typo?
The most recent version of the advanced trainer model on replicate.com fails

i have the same problem from April, it seems like devs abandoned the repo?

Same problem here...


Empty row

File: engine/userguide/networking/default_network/configure-dns.md
There is empty row in the table with options, table is placed after sentence Four different options affect container domain name services.

This is a non-technical error in an older version of the docs.


how to add a new button

When I want to add a new button, what should I do.
I add the new button in file strings.properties
then got the bug
    assert(stringId in self.idToMessage), "Missing string id : " + stringId
AssertionError: Missing string id : autoLabelDetail

I locate the error in stringBundle.py, file :/strings is not same as resources/strings/strings.properties
What is :/strings read by QFile

已解决，
修改 resources/strings/strings.properties； 之后 执行 pyrcc5 resources.qrc  -o libs/resources.py 更新 resources 文件；才生效


[Android] Let onCreateInputConnection to be delivered to XWalkView

onCreateInputConnection is never called if override it on XWalkView
because the one get callbacked is the descendant ContentView object
which get the focus actually but not the XWalkView object which
users holding. This patch passes this callback to the parent view
step by step and finally reaches to the XWalkView
BUG=XWALK-3024

@axinging @fujunwei

LGTM.  check in logs is a little hard to read.

@halton @axinging updated

Updated the commit log

LGTM


Unable to download JSON metadata

Checklist

[x] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2019.06.27
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE

Oh no sorry the data i pasted and wrote disappeared after i checked other similar bugs. i think ill open another one .


Remove all warnings on buildbot

Those are mostly doxygen warnings, and modular interface warnings. Everyone can fix them.
For example:
http://buildbot.shogun-toolbox.org/builders/deb3 - modular_interfaces/builds/2478
or:
http://buildbot.shogun-toolbox.org/builders/deb1 - libshogun/builds/3195

@karlnapf I suppose this is still open then?

http://buildbot.shogun-toolbox.org/builders/deb1 - libshogun/builds/3480
Other jobs probably have their own warnings as well.


Farming tracker is partially localized

When the "show relative time" option is ticked off, the completion times for the farming plugin use a partially localized time string to display the date at which the plant will finish growing - which clashes a bit with the rest of the interface being english.
Example:
"Fossil Island Middle - Done montag at 2:00"
I don't know what the community's stance on localization is, but I prefer to use english whenever possible.

Duplicate #2268
This will be fixed in today's update


Zarf destroy panic

Environment
Device and OS: Arch Linux
App version: v0.35.0
Kubernetes distro being used: N/A
Other:
Steps to reproduce

Run zarf destroy --confirm against a cluster where Zarf is not installed.

Expected result
The command should either error or should exit immediatly.
Actual Result
Panics due to a nil pointer in the state.
Visual Proof (screenshots, videos, text, etc)
Severity/Priority
Low/Medium
Additional Context
N/A

The easy solution to this problem is to just to check if state is nil before the other state check. I do however think it is slightly weird to delete a k3s cluster blindly without any user input just because the scripts are located at a specific file location.
https://github.com/defenseunicorns/zarf/blob/7288cf2b6c40570d84128fd4ec6673a3277aedee/src/cmd/destroy.go#L42-L56


Integrate BLST

Following the work in https://github.com/chainsafe/blst-ts and https://github.com/chainsafe/bls integrate into lodestar

BLST already integrated in current master :tada:
https://github.com/ChainSafe/lodestar/blob/4ca5a760c928c1257172bb4bf1033de2f60e6f3d/packages/lodestar-cli/src/util/bls.ts#L3-L10

oh I thought we want to process a chain segment (check linear chain first) in this issue. Something like:

do not change lodestar-beacon-state-transition
lodestar side: new runMultipleStateTransition(..., jobs: IBlockJob[]). Consumers would be initial sync and regular sync.
Accumulate signatures and use bls.verifyMultiple() to verify signatures beforehand
Run fastStateTransition() directly or the old runStateTransition() for each job/blocks without signature verification

@ChainSafe/eth2-0  can someone confirm if we plan to do it, and we want to do this in this issue or another one?

Yes this will be implemented soon. The tracking issue is https://github.com/ChainSafe/lodestar/issues/1473 and this PR is the first step for that https://github.com/ChainSafe/lodestar/pull/1821
In terms of speeding up signature verification, it has 3 steps

Change herumi for BLST, x10 speed increase :heavy_check_mark:
Use batch verification x2 speed increase :hourglass:
Multi-thread x2-x8 speed increase :question:


[#341] [Fix] Run development server on correct IP address

Fixes
Fixes #341  by @0saurabh0
Description
Before the change, the development server ran on <IP_ADDRESS>:8005 instead of <IP_ADDRESS>:8005, as listed by the README.md. After a simple configuration change for docker-compose.yml, the problem seems to be fixed. (As visible from the screenshot.)
Tests
Since the fix was a simple change in the configuration file, the black/isort tests for Python are not necessary. Please note that I've still run all pre-commit hooks beforehand.
Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Have you tested it locally i.e. Is the development server working/running?

Have you tested it locally i.e. Is the development server working/running?

Yes, the dev server is working as expected.

Thank you for linking the post, I understand the issue now. Apologies for the misunderstanding. I'll make changes accordingly

This works on the correct IP. I'll have a look whether than logging message can be changed.


update rosys

197_c6d3cffb84e26ef9a28ff832939612c4fda7238c doesnt run forever but fails

Error was fixed in https://github.com/zauberzeug/rosys/pull/214 and implemented in https://github.com/zauberzeug/field_friend/pull/202


it should consider the reservedIP when subnet create ippool

it should consider the reservedIP when subnet assinged the ip in ippool

https://github.com/spidernet-io/spiderpool/pull/834


code refactorization

Ongoing work to refactor the functions and build a scikit-learn-like class

@giray98 I think this PR is ready for merging, once you approve!


[Codebase] Overhaul for logging and debugging

Is your feature request related to a problem? Please describe.
There's little to none information we can get from users from the debug files when trying to fix an issue. It always seemed like some issues are only occuring for some users and not for others.
Describe the solution you'd like
In code, put a Logging function to every { major/minor function, try-catch block, point of interest }. Then additionaly, add a button in settings, that opens (pseudo) console window (or something like that [Discussion]) that'd display all events that had occured within the App. (Obviously, the logging will be done in background) (Ultimately, if app crashes, export entire instance log to a file)
Why this?
Though, we already are logging exceptions, it's sometimes not enough to investigate an issue. Currently in debug.txt you can mainly see the information of loaded drives 💁♂ ... and in debug_fulltrust.txt it's pretty similar situation.
Describe alternatives you've considered
(Discuss)
Additional context
There are a lot of issues we're not able to solve because we don't get enough information on them. By having more precise instance logging I believe majority of these issues will be easier to solve.

@d2dyno1 We get additional info in AppCenter and for the most part, @gave92 was able to solve many crashes from looking at the reports there.


Clicking on a Workflow Action refreshes entire MyDSpace page

See https://jira.lyrasis.org/browse/DS-4311

Closing as this is a duplicate of #721


[Suggestion] Add more events to console

Please, add events to show in console like...
A Wild %POKEMON% appeared! Trying to capture... [CP %CP%]
Capturing...
Captured %POKEMON%, Pokeballs used %POKEBALLS%.
Captured %POKEMON%, Pokeballs used %POKEBALLS%, CP is too low, exchanging.
Yoy received %AMOUNT% %POKECANDY% of %POKEMON% and %STARTDUST% star dust.
%POKEMON% run away!
Searching pokemons nearby...
Found a pokestop. Trying to get the items.

Your bag is full!!!
The pokestop is disabled, skipping.
You level up!! Level %LEVEL%, exp to level up again %RESTEXP%.
You are running out of pokeballs!
Sorry for my bad english

Maybe also add periodical profile fetch and display current DUST, etc.

Most events are now implemented. Feel free to open a new issue with new suggestions!


how use BCE loss train single_label data?

I read cross entropy loss code,find BCE loss used for multitask cls. so model config set this is error .loss=dict(type='CrossEntropyLoss',use_sigmoid=True,loss_weight=1.0),
because pred dim isn't same as label dim.
If I want use BCE loss train bin cls task,how should I write model config for loss?
LooK forward your reply.thks.

I rewrite mmcls/mdoels/losses/cross_entropy_loss.py binary_cross_entropy functions
add two lines:
pred=pred.squeeze()
label=label.float()

and my mode config is :
# model settings
model = dict(
    type='ImageClassifier',
    backbone=dict(type='MobileNetV2', widen_factor=0.25),
    neck=dict(type='GlobalAveragePooling'),
    head=dict(
        type='LinearClsHead',
        num_classes=1,
        in_channels=1280,
        loss=dict(type='CrossEntropyLoss',use_sigmoid=True,loss_weight=1.0),
        topk=(1,),
        cal_acc=True))

It's ok?
any reply for me is so helpful!!!

Can you show us your output pred size and the label size?

pred size (batch,1)  label size(batch,1) @Ezra-Yu

I find through this method,train loss don't decline.
I want to know that mmclassification BCE loss whether used train Single label dichotomy?

can you solve this problem? I meet a same one


Container host ports show up as "<IP_ADDRESS>" in "ports" tab in container detail page and in edit container page.

Rancher Versions:v1.4.0-rc9
Steps to reproduce the problem:
Create a container on a host that has no "scheduler ips".
Container host ports show up as "<IP_ADDRESS>" in "ports" tab in container detail page and in edit container page.

Container has ports set as:
"ports": [
"<IP_ADDRESS>:9091:80/tcp"
],

Metadata returns <IP_ADDRESS> for host Ip:
wget http://rancher-metadata/latest/self/container/ports/0 returns <IP_ADDRESS>:3456:80/tcp
Not sure which one is being used in this case. Both may need to be addressed.

I believe this is expected. If you don't specified any host ip, by default docker and cni plugin will bind <IP_ADDRESS> to all its port binding, which means binding to all ip4 address.

@StrongMonkey , From users perspective, he needs to know the Ip he can use to access the exposed port which in this case is the host's ip on which the container is running.
Also metadata for the container's port , should expose only the hostIp for the ports. This is what I see return for the earlier versions of metadata. Only the latest version of metadata is having this issue of returning "<IP_ADDRESS>" instead of host Ip for container ports.

<IP_ADDRESS> is what it really is, so that's what should be returned. There are an unknown number of IPs that the container might be reachable by. In the UI we can link to the primary host IP so you can click it, but returning it from the API as if that is the actual bound address is just wrong.

@vincent99 I was thinking the UI could be something like:
<IP_ADDRESS>
(<IP_ADDRESS>)

or
<IP_ADDRESS> (<IP_ADDRESS>)

where that IP in parens is the host IP. What do you think?
I'm going to assign to you @vincent99

This will be addressed in 2.0 as we will show the public endpoints to the user (per @vincent99 ) so im going to close this


Bugfix race condition

There were a couple of issues that mdb had which are resolved by this
commit:

<CTRL+C> sends interrupt but sometimes the output breaks
starting mdb attach before mdb launch would slip into an infinite
loop
sometimes the launcher would get stuck in an infinite loop anyway
exiting mdb attach would print loads of exceptions

The main changes that fix this are:

_forward_all_debuggers_to_client making sure debuggers are
initialized before running asyncio.gather(*tasks)

previously you could enter infinite loop because self.debuggers was
an empty list so we would await no tasks and get stuck in infinite
loop.

async_connection.py catch asyncio.IncompleteReadError and return
None.
In exchange_server.py handle None return values

exit infinite loop in _forward_all_debuggers_to_client
exit infinite loop in client_loop to shutdown client safely

closed as this was superseded by #48


Add match_info property to request class

Add match_info property to request class

This is useful for what? o.O

Haha, it's useful for developing for extension/Plugin.
I think it's not harmful to merge in  :) . Other frameworks, like Flask, aiohttp, etc, are all exposing similar method/property.

Could you elaborate on how other framework do this?

Aiohttp: http://aiohttp.readthedocs.io/en/stable/web_reference.html#aiohttp.web.Request.match_info
Flask:
http://flask.pocoo.org/docs/0.12/api/#flask.Request.view_args


Category Microsoft Edge ID 10952, 10953

When executing, on Windows 11 22H2:
Invoke-HardeningKitty -Mode Audit -FileFindingList .\lists\finding_list_msft_security_baseline_windows_11_22h2_machine.csv
the two Edge settings are not found:
`[*] 1/29/2023 6:22:34 PM - Starting Category Microsoft Edge
[$] ID 10952, Configure Windows Defender SmartScreen, Result=, Recommended=1, Severity=Medium
[$] ID 10953, Prevent bypassing Microsoft Defender SmartScreen prompts for sites, Result=, Recommended=1, Severity=Medium`
the list points to the reg key:
HKLM:\Software\Policies\Microsoft\MicrosoftEdge\PhishingFilter,EnabledV9
I could only find this setting here (the second Defender setting is also found here):
SOFTWARE\Policies\Microsoft\Internet Explorer\PhishingFilter

According to the document MS Security Baseline Windows 11 v22H2.xlsx URL, the path ...Microsoft\MicrosoftEdge\PhishingFilter... is correct. However, the policy file MSFT-Win11-v22H2.PolicyRules only points to the Internet Explorer one. I don't have a Windows 11 installation around at the moment, could you please configure the policy via group policy and monitor with registry key is changed?

The settings are here:
Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\System
EnableSmartScreen
ShellSmartScreenLevel, which can be Block or Warn, Block would be the correct setting.
Don't get confused, the config about Explorer not Edge, I doubt this is any different from win10.

Here a output of the Microsoft documentation regarding those settings, which use different path for Explorer and Edge

These settings (rows 2482-2484) are covered in ID 10951 to 10954

Nope,
10952 and 10953 should match 2842 or 1043 (2 registry path entrys here) in your excel file.
*Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\System*
Keys:
EnableSmartScreen
ShellSmartScreenLevel
but in your list it matches 2483 and 2484:
`10952,"Microsoft Edge","Configure Windows Defender SmartScreen",Registry,,HKLM:\Software\Policies\Microsoft\MicrosoftEdge\PhishingFilter,EnabledV9,,,,,1,=,Medium
10953,"Microsoft Edge","Prevent bypassing Microsoft Defender SmartScreen prompts for sites",Registry,,HKLM:\Software\Policies\Microsoft\MicrosoftEdge\PhishingFilter,PreventOverride,,,,,1,=,Medium
`
That's why the settings are reported as "unset", all other Defender settings are ok and don't fail. File Explorer Defender settings are in system and not in any *Edge registry folder.

I don't get it:

ID 1043 matches ID's 10766 and 10767
ID 2482 matches ID's 10951 and 10954
ID 2483 matches ID 10952
ID 2484 matches ID 10953

Okay, the category Microsoft Edge of 10952 and 10953 is not as in the Excel list however the registry keys are matching

Ok, I missed the category before "Starting category Microsoft Edge", but they are still 10952 and 10953 empty and not used, even if add the Edge 107 Baseline, it is still: Result=

That is interesting, I had access to a Win 11 Enterprise machine and used gpedit.msc and monitored for registry changes. Both registry keys were created after configuring the settings:

Is there an error in the source file from Microsoft? I did not check those templates yet.

Enterprise feature ?

Let's Microsoft answer this question, the documentation or the policy files are different. I posted a comment: https://techcommunity.microsoft.com/t5/microsoft-security-baselines/windows-11-version-22h2-security-baseline/bc-p/3733816/highlight/true#M562
If Microsoft recommends configuring Windows Defender for Mircosoft Edge, then the settings must be set in the way of the HardeningKitty list. If not this is not a recommendation I'll remove the checks.
I did a check on Windows 11 Pro as well, if I use gpedit.msc then the registry keys are set. If I use the PowerShell script of Microsoft then it is not configured.


Add Sushi Masterchef LP token strategy

This PR adds a strategy that allows users with their LP tokens staked in Sushi's masterchef to vote in snapshot proposals.
Note: this has not been tested and I'm not entirely familiar with The Graph and its inner workings. Please review and confirm it works however possible.
If there are any changes that need to be made, let me know! Thank you!

Fixed! @bonustrack :smile:
It assumes theres only 1 pool in the masterchef contract, which should work for most situations. If someone ever needs better support ping me!


dds_message’ was not declared in this scope    DDS::ReturnCode_t status = cdr_ts.deserialize(buffer, length, &dds_message);

I am not able to compile the code
getting this error
dds_message’ was not declared in this scope
   DDS::ReturnCode_t status = cdr_ts.deserialize(buffer, length, &dds_message);

Also when compile the colcon build --packages-select cyclonedds --cmake-args -DBUILD_IDLC=NO
You have called ADD_LIBRARY for library ddsc without any source files. This typically indicates a problem with your CMakeLists.txt file

Hello! Could you provide more context on your current build? as well as the steps to recreate it?
For the second compilation error, I believe that is just a warning when compiling cyclonedds, and can be ignored.

Thank you for your response
I believe this might be helpful
$ source /opt/ros/eloquent/setup.bash
$ colcon build --packages-select cyclonedds --cmake-args -DBUILD_IDLC=NO
Starting >>> cyclonedds
[Processing: cyclonedds]
--- stderr: cyclonedds
You have called ADD_LIBRARY for library ddsc without any source files. This typically indicates a problem with your CMakeLists.txt file
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
---
Finished <<< cyclonedds [33.8s]

Summary: 1 package finished [35.2s]
  1 package had stderr output: cyclonedds
$ colcon build
Starting >>> cyclonedds
Starting >>> rmf_fleet_msgs
Starting >>> building_map_msgs
Starting >>> rmf_utils
--- stderr: cyclonedds
You have called ADD_LIBRARY for library ddsc without any source files.

---
Failed   <<< ddsc-core	[ Exited with code 1 ]
Aborted  <<< rmf_task_msgs
Aborted  <<< rmf_traffic
Aborted  <<< rmf_traffic_msgs

Summary: 11 packages finished [4min 52s]
  1 package failed: ddsc-core
  3 packages aborted: rmf_task_msgs rmf_traffic rmf_traffic_msgs
  4 packages had stderr output: cyclonedds ddsc-core free_fleet_client_ros1 rmf_traffic
  8 packages not processed

Hi,
Again same error
colcon build --packages-select cyclonedds --cmake-args -DBUILD_IDLC=NO
Starting >>> cyclonedds
[Processing: cyclonedds]
--- stderr: cyclonedds
You have called ADD_LIBRARY for library ddsc without any source files. This typically indicates a problem with your CMakeLists.txt file
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
---
Finished <<< cyclonedds [30.8s]

Summary: 1 package finished [31.0s]
  1 package had stderr output: cyclonedds

hello! thanks for providing the details, the previous errors are due to the documentation using a deprecated version of cyclonedds, I have just merged some fixes and new instructions. this time, there is no need to build cyclonedds on its own first, could you try them out?
The warnings are due to building cyclonedds using build tools like colcon or catkin which expects packages to be architectured in a certain way, they can be ignored. I have since added this into the FAQ, https://github.com/osrf/free_fleet/blob/master/docs/faq.md

Thank you for your support :100:


Incorporate errorcheck tool into our CI job (linter)

It might be useful to incorporate the following tool into our CI job:
https://github.com/kisielk/errcheck

Added via https://github.com/RedHatInsights/insights-operator-utils/commit/1f8f56028f7ed7e792672393ba65c20bc6b3a290#diff-f7b06eed0e76b727475878e33c9d9791


[Feature Request]: Save chat history to disk

Is there an existing issue for this?

[X] I have searched the existing issues and checked the recent builds/commits

What would your feature do ?
Save history (chats) to a file.
Proposed workflow

Pass program --history or --save flag and chat history gets saved to ~/.edgeGPT/chats/foobar.log

Additional information
Thanks for your effort to date...

In my opinion, if you using EdgeGPT like a api (call bing ai in your program), you do it in your program is better.
If you just using it in command line (like python -m EdgeGPT ...), save log may useful

I made a patch for this feature at https://github.com/yvay/EdgeGPT/commit/9f519cc5ae3273b139e16777d82a4a243ea517c7
It's a bit ugly but so far it seems to work for me. I will try to tidy it up and prepare a PR if that's okay. I would love to see this feature in EdgeGPT.


Configurable recipe execution timeout

Currently, the SetupController and the ExecuteRecipeAction set HttpContext.Server.ScriptTimeout to a hardcoded value of 600 seconds. In some scenarios it is desirable to change this value without changing the source code.
HostComponents.config could be used for this to configure a public property on said types. The default would set from both controllers to 600 seconds.

Just to add: before anybody suggests this idea being able to set this by the user (like from the recipe itself), that shouldn't be allowed since changing execution timeout is a security sensitive operation.

In your opinions, should we add an entry to HostComponents.config for both the SetupController and the ExecuteRecipeAction separately, or should we add some sort of shared class that provides the ExecutionTimeout Setting?

For some reason the property value won't be injected into the controller. That, and the fact that we need the same value for two classes makes me consider adding a ScriptTimeout property to IMachineNameProvider and rename that to IApplicationEnvironment (or IEnvironmentAccessor). Unless someone stops me with a better idea?

I created a PR here so we can discuss the details: https://github.com/OrchardCMS/Orchard/pull/5813

I'd suggest putting this in web.config - it's not something you often want to change - but (for example) we really need to currently. I'm about to raise another issue for the performance of recipes, but summary is 1500 items takes about 22mins on Azure VMs....

Correct me if I'm wrong, but hasn't this one already been merged into dev?

HostComponent.config


Turn on Github CI

As an interim measure until we work out our longer term CI strategy
this PR enables some basic CI tests using the Github CI capability.
You can take a look at a sample of what this looks like here:
https://github.com/mattcaswell/temptest/pull/5
I've just enabled a small number of builds. It is not yet clear to me what the throughput of this service is - and some builds took 1.5 hours to complete, so I don't want to overload things. The objective of this is to just try and get some CI testing back so that we can at least start committing things again.

Note also that some builds are expected to fail. There are some issues in master at the moment. I'm not seeking to resolve them as part of this PR.

+1

Given the lack of CI testing at the moment - are we ok with classifying this as urgent? Adding that label - sorry should have added it before. Please reconfirm with that label!

Urgent is a good idea.  My approval stands.

To be a bit of a pain, any word on issue #13152, since we can't do GitHub CI to that platform.

To be a bit of a pain, any word on issue #13152, since we can't do GitHub CI to that platform.

@levitte is working on a buildbot infrastructure which should help with that. This PR is more about dealing with the immediate lack of access to Travis.

Pushed. We'll need to try and figure out the fixes for the various failing items.


Unable to add multiple items to cart

add one item to cart
go back to list of items
add another item to cart
check cart content
Expected: 2 items should be in the cart
Actual: 1 item is in the cart

fixed by updating book to bookId


Can't retract facts.

Hi!
Thanks for making Tau Prolog! It's an awesome system! I'm prototyping a new action language with it over at https://flamingo-lang.org.
I'm having trouble using retract/1. For example, in this program: http://tau-prolog.org/sandbox/7sS9oHzN, I would expect the query foo. to return false, but it returns true.
When I try using retract or asserta  I get a permission error. E.g., the query:
asserta(bar(3)). bar(X).

produces the following answers:
X = 2;
uncaught exception: error(permission_error(modify, static_procedure, bar/1), /(asserta, 1))

What am I doing wrong?
Thanks!

Actually, I think I figured it out:
:-dynamic(bar/1).

It might be worth adding this to the documentation.

It's actually a (standards compliance) bug. Asserting a (previously unknown) predicate implicitly makes it dynamic. That said, declaring all dynamic predicates using the dynamic/1 directive is good practice.

The execution is as expected. You must explicitly declare dynamic predicates if you provide any clauses for them. Also, in your example, note that the only way to execute a goal from the program is through the initialization directive.
:- dynamic(bar/1).
:- initialization(retract(bar(_))).

bar(2).
foo(X) :- bar(X).

The initialization directive will be available from the next version v0.3.0 (in the current version of git it is already available).

@jariazavalverde is correct. I didn't look into the program. As he explained, if a file contains clauses for a dynamic predicate, it must also contain a dynamic/1 directive for the predicate as per the ISO Prolog standard. Also, your program is trying to redefine the rectract/1 built-in predicate.


6 set up drizzle orm

Deployment failed because of missing environment variables, resolving on Vercel and retrying.

Ofri is in India, so there's no point waiting for him to review this PR


Bones are not updating properly when changing hair or logging in with "Apply Profiles on Character Select Screen" enabled

ArmatureManager/Armature needs a rewrite

Fix is in testing as of <IP_ADDRESS>


feat: add turbo build support

This pr is to add turbo support, and then can run the pnpm lint, pnpm build or pnpm test in the root path of project.

Hey @eryue0220
Could you detail what issue this is solving? My understanding is that Turbopack is both a task running and a bundler. We already use Vite or Tsup for building various packages in this repo, I'm not sure what this change brings over pnpm -r build in the root of the pnpm workspace?

Hey @eryue0220
Could you detail what issue this is solving? My understanding is that Turbopack is both a task running and a bundler. We already use Vite or Tsup for building various packages in this repo, I'm not sure what this change brings over pnpm -r build in the root of the pnpm workspace?

Hi,
In some degree, turbo is similar with pnpm -r build, But if I’m not mistaken, pnpm only run the build command recursively in packages/ folder, and pnpm cannot correctly handle the deps each package in the workspace, which may result in errors when running pnpm -r build. And turbo can cover this case.

pnpm does actually build in topological order, and in parallel, so we can be sure that the lowest level dependancies are built first. It seems that this isn't documented though, but there is reference to it here: https://github.com/pnpm/pnpm/issues/7131
If we find a good reason, such as a significant build time speed up, or if we come across something that pnpm can't solve, I'm open to adding it, but for now I'm going to close this.


chore(deps): bump ocamlformat to 0.23.0

This reformats basically every file in the worktree, but there are no actual code changes.

No code changes, will merge


Running from non-root directory

I'm trying to have the Package.swift file that contains the danger-swift dependency be in a subdirectory of my project, but I'm running in to some issues with Danger/SwiftLint.
If I move my Package.swift, Dangerfile.swift, and node-related files in to a subdirectory called DevelopmentDependencies and run swift run danger-swift local --danger-js-path (yarn bin danger) --verbose within that directory SwiftLint never picks up any errors/warnings.
I am running SwiftLint in my Dangerfile via SwiftLint.lint(directory: "../"), but SwiftLint.lint() also does not work. When run via swift run swiftlint --path "../" I get the warnings I expect.
If I only move the Package.swift and run it from the root via swift run --package-path ./DevelopmentDependencies/ danger-swift local --danger-js-path (yarn bin danger) --verbose it yields an error:
Launching Danger Swift local (v2.0.6)
Running: /PROJECT_ROOT/node_modules/.bin/danger local --process danger-swift --passURLForDSL --verbose
events.js:187
      throw er; // Unhandled 'error' event
      ^

Error: spawn danger-swift ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:262:19)
    at onErrorNT (internal/child_process.js:464:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:268:12)
    at onErrorNT (internal/child_process.js:464:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn danger-swift',
  path: 'danger-swift',
  spawnargs: []
}

Is there a way to do this?

This is not possible at the moment in the way you are trying to do it I think.
But there are two alternatives:

You can keep the Dangerfile in another folder, but have Package.swift in your main folder, and run danger from the main folder with --dangerfile DevelopmentDependencies/Dangerfile.swift
Swiftlint would need to accept the files list as alternative to the directory in https://github.com/danger/swift/blob/master/Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L17
This is because directory just filters the modified and created files but the paths danger gets are always relative to your main repo (then they never start with ../).
Adding that option would allow you to pass the files manually and use .map { :../" + $0 }

I also think that what you have there could work if you put lintAll to true, because in that case it runs it in the directory you specified (..), but don't think is what you actually want

Using lintAllFiles is working, thanks! It's honouring the .swiftlint.yml in my root and subdirectories and showing linting errors/warnings.
It looks like danger is finding the files and passing them to SwiftLint? But this option has SwiftLint finding the files?
The goal was to move the Package.swift out of the main folder because it makes working on the framework within another project easier because Xcode will only download/build the dependencies in the root Package.swift, so when danger etc. are in the root it slows down package resolution in Xcode.

To give more context, this is what happens:

When you use lintAllFiles with directory danger calls Swiftlint directly and passes to it the directory you want to lint.
When you don't use it danger takes all the files that are modified or created on your PR, filters out the one that doesn't have in the path the directory you want, and passes them to Swiftlint.

Now given your path doesn't have ../ in the path (they are relative to the root of the project), everything will be filtered out.
You could use the directory path relative from your root, but in that case Swiftlint wouldn't find the files.
This is why my best suggestion, if you don't want to lint all the files, would be change Swiflint to accept also a list of files to lint then you can change the file paths as you prefer (like by adding ../ to every path and filtering out what you want).
Otherwise lint lintAllFiles should be ok

To give more context, this is what happens:
* When you use `lintAllFiles` with directory danger calls Swiftlint directly and passes to it the directory you want to lint.

* When you don't use it danger takes all the files that are modified or created on your PR, filters out the one that doesn't have in the path the directory you want, and passes them to Swiftlint.

Now given your path doesn't have ../ in the path (they are relative to the root of the project), everything will be filtered out.
You could use the directory path relative from your root, but in that case Swiftlint wouldn't find the files.
This is why my best suggestion, if you don't want to lint all the files, would be change Swiflint to accept also a list of files to lint then you can change the file paths as you prefer (like by adding ../ to every path and filtering out what you want).
Otherwise lint lintAllFiles should be ok

Thanks for the content, I see why it would be better (performance) to not use lintAllFiles, but it sounds like that's not currently possible.
I'm thinking that if Danger were to use full paths and expand the ../ then it could work? I'd be interested in trying to get this to work.
For my current projects using lintAllFiles is ok, so if you want to close this issues please go ahead.

I was running into this same issue recently while trying to move all of the Danger related files out of the root to keep things more organized and to avoid Xcode thinking my project was a SPM module because of the Package.swift at the root. I worked out the following solution as a workaround:
I'm running the following command from CI:
(cd scripts/swift/Danger/ && swift run danger-swift ci --dangerfile DangerFilePreChecks.swift --verbose --id PreChecks)
And I'm setting an ENV variable for the relative path to the .swiftlint.yml file:
`SWIFTLINT_CONFIG_FILE="../../../.swiftlint.yml"
And using that config location within my Dangerfile:
let configFile = ProcessInfo.processInfo.environment["SWIFTLINT_CONFIG_FILE"] ?? ".swiftlint.yml"
This allows me to move the danger related files (including the Package.swift) out of the root and into a separate folder.

@ecerney but the paths are still relative to your repo root folder, how did you solve that?
if you run cd scripts/swift/Danger/ && swift run danger-swift ci --dangerfile DangerFilePreChecks.swift --verbose --id PreChecks and let's suppose in your PR you modified File.swift (assuming you are not using lintAll with a directory path), it will try to lint scripts/swift/Danger/Files.swift no?

Hmm I see what you're saying, but it works for me without the lintAll option.
Lets use the following as an example structure:
scripts
swift
Danger
DangerFilePreChecks.swift
Sources
Files.swift
.swiftlint.yml
So I believe in specifying where the .yml file is, swiftlint then uses that as the relative root for files to lint. Perhaps danger-swiftlint gets the relative path from github like Sources/Files.swift and then adds an absolute path based on the absolute path of the .yml file?
cd scripts/swift/Danger/ && swift run danger-swift ci --dangerfile DangerFilePreChecks.swift --verbose --id PreChecks will make the current directory scripts/swift/Danger. In DangerFilePreChecks.swift, we pass the .yml path as FileManager.default.currentDirectoryPath + "/" + configFile aka Home/MyProject/scripts/swift/Danger/../../../.swiftlint.yml aka Home/MyProject/.swiftlint.yml. Then swiftlint uses that as the root at which to lint files.

For anyone new that experiences this issue, as you will find in the Repo's documentation. You can add the --pwd relative/path/to/working/directory
This is the simplest way to not add the "lintAllFiles" option.
if you have the Package.swift in a directory called for example "Danger" in the root, then the steps to run relative to the root would be

cd to where the package is located eg. Danger
run swift run danger-swift pr [URLOFThePR] --cwd ../

this will set in danger the current working directory to be the root of the project and not the directory you are running it from. SwiftLint works like a charm.

For anyone new that experiences this issue, as you will find in the Repo's documentation. You can add the --pwd relative/path/to/working/directory
This is the simplest way to not add the "lintAllFiles" option.

if you have the Package.swift in a directory called for example Danger in the root, then the steps to run relative to the root would be

cd to where the package is located eg. Danger
run swift run danger-swift pr [URLOFThePR] --cwd ../

this will set in danger the current working directory to be the root of the project and not the directory you are running it from. SwiftLint works like a charm.

Hey folks, it looks like this is a solved problem now? As mentioned above, there's --cwd to set working directory, and there's also --dangerfile to point danger-swift to its Dangerfile. Is there something missing to call it done?

Closing because the issue looks solved, if you still have issues with this feel free to re open it


PT-5117 Fixed test to be compatible with go modules

What does this PR do?
Since dependencies are handled with go modules - it is no longer required for package to be in the package name location.

:shipit:


Generalizing AlleleData into Dataset

Created Dataset module for providing different views of (alleles, peptides, affinities, sample_weights)
Responsibility for kmer encoding and conversion between IC50<->scores moved onto predictor

Modulo a couple of small comments, LGTM. I think this organization is a good improvement!

@timodonnell I'm done with the main refactoring but still have to move some scripts out of experiments into script and update them to work with Dataset.

Coverage decreased (-5.2%) to 66.182% when pulling a2e339d58cc2e7e0caf8c18bbd489981d89ab02a on dataset into a737a18dc91d187d8969df0279d50bab633f93ff on master.


Crashes and UI Glitches When Deleting a File Added to Git Repository

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.92.20
OS Version: Windows 10

Summary:
When I create a file in Visual Studio Code (VSCode), add it to the Git repository, and then manually delete it from the file system, VSCode crashes while trying to access the deleted file. Additionally, the code identifier (which shows how many times a function is referenced) exhibits UI flickering.
Steps to Reproduce:

Create a new C# file (e.g., MessageSystemSetting.cs) in VSCode.
Commit the changes to the Git repository.
Manually delete the file from the file system.
Attempt to view or open the deleted file in the Git panel of VSCode.

Expected Behavior:
VSCode should gracefully handle the situation where a file has been deleted from the file system and not crash or display error messages.
Actual Behavior:

Error messages appear stating "Server was requested to shut down." with error code -32000.
The Microsoft.CodeAnalysis.LanguageServer server crashes multiple times (five times within three minutes) and does not restart.
The code identifier displays UI flickering issues.

Screenshots / Logs:

[Error - 20:52:20] Document pull failed for text document file:///d%3A/Users/%E6%81%A9%E5%87%A1/Unity/Unity%20Program/RF-Memories%20from%20FurCafe/Assets/Main/UI/StorylineInterface/MessageSystem/MessageBox/Keycode/MessageSystemSetting.cs
  Message: Server was requested to shut down.
  Code: -32000
[object Object]
[Error - 20:52:20] Request textDocument/diagnostic failed.
  Message: Server was requested to shut down.
  Code: -32000
[object Object]
[Error - 20:52:20] Document pull failed for text document file:///d%3A/Users/%E6%81%A9%E5%87%A1/Unity/Unity%20Program/RF-Memories%20from%20FurCafe/Assets/Main/UI/StorylineInterface/MessageSystem/MessageBox/Keycode/MessageSystemSetting.cs
  Message: Server was requested to shut down.
  Code: -32000
[object Object]
[Error - 20:52:20] The Microsoft.CodeAnalysis.LanguageServer server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.

Thanks!
If my question is a repeat, I'm very sorry. ：}

Bro can you please the name of this theme?

Bro can you please tell me the name of this theme?

Default Dark Moderm
I use the font "荆南麦圆体"

Bro can you please tell me the name of this theme?

if you like i can provide you the font asset

There is no theme with this name "Default Dark Moderm"

There is no theme with this name "Default Dark Moderm"

There is no theme with this name "Default Dark Moderm"

Here is not the place to talk about the "theme" of vscode.
If you like, you can email me instead of here.
<EMAIL_ADDRESS>


Turtle Module

Is your feature request related to a problem? Please describe.
A bunch of small projects that helps to understand the implementation of turtle module.
Describe the solution you'd like
Making designs and beautiful patterns using turtle module, and at last making a final painting.

@anumshka let me know what else can be added to this folder: https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/master/Codes on Turtle Graphics

I would like to add the following:

A random walk generator
A beautiful pattern using regular polygons
A model of Hirst spot painting (https://www.damienhirst.com/texts1/series/spots)
Basic designs for beginners


NSForegroundColorAttributeName was renamed and won't compile in Swift 4 builds

When trying to build a project using Swift 4 / Xcode 9, encounter the following error:
[Path/To/Project]/Pods/StretchyHeaderView/StretchyHeaderView/Classes/UINavigationBar+Alpha.swift:63:37: 'NSForegroundColorAttributeName' has been renamed to 'NSAttributedStringKey.foregroundColor'
This causes the build to fail.
Current workaround is to unlock the file and use Xcode's 'fix-it', or manually change the value. Everything builds properly after that. Would be nice to have an official update that addresses this though :)

Thanks. I will upgrade to Swift 4 this week.

Upgrated to swift 4 https://github.com/sunlubo/StretchyHeaderView/pull/6


Build Assembly in CI even for Code Reviews

The 1.4.0-RC6 release failed https://teamcity.mesosphere.io/viewLog.html?buildId=543127&
This error would have been caught if we would have called sbt assembly in our CI.

See the test pipeline https://jenkins.mesosphere.com/service/jenkins/view/Marathon/job/marathon-pipelines/job/pipelines%252Fkarsten%252Frun-sbt-assembly/


fs.geturl() returns smb://username@host:None/path

I'd expect geturl() on a filesystem object to return either protocol://username:password@host[:port]/path or protocol://username@host[:port]/path, but geturl() in this case returns smb://username@host:None/path if no port was given explicitly, which seems to be wrong IMO.

Good catch, thanks. I'll release a patch.

Should be fixed in v1.0.4.


Test and CI refinement

No files were found with the provided path: /tmp/graphscope/. No artifacts will be uploaded.

[ ] The upload-artifact uploads nothing, please double check the logs location @lidongze0629

macOS-latest workflows will use macOS-11 soon. For more details, see https://github.com/actions/virtual-environments/issues/4060

[ ] Pre-check the compatibility of the dependencies of macOS-11, (low pri, @acezen )
[ ] unify the test scripts for local, use script/test.sh as local and minimum test in CI, as we discussed. @lidongze0629
[ ] clean up the files in .github/workflows, remove download-etcd.sh, install-minikube.sh, graphscope.Dockerfile @lidongze0629
[ ] use make command we defined in makefile to build. @lidongze0629
[ ] cache the rust built dependencies @siyuan0322
[ ] manager artifact. @lidongze0629

[ ] Unify k8s/graphscope.Dcokerfileand .github/workflow/graphscope.Dockerfile


pip installs binaries to location outside the PATH after upgrading to ubuntu-22.04

Description
Hello!
My team recently upgraded our self-hosted runner images from:
summerwind/actions-runner:v2.300.2-ubuntu-20.04 -> summerwind/actions-runner:v2.303.0-ubuntu-22.04

After making the upgrade, we noticed some of our jobs failing because binaries installed in those jobs were no longer on the PATH. Example error from a failing job: cookiecutter: No such file or directory
For this particular job, we were using pip to install a binary called cookiecutter like so: pip install cookiecutter
While the install step exited successfully, we are getting these warnings that indicate pip is installing to /home/runner/.local/bin, which is no longer on the PATH:
Example warnings from installing cookiecutter:
WARNING: The script slugify is installed in '/home/runner/.local/bin' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script normalizer is installed in '/home/runner/.local/bin' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script chardetect is installed in '/home/runner/.local/bin' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script cookiecutter is installed in '/home/runner/.local/bin' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

For now we are getting around this by modifying paths in the affected jobs, but we would rather know how we can patch this in our runner images. We have attempted adding layers to our runner image like ENV PATH="${PATH}:/home/runner/.local/bin" or by updating the PATH in /home/runner/.bashrc without success.
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Current runner version: '2.303.0'
Runner image: 'summerwind/actions-runner:v2.303.0-ubuntu-22.04'
We are using a custom image built FROM summerwind/actions-runner:v2.303.0-ubuntu-22.04. The bug surfaced after a change to the tag of that base image. No other layers in our custom image were modied.
We do not have public build to link to, unfortunately.
Is it regression?
summerwind/actions-runner:v2.300.2-ubuntu-20.04
Expected behavior
Package managers like pip install binaries that are executable without manipulating paths in the CI job directly. In this case either /home/runner/.local/bin is in the PATH loaded into the shell running our jobs or pip installs to a location that is on the PATH without additional configuration.
Actual behavior
/home/runner/.local/bin is not in the PATH. Jobs need to manually modify their PATH in order to execute binaries installed by package managers like pip.
Repro steps
Steps to reproduce are very simple:

In one step install the binary: pip install cookiecutter
In the next step, attempt to execute it: cookiecutter --help

Just heard from my colleague who tells me that pip was installing to /home/runner/.local/bin in the previous image we used, so we think it is the PATH that has changed.

Hi @erikkrieg!
Hmmm. I cannot reproduce the issue with our latest Ubuntu 22.04 runner. Are you sure that your workflow didn't change $PATH?
Example:
jobs:
  pip-test:
    runs-on: ubuntu-latest

    steps:
    - name: Check ENV
      run: echo $PATH
    - name: PIP install
      run: pip install cookiecutter
    - name: test run
      run: cookiecutter --help

Result:

So, please provide more info or I'll be forced to close the issue.

echo $PATH will result this for ubuntu-latest:
/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

echo $PATH will result this for ubuntu-latest:
/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

When we echo $PATH from the failing job we see: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

Our job looks like this (with some names obfuscated):
job-name:
    runs-on: [self-hosted, ci]
    steps:
    - uses: actions/checkout@v2
    - name: Install cookiecutter
      run: pip install cookiecutter
    - name: Do something with cookiecutter
      run: make use-cookiecutter

This job was not modified directly, the change was to the image running on our self-hosted "ci" runner.
This is the diff of the change the broke us:

@erikkrieg $PATH variable already correctly set in our images. Take a look here: https://github.com/actions/runner-images/blob/main/images/linux/scripts/installers/python.sh#:~:text=prependEtcEnvironmentPath '%24HOME/.local/bin'
I cannot be sure that your self-hosted runner assembled with using of all the scripts without any changes. At first glance, and at second glance, the problem lies precisely in how your runner is built, and not in our runners or scripts.
Please use the instructions for assembling a self-hosted runner: https://github.com/actions/runner-images/blob/main/docs/create-image-and-azure-resources.md

Thanks for taking a look and providing the links. I'll bring this back to my team. Seems like we are going to need to inspect the layers to understand where things are going awry.

Seems like I opened this issue in the wrong project. We think that the actions-runner-controller is where the issue could be originating from.


Uncaught abort(17). Build with -s ASSERTIONS=1 for more info.

I opened an MEI file.
I showed the notation view.

Atom: 1.35.1 x64
Electron: 2.0.18
OS: Mac OS X 10.14.3
Thrown From: mei-tools-atom package 0.2.0
Stack Trace
Uncaught abort(17). Build with -s ASSERTIONS=1 for more info.
At /Users/songsta/.atom/packages/mei-tools-atom/node_modules/verovio-dev/index.js:52

undefined

Commands
  9x -5:04.4.0 linter-ui-default:toggle-panel (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)
     -4:55.9.0 go-to-line:toggle (atom-text-editor.editor.is-focused)
     -4:54.3.0 core:cancel (input.hidden-input)
     -4:51.2.0 linter-ui-default:toggle-panel (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)
     -1:12.5.0 mei-tools-atom:toggle (input.hidden-input)

Non-Core Packages
busy-signal 2.0.1
intentions 1.1.5
language-mei 0.34.5
linter 2.3.0
linter-autocomplete-jing 0.8.4
linter-ui-default 1.7.1
mei-tools-atom 0.2.0

I assume the package is trying to render the data before it is loaded. Also it seems that it is using deprecated options. If somebody is still maintaining this project I can make a PR to fix these.

I'm fairly certain this can unofficially be considered unmaintained, but I'm pretty sure I have merge permissions (and that this issue should be considered my responsibility...) If it's an easy fix for you, by all means put in the PR and I can merge it!