Make sure ~ is expanded in NewServer; BroadcastReceiver uses temp path

Overview
[Describe what this pull request addresses.]
Fixes #
Pull request checklist

[ ] I have read the contributing guide.
[ ] I have agreed to the Contributor License Agreement.
[ ] I have updated the documentation.
[ ] I have resolved any merge conflicts.
[ ] I have included tests that cover my changes.
[ ] All new and existing tests pass.

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.

great!

Github doesn't let me merge this PR without @travisturner 's approval.


chore(config): include strict_front_matter_parsing in default config

Hi, noticed this setting is missing from the default config.
I'm not sure if you'd like to include all keys there by default. In case it's not necessary, this change can be discarded 🙂

Yep, this was the idea, I just forgot to add this one here. Thanks!


Fix parallel

Looks like the CLI upgrade broke some things, I'll see if I can check out the failure and fix tomorrow

Looking at it now :)

@pzuraq / @rwjblue we should be green!

No worries! Published in v2.0.2


HTML

HTML
##User Story
As a bootcamp student,
I want the Prework to be structured on a webpage
so that I can easily find and read information
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

CSS
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow

JavaScript
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

README
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser


Support node 10

v8::TryCatch has been removed in the v8 engine shipped with node 10 so node-pre-gyp fails in the compilation step. Not sure what the alternative is, but below is the line of code causing the issue. Seems like it would be a fairly simple fix (to someone more intimate with v8 than I am).
https://github.com/node-inspector/v8-profiler/blob/master/src/heap_profiler.cc#L16

change v8::TryCatch to Nan::TryCatch will be ok

Other errors will appear after applying @hyj1991's suggestion:
../src/heap_graph_node.cc:69:24: error: no matching function for call to ‘v8::Object::Has(int32_t&)’

@tlhunter
if (_cache->Has(_id)) {

change to
if (_cache->Has(Nan::New<Number>(_id))) {

:)


ASDF extension behavior appears to be sensitive to order of imports

cc @nden

Just to give some context to the issue:
The code on this branch attempts to implement serializing  of gwcs.WCS subclasses. When the test is run asdf raises a ValidationError. If the code is moved to the wcs schema and tag in asdf, the test passes. This makes me think asdf is not picking up the tag from gwcs. However, on current master (without the changes on this branch) asdf clearly picks up the tag from gwcs.
In addition, there may be a sensitivity to the order of imports but I need to double check that.

@drdavella I can't confirm that the order is important, so I changed the issue title to reflect what the original issue is.
Going through the AsdfFile.write_to code I can see now why the changes are picked up only if they are in asdf. custom_tree_to_tagged_tree calls _AsdfWriteTypeIndex.from_custom_type which fails to get type_from_cls and returns type_from_subclass.
So it appears the way I was trying to do it is not possible.

Hopefully a couple more hints - if I set handle_dynamic_subclasses=True in the gwcs.WCSType tag and specify its version in AsdfFile.write_to(tree, version='1.0.0') then asdf uses the gwcs tag with the subclass. handle_dynamic_subclasses is not documented AFAIK. The reason I need to set the version is that if not set then f = AsdfFile(); f.version  is used ('1.2.0') and this causes _AsdfWriteTypeIndex._type_by_subclasses to return asdf.tags.wcs.wcs.WCSType.

@nden thanks for the hints. I will dig further: my suspicion is that dynamic subclasses are not being handled properly for extension overrides (which is turning out to be a pretty annoying corner case). I do wonder if all of this would be resolved by #554, but I think we need to fix this either way.
There's documentation on handle_dynamic_subclasses here but I'm not sure how helpful it is.
Just to be clear, does your subclass have additional attributes that need to be serialized? In that case, I think this brings us back to #446 since there's not a great way to do this right now without writing another tag.


Data sources should be synchronous

Data sources should be synchronous per related changes to other terraform providers.

I assume this was fixed with https://github.com/pulumi/pulumi-terraform-template/pull/6?

Yes.


Extra call

I've noticed that getPosts function in post.controller.js executes twice. Presumably because of the server side rendering. I do believe that doubling workload is not what you normally want. Is there a way to avoid this?

Can you share how you able to see this executing twice?

@SOSANA just add console.log inside getPosts function. Log message will appear twice.

@SoundBot good catch! check this out, seems to be on initial load we get it called twice where as if we route from post back to main we only have expected results of executing once...

Yep. Any ideas how to fix this?

@SoundBot this is where the fun begins, also means our tests for this shouldn't of passed right?

The Action fetchPosts is disptached twice that's why getPosts is called twice. I will look into that.

In server/util/fetchData.js do console.log(needs) we will get Actions.fetchPosts two times. So the problem is in
  const needs = components.reduce((prev, current) => {
    return (current.need || [])
      .concat((current.WrappedComponent ? current.WrappedComponent.need : []) || [])
      .concat(prev);
  }, []);

Will fix!

@SoundBot
export function fetchComponentData(dispatch, components, params) {
  const needs = components.reduce((prev, current) => {
    console.log('test');
    return (current.need || [])
      .concat((current.WrappedComponent ? current.WrappedComponent.need !== current.need : []) || [])
      .concat(prev);
  }, []);
  console.log(needs);
  const promises = needs.map(need => dispatch(need(params)));
  return Promise.all(promises);
}

Fixed in #80

@SoundBot @mayankchd as per my last comment its called once from server, but fetch shows still fetching twice, this for client?


Cannot add .webp images to event descriptions

Describe the bug
Cannot add .webp images to event descriptions.
To Reproduce
Steps to reproduce the behavior:

Go to an event
Click on edit button in description section
Hit the add image button
Attempt to add  a .webp image
It appears to upload but then no image is displayed.

Expected behavior
I expect to be able to add any image file.

@Betree @jdaviescoates  I'm interested in working on this issue. Would it be possible to assign it to me? Thanks!

@Betree Here's the PR to resolve this issue in the API. I also added an additional note.


Empty prefix still adds a dash

https://github.com/algolia/autocomplete.js/blob/master/src/common/utils.js#L106
Adding a dash is hard-coded there. I have a special naming convention that I want to keep by not using a prefix, but when I set the prefix to an empty string it still adds the dash.

This would have to be implemented as a new feature. For example adding a "noPrefix" option to cssClasses could do it.
Taking PRs for this!

It doesn't have to be a new feature, looks more like a bug releasable with a patch version.
As a user of the API when I pass an empty string to the prefix configuration parameter I expect the trailing dash to be removed as well.

Hi @olanod, unfortunately since this bug has been there for such a long time, fixing it in a patch version MIGHT lead to a different behavior for some of our users. i.e. Without knowing it, some people might be relying on that bug.
We have no way to find out, that's why I would rather add a new option for now.

I think this is closed with #156


2/1/23 Team Meeting

Agenda:

Present progress reports.
Confirm all members have attended or watched the lecture from 1/12/23.
Brief on plan for demo during presentation in April.
Discuss sourcing of machines for demo during presentation in April.
Discuss importance of significant code development by end of semester and potential discussion with client regarding it.

Had day and month swapped, fixed to avoid confusion during audit


Browsersync doesn't seem to work on windows

Hello,
I try the browsersync extensions from current vscode and insider build too on different projects without success: it always throws Cannot get in chrome.
But if I load localhost:3001, then I get browser-sync config page.
I am running browsersync on windows 10 64bits.
It would be great to add browser-sync start only without opening the browser because I want to start from vscode-chrome-debug launcher.
Thank you in advance for your help.

Hi @Alphapage ,
Thanks for pointing out. Yes, I had noticed some hiccups with WIN machines. And also, I can try to add a config, not open the browser on start.
Cheers,
Jeremy

I found that folderPath starts with / : something like /c:\\.... I don't know if it is a vscode bug or the extension bug, but if I remove the / then all is working as expected.
Adding a config to customize the extension 👍

@Alphapage where can I edit the folderPath?  Thanks in advance!

@Alphapage @mspanish https://github.com/remicass/vscode-exts/pull/12 should resolve the issue. And I have added configuration for opening the browser on start or not.

Does not work for me.
Just downloaded & installed the latest version of the extension.
getting the same problem as reported on windows.

The same, vscode x64 win10 version 1.23.0

Hi guys,
Apologies in not publishing a patch. This has been fixed for windows now, please install version 1.1.1.
Thank you :)

still not working for me in windows 10, I receive the Cannot GET / when I try localhost:3000


Import of eye_zoom_mouse, eye_mouse was removed from mouse.py, but the references to them are still present in code and raise errors

The import of eye_zoom_mouse and eye_mouse was removed from mouse.py 4 days ago but the references to them are still present in code. It raises errors in the talon log. It also breaks mouse functionality, like continuous scrolling.

Oops, this was an embarrassing merge error on my part; I can fix this tomorrow if no one beats me to it

This has been addressed in #1095


Node version?

Hi @danigb!
First off, thanks for the very nice module.
I am thinking to use it in upcoming audiojs/audio version, and audio-loader is almost perfect. One thing though — is it possible to make it work in nodejs?
I see right now you take ac as a first argument everywhere, but we use audio-context singleton to make that argument optional. That is suitable in case of nodejs, where having context is not necessary.
Appreciate any response.

Hi @dfcreative,
I'm glad you like the module. I don't know how to make it works on nodejs since I've never try work with audio in that environment, but it sounds appealing! Can you explain a little bit how to do it? I would happy accept some pull request or we can see how to integrate with your library.
Thanks for the invitation too!
Regards,
Dani

I’ve added outline of how it may look here.
The points of difference:

For node we use request and for browser xhr (or fetch polyfill if there is such).
In node we don’t have audio context, and it should be made an optional argument. The common practice is passing (maybe) options with context.
For decoding we use audio-decode, in browser it automatically uses WebAudioAPI.

Feel free to take part in discussions, share ideas etc. Feel at home)

It looks good to me. I'll try to make it work on nodejs soon, so expect
some questions ;-)
El El sáb, 10 sept 2016 a las 22:03, Dima Yv<EMAIL_ADDRESS>escribió:

I’ve added outline of how it may look here
https://github.com/dfcreative/audio-load/blob/master/index.js.
The points of difference:

For node we use request and for browser xhr (or fetch polyfill
if there is such).
In node we don’t have audio context, and it should be made an
optional argument. The common practice is passing (maybe) options with
context.
For decoding we use audio-decode
https://github.com/audiojs/audio-decode, in browser it automatically
uses WebAudioAPI.

Feel free to take part in discussions
https://github.com/audiojs/contributing, share ideas etc. Feel at home)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danigb/audio-loader/issues/2#issuecomment-246134509,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAdIUTTIgj_2lnyegknKieuZQmshKIpks5qow0KgaJpZM4J5SCH
.

Hi @dfcreative,
I've been playing a little bit with your libraries and I think it will be easy to adapt audio-loader to nodejs environment. Unfortunately, I've made a little test of loading and playing audio and I couldn't hear anything (I don't know if it's a problem on my side or not). The code I used to test was:
var fs = require('fs')
var decodeAudio = require('audio-decode')
var play = require('audio-play')

var CLAVE = './example/samples/maeclave.wav'

function load (file) {
  return new Promise(function (done, reject) {
    fs.readFile(file, function (err, file) {
      err ? reject(err) : done(file)
    })
  })
}
function decode (data) {
  return new Promise(function (done, reject) {
    decodeAudio(data, function (err, buffer) {
      err ? reject(err) : done(buffer)
    })
  })
}

load(CLAVE).then(decode).then(function (buffer) {
  console.log('Loaded')
  play(buffer, {
    autoplay: true
  }, function () {
    console.log('Ended', arguments)
  })
}).catch(function (err) {
  console.log('Error', err)
})

The output in my machine (osx):
2016-09-12 03:12:41.675 node[8012:401831] 03:12:41.675 WARNING:  140: This application, or a library it uses, is using the deprecated Carbon Component Manager for hosting Audio Units. Support for this will be removed in a future release. Also, this makes the host incompatible with version 3 audio units. Please transition to the API's in AudioComponent.h.
Loaded
Ended {}
Ended { '0': true }

I've installed your audio-play library with: npm i --save github:audiojs/audio-play
Any ideas?
Anyway, It would be great to use audio in node. Thanks for your effort and libraries! They look really nice, let's do it 👍

That warning looks like a problem of node-speaker, we are going to transit to our own version of it.
You can actually check if it works in browser by budo test.js (budo instead of node). If there is sound - that means it will also work in node. You can install budo globally from npm.

I don't know what you mean... What can I check? Not the code I had write, of course, because of all the node calls... Or I am missing something? Is there any way I can play a buffer in node different from the one I've tried? Sorry for the confusion.

Ah, I see. That is the problem of the node-speaker package we use to output sound. It has large buffering and if your sample is less than ~2s it will just ignore the output. It’s a bug https://github.com/audiojs/audio-speaker/issues/21.
Try larger wav file and that should work.

Actually I resolved this, you can just update audiojs/audio-play and it should work.

Great! It works... 👍  I'll work on an adapted version of audio-loader and then we discuss the detais.

Hi @dfcreative
Here's the report of my progress (commit: https://github.com/danigb/audio-loader/commit/c14f61b9e510d49b95038933e6595a425ad80fa6)

The first thing is that, since make it work it on node means load a lot of extra modules (and module file size in browser matters) I've decided to add audiojs support in a separate file. So instead of require('audio-load') you must write require('audio-load/node'). But I'm open to suggestions.
I've created a examples/node.js file that runs a simple example (node examples/node.js)
It works when loading files from filesystem, but it fails when loading from http. Thats because audio-type module can't detect the audio file type. (The error is: [Error: Cannot detect audio format of buffer]). Maybe you can provide some light here
After playing the sample, it waits more than a second to finish. Thats something you should probably need to polish in audio-play module (and probably related to the small length of the samples I'm using)
Having an audio environment in node is great!!

Please tell me if you have any clue about the audio file type problem.
Regards,
Dani

Nice!

For that purpose there is browser field in package.json, so that the main package entry is node version, and usually /browser.js is for browser. Also js file named node.js messes up with node itself when I try to launch it in windows. Mb it is better to rename browser version to browser.js and keep index.js for node.

Pass encoding: null instead of encoding: undefined to sendRequest to receive binary data as a response, should work. That was my mistake in audio-load.

The 2s of silence is bad workaround in audio-play for now, otherwise that ignores output for short sounds. It should be fixed in some future, not sure how bad it is.

Thanks, looking forward to putting it to use in audio!

Hi,
I've made another commit. It seems to work with single audio files, multiple encoded json audio and soundfont files. Some things must be polished (like the point 1 of the previous comment) but the basic structure is done.
When running the example in my machine, I get a lot of warnings: [../deps/mpg123/src/output/coreaudio.c:81] warning: Didn't have any audio data in callback (buffer underflow). Maybe you want to take a look.
Regards,
Dani

Sweet, it works! I have no such errors, though I use windows platform.
I guess tests also should be able to be run in node, right?

I won't be able to work more on this today, but I forgot to comment one issue: as you can see in line 8 of node.js file, I had to patch audio-decode. The thing is that, in audio decode it uses Buffer.from(buffer) to convert from ArrayBuffer to Buffer, but this doesn't work if the audio is encoded, because it uses a Uint8Array. Any solution proposal is welcomed ;-)
I hope tomorrow I have time so I can fix tests and prepare a new release of the library (I'm still in doubt about the function signature changes, and some other minor issues)
Regards,
Dani

Not sure why Buffer.from(buffer) does not work for you, there is no difference between Buffer.from(array) and new Buffer(array) afaik, just tested that.
The function signature could be changed at least to avoid load(null, url), because it looks confusing in code.
The intuition is load(what, how), (in more generals sense do(what, how), or change(what, how)) but I see that you use context as a first argument across many packages, so that might be a trouble. Therefore possibly just check if first argument is not context, so that function can be both
load(context, url);
//and
load(url);
//which is the same as
load(null, url)

Here you have more information about the error: https://www.npmjs.com/package/typedarray-to-buffer
Maybe it's because my node it's too old (4.2). What versions of node are you planning to support?
I agree is weird to have an null as first parameter.

Ok, I’ve updated audio-decode, now it does not copy typed array.

Hi @dfcreative
I've made lot of changes, and is working... more or less. I'm having troubles in the following areas:

Even when the example is working on node, I can't make the test passing on that environment (currently are skipped)
When building the distribution file with browserify, it includes some (unnecessary) extra library (see dist/audio-loader.js)
The node example throws lot of warnings and sometimes it get stalled

I finally remove the AudioContext from the function signature ;-)
I think when that issues are solved, the work is done.
Regards,
Dani

Update: some node examples throws errors on my computer (OSX, Node 4):
/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/mp3/src/header.js:135
        throw new AV.UnderflowError(); // LOSTSYNC
        ^
Error
    at new UnderflowError (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/av/src/core/underflow.js:13:20)
    at MP3FrameHeader.decode (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/mp3/src/header.js:135:15)
    at Function.MP3FrameHeader.decode (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/mp3/src/header.js:237:16)
    at Class.readChunk (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/mp3/src/demuxer.js:139:41)
    at BufferSource.<anonymous> (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/av/src/demuxer.js:49:19)
    at BufferSource.EventEmitter.emit (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/av/src/core/events.js:64:12)
    at BufferSource.loop (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/av/src/sources/buffer.js:49:21)
    at Immediate._onImmediate (/Users/Dani/Code/Js16/audio-loader/node_modules/audio-decode/node_modules/av/src/sources/buffer.js:4:59)
    at processImmediate [as _immediateCallback] (timers.js:368:17)
```

Hi Dani!
That is awesome! I like the restructuring!
I’ve added some comments to your last commit.

In node use is-audio-buffer package instead of buffer instanceof Buffer. (The last never works btw).
It is better to avoid bundling in repo in this case, but I noticed that you use Buffer object in browser files — try removing any mention of it, because by itself Buffer module is ~40kb of code. That should help with the size. Also you can see the list of included packages as: browserify . --list
The errors of decoding are related to the short size of files. These are errors of decoders: aurora.js and wav-decoder. We should address them there. For now try to use larger files if possible.

I would also recommend adding 'use strict'; to the top of every file and setup eslint, but I can do a PR for that.
Also here you have base64 decoder, same as in audio-lena, we can think of merging that part of code one day.
All in all, great, looking forward to finishing!

Hi @dfcreative,
I'm glad you like it. Thanks a lot for the comments (from the source also). Here some thoughts:

Understood. Done.
Great, you found the root of the dependency problem. I know that is highly improbable that audio-loader is used without browserify or similar tool, but I like to bundle it mostly to test that I'm doin' it right (like detect unused dependencies, like this one)
Ok. I've made a commit where the test works with the the wav... but fails with mp3. Arggh.
Yes, I forgot. Done.
It sounds good to me.
Currently pass the audio context is not supported. Since the only method it needs from audio context is decodeAudioData you can pass the method alone. It's not documented because I'm not 100% sure if it's the right path.

When I try to run the test with an .mp3 file I get the following error:
at new UnderflowError (node_modules/audio-decode/node_modules/av/src/core/underflow.js:13:20)
      at MP3FrameHeader.decode (node_modules/audio-decode/node_modules/mp3/src/header.js:135:15)
      at Function.MP3FrameHeader.decode (node_modules/audio-decode/node_modules/mp3/src/header.js:237:16)
      at Class.readChunk (node_modules/audio-decode/node_modules/mp3/src/demuxer.js:139:41)
      at BufferSource.<anonymous> (node_modules/audio-decode/node_modules/av/src/demuxer.js:49:19)
      at BufferSource.EventEmitter.emit (node_modules/audio-decode/node_modules/av/src/core/events.js:64:12)
      at BufferSource.loop (node_modules/audio-decode/node_modules/av/src/sources/buffer.js:49:21)
      at Immediate._onImmediate (node_modules/audio-decode/node_modules/av/src/sources/buffer.js:4:59)

I think we are really close to a release 👍 Thanks for the idea and the support.

Bundling won’t save from unused dependencies, eslint for that purpose is way better, that also detects unused vars etc. You can use very loose config from audiojs.
With mp3 I have the same issue, I guess we need to try larger mp3.
As for restricting user passing own context there is a problem. Web-Audio-API supports only 6 context instances at the same time (depends on machine, here it is 999 there it is 1). So if user already used all of them, he won’t be able to use audio-loader. Passing decode function may work though, as far as it does not require sampleRate and other context params. Though that is a bit more difficult for the user than just passing newly created context - he has to remember the name context.decodeAudioData.
Anyways it’s up to you to decide, that is awesome we progressed so far.

Hi,
I've added a longer mp3 to test and it works. 👏
Your're right about the AudioContext, so I've updated the README to document about it.
I use standard style, and an in-editor standard-eslint plugin. But I'm open to suggestions (and PR)
For me the 0.6.0 release is ready. What do you think?

We can remove this wrapper (audio-decode does that already) and we’re ready for release I think :fireworks:

Before the release I've think I'll follow you advice and add context as another option 👍
Anything else before publish? 1, 2, 3...

Lgtm, there may be issues when I try to integrate into audio, but for now looks good.

Hi @dfcreative. I made a release, so I'll close this issue. Please open a new one with any issue you encounter. Nice to talk with you.


year zero in 360 day valid

The year zero special case is for gregorian calendar only

I'm thinking that this new rules logic should also be reflected in the "vectorised" rules function, convert_time_coords.
Background...
The "vectorised" functions are _convert_time_coords and _convert_vertical_coords,
which parallel the "normal" (scalar, i.e. single-field) functions _convert_scalar_time_coords and _convert_scalar_vertical_coords.
They are used only for the "fast structured fieldsfile loading", in iris.experimental.fieldsfile.
This insprired me to go looking for changes since the vectorised functions were split from the scalar ones.
I found that there have been a couple of changes to the scalar rules that did not get duplicated in the vector ones :

the (lbcode[-1] == 3) case : here
(for the vertical-coordinates) the (lbvc == 19) case : here

(I think that's all for now, but I could possibly have missed something).
Obviously we are a bit exposed to mistakes here, with the duplicated logic.
Apart from just fixing those, I think it would be desirable to combine the two routines somehow.
There are some problems with that however..

the exact logic that 'truly equivalent' vectorised functions would need to replicate includes the behaviour of merge in a 'normal', which is obviously non-trivial
@rhattersley pointed out that the vectorised version is currently intentionally different in some ways (i.e. fieldsfile structured loading needs to handle coordinates differently in some cases, at least for now)

(most notably the handling of realization coordinate, which structured load conveniently ignores at present)

I am looking into this, and will aim to make a proposal shortly...

@rhattersley pointed out that the vectorised version is currently intentionally different in some ways

I didn't mean to imply "intentionally" - it's more a case of "conveniently, in one specific use case(*)". I  wouldn't expect that single use case to prevent the scalar & vector conversions from being made consistent, but the use case is worth bearing in mind when deciding on what that consistent behaviour should be.
*) Data from an ensemble member with index N are written out with LBRSVD4 == N for all time steps except T+0, where they are written with LBRSVD4 == 0. The vectorised conversion ignores this value so multiple time points happily merge. The scalar conversion adds a realization coordinate for the non-zero time steps but does nothing at T+0, so they don't merge without manual meddling (e.g. using a load callback).

@rhattersley I wouldn't expect that single use case to prevent the scalar & vector conversions from being made consistent, but the use case is worth bearing in mind when deciding on what that consistent behaviour should be.

Understood.
I  think in any case we don't need to completely rationalise the scalar + vector behaviour.
The 'vector' usage is, for now at least, still a special case with it's own independent requirements, which does not need to be identical to 'ordinary' load in every case or respect.
The point at issue here is really the difficulty of maintenance, which can addressed simply by combining the logic into a single routine.
I think we can do that without any immediate functional impacts --  then, afterwards, we can discuss what further changes are desirable, to make the two usages more similar.

The point at issue here is really the difficulty of maintenance, which can addressed simply by combining the logic into a single routine.

:+1: for reducing the maintenance burden. Care will be needed to ensure unification doesn't significantly worsen performance.

this new rules logic should also be reflected in the "vectorised" rules function

Since #1959 merged this should now be easy, but needs a rebase.

👍 in principle. @pp-mo, do you want to take over on this PR?

@pelson in principle. pp-mo, do you want to take over on this PR?

Ok, probably worth linking with #2243 -- there are a bunch of outstanding issues and to-dos in this area.

Closing as this appears to have stalled.

@pp-mo wrote: Ok, probably worth linking with #2243 -- there are a bunch of outstanding issues and to-dos in this area.

May I strongly encourage small, easily mergeable PRs. This PR wasn't too far away - apart from addressing review comments, adding a simple test and a what's new entry, I'd have been happy to merge.


Add rating bar, favorite button, prices and social media buttons on a…

…uth page

@TarekAlabd  I try do all things you told me , I will wait your review and comments

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

How can I add you as Reviewer? I searched but I arrived to anything -_-

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

How can I add you as Reviewer? I searched but I arrived to anything -_-

If you open this page of a pull request from your laptop, you will find something like a navbar on the right.
It contains some components like Reviewers, Assignees, Labels, and so on.
It's an important thing to fill these data, click on reviewers and add me as a reviewer, and add you as an assignee, and so on.

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

How can I add you as Reviewer? I searched but I arrived to anything -_-

If you open this page of a pull request from your laptop, you will find something like a navbar on the right. It contains some components like Reviewers, Assignees, Labels, and so on. It's an important thing to fill these data, click on reviewers and add me as a reviewer, and add you as an assignee, and so on.

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

How can I add you as Reviewer? I searched but I arrived to anything -_-

If you open this page of a pull request from your laptop, you will find something like a navbar on the right. It contains some components like Reviewers, Assignees, Labels, and so on. It's an important thing to fill these data, click on reviewers and add me as a reviewer, and add you as an assignee, and so on.

https://drive.google.com/file/d/1j1prAApkq9xwtHToLl2EqgLJnFW3qx8f/view?usp=sharing.     I can't access any one of them

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

How can I add you as Reviewer? I searched but I arrived to anything -_-

If you open this page of a pull request from your laptop, you will find something like a navbar on the right. It contains some components like Reviewers, Assignees, Labels, and so on. It's an important thing to fill these data, click on reviewers and add me as a reviewer, and add you as an assignee, and so on.

@Azmaa22
Great work, Asmaa
Can you add me as a Reviewer in the pull request?

How can I add you as Reviewer? I searched but I arrived to anything -_-

If you open this page of a pull request from your laptop, you will find something like a navbar on the right. It contains some components like Reviewers, Assignees, Labels, and so on. It's an important thing to fill these data, click on reviewers and add me as a reviewer, and add you as an assignee, and so on.

https://drive.google.com/file/d/1j1prAApkq9xwtHToLl2EqgLJnFW3qx8f/view?usp=sharing. I can't access any one of them

Do I create a pull request other than this or is there a solution to this problem? @TarekAlabd


Add support for Filebeat 6

Adds a $major_version parameter so that Filebeat 6 can be installed.

Thanks! If you have time, can you update the README file to with a note about how to upgrade and add the major_version parameter too?
If you won't have time I'll merge this when I'll be at a computer long enough to add it (probably tomorrow morning eastern US time).
Thanks again!

Yeah, can do. I just realized I need to tweak some more things anyway

Oops, clicked the wrong button.

Hm, the Travis failure seems unrelated.

Yeah - I'll have to look at those particular tests a little later. I'll try to get this merged in the morning. Thanks again for adding support for v6.


Password Protect PPT

Hi all,
Is there a way to password protect a ppt generated by this PptxGenJS? Or Is there any other lib that would do it?

Sorry, password protection is not part of the OOXML spec, it's specific to Microsoft.
Source.


Array comparison functions (=, !=, >...etc) should use MethodHandles

these functions are currently building blocks and calling type.compareTo, instead they should get a method handle for the appropriate comparison function and use that

I believe this is a dup of https://github.com/facebook/presto/issues/2444


JetBrains: Telemetry: Pass params to autocomplete event logging

Our class in telemetry/Event.java has eventProperties and publicArgument, and currently, they are both always empty. We ought to use them to provide more info on what's happening. The VS Code code gives us some pointers on how to do it.
We didn't do this at the time of launch because we ran out of time, and didn't prioritize this because Cody Agent might just give us this for free.

We want to know:

How many completions do we have that we filter out
How long the inline hint is visible
Track rejections unless the inline hint wasn't visible for a long enough time

There is a single canonical event (could be called AutocompleteEvent) we want to track with three attributes:

llmLatencyMs: number – from last keystroke until we display the inline hint
hintVisibleDurationMs: number – from the time we displayed the inline hint until it's accepted or rejected
didAccept: boolean – accepted or rejected.

Tasks:

[ ] See the shape of the events that VS Code sends

How: the easiest way might be to start the VS Code extension in dev mode and see the events it logs.

[ ] Copy that structure for now

But internally, we can model the logging the way we described above
Ideally, we want to 100% match the structure, but if we roughly achieve it, it might be enough.

Goodie: In VS Code, we're using a bunch of hacks to achieve this logging because many things happen under the hood. We have more control, so it'll be much easier.

VS Code event analysis result:
In case of an accepted completion, these four items are logged:

CodyVSCodeExtension:completion:started {"multiline":true,"providerIdentifier":"anthropic","languageId":"typescript","type":"inline","multilineMode":"block"}
CodyVSCodeExtension:completion:networkRequestStarted {"multiline":true,"providerIdentifier":"anthropic","languageId":"typescript","type":"inline","multilineMode":"block","contextSummary":{"duration":6.322709083557129}}
CodyVSCodeExtension:completion:suggested {"multiline":true,"providerIdentifier":"anthropic","languageId":"typescript","type":"inline","multilineMode":"block","latency":1754.8648748397827,"displayDuration":5912.106917142868,"read":true,"otherCompletionProviderEnabled":false}
CodyVSCodeExtension:completion:accepted {"multiline":true,"providerIdentifier":"anthropic","languageId":"typescript","type":"inline","multilineMode":"block","lines":2,"otherCompletionProviderEnabled":false}

In case of a rejected completion, these three items are logged:

CodyVSCodeExtension:completion:started {"multiline":false,"providerIdentifier":"anthropic","languageId":"typescript","type":"inline","multilineMode":null}
CodyVSCodeExtension:completion:networkRequestStarted {"multiline":false,"providerIdentifier":"anthropic","languageId":"typescript","type":"inline","multilineMode":null,"contextSummary":{"duration":5.251167058944702}}
CodyVSCodeExtension:completion:suggested {"multiline":false,"providerIdentifier":"anthropic","languageId":"typescript","type":"inline","multilineMode":null,"latency":899.7096660137177,"displayDuration":6421.2282910346985,"read":true,"otherCompletionProviderEnabled":false}

Evaluation:

I don't think networkRequestStarted is needed.
We already log all three other events in JetBrains. But not the arguments.

We lack these arguments:
{
"multiline": boolean,
"providerIdentifier": string
"languageId": string,
"type": string,
"multilineMode": string,
"latency": number, // only for completion:suggested
"displayDuration": number, // only for completion:suggested
"read": boolean, // only for completion:suggested
"otherCompletionProviderEnabled": boolean, // only for completion:suggested
}

Of these, I think we only need "latency" and "displayDuration", and only for completion:suggested.

I don't think networkRequestStarted is needed.

Yeah I removed this already from VS Code too :)


Technical/compose and readme update

Changed:

README
pliki compose

Added:

workflow

I did some code cleaning and added usage of specific versions of git repos


chore(main): release 2.4.0

:robot: I have created a release beep boop
2.4.0 (2024-02-07)
Features

graphql: add indexPage (4243a28)
sitemap.xml: implement indexPage (de6d61f)

Bug Fixes

sitemap.xml.ts: add slug 404 check (7c0c099)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/crea-orkest/crea-public/releases/tag/v2.4.0 :sunflower:


Fix unintended autoplaylist shuffle.

After creating your pull request, tick these boxes if they are applicable to you.

[x] I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
[x] I have tested my changes on Python 3.5/3.6

Description
Autoplaylist seems to be converting to set, therefore messing up the initial order even if random autoplaylist is turned off.

Not sure why this was a set, thanks.


Improve alert styling

Improve alert styling

Removed (X), clicking anywhere on the alert closes it
Improved color, it's now a bit less flashy to the eye

yooo no way CI passed

We should use this instead
https://sonner.emilkowal.ski/

Closing in favour of #416


Cache-Setting 'NoCaching' not saved

Description of bug
It is not possible to turn Caching off (set Caching to 'NoCaching') in the Server-Settings of the PersonaBar (DNN GUI).
Steps to reproduce
List the precise steps to reproduce the bug:

Go to 'Settings > Server-Settings > Performance'
Click on 'Cache-Settings' dropdown
Select 'NoCache' and 'Save' settings
Reload page (or restart app to be sure) or check database: the setting is not stored. Value in database should be '0'. This only happens when selecting 'NoCache", all other options of the dropdown box are stored correctly.

Current behavior
When selecting 'NoCache' value is not set in the database. Changing setting to 'Light/Moderate/Heavy Caching' works fine.

SettingValue of SettingName 'PerformanceSetting' in Table HostSettings should be set to '0' (zero).
Screenshots
Screenshot of the dropdown attached.

Error information
Provide any error information (console errors, error logs, etc.) related to this bug.
Additional context
Provide any additional context that may be helpful in understanding and/or resolving the bug.
Affected version

[X] 09.09.00
[X] 09.09.01 latest supported release

Affected browser

[X] Chrome
[X] Firefox
[X] Microsoft Edge Chromium

I just tested on DNN 9.9.0 (new install) and can confirm this bug.

Yeah, been like this a while, I just tried it on a local 9.03.02 site.

I intend to work on this ticket and I can submit pull request in a day.


Support frame-ancestors directive

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors

The HTTP Content-Security-Policy (CSP) frame-ancestors directive specifies valid parents that may embed a page using , , , , or .

Hello @ivy-rew. FYI we've just forked this repository in order to build upon the work that was already done.
Our goal is to add full support for CSP Level 3: https://github.com/NationalBankBelgium/ContentSecurityPolicyFilter

I'm not investing any further on this filter, since we're setting headers like these on an NGINX revers proxy nowadays.
However, if anyone is trying to build the commit; I've just resurrected it here : https://github.com/ivy-rew/ContentSecurityPolicyFilter/commits/master/


Pyspark java.io.IOException: Reached end of input stream

Hi! When using pyspark to read and save query with limit 1 million rows everything working fine. However when I try to set the limit up to 10 million rows, for example, got this error on the same query:
Caused by: java.io.IOException: Reached end of input stream after reading 17 of 40 bytes
my code:
spark_config = (
    SparkConf()
    .setMaster('local')
    .setAppName('test')
    .set('spark.sql.execution.arrow.pyspark.enabled', 'true')
    .set('spark.sql.sources.partitionOverwriteMode', 'dynamic')
    .set('spark.sql.shuffle.partitions', 4)
    .set('spark.default.parallelism', 4)
    .set('spark.jars', 'clickhouse-jdbc-0.3.2-patch10-all.jar')
    .set('spark.driver.memory', '8g')
    .set('spark.executor.memory', '8g')
    .set('spark.executor.cores', 2)
    .set('spark.dynamicAllocation.maxExecutors', 4)
    .set('spark.dynamicAllocation.minExecutors', 2)
    .set('spark.kryoserializer.buffer.max', '512')
)
spark = (
    SparkSession
    .builder
    .config(conf=spark_config)
    .enableHiveSupport()
    .getOrCreate()
)

sp_test = (
    spark
    .read
    .format('jdbc')
    .option('url', 'jdbc:clickhouse://ch_addr:8123/db?ssl=true&custom_http_params=max_rows_to_read%3D100000000')
    .option('query', query)
    .option('user', connection_params['login'])
    .option('password', connection_params['password'])
    .option('driver', 'com.clickhouse.jdbc.ClickHouseDriver')
    .option('numPartitions', 1)
    .option('fetchsize', 100_000)
    .load()
)

sp_test.write.mode('overwrite').parquet("hdfs:///folder/test_data.parquet")

SQL query on one table without any joins and group or order statements.
clickhouse-jdbc-0.3.2-patch10-all.jar
pyspark 3.0.0
clickhouse <IP_ADDRESS>
Probably the #893 is somehow connected.
Below attached a part of detailed log:
22/07/01 09:12:12 DEBUG ParquetFileWriter: 146205191: footer length = 5575
22/07/01 09:12:12 DEBUG BytesUtils: write le int: 5575 => 199 21 0 0
22/07/01 09:12:12 DEBUG DataStreamer: Queued packet seqno: 2269 offsetInBlock: 11935232 lastPacketInBlock: false lastByteOffsetInBlock: 11987471, blk_2118512093_1045620111
22/07/01 09:12:12 DEBUG DataStreamer: Queued packet seqno: 2270 offsetInBlock: 11987471 lastPacketInBlock: true lastByteOffsetInBlock: 11987471, blk_2118512093_1045620111
22/07/01 09:12:12 DEBUG DataStreamer: stage=DATA_STREAMING, blk_2118512093_1045620111
22/07/01 09:12:12 DEBUG DataStreamer: blk_2118512093_1045620111 waiting for ack for: 2270
22/07/01 09:12:12 DEBUG DataStreamer: blk_2118512093_1045620111 sending packet seqno: 2269 offsetInBlock: 11935232 lastPacketInBlock: false lastByteOffsetInBlock: 11987471
22/07/01 09:12:12 DEBUG DataStreamer: stage=DATA_STREAMING, blk_2118512093_1045620111
22/07/01 09:12:12 DEBUG DataStreamer: DFSClient seqno: 2269 reply: SUCCESS reply: SUCCESS reply: SUCCESS downstreamAckTimeNanos: 464050 flag: 0 flag: 0 flag: 0
22/07/01 09:12:12 DEBUG DataStreamer: blk_2118512093_1045620111 sending packet seqno: 2270 offsetInBlock: 11987471 lastPacketInBlock: true lastByteOffsetInBlock: 11987471
22/07/01 09:12:12 DEBUG DataStreamer: DFSClient seqno: 2270 reply: SUCCESS reply: SUCCESS reply: SUCCESS downstreamAckTimeNanos: 5467820 flag: 0 flag: 0 flag: 0
22/07/01 09:12:12 DEBUG DataStreamer: Closing old block BP-176122593-[ADDRESS]-1631109548934:blk_2118512093_1045620111
22/07/01 09:12:12 DEBUG Client: IPC Client (62343880) connection to [ADDRESS]:8020 from user sending #41 org.apache.hadoop.hdfs.protocol.ClientProtocol.complete
22/07/01 09:12:12 DEBUG Client: IPC Client (62343880) connection to [ADDRESS]:8020 from user got value #41
22/07/01 09:12:12 DEBUG ProtobufRpcEngine: Call: complete took 3ms
22/07/01 09:12:12 DEBUG Client: IPC Client (62343880) connection to [ADDRESS]:8020 from user sending #42 org.apache.hadoop.hdfs.protocol.ClientProtocol.delete
22/07/01 09:12:12 DEBUG Client: IPC Client (62343880) connection to [ADDRESS]:8020 from user got value #42
22/07/01 09:12:12 DEBUG ProtobufRpcEngine: Call: delete took 3ms
22/07/01 09:12:12 ERROR FileFormatWriter: Job job_20220701091101_0001 aborted.
22/07/01 09:12:12 INFO JDBCRDD: closed connection
22/07/01 09:12:12 ERROR Executor: Exception in task 0.0 in stage 1.0 (TID 1)
org.apache.spark.SparkException: Task failed while writing rows.
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:291)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$write$15(FileFormatWriter.scala:205)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:127)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:444)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1377)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:447)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.sql.SQLException: java.io.IOException: Reached end of input stream after reading 17 of 40 bytes
	at com.clickhouse.jdbc.SqlExceptionUtils.handle(SqlExceptionUtils.java:77)
	at com.clickhouse.jdbc.ClickHouseResultSet.next(ClickHouseResultSet.java:716)
	at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anon$1.getNext(JdbcUtils.scala:357)
	at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anon$1.getNext(JdbcUtils.scala:343)
	at org.apache.spark.util.NextIterator.hasNext(NextIterator.scala:73)
	at org.apache.spark.InterruptibleIterator.hasNext(InterruptibleIterator.scala:37)
	at org.apache.spark.util.CompletionIterator.hasNext(CompletionIterator.scala:31)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
	at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
	at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:729)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$executeTask$1(FileFormatWriter.scala:272)
	at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1411)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:281)
	... 9 more
Caused by: java.io.IOException: Reached end of input stream after reading 17 of 40 bytes
	at com.clickhouse.client.stream.AbstractByteArrayInputStream.readBytes(AbstractByteArrayInputStream.java:241)
	at com.clickhouse.client.data.ClickHouseRowBinaryProcessor$MappedFunctions.lambda$buildMappingsForDataTypes$64(ClickHouseRowBinaryProcessor.java:336)
	at com.clickhouse.client.data.ClickHouseRowBinaryProcessor$MappedFunctions.deserialize(ClickHouseRowBinaryProcessor.java:466)
	at com.clickhouse.client.data.ClickHouseRowBinaryProcessor.readAndFill(ClickHouseRowBinaryProcessor.java:509)
	at com.clickhouse.client.ClickHouseDataProcessor.nextRecord(ClickHouseDataProcessor.java:143)
	at com.clickhouse.client.ClickHouseDataProcessor.access$100(ClickHouseDataProcessor.java:21)
	at com.clickhouse.client.ClickHouseDataProcessor$RecordsIterator.next(ClickHouseDataProcessor.java:36)
	at com.clickhouse.client.ClickHouseDataProcessor$RecordsIterator.next(ClickHouseDataProcessor.java:22)
	at com.clickhouse.jdbc.ClickHouseResultSet.next(ClickHouseResultSet.java:714)
	... 20 more

Also tried couple older version of jdbc driver with the same result.
I would be grateful for any ideas.

Hi @1pyxa1, I'm not sure what exactly happened but it looks like server closed the stream somehow. Is there any error on server? You may check either log file or system.query_log table.

Hi,
sorry for late reply. indeed there was the error in system.query_log.
Code: 160. DB::Exception: Query is executing too slow: 52535.46312494424 rows/sec., minimum: 1000000: While executing MergeTreeThread. (TOO_SLOW) (version <IP_ADDRESS> (official build))

after I pass min_execution_speed setting got again
Caused by: java.io.IOException: Reached end of input stream after reading 17 of 40 bytes

in pyspark application and the 'real' cause in system.query_log:
Code: 160. DB::Exception: Estimated query execution time (2069.1041993063686 seconds) is too long. Maximum: 2000. Estimated rows to process: 62228407: While executing MergeTreeThread. (TOO_SLOW) (version <IP_ADDRESS> (official build))

is there any chance to pass this exceptions to application? it would be much convenient for debug.

Hi @1pyxa1, I'm not sure what exactly happened but it looks like server closed the stream somehow. Is there any error on server? You may check either log file or system.query_log table.
Update: it seems you're connecting to ClickHouse server directly according to above code, but can you also double check if there any proxy sits inbetween?

remove  proxy is ok, thank you !


Linking to a complete sample for Web App calling Web API

The existing link takes you to a page with a lot of good reference material, but it's a horrible tutorial (e.g. there is no start or end state and there is very little how-to involved). Instead, I'm proposing to change the link to the very well documented, complete, and working tutorial for Microsoft Graph ("Build ASP.NET MVC apps with Microsoft Graph"). This also helps users in the community start working with the Graph as their sample API.

@bspender : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bspender : I've gone ahead and made the modifications. Please check, and I believe we can close this PR. Thanks again for the feedback!

@PRMerger10 : this PR was processed

https://github.com/MicrosoftDocs/azure-docs/pull/37529 got merged and it superceded this one.
#please-close


Very low values in weights array leads to RuntimeError: Unknown exception

Entropy calculation reports 'Unknown exception' with small weights.
details: dihedrals.dihedralEntropy() reports error with weights around 1e-30, multiplying the values by 1e3 solve the issue. (Multiplying by anything lower doesn't work. X-Entropy installation followed the standard procedure with conda.)
Error message
RuntimeError                              Traceback (most recent call last)
<'ipython-input-79-f0c02d38a1ab> in <'module>
2 dih_ent = dihedrals.dihedralEntropy(data=torsions,
3  weights=pop_norm.values, verbose=True)
----> 4 dih_ent.calculate()
~/.conda/envs/p3/lib/python3.8/site-packages/xentropy/dihedrals.py in calculate(self, resolution, method, verbose, id_gas)
118
119             # integral = kernel.integrate(start, end, method=self.method)
--> 120             p_logp = kernel.calculate_entropy(-PI, PI, method=self.method)
121
122             entropy = - p_logp * id_gas
xentropy/kde_kernel/kde_kernel.pyx in xentropy.kde_kernel._kde_kernel.calculate_entropy()
RuntimeError: Unknown exception

the lowest value for individual weight goes to 1e-70

This is related to the dihehedralEntropy module.
However, I believe that this might lead to issue for the kde module as well. There we might have a general problem with the weighted kde anyways, though #56 .
@jokr91 I can easily set very low weights to zero in the python frontend (then I would give a warning, that we do this manipulation to the input values)
Anyways, is it possible to trace way this exception is unknown?

Actually, I think the problem may lie elsewhere, because the values do not really need to be very small even.
However, the problem might be connected to the normalization of the weights (#56 )

I suggest to pull  #60 first as soon as it is accepted.


Update goals.js

fix GoalBreakBlock

Is end is indeed broken. I can merge when ready.

let's not make a breaking change for such a minor reason


nixosTest: allow tests to customize partition layout

I would like to write integration tests with nixosTest that use different partition layouts in test VMs than the standard ext4-on-disk. My main motivation for that is being able to test systems with an ephemeral rootfs (AKA "erase your darlings"-type systems) with a filesystem/partition layout that's faithful to production.
The filesystem mounted at /nix would remain un-overridable since it's imperative to the way nixosTest works (afaict). But the filesystem setup script in the initrd could be overridden. I've hacked up a quick patch for this at https://github.com/T0astBread/nixpkgs/commit/c53891fa6594f653e2fc4e097c4c1f8e8244d88d, if that sounds approximately good to you I can open a proper PR.

This should also work for the build-vm command though I haven't tested that.

ephemeral rootfs

Awesome.

un-overridable since it's imperative to the way nixosTest works (afaict).

There's virtualisation.useNixStoreImage, which puts the relevant store paths in a disk image instead. I wouldn't recommend putting disk images in the store like that, but that's another option. Perhaps we could add an alternative to this. Variations on this could run the activation script as well, or build the image at the last minute, although both of those will be slower.

I've hacked up a quick patch

I don't think we can change the default to one that disappears when user modules set it at the default priority.
It would break configurations like those in the bees, ec2, glusterfs and other tests.
To discard the default in your own configuration, you could use lib.mkForce instead.
Another small thing is to switch from nixosTest to the glue that the other tests use.
Feel free to open that PR.

Apologies for being a bit slow with the PR. I just accidentally destroyed my filesystem (unrelated to this issue) so I'm currently busy restoring things from backups. 😓
About using mkForce: mkVMOverride (which is used in qemu-vm.nix) has a higher priority than mkForce. Does that mean we should change the priority of mkVMOverride to give mkForce precedence? Or are you suggesting we use something else instead of mkVMOverride for the bootloader and filesystem options required here?

Apologies for being a bit slow

Don't worry. Everyone contributes at their own pace.

About using mkForce: mkVMOverride (which is used in qemu-vm.nix) has a higher priority than mkForce.

Ohh. I made a mistake. I thought they were the other way around. Changing them is a rather breaking change.
I think we've reached the point where nixosTest and nixos-rebuild build-vm have different requirements. A more sustainable solution I think is to refactor the module, to split it up into distinct modules with their own purposes and a common module. Probably most of it can be in the common module.
One trick we might use is a mkVMOverride-like function with a new name, that is not in lib, but in an internal option, so that we can make it behave the right way for each of the use cases. I'd like to avoid that if possible though.

right?

NixOS is rather vulnerable to spacebar heating. We can't be sure, but it seems so.

Could we perhaps check if the user has explicitly set virtualisation.fileSystems."/" (or /boot, /nix, etc.) and then use that value instead?

Not really feasible. We only get to access the final value.
Maybe we need to add a flag that can disable the default definitions. Explicit and minimal magic.

And it also shouldn't cause problems with production configurations since those use fileSystems instead.

Seems so. Also in case of build-vms, users should be specifying their vm-only options in vmVariant anyway, and nixosTest configs are never production.

Cool, so does the following look like a plan to you:

Add an option called virtualisation.useDefaultFilesystems (default true)
If true, everything stays the way it is right now
Else, we omit the definition of the root filesystem and initrd options for formatting the disk with ext4

I guess the root filesystem is the only one we need to omit. Looks like everything else can already be changed in some other way.

Then users can just set virtualisation.useDefaultFilesystems = false; and define their own in virtualisation.fileSystems + initrd for setup.

sgtm


Error Moor on Profile mode but not in Debug mode

Hello,
I'm having an issue with a stream from my database. everything work fine in debug mode but in profile mode or release mode I get this error:
"SqliteException(1555): UNIQUE constraint failed: bookmark_table.id, constraint failed (code 1555)" E/flutter (17463): #0      PreparedStatement.execute (package:moor_ffi/src/impl/prepared_statement.dart:107) E/flutter (17463): #1      _VmDelegate._runWithArgs (package:moor_ffi/src/vm_database.dart:72) E/flutter (17463): #2      _VmDelegate.runInsert (package:moor_ffi/src/vm_database.dart:84) E/flutter (17463): #3      _ExecutorWithQueryDelegate.runInsert.<anonymous closure> (package:moor/src/runtime/executor/helpers/engines.dart:69) E/flutter (17463): #4      BasicLock.synchronized (package:synchronized/src/basic_lock.dart:32) E/flutter (17463): #5      _ExecutorWithQueryDelegate._synchronized (package:moor/src/runtime/executor/helpers/engines.dart:22) E/flutter (17463): #6      _ExecutorWithQueryDelegate.runInsert (package:moor/src/runtime/executor/helpers/engines.dart:67) E/flutter (17463): #7      _MoorServer._runQuery (package:moor/src/runtime/isolate/server.dart:87) E/flutter (17463): <asynchronous suspension> E/flutter (17463): #8      IsolateCommunication.setRequestHandler.<anonymous closure>.<anonymous closure> (package:moor/src/runtime/isolate/communication.dart) E/flutter (17463): <asynchronous suspension>
This is the stream method I created inside the MyDatabase and currently using with a streambuilder in my UI :
MyDatabase Stream Method
Stream<bool> containsBookmarkStream(int id) {
    return select(
            bookmarkTable)
        .watch()
        .map((event) => event.any((element) => element.id == id));
  }

UI
StreamBuilder<bool>(
          stream: database.containsBookmarkStream(currentInfoModelID),
          builder: (context, snapshot) {
            if (snapshot.hasData) {
              bool isSaved = snapshot.data;

              return IconButton(
                tooltip: 'Bookmark',
                icon: (isSaved)
                    ? Icon(
                        Icons.star,
                        color: iconColor,
                      )
                    : Icon(
                        Icons.star_border,
                        color: iconColor,
                      ),
                onPressed: () {
                  switch (!isSaved) {
                    case true:
                      database.addBookmark(currentInfoModelID);

                      break;
                    case false:
                      database.removeBookmark(currentInfoModelID);

                      break;
                  }

                  Scaffold.of(context).showSnackBar(
                    SnackBar(
                      duration: Duration(seconds: 1),
                      content: isSaved ? Text('Removed') : Text('Saved'),
                    ),
                  );
                },
              );
            } else {
              return CircularProgressIndicator();
            }
          },
        ),

notes: I'm using provider and also using isolate from this example:
Thanks for the help.

Thanks for the report. Can you enable logStatements on the VmDatabase so that moor logs the statements it issues?

I 've enabled log statements for both debug mode and profile mode, here the result of the two:
PROFILE MODE
Moor: Sent BEGIN TRANSACTION with args []
I/flutter (20492): Moor: Sent INSERT INTO bookmark_table (id) VALUES (?) with args [100983271063552]
I/flutter (20492): Moor: Sent ROLLBACK TRANSACTION with args []
I/flutter (20492): Moor: Sent BEGIN TRANSACTION with args []
E/flutter (20492): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: "SqliteException(1555): UNIQUE constraint failed: bookmark_table.id, constraint failed (code 1555)"
E/flutter (20492): #0      PreparedStatement.execute (package:moor_ffi/src/impl/prepared_statement.dart:107)
E/flutter (20492): #1      _VmDelegate._runWithArgs (package:moor_ffi/src/vm_database.dart:72)
E/flutter (20492): #2      _VmDelegate.runInsert (package:moor_ffi/src/vm_database.dart:84)
E/flutter (20492): #3      _ExecutorWithQueryDelegate.runInsert.<anonymous closure> (package:moor/src/runtime/executor/helpers/engines.dart:69)
E/flutter (20492): #4      BasicLock.synchronized (package:synchronized/src/basic_lock.dart:32)
E/flutter (20492): #5      _ExecutorWithQueryDelegate._synchronized (package:moor/src/runtime/executor/helpers/engines.dart:22)
E/flutter (20492): #6      _ExecutorWithQueryDelegate.runInsert (package:moor/src/runtime/executor/helpers/engines.dart:67)
E/flutter (20492): #7      _MoorServer._runQuery (package:moor/src/runtime/isolate/server.dart:87)
E/flutter (20492): <asynchronous suspension>
E/flutter (20492): #8      IsolateCommunication.setRequestHandler.<anonymous closure>.<anonymous closure> (package:moor/src/runtime/isolate/communication.dart)
E/flutter (20492): <asynchronous suspension>
E/flutter (20492):
.....

DEBUG MODE
I/flutter (23767): Moor: Sent INSERT INTO bookmark_table (id) VALUES (?) with args [23515]
I/flutter (23767): Moor: Sent COMMIT TRANSACTION with args []
I/flutter (23767): Moor: Sent SELECT * FROM bookmark_table; with args []

.....

I/flutter (23767): Moor: Sent DELETE FROM bookmark_table WHERE id = ?; with args [23515]
I/flutter (23767): Moor: Sent COMMIT TRANSACTION with args []
I/flutter (23767): Moor: Sent SELECT * FROM bookmark_table; with args []

.....

It's seem to have a rollback transaction in Profile mode but not in Debug mode.
notes : the bookmark_table only contains integer ids inside with autoIncrement()

This sounds a bit like https://github.com/flutter/flutter/issues/54948, are you building on Windows? And which Flutter version are you on?
When permuting the upper and lower 32 bits of 23515, we get<PHONE_NUMBER>65440. For<PHONE_NUMBER>63552 it would be 23512.
Since that permutation shows up in the logs, it sounds like it happens in Dart, before calling ffi methods. If you print(currentInfoModelID), does that show the same values on debug and profile builds?

I' ve run flutter doctor for the full details:
[√] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.18363.900], locale en-US)
    • Flutter version 1.17.5 at C:\src\flutter
    • Framework revision 8af6b2f038 (11 days ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\Uns1t\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[!] IntelliJ IDEA Ultimate Edition (version 2019.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.1.3
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[√] Connected device (1 available)
    • One • 57f688ec • android-arm • Android 6.0.1 (API 23)

! Doctor found issues in 1 category.

here is the print statements from both debug and profile mode:
Profile mode
....
I/flutter (21471):<PHONE_NUMBER>98144 // PRINTED VALUE HERE OF currentInfoModelID
I/flutter (21471): Moor: Sent BEGIN TRANSACTION with args []
I/flutter (21471): Moor: Sent INSERT INTO bookmark_table (id) VALUES (?) with args [100991860998144]
I/flutter (21471): Moor: Sent ROLLBACK TRANSACTION with args []
E/flutter (21471): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: "SqliteException(1555): UNIQUE constraint failed: bookmark_table.id, constraint failed (code 1555)"
E/flutter (21471): #0      PreparedStatement.execute (package:moor_ffi/src/impl/prepared_statement.dart:107)
E/flutter (21471): #1      _VmDelegate._runWithArgs (package:moor_ffi/src/vm_database.dart:72)
E/flutter (21471): #2      _VmDelegate.runInsert (package:moor_ffi/src/vm_database.dart:84)
E/flutter (21471): #3      _ExecutorWithQueryDelegate.runInsert.<anonymous closure> (package:moor/src/runtime/executor/helpers/engines.dart:69)
E/flutter (21471): #4      BasicLock.synchronized (package:synchronized/src/basic_lock.dart:32)
E/flutter (21471): #5      _ExecutorWithQueryDelegate._synchronized (package:moor/src/runtime/executor/helpers/engines.dart:22)
E/flutter (21471): #6      _ExecutorWithQueryDelegate.runInsert (package:moor/src/runtime/executor/helpers/engines.dart:67)
E/flutter (21471): #7      _MoorServer._runQuery (package:moor/src/runtime/isolate/server.dart:87)
E/flutter (21471): <asynchronous suspension>
E/flutter (21471): #8      IsolateCommunication.setRequestHandler.<anonymous closure>.<anonymous closure> (package:moor/src/runtime/isolate/communication.dart)
E/flutter (21471): <asynchronous suspension>
E/flutter (21471): ........

Debug mode
......
I/flutter (24192): 23514 //PRINTED VALUE HERE OF currentInfoModelID
I/flutter (24192): Moor: Sent BEGIN TRANSACTION with args []
I/flutter (24192): Moor: Sent INSERT INTO bookmark_table (id) VALUES (?) with args [23514]
I/flutter (24192): Moor: Sent COMMIT TRANSACTION with args []
I/flutter (24192): Moor: Sent SELECT * FROM bookmark_table; with args []
.......

you're right my id doesn't print 23514 in profile mode.

I think that Flutter issue hasn't yet been fixed on stable. Can you try to switch to an unstable Flutter channel and see if that works? It switching to say master works, it's probably because of that compiler bug.

I've changed to flutter channel master but went I compile the code it's gave me a build error:
Launching lib\main.dart on One in release mode...
Running Gradle task 'assembleRelease'...
Error: Could not resolve the package 'characters' in 'package:characters/characters.dart'.
/C:/src/flutter/packages/flutter/lib/src/material/text_field.dart:9:8: Error: Not found: 'package:characters/characters.dart'
import 'package:characters/characters.dart';
       ^
/C:/src/flutter/packages/flutter/lib/widgets.dart:18:1: Error: Not found: 'package:characters/characters.dart'
export 'package:characters/characters.dart';
^
/C:/src/flutter/packages/flutter/lib/src/services/text_formatter.dart:9:8: Error: Not found: 'package:characters/characters.dart'
import 'package:characters/characters.dart';
       ^
/C:/src/flutter/packages/flutter/lib/src/rendering/editable.dart:10:8: Error: Not found: 'package:characters/characters.dart'
import 'package:characters/characters.dart';
       ^
/C:/src/flutter/packages/flutter/lib/src/material/text_field.dart:822:61: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
  int get _currentLength => _effectiveController.value.text.characters.length;
                                                            ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/material/text_field.dart:824:118: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
  bool get _hasIntrinsicError => widget.maxLength != null && widget.maxLength > 0 && _effectiveController.value.text.characters.length > widget.maxLength;
                                                                                ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_formatter.dart:355:11: Error: 'CharacterRange' isn't a type.
    final CharacterRange iterator = CharacterRange(value.text);
          ^^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_formatter.dart:355:37: Error: Method not found: 'CharacterRange'.
    final CharacterRange iterator = CharacterRange(value.text);
                                    ^^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_formatter.dart:356:20: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
    if (value.text.characters.length > maxLength) {
                   ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_formatter.dart:375:61: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
    if (maxLength != null && maxLength > 0 && newValue.text.characters.length > maxLength) {
                                                            ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_formatter.dart:378:25: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
      if (oldValue.text.characters.length == maxLength) {
                        ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/rendering/editable.dart:244:64: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
       assert(obscuringCharacter != null && obscuringCharacter.characters.length == 1),
                                                               ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/rendering/editable.dart:361:35: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
    assert(value != null && value.characters.length == 1);
                                  ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/rendering/editable.dart:567:11: Error: 'Characters' isn't a type.
    final Characters remaining = string.characters.skipWhile((String currentString) {
          ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/rendering/editable.dart:567:41: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
    final Characters remaining = string.characters.skipWhile((String currentString) {
                                        ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/rendering/editable.dart:600:47: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
    for (final String currentString in string.characters) {
                                              ^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/rendering/editable.dart:602:40: Error: The getter 'characters' isn't defined for the class 'String'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'characters'.
          !_isWhitespace(currentString.characters.first.toString().codeUnitAt(0))) {
                                       ^^^^^^^^^^
Unhandled exception:
FileSystemException(uri=org-dartlang-untranslatable-uri:package%3Acharacters%2Fcharacters.dart; message=StandardFileSystem only supports file:* and da
ta:* URIs)
#0      StandardFileSystem.entityForUri (package:front_end/src/api_prototype/standard_file_system.dart:33:7)
#1      asFileUri (package:vm/kernel_front_end.dart:659:37)
#2      writeDepfile (package:vm/kernel_front_end.dart:853:21)
<asynchronous suspension>
#3      FrontendCompiler.compile (package:frontend_server/frontend_server.dart:574:15)
<asynchronous suspension>
#4      _FlutterFrontendCompiler.compile (package:flutter_frontend_server/server.dart:43:22)
#5      starter (package:flutter_frontend_server/server
.dart:182:27)
#6      main (file:///C:/b/s/w/ir/cache/builder/src/flutter/flutter_frontend_server/bin/starter.dart:9:30)
#7      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#8      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

FAILURE: Build failed with an exception.

* Where:
Script 'C:\src\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 896

* What went wrong:
Execution failed for task ':app:compileFlutterBuildRelease'.
> Process 'command 'C:\src\flutter\bin\flutter.bat'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2m 2s
Exception: Gradle task assembleRelease failed with exit code 1

I think I'll need to wait until it can be fixed in the stable channel . Meanwhile, I'll see if the're a workaround until it can be fixed but I wonder if I could change the moor_ffi to moor_flutter version? would it be the same result? is it recommended?

You can try to use moor_flutter instead of moor_ffi, yes. moor_ffi is faster and allows us to use the latest sqlite3 version, but there's nothing wrong with using moor_flutter, especially if there are bugs preventing you from using dart:ffi.

This issue has been fixed in flutter 1.20 , so I'll close it. Thanks for the help, suggestions and the moor package since it's help me a lot during my development I appreciated it.


python312Packages.craft-parts: 1.26.2 -> 1.29.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.craft-parts is: Software artifact parts builder from Canonical
meta.homepage for python312Packages.craft-parts is: https://github.com/canonical/craft-parts
meta.changelog for python312Packages.craft-parts is: https://github.com/canonical/craft-parts/releases/tag/1.29.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.29.0 with grep in /nix/store/k3gbm97w0156s4map7izny3ra1fg1q2r-python3.12-craft-parts-1.29.0
found 1.29.0 in filename of file in /nix/store/k3gbm97w0156s4map7izny3ra1fg1q2r-python3.12-craft-parts-1.29.0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
python311Packages.craft-application-1
python311Packages.craft-parts
python312Packages.craft-application-1
python312Packages.craft-parts
rockcraft

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k3gbm97w0156s4map7izny3ra1fg1q2r-python3.12-craft-parts-1.29.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.craft-parts https://github.com/r-ryantm/nixpkgs/archive/03e7bee98cf9b5814dd55738e84a46cfddf38f5e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/03e7bee98cf9b5814dd55738e84a46cfddf38f5e#python312Packages.craft-parts

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k3gbm97w0156s4map7izny3ra1fg1q2r-python3.12-craft-parts-1.29.0
ls -la /nix/store/k3gbm97w0156s4map7izny3ra1fg1q2r-python3.12-craft-parts-1.29.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

10 packages built:

python311Packages.craft-application-1
python311Packages.craft-application-1.dist
python311Packages.craft-parts
python311Packages.craft-parts.dist
python312Packages.craft-application-1
python312Packages.craft-application-1.dist
python312Packages.craft-parts
python312Packages.craft-parts.dist
rockcraft
rockcraft.dist

Maintainer pings
cc @jnsgruk for testing.

Duplicate of https://github.com/NixOS/nixpkgs/pull/300596


support Svelte 5

Expand the peer dependency range for Svelte to include Svelte 5 prereleases.
SvelteKit uses svelte-hmr under the hood, but given that svelte-hmr doesn't allow Svelte 5, strict package managers will consider a SvelteKit + Svelte 5 project invalid even if SvelteKit supports it in the dependency range.
Here's what yarn explain peer-requirements has to say on the matter:
We have a problem with svelte, which is provided with version 5.0.0-next.17.
It is needed by the following direct dependencies of workspaces in your project:

  ✓ @storybook/sveltekit@portal:/Users/jeppe/dev/work/storybook/storybook/code/frameworks/sveltekit::locator=svelte-kit-prerelease-ts%40workspace%3A. [f85c6] (via ^4.0.0 || ^5.0.0-next.16)

However, those packages themselves have more dependencies listing svelte as peer dependency:

  ✓ @sveltejs/vite-plugin-svelte-inspector@npm:2.0.0 [c7b72] (via ^4.0.0 || ^5.0.0-next.0)
  ✘ svelte-hmr@npm:0.15.3 [c7b72] (via ^3.19.0 || ^4.0.0)
  ✓ @sveltejs/vite-plugin-svelte@npm:3.0.1 [cedf8] (via ^4.0.0 || ^5.0.0-next.0)
  ✓ svelte-preprocess@npm:5.1.1 [cedf8] (via ^3.23.0 || ^4.0.0-next.0 || ^4.0.0 || ^5.0.0-next.0)
  ✓ @storybook/svelte-vite@portal:/Users/jeppe/dev/work/storybook/storybook/code/frameworks/svelte-vite::locator=svelte-kit-prerelease-ts%40workspace%3A. [f0054] (via ^4.0.0 || ^5.0.0-next.16)

Put together, the final range we computed is ^4.0.0 || ^4.0.0

This is currently blocking Storybook from testing against Svelte 5 in our ecosystem CI

In general svelte5 support in vite-plugin-svelte (and sveltekit) is marked as experimental, svelte-5 is still in alpha so expect breaking changes from time to time.
Due to the experimental nature there are a few things that are not perfect rn and peer dependency ranges is one of them.
pnpm allows you to silence peer dependency warnings by name, maybe yarn has a similar feature? Otherwise i'd recommend to disable strict peer checks for the svelte5 test altogether.
It's very likely that there is going to be a new major release for vite-plugin-svelte to add proper support for svelte5 that no longer depends on svelte-hmr.

That's fair, thanks for the feedback!
We actually explicitly tell Yarn to error on incompatible peer dependencies in our CI. This does cause problems sometimes with upstreams like this, but it also often catches problems caused by our internal packages.
Either way this is something to solve on our side, I'll figure out a workaround.


MessageUpdated not working

MessageDeleted works perfectly but not MessageUpdated
i.e. : https://i.imgur.com/cftM3mc.png
No errors or warning in the console. Redis installed fine and all other logs working.
Every log events are registered : https://i.imgur.com/lMvzO6n.png

MesssageUpdated event ignores messages which are updated in the channel the bot is logging in.
I tested, it works.


Failed to scrobble:  Missing data on One Piece episode

Hi, I'm already logged into trakt (using the footer btn) but in this episode https://www.crunchyroll.com/one-piece/episode-338-the-joy-of-seeing-people-the-gentleman-skeletons-true-identity-655299 it shows this:
Failed to scrobble: Missing data.
Do I need to do something else?
Thanks for your time

This is one of the tricky series to match to Trakt and I haven't figured out a good way yet. The issue is that Crunchyroll makes up their own "seasons", which don't match up with the ones on Trakt. On the other hand, Trakt makes it hard to look up episodes by absolute number, insisting on season-based numbering.
The only way I see right now is to load all episodes from all seasons, which is almost 900 episodes split over 19 seasons and would require 19 separate requests to be sent. I feel this would be close to abusing Trakt's API, so I'll hopefully come up with something better.


Revert #406

What this PR does / why we need it:
Revert #406
The #406 PR introduced the toolchain go1.22.2 directive,
which is causing troubles in our d/s builds.
Release note:
NONE

/hold
need to verify additional things

/lgtm


explicitly load db drivers, before removing drivers from vendor package

openark/golib is to drop imports for github.com/mattn/go-sqlite3 and github.com/go-sql-driver/mysql ; they are not directly used by openark/golib and they create overhead when importing openark/golib.
We therefore now explicitly load these two packages in orchestrator.

Related: https://github.com/outbrain/golib/compare/master...openark:remove-db-dependencies?expand=1

Relates: https://github.com/outbrain/golib/pull/10


Align checkpointing code with NeoX

This PR makes small changes to the DeepSpeed checkpointing code that makes the advanced features such as universal checkpoints compatible for use with GPT-NeoX models.

@dashstander, just wanted to check that you meant to close this?

Yes, sorry, I meant to make the PR against EleutherAI's fork. I'll delete this branch shortly


Write installation steps in readme.md

While waiting for the deployment automation (#6), we should write the installation steps in the readme:

How to deploy the custom policies in AAD B2C
How to deploy and configure the SPIDProxy
How to get started with the demo.spid.gov.it environment

Hi, I would like to try your solution. Is it still current? Does the installation documentation not yet exist?

Hi @asorcinelli , the solution is still current and widely used. Official docs is still not yet available but you can use the one available in #44

Hi @fume, thanks for the reply. Yes, I saw the documentation and managed to set up the entire environment. I have a problem, but I don't want to dwell on it here as I don't think it's the right place. Could I contact you somehow and explain the problem? Maybe you can help me. Thank you.

Hi @fume, thanks for your work. I followed the documentation and I configured the entire environment. I have a problem, I always receive the error from b2c "The service provider is not a valid audience of the assertion." CouId contact you and explain the problem? Could you help me? Thank you.

Hi @gicaz,
i apologize for the late reply!
Could you please share a SAMLTrace of the authentication process? That would definetely help to troubleshoot the error, but most probably you are right: something in the SPIDProxy setting could be wrong.
As a recap:

MetadataUrl: unused 😄
SPIDEntityId: is the entityId of the metadata sent to AgID (or uploaded on the Demo SPID Gov environment)
CIEEntityId: is the entityID of the metadata uploaded on the 'Portale Federazione CIE'. Could be the same as SPIDEntityId
EntityId: is the entityId of AAD B2C (usually something like 'https://your-tenant.b2clogin.com/your-tenant.onmicrosoft.com/B2C_1A_TrustFrameworkBase'
FederatorAttributeConsumerServiceUrl: is the endpoint where the SPIDProxy should forward the samlresponse. Your value format seems correct to me

HI @fume, thank you very much for your reply. Now it works!
I made a mistake with the EntityID parameter as I had assumed.
I configured the EntityID as you described and the authentication was completed successfully.
Now I correctly receive the JWT from Azure B2C and log in to the test app.


Old protobuf install in Dockerfile build

If building the model-analyzer from the provided Dockerfile, protobuf version 3.6.1 is installed leading to a failure when running the profile command:
  File "/usr/local/bin/model-analyzer", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/model_analyzer/entrypoint.py", line 280, in main
    analyzer.cb_search(client=client)
  File "/usr/local/lib/python3.8/dist-packages/model_analyzer/analyzer.py", line 166, in cb_search
    self._model_manager.cb_search_models(self._config.profile_models)
  File "/usr/local/lib/python3.8/dist-packages/model_analyzer/model_manager.py", line 113, in cb_search_models
    self._execute_vw_search(self._config.iterations)
  File "/usr/local/lib/python3.8/dist-packages/model_analyzer/model_manager.py", line 296, in _execute_vw_search
    if not self._create_and_load_model_variant(
  File "/usr/local/lib/python3.8/dist-packages/model_analyzer/model_manager.py", line 338, in _create_and_load_model_variant
    variant_config.write_config_to_file(new_model_dir,
  File "/usr/local/lib/python3.8/dist-packages/model_analyzer/triton/model/model_config.py", line 182, in write_config_to_file
    model_config_bytes = text_format.MessageToBytes(self._model_config)
AttributeError: module 'google.protobuf.text_format' has no attribute 'MessageToBytes'

In the pre-built image nvcr.io/nvidia/tritonserver:21.06-py3-sdk, protobuf version 3.17 is installed which does have an implementation for MessageToBytes.

A quick fix is just to do a: python3 -m pip install --upgrade protobuf. I'm not sure of what package is responsible for installing the old version of protobuf at this point.

Are you on the 21.06 branch? This issue existed in the earlier versions of MA but it is fixed in the 21.06 release. I just tried building the docker from source but was not able to reproduce this issue:
 model_analyzer git:(r21.06) docker run -ti  model-analyzer /bin/bash
=============================
=== Triton Model Analyzer ===
=============================
NVIDIA Release 21.06 (build 24198912)
Copyright (c) 2020-2021, NVIDIA CORPORATION.  All rights reserved.
Various files include modifications (c) NVIDIA CORPORATION.  All rights reserved.
This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license
find: File system loop detected; '/usr/bin/X11' is part of the same file system loop as '/usr/bin'.

WARNING: The NVIDIA Driver was not detected.  GPU functionality will not be available.
   Use Docker with NVIDIA Container Toolkit to start this container; see
   https://github.com/NVIDIA/nvidia-docker.

root@de60997f74a8:/opt/triton-model-analyzer# python3
Python 3.8.10 (default, Jun  2 2021, 10:49:15)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.protobuf
>>> print(google.protobuf.__version__)
3.17.3

This is on the main branch as of today. I found that the protobuf is being installed via apt via the line RUN apt-get install -y wkhtmltopdf. In the docker build log you can see:
Setting up python3-protobuf (<IP_ADDRESS>-2ubuntu5)


Updated example output in Manage Long-Running Queries

I missed this page when updating SHOW QUERIES example output in #6764, for #6189.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/103051b30ea708c04d0553b3c57c4c0ab37206c1/
Edited pages:

v20.1/manage-long-running-queries.md

TFTR @Amruta-Ranade !


TouchEvent issue on android for adjacent SVG paths

Bug
This is only for android! (For iOS it works like expected)
If for example we have two NONE overlapping but adjacent SVG paths (in different SVG components) but with overlapping rectangles of their circumscribed bounds (paths DO NOT overlapp) then touch event only works for last SVG or for not intersected circumscribed bounds ... or if you put zIndex higher for first SVG then touch will work for that image.... for iOS it works like expected and all none overlapping paths touchable (regardless their rectangle circumscribed bounds and zIndexes)

I think I'm having this exact issue. I have an SVG of a car, detailing many of the parts of the vehicle (Each in its own path or line).  On iOS, each part is easily selectable, on android, some of the parts are unselectable (or require selecting on the line itself). Not sure what's going on with it!

Hello! Something will respond here?

@alloy  @kant  @yangyi ? could someone help to fix Android issue with clicking svg paths?

I don’t have Android experience.
It seems like you will have to debug/fix this yourself (and please do send a PR when you do).

@alloy  I;m not android developer but could fix it ..though having issue:
.../react-native-svg-develop/android/src/main/java/com/horcrux/svg/LineView.java:17: error: cannot find symbol
import com.facebook.react.bridge.Dynamic;
^
symbol:   class Dynamic
location: package com.facebook.react.bridge

Any updates on this issue?

Hello @ideveloperaz @ngima,
If the issue is still relevant, please provide an example to reproduce the problem.
Thank you.


"Failed to write hook to 'C:\Program Files (x86)\Steam\steamapps\common\Deep Rock Galactic\FSD\Binaries\Win64\x3daudio1_7.dll'

This is the message that appeared after I tried to install the mods. My antivirus flagged x3daudio1_7.dll as infected with a trojan the first time I tried to install the mods, so I told it to revert it back (which it did) and to ignore both MINT and the .dll file... but it still gives me this error and it can't even uninstall the mods. Turning the antivirus off didn't solve it, neither reinstalling the game or verifying the game's cache. At some point while trying some other things the antivirus still decided to completely remove the x3daudio1_7.dll file... and now I can't seem to get it back, not even after reinstalling the game. So yeah, it's completely messed up :/

Unfortunately we can't do anything about your antivirus flagging the hook mint generates (you'll have to ignore the hook, one possibility is to add an exception for the game folder, but I won't make the suggestion to modify antivirus config because that's your decision to make considering the risks).


Add diagnostic mode for all chars

## Enable diagnostic mode in the deployment
##
diagnosticMode:
  ## @param diagnosticMode.enabled Enable diagnostic mode (all probes will be disabled and the command will be overridden)
  ##
  enabled: false
  ## @param diagnosticMode.command Command to override all containers in the deployment
  ##
  command:
    - sleep
  ## @param diagnosticMode.args Args to override all containers in the deployment
  ##
  args:
    - infinity

The following components need to be modified

[ ] https://github.com/drycc/controller
[ ] https://github.com/drycc/rabbitmq
[ ] https://github.com/drycc/redis
[ ] https://github.com/drycc/registry
[x] https://github.com/drycc/storage
[ ] https://github.com/drycc/timeseries
[ ] https://github.com/drycc/logger
[ ] https://github.com/drycc/builder
[ ] https://github.com/drycc/manager
[ ] https://github.com/drycc/registry-proxy
[ ] https://github.com/drycc/monitor
[ ] https://github.com/drycc/fluentbit
[ ] https://github.com/drycc/passport
[ ] https://github.com/drycc/database

complete


Add segments function as a test util function

To improve and facilitate test coverage (e.g. for the following case which is currently under development: https://github.com/keep-starknet-strange/cairo-zig/issues/8), we need to start developing some useful tests for the core of the VM, the segments logic is one of them:

Details of similar implementation in Rust can be found here: https://github.com/lambdaclass/cairo-vm/blob/e6171d66a64146acc16d5512766ae91ae044f297/vm/src/utils.rs#L102-L117
This can be done after #74 is resolved.

can take have it done :)

can take have it done :)

@oxlime Assigned


Merge in the OCC changes in seiv2 into main

Describe your changes and provide context
This will merge seiv2 into main, which effectively means merging occ into main based on the current branch state
Testing performed to validate your change
Loadtesting + CI
NEED TO UPDATE THE GO MOD with a sei-cosmos tag in main
MERGE WITHOUT SQUASH

Codecov Report
Attention: Patch coverage is 34.11765% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 63.01%. Comparing base (73ee42b) to head (56d7956).
 Consider uploading reports for the commit f1f5172 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   63.45%   63.01%   -0.45%
==========================================
  Files         257      257
  Lines       16740    16867     +127
==========================================
+ Hits        10623    10628       +5
- Misses       5611     5730     +119
- Partials      506      509       +3

Files
Coverage Δ

aclmapping/dex/mappings.go
100.00% <100.00%> (ø)

app/test_helpers.go
48.83% <100.00%> (+0.29%)
:arrow_up:

...x/keeper/msgserver/msg_server_register_contract.go
59.17% <100.00%> (ø)

...keeper/msgserver/msg_server_unregister_contract.go
45.83% <100.00%> (ø)

.../keeper/msgserver/msg_server_unsuspend_contract.go
62.96% <100.00%> (ø)

x/dex/module.go
57.21% <100.00%> (ø)

x/oracle/types/test_utils.go
51.89% <ø> (ø)

x/dex/contract/abci.go
7.35% <0.00%> (ø)

x/dex/types/keys.go
36.47% <0.00%> (-1.81%)
:arrow_down:

app/abci.go
62.96% <0.00%> (-12.60%)
:arrow_down:

... and 2 more

... and 4 files with indirect coverage changes