Call to undefined method mathTagHook()

With Math enabled, if I save the page with $$ section in <markdown>, the page will be like this:
[cc9dd1222bfb599d83029366] /index.php?title=%E6%96%87%E6%9C%AC%E6%A0%B7%E5%BC%8F%E7%A4%BA%E4%BE%8B&action=submit Error: Call to undefined method MediaWiki\Extension\Math\Hooks::mathTagHook()

Backtrace:

from /home/wwwroot/wiki/extensions/WikiMarkdown/includes/WikiMarkdown.php(155)
#0 [internal function]: WikiMarkdown::{closure}()
#1 /home/wwwroot/wiki/extensions/WikiMarkdown/includes/WikiMarkdown.php(157): preg_replace_callback()
#2 /home/wwwroot/wiki/includes/parser/Parser.php(3979): WikiMarkdown::parserHook()
#3 /home/wwwroot/wiki/includes/parser/PPFrame_Hash.php(353): Parser->extensionSubstitution()
#4 /home/wwwroot/wiki/includes/parser/Parser.php(2932): PPFrame_Hash->expand()
#5 /home/wwwroot/wiki/includes/parser/Parser.php(1579): Parser->replaceVariables()
#6 /home/wwwroot/wiki/includes/parser/Parser.php(697): Parser->internalParse()
#7 /home/wwwroot/wiki/includes/content/WikitextContentHandler.php(294): Parser->parse()
#8 /home/wwwroot/wiki/includes/content/ContentHandler.php(1705): WikitextContentHandler->fillParserOutput()
#9 /home/wwwroot/wiki/includes/content/Renderer/ContentRenderer.php(47): ContentHandler->getParserOutput()
#10 /home/wwwroot/wiki/includes/EditPage.php(4254): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput()
#11 /home/wwwroot/wiki/includes/EditPage.php(4157): EditPage->doPreviewParse()
#12 /home/wwwroot/wiki/includes/EditPage.php(2926): EditPage->getPreviewText()
#13 /home/wwwroot/wiki/includes/EditPage.php(728): EditPage->showEditForm()
#14 /home/wwwroot/wiki/includes/actions/EditAction.php(71): EditPage->edit()
#15 /home/wwwroot/wiki/includes/actions/SubmitAction.php(38): EditAction->show()
#16 /home/wwwroot/wiki/includes/MediaWiki.php(543): SubmitAction->show()
#17 /home/wwwroot/wiki/includes/MediaWiki.php(321): MediaWiki->performAction()
#18 /home/wwwroot/wiki/includes/MediaWiki.php(912): MediaWiki->performRequest()
#19 /home/wwwroot/wiki/includes/MediaWiki.php(563): MediaWiki->main()
#20 /home/wwwroot/wiki/index.php(53): MediaWiki->run()
#21 /home/wwwroot/wiki/index.php(46): wfIndexMain()
#22 {main}

Is it caused by some version mismatch? I'm currently using

MediaWiki 1.38.4
PHP 7.4.30
WikiMarkdown 1.1.3 (642e707) 2022-08-15
Math 3.0.0
SyntaxHighlight 2.0 (it works fine with markdown)
benjaminhoegh/parsedown-extended 1.1.2
erusev/parsedown 1.8.0b7
erusev/parsedown-extra 0.8.1

Can you confirm that using the Math extension normally (not within markdown) works properly?

Additionally, I've tested this extension with Math 3.0.0 (4e8cc52) on MediaWiki 1.35.8 (latest LTS release) and there is no issue.  It looks like the Math extension has had some refactoring, which would make certain versions incompatible (much like what you are seeing). Please try using the 4e8cc52 version of Math and see if that works for you.  Once the next LTS release of MediaWiki is stable (1.39), I'll look into making changes to support whatever version of Math comes with that version.

I'll look into making changes to support whatever version of Math comes with that version.
OK, I get it.

Can you confirm that using the Math extension normally (not within markdown) works properly?
It works normally without markdown. I'll disable math section in markdown for a simple fix as this is actually not a big issue for me though XD

Thanks for your help!

You might also be able to apply a simple hack to your version of WikiMarkdown by changing lines 130, 138, 146, and 155 to have MediaWiki\Extension\Math\HookHandlers instead of MediaWiki\Extension\Math\Hooks.  I won't make this change here yet since that will break 1.35 compatibility and I mainly support MediaWiki LTS releases, but I'll likely need to make that change when MediaWiki 1.39 is released.

Pretty cool solution, I'll try it later. Thanks!

to fix https://github.com/kuenzign/WikiMarkdown/issues/6
in 1.41 construct function changes to
public function __construct(
--
   RendererFactory $rendererFactory,
   UserOptionsLookup $userOptionsLookup,
   HookContainer $hookContainer
   ) {
   $this->rendererFactory = $rendererFactory;
   $this->userOptionsLookup = $userOptionsLookup;
   $this->hookRunner = new HookRunner( $hookContainer );
   }

so need some fix to 3 arg in
	$hookHandler = new \MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler(
				MediaWiki\MediaWikiServices::getInstance()->getService( 'Math.RendererFactory' ),
				MediaWiki\MediaWikiServices::getInstance()->getService( 'UserOptionsLookup' )
			);


After create a fresh Project,run npm i is error

Describe the bug
After create fresh Project,run npm i is error
System Info
  System:
    OS: Windows 10 10.0.19042
    CPU: (4) x64 Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz
    Memory: 6.56 GB / 15.88 GB
  Binaries:
    Node: 14.16.0 - D:\Node.js\node.EXE
    Yarn: 1.22.10 - D:\Node.js\node-global\yarn.CMD
    npm: 6.14.2 - D:\Node.js\npm.CMD
  Browsers:
    Chrome: 89.0.4389.114
    Edge: Spartan (44.19041.423.0), Chromium (89.0.774.76)
    Internet Explorer: 11.0.19041.1
  npmPackages:
    @vitejs/plugin-vue: ^1.1.5 => 1.2.1
    vite: ^2.1.3 => 2.1.5

Used package manager: npm
Logs
$ npm i

><EMAIL_ADDRESS>postinstall E:\apidoc-cms\node_modules\esbuild
> node install.js

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.

added 146 packages from 186 contributors and audited 147 packages in 35.836s

7 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Administrator@DESKTOP-KA7EPLR MINGW64 /e/apidoc-cms (1.0.0-dev-dxy)
$ The version of the downloaded binary is incorrect: spawnSync E:\apidoc-cms\node_modules\esbuild\esbuild.exe EPERM
Install unsuccessful

Try installing esbuild directly in a fresh project. I think this may be an issue to report to esbuild.


Release, please

Would it be possible to build a new patch release just to get the bindgen-0.66 upgrade?

@asomers I think I can do that tomorrow.


Update riscv docker

Update Linux toolchain to support rv32 and rv64 multilib
Update rv32 baremetal toolchain to support zvl and zve ISA extensions

Docker image pull time increased from 1 min to 1min 4s (image size goes from 10GB to 11.4GB)
The followup PRs will

[ ] Enable RISCV 32-bit Linux build/test environment, so we can have one more 32-bit system that can run IREE modules without building everything into bare-metal mode.
[ ] Enable iree_static_linker_test in crosscompile environments.


Use latest version of prometheus fork

This one depends on prism, not frankenstein, thus obsoleting our
non-upstreamed changes in the vendor directory.
Part of #28. Made possible by tomwilkie/prometheus#78

:+1:


Resolve links for returned fields

If a field is a Contentful::Link, we should call resolve() on it so we get a proper object.
This needs to be done in ContenfulModel::Base.method_missing()

Hey @edtjones, yes it looks like on line 20 if we simply resolved the asset it should work just fine. It also seems like the first level of returned link are being auto-resolved by the contentful ruby client - I wonder if we were to set the include query param to equal the total defined depth of an asset if it would take care of all the resolving for you? I.e. client.entries(include: 1) from their Readme.

This has been solved by changing the Client to use dynamic entry resolution, which already solves any nested entries.


#70 - There is no Password option for Rsync SSH. Documentation is up…

What we have:

People see a problem while trying to use this GitHub action with a Private key secured by a passphrase.
-- Example: #70
There is no option to pass a password for the private key in the SSH command. So, Rsync used here won't allow us to do that.
-- Reference: Articles like that. "When prompted, do not enter a password or passphrase",
-- SSH - Available CLI Command Options

What this PR offers:

We can simply ask people to create a private key without a password.

Thanks


incomplete output

Hey im wondering how to interpret the results or if something is broken.
I'm currently running  a flakes enabled build (on an s390x host)
which looks like:
[3/125/228 built, 0.0 MiB DL] building tpm2-tss-4.1.3 (buildPhase):   CC       src/tss2-sys/api/libtss2_sys_la-Tss2_Sys_HMAC.lo

but looking at nix top i see something like this:
Summary per output
       4 → /tmp/nix-build-libusb-1.0.27.drv-0
      15 →

 * * *

:: (nixbld1) → /tmp/nix-build-libusb-1.0.27.drv-0
  UID     PID    PPID STIME     TIME COMMAND
<PHONE_NUMBER> 1242103 08:48 00:00:00 bash -e /nix/store/v6x3cs394jgqfbi0a42pam708flxaphh-default-builder.sh
<PHONE_NUMBER> 1246381 08:48 00:00:00 /nix/store/aiaa22nsyb42cnki2kakvcrv837vmjb7-cargo-auditable-0.6.2/bin/cargo-auditable auditable build -j 4 --target s390x-unknown-linux-gnu --offline --profile release
<PHONE_NUMBER> 1259523 08:48 00:00:02 /nix/store/a9m0813i38caxbrc0dqfwiivcspskm0h-cargo-1.80.1/bin/.cargo-wrapped build -j 4 --target s390x-unknown-linux-gnu --offline --profile release
<PHONE_NUMBER> 1259900 09:04 00:03:29 /nix/store/58csmqlj44z2f55ahh4bamgvdxw5mirn-rustc-1.80.1/bin/rustc --crate-name cargo --edition=2021 /build/cargo-c-0.10.2-vendor.tar.gz/cargo/src/cargo/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-

:: (nixbld13) →
  UID     PID    PPID STIME     TIME COMMAND
<PHONE_NUMBER> 1242103 08:48 00:00:00 bash -e /nix/store/v6x3cs394jgqfbi0a42pam708flxaphh-default-builder.sh
<PHONE_NUMBER> 1246512 08:49 00:00:00 make -j4 SHELL=/nix/store/pbyqslksmhq40jb6iwmr4xdzw5x1jkf8-bootstrap-tools/bin/bash BUILD_SYSTEM_HEADER_DIR=/nix/store/rn7d7dwhfz0i9k2hh59smxvjislmsvly-glibc-2.39-52-dev/include SYSTEM_HEADER_DIR=/nix/store/rn7d7dwhfz0i9k2hh59smx
<PHONE_NUMBER> 1301454 08:49 00:00:00 make DESTDIR= RPATH_ENVVAR=LD_LIBRARY_PATH TARGET_SUBDIR=s390x-unknown-linux-gnu bindir=/nix/store/f34hr4426znsbhvy5f6xz33mn2z0kn9s-gfortran-13.3.0/bin datadir=/nix/store/f34hr4426znsbhvy5f6xz33mn2z0kn9s-gfortran-13.3.0/share exe
<PHONE_NUMBER> 1301527 08:49 00:00:00 /nix/store/pbyqslksmhq40jb6iwmr4xdzw5x1jkf8-bootstrap-tools/bin/bash -c r=`${PWDCMD-pwd}`; export r; \ s=`cd ../gcc-13.3.0; ${PWDCMD-pwd}`; export s; \ if test -f stage1-lean ; then \   echo Skipping rebuild of stage1; \ else \
<PHONE_NUMBER> 1301749 08:49 00:00:00 make DESTDIR= RPATH_ENVVAR=LD_LIBRARY_PATH TARGET_SUBDIR=s390x-unknown-linux-gnu bindir=/nix/store/f34hr4426znsbhvy5f6xz33mn2z0kn9s-gfortran-13.3.0/bin datadir=/nix/store/f34hr4426znsbhvy5f6xz33mn2z0kn9s-gfortran-13.3.0/share exe
<PHONE_NUMBER> 1301876 08:54 00:00:00 /nix/store/pbyqslksmhq40jb6iwmr4xdzw5x1jkf8-bootstrap-tools/bin/bash -c r=`${PWDCMD-pwd}`; export r; \ s=`cd ../gcc-13.3.0; ${PWDCMD-pwd}`; export s; \ TFLAGS="-fno-checking"; \ FLEX="/build/gcc-13.3.0/missing flex"; export FLEX;
<PHONE_NUMBER> 1458883 08:54 00:00:00 make DESTDIR= RPATH_ENVVAR=LD_LIBRARY_PATH TARGET_SUBDIR=s390x-unknown-linux-gnu bindir=/nix/store/f34hr4426znsbhvy5f6xz33mn2z0kn9s-gfortran-13.3.0/bin datadir=/nix/store/f34hr4426znsbhvy5f6xz33mn2z0kn9s-gfortran-13.3.0/share exe
<PHONE_NUMBER> 1458918 09:08 00:00:00 /nix/store/kn1a1mn6h9zczn8d65i778dp3gfx5jnz-xgcc-13.3.0/bin/g++ -fPIC -O2 -U_FORTIFY_SOURCE -fzero-call-used-regs=used-gpr -fstack-protector-strong --param ssp-buffer-size=4 -fno-strict-overflow -march=z10 -std=c++11 -fno-PIE -c
<PHONE_NUMBER> 1458918 09:08 00:00:00 /nix/store/kn1a1mn6h9zczn8d65i778dp3gfx5jnz-xgcc-13.3.0/bin/g++ -fPIC -O2 -U_FORTIFY_SOURCE -fzero-call-used-regs=used-gpr -fstack-protector-strong --param ssp-buffer-size=4 -fno-strict-overflow -march=z10 -std=c++11 -fno-PIE -c
<PHONE_NUMBER> 1618611 09:08 00:00:00 /nix/store/kn1a1mn6h9zczn8d65i778dp3gfx5jnz-xgcc-13.3.0/libexec/gcc/s390x-unknown-linux-gnu/13.3.0/cc1plus -quiet -I . -I . -I ../../gcc-13.3.0/gcc -I ../../gcc-13.3.0/gcc/. -I ../../gcc-13.3.0/gcc/../include -I ../../gcc-13.3.0/
<PHONE_NUMBER> 1458918 09:08 00:00:00 /nix/store/kn1a1mn6h9zczn8d65i778dp3gfx5jnz-xgcc-13.3.0/bin/g++ -fPIC -O2 -U_FORTIFY_SOURCE -fzero-call-used-regs=used-gpr -fstack-protector-strong --param ssp-buffer-size=4 -fno-strict-overflow -march=z10 -std=c++11 -fno-PIE -c
<PHONE_NUMBER> 1618864 09:08 00:00:00 /nix/store/kn1a1mn6h9zczn8d65i778dp3gfx5jnz-xgcc-13.3.0/libexec/gcc/s390x-unknown-linux-gnu/13.3.0/cc1plus -quiet -I . -I . -I ../../gcc-13.3.0/gcc -I ../../gcc-13.3.0/gcc/. -I ../../gcc-13.3.0/gcc/../include -I ../../gcc-13.3.0/
<PHONE_NUMBER> 1458918 09:08 00:00:00 /nix/store/kn1a1mn6h9zczn8d65i778dp3gfx5jnz-xgcc-13.3.0/bin/g++ -fPIC -O2 -U_FORTIFY_SOURCE -fzero-call-used-regs=used-gpr -fstack-protector-strong --param ssp-buffer-size=4 -fno-strict-overflow -march=z10 -std=c++11 -fno-PIE -c
<PHONE_NUMBER> 1619292 09:08 00:00:00 /nix/store/kn1a1mn6h9zczn8d65i778dp3gfx5jnz-xgcc-13.3.0/libexec/gcc/s390x-unknown-linux-gnu/13.3.0/cc1plus -quiet -I . -I . -I ../../gcc-13.3.0/gcc -I ../../gcc-13.3.0/gcc/. -I ../../gcc-13.3.0/gcc/../include -I ../../gcc-13.3.0/
<PHONE_NUMBER> 1618357 09:08 00:00:00 /nix/store/bcr0i2gzw6kyrdvyz3bfj37x0kgxnwfd-binutils-patchelfed-ld-wrapper-2.42/bin/as -I . -I . -I ../../gcc-13.3.0/gcc -I ../../gcc-13.3.0/gcc/. -I ../../gcc-13.3.0/gcc/../include -I ../../gcc-13.3.0/gcc/../libcpp/include -I .

please note that the jobs nix-top shows may not be these that are listed above as between calling nix-top and looking at the nix build progress output some time passed but nix-top still doesn't seem to generate more useful output. As I see the following parts:
Summary per output
       9 → /tmp/nix-build-libusb-1.0.27.drv-0
       3 →
      13 →

 * * *

:: (nixbld1) → /tmp/nix-build-libusb-1.0.27.drv-0

I assume (nixbld1) →  to (nixbld-13) → ... should display the drv they are building but only really :: (nixbld1) → /tmp/nix-build-libusb-1.0.27.drv-0 seems to display anything
Im including a screenshot to compare the live output of nix-top with the nix build progress:

unless I am misusing this tool I assume for every nixbld user/job i should see one drv. While this tool is useful regardless as I can for example see the compileflags used before waiting for the build to finish like (march=z10) and can sort of derive whats being build by looking at the directories shown at times in the commands displayed, this doesn't feel like its really making use of the full potential this tool may have as then its just the ps command paired with grep and some curses-like tool to display it.

im including a second picture where just one drv is being build

as now
Summary per output
      14 →

 * * *

:: (nixbld13) →

is shown, as for some reason        9 → /tmp/nix-build-libusb-1.0.27.drv-0 like seen above does seem to point to a valid drv while the build job for [1/206/228 built, 0.0 MiB DL] building gfortran-13.3.0 (buildPhase) does not I am now convinced this isn't the intended behavior

just making sure: this also happens in the same ways as described above on x86 so not just s390x

maybe it has a problem with flakes? Though I doubt thats it I'd have to check though


A few small improvements

Feat: --block and --confirm flags to better emulate the default yazi shell.
Feat: Capitalise shell prompt.
Feat: Support for nushell.
Feat: Accept "Kornshell" or "ksh" as arguments.
Feat: Use default shell and not blocking by default.
Feat: Update LICENSE and README.
Refactor: General formatting.

I have an idea if you are thinking to implement special commands with keybindings. For example, let's keep : and ; as it is. I am using custom-shell with keybindings ["'", ";"] together. That way the default yazi is also usable.
We can let the users configure special commands with ["'", ""]. Like 'l will run say ls -la, etc.

Configure chars from 0-9,a-z seems enough. Keep the custom-shell current as it is with ';, with special commands can be configured for other keys.

The codes looks fine to me

The codes looks fine to me

I tested it locally and it works fine.

ill suggest changes in the readme before merging the changes within a day.

Please make the below changes

Let --confirm be true by default. Keep block available for true/false.
I'll change the readme myself according to the new codes. So no need to push the readme.

Done

Ok now it doesnt work for me at all. any of the commands in your fork's readme where the prompt is supposed to come, is not coming.

Correct. When --confirm is enabled, there is no prompt.

I am trying to fix it. Maybe have to change many things. If one thing, works other breaks. I'll respond in a day. If you solve it. Share the code, instead of a commit.

This behaviour is expected. set --confirm to false to see a prompt

Hey, I have been looking into various options myself, and it seems to make it generalised and stuff. Your original codes seemed great(sorry for the troubles). Also I have also looked into your fork, some more additions have been added. If you feel like creating a new PR, you are welcome to. Thanks


Add option to read Transformations from a file

Description
This PR adds the option for the Traffic Replayer to read the transformations from a file.
Check List

[ ] New functionality includes testing

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks for the comments @gregschohn!
All addressed in new commits.

I tested attempting #367 with the following TransformerConfig.json file:
[
  {"JsonJMESPathTransformerProvider": { "script": "{ \"settings\": settings, \"mappings\": payload.mappings.*.properties | [merge(@)] }"}}]

Results: can confirm that the above transformation does fix the bug. I was able to reproduce the bug without the transformation.


Allow listing pools based on stake instead of wallet id

Issue Number
#1720
Overview

[x] Make list stake pool endpoint take Coin instead of WalletId.
[x] Adjust corresponding types and tests (A few more I think)
[x] Fail with err400 when query param is not present on Shelley.
[x] Adjust swagger

Comments
Originally:
GET /stake-pools

What was recently introduced:
GET /wallets/:wid/stake-pools

Now:
GET /stake-pools?stake=1000

For jormungandr the query parameter is not required, and unused. This
minimises breaking changes.

Slack thread
This PR gives greater flexibility to Daedalus and other API users

bors try

bors r+

bors r+

bors try

bors r+


add failing test

This adds 2 failing tests for using reserved names (query and input). However, I think it's likely this issue is for all reserved words.

Thanks!


Retrieving Coin of the Day

Is it somehow possible to retrieve the "Coin of the day", which doesn't have to be the best Altrank or Galaxy Score coin per se?

Sure, what do you want to do with it?
https://lunarcrush.com/developers/api/coinoftheday


The system message that appears when someone requests to join a workspace isn't appearing correctly

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.50-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729117570646089
Action Performed:

Log in as user A
Go to workspace settings
Click "share" and copy the URL
Open the URL and login with different account user B
Log in back to user A and go to #admin room of the workspace

Expected Result:
System message should be user B requested to join user A workspace
Actual Result:
user B requested to join the workspace (invited by user A).
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
user B requested to join the workspace (invited by user A).
What is the root cause of that problem?
The action of this report Action is ACTIONABLEJOINREQUEST and we are not handling this action in the front-end.
What changes do you think we should make in order to solve the problem?

We should create new translation key for this action

        joinRequest: ({user, workspaceName}: {user: string, workspaceName: string} ) => ` ${user} requested to join ${workspaceName}`,

Create a util to get the join request message in ReportUtils

function getJoinRequestMessage(reportAction: ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST>) {
    return Localize.translateLocal('joinRequest', {user: ..., workspaceName: ...});
}

Do the same way as we do for other actions to add a case for the join request in other places

In ReportActionItem here
else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) {
    children = <ReportActionItemBasicMessage message={ReportUtils.getJoinRequestMessage(action)} />;
}

In OptionsListUtils.ts here
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) {
   return getJoinRequestMessage(parentReportAction);
}

In ContextMenuActions.tsx here
else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) {
     const displayMessage = ReportUtils.getJoinRequestMessage(reportAction);
     Clipboard.setString(displayMessage);

What alternative solutions did you explore? (Optional)

Rotating the label so we can assign another BZ member while I am OOO


Backwards compatibility with for missing **kwargs in Field

In #5029, the issue came up of what to do about renamed/removed keyword arguments to the Field function.
The decision there was to use **kwargs to provide as much backwards compatibility as possible, but to:

Use @overload to expose the method to type checkers / IDEs with a **kwargs-less signature
Emit a DeprecationWarning if any deprecated behavior is observed (i.e., use of renamed/eliminated keyword arguments)

I'm creating this issue for tracking purposes to make sure this is done before the v2 release.

Too old to be relevant, closing as not planned (or not relevant)

Closed by #5800


Simplified form pre-filling a bit.

@olivierteboul there is a bug with the time text generation however, let's sync tomorrow.

i sent you a fix already. thanks for catching it


Avoid exposing internal types in new VolumeChooser SPIs

For 2.0.0 new method were added to VolumeChooser that expose internal
types like ServerContext.  These types are very unstable and will
likely change alot in the future as we seek to remove static state
in Accumulo.  This PR introduces a simple SPI interface that exposes
some of the functionality of ServerContext in a more stable way.

@milleruntime and @ctubbsii I am finished making updates based on the comments that have been made so far.


Sentinel should have an API to encrypt (but not decrypt) a secret using Aegis Safe public key. — this way we can store the secret wherever we want, and let a CI pipeline talk to aegis by providing the encrypted secret instead.

Similar to what we have here http://vimeo.com/v0lkan/aegis-ops
but without all the GPG complexity, because Aegis Safe already knows how to encrypt stuff.
This will make it
a) less flexible
b) opinionated
b) but very practical.

Done.


SetGeometryShader(NULL) mandatory?

I've a question concerning Effects11. Until now I had the following compile statements in my techniques.
    SetVertexShader(CompileShader(vs_5_0, VS()));
    SetPixelShader(CompileShader(ps_5_0, PS()));

Now I have an effect which compiles a geometry shader. This seems to have a side effect. If I don't set SetGeometryShader(NULL) to all my other effects I get the following errors. Is this a bug or a feature? Does the same also apply to SetHullShader, SetDomainShader, ...?
    D3D11 ERROR: ID3D11DeviceContext::Draw: Vertex Shader - Geometry Shader linkage error: Signatures between stages are incompatible. The input stage requires Semantic/Index (COLOR,0) as input, but it is not provided by the output stage. [ EXECUTION ERROR #342: DEVICE_SHADER_LINKAGE_SEMANTICNAME_NOT_FOUND]
    D3D11 ERROR: ID3D11DeviceContext::Draw: Vertex Shader - Geometry Shader linkage error: Signatures between stages are incompatible. Semantic 'TEXCOORD' is defined for mismatched hardware registers between the output stage and input stage. [ EXECUTION ERROR #343: DEVICE_SHADER_LINKAGE_REGISTERINDEX]
    D3D11 ERROR: ID3D11DeviceContext::Draw: Vertex Shader - Geometry Shader linkage error: Signatures between stages are incompatible. The input stage requires Semantic/Index (TEXCOORD,1) as input, but it is not provided by the output stage. [ EXECUTION ERROR #342: DEVICE_SHADER_LINKAGE_SEMANTICNAME_NOT_FOUND]
    D3D11 ERROR: ID3D11DeviceContext::Draw: Geometry Shader - Pixel Shader linkage error: Signatures between stages are incompatible. Semantic 'TEXCOORD' is defined for mismatched hardware registers between the output stage and input stage. [ EXECUTION ERROR #343: DEVICE_SHADER_LINKAGE_REGISTERINDEX]
    D3D11 ERROR: ID3D11DeviceContext::Draw: The declared input primitive type in the current Geometry Shader does not match the current input topology. [ EXECUTION ERROR #360: DEVICE_DRAW_GS_INPUT_PRIMITIVE_MISMATCH]

The geometry shader is also compiled as gs_5_0:
    SetGeometryShader(CompileShader(gs_5_0, GS()));

    [maxvertexcount(4)]
    void PhongSurfelGS(point GSPS_INPUT sprite[1], inout TriangleStream<GSPS_INPUT> triStream)
    {
        GSPS_INPUT v;

        ...
    }

I had the same error when using DirectX::SpriteBatch. After adding the following line the error disappeared.
 deviceContext->GSSetShader(nullptr, nullptr, 0);
Notice: Currently, I am using a DirectXTK version which has VS2012 support.

That's expected. DirectXTK does not 'save & restore" state as that's quite expensive. Instead, I document the states it changes on the wiki.


use bullet points for the frontpage

rebased from #248.
While bullet points itself are already an improvement, we should make sure we put the key features concise there.
Ping @JackStouffer (you are familar with the D's feature overview, right?)

:+1:

LGTM sans comments

Rebased with feedback incorporated (thanks!) and added these two points:

multi-paradigm (imperative, structured, object oriented, generic, functional programming purity, and even assembly)
built-in error prevention (contracts, unittests)

How should we sort those points?
Should we provide links for these points?

Thanks!
1.) I do like the current sorting. IMO we can just leave it the way it i.
2.) I don't think that we need links for them. We provide already a lot of links throughout the tour and we touch a lot of the topics listed. So links would just visual overhead in my eyes.

1.) I do like the current sorting. IMO we can just leave it the way it i.

As I need this for the D-Man on the frontpage (and it's a clear improvement), I will go ahead and merge it.
Please feel free to open a PR to make it even better!

Yep nothing is set in stone :-)


SizeEstimation expose function dealing with raw scripts for UTXO

A new inspection was created.

A new inspection was created.

A new inspection was created.

The inspection completed: 2 updated code elements

The inspection completed: 2 updated code elements


error: 'H' format requires 0 <= number <= 65535

When I run my quantum machine learning algorithm on ibm quantum computer, I get:
error                                     Traceback (most recent call last)
 in <cell line: 270>()
268
269 # Optimize the parameters
--> 270 opt_result = optimizer.minimize(fun=lambda theta_flat: cost_function(theta_flat, num_qubits), x0=theta_flat)
271 optimal_theta = opt_result.x
272 optimal_value = opt_result.fun
...........
/usr/local/lib/python3.10/dist-packages/qiskit/qpy/binary_io/circuits.py in _write_instruction(file_obj, instruction, custom_operations, index_map, use_symengine, version)
686     num_ctrl_qubits = getattr(instruction.operation, "num_ctrl_qubits", 0)
687     ctrl_state = getattr(instruction.operation, "ctrl_state", 0)
--> 688     instruction_raw = struct.pack(
689         formats.CIRCUIT_INSTRUCTION_V2_PACK,
690         len(gate_class_name),
error: 'H' format requires 0 <= number <= 65535

Hi @tralala87, can you post a code snippet of how to reproduce this problem?

Closing. @tralala87 feel free to reopen if you encounter this issue again.


Rename plugin?

I wasted some time trying to figure out where the paper-* snippets were coming from so I could remove them from vscode.
If you could name your plugin in a way that indicates that this isn't just for pure handlebars, it might save other developers from having to go on similar searches.

I think I'm gonna remove those snippets from the extension. I don't think that was a good idea.

should be fixed now at 0.2.0


Added option to set the custom TextView ID

added option to set the custom TextView ID in method withCustomView() (updated javadoc) (here and here)
renamed mTextResId to mCustomResId (here)
added mCustomTextViewId property (here)
added public getContextView() to return the tooltip View (here)
fixed problem reported in #44 , now the arrow is generated in mView instead of mTextView (here and here and here)
changed target that receives the animation to TooltipViewImpl instead of "mTextView" (here and here)

Now, is possible to use any custom view, and the arrow will not appear only if "replaceBackground = true" or "withArrow = false"
Please, look to this PR and let me know if something is wrong.

Can you split the changes into multiple pull requests? So we can go through each one separately

The changes are dependent :(

First I added the option for set the TextView ID.
This caused problems with the animation, because only the TextView was animated. So I changed to animate full TooltipViewImpl.
If the background of the layout has the same color as the TextView, the arrow disappears. Because the arrow was created in TextView. So I changed to create in parent layout (mView).
I need retrieve the views out (via findViewById), so I created the getContentView

I dont know how I could split this. What do you think?

Ah ok, I thought they were separate features.
Why should you be able to specify the text id? I don't see any value on that.

In my case, I use a standard for naming IDs (only for good practice). However, if the user does not specify keeps android.R.id.text1
But the biggest problems were:

The animation happen only in TextView. If I put a custom layout with a TextView and a button, only the TextView would move, the button does not move.
And the problem with the Arrow, which also was known, and was explained in the documentation.

Please, feel free to evaluate the PR. If these changes are not interesting, I can use my Fork for now.

I think you should keep the fixed id for the textview. Give too much freedom to devs is not always a good thing and can just add more complexity to the app. Anyway, I don't have time now for evaluating the PR cause I'm leaving for vacation, but I'll do as soon I'll go back next week. thank you.

I appreciate your attention.
I'm a bit of urgency, I had to create my own implementation. :smile:
Sorry for taking your time. I'll look at your library again in the future.
Thank you


Typo

https://console.firebase.google.com/project/MY_PROJECT/functions/logs

@comerc if you're reporting a bug in the Firebase console please do it here:
https://firebase.google.com/support/troubleshooter/report/bugs

@comerc if you're reporting a bug in the Firebase console please do it here:
https://firebase.google.com/support/troubleshooter/report/bugs

😂

😂


Add URL to McThings project to the Scenes templates

Done, added to the template and to all scenes that exist now.


mace::MaceTensor constructor.

Why mace::Mace Tensor constructor need std::shared_ptr when can user float * ?.  mace::Mace Tensor not create data show it can't free it.
I build a RAII object to processing data use one memory for anytime processing.
https://stackoverflow.com/questions/6675651/when-should-i-use-raw-pointers-over-smart-pointers
P/S Sorry for my English.

It defends useful data not to be destroyed by users during mace run.


Fix language selection not retained across some screens IDVA3-1293

Screens: individual_statement, individualPscList, personal_code, psc_type

add hidden input to propagate lang on screen template where missing
add "?lang="+lang to button href on screen template -- to be replaced by future work

Other refactoring:

add test/ folder to file and folder naming rule checks
refactor /test files/folders to conform to naming rules
move eslint plugins to devDependencies section of package.json
tidy file globs in "lint" scripts of package.json

CI: No security warnings found

CI: No security warnings found


Cyclic term (display) error easy to see

v.2.33.53
?- Y = [[_|Y]].
   Y = [[_,.]]. % unexpected
?-

v2.34.0
$ tpl
?- Y = [[_|Y]], Y = [[Y|_]].
   Y = [[_|Y]]. % Do we expect Y = [[Y|Y]] here?

$ swipl;scryer-prolog
?- Y = [[_|Y]], Y = [[Y|_]].
Y = [[Y|Y]].
?- halt.
?- Y = [[_|Y]], Y = [[Y|_]].
   Y = [[Y|Y]].
?- halt.
$

Substituting named variables for the anons is easier to see what's going on...
$ scryer-prolog
?- Y = [[X|Y]], Y = [[Y|Z]].
Y = [[Y|Y]], X = [[Y|Y]], Z = [[Y|Y]].
~/trealla (devel) $ swipl -q
?- Y = [[X|Y]], Y = [[Y|Z]].
Y = X, X = Z, Z = [[Z|Z]].
~/trealla (devel) $ tpl
?- Y = [[X|Y]], Y = [[Y|Z]].
Y = [[X|Y]], X = [[X|Y]], Z = [[X|Y]].
~/trealla (devel) $ yap -q
?- Y = [[X|Y]], Y = [[Y|Z]].
Y=[[A|A]],
X=[[B|B]],
Z=[[[[C|C]],[D|D]]],
D=[[D|D]],
C=[[C|C]],
B=[[B|B]],
A=[[A|A]]
Yap is certainly very inventive.

Yep, easier.
$ tpl
?- ([[X|Y]]=[[Y|Z]])=A,A=(Z=X),A=(Z=Y),A=(X=Y).
   X = [[Y,[X|Y]]],
   Y = [[Y,[X|Y]]],
   Z = [[[[Y|Z]],[[.]|Z]]],               % [.]  unexpected
   A = ([[[[Y|Z]],[[.]|Z]]]=[[Y,[X|Y]]]). % [.]  unexpected

?- ([[X|Y]]=[[Y|Z]])=A,A=(Z=X),A=(Y=Z),A=(X=Y).
   X = [[[[X|Y]],[X,.]]],                 % [X,.] unexpected
   Y = [[[[Y|Z]]|Y]],
   Z = [[[[Y|Z]]|Y]],
   A = ([[[[Y|Z]]|Y]]=[[[[X|Y]],[X,.]]]). % [X,.] unexpected

Resolution found in Mariana's Web Level 9.

If you say so.

Why not keep a secret?
?- Y = [[Y|_]], Y = [[_|Y]].
   Y = [[Y|_A]].

It's something to do with how they're bound. Can't really tell how/why.
On Sun, Jan 21, 2024 at 1:44 PM flexoron @.***> wrote:

Why not keep a secret?
?- Y = [[Y|]], Y = [[|Y]].
Y = [[Y|_A]].
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/475#issuecomment-1902491913,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSESJYIUKVOJWCRTE2ZLYPSFKJAVCNFSM6AAAAABCCZVVU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGQ4TCOJRGM
.
You are receiving this because you commented.Message ID:
@.***>

Remindes me of Austrian Jodeller adores Germanic Mountain:
https://www.youtube.com/watch?v=3PqAppuqp6g


Release version 0.1.1

Coverage remained the same at 100.0% when pulling 56058f454f939ccf0453c67718c880575d72e602 on release/0.1.1 into e3d68479f8307c11bde6c91bbe46aa8cd9f14995 on master.


Update index.md

Why:

Closes [issue link]
What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (eg. a "before and after video")

Thanks for opening a PR! This is currently a reusable and making this change would break the reusable. I'm going to close this PR.
Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions or check out issues with the help wanted label. :sparkles:


Set up automatic deployments

https://docs.travis-ci.com/user/deployment/cargo/, https://docs.travis-ci.com/user/deployment/releases/

Added I think in 0.3


Colorized the short Warnings/Errors generated by the toolchains

These commits add colorization to all of the short form Warning and Error messages generated by the compiler when the --color switch is provided on the command line. The default colorization will make Warnings Yellow and Errors Red, but can be changed by the user, in mbed_settings.py if they find yellow and red unreadable or ugly.
Affects these top level scripts:

build.py
make.py
test.py

Therefore the mbed subcommands compile, and test are also affected.

cc @bogdanm @screamerbg @0xc0170 @sg-

Don't like the colorama dependency in utils.py. Why not handle notify function/output and colorize from there?

I could. I assumed that it could be a more general purpose colorization function and used in more than just the toolchains.

Don't merge yet. New implementation coming.

Implementation will be: add option to options.py to add colorization; use that option to replace the notification function within the toolchains through the constructor.

The implementation is much better now, but still changes something in tools/toolchains/init.py, which I don't like.

What did you test this on? Doesn't work in my Linux console:
Building project blinky (K64F, GCC_ARM)
Compile: main.cpp
[.31m[Error] main.cpp@4: 'ds' does not name a type
[.0m[.33m[Warning] main.cpp@17: 'rtos::Thread::Thread(void (*)(const void*), void*, osPriority, uint32_t, unsigned char*)[...]
[.0m./main.cpp:4:1: error: 'ds' does not name a type

My TERM is set to xterm (and is fully capable of doing color output).

...and the same thing happens in Windows (cmd.exe). :-1:

@bogdanm: I tested it Xterm (echo $TERM is xterm), URxvt (echo $TERM is rxvt-unicode), and windows cmd.exe (echo $TERM is $TERM :smile:).
before Replace color definitions...:
URxvt gets color, xterm gets no color, cmd.exe gets no color. However, I do not see the escape codes.
After:
URxvt gets color, xterm gets color, cmd.exe still no color. I still don't see escape codes.

@theotherjimmy Would you be so kind and add meaningful description to this PR ? See [here]9https://github.com/PrzemekWirkus/mbed/blob/docs/docs/COMMITTERS.md#pull-request)

@PrzemekWirkus Thank you for the friendly reminder. Please find a description of what this PR adds to our tools in the first comment.

Thanks, Jimmy.
+1
@bogdanm can you confirm that the latest version works for you?

Linux: it works partially. Warnings like the one below are shown in the proper color:
[Warning] RTX_CM_lib.h@681: implicit declaration of function 'atexit' [-Wimplicit-function-declaration]

Errors are more problematic. For the error below:
Compile: main.cpp
[Error] main.cpp@4: 'ds' does not name a type
[Warning] main.cpp@17: 'rtos::Thread::Thread(void (*)(const void*), void*, osPriority, uint32_t, unsigned char*)' is deprecated (declared at ./mbed-os/core/rtos/rtos/Thread.h:138): Thread-spawning constructors hide errors and may lead to complex program state when a thread is declared [-Wdeprecated-declarations]
[Error] main.cpp@20: 'led1' was not declared in this scope
./main.cpp:4:1: error: 'ds' does not name a type
 ds
 ^
./main.cpp: In function 'int main()':
./main.cpp:17:30: warning: 'rtos::Thread::Thread(void (*)(const void*), void*, osPriority, uint32_t, unsigned char*)' is deprecated (declared at ./mbed-os/core/rtos/rtos/Thread.h:138): Thread-spawning constructors hide errors and may lead to complex program state when a thread is declared [-Wdeprecated-declarations]
     Thread thread(led2_thread);
                              ^
./main.cpp:20:9: error: 'led1' was not declared in this scope
         led1 = !led1;
         ^
[ERROR] ./main.cpp:4:1: error: 'ds' does not name a type
 ds
 ^
./main.cpp: In function 'int main()':
./main.cpp:17:30: warning: 'rtos::Thread::Thread(void (*)(const void*), void*, osPriority, uint32_t, unsigned char*)' is deprecated (declared at ./mbed-os/core/rtos/rtos/Thread.h:138): Thread-spawning constructors hide errors and may lead to complex program state when a thread is declared [-Wdeprecated-declarations]
     Thread thread(led2_thread);
                              ^
./main.cpp:20:9: error: 'led1' was not declared in this scope
         led1 = !led1;
         ^

the first 4 lines are properly colorized, the others are shown in the regular color. Also, I have a linker error that's not being colorized at all.
I don't consider any of the above to be a blocker for merging this PR. We can improve it later.
I'm going to test in Windows and come back with the results in a separate comment.

I can see the exact same behaviour in Windows, which is a good thing.
Conclusion: not yet complete, but ready to be merged in as far as I'm concerned. :+1:

@bogdanm, Yep, only the short form of the Warnings/Errors are colorized at the moment. It should be possible to build on this PR to make a more complete colorization in the future.


conversationalRetrievalChain - how to set the template

Issue you'd like to raise.
I am using conversationalRetrievalChain. I cannot seem to change the system template. Any suggestion how to do this?
retriever = vectorstore.as_retriever(search_kwargs={"k": source_amount},  qa_template=QA_PROMPT, question_generator_template=CONDENSE_PROMPT)
qa = ConversationalRetrievalChain.from_llm(llm=model, retriever=retriever, return_source_documents=True)
When printing QA:
[SystemMessagePromptTemplate(prompt=PromptTemplate(input_variables=['context'], output_parser=None, partial_variables={}, template="Use the following pieces of context to answer the users question. \nIf you don't know the answer, just say that you don't know, don't try to make up an answer.\n----------------\n{context}", template_format='f-string', validate_template=True), additional_kwargs={}), HumanMessagePromptTemplate(prompt=PromptTemplate(input_variables=['question'],
Whatever I try, I seem to be unable to change the template "Use the following pieces of context to answer..."
Suggestion:
No response

QA_PROMPT = PromptTemplate()
combine_docs_chain_kwargs={'prompt': QA_PROMPT}

Indeed, just figured it out 5 minutes ago
`        system_template = """End every answer with "Ahoi Matey I love you". Use the following pieces of context to answer the users question.
If you cannot find the answer from the pieces of context, just say that you don't know, don't try to make up an answer.
----------------
{context}"""
    # Create the chat prompt templates
    messages = [
    SystemMessagePromptTemplate.from_template(system_template),
    HumanMessagePromptTemplate.from_template("{question}")
    ]
    qa_prompt = ChatPromptTemplate.from_messages(messages)`

and then
qa = ConversationalRetrievalChain.from_llm(llm=model, retriever=retriever, return_source_documents=True,combine_docs_chain_kwargs={"prompt": qa_prompt})

Author

I am facing similar error. Can you share a little bit more of a code, please?
What is st.write here?

I am not able to use memory in the above piece of code. Can someone suggest any ideas?

@DennisPeeters  can you tell me what will go inside the context? please as I  got suck there for 2 days If can response early I would be greatful

@DennisPeeters Can you what should be the syntax to get the prompt of conversational retrieval chain

Hi sorry for not replying, been very busy and as I said above, I am not a developer.
So lets try @Srishti2002-jai - do you get any error? Can you share some of your code? What are you trying to do?

The context is loaded automatically from qa I think. The st.write is because i am using streamlit

You can custom the prompt, this is the reference
https://js.langchain.com/docs/modules/chains/index_related_chains/conversational_retrieval

general_user_template = "Question:{question}"
messages = [
SystemMessagePromptTemplate.from_template(prompt),
HumanMessagePromptTemplate.from_template(general_user_template)
]
qa_prompt = ChatPromptTemplate.from_messages( messages )
qa = ConversationalRetrievalChain.from_llm(
model,
vectordb.as_retriever(),
memory=memory,
chain_type="stuff",
return_source_documents = True,
combine_docs_chain_kwargs={'prompt': qa_prompt}
)
PLEASE CAN SOMEONE HELP ME START THE CONVERSATION? I'm getting this error when using qa.run(question) : run` not supported when there is not exactly one output key. Got ['answer', 'source_documents'].


Implement batched writing

ATM, writes to a remote server must be staged locally and then all new data gets sent up on commit. This is wasteful in at least two directions and, in particular, slows down sync.
Needs clear design.
Blocked by:

https://github.com/attic-labs/noms/issues/2640
https://github.com/attic-labs/noms/issues/3178

So I think the abstract design for this is basically to "pull" the way NBS works across the wire. That is, and open NBS store is basically a transaction. Before commit (UpdateRoot/Flush) writes are buffered to memtable and then flushed to file tables, the in memory manifest keeps reference to all novel tables, but doesn't update the durable manifest (i.e. such that other readers can see this tx's work) until commit.
The idea with batched writing would be similar. Strawman:

writeValue becomes "write a new table, persist it, but don't include it in the manifest", the call would return the name (hash) of the table
UpdateRoot/Flush would be required to include the set of novel tables to include in the operation.

There are two challenges to making this work

The commit stage needs to ensure validity of the database. This would happen in two parts:
a) Individual chunks will be integrity checked.
b) During commit, the server must insure completeness of all new values. The approach would be to process the novel tables and use the new lazy completeness validation to ensure there are no dangling references.

GC. Since we don't have a design yet for GC, we just need to be sure that the design for batch writing doesn't back us into a corner.

WRT (1), there are some choices around when (a) is done and whether some amount of work for (b) is preprocessed (i.e. for each novel table, keep a record somewhere of unresolved references, so as to avoid commit needing to fetch and process all of the tables)

One thing we should do as a part of this is have the call to write a table return the set of dangling refs (if any). This way, sync can avoid writing a bunch of chunks, and immediately call back with basically the same data asking about hasMany


Enable ssh-agent support for secure connection

Suggestion which works fine in our case:
'key' => getenv('HOME') . '/.ssh/id_rsa',
'agent' => !empty(getenv('SSH_AUTH_SOCK')),

This way the agent is only used if it is active as indicated by the SSH_AUTH_SOCK environment variable. For other cases the private key is used.


refactor refactor broker reading process to avoid null broker connection

Proposed changes
issue: #26052
Move the RPC to broker related operations into BrokerFileSystem, and should not expose the connection to the reader.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


Allow MIMO in ops

Signed-off-by: Kaiyuan Hu<EMAIL_ADDRESS>

Codecov Report

Merging #844 (4bc388c) into main (aa1a4e3) will increase coverage by 0.10%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   70.99%   71.09%   +0.10%
==========================================
  Files         185      185
  Lines        8196     8235      +39
  Branches     1340     1350      +10
==========================================
+ Hits         5819     5855      +36
+ Misses       1980     1979       -1
- Partials      397      401       +4

Impacted Files
Coverage Δ

towhee/__init__.py
83.80% <86.66%> (-0.05%)
:arrow_down:

towhee/trainer/trainer.py
67.70% <0.00%> (-0.19%)
:arrow_down:

towhee/trainer/training_config.py
82.20% <0.00%> (+0.15%)
:arrow_up:

towhee/trainer/utils/trainer_utils.py
65.38% <0.00%> (+0.32%)
:arrow_up:

towhee/hub/repo_manager.py
81.08% <0.00%> (+0.90%)
:arrow_up:

towhee/trainer/optimization/optimization.py
34.32% <0.00%> (+2.02%)
:arrow_up:

towhee/trainer/utils/visualization.py
89.71% <0.00%> (+2.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1a4e3...4bc388c. Read the comment docs.

The unit test should cover:
ops.towhee.test_op["in", "out"]()(e)

ops.towhee.test_op["in", ("out1", "out2")]()(e)

ops.towhee.test_op[("in1", "in2"), "out"]()(e)

ops.towhee.test_op[("in1", "in2"), ("out1", "out2")]()(e)

/lgtm
/approve


Incorrect insufficent funds error on dApp connector.

https://github.com/input-output-hk/lace/blob/35bfd44b1351e41d68fad6886915354ecee4cdc2/apps/browser-extension-wallet/src/features/dapp/components/ConfirmTransaction.tsx#LL192C1-L198C8
Here, it makes an assertion:
      if (totalCoins >= availableBalance?.coins) {
        setInsufficientFunds(true);
      }

which is incorrect as it doesn't consider transaction inputs from scripts.
It should be
      if (totalCoins >= availableBalance?.coins + <TxInputs>) {
        setInsufficientFunds(true);
      }

Probably something like this:
    const totalInputs = tx.body.inputs.reduce((acc, txIn) => txIn.value.coins + acc);
    const externalOutputs = tx.body.outputs.filter((output) => output.address !== walletInfo.address);
    let totalCoins = BigInt(0);

    // eslint-disable-next-line unicorn/no-array-reduce
    const txSummaryOutputs: Wallet.Cip30SignTxSummary['outputs'] = externalOutputs.reduce((acc, txOut) => {
      // Don't show withdrawl tx's etc
      if (txOut.address.toString() === walletInfo.address.toString()) return acc;
      totalCoins += txOut.value.coins;
      if (totalCoins >= availableBalance?.coins + totalInputs) {
        setInsufficientFunds(true);
      }

It's not tested, I don't have dev environment up and running

@mchappell - this one's from June 2023, LW-8590 is completed, what should happen to this issue?
JON P

This has been completed, merged, and released. Closing this issue


Controller, template and styles for PDF generation

This pull request introduces:

[x] A controller and view for PDFs. View is currently populated with 'dummy' instance variables pending them being linked to actual data. Also introduces SASS stylesheets for the template and associated entries in the locale file for labels etc.
[x] Populates the document using the escorts data
[X] A preview button
[x] Generates a PDF containing ID data from previous step/ticket
[x] URL matches /escort/:id/preview

@dan-palmer @cesidio I'll need some help with the two remaining tasks. Thanks.

Input screen showing 'Preview PER' link

Hi @gtvj  ,
The new PDF generation is a bit broken and needs to be fixed up, as the photo to be attached now goes below the other form controls. Also if the form elements are empty they have a lower height.
Thanks

All styling changes etc. now added and rebased with master. Suggest we merge this pull request now.


Add offsetInBytes as property to typed lists

To create read-only copies of a Uint8List, the view constructor is more efficient than creating a sublist. However, if the viewed list itselfe was created by viewing a buffer, the list index and the underlying buffer index do not necessarily match. Viewing this list again to create a new one might result in unexpected behaviour. Consider the following code:
Uint8List base=new Uint8List.fromList(new List<int>.generate(10, (int index)=>index));
print(base);
Uint8List first=new Uint8List.view(base.buffer,1);
print(first);
print(first.buffer==base.buffer);
Uint8List second=new Uint8List.view(first.buffer,1);
print(second);
print(second.buffer==first.buffer);

will produce this result
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
[1, 2, 3, 4, 5, 6, 7, 8, 9]
true
[1, 2, 3, 4, 5, 6, 7, 8, 9]
true

even if you might expect line 4 to yield
[2, 3, 4, 5, 6, 7, 8, 9]

To overcome this, a typed list could know its offsetInBytes relative to the underlying buffer. If I then view this list again, I can then manually add offsetInBytes to the index I want to view.

Thanks for the answer, how could I've overseen that 😅


Added a simple memes app which used the concept of API calls

Description

This is a simple memes app which uses the concept of API calls using a volley library. This is a beginner friendly app that uses core concept of API.
Type of Change:

Android application added

Technologies and Libraries Used :

API Calls
Volley Library
Glide Library

Checklist:

[✔] My PR follows the style guidelines of this project
[✔] I have performed a self-review of my own code or materials
[✔] My branch is up-to-date with the Upstream development branch
[✔] I have added necessary images/screenshots of my changes

Screenshots
https://user-images.githubusercontent.com/87534228/138355174-51eff5ef-7c3a-4fbb-9942-d1684ea73d02.mp4
Comments
Please review by PR and let me know in case of any conflicts and I will resolve them.
If found useful, please label my PR as hacktoberfest-accepted. It would be appreciated.

Hey @AkshaiBaruah your app files/folder are not visible in this PR, also verify and review working of your app before sending PR
Go through contributing.md for contributions
Thanks!


shimdiag: New tool to diagnose runhcs shims

Currently this tool allows listing running shims and execing a process
in the shim's associated utility VM.

LGTM

Dude you merged this without fixing what we talked about.... I will submit a follow-up


gdtoolkit: init at 3.3.1

Motivation for this change
Add package https://github.com/Scony/godot-gdscript-toolkit
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The code looks good :blush:
Just a few issues with the commits, could you rename them to something like this?
* maintainers: add shiryel # first
* gdtoolkit: init at 3.3.1 # second

That way you can also include the meta.maintainers addition in the original commit, since we want to have every commit building/abiding guidelines.


lower number of procs on factotum

Is your feature request related to a problem? Please describe.
factotum is experiencing the occasional oom error when certain memory-intensive jobs are run in queues with a high value for numprocs in supervisord.conf
Describe the solution you'd like
make the following updates:

set factotum-job_worker-large to numprocs=16
set factotum-job_worker-standard_product-completeness_evaluator to numprocs=5

updated values in /export/home/hysdsops/.sds/files/supervisord.conf.factotum on mozart and /data/export/home/hysdsops/verdi/etc/supervisord.conf on factotum.


🍒 Cherry pick PR #6366 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/6366 to staging 🍒

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.15-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Document what parts of BuildStream / plugins depend on host packages

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Apr 10, 2018, 15:22
AFAIK, we depend on

host's ssh to push to the bst cache
host's bubblewrap for sandboxing
host's ostree for caching artifacts

Also, this plugins:

patch depends on host's patch
tar depends on host's lzip
git depends on host's git
bzr depends on host's bzr

In GitLab by [Gitlab user @jjardon] on Apr 12, 2018, 18:15
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 12, 2018, 18:20
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 12, 2018, 18:21
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 11:11
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 11:13
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 14:52
mentioned in merge request !406

In GitLab by [Gitlab user @jjardon] on Jun 10, 2018, 21:23
mentioned in merge request !495

In GitLab by [Gitlab user @jjardon] on Jun 11, 2018, 23:54
mentioned in commit f70ca7a3e3f210267937b6604399001f01fb4784

In GitLab by [Gitlab user @jjardon] on Jun 11, 2018, 23:54
mentioned in commit b1b1f64a7dd843ef03c574bce98a60f794e8a654

In GitLab by [Gitlab user @jjardon] on Jun 11, 2018, 23:54
mentioned in commit 0bed777b3e1af9b69f7a955cf8a006e320d6d899

In GitLab by [Gitlab user @jjardon] on Jun 11, 2018, 23:54
mentioned in commit 1e17ab8fbf6ae1cd3d49413327f3cb60ecea3455

In GitLab by [Gitlab user @jjardon] on Jun 11, 2018, 23:54
mentioned in commit 0ff544fed28b2481ddb3038024080ff761864f57

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:44
mentioned in commit 0e4dad21e7d8709f7c19e0731ead3b7013f2cb6f

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:44
mentioned in commit 1aa6e08277fbe57389ad4a558c5cd8f0985d6856

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:44
mentioned in commit 9f2f4e2c909a184fda3fb2099c7032e8c480b9fd

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:44
mentioned in commit d0a333995df93130da96ee8ad12e5147e829eaf2

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:44
mentioned in commit bbe718748fe5cfe00c441abd1dec6af5c14a1d34

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:46
mentioned in commit bbb17b6f168f2b84da1220584747dba77ba002bd

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:46
mentioned in commit fea856dd8ad17baf478dd6818e922328d5b7ccf2

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:46
mentioned in commit 2c94faf827a94357b467334c6e007322fd74e45c

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:46
mentioned in commit 0396d804f8698179e07aac8c67e8b4d6fae4e4e8

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:46
mentioned in commit fc103f0a1ae78626a3a11ba038dd7b84ef1841a7

In GitLab by [Gitlab user @jjardon] on Jun 21, 2018, 19:47
changed the description

In GitLab by [Gitlab user @tristanvb] on Jun 22, 2018, 18:00
changed title from Document what parts of Build{-s-}tream / plugins depend on host packages to Document what parts of Build{+S+}tream / plugins depend on host packages

In GitLab by [Gitlab user @jjardon] on Jun 22, 2018, 18:09
mentioned in commit e90098e0e0decbd40f8e1980772d921e7843b8ab

In GitLab by [Gitlab user @jjardon] on Jun 22, 2018, 18:09
mentioned in commit b5d917940d79b859c7ebab0d25f512a805647b25

In GitLab by [Gitlab user @jjardon] on Jun 22, 2018, 18:09
mentioned in commit 3b1e869bd8c64750a2e725a523acd55dc8e94360

In GitLab by [Gitlab user @jjardon] on Jun 22, 2018, 18:09
mentioned in commit be92cc8d7ff2dafee1a15b07a43802be01d5ad5a

In GitLab by [Gitlab user @jjardon] on Jun 22, 2018, 18:09
mentioned in commit 7d97c6d3f3d59cf078df3bedd178e7977868d9d5

In GitLab by [Gitlab user @tristanvb] on Jun 23, 2018, 01:08
This is closed by !495 (landed as a part of !516).

In GitLab by [Gitlab user @tristanvb] on Jun 23, 2018, 01:08
closed


Update README.md

Added a call to action - follow me experimenting!

Less detail next time. Thanks


Trimmed selector string before parsing

What
Fixed regression where a selector with leading whitespace caused a JsonParseException.
How
Trimmed selector string before parsing.
Testing
Added a new test testNotNullIndexMovieNameAndYearSelectorStringWithSpace with whitespace at the start (and within) the selector string.
Reviewers

+1, probably put 3d5c335 first and squash 3073ecf and 908e646 together into a single commit (or perhaps just squash them all together).


Remove redundant wheel dependency from pyproject.toml

Remove the redundant wheel dependency from pyproject.toml.  All
setuptools version automatically expose the dependency via the PEP517
backend since day one.  Listing it explicitly in build requirements
was a documentation mistake that was fixed in:
https://github.com/pypa/setuptools/commit/f7d30a9529378cf69054b5176249e5457aaf640a

thanks


IOS8 Physical Device Support

Addresses issue #384 and #369 errors when attempting to run iOS8 on a physical device, and broadens the recognized versions.
Also, changes the location of log file to where it unpacks other needed files.

@mmmulani Could you take a look at this request too?

👍🏾


create infra deployment

TODO: when to git clone the other repository
Run ansible playbopok
Store kubeconfig in the agreed folder structure

Created the code that invokes the playbook, and fetch the kubeconfig' details from playbook's output , fixed some bugs and now testing the integration of the new cluster with the app deployment.

Finished silent demo recording of exporting-->provisioning-->deploying.

Task Completed after thorough tests and complete demo of the whole steps in the procedure


Move visualization from r-ldavis for pyLDAvis

https://github.com/bmabey/pyLDAvis
fixes #22

Fixed in #31


Recording Video with two Audio Inputs

I am recording a control in my app and get audio from the speakers as input, but I want also to get audio from the microphone but I can't add other audio source to the Recorder
Can we use MixingSampleProvider but I tried ,but I couldn't implement it here in Screna
`           audioSource = new LoopbackProvider(LoopbackProvider.DefaultDevice);
Point locationFromScreen = myControl.PointToScreen(new Point(0, 0));
PresentationSource source = PresentationSource.FromVisual(myControl);
Point targetPoint = source.CompositionTarget.TransformFromDevice.Transform(locationFromScreen);
        int videoWidth = (int)wbDashboard.ActualWidth;// (int)(1.5 * wbDashboard.ActualWidth + 24);

        int videoHeight = (int)wbDashboard.ActualHeight;

        System.Drawing.Size videoSize = new System.Drawing.Size((2 - videoWidth % 2) + videoWidth, (2 - videoHeight % 2) + videoHeight);

        System.Drawing.Rectangle rect = new System.Drawing.Rectangle(new System.Drawing.Point((int)targetPoint.X, (int)targetPoint.Y), videoSize);

        var imgProvider = new RegionProvider(rect);
        var encoder = AviCodec.MotionJpeg;
        //var encoder = AviCodec.Xvid;
        bool x264Exist = false;
        foreach (var codecInfo in SharpAvi.Codecs.Mpeg4VideoEncoderVcm.GetAvailableCodecs())
        {
            if (codecInfo.Codec == SharpAvi.KnownFourCCs.Codecs.X264)
            {
                x264Exist = true;
                break;
            }
        }
        if (x264Exist)
        {
            encoder = AviCodec.X264;

            Microsoft.Win32.RegistryKey myKey = Microsoft.Win32.Registry.CurrentUser.OpenSubKey("SOFTWARE\\GNU\\x264", true);
            if (myKey != null)
            {
                myKey.SetValue("zerolatency", "1", Microsoft.Win32.RegistryValueKind.DWord);
                myKey.SetValue("log_level", "0", Microsoft.Win32.RegistryValueKind.DWord);
            }
            myKey.Close();
        }
        _recorder = new Recorder(videoWriter, imgProvider, 10, audioSource)`

Hi! Capturing both input and output audio has been implemented using BASS.
You can see the code in Screna.Bass folder. It is not released on NuGet for now.
As an example you can see Captura.

Thanks @MathewSachin, I will check it


fix(cancelled order message): cancelled order status now works

Pull Request

Description
Now the 4 statuses of an order work to notify

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[X] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality
to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

Task linked: CU-8689x4y8r BUG - The message status: Cancelled Order is not sent.

When the status is 0, I should send the pending, but it sends me the confirmation email


Bad certificates on local websites: **.creativecommons.org

Bad certificate on:
it.creativecommons.org
es.creativecommons.org
fr.creativecommons.org
strangely enough, some seem to work, such as:
de.creativecommons.org

@robmyers @little-wow

Thank you for reporting this! I will look into it.

No one has been assigned to this since september 7th. Anyone?

not sure why @TimidRobot closed this this issue, since there are still bad certs.


Making ETCD component High Availability

Updating ETCD replicas to be set to 3, making it HA.
Adding an anti-affinity to the ETCD component.

@DharmitD unfortunately this won't work. etcd requires specific configuration to be deployed as a cluster, including a shared filesystem. See https://etcd.io/docs/v3.5/op-guide/clustering/.
See also this comment: https://github.com/kserve/modelmesh-serving/issues/210#issuecomment-1215186679

@DharmitD unfortunately this won't work. etcd requires specific configuration to be deployed as a cluster, including a shared filesystem. See https://etcd.io/docs/v3.5/op-guide/clustering/.
See also this comment: #210 (comment) and discussion in this issue #249.

Thanks for pointing this out @njhill , closing this PR as we don't satisfy the mentioned pre-requisites for etcd to be HA.


ResizeImage reduces image quality and makes it blurry

I have recently added ResizeImage to my application to optimize performance of the app but it not only reduces the quality of the images but it makes them blurry too. Can anyone explain to me how to avoid that but still have that optimization?
For example here is one place where i used it on asset image:
 ` AspectRatio(
                      aspectRatio: 4 / 3,
                      child: ClipRRect(
                        borderRadius: languages.direction == 'rtl'
                            ? BorderRadius.only(topRight: Radius.circular(7), bottomRight: Radius.circular(7))
                            : BorderRadius.only(topLeft: Radius.circular(7), bottomLeft: Radius.circular(7)),
                        clipBehavior: Clip.hardEdge,
                        child: Image(image: ResizeImage(AssetImage('assets/images/noimage.jpg'), width: 133),fit: BoxFit.cover),
                      ),`

And here is the comparison of the images with and without using ResizeImage taken from my phone: https://ibb.co/26JVcpW

Is there any solution for fixing it? Thanks in advance :)

Any updates on this one please?

I'm not sure what you were expecting.
ResizeImage decodes the image with the specified dimensions instead of the native image size. This will lose detail. The further your specified dimensions are from the original dimensions, the worse your image will look, especially if then scaled up to a larger image size. Think of downloading a desktop wallpaper with dimensions of 1240x698 and then scaling them up to 1920x1080. This will look worse than downloading the wallpaper with 1920x1080 to begin with.
I don't think this is an issue with Flutter.

@VladanRandjelovic did you took into account devicePixelRatio ?
If you have an image which width is 133, you should pass 133 x devicePixelRatio to ResizeImage in order to prevent image to be blurry. Image widget sizes are in dp, ResizeImage sizes are in pixels.


[Feature request] DL by Group/folder ID

Prerequisites

[x] Did you read FAQ section?n yes
[x] Did you test with the latest releases or commit ? yes

Description
Hi,
Sry for my english and my stupidity, can you add features:
"Download new illust from boukmarked memmbers by Group/folder ID "
Exemple by Personal link for group/folder: "AD"
https://www.pixiv.net/bookmark_new_illust.php?tag=AD
Cordialement,
Eiv
Versions
PixivUtil20180607

I don't think https://www.pixiv.net/bookmark_new_illust.php?tag=AD has a tag parameter.
Do you means https://www.pixiv.net/bookmark.php?tag=AD? You can use option 6. Download from bookmarked images (/bookmark.php)

Sorry, poorly expressed, I seek to download the new illustrations of my follow-ups. But only those in a folder, for not having rescan all the files that I already download and only retrieve the news.
and the option work see: https://i.imgur.com/y7tlcAC.png

I see, somehow I don't have it in my pixiv account. Is it premium feature?

Hooo yes is premium ^^" feature https://i.imgur.com/z8ya7JX.png


Search function in connection overview

In this overview, the connections quickly add up:

In order to make it easier to find your database, add a search bar that searches on connection name.
Also, the styling could be a little bit better here (overflowing database name in the panel) :P

Yeh me and frontend (especially CSS) are still not great friends sometimes. I will try fix this.
Took the search bar into the feature list for 0.5 although by now it's unlikely that every feature makes it.
I think this one should not be so difficult.

I fixed the styling in #168 at least. Search probably next week.

Also merged the search bar now in #175 :D


Bare-Metal kubernetes-Cluster is unable to handle TLS-termination with istios 1.6.2

Bug description
Creating a simple Hello-World container with http returning only a textfile will be accessible via http curl --verbose http://domain.com will yield the text-file-content.
Trying this with https leads to a preemptive termination. IMHO The SSL-Cert is not found.
This is a new cluster so I will give the setupsets here as well.
From Kiali it looks like the https-requests are neither arriving at the pod nor appears there to be a route.

% istioctl install --set values.gateways.istio-ingressgateway.sds.enabled=true --set components.telemetry.enabled=true --set addonComponents.grafana.enabled=true --set values.grafana.enabled=true --set values.kiali.enabled=true --set "values.kiali.dashboard.grafanaURL=http://grafana:3000"  --set components.citadel.enabled=true --set components.citadel.enabled=true &&
kubectl apply -f https://raw.githubusercontent.com/cilium/cilium/master/install/kubernetes/quick-install.yaml &&
kubectl apply -f https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.3.6/components.yaml &&
kubectl apply -f https://raw.githubusercontent.com/metallb/metallb/v0.9.3/manifests/namespace.yaml &&
kubectl apply -f https://raw.githubusercontent.com/metallb/metallb/v0.9.3/manifests/metallb.yaml &&
kubectl create secret generic -n metallb-system memberlist --from-literal=secretkey="$(openssl rand -base64 128)" &&
kubectl create secret tls domain-wildcard --key=domain.com.pem.key --cert=domain.com.pem.crt -n istio-system

% kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.4", GitCommit:"c96aede7b5205121079932896c4ad89bb93260af", GitTreeState:"archive", BuildDate:"2020-06-20T07:41:29Z", GoVersion:"go1.14.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:43:34Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

% istioctl version --remote
client version: 1.6.2
control plane version: 1.6.2
data plane version: 1.6.2 (2 proxies)

Pod-VirtualService-Service-Gateway-configuration

apiVersion: apps/v1
kind: StatefulSet
metadata:
name: httpdtest
labels:
run: httpdtest
spec:
replicas: 1
serviceName: "httpdtest-service"
selector:
matchLabels:
run: httpdtest
template:
metadata:
labels:
run: httpdtest
spec:
imagePullSecrets:
- name: regcred
containers:
- name: httpd
image: domain/httpdhelloworld:1
imagePullPolicy: Always
ports:
- containerPort: 80
dnsConfig:
searches:
- default.svc.cluster.local
- svc.cluster.local
- cluster.local

apiVersion: v1
kind: Service
metadata:
name: httpdtest-service
labels:
name: httpdtest-service
spec:
selector:
run: httpdtest
ports:

protocol: TCP
port: 80
targetPort: 80
name: http
protocol: TCP
port: 443
targetPort: 80
name: https

apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: mygateway
spec:
selector:
istio: ingressgateway # use istio default ingress gateway
servers:

port:
number: 443
name: https
protocol: HTTPS
tls:
mode: SIMPLE
credentialName: domain-wildcard # must be the same as secret
hosts:

"*"

port:
number: 80
name: http
protocol: HTTP
hosts:

"*" #wildcard or the correct domains does not matter

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: httpd
spec:
hosts:

"domain"
gateways:
mygateway
http:

name: httpdtest-http
route:

destination:
port:
number: 80
host: httpdtest-service

name: httpdtest-https
route:

destination:
port:
number: 443
host: httpdtest-service

Curl commands

% curl --verbose domain.com

Trying xxx.xxx.xxx.xxx:80...
Connected to domain.com (xxx.xxx.xxx.xxx) port 80 (#0)

GET / HTTP/1.1
Host: domain.com
User-Agent: curl/7.70.0
Accept: /

Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< date: Sat, 27 Jun 2020 21:54:23 GMT
< server: istio-envoy
< last-modified: Sat, 27 Jun 2020 05:58:55 GMT
< etag: "d-5a90a855105c0"
< accept-ranges: bytes
< content-length: 13
< content-type: text/html
< x-envoy-upstream-service-time: 22
<
HELLO WORLD
Connection #0 to host domain.com left intact

% curl --verbose https://domain.com

Trying xxx.xxx.xxx.xxx:443...
Connected to domain.com (xxx.xxx.xxx.xxx) port 443 (#0)
ALPN, offering h2
ALPN, offering http/1.1
successfully set certificate verify locations:
CAfile: /etc/ssl/certs/ca-certificates.crt
CApath: none
TLSv1.3 (OUT), TLS handshake, Client hello (1):
OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to domain.com:443
Closing connection 0
curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to domain.com:443

SSL-Certificate

% echo | openssl s_client -showcerts -servername domain.com -connect domain.com:443 2>/dev/null | openssl x509 -inform pem -noout -text                             :(
unable to load certificate
139678901523776:error:0909006C:PEM routines:get_name:no start line:crypto/pem/pem_lib.c:745:Expecting: TRUSTED CERTIFICATE

Documentation is talks about 2 different creation for tls-secrets as well.
It talks about a generic secret here https://istio.io/latest/docs/reference/config/networking/gateway/#ServerTLSSettings
But here https://istio.io/latest/docs/tasks/traffic-management/ingress/secure-ingress/#configure-a-tls-ingress-gateway-for-a-single-host it uses a regular tls-secret.
[X] Configuration Infrastructure
[X] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
I would expect https://domain.com to yield the same result as http://domain.com with above configuration.
Steps to reproduce the bug
Follow above steps and execute curl against the https-endpoint.
It also appears that the steps here https://archive.istio.io/v1.5/pt-br/docs/tasks/traffic-management/ingress/secure-ingress-mount/ : creating a secret in namespaces istio-system so that it will be mounted is not working either(at least the result for curl is the same). The secrets are mounted alright, I also restarted the gateway and the corresponding pod, but I still cannot gain access to the pod via https.
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
client version: 1.6.2
control plane version: 1.6.2
data plane version: 1.6.2 (2 proxies)
How was Istio installed?
istioctl install --set components.telemetry.enabled=true --set addonComponents.grafana.enabled=true --set values.grafana.enabled=true --set values.kiali.enabled=true --set "values.kiali.dashboard.grafanaURL=http://grafana:3000"  --set components.citadel.enabled=true --set components.citadel.enabled=true
Environment where bug was observed (cloud vendor, OS, etc)
Debian 4.19.118-2+deb10u1, regular server.

Can you post the config dump and access logs on the ingress? I could not reproduce this. See https://github.com/istio/istio/wiki/Troubleshooting-Istio for info

I have long since switched ingress, since it was still not a completely setup cluster and a new one, without requirements, at that.
I thought about attaching the configuration, but, if memory serves me right, I found that it was also containing my ssl-certificates, which I am more than reluctant to post.


Fix Diamond Princess naming

Describe the bug
In the latest JHU release, the Diamond Princess is its own country.
Expected behavior
Entries pertaining to the Diamond Princess should have Country/Region set to Cruise Ship and Province/State to Diamond Princess.

Also renaming Burma to Myanmar.


Colorful Solarized Light theme

This patch uses more colors for the Solarized Light theme. All
punctuation is red, operators are green and variables are blue.
The result looks like this:

Thanks for working on this!
However, I disagree with such a bright color for punctuation. In all our themes, punctuation has a color that will make it less noticeable, not more. The reason is that you don't want it to stand out when you scan the code, you want it to fade to the background so you can scan what actually matters.

This is how Solarized Light looks in my editor (Atom) btw, if it helps:

However, I disagree with such a bright color for punctuation.

On PR #872 you posted this picture:

It has red punctuation. I just tried to match it as closely as possible.

I could easily make an exception for markup:
.language-markup .token.punctuation {
	color: #586e75; /* base01 */
}

Sorry :(
I think it might be good to collect samples for our core languages from various editors, compare them and try to do something similar. But it's kind of a chore to do that.


Add a Gitter chat badge to README.md

DarkGigaByte/rollout now has a Chat Room on Gitter
@DarkGigaByte has just created a chat room. You can visit it here: https://gitter.im/DarkGigaByte/rollout.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

integrated badge by myself (without google tracking ;) )


Space name constraints

Enfore the following constraints on space names:

Must only contain characters [a-zA-Z0-9_]
Names must be unqiue

Add a Version field to space config and migrate the names of old configs
to the new standard.
Also:

add JSONFile functions to package fs. Used for atomic update of json files.

closes #791

blocked by brim#856

@brimsec/zq @nwt did a large refactor of this to incorporate subspaces. Ready for another look.

Thanks @nwt !


Add files via upload

@abdallahalidev Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@abdallahalidev You might miss my previous comment. Please react.

@abdallahalidev I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Meta-Issue: Migration

This is a meta-issue to track other issues related to migration.  In particular, we need to address

Documentation of current status of migration tooling
Documentation of functionality the user can expect after migrating
Documented examples of migrating from 7.x using both FOXML and CSV
Document the OpenRefine workflow to clean up your data on the way in
Iterate upon the Default Metadata profile and its RDF mapping

As well as discuss any other issues and respond to any feedback that may arise.

DIG: Keep open; track related issues; revisit as LYRASIS/IMLS grant deliverables become available


[SPARK-43876][SQL] Enable fast hashmap for distinct queries

What changes were proposed in this pull request?
Spark will enable fast hash map for primitive data types in HashAggregateExec.
Enable this for distinct queries which bufferSchema is empty.
For example, we can also build a fast hash map with the key a + b for query SELECT distinct a, b from tab
Why are the changes needed?
Improve distinct queries performance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists UT

cc @sameeragarwal @c21

cc @viirya

Merged to master for Apache Spark 3.5.0. Thank you, @wankunde .

https://spark.apache.org/versioning-policy.html (Apache Spark 3.5.0 on August 2023)


External Authorization Provider

What should we add or change to make your life better?
An increasing used service for Envoy-based proxy providers is the ability to provide an External Authorization service using Envoy's extauthz support. It'd be great if YARP could support this as seamlessly as possible.
Why is this important to you?
Allows a simpler transition from envoy-based proxies as well as enabled simple interop with tools like Open Policy Agent. https://github.com/open-policy-agent/opa-envoy-plugin (though this be accomplished with a more direct integration)
Additional Notes
I'm interested in possible implementing this as a third-party lib, but had some questions:

Considering this is completely deferring auth to an external service, would the path to implement this be https://docs.microsoft.com/en-us/aspnet/core/security/authorization/iauthorizationpolicyprovider?view=aspnetcore-3.1?
Would IProxyConfig be how I get cluster information? Would like to implement this how envoy implements this where the extauthz request is treated like just another proxy request to a cluster.
Is there a way to get the current request's cluster destination information?

Here's the current auth docs for reference: https://microsoft.github.io/reverse-proxy/articles/authn-authz.html
I'm browsing through the extauthz docs looking for some more concrete details on how it works. The implication from here is that you send the entire request over gRPC, along with source and destination information. That seems extremely expensive, effectively doubling the work the proxy has to do on every request. Worse, it seems to require buffering all request bodies (and as strings no less).
This doesn't seem to integrate well with AspNetCore's authentication or authorization systems, it combines both and you'd likely have to replace both.
I think this could be written as a middleware in the proxy pipeline. See the IReverseProxyFeature for information about the matched cluster and destinations.
https://github.com/microsoft/reverse-proxy/blob/1986522cdd89da60363a7fd94569aabb3d3186b5/samples/ReverseProxy.Config.Sample/Startup.cs#L50-L62

The implication from here is that you send the entire request over gRPC, along with source and destination information. That seems extremely expensive, effectively doubling the work the proxy has to do on every request.

That's somewhat true, and usually reduced by running the OPA process or other ExtAuthz process as a sidecar. It's a little expensive, but well worth the cost.

Worse, it seems to require buffering all request bodies (and as strings no less).

This is optionally luckily. You actually have to opt into this.

This doesn't seem to integrate well with AspNetCore's authentication or authorization systems, it combines both and you'd likely have to replace both.

Not quite true. It's purely authz, and assumes that authentication is done at a previous layer and passed into the CheckRequest as data. It can do authn, but the intent is just authz.

I think this could be written as a middleware in the proxy pipeline. See the IReverseProxyFeature for information about the matched cluster and destinations.

Noted! I'll take a look into this.

This doesn't seem to integrate well with AspNetCore's authentication or authorization systems, it combines both and you'd likely have to replace both.

Not quite true. It's purely authz, and assumes that authentication is done at a previous layer and passed into the CheckRequest as data. It can do authn, but the intent is just authz.

How's that? When you're only passing the request headers to this remote service it has to do both the AuthN and AuthZ validation of those values. Or is there somewhere else you can provide AuthN data.
For contrast, AspNetCore's AuthN system produces a ClaimsPrincipal, and that's the input for the AuthZ system. The AuthZ system doesn't know anything about request headers.

How's that? When you're only passing the request headers to this remote service it has to do both the AuthN and AuthZ validation of those values. Or is there somewhere else you can provide AuthN data.

For contrast, AspNetCore's AuthN system produces a ClaimsPrincipal, and that's the input for the AuthZ system. The AuthZ system doesn't know anything about request headers.

That's true. The middleware/handler would need to translate the Claims Principal into something that the Ext Auth service can consume. That's sort of how envoy does it too. You'd set up, for example, JWT Authentication. The data from that then is either translated into headers or passed as dynamic metadata which then is passed to the Ext Authz service. So the YARP middleware could either map the ClaimsPrincipal to metadata that the service could understand, or have a toggle such that if you're just using JWT Auth, it'll pass either the raw or decoded payload token through.

You'd set up, for example, JWT Authentication. The data from that then is either translated into headers or passed as dynamic metadata which then is passed to the Ext Authz service. So the YARP middleware could either map the ClaimsPrincipal to metadata that the service could understand, or have a toggle such that if you're just using JWT Auth, it'll pass either the raw or decoded payload token through.

This seems to be the same thing we did in our setup locally and translate several JWT claims to headers as well as pass the raw token through for upstream services to extract more if needed. We have it setup as the AuthorizationPolicy in the config currently so that certainly can do what you are looking for. We started with it being a middleware and found that it made more sense for us to handle it as an AuthorizationPolicy since only some routes would utilize it and it provided a very coarse level of authorization so it seemed logical.

@amweiss Good to hear, and some nice validation. I actually think that path could be even more interesting given a more direct OPA integration. You could have the policy param correspond to an Policy path.

Triage: We think this scenario is fairly advanced (and costly on performance), hence should be handled by custom code and that we do not need configuration for that.
Closing. If there is additional information or more customers needing it, we can reconsider in future and reopen.

That's fair. I'll try and PoC this independently. Only follow up question then is if a component in the YARP pipeline that wants to make an external request (rate limting / ext auth) can somehow also send that request through the proxy pipeline aside from literally calling the proxy again. That way an external service can be configured via clusters and lb against.

That's a bit recursive. I'd expect you to keep the services needed to operate the proxy separate from those behind the proxy. E.g. you wouldn't want your request to the rate limiting service to get rate limited by the proxy.
You can still take advantage of the IConfiguration system, but you'd provide your own schema for those external services.

I guess more specifically, I'd like to at the very least load balance against those services. I'm guessing for now though that'd require just having an independent proxy, yes?

Right, if those services need load balancing then they should provide their own.


ref(docs): move "private repos" section after "custom buildpacks"

It was suggested that the "Optional: Add SSH key to use private repositories" section detours too much from the basic workflow in the "Using Buildpacks" doc, and that it would fit better after "Custom Buildpacks." This does that as well as shortens some language and adds a basic usage example. ping @gabrtv.
Refs #3305.

huuuuuuuuge :+1: from me. +:100:, in fact!
Docs LGTM

LGTM, as this was my ask originally.


chore(CX-2148): hide description from auction results

This PR resolves CX-2148
Description

Hide description from auction results

#squashongreen


Prototype/Comparator set

@PeteWilliams there's conflicts to resolve

@PeteWilliams there's conflicts to resolve

Now resolved.


Chains missing estimated_upgrade_time when upgrade is found

This chain has an upgrade but the upgrade time is null I guess that shouldn't happen.

Thanks for the report, we have pushed a patch in #37 to retry the estimated upgrade time calculation if we fail to retrieve the data we need for this calculation.


Uploaded RSA Key, gravitee keeps using HMAC with default secret

Hi,
I'm using gravitee am. For a security domain I uploaded a keystore containig an RSA key.
However, id_token and access_token are signed using HMAC and default secret (the one in gravitee.xml). Token signature validation fails using the RSA key (RSA key with HS256 signed token instead of RS256).
Using HMAC and default secret token passes validation, but I don't want to embed the secret in my web app. I want to use RS256 and RSA key contained in jwks.json.
What should I do?
{
  "issuer" : "http://:GRAVITEE_HOST/am/oauth/oidc",
  "authorization_endpoint" : "http://:GRAVITEE_HOST/am/oauth/oauth/authorize",
  "token_endpoint" : "http://:GRAVITEE_HOST/am/oauth/oauth/token",
  "userinfo_endpoint" : "http://<IP_ADDRESS>/am/oauth/oidc/userinfo",
  "jwks_uri" : "http://:GRAVITEE_HOST/am/oauth/oidc/.well-known/jwks.json",
  "end_session_endpoint" : "http://:GRAVITEE_HOST/am/oauth/logout",
  "revocation_endpoint" : "http://:GRAVITEE_HOST/am/oauth/oauth/revoke",
  "introspection_endpoint" : "http://:GRAVITEE_HOST/am/oauth/oauth/introspect",
  "registration_endpoint" : "http://:GRAVITEE_HOST/am/oauth/oidc/register",
  "scopes_supported" : [ "profile", "email", "address", "phone", "openid", "offline_access", "dcr", "dcr_admin", "scim", "consent_admin" ],
  "response_types_supported" : [ "code", "token", "id_token", "id_token token", "code id_token", "code token", "code id_token token" ],
  "grant_types_supported" : [ "client_credentials", "password", "implicit", "authorization_code", "refresh_token", "urn:ietf:params:oauth:grant-type:jwt-bearer" ],
  "subject_types_supported" : [ "public" ],
  "id_token_signing_alg_values_supported" : [ "HS512", "RS256", "RS512" ],
  "userinfo_signing_alg_values_supported" : [ "RS384", "RS256", "RS512" ],
  "token_endpoint_auth_methods_supported" : [ "client_secret_basic", "client_secret_post", "private_key_jwt" ],
  "claim_types_supported" : [ "normal" ],
  "claims_supported" : [ "name", "family_name", "given_name", "middle_name", "nickname", "preferred_username", "profile", "picture", "website", "gender", "birthdate", "zoneinfo", "locale", "updated_at", "email", "email_verified", "address", "phone_number", "phone_number_verified" ],
  "code_challenge_methods_supported" : [ "plain", "S256" ],
  "claims_parameter_supported" : true,
  "request_parameter_supported" : false,
  "request_uri_parameter_supported" : true,
  "require_request_uri_registration" : true
}

{
  "keys" : [ {
    "kty" : "RSA",
    "alg" : "RS256",
    "kid" : "default-gravitee-am-key",
    "x5c" : [ "IT_SEEMS_BASE64" ],
    "x5t#S256" : "...",
    "e" : "AQAB",
    "n" : "..."
  } ]
}

Hi @gianx89 ,
Did you choose the correct Certificate for your client ?

Didn't see that section, maybe it would be useful to highlight this aspect in the docs (certificates section). Thank you for the fast reply, now it works.