We Detected An Unusual Login Attempt

i have this error on login
Fatal error: Uncaught InstagramScraper\Exception\InstagramAuthException: Something went wrong. Please report issue. in \src\InstagramScraper\Instagram.php:1685 Stack trace: #0 C:\xampp\htdocs\zhav\ajax.php(432): InstagramScraper\Instagram->login() #1 {main} thrown in \src\InstagramScraper\Instagram.php on line 1685
and after this when i login in instagram web i see the We Detected An Unusual Login Attempt page

I was receiving this error too. I'm afraid. Any ideas would be massively appreciated!

Hi all,
I also got the same issue earlier, then I tried to keep the login response  in the session an example using Laravel framework is mentioned below

   public static function connect($login=false){
               try{
       if($login){
           // checking, if the previous session exists returns value
           if(Session::has('instascrapper') && !empty(Session::get('instascrapper'))){
               return Session::get('instascrapper');
           }else{
                   sleep(3);// mimc user
                   // if not exists call the function and
                   // save the response in session
                   $instagram = Instagram::withCredentials(self::USERNAME, self::PASSWORD, new Psr16Adapter('Files'));
                   $instagram->login();
                   $instagram->saveSession();
                  // saving session and returning
                  Session::put('instascrapper',$instagram);
                   return $instagram;
           }
       }else{
           $instagram =  new Instagram();
           return $instagram;
       }
               }catch(Exception $exception){
                   return $exception;
               }
   }

    public function LikeMedia(Request $request){
            try {
               if($request->has('media')){
                     $media_id = $request->media;
                    // calling the above connect function
                    $instagram = InstagramClient::connect(true);
                    $instagram->unlike($media_id);
                }else{
                    return $this->responseWithStatus(422,'Media id required');
                }
            } catch (\InstagramException $ex) {
                echo $ex->getMessage();
            }
    }

These functions are working for me perfectly
By keeping the login response in the session we can avoid sending multiple requests for the actual login

Hi all,
I also got the same issue earlier, then I tried to keep the login response in the session an example using Laravel framework is mentioned below

   public static function connect($login=false){
               try{
       if($login){
           // checking, if the previous session exists returns value
           if(Session::has('instascrapper') && !empty(Session::get('instascrapper'))){
               return Session::get('instascrapper');
           }else{
                   sleep(3);// mimc user
                   // call the function login function and  save the response in session
                   $instagram = Instagram::withCredentials(self::USERNAME, self::PASSWORD, new Psr16Adapter('Files'));
                   $instagram->login();
                   $instagram->saveSession();
                  // saving session and returning
                  Session::put('instascrapper',$instagram);
                   return $instagram;
           }
       }else{
           $instagram =  new Instagram();
           return $instagram;
       }
               }catch(Exception $exception){
                   return $exception;
               }
   }

    public function LikeMedia(Request $request){
            try {
               if($request->has('media')){
                     $media_id = $request->media;
                    // calling the above connect function
                    $instagram = InstagramClient::connect(true);
                    $instagram->unlike($media_id);
                }else{
                    return $this->responseWithStatus(422,'Media id required');
                }
            } catch (\InstagramException $ex) {
                echo $ex->getMessage();
            }
    }

These functions are working for me perfectly
By keeping the login response in the session we can avoid sending multiple requests for the actual login

@popmatik @tenet912

For me Instagram::withCredentials always throws the exception: "Something went wrong. Please report issue" (code 400), so I cannot get the login response to save it...

Hi all,
I also got the same issue earlier, then I tried to keep the login response in the session an example using Laravel framework is mentioned below

   public static function connect($login=false){
               try{
       if($login){
           // checking, if the previous session exists returns value
           if(Session::has('instascrapper') && !empty(Session::get('instascrapper'))){
               return Session::get('instascrapper');
           }else{
                   sleep(3);// mimc user
                   // call the function login function and  save the response in session
                   $instagram = Instagram::withCredentials(self::USERNAME, self::PASSWORD, new Psr16Adapter('Files'));
                   $instagram->login();
                   $instagram->saveSession();
                  // saving session and returning
                  Session::put('instascrapper',$instagram);
                   return $instagram;
           }
       }else{
           $instagram =  new Instagram();
           return $instagram;
       }
               }catch(Exception $exception){
                   return $exception;
               }
   }

    public function LikeMedia(Request $request){
            try {
               if($request->has('media')){
                     $media_id = $request->media;
                    // calling the above connect function
                    $instagram = InstagramClient::connect(true);
                    $instagram->unlike($media_id);
                }else{
                    return $this->responseWithStatus(422,'Media id required');
                }
            } catch (\InstagramException $ex) {
                echo $ex->getMessage();
            }
    }

These functions are working for me perfectly
By keeping the login response in the session we can avoid sending multiple requests for the actual login

please explain me on this codes . thanks
`use InstagramScraper\Instagram;
use Phpfastcache\Helper\Psr16Adapter;
$user = '';
$password = "'';";
$instagram = \InstagramScraper\Instagram::withCredentials( $user, $password, new Psr16Adapter('Files'));
$instagram->login();
// For getting information about account you don't need to auth:
$account = $instagram->getAccount('kevin');
// Available fields
echo "Account info:\n";
echo "Id: {$account->getId()}\n";
echo "Username: {$account->getUsername()}\n";
echo "Full name: {$account->getFullName()}\n";
echo "Biography: {$account->getBiography()}\n";
echo "Profile picture url: {$account->getProfilePicUrl()}\n";
echo "External link: {$account->getExternalUrl()}\n";
echo "Number of published posts: {$account->getMediaCount()}\n";
echo "Number of followers: {$account->getFollowsCount()}\n";
echo "Number of follows: {$account->getFollowedByCount()}\n";
echo "Is private: {$account->isPrivate()}\n";
echo "Is verified: {$account->isVerified()}\n";`
how can i use your function in this codes ?

For me Instagram::withCredentials always throws the exception: "Something went wrong. Please report issue" (code 400), so I cannot get the login response to save it...

you have the same problem ?

Hi @tenet912 ,
$user = '';
$password = "'';";
$instagram = \InstagramScraper\Instagram::withCredentials( $user, $password, new Psr16Adapter('Files'));
$instagram->login();
$instagram->saveSession();
after this print and see what's in there in the $instagram variable,
Save that value in the session, if you are developing a website or web application :
$_SESSION["instagram"] = $instagram;
you can call any where you want eg:
like this way you can skip calling the withCredentials function repetadily
if (isset($_SESSION['errors'])){
$instagram = $_SESSION["instagram"];
}else{
$instagram = \InstagramScraper\Instagram::withCredentials( $user, $password, new Psr16Adapter('Files'));
$instagram->login();
$instagram->saveSession();
$_SESSION["instagram"] = $instagram;
}
$account = $instagram->getAccount('kevin');
also if you don't want to call the getAccount function using credentials simply call
$instagram = new \InstagramScraper\Instagram();
// For getting information about account you don't need to auth:
$account = $instagram->getAccount('kevin');

I am getting the message “unusual login attempts” on first attempt to perform login.
Any suggestion on how to request the security code and submit it using this package??

Save in file?

Hi @tenet912 ,
$user = '';
$password = "'';";
$instagram = \InstagramScraper\Instagram::withCredentials( $user, $password, new Psr16Adapter('Files'));
$instagram->login();
$instagram->saveSession();
after this print and see what's in there in the $instagram variable,
Save that value in the session, if you are developing a website or web application :
$_SESSION["instagram"] = $instagram;
you can call any where you want eg:
like this way you can skip withCredentials function calling repeatedly
if (isset($_SESSION['errors'])){
$instagram = $_SESSION["instagram"];
}else{
$instagram = \InstagramScraper\Instagram::withCredentials( $user, $password, new Psr16Adapter('Files'));
$instagram->login();
$instagram->saveSession();
$_SESSION["instagram"] = $instagram;
}
$account = $instagram->getAccount('kevin');
also if you don't want to call the getAccount function using credentials simply call
$instagram = new \InstagramScraper\Instagram();
// For getting information about account you don't need to auth:
$account = $instagram->getAccount('kevin');

Will this also save the session when running in terminal on MacOS? Trying to prevent a login each time I execute a function.

Might be different use case, but still wanted to share.
If I understand the working correct, when you create the session with Psr16Adapter, the information is already stored on file and reused (you can find the cache in the './phpfastcache//Files/8c/0c').
The main steps of the Login() are:

Read session from Psr16Adapter cache ('$session = static::$instanceCache->get($this->getCacheKey());')
Check if session exists and is still loggedin @Instagram ('if ($force || !$this->isLoggedIn($session))')
if no $session or not loggedIn => login

The issue that I had with this method is that (at least in my case) the Psr16Adapter expired in 900 seconds after creation, which did not update on a new save. So I got a lot of login mails from Instagram. I made a change and use '$instagram->saveSession(86400);' to ensure the cache remains valid for a while and the expiration date is update upon each request.
Note: The actual checking in step 2 of the login takes a call on instagram, which does not seem necessary, so I skipped that if the $session is available.


jax.random.KeyArray deprecated

As per jax changelog, from jax 0.4.24 on jax.random.KeyArray is no longer, so haliax fails to import with
AttributeError: module 'jax.random' has no attribute 'KeyArray'

oops, ok, will fix soon!

i fixed this at some point


ProGAP Code Execution Errors

Hi Sisaman:
So happy to see your code about ProGAP. I'm attempting to execute the code, but I encounter errors. Specifically, when the model is set to GNN-DP and the graph convolution layer is either GCN or GAT, an error arises during runtime:
ValueError: Attempted to use an uninitialized parameter in <built-in method empty_like of type object at  0x7f9ba553a140>. This error happens when you are using a LazyModule or explicitly manipulating torch.nn.parameter.UninitializedParameter objects. When using LazyModules Call forward with a dummy batch to initialize the parameters before calling torch functions.
Can you tell me how to fix the bug? Thanks.

Can you give me the exact CLI command you use to reproduce the error?

Thank you for your response. The exact CLI command I used is: python train.py gnn node --dataset facebook --hidden_dim 16 --activation relu --optimizer adam --learning_rate 0.01 --repeats 1 --epochs 100 --batch_size 64 --verbose False --base_layers 1 --head_layers 1 --jk cat --epsilon 8.0 --project GNN.
To utilize the GCN architecture as the backbone GNN model, I modified core/methods/gnn/node.py at line 36 to conv='gcn'.


Any way to reference a specific waypoint in the onEnter/onLeave handler?

I have a series of waypoints marking important boundaries on a long, scrolling page. I'd like them all to fire the same onEnter/onLeave handler rather than writing individual handlers for each Waypoint. Would it be possible to pass the key attribute or the id of the waypoint itself as part of the data object these handlers receive?

Hi @andremalkine ! Thanks for the issue.

Would it be possible to pass the key attribute or the id of the waypoint itself as part of the data object these handlers receive?

Yup, doing something like this is technically possible from within the lib. It would require updating these lines to be something like:
const callbackArg = {
  currentPosition,
  previousPosition,
  event,
  waypointTop: bounds.waypointTop,
  waypointBottom: bounds.waypointBottom,
  viewportTop: bounds.viewportTop,
  viewportBottom: bounds.viewportBottom,
  id: this.props.id // or whatever
};

Although I understand the need, I'm not sure if I'm convinced that we need it. Would a system like one of these work for you instead, @andremalkine ?
// If it's a long list of items...
render() {
  return (

      {myThings.map((thing, index) => (
        <Waypoint
          key={index}
          onEnter={this.onWaypointEnter.bind(this, index)}/>
      ))}

  );
}

// If it's a list of items with some sort of identifier
render() {
  return (

      {myThings.map((thing, index) => (
        <Waypoint
          key={index}
          onEnter={(waypointData => this.onWaypointEnter(thing.id, waypointData))}/>
      ))}

  );
}

I'm assuming you want to avoid creating dynamic functions? That sounds like a valid concern. I think it might make sense to allow an identifier prop to be passed in, with the sole purpose of making it easier to write reusable onEnter/onLeave handlers.
Another option would be to allow an arbitrary metadata prop to be passed in, which will then get passed to handlers untouched.
Yet another option would be to simply send back the DOM element that we use internally for the waypoint. With the new support for children, you could prepare a custom DOM element with some metadata/attributes that you can then use in the handler.
Just brainstorming, I'd be interested to hear other people's thought.

@trotzig  That is correct, this comes from a desire not to write anonymous functions in-line. I think any of the suggestions you made would be great.
That being said, using bind or otherwise works fine if you don't mind writing that way.

bind will work, but you still end up creating new functions.

I'm assuming you want to avoid creating dynamic functions? That sounds like a valid concern.

:+1:

Another option would be to allow an arbitrary metadata prop to be passed in, which will then get passed to handlers untouched.

I like this option :+1: .

May I ask how many waypoints you use on a page @andremalkine? I would expect scrolling lag to be the first performance issue you'd see if a page was flooded with waypoints, long before dynamic method creation would be a problem. I've been thinking about the use-case some more, and I don't see this as being unique to react-waypoint in any way. Basically any component that anonymously calls (not sending any data than can be used to identify the instance) has this problem.
For instance, we have a Button component that takes an onClick function. No data is passed to the onClick handler, so on pages where we're dynamically rendering many buttons we have to create anonymous functions. I don't think it's the responsibility of the Button component or the waypoint to handle identifying itself.
I'm interested to hear what others think though. Also, are there techniques (or even npm modules) that can help with avoiding to create anonymous functions on each (re-)render? A simple memoization might be enough:
const handlers = {};

function memoizedHandler(id) {
  if (handlers[id]) {
    return handlers[id];
  }
  handlers[id] = () => {
    // do something useful with `id` here...
  };
  return handlers[id];
}

function MyComponent() {
  return (

      {someList.map(({ id }) => (
        <Waypoint onEnter={memoizedHandler(id)} />
      )}

  );
}
...

@trotzig I have a page with 5 viewport filling "sections". As the user scrolls, I'm interested in knowing when each new section enters and leaves the viewport. There is an arbitrary amount of content above them, and they can each overflow the viewport and be different heights if needed, so having waypoints is very handy/convenient.
I think the real motivation behind my question was the fact that each enter/leave triggers a very simple, similar action of declaring which section you're "in", 0-4. That's it. Writing that simple behavior over and over just felt odd, and I always try to spawn anonymous functions when rendering.
I like your memoization suggestion, it's a nice compromise between the two. You may still wind up writing a series of separate but nearly identical functions, but you avoid the aforementioned spawning.

Thanks for the follow-up @andremalkine! I'm going to close this issue without any actions, as I think we've figured out a good-enough workaround for you and others who might run into the same issue.


Uncaught TypeError: _this.notificationEl.querySelector is not a function

[Enter steps to reproduce:]

...
...

Atom: 1.36.1 x64
Electron: 2.0.18
OS: Linux Mint
Thrown From: linter-gcc package 0.7.1
Stack Trace
Uncaught TypeError: _this.notificationEl.querySelector is not a function
At /home/eudson/.atom/packages/linter-gcc/node_modules/atom-package-deps/lib/view.js:22

TypeError: _this.notificationEl.querySelector is not a function
    at /packages/linter-gcc/node_modules/atom-package-deps/lib/view.js:22:58

Commands
  2x -3:00.2.0 welcome:show (input.hidden-input)

Non-Core Packages
atom-beautify 0.33.4
atom-material-syntax 1.0.8
atom-material-ui 2.1.3
color-picker 2.3.0
file-icons 2.1.32
linter-gcc 0.7.1
pigments 0.40.2

Linter GCC doesn't work anymore, https://atom.io/packages/linter-gcc2

See the following issue for further details and some potential resolutions.

Duplicate of #209


just sets HTML at the bottom of screen

This is happening in the latest install of electron. It doesn't matter if I call it in the renderer or the main window through IRPC its the same.
same as #4
PFA screenshot below.

Related to #4.
Did you add dist/smalltalk.css to your html page like in example?

Close due to long time of inactivity


Cosmos DB: Upgrade cosmos DB SDK to latest version i.e. 3.38.1

Why make this change?
We want to use SDK latest features like:

Patch API
Ability to disable certificate check by including a flag in connection string.
Hierarchal Partition Key

etc.
What is this change?
Upgrade Cosmos to the latest version3.38.1. It's a non-breaking change
How was this tested?
NA
Sample Request(s)
NA

/azp run

There may not be tests for this.. how do we know DAB isn't affected by at least one of the breaking changes for CosmosSDK listed in : https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/changelog.md since we are upgrading from 3.2.0 2021-06-21 (released in 2021)

⚠ Note: Starting with version 3.38.0, the .NET SDK enables the ODE feature by default. This can potentially cause a new type of continuation token to be generated. Such a token is not recognized by the older SDKs by design and this could result in a Malformed Continuation Token Exception. If you have a scenario where tokens generated from the newer SDKs are used by an older SDK, we recommend a 2 step approach to upgrade:
Upgrade to the new SDK and disable ODE, both together as part of a single deployment. Wait for all nodes to upgrade.
In order to disable ODE, set EnableOptimisticDirectExecution to false in the QueryRequestOptions.
Enable ODE as part of second deployment for all nodes.

If you have a scenario where tokens generated from the newer SDKs are used by an older SDK, we recommend a 2 step approach to upgrade:

Good question! but I don't think we have a scenario where tokens generated by newer DAB(that uses the new SDK) will be used by  older DAB (that uses the old SDK). Because when client apps target a newer DAB, older DAB shouldn't be in picture.

FYI @sourabh1007 merging this, if you have concerns regarding breaking changes please address in a separate PR


Capture document size, RU usage, retry stats for get and put in CosmosDB

This PR enables capturing stats related to document size and RU used for get and put operation.
Description
Document Size Stats
With this PR the get and put operation would include the document size and RU used
[2019-09-30T11:29:53.553Z] [INFO] [#tid_1] [CosmosDBArtifactStore] [PUT] 'subjects' completed document: 'id: anon-OIPNjW7IigJetLxDwwlPwlcG2Fl, rev: null', size=235, ru=7.05 [marker:database_saveDocument_finish:9308:685]

Further the PR also add a histogram for document size.
# TYPE histogram_cosmosdb_doc_size_bytes histogram
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="512.0"} 0.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="1024.0"} 0.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="2048.0"} 0.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="4096.0"} 0.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="16384.0"} 0.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="65536.0"} 3815.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="524288.0"} 3815.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="1048576.0"} 3815.0
histogram_cosmosdb_doc_size_bytes_bucket{collection="activations",le="+Inf"} 3815.0
histogram_cosmosdb_doc_size_bytes_count{collection="activations"} 3815.0
histogram_cosmosdb_doc_size_bytes_sum{collection="activations"} 192398080.0

Client Diagnostic Stats
If the TransactionId has debug mode enabled (extension of support added in #4275) then it would also include some client side diagnostic info generated by CosmosDB when using Direct mode
[2019-09-30T11:50:34.472Z] [INFO] [#tid_42] [CosmosDBArtifactStore] [PUT] 'subjects' completed document: 'id: anon-MZIVqUOiMiyxxYXJTyLxYnihVNI, rev: null', size=235, ru=7.05 RequestStartTime: "30 Sep 2019 11:50:30.908", RequestEndTime: "30 Sep 2019 11:50:34.464", Duration: 3556 ms, Number of regions attempted: 1 StoreResponseStatistics{requestResponseTime="30 Sep 2019 11:50:33.281", storeResult=storePhysicalAddress: rntbd://cdb-ms-prod-eastus1-fd18.documents.azure.com:14047/apps/a12ab0b2-98f6-4f5a-a7d4-f67e3a08d496/services/e50f5eae-0700-4539-9323-e4a587786587/partitions/eaa72284-4d0b-4ddf-a919-c890c12803a3/replicas/132138294859720735p/, lsn: 1177, globalCommittedLsn: 1176, partitionKeyRangeId: 0, isValid: true, statusCode: 201, subStatusCode: 0, isGone: false, isNotFound: false, isInvalidPartition: false, requestCharge: 7.05, itemLSN: -1, sessionToken: -1#1177, exception: null, requestResourceType=Document, requestOperationType=Create} AddressResolutionStatistics{startTime="30 Sep 2019 11:50:31.471", endTime="30 Sep 2019 11:50:31.705", targetEndpoint='https://foo-eastus.documents.azure.com:443/addresses/?$resolveFor=dbs%2FXk1oAA%3D%3D%2Fcolls%2FXk1oAKUKbiU%3D%2Fdocs&$filter=protocol%20eq%20rntbd&$partitionKeyRangeIds=0'} StoreResponseStatistics{requestResponseTime="30 Sep 2019 11:50:34.464", storeResult=storePhysicalAddress: rntbd://cdb-ms-prod-eastus1-fd18.documents.azure.com:14064/apps/a12ab0b2-98f6-4f5a-a7d4-f67e3a08d496/services/e50f5eae-0700-4539-9323-e4a587786587/partitions/eaa72284-4d0b-4ddf-a919-c890c12803a3/replicas/132119752170912464s/, lsn: 1177, globalCommittedLsn: 1177, partitionKeyRangeId: 0, isValid: true, statusCode: 204, subStatusCode: 0, isGone: false, isNotFound: false, isInvalidPartition: false, requestCharge: 0.0, itemLSN: 660, sessionToken: -1#1177, exception: null, requestResourceType=DocumentCollection, requestOperationType=Head} [marker:database_saveDocument_finish:15080:3568]

Retry stats
The PR also enabled to capture the internal retry done by SDK upon throttling. Currently there is no direct support to capture such stats (Azure/azure-cosmosdb-java#262). So this PR makes use of Logback to capture the stats by intercepting the warning log message generated upon a 429 response
[2019-09-27T07:57:15.161Z] [WARN] Operation will be retried after 6 milliseconds. [2019-09-27T07:57:15.161Z] [WARN] Operation will be retried after 6 milliseconds. Current attempt 1, Cumulative delay PT0.006S
com.microsoft.azure.cosmosdb.DocumentClientException: Message: {"Errors":["Request rate is large"]}
ActivityId: 28ebd9fc-2615-4e9f-b4a7-ec3ebb464b36, Request URI: /apps/cebf41ab-a2c2-4055-b592-9887b5c5a634/services/91918f88-9f66-459c-93cf-53644d05f280/partitions/2baa1e8f-3751-444c-8be7-f831dc692a63/replicas/132121471945325759p/, RequestStats:
RequestStartTime: 2019-09-27T07:57:14.6731085Z, RequestEndTime: 2019-09-27T07:57:14.6731085Z, Number of regions attempted: 1
ResponseTime: 2019-09-27T07:57:14.6731085Z, StoreResult: StorePhysicalAddress: rntbd://cdb-ms-prod-eastus1-fd34.documents.azure.com:16701/apps/cebf41ab-a2c2-4055-b592-9887b5c5a634/services/91918f88-9f66-459c-93cf-53644d05f280/partitions/2baa1e8f-3751-444c-8be7-f831dc692a63/replicas/132121471945325759p/, LSN: 1898, GlobalCommittedLsn: 1897, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: , UsingLocalLSN: False, TransportException: null, ResourceType: Document, OperationType: Create
, SDK: Microsoft.Azure.Documents.Common/2.5.1, StatusCode: TooManyRequests
    at com.microsoft.azure.cosmosdb.rx.internal.RxGatewayStoreModel.validateOrThrow(RxGatewayStoreModel.java:444)
    at com.microsoft.azure.cosmosdb.rx.internal.RxGatewayStoreModel.lambda$null$8(RxGatewayStoreModel.java:382)

A typical log message looks like above which has info related to

Attempt count
If retry would be done or it was the last retry
Operation type like Get or Create etc

Prometheus metrics for retry
counter_cosmosdb_retry_success_total{type="Create"} 164.0

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[ ] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4652 into master will decrease coverage by 6.02%.
The diff coverage is 20.89%.

@@            Coverage Diff             @@
##           master    #4652      +/-   ##
==========================================
- Coverage   84.46%   78.44%   -6.03%
==========================================
  Files         183      184       +1
  Lines        8377     8433      +56
  Branches      566      591      +25
==========================================
- Hits         7076     6615     -461
- Misses       1301     1818     +517

Impacted Files
Coverage Δ

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.89%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
7.69% <100%> (-48.31%)
:arrow_down:

...core/database/cosmosdb/RetryMetricsCollector.scala
35.13% <35.13%> (ø)

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-94.74%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedListener.scala
0% <0%> (-86.67%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-76.48%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-74.08%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a581bea...7bd46ab. Read the comment docs.


[$500] IOU -Admin is unable to add receipt on Employee's expense request but the placeholder displayed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.11-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Log in as the employee
Navigate to a expense request conversation that has a receipt
Click on the receipt thumbnail
Click on Delete Receipt from 3 dot menu on the top right
Log in as admin
Navigate to the expense from Step 2
Click on "+" button from deleted receipt ( click once and click few times)

Expected Result:
Since placeholder shows up, admin should be able to add receipt
Actual Result:
Admin is unable to add receipt on Employee's expense request but the placeholder still shows up.
Clicking on it fast enough will redirect admin to report page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/b64ad6fb-5602-4f3c-9429-7e375838cb8d
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a1dbb186e5ac4d8c
Upwork Job ID:<PHONE_NUMBER>483804672
Last Price Increase: 2023-12-12

@sobitneupane can you please review the proposal above? Thanks!

Bump @sobitneupane for urgency. Thanks!

Thanks for the proposal @bernhardoj
Proposal from @bernhardoj looks good.
🎀 👀 🎀 C+ reviewed

Payment summary:
@sobitneupane $500 for C+ review / Requires payment through NewDot Manual Requests.
@bernhardoj, $500 for fixing the issue. Payment processed in Upwork.

@sobitneupane Please complete the checklist so I can close this issue. Thanks!

Bump @sobitneupane

@sobitneupane, please provide an update!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/31024

[ ]  [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/31024#issuecomment-1878801482

[ ]  [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

It was missed during the testing of linked PR.

[ ]  [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[ ]  [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal:

As an employee, request money on the policy expense chat or open an existing money request detail
(If there is a receipt, delete/remove it) Verify there is an add receipt thumbnail.
As an admin, open the money request detail
Verify add receipt thumbnail is hidden

Do we agree 👍 or 👎

[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

https://github.com/Expensify/Expensify/issues/357292

All set!

$500 approved for @sobitneupane based on this comment.


Clean up

[ ] Removing old Comments,
[ ] restructuring Files,
[ ] making the code more readeble
[x] changing Filenames from .h to .hpp

Chaged to hpp, but it's still manly a C Project because of the two STB Headers... lol

Removed old Comments


Desktop-Client Notification like Chrome

Hello,
i test Zulip since a few days and i noticed that the notifications in the desktop client really sucks. This bubble is good for a single notification from a programm... but not when you have a continuous conversation with some people...
Maybe it is possible to change the notification-bubble to something that looks like the notification of chrome/firefox or like in Outlook when you receive a new E-Mail.
Are there any plans for this? Is it possible to make is in the next release?
Greetings

There are no current plans for changing the notification bubbles in the desktop app.
I'm also not entirely sure what exactly you'd like to change; what platform are you using, and can you post screenshots explaining the change you'd like to see here?

I mean this Notificcation (Windows Client):

Change to something like this:

Ahh, OK.  I'd be curious to hear whether anyone prefers the current model (in which case it might make sense to make an opton to control the notification style) or whether it'd be better to just change it for everyone.
In the meantime you may be able to get the Chrome experience while still having your Zulip window be easy to find by using a pinned tab in Chrome or a second browser...

Sure... but this feature would ne nice... only the IT-department has chrome or firefox as second brower....the rest is usin IE :/

@BornToBeRoot @timabbott by rebuilding the desktop client in Node-Webkit/Electron this can be easily done.

Yep @akashnimare, I'm hoping to have one of our GSOC students take on rebuilding the Zulip desktop app using Electron, which I think will make incremental improvements easier in the future (certainly it's a stack a lot more people know than the existing QT+webkit stack).

Oh. Awesome. Should I take part in this? Have been working in electron/nw
for a year.
On Mar 8, 2016 11:13, "Tim Abbott"<EMAIL_ADDRESS>wrote:

Yep @akashnimare https://github.com/akashnimare, I'm hoping to have one
of our GSOC students take on rebuilding the Zulip desktop app using
Electron, which I think will make incremental improvements easier in the
future (certainly it's a stack a lot more people know than the existing
QT+webkit stack).
—
Reply to this email directly or view it on GitHub
https://github.com/zulip/zulip/issues/350#issuecomment-193618069.

If you're interested, sure!  See https://summerofcode.withgoogle.com/organizations/5197525313126400/ for the Zulip GSOC page.
For some background, the Zulip desktop app is actually a fairly small codebase, because it's a thin wrapper around the main Zulip web app (only ~2500 LOC that's not 3rd-party code).  The goal of that project would be to replace the QT+webkit desktop app with an electron app implementing the same functionality; if that's completed with time the spare, there's improvements to the app that we could add onto the project like fixing this bug and making the desktop app support multiple teams at the same time nicely.
Since the bug tracker isn't a great discussion forum for this sort of thing, ping me off-list if you want to discuss more!

Closing this, since the old desktop application has been completely replaced by the electron app discussed here.


[4.x] Backport documentation updates for formatting and branch renames

This backports most of

#19548 (minus actually switching to MyST)
#19601
#19607 (merged part)
#19647

lgtm, feel free to merge once CI is happy.


Dispatch safariViewController on main queue

The safariViewController dispatch was occuring on another thread.
This sometimes caused app crashes when the view was presented,
in particular if the keyboard had been presented via a TextInput or
other component. The resulting crash complained about
_cachedSystemAnimationFence and the main thread. This has been with
other React Native apps that load a viewController.
Dispatching to present the viewController on the main thread fixes this
issue.

This fix should address #179.


feat: support async iterator for paging method

Related issue: https://github.com/googleapis/gapic-generator-typescript/issues/36

we decide to implement another interface instead of passing one more option to the paging method, close this PR


Adds more convolution operations and dynamic op improvments

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Please review
https://github.com/deeplearning4j/deeplearning4j/blob/master/CONTRIBUTING.md before opening a pull request.

@maxpumperla yeah thanks missed that..will clean the names up. Copy pasta :D.

@agibsonccc yeah, happens all the time. :) Just wanted to point out all the doc string that need updates, so you don't have to (again)


Fix encrypted mount support for ecryptfs v2 wrapping (Issue #3947)

Thanks for submitting a fix!
I wonder if it would be better to use that first line to store the size of the keys, so that we don't have to try to guess it.  We can default to "80 80" if nothing is specified.
The downside is that people who have encrypted new chroots will have to re-create them (this is ok; they never worked), but people who recently encrypted unencrypted chroots would still be up a creek without a paddle (this is not ok).
Also I'm not actually sure what people do with the first line in KEYFILE currently.  In theory, if you're storing keyfiles separately, one could use the line to add whatever comments you want, which could be useful.  Using it for metadata could mess things up.
Really what I should have done from the get-go is store the wrapped keys base64-encoded on separate lines (maybe even with variable names), instead of dumping the binary directly into the file, but too late for that.
All considered, I think the current approach is fine, and we should merge it once the syntax is fixed.

Cool, I've pushed those style changes. I think supporting existing .ecryptfs files is important -- I first encountered this when adding encryption to an existing chroot, so having it work following an update would be nice.

Thanks; now we just need to run the encryption test suite on the change.


Postgres not supported when using the container image (cannot import psycopg2)

As part of the work happening in spantaleev/matrix-docker-ansible-deploy#740, I was trying to migrate matrix-registration to Postgres for us.
When the Docker container image is used and the configuration specifies db: postgresql://....., SQLAlchemy attempts to import psycopg2, which fails:

ModuleNotFoundError: No module named 'psycopg2'

I've tried fixing this by modifying Dockerfile, so that it would install py3-psycopg2 and found some strange things:

PYTHON_VERSION=3.7, yet Alpine 3.11 is used, where the default Python 3 interpreter is 3.8.x, so there is a mismatch. Installing py3-psycopg means the module gets installed to /usr/local/lib/python3.8/site-packages. The Python 3.7 interpreter this image uses actually looks for modules in /usr/local/lib/python3.7/site-packages. I guess this mismatch should be corrected anyway. And now that Alpine is on 3.12, you probably want to be on that..?

perhaps FROM docker.io/python:${PYTHON_VERSION}-alpine as builder should be changed to something more specific (instead of letting it use some random Alpine version). Not sure where it currently points right now (perhaps to 3.12?)

even with all of the above fixes, I still couldn't get import psycopg2 to work in the container's Python 3 interpreter. I'm not sure what's going on..

Interestingly, starting from a base alpine:3.12 image and installing python3 and py3-psycopg2, you can import psycopg2 without troubles.
docker run -it --rm docker.io/alpine:3.12 /bin/sh

# apk add --no-cache python3 py3-psycopg2
# python3 -c 'import psycopg2'

There is something weird going on when the image is based on docker.io/python:${PYTHON_VERSION}-alpine3.11 (no matter which Python/Alpine version is used).
docker run -it --rm docker.io/python:3.8-alpine3.12 /bin/sh

# apk add --no-cache python3 py3-psycopg2
# python3 -c 'import psycopg2'

yields
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'psycopg2'


Update README.md

Made text more coherent and concise

Thanks a lot @lkylych for the text polishing, it looks good !


Hide warning and error show on editor

The diagnostic shows like this:

How do I hide the 'E' and 'W' on the left side, and the diagnostic on the right side?

That has nothing to do with this source and cmp plugin in general. You need to set that in configuration for lsp client (I assume it's built in lsp client). You most likely have signs defined for those diagnostics, have a look at help for lsp in nvim.

This worked for me:
-- Make diagnostics less intrusive
vim.lsp.handlers["textDocument/publishDiagnostics"] = vim.lsp.with(
  vim.lsp.diagnostic.on_publish_diagnostics, {
    virtual_text = false,
    signs = false,
    underline = true,
    severity_sort = true,
  }
)

Thank you @rorystephenson!


[Experiment] - slice(state_root, slice_root, depth) function in geth + RPC API

[ ] Function slice(state_root, slice_root, depth) walks from an state or storage trie node relative to the state root, until complete the given depth.
[ ] Exports a json of hex values using the geth RPC (including the stem of the slice)
[ ] Obtain metrics of use in live (i.e. synchronizing) client

Done in geth fork


Test against PHP 7.1 and not against HHVM nightly anymore

PHP 7.1 is available on travis and HHVM is broken on travis for a while now.

@clue @jsor 👍 or 👎 ?

👍

Perhaps I'm missing something, but what is the point in adding PHP 7.1 here? Afaict there are no BC breaks and nothing we take advantage of in particular, so should we really keep adding new versions to our ever growing test matrix? Also, what about our other components?
:+1: on dropping unsupported/broken hhvm-nightly builds
+-0 on adding PHP 7.1 support

Right the addition of 7.1 is a force of habit of always testing against all supported versions. I'm +-0 on it to be honest so if anyone insists on not testing against it that is fine by me since we also test against 7.0.


Add MarkJob, MarkJobParser

added MarkJob class
added MarkJobParser class
added abstract methods Model::getFilteredJobList, Model::jobStatusUpToDate
added overridden methods ModelManager::getFilteredJobList, ModelManager::jobStatusUpToDate
added invalid index error message to Messages
added new Job constructor to be used by MarkJob command
updated overridden methods in AddJobTest, AddApplicantTest, AddCommandTest
TODO: MarkJobTest

Codecov Report

Merging #142 (1545a4b) into master (0237858) will decrease coverage by 1.41%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
- Coverage     72.35%   70.94%   -1.42%
  Complexity      666      666
============================================
  Files           109      111       +2
  Lines          2261     2306      +45
  Branches        277      282       +5
============================================
  Hits           1636     1636
- Misses          513      558      +45
  Partials        112      112

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...java/seedu/address/logic/commands/job/MarkJob.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
64.00% <0.00%> (-2.67%)
:arrow_down:

...du/address/logic/parser/job/MarkCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
84.00% <0.00%> (-3.50%)
:arrow_down:

src/main/java/seedu/address/model/job/Job.java
69.73% <0.00%> (-11.81%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0237858...1545a4b. Read the comment docs.

LGTM


New web UI component for lists of editable entities

With the forthcoming effort to remove functionality from the admin console, we would like to have a consistent look and feel for the listing of editable entities (e.g. Courses / Reports / Schemas / Collections etc)
Or perhaps we provide a tree interface which each entity type a root level node?

Makes sense to have that kind of an interface.  Given what the Admin Console can do, the entities should be able to have a generic CRUD structure as long as we allow for a customizable entity edit page (Hierarchy editor will be quite a bit different then a Report editor)

For 6.6 we've decided on a simple search like interface for selecting courses to edit. However we'll probably revisit this at some stage.

Maybe it's implicit, but will users be able to edit a course from this flow as well (not just create and search courses)?

@cbeach47 Yeah it'll be for deleting, creating and editing.


Accessing instance variables in then block

I can't seem to access class variables in my then block:
For example
class GradientView {
   let colors = ...
   lazy var gradientLayer = CAGradientLayer().then {
       $0.colors = self.colors // also tried colors
   }
}

doesn't work, but
class GradientView {
   let colors = ...
   lazy var gradientLayer: CAGradientLayer = {
       let layer = CAGradientLayer()
       layer.colors = self.colors
       return layer
   }()
}

does.
Can I repeat my old pattern of accessing instance variables in a lazy init using Then?

@AndrewSB, sorry for delay! It seems like a Swift bug. Try add type annotation to gradientLayer.

class GradientView {
   let colors = ...
   lazy var gradientLayer: CAGradientLayer = CAGradientLayer().then {
       $0.colors = self.colors // also tried colors
   }
}

@AndrewSB, Doesn't it work?

It does! Thanks @devxoul!


想问下用wechaty会被微信官方封号吗？

刚来这个项目，非常感谢作者，想请教下大家这个是用的什么登录原理，会被封号吗？谢谢

There is documentation for developer to get deep into wechaty, so I suggest that you can read it later to know more.
How does login process work depending on what type of token you are using, please refer to: puppet-service doc to get more info about login process.
Wether your account is going to be blocked is depending on what you have done in IM platforms, eg: Wechat, DingTalk, Lark,  WhatsApp and so on. So we suggest that wechaty developers should do right things and don't do anything against the law.  If you according to the rules, it should not be blocked. Hope that it can help you.

Thanks a lot for your kind reply.
Best，
Yoga
骑马小猫 @.***> 于2021年11月12日周五 下午4:58写道：

There is documentation for developer to get deep into wechaty
https://wechaty.js.org/docs/wechaty, so I suggest that you can read it
later to know more.
How does login process work depending on what type of token you are using,
please refer to: puppet-service
https://wechaty.js.org/docs/puppet-services/overview doc to get more
info about login process.
Wether your account is going to be blocked is depending on what you have
done in IM platforms, eg: Wechat, DingTalk, Lark, WhatsApp and so on. So we
suggest that wechaty developers should do right things and don't do
anything against the law. If you according to the rules, it should not be
blocked. Hope that it can help you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wechaty/python-wechaty/issues/278#issuecomment-966932910,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQUUTPVABIERPASJM62VK3ULTJKXANCNFSM5H4EDV3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
i yjqforever!


Query: How to configure the Imou cameras for Dual Audio

Hi,
I am not sure if this is the right forum to discuss. I recently tried to enable Dual Audio for one of my Imou Cue 2 Camera but it didn't work. The camera has two rtsp stream urls, I added both of them to go2rtc config.
I could hear one way audio (from camera to mobile/pc) but the dual audio didn't work for me.
Even though I could see the live stream but couldn't here any audio on either side.
I need help to know if Imou cameras supported for dual audio.

Check stream info for active stream in WebUI. Probably your camera doesn't support two way audio standards. And uses some proprietary protocol.

This is what I have under the stream info.  I am new to this and not able to conclude anything.
Could you please help?
From: Alex X @.***
Sent: Wednesday, July 26, 2023 3:02 PM
To: AlexxIT/go2rtc @.>
Cc: mannish-kumar @.>; Author @.***>
Subject: Re: [AlexxIT/go2rtc] Query: How to configure the Imou cameras for Dual Audio (Issue #548)
Check stream info for active stream in WebUI. Probably your camera doesn't support two way audio standards. And uses some proprietary protocol.
—
Reply to this email directly, view it on GitHub https://github.com/AlexxIT/go2rtc/issues/548#issuecomment-1651361021 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AU37MGL6K75T4NKJ57W2TSLXSDP2RANCNFSM6AAAAAA2YIAGNY .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AU37MGP7JGY4JESNWNZMKZDXSDP2RA5CNFSM6AAAAAA2YIAGN2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTCNXCP2.gif Message ID: @.*** @.***> >

So your camera doesn't support open two way audio standards. It can't be helped.

Most of the brands doesn't mention much details in their specs in India. Do you know any cameras that supports this and I can buy.
How about Tapo C110. As per the video on youtube (https://youtu.be/WnRJxneCUYE) it looks like it is supported.


Validation crashes on top-level null-valued object attributes

When validating an object like this:
{"title":"My Title","description":null}

Schema validation crashes with:
2017-03-22 17:07:29,672 ERROR [pyramid_debugtoolbar:233][waitress] Exception at http://localhost:6543/images/402e0db8-0de2-4c31-b423-6de2a302c58d
traceback url: http://localhost:6543/_debug_toolbar/exception?tb=4511419416&token=62275c7862665c783935653f725a5c7866365c786530325c78623627
Traceback (most recent call last):
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid_debugtoolbar/toolbar.py", line 215, in toolbar_tween
    response = _handler(request)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid_debugtoolbar/panels/performance.py", line 57, in resource_timer_handler
    result = handler(request)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid/tweens.py", line 51, in excview_tween
    request_iface=request_iface.combined
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid/view.py", line 612, in _call_view
    response = view_callable(context, request)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid/viewderivers.py", line 351, in authdebug_view
    return view(context, request)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid/viewderivers.py", line 409, in viewresult_to_response
    result = view(context, request)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid/tweens.py", line 22, in excview_tween
    response = handler(request)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid_swagger/tween.py", line 173, in validator_tween
    validation_context=validation_context)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid_swagger/tween.py", line 459, in _validate
    return f(*args, **kwargs)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/pyramid_swagger/tween.py", line 570, in swaggerize_request
    request_data = unmarshal_request(request, op)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/bravado_core/request.py", line 66, in unmarshal_request
    param_value = unmarshal_param(param, request)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/bravado_core/param.py", line 200, in unmarshal_param
    value = unmarshal_schema_object(swagger_spec, param_spec, raw_value)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/bravado_core/unmarshal.py", line 59, in unmarshal_schema_object
    return unmarshal_object(swagger_spec, schema_object_spec, value)
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/bravado_core/unmarshal.py", line 136, in unmarshal_object
    if schema.has_default(swagger_spec, prop_spec):
  File "/Users/daine/Developer/images/venv/lib/python3.5/site-packages/bravado_core/schema.py", line 22, in has_default
    return 'default' in swagger_spec.deref(schema_object_spec)
TypeError: argument of type 'NoneType' is not iterable

@DaineDanielson this issue is a bravado-core issue related to the last released version. More context is available on https://github.com/Yelp/bravado-core/issues/163.
Until the bravado-core issue is not fixed you'll continue to get this error.
For the moment my suggestion is to pin bravado-core < 4.7.0

I was in the midst of writing my own PR for bravado-core when you replied with that link. Thanks!

Fixed in Yelp/bravado-core#165.


Update typescript definitions for release 0.14

Update typescript definitions:

update actions definition to reflect the fragmented state
delete mixins and events definitions
update the test to utilize fragmented state

One thing that would also be good to show an example of is a type safe higher order app.

The typescript definitions are missing several other pieces to be complete:

a proper definition for Thunk
a proper definition for the jsx namespace (intrinsic elements + their props, maybe we could take them from preact? It's MIT so should be fine...)
examples with HOA + above points
I probably forgot a bunch.

I may open an issue to gather all those and fix them little by little..

Opened #409 to track these items. Can we merge this?


Possiblity of having glare always on, even without hovering

Can you explain more about what you mean and its use case?
Do you want to control the glare elements in the code separately without tilting the component itself?
Or do you want to set a default (rest) position/opacity for the glare elements?

@rashidshamloo What I mean is basically having the glare effect always on, in a static preset position.
So even if I start hovering over the element, the glare effect will still stay there visible.

^ Basically look like this even without tilting the card.

Thanks for the explanation.
I have added the lineGlareFixedPosition and spotGlareFixedPosition properties which can be used to set a fixed position for the glare elements.
You can supply preset positions like "top-left", "center", etc. as well as precise positions by providing an object containing the left property for the line glare element. and left and top properties for the spot glare element.
example:
spotGlareFixedPosition="top-left"
spotGlareFixedPosition={{ left: '20%', top: '50px' }}
left and top properties can be set to percentage as well as pixel values.
These properties can also be used to animate the glare elements inside the code without affecting or being affected by the tilt angle.
You can play around with them (the presets) in the Storybook:

Line Glare
Spot Glare

Please let me know if this works for your use case.


DateTimePicker Component Not Functioning Correctly with Multiple Instances in Latest Filament Update

Package
filament/filament
Package Version
v3.2.130
Laravel Version
v11.35.1
Livewire Version
v3.5.17
PHP Version
PHP 8.3
Problem description
The DateTimePicker component does not function as expected when multiple instances are used in a form. The date selectors fail to display correctly after updating to the latest version of Filament.
Tested with an older version (without the latest updates), and it worked fine. This suggests the issue may be related to recent changes in the Filament update.
Screenshot of the current issue

Expected behavior
It should display relevant dates for all multiple DateTimePicker components.
Steps to reproduce

Create Multiple DateTimePicker in a FIlament form.
Pick a date from the first DateTimePicker
Pick a date from 2nd DateTimePicker

Reproduction repository (issue will be closed if this is not valid)
https://github.com
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

@danharrin

Please double check your Filament version composer show filament/filament.
If it is correct and not something lower than the latest release, try downgrading Livewire to v3.5.12 and let me know if it fixes.
If you create a reproduction repository this issue can be reopened.

same


[cloudflared] - Add support for prometheus metrics

Add support for prometheus metrics

Hi @nushkovg is there any chance to review this please?

@nushkovg thank you!


fix(versions): update Activiti/activiti-cloud-notifications-graphql versions into master

UpdateBot pushed maven dependency: org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies to: 7.1.149

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies 7.1.149


Support formatter plugins

Fluentd 0.10.58 or later supports formatter plugin feature.

Could you fix conflicts? Sorry for inconvenience. Thanks,

Rebased!

Thanks!


Model Description
E-Drive passport as a deviation from the Digital Product Passport.
Includes attributes from the transmission.transmission_passport, which will be deprecated in the future.
Relevant Standards

Example Data

DPP general data for metadata of a passport
Transmission data

MS1 Criteria

[ ] The proposed aspect model does not exist already
[ ] The proposed aspect model does not extend an existing aspect but introduces completely new functionality
[ ] The proposal references a Catena-X use case
[ ] Relevant standards are mentioned/linked
[ ] A first draft of the data structure is provided in an example
[ ] A modeling steward has been assigned

Modeling_Team

The proposed aspect model does not exist already -> OK
The proposed aspect model does not extend an existing aspect but introduces completely new functionality -> OK
The proposal references a Catena-X use case -> OK
Relevant standards are mentioned/linked -> OK
A first draft of the data structure is provided in an example -> OK
A modeling steward has been assigned -> @agg3fe


Support exclusive_range_pattern

Fix #9779

Note: There are some more unstable range patterns that are not supported yet as well, for instance, ..=2 or such. I am just fixing the one that is getting stabilized in 1.55.

@bors r+

bors r=matklad

bors seems to have crashed earlier today so its stuck
bors r-
bors r=matklad


Fix deprecated command line argument

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.70%. Comparing base (2f1926a) to head (c2f63df).

:exclamation:  There is a different number of reports uploaded between BASE (2f1926a) and HEAD (c2f63df). Click for more details.
HEAD has 16 uploads less than BASE

Flag
BASE (2f1926a)
HEAD (c2f63df)

18
2

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #37       +/-   ##
===========================================
- Coverage   70.59%   43.70%   -26.90%
===========================================
  Files          15       15
  Lines        2850     7821     +4971
  Branches        9        0        -9
===========================================
+ Hits         2012     3418     +1406
- Misses        838     4403     +3565

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


spring-data-dynamodb 4.4.0 unavailable in maven/sonatype repositories

You are right. Thanks for reporting.
Will investigate

I'm stuck on this too;
#50 is closed, but 4.4.0 is not available. Please let us know once this is ready.

Tried to do a new release. It went through Sonatype's Nexus. Let's hope it appears in Central soon

4.4.1 (which is the same as 4.4.0) is available in Maven Central:
https://repo1.maven.org/maven2/com/github/derjust/spring-data-dynamodb/4.4.1/
It might not appear in Maven Central searches yet but Maven & Co should be already be able to pull it

Thanks! All worked out well! Appreciate all your help.

Was able to use 4.4.1. The build worked! Thanks for the quick turn around


Add an Awards entry for CRN recognition

Fixes #4632.

looks sane ... couldn't see the .png ... hope you picked a good one
On Fri, Nov 20, 2020 at 4:08 PM Christian Nunciato<EMAIL_ADDRESS>wrote:

@cnunciato https://github.com/cnunciato requested your review on: #4633
https://github.com/pulumi/docs/pull/4633 Add an Awards entry for CRN
recognition.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/pulumi/docs/pull/4633#event-4023212815, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB77TQWV4G5FEGDWEKFJYXTSQ4AJNANCNFSM4T5LT5MQ
.

@zchase I think so, yeah, but we can definitely change this if you think we should.


Suggestion #NewFeature - Persist sound volume configs locally

I need to keep the same sound volume after close and reopen de site.
I'm stared recently with Angular, Maybe you(@trungk18) can help with a video tutorial about that.
I loved the project and I want to contribute with them in the future.
Thanks!

@wellington1993 Thanks, that's a great suggestion. I'll add it in maybe tonight or tomorrow. I think it is already built in Spotify API, so what I need to do is to get the volume from Spotify API and set it along when initializing the Angular Spotify Web Player 😆
As I mentioned on the repo, there are some live stream sessions coming soon. And seems you have already waiting for the first one. Looking forward to seeing you there!

Thanks! @trungk18 I'm suggesting some thinks to learn Angular too!
Nice work.

@wellington1993 Sorry for not starting on that, I thought Spotify SDK will remember the volume when I connect to the player but turned out It didn't hehe. I'll need to store the volume inside localStorage then, but before getting into that. I need to finalize what I want to have in the storage too. Will get back into this issue in the next couple days.

Hi @trungk18! Is this considered as closed from #53 ?  If not, what else needs to be done to close it?

@nikosanif Thanks for reminding me. I forgot to close it 🤣


Upgrade eslint to v5.11.1 and grunt-eslint to v21

Coverage remained the same at 81.639% when pulling 3d5ae087c1550aa8c6e7a7b0ae556873ec8dfd5c on jimjenkins5:upgrade_eslint into 473585bff34932e034342232bfe97eead5d366b0 on silvermine:master.

Looks fine.


How to best work together with this team while adapting it to make it our own

what's the teams recommended way to make data.all our own while still receiving upstream updates?
Currently it's more of a boilerplate/quickstarter but ideally, we'd like to continue pulling in changes from upstream. However, that would require pretty big integration efforts from our side to merge in changes while also changing the theme, entity names (e.g. organisation/domain) etc.
Any recommendations?

Hello,
Customers usually fork the awslabs/aws-dataall repository and create their own branch from which they deploy data.all in their AWS accounts. In this way, they can configure their data.all deployment in their custom branch, and receive updates by merging from the main branch.
This works well if you do not diverge to much from the open-source version (main branch). Customers that want to keep close to the main branch just have to change the cdk.json and cdk.contect.json files, which are the config files for the deployment.
However merge conflicts might appear if you start diverging form the open-source version (editing some functionalities, changing naming convention, ...). Here you have two solutions:

Resolve potential conflicts when merging from the main branch
Create a pull request to edit the main branch. If your change benefits other users (adding a new functionality for example), then the team will accept the merge and your version will be similar to the main branch again which means easier code merge for you.

If you need new data.all features and want to create them, I suggest that you create an Github Issue first, so that the data.all team is aware of what you are doing. This will help having your code integrated in the main branch.
I hope this answers your question.


N46: Tooling updates

_Part of #1378

Tnx!

<..> from scirin:source

Since we're using squash&merge PR resolution, it's much easier to use a separate named branch for each PR, something like n46-tooling in this case, to avoid having a divergent history in your main branch.


Add strategy to run tests with the "old" and "new" K8s versions

Signed-off-by: Alexey Roytman<EMAIL_ADDRESS>

@roytman LGTM. There is a setting of K8S_VERSION=1.19.2 in  install_kubebuilder.sh script. not sure if that should be changed too

@roytman LGTM. There is a setting of K8S_VERSION=1.19.2 in install_kubebuilder.sh script. not sure if that should be changed too

Thanks @revit13 , let's put it in a separate commit

/cherry-pick branch=releases/0.6.4


Serialize stepfn execution

This is an attempt to address the issues described in #106 just serializing the execution of every stepfn.
This approach should allow us to reenable other features of testing.T, like Cleanup and Deadline
Changes

:broom: Serialize StepFn execution

cc @dprotaso @n3wscott WDYT about this PR to start approaching the issues of #106?

@n3wscott @dprotaso I've refactored again execution.go and added a test to environment_test.go to show the potential of my idea here. In short, I've implemented two policies:

If a requirement fails, no assertions are executed, but teardown are, and the test is marked as skipped more than failed, with the proper cause
If a setup fails, no requirements and assertions are executed, but teardown are, and the test is marked as failed

I've also added a comment about how IMO we should execute asserts and record their results, aka run them all and then check if we reached a certain compliance level.
There is some duplicated code I know, I'll remove it later, but now it's ok and it shows my point. For some reason github actions are not executing e2e tests, but you can try these on your local machine and you see they work as expected


Spring Cloud Contract - Spring Kafka

As per the discussion with Marcin on Twitter, Spring Cloud Contract does not have implementation to support pure Spring Kafka Template.  As, there is no feature for spring cloud contract to support spring kafka template.
Can I please request to have the implementation?

Is there any plans when it will be done?

Hello, it's in the backlog @IrishkA13 and it will  be done; will try to add it for Hoxton release.

I think I have a prototype working. Does anyone have a sample I could play with?

@jakubnabrdalik

@IrishkA13 2.2.0.M3, so I assume it goes to future release 2.2.0.RELEASE (so it's not released yet, just M3)

@mfolnovic thanks for reply
Are there any planned dates for 2.2.0.RELEASE?

Please check https://github.com/spring-cloud/spring-cloud-release/milestones for release dates

Hi!
I added one field to your sample kafka contract.
Contract.make { 	label("trigger") 	input { 		triggeredBy("trigger()") 	} 	outputMessage { 		sentTo("topic1") 		body([ 		        foo: 'example', 			bar: 'example2' 		]) 	} }
and change application-test.yaml (consumer side)
spring:   kafka:     bootstrap-servers: ${spring.embedded.kafka.brokers}     producer:       properties:         "value.serializer": "org.springframework.kafka.support.serializer.JsonSerializer"         "spring.json.trusted.packages": "*"     consumer:       properties:         "value.deserializer": "org.springframework.kafka.support.serializer.JsonDeserializer"         "value.serializer": "org.springframework.kafka.support.serializer.JsonSerializer"         "spring.json.trusted.packages": "*"       group-id: groupId
I also add "bar" field to Foo2 class on the consumer side. Now if I run the ApplicationTests on the consumer side I have exception like this:
Caused by: org.springframework.kafka.support.converter.ConversionException: Failed to convert from JSON; nested exception is com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of com.common.Foo2 (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('{"foo":"example","bar":"example2"}')  at [Source: (String)""{\"foo\":\"example\",\"bar\":\"example2\"}""; line: 1, column: 1]
This exception is caused by:

extra " sign at the start and end of the message
backslashes

When I add this hack everythinks works. Is there any other way to solve this?
`	@Bean
@Primary
public RecordMessageConverter converter() {
return new StringJsonMessageConverter() {
@Override
protected Object convertPayload(Message<?> message) {
//				return super.convertPayload(message);
String value = (String) super.convertPayload(message);
if (value.length() > 2 && value.startsWith(""") && value.endsWith(""")) {
value = value.substring(1, value.length() - 1);
			}
			return StringEscapeUtils.unescapeJson(value); //apache commons
		}
	};
}`

I think I had a similar issue so to speak. In the tests (https://github.com/spring-cloud/spring-cloud-contract/tree/master/tests/spring-cloud-contract-stub-runner-kafka), what I did was:
application.yml
spring:
  kafka:
    bootstrap-servers: ${spring.embedded.kafka.brokers}
    producer:
      properties:
        "value.serializer": "org.springframework.kafka.support.serializer.JsonSerializer"
        "spring.json.trusted.packages": "*"
    consumer:
      properties:
        "value.deserializer": "org.springframework.kafka.support.serializer.JsonDeserializer"
        "value.serializer": "org.springframework.kafka.support.serializer.JsonSerializer"
        "spring.json.trusted.packages": "*"
      group-id: ${random.value}

that's how I received the message
private boolean assertThatBodyContainsBookNameFoo(Object payload) {
		log.info("Got payload [" + payload + "]")
		String objectAsString = payload instanceof String ? payload :
				JsonOutput.toJson(payload)
		def json = new JsonSlurper().parseText(objectAsString)
		return json.bookName == 'foo'
	}

I'm no Kafka expert, so maybe what I did is just a hack. I guess we would need to ask @olegz , @sobychacko or @garyrussell for help if what I did is actually a hack .

BTW this is how we construct the message you then receive (https://github.com/spring-cloud/spring-cloud-contract/blob/master/spring-cloud-contract-verifier/src/main/java/org/springframework/cloud/contract/verifier/messaging/kafka/KafkaStubMessages.java#L97-L173)

class Record {

	private final ConsumerRecord record;

	Record(ConsumerRecord record) {
		this.record = record;
	}

	private Map<String, Object> toMap(Headers headers) {
		Map<String, Object> map = new HashMap<>();
		for (Header header : headers) {
			map.put(header.key(), header.value());
		}
		return map;
	}

	Message toMessage() {
		Object textPayload = record.value();
		// sometimes it's a message sometimes just payload
		MessageHeaders headers = new MessageHeaders(toMap(record.headers()));
		if (textPayload instanceof String && ((String) textPayload).contains("payload")
				&& ((String) textPayload).contains("headers")) {
			try {
				Object object = new JSONParser(JSONParser.DEFAULT_PERMISSIVE_MODE)
						.parse((String) textPayload);
				JSONObject jo = (JSONObject) object;
				String payload = (String) jo.get("payload");
				JSONObject headersInJson = (JSONObject) jo.get("headers");
				Map newHeaders = new HashMap(headers);
				newHeaders.putAll(headersInJson);
				return MessageBuilder.createMessage(unquoted(payload),
						new MessageHeaders(newHeaders));
			}
			catch (ParseException ex) {
				throw new IllegalStateException(ex);
			}
		}
		return MessageBuilder.createMessage(unquoted(textPayload), headers);
	}

	private Object unquoted(Object value) {
		String textPayload = value instanceof byte[] ? new String((byte[]) value)
				: value.toString();
		if (textPayload.startsWith("\"") && textPayload.endsWith("\"")) {
			return textPayload.substring(1, textPayload.length() - 1).replace("\\\"",
					"\"");
		}
		return textPayload;
	}

}

I found the root cause of the error.
StubRunnerExecutor.java
	private void sendMessage(Contract groovyDsl) {
		OutputMessage outputMessage = groovyDsl.getOutputMessage();
		DslProperty<?> body = outputMessage.getBody();
		Headers headers = outputMessage.getHeaders();
		// TODO: Json is harcoded here
		this.contractVerifierMessaging.send(
				JsonOutput.toJson(BodyExtractor.extractClientValueFromBody(
						body == null ? null : body.getClientValue())),
				headers == null ? null : headers.asStubSideMap(),
				outputMessage.getSentTo().getClientValue());
	}

The message is serialized to json before send to Kafka topic. Then KafkaTemplate use RecordMessageConverter to serialize already serialized json.
Finally, we have a twice serialized json message. If we receive message like this the deserializer cannot deserialize it to target object because after deserialization we have a String containing json (created by StubRunnerExecutor).
The message passed to KafkaTemplage cannot be serialized to json. This will allow Record MessageConverter to serialize the message to the target form.

We've decided to go with the middleware based approach for messaging as presented in https://github.com/spring-cloud-samples/spring-cloud-contract-samples/tree/main/producer_kafka_middleware and https://github.com/spring-cloud-samples/spring-cloud-contract-samples/tree/main/consumer_kafka_middleware .
That means we want to encourage the user to use e.g. testcontainers to start an actual broker and then use the MessageVerifierSender / MessageVerifierReceiver implementations to tell us how to send and receive a message


React DataTable Column Resizing Not Being Applied

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
When using DataTable, adding the resizeColumns prop makes no functional difference and the columns are still fixed size.
By setting a breakpoint in DataTable.js in Chrome DevTools, you can see that without the prop, resizeColumns is undefined:

And then when the prop is present, it is set to true:

So the props are being set correctly but from there, the value isn't being applied correctly.
This issue persists even when explicitly setting disableResizing to false in the column defs.
npm 8.15.0
node 16.17.0
Reduced test cases
    <DataTable
      id="activities_table"
      columns={ACTIVITIES_FIELDS} bordered hover
      responsive
      disablePagination
      data={MOCK_ACTIVITIES}
      resizeColumns
    ></DataTable>

What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome 106
What version of Modus React Bootstrap are you using?
v1.1.4
Priority
Medium

@owebb98 I talked to<EMAIL_ADDRESS>and the issue seems to be fixed. Please confirm.

@owebb98 I talked to<EMAIL_ADDRESS>and the issue seems to be fixed. Please confirm.

Hi @msankaran0712, yes, this is now working as expected after changing our styles.scss file to use<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>I will close this issue now. Many thanks


Merge current 1.x release into master

I've run into a blocker for us in issue #327 and thought I'd just go through the code and create a merge. This merges #345 and #347 so 2.x branch is up-to-date.
Hopefully this will unblock a 2.x release, since Drupal is waiting for this and out package swisnl/json-api-client.

Great news, thank you! It could use nightly for PHP 8.0 run

Ok, onbly check that fails is the phpstan one. But not sure how much i should change for these errors.
 ------ -----------------------------------------------------------------------------------
  Line   Message.php
 ------ -----------------------------------------------------------------------------------
  148    Variable $headerLines in PHPDoc tag @var does not match assigned variable $count.
 ------ -----------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   Utils.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------
  301    Parameter #1 $fp of function fwrite expects resource, resource|false given.
  301    Parameter #2 $str of function fwrite expects string, bool|float|int|string given.
  302    Parameter #1 $fp of function fseek expects resource, resource|false given.
  304    Parameter #1 $stream of class GuzzleHttp\Psr7\Stream constructor expects resource, resource|false given.
  309    Parameter #1 $stream of class GuzzleHttp\Psr7\Stream constructor expects resource, (callable)|Iterator|Psr\Http\Message\StreamInterface|resource|null given.
  322    Parameter #1 $object of function method_exists expects object|string, (callable)|resource|null given.
  327    Parameter #1 $stream of class GuzzleHttp\Psr7\Stream constructor expects resource, resource|false given.
  353    Parameter #1 $callback of function set_error_handler expects (callable(int, string, string, int, array): bool)|null, Closure(): void given.
  370    Method GuzzleHttp\Psr7\Utils::tryFopen() should return resource but returns resource|false.
  396    Unreachable statement - code above always terminates.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------

There, i've fixed the last phpstan errors, either by some extra checks or adding an ignore to lines where phpstan doesn't completely understand the code.

So, just to confirm, there are no calls to the "functions" now, only to "static class methods", just like in the 1.x series. The next step would be to delete the functions entirely from the 2.x series.

All function calls are removed and i even removed the functions.php itself and ots tests. This was i could verify there was nothing left. So yeah, fully merged and deprecated finction have been removed :)
Sent from Ninehttp://www.9folders.com/

Van: Graham Campbell<EMAIL_ADDRESS>verzonden: donderdag 26 november 2020 01:19
Aan: guzzle/psr7
Cc: Björn Brala; Author
Onderwerp: Re: [guzzle/psr7] Merge current 1.x release into master (#360)
So, just to confirm, there are no calls to the "functions" now, only to "static class methods", just like in the 1.x series. The next step would be to delete the functions entirely from the 2.x series.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/guzzle/psr7/pull/360#issuecomment-734003705, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZEN6W2DYXOGAGMHQD7P3TSRWNGZANCNFSM4UBC2BQA.

Excellent. 👍

@Tobion valid point, will fix that. Seems there was some feedback also on the PR which was disregarded until 2.0, so that would mean some slight extra changes.

I think it would be fine for that to be sorted in a follow-up PR. It's more important the other changes from 1.x make it into master than the test suite runs on PHPUnit 9. End users don't use the tests, but they do use what's in src. ;)

Seems the tests were already merged, but forgot the change in the composer.json and phpunit.xml.dist. Hopefully everythings is green ;)

I believe the changes requested in https://github.com/guzzle/psr7/pull/360#pullrequestreview-547178164 have been resolved, correct? @Tobion can you confirm that they've been addressed? Thanks!

@Tobion hope you had a nice newyears, any chance you can review this any time soon?

@Tobion hope you had a nice newyears, any chance you can review this any time soon?

The HHVM specific code in this PR should be deleted. 2.x does not support HHVM, so the HHVM fixes in this PR should be taken out.

The HHVM specific code in this PR should be deleted. 2.x does not support HHVM, so the HHVM fixes in this PR should be taken out.

Sure, i removed the 2 skips for the tests on HHVM.

Sure, i removed the 2 skips for the tests on HHVM.

Would be nice to get this moving again :)

I've looked at this and at first sight it looks good to me. Hard to compare the functions to the static calls though, but the tests are passing so 👍

Thank you Barry.
The more people that review and tests this the more confident will the maintainer be to merge it. Your comment is much appreciated.

@nyholm and I have discussed this PR, and it includes unrelated changes and the merges to the utils classes seem to accidentally remove 2.x changes including return types. For this reason, I am going to start again here, so I can be sure everything is correct. Verifying everything in this PR is correct is as much work as me starting again here.
I appreciate everyone's efforts here, and I hope this doesn't put anyone off future contributions. We just have to make sure the merge is good. :)

I’m sure you done the best you possible can for this PR. But I cannot be 100% sure of the correctness. I also don’t know you as a contributors.
This might be an issue with my need for control or trust issues, but if you where a person with poor intentions, this is a exactly the kind of PR one should hide bad code in.
We will make sure a version of this PR is merged in the next few days.

No problem at all. My main goal doing the work was to get this going and merged. I'm glad that is happening soon, even though its not my commit. Thanks for taking the time to get this up and running soon 😀
Outlook for Androidhttps://aka.ms/ghei36 downloaden

From: Tobias Nyholm<EMAIL_ADDRESS>Sent: Sunday, March 7, 2021 4:56:46 PM
To: guzzle/psr7<EMAIL_ADDRESS>Cc: Björn Brala<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [guzzle/psr7] Merge current 1.x release into master (#360)
I’m sure you done the best you possible can for this PR. But I cannot be 100% sure of the correctness. I also don’t know you as a contributors.
This might be an issue with my need for control or trust issues, but if you where a person with poor intentions, this is a exactly the kind of PR one should hide bad code in.
We will make sure a version of this PR is merged in the next few days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/guzzle/psr7/pull/360#issuecomment-792300654, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZEN6R5EP6VRMGPYPDOIEDTCOO35ANCNFSM4UBC2BQA.

If there is a new PR, can it be linked? As I understand this was blocking the availability of PSR-17 support in a stable release. Thanks!

It is not.
It has been multiple PRs. See the PRs creates in the past few days. Also note that master is already updated with code from 1.x.

Reference for my comment: https://github.com/guzzle/psr7/issues/327#issuecomment-696365081

I guess my question is, if this is not the way forward to have PSR-17 support in a stable release, then what is? We need some guidance since #327 has been stalled nearly a year and the last advice we were given here was to try to make that merge happen.


Wagtail must use "pk" instead "id" for users models

I'm using a custom user model with a primary key called "Identified" instead "id". Wagtail obliged to use "id", which is incorrect. If "pk" is used, it always works and will be more correct.
Examples of the error:

NoReverseMatch at /cms/users/
Reverse for 'edit' with arguments '('',)' and keyword arguments '{}' not found. 1 pattern(s) tried: [u'cms/users/([^\/]+)/$']

Source:

**/wagtail/wagtailusers/templates/wagtailusers/users/list.html
{% url 'wagtailusers_users:edit' user.id %}
">{{ user.get_full_name|default:user.get_username }}

Other error:

FieldError at /cms/users/default|gis/
Cannot resolve keyword 'id' into field. Choices are: auth_token, client, contact, date_joined, document, editeds_by, email, first_name, full_name, groups, historicalavailability, identified, image, is_active, is_staff, is_superuser, last_login, last_modified, last_name, logentry, metadatas, note, owned_pages, pagerevision, password, processedavailability, salutation, savefilter_created_by, savefilters, selectmark, site_group, user_permissions, username, userprofile

Source:

***/wagtail/wagtailusers/views/users.py in edit
@permission_required(change_user_perm)
def edit(request, user_id):
user = get_object_or_404(User, id=user_id) ...

I created PR #2352.
Also I think that would be better to use "pk" for all models inside of Wagtail. I found more than 820 usages of ".id" in *.py files (most of them in tests) and more than 160 in *.html. It's probably not so important for Wagtail users, but gives more flexibility for Wagtail's developers.

Fixed in #2352.
Standardising on pk in our code is probably a good habit to get into, but it's less important for Wagtail's own models (where we know the primary key will always be id) so I think this fix is sufficient for now.


Best Fit Line: The tooltip formula does not apply to RTL

1: Turn on best fit line
2: Turn on RTL
Check tooltip
If it should be handling RTL that is? Don't really know with math formulas

@pernyl what do you expect to be different for RTL

We discussed it a bit and it will not look good if we try to change the formula in an RTL way. Better to leave it as it is


Cobra Issue: error when using with node.js for a server

Make sure you have read the documentation, and have put forth a reasonable effort to find an existing answer.
Expected behaviour
Actual behaviour
after installing the sdk and trying to use it, I'm getting this error:
node:internal/modules/cjs/loader:1080
throw err;
^
Error: Cannot find module '@picovoice/cobra-web'
Require stack:
Steps to reproduce the behaviour
(Include enough details so that the issue can be reproduced independently.)

How did you install it, how are you using it? need more info.

I installed it with npm install --save @picovoice/cobra-web
I'm running my serve on linux
importing like this:
const CobraWorker = require('@picovoice/cobra-web');
and then getting the error

Is this for a node.js backend project or frontend?

Node.js backend

As mentioned here https://github.com/Picovoice/cobra/tree/main/binding/web#compatibility, Cobra-web is for web only. Cobra has no support for Node.js at the moment.


Red Subtle Buttons

Testing visual-diff, probably should not merge 😛

The red buttons are a bit too aggressive - closing


Fix CI config

It seems that yaml sees an unquoted on value as true.
Take a look if it would works.
Also, I wanted to ask you to turn on CI on PR branches.

I turned CI setting on.
Thank you for fix!


Correct bug chinese page proxies

Correct list number bug in page https://kubernetes.io/zh/docs/concepts/cluster-administration/proxies/
This is a bug similar to https://github.com/kubernetes/website/issues/21257

/lgtm
/approve


Dynamic configuration of property source using label rather than names

I suggest taking futher step from ConfigMap PropertySource and allow support controller about kubernetes.
Suggest configuration is:
spring:
  application:
    name: cloud-k8s-app
  cloud:
    kubernetes:
      config:
        namespace: default-namespace
        sources:
         # Spring Cloud Kubernetes will lookup a ConfigMap labeled config-label with value c1 in namespace default-namespace
         - label: config-label
           value: c1
         # Spring Cloud Kubernetes will lookup a ConfigMap labeled config-label2 with value c3 in namespace in namespace n3
         - namespace: n3
           label: config-label2
           value: c3

Each add/patch/remove of config maps with this these ConfigMap will change the configuration.
The ConfigMap will be used same as they directly wrote as part of spring configuration

Can you please describe more in depth what you are trying to do beyond what is currently available? I'm having a hard time understanding.

@spencergibb  I have dozen of config maps (hierocracy) for same micro service and want to allow spring-cloud-kubernetes to track them all.

@AssafKatz3 I would love to understand your use case a little more, currently I feel that I am missing some piece of information :)

@geoand I have micro service that can be configured by our customers and in some cases per environment basis. This means that the relevant list of config map for this micro service is dynamically from code perfective. Sometime I have one config map, sometime two, sometime three (depended on running environment). Moreover, the name of exact config map can be different (contains the environment for example) so it is complex to hard coded it.
In on top of it I have hierocracy of config maps so the micro service need to take configuration not only from its own config maps (like I described in previous paragraph) but I also from configuration of its domain (group of micro services) which is originated in similar manner.
If you think that it is confusing, you are right, this why I want to use labels instead using specific config maps name. This will make our life easier than trying to catch all cases one by one.

@AssafKatz3 I now see what you mean, thanks for that information!
It's definitely technically possible to do something like that but I would love to here what @iocanel and @salaboy think about this ( FWIW, I have never seen something similar being used :) )

Hi team,
I have a similar case that it's expected to have a few Config Maps, one for each microservice and an API gateway that is responsible to read these routes in these files.
It would be great to be able to read the Config Maps by label dynamically, so the application can keep listening for new Config Maps and changes in the current ones.
Is there any plan for this feature?

@juliabenatti we have no plans at the moment, if you would like though you can certainly take a stab at it and submit a PR.  That is always welcome!

Another upvote for this feature - we want to be able to dynamically add configmaps to the set of those that are used by a microservice, and having a label-based mechanism for configmap selection (which appears to be supported for secrets) would be the most convenient approach.
Without this, we have to redeploy the microservice every time we want to add support for a new configmap. or define one uber-configmap to contain the aggregation of our configuration (which becomes harder to manage).

Could also be useful in a multi-tenant system, where tenant-specific configuration is put in separate configmaps. Upvoted

Just to say it used to be possible in earlier versions of Spring Cloud Kubernetes to work around this because the ConfigReloadAutoConfiguration.ConfigReloadAutoConfigurationBeans.propertyChangeWatcher() method was annotated with @ConditionalOnMissingBean. So you could roll a custom source locator for ConfigMaps that was driven by labels.
But that annotation seems to have been removed in more recent builds, so that workaround has now effectively gone.

@wabrit I dont see that here https://github.com/spring-cloud/spring-cloud-kubernetes/blob/1.1.x/spring-cloud-kubernetes-config/src/main/java/org/springframework/cloud/kubernetes/config/reload/ConfigReloadAutoConfiguration.java#L85

Hi Ryan -  the annotation is missing from the method in that revision you linked to, but I've definitely used versions of Spring Cloud that loaded a version of SCK where it was present.

OK I see, I think we can add that back without a problem.  Can you open a separate issue for this?

Yep will do - thanks, Alan

It seems to me that all this issue was asking for is labeling support for config maps, and in such a case this is now part of main branch, and can ne closed. @ryanjbaxter I hope I am not missing anything.  thank you

It seems to me that all this issue was asking for is labeling support for config maps, and in such a case this is now part of main branch, and can be closed. @ryanjbaxter I hope I am not missing anything. thank you

This issue is asking to select config maps by labels rather than names. Where was it implemented in the main branch?

@AssafKatz3  I added such support, see here. Since it is in the main branch, it is not yet released.

4 years later and we closed this one, I feel like a kid that tasted candy for the first time :)

That's great news - can I ask under what release we are likely to see this included, and will it be exposed via a spring.cloud.kubernetes.config.label property as is currently supported for Secret sources?

It will be part of Spring Cloud 2022.0.0 and will be in our next milestone release scheduled to happen next week.
Documentation can be found here https://github.com/spring-cloud/spring-cloud-kubernetes/blob/main/docs/src/main/asciidoc/property-source-config.adoc#using-a-configmap-propertysource


Fix output file in expr bodied function BBE

Purpose

$subject

Codecov Report

Merging #21934 into stage will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            stage   #21934   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfd3c8...181b49f. Read the comment docs.


feat: add Chinese translation

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] I have joined the Ory Community Slack.
[X] I am signed up to the Ory Security Patch Newsletter.

Ory Network Project
No response
Describe your problem
Add Chinese localization support
Describe your ideal solution
Add Chinese localization support
Workarounds or alternatives
none
Version
v0.5.0
Additional Context
No response

@jonas-jonas
Please review this PR when you have time. Thank you!