Snapshots combined with using -count

Issue
This could be a bug or a feature - I'm still actually digging into this but wanted to open an issue because you might be able to dig into it faster (if you've not already come across this!)
It looks like when running with -count (i.e. go test -count 5 ./...) in some (if not all?) cases snapshots get counted multiple times for the same test rather than recompared - i.e. the snapshot gets updated with [TestRun/#00 - n] where n is the number of snapshots called so far across all runs.
I think this is because the test ids are using a global registry + mutex and that -count is working within the same process, it just calls the test functions multiple times.
I think this could be worked around by exposing a way of manually clearing/resetting the registry, which could be called before every test in TestMain, but I've not yet tested that to confirm.
I'm also not sure if something like https://github.com/golang/go/issues/64883 would make it possible for the library to handle this automatically.

Hey 👋  That is correct. I can't say it's a bug but rather a feature of supporting multiple calls of matchSnapshot in a single test.

in some (if not all?)

It's all cases.
I have spent some time looking into this, but couldn't find a good solution unfortunately. I would be willing to do a breaking change (some people are using snaps with a count) as the correct way would be do run a test mulitple times and verify with the same snapshot each time but I don't want to remove the ability to be able to call matchSnapshot multiple times in a single test.
The reason why this is difficult to solve is because there is no way to differentiate a snaps.MatchSnapshot is called due to the -count>1 or  the snaps.MatchSnapshot is called multiple times inside the test.
As for the TestMain I am pretty it's called only once when you invoke go test and not count times.
To sum up, from the snaps perspective
This
func TestMyTest(t *testing.T) {
  t.Run("my test", func (t *testing.T) {
  	snaps.MatchSnapshot(t, "hello world")
    snaps.MatchSnapshot(t, "hello world")
  }
}

and this can't be differentiated.
// go test -count=2 ./...
func TestMyTest(t *testing.T) {
  t.Run("my test", func (t *testing.T) {
  	snaps.MatchSnapshot(t, "hello world")
  }
}

I can check again my notes and what I tried in the past as it has been some time. As for the go issue it could potentially help in oder to identify if calling with -count>1.

What you've said is pretty much word-for-word what I was thinking too, and why I went looking for https://github.com/golang/go/issues/64883 but then I managed to get myself confused in trying to reproduce it 😅
I've put a comment on that testing.Count issue.

Okay found my old notes and spent some time brainstorming with a new solution. I think have something working, but need to spend some time refining it before creating a pr. My solution interfers a bit with clean up functionality and I wouldn't like to  introduce a bug there.

Cool - fwiw I was thinking you could also support this by introducing a new method for resetting/clearing the global registry for a test which could be called whenever the test started:
func TestMyTest(t *testing.T) {
	t.Run("my test", func(t *testing.T) {
		snaps.Start(t)
		snaps.MatchSnapshot(t, "hello world")
		snaps.MatchSnapshot(t, "hello world")
	})
}

I tried to do something similar indeed without affecting the api but this is a breaking change as some people are already running it with -count>1 but as I said

the correct way would be do run a test mulitple times and verify with the same snapshot each time

Need to run more manual tests to verify I don't introduce any regressions and add unit tests.


jQuery conflict with Semantic UI

This is a (multiple allowed):

[x] bug

Swiper Version: 3.4.2

Platform/Target and Browser Versions: Any

What you did
Include the jQuery version of Swiper.
Expected Behavior
Animations to work.
Actual Behavior
Animations not working due to conflict.
Non-jQuery version works, so jQuery Swiper seems to trigger Semantic UI animations which it shouldn't.
Example: https://jsfiddle.net/0mtt2phe/2/

+1
that's right, this bug exist for a long time ago, but there is no problem to use the vanilla javascript version.

Agree! Especially as jQuery already weighs about 90kb.
Semantic-UI is fairly used today, it relies on jQuery and its javascript is huge, so every kilobyte saved is welcome. I hope this bug will be corrected soon. All my support to the team

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue

There is no more jQuery version of Swiper


fix(docs): some styles not being applied

Current dependencies on/for this PR:

main

PR #51   👈

This stack of pull requests is managed by Graphite.


Update s3, sdk-core, sqs to 2.20.45

About this PR
📦 Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.295 to 2.20.45
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #598.


Fix setup module outputs.

Fix setup module outputs.
closes #4

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Consider adding a section to sign up for a free HNY account in each chart's readme

It may be helpful to have a sign-up link in the readmes for these charts. It doesn't seem inconceivable that someone might be interested in honeycomb, see if there's a helm chart published in a repository (e.g., artifacthub), and install it and then go from there. If there's a link to create a free account, that lets them do one less google query.

Use this link - https://bit.ly/32P0cfQ


[FEATURE] Bump the version for 1.3.1 opensearch-dashboards release

Is your feature request related to a problem?
We need to bump the version for 1.3.1 in 1.x and 1.3 branches for 1.3.1 releases wrt to the release issue - https://github.com/opensearch-project/opensearch-build/issues/1885

Done in #225


Fixes & Changes for recent issues

Redfin 500 Bug Fix (needs to be handled on frontend)
LatLong on Redfin
Sold and DOM for Redfin
Agent name & phone on Redfin

TODO: change posted_time on Zillow to datetime & fix 403 response

Addresses #17 & #21


(lombok): add lombok @Data & fix @Setter

just see the code

@iocanel
Please review again and I had added tests and fixed docs, thank you.


net: UDP sockets on windows error on receive due to ICMP TTL

Go version
go1.22.5
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/raggi/Library/Caches/go-build'
GOENV='/Users/raggi/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/raggi/go/pkg/mod'
GONOPROXY='ra66i.org/raggi,rag.pub/raggi'
GONOSUMDB='ra66i.org/raggi,rag.pub/raggi'
GOOS='darwin'
GOPATH='/Users/raggi/go'
GOPRIVATE='ra66i.org/raggi,rag.pub/raggi'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/raggi/.cache/tailscale-go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/raggi/.cache/tailscale-go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.22.5'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/bb/dyr_1n6j575g8nq85nmnfbt00000gn/T/go-build2102863150=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?
We have observed errors in RecvFrom as a result of ICMP replies to UDP sockets on Windows, which is an unexpected behavior resulting from a Windows socket behavior quirk.
What did you see happen?
Socket recv generated an error as a result of ICMP replies to earlier sent packets.
What did you expect to see?
Socket recv should not generate an error due to ICMP received.
Detail & Proposal
Background: a prior round of this issue was fixed in https://github.com/golang/go/commit/3114bd6f97492461d2027a49fee9f7fce3742b75 which addressed one case of ICMP reply (https://www.betaarchive.com/wiki/index.php?title=Microsoft_KB_Archive/263823), but there are two. The Godot project ran into this issue as well, and describes the issue and fix here: https://github.com/godotengine/godot/commit/397b01d590e5850762d25eaaa2951b1a76da46dc
The net package only disables SIO_UDP_CONNRESET, but not SIO_UDP_NETRESET, as such there are still ICMP responses that can lead to wsarecvfrom: The connection has been broken due to keep-alive activity detecting a failure while the operation was in progress.
We should set SIO_UDP_NETRESET as well as SIO_UDP_CONNRESET in order to get behavior that is most similar to bsd sockets on the other major platforms, where asynchronous ICMP replies are ignored unless explicitly opted in to.

Related Issues and Documentation

x/net/icmp: listen icmp in Windows not work properly #38427
internal/poll: sending a zero-byte-payload UDP packet on Windows is a no-op #26668 (closed)
net: TCP RST handling is unreliable on OSX #50254
net: ReadFromUDP falls into busy waiting on empty UDP packet #59704 (closed)
x/net/icmp: PacketConn.ReadFrom on an unprivileged PacketConn on darwin returns the entire IP packet #47369
net: no checksum processing on loopback #23599 (closed)
net: UDPConn.ReadFrom returns error for oversized datagram on Windows #14074 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

cc @golang/windows

The Godot project ran into this issue as well, and describes the issue and fix here: godotengine/godot@397b01d

Is there some official documentation for this?
I searched for SIO_UDP_NETRESET, but I could not find anything.
Or are we supposed to assume that https://github.com/godotengine/godot know how it works.
Thank you.
Alex


Fix test failure with Spark 3.3 by looking for less specific error message

Closes https://github.com/NVIDIA/spark-rapids/issues/5182
Spark 3.3 changed which exception they throw for a divide that causes an overflow in https://github.com/apache/spark/commit/c2ed15de94f611972c463ff8bba9268c1e93fd30, causing our tests to fail.
This PR changes the affected test to just look for ArithmeticException rather than specifically java.lang.ArithmeticException. This is the same approach used in the other tests.

build


Start Coding

We need a good baseline for our project.

Spring Boot Initializr, Thymeleaf, Spring Boot Web

For hot-reload and rebuild, add
<dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-devtools</artifactId>
</dependency>

to pom.xml
Go to File \ Settings \ Build, Execution, Deployment and tick Build project automatically.
Then hit CTRL + A open Registry... and set compiler.automake.allow.when.app.running to true.

When editing files we now no longer need to restart the entire program, just hit CTRL + SHIFT + F9 and reload your page.


Add SDK v4 compatibility layer.

This is change is required to enable a bridge between SDK 3 and 4 for hac apps.
requires: https://github.com/RedHatInsights/insights-chrome/pull/2663
cc @karelhala

/lgtm


Fix ScrollContainer lagging behind by one frame

The internal size the ScrollContainer used to make decisions about
the scroll range, scrollbar size, etc. was outdated by one frame
because it was updated before its children.

👍  fixes chat scrollToEnd too

Fixing scroll to end was the point. Only for his game, not osu. ;)
On 8 Jun 2017 6:53 a.m., "Dean Herbert"<EMAIL_ADDRESS>wrote:

Merged #801 https://github.com/ppy/osu-framework/pull/801.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ppy/osu-framework/pull/801#event-1114836775, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEshB3UotUr_qPEn_osuoyXwJIyB-lt9ks5sB34pgaJpZM4NzPQ6
.

Mutual benefit; not complaining 🏎


Preparation to remove the pyautogui dep

Pyautogui is only used atm to find locate pictures on the screen and get the width & height of the monitor. so doing this may reduce the dependency size

Todos for this PR:

Linux support
Remove pyautogui dep
Guide for contributing with gameplans as bot is now generic for any gameplan (I think)

Fix #26, #21, #23

gray windows possible fix: https://stackoverflow.com/questions/32560289/displaying-image-without-waitkey

@linus-jansson Is this going to be merged?

@linus-jansson Is this going to be merged?

Yes the idea is that this is going to be merged in due time. If you feel like contributing you can use this branch as a base.

@linus-jansson Is this going to be merged?

Yes the idea is that this is going to be merged in due time. If you feel like contributing you can use this branch as a base.

Awesome! I was just asking since there haven't been any commits in a while


Remove HTTP3 dependent code from the qpack implementation.

Motivation:
The QPACK decoder / encoder should not depend on HTTP3 and also throw their own exception type to make it easier to convert stuff to the right HTTP3 error code.
Modifications:

Introduce QpackException and use it in the QPACK code
Move Http3HeadersSink out of QpackDecoder and let it throw Http3Exception during header validation
Adjust tests

Result:
QPACK not depends on http3 stuff anymore

/cc @kachayev


check_vmware_alarms | Add support for filtering by entity name, resource pools

While working on the plugin for GH-201, I initially opted to drop flags common to some of the other plugins:

ignore (or explicitly include) specific VMs (list)
ignore (or explicitly include) specific resource pools (list)

At the time I didn't see a strong use case for them, but as I'm getting closer to having something usable, I see where filtering alarms based on those settings could prove useful. Spinning off this issue to track an initial batch of enhancements to the plugin after initial release.

Added multiple datacenters support to the list of future features.
Past this set, it may be worth opening additional issues to track further enhancements?

Past this set, it may be worth opening additional issues to track further enhancements?

I added one more that came to mind:

ignore (or explicitly include) alarms with provided description substrings

Spun off bulk of enhancements to separate issues. I removed this filtering option from the list of planned options:

evaluate (or not) powered off VMs (boolean)

If it's requested later we should be able to add support for it without too much trouble.

The latter phase will be to filter on resource pools.
Note to self: Resource Pools can nest, so don't filter first to VMs and then pools thinking to optimize the search.

At a glance it appears that resource pools can contain other pools and VMs, but not much else.
https://vdc-download.vmware.com/vmwb-repository/dcr-public/8946c1b6-2861-4c12-a45f-f14ae0d3b1b9/a5b8094c-c222-4307-9399-3b606a04af55/vim.ResourcePool.html
Both the vms and resourcePools properties are arrays, so I would need to check each one.
Or, since we have the MOID associated with the alarm we should be able to search against that directly and then check the appropriate property for the associated resource pool MOID that matches the provided name?

https://vdc-download.vmware.com/vmwb-repository/dcr-public/8946c1b6-2861-4c12-a45f-f14ae0d3b1b9/a5b8094c-c222-4307-9399-3b606a04af55/vim.ManagedEntity.html
What about the parent property provided by ManagedEntity?
Perhaps start with grabbing the MOID for the named resource pools (plural) and then check the parent property for entity associated with triggered alarm for a match?
Does a VM have a "parent" property that points to a resource pool MOID?
If null or empty, no match.

What about the parent property provided by ManagedEntity?

In the case of a specific VM, the parent property refers to the folder containing the VM (ManagedObjectReference:Folder), so that isn't helpful here. The resourcePool property for a specific VM points to a specific Resource Pool (ManagedObjectReference:ResourcePool) as expected however, so that remains a viable option.
Using the MOB, it looks like only VMs or Resource Pools can be "housed" by a Resource Pool, so handling just those two cases seems like a good starting point.

What about the parent property provided by ManagedEntity?

In the case of a specific VM, the parent property refers to the folder containing the VM (ManagedObjectReference:Folder), so that isn't helpful here. The resourcePool property for a specific VM points to a specific Resource Pool (ManagedObjectReference:ResourcePool) as expected however, so that remains a viable option.
Using the MOB, it looks like only VMs or Resource Pools can be "housed" by a Resource Pool, so handling just those two cases seems like a good starting point.

Worth (explicitly) noting:

The parent property for a Resource Pool points to a Resource Pool.
The resourcePool property for a Virtual Machine points to a Resource Pool.

Filtering by resource pool functionality added, but documentation needed:

README

flags
example
overview?

contrib

add command definitions

Filtering by resource pool functionality added, but documentation needed:

Now merged to master branch per GH-252.
Documentation work needed to reflect the changes.


"Nana" is listed in the drop-down menu

Description:
"Nana" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Nana" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Nana, CĂLĂRAȘI".


Rename unclear local variables in parse_image()

The variable name dim is used to represent dim, image_format, and
access_qualifier in parse_image(). This might cause confusion for
someone trying to read and understand symbols.rs. This commit changes
names of variables to better reflect their purpose.

Thank you for your PR, and congrats on your first contribution! 🎉

Thank you for your PR, and congrats on your first contribution! 🎉


Implement garden.io for local development of wego-app

Short description
As a developer I want to implement garden.io so that I can have fast deployments of wego-api locally.
Garden will allow us to develop API features quickly while the wego-app is running on the cluster.
Success looks like: I can run a command and a wego-app instance runs on the cluster; when I update some .go files, the server reloads with the changes.
Acceptance Criteria:

One-time installation instructions are documented in the README
Some sort of configuration file is present in the weave-gitops repo that tells Garden what to do
WeGO devs are able to run a script or Makefile target to get started
Updating .go code automatically reloads the container/pod/deployment running in the cluster
Rebuilds should not take longer than a few seconds to complete (if its taking too long to rebuild, we need to re-evaluate)
The wego-app needs to be accessible via localhost so that UI development can happen

Putting this on hold for now. Closing.


fix: remove print statement in init.py

Codecov Report

Merging #102 (d9cb689) into main (055894b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          219       219
  Branches         4         4
=========================================
  Hits           219       219

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Leviton z-wave dimmer reports incorrect value after being turned on.

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.44.1
Python release (python3 --version):
Python 3.5.2+
Component/platform:
Aeotec ZW090 Z-Stick Gen5
Leviton VRMX1-1LZ Dimmer
Description of problem:
When turning the device on through the hass UI the device reports being on for about a second and then the UI switches back to showing it as off even though the lights are on. If I toggle it on again then the button stays showing on. A similar issue happens if I change the dim level, the lights do dim to the right level but the hass dimmer slider reverts back to showing the old value.
Relevant OZW log: https://hastebin.com/raw/fubelexepu
This might also quite possibly be related to an issue I had with OZW in a different project: https://github.com/OpenZWave/node-openzwave-shared/issues/65

There is a solution available also in HA for this:
zwave:
  usb_path: /dev/ttyACM0
  device_config:
    light.your_light_entity_id_2:
      refresh_value: true

https://home-assistant.io/docs/z-wave/#configuration

That does indeed solve the issue. I'm not sure it's really obvious what that config value does from reading the documentation though.


save commands to local database

Would be cool to save all prompts (sqlite?) and their responses. This will help to control cost.
If I type exact same command again, the results can be shown from the database.

A command cache. Not a bad idea.


Double quoting interpolated file name for coffee

@kreichert What is the purpose behind this?
I'm not a user of coffee script, I guess single quotes are not interpreted or why did you apply this change?

@wzrdtales Yes, in coffeescript if you have any interpolated values in a string (the #{__dirname} part in this case), then the string needs to be surrounded by double quotes; otherwise the value is treated as a literal.  For reference - https://coffeescript-cookbook.github.io/chapters/strings/interpolation

@kreichert Thanks :)


Compile Error

Hello.  Trying to compile on Ubuntu 16.04 I seem to be getting an interesting error
vess@vorpal:~/code/3d/experiments/realsense_sdk/build$ make
[  1%] Building CXX object sdk/src/utilities/logger/log_utils/CMakeFiles/realsense_log_utils.dir/log_utils.cpp.o
[  2%] Linking CXX shared library librealsense_log_utils.so
[  2%] Built target realsense_log_utils
[  3%] Building CXX object sdk/src/core/image/CMakeFiles/realsense_image.dir/image_base.cpp.o
[  5%] Building CXX object sdk/src/core/image/CMakeFiles/realsense_image.dir/custom_image.cpp.o
[  6%] Building CXX object sdk/src/core/image/CMakeFiles/realsense_image.dir/image_conversion_util.cpp.o
/home/vess/code/3d/experiments/realsense_sdk/sdk/src/core/image/image_conversion_util.cpp: In static member function ‘static rs::core::status rs::core::image_conversion_util::convert(const rs::core::image_info&, const uint8_t*, const rs::core::image_info&, uint8_t*)’:
/home/vess/code/3d/experiments/realsense_sdk/sdk/src/core/image/image_conversion_util.cpp:45:29: error: ‘applyColorMap’ is not a member of ‘cv’
cv::applyColorMap(color_map, dst_mat, cv::COLORMAP_HOT);
^
/home/vess/code/3d/experiments/realsense_sdk/sdk/src/core/image/image_conversion_util.cpp:45:67: error: ‘COLORMAP_HOT’ is not a member of ‘cv’
cv::applyColorMap(color_map, dst_mat, cv::COLORMAP_HOT);
^
/home/vess/code/3d/experiments/realsense_sdk/sdk/src/core/image/image_conversion_util.cpp:48:25: error: ‘applyColorMap’ is not a member of ‘cv’
cv::applyColorMap(color_map, src_mat, cv::COLORMAP_HOT);
^
/home/vess/code/3d/experiments/realsense_sdk/sdk/src/core/image/image_conversion_util.cpp:48:63: error: ‘COLORMAP_HOT’ is not a member of ‘cv’
cv::applyColorMap(color_map, src_mat, cv::COLORMAP_HOT);
^
sdk/src/core/image/CMakeFiles/realsense_image.dir/build.make:110: recipe for target 'sdk/src/core/image/CMakeFiles/realsense_image.dir/image_conversion_util.cpp.o' failed
make[2]: *** [sdk/src/core/image/CMakeFiles/realsense_image.dir/image_conversion_util.cpp.o] Error 1
CMakeFiles/Makefile2:408: recipe for target 'sdk/src/core/image/CMakeFiles/realsense_image.dir/all' failed
make[1]: *** [sdk/src/core/image/CMakeFiles/realsense_image.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
Any ideas?

Hi,
The SDK requires opencv version 3.1 inparticular and other dependencies in general. The list of requirements can be viewed in the main README file.
Are you using the correct opencv?


Distribute Dockerhub Credentials

With the new Dockerhub account obtained, we need to distribute account credentials to any piece of our infrastructure that pulls images from Dockerhub so that rate limiting won't kick in. Note - the criteria listed below might best be worked on as separate cards in the appropriate project repos.
Acceptance criteria

[ ] Add credentials to Concourse
[ ] Add credentials to K8s
[ ] Add members of engineering team to Dockerhub account

@mheadd can you break out this story into three separate, smaller stories (one each for the AC's above)? That will make prioritizing the work much easier. Closing this issue so it can be replaced by the three smaller stories.

@karareinsel Separate issues added in the appropriate repos. See references ☝


pickup_objects

Implementing a script that allows a player to pick up objects from the map

Added pickMeUp.cs
and collidable object .cs


sort usernames when posting comment

this is so that changes to the sort order in the OWNERS.yaml file doesnt affect us detecting that its still just the same list

closed by https://github.com/google/github-owners-bot/pull/21


Handle custom ops without op_dialect_version_map entry

A small fix to the recent addition of op_dialect_version_map to name ops with multiple versions. Custom ops may not have an entry in this map, and can be handled as before (without any renaming).

Can one of the admins verify this patch?

@jenkins-droid test

Hi @chentong319 : any feedback on this? I assume that the CI failures are unrelated to this PR (as far as I can see)?

@jenkins-droid test this please

Jenkins Linux s390x Build #1321 [push] Handle custom ops withou... started at 09:42

Jenkins Linux amd64 Build #1323 [push] Handle custom ops withou... started at 08:42

Jenkins Linux ppc64le Build #469 [push] Handle custom ops withou... started at 09:45

Jenkins Linux s390x Build #1321 [push] Handle custom ops withou... passed after 40 min

Jenkins Linux amd64 Build #1323 [push] Handle custom ops withou... passed after 46 min

Jenkins Linux ppc64le Build #469 [push] Handle custom ops withou... passed after 54 min


[TOMEE-2680] Translate MicroProfile Metrics Histogram Example to Spanish

https://issues.apache.org/jira/browse/TOMEE-2680

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Location of proposals directory corrected.

LGTM, why isn't this merged? cc @erictune

Gah, it is because of the CLA. @CsatariGergely you have to sign a CLA to do this change.

@CsatariGergely, yes, we are still waiting for CLA from @CsatariGergely.

@idvoretskyi, @philips: I'm discussing the CLA issue with @bgrant0607, @sarahnovotny, @aronchick and @monadic in mail.

@CsatariGergely what is the conclusion of the CLA issue?

This is fixed and this PR can be closed.


Readme Installation

Installation
Add checklist_rating to your pubspec.yaml dependencies:
dev_dependencies:
  checklist_rating: ^0.0.4

is the package only required during development? if not, please change the installation readme
dependencies:
  checklist_rating: ^0.0.4

done updated, thanks


Write and switch cs cli to use temporal UUID's.

Changes proposed in this PR

Make cs generate temporal UUID's when it submits jobs to cook.

Why are we making these changes?
Random UUID's can be 30x much more expensive to manage.

Will merge when build is green


Revert "GEODE-8664: Nest errors in DistributionImpl.start"

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ]  Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[ ]  Has your PR been rebased against the latest commit within the target branch (typically develop)?
[ ]  Is your initial contribution a single, squashed commit?
[ ]  Does gradlew build run cleanly?
[ ]  Have you written or updated unit tests to verify your changes?
[ ]  If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>
As it seems there were some spurious failures during CI execution and that hid some test cases which were actually failing.
Reverting this commit for now and will be included again once tests have been fixed.
Reverts: apache/geode#5725

I should have picked up the legit errors amongst the noise. Sorry for the run-around.


How to start a http request on imba?

Are there some http libs for imba?

Do you mean on the server or client? Imba is fully interoperable with regular js libraries ( you can require things just like you would in regular node/js). I will make a simple example.

It would very nice to have this example here :)


Not able to click on print button when the window application under test triggers the print dialogue window. Please help.

What have you already tried mere giving the title does not help much, which language binding are you using.

Sorry
I am using C#
I have tried finding the xpath for the print dialogue window and then clicking on print button. But somehow that does not work.

Check inspect it might be a separate window altogether

It opens up as a seperate window. Well in that case what should be done?
On Mon, 22 Mar 2021, 22:30 anunay1, @.***> wrote:

Check inspect it might be a separate window altogether
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/WinAppDriver/issues/1477#issuecomment-803910669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOT2FLX4O4XNNRAC33RLDK3TE4E37ANCNFSM4ZSW4R7A
.

then you need to create a desktop session with root and switch to the print window.

check wiki on how to create a root session and jump to the opened window.

Thank you. Will do that and post my result.

check the bug #894 I have also uploaded a C# project. will save you time

Thanks i tried this...now i am able to focus on the print window but still not able to click print.
It somehow focuses on one element and does not move to other element. I used action class to move to the print element.
Any suggestions..

Can you how many print element are there? There might be more than 1.

Yes there are more than one...but it is not getting clicked with automation id

check with all the index values.

Can you please elaborate a little?

can you share the code how you are getting the count.

I was able to get the xpath. Thanks a lot for your help.

If it's resolved please close the bug


Added Google datastore backend

switched from godep to dep
Cleaned up linting
Added context to all store inteface methods

can you update the README with details for the new backend?


fix: Label + Checkbox tick Bug

What I did
We noticed when clicking on input checkboxes in our code examples they did not "tick".

Looks good, clicks still pass through on inputs


Is there an easy way to size fix "x" amount of gallery images per row?

I see class="full"... is there an easy way to size, say 4 images per row in a gallery?

The gallery include has some logic built in that determines what CSS class to apply to the wrapper, which in turn determines if it should be 2 or 3 columns of images.
{% if gallery_size == '2' %}
  {% assign gallery_layout = 'half' %}
{% elsif gallery_size >= '3' %}
  {% assign gallery_layout = 'third' %}
{% else %}
  {% assign gallery_layout = '' %}
{% endif %}

To do this with the least amount of work on your part you'd need to add a new class to style the images into 4 columns. I'd start with adding something like .fourth to _base.scss:
figure {

  &.fourth{
    > a,
    > img {
      @include breakpoint($small) {
        width: calc(25% - 0.5em);
      }
    }
...
}

Then you can use the gallery include with the class parameter like so:
{% include gallery class="fourth" %}

And you should get something like this:

I updated the _base.scss as you suggested and changed the gallery include to the following...
{% if gallery_size == '2' %}   {% assign gallery_layout = 'half' %} {% elsif gallery_size == '3' %}   {% assign gallery_layout = 'third' %} {% elsif gallery_size >= '4' %}   {% assign gallery_layout = 'fourth' %} {% else %}   {% assign gallery_layout = '' %} {% endif %}
Instead of displaying the images as desired (in your example), I get each image being 100% width even though class="fourth" is displayed in the resulting figure tag.
Any ideas?

You probably need to build the CSS as it's not automatic. You'll need to preprocess it using the included npm run build:css task. You made the change to the SCSS but it doesn't exist in the compiled CSS the site uses.

That did it!!!
Thanks :+1:

:smile:

It would probably be good to include this patch, I had done a similar thing a while back and suspect more people have to edit those files. Would be better to stay in sync with upstream.

@Sciss Visually four columns is pushing it for me as the images start to get small. I have a feeling this one is a matter of taste and no matter what solution I bake into the theme someone is going to want something else :wink:
For now I think I'm going to leave it as is and err on the side of being conservative with 3 columns as the max.

I think there should be a more generic approach to the problem of Responsive Grid Layout. You may find relevant the discussion and solution we had on this issue


Fix issues 1290 1211 1201

Fix node is still schedulable When there are disks with disabled scheduling and invalid disks
Resotre last backup is disabled when an error occurs in the backup file
Fixed the field style of Edit Node and Disks popup

https://github.com/longhorn/longhorn/issues/1201
https://github.com/longhorn/longhorn/issues/1211
https://github.com/longhorn/longhorn/issues/1290
image: wangsiye/longhorn-ui:187f116
Signed-off-by: Siye Wang<EMAIL_ADDRESS>

Regarding #265 (saw a screenshot only)

[ ] Put the Storage Available at the last line instead of the first one.


chore(fastify): Apply deprecation warnings for fastify

Description
Warn about deprecations of the following environment variables in Clerk Fastify plugin:

CLERK_API_KEY
CLERK_FRONTEND_API

Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[x] (If applicable) JSDoc comments have been added or updated for any package exports
[x] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[x] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Issue Checker "fix" buttons broken in 4.2.1

Installed 4.2.1 on a new computer and noticed I had 3 failed checks. Attempted to use the "fix" buttons, and a large UI error window popped up. Buttons still function as long as you run the application as administrator.

If not sensitive, can you send me your config.ini file?


ADBDEV-3175: Remove per byte precision message truncation for multibyte strings

Greenplum does not correct truncate error log on error in external web tables
If error code is not zero and error message is truncated in interpretError
on multi-byte character then assert occurs
CREATE EXTERNAL WEB TABLE table_test (text text) EXECUTE $$ (echo -n ‘ && seq 1 500 | cut -b1 | tr -d '\n' && echo -n ’) >/dev/stderr && false $$ ON ALL FORMAT 'CSV';
SET gp_debug_linger = 10;
SELECT true FROM table_test;
CREATE EXTERNAL TABLE
SET
ERROR:  Unexpected internal error (elog.c:241)  (seg0 slice1 <IP_ADDRESS>:6434 pid=92858) (elog.c:241)
DETAIL:  FailedAssertion("!(pg_verifymbstr(*str, len, ((bool) 1)))", File: "elog.c", Line: 241)
HINT:  Process 92858 will wait for gp_debug_linger=10 seconds before termination.
Note that its locks and other resources will not be released until then.

If error code is zero and command emit stderr and this error message is
truncated in write_log (which is called by read_err_msg) on multi-byte
character then bad character writes to log and later this log can not be
correct read
CREATE EXTERNAL WEB TABLE table_test (text text) EXECUTE $$ (echo -n ‘ && seq 1 2006 | cut -b1 | tr -d '\n' && echo -n ’) >/dev/stderr && true $$ ON ALL FORMAT 'CSV';
SELECT true FROM table_test;
SELECT logseverity FROM gp_toolkit.gp_log_system WHERE logmessage LIKE 'read err msg from pipe%' AND logdatabase = current_database() LIMIT 1;
CREATE EXTERNAL TABLE
 bool
------
(0 rows)

ERROR:  invalid byte sequence for encoding "UTF8": 0xe2 0x22 0x2c  (seg0 slice1 <IP_ADDRESS>:6434 pid=93923)
CONTEXT:  External table __gp_log_segment_ext, line 71 of file execute:cat $GP_SEG_DATADIR/pg_log/*.csv

Solution is correct truncate error log according to database encoding

if command has pipe and error code is zero and error log is truncated

Please explain in the PR description in which cases external table error message gets into very common write_log function?
Also, provide a well-formatted commit message.

Please explain in the PR description in which cases external table error message gets into very common write_log function?

done

Use function names instead of URL links there, at least.

I add function names

Greenplum does not correct truncate error log on error in external web tables.
If error code is not zero and error message is truncated in interpretError
on multi-byte character then assert occurs.
If error code is zero and command emit stderr and this error message is
truncated in write_log (which is called by read_err_msg) on multi-byte
character then bad character writes to log and later this log can not be
correct read.
Solution is correct truncate error log according to database encoding.

Greenplum does not correct truncate error log on error in external web tables.

Added some punctuation and grammatic fixes. Left complex queries alone.

Greenplum does not truncate error log correctly on error in external web tables.
If error code is not zero and error message is truncated in interpretError
on multi-byte character, then assert occurs.
If error code is zero and command emit stderr and this error message is
truncated in write_log (which is called by read_err_msg) on multi-byte
character, then bad character writes to log and later this log can not be
correctly read.
Solution is to correct error log truncation according to database encoding.


getting error Init error, NetworkError: Cache.add() encountered a network error

Getting error Init error, NetworkError: Cache.add() encountered a network error
My system has 8 GB of RAM I tried with llama as well as tiny llama , llama failed at 92% and tiny llama at 97%.

Here's my console logs at this point:

And this is from my dev tools:

I've started facing the same issue with TinyLlama.
phi-2 continues working fine, though.

This error is related to this one https://github.com/mlc-ai/web-llm/issues/289
That has been accentuated due to the parallel downloads via this one https://github.com/apache/tvm/pull/16525

Thanks. Now I am not getting the error but its occupying my entire RAM. How much minimum RAM is needed for this to run?

@devashish234073 you should open a new issue for that to keep the issue on topic

Thank you, @CharlieFRuan! I've just tested it and confirmed the issue has been fixed!

@devashish234073 you should open a new issue for that to keep the issue on topic

Sure, raised this --> https://github.com/mlc-ai/web-llm/issues/324


Add flit.init module

This can be run with: python3 -m flit.init for now.
@Carreau - this is similar to your PR #9. I'm still going back and forth on whether I want it or not, but I spent some time working on it on the plane.
The main difference from your design is that I didn't want to tie it to git; instead I use entries from last time you ran the tool as defaults. I've also designed it so it would be fairly easy to build a different interface for the same functionality - I'm looking at Urwid as one possibility.

How's jetlag ?
Looks good otherwise.


[Bug] Cannot Build Solution On Visual Studio For Mac 2019 After 1.3.1

Description
This isn't really a bug but it has affected me all the same so I thought it would be best to ask here.
Since version 1.3.1 of the library I cannot build the project locally using visual studio for mac. I have confirmed by running the 1.3.1 commit (35d7d5f7620110a55de9ec8a1afd0397e64b4d10) without issue:

When i go to 1.3.2 or higher, i get the following error:

Error: .NET Core 1.0 SDK is required to build this application, and is not installed.
Install the latest update to the .NET Core 1.0 SDK by visiting https://aka.ms/vs/mac/install-netcore1 (Xamarin.CommunityToolkit)

Error: .NET Core 2.0 SDK is required to build this application, and is not installed.
Install the latest update to the .NET Core 2.0 SDK by visiting https://aka.ms/vs/mac/install-netcore2 (Xamarin.CommunityToolkit.Markup)

I followed the urls & downloaded the .NET 2.0 SDK as instructed, installed & get the same error. Interestingly the link for .NET Core 1.0 sdk doesn't take you anywhere, I got redirected to bing.... https://aka.ms/vs/mac/install-netcore1
I can build this code & run it from windows, its just mac that is affected. I daily drive mac for development, so I would like to get this issue resolved. Could this be an issue with workloads & maui? I do have visual studio 2022 preview installed on the mac aswell. I know some of you in the team do use macs & maybe this is something youve come across?
Basic Information

Version with issue: 1.3.2 & above
Last known good version: 1.3.1
IDE: Visual Studio For Mac 2019

IDE Details

expand to see ide details
=== Visual Studio Professional 2019 for Mac ===

Version 8.10.17 (build 2)
Installation UUID: 65f9ab1b-a127-4a98-ac20-f9fb7510f8b9
	GTK+ 2.24.23 (Raleigh theme)
	Xamarin.Mac <IP_ADDRESS> (d16-6 / 088c73638)

	Package version: 612000162

=== Mono Framework MDK ===

Runtime:
	Mono <IP_ADDRESS> (2020-02/2ca650f1f62) (64-bit)
	Package version: 612000162

=== Roslyn (Language Service) ===

3.10.0-4.21269.26+029847714208ebe49668667c60ea5b0a294e0fcb

=== NuGet ===

Version: <IP_ADDRESS>34

=== .NET SDK (x64) ===

SDK: /usr/local/share/dotnet/sdk/6.0.101/Sdks
SDK Versions:
	6.0.101
	6.0.100
	5.0.404
	5.0.403
	5.0.402
	5.0.401
	5.0.400
	5.0.302
	5.0.301
	5.0.203
	5.0.202
	5.0.201
	5.0.103
	5.0.102
	5.0.101
	5.0.100
	3.1.416
	3.1.415
	3.1.414
	3.1.413
	3.1.412
	3.1.411
	3.1.410
	3.1.409
	3.1.408
	3.1.407
	3.1.406
	3.1.405
	3.1.404
	3.1.403
	3.1.300
	3.1.201
	2.1.202
	2.0.0
MSBuild SDKs: /Applications/Visual Studio.app/Contents/Resources/lib/monodevelop/bin/MSBuild/Current/bin/Sdks

=== .NET Core Runtime ===

Runtime: /usr/local/share/dotnet/dotnet
Runtime Versions:
	6.0.1
	6.0.0
	5.0.13
	5.0.12
	5.0.11
	5.0.10
	5.0.9
	5.0.8
	5.0.7
	5.0.6
	5.0.5
	5.0.4
	5.0.3
	5.0.2
	5.0.1
	5.0.0
	3.1.22
	3.1.21
	3.1.20
	3.1.19
	3.1.18
	3.1.17
	3.1.16
	3.1.15
	3.1.14
	3.1.13
	3.1.12
	3.1.11
	3.1.10
	3.1.9
	3.1.4
	3.1.3
	2.1.23
	2.0.9
	2.0.0

=== .NET Core 3.1 SDK ===

SDK: 3.1.416

=== .NET 5.0 SDK ===

SDK: 5.0.404

=== Xamarin.Profiler ===

Version: <IP_ADDRESS>
Location: /Applications/Xamarin Profiler.app/Contents/MacOS/Xamarin Profiler

=== Updater ===

Version: 11

=== Apple Developer Tools ===

Xcode 13.2.1 (19586)
Build 13C100

=== Xamarin.Mac ===

Version: <IP_ADDRESS> (Visual Studio Professional)
Hash: 8fc41ae82
Branch: xcode13.2
Build date: 2021-12-09 01:07:56-0500

=== Xamarin.iOS ===

Version: <IP_ADDRESS> (Visual Studio Professional)
Hash: 8fc41ae82
Branch: xcode13.2
Build date: 2021-12-09 01:07:56-0500

=== Xamarin Designer ===

Version: <IP_ADDRESS>
Hash: 56f9b80b0
Branch: remotes/origin/d16-11
Build date: 2021-12-15 02:44:16 UTC

=== Xamarin.Android ===

Version: <IP_ADDRESS> (Visual Studio Professional)
Commit: xamarin-android/d16-11/f0e3c2d
Android SDK: /Users/alex.duffell/Library/Developer/Xamarin/android-sdk-macosx
	Supported Android versions:
		8.1 (API level 27)

SDK Tools Version: 26.1.1
SDK Platform Tools Version: 31.0.3
SDK Build Tools Version: 30.0.3

Build Information:
Mono: c633fe9
Java.Interop: xamarin/java.interop/d16-11@476bb5b
ProGuard: Guardsquare/proguard/v7.0.1@912d149
SQLite: xamarin/sqlite/3.35.4@85460d3
Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-11@87af37b

=== Eclipse Temurin JDK ===

Java SDK: Not Found

=== Android SDK Manager ===

Version: <IP_ADDRESS>
Hash: 1b81df5
Branch: remotes/origin/d16-10
Build date: 2021-11-12 01:17:32 UTC

=== Android Device Manager ===

Version: <IP_ADDRESS>
Hash: 89dcc0b
Branch: remotes/origin/d16-10
Build date: 2021-11-12 01:17:52 UTC

=== Build Information ===

Release ID: 810170002
Git revision: 58f7763d4d64fcf005a474d25a5d9fd5ce46d7f5
Build date: 2022-01-05 12:51:28-05
Build branch: release-8.10

=== Operating System ===

Mac OS X 11.4.0
Darwin 20.5.0 Darwin Kernel Version 20.5.0
    Sat May  8 05:10:33 PDT 2021
    root:xnu-7195.121.3~9/RELEASE_X86_64 x86_64

=== Enabled user installed extensions ===

DeepClean 1.2.5
Code Distribution Extension 1.1
LightSwitch 💡 1.0
Code Coverage 2.0.1

Deleting global.json seemed to fix the issue, what can we do to make this backwards compatible? I have VS2022 installed on this machine but not all of the Maui workloads so I can't confirm if they are mandatory.

Deleting global.json seemed to fix the issue, what can we do to make this backwards compatible? I have VS2022 installed on this machine but not all of the Maui workloads so I can't confirm if they are mandatory.

I am still getting the issue after deleting the global.json file.

@Axemasta interestingly I don't even have .NET Core 2.0 installed on my Mac.
=== Visual Studio Community 2019 for Mac ===

Version 8.10.17 (build 2)
Installation UUID: 90063c96-7a7b-40b6-8287-01330f9f04fc
	GTK+ 2.24.23 (Raleigh theme)
	Xamarin.Mac <IP_ADDRESS> (d16-6 / 088c73638)

	Package version: 612000162

=== .NET SDK (x64) ===

SDK: /usr/local/share/dotnet/x64/sdk/6.0.101/Sdks
SDK Versions:
	6.0.101
	5.0.404
	3.1.416
MSBuild SDKs: /Applications/Visual Studio.app/Contents/Resources/lib/monodevelop/bin/MSBuild/Current/bin/Sdks

=== .NET Core Runtime ===

Runtime: /usr/local/share/dotnet/x64/dotnet
Runtime Versions:
	6.0.1
	5.0.13
	3.1.22

=== .NET Core 3.1 SDK ===

SDK: 3.1.416

=== .NET 5.0 SDK ===

SDK: 5.0.404

It may well be that 2022 and 2019 are not playing nicely as I don't have 2022 installed and I can compile fine.
I know recently I had issues when installing a version of .NET 6.0 preview, it broke many things like PowerShell core and other things. Sadly the fix there was to completely remove all versions of .NET Core Runtime and SDK and then install these above. Wiping all may have been overkill but it seemed to make sense to get back to a level of cleanliness before building back up again.

@bijington I will have a go at uninstalling all of the different versions on my mac and see if that makes a difference. If this does help might I suggest we create a development guide, akin to the ones seen in forms & maui?

@bijington I will have a go at uninstalling all of the different versions on my mac and see if that makes a difference. If this does help might I suggest we create a development guide, akin to the ones seen in forms & maui?

I am all for any documentation to aid the development process :) good idea!

@Axemasta could you please pull the latest changes? I removed netcoreapp2.0 dependency

@Axemasta we did get feedback from you. I am closing the issue for now. If the issue is still reproduced, please reopen it again.


Bot fix

Trying to fix le bot.

Changes Unknown when pulling ae1416d5bab6d19df9aa255cad9a3f2703edf81f on bot-fix into ** on v3**.

I could imagine that we are legitimately over aggregate budget now, since we previously weren't picking up workbox-sw or workbox-runtime-caching.
I'm not sure why there are only 7 items in the All File Sizes table, though? I don't think that I touched that code, unless it's something that got wonky when the browser/ subpath was removed from build/...

Changes Unknown when pulling aca9f57003f1cb5f349bc7ae607f9f6cb16fec7f on bot-fix into ** on v3**.

Changes Unknown when pulling d1c19d4333910419485c9e35ff1ffaa1fb640ef5 on bot-fix into ** on v3**.

👍 Thanks for cleaning this up.

Changes Unknown when pulling bfe0c28717220d179b31445b418fadf4382ea04d on bot-fix into ** on v3**.


fix: out of order message delivery

Description
In order to minimize the blocking of asynchronous I/O tasks when a large number of message chunks (e.g., model size is large) need to be assembled, threading is used. This led to a bug wherein messages are delivered to a receive queue in an out-of-order fashion. For example, consider two back-to-back messages; the first message is larger than the second. In this case, the second can be inserted before the first because the second has high chance to finish the assembling.
The changes here are for fixing the bug. To do so, we leverage another queue to synchronize message delivery order. For that, chunk manager class is introduced. One chunk manager is created for a backend. And it maintains a list of chunk threads per end, each of which is responsible for assemling messages sequentially and pushing them into the receive queue of the end.
Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[ ] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[ ] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Codecov Report

Merging #354 (cecc3c9) into main (466e6cc) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   14.39%   14.39%
=======================================
  Files          48       48
  Lines        2771     2771
=======================================
  Hits          399      399
  Misses       2354     2354
  Partials       18       18

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update plots.py

Added option to specify axis for plot_objective, allowing more complex plots

Hello @AyrtonB! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file skopt/plots.py:

Line 540:80: E501 line too long (85 > 79 characters)
Line 701:5: E266 too many leading '#' for block comment
Line 704:29: E128 continuation line under-indented for visual indent

Thanks, can you fix the pep8 issues, so that the CI starts the tests?


Chnage txt with passowrd star

Hi
,i need to use it as for Password field how  can I change it

Hi, sumitagrawal, we have not implemented a property to hide the one time passcode. But you can achieve what you want to do by using this library as a controlled component. Basically you have to manage the state in your component and provide the value (like ****) to code property and also provide the onCodeChange handler. You can take a look at the commented out lines in the example, especially the following two lines
// code={this.state.code} //You can supply this prop or not. The component will be used as a controlled / uncontrolled component respectively.
// onCodeChanged = {code => { this.setState({code})}}

Can we add a secureTextEntry prop ?

hmm. Yeah, I guess that makes sense

This was added! ⭐


Remove "type: ignore" by using list(dict), not dict.keys()

In Python 3, list(dict) is often a better way to express dict.keys()
Related to #1560 -- @RobbeSneyders @nielsbox Your review, please.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.656%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2710

Relevant Lines:
2863

💛  - Coveralls

Thanks @cclauss, LGTM.


Lens should point to the release docs

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>
On production builds Lens should point to its version of the docs.
On dev builds it should point to latest (as the next version hasn't been released yet)

Shall I fix that in a follow up PR before we release, or it do it now? I completely forgot to implement that @jakolehm .

Shall I fix that in a follow up PR before we release, or it do it now? I completely forgot to implement that @jakolehm .

IMHO this PR is already an improvement so follow up PR is fine.


Improve performance of LookupImpl.LookupAnalysis via pre-built index

LookupImpl.LookupAnalysis takes O(classpath length) to run. In project with long classpath, LookupImpl.LookupAnalysis is noticeable in profiling. (According to #593)
This PR introduces a binaryClassNameToAnalysis lookup table to reduce lookup time complexity.
For memory consumption of binaryClassNameToAnalysis, assuming there are 10000 binary class names in the worst case, each with 50 characters (100 bytes), the total key size is 10000 * 100 bytes = 1 MB, which is small.
Closes #593.

Overall LGTM, but if would be cool if we could include either a benchmark or some sample project that demonstrates the improvement.

Here's the two recent CI benchmark results with & without the optimization:
https://github.com/sbt/zinc/actions/runs/6773539163/job/18408627550 and https://github.com/sbt/zinc/actions/runs/6764410486/job/18382666918
Here's some excerpts:
Without optimization:
[info] Result "xsbt.HotScalacBenchmark.action":
[info]   N = 5
[info]   mean =  23098.871 ±(99.9%) 497.066 ms/op
[info]   Histogram, ms/op:
[info]     [22900.000, 22925.000) = 1
[info]     [22925.000, 22950.000) = 0
[info]     [22950.000, 22975.000) = 0
[info]     [22975.000, 23000.000) = 0
[info]     [23000.000, 23025.000) = 0
[info]     [23025.000, 23050.000) = 0
[info]     [23050.000, 23075.000) = 1
[info]     [23075.000, 23100.000) = 1
[info]     [23100.000, 23125.000) = 0
[info]     [23125.000, 23150.000) = 0
[info]     [23150.000, 23175.000) = 0
[info]     [23175.000, 23200.000) = 1
[info]     [23200.000, 23225.000) = 0
[info]     [23225.000, 23250.000) = 0
[info]     [23250.000, 23275.000) = 1
[info]   Percentiles, ms/op:
[info]       p(0.0000) =  22917.677 ms/op
[info]      p(50.0000) =  23085.449 ms/op
[info]      p(90.0000) =  23253.221 ms/op
[info]      p(95.0000) =  23253.221 ms/op
[info]      p(99.0000) =  23253.221 ms/op
[info]      p(99.9000) =  23253.221 ms/op
[info]      p(99.9900) =  23253.221 ms/op
[info]      p(99.9990) =  23253.221 ms/op
[info]      p(99.9999) =  23253.221 ms/op
[info]     p(100.0000) =  23253.221 ms/op
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.alloc.rate":
[info]   130.140 ±(99.9%) 3.472 MB/sec [Average]
[info]   (min, avg, max) = (129.191, 130.140, 131.328), stdev = 0.902
[info]   CI (99.9%): [126.668, 133.613] (assumes normal distribution)
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.alloc.rate.norm":
[info]<PHONE_NUMBER>.400 ±(99.9%) 9353105.171 B/op [Average]
[info]   (min, avg, max) =<PHONE_NUMBER>.000,<PHONE_NUMBER>.400,<PHONE_NUMBER>.000), stdev = 2428971.711
[info]   CI (99.9%): [3147402277.229,<PHONE_NUMBER>.571] (assumes normal distribution)
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.count":
[info]   90.000 ±(99.9%) 0.001 counts [Sum]
[info]   (min, avg, max) = (17.000, 18.000, 22.000), stdev = 2.236
[info]   CI (99.9%): [90.000, 90.000] (assumes normal distribution)
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.time":
[info]   7154.000 ±(99.9%) 0.001 ms [Sum]
[info]   (min, avg, max) = (1346.000, 1430.800, 1511.000), stdev = 64.325
[info]   CI (99.9%): [7154.000, 7154.000] (assumes normal distribution)

With optimization:
[info] Result "xsbt.HotScalacBenchmark.action":
[info]   N = 5
[info]   mean =  18656.264 ±(99.9%) 612.879 ms/op
[info]   Histogram, ms/op:
[info]     [18500.000, 18550.000) = 1
[info]     [18550.000, 18600.000) = 1
[info]     [18600.000, 18650.000) = 1
[info]     [18650.000, 18700.000) = 1
[info]     [18700.000, 18750.000) = 0
[info]     [18750.000, 18800.000) = 0
[info]     [18800.000, 18850.000) = 0
[info]     [18850.000, 18900.000) = 0
[info]     [18900.000, 18950.000) = 1
[info]   Percentiles, ms/op:
[info]       p(0.0000) =  18522.046 ms/op
[info]      p(50.0000) =  18622.710 ms/op
[info]      p(90.0000) =  18924.700 ms/op
[info]      p(95.0000) =  18924.700 ms/op
[info]      p(99.0000) =  18924.700 ms/op
[info]      p(99.9000) =  18924.700 ms/op
[info]      p(99.9900) =  18924.700 ms/op
[info]      p(99.9990) =  18924.700 ms/op
[info]      p(99.9999) =  18924.700 ms/op
[info]     p(100.0000) =  18924.700 ms/op
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.alloc.rate":
[info]   160.312 ±(99.9%) 5.542 MB/sec [Average]
[info]   (min, avg, max) = (158.092, 160.312, 161.700), stdev = 1.439
[info]   CI (99.9%): [154.770, 165.854] (assumes normal distribution)
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.alloc.rate.norm":
[info]<PHONE_NUMBER>.400 ±(99.9%) 4212317.767 B/op [Average]
[info]   (min, avg, max) =<PHONE_NUMBER>.000,<PHONE_NUMBER>.400,<PHONE_NUMBER>.000), stdev = 1093925.547
[info]   CI (99.9%): [3138165000.633,<PHONE_NUMBER>.167] (assumes normal distribution)
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.count":
[info]   104.000 ±(99.9%) 0.001 counts [Sum]
[info]   (min, avg, max) = (20.000, 20.800, 22.000), stdev = 1.095
[info]   CI (99.9%): [104.000, 104.000] (assumes normal distribution)
[info] Secondary result "xsbt.HotScalacBenchmark.action:gc.time":
[info]   6546.000 ±(99.9%) 0.001 ms [Sum]
[info]   (min, avg, max) = (1258.000, 1309.200, 1333.000), stdev = 31.815
[info]   CI (99.9%): [6546.000, 6546.000] (assumes normal distribution)

So the numbers do seem to be smaller. However I don't know if the CI uses the same machine each time. If CI benchmark results is not truth-worthy enough, I can do testing locally on my laptop.

I had checked CI results for xsbt.HotScalacBenchmark.action across different recent PRs
1270: 23870.623 ±      897.960   ms/op

1272: 15522.280 ±      290.355   ms/op

1274:  22776.748 ±      824.291   ms/op

1274:  20984.942 ±     1091.008   ms/op

So... Cross comparison between different CI runs is meaningless. I shall run benchmarks locally instead to gather data.

Here's the benchmark result:
With the optimization:
[info] HotScalacBenchmark.action                         /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample   10        6817.422 ±      112.969   ms/op
[info] HotScalacBenchmark.action:gc.alloc.rate           /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5         440.283 ±       22.578  MB/sec
[info] HotScalacBenchmark.action:gc.alloc.rate.norm      /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5<PHONE_NUMBER>.600 ± 12227671.111    B/op
[info] HotScalacBenchmark.action:gc.count                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5         214.000                 counts
[info] HotScalacBenchmark.action:gc.time                 /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5        3105.000                     ms
[info] HotScalacBenchmark.action:p0.00                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6744.441                  ms/op
[info] HotScalacBenchmark.action:p0.50                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6794.772                  ms/op
[info] HotScalacBenchmark.action:p0.90                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6944.929                  ms/op
[info] HotScalacBenchmark.action:p0.95                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6945.767                  ms/op
[info] HotScalacBenchmark.action:p0.99                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6945.767                  ms/op
[info] HotScalacBenchmark.action:p0.999                  /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6945.767                  ms/op
[info] HotScalacBenchmark.action:p0.9999                 /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6945.767                  ms/op
[info] HotScalacBenchmark.action:p1.00                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             6945.767                  ms/op
[info] HotShapelessBenchmark.action                      /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample   18        3321.423 ±       27.155   ms/op
[info] HotShapelessBenchmark.action:gc.alloc.rate        /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5         463.219 ±       20.049  MB/sec
[info] HotShapelessBenchmark.action:gc.alloc.rate.norm   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5<PHONE_NUMBER>.400 ±  5928171.244    B/op
[info] HotShapelessBenchmark.action:gc.count             /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5         213.000                 counts
[info] HotShapelessBenchmark.action:gc.time              /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample    5        3202.000                     ms
[info] HotShapelessBenchmark.action:p0.00                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3271.557                  ms/op
[info] HotShapelessBenchmark.action:p0.50                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3317.694                  ms/op
[info] HotShapelessBenchmark.action:p0.90                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3364.671                  ms/op
[info] HotShapelessBenchmark.action:p0.95                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3372.220                  ms/op
[info] HotShapelessBenchmark.action:p0.99                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3372.220                  ms/op
[info] HotShapelessBenchmark.action:p0.999               /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3372.220                  ms/op
[info] HotShapelessBenchmark.action:p0.9999              /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3372.220                  ms/op
[info] HotShapelessBenchmark.action:p1.00                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true  sample             3372.220                  ms/op
[info] ColdScalacBenchmark.action                        /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5       22372.120 ±      649.988   ms/op
[info] ColdScalacBenchmark.action:gc.alloc.rate          /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5         150.684 ±        3.944  MB/sec
[info] ColdScalacBenchmark.action:gc.alloc.rate.norm     /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5<PHONE_NUMBER>.800 ± 16153258.595    B/op
[info] ColdScalacBenchmark.action:gc.count               /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5         296.000                 counts
[info] ColdScalacBenchmark.action:gc.time                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5        2373.000                     ms
[info] ColdShapelessBenchmark.action                     /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5       16251.642 ±      673.525   ms/op
[info] ColdShapelessBenchmark.action:gc.alloc.rate       /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5         114.146 ±        4.107  MB/sec
[info] ColdShapelessBenchmark.action:gc.alloc.rate.norm  /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5<PHONE_NUMBER>.800 ± 13875755.814    B/op
[info] ColdShapelessBenchmark.action:gc.count            /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5         190.000                 counts
[info] ColdShapelessBenchmark.action:gc.time             /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_3a4aced9           true      ss    5        1626.000                     ms
[success] Total time: 586 s (09:46), completed Nov 6, 2023, 10:31:46 p.m.

Without optimization:
[info] HotScalacBenchmark.action                         /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample   10        6767.929 ±       69.926   ms/op
[info] HotScalacBenchmark.action:gc.alloc.rate           /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5         442.517 ±       16.960  MB/sec
[info] HotScalacBenchmark.action:gc.alloc.rate.norm      /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5<PHONE_NUMBER>.800 ±  7168994.553    B/op
[info] HotScalacBenchmark.action:gc.count                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5         208.000                 counts
[info] HotScalacBenchmark.action:gc.time                 /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5        2993.000                     ms
[info] HotScalacBenchmark.action:p0.00                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6710.886                  ms/op
[info] HotScalacBenchmark.action:p0.50                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6773.801                  ms/op
[info] HotScalacBenchmark.action:p0.90                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6835.038                  ms/op
[info] HotScalacBenchmark.action:p0.95                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6836.716                  ms/op
[info] HotScalacBenchmark.action:p0.99                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6836.716                  ms/op
[info] HotScalacBenchmark.action:p0.999                  /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6836.716                  ms/op
[info] HotScalacBenchmark.action:p0.9999                 /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6836.716                  ms/op
[info] HotScalacBenchmark.action:p1.00                   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             6836.716                  ms/op
[info] HotShapelessBenchmark.action                      /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample   18        3321.889 ±       52.968   ms/op
[info] HotShapelessBenchmark.action:gc.alloc.rate        /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5         460.968 ±       26.362  MB/sec
[info] HotShapelessBenchmark.action:gc.alloc.rate.norm   /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5<PHONE_NUMBER>.400 ±  4094565.358    B/op
[info] HotShapelessBenchmark.action:gc.count             /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5         208.000                 counts
[info] HotShapelessBenchmark.action:gc.time              /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample    5        3362.000                     ms
[info] HotShapelessBenchmark.action:p0.00                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3250.586                  ms/op
[info] HotShapelessBenchmark.action:p0.50                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3309.306                  ms/op
[info] HotShapelessBenchmark.action:p0.90                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3428.005                  ms/op
[info] HotShapelessBenchmark.action:p0.95                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3439.329                  ms/op
[info] HotShapelessBenchmark.action:p0.99                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3439.329                  ms/op
[info] HotShapelessBenchmark.action:p0.999               /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3439.329                  ms/op
[info] HotShapelessBenchmark.action:p0.9999              /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3439.329                  ms/op
[info] HotShapelessBenchmark.action:p1.00                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true  sample             3439.329                  ms/op
[info] ColdScalacBenchmark.action                        /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5       22429.638 ±      687.585   ms/op
[info] ColdScalacBenchmark.action:gc.alloc.rate          /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5         150.384 ±        3.941  MB/sec
[info] ColdScalacBenchmark.action:gc.alloc.rate.norm     /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5<PHONE_NUMBER>.000 ± 31303175.452    B/op
[info] ColdScalacBenchmark.action:gc.count               /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5         282.000                 counts
[info] ColdScalacBenchmark.action:gc.time                /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5        2336.000                     ms
[info] ColdShapelessBenchmark.action                     /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5       16221.570 ±      512.319   ms/op
[info] ColdShapelessBenchmark.action:gc.alloc.rate       /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5         114.326 ±        1.850  MB/sec
[info] ColdShapelessBenchmark.action:gc.alloc.rate.norm  /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5<PHONE_NUMBER>.000 ± 16016911.514    B/op
[info] ColdShapelessBenchmark.action:gc.count            /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5         194.000                 counts
[info] ColdShapelessBenchmark.action:gc.time             /var/folders/fm/f93y40ld5ql0h43m_7p6kkqh0000gn/T/sbt_89158142           true      ss    5        1616.000                     ms
[success] Total time: 585 s (09:45), completed Nov 6, 2023, 10:44:17 p.m.

The changes are within the error margin, so it seems this was a case of premature optimization. I suggest we discard this change to avoid unnecessary complexity in the codebase. Thank you for the opportunity for me to learn and improve through this process.

It's possible that the change still works but it requires significantly larger classpath than what you tested.

It's possible that the change still works but it requires significantly larger classpath than what you tested.

You are right, it is too early to say that the optimization is pre-mature (albeit I should have done more due diligence before opening the PR).
I just posted a comment under #593 requesting for extra detail. Hopefully we can get & replicate the exact setup retronym used when he raised the issue.

Need to revisit this PR.
When I did this PR, I noticed no improvement as this PR did not actually address the the real hotspot.
https://github.com/sbt/zinc/blob/44ae3fc67c799b8adef3ad9a229d323ad4e8d232/zinc/src/main/scala/sbt/internal/inc/LookupImpl.scala#L26-L32
I didn't really understand https://github.com/sbt/zinc/issues/593#issue-356617851 back then but now it make a lot more sense. If build tool pass in a naive implementation of perClasspathEntryLookup this can easily be performance bottleneck.


ONYX.WEATHER ?

Unfortunately, my ONYX.WEATHER is not integrated to Home Assistant. Is ONYX.WEATHER not yet integrated and if so, when can it be expected, because I need the ONYX.WEATHER in Home Assistant.

first off, i do not own an ONYX.WEATHER device myself, and i am also unable to test such an entity and integration.
this is why i was and am reluctant to support it, as i can never confirm if it is working correctly.
i implemented this sensor according to the API specification in the client itself, though (https://github.com/muhlba91/onyx-client/blob/main/onyx_client/device/weather.py), based on https://github.com/hella-info/onyx_api?tab=readme-ov-file#weather-stations.
what would still be necessary is mapping that entity to sensor entities in home assistant.
as far as i can tell, using a weather entity is impossible - a weather entity requires a condition that the sensor doesn't provide. a weather entity also does not support the brightness measurements that the sensor provides.
hence, the only solution i see is to create multiple sensor entities that map the ONYX.WEATHER sensor values to home assistant sensors.
i'm open to implementing basic support for these sensors, though with the caveat that they will be/stay untested from my side.
let me know what you think, especially if the plan to add multiple standalone sensors would work for your use case and if the data received by the sensor is still the same as mentioned in the API specification (https://github.com/hella-info/onyx_api?tab=readme-ov-file#weather-stations). i'd then add support in the next few weeks, as described above.

An integration of the weather station would be great. I thought that it hadn't been integrated yet due to a lack of testing opportunities. I would be delighted and would create individual sensors in Homassistant. Many thanks at this point for the very successful ONYX integration.

first off, i do not own an ONYX.WEATHER device myself, and i am also unable to test such an entity and integration. this is why i was and am reluctant to support it, as i can never confirm if it is working correctly.
i implemented this sensor according to the API specification in the client itself, though (https://github.com/muhlba91/onyx-client/blob/main/onyx_client/device/weather.py), based on https://github.com/hella-info/onyx_api?tab=readme-ov-file#weather-stations.
what would still be necessary is mapping that entity to sensor entities in home assistant. as far as i can tell, using a weather entity is impossible - a weather entity requires a condition that the sensor doesn't provide. a weather entity also does not support the brightness measurements that the sensor provides. hence, the only solution i see is to create multiple sensor entities that map the ONYX.WEATHER sensor values to home assistant sensors.
i'm open to implementing basic support for these sensors, though with the caveat that they will be/stay untested from my side. let me know what you think, especially if the plan to add multiple standalone sensors would work for your use case and if the data received by the sensor is still the same as mentioned in the API specification (https://github.com/hella-info/onyx_api?tab=readme-ov-file#weather-stations). i'd then add support in the next few weeks, as described above.

Thank you very much for the quick reply.
Why I would have liked to have the ONYX.WEATHER in HA is as follows:

The ONYX app from Hella only shows the current values. But since I live in an area with a strong foehn storm, I am looking for a way to see the history of wind, sun, temperature, humidity and air pressure from the last hours, days or weeks and I was recommended to do it via HA if there is a ONYX integration. So I bought a Rapi and set up HA and this integration and now realized that there is no ONYX.WEATHER data available.

If i use api.hella.link/box/.../api/v3/devices/... I  just received the following response:
{ 	"name": "Wettersensor", 	"type": "weather", 	"actions": [ 		"wink" 	], 	"properties": { 		"air_pressure": { 			"type": "numeric", 			"minimum": 0, 			"maximum": 150000, 			"value": 90374, 			"readonly": true 		}, 		"humidity": { 			"type": "numeric", 			"minimum": 0, 			"maximum": 100, 			"value": 78, 			"readonly": true 		}, 		"sun_brightness_peak": { 			"type": "numeric", 			"minimum": 0, 			"maximum": 150000, 			"value": 53710, 			"readonly": true 		}, 		"sun_brightness_sink": { 			"type": "numeric", 			"minimum": 0, 			"maximum": 150001, 			"value": 20966, 			"readonly": true 		}, 		"temperature": { 			"type": "numeric", 			"minimum": -400, 			"maximum": 1500, 			"value": 72, 			"readonly": true 		}, 		"wind_peak": { 			"type": "numeric", 			"minimum": 0, 			"maximum": 100000, 			"value": 2501, 			"readonly": true 		} 	} }

thank you for your feedbacks and the API output! 👍
i‘ll go ahead and map the onyx sensor values to HA sensors to add basic support for the weather station.

Thank you very much.

can you please test v7.0.0-beta.0?
i have added the HA sensors for the weather sensor values. as i don't have any testing possibility, please confirm if it's working or let me know of any bugs you find.

I will test it tonight. As I have just started with Home Assistant, my question is how to test a new beta release?
Grüße aus Innsbruck

if you have HACS installed in your HA, you can search for this integration (as you do with a non-beta release) if you add the repository. then you can enable beta versions in HACS: https://hacs.xyz/docs/faq/beta/.
alternatively, you can just check out the git tag and overwrite the (already existing) custom component in the custom_components/hella_onyx directory of your HA installation with the contents of this repository's directory custom_components/heally_onyx.
don't forget to restart HA afterwards to load the new integration version and install dependencies.

Thank you very much. I will try it and give feedback tomorrow.

I have just updated to v7.0.0-beta.0 and have now received the weather station as a new device and 7 new entities in HA. The values of all sensors match those from the Onyx app. The only difference is the wind speed. This is displayed in the app in m/s and in Homeassistant in km/h (but correctly converted). Perfect. So far I have not been able to detect any errors. Thank you so much.

Great, I'm looking forward to my test.
I think the 3 decimal places for the wind peak are too many, one decimal place should be sufficient and would fit better with the temperature value with one decimal place.

thanks for the feedback! 👍
regarding the wind peak, i am setting m/s as the unit (https://github.com/muhlba91/onyx-homeassistant-integration/blob/main/custom_components/hella_onyx/sensors/weather.py#L147), but HA will convert it to the preferred user unit. so i guess there's km/h set as your default somewhere.
regarding the decimal places, i can add a suggested precision and set it to 1 decimal place, and users can set the precision differently in the UI by clicking on the gear icon on the entity. my idea is the following suggested precisions:

humidity: 0
wind, temperature, brightness: 1

does this default suggestion of the decimal precision make sense for the implementation of these sensors?
btw, you can manually set the unit and decimal places for each entity: click on the entity and the settings button (gear icon) in the opened dialog.

i have now set the suggested precisions with brightness to 0 decimal places.
can you please try v7.0.0-beta.1 to test if this configuration is considered?
as for lx vs klx, HA only supports lx as the unit for brightness; hence, i can not manipulate this one.

i'm sorry - this was an unrelated change which was not supposed to get into main yet. i reverted that change with v7.0.0-beta.2 - can you please try and confirm?

v7.0.0-beta.2 works, many thanks.

awesome, thank you a lot for trying it and providing feedback. 👍🏻
i‘ll draft the final release tomorrow unless there are any errors coming up from the beta.

Is it possible to sort the order of the weather measured values?
e.g.:
Temperature
Humidity
Wind Peak
Air Pressure
Sun Brightness Peak
Sun Brightness Sink
Device Type
Otherwise, everything worked as expected so far and the charts also looks good.

cool, thanks for the feedback - i'll draft a release during the day! 👍
as for ordering, this is donme by HA itself. by default it's ordered by name alphabetically. you can rename each sensor btw, and also create your own dashboard with a certain ordering but that's nothing an integration can influence.

v7.0.0 is released; closing this issue.

@Jibberchris  Are the measured brightness values from your weather station also 10 times higher than the real expected values?
The maximum possible sun brightness is 130,000 lx with a clear sky and the sun at its zenith. In central Europe, a maximum of 90,000 lx should be reached at midday in summer and a maximum of 20,000 lx at midday in winter. This morning at 9:14 a.m., for example, my weather sensor measured hit the upper limit of the sensor at 150,000 lx. However, a maximum of 15,000 lx would be expected at this time.

no, my values tend to be too low, but that's because my weather station is currently mounted under a canopy and is therefore in the shade - even so, I usually only have values of around 500lx on the last few foggy days, so I feel that the values are 10 times too low. In any case, the values in the app are the same as the values in the Home Assistant. Maybe we should write to Hella support.

no, my values tend to be too low, but that's because my weather station is currently mounted under a canopy and is therefore in the shade - even so, I usually only have values of around 500lx on the last few foggy days, so I feel that the values are 10 times too low. In any case, the values in the app are the same as the values in the Home Assistant. Maybe we should write to Hella support.

I spoke to the chief developer at Hella on the phone today and had already sent him my data per mail, which he said should not be correct.

@mrogin-technic just to be sure: the values shown in HA are the same as shown in the ONYX app?
because then that would indeed mean there‘s some measurement error in the device or ONYX itself but not caused by this integration when getting the values.

@mrogin-technic just to be sure: the values shown in HA are the same as shown in the ONYX app?
because then that would indeed mean there‘s some measurement error in the device or ONYX itself but not caused by this integration when getting the values.

Yes, the values shown in HA are the same as shown in the ONYX app and ONYX itself show unrealistic sun brightness values for my ONYX.WEATHER. That's why I asked @Jibberchris directly, because if it was the same with him in the sun, it would have to be a bug with onyx software.

Today, the sun shone all day under a cloudless sky. However, it turned out that the brightness sensors of the ONYX.WEATHER-Station unfortunately do not provide meaningful values.
At 9:15 a.m., 150.000 lux were already measured at low brightness as the sun was only 12.8° height above the horizon. However, at midday, when the sunlight and brightness were at their highest, the measured values fell significantly down to 42.000 lx and rose again in the late afternoon and 100.000 lux were measured at sunset.


Fix uncaught errors

Codecov Report

Merging #133 (037d556) into main (7a18ae1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   95.10%   95.10%
=======================================
  Files          29       29
  Lines        1655     1655
=======================================
  Hits         1574     1574
  Misses         81       81

Impacted Files
Coverage Δ

pybryt/execution/tracing.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a18ae1...037d556. Read the comment docs.


microk8s status --wait-ready hangs forever - Fedora 35

I'm following below steps as mentioned on the installation https://microk8s.io/
sudo snap install microk8s --classic
microk8s status --wait-ready
And the command microk8s status --wait-ready hangs.
While is hanging, by hitting crtl+c I get below output:
Traceback (most recent call last):
  File "/snap/microk8s/2948/scripts/wrappers/status.py", line 223, in <module>
    isReady = wait_for_ready(timeout)
  File "/var/lib/snapd/snap/microk8s/2948/scripts/wrappers/common/utils.py", line 125, in wait_for_ready
    if is_cluster_ready():
  File "/var/lib/snapd/snap/microk8s/2948/scripts/wrappers/common/utils.py", line 54, in is_cluster_ready
    service_output = kubectl_get("all")
  File "/var/lib/snapd/snap/microk8s/2948/scripts/wrappers/common/utils.py", line 169, in kubectl_get
    return run("kubectl", kubeconfig, "get", cmd, "--all-namespaces", die=False)
  File "/var/lib/snapd/snap/microk8s/2948/scripts/wrappers/common/utils.py", line 35, in run
    args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env
  File "/snap/microk8s/2948/usr/lib/python3.6/subprocess.py", line 425, in run
    stdout, stderr = process.communicate(input, timeout=timeout)
  File "/snap/microk8s/2948/usr/lib/python3.6/subprocess.py", line 863, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
  File "/snap/microk8s/2948/usr/lib/python3.6/subprocess.py", line 1534, in _communicate
    ready = selector.select(timeout)
  File "/snap/microk8s/2948/usr/lib/python3.6/selectors.py", line 376, in select
    fd_event_list = self._poll.poll(timeout)
KeyboardInterrupt

Details of the OS:

Fedora 35 (Workstation Edition)
64-bit
Gnome version 41.3
Windowing System X11

I'm also attaching the tarball from the microk8s inspect command
inspection-report-20220223_133744.tar.gz
Relevant PRs (where I didnt manage to solve my problem)
https://github.com/canonical/microk8s/issues/1246
https://github.com/canonical/microk8s/issues/2574

Hi @pacostas can you please attach the inspection tarball one more time?

updated, thank you :)

I was checking the logs.
K8sdqlite isnt starting due to this.
Feb 23 13:34:00 <IP_ADDRESS> microk8s.daemon-k8s-dqlite[479837]: I0223 13:34:00.205408  479837 log.go:181] [ERROR] dqlite: proxy: first: remote -> local: remote error: tls: bad certificate

Was wondering what happened to the certificates being used by dqlite.
The cluster.yaml and info.yaml ID are not the same.
Info.yaml
Address: <IP_ADDRESS>:19001
ID:<PHONE_NUMBER>608546238
Role: 0

Cluster.yaml
- Address: <IP_ADDRESS>:19001
  ID: 0
  Role: 0


Lazy Loading route causing issue in bundle

Hi,
After I bundled my code with systemjs-builder, routing is causing an issue.
my routing file looks like :
import { NgModule }             from '@angular/core';
import { RouterModule, Routes } from '@angular/router';
const routes: Routes = [
{ path: '', redirectTo: '/dashboard', pathMatch: 'full'},
{ path: 'dashboard', loadChildren: './app/dashboard/dashboard.module#DashboardModule' },
];
@NgModule({
imports: [ RouterModule.forRoot(routes) ],
exports: [ RouterModule ]
})
export class AppRoutingModule {}
The error :

Please help me to fix this issue.

Can you provide a repo?


Flashing red status on the Outline view

Testing #69299:
Have this SCSS, | is cusor:
.foo {
  .foobar {
|

.foo {}

Press enter, you see flashing red:

Same in 1.31.x, not a regression, still unhappy. The challenge is that markers are matches at the time of editing and later (after the edit) being updated. That causes the flicker

Moving to March. This is actually tricky because I have an updated outline model, but a "stale" marker model. Checking the markers means that flash completely and I think that actually worst (see gif). We can consider delaying the update a little more, e.g optimistically wait a little for a markers change event.

I'm not sure how to verify this. I can repro on stable, but in insiders the whole outline is red so there is no opportunity for it to flash red.

Yeah, that's already it. When there is no more flashing then everything is good


chore: StatisticCustomRange is relevant to routes, not models

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

5 of 5 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 86.249%

Totals

Change from base Build<PHONE_NUMBER>6:
0.006%

Covered Lines:
1819

Relevant Lines:
2109

💛  - Coveralls


harry.md

Please add me to the project!

Glad you figured out the pull request. Looks good to me.


Docs-update-contributions

Description

Update OS "Contributing to Calico documentation", section "Docs site organization"
Also updated "Add new pages" to include code for new landing pages.

Deploy preview for calico ready!
Built with commit a1f199dcbeabb75cf9fadf742be9b81a8e2fe165
https://deploy-preview-3761--calico.netlify.app


Patch critical zlib vulnerability

What
Patch critical zlib vulnerability
Warning raised by snyk code scanning.
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.
You should have run NOCOVERAGE=true rake rswag to ensure the swagger docs are up-to-date

@colinbruce have sanity tested an API query on the uat host for the branch and it all worked fine

Looks good, however, would it be best to update all packages $ apk --update-cache upgrade or upgrade to the latest alpine image in order to resolve all security vulnerabilities?

Looks good, however, would it be best to update all packages $ apk --update-cache upgrade or upgrade to the latest alpine image in order to resolve all security vulnerabilities within the container?

not sure that $ apk --update-cache upgrade would do it but am slightly ahead of you on the upgrade to 3.16, see separate PR, which i am I will check for zlib version once deployed

closing in favour of https://github.com/ministryofjustice/laa-hmrc-interface-service-api/pull/808


Feature Request: option to hide tray icon

OS: Mac OS 10.12.5
Issue Descriptions: It would be nice to have the option to hide the tray icon on Mac OS. All of the controls I need are available on my keyboard, so I don't have much use for the tray dropdown.
Steps to Reproduce: Not a bug.
Thanks for the app. It's fantastic!

+1 here on Ubuntu. I don't necessarily need that feature myself as I have enough horizontal space (or not enough tray icons?) but I can see how it could be useful.

Discussed before, search through issues for reasoning as to why we keep saying no

Ah, sorry, I should have known to look through the "Closed" issues. Thanks anyway!


Update instructions to use JDK-17 or later

It needs to be compatible with the new Kotlin Wizard, which will apply jvmToolchain(17) for all jvm projects.

These versions in readme are minimal versions. Wizard shouldn't affect them and our support for them.
We can write a recommended version though. Not sure what exactly it should be - "JDK 17", "JDK 19", or "the latest available".

These versions in readme are the minimal versions. The wizard shouldn't affect them and our support for them.
We can write a recommended version though. Not sure what exactly it should be - "JDK 17", "JDK 19", or "the latest available".

New wizard projects will work only with JDK 17 out of the box. But, users may change jvmToolchain(11) version in build.gradle.kts file for desktop module.

We should keep JDK 11 in VERSIONING anyway, it doesn't depend on the wizard.
In Getting started we can change to JDK 17, it partially depends on wizard.

Also, we need JDK17 in compose/README (Issue here: https://github.com/JetBrains/compose-jb/issues/2826)

Does using JDK17 keep compatibility with Android API 33 and lower?
According to these docs,
https://developer.android.com/build/jdks#compileSdk
API33 uses JDK11, and API34 uses JDK17

@frankkienl

Does using JDK17 keep compatibility with Android API 33 and lower?

Yes

This PR is outdated


TTS Eval: Add TTS evaluation (MOS estimation)

What does this PR do?
Add TTS evaluation models trained on the SOMOS dataset
There should be no breaking changes

[x] Did you read the contributor guideline?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
[ ] Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
[ ] Review the self-review checklist to ensure the code is ready for review

Thank you @flexthink  for your contribution! Having a model for MOS estimation is valuable for SpeechBrain. Here are some comments following an initial code inspection:

The README.md file is missing.
Recipe tests are not currently implemented.
There seems to be an implementation of multiple systems; could we focus on integrating only the best one to help maintenance?
We need to put the logs in the official Speechbrain Dropbox.
The best model needs to be uploaded to HF (Hugging Face).
In recipes/SOMOS/ttseval/contrastive_sampling.py, I suggest writing  docstring examples for RegressionContrastiveEnhancement and ContrastivePairingPipeline.
For ssl.py, docstring examples should be added for BaselineSSLFinetune and TransformerRegression.
In metric_stats.py, docstring examples should be provided for LinearRegressionStats under MetricStats.
There's a duplicative presence of somos_prepare.py. Could you confirm if the second instance is just a soft link?

I recommend @BenoitWang  reviewing this PR as well. His insights would be valuable.
Thank you once again for your contribution.

Hi @mravanelli @flexthink,
I guess this may not be the last version of the code since we have another branch where we did some latest experiments. I agree that we keep only the best recipe. Some of my observations in my benchmark:

wavlm large gives the best corr for now
l2 loss works better than l1 loss, but sometimes it does not converge if we start with l2, so I start with l1 for 1 epoch and then shift to l2.
I added ljspeech into the training set and first did a ground-truth vs synthesized classification, then fine-tuned this model on the regression task, this helped gain also a little bit. To simplify the recipe we can provide the link of this classification model instead of adding the classification scripts.

As for the code, it seems good to me, the only thing I see here is that I don't find ssl.py very necessary, it wraps some basic speechbrain modules that we can put in the yaml file. What do you think @flexthink ?