Any way to update the count text while searching?

Great autocomplete by the way and docs, covers almost all the bases including accessibility!
On search I would like it to say 'Searching...' so two things would need to be in place for that: Currently searching and dropdown visible.
Example:

     Searching...

     Found 10 results

Thanks!

Hi,
I don't know if I understood exactly, you want to show Searching ... and Found 10 results.
The easiest way to add the code:

  <input type="text" id="basic" placeholder="type w">

    Searching...

When searching you have an auto-is-loading class, when it appears show this item from Searching..., of course you have to style it.
As for the second problem, you have an example header/footer
There you have two slots [header, footer] this example shows you can shove anything you want into them.
Good luck


Offline Mode

If there is a way to make the program/website usable while offline, that would help with website traffic if that becomes a problem. maybe there could be a way to implement bluetooth or LAN connectivity so your friends can work with your projects IRL instead of online

Currently, the website is fully accessible Offline.
As it's a PWA (Progressive Web App), when you go to the web app, it will automatically save the website into your cache and allows you to access it offline.
A collab mode offline would be cool, I will look into it.
I don't think about using Bluetooth, but also don't know how I could do using LAN. The thing is that I use peer-to-peer and I don't really know if I can use something else.


Pages per feature?

Related to issue #311 and PR #330
Same aproach - we should couple context, not functionality. What is now in "pages" should be in feature folder. Yes? If not, why?

I don't know to be fair. I think of pages as a "C" in "MVC". They serve slightly different purpose for me, they carry out pretty important business logic, including routing (like this.transitionTo). That said, I'd like to keep ALL components and smaller parts living in features reusable and atomic w/o any side effects.

I think of every feature as kind of module... Lets say that page is controller - still, for me makes more sense to keep controller and stuff that it controlls together, in one place, one context. Rather than have one place for controllers. It's same logic I apllied on test folder.
I see a point... what is in feature is clean and reusable, and in pages it gets use-case/app specific. Contain of feature says what can I use, but doesn't say how - that is specified in pages.
Ye, now I dont know either :D

As per latest point:

Now, lets say that I want to have Dashboard and there list of five users and five todos, but as read only (without editable). What would you do? I cant reuse TodosList nor UsersList - they have hardcoded Editable.

You can create TodosPage & UsersPage and make reusable component TableView that will render given array of objects? Just wondering ;) By convention pages should render mainly other reusable components or feature specific elements (of course you can skip that for pages like aboutUs where it does not make any sense)

TableView is ofc possible, this was maybe a bad example. I've lost my original point, too bad :) But this chat helped me understand why it is in pages, thanks.
I'm closing this, alho I might reopen this one day :) I'm currently working on two projects separately and I have space to try both way, if I come across any problems I will let you know :)

Yes, you are correct. Feel free to send PR ;-)

done

Its detail but it might be better to name "controlling page" other way, than "page.react.js". Can be confusing for newcommers, when I open module, I'm looking for somethink like "index" (standart from npm) or somethink with same name module has (same name? oh, this looks important), page is more like "what ever bro..."
@grabbou what do you think?


Make headers look better

Add more character to the header (add arrow, not just say Home)

It looks better now.


feature: Add group size environment variable injection

What type of PR is this?
/kind feature

What this PR does / why we need it

Add group size environment variable injection

Which issue(s) this PR fixes

Fixes # https://github.com/kubernetes-sigs/lws/issues/203
Special notes for your reviewer
Does this PR introduce a user-facing change?

Add LWS_GROUP_SIZE environment variable to all containers in a leaderworkerset.

Practical use of local branches
root@VM-0-8-ubuntu:/home/ubuntu/lws# kubectl get pods
NAME                         READY   STATUS    RESTARTS   AGE
leaderworkerset-sample-0     1/1     Running   0          32s
leaderworkerset-sample-0-1   1/1     Running   0          32s
leaderworkerset-sample-0-2   1/1     Running   0          32s
leaderworkerset-sample-0-3   1/1     Running   0          32s
leaderworkerset-sample-1     1/1     Running   0          32s
leaderworkerset-sample-1-1   1/1     Running   0          32s
leaderworkerset-sample-1-2   1/1     Running   0          32s
leaderworkerset-sample-1-3   1/1     Running   0          32s
leaderworkerset-sample-2     1/1     Running   0          32s
leaderworkerset-sample-2-1   1/1     Running   0          32s
leaderworkerset-sample-2-2   1/1     Running   0          32s
leaderworkerset-sample-2-3   1/1     Running   0          32s
root@VM-0-8-ubuntu:/home/ubuntu/lws# kubectl describe pods leaderworkerset-sample-2
Name:             leaderworkerset-sample-2
Namespace:        default
Priority:         0
Service Account:  default
Node:             cluster1-worker2/<IP_ADDRESS>
Start Time:       Wed, 04 Sep 2024 13:17:19 +0800
Labels:           apps.kubernetes.io/pod-index=2
                  controller-revision-hash=leaderworkerset-sample-7b67975f84
                  leaderworkerset.sigs.k8s.io/group-index=2
                  leaderworkerset.sigs.k8s.io/group-key=ee0d9ef1ac6e34b19b82b1ec3c9df8128b804444
                  leaderworkerset.sigs.k8s.io/name=leaderworkerset-sample
                  leaderworkerset.sigs.k8s.io/template-revision-hash=97c9d753bb0b5993c9154ee9b9ea554e2ed3fb3d
                  leaderworkerset.sigs.k8s.io/worker-index=0
                  statefulset.kubernetes.io/pod-name=leaderworkerset-sample-2
Annotations:      leaderworkerset.sigs.k8s.io/size: 4
Status:           Running
IP:               <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  StatefulSet/leaderworkerset-sample
Containers:
  nginx:
    Container ID:   containerd://c40aa91f558e0d045551bc14e4a805490eba881244c7e50b51d73f9e576bf5e7
    Image:          nginx:1.14.2
    Image ID:       docker.io/library/nginx@sha256:f7988fb6c02e0ce69257d9bd9cf37ae20a60f1df7563c3a2a6abe24160306b8d
    Port:           8080/TCP
    Host Port:      0/TCP
    State:          Running
      Started:      Wed, 04 Sep 2024 13:17:20 +0800
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:  100m
    Requests:
      cpu:  50m
    Environment:
      LWS_LEADER_ADDRESS:  leaderworkerset-sample-2.leaderworkerset-sample.default
      LWS_GROUP_SIZE:      4
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-fc46f (ro)
Conditions:
  Type                        Status
  PodReadyToStartContainers   True
  Initialized                 True
  Ready                       True
  ContainersReady             True
  PodScheduled                True
Volumes:
  kube-api-access-fc46f:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  40s   default-scheduler  Successfully assigned default/leaderworkerset-sample-2 to cluster1-worker2
  Normal  Pulled     39s   kubelet            Container image "nginx:1.14.2" already present on machine
  Normal  Created    39s   kubelet            Created container nginx
  Normal  Started    39s   kubelet            Started container nginx
root@VM-0-8-ubuntu:/home/ubuntu/lws#

/lgtm
/approve


incremental models that include updating existing records

general idea:

uniquely identify new records with key=(pk | composite key)
delete existing records matching key
insert new records matching key


Install Django CMS to existing project needs update

Currently the instructions to install Django CMS to an existing project does not work for django 1.8 - imagine these instructions need updating. (requirements don't include django 1.7 or .8)

@evildmp is this the case?

Just as an example - in the instructions, TEMPLATE_CONTEXT_PROCESSORS = []  is used, however, in Django 1.8+, this is deprecated.  All TEMPLATE options fall into the TEMPLATE tag now.   I tried following instructions to update my project with django CMS (I'm using django 1.8.6), but instructed me to update the TEMPLATES tag

@grwhumphries thanks for the report, also affects template-related steps in http://docs.django-cms.org/en/latest/introduction/install.html.


upgrade golang to v1.17

Signed-off-by: Xiangjing Li<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/15570

/lgtm


Added link to home on header logo

Summary of Changes
Added link to home page of Amundsen for the Lyft logo in the nav bar as requested here
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide
[ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

Codecov Report

Merging #162 into master will increase coverage by 19.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #162       +/-   ##
==========================================
+ Coverage   53.24%   73.1%   +19.85%
==========================================
  Files         108      22       -86
  Lines        2710     948     -1762
  Branches      277      79      -198
==========================================
- Hits         1443     693      -750
+ Misses       1238     229     -1009
+ Partials       29      26        -3

Impacted Files
Coverage Δ

...ication/static/js/components/common/Tabs/index.tsx

...ndsen_application/static/js/ducks/search/api/v0.ts

...ation/static/js/ducks/tableMetadata/api/helpers.ts

...dsen_application/static/js/ducks/search/reducer.ts

...lication/static/js/components/SearchPage/index.tsx

...ation/static/js/components/SearchPage/constants.ts

...application/static/js/ducks/popularTables/types.ts

...pplication/static/js/ducks/tableMetadata/api/v0.ts

...ic/js/components/SearchPage/SearchBar/constants.ts

...on/static/js/components/AnnouncementPage/index.tsx

... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba07ea...3463f18. Read the comment docs.

@ryanlieu note that it will be best to describe the feature in the summary or link to a public github issue as opposed to our JIRA tickets. Non-Lyft contributors won't be able to understand the context because they can't view the link.


Add hover card to holdings by user

A hovercard could be added as well as now it doesn't work :|
Once you hover on the username in the user's holdings, it should show the hover user profile card
Reserved for @Jarsen136 👀

Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/2751#issuecomment-1090075164

take this
pls tell me more about what kind of card you would like to add 👀

this one :)
https://user-images.githubusercontent.com/5887929/161991695-a3faf804-c8c3-477d-bfbb-82053ab36071.mov


perf(tests): enable tests to run concurrently

By making it so every test run in a separate folder, so all tests can run at the same time without any conflicts

Maybe also updating the tests workflow would be a good idea?

Maybe also updating the tests workflow to run multi-threaded would be a good idea?

Would be great! Could you update the PR to include that?

Maybe also updating the tests workflow to run multi-threaded would be a good idea?

Would be great! Could you update the PR to include that?

Sure!


Add hash quote syntax

In Common Lisp, #'function-name exists as a shortcut to the function
reference (function function-name). Although that in LFE you couldn't
do that in exactly the same way, as a function's arity always has to be
known in order to reference it, we can have something very similar:
Just use the Common Lisp syntax and specify the arity in addition.
Usage Examples:
(: lists map #'string:to_lower/1 '("fooBar" "FizzBuzz"))

(: lists filter #'is_function/1 (list #'-/1 3 #'abs/1 -5))

(: lists map #'-/1 '(5 -8 1))

(: lists zipwith #'-/2 '(1 2 3) '(1 5 8))

(: lists zipwith #'//2 '(1 2 3) '(1 5 8))

(: lists zipwith #'=:=/2 '(1 2 3) '(1 5 8))

(: lists sort #'</2 '(1 8 5 2 3))

Note that for the first of the two commits here ("Remove and ignore [...]"), I've made a separate pull request, which is inted to be applied before this one.


Remove default parameters or setup babel?

https://github.com/tightenco/ziggy/blob/8962ad96cda7daedd76bf9268861112b613d6063/src/js/route.js#L1
Default params only work in modern browsers. For this to work in IE 11 or anything else before es6 you might want to use babel, or just remove the default params and add a check at the top of the function? :)

May be generate a minified version along.

That's totally my fault. I'd rather not introduce babel just for this. I'll update. Thanks @zackify!

I think we will eventually end up adding Babel as the Javascript becomes more in-depth, but I agree, lets hold off for now.

@DanielCoulbourne if you want I could send a pr that adds minimal stuff and a precommit hook that builds it. It's whatev you want bro

Params still have a default value set to {}.

uhguhghghghghghgh
thanks totally did not notice lol


fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object

Fixed typos.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

I will do that now.


fix closing bracket

Cheers for this - I actually pushed a fix before I spotted this PR (and I've added prepublish hooks so that I don't send up a bad release again - sorry - and thank you!)


Feature Print DataAsset

Hi, is it possible to also print DataAsset. Currently,  it says no widget  found.

Hi imtrobin,
If you are calling it from a button on the toolbar, try a shortcut key.
It is possible that the focus has been lost.
I apologize for the inconvenience and ask for your patience while I work to
correct this issue.
Thanks,
Naotsun
On Fri, Oct 13, 2023 at 10:40 AM imtrobin @.***> wrote:

Hi, is it possible to also print DataAsset. Currently, it says no widget
found.
—
Reply to this email directly, view it on GitHub
https://github.com/Naotsun19B/GraphPrinter/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMLKIGVSPJ6QJUFND4PI4W3X7CLZRANCNFSM6AAAAAA56NZFNU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


No callback registered for transaction with state purchased.

i always get this message  ** No callback registered for transaction with state purchased.** and i don't know why.
here is my code
InAppUtils.purchaseProduct(sku, async (error, response) => {                                         if (response && response.productIdentifier) {                                             subscribe('ios', token, {                                                 iap_id: response.productIdentifier,                                                 receipt: response                                             }, {                                                 success: ({ code, message }) => {                                                     if (code == 200 || code == 201)                                                         dispatch(fetchUserInfo(nav));                                                     else                                                         alert(message);                                                 }, error: err => alert(JSON.stringify(err))                                             })                                         }                                     })                                 }
any idea?
System:
OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i7-4771 CPU @ 3.50GHz
Memory: 6.17 GB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 14.15.4 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 6.14.10 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>53283
Xcode: 12.3/12C33 - /usr/bin/xcodebuild
Languages:
Java: 15.0.2 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.11.0 => 16.11.0
react-native: 0.62.2 => 0.62.2
npmGlobalPackages:
react-native: Not Found

fixed after upgrade the package to latest


What is the preferred way of sending errors to the api gateway?

When using MoleculerError to create errors in my services which are in turn sent back to the api-gateway it exclusively sends http status code 200 back to the client regardless. I've tried adding a global onError handler aswell, but to no avail. When I return errors from moleculer-web (authorize function) it sends them back to the client correctly so I am assuming this is an issue with how data is being exchanged between the api gateway and the services and how errors are picked up.
What is the best practice here?

Could you show the code part where you throw an Error? Do you use either throw new MoleculerError() or  return Promise.reject(new MoleculerError()) instead of return new MoleculerError()?

Here is an example;
from users.js
 try {     user = await ctx.broker.call("identity.get", { id: ctx.params.id });   } catch (err) {     return new MoleculerError("Error in retrieving user", 500);   }
and then inside actions;
      async get(ctx) {         return await userActions.get(ctx);       },
This is the only I get it to not crash. If I use Promise.reject in the actual function where I return the Error I get a type error circular to json fault.

This code is not correct because it will be a simple response which is 200. You must throw or reject the errors. The circular JSON error comes from other reason because it should work properly.


Add missed features - (2.20.0 - 0.85.1 - 1.55.1)

add gyms battle features
add raid attack features
add lobby features
update protobuf to 3.5.0
update to 0.87.5 (2.21.0)

You are including stuff like SignalLog that's already here but named Signature

ok delete

I think on initial glance this looks good @AeonLucid

Tested and works fine.Ready to go @AeonLucid

@AeonLucid are you going to merge or is this project abandoned? Last commit was September

@AeonLucid please merge.

I think we can safely consider this project abandoned at this point. I have already moved the Java repo over to furtif's fork.  Thoughts?

@celandro uses https://github.com/Furtif/POGOProtos allright


Request totals for dashboard v2

Implements a module that displays totals of requests/connections being made. There's a lot of metrics manipulation here that I think could be simplified going forwards

Fixes #193

realizing I made a fatal mistake by not naming this module TotalRequestsLive

:star: :package: :rabbit:  I like this branch a lot

:star: :panda_face:

:star: :+1:


cargo test --test cli_run runs for ever when the example programs don't compile

The cargo test --test cli_run has an issue when the example programs don't compile: it makes the test waiting without emitting any error.
E.G., add an invalid line in examples/hello-world/Hello.roc:
app Hello provides [ main ] imports []

greeting =
    hi = "Hello"
    name = "World"

    "\(hi), \(name)!!!!!!!!!!!!!"

f # <---- this is meaningless!

main = greeting

and run:
cargo test --test cli_run hello

This would display:
running 2 tests

And nothing happens.

Closing as this is no longer and issue.


Fix accidental typo

Hi @mattdesl!
I was rambling through the code and found a typo.
Not sure whether it fixes something, just guess it should be like that :)

D'oh, thanks! :smile:


YouTube Music thinks account is being used in multiple locations

Checklist:

[x] I have checked that there are no issues with similar or the same content
YOU SHOULD CHECK CLOSED ISSUES AS WELL

[x] I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there

[x] I have double checked and can reproduce the issue

OS: Linux Mint
GPMDP Version: Latest (4.7.1)
Issue Descriptions: At times, YouTube Music will pop up a modal saying:

Listen on this device?
Your account is being used on another device. Listen on this device instead?
[Not Now] [Switch]

I have to hit the Switch button to start my music back up. I use only this machine with GPMDP / YTM, so I think the problem lies with how GPMDP integrates with YTM, and it gets confused somehow.
Steps to Reproduce: I believe that it usually happens when I've paused the music for a short time, then attempt to start the music again. I don't know if this contributes to the problem, but I use Global Hotkeys to do the pausing and unpausing.

I can confirm this exact issue on Windows, too.
Would be nice if someone were able to look into it!

Not exactly an issue/bug for me, but it'd be great if this program could "Auto-Switch" when this notification appears. This way I don't have to flip back and forth to this program to manually click switch.


Update the library to support generics

Description

[ ] Bump golang version in go.mod to 1.18 and in relevant GitHub actions
[ ] Execute go mod tidy to format the go modules files correctly
[ ] The library actually accepts only string items. It should be modified to support generics and use arbitrary item types. For example:

func New(items ...any) (*RoundRobin, error) {
	return NewWithOptions(DefaultOptions, items...)
}

There are 2 possible methods to implement Generics here

Not strict (only using any )

If implemented this way roundrobin.New(proxies...) will not work because
it is not possible to convert []string to []any so we have to do more changes
and type handling and is less strict

Strictly Generic (Using Constraints)

This implementation is strictly generic so to invoke this we need to use
something similar to roundrobin.New[string]("a", "b", "c", "d").

Either way it will break all its dependents i.e proxify and shuffledns .
This has more cons than pros so it was decided to skip this for now


Creating some functions in file_manager.py

Write following functions in file_manager.py
Note : Make sure not to push these to main branch, create a new branch.
All of these functions must have proper docstrings (refer to the docstrings of already existing functions).

is_file(file_name) - checks whether the file exists or not.
is_folder(folder_name) - checks whether the folder exists.
list_files(address) - lists all the file in the given address (not folders)
list_folders(address) - list all the folders at given address (not files)
list_all(address) - list both files and folders at given address
delete_file(file_name) - This function deletes the file.
copy_file (file_name, destination_folder) - Copies the file to the destination folder.

How to test the module?
The testing procedure involves using a file named test.py, which is explicitly excluded from version control via the .gitignore configuration. Consequently, any files generated within the test folder will also be excluded from version control and, thus, will not be pushed to the repository. (Note: The folder specified is test folder not tests folder. tests folder has unit tests)

i would like to attempt this if you are fine with it


modifier keys and batch operations...

so, i'm typing in lowercase right now because i discovered an extremely inconvenient problem with superpng and batch operations - shift/alt keys will open input options even when photoshop is not in focus/minimized/etc, and it does not respect the batch operation option to suppress file open dialogs.
as you might have guessed, i'm running a batch operation right now, one of several i'll need to do tonight
this means that holding down shift to select text in another program can trigger it, or alt tabbing, or, yes, holding shift to capitalize things.
i beg of you to fix this

@oomek Any chance you have a build environment that would work for compiling this? I'd love it if you could change it to require both Ctrl and Shift to be held down (and leaving alt out entirely).

Don't be. It's how we call ciggarettes here in the UK. But I digress. I've never compiled a Photoshop plugin, but I can try. I also requested one feature a while back (premultipied alpha option on the save dialog box) Maybe now is the time.

I'm looking at the code now, it seems I was mistaken about it accepting the Ctrl key.
https://github.com/fnordware/SuperPNG/blob/0de1e0eec097de72a122b89db31fd2cd4f38e86b/src/photoshop/win/SuperPNG_InUI_Win.cpp#L210
So this line could just be changed to...
bool shift_key = ( KeyIsDown(VK_SHIFT) && KeyIsDown(VK_CONTROL) );
Or to be on the safe side, since there might be a reason he specified the left and right variants separately (Photoshop bug maybe?)...
bool shift_key = ( ( KeyIsDown(VK_LSHIFT) || KeyIsDown(VK_RSHIFT) ) && ( KeyIsDown(VK_LCONTROL) && KeyIsDown(VK_RCONTROL) ) );

@oomek On second thought, I practically never see alt + shift hotkeys in any program, so let's go with that instead.
bool shift_key = ( ( KeyIsDown(VK_LSHIFT) || KeyIsDown(VK_RSHIFT) ) && ( KeyIsDown(VK_LMENU) || KeyIsDown(VK_RMENU) ) );

@oomek Having read your feature request for premultipled alpha, I would VERY much like this too.

I'll give it a go tomorrow or during the weekend.

@Aidolii please open an issue on my fork https://github.com/oomek/SuperPNG
so we can discuss it further. I've added premultiply alpha to the save dialog, but I'm not sure about suppressing the hotkeys as it also affect the dialog not showing up when you normally open the file.

https://github.com/oomek/SuperPNG/releases


[SR-14035] Compiler toolchain build error on M1 mac

Previous ID
SR-14035

Radar
rdar://problem/73014167

Original Reporter
@johnno1962

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Compiler, Project Infrastructure

Labels
Bug

Assignee
@shahmishal

Priority
Medium

md5: 10a69735b885909bbf12d3e950153532

Issue Description:
HI Apple,
I've tried any number of things but have been unable to build a toolchain using swift/main & Xcode 12.3 and the swift/utils/build-toolchain script. It seems to be something to do with supporting multiple architectures for macOS and simulator w/lipo. This warning may be relevant:
warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: archive library: lib/swift/watchsimulator/i386/libswiftCompatibility51.a will be fat and ar(1) will not be able to operate on it

A year on, I've just tried again and basically utils/build-toolchain basically no longer works (on an M1 at least). The issues I mentioned above are still there along with a few new undefined symbols related to half-floats and the bootstrapping process to bring Swift sources into the compiler doesn't seem to work, failing to find a usable version of swiftc. I don't have an intel machine to test if it "just works" on that architecture.

@edymtt Looks like you had a fix for this previously, I wonder if something changed recently.

edymt's fix made a big difference but there are many other issues, at least on my machine. My clone is from a week ago.

An update on building a toolchain on M1, I've been able to get the build past the previous road blocks I mentioned by performing the whole build under rosetta!
I've not been able to get a toolchain just yet as it trips up at the very last trying to build swift-driver multi-architecture but it does seem to indicate this isn't a holding it wrong issue or specific to my particular clone. The problem is very easy to replicate if you run build-toolchain on an M1. I'm sure someone with the right llvm and CMake knowledge could clear this up in an instant.

To finish the week  on a high note, I've been rewarded with a toolchain built on an M1 by running the whole thing inside Rosetta2. I had to edit the build.ninja file for libYams.a inside the swift-driver project to correct the -arch for target arm64 then build on the command line, edit that build out and retry the toolchain script. Seems like an obscure CMake problem for this configuration. Note, the "rosetta" trick only works with recent versions of CMake (I used 3.23.1 and Xcode 13.4)

@johnno1962 I am assuming that normal-ish builds work on M1? Are you only seeing this issue with build-toolchain?

Yes, I think the build-script with and without --xcode works now.

@johnno1962 I imagine that the issue here is that build-toolchain I don't think on our CI is being run on M1 machines. So I imagine that some incompatibilities have snuck in. @shahmishal we really should have a bot running build-toolchain on an Apple Silicon machine (maybe once a day) like the status bot.

I couldn't agree more but the first step would be investigating the problems I'm seeing and getting it working.

Bump.

Just did a fresh clone and build-toolchain. Worked 💯 Thanks to everyone who sorted this out.


Changed AzureRM to Az in DataFactory document.

#39591

@zhangyd2015 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#sign-off


Deployment Validation with coverage-formatters writes to nested coverage/ folder

Summary
We use Github actions. One of our steps is to do a trial deployment to validate and do code coverage calculations. Specifically we use this command:
sf project deploy start --verbose --dry-run -x package/package.xml --target-org stage --ignore-conflicts --wait 45 --test-level RunSpecifiedTests --tests ${{ steps.related-tests.outputs.result }} --coverage-formatters json --coverage-formatters cobertura

This command executes normally. Here's the log output from that command:
... (skipping deployment and testing lines of 'In Progress'

Test Success [1]
✓ CaseRepoTest.unitTestConstructorPositive

Apex Code Coverage
 Name         % Covered Uncovered Lines
 ──────────── ───────── ───────────────
 CaseRepo 100%

Test Results Summary
Passing: 1
Failing: 0
Total: 1
Time: 70
Code Coverage formats, [json, cobertura], written to coverage/
Dry-run complete.

This results in the cobertura file being written to coverage/coverage/cobertura.xml' not coverage/cobertura.xml` as I would expect, given the output line saying "Code Coverage formats, [json, cobertura], written to coverage/"
Steps To Reproduce
I'm unable to create a full repo, for security reasons. However, the operant bits of the workflow file are as follows:
      - name: Generate Deployment Delta
        run: |
          sf sgd source delta -t="HEAD" -f="HEAD~1" -o "." --loglevel=debug
      - name: Deploy to Stage and run Tests (Check Only)
        if: ${{ steps.related-tests.outputs.result != null }}
        run: |
          echo "Running related tests: ${{ steps.related-tests.outputs.result }}"
          sf project deploy start --verbose --dry-run -x package/package.xml --target-org stage --ignore-conflicts --wait 45 --test-level RunSpecifiedTests --tests ${{ steps.related-tests.outputs.result }} --coverage-formatters json --coverage-formatters cobertura
      - name: Deploy to Stage without running Tests (Check Only)
        if: ${{ steps.related-tests.outputs.result == null }}
        run: |
          echo "Running related tests: ${{ steps.related-tests.outputs.result }}"
          sf project deploy start --verbose --dry-run -x package/package.xml --target-org stage --ignore-conflicts --wait 45 --coverage-formatters json --coverage-formatters cobertura
      - name: "Check Cobertura file was created"
        id: does_cobetura_exist
        shell: bash
        run: |
          file=$(pwd)/coverage/coverage/cobertura.xml
          if [ -f $file ]; then
            echo "coverage/coverage/cobertura.xml exists"
            echo "FILE_EXISTS=true" >> $GITHUB_OUTPUT
          else
            echo "$(pwd)/coverage/coverage/cobertura.xml does not exist"
            echo "FILE_EXISTS=true" >> $GITHUB_OUTPUT
          fi

Expected result
cobertura.xml should be found in the WorkingDir's coverage/ folder.
Actual result
cobertura.xml (and it's sister Json file) are written to coverage/coverage/ folder.
System Information
Github Actions using the official SF cli docker image:
    container:
      image: salesforce/cli:latest-full

Additional information

{
  "architecture": "linux-x64",
  "cliVersion"<EMAIL_ADDRESS>  "nodeVersion": "node-v18.20.1",
  "osVersion": "Linux 6.5.0-1017-azure",
  "rootPath": "/usr/local/lib/nodejs/lib/node_modules/@salesforce/cli",
  "shell": "bash",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 3.0.[13](https://github.com/department-of-veterans-affairs/va-teams/actions/runs/8635526082/job/23673436239#step:14:14) (core)",
    "@oclif/plugin-commands 3.2.2 (core)",
    "@oclif/plugin-help 6.0.20 (core)",
    "@oclif/plugin-not-found 3.1.1 (core)",
    "@oclif/plugin-plugins 5.0.1 (core)",
    "@oclif/plugin-search 1.0.20 (core)",
    "@oclif/plugin-update 4.2.2 (core)",
    "@oclif/plugin-version 2.0.16 (core)",
    "@oclif/plugin-warn-if-update-available 3.0.[15](https://github.com/department-of-veterans-affairs/va-teams/actions/runs/8635526082/job/23673436239#step:14:16) (core)",
    "@oclif/plugin-which 3.1.7 (core)",
    "@salesforce/cli 2.35.6 (core)",
    "apex 3.1.0 (core)",
    "auth 3.5.0 (core)",
    "data 3.2.2 (core)",
    "deploy-retrieve 3.4.0 (core)",
    "info 3.1.0 (core)",
    "limits 3.2.0 (core)",
    "marketplace 1.1.0 (core)",
    "org 3.6.0 (core)",
    "packaging 2.2.0 (core)",
    "schema 3.2.0 (core)",
    "settings 2.1.0 (core)",
    "sobject 1.2.0 (core)",
    "source 3.2.0 (core)",
    "telemetry 3.1.[17](https://github.com/department-of-veterans-affairs/va-teams/actions/runs/8635526082/job/23673436239#step:14:18) (core)",
    "templates 56.1.0 (core)",
    "trust 3.4.0 (core)",
    "user 3.4.0 (core)",
    "sfdx-git-delta 5.34.0 (user)"
  ]
}

You should change your info-required-bot to accept a docker image tag as well.

hey @codefriar - nice catch - we'll get this fixed

@WillieRuemmele  - at the risk of being told off here,
it'd be nice if i could specify the folder / filename ;)

@codefriar more than just --output-dir?

@WillieRuemmele Apologies. I didn't realize --output-dir was an option. It's not listed here: https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/cli_reference_project_commands_unified.htm#cli_reference_project_deploy_start_unified
Nor is it listed in the command output:

Perhaps that's a docs bug? I'm currently testing adding --output-dir to my ci setup.
I understand this is likely a breaking change. is there any other solution than just updating the output of where it's stored?

sorry, I mislead you, it's the --results-dir flag

ah, then it's my bad for not having caught --results-dir I kept looking for an output option.

@codefriar - I'm not affiliated with Salesforce, but this is consistent with what I've seen developing a plugin (not to advertise it or suggest you use it - https://github.com/mcarvin8/apex-code-coverage-transformer).
The --results-dir flag is the one you use to specifiy a different directory besides the default one (which I believe defaults to the deploy ID). But this still creates an additional coverage sub-folder.

@codefriar - I'm not affiliated with Salesforce, but this is consistent with what I've seen developing a plugin to convert the code coverage output for SonarQube and what I've listed in that plugin's readme (not to advertise it or suggest you use it - https://github.com/mcarvin8/apex-code-coverage-transformer).
The --results-dir flag is the one you use to specify a different directory besides the default one (which I believe defaults to the deploy ID). But this still creates an additional coverage sub-folder no matter what results-dir you specify.
I usually append this to my deploy command (my plugin converts the JSON output over the cobertura output but I think the directory logic works the same) - --coverage-formatters json --results-dir coverage.
This still creates the coverage file in ../coverage/coverage/coverage.json
I've tested json-summary and that gets added to the same folder path, just a different file name.
I think it would be nice if this extra sub-folder created by the CLI was removed since I've definitely had failed pipelines when passing the coverage file path to my plugin.

@mcarvin8 is there any ongoing work by Salesforce to support sf run test format (test-result-codecoverage.json) while doing sf project deploy ?

@mathpaquette - I'm not aware of any ongoing work to have the same coverage JSON formats for both deployments and test run. That would be ideal. But I haven't created an issue to request that, but let me dig first to see if anyone else has submitted a request for that.
I did submit a case before I went on travel to have Salesforce fix the deployment command coverage reports since the deployment coverage reports inaccurately report covered lines in Apex classes/triggers, but I think that was closed while I was away.


Add generated paginators

This adds generated paginators for a number of services. This only adds
the simple cases where the response contains only two elements: a list
which is the result key and the next token.
The script that generated these will look for the standard values
('NextToken', 'MaxResults') but also look for any values that are common
within a given service.

This looks awesome, thanks!

I got a request to break this up into 98 PRs, one for each service. Thank god for hub

After breaking out 20ish prs we decided it would be better to just add more generated tests so we really don't have to look at these.


flappy content schema test

Hey,
just putting a note in for this.
there seems to be some flaky tests in the manuals publisher that get triggered when you update content schema, looking through the builds it seems to be a common flaky test

we owe you a beer :D

Well, my commit message does say "...and the test consistently passes (or so it seems anyway)." so maybe give it a while 😉 to be sure.


how to Record two sceneView (Stereo Mode) ?

Hello Ahmed, I'm Amr
I have to make my app with two views of "ARSCNView"
    @IBOutlet var sceneViewL: ARSCNView!
    @IBOutlet var sceneViewR: ARSCNView!

then should record them on the same video, how can I add it on recorder ?!
recorder = RecordAR(ARSceneKit: sceneViewL)
if you can speak Arabic that will be better bro :D

this is my merge UIImage


Add conversation styling and shortcuts for Android 🤖

cc: @arosiclair
Details

The PR implements conversation notifications for Android alongside with conversation shortcuts. From now on it is possible to go to a conversation from android shortcuts, and manage them in system options.
Fixed Issues

$ https://github.com/Expensify/App/issues/37604
PROPOSAL: N/A
Tests

[x] Get a DM notification and press it
[x] Leave the app and long press on the app icon
[x] The conversation shortcut should appear

Offline tests

N/A
QA Steps

[x] Get a DM notification and press it
[x] Leave the app and long press on the app icon
[x] The conversation shortcut should appear

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/d6245757-9cd9-42ec-9a6e-931c6a220f8b

Android: mWeb Chrome
N/A

iOS: Native
N/A

iOS: mWeb Safari
N/A

MacOS: Chrome / Safari
N/A

MacOS: Desktop
N/A

Ad-hoc build is running

Is this expected? If we have two notifications only one of them is displayed in the long press menu:
screen-20240819-215535.mp4

I think that's how Android handles it - on other apps it only shows the newest notification, and it looks very similar to the video

@rayane-djouah I haven't found any way to change that. I also quickly browsed through the Google documentation, and couldn't see anything that could change that behaviour - nevertheless it only appears when there are less than 3 shortcuts.
However I've also noticed a small bug I'll have to fix - the shortcuts don't get dismissed after signing out. I'll try to address that this week! (I also have some duties around the HybridApp, that's why I cannot jump straight to it)

Just a quick update: I've had some time to give it a go. My guts tell me it's possible, but I was still not able to change the behaviour of the shortcut 😄
I also investigated the shortcuts removal upon sign out, however it would be a bit more complicated. Ideally I would write a native class that would handle the shortcuts, and expose the clear method to React Native, and trigger it whenever a user signs out. It would require more work, but I think it's necessary to avoid some strange hacks.
There are some RN libraries out there, but it seems they don't handle our specific use-case of Conversation Shortcuts. Therefore I don't know if they would work correctly. We can always write a tailor-made Native Module that could also handle our navigation quirks if we decide to add other shortcuts (similarly to OldDot)
I would love to hear your feedback! I'll try to find some time next week to move on with it!

I also quickly browsed through the Google documentation, and couldn't see anything that could change that behaviour - nevertheless it only appears when there are less than 3 shortcuts. I'll investigate that further

This issue happens on every flavor of Android (Pixel, Samsung, etc) or just some of them?

I also investigated the shortcuts removal upon sign out, however it would be a bit more complicated.

After signing out, do the shortcuts not work at all? Or does the app let you sign in and then redirect to the correct chat?

Hi everyone!

This issue happens on every flavor of Android (Pixel, Samsung, etc) or just some of them?

I tested on 3 devices, and it seems like it might be the default Android behaviour in that scenario (if there is a Notification targeting one of shortcuts, it doesn't duplicate the data). Although if there is more than 2 shortcuts, the issue doesn't exist (the problematic empty shortcut doesn't show up). I played with shortcut and notification builders, but I couldn't find a way to get rid of this problem

After signing out, do the shortcuts not work at all? Or does the app let you sign in and then redirect to the correct chat?

The shortcuts are available, but if the user is logged out the app opens on the SignIn page. If the user is signed in to another account, the Chat not found page appears.

The shortcuts are available, but if the user is logged out the app opens on the SignIn page. If the user is signed in to another account, the Chat not found page appears.

Oh okay good catch. Then we should be sure to reset these shortcuts whenever we log out/in.

Sorry for answering late, we've had some work after upgrading React Native in Hybrid App 😄

Oh okay good catch. Then we should be sure to reset these shortcuts whenever we log out/in.

So I think that the cleanest solution would be to create a simple NativeModule to expose a clearConversationShortcuts method to React Native side. We could call it in the signOut function to do the clean up. What do you think about it?

So I think that the cleanest solution would be to create a simple NativeModule to expose a clearConversationShortcuts method to React Native side. We could call it in the signOut function to do the clean up. What do you think about it?

I can't think of any other option so that makes sense to me too 👍

Thanks for answering @arosiclair! In this case, let's go with the NativeModule 😄 I'd love to finish the PR myself, but because currently I have a lot of work in the HybridApp project, and I don't want to block the progress @Skalakid will pick up the PR in order to finish the missing pieces! 😄

Hi, I'm Michał from SWM and I will continue finishing this PR 😄

Hello, I'm having trouble with testing message notifications when app is in the background. Do we have any problems with notifications system right now? I checked the production Android app and I don't get any alert/pop up when other users text me. The same happens on the latest main and on this PR's branch. Any updates on the backend side?

Hello, I'm having trouble with testing message notifications when app is in the background. Do we have any problems with notifications system right now? I checked the production Android app and I don't get any alert/pop up when other users text me. The same happens on the latest main and on this PR's branch. Any updates on the backend side?

Yes we started sending NewDot push notifications only to users that are enrolled in the new experience (tryNewDot.classicRedirect is enabled). Try running this JS snippet in the console in OldDot to enroll your user:
const nvp = NVP.get('tryNewDot');
nvp.classicRedirect.dismissed = false;
NVP.set('tryNewDot', nvp);

Alternatively, creating a new user in NewDot should automatically enroll them.

Heads up push notifications for the new experience are indeed bugged. We're working on a fix. Hopefully we can get it out in the next day or two.

Hello, I've added Android and iOS native modules for dynamic shortcuts and added shortcut clearing on signing out. Also, I resolved review comment from @arosiclair. The PR is ready for another review and re-test

Build is running here

@rayane-djouah can you build and test locally?

@arosiclair Hmm I see that there were some problems with the builds, maybe they was caused by not having the latest changes. I just merged the latest main so how about trying building it again?

We should just continue testing locally, ad-hoc builds are very slow and inefficient especially if we don't really need them.

@rayane-djouah Were you able to test it with notifications turned on?

@rayane-djouah I've added a fix for it. After these changes I wasn't able to reproduce the issues that you mentioned :D

@arosiclair I've added your suggestion, and everything seems to work well 😄
https://github.com/user-attachments/assets/71eddb99-bec9-4158-b84f-511cea0cbbb9

🚀 Deployed to production by https://github.com/grgia in version: 9.0.36-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

FYI @Julesssss we deployed conversation notifications for Android (NewDot not HybridApp) with this ^. I'm not on Android anymore so I can't test it normally so lemme know if this is buggy in any way.


Firefox 93: image-rendering: pixelated 🎉

https://bugzilla.mozilla.org/show_bug.cgi?id=856337#c57

Target Milestone: --- → 93 Branch

Doesn't appear to be in Nightly just yet, but surely tomorrow.
https://tests.caniuse.com/css-crisp-edges

Go
On Sat., 4 Sep. 2021, 4:38 am Kai, @.***> wrote:

https://bugzilla.mozilla.org/show_bug.cgi?id=856337#c57
Target Milestone: --- → 93 Branch
Doesn't appear to be in Nightly just yet, but surely tomorrow.
https://tests.caniuse.com/css-crisp-edges
You can view, comment on, or merge this pull request online at:
https://github.com/Fyrd/caniuse/pull/6011
Commit Summary

Update css-crisp-edges.json

File Changes

M features-json/css-crisp-edges.json
https://github.com/Fyrd/caniuse/pull/6011/files#diff-1fa4bd3cc4d6aeeee9942b72c77cc0b16cfbd564acc6a89cbdec8fe16571310e
(2)

Patch Links:

https://github.com/Fyrd/caniuse/pull/6011.patch
https://github.com/Fyrd/caniuse/pull/6011.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Fyrd/caniuse/pull/6011, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUAE3KOVB5OEUBZA2LM7NFTUAEI4HANCNFSM5DMIWKIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Confirmed, thanks!


Support building reusable components: Single dependency passing

This is draft PR, the purpose of it to demonstrate first steps on implementation of issue #4265 - Support building reusable components / eco-system, get overall feedback on design direction.
It will be broken into smaller PRs that can be easier reviewed.
There is a lot of glue code and many changes  are simply massaging existing code to get it better shape to support functionality.
Here are the main things to pay attention:

I'm reusing existing dependency management code, as it looks like good starting / staging point, but also is not really used anywhere

IFluidDependencySynthesizer is split, smaller IFluidDependencyProvider interface is added supporting only consumption flow.

All the interesting logic is concentrated in DataObject & PureDataObjetFactory. The following changes are done:

Passing of dependencies is explicit, no more reliance on ContainerRuntime.scope.
Dependencies are automatically serialized and deserialized on load, assuming they support IFluidLoadable.
A method is added to wrap non-serializable object into serializable object, to simplify creation of input for child objects.

UTs (packages/test/end-to-end-tests/src/test/dependency.spec.ts)  can be reasonable proxy for usage, though it's a bit hard to follow code given structure of our UTs (some things are in core UT infra and usage flow is not very obvious).
Better example of usage pattern is Pond & Vltava changes. They demonstrate passing passing around dependencies, and in case of Pond - wrapping non-serializable object into IFluidLoadable to be passed down to consumers.
ContainerRuntimeFactoryWithDefaultDataStore is switch to take factory, not symbolic name.

if factory is DataObjectFactory, it will use direct (DataObjectFactory) methods of creating root component vs. using runtime

Detached Root data store creation is added both to runtime & Aqueduct.

Next steps:

Get it in over multiple PRs
Use required argument semantics, not optional argument semantics when describing dependencies.
Modify the system to support multiple dependencies. Current system only supports just one object, which is not sufficient.
Move dependencies to be of IFludLodable type only.
Have a better system to describe dependencies. It should be of more general form name: type, not type: type

I haven't spent any time on this, but as a general note, i think aqueduct is getting pretty bloated and complex. i don't know if this is the right place/time, but we should consider pushing down concepts/patterns that make sesnse to the runtime layer, as ideally aqueduct is a light wrapper putting things together.

@anthony-murphy , thanks for feedback! If possible, I'd prefer to move here incrementally, as even these changes are rather massive (unfortunately), even though I've implemented only small part of what needs to be done here (i.e. it's mostly plumbing work). I'm reusing existing (but not used) functionality backed into DataObject, and for most part do not add that much new functionality. I'd prefer to keep going that route, and once it takes its reasonable shape (after all the "next steps" I mentioned above), it would be great time to re0evaluate.
What do you think?
Note that some things will become simpler for DataObject. For example, I think I'll combine optional & required templated args on DataObject,

I've raised 3 staging PRs from here. Once they settle, I'll raise final PR with actual changes.
Feedback is still welcome, but given I do not expect much traction till final PR will be raised, closing this one.


NoMethodError: super: no superclass method `backward' for Faker::Time:Class

Hello,
My project tests are failing from time to time with the same error below:
Failure/Error: request.env['omniauth.auth'] = Faker::Omniauth.github

NoMethodError: super: no superclass method `backward' for Faker::Time:Class

The first line call Faker::Omniauth.github method added by my PR #888. However, the tests only fail on Travis, and works fine on my machine!
If you check the build history you will notice I have experienced the problem multiple times.
Does anyone know what is going on? I would be happy to open a PR to solve the problem if only I know the reasons.
My Gemfile:
gem 'faker', github: 'stympy/faker', ref: 'a949848f'

Closed by #971


Add a method to show homepage / list all doujins by setting sort value to * in search.

The homepage sorts by most recently uploaded, which is also the default behavior on the api. If you search with the sort paramater as SortMethods.RECENT or no paramater at all it'll get what you're aiming for. I'll also document this once I add a proper documentation.

Your api doesn't have a homepage method. SortMethods.RECENT should be passed to search, but it requires a query. I just realize I mistakenly specified query as sort.
homepage(page, sort) {
    return this.search('*', page, sort);
}

will do. I guess.

I did some testing and got inconsistent results. The home page shows results that do not appear when searching for *, and vice-versa. Not really sure what to do here.


Device brightness is lower than normal after jailbreaking

Im using iPhone 12 Pro Max 15.4.1.
After a successful jailbreak, the device brightness is super low that i can barely see anything (even tho its set on maximum in control center). I always have to respring after jailbreaking to fix this.
happens on 1.0.5 and still not fixed on 1.1.1

Lol, same to me on iPhone 13 Pro Max 15.0.2 dopamine

Duplicate of #123


IconMenu Click Not Triggered in Mobile Browsers

Tested the IconMenus on the documentation page in both iOS Safari and Chrome.
For about half of the times, tapping on the icons would not bring up the menu.

This issue appears to be happening with any component using <MenuItem />.

I'm also having this issue. I updated material-ui to the latest stable version. I tried a combination of different settings on the IconMenu (onTouchTap, onRequestChange, useLayerForClickAway) but the IconMenu is still very inconsistent on iOS Safari especially. Sometimes it opens and sometimes it wont. Almost looks like it opens and closes straight away because I can make out the animation starting to open and then it stops. I used to get the error this.onTouchStart is not a function but since I've updated material-ui I'm not getting any errors anymore, but the IconMenu still doesn't work.

I just noticed something strange. I'm using IconMenu as my iconElementRight of my AppBar. The AppBar is always visible even when you scroll (css position: 'fixed').
I noticed the IconMenu will not open when the page I am currently on is scrollable.
If the page I am currently on is not scrollable then the IconMenu works.
Anyone have any ideas why this is???

We have been removing the IconMenu component on the v1-beta branch. We are now encouraging people to use lower level components: the IconButton and Menu component:

  return (
      <div>
        <IconButton
          aria-label="More"
          aria-owns="long-menu"
          aria-haspopup="true"
          onClick={this.handleClick}
        >
          <MoreVertIcon />
        </IconButton>
        <Menu
          id="long-menu"
          anchorEl={this.state.anchorEl}
          open={this.state.open}
          onRequestClose={this.handleRequestClose}
          style={{ maxHeight: ITEM_HEIGHT * 4.5 }}
          MenuListProps={{
            style: {
              width: 200,
            },
          }}
        >
          {options.map(option =>
            <MenuItem key={option} selected={option === 'Pyxis'} onClick={this.handleRequestClose}>
              {option}
            </MenuItem>,
          )}
        </Menu>
      </div>
    );

Hence, I'm closing it. Still, we will accept PR fixes until v1-beta takes over the master branch.


V4/nav rework

Motivation
The navigation needed a bit of an overhaul. There were a few inconsistencies:

Our previous tab navigation gave the feeling that all the pages were at equal standings. This change shows the hierarchy among the pages.
Some pages shared parameters and some did not. The new page organization takes that into account and organizes the pages such that each section has one set of parameters. Trips has date selection and station selection. Line has just date selection
We have far less data for bus routes than we do for subways. Previously we were displaying them as equivalents. Now buses have their own tab, and that tab only has the pages relevant to buses.
There was no place for system-wide metrics.
Old nav was fairly rigid. No place to add new pages which may have a new set of parameters.

Changes

Moved all navigation to the sidebar
Added a bus/subway/system tab
Separated the old overview page into today and overview
Put all station-based metrics into the trips section.
Separated station-based metrics into range and single day tabs. This is up for debate. The plan is to share with the group on Thursday, and then make a decision.
Sidebar nav

Range/single day tabs (undecided)

Testing Instructions
Click around between all the pages. Keep in mind, most of the logic for query params is coming in the next PR. So things like default parameters, and persistent parameters are not currently working. Should probably just ignore the query params for now.

Initial thoughts (some of the same discussed in slack)
Personally I don't think we should seperate out range and single day views

As @skaplan-dev brought up, speed might not be the most useful to a rider, so making the metric front and center might not be the most advisable. Although, we can discuss this with more of labs to determine order

I also noticed that dates disappear from query params when jumping between pages. Ideally we'd persist the query params even if a page ignores them. Same with preferences between range and single select, like we do today

One minor, nitpicky, thought towards not separating singe/range is when separated on my large monitor, I had to scroll to see all option in the sidebar. Less options on the sidebar brings more things above the fold for the average user

Notes so far:
1: Love the floating datepicker

2: One bug with the tabs
One bug with the tabs, and maybe with the concept, is sometimes it can get into a single date selection state, despite selecting range, which looks much weirder than if you didn't have the tabs

3: Overview page should have white widget borders
They should have the same widget borders, or, one large white border for the section. It living on the background feels weird (I know this might be a different problem to solve)

4: Two overview pages
Not a fan of both of these pages being called the same thing. Overview works in the main line section, but I don't love the name for the Trip section

5: Alert taking full width while speed doesn't
It's odd to me that they're different sizes. Either they'd sit next to each other, or, both be full width

1: Love the floating datepicker
😁

2: One bug with the tabs

True, though I think we could add a way to prevent this

3: Overview page should have white widget borders

Agreed

4: Two overview pages

Yea, I think you're right. I'm open to suggestions for other names.

5: Alert taking full width while speed doesn't

Yea, I agree. Ideally we will have a third thing there soon and can adjust these accordingly. I was thinking full alerts then two half-size below. Although now idk if alerts needs that much space. For now I can make them all full-width

🐛

I should note a caveat to my review, that I am still not a fan of the tab range vs single. I much prefer our original method for date selection changes. I am however fine with merging in this manor since it is easily reversible should the majority of labs agree

https://github.com/transitmatters/t-performance-dash/pull/458#issuecomment-1503756299
Will be fixed in next PR

Thanks for the thorough review  @skaplan-dev  😁
I think you make a good point about checking for line. I will look into your suggestion - my immediate thought is that since most components just pull the line from useDelimitatedRoute() I would think any prior gating on line wouldn't be known to the component. I could maybe do something inside the router? idk. Do you have any ideas? or am I missing something?
Also in top-level pages, they would have no way of being gated other than checking the params I would think.

Default route broken

fixed.

Speed widget broken

I can't seem to replicate this

Station picker under explore doesn’t change for headways / traveltimes when switching line

I can probably figure this out, but the next change is overhauling the station selector and then it will pull values from the query params. So that will fix it. Do you think it needs to be fixed in this PR?

Bus page is broken

Preexisting bug:
https://github.com/transitmatters/t-performance-dash/issues/452

Aggregate apis aren’t working for me locally

I also haven't been able to reproduce this

Can you explain having travel times / headways / dwells under trips and line?

Do you mean why they are not under trips and line? If so, the pages are organized by the parameters they take. The line section is station-agnostic. The trips section has the widgets which require a station to be chosen. Another reason to separate them is the "expected" date ranges are very different. A date range of a year or more in the line section is to be expected, whereas it will be very slow or not work in the trips section. If someone is clicking around in the line section then goes to "headways" and nothing loads, that will be a source of confusion/friction.

Why are we using GL and Green / etc . Shouldn't we stick to one denominator for the line? It seems like they're describing the same thing

https://github.com/transitmatters/t-performance-dash/pull/459

Tooltips on disabled nav items?

All for it. I can create an issue? https://github.com/transitmatters/t-performance-dash/issues/476


created celsius option

add celsius option in Settings.bundle
created function to convert Fahrenheit to Celsius
change temperature labels text according to option select for displaying temperature degrees in celsius or fahrenheit

I'll Merge this when I get home tonight. I'm excited to see the changes :)


[BUG] Unable to chat or send private message: com.squareup.moshi.JsonDataException

Description
Unable to chat or send private message: com.squareup.moshi.JsonDataException: Expected BEGIN_OBJECT but was NULL at path $.messages[0].reactions at $.messages[0].reactions
Devices and Versions
Your Rocket.Chat.Android version:
From F-droid : 2.6.0 Build 2042 - 22c57a15 - foss

Your Rocket.Chat Server version:
Hash : 40b50f31641c77c5d60a26641fdd840b374140da
Date : Fri Sep 28 00:06:32 2018 -0300
Branch : HEAD
Tag : 0.70.0
Author : Diego Sampaio
Subject : Merge pull request #12198 from RocketChat/release-0.70.0

Mobile device model and OS version:
Device: Samsung Galaxy s4: GT-I9505
Android: 7.1.2 (LineageOS 14.1-20180928-NIGHTLY-jltexx - without GApps installed)

Steps to reproduce

Install rocket.chat FOSS from fdroid
Connect to rocket.chat server
Click on one user or one channel
Get blank conversation window with message:  com.squareup.moshi.JsonDataException: Expected BEGIN_OBJECT but was NULL at path $.messages[0].reactions at $.messages[0].reactions

Logs
com.squareup.moshi.JsonDataException: Expected BEGIN_OBJECT but was NULL at path $.messages[0].reactions at $.messages[0].reactions

@adrienbresson This is already fixed for next release, thank you!


de language support & sort order

Added German to the client settings and sorted the order alphabetically
Added more strings

ok so for merging's sake, i think pull requests should be done on develop-ts, to keep it up to date

also i made the language dropdown automatic, so that one is not needed

Ok, I made a new pull request for the develop-ts-Branch. So I close this one.


nvim-treesitter, nvim-treesitter-textobjects: use 0.5-compat branch

Motivation for this change
As nvim-treesitter readme and comment of nvim-treesitter-textobjects there state, people using neovim 0.5 stable should use 0.5-compat branch of both nvim-treesitter and nvim-treesitter-textobjects. Because nixpkgs contains stable neovim 0.5 this PR switches these plugins to 0.5-compat branches.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 131569 at ec600821 run on x86_64-linux 1

41 packages built successfully:

spacevim
tests.vim.test_vim_with_vim_nix
vimPlugins.ale
vimPlugins.chadtree
vimPlugins.coc-nvim
vimPlugins.compe-tmux
vimPlugins.completion-treesitter
vimPlugins.context_filetype-vim
vimPlugins.cpsm
vimPlugins.diffview-nvim
vimPlugins.editorconfig-vim
vimPlugins.friendly-snippets
vimPlugins.fwatch-nvim
vimPlugins.luasnip
vimPlugins.ncm2-ultisnips
vimPlugins.neco-look
vimPlugins.nord-nvim
vimPlugins.null-ls-nvim
vimPlugins.nvim-dap
vimPlugins.nvim-dap-ui
vimPlugins.nvim-dap-virtual-text
vimPlugins.nvim-lspconfig
vimPlugins.nvim-toggleterm-lua
vimPlugins.nvim-treesitter
vimPlugins.nvim-treesitter-textobjects
vimPlugins.packer-nvim
vimPlugins.rust-tools-nvim
vimPlugins.srcery-vim
vimPlugins.telescope-frecency-nvim
vimPlugins.telescope-fzf-native-nvim
vimPlugins.telescope-fzf-writer-nvim
vimPlugins.telescope-fzy-native-nvim
vimPlugins.telescope-nvim
vimPlugins.telescope-symbols-nvim
vimPlugins.telescope-z-nvim
vimPlugins.ultisnips
vimPlugins.vim-android
vimPlugins.vim-clap
vimPlugins.vim-matchup
vimPlugins.vim-startuptime
vimPlugins.vimtex

2 suggestions:

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

LGTM. For those of use using the nightly version, you can try https://github.com/NixOS/nixpkgs/pull/126633 to maintain your own vimplugin overlay.


Add more architectures.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, rerender

@conda-forge-admin, rerender

@isuruf I don't understand the error message, Python3_NumPy_INCLUDE_DIRS is passed correctly to CMake.
2024-07-22T05:31:28.3268554Z + cmake -DCMAKE_AR=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-ar -DCMAKE_CXX_COMPILER_AR=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-gcc-ar -DCMAKE_C_COMPILER_AR=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-gcc-ar -DCMAKE_RANLIB=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-ranlib -DCMAKE_CXX_COMPILER_RANLIB=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-gcc-ranlib -DCMAKE_C_COMPILER_RANLIB=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-gcc-ranlib -DCMAKE_LINKER=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-ld -DCMAKE_STRIP=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-strip -DCMAKE_BUILD_TYPE=Release -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=ONLY '-DCMAKE_FIND_ROOT_PATH=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_;/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/aarch64-conda-linux-gnu/sysroot' -DCMAKE_INSTALL_PREFIX=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_ -DCMAKE_INSTALL_LIBDIR=lib '-DCMAKE_PROGRAM_PATH=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin;/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin' -DCMAKE_SYSTEM_NAME=Linux -DCMAKE_SYSTEM_PROCESSOR=aarch64 -DLLVM_TABLEGEN_EXE=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/llvm-tblgen -DNATIVE_LLVM_DIR=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/lib/cmake/llvm '-DCROSS_TOOLCHAIN_FLAGS_NATIVE=-DCMAKE_C_COMPILER=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/x86_64-conda-linux-gnu-cc;-DCMAKE_CXX_COMPILER=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/x86_64-conda-linux-gnu-c++;-DCMAKE_C_FLAGS=-O2;-DCMAKE_CXX_FLAGS=-O2;-DCMAKE_EXE_LINKER_FLAGS="-L/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/lib";-DCMAKE_MODULE_LINKER_FLAGS=;-DCMAKE_SHARED_LINKER_FLAGS=;-DCMAKE_STATIC_LINKER_FLAGS=;-DCMAKE_AR=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-ar;-DCMAKE_RANLIB=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/bin/aarch64-conda-linux-gnu-ranlib;-DZLIB_ROOT=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env;-DPython3_NumPy_INCLUDE_DIRS=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_build_env/venv/lib/python3.8/site-packages/numpy/core/include' -DCMAKE_INSTALL_PREFIX=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_ -DCMAKE_BUILD_TYPE=Release -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON -DLLVM_BUILD_TOOLS=ON -DLLVM_BUILD_UTILS=ON -DMLIR_ENABLE_BINDINGS_PYTHON=ON -DPython3_EXECUTABLE=/home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1721625845367/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/python -GNinja ../mlir
2

@conda-forge-admin, rerender

Don't mind me, I wanted to look at the CI results (which aren't there, that's why I didn't see them), and thought I was pressing on a fold-out button.

Don't mind me, I wanted to look at the CI results (which aren't there, that's why I didn't see them), and thought I was pressing on a fold-out button.

Here's the current failure I've been striúggling with forever:
-- Found Python3: $BUILD_PREFIX/bin/python3.9 (found version "3.9.19") found components: Interpreter Development Development.Module Development.Embed
CMake Error at /home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1722244606773/_build_env/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find Python3 (missing: Python3_NumPy_INCLUDE_DIRS NumPy) (found
  version "3.9.19")
Call Stack (most recent call first):
  /home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1722244606773/_build_env/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  /home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1722244606773/_build_env/share/cmake-3.30/Modules/FindPython/Support.cmake:3984 (find_package_handle_standard_args)
  /home/conda/feedstock_root/build_artifacts/mlir-python-bindings_1722244606773/_build_env/share/cmake-3.30/Modules/FindPython3.cmake:596 (include)
  cmake/modules/MLIRDetectPythonEnv.cmake:21 (find_package)
  CMakeLists.txt:173 (mlir_configure_python_dev_packages)

It seems the pinocchio recipe has found a work-around for the "not finding numpy in cross-compilation" issue.

It seems the pinocchio recipe has found a work-around for the "not finding numpy in cross-compilation" issue.

Okay, now we're past config and into build errors.

The issue is that it needs a native mlir-tblgen that needs to run on the build_platform:
[94/2003] Building native mlir-tblgen...

which then fails because it points to $PREFIX instead of $BUILD_PREFIX. The llvmdev recipe has some inspiration for this.

OK, this is upstream (or CMake) being obtuse. It ignores the LLVM_ENABLE_* flags for the cross-compilation, and just uses what it found earlier during config
-- Check for working CXX compiler: $BUILD_PREFIX/bin/aarch64-conda-linux-gnu-c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found ZLIB: $PREFIX/lib/libz.so (found version "1.3.1")
-- Found zstd: $PREFIX/lib/libzstd.so
-- Found LibXml2: $PREFIX/lib/libxml2.so (found version "2.12.7")

directly on the linker path
[...] $BUILD_PREFIX/lib/libLLVMDemangle.a  -lrt  -ldl  -lpthread  -lm  $PREFIX/lib/libz.so  $PREFIX/lib/libzstd.so

I checked the last build here and the bindings here don't even link to zlib/zstd, so let's just switch that off completely.

There were a bunch of issues; in summary:

build script was pointing to LLVM_TABLEGEN_EXE, which is irrelevant here
LLVM_NATIVE_DIR in contrast is essential (used by our patch)
The key to pointing the native compilation to the right prefix was -DCMAKE_PREFIX_PATH (taken from mlir recipe where this is working already)
In principle, we shouldn't even need to recompile mlir-tblgen, because we can just depend on mlir itself here (in obvious contrast to the mlir recipe)
If we do that though, the build still tries to compile mlir-tblgen (probably related to this), so we still need the other fixes as well

However, figuring all this out has created a mighty mess in the commit history, so I'll open a rebased PR (with proper authorship of the commits of course) that cleans this up.

Superceded by #33.


chore: code cleanup

Motivation
I removed some dead code from the codebase and cleaned up some other issues my linter complained about.
Description

Prepared changelog for changes of the next release
un-exported errors that don't need to be exported
removed assignments to _ if all return values are ignored
removed dead code from the common/util package

Test Plan
existing tests pass
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


Node pkg refactoring

[x] 1. Split components into component-specific subpackages as fx.Modules (e.g. header components go into node/header)
[x] 2. Split opts and configs into related subpackages
[x] 3. Create node subpackage inside node directory (e.g. node/node) that provides its own fx.Module
[ ] 4. Migrate cmds + flags into node/<subpkg> and have cmd depend on them
[x] 5. https://github.com/celestiaorg/celestia-node/issues/965

Desired outcome:
module.Cmds
module.Flags
module.API
module.Module
module.Config
module.Init

header.Module(node.Type) --> provides header.Module based on node type

easiest -> hardest
create module.Module (fx.Module)
put module config in subpackage module.Config

cmds and flags

implementing `type <pkg_API> interface` inside subpackage

I am starting to become really conflicted about how the interface between the cmd/flags and the node subpackages should look.
These flags and their parsing are clearly logically closer to the command themselves than the actual implementation of the options. It seems like a bad pattern to have the subpackages themselves modifying the "global" state (by handling setting the Env themselves).
I think the best solution (for now) may be to keep the flags and their parsing methods in cmd, but to move the options and configs to the subpackages. This is what Hlib is experimenting with in https://github.com/renaynay/celestia-node/pull/90 and I really like it.
I have spent quite a bit of time now trying to figure out the best way to move the flags into the subpackages themselves, but will abandon this and move forward with only moving the opts and configs, and creating modules for the individual subpackages - based on top of Hlib's PR

Eventually™, we still should find a way for any module to hold the set of flags and cmds relatated to the the module. This will be especially important once we define APIs for modules with RPC server/client shims, so that introduced cmds can interact with those.
E.g. there is a p2p module, which contains an API with ListenAddr method(from #506) and respectively there is a command celestia p2p listen-addr which calls the ListenAddr over the API. It also has a set of flags and options for the method. The p2p module here encompasses everything mentioned and all other p2p related commands with their flags.
In our case right now, we have onlu flags for the start/run command which is slightly different case from the p2p specific commands mentioned above. Ideally, we would also keep these start/run p2p related flags in the p2p module, but it might be a bit premature to do this now.

Moving 4. Migrate cmds + flags into node/<subpkg> and have cmd depend on them into a separate issue

Closed by #997


Setting aria-current="false" on a <NavLink /> erroneously raises a prop warning

Version
5.2.0
Test Case
https://codesandbox.io/s/react-router-forked-j3kvm
Steps to reproduce

Create a <NavLink /> element, and pass it the prop aria-current="false"

Expected Behavior
Per the react-router documentation and the source for <NavLink />, this should be an acceptable value for the aria-current prop.
Actual Behavior
A prop warning is raised:

Warning: Failed prop type: Invalid prop aria-current of value false supplied to NavLink, expected one of ["page","step","location","date","time","true"].

For what it is worth, the reason we are doing this is because we are using <NavLink /> elements as tabs in a tabpanel interface with deep linking, and in this case aria-selected is a more accurate state to use than aria-current.
Thanks very much for any assistance you can provide.

It's fixed on master, but not yet released: #7503


Fixed : issue #116

Related Issue
Closes #116

Description
I added a Go To Top button on the website. The functionality of that button is when the button is clicked it takes directly to the top.
Screenshots
https://github.com/Gaurav-Verma07/sampark/assets/85991449/9c7dc6b1-b7d3-4bbc-b636-9d2769527676

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

bro please use existing @tabler/icons instead of react-icons

bro please use existing @tabler/icons instead of react-icons

Okay

@Gaurav-Verma07 Made the changes you asked me to make. Please check.


Support atomic operations on update

Problem
Whenever in need to perform an update on a field based on its current value, Prisma requires to first fetch the record, and then perform the update call.
This creates room for race conditions if the value gets changed in the data source between the fetching and updating calls.
The alternative is to rely on raw SQL queries, which defeats the value of using Prisma.
Context
SQL offers to perform a certain set of operations on fields in an UPDATE query:

Arithmetic operations: add (+), subtract (-), multiply (*), divide (/) or modulo (%)
String operations: concat (field = otherField + ' ')
Functions (type-dependent): e.g. CONCAT, LOWER, UPPER for strings, ABS, CEIL, ROUND, etc. for numbers

Ideal solution
An ideal solution would offer a way to express operations, and allow to incrementally add support for more and more functions over time, while only supporting a limited set in the first iteration.
Proposed first iteration
The most important set of operations to support are the arithmetic operations on numbers, provided that they are the most commonly used.
Type-dependent functions supports could be considered separately.
Suggested solutions

cf. #655 for a set of proposals

This would be great with transaction api

Suggested Solution
We go with the Object notation, unless it's easier to go straight to the Helper Function syntax.
Process
The following was my process for working through the solution:

I started with S-expressions since they are the most "pure" expression-syntax.
I turned those S-expressions into Javascript via functions.
Those functions morphed into the AST representation.
I simplified the AST into a more domain-specific object notation.
Build up helper functions from the AST.

1. S-expressions
Initial exploration using S-expressions. Here, everything is a list.
age: (+ age 10)
age: (- age 10)
age: (* age 10)
age: (/ age 10)
age: (% age 10)

age: (+ age (+ otherField 10))
age: (- age (- otherField 10))
age: (* age (* otherField 10))
age: (/ age (/ otherField 10))
age: (% age (% otherField 10))

full_name: (concat first_name last_name)
checksum: (md5 contents)
contents_b64: (base64 contents)
email: (lower email)
amount: (abs amount)
amount: (ceil 10.5)
amount: (round 10.5)

A direct translation, doesn't lend itself very well to Javascript ["+", Symbol("age"), ["+", Symbol("otherField"), 10]].

2. Functions
This form uses functions:
age: add(age, 10)
age: subtract(age, 10)
age: multiply(age, 10)
age: divide(age, 10)
age: modulo(age, 10)

age: add(age, add(otherField, 10))
age: subtract(age, subtract(otherField, 10))
age: multiply(age, multiply(otherField, 10))
age: divide(age, divide(otherField, 10))
age: modulo(age, modulo(otherField, 10))

full_name: concat(first_name, last_name)
checksum: md5(contents)
contents_b64: base64(contents)
email: lower(email)
amount: abs(amount)
amount: ceil(10.5)
amount: round(10.5)

I feel like this would be the ideal solution if these functions were magically global.

3. AST
Using https://astexplorer.net/, we could turn these functions into proper AST objects:
age: {
  type: "CallExpression",
  callee: {
    type: "Identifier",
    name: "add"
  },
  arguments: [
    {
      type: "Identifier",
      name: "age"
    },
    {
      type: "Literal",
      value: 10
    },
  ]
}

age: {
  type: "CallExpression",
  callee: {
    type: "Identifier",
    name: "add"
  },
  arguments: [
    {
      type: "Identifier",
      name: "age"
    },
    {
      type: "CallExpression",
      callee: {
        type: "Identifier",
        name: "add"
      },
      arguments: [
        {
          type: "Identifier",
          name: "otherField"
        },
        {
          type: "Literal",
          value: 10
        }
      ]
    }
  ]
}

age: {
  type: "CallExpression",
  callee: {
    type: "Identifier",
    name: "round"
  },
  arguments: [
    {
      type: "Literal",
      value: 10
    }
  ]
}

This would work, but it'd be a bit verbose for people to write. It's also somewhat unnecessary, since Rust is eventually the one executing these expressions and Rust doesn't have an understanding of the Javascript AST.

4. Objects
Since we don't need the full expressiveness of the Javascript AST, we can simplify our AST:
age: { fn: "add", args: [ Symbol("age"), 10 ] }
age: { fn: "subtract", args: [ Symbol("age"), 10 ] }
age: { fn: "multiply", args: [ Symbol("age"), 10 ] }
age: { fn: "divide", args: [ Symbol("age"), 10 ] }
age: { fn: "modulo", args: [ Symbol("age"), 10 ] }

age: { fn: "add", args: [ Symbol("age"), { fn: "add", args: [ Symbol("otherField"), 10 ] } ] }
age: { fn: "subtract", args: [ Symbol("age"), { fn: "subtract", args: [ Symbol("otherField"), 10 ] } ] }
age: { fn: "multiply", args: [ Symbol("age"), { fn: "multiply", args: [ Symbol("otherField"), 10 ] } ] }
age: { fn: "divide", args: [ Symbol("age"), { fn: "divide", args: [ Symbol("otherField"), 10 ] } ] }
age: { fn: "modulo", args: [ Symbol("age"), { fn: "modulo", args: [ Symbol("otherField"), 10 ] } ] }

full_name: { op: "concat", args: [ Symbol("first_name"), Symbol("last_name") ] }
checksum: { op: "md5", args: [ Symbol("contents") ] }
amount: { op: "round", args: [ 10.5 ] }

A bit verbose, but it does give us the flexibility to add more operations and will allow us to introduce method expressions later.
Note on Symbols: are like creating your own custom identifier. I'm not sure if we should use them here, but the application does feel appropriate. I'd imagine these would be imported from Prisma Client. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol.

Open Questions:

Should we use symbols?
Can we make this type-safe? Filters would depend on the column type,

e.g. age supports number operations
e.g. full_name supports string operations

5. Helper functions
We could eventually do this later.
age: (x) => x.add(x.age, 10)
age: (x) => x.subtract(x.age, 10)
age: (x) => x.multiply(x.age, 10)
age: (x) => x.divide(x.age, 10)
age: (x) => x.modulo(x.age, 10)

age: (x) => x.add(x.age, x.add(x.otherField, 10))
age: (x) => x.subtract(x.age, x.subtract(x.otherField, 10))
age: (x) => x.multiply(x.age, x.multiply(x.otherField, 10))
age: (x) => x.divide(x.age, x.divide(x.otherField, 10))
age: (x) => x.modulo(x.age, x.modulo(x.otherField, 10))

age: (x) => x.concat(x.first_name, x.last_name)
checksum: (x) => x.md5(x.contents)
amount: (x) => x.round(10.5)

Alternatives

Use a separate argument for fields
x.age.add(10) form instead

After some additional internal discussion, we're leaning towards starting with a simpler API and introduce expressions later.
Step 1: Limited object syntax
Start with something simple. A limited solution to atomic updates.
age: {
    set: 18, // this just sets the value, previous syntax is `data: { age: 18 }`
    increment: 1, // age = age + 1
    decrement: 2, // age = age - 2
    multiply: 3, // age = age * 3
    divide: 4, // age = age / 4
}

Step 2: Add functional syntax
The aim here is to provide higher-level syntax-sugar. The underlying query that this generates may be equivalent to the object expression above, but it doesn't have to be. It could be a more generic expression syntax.
{
   age: u => u.age.inc(1)
}

Step 3: Extend Functional Syntax
{
  age: u => u.age.add(u.otherField.add(10))
}

We'll later extend this syntax to support more arbitrary expressions. The underlying query that this generates will likely need to be more generic than the object syntax above to accommodate this.
Right now we're planning on starting with Step 1. Step 2 and Step 3 are currently unplanned and the syntax may change.
Open Questions

It might be nice to add a couple simple string operations to stress test our solution. I think concat would be the most useful, but that also brings complexity. Two other options could be append and prepend
Are there any other must-have filters in Step 1 that we're missing?
What will the protocol look like between client and query engine?

We released the Step 1 of the solution in release 2.6.0.
We will keep tabs on your feedback and possibly follow up with an expression-based notation in a separate issue.
Thanks!


Fix the variable substitution for task results inside array parameters

Changes
Fix the variable substitution for task results inside array parameters
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Fixes #2296

@vdemeester I moved some tests from v1alpha1 package to v1beta1. They were beta1 related anyway. Let me know if you have any questions.

/kind bug

/cc @sbwsg


RFM - SDIO

Current Maintainer

[ ] I am the maintainer of the package and wish to pass it to someone else;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details

Package URL: https://chocolatey.org/packages/sdio
Package source URL: https://github.com/Spunkie/chocolatey-packages/tree/master/automatic/sdio

This package has been a constant thorn in my side.
The developer always seems to be making minor tweaks to naming conventions, caplizations, internal dir structure, etc for no real reason. Then he stopped providing releases on sourceforge so I had to try to build a script that pull the latest version directly from the website(https://www.snappy-driver-installer.org/download/), but this also sporadically changes structure every few months so I just gave up.
All this combined means the majority of the packages releases over the last 3 years don't work. So, I don't have the time or desire to babysit this package and I hope someone that uses is and cares can take it off my hand.

/confirm your-chocolatey-username

@AdmiringWorm Well the bot's broken, my https://chocolatey.org/profiles/Spunkie is linked to github correctly. Might have something to do with the link to the pkg source is broken on the current SDIO pkg.

/confirm Spunkie Spunkie

/attach @Spunkie Spunkie

/recheck

@Spunkie it is not broken, (at least not in that case). You didn't replace your-chocolatey-username with you actual chocolatey username.

we need a update

Hello,
I'll take this one, @Spunkie can you add tunisiano as maintainer?
Thank you

Package ready to be pushed

Done and approved, so you can close this issue.