[WIP] Add numbers search, buy, cancel

Hi,
I started implementing numbers searching, buying and cancelling. It's not yet production tested, but I'd like to know if I'm going in the right direction here.
Any comments welcome!

This has been tested against the live API and an example has been added

@marcw Will take a look, thanks!

@marcw It's a great start, here are a few things to keep in mind.
The collection methods should accept number resources as arguments. See the 'Entity' section of the client library spec. This would allow the same object returned by search() to be passed to buy().
**Throughout the library, where an entity can be used an array can also be used. ** The spec leaves this up to the language (just that library methods should accept arguments as well as entities). For the PHP library I've chosen to avoid really long argument lists in favor of arrays because:

optional arguments get really messy as consuming code needs to duplicate default values to 'skip' them
arrays can match the exact structure of the API request / response (an array representation of a JSON object)
we can treat entities as arrays (using ArrayAccess), so a developer can ignore (for the most part) the entities entirely, act as if the client library is returning arrays and consuming arrays.

The search() method is similar, in that it should accept an array (to keep the argument list manageable) or an object. In this case, the object wouldn't be a Number but some kind of filter. Take a look at this call filter as an example.
Following that, if you look at what I've got going on the develop-collection-refactor branch you can see I'm working on changing some naming. client to collection and entity to a specific resource (Call in the case of the example). The goal here is to treat even the non-RESTful endpoints the same was as the newer RESTful endpoints, so that means the number methods here should try to map to what we'd expect from the next version of the API. That means using methods like post(), get(), etc. And that should allow some shared code for common things. Can then alias search() and other current names to that.
Once you think of search() as a collection, there's conflict between that and the actual collection of account numbers (which is not yet supported, see #23). Since Nexmo\Numbers\Client should eventually become Nexmo\Numbers\Collection, the purchasable numbers should be its own collection. I'm not sure if that should be something like Nexmo\Numbers\SearchCollection or more like Nexmo\AvailibleNumbers\Collection. I'd like the namespacing to be similar to the API path, but I need to check if there is a solid URI structure for the next version of this API.
In the same way, there's a bit of a mismatch between a Number object when it's returned from the collection of numbers I own, and when it's from the collection of numbers I can buy (for example, the cost property). So search() should probably not return the same object, especially so buy() can type hint that it expects an available number, not an own number.
A lot of info I know, and I'm sure @leggetter would like some of the reasoning here put into a proper form in the README to help others. :smile:
The develop-collection-refactor should be helpful it seeing what I think is a much better way of dealing with collections and resources than what I had started with when I wrote the number code. Don't let me delay you if you want to take a look there and keep updating this PR, but if I get a chance, would you mind if I PR'd your PR with some of the changes I outline here?

Thanks for your answers. Feel free to PR my PR! :)

Is this something we could pick up again from its current state? Probably a question for @mheap

This functionality was added vis #75, #76 and #80
Thanks for the original PR!


Provide high level documentation of Trace-X

As Team
I want high level documentation for trace-X
so that external contributors get a quick glance over the product
Hints / Details
Acceptance Criteria

[ ] Documentation contains the following information

[ ] (1) Business Problem & Process Description #441
[ ] (2) End User Benefit Statement for Interoperability
[ ] (3) App Provider Commitments
[ ] (4) Architecture Functional Cut
[ ] (5) Business Semantics Alignment
[ ] (6) Mapping against Catena-X Architecture Framework
[ ] (7) Technical Integration Design (interaction diagrams)

Out of Scope

...

Wontfix.


ekf2_main: update stored mag bias variances

Instead of using a fixed mag bias variance to compute the influence of the currently estimated mag bias on the previously saved parameter, we now also save the variance of the parameter.
The value is automatically updated and the only remaining tuning parameter is EKF2_MAGB_K, which is more intuitive.

This looks good to me, although it does complicate how I was considering scaling this to a multi-ekf world.

Side question, realistically is anyone actually tuning EKF2_MAGB_K?

Side question, realistically is anyone actually tuning EKF2_MAGB_K?

Probably only a few people know that this parameter exists. I don't think anyone is actually tuning it.

Side question, realistically is anyone actually tuning EKF2_MAGB_K?

Probably only a few people know that this parameter exists. I don't think anyone is actually tuning it.

I suppose it would be silly to suggest it now, but as a more general statement overall I think we'd be better off only introducing parameters that are absolutely needed and going to be used. Otherwise it's yet another dimension of a test matrix we're neglecting, not to mention a small waste of flash, memory, and parameter sync time.

Should we move on with this? What's missing? Templating will be solved in the next step and the parameters added are necessary to keep state. EKF2_MAGB_K was not touched and could still get removed.

Should we move on with this? What's missing? Templating will be solved in the next step and the parameters added are necessary to keep state. EKF2_MAGB_K was not touched and could still get removed.

Maybe just the "reset to default": https://github.com/PX4/Firmware/pull/15772#discussion_r492156574 but I'm not sure how to implement it properly, @dagar could you help me with that?
For the rest @priseborough agreed with the idea and suggested that we keep that calibration separated from the CAL_MAG_... to avoid modifying the "factory calibration". Also, moving the logic to sensors will require to pass quite a lot of information back to the sensor module, so I think we need to keep it at a higher level since it needs some context. However, maybe a "higher level" isn't "here" given that we're going to switch to a multi-ekf structure soon.

After more reflection, I think this change won't improve the estimate that much as we would need to add some process noise to factor in the bias deviation over time to be more accurate. We would then need to know the current age of the drone and since the changes in mag bias are more often due to magnetization, they are not slowly changing over time and adding some process noise won't be much better than the current implementation with a fix variance.


Cookie banner for HCaptcha

HCaptcha uses cookies for that we need a Cookie banner.
@quintus-luis please provide a design.

Grid with 960px width


Could not reload the pretrained mobilenet model

NotFoundError (see above for traceback): Key MobilenetV1/Conv2d_9_pointwise/BatchNorm/beta/Adam not found in checkpoint
[[Node: save_2/RestoreV2_287 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/cpu:0"](_recv_save_2/Const_0, save_2/RestoreV2_287/tensor_names, save_2/RestoreV2_287/shape_and_slices)]]
[[Node: save_2/RestoreV2_110/_1209 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/gpu:0", send_device="/job:localhost/replica:0/task:0/cpu:0", send_device_incarnation=1, tensor_name="edge_1345_save_2/RestoreV2_110", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/gpu:0"]]

https://github.com/tensorflow/tensorflow/issues/312

I have solved this problem and run normally, but have you made this network loss converged as your process?

@dyz-zju Can you share some details regarding solving this issue? Having trouble to run it. Thanks!

Hi @zhuoruiyang
I changed like this:
try:
checkpoint=tf.train.latest_checkpoint(output_file)
saver.restore(sess, checkpoint)
except:
variables=tf.global_variables()
reader=pywrap_tensorflow.NewCheckpointReader(model_path)
var_keep_dic=reader.get_variables_to_shape_map()
variables_to_restore = []
for v in variables:
if v.name.split(':')[0] in var_keep_dic:
variables_to_restore.append(v)
restorer = tf.train.Saver(variables_to_restore)
restorer.restore(sess, model_path)

Hi @dyz-zju
Thank you for your response!
Still, it doesn't work for me. The following is what I got. Do you have any ideas why it happens? Or maybe it's better if you don't mind to upload your working code? Perhaps there is somewhere else I need to make the changes to fix the issue.
Traceback (most recent call last):
File "/home/zhuorui/git/deep-camera-relocalization/run_posenet.py", line 197, in
main()
File "/home/zhuorui/git/deep-camera-relocalization/run_posenet.py", line 127, in main
var_keep_dic = reader.get_variables_to_shape_map()
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 116, in
getattr = lambda self, name: _swig_getattr(self, CheckpointReader, name)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 74, in _swig_getattr
return _swig_getattr_nondynamic(self, class_type, name, 0)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 69, in _swig_getattr_nondynamic
return object.getattr(self, name)
AttributeError: type object 'object' has no attribute 'getattr'

@zhuoruiyang
from tensorflow.python import pywrap_tensorflow

@dyz-zju I did make that change in my code so that I can run the piece of code you sent inside the original code. BTW, regarding pretrained model, I downloaded from the following link, which should be correct I believe. Any other thought? Thanks!
https://github.com/tensorflow/models/tree/master/research/slim

@dyz-zju
Finally, I'm able to run it properly now. Thanks for your suggestions!
Your fix should work, I think I made a small mistake while setting the path.

@dyz-zju
BTW, I saw you have a question regarding the convergence. As I checked, the loss did converge if you train a model.


How to avoid duplicate combinations?

I don't want to create a combination where all the other layers are the same, only the background is different.
examples)
Do NOT want case ▼
#001
background: black
accessories: ring
eyes: blue
horns: cow
skins: red hoodie
#002
background: blue
accessories: ring
eyes: blue
horns: cow
skins: red hoodie
All layers same and only the background color is different. This does not feel 'UNIQUE'

I want case ▼
#001
background: black
accessories: ring
eyes: blue
horns: cow
skins: red hoodie
#002
background: blue
accessories: ring
eyes: blue
horns: cow
skins: yellow hoodie
There is only one 'ring+blue+cow+red hoodie' combination regardless of the background color.
Please kindly help.

your problem is on weight
https://youtu.be/qmpuvGdI0w4 on minute 12:55 should help you

@jabjoi That code is very different from https://github.com/HashLips/generative-art-opensource

Which branch are you using? Branch v3 and the main one dont create any duplicates and I recommend you use the main branch

@jabjoi @Ponda1 Thank you for everything. Branch v3 is perfect for me.

is there a way to exclude background layer as part of the traits? Per @tontonfriends example, uniqueness doesn't feel right if no main character elements are different. I wonder if we can exclude the dna check to exclude the first number if possible


[FEATURE] -  Update cardano-cli conway query spo-stake-distribution

What
We need to update the output of  cardano-cli conway query spo-stake-distribution to include the DREP delegation choices of the Pool's rewards accounts. This, once https://github.com/IntersectMBO/cardano-ledger/issues/4645 is implemented, in particular:
To be more specific the solution to this problem is:

1.  To change the default vote for SPOs to `No` from `Abstain` for all of the three proposals in question
2. Check whether SPO's reward address is delegated to the predefined `AlwaysNoConfidence` DRep and count default vote as `Yes` only on `NoConfidence` proposals for that SPO.
3. Check whether SPO's reward address is delegated to predefined `AlwaysAbstain` DRep and count default vote as `Abstain` for that SPO on all three: `NoConfidence`, `UpdateCommitee` and `ParameterUpdate` proposals.

For example:
    [
        "dec39dd553180bf78b206258aba3861537b185580086ca3f62716f8d",
<PHONE_NUMBER>2397,
        "drep-alwaysAbstain"
    ],
    [
        "e2fd1cd89bba55dc457574adf420240c28a2bfdb3d460279e453c57a",
<PHONE_NUMBER>8807,
        "drep-keyHash-ffc25bcec3379aea4e32f353b4048fc7ab9fc1124c01738546e2f7bb"
    ],
    [
        "eec73ca2652e1ae92852195ff3289dd991a83dbe5f989f06e1c96b64",
<PHONE_NUMBER>8560,
        "drep-alwaysNoConfidence"
    ],
    [
        "f386ee192cf53c26da7457b7d8992ae0e52a05fc1c88c5d653a90021",
<PHONE_NUMBER>5103,
        "drep-scriptHash-186e32faa80a26810392fda6d559c7ed4721a65ce1c9d4ef3e1c87b4"
    ]

(Thank you @gitmachtl)
Why
https://github.com/IntersectMBO/cardano-ledger/issues/4645 changes the way SPO votes are counted. The SPO reward account delegation choice will impact how the pool's stake counts for voting. It is important to show this information so that downstream tools can recreate the vote count.
Personas

[x] SPOs
[ ] dApp Devs
[ ] Exchanges
[ ] Wallets
[ ] 3rd party tools
[x] ADA holders

Definition of Done (DoD)

[ ] Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
[ ] Builds successfully on CI
[ ] Code & Test review (as per Acceptance Criteria)
[ ] There is documentation and/or examples for the new functionality (usage/response)
[ ] Log/record changes on Vnext (or similar depending on what we adopt)
[ ] Ticket number(s) included in PR description
[ ] All Acceptance Criteria met and covered by dev/unit/property/integration tests
[ ] System/E2E automated tests + System Test Engineer Owner Sign-off

NOTE:  Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

[ ] Product Owner
[ ] Dev Owner
[ ] System Test Engineer Owner

Related PRs
Acceptance Criteria
The output must show the SPO rewards account delegation choice: "registered DRep", "Always abstain" or "Always no confidence"

here is the cross reference to the ledger part
https://github.com/IntersectMBO/cardano-ledger/issues/4663

i will extended this FR to also change the spo-stake-distribution name into spo-power-distribution or spo-votepower-distribution.

@gitmachtl> sorry no progress nearly yet because I've been helping with query proposals the last week (https://github.com/IntersectMBO/cardano-cli/pull/984 and https://github.com/IntersectMBO/cardano-node/pull/6045). When is the hf planned?

@smelc i think sometimes in january

@smelc i think sometimes in january

Then this might be doable. I'll focus on this one during the next days :+1: FYI @Jimbo4350

Work being done here: https://github.com/IntersectMBO/cardano-cli/commits/smelc/augment-spo-stake-distribution/

Work being done here: https://github.com/IntersectMBO/cardano-cli/commits/smelc/augment-spo-stake-distribution/

Have not checked your code yet, is the goal to mimic the output we set up as an example output here? https://github.com/IntersectMBO/cardano-cli/issues/911#issue-2545728041

@smelc the thing is that this than would be a breaking change for tooling, adding just a 3rd entry will most likely not break any tooling.

@smelc the thing is that this than would be a breaking change for tooling, adding just a 3rd entry will most likely not break any tooling.

Sounds good :+1: I added commit Revert to triplet JSON to just add the third entry :+1:

@smelc having some issues compiling this branch. can you give me a hint on how to link the correct cardano.api.ledger ?
src/Cardano/CLI/EraBased/Run/Query.hs:1687:71: error:
    Not in scope: ‘L.coerceKeyRole’
    Module ‘Cardano.Api.Ledger’ does not export ‘coerceKeyRole’.
     |
1687 |         _stakeCreds' :: [L.Credential L.Staking StandardCrypto] = map L.coerceKeyRole _stakeCreds
     |                                                                       ^^^^^^^^^^^^^^^

src/Cardano/CLI/EraBased/Run/Query.hs:1693:60: error:
    Not in scope: ‘L.coerceKeyRole’
    Module ‘Cardano.Api.Ledger’ does not export ‘coerceKeyRole’.
     |
1693 |              ) = Map.fromSet (fromShelleyStakeCredential . L.coerceKeyRole . L.KeyHashObj) spos
     |                                                            ^^^^^^^^^^^^^^^
Error: cabal: Failed to build cardano-cli-<IP_ADDRESS> (which is required by
test:cardano-cli-test from cardano-cli-<IP_ADDRESS> and test:cardano-cli-golden
from cardano-cli-<IP_ADDRESS>).

@gitmachtl> sorry my bad, I should have thought of this.
I have added an SRP in additional commit to the https://github.com/IntersectMBO/cardano-cli/commits/smelc/augment-spo-stake-distribution/ branch so it should compile on your end now.

@smelc hmm...
remote: Enumerating objects: 108652, done.
remote: Counting objects: 100% (1629/1629), done.
remote: Compressing objects: 100% (647/647), done.
remote: Total 108652 (delta 808), reused 1412 (delta 642), pack-reused 107023 (from 1)
Receiving objects: 100% (108652/108652), 54.03 MiB | 3.46 MiB/s, done.
Resolving deltas: 100% (68059/68059), done.
fatal: Could not parse object 'e2c544815bc3a8994e8fdb70a0153244ee77ea75'.

@gitmachtl> it's there but not on a branch:

Maybe that's the issue, so creating the branch right away.

@smelc yup, that worked, thx!

@smelc when i try the updated command, i get the result of null for all pool entries drep-delegation. currently using sanchonet and preview for this with node 10.1.3.

@gitmachtl> yes I think something is off, but I've been blocked by other bugs to fully grasp the problem using cardano-testnet. How can I reproduce your test on sanchonet?

I am running a synced node 10.1.3 on sanchonet. Than i ran the cli command:
cardano-cli conway query spo-stake-distribution --all-spos
which resulted in the output
[
    [
        "02641404878b0b7efce28de535c67ddcf073606082d01a3eb01a82ab",
<PHONE_NUMBER>6193,
        null
    ],
    [
        "1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910",
<PHONE_NUMBER>8741,
        null
    ],
    [
        "30c650e28e1df418bf6881a893fbf872043b522d27d7ad8ead443c82",
<PHONE_NUMBER>4363,
        null
    ],
    [
        "350856bd7854339f7baef0e71e34dbc73f256552814f1d94e42281c3",
<PHONE_NUMBER>2909,
        null
    ],
    [
        "3531737ad43673ec059ff03249c3b8d4cfe29fa764d7fd96cc731805",
        97467769,
        null
    ],
    [
        "395933c7b6ca33d1f4a2b22472a6321bc050b166f3f89bb4195f68d5",
        47288144,
        null
    ],
    [
        "3c4fb94e1a2c5649a870aee5a70f21cd64807c7dc38632efcaf3d921",
<PHONE_NUMBER>7006,
        null
    ],
...
    [
        "e561b840eb762b0468e123b5fb38b1e1da1a02f25a97308309e10d9d",
<PHONE_NUMBER>4,
        null
    ],
    [
        "eae7268bbae047d838d95de2d635681df9eb1f122a4798779f3e8918",
<PHONE_NUMBER>5676,
        null
    ],
    [
        "f08b6d872f3caa1b4e65cd1e74d51e6ac000e7303ac18c92d0fca1c1",
        97469265,
        null
    ],
    [
        "f5fddd5469f8bbedb726227df2c6feaeaaeaf79aa597a1fb7f971af4",
<PHONE_NUMBER>4786,
        null
    ]
]

We have some testpools running on sanchonet, one it for example pool id 1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910
${cardanocli} conway query spo-stake-distribution --spo-key-hash 1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910
[
    [
        "1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910",
<PHONE_NUMBER>8741,
        null
    ]
]

and that output should actually be like:
[
  [
    "1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910",
<PHONE_NUMBER>8741,
    "drep-alwaysNoConfidence"
  ]
]

or for this pool:
[
  [
    "3531737ad43673ec059ff03249c3b8d4cfe29fa764d7fd96cc731805",
    97467769,
    "drep1ytutlw3p969u9egkxysjrw7km90x763npu9k0226w46cmnq6pkh99"
  ]
]

@gitmachtl> how would yo obtain the information using other queries? This is so that I can debug using a successful case.

@smelc here is a code snippet you can run to get the values via koios and some conversion magic:
#!/bin/bash
koiosAPI="https://sancho.koios.rest/api/v1"
echo "### KOIOS: get pool list"
tmpPoolList=$(curl -s -X GET "${koiosAPI}/pool_list" -H "accept: application/json" | jq -r '[.[].pool_id_bech32]')
echo "### KOIOS: get detailed pool infos"
tmpPoolInfos=$(curl -s -X POST "${koiosAPI}/pool_info" -H "accept: application/json" -H "content-type: application/json" -d "{\"_pool_bech32_ids\":${tmpPoolList}}")
poolStakeDistributionJSON=$(jq -r '[ .[] | [ .pool_id_hex, ((.voting_power // 0) | tonumber), .reward_addr_delegated_drep ] ]' <<< ${tmpPoolInfos})
poolStakeDistributionJSON=$(sed "s/drep_always_abstain/drep-alwaysAbstain/g" <<< ${poolStakeDistributionJSON})
poolStakeDistributionJSON=$(sed "s/drep_always_no_confidence/drep-alwaysNoConfidence/g" <<< ${poolStakeDistributionJSON})
echo "### POOL LIST:"
jq -r <<< ${poolStakeDistributionJSON}

query takes a while

@gitmachtl> in terms of CLI only, can you confirm that I get the info you want as follows (using the SPO id 1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910 as guidance):
# First obtain the reward account key hash
>  cabal run cardano-cli -- conway query pool-state --stake-pool-id 1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910 --testnet-magic 4
{
    "1b7a61ba3e5292f34666af3bb2f0b8d36e5001aa41e235709ffa6910": {
        "futurePoolParams": null,
        "poolParams": ...
            "rewardAccount": {
                "credential": {
                    "keyHash": "468bfb1fc096297a108bfdfb3bd6aa7eb4182f378bbe0241fd50c18c"
                },
                ...
            },
            ...
        },
    }
# Obtain the address
> cabal run cardano-cli -- conway stake-address build --stake-key-hash 468bfb1fc096297a108bfdfb3bd6aa7eb4182f378bbe0241fd50c18c --testnet-magic 4 > stake-468bfb1fc096297a108bfdfb3bd6aa7eb4182f378bbe0241fd50c18c.addr
# Obtain info
> cabal run cardano-cli -- conway query stake-address-info --testnet-magic 4 --address $(cat stake-468bfb1fc096297a108bfdfb3bd6aa7eb4182f378bbe0241fd50c18c.addr)
[
    {
        "address": "stake_test1uprgh7clcztzj7ss307lkw7k4fltgxp0x79muqjpl4gvrrqxcnvpz",
        "delegationDeposit": 2000000,
        "rewardAccountBalance":<PHONE_NUMBER>33,
        "stakeDelegation": "pool1rdaxrw3722f0x3nx4uam9u9c6dh9qqd2g83r2uyllf53qmmj5uu",
        "voteDelegation": "alwaysNoConfidence"
    }

And so you want spo-stake-distribution (or renamed like you want) to show the voteDelegation field obtained in this manner :point_up:?

@smelc the voteDelegation of the pools rewards account is the default vote of an SPO. is it not implemented that way?

@smelc the voteDelegation of the pools rewards account is the default vote of an SPO. is it not implemented that way?

From the CLI point of view, no, until we have access to https://github.com/IntersectMBO/cardano-ledger/pull/4735. This PR made it to cardano-ledger-api in version 1.9.5, but CLI depends on version 1.9.3. right now.
What I can do is to go through the hoops shown above until we have access to the ledger's query, so that you have the desired output asap. It's a small task.

@smelc can you specify what you mean with SPO? the pledge account of a pool is not the account we are looking here for the voteDelegation. its the rewards account of a pool. that can be one of the pledge accounts, but its not a must.

ah ok, so you are missing the query in ledger-api 1.9.3 which would be a quick solution for that.

@smelc can you specify what you mean with SPO?

I mean the identifier that is passed to query spo-stake-distribution.

the pledge account of a pool is not the account we are looking here for the voteDelegation. its the rewards account of a pool. that can be one of the pledge accounts, but its not a must.

Sorry I'm not super savvy regarding how pools operate. I have a programmatic thinking here, so really I meant following the process described above in terms of CLI commands. If this process is not always right, then there is no other choice than waiting for the ledger's query to be available to CLI, which is probably a few weeks away at this point.
And I will personally be off starting from the end of next week (EOD Friday 13th), so either I try to give you something during the next days; or it will probably be next year. Except if someone else from the CLI team picks it up, but we are all on PTO at some point during the next weeks.

hi, ah ok, thanks for the reply. so yes, the process described above will lead to the right result all the time. if you have the time to integrate it that way before the holidays that would be awesome. :-)

if you have the time to integrate it that way before the holidays that would be awesome. :-)

@gitmachtl> I'll look at this next week. I have quite a few duties planned already, but should be able to ship it before I leave for vacation :+1: cc @Jimbo4350


Coding Challenge getting blocked by padding on Safari

Describe your problem and how to reproduce it:
Launching any challenge on the curriculum on Safari causes this issue. It may be specific to Safari or just specific versions. Also does not matter if it is in day/night mode.
Add a Link to the page with the problem:
https://learn.freecodecamp.org/responsive-web-design/basic-css/change-the-color-of-text
(Could be any challenge)
Tell us about your browser and operating system:

Browser Name: Safari
Browser Version:  Version 11.1.1 (13605.2.8)
Operating System: MacOS High Sierra 10.13.5 (17F77)

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

Could be similar to this issue

@hilliarj Have you tried adjusting your Zoom level?

@hilliarj Have you tried adjusting your Zoom level?

Yes. Changing the zoom level makes it stop. Should I close this issue since it is essentially the same as #35116?

If it is the same as the earlier issue, then please close this one.


[Bug] [api] After the process definition is exported and then imported to another project, the process list displays abnormally

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
流程定义导出再导入到另一个项目后流程列表显示异常显示不出来
What you expected to happen
流程定义导出再导入到另一个项目后流程列表显示正常
How to reproduce
查看了代码，发现导入后流程的version字段未更新到1，导致与之前重复，页面查询到2条相同的两条历史版本
Anything else
No response
Version
3.0.0
The problem still exists in 3.1.4
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@huanzui Would u like to submit a PR to fix it? Could u plz use English for PR description?


Angular Drawer

This is Angular counterpart to https://github.com/AgnosticUI/agnosticui/issues/79

@vitale232 lmk if you'd be interested in this one once all the menu refactoring stuff dust settles?


Add support for RF4.0

Relates #254
Several changes to core and tests were needed to support RF 4.0.
Deprecated:

nested-for-loop (allowed in RF 4.0)
invalid-comment (bug that caused comments starting from second cell be interpreted as Keyword Call was fixed)

Extended Github Actions to test on pre 4.0 and 4.0 RF version.
Replaced ast.NodeVisitor by ModelVisitor in VisitorChecker (allows to reduce amount of code needed ito visit all matching nodes in some cases)
Refactored section-our-of-order rule

Codecov Report

Merging #255 (b557514) into master (7325c3a) will decrease coverage by 0.74%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   98.97%   98.23%   -0.75%
==========================================
  Files          33       33
  Lines        2152     2153       +1
==========================================
- Hits         2130     2115      -15
- Misses         22       38      +16

Impacted Files
Coverage Δ

robocop/checkers/misc.py
91.89% <ø> (-8.11%)
:arrow_down:

robocop/checkers/__init__.py
88.40% <60.00%> (-2.51%)
:arrow_down:

robocop/checkers/errors.py
95.83% <83.33%> (-4.17%)
:arrow_down:

robocop/checkers/duplications.py
98.93% <95.65%> (-1.07%)
:arrow_down:

robocop/checkers/comments.py
95.65% <100.00%> (-4.35%)
:arrow_down:

robocop/checkers/lengths.py
98.70% <100.00%> (-1.30%)
:arrow_down:

robocop/checkers/naming.py
99.19% <100.00%> (-0.81%)
:arrow_down:

robocop/checkers/spacing.py
98.23% <100.00%> (-1.77%)
:arrow_down:

robocop/utils/__init__.py
100.00% <100.00%> (ø)

robocop/utils/utils.py
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7325c3a...b557514. Read the comment docs.


vscode extesion http keep-alive problem

The following code:
let XXXXX = new http.Agent({ keepAlive: true, maxSockets: 1})
for(let i=0;i<3;i++){
http.get({
hostname: 'localhost',
method:'GET',
port: 23659,
path: '/api/get/alive',
agent:XXXXX
}, resp => {
resp.on('data', data => {
console.log('data',data)
});
for (const key in XXXXX.sockets) {
console.log(key)
// if (XXXXX.sockets.hasOwnProperty(key)) {
//     console.log(key + ": ", XXXXX.sockets[key]);
}
}).end()
}
When run in a VS Code plugin and capturing packets using Wireshark, you observed:
Connection: close
When run in a regular npm project, you observed:
Connection: keep-alive
I have been struggling with this issue for two days. Could you please help me take a look?

Please ask your question on StackOverflow. We have a great community over there. They have already answered thousands of questions and are happy to answer yours as well. See also our issue reporting guidelines.
Happy Coding!


⚠ Bofrost.at has degraded performance

In 0b2b803, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 995 ms

Resolved: Bofrost.at performance has improved in 2920a69 after 18 minutes.


Create an API and client to generate demo tokens

The https://demo.scitokens.org website can create tokens understood by services in a demo capacity.  This project's deliverables will be:

An API built into the demo.scitokens.org website to generate tokens with arbitrary claims.
A python client to request tokens, which arbitrary claims.  This client will be included in the python scitokens library.

I think the API is implemented in https://github.com/scitokens/scitokens-heroku/blob/master/app.py and the client is demonstrated in https://github.com/SciAuth/scitoken-demo so is this done or is there more work needed?

I would like an official tool distributed with the python scitokens library to implement this.  Though, it wouldn't be much more than wrapping what we showed in scitoken-demo with command line options.


Revert "Only use one single ciphersuite if 0-rtt is actually enabled"

Reverts hannestschofenig/mbedtls#281
We are seeing test failures from our internal tests. Currently I am not able to reproduce the test with ssl_client2 yet. But the test failure is from the server when it tries to derive early secret, resulting in a bad_record_mac alert.
These are the scenario that passes:

One configures the client to use only one cipher suite;
One configures the client to use multiple cipher suite, and during resumption the previously negotiated cipher suite is the first one in the list;

The case where it fails is when in resumption there are multiple cipher suites and the previously negotiates cipher suite is not the first one. I am not sure what causes the failure but I suspect somewhere in the code we are making the assumption that the first cipher suite in the list is the one to use.

I debugged both the server and client a little more. It seems in mbedtls we always use the first cipher suite we can use (here). If this is not the one the server selected in the last session, we will encounter this failure.


cant get blue  style blue

FreeCodeCamp Issue template
To Use this Template:

Fill out what you can
Delete what you do not fill out

NOTE: ISSUES ARE NOT FOR CODE HELP - Ask for Help at https://gitter.im/FreeCodeCamp/Help
Issue Description

When Issue Happens
Steps To Reproduce

Browser Information

Browser Name, Version
Operating System

Your Code
If relevant, paste all of your challenge code in here

Screenshot

Issue has no problem description. It looks like you're having a problem solving this challenge, so I'd advise you visit the Gitter Chat for help. If they confirm you're seeing a bug please open a new issue where you fill in the template with the required information. Thanks and happy coding!

thanks
On Mar 2, 2016 4:38 PM, "Logan Tegman"<EMAIL_ADDRESS>wrote:

Issue has no problem description. It looks like you're having a problem
solving this challenge, so I'd advise you visit the Gitter Chat for help.
If they confirm you're seeing a bug please open a new issue where you fill
in the template with the required information. Thanks and happy coding!
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/7363#issuecomment-191508876
.


Differentiate between a stopped VM and a suspended VM for Azure

This updates the power state support for Azure. It addresses this BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1316280
At the moment, the "stop" operation within the UI sends a power off message. This basically suspends the VM, but does not deallocate it. This is potentially confusing for people who are used to the new Azure portal, where the stop button actually deallocates the VM. One of the main differences between a VM that is suspended versus one that is deallocated is that the former still incurs billing charges, while the latter does not. For more information about the differences you can read:
https://blogs.technet.microsoft.com/uspartner_ts2team/2014/10/10/azure-virtual-machines-stopping-versus-stopping-deallocating/
So, long story short, this PR alters the "stop" operation to actually mimic the Azure portal and deallocates the VM, and also adds a "suspend" operation that just sends a poweroff request, and this will be reflected in the UI as well.

@bzwei @bronaghs @blomquisg Please review.

@djberg96 In the UI the only Power options are Stop and Terminate. So Stop will do the deallocate. What does Terminate do?
Do you suggest to add suspend to the Power options too?

@bzwei Ok, updated.
There will be both "suspend" and "stop" options for a VM if it is running once this PR is accepted (the UI hooks into it automatically). If it is stopped (deallocated) or suspended, the UI just shows start.
The terminate option is to delete the VM I believe.

👍

LGTM 👍
@blomquisg - review/merge?


Using Discovery Service and MDQ

Hi! We are trying to use djangosaml2 with a Discovery Service (Seamless Access) and IdP metadata obtained "on the fly" using an MDQ (Metadata Query, https://datatracker.ietf.org/doc/draft-young-md-query-saml/), but, although pysaml2 has provisions for a discovery URL in the SP definition, djangosaml2 fails because there is no IdP configured.
Is there a way to use Discory Service with djangosaml2?
Thanks.

Hi @vgiralt
I think that you're right, djangosaml2 only have an embedded wayf page but any support for ds at this moment.
The faulty code Is here:
https://github.com/knaperek/djangosaml2/blob/00c59a9aa85ced8e9ee0e0a5742d83a479f037b9/djangosaml2/views.py#L146
It rely on availble_idps here
https://github.com/knaperek/djangosaml2/blob/00c59a9aa85ced8e9ee0e0a5742d83a479f037b9/djangosaml2/utils.py#L30
As we can see, It only checks for already defined idp in its config. Adding da support would be trivial, we should add a parameter in SETTINGS, like SAML2_DISCO_URL. if It Is there, then a redirect to ds would happen and when the da Will redirect again on the SP, the login functions would handle the get arg to find out the selected idp. This check could be fine in available_idps as well.
Don't know when I'll have some minutes to implement this, if you're ready to do a PR i can follow you in this

Done! I've added the needed code and created a pull request. Works for me.


Flutter fix in IDE

I have upgraded to flutter 2, and both VS Code and Android Studio got the latest plugin of flutter and dart. However, I could not find the function mentioned in flutter fix.
I am using the Crostini to run VS Code and Android Studio.

same here, in VScode.

flutter doctor output:
[√] Flutter (Channel stable, 2.0.0, on Microsoft Windows [Version 10.0.19041.804], locale en-GB)
• Flutter version 2.0.0 at C:\src\flutter
• Framework revision 60bd88df91 (4 days ago), 2021-03-03 09:13:17 -0800
• Engine revision 40441def69
• Dart version 2.12.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\carlo\AppData\Local\Android\Sdk
• Platform android-29, build-tools 29.0.3
• ANDROID_HOME = C:\Users\carlo\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 44.0.2
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] VS Code (version 1.54.1)
• VS Code at C:\Users\carlo\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.20.0

same here, in VScode.

flutter doctor output:
[√] Flutter (Channel stable, 2.0.0, on Microsoft Windows [Version 10.0.19041.804], locale en-GB)
• Flutter version 2.0.0 at C:\src\flutter
• Framework revision 60bd88d (4 days ago), 2021-03-03 09:13:17 -0800
• Engine revision 40441def69
• Dart version 2.12.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\carlo\AppData\Local\Android\Sdk
• Platform android-29, build-tools 29.0.3
• ANDROID_HOME = C:\Users\carlo\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 44.0.2
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] VS Code (version 1.54.1)
• VS Code at C:\Users\carlo\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.20.0

Thanks for your reply. I am just wondering am I the only one who faces this issue since I could not find anyone getting such issue.

Hi @llh-him
Following the indication of VS Code Flutter Extension, the correct way to address the problem is to open an issue in the dedicated repository.
About the IntelliJ/Android Studio plugin
Following the indication of jetbrains' Flutter plugin, the correct way to address the problem is to open an issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

I opened the issue at the suggested repository
However, may be @llh-him  is having the same problem in Android Studio?

I have upgraded to flutter 2, and both VS Code and Android Studio got the latest plugin of flutter and dart. However, I could not find the function mentioned in flutter fix.
I am using the Crostini to run VS Code and Android Studio.

If it is so, the dart-code repository recommend to follow the issue in flutter repository?

Flutter SDK Issues
Issues relating to Flutter that can be reproduced in IntelliJ/Android Studio or the command line should be reported in the Flutter SDK repository


Show commit message in the list of workflow runs

When I look at the list of recent workflow runs I am quite clueless which revision was checked by that run. In other words, seeing the run ID and commit hash in the list is not what would help me navigate the list.
Instead, I propose to see the commit message or pull request title, or tag, or basically any other user-friendly text in the list, if available. That would help me navigate the list much better than seeing the run IDs. 🙏 ❤
In ideal world, the list would show the "thing" that triggered the workflow in a way that is user-recognisable based on the trigger. So when you push a commit, it shows the commit message. When you create a tag, it shows the tag name etc. Personally I would be absolutely happy with having this work with commits, pull requests and tags.
Thanks for considering this! Great extension, finally I don't have to leave VS Code to check my workflow status. 💯

I'm still very interested in having the workflow run titles have better descriptions, thank you very much robot 🤖 ! 😇

@cschleiden the stale bot decided to close this anyway. Could you please reopen?


Trigger planes in pressable button won't scale with button

Describe the bug
Planes for defining the distances for a button to trigger / release are not scaled with the button.
To reproduce
Create a pressable button and up or downscale the button. Observe the debug planes showing the maxDistance / releaseDistance etc won't adjust accordingly
Expected behavior
Planes should either adjust accordingly to the scaling or have a setting to allow them to be scaled with the button (make distances local checkbox?)
Your Setup (please complete the following information)

MRTK Version v2 RC1

Target Platform (please complete the following information)

HoloLens 2

I believe that this was fixed by #4144 based on the following comment in that PR:
Yes there's at least 2 tickets that are fixed with this PR (#4219, #4216) - but I just wanted to open this as a draft for having a discussion about it. If possible I'd like to avoid having the migration step (if we have to keep it in it should be moved out of the class).

not fixed! i was asked to close the draft PR - there's a comment in there that says there's going to be a second PR with the actual fix - the draft was just for discussing the fixes


Fix all doc warnings

Describe the feature
Fix all warnings emitted during
cargo doc --all --no-deps --all-features --document-private-items

Additional context
No response

I would like to take this one


HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.…

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
155
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ HBASE-21879 Compile Tests _

+1
mvninstall
272
HBASE-21879 passed

+1
compile
21
HBASE-21879 passed

+1
checkstyle
23
HBASE-21879 passed

+1
shadedjars
283
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
39
HBASE-21879 passed

+1
javadoc
19
HBASE-21879 passed

_ Patch Compile Tests _

+1
mvninstall
256
the patch passed

+1
compile
21
the patch passed

+1
javac
21
the patch passed

-1
checkstyle
23
hbase-common: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
275
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
775
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
46
the patch passed

+1
javadoc
19
the patch passed

_ Other Tests _

+1
unit
155
hbase-common in the patch passed.

+1
asflicense
10
The patch does not generate ASF License warnings.

2720

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/318

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux d852da472fbe 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
HBASE-21879 / 7840613bd1

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/artifact/out/diff-checkstyle-hbase-common.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/testReport/

Max. process+thread count
255 (vs. ulimit of 10000)

modules
C: hbase-common U: hbase-common

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Updated the patch to address the checkstyle issues.

+1, after QA warning addressed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
23
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ HBASE-21879 Compile Tests _

+1
mvninstall
247
HBASE-21879 passed

+1
compile
22
HBASE-21879 passed

+1
checkstyle
22
HBASE-21879 passed

+1
shadedjars
269
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
40
HBASE-21879 passed

+1
javadoc
20
HBASE-21879 passed

_ Patch Compile Tests _

+1
mvninstall
239
the patch passed

+1
compile
21
the patch passed

+1
javac
21
the patch passed

+1
checkstyle
22
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
265
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
746
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
46
the patch passed

+1
javadoc
21
the patch passed

_ Other Tests _

+1
unit
170
hbase-common in the patch passed.

+1
asflicense
12
The patch does not generate ASF License warnings.

2495

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/318

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 16b881aa5edc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
HBASE-21879 / 7840613bd1

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/2/testReport/

Max. process+thread count
366 (vs. ulimit of 10000)

modules
C: hbase-common U: hbase-common

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


Automate subject activation

Worker script to activate subjects below when they fall below an active number

I thought the idea with Cellect was that we don't need to limit the number of active subjects?

Do we have any stats on server numbers, concurrent users and subject set sizes? If we can hold a large priority set for 4-10k concurrent users we could be good for stargazing.
What about long term with lots of projects? db connection limits might be a scaling issue if we need lots of cellect servers and api and sidekiq nodes.

Depends on the outcome of #504

Cellect is going to handle large enough subject sets and we can manually do this if needed. We will revisit this for full scale panoptes (many projects) if needed in the future.


Mybatis does not work in multithreaded programming

MyBatis version
3.x.x
Database vendor and version
Test case or example project
Steps to reproduce
Expected result
Actual result

Please see the doc.
In standard usage of MyBatis core module, the SqlSession and mapper object does not support the thread-safe. This is design. The MyBatis provide the SqlSessionManager for support the thread-safe as optional module.

@impactCn
I've created #1532 for improving a reference documentation. Therefore, I've closed this issue. If you cannot resolve your problem, please reopen this issue with detail explanation for your problem.
Thanks!


Missing concrete implementation for generic override mismatch

For this generic override mismatch the analyzer generates a 'missing concrete implementation' warning instead of an 'override mismatch':
abstract class A<E> {
  T f<T>(T a, T b(T c, E d));
}

abstract class B<E> implements A<E> {
  T f<T>(var a, T b(T c, E d)) => null; // 'var a' should have been 'T a'
}

class C<E> extends B<E> implements A<E> {}

generates Missing concrete implementation of 'f'. (override.dart, line 9, col 7) for the last line.

I'm assuming this is with strong mode enabled?
Is it a mismatching override at all? You change the a parameter type from T to dynamic, which should be a safe override for all types T.

It is not with strong mode enabled.

In that case, the types should be identical, all the type parameters should just be dynamic. I'm guessing this is similar to #28236.

Analyzer now only reports:

error • A value of type 'Null' can't be returned from method 'f' because it has a return type of 'T'. • a.dart:6:35 • return_of_invalid_type

I'm also confused about var inheriting...

Analyzer now only reports:

error • A value of type 'Null' can't be returned from method 'f' because it has a return type of 'T'. • a.dart:6:35 • return_of_invalid_type

I'm also confused about var inheriting...

Given that the is was with Dart 1 semantics and that the analyzer correctly infers var a as T a for Dart 2 semantics we can close this issue.

Given that the is was with Dart 1 semantics and that the analyzer correctly infers var a as T a for Dart 2 semantics we can close this issue.


[AutoPR security/resource-manager] Adding more documentation to ASC Pricing API

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6691

(message created by the CI based on PR content)


Set theme settings variables from config

Overview

[x] Inject all theme config settings as less variables when loading theme stylesheets
[x] Don't load stylesheets until after the config has been activated for a theme
[x] Make activate method in package main optional. Since themes will most likely only set a config object in their package main, requiring them all to have a no-op activate: -> seemed ugly. Also deactivate was already optional so this makes it consistent with that.

Curious if there's any movement on this; I'm definitely very interested in using it! :)

Curious if there's any movement on this

No, the proof of concept went smoothly, but getting it production ready did not go as well.
The main issue was that it required drastically changing Atom's startup since package configs had to be loaded before loading any core stylesheets could begin since package config values could be pulled into computed core stylesheet variables.
It also required recompiling core, package, and theme stylesheets on config changes which is really expensive as well.  Correctly caching and busting the cache on config changes and stylesheet updates was also presenting issues.
Therefore I don't think this is something that will ship in Atom 1.0, perhaps using CSS variables once they ship in Chrome could be used for a similar feature.

Fair enough!

Hello! Is there any progress regarding this issue? Will be able to provide ui-theme options that affect less variables anytime soon? :)

@wdanilo I have been able to implement stylesheet options by setting css variables in a style attribute. Depending on what kind options you need this is also more elegant as the changes are applied without having to re-compile less, which in theory also lets you transition between values.

@braver have you thought about contributing this to Atom. Likewise, Atom folks, do you think this has a place in core? I believe I do.
CSS custom properties derived from the user's config and declared in a high-level ancestor such as atom-workspace can allow the following:

Avoids changing Atom's startup sequence and the need to recompile-LESS-on-change.
Accessible at runtime, therefore accessible from both CSS and LESS user styles, themes, and packages
The ability to modify this value at runtime (through settings etc) without an Atom reload
The ability to read these values in JavaScript as well through el.getPropertyValue('--my-var'), though atom.config is still a much better place to read core config settings
The ability to override the property value at a lower level in the tree

Current workarounds involve things like monitoring changes to atom.config and modifying a style node to reflect these changes, as is done in the GitHub package. We'll likely have to implement something similar throughout Atom IDE, such as in its Outline pane.
I can even see a future where all UI and Theme constants are declared this way, thus allowing package authors and users to use whichever CSS preprocessor (or none at all!) they wish. Though this would require a transition plan from LESS variables 😬
cc @damieng @binarymuse

/cc @simurai (who is on leave atm) on the above — I seem to recall some experimentation with something like this but my memory is fuzzy.

@wbinnssmith In my own professional projects where I can rely on a recent version of Chrome, I have moved to custom properties over Less variables (effectively using Less only for its nested selectors), and it’s amazing really. So much more powerful and flexible and everything updates immediately.
 But color functions are in the CSS spec.

@wbinnssmith Agreed. Would be awesome to use custom properties.
@braver has a valid concern about color calculations. Like darken(), lighten() or checking contrast. It will eventually be available in CSS, but doesn't seem to be listed here: https://www.chromestatus.com/features#color. So probably not that soon.
But might still be worth a try to see how far we get without them. Maybe add more variables so that package authors don't need to calculate other colors. And if they really do, they would have to go from CSS > JS > CSS. Instead of Less.
I played around with this https://github.com/simurai/tone-syntax theme, where you can change colors in the theme settings and then it spits out all the custom variables. Performance is pretty ok.


Correction to README file

Hello, there is an error in this documentation. At line 23, reader is advised to add:
@import<EMAIL_ADDRESS>
This file does not exist.
User should be advised to add:
@import<EMAIL_ADDRESS>
Thank you
a

Codecov Report

Merging #799 into rc0.12.0 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           rc0.12.0     #799   +/-   ##
=========================================
  Coverage     95.14%   95.14%
=========================================
  Files            73       73
  Lines          2924     2924
  Branches        449      449
=========================================
  Hits           2782     2782
  Misses           46       46
  Partials         96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd7776...dcc73be. Read the comment docs.

Second commit to this PR:
At Line 30 of README documentation: Advise reader to add overflow: hidden property to .ripple-icon-component to render properly bounded ripple.
The current documentation leads the reader to create an unbounded ripple, extending outside the dimensions of the component (even when the unbounded prop is removed). The overflow: hidden property must be added to render the expected bounded ripple effect.
Thank you
a


Add the frozen_string_literal pragma

:+1: from me.
@gkellogg @bendiken we should talk about when and how to do this across the suite. See: https://bugs.ruby-lang.org/issues/11473

@no-reply here's how:
find . -name "*.rb" -exec perl -pi -e 'print "# frozen_string_literal: true\n" if $. == 1' {} \;

Definitely a :+1: on this count.

Well, I was all ready to merge, but rbx is failing:
undefined method []' on nil:NilClass. (NoMethodError)`

Looks like the rbx problem was just a CI hiccup.

Note that the generated vocabulary already freezes strings, so the frozen_string_literal pragma shouldn't cause anything else to freeze. We also can't get rid of the explicit .frozen method on each string because we need to be explicit for Ruby < 2.3.0, but it's certainly a reasonable thing to do, and we should, indeed, look to see where else it may be useful more generically.

@gkellogg not all strings were frozen. See the keys: https://github.com/ruby-rdf/rdf-vocab/blob/develop/lib/rdf/vocab/dc.rb#L11-L13

True; those should probably be symbols, though. I'll look into that.

This has me curious whether a symbol like :'dc:creator' instantiates a mutable string literal.
Life's Big Questions :tm:

This has me curious whether a symbol like :'dc:creator' instantiates a mutable string literal.

From a theoretical understanding that should just add a new entry to a symbol table. Each time you call #to_s on the Symbol object, it will give you back a newly-allocated String object. Obviously this is implementation-dependent, though.

Note that "foo-bar".to_sym #=> :"foo-bar"


Platform-specific skipped tests

It seemed silly to me that we were skipping tests everywhere just because they were behaving badly on one platform, so now we have the option to only skip tests on certain platforms if we so wish!
By default tests are skipped on all platforms, but you can now provide a (lower-case comma-separated) list of which platforms the test should be skipped on. The available options mirror the AK_OS_
I restricted the Worker tests to macOS since that is why they were added in the first place, but I did not go through and audit the rest of them. I did also add Text/input/HTML/DedicatedWorkerGlobalScope-instanceof.html to the list of skipped tests on macOS, since it is consistently hanging on my machine. See #1306 for details.

First thought:
What about a Skipped_ section in the ini file instead of making weird looking relative-path=list,of,strings key-value pairs?

If we did that the logic would be like
for platform in my_platform_list:
   if group = config.group(`Skipped_${platform}`):
       for key in group:
          list_of_skipped_tests.append(key)

Which seems a bit simpler than what you have now

I did play around with that approach first, but I ran into two issues pretty quickly:
Firstly, the "Unknown group" warning would either have to be a lot more complicated (Skipped_linux is a valid key even if you're running on macOS), or will need to be dropped entirely. I'm not sure how much value it's really adding though, so I think that would be ok.
The bigger issue though is that if you ever wanted to skip a test on two platforms it would be much more verbose than it is now. Skipping on both (and only) macOS and iOS would need to look like:
[Skipped_macos]
Some/Test/Path.html

[Skipped_ios]
Some/Test/Path.html

We could add in even more helpers for these cases (i.e. something like Skipped_apple), but it's still not a great solution.
That being said I'm also not happy with the solution I landed on either, if only because it makes my syntax highlighting go weird. If the config format were more structured (i.e. YAML/JSON) I'd probably do something like:
skipped:
  - Some/Test/Skipped/Everywhere
  - path: Some/Conditionally/Skipped/Test
    platforms: [macos, ios]

But that was hard to replicate in the Serenity Config format.
If you think the duplication concerns and lack of warning are ok then I'm happy to do that approach.

:man_shrugging: ini is a very restrictive format. if we want more interesting things to happen, loading a JSON file with AK::JsonValue::from_string wouldn't be the worst thing in the world. Lemme poke the other maintainers to leave feedback here or in #testing.

You underestimate the power of ini!
It's possible to make this work:
[Skip:macos,ios]
Foo/bar

[Skip:macos]
Bar/baz

(The group names don't have to be \w+ you know...)

If we’re going to do this, a different approach to consider is something like the way the WebKit project handles it — which is to organize skip/expected-to-fail/expected-to-be-flaky data into TestExpectations files into platform-specific directories.
See https://github.com/WebKit/WebKit/tree/main/LayoutTests/platform and for a specific example, see https://github.com/WebKit/WebKit/blob/main/LayoutTests/platform/mac/TestExpectations
I’m not voting for that as being an absolutely-better way of handling it — but instead just offering it up as something worth taking a look at that was designed to address the same problems.

Another idea (which I'm also not voting for but just offering) is to keep the metadata for each test in that test, in a magic comment or something. Maybe:
<!-- SKIP: mac, win -->

You underestimate the power of ini! [snip]

True! But that also makes the pattern matching part of the skip logic slightly more complicated. Not impossibly so by any means, but the key/value approach was less work, which is why I went with that. This does look cleaner though, so I'm tempted to give it another shot.

If we’re going to do this, a different approach to consider is something like the way the WebKit project handles it [snip]

Definitely an interesting idea to keep in mind, but I personally am not a fan of having bespoke file formats for things like this, and it seems overkill for what we need at the moment, especially since afaik Ladybird's internal tests are currently strictly pass/fail. Something to keep in mind though, especially with its ability to "un-skip" tests per-platform, which has the same effect as saying "skip except on <platform>", which could be useful.

Another idea (which I'm also not voting for but just offering) is to keep the metadata for each test in that test, in a magic comment near the top of the file or something. [snip]

Ooh, I both really do and really don't like this idea. On the one hand it's simple and keeps the skips tightly coupled to the tests, but on the other hand it makes it a little harder to find all the skipped tests (though since we list all the skipped tests at the end of the run it's not that big of a deal). It would also entirely prevent having any sort of pattern-matched skips since you would have to add them to each file individually. Maybe some CLI tooling could help with that, but that feels like a pain point waiting to happen.
The more I think about that last option (the inline comments one) the more I like it actually. The only real pain point is the inherent lack of globbing support. Maybe we could do a hybrid approach? Have per-file skips as described then also have a directory-scoped file (i.e. Tests/LibWeb/platform/macos/Skips.txt [or some other format]) that applies to the whole directory? It still wouldn't allow for skipping some-but-not-all tests in a directory, but that could push us towards better organizing the tests' directory structure anyway, which might not be a bad thing.
At the end of the day though, I'm not the one who will be interacting with this system the most, so I'm happy to go with whatever the group consensus is.

On that vein, I'm going to hold off on addressing the review comments until we settle on an approach.


[Core] optional defaultEntityReference return

Description
Closes #1100. Having no data for a default entity reference is not an error state.

[x] I have updated the release notes.
[x] I have updated all relevant user documentation.

Thanks! Should we update the default implementation to return a null optional for now, as the kEntityAccessError is no longer documented.

Although it'll change with the result of https://github.com/OpenAssetIO/OpenAssetIO/pull/1101, it's a good point that it's currently inconsistent and undocumented.

Thanks! Should we update the default implementation to return a null optional for now, as the kEntityAccessError is no longer documented.

Although it'll change with the result of #1101, it's a good point that it's currently inconsistent and undocumented.

Modified default behaviour in 42ca5099


feat: add support for included examples

add support for examples included with it_behaves_like

Bonjour @raw1z :wave:
Can you send an example Ruby file that you want to support? Unfortunately this just seems to break the tests that can be run with make test

Bonjour @raw1z 👋
Can you send an example Ruby file that you want to support? Unfortunately this just seems to break the tests that can be run with make test

I added example ruby files. I also made make test_core pass. I can't make make test_rspec pass. I noticed that it was also failing on the main branch so the errors might not come from the changes in this PR.

Awesome. Thanks so much!


Fixing Metal, truncated answers and GGML errors (howto)

Llama plugin workarounds
I'm trying summarize multiple threads, while a plugin update is pending. Streaming support was already added last night, so it isn't mentioned here. Today is Mon 11, Sep 2023.
1. Using the new GGUF models
Install the plugin:
llm install -U llm-llama-cpp

Now install the latest llama-cpp-python with Metal support:
CMAKE_ARGS="-DLLAMA_METAL=on" FORCE_CMAKE=1 llm install llama-cpp-python

The current documentation shows this advice, but it will lead to an error. GGML .bin files are no longer supported by Llama.cpp:
llm llama-cpp download-model https://huggingface.co/TheBloke/Llama-2-7B-Chat-GGML/resolve/main/llama-2-7b-chat.ggmlv3.q8_0.bin

To see the error, the plugin supports a verbose mode:
llm -m llama-2-7b-chat.ggmlv3.q8_0 'five names for a cute pet skunk' -o verbose true
gguf_init_from_file: invalid magic number 67676a74
error loading model: llama_model_loader: failed to load model from /Users/ph/Library/Application Support/io.datasette.llm/llama-cpp/models/llama-2-7b-chat.ggmlv3.q8_0.bin

llama_load_model_from_file: failed to load model

If you try to download the same model, but with the new GGUF format, the plugin gives an error, because download-model expects a .bin extension.
llm llama-cpp download-model https://huggingface.co/TheBloke/Llama-2-7b-Chat-GGUF/resolve/main/llama-2-7b-chat.Q8_0.gguf
Usage: llm llama-cpp download-model [OPTIONS] URL
Try 'llm llama-cpp download-model --help' for help.

Error: Invalid value: URL must end with .bin

A fix for this would be the plugin to accept all formats supported by llama.cpp. See this comment.
Pending that, you can download the model directly to the correct location and then add it:
cd ~/Library/Application\ Support/io.datasette.llm/llama-cpp/models

wget https://huggingface.co/TheBloke/Llama-2-7b-Chat-GGUF/resolve/main/llama-2-7b-chat.Q8_0.gguf

llm llama-cpp add-model llama-2-7b-chat.Q8_0.gguf

Now you can run the model as usual:
llm models list
llm -m llama-2-7b-chat.Q8_0 'five names for a cute pet skunk'

Or in verbose mode:
llm -m llama-2-7b-chat.Q8_0 'five names for a cute pet skunk' -o verbose true

But Metal is not yet active. There are no lines that begin like this:
ggml_metal_add_buffer: allocated...

2. Activate Metal support
Until there's a new plugin version, you need to patch lla-llama-cpp to activate Metal support. This is quite straightforward.
git clone https://github.com/simonw/llm-llama-cpp.git
cd llm-llama-cpp

Then you need to add n_gpu_layers to the end of this line in llm_llama_cpp.py, as described in Simon's comment.
 model_path=self.path, verbose=prompt.options.verbose, n_ctx=4000, n_gpu_layers=1

Now reinstall the plugin from this folder:
llm install .

And try generating content again. You should see in Activity Monitor, how the GPU is now used. Verbose mode (shown above) would include mentions of Metal.
llm -m llama-2-7b-chat.Q8_0 'five names for a cute pet skunk'

3. Activate longer answers
At this point the answers are still truncated. You need to add a max_tokens to the plugin as described in Simon's comment.
stream = llm_model(prompt_text, stream=True, max_tokens=4000)

Now reinstall the plugin from this folder:
llm install .

And try one more time:
llm -m llama-2-7b-chat.Q8_0 'five names for a cute pet skunk'

All done
That should be the whole list. I'm sure there will be a new plugin version soon, but in the meanwhile, hope this helps someone.

As far as I can tell you can set n_gpu_layers=1 even for non-GPU builds and it still works.
So... I'm setting that to 1 by default and providing a -o no_gpu 1 option to turn that off, just in case someone needs that.


Temporary fix for TextLive fail

The Travis build was failing on all our branches due to an issue with TextLive (an external dependency).
The author of TextLive is working on a fix.
For now... I have implemented the fix suggested here: https://github.com/travis-ci/travis-ci/issues/7852

Fingers crossed!


Now using replaceUser instead of updateUser in BO

Should be merged when everything is ready on Kuzzle side regarding new credential management.

Codecov Report

Merging #304 into 2.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #304   +/-   ##
=======================================
  Coverage   75.84%   75.84%
=======================================
  Files          39       39
  Lines         770      770
=======================================
  Hits          584      584
  Misses        186      186

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd5557...70f351c. Read the comment docs.


Cannot open file png on public link

Describe the bug
Steps to reproduce the behavior:

add a png file and open it in mediaviewer (opened correctly)
create public link and open public link
open png file in mediaviewer

Expected behavior
The pnd file can be opened in mediaviewer
Actual behavior
Error 500
2021-12-10T14:07:21+01:00 ERR could not get thumbnail error="{\"id\":\"com.owncloud.api.thumbnails\",\"code\":500,\"detail\":\"could not get image from source: could not get the image \\\"https://<IP_ADDRESS>:9200/remote.php/dav/public-files/VBWKXTWsWiWyuNo/amoadklbbpmdaabc.png/amoadklbbpmdaabc.png\\\". Request returned with statuscode 403 \",\"status\":\"Internal Server Error\"}" service=webdav
BUT: If you create a public link to a folder with a file, it works correctly
Setup
Please describe how you started the server and provide a list of relevant environment variables.

OCIS_VERSION=v1.16.0
BRANCH=v1.16.0-rc2

I tested it with the 1.16 release and it works. Could you try again?

I might have more information on this. I noticed the same - at first it seemed random, but by now I think it might be dependent on the resolution:
curl 'https://host.docker.internal:9200/remote.php/dav/public-files/JzdwNgPegOTMRqk/San%20Francisco.jpg?a=1&c=cb90522b716442a97b13a090e757e3ab&preview=1&scalingup=0&x=1280&y=1280&signature=d7eb048024714ea0a95695bc23bdec5c96f483845f511548a78248dfdfc4f25e&expiration=2022-01-21T22%3A28%3A46Z' \
  -H 'Connection: keep-alive' \
  -H 'Pragma: no-cache' \
  -H 'Cache-Control: no-cache' \
  -H 'sec-ch-ua: "Chromium";v="95", ";Not A Brand";v="99"' \
  -H 'authorization: Bearer' \
  -H 'x-requested-with: XMLHttpRequest' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36' \
  -H 'sec-ch-ua-platform: "Linux"' \
  -H 'Accept: */*' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Referer: https://host.docker.internal:9200/' \
  -H 'Accept-Language: en,en-US;q=0.9,de;q=0.8,nl;q=0.7' \
  -H 'Cookie: oc_sessionPassphrase=fqweHxd%2BdJg8FP3OxHe4xPvw1COHodX4OkALnkVzp49oss3TD1uAmn97iKEH36eMe2WJFzUgM40bBG%2Be5StNAXQ02Cckve1pTcL8FGt2Vwg32rvdjdrRGvM0H%2FCshtBX; ocrdljgzi4vx=vnt05ac8qc3hniqolfdnronot9; ocjoxjzcyrm1=7sjkvp4er8rthns96d66vagikn' \
  --compressed \
  --insecure
<?xml version="1.0" encoding="UTF-8"?>
<d:error xmlns:d="DAV" xmlns:s="http://sabredav.org/ns"><s:exception></s:exception><s:message>{"id":"com.owncloud.api.thumbnails","code":500,"detail":"could not get image from source: could not get the image \"https://host.docker.internal:9200/remote.php/dav/public-files/JzdwNgPegOTMRqk/San%20Francisco.jpg\".  Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

Right now I can reproduce 100% of the times. The only difference in those requests is x=1280&y=1280 vs x=3840&y=3840.


Unable to build with personal fork of massa's polkadot-sdk

I was trying to work on the issue #1484 and i need to do some changes in the polkadot sdk.
So I forked the repo and then updated madara's cargo.toml to make it point to my own fork instead of the massa one but i encountered a rust type error with FixedU128 of sp_arithmetic crates because this one is also pulled by the blockifier.
I managed to fix by patching the Cargo.toml like this :
[patch.'https://github.com/massalabs/polkadot-sdk'] sp-arithmetic = { git = "https://github.com/azurwastaken/polkadot-sdk", branch = "release-polkadot-v1.3.0-std", default-features = false, features = ["std"] }
But I was wondering how to make it easier for us to do some change in the polkadot sdk and test it with madara.
I don't think i can make a pr with my fix but at least we can put it in a dev doc or something like this.
What do you think ?

I think bringing it within this repo using git submodules would make it easier to develop on.

@apoorvsadana @EvolveArt any opinion on this one?

@AbdelStark was pushing for the removal of sub-repos, but I find them useful.
What do you all think?

I don't think we're using them in anyway right now to be honest. I would advocate for removing it as well.

will be solved with #1596


sqlite: fix short time parsing

Probably a typo. Fixes errors like this:
cannot parse time from column 3: parsing time "2024-03-08 18:41:53" as "2006-01-02 15:04:05.000-0700": cannot parse "" as ".000"

Signed-off-by: Ilya Mateyko<EMAIL_ADDRESS>

Done. There was actually a test for this, but it was broken.

Wonderful, thanks!


Unable to use it in subgraphs

Subgraph is a web3 service that indexes blockchain events.
Sometimes data needs to be retrieved from some centralized servers.
We tried using this library for same but not able to use.
Could you help us with this @JairusSW .

Hello there!
Can you tell me what version of AssemblyScript you are using now?
The version of as-fetch that is on NPM is built for 0.19.x, but I am refactoring it to work for 0.27.x. If you are on 0.19.x and you want to use it, try importing like shown in issue #2 .
I should release a updated version soon, but I am busy at the moment.

blockchains usually disallow any unpredictable & external behavior. Also as-fetch depends on JavaScript runtime while The Graph has own runtime. So I don't think that as-fetch or something similar can be used in your case

Yes, that should be the issue. Closing now


fatal error: snitch/snitch_registry.hpp: No such file or directory

Trying to build an example from the README using the 1.1.0 release, I've got the following error:
/usr/include/snitch/snitch_macros_check.hpp:9:10: fatal error: snitch/snitch_registry.hpp: No such file or directory
    9 | #include "snitch/snitch_registry.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

I believe the problem is that this file is not listed here:
https://github.com/cschreib/snitch/blob/d040b89227a4cea74986aeaf4b57ec62994cab7e/CMakeLists.txt#L68-L69
That's why it's not installed here:
https://github.com/cschreib/snitch/blob/d040b89227a4cea74986aeaf4b57ec62994cab7e/CMakeLists.txt#L99-L101
I'd provide a PR for that, but perhaps this change affects the Benchmark section too.

Thank you very much for reporting this. I think you're diagnostic is correct, although I don't think this will impact the benchmark (it's done using FetchContent, not the CMake-installed library). I don't actually test the CMake-installed library; that needs to change so we can prevent this from happening again. I'm happy for you to do a PR to just add the missing header, so we can quickly issue v1.1.1 (that didn't take long). I can work on adding more testing in parallel, as that's lower priority.


added rails instructions to documentation

Hi there, I love using unirest but noticed as I was talking to a student about open source projects and she was having trouble setting up in her rails app. I thought it would be an easy add for me to contribute.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Number of GPUs for Training

Hi,
How many (and which) GPUs did you use while training your baselines (D-DETR) and your proposed method (Cal-DETR)?

Thank you for your interest. 4 GPUs (Tesla V100).


message needs to be unwrapped before it can be set to state

e.g. code such as
https://github.com/threefoldfoundation/tfchain-wallet-electron/blob/cc0f143f4fecbd8732079f5dd04155baec1ee207/app/components/Transfer.js#L132
Won't work, as the errorMessage is not a string or something it can handle. It is an exception thrown by python code and wrapped in some weird JS object that has to be unwrapped to get the message (or parsed message) from there. For now the app crashes on that if it occurs.
It is possible you also have this on other locations, please check.

Resolved. All exceptions returned by TFChain code now have the str() method, that lets you stringify the error. Already resolved it for the example code.


VM: fix codegen for APPEND

After changes in #391 some tests started to fail. This PR fixes codegen for APPEND.

After changes in #391 some tests started to fail. This PR fixes codegen for APPEND.

I believe you're talking about at least this test:
TestStringToByteAppend


[App Config] BREAKING CHANGE: Key-value import and export improvements

Related command
az appconfig kv import
az appconfig kv export
Description

Adds validations to JSON file imports to ensure that only valid JSON objects are imports. Other JSON primitives will be rejected
Prevents issue of dropping some key-values when trying to convert integer keys to an array. Reverts to exporting key-values as objects when keys are not continuous integers, or both strings and integer keys are found. This ensures that no keys are dropped. Keys at the root of an object are not treated as indices of an array even if they are continuous

Testing Guide

History Notes

[App Config] Change:az appconfig kv import : Add validation to JSON file import
[App Config] Change:az appconfig kv export: Update array conversion logic to prevent dropping keys during export

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

App Configuration

Hi @zhoxing-ms, @yonzhan,
Please this change does not change any command syntax, however, it updates the behaviour of existing functionality. I would like to confirm if that is considered a breaking change in the CLI just so I could update the hitory accordingly. Thanks!

@albertofori Yes, if this PR will change the existing business behavior of users, it will cause breaking change.
It is recommended to implement breaking change in the unified breaking change window of CLI (Microsoft Build and Ignite), so as to reduce it's impact on users
For more details about CLI breaking change process, please refer to this doc breaking_changes.md

@albertofori Yes, if this PR will change the existing business behavior of users, it will cause breaking change. It is recommended to implement breaking change in the unified breaking change window of CLI (Microsoft Build and Ignite), so as to reduce it's impact on users For more details about CLI breaking change process, please refer to this doc breaking_changes.md

Thanks a lot, @zhoxing-ms!

What do we do when importing a json array as root?

What do we do when importing a json array as root?

We error out and tell the user to import a json object.
https://github.com/Azure/azure-cli/pull/23419/commits/b8915aa7dcb6bd7536eb695edd61b5bd1081d8fe#:~:text=if not isinstance,).name))

@albertofori Yes, if this PR will change the existing business behavior of users, it will cause breaking change. It is recommended to implement breaking change in the unified breaking change window of CLI (Microsoft Build and Ignite), so as to reduce it's impact on users For more details about CLI breaking change process, please refer to this doc breaking_changes.md

@zhoxing-ms So to confirm, please can this be merged in if there are no further issues or do we have to hold it until the breaking change window?

@albertofori If we merged this PR now, this PR will be added to the current sprint release by our CI pipeline.
So I suggest not to merge it first. Wait until the sprint of Ignite Event (around October 12, 2022), and then please remind us to merge it. What do you think?

@albertofori If we merged this PR now, this PR will be added to the current sprint release by our CI pipeline. So I suggest not to merge it first. Wait until the sprint of Ignite Event (October), and then please remind us to merge it. What do you think?

@zhoxing-ms Thanks! I will make sure to remind the team to merge this in the next sprint then.

@albertofori Could you please address those conflicts~

Could you please add the information of the breaking change and the correct usage recommended in the PR description?

Could you please add the information of the breaking change and the correct usage recommended in the PR description?
Information on correct usage and the breaking change has been added in point 1. in the PR description.

@albertofori Could you please resolve those conflicts?

/azp run

@avanigupta Could you help review and approve this PR tomorrow?
Because the release for Ignite sprint will be launched the day after tomorrow and the breaking change of this PR has been published in the breaking change doc. In order to make this PR catch up with the current breaking change window, if you do not reply in time, we will merge this PR tomorrow evening.

[App Config] BREAKING CHANGE: az appconfig kv import: Add validation to JSON file import to ensure that only valid JSON objects are imports
[App Config] BREAKING CHANGE: az appconfig kv export: Update the array conversion logic to prevent dropping keys during export

@albertofori I modified the PR description to comply with the specification of history notes. Please help to see if it is accurate and meets your expectations

[App Config] BREAKING CHANGE: az appconfig kv import: Add validation to JSON file import to ensure that only valid JSON objects are imports
[App Config] BREAKING CHANGE: az appconfig kv export: Update the array conversion logic to prevent dropping keys during export

@albertofori I modified the PR description to comply with the specification of history notes. Please help to see if it is accurate and meets your expectations

@zhoxing-ms Please it looks fine. Thanks! By the way, I added a few updates to the first point in the description based on updates that came later in this PR . I hope it still adheres to the required specifications.


Add NavigationTransitions

Project URL
https://github.com/davdroman/swiftui-navigation-transitions
Category
UI -> Animation -> Transition
Why it should be included to awesome-ios
No other library offers this level of functionality so tightly integrated into SwiftUI's own views. It feels to me like an important addition to the community in bridging the gap between UIKit and SwiftUI.
I purposefully designed the API to feel as if it's part of SwiftUI, and I think it shows in how nice and succinct its usage is whilst maintaining entire layers of customizability abstracted away from library users.
Checklist

[x] Has 50 GitHub stargazers or more
[x] Only one project/change is in this pull request
[x] Isn't an archived project
[ ] Has more than one contributor
[x] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@davdroman
Thanks for contributing!


Feat: implement price() method

This PR covers adding of price() method
Limitations and details:

There is no way to receive a history of price changes. The "currency/exchangerate" endpoint is the only one to calculate the exchange rate and it returns only one float value at a time
We can not look up for a custom currency exchange rate. My goal was to test an exchange rate for a created currency. After creating a custom currency using the currency/create.json endpoint and trying to receive its rate from the "currency/exchangerate" endpoint it returns an empty string and doesn't see a new currency
Test action will fail until https://github.com/macxred/cashctrl_api/pull/44 is merged

@lasuk Please review the changes and provide feedback or approval for merging.

Thanks for completing 'price' methods to the extend supported by the CashCtrl API.
I've added a commit to further clarify error messages and docstrings.
Ready for merging as soon as the CI test gives us the green light ..


Duplicate entries

I spotted 912 duplicated entries, for example:
12318 | 27.86 | 46.50 | albesti | VASLUI | VS | 1171.0 | Nord-Est
27.55 | 46.70 | albesti | VASLUI | VS | 239.0 | Nord-Est
22.51 | 47.32 | almasu mic | BIHOR | BH | 552.0 | Nord-Vest
22.14 | 47.17 | almasu mic | BIHOR | BH | 209.0 | Nord-Vest
Most probably they were inserted from different data sources at different points in time.
I think it would be good to drop all duplicates, and keeping the ones with the maximum population value.
I'm open to discussion if there is anything I misunderstood.

I think it would be great to update the source with the official one http://data.gov.ro/dataset/siruta

http://data.gov.ro/dataset/siruta

Your link to official data is broken, although the text displayed is the correct link.

it would be nice to have some sort of automation from here
(http://colectaredate.insse.ro/senin/classifications.htm?selectedClassification=&action=&classificationName=SIRUTA)
i found the latest list from 2018

@zhgabor yea, MDB and DBF.


Mobile controls

Occasionally the virtual stick will get stuck in one position after flicking it a bit and will not be able to be moved until you reload the page additionally mobile is missing a few buttons that are needed in some games (all the c buttons, both l and r, and the d pad) I don't know if those are available but just off by default but either way the layout of the buttons should be able to be changed from the menu when in a game.

Yeah I've seen the "virtual stick getting stuck" issue as well, I think it is related to NippleJS which is the library I am using and is probably this issue which has not been fixed yet:
https://github.com/yoannmoinet/nipplejs/issues/151
In terms of the mobile buttons missing, I totally agree and it was mainly that there just isn't a lot of space for all the buttons in portrait mode (which is the only mode that is currently supported). So it was really just a tradeoff where I kind of picked the most common buttons I thought people would need (understandably it's not a solution but that was my thinking) The ways to solve that long term would be either to create a landscape mode where I would have buttons overlayed, or maybe make the buttons configurable like you said.


Tooltip arrows?

This may be a work in progress, but noticed that the reactstrap Tooltip does not have an arrow like the Bootstrap v4 docs:
BS4:
http://v4-alpha.getbootstrap.com/components/tooltips/#static-demo
Reactstrap:
https://reactstrap.github.io/components/tooltips/#
Is this intentional or an oversight?    Happy to look at this if so, but wanted to check first.

Oof. Thanks for reporting! Looks like a change in the latest alpha release. See https://github.com/twbs/bootstrap/commit/e7f79b32f22d7f39138a7003272b54ceb3b12426#diff-9ff9d982e0cf16baef57b77d798f5400
Feel free to send a pr.

Thanks for the quick update, will take a look!

This is a bit more involved than I assumed - I'm still looking at it but if anyone more knowledgable of the codebase wants to grab it in the meantime, please do.

@gthomas-appfolio published in 3.9.2 and 4.0.0-alpha.2. Also pushed out the in -> .active switch in 4.0.0-alpha.2.


[manuf] Verify manuf_state_creator consistency between ROM_EXT and OTP

This adds the check to ensure the manuf_state_creator field in the ROM_EXT manifest matches the expected value that will be provisioned into the OTP. The ROM_EXT manifest is located in slot b and is flashed during the second bootstrap. The verification is done before the OTP is provisioned or the bootstrap is disabled, allowing for correction and re-running the personalization flow.
This PR partially addresses #24617

The failed job //sw/device/tests:i2c_target_test_fpga_cw310_sival in the CI pipeline should be unrelated to this PR. I also spotted the same job failed in the other PRs.


I can't access an object property inside event

Hi, I am using React with Pannellum.  In component B, which is a child of component A, I have this method:
const loadScene = sceneId => {
console.log(CONFIG[period].scenes[sceneId]); // works
pano.loadScene(sceneId);
setBig(false);
}
"pano" is a global variable and holds the pannellum object. "CONFIG" is also another global variable that keeps the object that I used to generate my panorama.
Inside component A, we have this inside useEffect():
pano.on("scenechange", newScene => {
console.log(CONFIG[period].scenes[newScene]); // doesn't work
// error: Uncaught TypeError: Cannot read properties of undefined (reading 'scenes')
// at :185:42
// at fireEvent (pannellum.js?ver=2.5.6:4796)
// at loadScene (pannellum.js?ver=2.5.6:3980)
// ...
});
"period" exists in both components.
I don't know why this happens nor if it's actually a bug or not. I tried looking at fireEvent but I don't understand its code.

This looks like an issue with your code / with React, not with Pannellum. Based on the error, CONFIG[period] is undefined. You should make sure the period key actually matches one of the keys in CONFIG.

Yeah, I actually made sure, when I console.log period, CONFIG, CONFIG[period] and CONFIG[period].scenes all separately and inside the loadScene function (which is another component) they all work. But when I do the same inside "scenechange" event, only the last one (CONFIG[period].scenes) doesn't work. So it seems to be a problem with "scenes" property, maybe because of its name, but when I tried changing its name (by coping the object inside rhe event) to something like "sc3n3s" it stills doesn't work. So, in short:
const loadScene = sceneId => {
console.log(period); // ok
console.log(CONFIG); // ok
console.log(CONFIG[period]); // ok
console.log(CONFIG[period].scenes); // ok
}
pano.on("scenechange", newScene => {
console.log(period); // ok
console.log(CONFIG); // ok
console.log(CONFIG[period]); // ok
console.log(CONFIG[period].scenes); // not ok
}
});

I can't help you if you don't provide proper information. The console.log statements are not printing ok to the console; they're printing the information necessary to debug this. You wrote that console.log(CONFIG[period]) is "ok" in the second case, but it's clearly not, since it doesn't include a scenes key.
This is also definitely an issue with your code and not an issue with Pannellum.

I didn't say they are printing "ok"/"not ok", I meant if they printed correctly the object in question or not.
I actually can print an object's key with no problem, and that's what I did with CONFIG[period] in which period is a string. If period = "day" it would print CONFIG.day, and so on. I mean, I don't need to print a key inside it (OCNFIG.day.scenes) in order for it to work, since console.log will print the whole thing including scenes key.
That's how Javascript works so I don't see your point here.
And, for more information, this is the object's structure:
let CONFIG = {
day: {
default: {
// other keys
},
scenes: {
// Other keys
},
},
night: {
default: {
// other keys
},
scenes: {
// Other keys
},
}
}
When I execute console.log(CONFIG[period]) in which period = "day", it will print the whole object inside "day" key, and it did in all cases, meant by the "ok" word as in "hey, it worked!". But when I console log CONFIG[period].scenes in which period = "day" it works everywhere else except inside scenechange event, in other words, it's "ok"/working/printing the object correctly. It doesn't mean it's undefined since if so the object would be undefined everywhere, right?

I didn't mean they are literally printing "ok"/"not ok", I meant if they printed correctly the object in question or not.

I know that. My point is that your classification of the output as "ok" / "not ok" appears to be incorrect. Without the actual output, which you still haven't provided, I can't identify the issue. Copy and paste the output from the console.
If CONFIG[period] was an object with a scenes property, CONFIG[period].scenes would be defined. However, CONFIG[period].scenes is undefined, which means that CONFIG[period] does not have a scenes property.


fix #2366: v5 Mixer crashes when adding 8+ inputs to it while playing

Proposed fix (or rather a workaround) to a crash caused by a adding multiple new inputs to a mixer on the fly. See issue #2366

oops wrong branch


Two new openigtlink operators, and a sample application interfacing with 3D Slicer using the operators

Some new work that allows Holoscan SDK to be used as a compute backend for, e.g., 3D Slicer
This PR contains two new openigtlink transmit and receive operators, and a sample application in which the operators are used, in conjunction with an AI segmentation pipeline, to:

Send Holoscan sample video data from a node running Holoscan SDK, using OpenIGTLinkTxOp, to 3D Slicer running on a different node (simulating a video source connected to 3D Slicer):

For cpp application, the ultrasound sample data is sent.
For python application, the colonoscopy sample data is sent.

Transmit the video data back to Holoscan SDK using OpenIGTLinkIF Module, and receive the data with the OpenIGTLinkRxOp operator.
Perform an AI segmentation pipeline in Holoscan:

For cpp application, the ultrasound segmentation model is deployed.
For python application, the colonoscopy segmentation model is deployed.

Use Holoviz in headless mode to render image and segmentation and then send the data back to 3D Slicer using the OpenIGTLinkTxOp operator.

The workflow allows for sending image data from 3D Slicer over network to Holoscan SDK (running on either x86 or arm), do some compute task (e.g., AI inference), and send the results back to 3D Slicer for visualization. Nodes can run distributed; for example, Holoscan SDK can run on an IGX Orin (Node A) sending the video data, 3D Slicer on a Windows laptop (Node B) and the AI inference pipeline on yet another machine (Node C). Also, note that the openigtlink operators can connect to any software/library that supports the OpenIGTLink protocol; here, 3D Slicer is used as it is a popular open source software package for image analysis and scientific visualization.

Thanks @jjomier! I have addressed your comments.


New version: nektos.act version 0.2.59

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

/AzurePipelines run

Hi @nektos-ci,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 695.)

Automatic Validation ended with:

Installation failed with exit code -1978335187 2024-02-01 23:42:12.733 [FAIL] Installer failed security check. Url: https://github.com/nektos/act/releases/download/v0.2.59/act_Windows_i386.zip Result: 0x80004005

(Automated response - build 695.)

/AzurePipelines run


Collab Notebook: Ingesting data from REST API into Database

For Definition of done see the milestone description: https://github.com/vmware/versatile-data-kit/milestone/29
Create google collab notebook for https://github.com/vmware/versatile-data-kit/wiki/Ingesting-data-from-REST-API-into-Database

Hey I'm a new grad developer from Canada, I'm looking to get my hands dirty with my first open source project. I've already joined the slack, can you give me any points on where to go from here? I've used google collab for some ML assignments from my university before so I am somewhat familiar with it.


How can I push multi data dynamically in ngx-gallery ?

this.multiImage = imagesOfFirestore;
    for (let index = 0; index < this.multiImage.length; index++) {

      this.galleryImages = [
        {
          small: this.multiImage[index],
          medium: this.multiImage[index],
          big: this.multiImage[index]
        },
      ];
    }

If the problem is that you are not seeing the new images, you need to create a new object reference:
const newImages = [];
for (let index = 0; index < this.multiImage.length; index++) {
  newImages.push({
    small: this.multiImage[index],
    medium: this.multiImage[index],
    big: this.multiImage[index]
  });
}
this.galleryImages = newImages;

I haven't tested this code, so take it with a grain of salt. Hope it helps.

<ngx-gallery [options]="galleryOptions" [images]="galleryImages">