Incorrect URL when route includes domain with a port

Ziggy version
1.5
Laravel version
10.3.1
Description
When your APP_URL contains port and domain from route also contains it'll join together.
Ziggy call and context
window.route('test', { param: '123' })

# Output
http://<IP_ADDRESS>:9100:9000/test/123

Ziggy configuration
{
    "url": "http://<IP_ADDRESS>:9000",
    "port": 9000,
    "defaults": {},
    "routes": {
        "sanctum.csrf-cookie": {
            "uri": "sanctum/csrf-cookie",
            "methods": [
                "GET",
                "HEAD"
            ]
        },
        "ignition.healthCheck": {
            "uri": "_ignition/health-check",
            "methods": [
                "GET",
                "HEAD"
            ]
        },
        "ignition.executeSolution": {
            "uri": "_ignition/execute-solution",
            "methods": [
                "POST"
            ]
        },
        "ignition.updateConfig": {
            "uri": "_ignition/update-config",
            "methods": [
                "POST"
            ]
        },
        "test": {
            "uri": "test/{param}",
            "methods": [
                "GET",
                "HEAD"
            ],
            "domain": "<IP_ADDRESS>:9100"
        }
    }
}

Route definition
Route::get('/test/{param}')
    ->name('test')
    ->domain('http://<IP_ADDRESS>:9100');

Just so I'm clear, your APP_URL is http://<IP_ADDRESS>:9000?
What is the URL of the page where you're seeing Ziggy output the double port?
How exactly are you generating your Ziggy config and loading it onto the page?
And how does Laravel's PHP route() helper behave here—with that route definition and APP_ENV, what does route('test', ['param' => 123]) output?

Just so I'm clear, your APP_URL is http://<IP_ADDRESS>:9000?

Correct

What is the URL of the page where you're seeing Ziggy output the double port?

Homepage aka / but it refers to every page

How exactly are you generating your Ziggy config and loading it onto the page?

@routes in blade view

And how does Laravel's PHP route() helper behave here—with that route definition and APP_ENV, what does route('test', ['param' => 123]) output?

Well, never tested that, but it looks like it has the same output as this package.
http://<IP_ADDRESS>:9100:9000/test/123

Homepage aka / but it refers to every page

What's the actual full URL in the browser, including the host? I'm wondering because Ziggy (and Laravel) uses the current request URL for most route generation.
What's the behavior you want or were expecting here? This probably isn't helpful but if Laravel outputs the double port, Ziggy will likely continue to do that as well. I'd rather be consistent with Laravel's behavior even if it's wrong. That being said, if there's clearly a better way to handle this it might be worth PRing to Laravel, I'm just not sure exactly what should happen here.

Closing this because we want to match Laravel's behaviour even if it's weird or wrong, so I don't think there's anything for Ziggy to change here. I'm still interested if you have a specific suggestion here about what should happen instead, so feel free to comment again!


Correctly Parse Subroutines Following Fat Commas

When a user clicks or hovers on a word, the language server needs to parse out the relevant symbol underneath the cursor. There's a bug when a subroutine name is preceded by =>. The language server is picking this up as part of the symbol. The following code reproduces this issue and "world" returns no results for hover or go-to definition. The function getSymbol in utils.ts needs to be fixed.
sub world {
    return "world";
}

my $foo = {"Hello"=>world};

This is now resolved.


Slate v0 is not reloading browser after trying Slate V1

### Problem
I was trying to use Slate V1 on an existing project then I was back to Slate v0.
But the browsersync doesn't reload the browser anymore.
Any idea why?
P.S. I've removed mkcert, yarn and killed HSTS in chrome already.
Thank you.

@radmedov can you try viewing you Slate v0 project in a Chrome incognito window? Pretty sure this is because Slate v1 uses https://localhost and not http, which can cause Chrome to default to using https in the future.

@t-kelly It doesn't work in an incognito mode as well. It's also not working in any browser.
I'm getting in the Chrome console:

This site does not have a valid SSL certificate! Without SSL, your site's and visitors' data is vulnerable to theft and tampering. Get a valid SSL certificate before releasing your website to the public.

Firefox's console:

This site makes use of a SHA-1 Certificate; it’s recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.

Strict-Transport-Security: The connection to the site is untrustworthy, so the specified header was ignored.
Mkcert certificate was removed. The browser uses the certificate from the node-modules folder of the project.
I've tried to build a new slate v0 project with just slate default theme and it also doesn't reload browser. It seems like the browser wasn't using any certificate from node-modules before I've tried Slate v1. I just have no idea how to force browser not to use any certificate.
Thank you.

@radmedov if you're in MacOS, try opening the Keychain Access app and deleting any cert referencing localhost?

@t-kelly, I did removed it immediately I got back to Slate v0. Sorry if I wasn’t clear at the beginning. I did remove all related to the Slate v1, re-install node.

You can still use Slate v0 + LivePage Extension. Just make sure to set up the poll for updates more than 1500ms.
OMG! Just tried LivePage Extension and it works with any configuration! Thank you!

Ran into this issue a well. I've ended up "solving" it by copy pasting node_modules from a .13 project into a .14 project. And I say "solving" it because I still need to hit CMD + Save a few time before it reloads with the changes.
And this all started happening after trying 1.0.0 beta and slate 0.14.0


Accessing WPF resources via relative vs fully-qualified URIs

As far as I'm aware, the following are equivalent in WPF:
Uri uri = new Uri("/PageResourceFile.xaml", UriKind.Relative);

and
Uri uri = new Uri("pack://application:,,,/PageResourceFile.xaml");

Is there any reason to prefer one over the other? If not, it would be helpful to update this page to indicate that they are indeed equivalent.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a45ab2e-2d6e-7953-91a3-015ad4a532e5
Version Independent ID: 93ebea65-7df0-6535-732c-03079780305b
Content: Application Resource, Content, and Data Files - WPF .NET Framework
Content Source: dotnet-desktop-guide/framework/wpf/app-development/wpf-application-resource-content-and-data-files.md
Product: dotnet-framework
Technology: dotnet-wpf
GitHub Login: @adegeo
Microsoft Alias: adegeo

@IanKemp Hello! Really one of the links in the article explains more about it; https://docs.microsoft.com/en-us/dotnet/desktop/wpf/app-development/pack-uris-in-wpf?view=netframeworkdesktop-4.8
As with any URI, if you don't use the scheme+authority scheme://authority/path then the URI just represents the path of the resource, not where it's hosted. For example, if you used /PageResourceFile.xaml with an HTTP web object, it probably infers the final path of http://whatever-current-authority-you've-been-using.com/PageResourceFile.xaml which wouldn't go anywhere and probably be an error. The WPF content loader uses:

Scheme
pack://
Authority
application:,,, (which is really application:/// but the / needs to be encoded with , to be compliant with standards

So the WPF loader can infer it's own scheme+authority (much like an HTTP web object might) on the URI making /PageResourceFile.xaml and pack://application:,,,/PageResourceFile.xaml resolve to the the same place.


Cleanup, more about ordinals

Fixed some bugs on meta pats, added some lemmas about ordinals

Improved handling of missing bind patterns!!
bors r+


Invalid Signature - provided signature does not match

Hi,
I am getting an invalid signature exception (400) using the Setup for the old WooCommerce API v3 example in the documentation (getting a 404 with the P REST API, but that's a separate issue).
I read up on all related issues & solutions regarding woothemes API I could find , but  I am not able to figure out what is going wrong. Any pointers?
. {"errors":[{"code":"woocommerce_api_authentication_error","message":"Invalid Signature - provided signature does not match"}]}
string_to_sign =
GET&http%3A%2F%2Fdigitalsystems4dev.com%2Fwc-api%2Fv3%2Fproducts&oauth_consumer_key%%26oauth_nonce%%26oauth_signature_method%3DHMAC-SHA256%26oauth_timestamp%3D1463680922
query_string = oauth_consumer_key=c***&oauth_timestamp=1463683292&oauth_nonce=750657abcf2e03a85fd1acfb965d806be291daca&oauth_signature_method=HMAC-SHA256&oauth_signature=UKdq5Vm0YDTmZ2LtnKj2%2F%2FIrrYRj3MCRytJt0VQ7ZZ4%3D
URL
http://digitalsystems4dev.com/wc-api/wc/v3/products?oauth_consumer_key=ck_8d60fb00cc4c1a7da8df182c01f6aaa24eabb423&oauth_timestamp=1463683474&oauth_nonce=cbb609be40c3eb5a0d99213d3a79cd3559ffade7&oauth_signature_method=HMAC-SHA256&oauth_signature=idndeHBygNPp2KMVQpedb6SkDJ8PB4UHWLKlbhr8wiI%3D

I tried the same with a SSL domain on bluehost (rather than godaddy as above). I am getting a 400 as well.
When I use curl, the test product comes back correctly: curl https://www.example.com/wc-api/v3/orders  -u consumer_key:consumer_secret

Turns out I was using version="wc/v3", but connected to the  old WooCommerce API v3. As a result, the URL had wc/v3 in the path which doesn't exist https://kashalife-beta.com/wc-api/wc/v3/products

For the old API we can use one version="v3"


Add TDEBYOK api swagger files for serveroperations and MIoperations

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kingsleyAzure sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can one of the admins verify this patch?

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Please take a look, Thanks !

@kingsleyAzure are you still follow this PR? Could you help fix the CI errors?

I am still working on it

How Can I fix this prettier check thing ? I tried tutorials here and not working:
https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md


cmake failed on master branch

What platform are you using? (please provide specific distribution/version in summary)

Linux

32 and/or 64 bit?

64-bit

What build system are you using?

cmake

Summary of Issue
make failed when building the master branch using cmake
Steps to reproduce the behavior
% gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
% cmake --version
cmake version 3.7.2
% cmake ../netcdf-c -D"ENABLE_NETCDF_4=OFF"
% make
[  1%] Building C object libdispatch/CMakeFiles/dispatch.dir/dparallel.c.o
In file included from netcdf-c/libdispatch/dparallel.c:10:
netcdf-c/include/ncdispatch.h:111: error: redefinition of typedef 'NC_Dispatch'
netcdf-c/include/netcdf.h:515: note: previous declaration of 'NC_Dispatch' was here
make[2]: *** [libdispatch/CMakeFiles/dispatch.dir/dparallel.c.o] Error 1
make[1]: *** [libdispatch/CMakeFiles/dispatch.dir/all] Error 2
make: *** [all] Error 2

In netcdf.h you need to replace
typedef  struct NC_Dispatch NC_Dispatch
with
struct NC_Dispatch;
and then replace all subsequent argument with type NC_Dispatch to
"struct NC_DIspatch"


Accept --release and build in release mode when provided.

Thanks.
That AddGccReleaseFlag is hacky. I'd prefer if you use an if directly when building the command.
However I'm ok with this code as is if you add a TODO comment to say it should be changed.

That AddGccReleaseFlag is hacky. I'd prefer if you use an if directly when building the command.

I started with ifs, but it was much more verbose, due to the fact that the TermCmds are never given a var name. Using the traits as I did allowed me to keep the TermCmd building inline.
I'll add a TODO.


Example - Gravities of the Solar System

PR Checklist
If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

[ ] Did I update CHANGELOG.md with whatever changes/features I added with this PR?
[x] Did I make sure to only change the part of the file where I introduced a new change/feature?
[x] Did I cover all corner cases to be close to 100% test coverage (if applicable)?
[x] Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
[x] Did I properly add test dependencies to the test directory (if applicable)?
[x] Did I check relevant tutorials that may be affected by changes in this PR?
[x] Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #360
How did you address these issues with this PR? What methods did you use?
Not sure if you would like to bump the version in the CHANGELOG.md just for an example.
Otherwise, the code in this PR is just for a new example. The example has been added to the repos /examples folder as well as the Examples in the docs. Below is an example of the finished animation!

Hey people. This PR Looks really solid!

However it might make sense to try it out without it first and learn the best approach of how to make it internal later on.

I can't agree more @Wikunia. Before having some rigid math/physics/any computational stuff it would be better to have multiple examples before hand. We could divide and exand the examples sections though(based on domain). Also I would love to see how we can possibly integrate other physics based/domain specific packages from the julia package ecosystem since those will be much more performant and also save us time.


Create a new job that pushes origin-gce in dockerhub

Or update the existing job that pushes releases in dockerhub to also push origin-gce (if that makes sense).
@jhadvig @smarterclayton @stevekuznetsov

zz-origin-gce is the gate that prevents openshift-ansible changes from
impacting jobs, by controlling  when a new origin-gce image containing new
openshift-ansible code is added.  It's probably better to be a different
job.
On Mon, Jul 31, 2017 at 6:06 AM, Michail Kargakis<EMAIL_ADDRESS>wrote:

Or update the existing job that pushes releases in dockerhub to also push
origin-gce (if that makes sense).
@jhadvig https://github.com/jhadvig @smarterclayton
https://github.com/smarterclayton @stevekuznetsov
https://github.com/stevekuznetsov
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/aos-cd-jobs/issues/474, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p-3rWjVxABO6QrL5CGsyZQTnWVssks5sTacigaJpZM4OoKxT
.


Fix dependencies

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

tools/office-cmdlet-updater/constants/commands.js
:white_check_mark:Succeeded

tools/office-cmdlet-updater/services/cmdlet.dependencies.service.js
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Customization of ValidateDataStep

Hi there,
Just wondering is there anyway to modify the ValidateDataStep as attached screenshot? Basically I need to add a check All checkbox and move the "Delete Selected Rows" button to the bottom.
Thanks,
Quentin

Hey, sorry for a late reply. Sadly, the only way to achieve this would be to fork the project as the requirements are too unique for us to add to the project.


bug fix: Load the page for the first time, show ribbon

Bug fix: call e() function without set the targetA = true.

@voiddog tnx!


GO: 852. Peak Index in a Mountain Array

File(s) Modified: 852-Peak-Index-In-A-Mountain-Array.go
Language(s) Used: Go.
Submission URL: _https://leetcode.com/submissions/detail/774496479/_

Thanks, @MaratKhakim!


allow decimal and/or fractional degree entry on the rotate/zoom dialog

Description
I attempted to do a fractional/ decimal rotation and the entry box only appears to allow integers. the "." and "/" characters are not allowed.
Additional context
from @cameronwhite
cameronwhite
Nov 17, 2024
Maintainer
Ah, it seems like the fractional rotation is working the master branch, so this must have changed at some point while porting Pinta to GTK4. Testing Pinta 2.1 it indeed only accepts integers

Since this is already working in the master branch, most likely this will just wait for the next major release since I'm not currently planning a 2.1.x minor release


Update pyproject.toml

Update osc-ingest-tools so that we can use SqlAlchemy 2.0.
Other OS-Climate repos can decide when and if they want to follow suit.  Since these tools are anticipated to run in their own virtual environments (at least for now), there shouldn't be a lot of version conflict.  Data pipelines that do feed ITR (and might be running in the same virtual environment) can be trivially updated by replacing patterns of the form:
    engine.execute(\"select * from essd.regions\").fetchall()
with
    with engine.begin() as cxn:\n",
        qres = cxn.execute(text(\"select * from essd.regions\")).fetchall()

Note the call to text as we cannot pass raw strings to execute (to better protect against SQL injection attacks).

So this failed in part because the pdm.lock file is out of date, and pre-commit run -a doesn't fix that.


Next Steps link goes back to same page

[Enter feedback here]
The Next Steps link is for the current page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43125fc1-f1fb-fa8c-69a6-7866a1b3a1fe
Version Independent ID: 174dbe2c-7469-a63a-ffd6-757272ce5c50
Content: Activate my Azure AD roles in PIM - Azure Active Directory
Content Source: articles/active-directory/privileged-identity-management/pim-how-to-activate-role.md
Service: active-directory
Sub-service: pim
GitHub Login: @curtand
Microsoft Alias: curtand

One more comment, the paragraph in the "Determine your version of PIM" section that starts with:
"Beginning in November 2019" - is that the correct year? The date of the article shows 11/28/20.
Just wondering

One more comment, the paragraph in the "Determine your version of PIM" section that starts with:
"Beginning in November 2019" - is that the correct year? The date of the article shows 11/28/20.
Just wondering

@cchapin-ms
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@cchapin-ms
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Hi @cchapin-ms
Thanks for the feedback!! The link is fixed in PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/160472
The year is correct. I'll check to see if the customers that we were accommodating still depend on the text.
#please-close


Please make breaking changes more apparent

This commit: https://github.com/surveyjs/surveyjs/commit/df88fba62e14feeea7a15368308573f65c163ecd which moved questions from questions to elements within the survey JSON was a breaking change for us, which was surprising since we were upgrading from 0.12.1 to 0.12.18 which is patch-level versioning according to semver.
I know that technically since this library is not on a 1.0 release yet nothing should be stable and anything can change, but there's nothing about breaking changes in the changelog and it would be really really handy to have that listed somewhere.
Thanks for a good project, though! And maybe look at something like https://github.com/conventional-changelog/conventional-changelog

@c0bra To be honest I hate breaking changes myself. I know how painful they are. That is why, I have written a code to make sure all old json are working and "questions" property is still there, as well as addQuestion/addNewQuestion methods.
I have rename the methods for "QuestionRowModel" class. However, it is for internal use. I still did not remove questions property from there:
    public elements: Array<IElement> = [];
    //TODO remove after updating react and vue
    public get questions(): Array<IElement> { return this.elements;}

Do you use this class? It uses in SurveyJS Editor during drag&drop. That's why I have made it public/export.
Thank you,
Andrew

@c0bra, thanks a lot for your interest and for the "conventional-changelog" link. We'll think about it.

@andrewtelnov so I'm taking the JSON from the editor and storing it in a database. I believe I'm manually pulling the JSON from the editor via the .text property, so some stuff pre-upgrade is under questions and post upgrade it's under elements. I think the survey.js front-end works fine.
However I have some aggregate reporting tooling that was processing survey result information and that was using the raw JSON by itself and relying on the questions prop. If I had dumped that into an instance of the editor and used the API it probably would have saved me. I just didn't consider doing that.

@c0bra Yes, you are right. "questions" will be converted to "elements" on survey serializing.
Ok, we  had to create a breaking changes page or something like that.
Thank you,
Andrew

@andrewtelnov Thanks very much for your response. Cheers!


[TypeChecker] Disallow if #unavailable to produce different opaque …

…result
Only if #available conditions should be allowed to produce a different
underlying type for opaque result to support backward deployment.

@swift-ci please smoke test

@swift-ci please smoke test Windows platform


I want to mark existing address as default shipping address So I do not have to choose it every order

Context
There is a special flag in the addresses, which is Default Shipping Address. I want to be able to set existing address as the default one for the shipping.
Acceptance Criteria

In My Addresses link I can see the possibility of setting an address as default shipping address.
I can see which address is currently set as default shipping address.
After I change the default shipping address then I can see the flag at the new default shipping address.
Default shipping address is used by default in a checkout.

It was already done.


Duplicated files in releases

Prerequisites

[ ] I am running the latest version. (up upgrade)
[x] I searched to see if the issue already exists.
[ ] I inspected the verbose debug output with the -v, --verbose flag.
[ ] Are you an Up Pro subscriber?

Description
This is actually not an issue (feel free to ignore it), but something unexpected.
The LICENSE and Readme files are duplicated in the releases, I don't know if you aware of that? I guess that can become an issue at some point.
In practice the files are overridden when you extract the tarball.

Love Up?
I love you TJ
Slack
Join us on Slack https://chat.apex.sh/

Yeah that's expected, the duplicated files are overriden.
I noticed that by looking at the header where it seems that you have duplicated entries (I'm not even sure who it's possible).
Might be worth pinging the goreleaser folks? As I said it's probably not an issue for you.

closing for now since it doesn't harm anything :D

Yeah sure lol


Edge Device Examples

Apart from CLI, it will help for the community to get real edge device example such as Arduino or Rasberri

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0c550f7-328c-7d5d-0594-e0bb7ac9cb7a
Version Independent ID: ce2d86b7-e3ca-a7c9-9fef-43631f6f7fdb
Content: Control a device from Azure IoT Hub quickstart (Node.js)
Content Source: articles/iot-hub/quickstart-control-device-node.md
Service: iot-hub
GitHub Login: @dominicbetts
Microsoft Alias: dobett

Hello @ajiteshg and thank you for taking the time to provide feedback :)! Please let us know if the documentation here - Azure IoT Hub get started with physical devices tutorials - is what you were searching for? If you have other ideas for samples let us also know and we will make sure that the right people look into it!

Hi @ajiteshg just checking if we can help you further on this issue\suggestion? Thank you!

Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Sam/pgrx 0 11 3 support

What kind of change does this PR introduce?
I discovered that on some distros (not just in nix builds) that aarch64-linux builds of our psql_15 bundle were failing due to this issue
https://github.com/pgcentralfoundation/pgrx/issues/1429#issuecomment-1852730951
The problem was fixed in rust-nindgen and then ported to pgrx 0.11.3
We updated pg_graphql, pg_jsonschema and supabase-wrappers to use 0.11.3, tested directly  on x86_64-linux and aarch64-linux (including assuring that nix flake check -L --all-systems passes on both systems)
Updating to 0.11.3 required a bump of nixpkgs-unstable which is found in the changes at https://github.com/supabase/postgres/compare/sam/pgrx-0-11-3-support?expand=1&template=default.md#diff-216b2b7bfde9416c79d133bacb031e95702a20bdedb548c0b055c837aa4f6a9c  this is achieved by running nix flake update nixpkgs  , which is tied to the nixpkgs-unstable in our flake https://github.com/supabase/postgres/blob/f0a2e4153022c53e1d82e44f7290a5451c12075e/flake.nix#L5
pgrx 0.11.3 in nix required that we set a var CARGO (in this case setting it to the cargo supplied by nixpkgs see: https://github.com/supabase/postgres/compare/sam/pgrx-0-11-3-support?expand=1&template=default.md#diff-0742481ee07030a8964829237ee62f3a15a7796f0daea6a0361b2b67292eb9abR17 )
I needed to update the gh action workflows to make sure we are not just cross compiling, but actually building on the native machine/platform for each platform we want to support currently (for this pr x86_64-linux and aarch64-linux ).
closes #942

Will need a couple iterations/commits  to resolve gh actions issues


Fix cinder-api logging to stdout

On commit 64a5e288ef977be47fead7941d5489d72142f8f2 we made the logs go to /dev/stdout to make the API service logs not appear as [wsgi:error], but on some deployments we now find that the Cinder-API service returns status code 500 and doesn't work at all.
Inside the API logs we see error:
PermissionError: [Errno 13] Permission denied: '/dev/stdout'
Recurrently looking at permissions of /dev/stdout we find:
[cinder@cinder-api-54859ccfbd-pqxwf ~]$ ls -la /dev/stdout
lrwxrwxrwx. 1 root root 15 Jun 28 19:41 /dev/stdout -> /proc/self/fd/1
[cinder@cinder-api-54859ccfbd-pqxwf ~]$ ls -la /proc/self/fd/1
lrwx------. 1 cinder cinder 64 Jun 28 20:01 /proc/self/fd/1 -> /dev/pts/0
[cinder@cinder-api-54859ccfbd-pqxwf ~]$ ls -la /dev/pts/0
crw--w----. 1 root tty 136, 0 Jun 28 20:01 /dev/pts/0
Other cinder-services (scheduler, volume, and backup) don't have this issue because they run as root, but httpd doesn't allow to run mod_wsgi as root, so we are running it as cinder, as seen in templates/cinder/config/10-cinder_wsgi.conf:
WSGIDaemonProcess cinder-api display-name=cinder_wsgi group=cinder processes=4 threads=1 user=cinder
This patch does a temporary fix by adding the Cinder user to the tty group before starting the httpd service.
Ideally the cinder base image would be modified to include the cinder user from the start, so a review has been submitted to do precisely that: https://review.opendev.org/c/openstack/kolla/+/887370

/test cinder-operator-build-deploy-kuttl

Ideally the cinder base image would be modified to include the cinder user from the start, so a review has been submitted to do precisely that: https://review.opendev.org/c/openstack/kolla/+/887370

Adding this group in the image would need to be done here https://github.com/openstack-k8s-operators/tcib/blob/main/container-images/kolla/base/uid_gid_manage.sh#L39

I tried this with custom ironic containers which had the ironic user added to the tty. The same issue occurs for me locally when I deploy with these images, so I don't think this approach will work
https://github.com/openstack-k8s-operators/tcib/compare/main...steveb:tcib:ttyironic

/test cinder-operator-build-deploy-tempest

/test cinder-operator-build-deploy-kuttl

I think this doesn't work properly [1] or at least it's not interpreted as it should.
Should we rework this part using the side container approach as done w/ nova? That should be a better long term solution I guess.
[1] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openstack-k8s-operators_cinder-operator/223/pull-ci-openstack-k8s-operators-cinder-operator-main-cinder-operator-build-deploy-tempest/1674754162631380992/artifacts/cinder-operator-build-deploy-tempest/openstack-k8s-operators-gather/artifacts/pods/cinder-api-b884b58c6-6sgm6-containers.log

@Akrog @abays @ASBishop I'm in the process of tagging both Cinder and Glance for dev preview as we agreed last week.
I realized that for 4.12+ we might want to land this fix, otherwise we keep seeing cinder-api crushing due to the issue described in the patch (permission denied on /dev/stdout).
However, I'm not sure this patch really addresses it, while the sidecar container solves pretty much the issue.
I have a working patch [1], where basically is the operator responsible to enforce the logging pattern to the container as part of its config (/dev/stdout vs logging file streamed in a sidecar).
As a mid-term approach (to unblock tagging the repos) I'm wondering if it's something acceptable (we might require to revisit the logic in the controllers or we can easily follow up after tagging the repo).
I wanted to mention it here  to make sure you are able to check [1] and unblock the repos tagging during the next week.
FYI Glance is also blocked by Cinder tagging (we recently imported the cinder-operator/api due to the introduction of cinder as a glance backend).
[1] https://github.com/openstack-k8s-operators/cinder-operator/pull/236
[2] https://github.com/openstack-k8s-operators/glance-operator/pull/276

Abandon in favor of sidecar containers (PR#238)


Replace KCP-bind with kube-bind

The main goal of this item is to replace KCP bind with kube-bind, transparently so KS is still fully functional (using KCP workspaces)
We can separate into two different sections/PRs
This work will be done through the branch:  https://github.com/kubestellar/kubestellar/tree/kube-bind

Use kube-bind, continue using the logical-cluster ID when processing the List/Watch objects comings from the Export
Remove the logical-cluster id with space-name coming from an internal mapping of the kube-bind annotation & space name

###Phase1:  Use kube-bind  PR:  https://github.com/kubestellar/kubestellar/pull/1265

the KS container image (used by all KS containers) should include the KB needed executables
Setup scripts that build the ESPW, WDS, and IS should be changed to:

Run dex,
ESPW: Run backend engine + import all KS CRDs + add KB export label + import the KB CRDs
IS, WDS: Run konnector, bind all KS resources

Mailbox controller - create bind for new MBs (can call script) - Note the above is done in the mb-controller container
Need to replace the check on all controllers that verify the export exists
Note: some of the KB components may reside on different containers (e.g., dex and konnectors for MBs) - need to verify access

Phase2: Stop using the cluster-id
Background:
KCP objects have special annotation("kcp.io/cluster") that holds a reference to the cluster. From that reference is is also possible to obtain the workspace. This annotation is set by KCP and will not be available in other providers.
For example, when we use a watch or List over an APIExport using kube-bind, we get a list of objects and such annotation is the only way to know which cluster the object belongs to.

During bind generate a map of [provider NS for the consumer : space name]
Change the relevant controllers code

Notes regarding SM integration:

When spaces are created through the SM, the SM will start the konnector process & (optionally) the backend engine process
When the space-manager will be used, the mapping of the provider NS of the consumer will be added to the space annotation

The two steps enumerated in the opening comment definitely belong in distinct PRs. The first step has no dependency on the space framework and can be taken before any introduction of the space framework. The second step pre-reqs use of the space framework, and can be delayed until some provider other than kcp is used.

@ezrasilvera can this be closed?


Help!!

Nothing happens when i connect

Yeah - I'm getting the same type of thing when I try - but head set still tells me to press the connect button.

For Oculus Quest you can try JackD83's fork.
It works only with Quest, and it has several Quest specific improvements.


Add Customer status type

Preview is available here:http://developers-pr150.previews.kube001.services.stellar-ops.com


[ENHANCE] Jester commands missing/not functioning

Hello!
Here I leave some problem I have since long with AIRIO.. Just for testing when is possible and no rush at all (incredible job about this community)

If I command Jester to be silent,He continue giving "nails" rwr callouts or enemy position. With Yester Wheel no problem. It doesn't work for making him silent and alowing him to speak again.

Switch LANTIRN doesnt work. Even it is is TCS or Lantirn, it won't change between both. With the Yester Wheel no problem

Don't know if this one is in this update. Toggle PDSTT/PSTT do not change from PD STT to PSTT. I go back to the RIO cockpit and always is set PDSTT

Command MAP [1-10] to point 1-3, fix initial etc, works with only some points: (Defense, home base and danger zone). Don't work for points1-3, fix, IP, or surface target. No problem if done in Yester Wheel

None of the RIO Grid options works. Only Radar Stabilize, and Map Mark [0-10] to Grid function. No sectors, no orientate grid, etc... Tested with Yester Wheel and the navigation options works in stabilize grid mode.

These are not from 2.8.. they are from longer... but will revisit again with wheel and not.

These are not from 2.8.. they are from longer... but will revisit again with wheel and not.

Point is we need to identify if these are vaicom or DCS issues. Your number one for instance is not a vaicom issue.

Ok.. updated all.. I removed the internal one.. and these are tested with the wheel (working) and vaicom (not working).
With the laser (not listed) I have an issue. I cannot make it switch off. In the wheel there is an option to reset the lantirn.. and then it switch the laser off.. but with vaicom, I believe there is no lantirn reset... only go to hud or snowplow.. but that doens't turn off the laser.

This is not an enhacement. They are bugs as they don't work as spected and they do work with Yester Wheel. Not something to make them better in future.

This is not an enhacement. They are bugs as they don't work as spected and they do work with Yester Wheel. Not something to make them better in future.

They are things that aren't implemented yet, and therefore aren't bugs but things to add/enhance.

No.. sorry.. they were things implemented in the past.. and at a certain point they failed. These are bugs from a looong time that Holliwood never adressed. Confirmed by users are the map to waypoint and the grid options. I foudn others also.
As said, these ones was working before. If  people didn't use it too much doesn't mean they were not implemented.

Yes some are bugs and some of these commands did not exist previously in Vaicom pro despite being documented. There maybe a reason Hollywood couldn't implement them, we are not sure yet. We will look at the whole AIRIO functions and try to include any missing ones. Thanks for your report. If you don't mind can you let us manage the tags? It helps with workflow and prioritising issues.

sure! thanks a lot for your effort!

Can confirm OP's list as of today and the latest open beta. Two things I'd add:

It would be so much better if Jester's radial menu was still available with AIRIO enabled. That way we could use voice for the commands that work and the menu for the rest.

In the NavGrid setup commands, it would be really nice if the bullseye reference that's available in the menu were also available via a voice command. As it stands, you have to add a map marker over bullseye to set it up via voice.


Hooking and saving process.

You will need to be very organized here, or you will spend all week backtracking. The hooks are pretty straightforward (a dict with a key for each hidden layer). Saving is where I tend to get messy.
Make sure that you keep the probe set separate from the dqn set. For DQN, we have a train/val split. For the separate probe set, we have a train and test split (or possibly some cross validation?) The training of the probes is less important as long as the splits are maintained and  everything is kept very consistent.

Seems like the easiest way to do this without messing with any dqn procedures is to write embeddings straight to a file in the forward loop. Would need a state variable to toggle whether or not I wish to write. (Only turn on for the target dqn, when passing probe set through model)

A note on probe set - will need to pass each train through the probe set to get "final" answer. (So that we are not working with ground truth. Unless I can get optimal action from gym?)

Hooks are live, but batching is unfamiliar. Check.


AZTEC siez limitation ?

Hi,
I think i found a strange limitation in the AZTEC barcode. When there is more than 472 chars in the barcode, it is not readable in 33% error code mode :
...
cab2d := "lsdkfmlkfmlkmkmezlkfmlzkfkezfezmfkkljkljkljflmfkelmfklmfezlfkezlmfkzlmefkelfkezlmfezmlflemkflmfklzfelzkflmfkezlmfkezmlfkzefkemzlfkmlezkfmzelfkezmkfelzmfkelzmfkzelmfkezmlfkezlmkflemzfklmezfkelzmfkezmlkfezlfkelmzfkezlmfkezmfkezlmkflmezkfezlmfkezmlfkezmlfklmezkflemzfkzemlkflzmekflzemfkezlmkfezmlfkezlmfkezmlfkezflmkezmlfelmzkfelmzfkzekflemzfklmezfkflmezklmfkezlmfkezlmfkezlfkelzmfkelzmfkezmlfkezlmfkezlmfklzmefkmezlfklmezkflemzkfmlezkfmlezkfezflkzemflkzemlfkzelmfkmelzfkmlz"
keyAztec := barcode.RegisterAztec(pdf, cab2d, 33, 0)
barcode.Barcode(pdf, keyAztec, posX + 87.1, posY + 66.6, 28, 28, false)
...
=> the generated barcode is not readable.
=> if you delete one character and generate it again, it works again.
Please tell me if i made a mistake.
Thank you very much, excuse my poor english :).

In fact, it seems that the issue happens with a specific value, but i can't tell exactly what data is wrong :
cab2d := "\x1E01\x1D02\x1D0075015\x1D250\x1D801\x1D116A1408809691\x1DGEOP\x1D900138\x1D075\x1Dref sender\x1D001/001\x1D02.00KG\x1DN\x1DADRESSE 3\x1DBEAUVITS\x1D\x1Draison sociale\x1E07\x1DG03\x1D0\x1D0\x1D1\x1D\x1FSOCIETE PRENOM DESTINATAIRE\x1FSOCIETE PRENOM<EMAIL_ADDRESS>1\x1FADRESSE 2\x1DB\x1D002.00KG\x1DSOCIETE\x1DNOM EXPEDITEUR PRENOM EXPEDITEUR\x1Dref sender\x1D\x1D\x1D\x1D\x1D\x1D\x1E07\x1DS010\x1DSOCIETE\x1F0677777777\x1FSOCIETE PRENOM DESTINATAIREADRESSE 3ADRESSE 1\x1FPARIS\x1F75015\x1F250\x1E"
keyAztec := barcode.RegisterAztec(pdf, cab2d, 33, 0)
barcode.Barcode(pdf, keyAztec, posX + 87.1, posY + 66.6, 28, 28, false)

Could you try a different reader? I guess it's either a problem with the reader or the generated checksum is wrong :( I'll have a look at it in a few days.

Indeed, i changed a few characters in the data, and then it worked. It seems to be a problem of checksum. I hope you'll manage to fix this. Please tell me if you need more tests.
Thank you for your work, the library is great !

It seems that the issue is tied to the error correction level algorithm too.


Multi-dimensional Arrays in v0.34 Error

Hi @evaporei looks like I'm running into an issue referencing: https://github.com/graphprotocol/graph-cli/issues/342
I'm successfully able to use codegen and write my handlers fine, but getting an error on build specifically on the multidimensional arrays. Typescript is showing the error for the generated schema as well.
ERROR TS2339: Property 'fromStringMatrix' does not exist on type '~lib/@graphprotocol/graph-ts/common/value/Value'.

     this.set("values", Value.fromStringMatrix(value));
                              ~~~~~~~~~~~~~~~~
 in generated/schema.ts(1300,30)

ERROR TS2339: Property 'fromBigIntMatrix' does not exist on type '~lib/@graphprotocol/graph-ts/common/value/Value'.

     this.set("valuesChance", Value.fromBigIntMatrix(value));
                                    ~~~~~~~~~~~~~~~~
 in generated/schema.ts(1318,36)

Here's the generated code snippet:
get values(): Array<Array<string>> {
    let value = this.get("values");
    return value!.toStringArray();
  }

  set values(value: Array<Array<string>>) {
    this.set("values", Value.fromStringMatrix(value));
  }

  get valuesChance(): Array<Array<BigInt>> {
    let value = this.get("valuesChance");
    return value!.toStringArray();
  }

  set valuesChance(value: Array<Array<BigInt>>) {
    this.set("valuesChance", Value.fromBigIntMatrix(value));
  }

Solidity model:
  struct CanvasTraits {
    string[] urlParams;
    string[] traits;
    string[][] values;
    uint16[] traitsChance;
    uint16[][] valuesChance;
  }

thanks @illestrater, what version of graph-cli and graph-ts are you using? @evaporei any thoughts on this

I'm having this issue as well, more specifically:
Definition in Solidity:
struct A {
   uint256[][] n
}

Error that I get when building:
ERROR TS2339: Property 'fromBigIntMatrix' does not exist on type '~lib/@graphprotocol/graph-ts/common/value/Value'.

         Value.fromBigIntMatrix(<Array<Array<BigInt>>>value)
               ~~~~~~~~~~~~~~~~
 in generated/schema.ts(310,15)

Versions:
    "@graphprotocol/graph-cli": "0.35.0",
    "@graphprotocol/graph-ts": "0.28.1"

example repo https://github.com/boyuanx/Subgraph-Demo
here is the error:

You can use graph-ts version 0.29.1, that will fix the issue :wink:

Hi @evaporei , building now works but when I try to query a 2D array, it shows the following error:
"message": "Feature nested list types is not yet implemented"


[WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1

Is there a reason this is still in WIP?

Is there an approximate ETA for this PR to land? This is blocking the https://github.com/stolostron/submariner-addon repo from bumping other dependencies.

@tpantelis hopefully by the end of week, or beginning of the next week

We're also looking for this to get merged, any updates?

https://github.com/openshift/api/pull/1983 https://github.com/openshift/client-go/pull/291 have been merged today
next one is this PR
cc @gallettilance @tpantelis @mzeevi


2022090801

Closes #7563
Closes #7559
Closes #7554
Closes #7552
Closes #7533
Closes #7532
Closes #7512
Closes #7498
Closes #7496
Closes #7495
Closes #7493
Closes #7417
Closes #7416
Closes #7415
Closes #7414
Closes #7412
Closes #7406
Closes #7405
Closes #7402
Closes #7401
Closes #6451
Closes #6452
Closes #7427
Closes #7399
Closes #7396
Closes #7389
Closes #7384
Closes #7373
Closes #7372
Closes #7371
Closes #7370
Closes #7338
Closes #7337
Closes #7336
Closes #7334

https://github.com/helium/denylist/issues/7533

我已经提供了详细的证据

@Reachmyemail closed because of what? Are you going to make a new one with these tickets? Saw a couple of my tickets were in this list. All about the H3Dex bug.


README problems

Hi, I just found your project and currently reading the README.
I'm raisins this issue just in case you didn't notice, some of the links are missing and the images aren't displaying properly that's all!
cheers

+1 as erralb raised.


Build fails on Ubuntu 22.04 for ARM64

Build fails on Ubuntu 22.04 for ARM64 with error message:
"Compiling bitcoind v0.21.0 error[E0425]: cannot find function download_filename in this scope".

Virtualization: kvm
Operating System: Ubuntu 22.04.2 LTS
Kernel: Linux 5.15.0-76-generic
Architecture: arm64

active toolchain
----------------
nightly-aarch64-unknown-linux-gnu (default)
rustc 1.72.0-nightly (f20afcc45 2023-07-04)

git status
On branch testnet
Your branch is up to date with 'origin/testnet'.
nothing to commit, working tree clean

cargo install --locked --path .
info: syncing channel updates for 'nightly-2022-11-18-aarch64-unknown-linux-gnu'
...
Compiling bitcoind v0.21.0
error[E0425]: cannot find function `download_filename` in this scope
  --> /home/.../.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoind-0.21.0/build.rs:52:29
   |
52 |     let download_filename = download_filename();
   |                             ^^^^^^^^^^^^^^^^^ not found in this scope

error[E0277]: the size for values of type `str` cannot be known at compilation time
  --> /home/.../.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoind-0.21.0/build.rs:67:13
   |
67 |             download_filename, VERSION, expected_hash
   |             ^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
   |
...


Integration slow to load

Home Assistant Version (eg. 2023.11): 2024.04
Ember Mug Component Version (eg. 0.8.0): 1.0.0
Which device(s) are you using for Bluetooth (e.g. Bluetooth Dongle / ESPHome Proxy): ESPHome Proxy

Description
This is a great integration!  However, it is also the slowest (by far) of any of my integrations to load.  I am now even seeing errors in the logs from it.  Anything that can be done to speed it up?  By the way, it is always the slowest and worse when the Mug is outside the range of bluetooth during the restart (e.g. most recently 112s with everything else <10s.
What I Did
Rebooted
Logs / Errors
2024-04-04 08:52:00.382 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: {('ember_mug', 'redacted'): redacted}
If possible/applicable, please enable logging, reproduce the issue and include any related errors below.
This greatly helps with debugging and is much appreciated.
(If you aren't sure how to enable it, please see the debugging section in the README)

Hi! Thanks! Glad you like it.
Hmm, that is quite a long time. Is that the time that's reported in Settings -> System -> Repairs -> integration startup time?
On mine, it is not light-speed, but it is reasonably fast at 4s.

There isn't much that can be done to speed it up from the integration standpoint except if we were to not try to connect to the device, however that would only appease the startup time stats and would prevent one being alerted from actual failures.
Do you have a lot of connection issues in your logs? You might need to enable debug logging. Perhaps your mug is far from the proxy it may have a tough time establishing a connection.

Yes, I took that timing from the screen you noted.  It does seem the time varies ... I just tried 3 reboots in a row and got timings of 22.68, 2.76, and then 22.83s.  No mention of the string "error" in the debug log either.

Yeah, that's because on startup it will try to connect to your device. If it connect immediately it only takes a second or two. However, if it has trouble connecting to your device, like if it's offline, far await, poor signal, used by your phone or something then it will take long as it will keep retrying for a little while.
This doesn't however, impact the availability of your home assistant instance and this happens with many integrations. For example, I use the WLED integration and my lights are outside and have poor wifi so sometimes it takes like 230s to startup.
You won't see an error, but you may might see connection failed. You do need to enable "debug logging" though. You can see the debugging section of the README for more info.
Is your device a good distance from the Proxy or are there things like a wifi adapter or USB 3 cables nearby that could cause interference? The Home Assistant page on Bluetooth has some good tips for connection issues.

Got it - OK, thank you!  Overall, it's working well and I don't think there are phone issues or predictable interference.  Probably nothing to lose sleep over.  Thanks again!


No such module KMPlaceholderTextView

We use your library as pod, but pulling from master branch, since pod spec was last updated 2 years ago.
Recently we started getting this error.
It seems that it is a result of moving source files to Sources folder. Podspec file was not change to accommodate this change.

Fixed in 12cf915155abaf9b98f2af02a7a325c699294104.


Incorrect version of six ?

Hi,
I'm install WAL-E on a fresh installation of Ubuntu 14.04 Server by doing : pip install -e git+git://github.com/wal-e/wal-e.git@#egg=wal-e
Then, I end up with the following error:
nremond@db01:~$ wal-e
Traceback (most recent call last):
  File "/usr/local/bin/wal-e", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2749, in <module>
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 446, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 459, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 628, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: six>=1.7.0

Also,
nremond@db01:~$ pip show six
---
Name: six
Version: 1.5.2
Location: /usr/lib/python2.7/dist-packages
Requires:

Any clue? I'm not so familiar with Python packaging.
Can I provide you with more informations ?
thank you
Nicolas

same as #143, sorry for the noise.


import error: 'assertWrappedQueryRef' is not exported

Hey i'm getting this error when trying to setup client streaming as a provider in NextJS 14.
here is the provider file im using
"use client";

import { HttpLink } from "@apollo/client";
import {
	ApolloNextAppProvider,
	ApolloClient,
	InMemoryCache,
} from "@apollo/experimental-nextjs-app-support";

function makeClient() {
	const httpLink = new HttpLink({
		uri: "https://example/graphql",
		fetchOptions: { cache: "no-store" },
	});
	return new ApolloClient({
		cache: new InMemoryCache(),
		link: httpLink,
	});
}

export function Apollo({ children }) {
	return (
		<ApolloNextAppProvider makeClient={makeClient}>
			{children}
		</ApolloNextAppProvider>
	);
}

if i go check the node_modules i dont see that being exported

solved by upgrading to latest apollo/client


Include "FLUTTER_INSTALL" in PUB_ENVIRONMENT var when running pub upgrade on flutter_tools during install

We're getting a LOT of hits for this tool in our pub telemetry. It gets run A LOT so it really skews our metrics.

See https://github.com/flutter/flutter/commit/358e1cd2e171e81067c9728df7508f0e72a76c3f

Thanks! Would you be willing to send us a PR?

Is this the call in question? https://github.com/flutter/flutter/blob/master/bin/flutter#L84

Is this the call in question? https://github.com/flutter/flutter/blob/master/bin/flutter#L84

Yup.

@eseidelGoogle @sethladd Here's a PR with the "spirit" of the needed changes - https://github.com/flutter/flutter/pull/9670
You don't want me writing bat files.
We could run w/ this now and fix up later – or have one of your shell ninjas run with it.
Whatever...

@goderbauer is probably the only person who you can get to write .bat in a reasonable time. :)
Can you help us understand how important this bug is?

Can you help us understand how important this bug is?

Well, we really want a accurate/fair view of packages that users are really using.
Lots of folks (it seems) try to install Flutter – so much that one-off packages like coverage and json_rpc_2 are showing up as top-20.
I'm going to write some custom logic to exclude clear flutter installs from the list – but having this "baked in" would make my job easier – and make it easier for us to track truly popular packages.

Personally, I don't know why this code wouldn't be written mostly in Dart.
Keeping these scripts in sync seems like a huge cost – and the overhead of calling Dart seems small compared to all of the downloading that's going on...


Placeholder UX tweaks

After #383 gameplay timing adjustment is pushed to the production Feed The Monster, please tag Tinsley and I in the Slack channel. We'd like to do a play through for any additional UX adjustments that may have an affect on engagement.
This task card will be a placeholder (for now) but will contain a bulletpoint list later after the playthroughs and should be included in our May 19th sprint.

Tinsley relayed these to me verbally via Google Meet so I spun up tasks #447-451 instead. Closing this task card.


Added React Store display names to byDisplayName Filter

The "byDisplayName" Filter now supports react store names

I see a few scenarios where blindly calling m.getName might lead to some unintended behavior. You might want to check if the module is a store by making sure m._dispatchToken exists.

BetterDiscord is really good! But Vencord is better

I think that is actually a good idea and I will add that.

I overall don't think this is a good idea. A display name refers to a specific property meant for react components. These days it's not as useful due to the mangling, but it is still a misnomer to apply it to the internal stores.


doesnt scroll up from the bottom

Hi,
thanks very much for this project. It was looking great immediately. But I have a problem.
When I scroll down to the absolute bottom of my page there is a fault behavior. When I click any link there (links to a different position on the same site) there is just a little jump upwards approximately a pixel or so. If I hit the link about 15 times it goes up 1 pixel but then suddenly on the 16th time it scrolls smoothly to the right position.
If I first scroll up a little manually it works on the first click. I couldn't figure out what the problem is. Any advice?

Thank you! This solved it for me.
I've changed easing: 'easeInOutCubic' to easing: 'easeOut'.

@dennisperremans Sorry you had to update your easing method. I'm wondering if there's a weird rounding issue happening or something..

Thanks @cferdinandi and @JonasHavers for the details. I thought I was losing my mind. The easeOut* fix worked for me, too. Thanks again!

`/**

Stop the scroll animation when it reaches its target (or the bottom/top of page)

@private
* @param {Number} position Current position on the page
* @param {Number} endLocation Scroll to location
* @param {Number} animationInterval How much to scroll on this loop
*/
  var stopAnimateScroll = function (position, endLocation, animationInterval) {
  	var currentLocation = root.pageYOffset;
  	 console.log(root.innerHeight + currentLocation);
  	 console.log("espacio "+ documentHeight);
  	if ( position == endLocation || currentLocation == endLocation || ( (root.innerHeight + currentLocation) >= documentHeight ) ) {
  		clearInterval(animationInterval);
  		if ( !isNum ) {
  			anchorElem.focus();
  		}
  		animateSettings.callback( anchor, toggle ); // Run callbacks after animation complete
  	}
  };`

@cferdinandi, Sorry for my english, but I Solve the problem of displacement stop at the bottom deleting de "|| ( (root.innerHeight + currentLocation) >= documentHeight )" of the picture that I attached.  <Line 381>.
If the problem was solved , sorry to bother . I am newbie.

@cferdinandi check deleting the line selected in the img. I can fix the problem of stoping scroll at the bottom.

@bastardesigns That line is needed to prevent an infinite loop from happening if the scroll target is outside of the window.


How large is the training set of RealEstate10K dataset

Hello,
Thanks for your code ! I would like to ask the size of the training images after running your code thorugh the training set. you mentioned that is a huge number but would you share how much TB it would be. I am asking to buy additional hard drive for it.

Hello, phongnhhn92 san
I'm afraid to say that I couldn't answer the accurate size, and it depends on image size which you want to use in your training.
I think that 8TB is much enough, but if you want to knonw more accurate size, you should download 5 or 10% of the dataset.
This would enable you to estimate the size of the whole dataset.
Good luck in your research.
cashiwamochi

Thanks for your helpful reply !
I will close this for now :D


typo: Double word "used"

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mail-flow/Set-RemoteDomain.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Test-PnPOffice365GroupAliasIsUsed.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add a GitHub html_link function

Look at this example from #350 :
unlinted_plists = modified_files.grep(/Localizable.strings$/).reject { |file| system("plutil -lint #{file}") }
fail("#{unlinted_plists.join(", ")} failed to lint with plutil") if unlinted_plists.count > 0

Ideally, we want to have richer fail metadata specifically around linking to files. In most of my plugins I end up writing something like:
github_loc = "/#{current_slug}/tree/#{github.branch_for_head}/#{path}"
message << "#### [#{path}](#{github_loc})\n\n"

Wherein what I really want to have happen is that my path string gets replaced by a clickable URL. This makes it easier to do more with Danger.
I'd propose a new method on Danger that takes either a to_s, or an array of to_s. If it's a string it converts it straight away, if it's an array it loops through them all converting them and adds an & at the end.
thing = "file.json
github.html_link thing   # -> file.json

things = ["file.json", "other.txt", "sure.md"]
github.html_link things   # -> [file.json,
 other.txt  &
 sure.md ]

Then instead I would have wrote:
unlinted_plists = modified_files.grep(/Localizable.strings$/).reject { |file| system("plutil -lint #{file}") }
fail("#{github.html_link unlinted_plists} failed to lint with plutil") if unlinted_plists.count > 0

Happy to change the name, was also considering link_to as I think that's what Rails does?

I've used this code before:
def url_for_path(path)
  commit = github.head_commit
  repo = env.request_source.pr_json[:head][:repo][:html_url]
  path = "/#{path}" unless path.start_with? '/'
  url = "#{repo}/blob/#{commit}#{path}"
end

The nice thing is that it supports PRs from a fork as well.


Wrong picture picked when sharing

Hello,
First of all many thanks for this app, I love it.
Hoping it might help, here is a bug I noticed:
After hiting the "share" icon on a picture I just took, I then choose the mean of sharing (email in my case), then another picture is displayed. I have to go back, pick again the correct picture and share it.
Also I find the time a little long after hiting the "share" button before all the possible sharing options are displayed on a whole new screen... I liked the way quickpic worked for that matter: a small unfolding menu with few sharing options that I usually choose.
Again many thanks

https://github.com/kollerlukas/Camera-Roll-Android-App/issues/135


I need some help here

How to migrate db v4 to v5 ? there is script so how can i acitvate it

@MrTabaOfficial , did you get assistance? I f not;

[ ] add this line to your package.json under scripts, you can reference my package.json

    "migrate-db": "node ./scripts/db-v4-to-v5.js"

[ ] run the following command;

npm run migrate-db

[ ] You should be good to go now! If this resolved your issue, please consider starring my project, happy coding!

@MrTabaOfficial , did you get assistance? I f not;

[ ]  add this line to your package.json under scripts, you can reference my package.json

    "migrate-db": "node ./scripts/db-v4-to-v5.js"

[ ]  run the following command;

npm run migrate-db

[ ]  You should be good to go now! If this resolved your issue, please consider starring my project, happy coding!

I added 2 command Line in Bot.js at once. you cant run script single it need more thing so you must add in main run file

@MrTabaOfficial , did you get assistance? I f not;

[ ]   add this line to your package.json under scripts, you can reference my package.json

    "migrate-db": "node ./scripts/db-v4-to-v5.js"

[ ]   run the following command;

npm run migrate-db

[ ]   You should be good to go now! If this resolved your issue, please consider starring my project, happy coding!

I added 2 command Line in Bot.js at once. you cant run script single it need more thing so you must add in main run file

Actually I did as i mentioned earlier and voila, it worked, but thanks now i know a new approach i can use, cheers


Specify file "location" in addition to "destination"

Hello!
Might be a bit of an edge case/weird setup, and if its not workable -- no worries!
All of my media is stored on a linux server, however my Jellyfin instance runs on a windows machine (as it has more computing oomf). Ideally, I would like to run Sportyfin on my linux box as a Cron job along with my other self-hosted projects.
I have my linux box mounted as a network drive in Windows -- so Jellyfin can access the files on the linux server.
The issue I run into, is that the xmltv file indicates the images are stored where the script put the files (in linux) - which isn't the same file path in Windows.
What would be ideal, is if I could specify to the script where the files can be "located" by Jellyfin - which is different than where the script's output/destination is specified.
e.g. output script files to /media/sportyfin but the created xmltv files say they are actually located at Z:\sportyfin
python3 -m sportyfin -a -s -v -o /media/sportyfin -l z:\sportyfin
Cheers, and thanks for your work on this project!

Thats actually an awesome use case. I will keep this issue open while I work on it! For now I think best case would be to manually edit the files.

Right on -- happy to hear it's well received!


Consider replacing go.chromium.org/luci

This mono-repo is very large, but we're only using a few relatively small features, such as error annotation and context-aware and testable clock.
The luci repo is most useful for Cloud-based apps, but for purely command-line apps it may be an overkill.

Packages actually used:

clock
common/logging
common/errors

clock
The only really useful feature here is testability: clock installs an implementation into the context, and substituting a fake version in tests helps testing time-dependent code in a deterministic way. At this time, it's probably not very useful feature. If some time-dependent code needs to be tested, we can provide a now function as a parameter, or a time value, which can be supplied in tests directly. This should cover most of our needs.
common/logging
It defines a Logger interface, and top-level corresponding methods which fetch a Logger instance from the context and use the appropriate method.
This can be relatively easily replaced with a compatible Logger interface and our own reimplementation of the logging methods. It's useful to keep it compatible with luci, since it implements Logger versions for App Engine or generally Google Cloud.
common/errors
The most useful features here are:

new error creation
existing error annotation
stack capture.

The stack capture is the trickiest feature, but also the one I use the least. Everything else could perhaps be reimplemented in a somewhat simpler way suitable for our purposes.

Technically, we no longer depend on LUCI. However, we still need to implement logging. I'll keep the issue open until that is done.

Closing this issue, as the remainder is tracked in stockparfait/logging#1.


Fix vendor entry for go-codec in vendor.json

FWIW, running govendor update twice didn't seem to fix it, but removing the "origin" entry and running it did.


[Feature] hide clip, thanks, download, report

please give an option to remove the buttons under the player. I use like and dislike, save to playlist options only. it would be great if we could remove all those unnecessary buttons and have the required one only.
the main request is to remove the ones shown directly under the player and replace that position with useful ones like save to playlist.
if you know any extension, please share. I found one script but its not working. Also, this would be a nice addition to nova.
thanks.
i want to use nova extensively, please don't get annoyed as I might post a lot feature requests and report bugs.

do you plan to add them eventually?

this script removed those buttons and placed them in the three-dot menu. but we can't configure anything.

and from unhook extension only these were helpful

An interesting idea is to hide the buttons instead of permanently deleting them

does this take less resources ?

i know basic css and flex box. but it seems pretty complicated. if it is a bit easy for a beginner, can you help me understand it?

this script is great. It removes the downoad button and replaces it with the useful save to playlist button. I use only two buttons lke/dislike and save to playlist. the latest yt UI added one step to reach save to playlist(which we use all the time). please have a look into the images. please implement in this way to nova.
Before:

After:

please add download, clip, report hide options as well, so that save to playlist comes out of the three dot meny

i just need save to playlist button under the player. I was trying add ask all the features I use in nova itself. I'm using another script for this. Thanks for looking into this.

this is perfect

please implement for thanks button as well. with that this issue can be closed. Thanks

https://www.youtube.com/watch?v=b7zBJNmdImo&t=43s
https://www.youtube.com/watch?v=muxq5sQVdlc
https://www.youtube.com/watch?v=Pf8YTpp7B2I
https://www.youtube.com/watch?v=uvNkdAggUGU
https://www.youtube.com/watch?v=Eb7al22iNPc

Wow.

this issue is solved. Thanks


incorrect "accelerator should be installed" warning with APCu

As per https://stackoverflow.com/questions/29187601/difference-between-apc-apcu-and-opcache , APCu is feature-equivalent version of APC for PHP 5.5+, due to OpCache integration in PHP core. As such, the check in https://github.com/symfony/symfony-standard/blob/3.3/var/SymfonyRequirements.php#L717 should
probably be
            ( ( extension_loaded('apc') || extension_loaded('apcu') ) && ini_get('apc.enabled'))
instead.

apcu is not an accelerator as it does not include opcache as you said yourself. So the change you are proposing doesn't make sense.


How do you update/pull/sync with upstream?

Really just curious about your approach for tracking the main codebase for VSCode!

This will be covered by #417.


Fix - TRSV2-346 - Cleaning up email footers.

Removed custom footers in most emails, and updated the default footer to say 'Trade Remedies Authority' and not DIT.
Also hardcoded footer and case email so they're no longer system parameters.

Codecov Report
Base: 51.92% // Head: 51.92% // No change to project coverage :thumbsup:

Coverage data is based on head (906c74f) compared to base (afe736e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #283   +/-   ##
========================================
  Coverage    51.92%   51.92%
========================================
  Files          199      199
  Lines        11143    11143
  Branches      1445     1445
========================================
  Hits          5786     5786
  Misses        5357     5357

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


typeahead: Update activity score computation algorithm for streams.

Earlier, streams were prioritised like this: pinned streams > subscribed streams > other streams, with message volume serving as the tie breaker.
Now we prioritise them like: stream being composed to > pinned unmuted streams > unpinned unmuted streams > pinned muted streams > unpinned muted streams > unsubscribed streams, with the same tie breaker.
Fixes: #20618.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @N-Shar-ma!


arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x …

Targets: Devices using arm/stm32h7x3x_rcc.c
Summary
This adds the option of using an external power supply connected directly to the VCAP pin.
This is necessary if the board designer decides to power the uC through an external power supply, which can help to decrease the temperature, have a stable current delivery, etc.
I kept this modification as simple as possible, so further combinations could be applied as shown in the reference manual RM0399, pages 275 and 329. It also is adapted to requirements shown in RM0433, pages 260 and 307.
Impact
This should have minimal or lack of any impact on present targets, as it's using a new setting built around the existing power options structure, keeping the current configurations untouched.
Testing

Checked correct compilation against nucleo-h743zi and stm32h747i-disco targets, modifying the configuration of settings involved.
Tested in HW with downstream (PX4) using 3DR Control Zero H7 OEM rev G.

Feedback is always welcome!

@xiaoxiang781216 My bad, I just squashed it.

@xiaoxiang781216 @acassis @davids5 Thank you!


feat(plugin-seo): add german translation

Description
Included a German translation file and updated index.ts

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[ ] Chore (non-breaking change which does not add functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Change to the templates directory (does not affect core functionality)
[ ] Change to the examples directory (does not affect core functionality)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Hey @fsyntax im getting an error on merging this

Head branch is out of date. Review and try the merge again.

You might need to check your beta branch, or copy these changes into a new PR and use a feature branch


oauthclient: local account discovery improvement

Uses userEXT table to do a lookup of the external identifier
in order to find the local account corresponding to the user
that logs in using oauth.

Signed-off-by: Javier Martin Montull <javier.martin.montull>

Comments addressed and rebased, please have a look @jirikuncar @lnielsen

@jmartinm looks good to me. :shipit:

@lnielsen good point. Thanks, I have updated the PR storing account_info in the session.
Can you have a look?
And I guess removing the account info from session here https://github.com/inveniosoftware/invenio/pull/2600/files#diff-e35f9879d99b458ee57ff1a2343f249cR140 is the right thing to do? We don't need it afterwards.
I will test this now on a test VM, have a look at the code and let me know if its looks ok.

To follow up, just tried it in a VM and it works as expected.

I have updated the session variable to _account_info

@jmartinm thanks! Do you think you could fix the docstrings at least in orcid.py?
see http://kwalitee.invenio-software.org/inveniosoftware/invenio/branches/d5c31da0c5e8f6947b5402c3519f6d68a1be0f81/jmartinm:local-account-discovery
I guess you can add @lnielsen and me as reviewes.

First apologies for the many iterations on this PR. One last thing I've spotted.
Instead of setting/deleting account_info in the session in contrib/orcid.py, it would better to do set account_info in authorized_signup_handler (here) and retrieve/delete it in signup_handler (here and here) .
Additionally, modify oauth_register() (here) to accept form.data and account_info (passed in here).
This way every service (orcid, github, google, twitter), that uses the signup handler  doesn't need to set and retrieve the account info in the session.

No problem @lnielsen , good suggestion. I will have a look and update the PR.

Updated the PR.

Instead of setting/deleting account_info in the session in contrib/orcid.py, it would better to do set account_info in authorized_signup_handler (here) and retrieve/delete it in signup_handler (here and here) .

I have put the deletion of the session here https://github.com/inveniosoftware/invenio/pull/2600/files#diff-8faf6f61294e068746c7eef9b029a0d1R308 as in some cases (like our orcid handler) one might want to access the account info in the setup handler.

Additionally, modify oauth_register() (here) to accept form.data and account_info (passed in here).

Do you see any advantage on this? Currently the dict gets updated so if we have the same key, e.g. email both from acount_info and from form.data the one from the form will be taken.
Seems to me a bit simpler than modifying the signature of https://github.com/inveniosoftware/invenio/blob/pu/invenio/modules/oauthclient/utils.py#L64 and having to extract keys from 2 different places, but maybe I am missing some advantage.

Do you see any advantage on this? Currently the dict gets updated so if we have the same key, e.g. email both from acount_info and from form.data the one from the form will be taken.

Mainly for security. As it is now it's safe, but it's very easy to introduce unwanted security issues. E.g someone adds a poorly validated form field that overwrites a trusted account info value allowing the end-user to pass in any value. Or, an oauth app sets a value in account_info, and uses it later in account setup, however in-between account info data gets overwritten by form data (since you run account_info.update()).
I would rather be careful in this case, since we're dealing with user authentication and sign up. Hence, being explicit about origin of values makes more sense to me.

Question: what about updating form.data with user_info on https://github.com/inveniosoftware/invenio/pull/2600/files#diff-8faf6f61294e068746c7eef9b029a0d1R284 ? Is there something what can get wrong?
Example:
data = dict(form.data)
data.update(account_info)

Example

data = dict(form.data)
data.update(account_info)

Problem with this is that, for example, right now here we are returning email=None so the email that the user introduces in the signup form would be updated to None.
If there is no other suggestion I will update later today the PR and modify the function to accept the two parameters.

we are returning email=None

IMHO you don't have to add None values to account_info. The usage looks safe.

IMHO you don't have to add None values to account_info. The usage looks safe.

Yep, in my case I agree, it is not needed and I will better remove it.
As the email=None was there before I am wondering if in the future somebody writes its own account_info it might happen that they pass email=None or email="" and be surprised by the signup form email not being used (if we go for the   data.update(account_info))

I think the simplest is just adding the two parameters to oauth_register, then there's no doubts.

Updated and tested one more time ;)


Preload(), and memory leak.

Hello.
I am using Xamarin Forms + Prism. I found that my app is not freeing memory taken by CachedImage, when View is closed.
When view is opened, I am preloading all images like this:
 try
                {
                    var task = ImageService.Instance.LoadUrl(url, TimeSpan.FromDays(1));
                    task.WithCache(FFImageLoading.Cache.CacheType.Disk);
                    task.BitmapOptimizations(true);

                    await task.Success(() =>
                    {
                        Device.BeginInvokeOnMainThread(() =>
                        {
                            LoadedImages.Add(url);
                            RemoveLoadingReference();

                            // Load first image from list
                            if (ImageUrl == null)
                            {
                                Position = 0;
                            }

                            OnPropertyChanged(() => PositionText);
                        });
                    })
                    .Error((info) =>
                    {
                        Device.BeginInvokeOnMainThread(() =>
                        {
                            RemoveLoadingReference();
                        });

                    }).PreloadAsync();
                }

And my CarouselViewControl item template looks like this:
          <ffimageloading:CachedImage
            HorizontalOptions="CenterAndExpand"
            VerticalOptions="CenterAndExpand"
            Aspect="AspectFit"
            DownsampleToViewSize="False"
            Source="{Binding .}">
          </ffimageloading:CachedImage>

I was testing this on iOS, and Android, and memory was not released in both cases. I was trying to call ImageSerice.Instance.InvalidateCacheAync, but it was freezing my app when called more than one time.

ImageSerice.Instance.InvalidateCacheAync was freezing my app, but using ImageService.Instance.InvalidateCacheEntryAsync(url, CacheType.Memory); is freeing memory. So issue can be closed.

Hi @ziomagic

You must use Preload with caution as device resources are finite.
"Not freeing memory" is what Preload method is all about, it caches bitmaps in RAM for a quicker access in future.
Consider using DownloadOnly instead.

My ios app also freezes when calling ImageSerice.Instance.InvalidateCacheAync. How to fix it?

@aucompany Could you write more details? How many images? What platform? Sample code?


Show progress hint in the task bar

As stated in https://github.com/godotengine/godot/pull/5560#issuecomment-231595959

I was able to make this work on Windows. For OSX there's NSProgressIndicator.
What I'm not sure is what should be the API for this though. I want to be able to set a ProgressBar or TextureProgress as "default" and make that show in the hint. Still, there's a need to enable/disable the hint at some point, as the OS API doesn't handle that automatically.
For Windows there's also error and pause states, I'm not sure if other OSes can handle that.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Token wrapper

Same as https://github.com/721labs/partial-common-ownership/pull/45 (which closed accidentally) and rebased on origin/token-wrapper.
Implements:
new deterministic unique wrapped token Id
a simple test
And re-ordered some test files. There is now a Test721PCOToken.sol, Test721Token.sol (without PCO functionality) and Test721Wrapper.sol

I hope you forgive some of the code style (variable name underscores, ordering, keeping it DRY) and missing tests, please let me know first if you think the architecture looks good! :)

Heads up: we're currently using Yarn as the package manager, and that's why there's no package-lock.json file presently.  Please remove package-lock.json.


reorganized content in ts and FAQs section and added new CICS questions

Signed-off-by: RadhaV2020<EMAIL_ADDRESS>

Some minor issues with hyperlinks exist in this PR. Will be fixed in the next commit

fixed the hyperlink issues, moved the CICS troubleshooting question under the TS section per the CICS team's ask.


Fix checking for permission when package is uploaded by a collaborator with lower perms

E.g. collaborator reader cannot package a project, since the last step of the package job: uploading the files, fails.

Task linked: QF-2094 Collaborators cannot package


[BUG] Mismatched Quirk: A19TunableWhite without model info (and Osram RGBW Outdoor Flex)

Describe the bug
Someone mentioned on the Hass Discord in #zigbee that a OSRAM Lightify Outdoor Flex RGBW always got a wrong quirk: A19TunableWhite. This quirk removes the colorwheel (since #488) (which is needed for a RGBW led strip).
This happens because the quirk (https://github.com/zigpy/zha-device-handlers/blob/dev/zhaquirks/osram/a19twhite.py) never included any "MODELS_INFO" and the signature matches exactly between those two devices.
It's also possible that further OSRAM devices also match and thus don't show the color wheel.
A solution to this seems like to add the proper model (and manufacturer info) to the quirk.
(Or is there a reason this quirk doesn't include any model info at all? If not, perhaps a test that every quirk has at least one model in MODELS_INFO would be a good idea?)
To Reproduce
Steps to reproduce the behavior:

Bind a OSRAM Lightify Outdoor FLEX RGBW to ZHA
Try to change the color using Hass
See color wheel missing

Expected behavior
The OSRAM A19TunableWhite quirk doesn't apply for the RGBW light.
Additional context
(The user on Discord with this issue wanted to submit an issue, but it seems like that didn't happen after multiple days.)

It is better if it included model and manufacturer

@danielbrunt57 Do you have the device signature of the A19TunableWhite OSRAM light?

{
"node_descriptor": "NodeDescriptor(byte1=1, byte2=64, mac_capability_flags=142, manufacturer_code=48042, maximum_buffer_size=64, maximum_incoming_transfer_size=0, server_mask=0, maximum_outgoing_transfer_size=0, descriptor_capability_field=3)",
"endpoints": {
"3": {
"profile_id": 260,
"device_type": "0x0102",
"in_clusters": [
"0x0000",
"0x0003",
"0x0004",
"0x0005",
"0x0006",
"0x0008",
"0x0300",
"0x0b04",
"0xfc0f"
],
"out_clusters": [
"0x0019"
]
}
},
"manufacturer": "OSRAM",
"model": "LIGHTIFY A19 Tunable White",
"class": "zhaquirks.osram.a19twhite.A19TunableWhite"
}
Thanks,
Daniel
From: TheJulianJES<EMAIL_ADDRESS>Sent: October 25, 2020 9:10 AM
To: zigpy/zha-device-handlers<EMAIL_ADDRESS>Cc: Daniel Brunt<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [zigpy/zha-device-handlers] [BUG] Mismatched Quirk: A19TunableWhite without model info (and Osram RGBW Outdoor Flex) (#536)
@danielbrunt57https://github.com/danielbrunt57 Do you have the device signature of the A19TunableWhite OSRAM light?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/zigpy/zha-device-handlers/issues/536#issuecomment-716171799, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL4JU3LIFBYVKPRKWVECJWDSMREWHANCNFSM4S5I2A7A.

Created PR #543 that just adds the model info, so the A19TunableWhite quirk isn't applied to other Osram RGBW products (thus not removing the color wheel for them anymore).

My apologies for introducing a bug with PR #488 ...

@danielbrunt57 The bug wasn’t introduced in your PR. It just so happens that now everyone notices that the quirk was missing the MODELS_INFO, as the RGB Color wheel was gone.


Main queue replaced with custom serial queue

Adjusted for swift3 as mentioned in #242

it looks like this was not merged to master


Large CPU usage in FireFox

Every animation(tested on your demos) in Firefox use CPU like 5x more than in Chrome, Opera(up to 40%).
My cpu is Ryzen 1500x.
Firefox 74.0(x64)
FireFox Developer 75.0b12(x64)
Both are fresh installed

Hi there. Thank you for letting us know. I will investigate but these browser specific issues can be hard to fix.

Hi folks, I'm starting to look into this as part of some perf work on my own app. The perf difference is pretty astounding, the same animation frames is processed in less than 5ms on Chrome, while Firefox take over 20ms, sometimes close to 30ms.
I've recorded and published a profiler session of the ptsjs home page on Firefox here. By looking at it, DOM operations are taking 74% of the CPU time on frame requests. To see that, check the call tree, select FrameRequestCallback and open the side panel on the right.
I've then done the same in Chrome. You can open it by going here. Note that this link only works on Chrome.
Comparing the recordings is not easy as both browsers are not recording the same thing. The easiest I've found is comparing Firefox's stack chart to Chrome's "Main" graph. There I'd advise to zoom or select a part of the timeline that covers a single animation frame request. The ones I've zoomed in take respectively 19ms and 5ms. The difference seems to come from the large blue blocks (DOM) in Firefox which do not seem to appear at all on Chrome. I'm not sure if the performance is really drastically different or if the browsers are just not recording things the same way. If they are indeed comparable, then it would seem the difference is at the DOM level, so nothing pts can do anything about.
I've tried further to focus on pts operations (JS not DOM) and get a sense of time spent. In this particular animation, perpendicularFrom is a time consuming pts calculation which doesn't involve rendering. By looking at the Call Tree in Firefox, we can find it and it has a total runtime of 2ms during a single animation frame. On the Chrome side, I've used the Bottom-Up tab and found that it has a total runtime of 1.7ms. That difference seems irrelevant compared to the order of magnitude found previously, I'd say it points to pts performance being browser agnostic.
Has anybody tried to run some other comparisons or measurements?
I'll try to get in touch with people at Mozilla to see if we can get eyes on this and ideas. Anyone else tried that?
Cheers.

Hi @tibotiber, I'm the product manager for Firefox performance. Thanks for investigating and capturing the profile. Most of the time seems to be spent in CanvasRenderingContext2D.stroke. I don't see an existing issue for this or a similar problem in Bugzilla (our issue tracker). Could you file an issue in Bugzilla to get it into our triage queue?

Thanks @ecsmyth, I've reported this, here is the ticket. I also linked in there other tickets that are related to this issue. 🤞 for now and happy to help, test, anything that can move this forward.

Thank you so much @tibotiber and @ecsmyth for investigating this issue! 🙏


How to listen /command@bot in supergroup?

In supergroup, I can use /command trigger the bot, but /command@bot cannot trigger the bot.

@iVanilla does your bot receive /command@bot message at all?
Could you check in you logs?

@ivanovaleksey No, only received /command.
Where is the logs file path?

Hi @ivanovaleksey, messages are coming. But now bot doesn't triggered by them :(

@iVanilla i think you should set the bot as the admin of the group ... it should works

@iVanilla didn't help :( Incoming messages still coming like /command@bot_name

I don't have very much experience about using bots in groups.
But the situation seems pretty clear.
Let's look at the official documentation on commands:

If multiple bots are in a group, it is possible to add bot usernames to commands in order to avoid confusion:
/start@TriviaBot
/start@ApocalypseBot
This is done automatically when commands are selected via the list of suggestions. Please remember that your bot needs to be able to process commands that are followed by its username.

So, it is totally up to developer how to trigger on a message.
If your bot is in a group and you just check command name (and don't check which bot the command is addressed to) it might be ambiguous situation.
As about ways of "fixing" it.
Yes, the most obvious would be to add switches with explicit bot name.
I guess In Ruby you can even create a nice little wrapper for it.
Also please note that you can check chat's type. For instance
#<Telegram::Bot::Types::Message:0x00007fb1efc264a8
 @audio=nil,
 @author_signature=nil,
 @caption=nil,
 @channel_chat_created=nil,
 @chat=
  #<Telegram::Bot::Types::Chat:0x00007fb1efc25c88
   @all_members_are_administrators=true,
   @description=nil,
   @first_name=nil,
   @id=-101746809,
   @invite_link=nil,
   @last_name=nil,
   @photo=nil,
   @pinned_message=nil,
   @title="Home chat",
   @type="group", # for direct messages it would be "private"
   @username=nil>,
 @contact=nil,
 @date=1509222289,
....

Maybe I can use it somehow.

@GanjMonk hmmm can you show us your source code ?(i mean a little bit ...) maybe you typed something wrong ..

@eVanilla, sure.
This code doesn't work if command sent from Group Chat  /start@bot_name
Telegram::Bot::Client.run(token, logger: Logger.new($stdout)) do |bot|   begin     bot.listen do |message|       case message.text        when '/start'          message_text = "Hi #{message.from.first_name}, here is a list of commands: \n         /calls - _List of calls_ \n         /duty - _Duty list_ \n         /requests - _Requests statistic_"         bot.api.sendMessage(chat_id: message.chat.id, text: message_text, parse_mode: 'Markdown')
This code works if command sent from Group Chat  /start@bot_name
Telegram::Bot::Client.run(token, logger: Logger.new($stdout)) do |bot|   begin     bot.listen do |message|       case message.text        when '/start', **'/start@bot_name'**          message_text = "Hi #{message.from.first_name}, here is a list of commands: \n         /calls - _List of calls_ \n         /duty - _Duty list_ \n         /requests - _Requests statistic_"         bot.api.sendMessage(chat_id: message.chat.id, text: message_text, parse_mode: 'Markdown')

@GanjMonk hmmm something is wrong ... use this send_message instead of this sendMessage

@eVanilla it works the same.
As @ivanovaleksey said it's up to developer how to trigger on a message, so I think we can close this issue.
Thx for help.


Integration with AdonisJS

Hi everyone
Did someone try to connect the bull board into AdonisJS?
AdonisJS is based on top of express js, so seems there should be a way to do so
Here is a doc for Routing https://adonisjs.com/docs/4.1/routing
If someone can help - will be much appreciated

I've reviewed adonis.js api, it's router is not based on express, you can write small adapter (proxy) handler between adonis => express.
Each express router (the thing that we export) has .handle(req, res) which gets express req & res.

Hi @felixmosh, i am using AdonisJS (v5) and is there an example of what the adapter between adonis => express should look like?
I need to show bull-board on an authenticated route, handled by Adonis router.
😄

Hi @felixmosh, i am using AdonisJS (v5) and is there an example of what the adapter between adonis => express should look like?
I need to show bull-board on an authenticated route, handled by Adonis router.
😄

Unfortunately, I'm not familiar with Adonis, so I can't help with it.
If you be able to create such adapter, I will more then happy to add an example with Adonis.js 🙏🏼

Since v3.0.0 it is easy task to write adonis.js adapter.
Ping me if you need some help :)

I've spent couple of hours into writing an AdonisJs v5 adapter. It's not an easy task at all.

Unfortunately AdonisJs doesn't have a way of setting a rendering engine, so this means it's impossible to use ejs templates without porting them into adonis' edge templates.

Error handling is very different at adonisjs, you don't catch errors defensively. It doesn't fit like it does with other micro frameworks. Workaround is there, sending an error response manually.

ServerAdapter interface needs at least jsdoc explanations. Instead of using a constructor method you implement ton of public methods but the adonisAdapter end users would never need any of the methods. Proper information hiding would hint authors how to implement the adapter.

@brkn thank you for your input. I'm not familiar with adonisjs. If you want to collab on it, i'm available to chat in discord.

This is how I've integrated if anyone is interested. https://github.com/brkn/adonis-bull-demo-app/pull/1
Once you create an alternative to index.ejs template like bull_board.edge, rest is straight forward.


Composite fields json support

This PR add support for importing / exporting json specs that have composite fields.
I've made the configuration for the builders public so users can specify any custom mappings they might have.

@Lukepmcauley, currently, we have Inspect method for Prefixer and Padder. But we don't have it for Encoder and StringSlice. Our initial assumption was to use Inspect for JSON serialization, describe, etc. features. But as far as I see, now we use it only in spec.Builder and for things that don't have it, we use maps like encodingsExtToInt, encodingsIntToExt. As result, we have a mixed approach to a string representation.
What do you think about removing Inspect method at all, revering StringSlice changes, and just using maps/functions to get string representation inside spec.Builder for everything? It will streamline how we get a string representation and may reduce the number of changes required in the future.
One drawback of such change is that it's an API-breaking change (removing Inspect() method).
Thoughts?
@krishishah @vtolstov

@alovak For the sorts I can revert the changes and use the function name for serialisation.
For the encoders and padders we'd still need some method of serialisation as type name is not enough information to recreate them and the builder doesn't have access to their internals. Any suggestions?

Yeah. I agree. We can't get the meta-information for padder and prefixer. Then, let's keep it as is (with Inspect()) and move the rest into spec.Builder maps. How does it sound?

@Lukepmcauley, currently, we have Inspect method for Prefixer and Padder. But we don't have it for Encoder and StringSlice. Our initial assumption was to use Inspect for JSON serialization, describe, etc. features. But as far as I see, now we use it only in spec.Builder and for things that don't have it, we use maps like encodingsExtToInt, encodingsIntToExt. As result, we have a mixed approach to get a string representation of the “thing”.
What do you think about removing Inspect method at all, revering StringSlice changes, and just using maps/functions to get string representation inside spec.Builder for everything? It will streamline how we get a string representation and may reduce the number of changes required in the future.
One drawback of such change is that it's an API-breaking change (removing Inspect() method).
Thoughts?
@krishishah @vtolstov

i don't use inspect method and i'm ok with breaking changes.

Codecov Report

Merging #129 (6c4f06e) into master (0ae91c8) will decrease coverage by 1.80%.
The diff coverage is 70.94%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   69.21%   67.40%   -1.81%
==========================================
  Files          33       33
  Lines        1192     1304     +112
==========================================
+ Hits          825      879      +54
- Misses        267      309      +42
- Partials      100      116      +16

Impacted Files
Coverage Δ

specs/builder.go
70.58% <70.94%> (-0.59%)
:arrow_down:

field/string.go
67.79% <0.00%> (-9.57%)
:arrow_down:

field/binary.go
47.45% <0.00%> (-7.26%)
:arrow_down:

field/numeric.go
70.76% <0.00%> (-5.90%)
:arrow_down:

field/composite.go
78.80% <0.00%> (-4.65%)
:arrow_down:

field/bitmap.go
68.88% <0.00%> (-2.54%)
:arrow_down:

message.go
68.67% <0.00%> (-1.60%)
:arrow_down:

field/spec.go
62.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae91c8...6c4f06e. Read the comment docs.