Run daily CI in a PR

Do not merge.
This is to run daily CI.

This won't fully cover the cross compile builds.  it will build but not test them.
All lines like this need updating: https://github.com/openssl/openssl/blob/c7ed5e4697a71012e0a2d9dd5eaf997754ae5156/.github/workflows/cross-compiles.yml#L186

@paulidale Updated.

Thanks.

Close/reopen after merge of #22491

Tests (apart from Coverity) passed.
Re-running them all.

All tests (apart from Coverity) passed a second time.

Kick for a third go around.

Third time around is good too.


modify README.md

Hello, avatsaev.
Thank you for ngx-log-monitor. It's useful for me.
I found mistake at README.md, so I open pull request.
Regards,

Thanks for the PR


New integration : lakeFS

.NET Aspire issue link
https://github.com/dotnet/aspire/issues/6508
Overview
lakeFS provides version control over the data lake, and uses Git-like semantics to create and access those versions. See lakeFS.
Usage example
Ability to register a lakeFS container in AppHost and use it as a service in clients project.
Additional context
No response
Help us help you
Yes, I'd like to be assigned to work on this item

Is this a hosting, client integration, or both?

Is this a hosting, client integration, or both?

{
"username": "string",
"key": {
"access_key_id": "AKIAIOSFODNN7EXAMPLE",
"secret_access_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
}
}

Both integrations are required. I am working on it and I will propose something soon but right now lakeFS does not suppot Azurite which does not ease the implementation.

You can find my first attempt to integrate lakeFS at https://github.com/RudyCo/AspireAppLakeFS.
I can't continue working on it because of time constraints but it's a starting point for anyone interested in leveraging lakeFS with Aspire.


mean based on reduce?

Hi,
Do you consider aggregate operations to be terminal - which is why they take a prematerialized list of items, or should they also be streaming? if so, how does this implementation of mean look like?
R.reduce((a,b)=>{ return [((a[0]*a[1])+b)/(a[1]+1), a[1]+1 ] }, [0.0, 0])

And:
> R.map((x)=>x[1], R.reduce((a,b)=>{ return [((a[0]*a[1])+b)/(a[1]+1), a[1]+1 ] }, [0.0, 0]))([1,2,3])
3

I tend to think of reduce as terminal.  That does not prevent you from writing something like that (altered slightly):
const avg = map(head, reduce(
  (a, b) => [((a[0] * a[1]) + b)/(a[1] + 1), a[1] + 1 ], [0.0, 0])
);

avg([1, 2, 3, 4]); //=> 2.5

But I would probably feel better using scan for this, which seems more closely related:
const avg2 = pipe(                    // ... Input [1, 2, 3, 4]
  scan(add, 0),                       // [0, 1, 3, 6, 10]
  tail,                               // [1, 3, 6, 10]
  converge(divide, [last, length]),   // 10 / 4
);                                    // ... Output 2.5

avg2([1, 2, 3, 4]); //=> 2.5

The output of scan already intrinsically contains the length you need here, but it would be easily queried for other desired parameters such as min or max, or even mode, and this could be done  stream-like on every addition to the data set or once when it's complete.

Thanks, this looks like another lovely way to do it 👍
Do you think any of these belong within ramda - in other words, is this worth a PR or should these live outside of ramda?

My initial thought is that these would do well in the Cookbook.  While they could be useful, they don't seem common enough in the way that the few math-related functions in Ramda are.  But if you think they belong there, feel free to argue the point.


Fix couch_key_tree:get_key_leafs/2

This is a fix for a long standing bug when retrieving all leaf keys for
a given set of keys. Before this patch we would incorrectly return some
keys as missing if they happened to be deeper on a branch for a key that
was found if they weren't themselves a leaf key.
COUCHDB-2863

+1
Verified this along with https://github.com/apache/couchdb-couch/pull/166 and https://github.com/apache/couchdb-fabric/pull/47
Don't completely grok the the code, but eunit tests pass, and function_clause error from https://issues.apache.org/jira/browse/COUCHDB-2863 doesn't happen anymore.
$ http 'http://adm:pass@localhost:15984/db/doc?open_revs=["1-967a00dff5e02add41819138abb3284d", "2-7051cbe5c8faecd085a3fa619e6e6337"]&latest=true'
HTTP/1.1 200 OK
Content-Type: multipart/mixed; boundary="958cf62657e616ab7d2e799d0d268bf6"
Date: Sun, 24 Apr 2016 01:04:15 GMT
Server: CouchDB/b49d069 (Erlang OTP/17)
Transfer-Encoding: chunked

--958cf62657e616ab7d2e799d0d268bf6
Content-Type: application/json

{"_id":"doc","_rev":"2-7051cbe5c8faecd085a3fa619e6e6337"}
--958cf62657e616ab7d2e799d0d268bf6--

Deleting the doc and getting latest works as expected as well:
$ http delete http://adm:pass@localhost:15984/db/doc?rev=2-7051cbe5c8faecd085a3fa619e6e6337
{
    "id": "doc",
    "ok": true,
    "rev": "3-7379b9e515b161226c6559d90c4dc49f"
}
$  http 'http://localhost:15984/db/doc?open_revs=["1-967a00dff5e02add41819138abb3284d", "2-7051cbe5c8faecd085a3fa619e6e6337"]&latest=true'
HTTP/1.1 200 OK
Content-Type: multipart/mixed; boundary="85b637594584dc5bb88940a5513ebc74"
Date: Sun, 24 Apr 2016 01:32:20 GMT
Server: CouchDB/b49d069 (Erlang OTP/17)
Transfer-Encoding: chunked

--85b637594584dc5bb88940a5513ebc74
Content-Type: application/json

{"_id":"doc","_rev":"3-7379b9e515b161226c6559d90c4dc49f","_deleted":true}
--85b637594584dc5bb88940a5513ebc74--

+1


Fix for application launcher crash

Closes: https://issues.redhat.com/browse/RHOAIENG-4490
Description

Cherry-pick of https://github.com/opendatahub-io/odh-dashboard/pull/2564

/lgtm


2.1 only: Robustness fix in mbedtls_ssl_derive_keys

In mbedtls_ssl_derive_keys, don't call mbedtls_md_hmac_starts in
ciphersuites that don't use HMAC. This doesn't change the behavior of
the code, but avoids relying on an uncaught error when attempting to
start an HMAC operation that hadn't been initialized.
This is the root cause for #1437, see https://github.com/ARMmbed/mbedtls/pull/1421/files#r175520310. I think #1437 is best resolved as part of #1421, but it's best to backport this robustness fix, more for documentation than anything else since it doesn't change the behavior.
If this approach is approved, I'll make an identical patch against mbedtls-2.7. For development, it's best included in #1437.

I have made a similar but complementary fix in https://github.com/ARMmbed/mbedtls-restricted/pull/440/commits/8a675f8ced3a6d7c3b0bdd2fdded9ca00206d699 - it might be worth consolidating both. Specifically, there's a previous call to md_setup that can be restricted to modes using MAC's, too.

One DLTS proxy test case failed on one configuration on the CI but I can't reproduce that failure locally. Since we don't get detailed logs from Jenkins, I'm inclined to treat this as a false negative due to a timeout or network glitch.

By the way, I didn't add a changelog entry because this should not affect the behavior of the product.

@hanno-arm Your fix removes code that is useless in certain configuration. That's complementary, but I prefer to keep them separate because I think it'll be easier to review that way — keep backports of incidental fixes made in separate PRs separate.


add 00-translations-ch_about_create_vir-env

something about how to create a virtual env in conda might be left before.
I just trans the step which lead to create dependencies file in class-00, -cn translation part.

@microsoft-github-policy-service agree


Google Gemini exploration

Contribution suggestion from @lgrammel
"Google Gemini exploration (this might be impact API design, so I want to prob do it myself)"

Am I correct to think that there is no support for gemini models/vertex on the lib at this moment? If one wanted to add this, what would be the steps to go?

@Morphexe correct. if you want to add this, you can follow the implementation pattern for any of the existing text generators and create a version of the gemini api. if you want to use vertex, you probably need to use google auth library, which is not edge ready, so the best approach would be to create a separate node module.


readthedocs down

I tried so many readthedocs site and all are down now. It simply showing "Service Unavailable"

Now it seems as if my projects aren't being sync'd with Github, even though RTD is back online. Any word/note on that?

This was a problem with our database that took me a few bleary-eyed hours this morning to resolve. Service was restored sometime around 5am PDT. Closing this.
@akutz feel free to open a separate issue with information on your project if this is still an issue.


Async generator stream is not closed if cancelled

Dart Programming Language Speciﬁcation (4th edition draft) version 1.11 chapter 16.14 Function Invocation reads:

If f is marked async* (9), then a fresh instance s implementing the built-in
class Stream is associated with the invocation and immediately returned. When
s is listened to, execution of the body of f will begin. When f terminates:
• If the current return value is deﬁned then, if s has been canceled then its
cancellation future is completed with null (16.2).
• If the current exception x is deﬁned:
– x is added to s.
– If s has been canceled then its cancellation future is completed with
x as an error.
• s is closed.

Please, note, that according to the specification s is closed in all cases.
The description for method Stream.listen() https://api.dartlang.org/1.14.2/dart-async/Stream/listen.html reads:

If this stream closes, the onDone handler is called.

Here is the sample code that demonstrates the problem:
import 'dart:async';

int sum = 0;

Stream generator() async* {
  // do not use yield here, because it may terminate the function
  // just do some actions
  for(int i=0; i<10000; i++){
    sum += i;
  }
}

main() {
  Stream s = generator();
  s.listen(
      (_) {},
      onDone: () {
        print('onDone: sum: $sum (expected: 49995000)');
      }
  ).cancel().then(
      (_) {
        print('cancel future is completed');
  });
}

Output:

cancel future is completed

Expected output:

cancel future is completed
onDone: sum: 49995000 (expected: 49995000)

Dart VM version: 1.14.2 (Tue Feb 09 15:17:24 2016) on "windows_x64"

The same problem is observed if generator() throws exception instead of normal completion.

When you call cancel on a StreamSubscription, you preclude any further events from being received. That's what cancel means: Stop receiving events. For a single subscription stream, it should also trigger early clean-up because the stream knows that any further events it might generate will be ignored anyway.
The done event is an event, so calling cancel also means that the onDone handler won't be called, since the done event was cancelled.
It might not be clear enough from the StreamSubscription documentation that the calling of onDone is also an event triggered callback, like onData and onError, and that cancel will ensure that no further callbacks are triggered.

Is there a way to find out the state of the Stream? (i.e. closed or not).
The onDone event was the only one I have found.
The same question is applicable to the Future: is there a way to find out whether it is completed or not?

A Stream doesn't have a state as such (at least not a single-subscription stream).
The StreamSubscription is either active (more events pending), done (done event has been delivered) or cancelled (by user). For a user, the cancelled and done states are indistinguishable - no further events will occur. The code that called cancel will have a received Future that completes eventually.
There is no way to inspect the subscription to see which state it is in, the user is expected to keep track the state of the subscriptions they have control of.

It seems to me that either the spec should be changed or the implementations in the vm and dart2js should be changed.  Please label this with vm and dart2js and spec, and explain in more detail what the problem is and what the solutions could be.

Reading this again - I think everybody is acting correctly, but the documentation should be improved. You only get an onDone call when a stream closes if you haven't already called cancel.


Adapt to eio + custom events

In my fork of eio+custom events (https://github.com/TheLortex/eio/tree/runtime-events) I make the distinction between fiber logs, location and name.
This PR should also fix CI

@patricoferris it's a bit complex to do dependency management with submodules, things can break (https://github.com/patricoferris/meio/actions/runs/4502145363/jobs/7923553432) as the submodule's dependencies change. Moreover, the monitored package has to be built with the same version of eio to be able to emit custom events.
My suggestion is to use a package constraint so that it reflects on the whole user's switch. For convenience, I have created https://github.com/TheLortex/custom-events-opam-repository containing an ocaml 5 compiler with the custom events patch, and a fork of eio emitting custom events.
What do you think ?

Great. The custom repository provides an easy start for people who want to try the project, and it remains compatible with both opam pins and a monorepo workflow.


Encryption and Decryption Password Protection is not working

When we are trying to make password protection below error is occuring. Could you please provide the solution to encrypt and decrypt the pdf with password protection
Error :spawn qpdf ENOENT
TypeScript Code :
var qpdf = require('node-qpdf2');
var file = path.join(__dirname, 'sample.pdf');
        const options = {
            keyLength: 128,
            password: 'test1234'
        }
        qpdf.encrypt(file, options);

ENOENT is a 'No Entity Exists' error. Can you verify that qpdf is installed? https://github.com/qpdf/qpdf

If that doesn't work, feel free to reopen.

Could you please provide the steps how to install the qpdf in the Window 10

Here is the link to the qpdf releases, take a look at the mingw or msvc zips, both should work on windows. https://github.com/qpdf/qpdf/releases. Side note: I haven't tested this package on windows, just unix systems. If there are problems after you get qpdf up and running, file an issue.


Lock failed, path = '...' (OS Error: Resource temporarily unavailable, errno = 11)

Question
I am getting this error message -
00:23 +159 -1: loading /talawa/test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart [E]
Failed to load "/talawa/test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart": lock failed, path = 'temporaryPath/currentuser.lock' (OS Error: Resource temporarily unavailable, errno = 11)
package:hive/src/backend/vm/storage_backend_vm.dart 81:5                           StorageBackendVm.initialize
===== asynchronous gap ===========================
package:hive/src/hive_impl.dart 116:9                                              HiveImpl._openBox
===== asynchronous gap ===========================
package:hive/src/hive_impl.dart 145:12                                             HiveImpl.openBox
===== asynchronous gap ===========================
test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart 98:3  main
===== asynchronous gap ===========================
/tmp/flutter_tools.LUVMPV/flutter_test_listener.QPCJSL/listener.dart 19:3          _testMain
I got this error - when I run flutter test.
Code sample
It is a big codebase.  Here is the link - https://github.com/architsangal/talawa
(Commit - https://github.com/architsangal/talawa/commit/1f087095002ba5898e09176eda342125f18a4c79)
Version

Platform: Not applicable
Flutter version: 2.10.3
Hive version: ^2.0.4

Can someone please help? Project has more than 250 test so this kind of solution will not work, I think.

@architsangal did you end up figuring it out? i'm running into the exact same issue

It was happening in my local system. When I pushed my code to GitHub, GitHub Action didn't give any errors. Flutter test run in parallel. So, it is possible that a resource is getting locked by one of the tests. Some other test wants to use that resource at that same movement. This looked like a typical OS lock error. You can try to find a way to run a flutter test in a single thread. I didn't get that part, yet. Please let me know if you get it.

Hello, I found the solution for running tests on a local machine, and don't take this error
flutter test --concurrency=1 --test-randomize-ordering-seed=random

This command runs tests in one thread and shuffles them in random order.


NOT Filter?

Is there a NOT operator for these filters?
Lets say that I mark only my integration tests with a test category. Could I specify a filter to run all tests that aren't TestCategory="Integration"?
It would be nice if there was a section that lists each operator and exactly what they do. It might seem basic but knowing that "&" is an AND filter and "|" is an OR filter would be nice.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb70526f-d02c-2b6c-3d34-0f4cac5809f0
Version Independent ID: e4443d71-7131-ae9b-447d-9ac0762a99fc
Content: Running selective unit tests - .NET Core
Content Source: docs/core/testing/selective-unit-tests.md
Product: dotnet-core
GitHub Login: @smadala
Microsoft Alias: mairaw

You can use the ! operator shown with FullyQualifiedName for TestCategory as well. For example:
dotnet test --filter TestCategory!=Integration

@adam-geisen Does this answer your question? Thanks!

Yes. It would still be nice for a table of the valid operators.

I would think you might have better luck finding something like that in the testing framework or runner (like Visual Studio) docs. I did quick search and came up with this, I think this is what you're looking for 😄
https://github.com/Microsoft/vstest-docs/blob/master/docs/filter.md
I'm going to close now. Thanks for the question :)

I see, thank you. That is exactly the doc I was looking for. Didn't know what to search!
You learn new things every day 👍

hehehe no worries!

But I want to ignore a specific project without adding categories on each test. Is there a "Does NOT contains" operator something like !~?


Disable update notifications for specific properties or relationships

Goals
I'd like to have a way to stop changes to certain properties or relationships from causing an object to be marked as updated in a notification.
Expected Results
I have a User model with two properties, name: String and retrievedAt: NSDate. The UI is setup to only show the name. When a network request is done to get the users, retrievedAt will be updated and cause the UI to update even though nothing in the UI needs to change.
Possible Solutions
Add a method to Object that can be overridden to provide properties that shouldn't cause an updated notification. This is the least flexible option since it would be set at the class level.
Add a property to addNotificationBlock that takes some kind of settings object that you can set properties that should be ignored.
Add a property to RealmCollectionChange or Object to find out what properties were changed to cause the update and allow the user to ignore them as needed.
Current Workarounds
Create a new object UserHousekeeping that contains the retrievedAt: NSDate and a relationship to the User. User then needs to use a LinkingObjects to have a reference to the UserHousekeeping without having notifications be created for changes to the related object.

The initial design proposal for change notifications had something like addNotificationBlock:watchingKeyPaths: which would make it only report modifications for the specified keypaths. This turned out to be nontrivial to implement (currently the information about which property changed is discarded long before any of the per-notification-block logic), but I think it's still high on the list of things we'd like to add to change notifications.

+1

I think it's still high on the list of things we'd like to add to change notifications.

Excellent!

Add a method to Object that can be overridden to provide properties that shouldn't cause an updated notification. This is the least flexible option since it would be set at the class level.

Just my 2 cents: I would rather not have this feature at all, than have it implemented in this inflexible manner. I already have use cases where I need notifications for specific related object changes in one view controller, and not in another view controller.
Finally, I propose  that instead of telling it what keypaths to watch, we tell it what keypaths to ignore, so a method like:addNotificationBlock:ignoringKeyPaths:.
Hopefully this feedback is useful.

need +1

+1

Any news on this one?

We'll post any developments regarding this issue, in this issue.

+1

+1

+1

+1

+1

+1111111111111

+1

+1

+1

+1

+1?

I really need this!

Is there some kind of roadmap for what features will be worked on when? It seems like this has been open for 2 years? I too need this desperately !

+1

https://twitter.com/iamdevloper/status/1138792943794343936?s=21

+1

+1

+1

Good news: https://github.com/realm/realm-cocoa/pull/7249 (currently in review) will enable this.

Keypath filter was shipping in 10.12.0.

Hi @tgoyne, I see that key path filtering is out but could I do the opposite now - ask to not observe a particular key path instead?

for anybody on this, to exclude a property you can do
            let schema = FItem().objectSchema
            var keyPaths = schema.properties.map { $0.name }
            keyPaths.removeAll(where: { $0 == "userActivated" })

            let t = Realm.defaultRealm().objects(FItem.self).observe(keyPaths: keyPaths, on: .main) { ... }

@peterpaulis keep in mind that this doesn't include all properties (e.g., LinkingObjects are by default not included in the list of properties obtained through the objectSchema). Though I don't think a LinkingObjects property can cause a change notification to begin with...


Where to start understanding the repository and how to console?

This is probably a really really dumb question, so I apologize for it.
I want to trace through the repository for learning purpose, but I am having trouble tracing it and debug it. Can someone point me a direction on how to

Find the entry point after running npm run watch and ./scripts/code.sh,  specifically how does this file get called https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/browser.ts ?

How to debug through console. I tried opening Developer: Toggle Developer Tools but no matter how much console.log I put in https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/browser.ts the consoles don't show up.

Thanks

Check out these docs
https://github.com/Microsoft/vscode/wiki/How-to-Contribute
Also try putting console logs somewhere else, maybe that file is not running in the renderer, since only the rendere output will get forwarded to the console.
As for the code base understanding docs those are missing thus assigning this to @gregvanl

At this point, there are no plans to document or give a detailed overview of the vscode code base.


Add docstrings for all modules and the package

It is desirable to have a docstring for the package and all modules so that, among other things, new contributors can more easily get a grasp of what a module is responsible for. This issue is related to issue #219.

@MacOS - nice work - merged into the main branch.


UI batch processing

Added space for multiple files in image sorting

Good catch, I accidentally committed them. Removed in new commit


HER2 gene symbol expected to return ERBB2

HER2 is a well-known alias for ERBB2, and should normalize to ERBB2 in DGIdb, we should investigate why this does not happen.

Duplicate: https://github.com/dgidb/dgidb-v5/issues/304


Example is missing call to super.onCreate

Hi, thank you for this. Just small remark example is missing super.onCreate as result views not get initialized and you get nullpointer exception.

Good catch! Would you mind submitting a quick PR?

+1


Added event type Blocked to Event examples

Delivery Event JSON examples were missing Blocked example, example includes 'type' field.

Hello @hmbrown64,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


How does equlity on FiniteDistributions work now?

I noticed a test was failing, one which compared two finite distributions for equality. How is equality of finite distributions checked now, if it is checked at all?

It should not be checked. Only equality on elements should be checked
On Tue 14 Jul, 2015 12:00 pm Sayantan Khan<EMAIL_ADDRESS>wrote:

I noticed a test was failing, one which compared two finite distributions
for equality. How is equality of finite distributions checked now, if it is
checked at all?
—
Reply to this email directly or view it on GitHub
https://github.com/siddhartha-gadgil/ProvingGround/issues/38.


Add text  on confirming audit that the audit must be finalized for it to take effect.

Summary
Add a confirmation message on "Confirm" in Audit that includes the information that the audit must be finalized before any changes will be made to the inventory.
Why?
Avoiding the banks doing distributions in between confirmation and finalization.
Details
Steps to the place this has to be:
login as<EMAIL_ADDRESS>Inventory
Inventory Audit
New Audit
Choose storage location and enter a quantity for at least one item
Click "Confirm Audit"
We currently have an "Are you sure?" confirmation pop-up there.
This should also have the text "Please note that this audit must also be finalized by someone with organization admin rights before changes to inventory will take place.  We strongly recommend completing that step before doing any further actions that affect inventory."
Criteria for completion

[ ] message appears
[ ] test to confirm

Hi @cielf! Could I please take on this task? I'm new to open source, but familiar with Ruby :)

That's why we have good first issues!

Hi @cielf , I’m new here and interested in contributing, can you assign this task to me


Fix Sequelize type definitions

fix some bug.

@samuelneff @codeanimal @drinchev Could you review this pull request?

:+1: Looks good. Thanks ;)

@drinchev thanks!
@horiuchi thanks mate!


Fix decoloring of comments icon

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes #474

In addition to app/views/readers/update_all.coffee and app/views/readers/update.coffee, I also changed these lines in app/views/comments/create.js.erb:
<% if @update_icon %>
$('#commentsIcon').addClass('new-comment');
<% end %>

While doing this, I was wondering if we really want the comments icon to be colored at all when you submit your own comment. Isn't it a bit weird for a user to then click on the icon just to notice it was their own comment 3 seconds ago?

While doing this, I was wondering if we really want the comments icon to be colored at all when you submit your own comment. Isn't it a bit weird for a user to then click on the icon just to notice it was their own comment 3 seconds ago?

We could discuss this. I mean, for me personally, I like to have this coloring even for my own comments, because it gives me some more visual feedback that I did something that other users will notice. Of course, others might disagree with that view.
By the way, for any changes in that direction, #445 should be resolved first, because the code responsible for selecting who gets a coloring is inside the comments_controller.rb in the commontator gem which we currently self-host. It would be better to have this back as a custom controller inside our own repository.


[BACKLOG-13291] Mavenize pentaho-kettle/plugins/xml-input

@pentaho/2-1b

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/xml-input/assemblies/plugin/pom.xml
  plugins/xml-input/assemblies/plugin/src/assembly/assembly.xml
  plugins/xml-input/assemblies/plugin/src/main/resources/XIN.svg
  plugins/xml-input/assemblies/plugin/src/main/resources/samples/transformations/XML Input - basic reading flat XML.ktr
  plugins/xml-input/assemblies/plugin/src/main/resources/version.xml
  plugins/xml-input/assemblies/pom.xml
  plugins/xml-input/core/pom.xml
  plugins/xml-input/core/src/main/filters/version.properties
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInput.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputData.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputField.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputFieldPosition.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputMeta.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/ui/trans/steps/xmlinput/XMLInputDialog.java
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_de_DE.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_en_US.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_es_AR.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_es_ES.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_fr_FR.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_it_IT.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_ja_JP.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_ko_KR.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_zh_CN.properties
  plugins/xml-input/core/src/main/resources/version.properties
  plugins/xml-input/core/src/main/resources/version.xml
  plugins/xml-input/pom.xml

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -.15%:small_red_triangle_down:

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins' -P '!assemblies' -amd build-helper:remove-project-artifact

Build Sensitive Files Changed
  plugins/xml-input/build-res/subfloor-pkg.xml
  plugins/xml-input/build-res/subfloor.xml
  plugins/xml-input/ivysettings.xml

Changed files
  plugins/xml-input/assemblies/plugin/pom.xml
  plugins/xml-input/assemblies/plugin/src/assembly/assembly.xml
  plugins/xml-input/assemblies/plugin/src/main/resources/XIN.svg
  plugins/xml-input/assemblies/plugin/src/main/resources/samples/transformations/XML Input - basic reading flat XML.ktr
  plugins/xml-input/assemblies/plugin/src/main/resources/version.xml
  plugins/xml-input/assemblies/pom.xml
  plugins/xml-input/build-res/subfloor-pkg.xml
  plugins/xml-input/build-res/subfloor.xml
  plugins/xml-input/build.properties
  plugins/xml-input/build.xml
  plugins/xml-input/core/pom.xml
  plugins/xml-input/core/src/main/filters/version.properties
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInput.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputData.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputField.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputFieldPosition.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/trans/steps/xmlinput/XMLInputMeta.java
  plugins/xml-input/core/src/main/java/org/pentaho/di/ui/trans/steps/xmlinput/XMLInputDialog.java
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_de_DE.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_en_US.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_es_AR.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_es_ES.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_fr_FR.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_it_IT.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_ja_JP.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_ko_KR.properties
  plugins/xml-input/core/src/main/resources/org/pentaho/di/trans/steps/xmlinput/messages/messages_zh_CN.properties
  plugins/xml-input/core/src/main/resources/version.properties
  plugins/xml-input/core/src/main/resources/version.xml
  plugins/xml-input/ivy.xml
  plugins/xml-input/ivysettings.xml
  plugins/xml-input/package-ivy.xml
  plugins/xml-input/pom.xml
  plugins/xml-input/res/version.xml

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -.93%:small_red_triangle_down:
Complexity Change: -.80%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change:  + .17%


drivers: pwm: small improvements/fixes

This PR introduces some small improvements/fixes to PWM drivers
NOTE: removed all formatting for now until it is discussed, this PR contains now tiny fixes or enhancements.

NOTE: removed all formatting for now until it is discussed, this PR contains now tiny fixes or enhancements.

@nashif ping, style changes are no longer part of the PR, please re-review


New scaffolded projects contain phantom dependencies and do not compile with pnpm

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[X] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details
SPFX 1.17.1 (but bug present for ages)
Node 16.20.1
Describe the bug / error
Projects that are scaffolded using the official @microsoft/generator-sharepoint generator contains phantom dependencies.
Phantom dependencies are well explained by Microsoft in their rushstack doc.
Using npm won't cause visible issue (which is like putting dust under the carpet). But the issue is revealed when using more robust package managers like pnpm.
@fluentui/react
1st missing dependency is @fluentui/react which is missing and prevent building scss files:
Error - sass - src\webparts\myWebPart\components\MyWebPart.module.scss(1,9): error Error: Can't find stylesheet to import.
  ╷
1 │ @import<EMAIL_ADDRESS>  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  src\webparts\myWebPart\components\MyWebPart.module.scss 1:9  root stylesheet
[22:32:29] Error - 'sass' sub task errored after 95 ms
 Can't find stylesheet to import.
  ╷
1 │ @import<EMAIL_ADDRESS>  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  src\webparts\myWebPart\components\MyWebPart.module.scss 1:9  root stylesheet

Solved by adding<EMAIL_ADDRESS>dependency explicitly.
'@microsoft/sp-component-base'
2nd missing dependency is '@microsoft/sp-component-base'.
Error - [tsc] src/webparts/myWebPart/MyWebPartWebPart.ts(9,32): error TS2307: Cannot find module '@microsoft/sp-component-base' or its corresponding type declarations.
Error - 'tsc' sub task errored after 4.58 s

Same fix: add<EMAIL_ADDRESS>explicitly to solve the issue.
Proposed solution
Obviously, the solution should be to include these two dependencies explicitly in the template, and any future explicit usage of a dependency. MS should also include yarn and pnpm package managers in their tests since their adoption is growing very high (npm has very low performance and have some issues regarding dependency graph - check Rustask for explanations)
Steps to reproduce
Install pnpm v8 and node 16

bootstrap a new SPFX project. Choose to create a webpart / react project.

pnpm --package yo@latest --package<EMAIL_ADDRESS>dlx yo @microsoft/sharepoint@latest --package-manager pnpm --component-type webpart --framework react --solution-name "repro-spfx" --component-name MyWebPart

install dependencies

cd repro-spfx
pnpm install

Try to build

pnpm build

❌ Does not compiles (missing @fluentui/react)
Add the missing dependency and try to build again

pnpm add<EMAIL_ADDRESS>pnpm build

❌ Does not compiles (missing @microsoft/sp-component-base)
Add the missing dependency and try to build

pnpm add<EMAIL_ADDRESS>pnpm build

✅ This time, every compiles properly

Expected behavior
Dependencies should be setup properly, in order to avoid phantom dependencies (which is a good practice I guess), and it should work out of the box with the major package managers (npm, yarn and pnpm).

dupe of #8939

fixed in 1.17.2


Is there a way to have logwatch and pflogsum added and act/deactivated by an Environment var?

Is there a way to have logwatch and pflogsum added and act/deactivated by an Environment var?
Context

Currently I'm using logwatch and pflogsum to monitor my mailserver. The way I'm installing it is using some docker-exec and docker cp after creating and running the container.
It would be nice to have them both added in the default-image.

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

Your Environment

Amount of RAM available:
Mailserver version used:
Docker version used:
Environment settings relevant to the config:
Any relevant stack traces ("Full trace" preferred):

Hello Johan, do you mean its okay to rais a PR to implement  it? If yes I will try  - would be my first one :).
I would update https://github.com/tomav/docker-mailserver/blob/master/target/start-mailserver.sh
and the the Dockerfile for installation - right?

Both yes

@helmutundarnold is this still relevant? If you can't make a PR but still would like to get this done I think the chances would increase if you shared the docker exec/cp commands you are using now and of course the config files. Or if it is no longer relevant, can we close this?

Hello Erik,
this would be the Environment Variables
# pflogsummReport
PFLOGSUMMREPORT_ENABLED=[true|false]   # empty = false
<EMAIL_ADDRESS>PFLOGSUMMREPORT_RECIPIENTS_ADDRESS=<email1>,<email2>...

# logwatch report
LOGWATCHREPORT_ENABLED=[true|false]  # empty = false
<EMAIL_ADDRESS>LOGWATCHREPORT_RECIPIENTS_ADDRESS=<email1>,<email2>...

This is my current function for pflogsummReport
  if [[ $PFLOGSUMMREPORT_ENABLED != true && $PFLOGSUMMREPORT_ENABLED != 1 ]]
    then
        echo "pflogsummReport not enabled"
        return
    fi

    # first clean up
    docker exec -it $MAIL_CONTAINER_NAME rm -rf /root/pflogsummReport

    # set PFLOGSUMMREPORT_SENDER + RECIPIENT
    sed  -i s/SENDER=.*$/SENDER=$PFLOGSUMMREPORT_SENDER_ADDRESS/ \
       $APPS_DIR/resources/pflogsummReport/root/pflogsummReport/pflogsummReport_yesterday.sh

    sed  -i s/RECIPIENTS=.*$/RECIPIENTS=$PFLOGSUMMREPORT_RECIPIENTS_ADDRESS/ \
       $APPS_DIR/resources/pflogsummReport/root/pflogsummReport/pflogsummReport_yesterday.sh

    sed  -i s/SENDER=.*$/SENDER=$PFLOGSUMMREPORT_SENDER_ADDRESS/ \
       $APPS_DIR/resources/pflogsummReport/root/pflogsummReport/pflogsummReport_today.sh

    sed  -i s/RECIPIENTS=.*$/RECIPIENTS=$PFLOGSUMMREPORT_RECIPIENTS_ADDRESS/ \
       $APPS_DIR/resources/pflogsummReport/root/pflogsummReport/pflogsummReport_today.sh

    echo "copy the preconfigured pflogsummReport into the container"
    inSRC="$APPS_DIR/resources/pflogsummReport/root/pflogsummReport"
    inDST="$MAIL_CONTAINER_NAME:/root"
    docker cp $inSRC $inDST
    docker exec -it $MAIL_CONTAINER_NAME chown -R root.root /root/pflogsummReport

    echo "update the cron.d"
    docker exec -it $MAIL_CONTAINER_NAME rm -rf /etc/cron.d/pflogsummReport
    inSRC="$APPS_DIR/resources/pflogsummReport/etc/cron.d/pflogsummReport"
    inDST="$MAIL_CONTAINER_NAME:/etc/cron.d"
    docker cp $inSRC $inDST
    docker exec -it $MAIL_CONTAINER_NAME chown root.root /etc/cron.d/pflogsummReport
    docker exec -it $MAIL_CONTAINER_NAME chmod 644 /etc/cron.d/pflogsummReport

The script that will be triggered by the cron is pflogsummReport_yesterday.sh . For maintainance reason I also created a script pflogsummReport_today.sh  which sends a report from todays logs.
[admin@triton904 pflogsummReport]$ cat pflogsummReport_yesterday.sh
#!/bin/sh

MAILLOG_DIR=/var/log/mail
WORK_DIR=/root/postfixTools
REPORT_FILE=$WORK_DIR/mail_repo_$(date '+%Y-%m-%d_%H%M%S').txt
SEND_HOST=$(uname -n)

RECIPIENTS=$PFLOGSUMMREPORT_RECIPIENTS_ADDRESS
SENDER=$PFLOGSUMMREPORT_SENDER_ADDRESS

BODY=$(/usr/sbin/pflogsumm $MAILLOG_DIR/mail.info -d yesterday)

/usr/sbin/sendmail -t <<EOF
From: $SENDER
To: $RECIPIENTS
Subject: pflogsumm for $SEND_HOST from yesterday sent on $(date '+%Y-%m-%d_%H%M%S')
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8
$BODY
EOF

For the Logwatch its similar
But logwatch must be added in the dockerfile
/usr/bin/apt-get update -y
/usr/bin/apt-get install logwatch -y

and the logwatchReport_yesterday.sh looks like
SEND_HOST=$(uname -n)
RECIPIENTS=$PFLOGSUMMREPORT_RECIPIENTS_ADDRESS
SENDER=$PFLOGSUMMREPORT_SENDER_ADDRESS

/usr/share/logwatch/scripts/logwatch.pl --hostname $SEND_HOST --range Yesterday --detail Med --mailto $RECIPIENTS

Would be nice if this could be added.

@helmutundarnold I just noticed that pflogsumm is included already. It is enabled with REPORT_RECIPIENT and there are also REPORT_SENDER and REPORT_INTERVAL options. Does that report work for you, or (if not) what is missing?
That doesn't cover logwatch of course.

Hello Erik,
unfortunately this implemented Report is triggered by logrotate and not
by a regular daily cron. And thus the report relays on the entire
logfile.  I would like to use that "yesterday" option to make sure I
have a summary from yesterday.
If you/Mailsever team implents a second report with logwatch I thought
it would be good to have similar Variables and it would be more flexible
for the future.
Best Regards
         Helmut
Am 16.08.19 um 11:23 schrieb Erik Wramner:

@helmutundarnold https://github.com/helmutundarnold I just noticed
that pflogsumm is included already. It is enabled with
REPORT_RECIPIENT and there are also REPORT_SENDER and REPORT_INTERVAL
options. Does that report work for you, or (if not) what is missing?
That doesn't cover logwatch of course.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tomav/docker-mailserver/issues/1093?email_source=notifications&email_token=AC7UW3ES3ZSFJPET57XY5RDQEZW2BA5CNFSM4GL42VM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4OEQNY#issuecomment-521947191,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7UW3C6ER3M4MC5IADB24DQEZW2BANCNFSM4GL42VMQ.

See #1262.

Hello Erik,
thanks for implementing and update with pflogsum and logwatch. I'm
looking forward of how it will work.
Regards
        Helmut
Am 15.09.19 um 18:25 schrieb Erik Wramner:

See #1262 https://github.com/tomav/docker-mailserver/pull/1262.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tomav/docker-mailserver/issues/1093?email_source=notifications&email_token=AC7UW3GTW27Q2KJRUYQSWRLQJZOV3A5CNFSM4GL42VM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XUCPY#issuecomment-531579199,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7UW3AQY44HZZV3ME4M2F3QJZOV3ANCNFSM4GL42VMQ.


pyca/cryptography external test doesn't uses the system version instead of the build version.

See https://github.com/openssl/openssl/issues/19389#issuecomment-1275517014

It seems #19407 already exists for this

https://github.com/openssl/openssl/pull/19439 has been merged.


Incorrect block number in ganache-cli 6.4.4

Expected Behavior
web3.eth.blockNumber should be equal to the actual (on-chain) block.number.
Current Behavior
web3.eth.blockNumber is equal to block.number - 1.
Possible Solution
This problem seems to have been fixed in ganache-cli 6.5.1.
I would be happy to understand what the problem was and how it was fixed (or to get a reference to the relevant release note, if viable).
Steps to Reproduce
File package.json:
  "dependencies": {
    "ganache-cli": "6.4.4",
    "truffle": "4.1.14"
  }

File MyContract.sol:
pragma solidity 0.4.24;
contract MyContract {
    function get() public view returns (uint256) {
        return block.number;
    }
}

File MyContractTest.js:
contract("MyContractTest", function(accounts) {
    it("test", async function() {
        const MyContract = await artifacts.require("MyContract").new();
        const expected = web3.eth.blockNumber;
        const actual = await MyContract.get();
        console.log();
        console.log("expected:", expected);
        console.log("actual:", actual.toString());
    });
});

Execution:

Run ganache-cli
Run truffle test

Printout:
expected: 1
actual: 2

When switching to ganache-cli 6.5.1, the printout is:
expected: 1
actual: 1

My Environment

Ganache Version: 6.4.4
Truffle Version: 4.1.14
NodeJS Version: 10.16.0 (npm 6.9.0)
Operating System: Windows 10 64 bits

This was fixed by https://github.com/trufflesuite/ganache-core/pull/443 referenced in the release notes for 6.5.1.
Is there any reason you can't update to 6.5.1?

@davidmurdoch:
There was a reason until recently - updating to 6.5.1 would yield exactly one of the following:

If I didn't fix my test to comply with the new version, then truffle test would fail
If I did fix my test to comply with the new version, then solidity-coverage would fail

I reported this problem at https://github.com/sc-forks/solidity-coverage/issues/362 as well, and the dev team fixed it almost instantly!
Thanks :)
One thing to notice - I would take the liberty to guess that if this fix in ganahe-cli has broken my test, then it has probably broken many other tests which rely on this specific behavior (web3.eth.blockNumber == block.number - 1).
Perhaps adding a very explicit announcement (or warning if you will) on the release notes (of both 6.4.4 and 6.5.1) would be useful here (though I admit I haven't actually made sure that it isn't already there).


Modifying pull request work items

Thanks for cool API and documentation!
Is it possible (or will be possible) to modify attached work items with POST/PUT/PATCH/DELETE commands?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5db99ecd-c056-34ad-ac0d-6cff18e9c4b2
Version Independent ID: b8c0789d-12f1-e296-5b57-47369857627f
Content: Pull Request Work Items (VSTS Git)
Content Source: docs-ref-autogen/git/Pull%20Request%20Work%20Items.yml
Service: unspecified
GitHub Login: @wnjenkin
Microsoft Alias: whjenkin

@GennadyGS We don't have any near term plans to add more commands to the PR links API.  If you're interested in seeing invest in this, I'd encourage you to visit our UserVoice forum to submit a suggestion.  This will give the item more visibility and allow others to add their support.
Thanks!


Update output box

@songfangyl I am wondering did you mean priority.Medium rather than severity.Medium for you label here? Severity label is supposed to be used for bugs.

OK! get it.


[EmbeddingApi] Add usecase for API onPageLoadStarted & onPageLoadStopped

-Modify test case to check onPageLoadStarted and onPageLoadStopped
-Cover the XWalkActivity and XWalkInitializer two ways
Impacted tests(approved): new 0, update 2, delete 0
Unit test platform: [Android]
Unit test result summary: pass 2, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-5017

@jennycao please help to review it.

LGTM


RUBY port of lz-string

Good news for Ruby devs - here is the lz-string port for Ruby https://github.com/Altivi/lz_string.

@pieroxy to this section https://github.com/pieroxy/lz-string#other-languages
Thanks in advance!

If you want to create a PR with that change (can easily do the one-line in github directly) - then I'll +1 and merge! :-)


Introduce $include-html-dropdown-classes setting

The dropdown HTML styles are currently included based on the $include-html-button-classes variable.
Surely a variable, $include-html-dropdown-classes, would make more sense for those wishing to use the dropdown classes but define their own buttons?

I was reviewing previous issues before opening my own one about this problem and I fond this one, so let me join to this request.
By what I saw, Foundation 6 won't separate buttons from dropdown buttons and this flag variable stuff will change, so I would like to know if (after 2 years from @cmwinters comment) a PR would be accepted to solve this in Foundation 5.
Thanks and sorry for getting this old closed issue back :wink:.


bug: Building Block Commands don't work with examples from the Docs

Overview
Building Block Commands don't work when used with example Accessor Methods in the APIv2 Documentation.
The vast majority users in the lab expect a multi-channel pipette to operate on an entire column (in a 96-well plate) at once, and when working with the multi are likely to use the given methods in the API documentation for accessing columns rather than wells. When used, these methods should produce the expected robot movement or a helpful error message.
Current behavior
It seems to be a known issue that the building block commands only accept single well location as an input when working with the multi channel pipette. See: https://github.com/Opentrons/opentrons/issues/4946 However, this behavior is not mentioned in the documentation and is confusing to users who are accustomed to thinking about the multi-channel pipette as working on entire columns at a time.
So, when users try to access an entire column with the multi-channel pipette, as shown here in the docs by doing something like p_multi.aspirate(10, plate.columns_by_name()['1']) they receive a TypeError from our API rather than the expected movement.
Steps to reproduce
Simulate the following protocol with version 3.16.1
from opentrons import protocol_api

# metadata
metadata = {'apiLevel': '2.2'}

### Run Protocol ###
def run(protocol: protocol_api.ProtocolContext):

    # tipracks
    tiprack_multi = protocol.load_labware('opentrons_96_tiprack_300ul', '10')

    # labware
    plate_96well = protocol.load_labware('nest_96_wellplate_100ul_pcr_full_skirt', '1')

    # pipettes
    p_multi = protocol.load_instrument('p300_multi', 'left', tip_racks=[tiprack_multi])

    # commands

    p_multi.pick_up_tip()
    p_multi.aspirate(100, plate_96well.columns_by_name()['1'] )
    p_multi.dispense(100, plate_96well.columns_by_name()['10'] )
    p_multi.drop_tip()

Results in the following error:
opentrons.protocol_api.execute.ExceptionInProtocolError: TypeError [line 27]: location should be a Well or Location, but it is [A1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1, B1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1, C1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1, D1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1, E1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1, F1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1, G1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1, H1 of NEST 96 Well Plate 100 µL PCR Full Skirt on 1]

Similarly, a TypeError is also observed when using any the following commands as well:
p_multi.dispense(100, plate_96well.columns_by_name()['1'] )
p_multi.mix(100, plate_96well.columns_by_name()['1'] )
p_multi.pick_up_tip(plate_96well.columns_by_name()['1'] )
p_multi.return_tip(plate_96well.columns_by_name()['1'] )

Expected behavior
Accessing a column by name when working with the multi-channel pipette should produce the expected robot movement rather than a TypeError

The fact that this doesn't work I am guessing is related. Commenting here instead of opening a new ticket.
p50.transfer(50,
     reaction_plate.columns_by_name()['1'].bottom(),
     mag_plate.columns_by_name()['1']
)

Thread for more context: https://opentrons.slack.com/archives/CL08J5DJ7/p1589900542000700


checker: fix offline when only having one replica

What problem does this PR solve?
Closes #1923.
What is changed and how it works?
This PR fixes it by checking if the max replica is 1 before transferring the leader.
Check List
Tests

Unit test

Codecov Report

Merging #1951 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage   78.08%   77.98%   -0.11%
==========================================
  Files         170      170
  Lines       16863    16863
==========================================
- Hits        13168    13151      -17
- Misses       2683     2696      +13
- Partials     1012     1016       +4

Impacted Files
Coverage Δ

server/schedule/checker/replica_checker.go
82.2% <100%> (ø)
:arrow_up:

server/kv/etcd_kv.go
75.32% <0%> (-9.1%)
:arrow_down:

server/schedulers/shuffle_hot_region.go
61.29% <0%> (-5.38%)
:arrow_down:

server/member/leader.go
77.04% <0%> (-4.09%)
:arrow_down:

server/member/lease.go
92.18% <0%> (-3.13%)
:arrow_down:

server/grpc_service.go
57.32% <0%> (-1.94%)
:arrow_down:

server/config/option.go
92.16% <0%> (-0.93%)
:arrow_down:

client/client.go
68.76% <0%> (-0.42%)
:arrow_down:

server/core/storage.go
76.04% <0%> (ø)
:arrow_up:

server/server.go
83.62% <0%> (+0.19%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f229796...64e41b3. Read the comment docs.


ERROR in Entry module not found:

Error: Cannot resolve module 'client/react' in /Users/z013mrq/react-back
/**
 * Created by z013mrq on 6/1/15.
 */
var path = require('path');
var webpack = require('webpack');

module.exports = {
    cache : true,
    entry:{
        react:"./client/react"
    },
    output:{
        path: path.join(__dirname,"client/build"),
        publicPath : "build/",
        filename:"[name].js",
        chunkFilename : "[chunkhash].js"
    },
    modules:{
        loader:[
            // required for react jsx
            { test: /\.js$/,    loader: "jsx-loader" },
            { test: /\.jsx$/,   loader: "jsx-loader?insertPragma=React.DOM" },
        ]
    },
    resolve:{
        alias:{

        }
    }
}

webpack --display-error-details
ERROR in Entry module not found: Error: Cannot resolve 'file' or 'directory' ./client/react in /Users/z013mrq/react-back
resolve file
/Users/z013mrq/react-back/client/react is not a file
/Users/z013mrq/react-back/client/react.webpack.js doesn't exist
/Users/z013mrq/react-back/client/react.web.js doesn't exist
/Users/z013mrq/react-back/client/react.js doesn't exist
/Users/z013mrq/react-back/client/react.json doesn't exist
resolve directory
/Users/z013mrq/react-back/client/react/package.json doesn't exist (directory description file)
directory default file index
resolve file index in /Users/z013mrq/react-back/client/react
/Users/z013mrq/react-back/client/react/index doesn't exist
/Users/z013mrq/react-back/client/react/index.web.js doesn't exist
/Users/z013mrq/react-back/client/react/index.webpack.js doesn't exist
/Users/z013mrq/react-back/client/react/index.js doesn't exist
/Users/z013mrq/react-back/client/react/index.json doesn't exist

i found that, .jsx file format is not supported for modules. So i renamed my files to .js and it started working. Any idea when requiring .jsx file will work

I think you might have a typo loader instead of loaders


Issue with 'Latest Release' zip

I downloaded the latest release zipped files linked in the main README and tried to implement cropper on an image tag (basically $img = '<img ...>'$img = $('<img ...>') and then $img.cropper({...})). I kept getting an error that said something like 'TypeError $img.cropper is not a function'.
I did some googling and found this thread  where someone had a similar error and after they tried fengyuanchen's rawgit links their code worked fine. Same thing happened to me. The error went away. Everything works beautifully now. So I think there might be something wrong with the js files in the zip.

In that thread I linked, sbsomya speculates it was either his jquery or cropper. I tested it with the version of jquery fengyuanchen uses (1.11.3) as well as v2.2.2 and it continued to work for both of them so I do not think it is a jquery issue.

The $img = '<img ...>' is not equal to $img = $('<img ...>').

My mistake, I've edited that in my above comment, my code did have $img = $('<img ...>')

Were you include the cropper.js into your page and run the code after that?

I know what sbsomya and I were doing wrong >__< . I think we were both accidentally downloaded the cropperjs files and tried implement cropper(jquery). Until your comment I didn't even realize there were two distinct libraries. Sorry about all that


server needs to buffer incoming CONNECT requests until it has received the settings

After fixing #106.

Discussed in the WebTransport working group, most likely the protocol will be changed such that the server never has to wait for SETTINGS.


[3.x] Add ability to accepts parameters when using BladePartial directive

Add ability to accepts parameters when using the FormBuilder to include blade partials.
Description
Right now we have the ability to use BladePartial in the FormBuilder for including view, but it is lacking the ability to send parameters/options to those views.
This pull requests aims to solve that situation.
Example
With this PR we'll be able to do:
use A17\Twill\Services\Forms\BladePartial;

...

    BladePartial::make()
        ->view('twill.shared.link', [
           'field_prefix' => 'recirculation',
           'label_note' => 'Optional. Page title will be used if empty.',
        ])

Hey!
I feel we could maybe split this into a second parameter, as we currently provide one method for each action.
BladePartial::make()->view('bar')->withAdditionalParameters(['bar' => 'foo'])

We could on top of that allow to add a closure option that we can provide the model in?
BladePartial::make()->view('bar')->withAdditionalParameters(fn(TwillModelInterface $model) => $model->attributes)

Hey!
I feel we could maybe split this into a second parameter, as we currently provide one method for each action.
BladePartial::make()->view('bar')->withAdditionalParameters(['bar' => 'foo'])

We could on top of that allow to add a closure option that we can provide the model in?
BladePartial::make()->view('bar')->withAdditionalParameters(fn(TwillModelInterface $model) => $model->attributes)

What do you think?

Makes total sense to me @haringsrob !
I took care of the new withAdditionalParameters function for now. I think we can grow from there.

hey @sauron
Perfect, indeed we'll see what's requested in the future regarding other features.


image/jpeg: bad RST marker due to pre-reset marker byte alignment

What did you do?
While writing a small app to decode and process the JPEG frames from webcams running in Motion-JPEG mode, I found that images from a Logitech C270 webcam failed to decode when using the jpeg.Decode function. Images from other /dev/video devices worked just fine. I confirmed that the same images decoded fine using other programs like vlc.
I isolated a frame that caused the decoder to fail and stepped through the decoding with a debugger and compared it to the part of the jpeg spec in F1.2.3 from https://www.w3.org/Graphics/JPEG/itu-t81.pdf#page=36&zoom=auto,-200,43.
Turns out the jpeg decoder doesn't handle 0xFF 0x00 bytes that precede the expected 0xFF 0xD* bytes that form the reset markers. The stuffed bytes are used for byte alignment.
Here's an example frame from the stream:

And here's a play.golang.org link with a reproducer: https://play.golang.org/p/QTTKiHRfrLe
I've experimented with a fix in the handling of the rst marker in the image/jpeg/scan.go file and I'm fairly confident that this should fix the issue (it certainly seemed to fix it in my usecase):
diff image/jpeg/scan.go /snap/go/current/src/image/jpeg/scan.go
313,320d312
<
<                               // detect the presence of a stuffed 0xff00 pair caused by byte alignment
<                               if d.tmp[0] == 0xff && d.tmp[1] == 0x00 {
<                                       if err := d.readFull(d.tmp[:2]); err != nil {
<                                               return err
<                                       }
<                               }
<

What did you expect to see?
Expected the frame to decode successfully as it is in other software like VLC and web browsers.
What did you see instead?
panic: invalid JPEG format: bad RST marker

Does this issue reproduce with the latest release (go1.11.2)?
Yes.
System details
go version go1.11 linux/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/ben/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ben/.gvm/pkgsets/go1.11/global"
GOPROXY=""
GORAwE=""
GOROOT="/home/ben/.gvm/gos/go1.11"
GOTMPDIR=""
GOTOOLDIR="/home/ben/.gvm/gos/go1.11/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/ben/projects/github.com/AstromechZA/scream/go.mod"
GOROOT/bin/go version: go version go1.11 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.11
uname -sr: Linux 4.15.0-36-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename:	bionic
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.27-3ubuntu1) stable release version 2.27.
gdb --version: GNU gdb (Ubuntu 8.1-0ubuntu3) <IP_ADDRESS>80409-git

CC @nigeltao

I've setup a branch with the proposed fix on my fork of golang/go. I may be completely wrong about this bug (there's a chance the webcam has a bad jpeg encoder) or there may be a better way to fix the issue :smile:

Any chance this will be fixed in 1.12?

The patch in the OP looks plausible (although I'd like the comment to mention F1.2.3 in the spec), but we are deep in the release cycle (https://github.com/golang/go/wiki/Go-Release-Cycle) for Go 1.13. As it is not a regression, it will probably land in 1.14 at the earliest.
Sorry for the late reply. I can't remember why I didn't see the "CC @nigeltao" note earlier.

Is this anticipated in 1.15?


CAMEL-10679

Producer does not populate attachments from response.
I would think of refactoring the whole part of the response handling.
In my opinion it would be best to handle this the same way as the
BasicMessageFilter does this for the request message.
This way anyone could implement custom behaviour if neccessary.
I would have done it, but i didnt want to break anybodys code, so i just
implemented it the same way the headers are populated.
Feel free to contact me about the change.

I'll wait for the fixes and I'll test and merge. Thanks @marcusmesserkewill and @davsclaus

I just saw, the adoc is auto generated, so this probaply doesnt need to be committed i guess.
Everything fine now? Or shall i remove the commit of the .adoc?
Please note i renamed the unit test method in my last commit.

yeah the table in the adoc files are auto generated

@oscerd will get this merged

yeah, I'll take care of this later today :-)

Thanks. The PR has been merged. Can you please close this one? @davsclaus do we need to backport to 2.18.x too?

From my point of view, it would be really nice, if you backport it to 2.18.x.
I have a project where i need this behaviour, right now i am using a modified version of 2.18.2-SNAPSHOT.
Where i initially made this pull request for.

Closed as requested.
Thanks a lot. :)

The main problem in backporting is that we have a new option on the endpoint and usually we avoid this situation in minor release. By the way lets wait for @davsclaus

@oscerd i think in this case its safer as its a seldom used component and its a change that dont change any existing behavior.

Great, I'll backport then :-)

Very nice. Thank you.
For when is the 2.18.2 scheduled?
I somewhere saw its scheduled for beginning of 2017.

Probably later this month.

@marcusmesserkewill do you think you can still re-open the other PR for 2.18.x? I see a lot of conflicts.

i can do a new PR for 2.18.x if you want.
(Because for the master i changed the method names, to be more precise to its matter.

yes, @marcusmesserkewill if you can


Camera CC Shortcut Freezes iPhone 7

Meridian 003 here.
To avoid it, open flipcontrolcenter and swap camera with other switch eg : respring switch.
Using photoscan app by google also may freeze the system. Delete the app to avoid freezing.

I close this issue as it seems it resolves itself after removing flipcc, flipswitch and rocketbootstrap.


Load and Close Chrome Silently and driver.Stop crashing

Hi,
I am using Agouti to Scrape a web page. Everything It is working ok except that the chrome window remains opened after the processing is finished.
When I call driver.stop like this:
	if err := driver.Stop(); err != nil {
		log.Fatal("Failed to close pages and stop WebDriver:", err)
	}

I receive the error message:

Failed to close pages and stop WebDriver:failed to stop service: failed to stop command: TerminateProcess: Access is denied.

Why is the stop crashing?
Is this why the chrome window is not closed at the end ?
By the way I am opening like this:
func openSelenium(options ...agouti.Option) *agouti.WebDriver {
	command := []string{"java", "-jar", "<path>\\selenium-server-standalone-2.53.0.jar", "-port", "5555"}
	return agouti.NewWebDriver("http://<IP_ADDRESS>:5555/wd/hub", command, options...)
}

The Chromedriver is in the path.
Thanks

If I call
gomega.Expect(page.Destroy()).To(gomega.Succeed())
The browser is closed correctly.
But I still do not know how to instantiate Chrome silently.

Does calling page.Destroy() before driver.Stop() also fix the TerminateProcess: Access is denied error? That error indicates that Windows won't let you terminate the WebDriver process for some reason.
What do you mean by "instantiate Chrome silently?" Do you mean headlessly? Is this a separate issue, or is it related to the error?

No this is not a separate but an associated issue. I would like to instantiate chrome hidden, that is headlessly as you said and close at the end of the program.
My application will be installed in the users desktop so I would like to scrape the pages in silence, that is I do not want the user to see a popup, or even a minimized, chrome window to appear. At this time When I start my application a chrome window, sometimes, normally opened, other time mimized is displayed.
I can now close the browser window with:
gomega.Expect(page.Destroy()).To(gomega.Succeed())
I need now to start the browser without displaying any window, even minimized.
Can you help me ?
Thanks

On Linux this is possible via xvfb. On any OS, this is possible by running a headless VM that runs Chrome+Selenium.
Alternatively, you could use PhantomJS instead of Selenium. It works extremely well with Agouti (check out agouti.PhantomJS()), and runs (headlessly) on all common OSs.

You said "On any OS, this is possible by running a headless VM that runs
Chrome+Selenium"
I will run in Windows, how can I do it?
Thanks
On Mon, Jun 27, 2016 at 10:43 AM, Stephen Levine<EMAIL_ADDRESS>wrote:

On Linux this is possible via xvfb
https://gist.github.com/alonisser/11192482. On any OS, this is possible
by running a headless VM that runs Chrome+Selenium.
Alternatively, you could use PhantomJS instead of Selenium. It works
extremely well with Agouti (check out agouti.PhantomJS()), and runs
(headlessly) on all common OSs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sclevine/agouti/issues/76#issuecomment-228749193, or mute
the thread
https://github.com/notifications/unsubscribe/ABfj5qSsuA7x8p5ZRXxZSAR5ZgOoXo4Mks5qP9OVgaJpZM4I-HWb
.

Here's an example, but this solution is very heavy-weight.  I would strongly recommend PhantomJS for your use case.

I see, Maybe PahntomJS is better to work run headless, but do you think the
performance comparable to Selenium ?
I have a lot of pages to scrape, table with a lot of rows. I have tested
PhantomJs with CasperJS and the performance did not seemed to be good.
Working with Agouti+Selenium it seemed to have a better perfvormance.
I could start 5 goroutines and it worked ok.
I can test PhantomJS but I am not sure about its performance.
Thanks
On Mon, Jun 27, 2016 at 11:39 AM, Stephen Levine<EMAIL_ADDRESS>wrote:

Here's an example
http://www.chrisle.me/2013/08/running-headless-selenium-with-chrome/,
but this solution is very heavy-weight.  I would strongly recommend
PhantomJS for your use case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sclevine/agouti/issues/76#issuecomment-228765161, or mute
the thread
https://github.com/notifications/unsubscribe/ABfj5mjITXgBs5JCBIhitr6bDp8l5Gbyks5qP-CNgaJpZM4I-HWb
.

In my experience, PhantomJS is usually faster. I usually use it directly, without Selenium. It has very few dependencies, so it's a convenient dependency for an application that you distribute to users.

Ok.
I will try it out.
Thanks
On Mon, Jun 27, 2016 at 11:59 AM, Stephen Levine<EMAIL_ADDRESS>wrote:

In my experience, PhantomJS is usually faster. I usually use it directly,
without Selenium. It has very few dependencies, so it's a convenient
dependency for an application that you distribute to users.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sclevine/agouti/issues/76#issuecomment-228771507, or mute
the thread
https://github.com/notifications/unsubscribe/ABfj5p_cR6xnMQkXMXiAKik3ZHU3eqRJks5qP-U7gaJpZM4I-HWb
.

Just one more question.
I am using windows, installed PhantomJS and put in the %PATH%.
Now I am trying to start agouti with PhantomJS

Failed to start PhantomJS:failed to start service: failed to run command: exec: "phantomjs": executable file not found in %PATH%

I am executing the commands:
driver := agouti.PhantomJS()

	if err := driver.Start(); err != nil {
		log.Fatal("Failed to start PhantomJS:", err)
	}

But it is in the in %PATH%
Can you help me

Agouti calls exec.Command() with phantomjs as the command path. If a binary called phantomjs is in your OS path, it should work. If you can't get that to work, you could specify a custom command using agouti.NewWebDriver. Check out how agouti.PhantomJS works: https://github.com/sclevine/agouti/blob/master/agouti.go#L21

It was a problem with Intellij. For some reason I had to close and reopen
Intellij and it worked.
Thank you very much.
On Mon, Jun 27, 2016 at 12:34 PM, Stephen Levine<EMAIL_ADDRESS>wrote:

Agouti calls exec.Command() with phantomjs as the command path. If a
binary called phantomjs is in your OS path, it should work. If you can't
get that to work, you could specify a custom command using
agouti.NewWebDriver. Check out how agouti.PhantomJS works:
https://github.com/sclevine/agouti/blob/master/agouti.go#L21
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sclevine/agouti/issues/76#issuecomment-228782551, or mute
the thread
https://github.com/notifications/unsubscribe/ABfj5mEX-AkMxG1_USA6P4oid-FNywaJks5qP-1qgaJpZM4I-HWb
.


About apollo2.5 perception, how to use Lidar?

In Apollo 2.5,  it supports vision based perception with obstacle and lane mark detections. However, in non-highway scenario, such as city, how to enable Lidar for perception module ?
I cannot find any instruction in readme.

you can refer the configure file like modules/perception/conf/perception.conf

@mickeyouyou I saw perception.config, perception_lowcost.config, ... From my understanding, we can use Lidar or Radar+Camera solution by different perception*.config. Am I right ?
Another confusion. How can I setup to choose one of them ? modules/perception/conf/config_manager.config is missing in master branch after all.

Answer 1. yeah, you are right;
Answer 2. you can execute bash like this :scripts/perception_lowcost.sh or scripts/perception.sh

@mickeyouyou Got it. Thanks mate!


Microservice Demo Not Working. Build failure

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/microservice-tutorial/docker-image
Operating System: windows
C:\Users\swinterrowd\myMicroservice>docker build -t mymicroservice .
error during connect: Post http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.40/build?buildargs=%7B%7D&cachefrom=%5B%5D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=Dockerfile&labels=%7B%7D&memory=0&memswap=0&networkmode=default&rm=1&session=ijepzg6rki0deun0multd4yal&shmsize=0&t=mymicroservice&target=&ulimits=null&version=1: open //./pipe/docker_engine: The system cannot find the file specified. In the default daemon configuration on Windows, the docker client must be run elevated to connect. This error may also indicate that the docker daemon is not running.


command to change radio volume

https://github.com/qbcore-framework/qb-radio/issues/2

Needs testing

This is something that should be added to the resource that wants to modify it, not pma-voice, the /vol command will likely be removed eventually, and is expected to be set by the resource.


Small fix

We're still calling the file zerocoin_v3.cpp?

@reubenyap We will rename it in a future commit. It must be done in a separate commit, because otherwise git does not understand that it's the same file, just moved.


ci fix junkectomy

This includes both of these patches:

CI: retrieve keys for LLVM repo
port/page.c cleanup

Please CI be nice and let them pass. :)

no longer needed - back to the original PR #1019


Use MSI_VERSION instead of WinGetVersion in WinGet publishing script

@ItzLevvie pointed out that our automation was not setting the winget package version properly. Thanks, @ItzLevvie!
This PR fixes that issue.
What happened?
There was some back and forth over how we will structure version numbers when releasing to WinGet and Choco and it was ultimately decided that we'd follow the MSI versioning scheme. I updated the PR with that strategy but missed that variable. This corrects it so future release will have the correct variables in place.

/check-enforcer override


No way to remove/exclude GROUP BY section while saving slices

I am using Caravel 0.8.5 and looks like there is no way to create a simple table slice without the GROUP BY section.
While after  removing the entries from the GROUP BY section and hitting the QUERY button retrieves the data but saving the slice the default COUNT() gets added to the Metrics text box and as a result it fails with
Exception: Choose either fields to [Group By] and [Metrics] or [Columns], not both
We need a DELETE or OFF button for the GROUP BY section and for that matter even for the TIME section.

if you have field(s) in columns, you can't have one in metrics or groupby. Is metrics empty?

Thanks for responding.
I am trying to create a table view without any groupby/aggregations and selecting some the columns in the 'NOT GROUPED BY' section .
As I mentioned in my prev note, I can run the query and view the data during Edit, but the moment I save it, some default Metrics gets added and the columns that I selected before are gone.
Looks like while saving the left hand section is filling up with defaults and not persisting my selection.

I can reproduce this also in 0.8.8, can't debug it right now, but will do tomorrow unless solved by then!

@kartha01 you can kinda go around the problem at the moment by setting up the columns you want to use in the edit slicer view, then your slicer will be saved in the correct way and should show up nicely again.
If I have time I'll figure out a fix, please @mistercrunch promote this to bug 👍

The only workaround I found is to groupby all colums and have a unique key.
Still the same bug as Kartha01 described, doing something equivqwlent to 'Select Colum1, Column2,... from table" workds in edit mode but when I want to save some default metrics gets added causing the error choose between Group by and metric or not group by


update to 0.2.0

{package} {version} {:snowflake:}
Destination channel: {Snowflake | defaults}
Links

{ticket_number}
Upstream repository
Upstream changelog/diff
Relevant dependency PRs:

...

Explanation of changes:

...

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_5c17sq9nrz/clone` failed. (See above for error)
The following problems have been found:
===== ERRORS =====

clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
clone/recipe/meta.yaml:45: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:45: missing_dev_url: The recipe is missing a dev_url
===== Final Report: =====
3 Errors and 0 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_6d4tygn4bp/clone` failed. (See above for error)
The following problems have been found:
===== ERRORS =====

clone/recipe/meta.yaml:45: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:45: missing_dev_url: The recipe is missing a dev_url
clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
3 Errors and 0 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_040rk3c202/clone` failed. (See above for error)
The following problems have been found:
===== ERRORS =====

clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
1 Error and 0 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_99bew2vafv/clone` failed. (See above for error)
The following problems have been found:
===== ERRORS =====

clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
1 Error and 0 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_9fan1mamj8/clone` failed. (See above for error)
The following problems have been found:
===== ERRORS =====

clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
1 Error and 0 Warnings were found


mkxp 0+20160224 (new formula)

mkxp is an open source interpreter for games made with RPG Maker XP/VX/VX Ace.
There's no tagged release yet nor planned anytime soon (Ancurio/mkxp#30), but mkxp has been around for years and already distributed with a commercial game port like To the Moon, so I'd call it stable enough for packaging.
Dependencies are somewhat hardwired and that's another good reason to have this formula in the tap; it'd be quite a lot of work to have all deps ready and there's no latest binary release for OS X recently.

By the way, I couldn't come up with a good test case. Probably need an actual resource/script that exits automatically, but not sure how I could make/get one.

@BrewTestBot test this please

In that thread on Mac OS X building instructions, upstream says there are no plans for tagged releases, and stuff is still broken.

By the way, does mkxp have a plan to release any official version? It'd be nice to have a tagged release with some reasonable versioning scheme. Homebrew may not accept HEAD-only packages in their games tap.

Not in the near future. As long as vital functionality such as font rendering is still broken, it makes little sense to me to start maintaining releases. Besides that, I'd like to focus the little time I spent on the project on writing / fixing code instead of version bureaucracy.

I think that means this isn't going to make the cut for official Homebrew taps, and it should continue to live in your own tap until upstream is prepared to bless a labeled release.
I see you've got a formula here in your fork of the homebrew/games tap. I'd recommend creating a new tap of your own (e.g. tomyun/games-personal or tomyun/games-ty) independent of homebrew-games so it can be the root of its own fork network, and make it clear there are standalone formulae there.
Thank you for your submission, regardless!


Missing resources for lib2to3 and main package

Nuitka installation evironment: see #492
Nuitka build command:
poetry run python -m nuitka --standalone --python-flag=no_site --show-progress --show-scons blender_renderfarm

Crash traceback:
Traceback (most recent call last):
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\__main__.py", line 20, in <module>
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\fire\core.py", line 138, in Fire
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\fire\core.py", line 466, in _Fire
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\fire\core.py", line 675, in _CallAndUpdateTrace
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\__main__.py", line 9, in render
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\blender_renderfarm\__init__.py", line 4, in <module blender_renderfarm>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\blender_renderfarm\encoder.py", line 1, in <module blender_renderfarm.encoder>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\ffmpeg\__init__.py", line 2, in <module ffmpeg>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\ffmpeg\nodes.py", line 3, in <module ffmpeg.nodes>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\past\__init__.py", line 88, in <module past>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\past\translation\__init__.py", line 42, in <module past.translation>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\lib2to3\refactor.py", line 25, in <module>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\lib2to3\fixer_util.py", line 7, in <module>
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 668, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 638, in _load_backward_compatible
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\lib2to3\pygram.py", line 32, in <module>
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\lib2to3\pgen2\driver.py", line 158, in load_packaged_grammar
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\pkgutil.py", line 637, in get_data
  File "<frozen importlib._bootstrap_external>", line 916, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\git\\blender-renderfarm\\blender_renderfarm.dist\\lib2to3\\Grammar3.7.4.final.0.pickle'

Note: It is possible that the above is a bug connected with using Nuitka inside venvs, as I was unable to find these resources in my venv, and had to look for them in the system interpreter files instead. The source runs fine inside the venv.
Alongside the issue of some dependencies missing resources, the main package is missing them as well:
> .\blender_renderfarm.exe benchmark
Preparing for benchmark.
Traceback (most recent call last):
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\__main__.py", line 20, in <module>
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\fire\core.py", line 138, in Fire
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\fire\core.py", line 466, in _Fire
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\fire\core.py", line 675, in _CallAndUpdateTrace
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\__main__.py", line 17, in benchmark
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\blender_renderfarm\__init__.py", line 16, in construct_farmspec
  File "D:\git\blender-renderfarm\blender_renderfarm.dist\pkgutil.py", line 637, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\git\\blender-renderfarm\\blender_renderfarm.dist\\blender_renderfarm\\resources\\bench.blend'

Actually pkgutils.get_data ought to be our best friend, because we will often be capable of analysing it at compile time.
That sender, renderfarm usage is not generally interesting, and you have to copy your own data files for now, although as I mentioned above, a plugin of Nuitka ought to inform you about those or statically analyse them.
As for lib2to3, is it really using that, or just happening to import it? I need to check it out, but I assume a simple addition to the data files plugin will do. Unfortunately I don't have a reproducer.
Yours,
Kay

The lib2to3 error seems to be a thing with Python Fire (the library it's using to construct the CLI), the package itself isn't using it directly.
I honestly did not understand what exactly you meant by this line:
That sender, renderfarm usage is not generally interesting

but if I understand that whole part correctly, resource files from the package have to be copied manually...?
That is something I can live with as that's easy to automate, but that lib2to3 issue (and actually I had an issue with Tk and Tcl missing it's files too) ought to be investigated more fully. I'll see what I can do to reproduce the issues.

Ok, Nuitka successfuly warns if Tk is imported in the main_module file, but it does not warn at all, if Tk is imported inside a call in a separate file, even if all main_module does is import that call from that other file and calls it.
tk_test.py
from tk_test2 import main

main()

tk_test2.py
def main():
    from tkinter import Tk

    Tk().withdraw()

Crash output:
> .\tk_test.dist\tk_test.exe
Traceback (most recent call last):
  File "D:\git\blender-renderfarm\tk_test.dist\tk_test.py", line 3, in <module>
  File "D:\git\blender-renderfarm\tk_test.dist\tk_test2.py", line 4, in main
  File "D:\git\blender-renderfarm\tk_test.dist\tkinter\__init__.py", line 2023, in __init__
_tkinter.TclError: Can't find a usable init.tcl in the following directories:
    D:/git/blender-renderfarm/lib/tcl8.6 D:/git/blender-renderfarm/lib/tcl8.6 D:/git/lib/tcl8.6 D:/git/blender-renderfarm/library D:/git/library D:/git/tcl8.6.9/library D:/tcl8.6.9/library

This probably means that Tcl wasn't installed properly.

And no warning from Nuitka in relation with lib2to3
l23_test.py
import lib2to3.pgen2.driver

lib2to3.pgen2.driver.load_packaged_grammar("lib2to3", "Grammar")

Crash output:
> .\l23_test.dist\l23_test.exe
Traceback (most recent call last):
  File "D:\git\blender-renderfarm\l23_test.dist\l23_test.py", line 3, in <module>
  File "D:\git\blender-renderfarm\l23_test.dist\lib2to3\pgen2\driver.py", line 158, in load_packaged_grammar
  File "D:\git\blender-renderfarm\l23_test.dist\pkgutil.py", line 637, in get_data
  File "<frozen importlib._bootstrap_external>", line 916, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\git\\blender-renderfarm\\l23_test.dist\\lib2to3\\Grammar3.7.4.final.0.pickle'

There is a fix for this on the factory branch.
https://nuitka.net/doc/factory.html

By the way, Poetry installs the project into the venv as an editable dependency. Shouldn't that help Nuitka bundle resource files into the resulting dist?

Part of the latest pre-release rc6.

@kayhayen lib2to3 or package resources?

Released as part of 0.6.6


128.0.1esr attach picture from screenshot not working

In Thunderbird 128.0.1esr  with add-on 1.128.4 the function to attatch a screenshot (e.g. by ALT+print) is not working anymore. Copying of files via CTRL+C is working.
It would be great if this function could be repaired because this was my main usage. THE ADD-ON IS GREAT!
THX in ADVANCE from Kiel

This is copy of my issue raised here #15
Hi, I am on on TB 128.1.0esr (64-bit)
Add in version is 1.128.4 Last Updated 19 August 2024 installed directly from TB or from file
All other add-ins disabled - no difference
No action when "paste from Clipboard" triggered either from the dropdown or menu bar
While I have limited knowledge about debugging TB I opened the debug add-in and got
Paused on exception : TypeError: Cc['@mozilla.org/embedcomp/prompt-service;1'] is undefined in line 106 of overlay.js
var promptService = Cc["@mozilla.org/embedcomp/prompt-service;1"].getService(Ci.nsIPromptService);

forgot to add stack

and console

Originally posted by @R00118189 in https://github.com/mganss/AttachFromClipboard/issues/15#issuecomment-2296442583

Fixed in upcoming version 1.128.5, currently under review at Mozilla.


improve travis

ok apparently it is impossible to upgrade travis' glibc. the self extracting arxive is compiled with a very new gcc apparently and so it cannot work. Any ideas @mattmilten

It's not that I didn't try something similar and also failed miserably...

You might want to check out the test-debian branch.
https://github.com/SCIP-Interfaces/PySCIPOpt/blob/test-debian/.travis.yml

I've seen somewhere that we might need to specify the GCC or CC variables to point to the new gcc. I can't find it right now, though.


haskellPackages.cryptonite: fix for aarch64 and re-enable tests

Motivation for this change
cryptonite has been dontCheck for nearly 3 years:
https://github.com/NixOS/nixpkgs/commit/358db2a22c03570e14bde625b9067c6ac36e95e3
but the test failures that led to that nixpkgs commit were fixed upstream around the same time:
https://github.com/haskell-crypto/cryptonite/issues/28
The first patch in this series re-enables tests for cryptonite.
Meanwhile, cryptonite-0.25 has a bug on aarch64 that was not caught because the tests are disabled. It only manifested in test failures on that arch in tls. The fix for this issue has been committed upstream, but no release has been made since, so the second patch in this series cherry-picks the commit from cryptonite upstream for aarch64. The fix is guarded by a check for that architecture, so it does not impact other architectures.
As an aside, a package like cryptonite seems like a very dangerous one to leave dontCheck for so long. Probably there should be some way to revisit, from time to time, packages whose tests have been disabled. One idea would be to run an occasional Hydra build where dontCheck is a no-op.
/cc @srhb
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-darwin (full log)
Attempted: haskellPackages.cryptonite
Partial log (click to expand)
Preprocessing test suite 'test-cryptonite' for cryptonite-0.25..
installing
Installing library in /nix/store/45irdmpc50ljvkg8c12as3mrhxksk333-cryptonite-0.25/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/cryptonite-0.25-7qwunXemDhaBfXM5ItvYSJ
post-installation fixup
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/45irdmpc50ljvkg8c12as3mrhxksk333-cryptonite-0.25/lib
patching script interpreter paths in /nix/store/45irdmpc50ljvkg8c12as3mrhxksk333-cryptonite-0.25
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/r934sxg9w5igbpr0kw1axkgg5qbm7pkp-cryptonite-0.25-doc
/nix/store/45irdmpc50ljvkg8c12as3mrhxksk333-cryptonite-0.25

Success on x86_64-linux (full log)
Attempted: haskellPackages.cryptonite
Partial log (click to expand)
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vdy9gzbgi58czhgglx9si131wp6ly6n1-cryptonite-0.25/lib
patching script interpreter paths in /nix/store/vdy9gzbgi58czhgglx9si131wp6ly6n1-cryptonite-0.25
checking for references to /build in /nix/store/vdy9gzbgi58czhgglx9si131wp6ly6n1-cryptonite-0.25...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/kpchfabp4m6bcqqcxyfd9kkv443x40ls-cryptonite-0.25-doc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/kpchfabp4m6bcqqcxyfd9kkv443x40ls-cryptonite-0.25-doc
checking for references to /build in /nix/store/kpchfabp4m6bcqqcxyfd9kkv443x40ls-cryptonite-0.25-doc...
/nix/store/vdy9gzbgi58czhgglx9si131wp6ly6n1-cryptonite-0.25

Thanks!


Ability to invert selection

This pull request adds the keybind F to invert the current selection.
There is a check to make sure that the selection can be inverted while staying within 5 selected cards.

I really like this idea! I think I might hold off on merging it in just yet, want to get baseline stuff implemented for all the buttons. Then add more complex "macros" like this.


Prevent discriminator columns from failing with in-memory database

Issue #4285
The default, provider-agnostic, value generator was setup to always generate temporary values. This was a carry over from when we required this so that entities could be added in any order, but that behavior was changed and so always generating temporary values is no longer needed.
The default value generator now doesn't generate temporary values, which may not be handled by the provider--such as is the case for in-memory. Where possible default value generators are still supplied that make use of GUIDs. One of these now gets used in this scenario.
This change doesn't really fix the problem that structural changes made to the model by a provider may not be handled correctly by other providers, but it fixes the issue at hand.

:shipit:


Add Variant Token

I will not ping the Discord about this pull request.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR
At minimum each entry should have
Token Address: 9ysRLs872GMvmAjjFZEFccnJBF3tYEVT1x7dFE1WPqTY
Token Name: Variant
Token Symbol: VRNT
Logo https://i.postimg.cc/FKZmqwXL/logo.jpg
Link to the official homepage of token: https://www.variantresearch.io
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Hello, I could use some help. Is there anything else I need to do for this?

Please include website, logo should be uploaded to this repo, and use valid tags defined on the top of the token list


[Retox] Preliminary: Architecture

The first step of Retox: Planning and deciding on our desired architecture - short and long term.

I see this is under "done", and I'm not sure why 😅
I think we should roll this over to the next iteration

Following the numerous discussions on this - I think we are now in a place to say that this specifically can be closed, and that the whole epic should be "rebranded" to fit a long-term goal that is more apt. (Detox cloud?)