Logs truncated

The training log in this run is truncated halfway.
https://app.wandb.ai/yaroslavvb/nccl_multiversion/runs/xf2u0a1t/logs
However, in my terminal things look fine
#
#                                                     out-of-place                       in-place
#       size         count    type   redop     time   algbw   busbw  error     time   algbw   busbw  error
#        (B)    (elements)                     (us)  (GB/s)  (GB/s)            (us)  (GB/s)  (GB/s)
ip-172-31-3-63:38231:38231 [0] NCCL INFO Launch mode Parallel
           8             2   float     sum    147.8
wandb: Waiting for W&B process to finish, PID 38094
0.00    0.00  2e-07    145.9    0.00    0.00  1e-07
          16             4   float     sum    146.7    0.00    0.00  0e+00    148.7    0.00    0.00  1e-07
          32             8   float     sum    145.4    0.00    0.00  1e-07    145.2    0.00    0.00  1e-07
          64            16   float     sum    148.3    0.00    0.00  1e-07    146.2    0.00    0.00  6e-08
         128            32   float     sum    153.3    0.00    0.00  6e-08    145.7    0.00    0.00  6e-08
         256            64   float     sum    147.0    0.00    0.00  6e-08    145.0    0.00    0.00  6e-08
         512           128   float     sum    147.6    0.00    0.01  6e-08    147.5    0.00    0.01  6e-08
        1024           256   float     sum    153.0    0.01    0.01  2e-07    151.6    0.01    0.01  2e-07
        2048           512   float     sum    155.2    0.01    0.02  2e-07    154.3    0.01    0.02  2e-07
        4096          1024   float     sum    156.9    0.03    0.05  5e-07    156.1    0.03    0.05  5e-07
        8192          2048   float     sum    157.9    0.05    0.10  5e-07    159.3    0.05    0.10  5e-07
       16384          4096   float     sum    160.9    0.10    0.19  5e-07    160.3    0.10    0.19  5e-07
       32768          8192   float     sum    171.6    0.19    0.36  5e-07    169.6    0.19    0.36  5e-07
       65536         16384   float     sum    190.2    0.34    0.65  5e-07    187.6    0.35    0.66  5e-07
      131072         32768   float     sum    220.1    0.60    1.12  5e-07    219.1    0.60    1.12  5e-07
      262144         65536   float     sum    493.8    0.53    1.00  5e-07    481.1    0.54    1.02  5e-07
      524288        131072   float     sum    627.1    0.84    1.57  5e-07    623.3    0.84    1.58  5e-07
     1048576        262144   float     sum   1179.2    0.89    1.67  5e-07   1198.1    0.88    1.64  5e-07
     2097152        524288   float     sum   1880.3    1.12    2.09  5e-07   1864.5    1.12    2.11  5e-07
     4194304       1048576   float     sum   2748.1    1.53    2.86  5wandb: Program ended successfully.
e-07   2695.8    1.56    2.92  5e-07
     8388608       2097152   float     sum   4628.4    1.81    3.40  5e-07   4606.3    1.82    3.41  5e-07
    16777216       4194304   float     sum   8202.9    2.05    3.83  5e-07   8201.6    2.05    3.84  5e-07
    33554432       8388608   float     sum    15366    2.18    4.09  5e-07    15431    2.17    4.08  5e-07
    67108864      16777216   float     sum    25315    2.65    4.97  5e-07    25285    2.65    4.98  5e-07
   134217728      33554432   float     sum    50201    2.67    5.01  5e-07    50372    2.66    5.00  5e-07
   268435456      67108864   float     sum   100369    2.67    5.01  5e-07   100327    2.68    5.02  5e-07
   536870912     134217728   float     sum   200402    2.68    5.02  5e-07   200552    2.68    5.02  5e-07
<PHONE_NUMBER>     268435456   float     sum   401202    2.68    5.02  5e-07   400422    2.68    5.03  5e-07
# Out of bounds values : 0 OK
# Avg bus bandwidth    : 1.71812
#

wandb: Run summary:
wandb:           NCCL_HOME /home/ec2-user/nccl/...
wandb:    NCCL_VERSION_TAG 2.4.6
wandb:            _runtime 84.59366464614868
wandb:          _timestamp<PHONE_NUMBER>.8924124
wandb:             SIZE_MB 1024
wandb:            NUM_GPUS 16
wandb:           NPER_NODE 8
wandb:           CUDA_HOME /usr/local/cuda-10.0...
wandb:           ofi_patch False
wandb:            EFA_HOME /opt/amazon/efa
wandb:              do_efa 1
wandb:         FOLDER_ROOT /home/ec2-user/nccl/...
wandb:               _step 1
wandb:            MPI_HOME /home/ec2-user/anaco...
wandb:   avg_bus_bandwidth 1.71812
wandb: Syncing files in wandb/run-20190607_173547-xf2u0a1t:
wandb:   description.md
wandb:   diff.patch
wandb:   output.log
wandb: plus 5 W&B file(s) and 0 media file(s)
wandb: - 5 of 8 files, 37277.000 of 41750.000 bytes uploaded
wandb: \ 6 of 8 files, 37315.000 of 41750.000 bytes uploaded
wandb: | 6 of 8 files, 37315.000 of 41750.000 bytes uploaded
wandb: / 6 of 8 files, 37315.000 of 41750.000 bytes uploaded
wandb: - 6 of 8 files, 37315.000 of 41750.000 bytes uploaded
wandb: \ 6 of 8 files, 37315.000 of 41750.000 bytes uploaded
wandb: | 6 of 8 files, 37315.000 of 41750.000 bytes uploaded
wandb:
wandb: Synced bench-16-efa-stock: https://app.wandb.ai/yaroslavvb/nccl_multiversion/runs/xf2u0a1t

Here's the code that was used to log the run above https://github.com/cybertronai/aws-network-benchmarks/blob/b89e25b098c33094faa48541e5dde17e154327d7/nccl_multiversion.py#L251

The thing to note is that the value "1.718" shows up, this could be a buffering issue, will try with  PYTHONUNBUFFERED=1 for future runs

Really appreciate the bug report.  I was taking a quick look at your reference code and I noticed you have your AWS keys in there - I think you probably want to take those out as the code is public.

AWS makes it really easy to leak credentials, don't they. Those are fake keys though :)

BTW, I noticed in my console logs it says " 2.86  5wandb: Program ended successfully", and this is exactly when the web logs cut off.

One possibility is that this has something to do with doing multiple runs in a row, I was doing run/crash/run/crash/run/etc , ie what triggers "wandb: Program ended successfully"?

That’s triggered when your script exits, we add an exit hook to your script
that tells the wandb process how you’ve exited.  I thought we flush the
stdout buffer, but it looks like we don’t.  Can you try calling
sys.stdout.flush right before your process exits?  It’s also possible work
is happening in threads so those need to be joined before the parent
exits...
On Sat, Jun 8, 2019 at 5:58 PM Yaroslav Bulatov<EMAIL_ADDRESS>wrote:

One possibility is that this has something to do with doing multiple runs
in a row, I was doing run/crash/run/crash/run/etc , ie what triggers
"wandb: Program ended successfully"?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wandb/client/issues/368?email_source=notifications&email_token=AAAAAEITKR5SNSFHOERYQU3PZPJLDA5CNFSM4HVZNEY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHXKDY#issuecomment-500135183,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAAAELHIYZPMQDNQ6HBDB3PZPJLDANCNFSM4HVZNEYQ
.

Will try that. Normally you don't need a flush because default behavior flushes after each print, but a possibility was that os.dup2 modified buffering behavior of stdout stream. I needed output of the command inside inside the script, so I was doing the following.
The solution on wandb side would be to flush stdout/stderr streams before exiting
class capture_stdout:
  """Utility to capture output, use as follows
     with util.capture_stdout() as stdout:
        sess = tf.Session()
    print("Captured:", stdout.getvalue()).
    """

  def __init__(self, fd=STDOUT):
    self.fd = fd
    self.prevfd = None

  def __enter__(self):
    t = tempfile.NamedTemporaryFile()
    self.prevfd = os.dup(self.fd)
    os.dup2(t.fileno(), self.fd)
    return TemporaryFileHelper(t)

 def __exit__(self, exc_type, exc_value, traceback):
   os.dup2(self.prevfd, self.fd)
   print("Running command:")

print(args.internal_cmd)
with util.capture_stdout() as outfile:
    os.system(args.internal_cmd)

# print logs so they show up in console
out: str = outfile.getvalue()
print(out)

We may have fixed this in the most recent release 0.8.2.  If you're still seeing it would you mind making a simple script that exhibits the lost logs?

seems to be fixed for me as well


How do I run the project locally to add an L2 network?

Hello everyone
Can you please tell me how to run the project locally to add my L2 network?
What configurations are required?
I want to connect my own contracts.

@dmitrii602 new networks are a paid integration.
Please see Superbridge.app/Rollies for more info


Recommended fork?

I have forked and maintained this library for a while now.   I've fixed several bugs and added a bunch of new features. The trunk is sort of in flux but I'm going to clean it up soon.
https://github.com/Steve132/pybitcointools

I have made a similar Python 3.6+ library that supports segwit. You can find it here: https://github.com/mcdallas/cryptotools

For a comparison by stars/downstream forks/activity, see
http://forked.yannick.io/vbuterin/pybitcointools


fix: Fix codecov post job

Fix silent error happening in CI. Example
[2023-12-11T19:59:53.180Z] ['error'] There was an error running the uploader:
Unable to detect SHA and slug, please specify them manually.
See the help for more details.

Reference https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/branch-ci-openshift-oadp-operator-master-unit-test-post/1734300664726556672/artifacts/unit-test-post/unit/build-log.txt

/override ci/prow/4.12-e2e-test-aws
/override ci/prow/4.12-e2e-test-azure
/override ci/prow/4.13-e2e-test-azure
No e2e, or operator change.

/lgtm


Rtctortmp

srs维护者你好：
基于srs birdger的理念实现了rtc转rtmp的功能。包括opus转码aac，h264使用jitterbuffer组帧的功能。
issue：
#2200

Codecov Report

Merging #2252 (0f02ab5) into develop (7c2cc4f) will decrease coverage by 0.44%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2252      +/-   ##
===========================================
- Coverage    55.55%   55.11%   -0.45%
===========================================
  Files          126      126
  Lines        55494    55887     +393
===========================================
- Hits         30832    30801      -31
- Misses       24662    25086     +424

Impacted Files
Coverage Δ

trunk/src/app/srs_app_config.cpp
64.69% <0.00%> (-0.16%)
:arrow_down:

trunk/src/app/srs_app_config.hpp
100.00% <ø> (ø)

trunk/src/app/srs_app_rtc_codec.cpp
0.00% <0.00%> (ø)

trunk/src/app/srs_app_rtc_jitbuffer.cpp
0.00% <0.00%> (ø)

trunk/src/app/srs_app_rtc_jitbuffer.hpp
0.00% <ø> (ø)

trunk/src/app/srs_app_rtc_source.cpp
9.13% <0.00%> (-3.06%)
:arrow_down:

trunk/src/app/srs_app_rtc_source.hpp
0.00% <ø> (ø)

trunk/src/app/srs_app_source.cpp
0.74% <0.00%> (-0.01%)
:arrow_down:

trunk/src/kernel/srs_kernel_rtc_rtp.hpp
27.69% <0.00%> (-0.44%)
:arrow_down:

trunk/src/app/srs_app_rtc_dtls.cpp
69.77% <0.00%> (-0.21%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2cc4f...0f02ab5. Read the comment docs.

Fixed by https://github.com/ossrs/srs/tree/feature/rtc2rtmp

Fixed by #2303


[DOCS] Examples of extending webpack configuration

The PWA Kit ships with a default Webpack configuration that can be extended:
https://github.com/SalesforceCommerceCloud/pwa-kit/blob/develop/packages/pwa-kit-dev/src/configs/webpack/config.js
Generally the pattern is to define your own webpack.config.js at your project root:
// webpack.config.js
const config = require('@salesforce/pwa-kit-react-sdk/configs/webpack/config')
const [client, ssr, rendered, clientOptional, requestProcessor]

// do whatever you want with config

module.exports = config

Extending the config can be useful for adding support for alternative webpack features like the ability to directly use CSS:
// webpack.config.js
const config = require('@salesforce/pwa-kit-react-sdk/configs/webpack/config')
const MiniCssExtractPlugin = require('mini-css-extract-plugin')

config.forEach((c) => {
    c.module.rules.push({
        test: /\.(sa|sc|c)ss$/,
        use: [MiniCssExtractPlugin.loader, 'css-loader']
    })
    c.plugins.push(new MiniCssExtractPlugin({filename: '[name].css'}))
})

module.exports = config

It would be great if we created documentation showing how to do this for common examples.

@johnboxall same... looks like this might help us: https://github.com/SalesforceCommerceCloud/pwa-kit/issues/1523


Add zone files parsing and loading tests

The ariadne::nameserver::zones module should be completed with unit testing.

Hi, I'd like to give this a shot.

Hello, @kastolars. Sure! I think you can open a draft PR and work on that.


[BUG]: INSTALLING EXPENSES

Describe the bug
ImportError: Module import failed for Expenses Entry, the DocType you're trying to open might be deleted.
Error: cannot import name 'ACCOUNT' from 'expenses.libs' (apps/expenses/expenses/libs/init.py)
To Reproduce
Steps to reproduce the behavior:

cd ~/frappe-bench
bench get-app https://github.com/kid1194/erpnext_expenses
bench --site [sitename] install-app expenses

Expected behavior
A clear and concise description of what you expected to happen.
Installing expenses...
Updating DocTypes for expenses      : [==                                      ] 6%An error occurred while installing expenses: Module import failed for Expenses Entry, the DocType you're trying to open might be deleted. Error: cannot import name 'ACCOUNT' from 'expenses.libs' (/home/iak/frappe-bench/apps/expenses/expenses/libs/init.py)
Traceback with variables (most recent call last):
File "apps/frappe/frappe/commands/site.py", line 462, in install_app
_install_app(app, verbose=context.verbose, force=force)
context = {'sites': ['bollexmedia.com'], 'force': False, 'verbose': False, 'profile': False}
apps = ('expenses',)
force = True
_install_app = <function install_app at 0x7f95cc7a4ae0>
filelock = <function filelock at 0x7f95cc79eca0>
exit_code = 0
Additional context
Frappe and ERPNEXT Version 15
Add any other context about the problem here.

@iakah Hey bro, thank you for reporting this problem..
I have updated the plugin and I hope that it works well for you, but if doesn't please inform me..
I really appreciate your patience and giving the plugin another try..
Best regards..

Hello @kid1194  thank you for the swift response. I  have tried it again and although now the migration is stopping at 12% instead of the previous 6%, it's still bringing the same error.  Kindly see below.
Installing expenses...
Updating DocTypes for expenses      : [=====                                   ] 12%An error occurred while installing expenses: Module import failed for Expense Type Account, the DocType you're trying to open might be deleted. Error: cannot import name 'ACCOUNT' from 'expenses.libs' (/home/iak/frappe-bench/apps/expenses/expenses/libs/init.py)
Traceback with variables (most recent call last):
File "apps/frappe/frappe/commands/site.py", line 462, in install_app

@iakah Thank you bro for giving it another try and for reporting the error..
I just want to as if you have ERPNext installed or not?
Because the "Account" Doctype that is mentioned in the error belongs to ERPNext..
Best regards..

Hi @kid1194 , yes I have erpnext installed.

@iakah Thank you bro for your response..
Can you please give it another try. I hope it gets installed this time..
And I hope that you like my small gesture of appreciation by adding your name in the list of contributors..
Best regards..

Hi @kid1194 thank you for the gesture and for your help debugging the application.
It has now been installed but however, there is one last validation error. kindly see below.
...................................................................................
App erpnext already installed
Installing expenses...
Updating DocTypes for expenses      : [========================================] 100%
An error occurred while installing expenses: Cannot change state of Cancelled Document. Transition row 14
Traceback with variables (most recent call last):

@iakah Thank you for reporting this bro..
I have fixed workflow transition and now it should work..
So, kindly please give it another chance and try installing it again..
Best regards..

It now works, thank you @kid1194, your response is swift and Kudos for the great work.

@iakah I'm glad to hear that it worked..
If you find any bug please let me know and I will be happy to fix it..
Best regards..

Hi @kid1194 , I found the following bugs on accessing it under accounting module.....

[Expense Attachment ]
,[Expense Item Account ]
,[Expense Type Account ]
,[Expenses Entry Details ]
,[Expenses Request Details ]
and Expenses Update Receiver pages are missing.
Under new expense type I get the following error:  ### App Versions

{
	"erpnext": "15.10.1",
	"expenses": "1.0.0",
	"frappe": "15.9.0"
}

Route
Form/Expense Type/new-expense-type-upjxfthbps

Traceback
Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 110, in application
    response = frappe.api.handle(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
           ^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/__init__.py", line 1682, in call
    return fn(*args, **newargs)
           ^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/expenses/expenses/libs/type.py", line 28, in type_form_setup
    "has_accounts": get_types_with_accounts("Expense Type")
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: get_types_with_accounts() takes 0 positional arguments but 1 was given

Request Data
{
	"type": "POST",
	"args": {},
	"freeze": false,
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/expenses.libs.type_form_setup",
	"request_id": null
}

Response Data
{
	"exception": "TypeError: get_types_with_accounts() takes 0 positional arguments but 1 was given",
	"exc_type": "TypeError",
	"_exc_source": "expenses (app)"
}

@iakah Hey bro, a million thanks for reporting this..
It seems that the app wasn't fully installed.
I have fixed the bug so please give it another try and check if these doctypes exist after install or not..
Please let me know if you face any problem..
Best regards..

Hi @kid1194 , the doctypes have still not yet showed.

@iakah Sorry bro about that..
I suspect the cleanup code that is run before install and after uninstall..
I have made small changes in that code and I hope that it fixes the problem because I haven't found anything that might cause such problem..
Please give it another try and try to uninstall it first then install again..
I will be waiting patiently for your response..
Thanks a lot again and again..
Best regards..

@iakah Hey bro..
I just wanted to know if you managed to install the expenses app or not?
Best regards..

Hello Bruv, I managed to install it..however, there are some issues..., the following pages are missing when I click the following.. [Expense Attachment ]
,[Expense Item Account ]
,[Expense Type Account ]
,[Expenses Entry Details ]
,[Expenses Request Details ]
and Expenses Update Receiver pages are missing.
Moreover, Under new expense type I get an error: ###
{
"exception": "TypeError: get_types_with_accounts() takes 0 positional arguments but 1 was given",
"exc_type": "TypeError",
"_exc_source": "expenses (app)"
}

Also the new expense entry page seems to be blank

thank you for reaching out @kid1194. Lets work on these.

@iakah Hey bro..
Thanks for your reply..
I think that the problem is because bench is installing the app from cache which is not the updated version from github..
So can you please fully uninstall the app using the following commands and then install it again..
Uninstall

Go to bench directory

cd ~/frappe-bench

Uninstall plugin from your site

bench --site [sitename] uninstall-app expenses

(Optional) Remove plugin from bench

bench remove-app expenses

(Optional) Restart bench

bench restart

But if you don't have bench access then let me know so I can find another way..
Best regards..

Hello @kid1194 , I have followed the above commands and also deleted the archived apps still to no luck....
What might be the problem?
Let me know what you need so that we can solve this.

@iakah Thank you for your great response..
I have made some modifications that I hope will fix this problem..
So please kindly give it another try..
Best regards..

thanks, the problem hasn't been fixed yet

@iakah Hey bro..
Can you please give it another try. I have checked the whole code and I made some changes, so hopefully it works this time..
If it doesn't, then sadly I can say that I have no idea about what is causing this problem..
Best regards..

@iakah Hey buddy..
I have made a lot if changes to the module and it is working without any problem, unless I have missed something..
So please give it another try and let me know if you face any problem..
Best regards..


Encapsulate Recipient a bit better.

The Recipient model is a bit of an implementation detail, and we want to make it easier to optimize things like stream searches in the future.

Merged, thanks @showell!  This is definitely a nicer abstraction for most of these call points.


Blank  tags when content contains a table at start

When the content contains a table as the first element (or only element), clicking at the start of the table automatically creates a

 node at the start.
When trying to delete the resulting gap from that node, more such nodes are just added to the start.
I have verified this bug in Chrome 39 and Firefox 33.1.1.

This happens in the example as well: https://guardian.github.io/scribe/ . When all the content is deleted, the result is not an empty string but

.
Is there a way to remove the wrapping

 tags?
Thanks for this great library.


[subnet-visualizer] Invalid HTML

In the infinite scrolling subnet visualizer, I noticed that a <div> is used to load pages, but that <div> is inside a <ul> element, which makes it not valid HTML. We should change the structure of the HTML so that it's valid.
We can use something like <section> > <div> > <a> (instead of <ul> > <div> > <li><a>.
CC: @pawelplsi

@nemesisdesign , I checked the templates but found the <ul>  within <div> and not viceversa at changeform.html. It maybe that I am viewing the wrong template, if so can you please tell me the correct one :)

@nepython It's not in a template, these divs are added dynamicaly by a script.
Anyway, I am working on solving it right now.


Update MemberUpdate Count Logic and Optimization (Old 293)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:07
MemberUpdate currently checks count<1 && debug, add option for count<1 && !debug.
Add eager loading.

In gitlab by @A-Lawrence on Aug 31, 2015, 01:09
mentioned in issue #229

In gitlab by @A-Lawrence on Aug 31, 2015, 01:10
mentioned in issue #248

In gitlab by @A-Lawrence on Aug 31, 2015, 01:13
Fixed in lines 133 and 134 of 584f7f179d5b - if a member in Cert only had one name, it wouldn't process.
NFarrington - 2015-03-02T18:45:52.731419+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:13

need to be fixed.

The members themselves, or our data?
ALawrence66 - 2015-02-28T00:15:50.585854+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:13
MemberUpdate - check count correctly, debug output correctly, eager loading, one-name members; resolves #488443 (293)
ÔåÆ <<cset 584f7f179d5b>>
NFarrington - 2015-02-28T00:14:40.518593+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:13
Members who have one name missing also need to be fixed.
NFarrington - 2015-02-27T23:57:44.771633+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:13
Also update output so only when debug is enabled.
NFarrington - 2015-02-27T23:54:57.751603+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:16
mentioned in issue #241

In gitlab by @A-Lawrence on Aug 31, 2015, 01:16
mentioned in issue #248

In gitlab by @A-Lawrence on Aug 31, 2015, 01:16
mentioned in issue #250

In gitlab by @A-Lawrence on Aug 31, 2015, 01:16
mentioned in issue #252


Speedml.eda() function failed to identify Numerical Continuous features

Using the titanic data sets, Speedml.eda() function failed to recognize or identify "Numerical Continuous" features.  I'm assuming it should have identified "Age" and "Fare" as "Numerical Continuous".  "Age" and "Fare" were identified by pandas as being of type float64 per my notebook gist.

Yes. That is as intended. I was surprised as well at first. See, I have a 90% unique values threshold setup for continuous variables. Age only has  88 unique of 891 values and Fare has 248 of 891. So lots of repetition. Should the threshold be lower? Should I make the threshold user configurable? Is this even a fair assessment of how we define continuous versus high-cardinality? I will leave this discussion open for other users to chime in.

Also note that there is a significant jump in model accuracy (250+ leaderboard positions jump) when I use Age and Fare as high-cardinality variables and apply sml.feature.density() method on them. See the companion notebook if this analysis makes more sense or I need to change my assumptions. https://github.com/Speedml/notebooks/blob/master/titanic/titanic-solution-using-speedml.ipynb

Side note on your gist.

You do not need to add following code. Speedml adds it for you.

%matplotlib inline
import matplotlib.pyplot as plt

Do you still get the deprecation warning after refreshing the notebook and running 0.9.2?

@manavsehgal  Thank you for the explanation concerning the numerical continuous variables.
As for the deprecation, I later realized I no longer need to add the imports.  Without them, I no longer have the deprecation warning.  So no issue there.
The demo that shows the Titanic solution using Speedml is a good example.  I would recommend adding a direct link to it in your main readme to reduce the need to find it in the "Demo" hyperlink.  This is THE example that showcases the use case justification for Speedml very well.  So I think it would be beneficial to make this example highly visible somehow in the readme.  Just my opinion.
Thanks again and for your quick response!

Great recommendation. I will add it to readme next!


evacuation

Some level of workload migration is desirable.  At a minimum the cloud administrator may want to take a compute node offline for maintenance.  They could issue an evacuate command, which would result in the scheduler needing to choose a new compute node on which to run each workload on the node to be evacuated.  We have ideas on how to implement this crudely (stop/restart) and more kindly (live migration), but have not yet had time to fully architect and implementation.

Fixed by PR
https://github.com/ciao-project/ciao/pull/1429


Use client's translated name and Allow custom PLAYER_REPUTATION as bar or number

Use client's translated name for VILLAGER_PROFESSION and INVENTORY_CONTENTS
Allow custom PLAYER_REPUTATION as bar or number

As a heads up I'm rewriting this plugin on VillagerInfo-Rewrite but this PR was definitely worth implementing before that gets finished lol


Report number of handles / file descriptors held by processes

It would be nice to be able to report the number of handles (Windows) or file descriptors (*nix) in the process metrics.  I can implement the Linux side of things easily and with some trying might be able to manage the OpenBSD and Darwin implementation.  I would much appreciate someone with more experience with C doing those though.  I haven't looked into the Windows side of things yet.

Linux/FreeBSD have been implemented. It would be nice to have the number of handles open by Windows processes. I don't think there are hard/soft limits in Windows.


Cu 21prurx add my own facts to the overall graph

I way underbid this one in the planning process. :(

Task linked: CU-21prurx Add my own facts to the overall graph


New version: Bitwarden.Bitwarden version 2024.7.0

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@mdanish-kh this PR is an error, the specified version was pulled back and doesn't exist
can we revert this PR?


[issue-5943] upgrade to xerces 2.12.2

Description
This PR...

Fixes: #5943

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[X] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2474

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3189)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36707 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5944-t3189-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File


Fix overdue marking of closed issues and milestones

Closed milestones and issues should only be marked overdue if they were
closed after their deadline.
Fix: #14536
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

:rocket:


Resubmissions Required for MD

We have been having some connection issues with MD, both their primary and secondary feed. This is not related to the SSHJ version bump, but appears to relate to systems issues on their end.
The files that need resubmitted are:
Primary Feed
7a8a24ef-562f-46b1-9134-6c148a3cedfa	md-phd.elr	covid-19-7a8a24ef-562f-46b1-9134-6c148a3cedfa-20220609031500.hl7	2022-06-09T01:18:11.088613-04:00
5823a9da-ecdc-44d6-be08-2ab1d5ad4e97	md-phd.elr	covid-19-5823a9da-ecdc-44d6-be08-2ab1d5ad4e97-20220609011517.hl7	2022-06-08T23:17:34.383353-04:00
48f95af7-e643-4852-aac0-cbb96e332eb5	md-phd.elr	covid-19-48f95af7-e643-4852-aac0-cbb96e332eb5-20220608231551.hl7	2022-06-08T21:17:57.147685-04:00
fdf9582a-85d7-42ab-92ac-8f8ed2c9b850	md-phd.elr	covid-19-fdf9582a-85d7-42ab-92ac-8f8ed2c9b850-20220526191527.hl7	2022-05-26T17:18:19.715752-04:00

Secondary Feed
647fe03b-b2d7-4ea9-be34-737e570a1174	md-phd.elr-secondary	covid-19-20220609091507-647fe03b-b2d7-4ea9-be34-737e570a1174-secondary.hl7	2022-06-09T07:17:06.235613-04:00
c187ee50-4986-46b6-82ab-6409fe574144	md-phd.elr-secondary	covid-19-20220609071520-c187ee50-4986-46b6-82ab-6409fe574144-secondary.hl7	2022-06-09T05:17:26.702243-04:00
3b98436f-26c0-45de-b47a-2d28b78fe5b0	md-phd.elr-secondary	covid-19-20220609051537-3b98436f-26c0-45de-b47a-2d28b78fe5b0-secondary.hl7	2022-06-09T03:18:38.919129-04:00
a70a30f5-89af-402e-8775-8c44f741f594	md-phd.elr-secondary	covid-19-20220609031500-a70a30f5-89af-402e-8775-8c44f741f594-secondary.hl7	2022-06-09T01:18:11.104248-04:00
e7675a54-561c-4dda-86ab-571a07b0ec43	md-phd.elr-secondary	covid-19-20220609011517-e7675a54-561c-4dda-86ab-571a07b0ec43-secondary.hl7	2022-06-08T23:17:29.789544-04:00
39d9f75e-f414-4917-81d4-ed824f7ddaac	md-phd.elr-secondary	covid-19-20220608231549-39d9f75e-f414-4917-81d4-ed824f7ddaac-secondary.hl7	2022-06-08T21:17:42.803911-04:00
db2cf6fc-b957-4d65-87f9-5059078b9f14	md-phd.elr-secondary	covid-19-20220526191523-db2cf6fc-b957-4d65-87f9-5059078b9f14-secondary.hl7	2022-05-26T17:18:39.637738-04:00

@sarahnw @Adrian-Brewster @anshulkumar-usds - These resubmissions have been completed.


In l2ls app, "App information goes to app_name.json"

This was a TODO in setup method. It had self.name = 'kytos.l2_learning_switch'. I noticed there is a kytos.json file with "name" = "of.l2ls" and that's why I removed both TODO and self.name line, but I'm not sure whether there is anything else to do (e.g., change kytos.json to app_name.json as said in TODO). Could the TODO creator check if this is solved?

The TODO was added prior to the definition of the json file. It will be kytos.json.
But, at least until now, we are not parsing the json file, so the napp will not have the 'name' attribute when loaded by the controller. That is not a problem if we are not using the napp name anywhere - I'm not sure about it.

In the logs, napp names are like "Thread-1122". We could get the name from kytos.json.

Agreed @cemsbr . Should be author/napp_name

After to close the #99, each Napp now read the kytos.json and updates yours object attributes. In the logs, the napp name of each thread is author/napp_name.

Indeed, this was fixed by kytos/kytos#287.


vend nfc dependency broken

After a # pacman -Syu, vend broke.

It seems as if it doesn't load the submodule in the git repo, but haven't really dug too deep

Dependency fixed by compiling and installing the nfc-bindings from source in the git submodule.
But now it doesn't respond on MQTT messages

There was a change in the nfc-bindings module not in upstream fix a locking thing, should be in nfc-bindings in /opt/nfcd

Maybe nfcpy/nfcpy will be a better road.
I will test and see what happens when running python -m nfc using that library on a Pi connectected with an NFC device connected over i2c.

Actually, i2c is out of question, but the readers we have available can be interfaced with UART connectors. More information and discussion on the subject: https://github.com/nfcpy/nfcpy/issues/76


Provide unit test for partial backport PR#416 for 2.5.x

Provide unit test for partial backport PR#416 for 2.5.x (from L. Lenart's PR#414) :

DispatcherTest provides code coverage tests of all getLocale() paths.

Hello Apache Struts Team.
The PR #416 was already accepted and merged, but Coveralls pointed out that code-coverage dropped.  Due to the potentially bad behaviour that could arise if Dispatcher Locale handling does not work as expected, a new set of unit tests for the Dispatcher getLocale() method has been created to confirm the expected behaviour.
If this PR looks OK to everyone, then it can be cherry-picked and modified as necessary to bring the tests into the 2.6.x stream.

Coverage increased (+0.02%) to 47.096% when pulling 4457f03c70dba544962482fcef5d58a29ba1fe61 on JCgH4164838Gh792C124B5:LL_tiny-improvements_unittest into 3d3512a399d3ddafca74f29ca3abef853db50506 on apache:struts-2-5-x.


[Feature] Metrics structure

Motivation
While micro-benchmarks are relevant in order to optimize a service as a single node, metrics are essential in order to analyze a distributed system. This PR proposes an initial step towards a more structural approach to system metrics.
This allows for a more targeted approach to optimizing network behavior at scale.
Using the same structural definition, the metrics should be queryable using both Prometheus & the json-RPC API.
Approach

[X] Metrics are namespaced in their relevant domain

Note: I feel the current categorization is somewhat strange, so this can definitely be improved

[X] Use type-safe metric type Wrappers, e.g. Counter, DiscreteGauge, etc
[X] Move metrics definition, background handling & call-site macros to the snarkos-metrics crate, to prevent duplication of crate includes
[X] Deprecate the snarkos-metrics binary
[X] Move json-RPC Stat type definitions to snarkos-metrics to prevent intermediate type conversions between the internal declaration & the expected API type.

Future/nice-to-haves

Consolidate metric declaration, categorization & handling using macros.
Consolidate metrics exporters, allowing a prometheus-compatible export without drain-only behavior, yet allowing a fixed time window for histograms.
Allow metrics aggregation over the mining network

Test Plan
Testing is currently limited to running a prometheus instance, manually scraping the prometheus endpoint or querying the json-RPC API. Not sure if it's worth the effort to add automated testing here.
Related PRs
N/A

Note: I changed the base branch to staging, which is the branch to file PRs against (as your PR is, judging by the commits :+1:).

Note: I changed the base branch to staging, which is the branch to file PRs against (as your PR is, judging by the commits 👍).
Edit: actually, it seems that you beat me to it 🙂.

Thank you! Yeah I noticed it a bit too late, force of habit ;-)

* a `cargo fmt` pass using the `nightly` toolchain

Done! I've coaxed my IDE into using the nightly formatter.

* the `outbound` metrics seem to have disappeared? I don't see them in `grafana` when running this branch locally, and I don't see them anywhere in the diff's "green"

I've removed the register_metrics, so they will only show up in the prometheus stats once first incremented. The only usage I can see is in network/src/outbound/outbound.rs, which is not compiled it seems. Or am I looking at the wrong outbound stats here?

I'm attaching the JSON model for my grafana dashboard, it might be useful:
grafana JSON model

Would you mind if I add this to the repo? Could be useful for others :-)?

the RPC snapshots currently still need to be available even with features=prometheus and some of them need to
have "overrides" (as they currently do) that allow us to know if the prometheus metrics are valid, as not all of them
currently are, especially the gauges; #782 should actually now be fixable due to the new structure, and #869 and #877 are
recent regressions; until we are confident that the metrics-driven values are perfectly correct, we need some of the
currently existing overrides - they can be exposed as another RPC if need be

So my future proposal here is to consolidate both metric types, removing the metrics-exporter-prometheus & just allow exporting the Stats in the prometheus format. This would make the Stats the single point of truth. As this is also fully statically initialized, there no lazy or conditional initialization anymore, preventing any metrics from being missed at start-up.
From a mapping perspective (key -> metric), I was planning on doing via registration macros to prevent client-side errors.
That should be sufficient in order to consider the metrics "correct".

The only usage I can see is in network/src/outbound/outbound.rs, which is not compiled it seems.

@Protryon any reason why that module wasn't just removed as part of lockless? It is, in fact, not compiled, and the outbound metrics are thus not incremented ever; we do want to measure the number of successfully sent messages, however, so we should bring them back, but it is indeed outside of this PR's scope.

Would you mind if I add this to the repo? Could be useful for others :-)?

I'm ok with this :ok_hand:.

future proposal (...)

As for the future plans, I agree that the end goal would be to only use "proper" metrics, but right now we are not incrementing/decrementing everything in the right place, so having an alternative way to view the number of connections or block height, even in a "clunky" way (e.g. using Ledger::get_current_block_height as opposed to the counterpart metric) is preferable to having unreliable values as the only reference, which can make debugging efforts more difficult. As far as I'm aware, it's currently the aforementioned outbound metrics (plus the OUTBOUND queue), the block height and the connections metrics.

future proposal (...)

As for the future plans, I agree that the end goal would be to only use "proper" metrics, but right now we are not incrementing/decrementing everything in the right place, so having an alternative way to view the number of connections or block height, even in a "clunky" way (e.g. using Ledger::get_current_block_height as opposed to the counterpart metric) is preferable to having unreliable values as the only reference, which can make debugging efforts more difficult. As far as I'm aware, it's currently the aforementioned outbound metrics (plus the OUTBOUND queue), the block height and the connections metrics.

Added the overrides back into 751eba37


Linkify experimental feature - demo page shows unlinked "should be linkified" text

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to the linkify-demo page
Notice that "ipns://ipfs.git.sexy" is not linkified (see screenshot below)

Expected behavior
All links under "Should be linkified" should be linkified.
Screenshots

Desktop (please complete the following information):

OS: macOS Monterey 12.1 (21C52)
Browser: Chrome
Version: 97.0.4692.99 (Official Build) (arm64)

Additional context
One of two fixes:

"ipns://ipfs.git.sexy" should be linkified.
or
"ipns://ipfs.git.sexy" should not be listed under the "Should be linkified section"

Good catch! This is because that domain name is dead and no longer has a valid DNSLink:
https://ipfs.io/ipns/ipfs.git.sexy/
@SgtPooki  mind opening PR that replaces all uses of  ipfs.git.sexy with en.wikipedia-on-ipfs.org  ?


Court Of Blades: v1.0.2 changed image links to use Roll20 repo

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Repointed images to Roll20 repo
Reduced tooltip visibility time

Character Sheet Info Roll20 Internal Use only.


Include 3XR.SPACE

Thanks for the PR! Can you add a short description for https://3xr.space? Excited to get this in.


Initial work to support non transitive R class with Databinding 7.1.0

Rebase with Databinding 7.1.0
Implement package aware R.txt in Bazel
No longer need to pass R.txt to generate stubs since once non transitive R class is enabled, each target's Kotlin code can only contain local module R imports.
Make R.txt more lenient to allow parsing package-aware R.txt

Changed to draft since this change is effectively breaking for folks not using non transitive R class.

Can be enabled by passing --define=nontransitive_r_class=1

Succeeded by https://github.com/grab/grab-bazel-common/pull/23


Upgradability

Checklist:

[x] Code contains relevant tests for the problem you are solving
[x] Ensure all new and existing tests pass
[x] Update any relevant READMEs and docs
[x] Submit to the develop branch instead of master

Description:
Not ready to merge yet. Waiting on dapp updates. Rewrites a lot of origin-js to include an upgradability strategy as well as other architectural changes.

This is a fair amount to review :) - perhaps we could get on a call sometime to walk through the code?

I'm not sure what the benefit of having the Evolving Registry concept on-chain is. From what I can see, the idea is to have a unique listing ID that works across different contracts. I see how that would be useful from an OriginJS or dapp perspective, but not sure what the benefit is at the contract level.
Instead, for the purposes of OriginJS and the Dapp, couldn't we just split the listing ID into two pieces, where the first is the contract version and the second is the listing ID on that contract? For example, listing 001-289 would be listing 289 on contract version 1. 003-97 would be listing 97 on contract version 3.
That way we can remove the extra gas, complexity and security implications of an Evolving Registry contract while keeping the ability to address listings on different marketplace contracts.

Appreciate all the feedback - I'll be looking over it. Just a heads up, this is a work in progress so I will be pushing commits to this branch. Created the PR for better visibility on what I'm doing here.

@nick Wish we'd looped you into this discussion earlier!
Yeah I like the idea you mentioned. I had also considered keeping track of various listing contracts entirely off-chain.
I went with this approach to be on the safe side of having a master registry on-chain. The main advantage I could see is being able to implement on-chain logic that needs to know whether a listing is an Origin listing or not.
For example, token incentives related to listings.
But yeah this may be over-engineered and overkill - felt like the safer option to me. We can always move from having a master on-chain registry to not having one, but it's harder to move in the other direction.
I could be persuaded either way. Any other thoughts? @DanielVF @cuongdo ?

I did a cursory review, because a lot of stuff is still in flux. Here are my high-level comments:

I'm curious what the overhead of scanning a bunch of logs is. For example, in getPurchaseLogs, you can from block 0. That might take a lot of time on mainnet. We could bound the search from the block number at which the the purchase started. This could be stored in IPFS. (This can be done later.)
The structure of the adapter looks generally good. I like the encapsulation of interacting with the contracts there. It doesn't seem particularly challenging to have either @tyleryasaka's contracts or @nick's contracts with this in place.
I think only allowing 2 digits for V01ListingAdapter, etc. is optimistic. We may want ~2-3 more digits there.
Once the dust settles and people are unblocked, I suggest presenting the overall structure during an engineering meeting. There's a lot to digest here, and everyone should understand how this code is structured.

I can look deeper when things have settled a bit.

Closing in favor of the work being done on https://github.com/OriginProtocol/origin-js/tree/nick/upgradability


alt property of a context menu item contributed by an extension has no effect

Issue Type: Bug
Based on https://github.com/microsoft/vscode/commit/c0caab4d8ccd67424ef2f57abd5a4a12275fb4d7 and https://github.com/microsoft/vscode/issues/85218#issuecomment-556074372 I expected to be able to add an alt property to entries that my extension's package.json contributes to the editor/context menu
        "menus": {
            "editor/context": [
                {
                    "command": "thefoldingstuff.fold",
                    "alt": "thefoldingstuff.foldRecursively",
                    "title": "Fold",
                    "group": "thefoldingstuff"
                },
                {
                    "command": "thefoldingstuff.unfold",
                    "alt": "thefoldingstuff.unfoldRecursively",
                    "title": "Unfold",
                    "group": "thefoldingstuff"
                },

But when I run my extension the command invoked from my entries in the context menu is always the one specified in the command property, even if I hold down the Alt key when picking the option.
VS Code version: Code - Insiders 1.41.0-insider (87c2e0be5d7359ce110c4c9ec9f6df71be996f8a, 2019-12-06T21:36:11.793Z)
OS version: Windows_NT x64 10.0.18363

The alt key is not something that can be pressed with Windows native context menus.
macOS: allows option + click in context menu
windows: allows alt + click in context menu with custom (not native)
linux: allows alt + click in context menu
So, yes, we could theoretically support this, but since it is a foreign concept to native windows, I'm not super sure we should.
/cc @bpasero


Links in particle documentation don't work

Links in "index.md" (Tab "Documentation") don't work if content of tab "Markup" is not visible.
Obviously the latter catches mouse events even when hidden.
When tab "Markup" is visible tab "Documentation" is pushed down within the page and all links work. Otherwise only links in "Documentation" which are positioned below the height of "Markup" content respond to clicks.

Thank you for your contribution. However, this issue has already been reported in sinnerschrader/patternplate-client#3. Please follow progress there to stay updated.
Generally speaking, this is a frontend-only problem, so it's scope is the patternplate-client project.


Calendar event unrecognized by Gmail and Outlook

I try to send out an event calendar item generated by ical4j library.
But instead in Gmail I see "invite.ics" attached file, and no "add to calendar" option.
In Outlook I see "not supported calendar message.ics", and no "add to calendar" option.
What am I missing?
I am using simple-java-mail 6.6.1, and ical4j 3.1.0.
My message dump looks something like this:
To: Person<EMAIL_ADDRESS>Cc: Another<EMAIL_ADDRESS>Message-ID:<PHONE_NUMBER>.0.1633348839489@ZEUS
Subject: Test Mail
MIME-Version: 1.0
Content-Type: text/calendar; charset="UTF-8"; method="REQUEST"
Content-Transfer-Encoding: 7bit
BEGIN:VCALENDAR
PRODID:-//Events Calendar//iCal4j 1.0//EN
VERSION:2.0
CALSCALE:GREGORIAN
BEGIN:VEVENT
DTSTAMP:20211004T120033Z
DTSTART:20211005T090032
DTEND:20211005T100032
SUMMARY:Test Event
DESCRIPTION:See you there!
LOCATION:Test Location
URL:http://somehost,com/events/1452713327988900
TZID:America/Halifax
UID:d1271f34-f26d-4eea-8899-3421b356c7a1
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>X-ALT-DESC;FMTTYPE=text/html:Test Event at Test LocationSee you
there!
END:VEVENT
END:VCALENDAR
.

Event  was missing tag METHOD:REQUEST


Added inverse function 1

Pull Request Template
Description
I have added a function to find the inverse of a given matrix using various functions in the code.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

!bounty 20


Tests

@adambraimbridge FYI here are some test which hopefully help document the behaviour a bit better too. Not comprehensive yet, but will make it easier to fix bugs without breaking other things


Service names not resolving

Rancher Versions:
Server: 1.3.3
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):
Docker Version:
1.12.6
OS and where are the hosts located? (cloud, bare metal, etc):
DigitalOcean cloud
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
internal DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Connecting to database instance with a client like SQL Pro or Querious using database service name.
Results:
Connection is refused. Only way to connect is by using service IP.

Can you describe the steps to reproduce, what are you launching, service with one container or multiple, loadbalancer yes/no? From where are you connecting to where?
So I can understand the problem better.

Please comment or file a new issue if you are still experiencing issues.


Define Feature Flagging Practices

User Story:
As a developer, I want clear feature flag guidelines so that I am able to find information regarding feature flags, how to activate them and use them in my code.
Acceptance Criteria:

Feature flagging practices are discussed and agreed upon
Team members understand how to enable feature flags in their codebase and related practices

Information can be found in the wiki


Remove ofy support from Address

This change is

Reviewed 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jianglai)

core/src/main/java/google/registry/model/eppcommon/Address.java line 163 at r5 (raw file):

          "Street address must have [1-3] lines: %s",
          street);
      //noinspection ConstantConditions

up to you if you want to do this, but you can get around this required comment by using guava's Strings::isNullOrEmpty

The warning is on the nullness of steet itself, which is a bit silly because we already checked for that in the previous checkArgument statement...


Add a warning about allergen detector when a product is not complete

When the user has set at least an allergen to detect, add a warning about allergen detector when a product is not complete.
"This product is not complete. As a result, we couldn't do the allergen check."

I would like to work on it :).

Go ahead :)

Please don't use pop-ups, just a dismissible message in the summary tab

Sure, thanks :).

Hey, how could I know that the product is incomplete?

"states_tags":["en:to-be-checked","en:complete","en:nutrition-facts-completed","en:ingredients-completed","en:expiration-date-to-be-completed","en:packaging-code-to-be-completed","en:characteristics-completed","en:categories-completed","en:brands-completed","en:packaging-completed","en:quantity-completed","en:product-name-completed","en:photos-validated","en:photos-uploaded"]

Uncomplete:
"states_tags":["en:to-be-completed","en:nutrition-facts-completed","en:ingredients-to-be-completed","en:expiration-date-to-be-completed","en:packaging-code-to-be-completed","en:characteristics-to-be-completed","en:categories-to-be-completed","en:brands-completed","en:packaging-to-be-completed","en:quantity-to-be-completed","en:product-name-completed","en:photos-to-be-validated","en:photos-uploaded"]

Thanks :).

I've analyzed the code and in that, I came to know that we're getting states_tags array from the server but we're not storing it anywhere so I'm thinking to store these values in Product class shall I do this?


Missing neutron star mass bins

It was recently noticed that, in some very particular cases, the mass function evolution algorithm seems to wind up with no neutron star (NS) bins whatsoever.
This does not happen often, but is likely an indicator of a larger issues. It's also almost definitely not real.
For example, when using the specific set of parameters from a fit of NGC6121, but altering the metallicity only:

We can that there's clearly a hole in the NS mass at a certain metallicity.
(Note: This should not imply that this is a bug related to the metallicity. In this case it is just the one parameter varied, which impacts the remnants formed. This could be caused by any combination of MF parameters which result in a specific makeup of remnants.)
It is very likely this was caused by the extensive changes made to EvolvedMF earlier this year (#3), especially fixes made relating to the NS masses. The NS bins must not be being filled in by remnants as they are formed.
The effects overall should be quite small. It only seems to be a NS problem, and that's the smallest component in these models. But, it still needs to be fixed.

The problem has been traced back to the spot in the derivatives where the mass of a freshly formed remnant is placed into the relevant remnant derivative bin (i.e. irem):
https://github.com/SMU-clusters/ssptools/blob/f0a19b7708fb184b960e43c9da9e3040da9e3f5a/ssptools/evolve_mf.py#L492-L499
Adding some logs shows that, for this example where no NS bins were populated, the mass (at every timestep which creates a NS because they all have the same mass) always goes into bin 11:
DEBUG:root:In `_derivs_sev` at time 61.51787138066902
DEBUG:root:current turn off bin is 17
DEBUG:root:m1=5.011872336272724, mto=5.7343059427359835, Nj=5361.42756899383
DEBUG:root:m_rem=1.4, cls_rem='NS'
DEBUG:root:irem=11

The issue is that this bin has a mean mass of ~1.35 (left edge at ~1.25), which also places it below the maximum WD mass for this metallicity. Therefore, the most massive WDs are also being placed into bin 11:
DEBUG:root:In `_derivs_sev` at time 61.58416871538862
DEBUG:root:current turn off bin is 17
DEBUG:root:m1=5.011872336272724, mto=5.731055782124926, Nj=5340.47811218627
DEBUG:root:m_rem=1.299616313035207, cls_rem='WD'
DEBUG:root:irem=11

And because the WD/BH IFMR limits are what is used to determine rem_types this bin is labelled as a WD bin.
So, in summary, in certain (very particular) cases, the mass bins will arrange themselves and the WD IFMR will be such that the WD and NS bins will overlap slightly, causing the NS to be placed into a WD bin.
The good news is that this would have no real effect on the dynamics of any models where this bug occurred, it is a very rare bug, and in any past models that any NS bin exists in we can be confident that the bug did not occur.

Another consequence of this bug, when it occurs, which is a good indicator, is that the NS mass bin should have been fixed to always have a mean mass of exactly 1.4, but that is of course not the case when it is mixed with the WDs.
So whenever you don't see a mass bin of 1.4 in the remnants, the NS are wrong.


Extra properties of Interface Message

Hey, thanks for your great work done here!
l wanna ask can you enable optional properties in interface Message ?

What would you mean by optional? ie. Leaving out some existing properties, adding a custom property handler, or changing the typings?

l mean adding a custom property handler, l need to dynamically assign some properties except data, id, method

Adding something like [prop: string]: any may help, do you think it's okay?

Could you provide a snippet that would utilize this custom property handler? can't really understand what you're trying to do right now

render() {
    return (
      <div style={{ backgroundColor: '#242424' }}>
        <Console
          logs={
            [{
              'method':"log",
              "data": [Array(1,2,3)],
              "id": "1",
              "other":"xxx"   // don't support that
            }]
          }
          variant="light"
        />
      </div>
    )
  }


1.19.2 version on modrinth

Only the versions for 1.18, 1.20 and 1.21 are on modrinth - 1.19.2 is only on curseforge. Could you upload the fabric 1.19.2 version to modrinth too?

Done


Add support for DNF-powered distros

Distributions like CentOS 8 use dnf as their package manager, which is why this role did not work correctly there. This fixes it.

Hey, thanks for your PR! I am currently on vacation with limited internet, but I will look at it next week.


npm ERR! code E404

Hi,
Once i'm doing npx node-cds-gen [tennant] [environment] with my environments details, I'm getting this error
`npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/node-cds-gen - Not found
npm ERR! 404
npm ERR! 404  'node-cds-gen@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR!      C:\Users\abodh\AppData\Roaming\npm-cache_logs\2020-05-05T21_13_08_353Z-debug.log
Install for [ 'node-cds-gen@latest' ] failed with code 1`
2020-05-05T21_13_08_353Z-debug.log

It is actually:
npx node-cds-auth [environment url]

E.g.
npx node-cds-auth org.crm.dynamics.com

@scottdurow ,
Thanks, that resolved the issue


Aleph client returning garbled bodies from chunked responses

When using the Aleph client functions, I'm seeing garbled bodies being returned from requests with chunked responses.  This is occurring for me with Aleph 0.4.0.
To add to the fun, I don't always see this behavior.  The problem seems to be in some way related to how or when Aleph namespaces are loaded.  When loading my full application in the Counterclockwise / Eclipse REPL, I consistently see the behavior.  However, when just loading smaller namespaces that include aleph.http, the behavior is less consistent.  Also I haven't noticed the problem when running the application through Leiningen or when loaded in a REPL from Cursive / IntelliJ, though I don't have any firm certainty that it's not happening in those scenarios.
Examples (slightly trimmed down):
=> @(aleph.http/get "http://www.google.com" {:as :string})

{:request-time 95,
 :headers {"server" "gws", "content-type" "text/html; charset=ISO-8859-1",
           "transfer-encoding" "chunked",
           "alternate-protocol" "80:quic,p=0",
           "accept-ranges" "none"}
 :status 200,
 :keep-alive? true,
 :connection-time 0,
 :body "<!doctypmore. GoI=functi++},funcd2d2d;baom:-2px;ext-decodecoratiound-pos0 !impord{marginpiaa{dis-moz-boxorder-co#f5f5f5,h)[a]=b}ndom();Lges/silhcookie.mrseInt(d){for(vais);gbar\"><tablew Active

Hmm, I'm trying to reproduce this by just making the request in aleph.http, and can't.  Just to help me zero in on where this error is being introduced, can you do the following:

Target [aleph "0.4.1-alpha2"]
See if this has different results:

(-> @(aleph.http/get "http://www.google.com") :body manifold.stream/stream->seq vec byte-streams/to-string)

Thanks!

Sorry, that code snippet is only valid if you're using raw-stream?, which you didn't mention, so I think you can safely ignore it.  Making sure it is still happening in the latest version would be helpful, though.

I am able to reproduce it with [aleph "0.4.1-alpha2"].  I'm going to try to work up a project.clj file and namespace that can trigger this.

Ok, I've figured out what is inducing this strangeness.  Using byte-streams/def-conversion, I defined conversions for Long -> bytes and bytes -> Long.
These conversions don't seem to be the sole cause though, it looks like core.async must also be present.  When I include core.async (version 0.1.346.0-17112a-alpha) the behavior is reliably reproducible, and when I remove core.async, then everything seems to behave normally.
So... is it reasonable to expect that defining byte-stream conversions for Long -> bytes and bytes -> Long should be free of side effects?  Or is this a touchy area when Aleph is also needed?
Reproduction code:  https://gist.github.com/tcushman/e5e82ffe63a09383d912
Dependencies:
[org.clojure/clojure "1.7.0"]
[org.clojure/core.async "0.1.346.0-17112a-alpha"]
[aleph "0.4.0"]

Haha, okay, I wasn't expecting custom conversions.  A few thoughts:  Your conversions are definitely not 0 cost, there's real copying being done there (as opposed to just wrapping a byte-array in an ByteArrayInputStream).  Also, they don't appear to be fully type-hinted, and would probably be faster if you just did them like this: https://github.com/ztellman/byte-transforms/blob/master/src/byte_transforms.clj#L101-L107.
I still cannot reproduce this, and the code you gave has (def ^:private LONG-BYTES (Long/BYTES)), which doesn't seem to be valid in my JVM.  Maybe this is just a typo, or maybe it points to some difference in our environment?
When you're able to reproduce this issue, can you give me the output of (bs/conversion-path java.io.InputStream String)?

Those two constants, LONG-BYTES and BYTE-SIZE are both 8.  Long/BYTES is new in Java8.  I'm using Oracle's JDK 1.8.0_51 & 1.8.0_31.  Sometimes everything loads up and runs cleanly, though 8.0_51 seems to pass a little more often than 8.0_31.  It was a bit crazy trying to narrow down the failure condition for something that didn't always fail.
I'll give the ByteBuffer conversion a try.
Below is the conversion path I get for InputStream -> String.  This was taken from a running system that was exhibiting the strangeness.
( [ {:on byte_streams.protocols.ByteSource,
     :on-interface byte_streams.protocols.ByteSource,
     :sigs {:take-bytes! {:name take-bytes!, :arglists ([_ n options]),
                          :doc "Takes `n` bytes from the byte source."}},
     :var #'byte-streams.protocols/ByteSource,
     :method-map {:take-bytes! :take-bytes!},
     :method-builders {#'byte-streams.protocols/take-bytes! #object[byte_streams.protocols$eval4720$fn__4721 0x40174927 "byte_streams.protocols$eval4720$fn__4721@40174927"]}}
    java.lang.CharSequence]
  [ java.lang.CharSequence java.lang.String ])

Ok, increasing the cost from 0 to 10 seems to inhibit the problem, even though the the conversion paths look identical.  Here is the conversion path returned when the cost of Long -> bytes and bytes -> Long is 10 instead of 0.
( [ {:on byte_streams.protocols.ByteSource,
     :on-interface byte_streams.protocols.ByteSource,
     :sigs {:take-bytes! {:name take-bytes!, :arglists ([_ n options]),
                          :doc "Takes `n` bytes from the byte source."}},
     :var #'byte-streams.protocols/ByteSource,
     :method-map {:take-bytes! :take-bytes!},
     :method-builders {#'byte-streams.protocols/take-bytes! #object[byte_streams.protocols$eval4720$fn__4721 0x4126936a "byte_streams.protocols$eval4720$fn__4721@4126936a"]}}
    java.lang.CharSequence ]
  [ java.lang.CharSequence java.lang.String ] )

I suspect the protocol referenced by :method-builders is hiding some of the details.

The culprit is https://github.com/ztellman/byte-streams/blob/master/src/byte_streams.clj#L514, where there's a hidden conversion to byte-arrays.  It should be enough to change the cost to 1, I'd think.  Can you confirm?

Yes, a cost of 1 seems to be enough.  I suppose that when searching for a cost-based path, any number of a -> b, b -> a conversions could be added into the path if both conversions claim to have no cost.
Thanks for your help on this.  I've got things in working order on my end.

The searches are breadth-first, so you can't infinitely recurse that way, but zero-cost conversions tend to have a graph-warping effect regardless.  Glad it wasn't just a bug on my end that randomly corrupted data.


fix #99 [Gamification] show level & the level name for each user when hovering on editor's name

fix #99

Coverage remained the same at 58.781% when pulling e14327e65d1fa04bccea362cca24533f9d637562 on YumiChen:master into fe999275f4ad18d391d8f887d77c5b5b63386fe8 on cofacts:master.

Thanks for the PR!! Will check on Wednesday

好的，會再確認一下這個問題，謝謝review~!


Pagination in load_as_pandas for large tables

The ability to pass limit=n to the delta_sharing.load_as_pandas function is very helpful, but it would be even better if you could also pass start_at=. This would allow large tables to be loaded and processed on a client machine without having to load the whole thing into memory.
eg
delta_sharing.load_as_pandas(table_url, limit=1000) returns rows 0-999
delta_sharing.load_as_pandas(table_url, limit=1000, start_at=1000) returns rows 1000-1999

Good point. However, it's actually not easy to implement pagination in an efficient way. For example, delta_sharing.load_as_pandas(table_url, limit=1000, start_at=1000) will still need to read the first 1000 rows and drop them before returning rows 1000-1999.

Would the filtering work here?

Would the filtering work here?

It will still do the filtering in the client side. Can we use load_as_spark to load the table as a Spark DataFrame and do the filtering? After that you can convert a Spark DataFrame to a Pandas DataFrame by calling to_pandas(). This would make your code more scalable which is what Spark is good at.

@zsxwing I have a similar use case where I am trying to consume the Delta Tables into a UI application. Spark wont be an ideal choice here as it takes some time for spark initialization and hence would be difficult to get the data in sub-seconds or seconds. I am looking for some option to pass filters while load_as_pandas. I could pass a filter so that only the portion that is drawn on my chart ui is loaded. Can this be achieved?


OBS is missing virtual camera functionality

Describe the bug
On other distros OBS has a "Start Virtual Camera" button below the "Start Recording" button, but on NixOS it is missing. AFAIK this is based on v4l2loopback.
Notify maintainers
@jb55  @MP2E
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.4.11, NixOS, 23.11 (Tapir), 23.11.git.91a22f76cd17M`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"nixos"`
 - channels(user): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I have the button in OBS with the following in /etc/nixos/configuration.nix:
boot.extraModulePackages = with config.boot.kernelPackages; [ v4l2loopback ];
boot.kernelModules = [
  "v4l2loopback"
];

That does indeed fix it. And I see it's mentioned on the wiki too.

followed https://nixos.wiki/wiki/OBS_Studio
but it asked my sudo password
added
  security.polkit.extraConfig = ''
    polkit.addRule(function(action, subject) {
        if (action.id == "org.freedesktop.policykit.exec" &&
            action.lookup("program") == "/run/current-system/sw/bin/modprobe" &&
            subject.isInGroup("users")) {
            return polkit.Result.YES;
        }
    });
  '';

and it worked
full config
{ config, lib, pkgs, modulesPath, inputs, settings, localpkgs, ... }:

let
  mypkgs = pkgs.nixpkgsMaster.pkgs;

  obs = mypkgs.wrapOBS {
    plugins = with mypkgs.obs-studio-plugins; [
      advanced-scene-switcher
      # obs-pipewire-audio-capture
      droidcam-obs
      # obs-shaderfilter
      # input-overlay
      # obs-source-clone
      # looking-glass-obs
      obs-source-record
      # obs-3d-effect
      # obs-teleport
      obs-backgroundremoval
      # obs-vaapi
      # obs-command-source
      # obs-vintage-filter
      # obs-gstreamer
      # obs-vkcapture
      # obs-hyperion
      # obs-websocket
      # obs-livesplit-one
      # obs-move-transition
      # obs-multi-rtmp
      # obs-ndi
      # wlrobs
      # obs-nvfbc
    ];
  };
in
{
  boot.extraModulePackages = with config.boot.kernelPackages; [
    v4l2loopback
  ];
  boot.extraModprobeConfig = ''
    options v4l2loopback devices=1 video_nr=1 card_label="My OBS Virt Cam" exclusive_caps=1
  '';
  security.polkit.enable = true;

  # subject.isInGroup("users")
  security.polkit.extraConfig = ''
    polkit.addRule(function(action, subject) {
        if (action.id == "org.freedesktop.policykit.exec" &&
            action.lookup("program") == "/run/current-system/sw/bin/modprobe" &&
            subject.isInGroup("users")) {
            return polkit.Result.YES;
        }
    });
  '';

  # boot.extraModulePackages = [
  #   config.boot.kernelPackages.v4l2loopback # Webcam loopback
  # ];

  # boot.kernelModules = [
  #   "v4l2loopback" # Webcam loopback
  #   # "snd-aloop"
  # ];
  # services.usbmuxd.enable = true; # Webcam loopback

  environment.systemPackages = [
    obs

    # Webcam packages
    # mypkgs.v4l-utils
    # mypkgs.android-tools
    # mypkgs.adb-sync
    # mypkgs.usbmuxd
  ];
}

followed https://nixos.wiki/wiki/OBS_Studio

Please use the official wiki: https://wiki.nixos.org/wiki/OBS_Studio.

but it asked my sudo password
added
  security.polkit.extraConfig = ''
    polkit.addRule(function(action, subject) {
        if (action.id == "org.freedesktop.policykit.exec" &&
            action.lookup("program") == "/run/current-system/sw/bin/modprobe" &&
            subject.isInGroup("users")) {
            return polkit.Result.YES;
        }
    });
  '';

This doesn't look very secure. If I understand it correctly, this allows every user of the system to load arbitrary kernel modules.

Please use the official wiki: https://wiki.nixos.org/wiki/OBS_Studio.

it didnt work for me

I open obs in terminal
I click button "start virtual camera"
I see in terminal logs it asks my user password to escalate to sudo
I enter password
doesnt work, "Note: If you are using the NVENC or AMD encoders, make sure your video drivers are up to date." error in gui

log
...

==== AUTHENTICATING FOR org.freedesktop.policykit.exec ====
Authentication is needed to run `/run/current-system/sw/bin/modprobe v4 ... _caps=1 card_label=OBS Virtual Camera' as the super user
Authenticating as: Serhii Khoma (srghma)
Password:
polkit-agent-helper-1: error response to PolicyKit daemon: GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: No session for cookie
==== AUTHENTICATION FAILED ====
Error executing command as another user: Not authorized

This incident has been reported.
info: Starting Virtual Camera output to Scene : My Scene

This doesn't look very secure

can fix to
subject.user == "srghma"
  security.polkit.extraConfig = ''
    polkit.addRule(function(action, subject) {
        if (action.id == "org.freedesktop.policykit.exec" &&
            action.lookup("program") == "/run/current-system/sw/bin/modprobe" &&
            subject.user == "srghma") {
            return polkit.Result.YES;
        }
    });
  '';

Can be improved using wrapper script solution from ChatGPT
To allow only the loading of a specific kernel module, such as a camera module, you can modify the Polkit rule to include a condition that checks the specific module being loaded. However, modprobe doesn't provide a straightforward way to enforce this directly via Polkit since it doesn't expose the module name in a way that Polkit rules can inspect.
One way to achieve this is by creating a wrapper script around modprobe that enforces the loading of only specific modules and then configuring Polkit to allow the execution of this script.
Steps to Implement

Create a Wrapper Script for Modprobe:
Create a script, for example, /usr/local/bin/modprobe-camera, that only allows loading the specific camera module (replace camera_module_name with the actual module name).
#!/bin/bash

if [ "$1" == "camera_module_name" ]; then
  /run/current-system/sw/bin/modprobe "$@"
else
  echo "Error: Only the camera module can be loaded via this script."
  exit 1
fi

Make sure to make the script executable:
sudo chmod +x /usr/local/bin/modprobe-camera

Modify the Polkit Rule to Allow Execution of the Wrapper Script:
Update your NixOS configuration to allow the user srghma to execute the wrapper script with elevated permissions.
security.polkit.extraConfig = ''
  polkit.addRule(function(action, subject) {
      if (action.id == "org.freedesktop.policykit.exec" &&
          action.lookup("program") == "/usr/local/bin/modprobe-camera" &&
          subject.user == "srghma") {
          return polkit.Result.YES;
      }
  });
'';

Rebuild Your NixOS Configuration:
Apply the changes by rebuilding your NixOS configuration.
sudo nixos-rebuild switch

Test the Wrapper Script:
As the user srghma, try loading the camera module using the wrapper script.
modprobe-camera camera_module_name

It should load the module if it is the camera module and deny loading any other modules.

Explanation:

Wrapper Script: The script ensures that only the specified camera module can be loaded. It checks the first argument ($1) to see if it matches camera_module_name and only then calls the actual modprobe command.
Polkit Rule: The Polkit rule grants the user srghma permission to execute the wrapper script with elevated permissions, ensuring that the security is enforced while allowing the required functionality.

By following these steps, you limit the user's ability to load kernel modules to only the specified camera module, enhancing the security of your system.

can fix to
subject.user == "srghma"

Orrr you could add "video" to that user's "extraGroups", which gives you access to camera devices including the v4l2loopback module which the virtual camera relies on. Then you don't need any of this polkit hackery.

@jansol
I already have had
 ~  groups
users wheel disk audio video dialout networkmanager libvirtd docker adbusers
 ~  nix-info
system: "x86_64-linux", multi-user?: yes, version: nix-env (Nix) 2.18.2, channels(root): "nixos-24.05, nixpkgs, nixpkgs-master, nixpkgs-unstable", nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos


[WIP] Jimmy adding intial genetic algorithm optimizer

This is a Work In Progress [WIP] PR to initiate the implementation of a Genetic algorithm optimizer for discrete, continuous, and a mixture of both.
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
When merged it closes #1238
What are the significant changes in functionality due to this change request?
RAVEN will be able to feel with global optimization problems over discrete and continuous design variables.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and XSD schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and XSD tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Replaced by  #1253


Feat: Add cut_major_lenght

This allows one to create an axon with a main branch and collaterals. The main branch is usually cut for local axons, as it propagates to other regions. With this PR, we can have a very long bar for it (so that it is considered as major branch), but not synthesize it entirely, to mimic the local axon reconstructions.

@lidakanari @adrien-berchet , this is ready to review, it is a 'minor hidden thing' for hipp axons, so i didn't add tests for now

Do you plan to add tests in this PR?

nope


[Question] No enough benefit whenever IsString needs to be concatenated ?

I feel the optional-args library fails flat because whenever I goes from :
"hello" to "hello" <> name (which in real code is pretty much inevitable) . The isString trick won't apply because the variable of type Text will determine the whole expression to be of type Text instead of Optional Text.
I then need to wrap the expression with "Specific" to obtain a Optional Text. At that point, the gain compared to Maybe is lost and I usually end up replacing Optional with Maybe to keep it simple (introducing something new has a cost even when the package is really tiny).
Am I missing something ?
Is there a way around that issue somehow  ?

You can use "hello" <> pure name and still keep it general without having to import any optional-args modules

Yes ! I didn't think about. Thanks for the tip !


MSVC ICE after fatal error C1004: unexpected end-of-file found

I've discovered that after any input that causes unexpected end-of-file found error (such as a single () all MSVCs on goldbolt ICE after emitting the error:
example.c
<source>(3): fatal error C1004: unexpected end-of-file found
Internal Compiler Error in Z:\opt\compiler-explorer\windows\19.00.24210\bin\amd64\cl.exe.  You will be prompted to send an error report to Microsoft later.
INTERNAL COMPILER ERROR in 'Z:\opt\compiler-explorer\windows\19.00.24210\bin\amd64\cl.exe'
    Please choose the Technical Support command on the Visual C++
    Help menu, or open the Technical Support help file for more information
Compiler returned: 2

I couldn't reproduce this behavior with my local VS 2010, 2015 and 2017, so it seems to be something godbolt-related. This is certainly not a major issue, but it's interesting how MSVC manages to ICE :)

(I think I'm going to close this as not fixable: I don't want to dig into why WINE isn't working here...)

Thanks for the quick response, Matt! I've checked https://godbolt.org/beta right now, but couldn't find any difference from the usual godbolt: the list of MSVC compilers is the same, and the output is exactly the same, including the compiler path (e.g. Z:\opt\compiler-explorer\windows\19.14.26423\bin\Hostx64\x64\cl.exe). Am I missing something?

Hi! Thanks for following up: confusingly the beta site has both the WINE-based compilers (for backward compatibility, at least for now), and new Windows compilers.
Try one of the compilers listed near the very bottom under "Visual C++" e.g. https://godbolt.org/beta/z/swHYO6

I did try to find other compilers when I checked last time, but there were none. I even tried Shift + click to refresh to avoid browser caching. However, now that I've followed your link, those new compilers appeared, and they work as expected. Not sure what the problem was. Thank you, Matt!


fix: update replace all button correctly while updating replace the value  on search view

Types

[x] 🐛 Bug Fixes

Background or solution
fixed #367
Changelog
update replace all button correctly while updating replace the value on search view

这个功能是 by design 吗，这里貌似只是给它 disabled 掉了

这个功能是 by design 吗，这里貌似只是给它 disabled 掉了

这个应该不是 bydesign，看起来是之前搜索面板性能优化改造把这里的条件判断有问题，导致替换全部的按钮更新有问题

Codecov Report

Merging #369 (c1d119e) into main (5b366e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   59.33%   59.33%
=======================================
  Files        1189     1189
  Lines       72850    72850
  Branches    15084    15084
=======================================
  Hits        43222    43222
  Misses      27001    27001
  Partials     2627     2627

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b366e6...c1d119e. Read the comment docs.


Ordering of creators/authors in DataCite DOI metadata

Dear all,
Describe the bug
Dataset https://doi.org/10.57992/nmrxiv.p55 (ordering of creators/authors got fixed in #1030)  has DOI metadata https://api.datacite.org/dois/10.57992/nmrxiv.p55 . The corresponding article https://doi.org/10.1021/acs.jnatprod.1c01035 has metadata https://api.crossref.org/works/10.1021/acs.jnatprod.1c01035 .
For CrossRef the ordering of authors of the article is the same as the ordering in the corresponding CrossRef metadata.
For DataCite the ordering of authors of the dataset is not the same as the ordering in the corresponding DataCite metadata.
Expected behavior
Same ordering of author/creators as shown in nmrXiv also in the DataCite metadata.
Best,
Tillmann

Dear @tilfischer ,
Did you create/publish this project before the fix of https://github.com/NFDI4Chem/nmrxiv/issues/1030 ?

Yes, got published before.

ok.. Can you plz send me the correct order of the authors?

The correct order is the order from the corresponding article: https://doi.org/10.1021/acs.jnatprod.1c01035 or https://api.crossref.org/works/10.1021/acs.jnatprod.1c01035 , whatever you prefer.

@CS76, Is there a way we can update the metadata for the already generated DOI?
As the DOI for this project was generated before the fix of the author's sorting issue, we might have to correct the order manually by API request.

Closing this in favour or #1080

Fixed as part of #1080


NSUL_UTIL::indexOf is not working

Changed indexOf in order to make it work with different types of conteiner


Outdated "Getting started" docs?

The first part of the Getting Started docs states:
---
title: Introduction
description: Re-usable components built using Radix UI and Tailwind CSS.
---

This is **NOT** a component library. It's a collection of re-usable components that you can copy and paste into your apps.

**What do you mean by not a component library?**

I mean you do not install it as a dependency. It is not available or distributed via npm.

I had actually found out about the site due to it's connection to Radix, so I was confused by this statement. Took me a while to figure out how to proceed with it, because as far as the component documentation is concerned, there are no imports from "@radix-ui".
There's also the npm page that threw me off: https://www.npmjs.com/package/shadcn-ui.
I could be wrong and this could just be outdated docs, but just wanted to raise the issue in case other newcomers get confused as I did.

You copy and paste the component code or install it with the CLI. This might have imports from Radix UI. Then you import the component that you've installed which doesn't have Radix imports and you use it.
So the library is made using Radix UI but you don't have to actually touch anything from Radix for it to work.

@mahmoudkhader it means there are no imports of shadcn, the point is you directly import the dependencies (i.e. radix). I believe the text is clear enough. Could we close this?

Yes, I understand how it works now. It wasn't very clear at first, but I got the hang of it after a while. I'll close the issue, though I'd recommend rephrasing "It is not available or distributed via npm" given that the default docs for each component feature an npx command for the component installation.


Groupie Team Member Message in Player Tooltips

Taking an idea from a past project.

https://github.com/Gogo1951/GogoWatch/issues/11
I think we ended up doing this by UnitID, not name. It had a lag with just name as we had to do a few lookups per mouseover.

Message should say:
{rt3} Groupie : Team Member
Ideally it'd be great if we could customize the message per person. So like "Team Member" or "Special Thanks" sort of thing.
I'll dig up a list of characters when we're ready to do this. Need to include everyone who has helped, on all their alts. Takes a bit ot get it assembled.

/run local name = UnitName("player"); local guid = UnitGUID("player"); ChatFrame1:AddMessage(name.." has the GUID: "..guid);
[Player-4408-03D2C535] = true, 	-- Gogodruid-Faerlina
[Player-4408-03D2C53D] = true, 	-- Gogohunter-Faerlina
[Player-4408-03D2C27F] = true, 	-- Gogomage-Faerlina
[Player-4408-03D2C4A6] = true, 	-- Gogopaladin-Faerlina
[Player-4408-03D2C57D] = true, 	-- Gogopriest-Faerlina
[Player-4408-03D2C295] = true, 	-- Gogorogue-Faerlina
[Player-4408-03D2C5E2] = true, 	-- Gogoshaman-Faerlina
[Player-4408-03D2C21E] = true, 	-- Gogowarlock-Faerlina
[Player-4408-03D2C4C4] = true, 	-- Gogowarrior-Faerlina

TODO
Player-4467-02AB80C7, Raegen, Firemaw
Player-4408-039B90A8, Aevala, Faerlina

implemented here: df61249b8ce65ff35303893d721fbee8102e0662
Feel free to edit the strings and change messages for everyone as you like

Player-4647-023571C6, Kynura-Grobbulus

Marking this as done!


Fixed broken links

What does this PR do?
Improve repo
For resources
Description
Fixed links on the Finnish books page.
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[X] Read our contributing guidelines
[X] Search for duplicates.
[X] Include author(s) and platform where appropriate.
[X] Put lists  in alphabetical order, correct spacing.
[X] Add needed indications (PDF, access notes, under construction)

Followup

Check the output of Travis-CI for linter errors!

thanks!


Fix audit hanging at curl.

Changes to the core

[x] Followed hacking.md.

Fixes https://github.com/caskroom/homebrew-cask/issues/23031.

Merged as aba97a8ca6b729e580ac8d1fc351c8cdab4c8d97.


feat: added function type for symbolRotate

Related to https://github.com/apache/incubator-echarts/pull/12348.

Note that symbolRotate does not work for radar series for now, a PR for fixing is pending.
apache/incubator-echarts#12695


Feature request: Restrict appearance to categories

Ref https://meta.discourse.org/t/retort-a-reaction-style-plugin-for-discourse/35903/97?u=gdpelican

+1. I would like to have a board for decision making, using Loomio-like reactions for reaching consensus.


Cannot open the R interactive window

As I said, I cannot open the R interactive window. And I cannot open the .sln which I built under visual studio 2015.

Which version of VS is it? Which version of R is it?

VS2017 and  R3.4.0  I just used the updated R tools for VS2017. And I cannot open the R interactive window  as well as  the .sln which I built under visual studio 2015 before.

3.4.0 is not supported yet (R changed plotting API). Next 15.3 update will have the support.
https://github.com/Microsoft/RTVS/issues/3441


Unexpected error while obtaining UI hierarchy

java.lang.NullPointerException

this problem is happening for java SDK version, Downgrade your Java version to "1.8.0_231".
quit the terminal and reopen type "uiautomatorviewer" and hit enter
that it.


Wrong rendering of pattern

pattern.pdf
Configuration:

Firefox Nightly 73.0a1 (2020-01-04)
macOS Mojave 10.14.6
PDF.js version: 2.4.254
Is a browser extension: built-in

Steps to reproduce the problem:

Open the PDF, zoom in to 200% for a more detailed view

What is the expected behavior?

What went wrong?

The crosshatch pattern is rendered by pdf.js using the wrong pattern style. The other pattern style just seem to have a broken redering.
TeX source of PDF:
\documentclass[a4paper,11pt]{scrartcl}
\usepackage{tikz}
\usetikzlibrary{patterns}

\begin{document}
crosshatch pattern:
\begin{tikzpicture}
\draw[draw=black, fill=black!10, pattern=crosshatch, pattern color=black] (0,0) rectangle (1,1);
\end{tikzpicture}
\\

north east lines pattern:
\begin{tikzpicture}
\draw[draw=black, fill=black!10, pattern=north east lines, pattern color=black] (0,0) rectangle (1,1);
\end{tikzpicture}
\\

north west lines pattern:
\begin{tikzpicture}
\draw[draw=black, fill=black!10, pattern=north west lines, pattern color=black] (0,0) rectangle (1,1);
\end{tikzpicture}
\\

grid pattern:
\begin{tikzpicture}
\draw[draw=black, fill=black!10, pattern=grid, pattern color=black] (0,0) rectangle (1,1);
\end{tikzpicture}
\end{document}

Since #11473, there is some tiny glitches on lines, should we reopen this ticket until rendering is perfectly effected ?