x/image/font/opentype: Face isn't compliant with font.Face

What version of Go are you using (go version)?

$ go version
go version go1.19.5 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/shady/.cache/go-build"
GOENV="/home/shady/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/shady/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/shady/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19.5"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build457832407=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I created a new face from opentype. Then, I called Glyph() on a non existing character.
What did you expect to see?
I expected it to return !ok, as stated in the font.Face documentation.
What did you see instead?
It returns ok.

I don't see an owner listed on https://dev.golang.org/owners, but most of the code seems to have been written by @nigeltao.

Hi! I proposed a small change here that should fix this issue.

I'm tempted to close this as Working As Intended.
Glyph index 0 is a valid index, and by convention it's the .notdef glyph used for missing characters. See:

https://learn.microsoft.com/en-us/typography/opentype/otspec170/recom#shape-of-notdef-glyph
https://www.high-logic.com/fontcreator/manual11/recommendedglyphs.html

Calling opentype.Face.Glyph with a rune that isn't covered by the font face should therefore arguably return ok == true and this .notdef glyph (typically an empty rectangle). The Face does contain a glyph for the rune argument. It just happens to be a fallback glyph.
There is a separate question of "if I have a string, what runes in it are covered by this Face (excluding .notdef glyphs)", but that is a much more complicated question, related to Harfbuzz-like layout and shaping and fontconfig-like font selection, and surely deserves separate API.
For example, Han Unification means that "does this Face have a non-zero glyph index for this rune" isn't sufficient to answer "is this the right font for this rune". At a minimum, this should probably involve some concept of the user's locale, but I don't think Go has a good cross-platform abstraction for this yet.
For example, Android's minikin library's author said that:

Much of the internal structure of Minikin is dedicated to itemization, which is done largely on the basis of the cmap coverage of the fonts in the fallback chain. Doing that query font-by-font for every character would be expensive, so there are fancy bitmap acceleration structures.

Again, font selection and coverage calculation is a bigger problem needing separate API.

Consider the opentype example_test.go file, changing the "e" in the "jelly" string to a Unicode U+2603 Snowman, and running go test:
diff --git a/font/opentype/example_test.go b/font/opentype/example_test.go
index 4d7ee85..c8d522a 100644
--- a/font/opentype/example_test.go
+++ b/font/opentype/example_test.go
@@ -46,7 +46,7 @@ func ExampleNewFace() {
                Dot:  fixed.P(startingDotX, startingDotY),
        }
        fmt.Printf("The dot is at %v\n", d.Dot)
-       d.DrawString("jel")
+       d.DrawString("j\u2603l")
        fmt.Printf("The dot is at %v\n", d.Dot)
        d.Src = image.NewUniform(color.Gray{0x7F})
        d.DrawString("ly")

Without your patch, this draws something roughly like "j▯lly" with an empty rectangle.
With your patch, this draws "jlly" with nothing at all between the "j" and the "l".

I think (1) is the better output.

Hello! Thank you for your response.

Glyph index 0 is a valid index, and by convention it's the .notdef glyph used for missing characters. See

I agree! Glyph index 0 is a valid index, however, it implies that the glyph you are trying to draw isn't present. The fact that the .notdef is being returned should mean that ok == false, as stated in the font.Face documentation.

It returns !ok if the face does not contain a glyph for r.

(Glyph, GlyphAdvance, GlyphBounds)
To me, this sounds like it must return an ok == false, and the .notdef glyph. After all, what is the point of the ok variable if not to determine that it is using a fallback glyph? The only other thing I see is for error handling, and to me, in an ideal world errors would mean itd draw the .notdef glyph.
The benefit of this patch is that libraries like multiface could work properly. It would make users be able to use fallback glyphs without the need for called Index() ourselves.

There is a separate question of "if I have a string, what runes in it are covered by this Face (excluding .notdef glyphs)", but that is a much more complicated question, related to Harfbuzz-like layout and shaping and fontconfig-like font selection, and surely deserves separate API.
For example, Han Unification means that "does this Face have a non-zero glyph index for this rune" isn't sufficient to answer "is this the right font for this rune". At a minimum, this should probably involve some concept of the user's locale, but I don't think Go has a good cross-platform abstraction for this yet.

There could be a separate structure and API for this, but I'm not sure to what extent that is relevant to the issue at hand.
I don't think this patch is significantly slower than before. It introduces 1-2 checks per function. The index() calls were already done before, it was just inline.
Regarding the example_test.go,  you are right. That test should output something like j▯lly. However, that sounds like an issue that should be fixed, rather than an issue that should be used to cancel this pr. I will look into how to fix this as soon as I can.

Consider the opentype example_test.go file, changing the "e" in the "jelly" string to a Unicode U+2603 Snowman, and running go test:
diff --git a/font/opentype/example_test.go b/font/opentype/example_test.go
index 4d7ee85..c8d522a 100644
--- a/font/opentype/example_test.go
+++ b/font/opentype/example_test.go
@@ -46,7 +46,7 @@ func ExampleNewFace() {
                Dot:  fixed.P(startingDotX, startingDotY),
        }
        fmt.Printf("The dot is at %v\n", d.Dot)
-       d.DrawString("jel")
+       d.DrawString("j\u2603l")
        fmt.Printf("The dot is at %v\n", d.Dot)
        d.Src = image.NewUniform(color.Gray{0x7F})
        d.DrawString("ly")

1. Without your patch, this draws something roughly like "j▯lly" with an empty rectangle.

2. With your patch, this draws "jlly" with nothing at all between the "j" and the "l".

I think (1) is the better output.

This is an issue due to image/font/font.go,  DrawString,  !ok has a TODO and a continue. When the check is removed, it would still draw ▯. Its better not to do the check regardless, as for errors return a 0 advance, and .notdef values still return ▯.
I am however unsure of this. It sounds a bit out of scope, what do you think @nigeltao?

Hello, may I please get an update on this, @nigeltao?


Read more -> jump to "more" anchor

Prerequisites

[X] I have searched for duplicate or closed feature requests

Proposal
Currently "read more" is just a link to a blog post.
In WordPress it worked different. It was a link to a blog posts more anchor, which could be manually set with <!--more-->.
Would be nice if you could implement this into your theme.
Motivation and context
Sometimes blog posts need more "preview" and if you click on "read more" you would not want to read the preview again.

Sounds good, it's possible to implement it, but there should be a parameter that control this behavior, it's hard to name that parameter, any suggestions about naming?

post.jumpto = readmore|start

Thought about it. Nothing useful yet. :)

@Natenom Thanks for the suggestion, I think post.readMoreFromContent may be more clear. I'll merge that PR #696 if the name is OK for you.


Android app will crash, when LNURLw doesn't have enough resources

Description
When there is LNURLw what allow withdrawal more, then it's actually placed on wallet, instead of error and failed payment, application will completely crash.
Expected Behavior
Error about failed payment.
Actual Behavior
App crashes completely.
Possible Fix
Handle error of failed payment.
Steps to Reproduce

On LNBits create LNURw and fund wallet some sats, but less then maximal allowed amount
Try withdraw some funds, lower than limit, but higher then actual funds available using Android app
App will crash.

Context
Annoying :)
Your Environment
Mi 10T Pro, Android 12 (MIUI 13.0.8)

BitBanana version: (0.6.6-beta)
Android version: (12 SKQ1.2211006)
Device: (Mi 10T Pro)
LND Version: (v0.16.4-beta)
LNBits Version: (0.10.10)

@theerror
Thanks for reporting the issue.
I was not aware of it. I'll see what I can do!

@theerror
I found the issue. Actually LNBits is not following the LNURL Spec correctly.
See the Issue that I opened here: https://github.com/lnbits/lnbits/issues/1953
Still it should of course not crash. I fixed the crash now (https://github.com/michaelWuensch/BitBanana/commit/00b98e70a17de0beeacb8d698b6fef896ec3349a) but due to the incorrect format of the returned error, it doesn't look that pretty. Once LNBits fixed their LNURLw implementation, the error message should look fine.
The fix will be in the next version, that will drop quite soon!
This is how it looks now:


Release build tests don't all pass

Would this still be the case if we removed the EXPECT_DEATH tests which check particular asserts?

Sorry for the long post, many things here as I started reading how to deal with this.

Release build optimises for speed, so -DNDEBUG flag is passed when building, which disable all asserts. We can simply remove this flag, which will make all tests pass in the Release build, but then we would surely lose performance, since the code will then run all the asserts.

It seems that the best thing to do is to develop in Debug build (which we do now), but test the Release build (we test the Debug build only), since it is ultimately what will be run outside of the development environment (see https://stackoverflow.com/questions/3416665/unit-testing-on-a-build-server-release-or-debug-code). Some compiler optimisations might make the Debug executable and Release executable behave slightly different, which might cause bugs (e.g. https://stackoverflow.com/questions/20484449/unit-test-passes-in-debug-build-but-fails-in-release-build ). So my vote is on testing the Release executable, not the Debug one, to make sure the code which will be executed by others is fine.

However, as said, to test the Release build we have to enable all asserts, which make us lose performance. There is a reason why cmake disable asserts in Release mode: asserts should not be in the Release executable. We need to revisit the asserts in pandora. I agree with this post: https://stackoverflow.com/a/409981/5264075 . Assertions are for conditions that should never happen when running the code - it is solely to catch developer errors, not user/data errors, and thus can be safely disabled in Release mode, e.g. asserting that the node coverage is the same as the number of reads in a pangenome::Node (this error cannot be caused by the user or the data, but only by programmers misusing the update_node_info_with_this_read function):
https://github.com/rmcolq/pandora/blob/ef6efe1d9e8231a45b2b3e33f5acc614389d1c7c/src/pangenome/pangraph.cpp#L69-L73
Exceptions are used for run-time error conditions, which could potentially happen when running the tool due to user/data problems, and must be enabled in Release mode, e.g.: the user passing a window size smaller than the kmer size:
https://github.com/rmcolq/pandora/blob/ef6efe1d9e8231a45b2b3e33f5acc614389d1c7c/src/compare_main.cpp#L269
This assert above also is very serious - in the current Release build, we allow the user to do this without any error message.
My impression is that the vast majority of the asserts in pandora deal with runtime errors, not developer errors. Runtime errors assertions must be in the executable. So I'd vote for: 1) quick fix: enable asserts in Release mode; 2) long term, better fix: refactor assert statements, splitting them into asserts and exceptions, asserts are disabled in Release mode, exceptions are enabled.

Solved in v0.8.0


plugins: component mounts again on switching editing mode

Components mount again each time one switches between editing and layout (add, rearrange, resize) mode.

why is that a problem?

I'm currently working on an injection plugin and this causes a new request to the injected Element each time you switch the mode.

I see, you could probably abstract the http call away and put some caching in place, or use the state to store the data temporarily

So, you mean the global editor store? Because storing the data in the component (which I tried) doesn't work, as it looses the state on mounting, or does it?

Yes you are correct. We sort of use the global store for storing temporary data from slate and use unserialize/deserialize to clean it up when exporting or hydrate it when importing. It would be, of course, better if there was no need for it, but I'm not sure if there is a quick fix for this issue.
Maybe opt for a MyPluginService for now that does some caching.
@inyono your opinion is valuable here :)

I basically said the same thing. Furthermore, if done correctly, we might get a better UX when storing the response in state since we can already show the exercise before making the request (especially annoying when having bad network connection). Similar to server-side rendering

Yes that is true. However, I dislike that deserialize and serialize might become such a popular use case. It's very easy to mess up here and return an invalid state as a third party developer. This might break the cell's content as a whole.
Do we have any other way of solving this?

Not sure what this has to do with (de-)serialize?

because it's cleaning the state up? or do you want to store the cache data within the document?

Yep, I wanted to store it within the document.

Solved this with a global cache, which is a good enough solution for me. Thanks 👍 -> Closing


Add print waterbody downstreams

To assist with determining points of connection between waterbodies and associated downstream segments/reaches/networks, this function adds a set designating the segments that are downstream of waterbodies -- i.e., the upstream-most segments of networks below a water body.
The main work of this function occurs in networkbuilder.py in the function get_waterbody_segments. The various sets generated by the get_waterbody_segments are returned as part of the tuple handled by the get_nhd_connections  in nhd_network_utilities.py.
The result of this change is observed by directly executing networkbuilder.py:
python networkbuilder.py

... or by calling the function with one of the example networks in the network traversal tool, setting the debuglevel to 3 to get a full printout of the waterbody sets, as in:
python nhd_network_traversal.py -w -n Pocono_TEST1 --debuglevel 3

@kumdonoaa I'm working on getting @awlostowski-noaa added to the repository so he can help review.

This PR is a simple update to make a little more information about the waterbodies available to the main application.


If I remove badssentials my server gets stuck in the loading screen

I've disabled every single resource in my server that isn't default or badssentials, and I still get stuck in the loading screen, if I start badssentials, or add it back after removing it from my server, it magically loads into the gam.e like normal.
 I would trust Badger enough to say that there is no malware, but I am certainly not doing anything wrong on my end

You're doing something wrong...


DeepLx Support

basically its deepl but without apikey https://github.com/OwO-Network/DeepLX

Thanks for sharing this! I want to make sure that adding this feature needs to setup your own service right?

yes

Done in #28


chore(part): remove obsolete sections

:tada: This PR is included in version 1.29.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use of nfft, pfft and pnfft

A few month ago support for nfft and pnfft was added. I don't know which combinations of these libraries should either be used together or are mutually exclusive. Should additional checks be added in case any specific combinations are required or disallowed?

Need to check:
variant(
"pnfft",
default=False,
when="+pfft",
description="Compile with PNFFT - Parallel Nonequispaced FFT library",
)


Add #issuecomment-382083526 to integration guide

This is the PR for https://github.com/pypa/warehouse/issues/3754

Need to make the title underline on line 86 match the length of the title above it.

@brainwane LGTM

@julieqiu Hi! Now that PyCon's over, do you have a moment to fix this up? Thanks.


Support Resteemed content

Resteemed content has been disabled and is automatically filtered out. Some users have accounts that are aggregated content by using resteems. Need to look at the best way to reimplement resteemed content.

Perhaps a new route/view that is /@:username/resteem/:permlink and pulls in external content and displays it with info that it is a resteem from X
should also be a setting to enable/disable


JapaneseStyle Validator

Japanese has two types of styles (desu/masu style and deal style). This validator detect the a mixture of desu-masu and deal style.

Fixed with #420


[Feature] enable redirect to be external address for stream load

Signed-off-by: Kevin Xiaohua Cai<EMAIL_ADDRESS>What type of PR is this：

[ ] BugFix
[X] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/common/Config.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/http/rest/LoadAction.java
9
9
100.00%
[]

not needed.


Surface more chat errors to ErrorBar

What
Show errors in UI when:

Incorrect credentials are used

Incorrect ACS endpoint is provided

Incorrect thread ID is used / user is not in the thread.

Sending message when user is not in a thread.

Two errors in the error bar.

How Tested
ChatComposite in local storybook.

todo: Add screenshots to PR
Update: DONE.

Screenshots looks great! Is there screenshot for showing multiple errors?

todo: Add screenshots to PR
Update: DONE.

Screenshots looks great! Is there screenshot for showing multiple errors?

Updated the PR description with example of two errors.


npm run preview doesn't work

Describe the bug
If one creates an app using the default set of instructions for svelte kit, the command npm run preview doesn't work.
Reproduction
npm init svelte@next my-app
cd my-app
npm install
npm run dev -- --open
npm run preview
Logs
npm run preview

><EMAIL_ADDRESS>preview
> svelte-kit preview

> Cannot find module '/Users/rgc/Desktop/my-app/.svelte-kit/output/server/index.js' imported from<EMAIL_ADDRESS>    at new NodeError (node:internal/errors:371:5)
    at finalizeResolution (node:internal/modules/esm/resolve:416:11)
    at moduleResolve (node:internal/modules/esm/resolve:932:10)
    at defaultResolve (node:internal/modules/esm/resolve:1044:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:422:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:222:40)
    at ESMLoader.import (node:internal/modules/esm/loader:276:22)
    at importModuleDynamically (node:internal/modules/esm/translators:111:35)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14)
    at preview (file:///Users/rgc/Desktop/my-app/node_modules/@sveltejs/kit/dist/chunks/index5.js:58:69)

System Info
System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1
    Memory: 69.77 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - /usr/local/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 8.4.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 99.0.4844.51
    Safari: 15.2
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.31
    @sveltejs/kit: next => 1.0.0-next.295
    svelte: ^3.46.0 => 3.46.4

Severity
blocking all usage of SvelteKit
Additional Information
can't deploy the app to a certain provider (cloud flare pages)

Hi Rajan,
Did you tried 'npm run build' before preview?

It worked post build for the sample app but it's failing for my app. Will see what's wrong. Thanks.

@Rajan Have you been able to solve your problem?

It worked after running this command.
rgc@Rajans-Computer my-app % sudo npm run build

Thanks for checking again, I will try it.


dictation_context: use talon.ui import to fix running on windows

Per Slack discussion with aegis, talon.ui.mac shouldn't imported from it all, we should import use the platform independent version instead.
Specifically, the mac package fails to raise ImportError properly:
2022-04-04 15:04:10 ERROR user.talon_axkit.dictation.dictation_context (C:\Users\nriley\AppData\Roaming\talon\user\talon_axkit\dictation\dictation_context.py) import failed
   15:                                    threading.py:930* # loader thread
   14:                                    threading.py:973*
   13:                                    threading.py:910*
   12:                         app\resources\loader.py:887|
   11:                         app\resources\loader.py:823|
   10:                         app\resources\loader.py:641|
    9:                         app\resources\loader.py:677|
    8:                         app\resources\loader.py:731|
    7:                         app\resources\loader.py:427| # [stack splice]
    6:                           importlib\__init__.py:127|
    5:                         app\resources\loader.py:248|
    4:                         app\resources\loader.py:243|
    3: user\talon_axkit\dictation\dictation_context.py:9  | from talon.mac.ui import Element
    2:                         app\resources\loader.py:361|
    1:                                 talon\mac\ui.py:29 |
AttributeError: 'Library' object has no attribute 'tl_mac_has_separate_spaces'

Do we want to add a if typing.TYPE_CHECKING per Slack?

I wasn't sure if that is helpful in our case as it'll still generate an error if undefined!

Do we want to add a if typing.TYPE_CHECKING per Slack?

Sorry, I didn't follow this part of the discussion. Is this the suggestion we set mypy?

Do we want to add a if typing.TYPE_CHECKING per Slack?

Sorry, I didn't follow this part of the discussion. Is this suggesting we set mypy?

This constant allows you to distinguish between evaluation for type checking and evaluation for execution. I think this isn't too useful here as the problem isn't with type checking per se, it's that talon.ui.Element isn't even defined on Windows (or Linux).

Do we want to add a if typing.TYPE_CHECKING per Slack?

Sorry, I didn't follow this part of the discussion. Is this suggesting we set mypy?

This constant allows you to distinguish between evaluation for type checking and evaluation for execution. I think this isn't too useful here as the problem isn't with type checking per se, it's that talon.ui.Element isn't even defined on Windows (or Linux).

Yeah I think it wouldn't necessarily solve any problems, just was thinking might be good hygiene, but the docs seem to imply that it's only worth the complexity if the module is expensive to import, so maybe we should just leave it

@nriley @pokey mind stamping this one? Thanks

Pretty sure @nriley has to do it because he requested changes

Ah, interesting.

OK, that works :) ThanksQ!

@nriley think you actually have to explicitly give this an "approved" code review, because you previously requested changes (that's what pokey is referring to) :)

OK, that works! Still learning here…

It's actually new to me too -- our GitHub Enterprise instance at work doesn't have this feature yet, so it actually causes a little bit of conflict (e.g. "I requested changes but then somebody else approved it and you merged it without addressing my concern, etc etc") :)


Test more edge cases

move file from tests/wpt/web-platform-tests to tests/wpt/mozilla

no changes
with changes

move file from tests/wpt/mozilla to tests/wpt/web-platform-tests

no changes
with changes

change properties of file in tests/wpt/web-platform-tests

no changes
with changes

create file in new subdirectory of tests/wpt/web-platform-tests


feat(RingTheory/Flat): flat base change commutes with equalizers

... and with kernels. For good definitional properties, the equality ker f = eqLocus f 0 is not used.

Thanks!
maintainer merge

Thanks!
bors merge


i have issue while build the project

how to solve this i am working on this project

yeah installed the the link you hav given  in github and then switch the version according to instruction

Did you compile it? The Makefile is relatively straightforward, it compiles the Autoparking units first, then it links them with the Allegro archives. Based on your error log, the latter stage is failing, which could  be due to non-compiled Allegro, or wrong folders. Assuming you're familiar with the C++ compilation process and Linux, I recommend you troubleshoote the issue through find (to locate the object files), grep to find the symbols and nm to inspect the object files.

I have followed all your given instructions in readme file and i tried every possible solutions to build the project but error is not going

when i compile the allegro

Hi, so Allegro 5.2.4 fails to compile as I suspected. I investigated the problem and it seems that an external dependency changed its API, thus breaking that Allegro build. Luckily, Allegro 5.2.7 (newer version) seems to work: can you try it and let me know if it solves your problem?

sir now this error occured ater folllowing previous steps and  Downloading new version of allgero

Hi, I have updated the Makefile, that should solve your problem.  Please run make clean, pull the latest master and follow the instructions again.

Thankyou so much its works


Ships generate above the ocean level in islands.

Ships generate above the ocean level in islands.
Version: 6.0pre9, 6.0pre10, 6.0pre11

This can't be fixed.


Acunetix Parser Bug

hello guys i hope you are doing great, i am facing an issue with Acunetix parser i tried to use the re-upload feature to upload my report and i got this error message
Deployment method (select with an X)

[X] Kubernetes

Console logs (optional)
[pid: 1|app: 0|req: 262549/510967] <IP_ADDRESS> () {34 vars in 411 bytes} [Mon May 24 13:23:15 2021] GET /uwsgi_health => generated 13394 bytes in 24 msecs (HTTP/1.1 200) 9 headers in 472 bytes (1 switches on core 1)
[pid: 1|app: 0|req: 262550/510968] <IP_ADDRESS> () {30 vars in 392 bytes} [Mon May 24 13:23:22 2021] GET /login?next=/ => generated 13394 bytes in 26 msecs (HTTP/1.1 200) 9 headers in 472 bytes (1 switches on core 0)
[pid: 1|app: 0|req: 262551/510969] <IP_ADDRESS> () {34 vars in 411 bytes} [Mon May 24 13:23:25 2021] GET /uwsgi_health => generated 13394 bytes in 25 msecs (HTTP/1.1 200) 9 headers in 472 bytes (1 switches on core 1)
[24/May/2021 13:23:27] ERROR [dojo:701]
Traceback (most recent call last):
File "./dojo/test/views.py", line 692, in re_import_scan_results
parser_findings = parser.get_findings(file, test)
File "./dojo/tools/acunetix/parser.py", line 33, in get_findings
return self.set_defectdojo_findings(acunetix_defectdojo_findings, test)
File "./dojo/tools/acunetix/parser.py", line 44, in set_defectdojo_findings
date=get_defectdojo_date(acunetix_defectdojo_finding.date),
File "./dojo/tools/acunetix/parser.py", line 70, in get_defectdojo_date
match = next(enumerate(matches))
StopIteration
[24/May/2021 13:23:27] ERROR [dojo:702] Error in parser:
[pid: 1|app: 0|req: 262552/510970] <IP_ADDRESS> () {76 vars in 1982 bytes} [Mon May 24 13:23:27 2021] POST /test/46/re_import_scan_results => generated 0 bytes in 53 msecs (HTTP/1.1 302) 8 headers in 466 bytes (1 switches on core 0)
[uwsgi-http key: chs-defectdojo.cegedim.com client_addr: <IP_ADDRESS> client_port: 1212] hr_read(): Connection reset by peer [plugins/http/http.c line 917]
Thanks i hope to hear from you soon

@AliElKhatteb is it possible to have the report that failed? (even redacted)

unfortunately i can't its a pentest report in my company

edited_report.zip

btw i used also json format and its not working also

taking a look at your report.

On release 2.0.0:

so its fixed on release 1.15.0

it seems. It's why it's important to specify the release number when you open an issue. Most of the time, the bug is already fixed in further releases. :)


[WIP] Error handling refactor

refs #6039, closes #6047, closes #6048
Implements the error handling refactor as outlined in https://github.com/TryGhost/Ghost/issues/6048#issuecomment-154045037

[x] add failing tests for #6047 & #6048
[x] add 401 error handling to application route to redirect to signin screen when user has invalid session
[ ] remove .catch() in ValidationEngine.save so that we let errors bubble up
[ ] review all uses of .save().catch() and remove or update to let errors bubble if appropriate
[ ] display the re-auth modal if user's session is invalid when attempting to save a post in the editor
[ ] use application route's error action to display an appropriate alert if not previously handled

Closing as much of this has been implemented alongside other PRs or superseded by new functionality.


Implement RelativeTime on Intl.RelativeTimeFormat API

https://developers.google.com/web/updates/2018/10/intl-relativetimeformat
https://github.com/tc39/proposal-intl-relative-time

CC: @github/web-systems

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#Browser_compatibility


Space with modifier stopped working

After an upgrade to
[I] ➜ keyd --version
keyd version: 2.2.1-beta (05d994b7e98c8d090e67c43cb37ac23a36948efc)

It seems like all combinations of modifiers and space result in just space. Is someone else seeing the same thing?
It's messing up Emacs bit :disappointed:

What is your config? I can't seem to reproduce this with a blank one.

This is my config
[ids]
0001:0001

[main]
# swap escape and capslock
capslock = esc
esc = capslock

# alt on hold and rightalt on tap (compose)
leftalt = overload(A, rightalt)
rightalt = overload(A, rightalt)

# meta on PrtSc
sysrq = layer(meta)

# vim movement layer, on space
space = overload(vim_mov, space)

[vim_mov]
h = left
j = down
k = up
l = right
p = pageup
; = pagedown
[ = home
' = end

Thanks. Overloaded sequences are now executed literally irrespective of context.  I've changed this behaviour in latest commit so this doesn't happen in the base layer which should fix your problem.

Excellent, that fixed it! Thanks for amazingly quick response.


Do not run only one test

Now let's see which tests are really failing.

Closing, because @jahow is working on this as well.


Added a library project

Added a library project for the library.
TODO : add a project for benchmarks and examples.

Good idea.
However the xcode stuff needs to go in the Xcode folder. The Lumberjack folder is reserved for the actual Lumberjack source code files.

As far as I understand, you've moved the project directory here.
https://github.com/robbiehanson/CocoaLumberjack/tree/master/Xcode/LumberjackFramework/Mobile
I have a slightly different vision of a perfect directories structure. Sorry.
I'm really glad to have a library project in the mainstream of the CocoaLumberjack.
Thank you for a great framework.

An even better way to distribute your project will be a static framework. Even newbies will have no problems integrating it to their projects.
kstenerud has a great template here, at github ( kstenerud / iOS-Universal-Framework ).
However, you'll have to patch his scripts to make them work with your your directories layout.
As for me, I'm happy to build a library from sources. (I wasn't happy to reuse them in a copy-paste style ).

static frameworks are good if you want to distribute just the binary, but not very good if you use xcode workspaces.

A logging framework is not a thing you should want to rebuild every
time. --> a binary fits just fine
Many iOS developers still do not use libraries properly preferring to
reuse the code in the "drag&drop sources" way.
I agree. A framework binary may be too large as it contains symbols for
both the device and the simulator. That's why I use libraries when deal
with open source.


ap/service bot

Added service_bot.py
Added run_service_bot bash script to automatically run TradingBot #wip
Get positions to uccesfully transact
Update position logs
refactor: use main() instead of global vars

Moved this to Golang in the NibiruChain/fbot repo


Steady state options in RISE

Hi Junior,
I asked about what RISE reports as "steady state" values in the solution and your answer was that it is "simply the deterministic steady state. RISE does not formally compute the ergodic mean at least for the purpose of presenting the solution. This is why RISE reports in separate expressions (@sig, @sig@sig,...), the elements related to the perturbation parameter." I have some follow up questions on this which are related to the different options of specifying around which point RISE should approximate the model (steady_state_unique, steady_state_imposed, "no specification").
I should first mention, that I have a model with an occasionally binding incentive constraint for banks. In my steady state file, I provide accurate values for the binding regime, but I don't tell RISE that it is the steady state for the binding regime, i.e., I only enter v."varname" = "some value" without using the bind-nobind-parameters.
When comparing some of the solutions from steady_state_unique, steady_state_imposed, "no specification", I noticed the following:
steady_state_unique (--> approximation around the ergodic mean)

RISE takes pretty much my given steady state values as deterministic steady state values for both regimes.
Hence, the user_resids reported in m are very small and pretty much the same as mine (i.e. those which appear when I use resid(m) command right after the rise command).
The values provided in @sig are rather small and different between the two regimes.

steady_state_fixed (--> approximation around an arbitrary point)

in most cases RISE takes my given steady state values as deterministic steady state values for both regimes, but in some cases the deterministic steady state values differ quite a bit from mine but are still the same for both regimes.
Hence, the user_resids become quite large (up to 1) for some of the equations.
The values provided in @sig are sometimes very big and differ quite a bit between NB and B.

"no specification of the point around which RISE should approx. the model" (--> default option: approximation around regime-specific steady states)

RISE apparently recognizes that I provide the values for the binding regime, and takes them as deterministic steady state values for the binding regime. For the NB regime it calculates an entirely new deterministic steady state (the values seem plausible to me for the non-binding case).
The user_resids are exactly the same I get with my values (i.e. those which appear when I use resid(m) command right after the rise command) so, I think RISE does not calculate them for its own steady state values (?).
The values provided in @sig are very small (essentially zero for binding regime and also very small for non-binding regime).

My resulting questions are:

Why are the deterministic steady states different between fixed and imposed? And particularly in the case of steady_state_fixed, why does RISE settle on a deterministic steady state which creates much bigger residuals in the model equations than the values I provide?
What do the values in @sig tell me under the three different steady state options?
How can I find out the point around which the system is approximated? From Maih (2015), I understand that for steady_state_unique and steady_state_imposed, RISE should approximate around just one point, i.e. the approximation point can't found by deterministic steady state + @sig or just @sig, because the resulting points would be different between the two regimes, i.e., there would be two approximation points.
The irfs I get from the irf command are shown in deviations from the respective approximation point or from the deterministic steady state?

Thank you in advance.
Best,
Johanna

Hi Johanna,

Fixed refers to some variables being fixed while imposed says that RISE should not check whether the approximation point is indeed the steady state
Whenever a vector of variables does not solve the steady state, in the version of RISE you are running, the discrepancy is stored in @sig. RISE then tries to solve for the dynamics in such a way that the original problem Ef(x(+1),x,x(-1),e)=0 despite the fact that the point we take the expansion around is not the steady state
The point around which the expansion is done is the steady state or the imposed point. The only difference is that if the point taken say, x is not such that f(x,x,x,0)=0, then the resulting residual has to be dealt with such that we still have that the approximated problem is zero in expectation. Obviously the steady state is the only point such that f(x,x,x,0)=0.
The IRFs are computed in deviation from the initial condition, which is the steady state.

Cheers,
J.


Native macOS (CoreGraphics) Plot Rendering

Adds a (partial) canvas implementation to support Vega rendering
(using the existing JavaScript canvas renderer) into CoreGraphics.
Thoroughly unit tests the above, by running through examples
from Vega, Vega-Lite, and Turi Create, and comparing the output
with output from the Vega canvas renderer in WebKit.
Adds C++ API to turi::visualization::Plot to render a Plot object
with CoreGraphics.
Adds C API to TuriCreate.h exposing the above C++ API.
Adopts NS_OPTIONS for direct enum binding to Swift from TuriCore.h.

@hoytak Please review the C++ and C parts. I'm not sure everything I'm doing there is quite right.
Depends on #1362.

@hoytak @abhishekpratapa @shantanuchhabra @TobyRoseman Review feedback has largely been addressed. I think this PR is ready to go in. Please sign off (and/or leave further feedback), thanks!


Cannot read property 'appendChild'

I setup a very simple test with the following markup:

Drag Me

Drag Me 2

and initialed it using var drake = dragula([document.querySelector('#container')]);
However, I'm getting the following error when I attempt to drag an item:
Uncaught TypeError: Cannot read property 'appendChild'
of nullrenderMirrorImage @ dragula.js:426startBecauseMouseMoved @ dragula.js:150

Any idea what the issue could be?  Thanks

I have the same problem.

I already download previous version (v3.5.3) and this version works correct.
Only last v3.5.4 version has this bug.

Could you provide a longer stack trace?

@jaw4ik is because dragula was included in the  tag, prior  was constructed.
To solve, just include dragula file inside the  tag.

you might want to state this clearly ath the start of the documentation page. had the same problem, took me some time to figure out, spending it debugging the source, actually. very rare these day that we don't include js files either in the header and use jquery document init, or the newer "require" pattern

@netil Yep, that was it :)

Added a note to the readme.


[Feature] Allow overriding the title field of a type

Problem description
Currently you can use the docs field in a Fern type to set the description field in the generated OpenAPI spec, however there's no way to set the title field of the generated schema. Instead, it defaults to be the same as the type name.
Why would it be useful?
Being able to specify the title of a type adds another level of human readable documentation, in addition to the very useful docs field.
Describe the solution (optional)
I propose adding title as a field for any type, and that it follows the same semantics as the title field in the relevant JSON Schema spec, that is:

6.1.  "title" and "description"
The value of both of these keywords MUST be a string.
Both of these keywords can be used to decorate a user interface with
information about the data produced by this user interface.  A title
will preferrably be short, whereas a description will provide
explanation about the purpose of the instance described by this
schema.

Additional context
n/a

@mstade, we recently pushed a feature that will allow you to add display-name to every single type. This will be eventually plumbed through in the documentation, do you mind giving that a try ?

Will do and report back – thank you @dsinghvi!

Apologies @dsinghvi for not responding to this sooner. The display-name sets the summary, which as it turns out was actually a better choice than title. This solved a lot of issues for us – thank you for this!


Enhancement: error handling

When an error occurred(sometimes in preset), we just log them to the console/file, no further things can be done until socket on the other side timeout.
The unexpected incoming data will break connection every now and then, we don't have a proper mechanism to handle this kind of error.

Closed via 99408ce.


Fix edge case on invalid rpath detection (test case)

Neovim is valid, but fails check:
=> Checking shared library dependencies
### WARNING ###  /raven/lib/lua/5.1/lpeg.so is not in located in /lib, /usr/lib or within the
RPATH/RUNPATH (/raven/toolchain/ravensys-gcc/lib:/raven/lib:/raven/lib/lua/5.1)

lpeg.so is dlopened and has no soname (and breaks something if a soname is added).


Add ability to select multiple list items at a time for formatting or deletion

Current behaviour: As of now you can only select on list item at a time, this can make formatting and deleting items tedious
Expected behaviour: Add ability to select multiple list items at a time and apply styles and formatting to all at once or delete all

I need the same features. It's irritating at the moment

Seems to relate to not having contenteditable="true" in top level ul or ol element. I'm not sure if this creates any regressions. It seems to work well within Directus CMS. I've created a PR here https://github.com/editor-js/nested-list/pull/77.


Gauss–Kronrod points and weights?

It would be nice to have support for generating Gauss–Kronrod points and weights for the weight functions in FastGaussQuadrature, at least when they exist, in order to have an error estimate from the resulting quadrature rule.
JuliaMath/QuadGK.jl/pull/83 should land shortly, and provides an implementation of an O(n²) algorithm by Laurie (1997) that takes as input a SymTridiagonal Jacobi matrix J for a weight function, and outputs a "Kronrod–Jacobi matrix" QuadGK.kronrodjacobi(J, n) whose eigenvalues/eigenvectors yield an order-n Gauss–Kronrod rule (exactly as an ordinary Jacobi matrix yields the Gaussian quadrature rule).   Arbitrary-precision arithmetic is supported.
The two caveats are (a) it's O(n²), and (b) a Gauss–Kronrod rule may not always exist for all weight functions.  (If real points and weights don't exist, kronrodjacobi throws an error.)  Even if the Kronrod rule exists, it may include quadrature points that lie outside of the original interval.

I thought Gauss–Kronrod tends to be low order eg n = 15. So does point (a) really matter?

h-adaptive quadrature schemes based on Gauss–Kronrod typically use relatively low order.    That's why I don't worry about the O(n²) in QuadGK.
In principle, however, you can use Gauss–Kronrod at any order if you want an error estimate from your quadrature scheme.   For p-adaptive quadrature, one does often go to high order, but in this case you typically want a whole family of nested rules, not just two — either Gauss–Patterson or Clenshaw–Curtis, typically.

Sounds more like a research question (not just a coding one) in the first instance. There would have to be a very strong application for this to be pursued though...

The application is anyone who wants to use a quadrature rule and have an error estimate - it’s not that mysterious. Personally, I find Gaussian quadrature rules hard to use in practice because they lack error estimates.
But if you only want O(n) algorithms in this package, I agree that’s a research problem for Kronrod.

I don't think we are not religious about O(n) so it could live here.
I see your point about error estimate.


[FEATURE] Support for external memory storage

Feature Area
Core functionality
Is your feature request related to a an existing bug? Please link it here.
Enabling memory cannot work when CrewAI application is deployed on a service that supports auto-scaling as the memory data storage files will not be present on new instance creation.
Describe the solution you'd like
Supporting client/server database integration and/or vertor storage integration where the storage is external to the server hosting the crewai application. I deally solution that can use main serverless cloud provider solutions like Vector Search (https://cloud.google.com/vertex-ai/docs/vector-search/quickstart) etc
Describe alternatives you've considered
Sharing drive among multiple instances but not sure how well this will scale and it is not a clean implementation. Additionally if the instance hosting the application dies the files are lost as well (in a serverless environment that storage is not persistent)
Additional context
No response
Willingness to Contribute
I can test the feature once it's implemented

still active feature request

keep alive


Make use of denyUncoveredHttpMethods when creating permissions

https://github.com/manorrock/piranha/commit/4a15509dde8d46735399a6b01adb8fa8125394f0


Catalog, Gear icon and bottom sheet to show error workflow.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1170
Description

Show gear icon when workflow is component workflow.
Hide workflow menu icon when workflow is component workflow.
Show bottom sheet with option show/hide error state buttons.
Use navigation graph to launch bottom sheet icon
On show/hide button click navigate back to questionnaire screen.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).


No GO term for beta-arrestin GPCR biased signalling

The only GO biological process term I found about arrestin is GPCR desensitization while in literature there are lots of papers talking about beta-arrestin biased pathway signaling. Here you have a review as example:
Transduction of Receptor Signals by ß-Arrestins
Robert J. Lefkowitz, Sudha K. Shenoy
Science 22 April 2005:
Vol. 308 no. 5721 pp. 512-517
DOI: 10.1126/science.1109237

Closing  this seems like a Molecular function involved in a  signalling process


Issue with outlines

So, ran into an odd little issue when trying to upscale a few images. It's a profile image for a character for a video game, and it has the headshot itself with a transparent background (so it can overlay it into the game without a set background image). Well, I think the transparency has something to do with why it isn't able to properly work with the outer edge of the image. See here for example, original image is above (basic upscaling with paint.net) with the Waifu'd image below.
http://i.imgur.com/YFQTrLk.png
Aside from the edge issues though, it looks absolutely phenomenal, so great work with the application overall!
EDIT: Well, the transparency had nothing to do with it. I just added a simple white background to the original image when testing, and I still got the absurdly pixelated outer edge.

I think that is a issue of the source image.

apply anti-aliasing or gaussian blur filter to the transparent channel before resizing.
or retouch the image after resizing.


Update Kubernetes APIs for 1.16

Various Kubernetes APIs were deprecated in 1.16. The various Heron Kubernetes yamls (and maybe code?) need to be updated to use the newer APIs. Kubernetes documentation on the changes can be found here: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
Example line that needs to be updated: https://github.com/apache/incubator-heron/blob/d8db1c50b499c823e319fd16a4476a02f525a367/deploy/kubernetes/helm/templates/tools.yaml#L31

@nicknezis any chance you could open up a PR to address these issues?

I've started the work. Also updating code to solve #3259

I bumped the API up from 1.0.0-beta3 to 3.0.0. I'm currently working on and testing a fix to use the latest 6.0.1. But this has more API changes so will take slightly longer.

This was completed by #3426


Unable to create a valid json representation of the SecretProviderClass object array

The readme notes that the object parameter is "most easily written using a YAML multi-line string or pipe character". Unfortunately cdk-eks will only accept json (https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-eks.KubernetesManifestProps.html).
I have tried a dozen ways to produce an acceptable json representation but can't seem to get it to work. Could you provide an example that would produce the equivalent of?:
apiVersion: secrets-store.csi.x-k8s.io/v1alpha1
kind: SecretProviderClass
metadata:
  name: my-secrets
  namespace: my-namespace
spec:
  provider: aws
  parameters:
    objects: |
      - objectName: "arn:aws:blahblah"
        objectType: "secretsmanager"

Many thanks!

Update! Finally got it work - hope this helps someone:
function buildSecretProviderClass(secretARN: string){

    const objectsList = `- objectName: \"` + secretARN + `\"\n  objectType: \"secretsmanager\"\n`;

    return {
         "apiVersion": "secrets-store.csi.x-k8s.io/v1alpha1",
         "kind": "SecretProviderClass",
         "metadata": {
            "name": "my-secrets",
            "namespace": "my-namespace"
        },
        "spec": {
            "provider": "aws",

            "parameters": {
                "objects": objectsList
            }

        }
    };
}


Mod function needs docs on behavior with negative numbers

https://docs.microsoft.com/en-us/azure/logic-apps/workflow-definition-language-functions-reference#mod
Needs examples and results for
// for each of these, are they -6, -5.5, -5, 5, 5.5, 6, or something else?
mod(-15.5,10)
mod(15.5,-10)
mod(-15.5,-10)

I also have similar questions about https://docs.microsoft.com/en-us/azure/logic-apps/workflow-definition-language-functions-reference#div
That is, should we think of these functions as implementing truncated division/remainder, floored division/remainder, euclidean division/remainder, ...?
A pointer to equivalent C# or Javascript functions would be sufficient to answer the question.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03aa9e88-7fa0-56ab-f794-58f0c37b6d7a
Version Independent ID: 25c5ef5c-6ba4-f5ff-f94b-8f2818ec2feb
Content: Reference guide for functions in expressions - Azure Logic Apps
Content Source: articles/logic-apps/workflow-definition-language-functions-reference.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Thanks for the feedback! We will review and get back to you shortly.

Javascript and C# both return the same results. They use the sign of the dividend, and Logic Apps do the same, so -5.5, 5.5, and -5.5. I've put in a PR to add examples with negative numbers. It will go live once the doc author has approved the changes.


fix: lock dev node version to 16.14.2

Description:
Latest node 16 image doesn't work anymore, so let's lock the version to 16.14.2

it doesn't work because of the dependencies that we have in the UI with this node version?

@daniellutz it won't work because the latest node 16 version has a bug


Saulparedes/fix kernel mshv config signature

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Update kernel-mshv config signature
Change Log

kernel-mshv

Does this affect the toolchain?

NO
Test Methodology

Pipeline error complains of mismatching signature https://dev.azure.com/mariner-org/mariner/_build/results?buildId=320349&view=logs&j=75cba72d-09cb-503a-3927-4ab61ac4a179&t=266a177c-c74b-572c-2e05-3a6c5cd5b38a&l=1570

Please run a buddybuild as well to verify

I was able to do a buddy build of kernel mshv https://dev.azure.com/mariner-org/mariner/_build/results?buildId=320407&view=results

Closing and reopening to restart checks


web support ?

not sure if this should be put in expo issues or here but when building for web, the modal works partly:
https://web-build-emy6a8m2f.now.sh
normally it shouldn't show by default (because isVisible is false at first)

This repo depends on the native React-Modal for the modal itself.
It seems on the web, react-native-web uses it's own modal component, so I believe this shouldn't work.

I am trying to use with react-native-web.
It works when modal needs to be displayed 'within' a particular component (eg within scroll view).
However, when I need modal to cover the whole screen within the browser, it does not work and instead is resized to be confined within parent's view dimention.
coverScreen setting does not seem to do anything

@rewieer react-native-web does not implement the Modal component, but there are interesting discussions here and here.

FYI<EMAIL_ADDRESS>now supports Modal. Currently testing this lib for web, and everything is working well from what I can tell so far..


Ayush version

I have completed my task of making blurred navbar work in Firefox as well as I have made navbar responsive so that it can work in mobile-view.
Desktop view:

Mobile View:

Thank you @kady-z  for your precious time and contribution to the webpage. Looking forward for more contributions


Documentation site is too bright

It hurts reading the docs because of the color scheme light grey/white and baby blue.  Is there any plans on changing or making a 'dark' theme for the documentation?

Yes, we know this already. On Windows its too bright, but it's a little bit tricky, because I'm not using windows and no windows user brought a good solution yet.

Fixed


Traceflow UX improvement

Describe the bug
Recently we received quite a lot support requests for the Traceflow feature with Octant UI, I helped troubleshoot one and it turned out it's just because the delay of the Traceflow result, but people may be confused by the blank graph and not realizing it's in progress.
To improve the user experience, instead of showing a blank graph, it would be better to have some message saying it's in progress or the traceflow is not found (due to illegal input).
Versions:
Please provide the following information:

Antrea version (Docker image tag). 0.9

@ZhangYW18 do you think it's something we can improve?

Currently, when drawing the traceflow graph, we judge the phase of traceflow first, and response with a blank graph if the phase is not "Succeeded". We can also show out some information on the graph when the traceflow is running, timeout, or in whatever any other status. When there's something wrong with traceflow, I suggest we show the error message via alerts, which will be available in the next Octant release.


Update yaml spec for orders top level element

@thedavidmeister I don't think that orderbook is optional feild here :
https://github.com/rainlanguage/specs/blob/main/ob-yaml.md?plain=1#L234

based on what @Siddharth2207 ?
if some code doesn't match the spec, typically we change the code, not the spec


Feature: Add feature to sign in to actually work

Feature description
I would like to work on that in firebase
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@Bijit-Mondal Go for it!

Yes, main branch only

I have create a PR


Error when skipping URL update

When I skip URL updates by removing the references section from the config file, i.e. lines 26-30 in
https://github.com/MerginMaps/mergin-media-sync/blob/main/config.yaml.default
I get the following error:
Silent ignoring references section if not contained in config file.

This is not correct.
We would like the service to not throw an error if the "references" section is missing form config.yaml.
At the moment it works and copies/moves files but throws an error if the references section is not present.
Error: SQLITE error: no such table: notes

It seems that with new version 0.4.0 you still have to add (e REFERENCES="[]" ) a reference section with an empty array. Otherwise it uses a defult confif with a "notes" table.
Error: SQLITE error: no such table: notes

I can quite see how this would happen, unless the specification is somewhere in the config.yaml.  There are explicit checks that replace setup references as [] if the references are missing from the config file or if it does not have value at all. The default yaml file is not read anywhere in the media sync.


nickname module removes trailing 0s

Hi, I have my bot appending IVs at the end of my nickname. I'm finding that its removing the trailing 0 if its there. For example, this bellsprout has 90%.

Use the following config:
"nickname_template": "{name:.8s}_{iv_pct}"
This will remove any letters from the name which are past the 8th symbol, so it will have space for the IV.


CodeCamp #46

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
models part-10 and others of #1982
Modification
Add typehint for models/utils, utils/array_converter.py and models/test_time_augs/merge_augs.py
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

@Xiangxu-0103, please review this PR

Please fix the lint.


FR: Exclude Folders

I would love the ability to exclude my templater folder from the SCL settings. the colors and emojis are all over the place as the templates are meant to be for actual notes. I'm sure folks would like to exclude other folders if possible

Going to close this now as the latest update allows you to style by path. You can restore the default styling by targeting that path to 'exclude' folders.


Update tests to cover non-bonded energies

Description
Resolves #118
Checklist

[ ] Add tests
[ ] Lint
[ ] Update docstrings

Something is still wrong with the big system, which I think relates to missing exceptions.


WebsiteAgent: @src and @title returning nothing

Here's me code:
{
  "expected_update_period_in_days": "90",
  "url": "https://nzb.cat/register",
  "type": "html",
  "mode": "on_change",
  "extract": {
    "message": {
      "css": "#wrap > div.container > div.col-xs-10 > div > div.panel-body.grey-frame > div > div > div",
      "value": "string(.)"
    },
    "title": {
      "css": "head > title",
      "value": "string(.)"
    },
    "url": {
      "css": "#wrap > div.container > div.col-xs-10 > div > div.panel-body.grey-frame > div > div > div",
      "value": "@src"
    }
  }
}

Ideally, I'd like to use @title for the title, and @src for the URL, however the @ value's just aren't working as documented, am I missing something here?
Here's the output:
[
  {
    "message": " Registrations are currently invite only.    Invites donations are currently disabled. Please request an invite from a friend to register.    ",
    "title": "Register - A usenet indexing website",
    "url": ""
  }
]

And here's the log:
[00:00:00] INFO -- : Dry Run started
[00:00:00] INFO -- : Fetching https://nzb.cat/register
[00:00:01] INFO -- : Extracting html at #wrap > div.container > div.col-xs-10 > div > div.panel-body.grey-frame > div > div > div
[00:00:01] INFO -- : Values extracted: [" Registrations are currently invite only.    Invites donations are currently disabled. Please request an invite from a friend to register.    "]
[00:00:01] INFO -- : Extracting html at head > title
[00:00:01] INFO -- : Values extracted: ["Register - A usenet indexing website"]
[00:00:01] INFO -- : Extracting html at #wrap > div.container > div.col-xs-10 > div > div.panel-body.grey-frame > div > div > div
[00:00:01] INFO -- : Values extracted: [""]
[00:00:01] INFO -- : Storing new parsed result for 'nzb.cat/register': {"message"=>" Registrations are currently invite only.    Invites donations are currently disabled. Please request an invite from a friend to register.    ", "title"=>"Register - A usenet indexing website", "url"=>""}
[00:00:01] INFO -- : Dry Run finished

Hey @kjbweb
starting of exploring the whole huginn space and stumbled upon your issue.
Not sure this is the reason, but does your div selected via
    "url": {
      "css": "#wrap > div.container > div.col-xs-10 > div > div.panel-body.grey-frame > div > div > div",
      "value": "@src"
    }

actually contain an src attribute? Haven't checked the site, but the selector got me wondering. As far as I understand, it would select the div and looking for a src-attribute there, no?
Cheers,
@spekulatius

Hey @kjbweb
starting of exploring the whole huginn space and stumbled upon your issue.
Not sure this is the reason, but does your div selected via
    "url": {
      "css": "#wrap > div.container > div.col-xs-10 > div > div.panel-body.grey-frame > div > div > div",
      "value": "@src"
    }

actually contain an src attribute? Haven't checked the site, but the selector got me wondering. As far as I understand, it would select the div and looking for a src-attribute there, no?
Cheers,
@spekulatius

Similarity for @title, I would expect this to be an attribute instead of the text content of the title tag.

Similarity for @title, I would expect this to be an attribute instead of the text content of the title tag.


Datadog process agent master

Fixes https://github.com/NixOS/nixpkgs/issues/46520
@rvl @coretemp

I have tested this on my host and it seems to work. Now I can see that datadog agent is one of the top consumers of memory :-) (OK the VM isn't doing much). Thanks!


package only works if app uses default name

I was just having trouble with another composer package which required me to rename my app to a different namespace.
And then I started having trouble with this package. It seems that because you use this statement in your controller
use App\Http\Controllers\Controller;

That this package will only work for applications that use the default namespace. I have renamed mine and the only way I could get your package to work was to rename that use statement and add my namespace.
This is the first time I am faced with such a conflict... is there something I am missing?

@vesper8,
You are right, above use statement is static as of now. so if you change root namespace then it will create trouble. I will look into it and will find out a way to fix it in next release.

@vesper8,
I just released a new version with custom app namespace support. Refer documentation here to make it working: https://github.com/mitulgolakiya/laravel-api-generator#using-with-custom-application-namespace

You had fixed this apparently but now the problem is back. Using the dev-master I am still running into many cases where I have had to manually change the namespace since I am using a custom namespace different than "App". Specifically, the requests are being generated with 'App/Http/Requests' even though I have set the correct namespace in the generator.php config file under 'namespace_request' so it is being ignored.
The base controller is also having the same issue as what I initially opened this issue about.
On a side note, it appears that the path_views from the generator.php is also being ignored. I tried having my views generated in a subfolder of resources/views/API/ and getting the error InvalidArgumentException in FileViewFinder.php line 137:
View [networks.index] not found.
but it works fine if I leave it to the default


[$250] [QBO] Enable and Disable multi-level tags

We made changes to support multi-level tags import when New Expensify is connected to accounting software.
Support bulk-enabling/disabling of multi-level tags.
Issue OwnerCurrent Issue Owner: @sakluger

Checking here if there was a regression from this issue.

I confirmed that there was a regression caused by this issue's PR.
None of the automation worked on this GH issue, so here's what I've done to wrap things up:

Assigned @s77rt as the C+
Sent an offer to @s77rt via Upwork for $125, which includes the regression penalty (offer)

@sakluger Accepted! Thanks!

Completed payment 👍


Invalid characters in prefix lead to Type Error

Invalid characters in the prefix in prefixes.yml lead to type error.
prefixes.yml:
2001:DB8:C00^::/32:
  description: bad v6 prefix
  asn: 65215
  ignoreMorespecifics: false

172.16.x.0/24:
  description: badv4 prefix
  asn: 65215
  ignoreMorespecifics: false

output:
loading config: /home/agallo/downloads/BGPalerter/config.yml
RUNNING ENVIRONMENT: production
Subscribing to: 2001:DB8:C00:^:/32
Subscribing to: 172.16.x.0/24
loading config: /home/agallo/downloads/BGPalerter/config.yml
RUNNING ENVIRONMENT: production
error: TypeError: Cannot read property 'filter' of undefined
error: TypeError: Cannot read property 'filter' of undefined

packet capture shows BGPalerter is attempting to subscribe to the prefix with the bad character:
Line-based text data (1 lines)
    {"type":"ris_subscribe","data":{"moreSpecific":true,"type":"UPDATE","host":null,"socketOptions":{"includeRaw":false},"prefix":"2001:DB8:C00:^:/32"}}

and the response does show that the bad prefix is detected:
Line-based text data (1 lines)
    {"type":"ris_error","data":{"params":{"moreSpecific":true,"type":"UPDATE","host":null,"socketOptions":{"includeRaw":false},"prefix":"2001:DB8:C00:^:/32"},"message":"Unable to parse the specified 'prefix'"}}

Maybe validate prefix and report errors when launched?
Thank you.

Thank you for reporting this. This is somehow related to the issue fixed yesterday where we removed the ip library.
We anyway needed to enforce checking on the yml file better so we just pushed a fix in the source. The new binaries instead will be released asap.