applying "meshpolicies, handlers", 504 Gateway Timeout

Bug description
Lots of errors like this, basically halting the install; installed on a new cluster.
I0123 18:56:12.929849   31872 round_trippers.go:438] GET https://<IP_ADDRESS>/apis/authentication.istio.io/v1alpha1/meshpolicies/default 404 Not Found in 16 milliseconds
I0123 18:56:12.929849   31872 round_trippers.go:444] Response Headers:
I0123 18:56:12.930196   31872 round_trippers.go:447]     Audit-Id: 8bcee49c-7a9d-4259-8c9c-93ecadda0b5a
I0123 18:56:12.930196   31872 round_trippers.go:447]     Content-Type: application/json
I0123 18:56:12.930196   31872 round_trippers.go:447]     Content-Length: 256
I0123 18:56:12.930196   31872 round_trippers.go:447]     Date: Thu, 23 Jan 2020 17:56:12 GMT
I0123 18:56:12.931201   31872 request.go:947] Response Body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"meshpolicies.authentication.istio.io \"default\" not found","reason":"NotFound","details":{"name":"default","group":"authentication.istio.io","kind":"meshpolicies"},"code":404}
I0123 18:56:12.932205   31872 request.go:947] Request Body: {"apiVersion":"authentication.istio.io/v1alpha1","kind":"MeshPolicy","metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"authentication.istio.io/v1alpha1\",\"kind\":\"MeshPolicy\",\"metadata\":{\"annotations\":{},\"labels\":{\"release\":\"istio\",\"tier\":\"control-plane\"},\"name\":\"default\"},\"spec\":{\"peers\":[{\"mtls\":{\"mode\":\"PERMISSIVE\"}}]}}\n"},"labels":{"release":"istio","tier":"control-plane"},"name":"default"},"spec":{"peers":[{"mtls":{"mode":"PERMISSIVE"}}]}}
I0123 18:56:12.932205   31872 round_trippers.go:419] curl -k -v -XPOST  -H "Content-Type: application/json" -H "Accept: application/json" -H "User-Agent: kubectl.exe/v1.15.5 (windows/amd64) kubernetes/20c265f" 'https://<IP_ADDRESS>/apis/authentication.istio.io/v1alpha1/meshpolicies'
I0123 18:56:42.948598   31872 round_trippers.go:438] POST https://<IP_ADDRESS>/apis/authentication.istio.io/v1alpha1/meshpolicies 504 Gateway Timeout in 30016 milliseconds

Expected behavior
Steps to reproduce the bug
Try to apply:
apiVersion: install.istio.io/v1alpha2
kind: IstioControlPlane
spec:
  profile: sds

  tag: 1.4.3

  defaultNamespace: istio-system

  cni:
    enabled: true
    components:
      cni:
        namespace: kube-system

  autoInjection:
    enabled: true
    components:
      injector:
        enabled: true

  security:
    components:
      cert_manager:
        enabled: true
      node_agent:
        enabled: true

  telemetry:
    enabled: true

  gateways:
    enabled: true

    components:
      ingressGateway:
        enabled: true

      egressGateway:
        enabled: true

  # https://istio.io/docs/tasks/observability/logs/access-log/
  # https://issuetracker.google.com/issues/126527530
  values:
    global:
      mtls:
        enabled: false
      controlPlaneSecurityEnabled: true
      logAsJson: true
      logging:
        level: default:info
      tracer:
        zipkin:
          address: jaeger-collector.monitoring:9411

    pilot:
      policy:
        enabled: true

    prometheus:
      enabled: false

    cni:
      enabled: true
      cniBinDir: /home/kubernetes/bin

    sidecarInjectorWebhook:
      rewriteAppHTTPProbe: true
      # https://github.com/istio/istio/pull/16539/files
      objectSelector:
        autoInject: true
        enabled: false

    kiali:
      enabled: true

    pilot:
      traceSampling: 100

    gateways:
      istio-ingressgateway:
        sds:
          enabled: true

on GKE with the recommended settings, and running private nodes but with a public endpoint, after templating it out and working around https://github.com/istio/istio/issues/20082
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
1.4.3
How was Istio installed?
istioctl generate (with the above), fix #20082 and then kubectl apply -k . with kustomization.yaml referencing the template.yaml file

I would love to have more visibility into this, but I am not quite sure how that would work. The webhook service doesn't know calls to it are failing, as they are not reaching the pod. Or are you suggesting if it hasn't gotten any calls within, say 5 minutes, it should log something?

That could be one solution, or you can trigger a Noop command when I do istioctl analyze -k to ping the webhook (implicitly via the API server); if that command fails to be "admitted" you can say that connectivity is broken.

That is a good idea, it might be possible to through the proxy api (like api/v1/namespaces/istio-system/services/istio-sidecar-injector:http/proxy). I am not certain that will fail in these cases, but if it does then that would be a great indicator

This issue doesn't need triage anymore; it's been understood and it can either be fixed as per the above discussion (analyze/timeout and/or docs of the port), or the powers that be should decide that the DX of Private GKE with Istio should suck.

 I haven't had a chance to set up a private cluster to try out if the proxy idea I mentioned above will work

@howardjohn Sorry, that came out wrong. I edited the message a couple of seconds later, but by then it was too late :(

I tried to set up a private cluster and things seem to work ok, I can't get it to fail. Firewall rules show only port 15020,443 have access. Any ideas?

If not, it would be helpful if you could show me the output of kubectl get --raw https://<IP_ADDRESS>/api/v1/namespaces/istio-system/services/https:istio-galley:https-validation/proxy/ready -v9. Replace the ip with your cluster ip which can be found with kubectl cluster-info

I can give you a repro in the form of a Terraform file:
# https://www.terraform.io/docs/providers/google/r/compute_subnetwork.html
resource "google_compute_network" "vpc" {
  name                    = "fou-${var.env}-vpc"
  routing_mode            = "GLOBAL"
  auto_create_subnetworks = false
}

resource "google_compute_subnetwork" "compute_subnet" {
  name                     = "${var.region}-${var.env}-compute"
  region                   = var.region
  ip_cidr_range            = var.cidr_compute
  network                  = google_compute_network.vpc.self_link
  private_ip_google_access = true

  log_config {
    aggregation_interval = "INTERVAL_15_MIN"
    flow_sampling        = 0.01
    metadata             = "INCLUDE_ALL_METADATA"
  }
}

resource "google_compute_subnetwork" "gke_subnet" {
  name                     = "${var.region}-${var.env}-gke"
  region                   = var.region
  ip_cidr_range            = var.cidr_gke_nodes
  network                  = google_compute_network.vpc.self_link
  private_ip_google_access = true

  log_config {
    aggregation_interval = "INTERVAL_15_MIN"
    flow_sampling        = 0.01
    metadata             = "INCLUDE_ALL_METADATA"
  }

  secondary_ip_range {
    range_name    = "${var.region}-${var.env}-gke-services"
    ip_cidr_range = var.cidr_gke_services
  }

  secondary_ip_range {
    range_name    = "${var.region}-${var.env}-gke-pods"
    ip_cidr_range = var.cidr_gke_pods
  }
}

resource "google_compute_router" "vpc_router" {
  name    = "vpc-router"
  region  = var.region
  network = google_compute_network.vpc.self_link
}

resource "google_compute_router_nat" "vpc_nat" {
  name                               = "vpc-nat"
  router                             = google_compute_router.vpc_router.name
  region                             = var.region
  nat_ip_allocate_option             = "AUTO_ONLY"
  source_subnetwork_ip_ranges_to_nat = "ALL_SUBNETWORKS_ALL_IP_RANGES"

  log_config {
    enable = true
    filter = "ERRORS_ONLY"
  }
}

data "google_container_engine_versions" "north1" {
  location       = var.region
  version_prefix = "1.15."
  project        = var.project_name
}

resource "google_container_cluster" "fou_cluster" {
  depends_on = [
    null_resource.delay,
    google_compute_subnetwork.gke_subnet,
    google_service_account.kubernetes
  ]

  # https://www.terraform.io/docs/providers/google/r/container_cluster.html#logging_service
  # https://www.terraform.io/docs/providers/google/r/container_cluster.html#monitoring_service
  provider                 = google-beta
  name                     = "fou-cluster"
  location                 = var.region
  remove_default_node_pool = true
  initial_node_count       = 1
  min_master_version       = data.google_container_engine_versions.north1.latest_master_version
  logging_service          = "logging.googleapis.com/kubernetes"
  monitoring_service       = "monitoring.googleapis.com/kubernetes"

  node_config {
    service_account = google_service_account.kubernetes.email
    preemptible     = true
    metadata = {
      disable-legacy-endpoints = "true"
    }
  }

  master_auth {
    username = ""
    password = ""

    client_certificate_config {
      issue_client_certificate = false
    }
  }

  # https://www.terraform.io/docs/providers/google/r/container_cluster.html#enable_intranode_visibility
  # https://www.terraform.io/docs/providers/google/r/container_cluster.html#ip_allocation_policy

  node_locations = var.zones
  enable_intranode_visibility = true
  enable_shielded_nodes       = true
  network                     = google_compute_network.vpc.self_link
  subnetwork                  = google_compute_subnetwork.gke_subnet.name

  ip_allocation_policy {
    cluster_secondary_range_name  = "${var.region}-${var.env}-gke-pods"
    services_secondary_range_name = "${var.region}-${var.env}-gke-services"
  }

  # https://cloud.google.com/kubernetes-engine/docs/concepts/private-cluster-concept
  private_cluster_config {
    enable_private_nodes = true
    enable_private_endpoint = false # or else we completely disable the public master EP
    master_ipv4_cidr_block = var.cidr_gke_master
  }

  network_policy {
    enabled = true
  }

  cluster_autoscaling {
    enabled = false
  }

  enable_binary_authorization = true

  maintenance_policy {
    daily_maintenance_window {
      start_time = "03:00"
    }
  }

  # Waiting for internal order for G Suite group
  #authenticator_groups_config {
  #  security_group =<EMAIL_ADDRESS>  #}

  master_authorized_networks_config {
    cidr_blocks {
      cidr_block   = "<IP_ADDRESS>/0"
      display_name = "The internet"
    }
  }

  addons_config {
    istio_config {
      disabled = true
    }

    http_load_balancing {
      disabled = true
    }

    # https://www.terraform.io/docs/providers/google/r/container_cluster.html#horizontal_pod_autoscaling
    horizontal_pod_autoscaling {
      disabled = true
    }

    # See https://www.terraform.io/docs/providers/google/r/container_cluster.html#network_policy
    # the network_policy block
    network_policy_config {
      disabled = false
    }
  }

  # https://cloud.google.com/kubernetes-engine/docs/how-to/pod-security-policies
  # https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#podsecuritypolicy-v1beta1-extensions
  # https://www.terraform.io/docs/providers/google/r/container_cluster.html#pod_security_policy_config
  pod_security_policy_config {
    enabled = false
  }
}

resource "null_resource" "get_credentials" {
  provisioner "local-exec" {
    command = "gcloud container clusters get-credentials ${google_container_cluster.fou_cluster.name} --region ${var.region}"
  }
  triggers = {
    after = google_container_cluster.fou_cluster.id
  }
}

If not, it would be helpful if you could show me the output

Do you mean, when I do not have the firewall rule enabled?

Yes, I am trying to see if that command fails when the cluster is not configured correctly. Right now it succeeds (200 code), but everything is working for some reason, so I must have set it up wrong. I am hoping that command will fail, then we can have a check that runs that command during analyze (or maybe even before install)

I'll loop back around to this once I've sorted out the ingresses that I commented a lot in today... I need to get this app working with Istio ingress, or I have to revert back to nginx for the second time.

Ill try out the terraform, someone else with this same problem was using terraform so maybe its doing something slightly different then what I did with gcloud commands. Thanks

Ok I am pretty sure I got this working now, the above command fails on a private cluster where the webhook fails

to keep myself from getting confused, I think we should de-dupe this issue with https://github.com/istio/istio/issues/19532. I'll continue investigation into this. Current status is we can likely make an analyzer to check this, if there are better suggestions to expose this info let me know


Make config file paths which are relative to the user's home directory work inside st2 CLI

This should fix the issue reported in https://github.com/StackStorm/st2/issues/3186.
TODO

[ ] Tests

Codecov Report

Merging #3192 into master will not impact coverage by -0.01%.

@@            Coverage Diff             @@
##           master    #3192      +/-   ##
==========================================
- Coverage   77.44%   77.44%   -0.01%
==========================================
  Files         432      432
  Lines       22318    22318
==========================================
- Hits        17284    17282       -2
- Misses       5034     5036       +2

Impacted Files
Coverage Δ

st2client/st2client/base.py
61.93% <100%> (ø)
:white_check_mark:

st2common/st2common/bootstrap/sensorsregistrar.py
80.58% <ø> (-4.85%)
:x:

st2common/st2common/query/base.py
67.18% <ø> (-2.29%)
:x:

st2common/st2common/bootstrap/rulesregistrar.py
76.11% <ø> (-1.77%)
:x:

st2common/st2common/bootstrap/policiesregistrar.py
87.4% <ø> (-0.79%)
:x:

st2common/st2common/persistence/base.py
92.51% <ø> (-0.53%)
:x:

st2common/st2common/services/triggers.py
92.78% <ø> (-0.52%)
:x:

st2api/st2api/controllers/v1/packs.py
90.12% <ø> (ø)
:white_check_mark:

st2api/st2api/controllers/v1/triggers.py
70.94% <ø> (+0.49%)
:white_check_mark:

st2actions/st2actions/container/base.py
91.18% <ø> (+0.59%)
:white_check_mark:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4749bac...25a2484. Read the comment docs.

Nice, thanks! I'll 👍  once there's tests - just hit me up on slack

Tests added in c9fbc152932281e7f867c7b5ca2282d8f8b3b308.


is it support for mac 10.15

I just download the release AppiumForMac(beta 3)
and then open it.
it seems to be started, but nothing shows in the desktop.
PS: i am working with macOS 10.15

Any logs about it?

where is tool log?

I have been able to get this to work on 10.13 - 10.15 recently
installed node, npm
npm installed appium
Download appium-mac, allow the app in system preferences accessibility, and allow any other app calling into it.
if you're running things out of terminal for example allow terminal.  If doing something over ssh allow the ssh-keygen-wrapper, for example.

ok, I will try for it. Thanks


Single lines starting with {a=" disappear

{a=" inline text

gives no output instead of
<p>{a=” inline text</p>

Interesting, if you add a blank line after it, or something like "# head", you'll get the expected output.
So Perhaps we just need to ensure that the continue function is called again at the end of input?

We need to handle the case where the close method for a attributes container is called, not because continue fails, but because the end of the document has been reached.  If at this point the container's extra.status is "continue", we need to reparse.


Optimize/trav

Make run scripts aware of which script is last in order. This allows for optimizations. This kind of optimization is added to run_trav. Skip teleporting into position so that tp is not blocked, simply just exit instead.

Trav optimization: Prefer to not use tele charges when getting back inside to loot when using charges. Only use tele charge if pathway was blocked. This change makes the bot use less tele charges, and thereby improve run speed due to not having to repair as often. If you can tele natively the change will not affect behavior.

Yep did ~50 trav runs just now with the latest change applied works fine.
I've had these optimizations (and a few more) for a long time but haven't gotten around do make a PR


Update specs2 versions to 4.15.0 which has build for Scala 3

This change is part of Scala 3 support work.
5.0.0-RC-21 version used in Scala 3 repositories is not compatible with many features we use in Rules Scala tests.
Specs2 4.15.0 was released which has a build for Scala 3. Updating repositories for 2.12, 2.13 and 3.1 to this version. There is no release for 2.11 anymore.

There is a regression in test filtering since 4.12.2, closing.


ConnectedReactRouter forcing the whole app to instantly re-render on every store change.

What We Know So Far

Looks like<EMAIL_ADDRESS>is forcing the app to re-render on every store change
There are some improvements in version 6.1.0 but there is an issue with version 6.2.1 still complaining about re-renders https://github.com/supasate/connected-react-router/issues/242

Connected Issues

The problem is that in version 6.1.0 and highter action creators push etc. are not working.
Either pushing and object is not working with 6.1.0. and higher

What To Do?

Would be nice to try skeleton without connected-react-router to see the behavior with normal react-router

Minimal app with some easy form would show us if there is any improvement with and without connected-react-router
*I expect that without connected-react-router just the form fields would be re-rendered while with it  the whole app would be re-rendering.

Maybe we should consider not using connected-react-router ?

Looks like the problem can be solved by reinstalling react-router-dom. I have tried to use @4.4.0-beta.7 and all the problems are solved. Combination with<EMAIL_ADDRESS>works for me just fine.

PS @4.4.0-beta.7 looks stable enough to be used.

The stable @4.4.0 version has been just released 🎉


UnsupportedOperationException is abused

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I note UnsupportedOperationException is abused. In some place, it is used to make gluten validation fail and let the program go into fallback path. But in some other place, this exception is really unexpected. And we should just let the program interrupt and leave it to developers to handle.
Maybe, it is better to introduce an independent exception, e.g, GlutenNotSupportException for fallback case.

Hi @baibaichen, as noting your code changes for gluten exceptions, I am thinking this separate issue related to exception handling. If you have some comments, please feel free to let me know.

Fixed by https://github.com/apache/incubator-gluten/pull/4996.


Derive node twin ids automatically

Since a node has one and only one twin, and this information is readily available, why not fetch this information automatically rather than requiring the farmer to enter it in the config file? The node twin field is also a source of confusion and mistakes. Farmers sometimes enter their own twin or a wrong id.

This will be done in #53


git:  ignore cabalWrapped-created .nix-shell-cabal.project

git: ignore cabalWrapped-created .nix-shell-cabal.project
This file is created in the cabal-inside-nix-shell mode, as an alternative to the cabal.project in-place mutation.

bors r+

bors r+


Build: needs flag to specify build only dependencies

Many times you will change deps in your project, and want to then interactively fix your codebase.

@justinwoo could you detail an example?

$ psc-package build --help
Usage: psc-package build [-d|--only-dependencies] [`purs compile`-options]
                         [--jobs ARG]
  Install dependencies and compile the current package

Available options:
  -d,--only-dependencies   Compile only the package's dependencies

if you remove deps you don't want in your project, your project doesn't build anymore. however, you still want to actually develop interactively at the leaf modules of your codebase.

I'm not sure I understand how this can happen. Assuming you have dependencies a, b, c and your project builds using all of them:

if you remove a then your project stops building. It doesn't make sense to rebuild only dependencies because the dependencies have already been built once
if you add d then your project should rebuild just fine even if you include project code

This is also a problem when you upgrade packages, which is the equivalent of removing a package to add another.

Another crucial detail is that it's not like all non-project sources will be built guaranteed, especially if module headers are parsed first and the compiler determines that there are no valid build plans (for good reason)

Really, the only actual workaround for this missing feature is to rm -rf src test && spago build && git checkout .

We had a IRL chat with @justinwoo and it turns out the reason why you want to compile deps-only is for cases in which you:

switch branches and there's a significant diff of deps
update dependencies that introduce breakage

..and still want your purs ide to give you meaningful suggestions.
So you'd do spago build --deps-only and then start purs ide


Remove multisigwallet as it is too complex to use

What this PR resolves:
Changes proposed in this PR:

Version:
Fixes: #

@ahussein  you are absolutely right but there should indeed be an alternative implementation, the current one is too  complex. Currently the explorers allow to see the multisig transactions if you query it sing a single address as well. The cuurent implementation requires to know the multisig addresses and the required number of signatures before you can use it, no way to know your address has been used in a multisigoutpu. The onlt reason the multisigwallet exists is to create an unsigned transaction right now.


Allow data-manager role to create requests in reqmgr2; check group me…

First issue found by Antanas, their DN was not able to make a POST call to reqmgr2/data/request (create a new request), I had to temporarily give him admin privileges:
https://cmsweb.cern.ch/sitedb/prod/people/pdmvserv%40vocms081.cern.ch
This PR changes basically two things:
a) we always check the group membership of the DN
b) we allow mainly "data-manager" and "production-operator" to also make requests.
@ticoann please review. I still need to test it in my VM.

BTW, there is also this file:
https://github.com/dmwm/WMCore/blob/6f3570a741779d209f0f720647642d51b64845da/src/python/WMCore/WMStats/Auth.py
with the same code. Git grep does not find any one using it. Shall I remove that code?

Thanks Alan, this give all the permission for every group, Is McM allowed to only creating and approving requests? Anyway, I will make this configurable so we can control this run time.  But lets push this for the testing. Do you want me to make new tag and make the pull request for testbed.

Thanks! I suggest we cut a new tag later this evening FNAL timezone :-)
I'll try to improve the authz in the coming weeks.


Vue.js Wrapper for the same

Hi, I was very enthusiastic to make a vue.js wrapper component for the same so I did. I also played with some CSS and had some tweaks to get it working as it should in Vue.js Component-based architecture.
https://github.com/silent-lad/Vue2BaremetricsCalendar
Hope you guys like it. Thanks.

Hey, this looks cool. I was just wondering if you had to do any special work to deconstruct the calendar if the element is removed from the page? I couldn't see anything in your Vue code.


Translation

Hi, I have made a new file for transalation : fr.yml
But It doesn't Work.
I put in : /extensions/vendor/bolt/googleanalytics/translations/
I check the outpout {{locale}}. It's "fr"
In config.yml, it's : "locale: fr_FR"
fr.yml.txt

Sorry ... It's OK now
This is the file for integration, if you want
fr.yml.txt


Unable to create jQuery modal dialog

Hi,
I'm trying to create a modal dialog to display when the admin page is ready using this code in the change_list.txt template :

..but when I load the page I'm getting "Uncaught TypeError: undefined is not a function".
Dialog is defined in change_list.txt (which is overriden) inside block content like this :

This is dialog.

What should I do to set this dialog to show?

I'm closing this as I can not help without more information.


Add commands to outline elements

The outline view should offer commands that can be run straight from an element. E.g. rename but also triggering things like find references et al. Similar to the editor-context-menu this could be made open for contributions

from https://github.com/MartinHaeusler

There are also refactoring features built into this UI in Eclipse:
Dragging a member and dropping it to another position also refactors the code by moving the code block belonging to that member to the position indicated by the drop target.
Deleting a tree node also deletes the corresponding sections of code in the file.
Any node has a context menu that allows for different operations, e.g. rename
The context menu also offers things like "find references" or "open call hierarchy"

As requested, this comment comes from issues/53451
Right now, the only features we have are a filter and a sort for finding/sorting elements in the code.
What if we can add more feature in this view? I don't know if it was designed for that, but it can help a lot for refactoring the code.
Here's a GIF demonstrating the current features :

What we can add :

Contextual Menu
Rename
Delete
Drag/Drop

For the Rename refactoring :
When the user right-click on the mouse, a contextual menu should appear and a "Rename" choice should be there. When the user, click on rename, it should rename the entity (constructor, property, method, etc) in the code and update all references. The user could also user the the keyboard shortcut like F2 for renaming, like we do in the application too.
For the Delete refactoring :
When the user right-click on the mouse, a contextual menu should appear and a "Delete" choice should be there. When the user, click on delete, it should delete the entity (constructor, property, method, etc) in the code and update all references. The user could also user the the keyboard shortcut like del for deleting, like we do in the application too.
For the Drag/Drop refactoring :
The user should be able to move the entity and it should update in the code too, not only in the outline view. The cursor should be changed by the "move" cursor.
Nice to have if it's possible :
When displaying the entities (constructors, properties, methods, etc). It would be very nice to have something visual to distinguish public vs protected vs private. Right now, all entities are displayed. When you have a huge class, sometimes you want to spot the private methods region. If you have something visual in this view, it would help a lot finding what you are looking for. Like changing the icon or the font. If a entity is private, the font could be darker than the public ones.
If it's possible, we can also add a sorting in the sorting choices. We can add something like "Sort by: Member access" below the "Sort by: Type"
If anyone has any refactoring ideas that I didn't mention, please feel free to add a comment. 😊😊

@yanckst I believe the public vs protected vs private part is tracked at #23927.

@kAlvaro I didn't saw the feature request when I added my comment, but I think my comment is still relevant

it is an old feature request and nothing happens. Are there any workarounds or plugins to work on the outline level?
Especially I miss a way to easy move and indent sections, when editing markdown files. A separate extension also would be fine, but I can't find any.
I can imagine that it is not so easy to implement something working in all languages, but maybe it would be possible to extend the outline view only for specific languages if it is to hard to implement a general solution?

Just adding my interest for a menu contribution point in the outline view (i.e., outline/item/context), similar to all other menu contribution points. My extension is currently resorting to inline codeActions but this is not elegant/efficient as user will have to scroll from one DocumentSymbol to another in the editor.

Adding a +1 for this feature request. I would appreciate the contextual UI to rename my note headers with right click on outline, then to run a command for the same operation.

+1 especially the drag&drop feature would be very helpful for me.


There are some questions about SYSTEM MODELS

Dear Author:
In your paper, the session 4 in the unit II ——System action, you describe 4 actions are  the reactive computation action, proactive computation action, pushing action, and cache update action respectively. You write the 2rd title is  Proactive Transmission or Pushing Action. I couldn't understand proactive computation action and proactive transmission action. Are they the same thing, or are they related in any way?
Besides,  in the system action space, why do four actions correspond to only three?  Three is cR, b, ∆s.
Could you give  me an answer? Thank you!

Dear Author: In your paper, the session 4 in the unit II ——System action, you describe 4 actions are the reactive computation action, proactive computation action, pushing action, and cache update action respectively. You write the 2rd title is Proactive Transmission or Pushing Action. I couldn't understand proactive computation action and proactive transmission action. Are they the same thing, or are they related in any way? Besides, in the system action space, why do four actions correspond to only three? Three is cR, b, ∆s. Could you give me an answer? Thank you!

I'm reading this paper, too. Could I share my understanding of this article with you?


Ability to merge changes from a copy of a question into the original

At the very least, something like "override my original question with this copy" would be helpful in some cases.
Ideally, a git-style version history and branching/merging system to allow collaboration on a question.

Done!


BulkRequest Handling on Failure

Which version of Elastic are you using?
[x] elastic.v5 (for Elasticsearch 5.x)
v5.0.30
Please describe the actual behavior
When some bulk request fail:
ERRO[0551] Elastic Flushing Failed                       err=elastic: Error 400 (Bad Request): Validation Failed: 1: index is missing;2: index is missing;3: index is missing;4: index is missing;5: index is missing;6: index is missing;7: index is missing;8: index is missing;9: index is missing;10: index is missing;11: index is missing;12: index is missing;13: index is missing;14: index is missing;

The retry is happening forever. In this case, since the record is having an incorrect index and type, this never succeeds (of course, this shall(should) not happen in the production env)
Please describe the expected behavior

Could we have a max limit for the retries configurable for bulk updates
Another question is - there were 30 records in this request. Only 14 of them have failed. When the retry happens all the 30 are being retried. Could the 14 be identified and only those be retried.
Another interesting behaviour is, I'm using the following code:

	afterCallback := func(id int64, requests []elastic.BulkableRequest, response *elastic.BulkResponse, err error) {
		if err != nil {
			log.WithFields(log.Fields{"id": id, "err": err.Error()}).Error("Elastic Flushing Failed")
			for k := range requests {
				src, rerr := requests[k].Source()
				if rerr == nil {
					for i := range src {
						fmt.Printf("Request[%d] Source[%d]: %s\n", k, i, src[i])
					}
				} else {
					fmt.Printf("Bulkable Request[%d] Not Returned: %s", k, rerr.Error())
				}
			}

			if response != nil {
				failed := response.Failed()
				for i := range failed {
					if failed[i].Error != nil {
						fmt.Printf("Failed[%d]: %+v", i, failed[i].Error)
					}
				}
			}
		}
	}

and I'm not seeing any Failed prints. So how to find which of these 14 were the real failures.
Any steps to reproduce the behavior?
One of my teammate had an issue during his development. So for testing purpose, I gave an incorrect type for certain records and incorrect index for some of them and added them to the bulk.

Okay, I see. This looks a bit like we need to be able to use configurable backoff/retries for Bulk API as well (just like Scroll API).
With regards to your questions:

Max limit of retries: You could do that once we have configurable backoff/retries for the Bulk API. Maybe it's worth adding a configurable backoff/retry for every API, and use the client's settings as the default.

Retrying: I really don't want Elastic to be "clever" and pick up the things that "should" happen. I try to simply make Elastic a transparent layer for working with Elasticsearch. I think it's better to let the application pick the correct logic on what should happen in case of an error.

Could you try to log the response and set up a unit test in a separate issue? With that we can check if there's something wrong. Either Elasticsearch changed its response structure or your code is missing something. There already is a test for the "failed" case, so I'm not sure what's wrong here...


dlib-android ndk build on Windows

I am a dlib fan. :)
I've used android-ndk-r11.
And I've tried on Windows.
But it says there is no logging.cc
Can you please explain how to build on Windows step by step?
Thanks.


Updatge pr-ci-triggers message

Only maintainers can trigger vendor CI, mention
that in in PR message.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 40.938%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
5604

Relevant Lines:
13689

💛  - Coveralls


interactiveSearch.html.

Does not exist

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3d455c9-d5c7-3a9e-5de5-b16072f3c77e
Version Independent ID: d0f120b2-5ef9-9112-d17f-e8b2275ed5b4
Content: Interactive Map Search with Azure Maps
Content Source: articles/azure-maps/quick-demo-map-app.md
Service: azure-maps
GitHub Login: @kgremban
Microsoft Alias: kgremban

@HowardEdidin Thank you for reporting this! We have assigned this issue to the author to investigate further and take the right course of action.

Hi @HowardEdidin this broken link has been fixed and is working in the live version of the article. I'm sorry for any inconvenience.

@mike-urnun-msft can you #please-close this issue as resolved?


Release Manager Blog Post

Describe the blog post you would like to write
This blog post will be about being release manager for the first time in OpenSearch and the mistakes I made and the things I learned.
Link to the blog post
What is the title of the blog post?
Day in the Life of a Release Manager
Who are the authors?
@eugenesk24
@stockholmux
What is the proposed posting date?
As soon as possible.

Hey @eugenesk24 - the quip link you posted isn't accessible to the general public and doesn't belong on github.

My bad! I removed it 👍

@krisfreedain FYI - just so this doesn't get list. @eugenesk24 shared this privately - please work together to get a PR made.

@eugenesk24 - let me know when you have time so we can work on this one. thanks


[1.0.0] Light DOM being replaced by shady DOM on ready

I am currently porting an app from 0.5 to 1.0 and it appears that the nested custom components appear to be getting replaced by the shady DOM of the parent element.
Before the Shady DOM fully loads:

After the Shady DOM has loaded:

I am not currently doing an DOM manipulation that would cause this. The web component logic appears to run without an issue, only the Light DOM elements seem to have been removed/replaced. I can't seem to see any logical reason for this  to be happening other than an issue.
Update: I put breakpoints on the elements 'when element is removed' this is the part of the polymer code that appears to be causing it:
 if (!this.shadyRoot._hasDistributed) {
 this.textContent = "";
 this.appendChild(this.shadyRoot);
 }

This is located on lines 1053 - 1056 of the Polymer library.

I didn't realise you needed to use the  element to act as an insertation point for light DOM within your element (as per: https://www.polymer-project.org/1.0/docs/devguide/local-dom.html#dom-distribution). This was not mentioned in the transition guide! I would recommend adding this to: https://www.polymer-project.org/1.0/docs/devguide/local-dom.html#dom-distribution


fix #331: sync node map

Fix CRASH with concurrent svg parsing

Thank you for a good catch! I think it's better to avoid holding of all nodes in the global store at all. So hope you can use your fix locally before we'll redesign this part of the codebase.

OK. I'll use serial queue for now


[SMALLFIX] Supply the name of variable to Preconditions.checkNotNull

Supply the name of variable to Preconditions.checkNotNull in /alluxio/job/server/src/main/java/alluxio/master/job/JobCoordinator.java line111

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2752/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2753/
Test FAILed.


[Groups Infra] Fetch data source views in agent configuration

Done in https://github.com/dust-tt/dust/pull/6708 and https://github.com/dust-tt/dust/pull/6726.


Fixed decompile to start using Mustermann

Ref:  https://github.com/sinatra/sinatra/pull/1086

Lol, I had older version

@vipulnsward no problem! Thank you for your help <3


Viewport crash

PURPOSE
Improve stability
EFFECT OF CHANGE
Resolve crash when mismatch sizes of the viewport and render data
TECHNICAL STEPS
Do not update RHI texture while RPR data not ready yet

This is moved changes  that made @awnzl  in another repo.

Ready to merge?

yes, it ready

Nope, I found an issue and will make another one commit

In case of context changing, framebuffer initialization was without calling resizing function (with params) and this breaks a validation logic. So, I just added initialization to the constructor.

Approve from my side


Admin Inline Form Field Customization (Select Widget's Option customization)

Hi,
This is not a bug but a help request.
I want to customize one field adding a data-attribute to every select's option to add js interaction with a other fields
So i have changed the template of my AdminInline.
In this template i changed the part:
{% with form=inline_admin_form.form %}{% render field.field %}{% endrender %}{% endwith %}
in
{% with form=inline_admin_form.form %}
{% if field.field.name == "my-custom-field" %}
{% render field.field %}{% part field.field %}
{% part field suffix %}DEBUG{% endpart %}
{% part field options %}`{{see_after}}`{% endpart %}
{% endpart %}{% endrender %}
{% else %}
{% render field.field %}{% endrender %}
{% endif %}
{% endwith %}

I can see DEBUG as prefix but...
{{see_after}} could be similar to the part options i can see in template django_select.html but i can access only to choice, value, selected values form material's templatefilter select_options
This is the part options of django_select.html
{% part field options %}{% for group, items in bound_field|select_options %}
            {% if group %}<optgroup label="{{ group }}">{% endif %}{% for choice, value, selected in items %}
            <option {% if value == None or value == '' %}value{% else %}value="{{ value|unlocalize }}"{% endif %}{% if selected %} selected="selected"{% endif %}>{% if value == None or value == '' %}{{ form_select_empty_label|default:choice }}{% else %}{{ choice }}{% endif %}</option>{% endfor %}
            {% if group %}</optgroup>{% endif %}{% endfor %}{% endpart %}

My question is: what is the best manner to accomplish my request?
Do you think is the best way to change the templatefilter to have additional data in my option's tag?
Consider that the data-attr is known only in the backend
Thanks in advance

Yeah, part context, and select/optinos attribute is tough in the current implementation. That's need improvements.
First of all {% if field.field.name == "my-custom-field" %} should be dropped. Just use {% part form.my_custom_field  ... %}
And you can use form.my_custom_field directly in the part declaration


Fix "no module named 'abba_private'"

Fix https://github.com/BIOP/abba_python/issues/14#issuecomment-2031940552
Still not sure why it didn't work before but at least we'll have a working version for now.

I'm not sure about the proper fix for that. Did you install the abba-python package or do you work from an IDE ?
Any module / packaging person with a python knowledge is welcomed to help!

I installed abba-python with pip install abba-python.
Before the last update (a little while ago), I could launch the GUI with a Brainglobe atlas.
I tried again today to launch the GUI from a notebook with a Brainglobe atlas and got the error. I tried again from a regular python console and I got the same error. So I went into the abba.py file at the designated line, and noticed that here :
https://github.com/BIOP/abba_python/blob/be17a502f4174efcf4622c1418d3d2dacd1aac8b/src/abba_python/abba.py#L101
you import abba_private differently, so I tried to replace the import at the faulty line https://github.com/BIOP/abba_python/blob/be17a502f4174efcf4622c1418d3d2dacd1aac8b/src/abba_python/abba.py#L181 and it worked.
But wth indeed :sweat_smile:

Don't you think it was the correct fix ? Sorry I did not have time to check it yet

Oops. I didn't know PRs were directly linked to the fork. I deleted the latter to re-fork it and start what I did from scratch... I'll try to redo the PR and find a way to work on another version (I guess this is the purpose of branches, I need to find out about that) 😓


[WebToolsE2E] [Unstable] When running aspire application, we sometimes see KubeConfigException : kubeconfig file not found when the host is trying to start up

REPRO STEPS

Clean machine: Win11 x64 23h2 ENU
Install VS 17.10 Preview 1 (includes Aspire 8.0 P3)
Open VS > New Aspire Starter Application > AspireStarterApp2 > Build and Ctrl+F5 > works fine
Update to VS 17.10 Preview 2 (includes Aspire 8.0 P4 version 8.0.0-preview.4.24128.4) + Apply feeds
Open VS > open AspireStarterApp2, build and Ctrl+F5 again

ACTUAL
Hosting failed to start - kubeconfig file not found

Workaround: Close the VS debug console window, build and ctrl+F5 again, and it works fine
EXPECTED
No error in VS debug console when we do Ctrl+F5

@karolz-ms @davidfowl , I've run into this issue a couple of times this week. So I went ahead and filed an issue but the repro is unstable and hard to reproduce consistently. I set the milestone as preview 4 in case the cause is something obvious, but we can move it out to P5 if needed. The workaround is simply to run it again.

I'll be in preview5 for sure.

This should be fixed (in Aspire P5) by https://github.com/dotnet/aspire/pull/2435  Please re-open if you still see this issue.

@karolz-ms is it?

@davidfowl I have good reasons to believe it did because I have finally realized what is causing this pattern:

older version of DCP --> works
install new version --> first run cannot reach DCP (timeout in ExecuteWithRetry which is part of Aspire.Hosting DCP client)
subsequent runs --> work

The answer is: this is caused by "advanced threat protection" antivirus software. On my dev machine it can take close to 10 seconds for the AV to scan new version of DCP binaries.
The old code in DCP hosting client had a timeout of 5 seconds. The PR bumps it up to 20 seconds. Only first ever ("arctic") run is affected.


Remove TextOptions

[X] I agree to follow the project's code of conduct.
[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Closes #222

Looks nice, let's move CplStringList somewhere else (not sure where, maybe into a new cpl module) to fix the warning, squash the commits and it's good to go.

Ping @stanciuadrian?


Tip Calculator Extension

🛠 Fixes Issue
#261
👨💻 Changes proposed

🔧 Check List (Check the type of issue it fixes)

[ ] Bug Fix
[x] New Extension
[ ] Enhancement
[ ] Documentation

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
📷 Screenshots

@whiteHatpro please add labels here.

Good work @Sulagna-Dutta-Roy ✨
Added the labels
Thanks for contributing 💛


⚠ 366.ru has degraded performance

In ef09780, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 1097 ms

Resolved: 366.ru performance has improved in 9a9aded.


and evaluates both operands

This program will stick in the loop:
        (= (loop) (loop))
        !(and False (loop))

Evaluating the second argument will harm the performance even if the second argument doesn't contain infinite loop
instead we can rewrite and via if
(: and2 (-> Atom Atom Bool))
(= (and2 $X $Y)
     (if $X $Y False))

!(and2 False (loop))

this and will return False

Rust MeTTa and Minimal MeTTa have different implementations for add. The first one implements and as a grounded operation. The problem with grounded operations is that they require interpreting their arguments before running the operation itself unless the operation arguments are of Atom type. However, in the latter case, it is not possible right now to declare that the argument type is Bool also. The same problem arises for and2 implementation. Minimal MeTTa implementation for and is in MeTTa itself, so it could be replaced in principle, but the type signature looks not too nice.
As a side remark, there is a question in semantics. In constructive mathematics, something can be provable, refutable, and undecidable. If the process never stops, its result is neither true or false. The question is how we define and in this case. and can be false if one of the arguments is provably false, or it can be true if both arguments are provably true. But this would be better to define in terms of dependent types.
In any case, what I don't like in such and2 is that it is not symmetric. That is, (and2 (loop) False) will not terminate. I know that many traditional programming languages have this special semantics for and. But I'd say that and is not that special, and the problem boils down to the order of computations, which we'd like to control. It might be perfectly ok for and to evaluate both operands, and if someone wants to avoid this, it should be done explicitly. We are lacking this feature atm, but there can also be different ways to introduce it. Maybe, some form of lazy computations could provide one approach. But maybe, we need to address this via parallel and sequential composition operations. With such operations, we could describe two different ands. In a sequential and, we would explicitly indicate that the first argument is calculated before the second. Parallel and could calculate both arguments simultaneously and terminate, when one of them returns False or both of them return True.
This can be considered as a possible future extension of Minimal MeTTa or as a feature of rholang space.

I agree that a function that gets stuck in a loop does not return a boolean, but that is not the point. What we usually have is some long-running function that will return a boolean but will run too long. Also i agree that might be better solutions like adding concurrent execution or iterative deepening execution strategy like in ciao prolog https://ciao-lang.org/legacy/files/ciao/ciao-1.5p133/ciao_html/ciao_97.html, it will provide symmetry, at least if we don't pass there some grounded function. Or maybe gounded functions should be called in a separate thread, while metta interpreter will continue it's execution in the main thread?
Anyway sequential and is a sensible default, much better than the current implementation. Current implementation is symmetrical but why it is an advantage?


Added a few Python 3 compatibility changes

Nice! Want to make the following change in .travis.yml? Swap:
python:
  - "2.7"

with
python:
  - "2.7"
  - "3.4"

That should force this to rerun on travis with the Python 3.4 tests.

Nice, both versions are passing! Great job @andrewosh , merging in.


Question about git push mirror

Does this library support git push --mirror operation?

No, this repo is a Go package for accessing the GitHub REST Developer API v3:
https://developer.github.com/v3/
The closest approximation to this would be creating a fork:
https://developer.github.com/v3/repos/forks/#create-a-fork

Oh I got it, go-github is just a library implementing GitHub API.

Yes, exactly.


DOC: <Issue related to /old/tracing/faq/querying_traces>

In the UI I have a filter so that a run's input "does not match" a given string. But I'm having a difficult time figuring out how to replicate that via the sdk/rest api filter syntax.
Any updates to the docs to indicate how to do "matches" and "does not match" for a run's input with maybe even an example provided would be greatly appreciated
Thanks!

realized I could determine it from the UI url. Figured out it was: notlike(inputs, "input string to not match")
seems like the "inputs" field and the "like" and "notlike" comparison operators should definitely be added to the docs


Some feature ideas

detection of updates in the workshop while the server is running + automatic restart e.g. 10 min after detection
tbh I use your manager mainly because of super easy management of mods, watchdog server and hooks. It would be ideal if there was an option to disable the webserver, api at all e.g. via config. It would save a few server FPS
multithreaded/async hooks, currently before each server start I backup the most important files and send them to a network drive (using beforeStart hook), it would be ideal if I could separate these actions and the sending files in the e.g. afterServerBoot hook, right, so as not to delay it

Im actually using this hooks feature to clean the logs that start to become a problem qhen you add a mod that write to many script errors.
I have already tried to go on the way to perform backup every time that the Server restarts. But the truth is that it is not practical.
Ideally, the times of the backup routine and those of server restart should not be linked.
The backup must perform atmens daily (once per day) or what the administator considers necessary. But in cases where the server restarts several times a day for a reason outside the normal routine, it ends up having a backup for each restart and is not useful in terms of information protection or even to reverse the changes.
Ideally, the backup is handled through the scheduller of the operating system with a specific script for that task. In my case I do it with the Aomei Backuper tool, but it is not necessary to have a third -party tool.

For the detection of updates in the workshop while the server is running + automatic restart e.g. 10 min after detection.

Also try to solve it that way. The problem in this case is as follows:
It has happened to me that the developer of some mod was implementing a new version and in this process performs more than one update in a question of hours or minutes. I do this myself, but for such a case I have an exclusive test server.
If a mod that you has aggregate begins to have this behavior, control the restart of the server. In addition, this could be used as a denial of service attack.
The ideal in this case is that at most notify the changes, but not to send a forced restart.

I suggest adding the functionality to perform a backup one, or more than a specific folder and compress this result by handling independent times of the programmed server restart. That would be very useful for those who do not have the ability to generate their own scripts.
I also like the idea of adding the option to completely deactivate the web interface. It is true that for those who do not use it, I will save fps.
On the other hand, I would love that web interface can be added more advanced functionalities, for example similar to the functionalities that Cftools has. Something basic no so complex, but it would be ideal like Battlemetrics.

Anyway, even so, it is still in my opinion the best manager server I have tried.

Thanks for the suggestions.
You really dont have to worry about the server FPS impact. The webserver really just idles if you dont use it.
You can also check your taskmanager for more details but the server manager is really resource-friendly.
The one thing that could actually impact the server fps is the ingame report (not by much, but it could).
If you are really concerned about it, there is an option to disable it in the config.
If disabled, it wont even load the server manager mods on your server.

What exactly is "IngameReport"?
What about mod update detection? It would be very useful feature imo

The ingame report is a small mod that send data about the ingame players and vehicles (name, location, health) to the server manager, so you can see it in the web interface
The mod detection is a bit harder to do, as @radixtenshi mentioned.
If a modder updates frequently, it might break your server.
It should be off by default, but I might implement that feature in the future

The ingame report is a small mod that send data about the ingame players and vehicles (name, location, health) to the server manager, so you can see it in the web interface
Thanks for the explanation :D

The mod detection is a bit harder to do, as @radixtenshi mentioned. If a modder updates frequently, it might break your server.
It should be off by default, but I might implement that feature in the future

The truth is that we should only use verified and reliable stable mods. Of course, something like this can happen, but it is hard to talk about DDOs here.... We will see that such a thing happens to the server, so we can easily take appropriate action. Such functionality has been in Omega Manager for a long time.
@radixtenshi
I would disagree that a reboot backup is not practical. In fact, this is the last moment in which we can make a backup, before an update of some mod can destroy our storage state. Currently, in "beforeStart" I have a script that makes a backup and sends it to an external drive. In addition, I do the same thing in half the time between reboots. With reboots every 6h - I have a backup every 3h.... Of course, at the back I have retention of these backups, but it is not important, these files are not that big.

I think you must first understand how a Backuip scheme works.
You can take all the backups you want, but the important thing is to have a backup that really serves (that is, it is effectively recoverable) and at the same time occupy the minimum of space.
The main objective of a backup is to be able to recover the state of the server in a database failure.
On the other hand, the game has its own backup system that stores the database periodically. This is programmed by the developers themselves and the server stores when developers consider that it is necessary. And if you look, with the backup scheme every 3 hours, the only thing you are doing is to repeat this information 8 times per day since if you observe the folder \ storage_1 \ backup \ (where is the database backed) probably not It has changed a lot.
From what I have seen this automatic system stores modifications of the database throughout the day and even several previous days.
It happened to me to have daily backups and yet just use the files of the carpetya \ storage_1 \ backup \ to recover the base in a case of disaster. You can do the test yourself, to reestablish a backup today, one of 2 days ago and one of 4 days ago and see the changes. I did that test on a test server.
It could be said that the Server already has an included backup system that contemplates the modifications of the database (which is what mods mainly modify or damage).
Considering all this, what would miss supporting? The configurations made by an administrator.
When would it be ideal to support them? Every time the administrator makes a configuration change. Therefore, this part no need to be automatic, with which it is done manually (with a previous Snapshot) that the admistrator plans relevant changes, would be sufficient.
And in conclusion, the Server Manager is not a backup tool, so I would not pretend to manage this aspect when there are tools developed exclusively for this task and of course offer adequate solution.
If your hosting is with an omegamanager interface (which is so obsolete) or a nitrado interface, in that case the ideal is that the backup is handled by hosting itself. If what you have is a VM (Virtual Machine) The ideal is to handle it via Snapshot, it is more efficient and safer.
Of course you can make a script that makes a copy of the files you want, but it's just a copy. It is not technically a backup and also although it serves, it would be the most precarious method.


How can I generate checksum files when building a plugin?

How can I generate checksum files when building a plugin?🧐

Please clarify your question.

Hello, I would like to generate a SHA-256 file hash. Additionally, I intend to have the SHA-256 file hash generated concurrently during the plugin build process.
Currently, I am utilizing the following command to generate the SHA-256 hash:
shasum --algorithm Go.ORM.Helper-1.2.2-signed.zip

https://github.com/maiqingqiang/go-orm-helper/releases/download/v1.2.2/Go.ORM.Helper-1.2.2-signed.zip.sha256

Basically, you should create a custom Exec task and define it as a next step after building the plugin.
See Gradle docs: https://docs.gradle.org/current/dsl/org.gradle.api.tasks.Exec.html


config.inc.php options

You suggest in the readme that config.inc.php can be edited to add options. What are those options?

Oh, it's copied and pasted from my another plugin. There is no options for this plugin.

ok thanks.


resource_subject missing

Hi!
Many thanks for your work and publishing it, one thing I notice is missing and should be easy to add is resource subject, currently role binding is limited to the resource type topic, subject is close but is base on schema registry example:
confluent iam rolebinding create
--principal User:sam
--resource Subject:transactions
--prefix
--role ResourceOwner
--kafka-cluster-id my-kafka-cluster-ID
--schema-registry-cluster-id schema-registry-cool-cluster
The schema is needed when for example using Avro messages.

Thanks for your contribution, and so sorry for my late reply. At the moment, i'm working on it to add full resource types like Subject and Schema, will public asap @eneasz.


Libabc: add new libabc package

Motivation for this change
Adds new package to provide the libabc library for other applications to link against.
Replaces pull request https://github.com/NixOS/nixpkgs/pull/27198
Depends on pull request https://github.com/NixOS/nixpkgs/pull/30565
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
N/A
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
N/A
[ ] Tested execution of all binary files (usually in ./result/bin/)
N/A
[x] Fits CONTRIBUTING.md.

cc @thoughtpolice for review

@vyp: extraneous line removed.

what do you think about the following approach?
From 847e8076b56db66dd61354e8e4c1bd44cd24624a Mon Sep 17 00:00:00 2001
From: Joerg Thalheim<EMAIL_ADDRESS>Date: Thu, 19 Oct 2017 12:05:42 +0100
Subject: [PATCH] abc: build verifier and library in one package

Signed-off-by: Joerg Thalheim<EMAIL_ADDRESS>---
 pkgs/applications/science/logic/abc/default.nix    | 23 +++++++------
 pkgs/applications/science/logic/abc/libabc.nix     | 40 ----------------------
 .../science/logic/abc/shared-library.patch         | 11 ++++++
 pkgs/top-level/all-packages.nix                    |  3 +-
 4 files changed, 25 insertions(+), 52 deletions(-)
 delete mode 100644 pkgs/applications/science/logic/abc/libabc.nix
 create mode 100644 pkgs/applications/science/logic/abc/shared-library.patch

diff --git a/pkgs/applications/science/logic/abc/default.nix b/pkgs/applications/science/logic/abc/default.nix
index bab9b302d7d..b95d6963652 100644
--- a/pkgs/applications/science/logic/abc/default.nix
+++ b/pkgs/applications/science/logic/abc/default.nix
@@ -1,7 +1,7 @@
-{ fetchhg, stdenv, readline }:
+{ fetchhg, stdenv, cmake, readline }:

 stdenv.mkDerivation rec {
-  name = "abc-verifier-${version}";
+  name = "abc-${version}";
   version = "20160818";

   src = fetchhg {
@@ -10,21 +10,24 @@ stdenv.mkDerivation rec {
     sha256 = "09yvhj53af91nc54gmy7cbp7yljfcyj68a87494r5xvdfnsj11gy";
   };

-  buildInputs = [ readline ];
-  preBuild = ''
-    export buildFlags="CC=$CC CXX=$CXX LD=$CXX"
+  buildInputs = [ cmake readline ];
+
+  patches = [ ./shared-library.patch ];
+
+  postBuild = ''
+    make libabc
   '';
-  enableParallelBuilding = true;
+
   installPhase = ''
-    mkdir -p $out/bin
-    mv abc $out/bin
+    install -D abc $out/bin/abc
+    install -D libabc.so $out/lib/libabc.so
   '';

   meta = {
-    description = "A tool for squential logic synthesis and formal verification";
+    description = "A library for sequential logic synthesis and formal verification";
     homepage    = "https://people.eecs.berkeley.edu/~alanmi/abc/abc.htm";
     license     = stdenv.lib.licenses.mit;
     platforms   = stdenv.lib.platforms.unix;
-    maintainers = [ stdenv.lib.maintainers.thoughtpolice ];
+    maintainers = [ stdenv.lib.maintainers.kquick ];
   };
 }
diff --git a/pkgs/applications/science/logic/abc/libabc.nix b/pkgs/applications/science/logic/abc/libabc.nix
deleted file mode 100644
index 9b2efd1b5ab..00000000000
--- a/pkgs/applications/science/logic/abc/libabc.nix
+++ /dev/null
@@ -1,40 +0,0 @@
-{ fetchhg, stdenv, pkgs }:
-
-stdenv.mkDerivation rec {
-
-  # Note that this derivation provides only the library, but under the
-  # "abc" name, to associate with libabc, which conforms to the
-  # standard library dependency referencing nomenclature.  The binary
-  # is available as a separate package with the "abc-verifier" naming.
-
-  name = "abc-${version}";
-  version = "20160818";
-
-  src = fetchhg {
-    url    = "https://bitbucket.org/alanmi/abc";
-    rev    = "a2e5bc66a68a72ccd267949e5c9973dd18f8932a";
-    sha256 = "09yvhj53af91nc54gmy7cbp7yljfcyj68a87494r5xvdfnsj11gy";
-  };
-
-  preBuild = ''
-    export buildFlags="CC=$CC CXX=$CXX LD=$CXX ABC_USE_NO_READLINE=1 libabc.a"
-  '';
-
-  # n.b. the following are documented, but libabc.so is not a valid make target:
-  # ABC_USE_PIC=1 libabc.so
-
-  enableParallelBuilding = true;
-  installPhase = ''
-    mkdir -p $out/lib
-    mv libabc.a $out/lib
-    # mv libabc.so $out/lib
-  '';
-
-  meta = {
-    description = "A library for sequential logic synthesis and formal verification";
-    homepage    = "https://people.eecs.berkeley.edu/~alanmi/abc/abc.htm";
-    license     = stdenv.lib.licenses.mit;
-    platforms   = stdenv.lib.platforms.unix;
-    maintainers = [ stdenv.lib.maintainers.kquick ];
-  };
-}
diff --git a/pkgs/applications/science/logic/abc/shared-library.patch b/pkgs/applications/science/logic/abc/shared-library.patch
new file mode 100644
index<PHONE_NUMBER>0..8954c36b560
--- /dev/null
+++ b/pkgs/applications/science/logic/abc/shared-library.patch
@@ -0,0 +1,11 @@
+--- hg-archive-org/CMakeLists.txt	2017-10-19 11:25:32.940200041 +0100
++++ hg-archive/CMakeLists.txt	2017-10-19 11:32:20.239750726 +0100
+@@ -93,7 +93,7 @@
+
+ list(REMOVE_ITEM ABC_SRC src/base/main/main.c)
+
+-add_library(libabc EXCLUDE_FROM_ALL ${ABC_SRC})
++add_library(libabc SHARED EXCLUDE_FROM_ALL ${ABC_SRC})
+ abc_properties(libabc PUBLIC)
+ set_property(TARGET libabc PROPERTY OUTPUT_NAME abc)
+
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 12d57f556b2..2e2d8d0ceb2 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -18481,8 +18481,7 @@ with pkgs;

   ### SCIENCE/LOGIC

-  abc = callPackage ../applications/science/logic/abc/libabc.nix {};
-  abc-verifier = callPackage ../applications/science/logic/abc {};
+  abc = callPackage ../applications/science/logic/abc {};

   abella = callPackage ../applications/science/logic/abella {};

--
2.14.2

@Mic92, my preference would be for the original form for the following reasons:

Your proposed change would involve changing the name of an existing package, which could have unintended consequences beyond the scope of just this repository.
The needs for the library or for the executable are separate and distinct.  For my purposes, I do not use the abc-verifier package, but I do need to link to the library.  This is akin to Redhat's practice of creating "foo-devel" packages.
The description in your form should probably be "A tool and library for ...".
Your form would remove thoughtpolice as a maintainer.
I'm not sure why you disabled enableParallelBuilding.
Your form also makes a change to always generate a shared library version instead of the static library.  My need is (slightly) better served by the static library version, and since there didn't seem to be anyone else using this :smiling_imp: I didn't invest the time to diagnose and enable building both versions.

While my preference is still for the original, divided form, I would be amenable to updates if you are strongly disposed to a version of your combined form (although I would like to hear from @thoughtpolice on this as well).

We prefer shared libraries in nixpkgs. By using outputs = ["out" "dev" "lib"]; the package can be splitted further to not include the exutable. enableParallelBuilding did not had an effect in the build - it still used -j1. The maintainer thing was just a copy'n'paste error. We can use an alias in lib/aliases.nix to link abc-verifier to the new version.

OK, thanks for the feedback.

So you no longer want to add this library?

I can locally build the static library which meets the needs I have for the moment.  I originally submitted this in July, and since there's been no interest from anyone else expressed in that period, I'm assuming I'm the only user.  I will probably work on this again sometime in the future when I have time to address your input and submit updates to the upstream package to allow building both the static and shared versions of the library.

Hi @kquick,
I apologize for getting back to you late. I had way too many Nixpkgs notifications, so I ignored them for a time. Thank you for the manual ping, I'm back in action now!
I agree with @Mic92 actually that having them both in the same place would be ideal, using the new shared output functionality. The main reason is: it's simply a lot easier to maintain for everyone when I won't have to go through and maintain multiple copies. (The yosys package actually uses its own variant of abc, but this is luckily less annoying since it abstracts away the details...)
However, abc has a very weird build system (I was actually fighting it on Windows recently); for example, I don't think the static Makefile variant actually builds shared objects, but we tend to like those for our -dev packages, but the CMake build was less reliable for me. It's all a bit odd...
In any case, if you have something that works for you now, I might be able to test @Mic92's changes and write up a  patch and have you test it, if that's OK.
Also: The reason I named the abc package abc-verifier is because there was already some bizarre abc package (some kind of weird "Aspect Oriented" thing, IIRC?) that was effectively unmaintained, but I was hesitant about just blindly renaming it. However, I removed that quite a while ago, I think, meaning that anyone who encountered it would have already hit that issue at least. abc-verifier isn't an especially good name, either, IMO, though... But I'm not entirely sure how many users there really are...

@thoughtpolice, thanks for the response.  Both you and @Mic92 have much more experience with Nixpkg maintenance, so I think it would be fine to go forward with @Mic92's version for the general support if neither of you have any significant concerns.  I agree about the build system, which is why I'm not eager to spend the time at the moment to resolve the static/shared issue... it may be better and easier for me to see if I can evolve my local use case to be able to use the shared library once I have some time to address it.
I figured there was some conflict on the original name.  My initial approach was intended to minimally conflict with any existing setup to avoid problems; I'm happy to defer to the two of you, I just don't have any additional bandwidth to work on the nixpkg for a couple of weeks.


Infer missing speed limits

The speed limit layer added in #169 is missing data, as described in the PR, discussed in #177, and visible clearly on any map.
I was considering integrating with https://github.com/westnordost/osm-legal-default-speeds to infer missing values, but currently, the rules for GB, which seem to match https://www.gov.uk/speed-limits, do not seem to take effect. I plugged https://www.openstreetmap.org/way/74150037 as an example highway=residential in at https://westnordost.github.io/osm-legal-default-speeds/#tags=highway%3Dresidential&cc=GB, but it didn't match any rules.
Opening this issue to track all possible solutions. I would be in favor in the UI of having an option to only show explicitly-tagged-in-OSM speeds, but disabling and de-emphasizing by default.

Sounds good, I think residential being 30 or less is a good starting point and thumbs up to representing that in the UX.

We have more thorough data from OS now


tf.keras.callbacks.ModelCheckpoint ignores the montior parameter and always use loss

I am running tf.keras.callbacks.ModelCheckpoint with the accuracy metric but loss is used to save the best checkpoints. I have tested this in different places (my computer and collab) and two different code and faced the same issue. Here is an example code and the results:
import tensorflow as tf
from tensorflow import keras
from tensorflow.keras import layers
import os
import shutil

def get_uncompiled_model():
    inputs = keras.Input(shape=(784,), name="digits")
    x = layers.Dense(64, activation="relu", name="dense_1")(inputs)
    x = layers.Dense(64, activation="relu", name="dense_2")(x)
    outputs = layers.Dense(10, activation="softmax", name="predictions")(x)
    model = keras.Model(inputs=inputs, outputs=outputs)
    return model

def get_compiled_model():
    model = get_uncompiled_model()
    model.compile(
        optimizer="rmsprop",
        loss="sparse_categorical_crossentropy",
        metrics=["accuracy"],
    )
    return model

(x_train, y_train), (x_test, y_test) = keras.datasets.mnist.load_data()

# Preprocess the data (these are NumPy arrays)
x_train = x_train.reshape(60000, 784).astype("float32") / 255
x_test = x_test.reshape(10000, 784).astype("float32") / 255

y_train = y_train.astype("float32")
y_test = y_test.astype("float32")

# Reserve 10,000 samples for validation
x_val = x_train[-10000:]
y_val = y_train[-10000:]
x_train = x_train[:-10000]
y_train = y_train[:-10000]

ckpt_folder = os.path.join(os.getcwd(), 'ckpt')
if os.path.exists(ckpt_folder):
    shutil.rmtree(ckpt_folder)

ckpt_path = os.path.join(r'D:\deep_learning\tf_keras\semantic_segmentation\logs', 'mymodel_{epoch}')

callbacks = [
    tf.keras.callbacks.ModelCheckpoint(
        # Path where to save the model
        # The two parameters below mean that we will overwrite
        # the current checkpoint if and only if
        # the `val_loss` score has improved.
        # The saved model name will include the current epoch.
        filepath=ckpt_path,
        montior="val_accuracy",
        # save the model weights with best validation accuracy
        mode='max',
        save_best_only=True,  # only save the best weights
        save_weights_only=False,
        # only save model weights (not whole model)
        verbose=1
    )
]

model = get_compiled_model()

model.fit(
    x_train, y_train, epochs=3, batch_size=1, callbacks=callbacks, validation_split=0.2, steps_per_epoch=1
)

1/1 [==============================] - ETA: 0s - loss: 2.6475 - accuracy: 0.0000e+00
Epoch 1: val_loss improved from -inf to 2.32311, saving model to D:\deep_learning\tf_keras\semantic_segmentation\logs\mymodel_1
1/1 [==============================] - 6s 6s/step - loss: 2.6475 - accuracy: 0.0000e+00 - val_loss: 2.3231 - val_accuracy: 0.1142
Epoch 2/3
1/1 [==============================] - ETA: 0s - loss: 1.9612 - accuracy: 1.0000
Epoch 2: val_loss improved from 2.32311 to 2.34286, saving model to D:\deep_learning\tf_keras\semantic_segmentation\logs\mymodel_2
1/1 [==============================] - 5s 5s/step - loss: 1.9612 - accuracy: 1.0000 - val_loss: 2.3429 - val_accuracy: 0.1187
Epoch 3/3
1/1 [==============================] - ETA: 0s - loss: 2.8378 - accuracy: 0.0000e+00
Epoch 3: val_loss did not improve from 2.34286
1/1 [==============================] - 5s 5s/step - loss: 2.8378 - accuracy: 0.0000e+00 - val_loss: 2.2943 - val_accuracy: 0.1346

I found the issue. I was using montior instead of monitor!


endpoints will be repeated after the reload

env
grape (0.6.1)
goliath (1.0.3)
rack (1.5.2)

posts.rb
class Posts < Grape::API
  version 'v1', :using => :path
  format :json

  params do
    requires :id, type: Integer
  end

  resource 'shopping-carts' do
    get "/users/:id" do
    end

    post "/users" do
    end

    put "/users/:id" do
    end

    delete "/users/:id" do
    end
  end
end

2.0.0p247 :001 > Posts.endpoints.size
 => 4
2.0.0p247 :002 > load '/home/tumayun/workspace/shopping-cart-service/app/apis/posts.rb'
 => true
2.0.0p247 :003 > Posts.endpoints.size
 => 8
2.0.0p247 :004 > load '/home/tumayun/workspace/shopping-cart-service/app/apis/posts.rb'
 => true
2.0.0p247 :005 > Posts.endpoints.size
 => 12
2.0.0p247 :006 > load '/home/tumayun/workspace/shopping-cart-service/app/apis/posts.rb'
 => true
2.0.0p247 :007 > Posts.endpoints.size
 => 16

Fixed in #988


ISPN-6318 Remove tests on unsecured caches

https://issues.jboss.org/browse/ISPN-6318

Pushed, thanks


Add action to copy file name and/or path as string

I often use this plugin to find an asset in my project I wish to subsequently insert as text into code.
Describe the solution you'd like
An action than yanks the currently selected file name and/or path as text to the buffer
Describe alternatives you've considered
Currently I either try and remember what I see (memory not great, many mistakes happen :)), or open the file and then get the filename of the buffer.

I wouldn't have those in telescope-file-browser.nvim, but you could easily adapt telescope.actions to your own liking.
https://github.com/nvim-telescope/telescope.nvim/blob/f174a0367b4fc7cb17710d867e25ea792311c418/lua/telescope/actions/init.lua#L480-L497
In both cases you'd need
local symbol = action_state.get_selected_entry().value

rather than value[1].
In any case, it's probably more of an upstream (= telescope) issue to generalize that function if you wouldn't be happy to adapt those issues.
Hope it helps, if there's any more telescope-file-browser.nvim-specific questions, happy to answer here. Otherwise, closing for the time being.

Thanks @fdschmidt93 – for any future travellers I was able to run with the selection and add two new functions. One adds just the filename, and the other the filename and path (there is a whole bunch of stuff in vim.inspect(action_state.get_selected_entry())!
--- Insert filename into the current buffer and keeping the insert mode.
actions.insert_name_i = function(prompt_bufnr)
  local symbol = action_state.get_selected_entry().ordinal
  actions.close(prompt_bufnr)
  vim.schedule(function()
    vim.cmd([[startinsert]])
    vim.api.nvim_put({ symbol }, "", true, true)
  end)
end

--- Insert file path and name into the current buffer and keeping the insert mode.
actions.insert_name_and_path_i = function(prompt_bufnr)
  local symbol = action_state.get_selected_entry().value
  actions.close(prompt_bufnr)
  vim.schedule(function()
    vim.cmd([[startinsert]])
    vim.api.nvim_put({ symbol }, "", true, true)
  end)
end

require("telescope").setup({
  defaults = {
    sorting_strategy = "descending",
    prompt_prefix = "   ",
    winblend = 25,
    mappings = {
      i = {
        ["<esc>"] = actions.close,
        ["<C-q>"] = actions.smart_send_to_qflist + actions.open_qflist,
      },
    },
  },
  extensions = {
    file_browser = {
      theme = "ivy",
      hidden = true,
      mappings = {
        ["i"] = {
          ["<S-M>"] = fb_actions.move,
          ["<C-Y>"] = actions.insert_name_i,
          ["<C-P>"] = actions.insert_name_and_path_i,
        },
      },
    },
  },

I wouldn't have those in telescope-file-browser.nvim, but you could easily adapt telescope.actions to your own liking.

Really? It seems like a very fitting functionality for telescope-file-browser to me.


Leverage docker default seccomp policy for istio init container

Signed-off-by: Christopher M. Luciano<EMAIL_ADDRESS>related: #4500

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cmluciano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
Assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thoraxe Can you try this out and see if it works for #4500?
I just noticed this added into the istio addon in k8s

@cmluciano: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

@cmluciano: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andraxylia, cmluciano
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [andraxylia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-unit-tests

prow/istio-presubmit.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
5efe2471d14822d7476d9d229b490f0c006f0a0a
link
/test istio-presubmit

prow/istio-unit-tests.sh
c2035b853e360c5a5de23d0b0ab1e8fc526f0684
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8411bf47a4af5b38607585dd7cdb75022fdf320f
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I'm not sure if the failures are related to my change or not @andraxylia @ZackButcher

/retest

Can you try to put a /hold and rebase on top of release-1.0 ? The tests are not flaky there.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8411bf47a4af5b38607585dd7cdb75022fdf320f
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
8411bf47a4af5b38607585dd7cdb75022fdf320f
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The tests that failed are TestTLSMultiplexing, I am not familiar with it the author no longer works on Istio, but that test is not required. If the required tests pass, you should be able to merge.

I would like this fix in 1.0.1 anyway @costinm wdyt?

/assign @costinm

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
8411bf47a4af5b38607585dd7cdb75022fdf320f
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
7a97db227c10f8471bcdccd18eff626284f70b38
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
25ce4cf9c655b73879af783d5165bb9632a5845c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Attempting to unblock.
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andraxylia, douglas-reid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [andraxylia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Is this still relevant today in light of work happening by @tiswanso et al?
Otherwise, the failures look unrelated, and a rebase and re-push should kick circleci and get the PR moving.

@ZackButcher I think it's still relevant depending on how long we want the enhancements to pod-controller or CNI plugins to bake. Regardless, I think the template might still be leveraged at some level of Istio config.

@ZackButcher @andraxylia closing since significant progress has been made on the CNI front


"IllegalStateException: Already resumed" on disconnected internal callback

Hi
Using 0.3.0, we sometime have this exception
Fatal Exception: java.lang.IllegalStateException: Already resumed
       at kotlin.coroutines.SafeContinuation.resumeWith(SafeContinuationJvm.kt:44)
       at com.welie.blessed.BluetoothCentralManager$cancelConnection$2$1.onDisconnectedPeripheral(BluetoothCentralManager.kt:538)
       at com.welie.blessed.BluetoothCentralManager$internalCallback$1$disconnected$1.invokeSuspend(BluetoothCentralManager.kt:209)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
       at kotlinx.coroutines.internal.LimitedDispatcher.run(LimitedDispatcher.kt:39)
       at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:95)
       at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
       at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
       at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
       at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

There is no way to catch it outise of the lib because the exception raise in an internal callback here :
https://github.com/weliem/blessed-android-coroutines/blob/0.3.0/blessed/src/main/java/com/welie/blessed/BluetoothCentralManager.kt#L209

Thanks for reporting. Not quite sure why this is happening.
How can I reproduce this?

I guess you are seeing that the device is disconnected twice? Can you share more logs?

Yes, i think that my code call disconnect twice in some cases.
But i think that the lib have to support this behavior and manage it, by ignoring the second call or something like that 🤷🏻♂ ?


Update claim-tokens to work with Typescript

Given we know that serverless-esbuild works with serverless offline, we can seamlessly run serverless lambdas with typescript (There is a working example with uniswap's fork of routing-api)

it will no longer be implemented


Communication with IoT hub stops after some hours.

Hello,
I'm using the OpcPublisher with my IoT hub as a standalone application and the Mqtt protocol.
My problem is that after a few hours of operation I'm receiving the following error:
Connection status changed to 'Disconnected', reason 'Retry_Expired'
After this, the communication with IoT hub is completely lost and the msg send failures counter in the OpcPublisher status output starts to increase.
Before there were also several messages (repeated almost hourly) like this:
Connection status changed to 'Disconnected_Retrying', reason 'Communication_Error'
What could be reason for this? There were no such problems occurring in former versions of the publisher (half a year ago).
Any help appreciated.
Thanks
Hartmut

Any solution to this issue?

Unfortunately not. I did a support request to MS support/IoT Hub. Found out that it only occurs when using mqtt-websocket-only and amqp-websocket-only. Works with Amqp.
MS support told me to clarify this directly with the owners of the opc publisher...
Still hoping to get some help here since supporting communication over websocket is required in many of our installations.
regards
Hartmut

Hi @anhame - apologies for this dragging out so long and us not getting back.  We are building a tool to track these issues to the correct owner (Us, IoT SDK or IoT Edge).
While we do this, want to clarify the working setup where raw mqtt and amqp works, does this mean connected over raw mqtt or amqp to EdgeHub, or to IoTHub?   And if the former, is EdgeHub connected over Websocket?   Or also over raw MQTT or AMQP?

Hi Marc,
the connection setup is just raw AMQP to IoTHub (didn't test with raw MQTT so far), it doesn't work over Websocket (neither AMQP nor MQTT).
regards

Further clarification - this is publisher connected directly to IoT Hub , not running inside IoT Edge, correct?

Yes, the opc publisher running as a standalone app connected directly to the IoT hub.

If you wish, I could add the last lines of the publisher logs with detailed Device SDK output (containing the exception that causes the communication to be stopped)?

That would be fantastic.   Btw., which version of publisher are you using, is it 2.5.1 or earlier?   So we know the version of IoT sdk in question also.

I'm using
publisher version 2.4.1,
Microsoft.Azure.Devices 1.17.3,
Microsoft..Azure.Devices.Client 1.20.1
I've attached the complete log file since it could also be helpful to see the complete history...
publisherLogs.zip

Using a tool to introduce bad packets into the network I can reliable get websocket communication to crash, not just in publisher, but in general.   Following up with SDK team.  To confirm - the issue does not repro for you if not using websocket, so this could be the smoking gun.

Yes, the publisher connectivity is fine when using Amqp...

Closing as we officially only support running our modules in IoT edge and thus websocket is not required.
Please open an issue with the azure iot sdk if you want to pursue issues in websocket connectivity or consider running with mqtt or amqp against IoT edge in transparent gateway mode.


Unwanted Letterboxing

Bug Description
Images that span the whole page in the editor are shown with letterboxing in preview. Obviously the user could set the image as a background for this purpose, but it should still match
Possibly due to the new aspect ratio?
Expected Behaviour
Editor should match preview
Steps to Reproduce

Add an image to the page
Stretch the image to fill the page (do not set as background or use fill)
save and preview the story

Screenshots
Editor:

Preview (Notice white padding / letterboxing):

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

@pbakaus is this a p0 for alpha?

yes. This should be fixed now with the new background resizing behavior though.

@pbakaus The case above is for an image that was manually stretched to more or less fit the page but is not actually a background image.

ooooh thanks for the clarification. Not a P0 then, nothing we can really do about that.

@dvoytenko @swissspidy it says this was closed via "automation" but I'm not seeing it fixed on staging. Should I reopen this for when we work on P1s?

Can't repro. Looks good to me. Are you sure you're setting "Fit to device"?

This was replicated by several others during our hangout where we all showed our stories.

Still. Is this b/c the feature is not very discoverable? Or b/c it's broken?

The cases in the hangout where al sadly "working as intended". That is, we all positioned things outside of the background, and these had letterboxing in the output. That's sadly unavoidable at the time being.

Maybe better default needed? Or auto-background-background for average color/blur?

It's still happening. Step to reproduce. Click image from media gallery. Move it to corner of page and resize it to fit to page manually. Preview mode there are white span on top and bottom.

/to @pbakaus @samitron7 This can certainly appear as broken to the user. But I believe this is working as intended.

It seems the safe area has wrong size against the full page size. Is this behavior expected?

Safe area is constructed to be safe against all page sizes (read "most"). So, it will be different from any particular page size you view it on. That's why there are special background/fullbleed rules.

This will be much more obvious, and much easier to fix when we implement the auto-overflowing safe zone.

This is fixed now that the new auto overflowing safe zone is implemented.


Add querystring parameters to limit which fields are returned

For clients who don’t need detailed data, cutting some fields (e.g. availability.slots or availability.capacity) from responses can make the response smaller and make the  queries faster since joins take less memory. We should add a querystring parameter than allows clients to ask for fewer fields.
I’m not 100% sure on the best form for this; it could be as simple as some presets, like ?detail_level=light, or it could be a comma-separated list of fields, like ?fields=id,external_ids,name,availability.valid_at,availability.available,availability.products.
This is not yet a high priority need, but I’m noting it down since Vaccinate the States wants to integrate on the front-end instead of the back-end, and this could be a particularly useful feature for that.

This project has been shut down. This issue has been left open as a guide for anyone forking this project — addressing this issue (or at least knowing about it!) is likely to be worthwhile for you if you are maintaining a running copy or fork of UNIVAF.


⚠ Processors has degraded performance

In 45064c3, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 65 ms

Resolved: Processors performance has improved in 59cd11d.


Feature: Implement Random Prompt Generator for Character

This feature has been completed in wasm, but it is difficult to call it in Python. We will postpone this work to after 1/1


Inconsistencies with what's in Amazon's docs with their sample responses

For example
In docs the name of the prop is IncludedFeeDetailList

But the examples have it as just IncludedFeeList
IncludedFeeList in "Example response (Success)"

There were 2 other examples I found, 1 is in the Points type, they have PointsMonetaryValue as required but in the XML sample in the docs, it's omitted, and I forgot to document the other one.
Type Points

@moltar My question is how should I approach this? Build around the XML or the docs

Did you check how other libraries are handling this?

Ooh that's a good a point, I should've thought of that earlier. Thanks!


Added support for NO_COLOR env variable

Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (123f931) 79.65% compared to head (098cd86) 79.50%.

Files
Patch %
Lines

...uk/ktaf/rendering/frames/ansi/AnsiGridTextFrame.kt
60.00%
5 Missing and 3 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   79.65%   79.50%   -0.16%
==========================================
  Files         110      110
  Lines        3008     3025      +17
  Branches      473      478       +5
==========================================
+ Hits         2396     2405       +9
- Misses        346      351       +5
- Partials      266      269       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add scmResourceGroupState context key

Commands contributed to the scm/resourceState/context can use the scmResourceState context key in their when-clauses to test the value of the contextValue property of the SourceControlResourceState.
There is no equivalent capability for commands contributed to the scm/resourceGroup/context menu. It is only possible to test the read-only id property of the SourceControlResourceGroup, which is done by checking scmResourceGroup in when-clauses.
Our SCM provider uses resource groups more dynamically than the Git provider does, and we want to vary the contents of a group's context menu (and inline command buttons) during its life. We cannot change the group's id property to achieve this, and we don't want to destroy and recreate a group in order to do so.
This issue is a feature request for the addition of an optional contextValue property on SourceControlResourceGroup, which would be exposed as a new context key named scmResourceGroupState.
If the proposal is accepted I am willing to prepare a PR.

@gjsjohnmurray, this ask sounds reasonable to me. Please feel free to submit a PR. Thanks!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


⚠ Spryr has degraded performance

In 367cf30, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3212 ms

Resolved: Spryr performance has improved in 7cf87a0 after 7 minutes.


Backporting Extra Clang Tools to Clang 8

It would be useful to add Extra Clang Tools to Clang 8 for things still on 8 (like Numba, CUDA, etc.). This would likely amount to backporting PR ( https://github.com/conda-forge/clangdev-feedstock/pull/64 ).

Addressed in PR ( https://github.com/conda-forge/clangdev-feedstock/pull/85 ).


Continue on error

Continue with the next request when an error occurs in the allocation of prefixes. Before this change, NSO would lock up when for example trying to allocate prefixes from a pool without free prefixes.

I haven't tested this. We're so early on in the life of this that there's probably plenty of bugs everywhere and every PR is an improvement ;) Alpha alpha. Code LGTM - will merge.