x/build: disable GOTOOLCHAIN=local for the x/tools/gopls repo

As soon as 1.23-rc1 is released, we want to update the toolchain requirement for x/tools/gopls to 1.23-rc1, in accordance with the plan in #65917. This means gopls will require at least a 1.23 toolchain to build.
However, we still want to support gopls integrating with the go command of older go versions. This would happen naturally on the release branch trybots, except that due to GOTOOLCHAIN=local they cannot build gopls. https://go.dev/cl/588766 contains a trial CL demonstrating this failure mode.
I propose that we remove the GOTOOLCHAIN=local setting for gopls tests. Given that the gopls build must already download external dependencies, I don't see why GOTOOLCHAIN=local is necessary.
A side effect may be that some gopls tests download additional toolchains. That may or may not be desirable, depending on whether the test itself is intended to exercise toolchain upgrades. Currently, we have some tests that we'd like to write but can't, because of the GOTOOLCHAIN=local restriction.  For tests where the toolchain upgrade is unintended, we can guard the test using existing mechanisms to skip on older toolchains.
This issue is somewhat urgent, since we want to make this change in the gopls go.mod file as soon as the Go rc is cut in mid June. Putting this in the 1.23 milestone to reflect the relationship of this issue with the 1.23 release.
CC @adonovan @hyangah @golang/release

Given that the gopls build must already download external dependencies, I don't see why GOTOOLCHAIN=local is necessary.

The Go release policy says the last two major Go releases are supported, and accepted proposal #34536 clarifies we support them equally. This means even if someone needs to take 8 months before upgrading to a newer major release after it's out, they can do so while receiving security fixes and other critical bug fixes on a supported older major version. When a newer major Go version bumps minimum OS requirements, the older major Go version can still be used for 6 months before becoming unsupported.
The builders are configured to test both supported release branches, in addition to tip, so that issues that affect only one of the two supported Go versions are caught. Setting GOTOOLCHAIN=local by default in the builders is done since the builders are responsible for selecting the toolchain being tested, and they wouldn't provide signal for said toolchain if it were to be accidentally upgraded to a different version. In other words, it's not done because it is necessary, but in order to increase the signal we get from them.
I wanted to share that context first. It's certainly possible to make an adjustment for the x/tools/gopls module if there's agreement that it's needed. Also, individual tests that need finer control can invoke the go tool while overriding its environment (including GOTOOLCHAIN), though that's probably not applicable in this case.

@dmitshur I'm not sure that the Go release policy applies in this way. Gopls is a tool that is used for editing Go code. We have gone to great effort to ensure that a gopls built with the most recent version of Go can be used to edit code targeting older Go versions. This issue is about ensuring that we also integrate with the go command of older go versions. From that perspective, it seems that we are still fully supporting older Go versions.
I suspect that consolidating gopls on the latest version of Go will actually improve its support for older Go versions, since gopls will benefit sooner from parser and type checker improvements.
With respect to updating the go.mod file to -rc1, this is only a temporary measure on the master branch. We will never reference an rc in the go.mod file of a released version of gopls. Updating the go.mod to 1.23-rc1 allows us to start working on simplifying the gopls codebase, removing legacy version support, so that we can release<EMAIL_ADDRESS>soon after Go 1.23 is released.
We regularly update the gopls go.mod file to bump the minimum version requirements of its dependencies to their latest version. Is the go toolchain any different? Serious question.
Here are a couple considerations:

An organization may have a policy saying that only Go 1.N.1 may be used to build tools, perhaps due to concerns about the stability of .0 releases. But of course, they are installing the latest version of gopls and its dependencies, so I'm not sure this concern is reasonable.
[pointed out by @dmitshur] The latest version of Go regularly drops support for older operating systems. Requiring the latest version of Go to build gopls means that users on e.g. Mac OS 10.15 can't build gopls. But of course, they can install an older version of gopls.

This is a tough call. We can of course be more conservative, and only move our go.mod to the oldest supported Go version (rather than the most recent Go version), but that means that our iteration cycle with the standard library is a 9mo-1y, rather than 3-6 months. It also means we have to simultaneously support multiple versions of e.g. the parser or type checker, which can have different semantics. This potentially significantly decreases the benefit of bumping our toolchain requirements.
@rsc I think we need your advice here.

Thanks. I'm convinced you should be able try this, given you're already taking the support needs into account to a great degree. This is something we can choose to undo if you learn it's not working well or as you intended. Sent you crrev.com/c/5589446.

Thanks Dmitri.
This could be hard to undo if we immediately break compatibility with 1.22 (which we may want to do, because of the gotypesalias change in go/types). We'll discuss this consideration on the team.
In any case, the change to remove GOTOOLCHAIN=local makes sense, because we may even want to keep around the N-2 and N-3 builders for some time, to ensure integration with legacy go commands.

Looks Dmitri's CL above fixed this! https://go.dev/cl/588766 shows tests passing seamlessly with 1.21.
Closing as completed. Awesome.


Won't load module if it is "exposed" in the cabal file

As stack repl doesn't allow :l -ing modules that are exposed, when the module that we are working on is exposed it is not loaded.

Misclicked, sorry 😛

Irrelevant with new version, closing


Android-Kotlin: 05.3 Android Content Provider

Description 📜

Prepare an exhaustive documentation about Content Providers in Android.

Domain of Contribution 📊

[x] Android Dev (Flutter, Java, Kotlin)

References
Android Content Provider Basics - Official Docs

Please Read it Carefully Before Contributing

Changes should be made in Android_Development_With_Kotlin/ directory under Android_Development_With_Kotlin branch.
Inside Android_Development_With_Kotlin/ directory creates a directory and names it according to the topic ( for this issue 05. Android Component)
Inside 05. Android Component/ directory add your task with subtopic number and name and make changes accordingly.
You have to push your PR to the Android_Development_With_Kotlin branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Kotlin pending then please first complete them.

Supervisor @rahulsain

I want to make "Documentation" on this issue - #1576 @rahulsain @ydasc815 . Kindly assign me this issue

@ayush-sleeping You are already assigned now

@ayush-sleeping You are already assigned now

no @rahulsain , Not on this . Because its still showing -
Assignees:
No one assigned

@ayush-sleeping You are already assigned now

no @rahulsain , Not on this . Because its still showing -
Assignees:
No one assigned

Please work on other issue, that I have just assigned you

@ayush-sleeping You are already assigned now

no @rahulsain , Not on this . Because its still showing -
Assignees:
No one assigned

Please work on other issue, that I have just assigned you

ok , thanks for replying me.

Hey @rahulsain I have completed all my panding issues , Now assign me this issue . I want to make a Documentation on this Topic.

@ayush-sleeping Do the required changes in the PR , so that I can merge it

Thanks @rahulsain

@ayush-sleeping Do the required changes in the PR , so that I can merge it

ok .... what i have to change ... can you tell me


[Bug]: could not parse txt file in demo

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
b8eedbdd86ca966582645e429abb6f1488ee621c
Other environment information
No response
Actual behavior
[ERROR]Internal server error: Sorry! Cant get file paul_graham_essay.txt from minio. Could you delete this file and uploaded again.
paul_graham_essay.txt
Expected behavior
No response
Steps to reproduce
upload the attached txt file in demo, try to parse it

Additional information
No response

I think you can delete it by youself. Press the trash button on the right.


Fix #453 Update package.json to include the build directory

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

[ ] Tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

LGTM - but can you do an npm pack, and try installing it locally?  Just as a sanity test?

packed and listed tables. seems good.


Update circe-generic, circe-literal to 0.14.9

About this PR
📦 Updates

io.circe:circe-generic
io.circe:circe-literal

from 0.14.6 to 0.14.9
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.circe" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #316.


IA-2613: Use Org unit change requests old values while approved

Using old field values while change request is approved, following those changes
Related JIRA tickets : IA-2613
Self proofreading checklist

[x] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] New translations have been added or updated if new strings have been introduced in the frontend
[ ] My migrations file are included
[ ] Are there enough tests
[ ] Documentation has been included (for new feature)

Changes

refactor useNewFields for readability
review status colors
using old values if status is approved

How to test
Remove old change requests you did before Marc previous PR.
Create 3 change requests
Reject, approved and let the last one to new (use the dashboard, not the admin)
Make sure the dialog renders properly the fields with correct colors, also if this is the approved one, values on the left should be different than the modified version.
Print screen / video

https://github.com/BLSQ/iaso/assets/12494624/7e27643a-2fd9-45ab-8098-5918ade8667e
new lay-out


in package.json "prepare:public"  ,a small mistake like&& not  ;

Yep this has been resolved by a prior PR, but thanks for pointing this out!


Error -9988 Steam closed

Steps to reproduce

I am trying to use Speech_Recognition
When I run it from Pycharm or from my bash I generate errors.

Expected behavior
I expected the speech_recognition file to run, as it did in December 2017.
Actual behavior
Bash Error
$ python converse.py
Initializing...
Traceback (most recent call last):
File "converse.py", line 116, in
listen(mic, recog)
NameError: name 'mic' is not defined
Pycharm Error
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/Users/owner/Library/Application Support/JetBrains/Toolbox/apps/PyCharm-P/ch-1/182.3911.3/PyCharm 2018.2 EAP.app/Contents/helpers/pydev/_pydev_bundle/pydev_umd.py", line 194, in runfile
    pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
  File "/Users/owner/Library/Application Support/JetBrains/Toolbox/apps/PyCharm-P/ch-1/182.3911.3/PyCharm 2018.2 EAP.app/Contents/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/Users/owner/sbox/James/JamesFiles/jamesmk6_2/converse.py", line 115, in <module>
    initialize_mic()
  File "/Users/owner/sbox/James/JamesFiles/jamesmk6_2/converse.py", line 54, in initialize_mic
    recog.adjust_for_ambient_noise(mic)
  File "/Users/owner/ThirdParty/speech_recognition/speech_recognition/__init__.py", line 188, in __exit__
    self.stream.close()
  File "/Users/owner/ThirdParty/speech_recognition/speech_recognition/__init__.py", line 203, in close
    if not self.pyaudio_stream.is_stopped():
  File "/Users/owner/ThirdParty/venv/lib/python3.7/site-packages/pyaudio.py", line 543, in is_stopped
    return pa.is_stream_stopped(self._stream)
OSError: [Errno -9988] Stream closed

System information
(Delete all the statements that don't apply.)
My iMac is macOS High Sierra
My Python version is 3.7.0a2
My Pip version is 18
My SpeechRecognition library version is 3.6.3
My PyAudio library version is 0.2.11
My microphones are: ['Built-in Microphone', 'Built-in Input', 'Built-in Output'], bose in ear headphones
My working microphones are:
python -c "import speech_recognition as sr;print(sr.Microphone.list_working_microphones())"
Traceback (most recent call last):
File "", line 1, in
AttributeError: type object 'Microphone' has no attribute 'list_working_microphones'
Ummmm problem...

This might be related to
Stream Closed Error #71
https://github.com/Uberi/speech_recognition/issues/71

This was fixed by #306 .


failed to create container with device mapper

I have docker 1.5.0 rc1 installed with logic volume as the storage. "--storage-opt dm.datadev=/dev/direct-lvm/data --storage-opt dm.metadatadev=/dev/direct-lvm/metadata" . I created a script which starts 10 containers in a roll with this command "docker run -d -i -t busybox /bin/sh"
I got the following error for two containers out of ten
FATA[0000] Error response from daemon: Cannot start container 60420bd54729a8ed7b0ec066889b8bb3a3c2fdabfbb38b90ca2520862bf3672d: Error getting container 60420bd54729a8ed7b0ec066889b8bb3a3c2fdabfbb38b90ca2520862bf3672d from driver devicemapper: Error mounting '/dev/mapper/docker-202:2-4072516-60420bd54729a8ed7b0ec066889b8bb3a3c2fdabfbb38b90ca2520862bf3672d' on '/var/lib/docker/devicemapper/mnt/60420bd54729a8ed7b0ec066889b8bb3a3c2fdabfbb38b90ca2520862bf3672d': no such file or directory
this problem also happened on docker 1.4.1

This is an exact duplicate of #4036.
I'm going to close and lock this issue so that the discussion continues on #4036. We're seeing a lot of duplicates for this issue and it makes keeping track of new devicemapper related issues difficult. That's why I'm locking it as well.
Please comment on #4036 if you get the "no such file or directory" error with devicemapper.


Fix CV notifications

Update Notifier to support CV violations with violation type = CV_{constraint_name}. Update CV e2e test to assert the GCS violations file exists after a scan.
Resolves #3621
Results from local test run of CV
✔  scanner-config-validator-gcs-policy: Command: `forseti model use aa730cdac11`
     ✔  Command: `forseti model use aa730cdac11` exit_status should eq 0
     ✔  Command: `forseti model use aa730cdac11` stdout should not match /Error communicating to the Forseti server./
     ✔  Command: `sudo rm -rf /home/ubuntu/policy-library/policy-library` exit_status should eq 0
     ✔  Command: `sudo git clone https://github.com/forseti-security/policy-library.git --branch master --depth 1 /home/ubuntu/policy-library/policy-library` exit_status should eq 0
     ✔  Command: `sudo gsutil cp -r gs://forseti-server-6ed34ce7/policy-library/policies /home/ubuntu/policy-library/policy-library` exit_status should eq 0
     ✔  Command: `sudo systemctl restart config-validator` exit_status should eq 0
     ✔  Command: `forseti scanner run` exit_status should eq 0
     ✔  Command: `forseti scanner run` stdout should match /Running ConfigValidatorScanner.../
     ✔  Command: `forseti scanner run` stdout should match /Scan completed/
     ✔  Command: `forseti scanner run` stdout should match /Scanner Index ID: (.*[0-9]*) is created/
     ✔  Command: `forseti notifier run --inventory_index_id<PHONE_NUMBER>583651` exit_status should eq 0
     ✔  Command: `forseti notifier run --inventory_index_id<PHONE_NUMBER>583651` stdout should match /Notification completed!/
     ✔  Command: `forseti notifier run --inventory_index_id<PHONE_NUMBER>583651` stdout should match /Retrieved ([0-9]*) violations for resource 'config_validator_violations'/
     ✔  Command: `mysql -u forseti_security_user -p --host <IP_ADDRESS> --database forseti_security --execute "SELECT COUNT(*) FROM violations V JOIN forseti_security.scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>583651 AND V.resource_id = 'forseti-server-db-6ed34ce7' AND V.violation_type = CONCAT('CV_', V.rule_name);"` exit_status should eq 0
     ✔  Command: `mysql -u forseti_security_user -p --host <IP_ADDRESS> --database forseti_security --execute "SELECT COUNT(*) FROM violations V JOIN forseti_security.scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>583651 AND V.resource_id = 'forseti-server-db-6ed34ce7' AND V.violation_type = CONCAT('CV_', V.rule_name);"` stdout should match /1/
     ✔  Command: `mysql -u forseti_security_user -p --host <IP_ADDRESS> --database forseti_security --execute "SELECT COUNT(*) FROM violations V JOIN forseti_security.scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>583651 AND V.resource_id = 'forseti-server-vm-6ed34ce7' AND V.resource_type = 'compute.googleapis.com/Instance' AND V.violation_type = CONCAT('CV_', V.rule_name);"` exit_status should eq 0
     ✔  Command: `mysql -u forseti_security_user -p --host <IP_ADDRESS> --database forseti_security --execute "SELECT COUNT(*) FROM violations V JOIN forseti_security.scanner_index SI ON SI.id = V.scanner_index_id WHERE SI.inventory_index_id =<PHONE_NUMBER>583651 AND V.resource_id = 'forseti-server-vm-6ed34ce7' AND V.resource_type = 'compute.googleapis.com/Instance' AND V.violation_type = CONCAT('CV_', V.rule_name);"` stdout should match /1/
     ✔  Command: `sudo gsutil ls gs://forseti-server-6ed34ce7/scanner_violations/violations.config_validator_violations.1581006572583651.*` exit_status should eq 0

Thanks for submitting the PR! I see the change that added CV_ to Config Validator violations is reverted. Please share the screenshot of how will the CV violations be displayed on CSCC and in GCS bucket.

The change did not get reverted. CV violations will be saved to the database as CV_{constraint} and that violation type will be communicated to all notifiers. The main fix is how Notifier groups together the violations in a dictionary. Notifier maps the violations so that it can run the Notifiers found in the server config.
Example violation types found in violations table with this change:

Thanks, can you also share the screenshot of the CV violation in the GCS?

Thanks, can you also share the screenshot of the CV violation in the GCS?


fix(code-input): fix theme click

Убрала темизацию для клика

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.846%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6270

Relevant Lines:
7048

💛  - Coveralls


Rest Client Generation Consolidation

Changes in azure-sdk-for-net repo: https://github.com/Azure/azure-sdk-for-net/pull/39576/

Here is the updated preview of azure-sdk-for-net repo: https://github.com/Azure/azure-sdk-for-net/pull/39918
All errors are fixed.

Latest preview in azure-sdk-for-net: https://github.com/Azure/azure-sdk-for-net/pull/39941


Map the internals of PackedIntegerArray.

Some values taken from #1686

Not necessary, but there's a couple of things in BitStorageAlignFix you might want to map while you're at it

@Earthcomputer Thanks! I'll have a look at that and push to this PR again

@Earthcomputer All done. I found two static final fields that were not being used. They look like chunk dimensions.


Add optional parameter colorsPerCategory to PieWidget

Pull Request Test Coverage Report for Build 669041054

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.629%

Totals

Change from base Build 668689666:
0.0%

Covered Lines:
569

Relevant Lines:
688

💛  - Coveralls

Not relevant anymore


Isort ignores --resolve-all-configs

As title mentions it completely ignores any nested config file, in my case setup.cfg.
Surprisingly even when switched to environment isort, or even when path set to the which isort that actually works properly from the command line.
isort --diff --resolve-all-configs components/core/app/gunicorn_app.py gives completely different output as does in VScode, using the mentioned --resolve-all-configs arg, no matter bundled, environment or path explicit is setted up.
I've an instance of setup.cfg file both in project's root folder and in components/core folder, main difference is the headings strings and a known_first_party=app setting on the one in components/core folder.
This works flawlessly on command line.

This is a bug in isort itself, I have filed an issue on isort and it has to be addressed there.
https://github.com/PyCQA/isort/issues/1989
If you need a workaround try this:
https://github.com/microsoft/vscode-python/issues/18714#issuecomment-1100641778

Another work-around is to add --settings-path <directory with .isort.cfg or full pathname> to isort.args.


oraclejdk: 8.191 -> 8.201; no longer depend on requireFile

Motivation for this change
No longer use requireFile and accept the license via nixpkgs option
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

8.201 has beed removed from the oracle website and the downloader does not work with 8.211


How to set different user limit for different users

hello i was trying to set rate_limit for diffrent users i have  added rate_limit plugins  into my haraka server
bt it  setting limit for all users on the server which i have created not specific users could anyone please guide me how to do this

in the same way as the login in #1188 but with the limits and not the password. btw you need also a redis server.


CLOUDP-185426 Enable logging when running mac notary

Proposed changes

Jira ticket: CLOUDP-#

Closes #[issue number]
Checklist

[ ] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
[ ] I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
[ ] I have updated test/README.md (if an e2e test has been added)
[ ] I have run make fmt and formatted my code

Further comments

I've updated goreleaser to 1.16.0 inline with https://github.com/goreleaser/goreleaser/issues/3741


Pull inventory summary

@bryanmtl @aamyot
this merge is necessary for me to finish my sync with quiet rake task (issue 562).
added a document type for inventory summary, methods to parse it with, and date service to pull the most recent document given a document name.

@aamyot thank you for the feedback! very helpful. i think this should be good to merge into master, yeah?

The only very little thing I would do is to turn the methods in your DateService into class methods instead of instance methods.
Hushed::DateService.build_date(date_string) instead of Hushed::DateService.new.build_date(date_string)
But it's 👍

@aamyot good point!!


add datadog

Thanks! I'll merge this as-is, but I'd love if you could create a company profile sometime!


Fix bug in jsonpb for maps with enum values.

Marshal parameters for map values are located under 'protobuf_val' tag. Jsonpb marshaler uses a tag for map. Added the subProp parameter for marshalField and marshalValue to provide 'protobuf_val' properties.

Thanks for your contribution. Can you rebase this to target the dev branch?

Sure, that's fine.


Use reconnectedHandler in Tendermint

Looks like we closed https://github.com/iov-one/iov-core/issues/229 a bit too early. We now have ReconnectingSocket, which accepts a reconnectedHandler. However, this handler is never used.
What we need for https://github.com/iov-one/ponferrada/issues/14 is clients that keep track of subsciptions they have. As soon as the socket reconnects, those subscriptions need to be recreated. This affects WebsocketClient from the Tendermint package and WsEthereumRpcClient.
This is needed for the browser extension to track transaction state after postTx. For Ethereum we use polling in this case, so this is lower priority. But in case of BNS, we use both transaction and block subscriptions in postTx, so this is needed for https://github.com/iov-one/ponferrada/issues/14.

Use reconnectedHandler in Tendermint (this ticket)
Use reconnectedHandler in Ethereum (https://github.com/iov-one/iov-core/issues/1204)

Extracted https://github.com/iov-one/iov-core/issues/1204 out of this one


Fix ZT lists update

When updating the cloudflare_zero_trust_list only changes to the items field was being considered to determine the list elements to store. However, customers can also use the items_with_description field to declare list elements with a description, so it also needs to be considered. This commit fixes the issue, adding an acceptance test to prove its effectiveness.

acceptance tests all passing
TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsList_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsList_Basic
--- PASS: TestAccCloudflareTeamsList_Basic (4.17s)
=== RUN   TestAccCloudflareTeamsList_BasicWithDescription
--- PASS: TestAccCloudflareTeamsList_BasicWithDescription (12.02s)
=== RUN   TestAccCloudflareTeamsList_LottaListItems
--- PASS: TestAccCloudflareTeamsList_LottaListItems (17.03s)
=== RUN   TestAccCloudflareTeamsList_Reordered
--- PASS: TestAccCloudflareTeamsList_Reordered (4.64s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	39.504s


It is 2017! Postpone expiration to 2025

This should get the failing tests to pass!
http://wilson.ci.chef.co/job/chef-server-trigger-ad_hoc/54/downstreambuildview/

:shipit:


[FLINK-31626] HsSubpartitionFileReaderImpl should recycle skipped read buffers.

What is the purpose of the change
In FLINK-30189, HsSubpartitionFileReaderImpl will skip the buffer has been consumed from memory to avoid double-consumption. But these buffers were not returned to the BatchShuffleReadBufferPool, resulting in read buffer leaks. In addition, all loaded buffers should also be recycled after data view released.
Brief change log

HsSubpartitionFileReader should not read buffers from disk after it has been released.
HsSubpartitionFileReaderImpl should recycle skipped read buffers.

Verifying this change
This change added unit tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

Thanks @TanYuxin-tyx for the review, I have addressed all the comments in the fix-up commit, please take a look again.

Rebased it and waiting for CI passing.

merged via 59462197.


Emit workflow counts per workflow type metrics

What changed?
Emit workflow counts per workflow type metrics
Fix the es query to exclude uninitialized workflow execution records

Why?

How did you test it?
Tested at staging2, added new panel to dashboard to see the results

Potential risks

Release notes

Documentation Changes

Sorry, we should be fixing the names if we plan on adding more workflows to esanalyzer. I feel like having 1 wf do both things is a gross violation of SRP


Next12.2 future/image support

Describe the bug
Using the experimental "allowFutureImage"  with storybook, it throw Error.
The "next/future/image" component is experimental and may be subject to breaking changes. To enable this experiment, please include `experimental: { images: { allowFutureImage: true } }` in your next.config.js file.

Your minimal, reproducible example
nextjs example with-storybook-app
Steps to reproduce

npx create-next-app --example with-storybook with-storybook-app
add experimental config

// next.config.js
module.exports = {
  ...
  experimental: {
    images: {
      allowFutureImage: true,
    },
  },
}

replace "next/image" to "next/future/image"

// pages/nextjsImages.js
import Image from 'next/future/image'

Expected behavior
with next.config.js setup, the stories including future/image should load without error.
How often does this bug happen?
Every time
Screenshots or Videos

Platform

mac OS
Chrome (102.0.5005.115)

storybook-addon-next version
1.6.7
Additional context
No response

@kodai3 found a quick hack by using this webpack alias:
    return {
      ...config,
      resolve: {
        ...config.resolve,
        alias: {
          ...config.resolve.alias,
          "next/future/image$": "next/image",
          // styles: path.resolve(__dirname, "../src/lib/"),
        },
      },
    };

This hack works.
But, next/future/image render only img tag, while next/image render img tag wrapped with span.
Storybook may show different results from production.

Yeah I guess the storybook add on will need to be updated. Otherwise we'd have to style for future and non future variants which would be annoying.

I am looking for a solution as well, the workaround doesn't align with the same container structure so the output will different between Next and Storybook

Workaround
import * as NextFutureImage from "next/future/image";
Object.defineProperty(NextFutureImage, "default", {
  configurable: true,
  value: (props) => {
    return <img {...props} />;
  },
});

The fix for the fill property will be release in the next stable release: https://github.com/vercel/next.js/releases/tag/v12.2.6-canary.3

...config,
resolve: {
...config.resolve,
alias: {
...config.resolve.alias,
"next/future/image$": "next/image",
// styles: path.resolve(__dirname, "../src/lib/"),
},
},

In my case the src was returned as an object, so in order to make it work I had to destructure it a bit more like that:
const {
      fill,
      src: { src },
      ...restProps
    } = props

    console.log(restProps)

    return (
      <img
        src={src}
        {...restProps}

I think this is the simplest solution.
import Image from 'next/future/image';

const OriginalImage = Image.default;
Object.defineProperty(Image, 'default', {
  configurable: true,
  value: props => <OriginalImage {...props} unoptimized />,
});

The best workaround i have made for now:
// /.storybook/preview.tsx
{
  const NextFutureImage = require('next/future/image') as typeof NextFutureImage__Type;

  const OriginalNextFutureImage = NextFutureImage.default;

  Object.defineProperty(NextFutureImage, 'default', {
    configurable: true,
    value: (props: NextFutureImageProps) => {
      const {src, ...restOfProps} = props;
      const fixedSrc: string = '/' + (typeof src === 'object' ? ('default' in src ? src.default.src : src.src) : src);
      const blurDataURL: string | undefined = props.src === 'string' ? props.src : undefined;

      return <OriginalNextFutureImage {...restOfProps} unoptimized src={fixedSrc} blurDataURL={blurDataURL} />;
    },
  });
}

This code is based on the original implementation of next/image in storybook-addon-next properly adjusted to work well with next/future/image instead.

To fix the warning I have:
// .storybook/main.js

const webpack = require('webpack');
const ImageConfig = require('next/dist/shared/lib/image-config'); // <----------------

module.exports = {
  stories: [
    '../stories/**/*.stories.@(tsx|ts|jsx|js|mts|cts)',
  ],
  addons: [
    'storybook-addon-next',
  ],
  core: {
    builder: 'webpack5',
  },
  webpackFinal(config) {
    config.plugins.push(new webpack.DefinePlugin({ // <----------------
      'process.env.__NEXT_IMAGE_OPTS': JSON.stringify({
        ...ImageConfig.imageConfigDefault,
        experimentalFuture: true,
      }),
    }));

    return config;
  },
};

and
// .storybook/preview.js

import NextFutureImage from 'next/future/image';

const OriginalNextImage = NextImage.default;
const OriginalNextFutureImage = NextFutureImage.default;

Object.defineProperty(NextImage, 'default', {
  configurable: true,
  value: props => <OriginalNextImage {...props} unoptimized />,
});

Object.defineProperty(NextFutureImage, 'default', {
  configurable: true,
  value: props => <OriginalNextFutureImage {...props} unoptimized />,
});

Since next 13 support has been released. I'm closing this issue

@ackvf in next 13 next/future/image just becomes next/image which this addon supports


Generate a request ID for the Clinical Ingestion REST API flow

Ingesting a patient through the REST API does not offer a way to match it against an either success or failed response.  Some of this exists within the NiFi flow but only if you get that deep into it - need something higher level
Example: Post 10 patients through REST API if any of those patients fail, there is no way to match a failure to the REST API request.

Fix delivered to the ingestion NiFi flow. Documentation udpated.


Fix error connection logging crash

If unmapped_url is not set, the code that logs a connection failure will crash.  We had this reported by a customer using a plugin which meant no remap rule was traversed.  This fix addressed their issue.
This code was brought in PR #7757, so any branch with that change also needs this change.

Looks good to me.


[ERROR] COMPILATION ERROR

I tried mvn jetty:run but could not as it gave me the following error trace:
howcase (master) $ mvn jetty:run
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.springframework.samples:spring-mvc-showcase:war:1.0.0-BUILD-SNAPSHOT
[WARNING] 'dependencies.dependency.version' for org.apache.logging.log4j:log4j-core:jar is either LATEST or RELEASE (both of them are being deprecated) @ line 48, column 13
[WARNING] 'dependencies.dependency.version' for org.apache.logging.log4j:log4j-slf4j-impl:jar is either LATEST or RELEASE (both of them are being deprecated) @ line 53, column 13
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-war-plugin is missing. @ line 183, column 12
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] ----------< org.springframework.samples:spring-mvc-showcase >-----------
[INFO] Building spring-mvc-showcase 1.0.0-BUILD-SNAPSHOT
[INFO] --------------------------------[ war ]---------------------------------
[INFO]
[INFO] >>> jetty-maven-plugin:9.4.8.v20171121:run (default-cli) > test-compile @ spring-mvc-showcase >>>
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ spring-mvc-showcase ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ spring-mvc-showcase ---
[INFO] Changes detected - recompiling the module!
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Compiling 40 source files to /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/target/classes
[INFO] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/form/FormBean.java: Some input files use or override a deprecated API.
[INFO] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/form/FormBean.java: Recompile with -Xlint:deprecation for details.
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/messageconverters/JavaBean.java:[4,33] package javax.xml.bind.annotation does not exist
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/messageconverters/JavaBean.java:[6,2] cannot find symbol
  symbol: class XmlRootElement
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/mapping/JavaBean.java:[3,33] package javax.xml.bind.annotation does not exist
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/mapping/JavaBean.java:[5,2] cannot find symbol
  symbol: class XmlRootElement
[INFO] 4 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.383 s
[INFO] Finished at: 2019-03-31T09:31:00+07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project spring-mvc-showcase: Compilation failure: Compilation failure:
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/messageconverters/JavaBean.java:[4,33] package javax.xml.bind.annotation does not exist
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/messageconverters/JavaBean.java:[6,2] cannot find symbol
[ERROR]   symbol: class XmlRootElement
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/mapping/JavaBean.java:[3,33] package javax.xml.bind.annotation does not exist
[ERROR] /media/nobu/Ubuntu Backup/Comp Sci/Web/Java/spring-mvc-showcase/src/main/java/org/springframework/samples/mvc/mapping/JavaBean.java:[5,2] cannot find symbol
[ERROR]   symbol: class XmlRootElement
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

In Eclipse , Debug as -> Debug Configuration -> Maven Build , select the base directory and  goals should be jetty:run and click on Debug.

I had the same problem. I was running Java 11 on the command-line. I changed JAVA_HOME and PATH to Java 8 and it worked.

Is the isssue resolved?


Resolve PydanticImportError by installing pydantic-settings

Description of changes
Summarize the changes made by this PR.
This PR resolves the PydanticImportError by installing the pydantic-settings package. The error occurred when trying to import chromadb due to the BaseSettings class being moved to the pydantic-settings package.
[Bug]: Chromadb import error. Dependency issue: Install pydantic-settings package #774

Improvements & Bug fixes

Resolved PydanticImportError
Installed pydantic-settings package

Test plan
How are these changes tested?
The changes can be tested by running the code that previously resulted in the import error and verifying that the error no longer occurs.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
There are no specific documentation changes required for this fix. However, it is important to ensure that the updated dependency on pydantic-settings is mentioned in the project's documentation or any relevant installation instructions if applicable.

Thanks @rjarun8
I am running Python 3.10 and this fix resolved the error

Unfortunately this approach won't work as it seems the newer version of pydantic /fast api has changed some validation logic which breaks the client/server mode. We should definitely enable newer versions of these depdencies but for now #783 will be our workaround


Implement computed property for hasDescription in Page/Panel for vue: #818

I believe this should fix issue #818, but I wasn't 100% sure if it's the correct business logic. I dug around and didn't see a showDescription property like there is with title, so I just implemented this getter to return true/false based on description alone.

It does not look like the failing build is related to my changes.

@benirose Yes, there is a functional test that has to be changed.
You fix is completely fine.

@benirose Of course it is there. We have released v0.98.3 today :)
Thank you,
Andrew


Feature/auto profilers arguments

@sobolron - FYI
WIP, not ready yet
Description
Refactored the code, as adding each new profiler bloated the main.py module.
Related Issue

Motivation and Context
Code was getting messy and bloated
How Has This Been Tested?

Screenshots

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have updated the relevant documentation.
[ ] I have added tests for new logic.

I'm not sure this abstraction is useful, if the PR adding it ends up adding lines and not removing :(

I'm not sure this abstraction is useful, if the PR adding it ends up adding lines and not removing :(

Usually I agree with this. And less code is better. But most added lines are caused by the registry which I think it's a file you won't need to normally read or change, and that the benefit of having the profilers arguments in profilers file is really nice.

@alonbentamar , I left a few comments. Looks good nonetheless. Please clean it up and we can merge tomorrow.
Also, if possible please take a look at https://github.com/Granulate/gprofiler/pull/126 and see how it's gonna work after your branch (adding NodeJS-specific options that actually go onto the SystemProfiler class)

@alonbentamar , I left a few comments. Looks good nonetheless. Please clean it up and we can merge tomorrow.
Also, if possible please take a look at #126 and see how it's gonna work after your branch (adding NodeJS-specific options that actually go onto the SystemProfiler class)

I think the node.js parameter would be a custom perf parameter instead of its own thing

@Jongy review #142 next and we'll merge both?


Chinese (Simplified) Language Pack 1.43.8 seems to be broken

Some plugins don't work on VSC 64-bit
such as: ms-ceintl.vscode-language-pack-zh-hans
Version: 1.43.0 (user setup)
Commit: 78a4c91400152c0f27ba4d363eb56d2835f9903a
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Steps to Reproduce:

npm i --save koa in a folder
cd this folder
code .

before i use koa,everything is ok... please help me...

I found the reason...

See https://github.com/microsoft/vscode/issues/92950:
I unzipped the latest language pack extension (ms-ceintl.vscode-language-pack-zh-hans, version 1.43.8) and found out that main.i18n.json is saved in UTF8 with BOM encoding and therefore cannot be parsed. The bug need to be addressed quickly and I suggest a recovery version of the extension be published as soon as possible.

Please see 1.43.9 LP with fix.

Thanks, now it works


Update commercequest extension

Description

Added a Dropdown to filter for Search-results during Search
Added a Preview [⌘+Enter] for Search-results. Including Tags, Author and Category

Screencast

Checklist

[ ] I read the extension guidelines
[ ] I read the documentation about publishing
[ ] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

I'm not sure why I have so many conflicts here @pernielsentikaer ? Is it because I did not run pull-contributions before my first merge of feature branches into master? Is there an elegant way to fix this here?


[Feature]: Map nodes for arrays

Feature Request
It would be nice to have a map node that works on arrays to allow for an easy way to setup iterating over an array.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

A split If node is basically a map node - how do you propose the map would work?

If you have any ideas feel free to reopen!


Model can't be loaded in cesium

I use this tool to export gltf models, the model can't be loaded in cesium, I don't know why. Can anyon help?
This is my command:
node .\bin\obj2gltf.js -i C:\Users\shaoping\Desktop\hangshu\HB_0402.obj -o C:\Users\shaoping\Desktop\hangshu\HB_0402.gltf
Tag 0.1.7  works OK, but it seems not surpport transparent texture.

This is my model files.

The model files didn't get uploaded. Can you try changing the extension to .txt or put inside a .zip?

Uploading tree.tar.gz…

tree.gltf.txt
tree.mtl.txt
tree.obj.txt
Sorry, I can't upload my texture, You can use any transparent picture to replace it.
tree.gltf.txt is the model i exported, I can't see it in cesium whit no error.

Thanks for uploading. The model was accidentally made fully transparent, there is a fix here: #77.
Once that's in also make sure to include the --checkTransparency flag, otherwise all textures are considered opaque.

Thank you, The problem is solved.


Chat - Unable to type next paragraph in message - Reported by: @Tushu17

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to app
Open any chat
Type 1 line & hit return to add a paragraph in same message

Expected Result:
In app user is able to add multiple paragraphs to the message by hitting return
Actual Result:
User is unable to add multiple lines in messages. When hit return, message is sent
Workaround:
unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number: 1.1.20-2
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639342107146300
View all open jobs on GitHub

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Ohh wait I'm dumb, this isn't even an issue and is expected behavior.
Use [Shift]+[Return] instead of just [Return] to add a newline.
Closing this out.

Hello @jasperhuangg , It's for mobile web on mobile web we can't add a new line because there is no shift key on mobile.

Bump @jasperhuangg

Should be good to work on by an external contributor

@jasperhuangg I think you forgot to reopen this issue.

Bump @jasperhuangg

Ahh I finally understand what you mean
Next time it would be helpful to include a video recording with the issue to prevent confusion.
https://user-images.githubusercontent.com/31285285/148434758-e05d47a4-c3ca-410f-93d5-1d8f03d24769.MOV
I see that this behavior doesn't happen for native iOS (hitting return gives you a new line). Are we going to change the behavior of mobile web to match that of native platforms?

Upwork

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

in src/pages/home/report/ReportActionCompose.js
we have this code in triggerHotkeyActions which makes pressing Enter key whiteout shift send the message.
// Submit the form when Enter is pressed
if (e.key === 'Enter' && !e.shiftKey) {
    e.preventDefault();
    this.submitForm();
}

so just deleting this will make all platforms use multiline when press enter.
but I think this code is set to some requirements.
so I suggest making send a message when press shift + enter (in case of  desktop )
and enter for the new line on all platforms.
and in this case, we just make the condition like this: -
if (e.key === 'Enter' && e.shiftKey) {
otherwise, we need to track the virtual keyboard.  to know if we are in web or web mobile.
and will track this by tracking screen dimensions or text input poison. since the react-native keyboard API does not work with the web.
then we but the first logic for web desktop
and second to the mobile web.

Deleting is not an option here. We do want to submit the code when the user press enter. But the question is: Will shift+enter be a good shortcut to send a message instead of Enter.
In both cases @ahmdshrif your proposal is good. But Let's get more eyes on this change on slack before we proceed. I will start a discussion thread tomorrow.

proposal
Maybe just add this if( this.props.isSmallScreenWidth ) { return; } to disable hotkey on small screen device.
on :
https://github.com/Expensify/App/blob/eaa09e7efd081dbc78db72e473b45f6524ed197b/src/pages/home/report/ReportActionCompose.js#L361

I think skipping the trigger for Mobile-web is the best option.

Shift-Enter won't work for Native devices.
we can't remove the logic as this is needed for other platforms.

otherwise, we need to track the virtual keyboard. to know if we are in web or web mobile.
and will track this by tracking screen dimensions or text input poison. since the react-native keyboard API does not work with the web.

We don't need to do all that. We have a way of checking that already.
I like @K4tsuki proposal as he is given the straight way of doing that. Although @ahmdshrif suggested this in the above paragraph, @K4tsuki has given the exact approach of doing it. It shows a better understanding of the codebase.
cc: @roryabraham .
:ribbon: :eyes: :ribbon:  C+ reviewed

I mention in my proposal we can track screen dimensions. but I think this will solve this issue for web mobile. but the issue will be on the web tablet so I am not going deeper with this solution

Yeah, that is a good point. What do you suggest then? I am still open to proposals.

Shift-Enter won't work for Native devices.

the current logic is set to web only. so we net need shift enter in native since native event not have e.key it has e.nativeEvent.key
if (e.key === 'Enter' && !e.shiftKey) {

Sorry, I mean for Desktop Web https://github.com/Expensify/App/issues/6767#issuecomment-1014702723. Mis typing...

I am getting confused. So here is slack https://expensify.slack.com/archives/C01GTK53T8Q/p1642436661064300. Do share your thoughts?

@parasharrajat  according to the slack thread, we agree that we need to detect the virtual keyboard.
thanks, @K4tsuki  for explaining this on slack.
so I will explain more about this option
we need the condition to be like this
  if (!this.state.isKeyboardScreen && e.key === 'Enter' && !e.shiftKey) {

how we will detect isKeyboardScreen since keyboardDidshow listener does not work on the web.
I dependant on 2 points: -

the window's dimension is changed when the virtual keyboard appears.
onFocus event happens before keyboard appears then the keyboard appears and the window's dimension changed.

so I save the screen dimension onFocus event and compare it with screen dimension after 400 ms (good time for the keyboard to appear)
checkKeyboardScreen() {
    const unfocusWindowHeight = Dimensions.get('window').height;
    setTimeout(() => {
        if (!this.state.isKeyboardScreen && unfocusWindowHeight !== Dimensions.get('window').height) {
            this.setState({isKeyboardScreen: true});
        }
        return false;
    }, 400);
}

just add it to focus event
we can do this from Dimension change listener but we will have many edge cases and will not be simple like this solution.

Thanks for the updared proposal @ahmdshrif . It's an interesting idea. Can you please plan it according to our codebase?

How will only run this code only on the web.

Dimensions.get('window').height

we don't use this directly. There is a withWindowDimension HOC.

Why do you need a timeout? How did you determine the 400ms for timeout? Note: we don't prefer any solution that depends on setTimeout without definite usage.

thanks, @parasharrajat  for mentioning these points

How will only run this code only on the web?

this only runs on the web as I mentioned e.key is undefined on native  I can add check on the platform but it will be duplicated.
  if (!this.state.isKeyboardScreen && e.key === 'Enter' && !e.shiftKey) {

we don't use this directly. There is a withWindowDimension HOC.

yes, good point  I update it in https://github.com/Expensify/App/issues/6767#issuecomment-1015090345

Why do you need a timeout? How did you determine the 400ms for timeout? Note: we don't prefer any solution that depends on setTimeout without definite usage.

I know it's not preferred to use time output there is no API to detect the keyboard like a native.
and the only event we have is onFocus. and the time from clicking on TextInput to keyboard appears.
will be less than 0.5 sec .

I know it's not preferred to use time output there is no API to detect the keyboard like a native.
and the only event we have is onFocus. and the time from clicking on TextInput to keyboard appears.
will be less than 0.5 sec .

Now, this raises a red flag. How can you be sure that each platform will take 400ms to open the keyboard?

Can we try a solution where we only check if a device is a touchscreen then assume it to be Mobile web and disable the shortcut?

Now, this raises a red flag. How can you be sure that each platform will take 400ms to open the keyboard?
not very sure

yes, I agree. what about checking on the first keypress after focus instead of timeout.(track this with some state )

Still feels like a hack. I don't what could be the side-effects of that.
https://github.com/Expensify/App/issues/6767#issuecomment-1015604434 Have you thought about it?

https://github.com/Expensify/App/issues/6767#issuecomment-1015604434 Have you thought about this?

Yes it's a perfect solution
But Withe rn web i am not find an api to add touch listener .
It's in normal js window.addlistener('touchstart', callback)

Maybe you can try canUseTouchScreen.

@parasharrajat  yes, it should be like that.
const isWebTouchScreen =  'ontouchstart' in window
if (!isWebTouchScreen && !this.state.isKeyboardScreen && e.key === 'Enter' && !e.shiftKey ) {

or just return if we will disable all shortcuts for web mobile.
triggerHotkeyActions(e) {
   const isWebTouchScreen =  'ontouchstart' in window
  if (!e || isWebTouchScreen) {
            return;
        }

Let's just do this.  https://github.com/Expensify/App/blob/eaa09e7efd081dbc78db72e473b45f6524ed197b/src/libs/canUseTouchscreen/index.js#L8
triggerHotkeyActions(e) {
   const isWebTouchScreen =  'ontouchstart' in window
  if (!e || canUseTouchScreen()) {
            return;
        }

@ahmdshrif 's proposal looks good.
:ribbon: :eyes: :ribbon:  C+ reviewed

ok, Thanks @parasharrajat  can we start PR?

Not yet. Rory will decide. Thanks.
cc: @roryabraham  https://github.com/Expensify/App/issues/6767#issuecomment-1016188721

So we want to determine whether or not Enter should send the message, right? According to the consensus in slack, the expected behavior is that Enter sends the message unless there is a software keyboard visible. This solution relying on canUseTouchScreen is problematic for any laptop with touch screens or tablets with keyboards (increasingly common use-cases), so I don't think that is great. Here's what I suggest:

First, use the new virtualKeyboard web API.

It's currently available on Chrome, Edge, and Opera: https://caniuse.com/?search=virtualkeyboard. That will currently cover a majority of Android and Microsoft users, and we can hope that, in time, it will be implemented in other browsers as well.

If we find that the virtualKeyboard API is unavailable, then fall back on canUseTouchScreen. This will give us the expected behavior to most Safari users. The only case in which that would be wrong would be using the web app on an iPad with a keyboard, which we can live with for now. Users can always download the native app.

Does that sound like a good plan to everyone?

Sounds like a plan.

looking good. @roryabraham
@parasharrajat  but looks like we have an issue with virtualkeyboard API.
it's not working with me on the project (give undefined value )
but I run the same code on expo snack it works in the same browser(updated chrome on mac and android ).
I do the test from the console
again it's not working on our project from console
but work on other websites consoles(Github for ex).
I think we need to update something to be able to use this API.
or it's a local host issue.
    isVirtualkeyboardOpen() {
        if ('virtualkeyboard' in navigator) {
            console.log('virtualkeyboard is supported!!');
            const { x, y, width, height } = navigator.virtualKeyboard.boundingRect;
            console.log('Virtual keyboard geometry:', x, y, width, height);
            return y > 0;
        }
        return canUseTouchScreen;
    }

oh, I test the console for https://new.expensify.com/ and it works
looks like it's a localhost issue. do we have a test domain to try it ?

It is virtualKeyboard not virtualkeyboard.

yes, I do the  test it without this condition (just write it for this on the comment.)
that is the navigator object I get not have virtualKeyboard  .
appCodeName: "Mozilla"
appName: "Netscape"
appVersion: "5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36"
connection: NetworkInformation {onchange: null, effectiveType: '4g', rtt: 150, downlink: 3.3, saveData: false}
cookieEnabled: true
doNotTrack: null
geolocation: Geolocation {}
hardwareConcurrency: 12
ink: Ink {}
language: "en-GB"
languages: (5) ['en-GB', 'ar-EG', 'ar', 'en-US', 'en']
maxTouchPoints: 0
mediaCapabilities: MediaCapabilities {}
mediaSession: MediaSession {metadata: null, playbackState: 'none'}
mimeTypes: MimeTypeArray {0: MimeType, 1: MimeType, application/pdf: MimeType, text/pdf: MimeType, length: 2}
onLine: true
pdfViewerEnabled: true
permissions: Permissions {}
platform: "MacIntel"
plugins: PluginArray {0: Plugin, 1: Plugin, 2: Plugin, 3: Plugin, 4: Plugin, PDF Viewer: Plugin, Chrome PDF Viewer: Plugin, Chromium PDF Viewer: Plugin, Microsoft Edge PDF Viewer: Plugin, WebKit built-in PDF: Plugin, …}
product: "Gecko"
productSub: "20030107"
scheduling: Scheduling {}
userActivation: UserActivation {hasBeenActive: true, isActive: true}
userAgent: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36"
vendor: "Google Inc."
vendorSub: ""
webdriver: false
webkitPersistentStorage: DeprecatedStorageQuota {}
webkitTemporaryStorage: DeprecatedStorageQuota {}

maybe it's a local issue for me since, in your production, I can get  virtualKeyboard   from navigator in the console.
wherever we still have the second check for touch screen implemented if the browser does not support it.

Yeah, Firefox does not support this API yet.

It's chrome browser but idk why it's log Firefox!.
Looklike i have local issue . But we can going with that sloution .

Okay, thanks for the updates here. @ahmdshrif Can you please write a single, cohesive proposal for this issue that I can evaluate before we move forward?

@roryabraham  yes that is my final one as you suggest : -
 isVirtualKeyboardOpen() {
        if ('virtualkeyboard' in navigator) {
            console.log('virtualkeyboard is supported!!');
            const { x, y, width, height } = navigator.virtualKeyboard.boundingRect;
            console.log('Virtual keyboard geometry:', x, y, width, height);
            return y > 0;
        }
        return canUseTouchScreen();
    }

triggerHotkeyActions(e) {
  if (!e || this.isVirtualKeyboardOpen()) {
  return;
}

@ahmdshrif This does not work.

if ('virtualkeyboard' in navigator)

Should run only on the web.

I mean: -
1- if we are on the web and we have virtualkeyboard support we will use it to know if the virtual keyboard is on or of.
Native(android and ios) also has navigator object without  virtualkeyboard  so this check is valid for all platforms .
but I make also check if there is a case in native navigator can be undefined.
  if (navigator && 'virtualkeyboard' in navigator) {
        // this web app or Desktop  with support  `virtualKeyboard` . so we can track if keyboard Is on or of
        const  keybordPostion = navigator.virtualKeyboard.boundingRect.y;
        return keybordPostion > 0; // keyboard is open if there position more than 0
}

2- if we are in the native or unsupported browser we will check if this device has a touch screen.
return
    // all native platform  or web not support `virtualkeyboard`
    return canUseTouchScreen();

In the end, as I explain here https://github.com/Expensify/App/issues/6767#issuecomment-1014705531 the current code is desirable this behavior from the native platform with this way.
so no need to add something  like  if (os.platform !== web) return

OK sounds good to me.
cc: @roryabraham

📣 @ahmdshrif You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

ok, I apply to Upwork.  working on PR
cc: @MitchExpensify

Hired @ahmdshrif & @parasharrajat for eventual C+ payment!

@MitchExpensify, can you hire me for reporting bonus. I have submitted the proposal but it's not showing up for some reason

Offer sent @Tushu17 !

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.33-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/7355

If no regressions arise, payment will be issued on 2022-02-08. :confetti_ball:

hi, @MitchExpensify I get the submit request rejected last week. do we have an issue here?

@ahmdshrif paid for the fix and contract ended (That "rejection" probably happened automatically for some reason e.g. the job closing automatically - All good now!)
@parasharrajat paid for C+ and contract ended
@Tushu17 paid for reporting and contract ended
Closing!

Ok thanks


Use VisitOperator trait in new FuncTranslator

This PR carves out a FuncTranslator type from the big FuncBuilder type.
The FuncBuilder type now owns a FuncTranslator as one of its fields.
All translation logic now lives inside the FuncTranslator type.
The FuncTranslator properly implements the VisitOperator trait to translate functions.
The FuncBuilder has the job to validate any Wasm bytecode before translating it via the VisitOperator trait.
This PR goes one step further into a direction that will allow us to have a well defined interface for wasmi multi Engine backend support.


Regenerate client with tchannel sanitization enabled

With https://github.com/yarpc/yarpc-go/pull/1259 we're now able to automatically strip all tchannel headers from any contexts that are provided to the dosa client. You can see this by checking out the .gen/dosa/dosaclient/client.go file. All of the methods now have a call to tchannel.WithoutHeaders(ctx) to strip the bad headers.
In order to generate this new client, we needed to update the version of thriftrw that we're using to version 1.5 and change a few of the arguments used with the yarpc thriftrw plugin. Those changes have been made in the Makefile.

I double checked and this doesn't bring in any new glide deps. So I think it's safe.


notebook() does not automatically launch/open a browser

Instead of leaving the environment vars PYTHON and JUPYTER empty when installing PyCall and IJulia (as suggested when no Python/Jupyter install is available),
ENV["PYTHON"] = ""
ENV["JUPYTER"] = ""

I have specified the full path to my freshly installed Python 3.6 and Jupyter 4.2.1 (by Anaconda 4.3.1). By definition, this does not install the miniconda Python (2) private environment.
Unfortunately, although Jupyter seems to work fine with the Julia's kernel, the commands
using IJulia
notebook()

no longer automatically open/launch the web browser on my Mac. That was a default behaviour by the miniconda (automated private) install. This forces me to manually navigate to http://localhost:8888/ or type at the os command line:  jupyter notebook list
macOS (x86_64-apple-darwin13.4.0)
Julia Version 0.5.2
IJulia                        1.5.0
PyCall                      1.12.0
Python 3.6
Jupyter 4.2.1
It might be related to http://www.andrewjaffe.net/blog/2017/05/python-bug-hunt.html and https://github.com/jupyter/notebook/issues/2438, although with the miniconda install it was working.
I temporarily solved it by typing at a shell prompt:
> jupyter notebook --generate-config
and then uncomment/edit the line of the file ~/.jupyter/jupyter_notebook_config.py (just created), into
c.NotebookApp.browser = 'Safari' (to have Safari explicitly indicated)

IJulia.notebook_cmd will tell you the command-line arguments it is using in notebook(); does running this manually work for you?
I suspect that this is a Jupyter bug, though I'm not sure why it would work at the command line.

By the way, it doesn't matter what environment variables you set when you call IJulia, only when you build IJulia.   Also, the PYTHON environment variable doesn't matter.
Try
ENV["JUPYTER"]="jupyter"
Pkg.build("IJulia")

Indeed, it might not be a IJulia bug, but IJulia is affected.
I am 90% sure that leaving ENV["JUPYTER"]="" initiate a download of miniconda. :-(
I don't want miniconda.. ;-) I don't want extra space used in .julia/

ENV["JUPYTER"]="" before Pkg.build will indeed case it to use Conda.  But I didn't suggest ENV["JUPYTER"]="", I suggested ENV["JUPYTER"]="jupyter" (assuming jupyter is in your PATH, as your above snippets implied).
Again, I want to verify that you set the JUPYTER env var before Pkg.build, not before using IJulia.   The environment variable only affects the Pkg.build.

I have just run into this issue on two different machines. I suspect the problem is upstream, as I also have the problem running jupyter from the shell.
First, on a student's machine with a brand-new install of the macOS 5.2 binary, new package dir, and using the IJulia default miniconda install.  On her machine, IJulia.notebook_cmd pointed at the Conda install in the package dir. Manually navigating to http://localhost:8888 brought up the Jupyter notebook home page.
I also just checked using notebook() from my julia-0.6-rc2, and the same thing.  The server runs, but doesn't load the page in the browser automatically.  This has worked in the past, but I usually launch jupyter from the shell instead so I'm not sure when this changed.  I'm using my own Anaconda jupyter, and Pkg.build has picked up the correct location:
julia> IJulia.notebook_cmd
2-element Array{String,1}:
 "/Users/rrock/anaconda/bin/jupyter"
 "notebook"

I just checked running jupyter from the shell, and I see the same problem there too (so the problem is probably upstream).  I see the following error when running from the shell:
0:97: execution error: "http://localhost:8888/tree?token=xxxxxxxxxxxxxxxxxxxx" doesn’t understand the “open location” message. (-1708)

Apparently, the problem is with macOS 10.12.5, and will be fixed in 10.12.6.  A temporary workaround is to run
export BROWSER=open

in the shell before launching julia.

@rsrock, it might be reasonable to include that BROWSER workaround in IJulia.notebook().  Change the line p = spawn(Cmd($notebook_cmd, detach=true, dir=dir)) to
if is_apple() # issue #551 workaround
    withenv("BROWSER"=>"open") do
        p = spawn(Cmd(`$notebook_cmd`, detach=true, dir=dir))
    end
else
    p = spawn(Cmd(`$notebook_cmd`, detach=true, dir=dir))
end

Yes, that works here.

A PR would be welcome.

Unless we should just wait for 10.12.6?  I don't see any likely downside to including the workaround, however.

This is happening for python 2.7.13 jupyter version 4.3.0.
Any other information I could provide?

@Ryanglambert see above: assuming you are on MacOS, it is a MacOS bug.  You can either ignore it (just open the localhost:8888 url in your browser) or set ENV["BROWSER"]="open" before running IJulia.notebook().

Closed by #552.

I can confirm that this problem occured right after the update to macOS 10.12.5.
My workaround is to define an alias 'nb' in ~/.bash_profile like this:
alias nb='export BROWSER=open; jupyter notebook'

I found one solution:
Step 1 generate the config file
$ jupyter notebook --generate-config
Step 2 open the config file
$ sudo vi ~/.jupyter/jupyter_notebook_config.py
Step3 find c.NotebookApp.browser set it to  u'Safari', also remember to remove '#' at this line
#c.NotebookApp.browser = u' '   --->  c.NotebookApp.browser = u'Safari'

The workaround in #552 will only work for running IJulia.notebook() from within Julia; if you are running jupyter from the command line you will still need a manual workaround.

As far as I can tell, the bug has already been fixed with the macOS 10.12.6 update.
using IJulia; notebook() works fine. Thank you!


JSONP not support numbers

In latest version mocky stop support numbers in ?callback=fname1241 <---
not supported ex: https://www.mocky.io/v2/xxxxxx?callback=jQuery1910379398508199031_1591549388376
work ok: https://www.mocky.io/v2/xxxxxx?callback=jQuery

Hello.
Thanks for your feedback. I'll fix that quickly

Fixed.


test: add integration test for get

Issue #, if available:
N/A
Description of changes:

I have added the test for dy get because the test is nothing
add create_temporary_table function: generate random table name and output the name into stdout. So if the test is failed, we can check the name on the result

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I have add the detail of create_temporary_table on the overview.


ICC fixes

const-qualify function-local static constant arrays.

Updated.

LGTM -- thanks @eile!

@deanberris your requested change actually does not work, at least with icc 17:
boost/network/protocol/http/client/facade.hpp(134): error: a value of type "const char [27]" cannot be used to initialize an entity of type "const char_type []"
          static char_type const content_type[] = "x-application/octet-stream";

I suggest to keep the initial code change by @eile:
static char_type* const content_type = "x-application/octet-stream";

I just verified that this compiles.

@tribal-tec -- that's interesting, why isn't this an ICC bug?
If you send me a pull request I'd be happy to review and merge it.


Assert triggered, possible bug, can't reproduce with bare Duktape

I'm not entirely sure if this is a bug in my own engine or in Duktape, but since the assert is inside of Duktape itself, I'm assuming an internal error.  This is the assert triggered:
PANIC 54: assertion failed: thr->callstack_top == entry_callstack_top + 1 (duk_js_call.c:1348) (calling abort)

This is the JS code that triggered it, but it uses API functions specific to minisphere:
var foodTalking = function() {
	name = GetCurrentPerson();
	new Scenario()
		.talk(name, 2.0, Infinity, "Please don't eat me, maggie!")
		.talk("maggie", 2.0, Infinity, "Too late!")
		.playSound('Munch.wav')
		.killPerson(name)
		.run(true)
}
SetPersonScript('Scott T', SCRIPT_ON_ACTIVATE_TALK, foodTalking);
SetPersonScript('Bruce', SCRIPT_ON_ACTIVATE_TALK, foodTalking);
SetPersonScript('Lauren', SCRIPT_ON_ACTIVATE_TALK, foodTalking);
SetPersonScript('Katelyn', SCRIPT_ON_ACTIVATE_TALK, foodTalking);
SetPersonScript('Amanda', SCRIPT_ON_ACTIVATE_TALK, foodTalking);

It segfaults at the point of calling SetPersonScript(), which shouldn't be an issue as all that does it store the function for later use.  If necessary, I might be able to put together a test case in my engine...

What happens if you run without assertions, is there a crash?

Yes, it segfaults.  I originally had assertions off, I turned them on to see if it was a Duktape bug or on my end.

Any chance of running under valgrind? :)

I haven't set up a Linux VM yet, but I did use the MSVC profiler and found that memory usage skyrocketed just before the crash, it topped out at about 60MB.

What does SetPersonScript() look like?  What happens if you replace it with an empty function?

The relevant code is in these two files:
person.c: https://github.com/fatcerberus/minisphere/blob/master/minisphere/persons.c
script.c: https://github.com/fatcerberus/minisphere/blob/master/minisphere/script.c
In person.c look for JS_SetPersonScript and follow the code path from there.  Sorry I can't simplify it further... :(

What happens if you make SetPersonScript() return immediately? If that avoids the problem, one way to narrow the cause down would be to enable/disable sections of SetPersonScript().
Valgrind is much more cost effective though as a first step :)

Yeah, I installed Hyper-V on my laptop but haven't set up a Linux VM yet.  I'll have to get on that! :-)
I'll do some experiments later, I'm away from the computer right now.

Okay, interesting thing I found out.  First some background IRT the offending SetPersonScript(): It can be passed either a string or JS function.  If the former, the string is compiled into a function and stored in an array in the global stash to be called later.  If the latter, that function is /also/ stored in the same array, just without the extra compilation step.
If I pass a string to SetPersonScript(), it works fine.  The crash occurs when I pass a function, even an empty one.  What I found out is that, for whatever reason, my function duk_require_sphere_script() is erroneously overwriting existing entries in the stash-array.  It just so happens that, in this particular case, the function overwritten was the function that was currently executing (to clarify, the SetPersonScript() call happens inside one of these stashed scripts).  Duktape then GCs it since that was the only reference to the function, and... well...
So this is a bug on my end certainly, but I'm wondering if it's ALSO a Duktape bug.  I would think the GC shouldn't be collecting functions mid-execution...

Hmm. Executing functions should be reachable and reference counted through the call stack - but perhaps there's a bug somewhere in there.

More specifically there should be a function reference on the value stack; the activation then uses a borrowed reference to that.
Could the function being executed be a bound function (xxx.bind())? (I'm asking because the bug might be related to bound chain resolution.)

It shouldn't be a bound function, as it's taken directly from duk_compile() (specifically duk_compile_lstring_filename).

Ok, in that case the value stack below the current function should definitely contain a reference, so either the refcount is mismanaged (leading to the function being freed) or something else goes wrong. The assert that triggered may provide a clue though, because the assert indicates call stack has been unwound incorrectly previously.

Okay, you can call off the wild goose chase now.  I found this bit of idiocy in js_SetPersonScript:
set_person_script(ctx, type, script_id);

See the ctx?  That's supposed to be a person_t*, not a Duktape context.  So in the process of storing the script ID, I was instead overwriting internal Duktape state.  Lovely.
Now the only mystery is why the compiler didn't warn me about passing the wrong pointer type...

Duktape duk_context * is currently a void * which makes warnings less informative.
I plan to change that as soon as I've worked through a few large upcoming merges.  Sorry :o

No problem, I honestly have no clue what I was thinking when I passed a Duktape context to an internal minisphere function like that.  I must just be so used to typing ctx that I did it reflexively without even thinking about it.  Interestingly, this was also what caused my stashed scripts to start overwriting each other.   :o)

It's an easy mistake to make; there are two improvements that might make it easier to catch:

Change duk_context * to be a specific struct pointer rather than a void *.
In all public API calls, assert both that ctx is non-NULL, and also assert for some known value in the structure to identify the structure (not 100% but would probably catch a useful number of cases).

I would think changing this line:
typedef void duk_context;
To something like:
typedef struct duk_hthread duk_context;
Would be sufficient.  The comments in duktape.h say that duk_context* maps directly to duk_hthread* anyway, and since nobody's accessing members of a duk_hthread from outside anyway, you don't have to expose the actual struct definition.

It's an easy mistake to make

Yeah, same thing's happened to me once or twice.

@fatcerberus Yep, that would be enough for now. Not 100% sure if there are any legacy compilers that will complain about never seeing the actual definition. They shouldn't because they don't need e.g. the struct size etc.
Anyway, I'm changing the headers so that the internal structures are also visible in the public header so that some basic operations can be made faster (e.g. direct access to the value stack without making an explicit library call). The definition will be visible during compilation then.

Concrete change tracked by #178.


Missing Beta Entitlement for iOS builds

how would I set this value for iOS builds? I think (not sure) it's done via the Entitlements.plist but maybe there's some cordova workflow to set it
thanks!

Try generating new provisioning profile. This error usually is generated with old provisioning profile. Apple changed structure of it at some point and it results with this error.

I will try but its a pretty recent provisioning profile.

Closing as "resolved". @bFlood Plese reopen if you have anymore issues.


Consultation about adding vapor pressure equations

Hello, if I customize a substance, and the reference phase of the substance is liquid and solid state, respectively, could I consult you what phase does the added vapor pressure equation (the following Substance.Psat.add_method()) refer to, is it the vapor pressure in the liquid state or the vapor pressure in the gaseous state?
The reference phase is liquid state.
Substance_1=bst.Chemical('Substance_1',
                  default=True,
                  search_db=False,
                  formula='C10H15O3',
                  Tb=350.7+273.15,
                  Hvap=82035.54660,
                  phase_ref="l",
                  Tm=70+273.15,
                  Hfus=29600,
                  Hf=-790760,
                  Tc=580,
                  Pc=2500002,
                  Vc=0.0005)
def User_antoine_model_Substance_1_model(T):
    return 10.0**(8 -  1500 / (T - 27))
Substance_1.Psat.add_method(f=User_antoine_model_Substance_1_model, Tmin=298.15, Tmax=599)

The reference phase is solid state.
Substance_2=bst.Chemical('Substance_2',
                  default=True,
                  search_db=False,
                  formula='C10H15O3',
                  Tb=230.7+273.15,
                  Hvap=82035.54660,
                  phase_ref="s",
                  Tm=15+273.15,
                  Hfus=29600,
                  Hf=-790760,
                  Tc=580,
                  Pc=2500002,
                  Vc=0.0005)
def User_antoine_model_Substance_2_model(T):
    return 10.0**(8 -  1500 / (T - 27))
Substance_2.Psat.add_method(f=User_antoine_model_Substance_2_model, Tmin=298.15, Tmax=599)

@yoelcortes, Hello, could you please take some time to look at this problem.

@zasddsgg, vapor pressure is not used for anything in single-phase chemicals. Psat refers to liquid-gas.

@yoelcortes, above chemicals are not single-phase chemicals and also participate in gas-liquid equilibrium. Just the reference phase of the chemicals is liquid and solid state, respectively, so could I consult you what phase does the added vapor pressure equation (Chemical.Psat.add_method()) refer to, is it the vapor pressure in the liquid state or the vapor pressure in the gaseous state.


Missing requirements in composer.json

There are no requirements in your composer.json.
Nothing about PHP version or Magento version.
This is sad guys.

Minimum required Magento version has been added to the composer.json

Add the minimum PHP Version maybe also?

Hi @bjoern-flagbit, It is not recommended to specify supported php versions in dependencies for Marketplace packages. We follow the Magento minimum php version's in this.
See: https://github.com/magento/marketplace-tools/blob/master/validate_m2_package.php#L706


Project Config

How about moving the project.config.ts to the src/client folder or somewhere else? every time i pull from master (described in the wiki) i have to update the file again..

project.config.ts is used only by scripts in the tools directory.
Why do you have to update it each time? Recently there was a "breaking change" regarding the import of Config which might have led to merge conflicts in this file but in general this is supposed to happen in very rare cases.

Every time I pull from git the file is overwritten. So I thought to move it to an other position.

Would you describe the steps you go through when you update the seed?

I move the src/client folder to client_backup, git stash,
then I do a git pull upstream master. after that i have to add my dependencies to the package.json file again, i have to update my project-config and move the client-folder backwards


Add Dialyzer for Typespecs

This patch adds dialyzer and runs type checks as part of our standard checks. Dialyzer will help us perform static verification of our code.

We'll need to make sure we cache the result of dialyzer in CircleCI so we don't wait 6 minutes per build. I'll add a cache directory to circle.yml in this PR.


adjusting times to local time zones

It would be so great if there were some way that I can write a time (perhaps a date?) in my local time zone, but it displays to others in their time zone. I think this would be best done with some form of markup, but perhaps something building on the "linkifier" system would be good too -- i.e., a regex that we can configure.
Please forgive me if this is the wrong place to file a vague feature request. =)

Right Now whenever We post a message on Zulip, then the time of message it shows is mine(with respect to my local timezone) and the person reading it in say some different timezone will get a relative time. So I think that we can extend this feature in messages too, but introducing some decorator like @ time .

I think this makes a lot of sense. Possible duplicate of https://github.com/zulip/zulip/issues/5176.

Can I claim this issue @rishig since issue #5176 is not yet closed?

@imsubhams I think this is a duplicate of #5176, which we should probably just finish.  I'll sync with @aero31aero on merging that.