Create custom widget for code actions (menu items).

Creating a custom list widget for code actions to improve the code actions experience.

Hi! I just tried out the new code action widget in 1.70.
Is there are plan to show the keyboard shortcuts in there as well (similar to the old code action context menu)?
This is helpful when there are different more detailed shortcuts for code actions, for example:
Old:

New:

The 2 shortcuts are not shown in the new version.

@lgrammel What OS are you using VS Code in + can you give me a little more detail on how you're opening the code action widget? I was actually unaware that keybindings were ever shown in the Quick Fix.
Given this notion though, I definitely think it's helpful and can take a look into adding it in!

I'm using Mac OS Monterey 12.2 and I've invoked the menu through a shortcut provided by the JavaScript Assistant extension that I'm developing. It would apply to any user-defined shortcut for code actions as well, say in the following scenario with CTRL+CMD+M:
{
    "key": "Ctrl+Cmd+M",
    "command": "editor.action.codeAction",
    "args": {
          "kind": "refactor.move",
          "apply": "never"
    }
}

{
    "key": "Ctrl+Alt+Up",
    "command": "editor.action.codeAction",
    "args": {
          "kind": "refactor.move.up",
          "apply": "ifSingle"
    }
}

{
    "key": "Ctrl+Alt+Down",
    "command": "editor.action.codeAction",
    "args": {
          "kind": "refactor.move.down",
          "apply": "ifSingle"
    }
}

Gotcha! I think the reason some users have the shortcut details is because VS Code is using the native OS context menu.
Regardless, I'll go ahead and open an issue and take a look at it this iteration!

Awesome, thank you!

it's really an awesome feature! it help me use my key bindings wehn refactor!
thank you!

Thanks for creating this feature. I have been waiting for shortcut support in quick actions for some time.
It realy is my highlight from the latest VS Code update😊

Some feedback from trying out useCustomCodeActionMenu: it's no longer possible to select a list item using the keyboard. For example, with the old version I was able to select "Unwrap function call" simply by typing u:

@lgrammel, may I ask what "theme" you are using in the "New"?

New:

Mine is not highlighting the current selection nor with keyboard nor with mouse after the cursor moving away. Like this

I tried the default light / dark them and neither shows the highlight.

@PabloLION I was using Github Light Default when I took the screenshot.

I have some feedback regarding the keyboard UX that has bothered me for a long time now 😅.
The old and the new widget both immediately select (but not activate) the option that is under the mouse cursor - even when opened with a hotkey (quick fix hotkey). This is really annoying if you want to quickly just accept the first quick fix in the list (e.g. adding an import), but coincidentally the mouse is over an option you don't want to choose and you either activate the wrong option, or have to scroll through all the options to the top first.
What I suggest is to ignore the mouse's position on the widget before the mouse is moved. This makes the mouse not interfere with whatever actions you are taking with the keyboard.
I will follow up with a small GIF if it's not clear.

@michaelschufi This fix is actually in Insiders at the moment! The mouse will no longer automatically select the option its hovering over on startup of the widget (although keyboard selection will still be on the first available code action). See https://github.com/microsoft/vscode/issues/157694

Some loose ends to potentially take a look at @mjbvz:

Keyboard and mouse interactions
UI/UX of headers, fonts, and how selection looks for hover on mouse vs focus from keyboard navigation
Adding code font to refactoring labels that have quotes around them (like Extract function newFunction)
Adding additional code action groups and codicons (https://github.com/microsoft/vscode/issues/158515)
Automatically open the refactoring preview diff editor after hitting Refactor preview from the widget (https://github.com/microsoft/vscode/issues/158408)
Position of the widget should open from the location of cursor, not from where highlight select started.
Mnuemonics: how does the user quickly get the refactor they want via only the keyboard? (https://github.com/microsoft/vscode/issues/157719)
Add a mini quickpick to help with mnuemonics and searching/filtering for the correct code action.

Closing as this is shipping with the august release


"CBC solver is not installed", even though it is installed

Describe the bug
CVXPY claims that the CBC solver is not installed, but I am pretty sure it is.
To Reproduce
Construct any problem, and then try to solve it with:
 problem.solve(solver=cvxpy.CBC)

Expected behavior
It should solve the problem.
Output
cvxpy.error.SolverError: The solver CBC is not installed.

Version

OS: Ubuntu 20.04
CVXPY Version: 1.1.1 and 1.1.12

Additional context
I have CBC installed, since I also tried to run PuLP, which uses CBC by default, and it runs correctly (I saw the CBC logs).
NOTE: I tried to install CBC with:
 python3 -m pip install cbcpy

but got an error:
ERROR: Could not find a version that satisfies the requirement cbcpy (from versions: none)
ERROR: No matching distribution found for cbcpy

cvxpy interfaces with cbc through cylp (https://www.cvxpy.org/install/#install-with-cbc-clp-cgl-support). You need to install cylp.

Also, PuLP includes CBC executables for the major platforms/architectures in its wheel. In most circumstances PuLP can and will use its personal copy of CBC regardless of the state of a global CBC install.


Add DockerHub Build + make container builds & push conditional on successful tests/

Overview
Taking experience with https://github.com/geopython/pygeoapi/pull/801 and updating GH Workflows for pycsw.
Add DockerHub build & push
Update GHCR & DockerHub build to require main.yml workflow to be successful
Update documentation
For the DockerHub build you'll need to add Repo Secrets for
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
[x] I have already previously agreed to the pycsw Contributions and Licensing Guidelines

Thank you, I will review

Minor comments, looks good.
We will need to update the secrets on GitHub, correct?

Made those corrections, good spot!
& yes, the admin will need to add secrets for ${DOCKER_USERNAME} & ${DOCKER_PASSWORD}


[Question] Enter a title

What is your question ?
ola would like to know how to fix the memory of intel hd grafics 630, in my shows that has 3mb and keeps locking
Anything else ?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @Clebersp,
Is your motherboard a H110 ?
Thanks for using my EFI.
Aurélien


OPRUN-3605: Update nodeSelector and tolerations on operator-controller deployment via kustomize patch

Updates the nodeSelector and toleration on the operator-controller deployment via a kustomize patch to allow it to be scheduled on the master node.

/lgtm

/retitle OPRUN-3605: Update nodeSelector and tolerations on operator-controller deployment via kustomize patch

/label acknowledge-critical-fixes-only

/hold
waiting for manual payload job to complete successfully
/override ci/prow/openshift-e2e-aws-techpreview


prevent memory leaking on uncompleted requests & add max post size limit...

Added a configurable max POST limit to prevent instant dead. Also added a close handler so we can clean up the unused buffer for when a request gets canceled.

Looks good - won't prevent a serious attacker from doing a few hundred requests in parallel and stopping just before hitting the limit, but better than nothing.

True but the good thing is that you can configure the limit your self based on the need of your application.


NaNs in the surrogate model for Florence

@WPringle The percentiles file percentiles.nc for Florence with 12-hr leadtime has values for 374,602 nodes out of which, almost half of them are NaNs (mostly land nodes, brown dots in the screenshot below). Is it OK to have NaNs? The number NaNs vary among different percentiles. For example, for quantile=50, there are 172,012 NaNs, but for quantile=90 this number drops to 166,912!

Path to the Percentile file on NHC_COLAB_2: /nhc/hurricanes/florence_2018_OFCL_12hr_korobov_30/setup/ensemble.dir/analyze/linear_k1_p1_n0.025/percentiles.nc
I'm checking ds_percentile.sel(source='surrogate',quantile=90).quantiles.values

That makes sense. The code automatically sets it NaN once the water level is below the allowed minimum depth.


Tracking: improve scaling up performance

The dashboard includes RW's 1cn baseline, 1cn (4X resources), 4cn (each cn 1X resource) and other systems:
http://metabase.risingwave-cloud.xyz/question/9549-nexmark-rw-vs-flink-avg-source-throughput-all-testbeds?rw_tag=nightly-20240127&flink_tag=v1.16.0&flink_label=flink-medium-1tm-test-20230104,flink-4x-medium-1tm-test-20240104&flink_metrics=avg-job-throughput-per-second
To access the dashboard, please refer to:
https://www.notion.so/Performance-Test-Dashboard-Manual-e33b26eb188e48379a7b714a01a4fc2c
4X 1cn performance tests are executed weekly.

[ ] #14986
[ ] #15251
[ ] #14985
[ ] #14987
[ ] #15004
[ ] perf: improve nexmark q103 scaling up performance
[ ] perf: improve nexmark q105 scaling up performance
[ ] ......

Improvements needed:

[ ] #14815 will improve a few stateless and computation-lightweight queries
[ ] ......

One common phenomenon is that
Join Executor Barrie Align, Join Actor Input Blocking Ratio, Join Actor Match Duration Per Second
are all much worse when scaling up

q17 is a query that scales reasonably well, i.e. on par with Flink
4X: https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?from=1706387572000&orgId=1&to=1706388294000&var-datasource=Prometheus:+test-useast1-eks-a&var-namespace=nexmark-lt-4x-1cn-affinity-weekly-20240127
1X: https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?from=1706403182000&orgId=1&to=1706404985000&var-datasource=Prometheus:+test-useast1-eks-a&var-namespace=nexmark-1cn-affinity-weekly-20240127

Query q15, q16 and q17 are similar but different: https://github.com/risingwavelabs/kube-bench/blob/main/manifests/nexmark/nexmark-sinks.template.yaml#L700C5-L713C87
Q17's plan:
 StreamSink { type: append-only, columns: [auction, day, total_bids, rank1_bids, rank2_bids, rank3_bids, min_price, max_price, avg_price, sum_price] }
 └─StreamProject { exprs: [$expr3, $expr2, count, count filter(($expr4 < 10000:Int32)), count filter(($expr4 >= 10000:Int32) AND ($expr4 < 1000000:Int32)), count filter(($expr4 >= 1000000:Int32)), min($expr4), max($expr4), (sum($expr4) / count($expr4)::Decimal) as $expr5, sum($expr4)] }
   └─StreamHashAgg [append_only] { group_key: [$expr2, $expr3], aggs: [count, count filter(($expr4 < 10000:Int32)), count filter(($expr4 >= 10000:Int32) AND ($expr4 < 1000000:Int32)), count filter(($expr4 >= 1000000:Int32)), min($expr4), max($expr4), sum($expr4), count($expr4)] }
     └─StreamExchange { dist: HashShard($expr2, $expr3) }
       └─StreamProject { exprs: [ToChar($expr1, 'YYYY-MM-DD':Varchar) as $expr2, Field(bid, 0:Int32) as $expr3, Field(bid, 2:Int32) as $expr4, _row_id] }
         └─StreamFilter { predicate: (event_type = 2:Int32) }
           └─StreamRowIdGen { row_id_index: 6 }
             └─StreamWatermarkFilter { watermark_descs: [Desc { column: $expr1, expr: ($expr1 - '00:00:04':Interval) }], output_watermarks: [$expr1] }
               └─StreamProject { exprs: [event_type, person, auction, bid, Case((event_type = 0:Int32), Field(person, 6:Int32), (event_type = 1:Int32), Field(auction, 5:Int32), Field(bid, 5:Int32)) as $expr1, _rw_kafka_timestamp, _row_id] }
                 └─StreamSource { source: nexmark, columns: [event_type, person, auction, bid, _rw_kafka_timestamp, _row_id] }
(10 rows)

Although q15 and q16 do not scale well at the moment, q17 DOES scale quite well.
Can refer to the peak number at http://metabase.risingwave-cloud.xyz/question/9270-nexmark-q17-blackhole-4x-medium-1cn-affinity-avg-source-output-rows-per-second-rows-s-history-thtb-2767?start_date=2024-01-04
Can also check Flink's number at http://metabase.risingwave-cloud.xyz/question/9732-flink-nexmark-q17-flink-4x-medium-1tm-avg-job-throughput-per-second-records-s-history-thtb-2922?start_date=2023-12-05
Both 4X above.


missing yew::html- published on crates?

I was trying to play around with yew, crates has version 0.0.1 while the git repo says 0.1.0 (crates won't resolve that version). Crates also doesn't seem to have the html module:
error[E0432]: unresolved import `yew::html`
 --> src/main.rs:4:10
  |
4 | use yew::html::*;
  |          ^^^^ Could not find `html` in `yew`

Has this not been published yet?

You need to target the github repository for now.
crates.io page:

Now you can use from source: https://github.com/DenisKolodin/yew```

Gotcha, thanks


Include ts-jest mock util functions in jest core

🚀 Feature Proposal
This proposal is for the outcome of the discussion in ts-jest that includests-jest mock util functions in jest core.
Motivation
Users don't have to install ts-jest anymore to access these util mocks, just need to install jest.
Pitch
Suggestion from @thymikee that it should belong to jest core

Yeah, I think this is a good idea. There's been some changes to mocks in @types/jest as well, would be nice to bring the best features of both into Jest itself (at which point DT could pull the features from us instead).
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/a68259ee8883cc9899463fe79a78bb49a9d2f6de/types/jest/index.d.ts#L1042-L1298

Hi, can I take this issue?

Yes please! 🙂

Hi @SimenB, I'm working on this issue and don't have much progress. I have some doubts about the approach that I should follow. Actually I didn't understand your first comment really well. Should I try to "use" definition on @types/jest on jest-mock package and work on top of it to add mocked fn from ts-jest?

Has this been abandoned? I can take a look

Include as well another proposal in this area from https://github.com/kulshekhar/ts-jest/issues/1065

got it, will do

Hi
is this issue still open @SimenB ?
can i take this

Hi, Can i Take this issue?


libnd4j: RgbToGrayscale op

We need to add implementation of TF RgbToGrayscale op

Please reassign it back to me, my mistake.

Thanks

@alexanderst PR is up,  can you please add Java wrapper for this op + tests?

P.s. https://github.com/KonduitAI/deeplearning4j/pull/138

Implemented


Input apis somedocs and testfix

fix example bin programs
first pass at fixing README.rst, needs work, its a mouthful.
remove has_tty from class Key, as NoKeyboard exception is always raised
remove unused import in terminal.py, use full keyword arguments to Key class initializer
fix identity issue of NoKeyboard exception after fork.

outdated


World rewrites

Hey, I'm having an issue with world rewrites on the latest version.
My config is below for world rewrites yet it's still not giving users the permissions from world. Any help?
# this list, the value assigned will be sent forward for permission calculation instead.
world-rewrite:
  world_nether: 'world'
  ResourceWorld: 'world'
  world_the_end: 'world'
  spawn: 'world'
  NewSpawn: 'world'
#  world_the_end: world

Can you check using the /lp user <user> info command to see if the extra world contexts are being added?


Display post according to months

How can I display blog posts according to month and not year?

Hi, you mean first year, later months?
2017 January
2017 February
...
...

Yeah or maybe like
2019
	january
		....
2018
	January
		XYZ
		ABC
	Feburary
		....

Thanks for reminding. I'll implement this week.

Anyone willing to pick this up in a PR is welcome!


no init-all so what do you recommend?

When run with new version of terraform with terragrunt, it will ask for init first.
But there is no init-all option currently.
What did you do with this situation?
Currently I write a quick script to go through the files of terragrunt.hcl and run terragrunt init in each folder.

Currently I write a quick script to go through the files of terragrunt.hcl and run terragrunt init in each folder.

This is basically what most people do. See also https://github.com/gruntwork-io/terragrunt/issues/609#issuecomment-441751036
https://github.com/gruntwork-io/terragrunt/issues/492 and https://github.com/gruntwork-io/terragrunt/issues/388 are the relevant bugfixes and feature improvements to achieve init-all like capability. Note that we have not gotten around to start on these yet.
We would also be happy to review a PR that adds init-all as an interim workaround (https://github.com/gruntwork-io/terragrunt/issues/388#issuecomment-360773506).


Rails 5 貌似不支持。

报错：
verify_authenticity_token has not been defined

有人在Rails 5试用了，我还想等5正式发布后，再做调试。
谢谢反馈，您能告诉我你详细的Rails的版本号吗？

同时把详细的错误信息贴一次。

Rails 版本：Rails 5.0.0.beta3
=> Booting Puma => Rails 5.0.0.beta3 application starting in development on http://localhost:3000 => Run rails server -hfor more startup options => Ctrl-C to shutdown server Exiting /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:641:inblock (2 levels) in skip_callback': Before process_action callback :verify_authenticity_token has not been defined (ArgumentError)
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:637:in each' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:637:in block in skip_callback'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:568:in block in __update_callbacks' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:566:in reverse_each'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:566:in __update_callbacks' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:636:in skip_callback'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/abstract_controller/callbacks.rb:210:in block (3 levels) in <module:ClassMethods>' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/abstract_controller/callbacks.rb:93:in block in _insert_callbacks'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/abstract_controller/callbacks.rb:92:in each' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/abstract_controller/callbacks.rb:92:in _insert_callbacks'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/abstract_controller/callbacks.rb:209:in block (2 levels) in <module:ClassMethods>' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/abstract_controller/callbacks.rb:216:in block (2 levels) in module:ClassMethods'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/weixin_rails_middleware-1.3.1/app/controllers/weixin_rails_middleware/weixin_controller.rb:5:in <class:WeixinController>' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/weixin_rails_middleware-1.3.1/app/controllers/weixin_rails_middleware/weixin_controller.rb:2:in module:WeixinRailsMiddleware'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/weixin_rails_middleware-1.3.1/app/controllers/weixin_rails_middleware/weixin_controller.rb:1:in <top (required)>' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:492:in load'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:492:in block in load_file' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:682:in new_constants_in'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:491:in load_file' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:388:in block in require_or_load'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:37:in block in load_interlock' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies/interlock.rb:12:in block in loading'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/concurrency/share_lock.rb:117:in exclusive' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies/interlock.rb:11:in loading'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:37:in load_interlock' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:369:in require_or_load'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:529:in load_missing_constant' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:212:in const_missing'
from /Users/Msms/Develop/workspace/wechatmanagement-plus/app/decorators/controllers/weixin_rails_middleware/weixin_controller_decorator.rb:5:in <top (required)>' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:296:in load'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:296:in block in load' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:268:in load_dependency'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:296:in load' 	from /Users/Msms/Develop/workspace/wechatmanagement-plus/config/application.rb:14:in block (2 levels) in class:Application'
from /Users/Msms/Develop/workspace/wechatmanagement-plus/config/application.rb:13:in glob' 	from /Users/Msms/Develop/workspace/wechatmanagement-plus/config/application.rb:13:in block in class:Application'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:396:in instance_exec' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:396:in block in make_lambda'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:169:in block (2 levels) in halting' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:547:in block (2 levels) in default_terminator'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:546:in catch' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:546:in block in default_terminator'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:170:in block in halting' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:454:in block in call'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:454:in each' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:454:in call'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:101:in __run_callbacks__' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:750:in _run_prepare_callbacks'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/callbacks.rb:90:in run_callbacks' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/action_dispatch/middleware/reloader.rb:81:in prepare!'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/actionpack-5.0.0.beta3/lib/action_dispatch/middleware/reloader.rb:53:in prepare!' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/application/finisher.rb:50:in block in module:Finisher'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/initializable.rb:30:in instance_exec' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/initializable.rb:30:in run'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/initializable.rb:55:in block in run_initializers' 	from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:228:in block in tsort_each'
from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:350:in block (2 levels) in each_strongly_connected_component' 	from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:431:in each_strongly_connected_component_from'
from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:349:in block in each_strongly_connected_component' 	from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in each'
from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in call' 	from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in each_strongly_connected_component'
from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:226:in tsort_each' 	from /Users/Msms/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:205:in tsort_each'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/initializable.rb:54:in run_initializers' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/application.rb:350:in initialize!'
from /Users/Msms/Develop/workspace/wechatmanagement-plus/config/environment.rb:5:in <top (required)>' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:302:in require'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:302:in block in require' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:268:in load_dependency'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/activesupport-5.0.0.beta3/lib/active_support/dependencies.rb:302:in require' 	from /Users/Msms/Develop/workspace/wechatmanagement-plus/config.ru:3:in block in '
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/builder.rb:55:in instance_eval' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/builder.rb:55:in initialize'
from /Users/Msms/Develop/workspace/wechatmanagement-plus/config.ru:in new' 	from /Users/Msms/Develop/workspace/wechatmanagement-plus/config.ru:in '
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/builder.rb:49:in eval' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/builder.rb:49:in new_from_string'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/builder.rb:40:in parse_file' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/server.rb:318:in build_app_and_options_from_config'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/server.rb:218:in app' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands/server.rb:58:in app'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/rack-2.0.0.alpha/lib/rack/server.rb:353:in wrapped_app' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands/server.rb:136:in log_to_stdout'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands/server.rb:76:in start' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands/commands_tasks.rb:90:in block in server'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands/commands_tasks.rb:85:in tap' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands/commands_tasks.rb:85:in server'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands/commands_tasks.rb:49:in run_command!' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/command.rb:20:in run'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/railties-5.0.0.beta3/lib/rails/commands.rb:18:in <top (required)>' 	from /Users/Msms/Develop/workspace/wechatmanagement-plus/bin/rails:9:in require'
from /Users/Msms/Develop/workspace/wechatmanagement-plus/bin/rails:9:in <top (required)>' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/spring-1.6.4/lib/spring/client/rails.rb:28:in load'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/spring-1.6.4/lib/spring/client/rails.rb:28:in call' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/spring-1.6.4/lib/spring/client/command.rb:7:in call'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/spring-1.6.4/lib/spring/client.rb:28:in run' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/spring-1.6.4/bin/spring:49:in <top (required)>'
from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/spring-1.6.4/lib/spring/binstub.rb:11:in load' 	from /Users/Msms/.rvm/gems/ruby-2.3.0@rails5.0/gems/spring-1.6.4/lib/spring/binstub.rb:11:in <top (required)>'
from /Users/Msms/Develop/workspace/wechatmanagement-plus/bin/spring:13:in require' 	from /Users/Msms/Develop/workspace/wechatmanagement-plus/bin/spring:13:in <top (required)>'
from bin/rails:3:in load' 	from bin/rails:3:in '
`

已修复！请使用这个版本：
gem 'weixin_rails_middleware', '~> 1.3', '>= 1.3.2'


Remove refs to kismatic from docs

Description
Type of fix: Documentation
Reason for fix: Apprenda no longer exist, the link used throughout the docs (https://apprenda.com/kismatic/) now redirects to https://atos.net/en/ instead. Kismatic meanwhile appears to have been abandoned, with no new commits at https://github.com/apprenda/kismatic in the last 6 months and the twitter account now being suspended: https://twitter.com/kismatic

Todos

[ ] Tests
[x] Documentation
[ ] Release note

Release Note

None required

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Deploy preview for calico ready!
Built with commit 11803be1b988b2c6d3b84e5105fe2b761cbb3c2d
https://deploy-preview-2343--calico.netlify.com

@gjtempleton thanks, this LGTM.


[BUG] Phone number field at Login should not require spaces

Describe the bug
When creating an account, the form will throw an error unless you use spaces in the phone number. Ex: "555 xxx xxxx". One should be able to use dashes or periods or the phone number should automatically add the desired formatting when you're typing out the number.
To Reproduce
Steps to reproduce the behavior:

Go to 'dev.nationalpolicedata.org'
Click on 'Join Us'
Enter the required information into the form and click submit.
See error

Expected behavior
When you are entering a phone number for the account creation process, it should either not be as strict or it should handle the formatting automatically.
Screenshots

I have created a [pull request] (https://github.com/codeforboston/police-data-trust/pull/273) for this ticket.
Modified the regular expression to cover these variations of the formats of phone numbers below:
+123456789012
1234567890
(123) 456-7890
123-456-7890


PIP package for the new vesion

The taskrunner package within PyPI servers is still the old version. Are you going to upload the new package? Thank you!

Hi, I am also looking for the latest version of taskrunner on PyPI servers. My project would benefit from PR #17. Will a new package be available?
Thank you!

Hi, thanks for the ping, I completely forgot about this. It should be out on PyPI now.

Just checked PyPI and the latest version is there. Thank you!


Cannot find module 'ignore' imported from '/app/app/components/chat/ImportFolderButton.tsx' on fresh install

Describe the bug
Hey everyone,
I'm having troubles on Linux MINT using docker-compose to get the webpage up and running.
I reckon one of the latest cool features was to add the Import Folder button which worked on my last test using a Mac OS M1 configuration. Something seems to be missing. Maybe @wonderwhy-er  could help? I think he did the actual improvement upgrade, you might be the best asset to help?
Link to the Bolt URL that caused the error
localhost:5173
Steps to reproduce
follow the README.md on Linux :
I git cloned the repository, ran the docker build and docker-compose but the docker-compose file was uncomplete. I followed the Issue #241 and got the file corrected adding the context directive.
Expected behavior
However, now the docker-compose --profile development up command is passed, I should be able to get to the web page http://localhost:5173
Screen Recording / Screenshot

Once the docker-compose file is corrected, docker runs OK but the webpage doesn't greet with bolt :'(
Platform

OS: [Linux MINT]
Browser: [e.g. Chrome (Brave Browser), Firefox]

Additional context
I'm using the most fresh git but I could not see anyone else meeting this issue. Is everyone using MacOS or Windows?
:^)
I did a docker exec -it  bash and checked the existence of the .tsx file, and it looks just like the one on the original repo. It does not sound wrong tho...
Thanks a lot everyone, keep it up!

i got the same error on window. do you solved it ?

No I havn't solved it.
However I heard some other devs forked the project and made a docker run command if you'd like to try
https://hub.docker.com/r/weekendwarrior1999/bolt.new-any-llm
if anyone is interested

Hmm, that is weird, did you run pnpm install or npm install?
It was added here https://github.com/coleam00/bolt.new-any-llm/pull/413/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R73
And it is in package.json so should be installed if you run install.

i run pnpm install and its ok now for me. seem npm install didn't install the dependencies.

Hmm, that is weird, did you run pnpm install or npm install?
It was added here https://github.com/coleam00/bolt.new-any-llm/pull/413/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R73
And it is in package.json so should be installed if you run install.

I only have used docker at the moment, but i'm willing to try on a pnpm environment too.
I figured out I would prefer docker because it would run anywhere, plus I feel more 'at home' using Docker and docker-compose.

So I tested with pnpm instead this time, still on Linux MINT, ollama, qwen, and firefox/brave browser.
I do not have that error as with docker-compose, but I just get these three dots '...' whenever I'm clicking on one of the examples like Tic Tac Toe
Tested with dev env and production env.
I am about to test it on Windows with my small 2GB GPU. Should be enough for the smallest models like llama3.2:1B or qwen.
I'd love to make it work on Linux/Docker to host it on ubuntu servers, though! :^) for clustering and future scaling purposes made easier.


Set another Property as ID

I have a BaseEntity with ID, and a derived Entity class. Is there any way to set another property as Identity for that class?

No, but that's an Entity Framework limitation. It uses the identifiers as foreign keys to the tables of the derived classes.


feat: enhance README parameter documentation

Improve clarity and readability of the Parameters section
Organize model parameters into a table format
Deprecate old SD2.1 values with strikethrough; provide updated values
Reformat parameter ranges into a structured table
Add usage guidelines for better understanding
Link to SDXL results for further reference

I also Added comments for clarity and documentation

Added comments throughout the code to explain the purpose and functionality of functions, parameters, and important logic.
Enhanced code readability and maintainability for future developers.


Bundled installer instructions

Codecov Report

Merging #3620 into master will increase coverage by 1.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3620      +/-   ##
==========================================
+ Coverage   71.63%   72.79%   +1.15%
==========================================
  Files         420      420
  Lines       26160    28511    +2351
  Branches     3963     4799     +836
==========================================
+ Hits        18740    20754    +2014
- Misses       6249     6497     +248
- Partials     1171     1260      +89

Impacted Files
Coverage Δ

...i-cloud/azure/cli/command_modules/cloud/_params.py
90% <0%> (-3.34%)
:arrow_down:

...or/azure/cli/command_modules/monitor/validators.py
45.2% <0%> (-3.19%)
:arrow_down:

...vice/azure/cli/command_modules/appservice/_help.py
100% <0%> (ø)
:arrow_up:

...azure-cli-sf/azure/cli/command_modules/sf/_help.py
100% <0%> (ø)
:arrow_up:

...skhelp/azure/cli/command_modules/taskhelp/_help.py
100% <0%> (ø)
:arrow_up:

...ult/azure/cli/command_modules/keyvault/commands.py
100% <0%> (ø)
:arrow_up:

...yvault/azure/cli/command_modules/keyvault/_help.py
100% <0%> (ø)
:arrow_up:

...ure-cli-lab/azure/cli/command_modules/lab/_help.py
100% <0%> (ø)
:arrow_up:

...cli-redis/azure/cli/command_modules/redis/_help.py
100% <0%> (ø)
:arrow_up:

...ure-cli-sql/azure/cli/command_modules/sql/_help.py
100% <0%> (ø)
:arrow_up:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f370602...bdd0947. Read the comment docs.


tcProp confusion

All examples in tProp.ts mention tcProp, which IIUIC doesn't exist (I guess, it's how tProp used to be called earlier).

Another thing: There's a tProp overload stating that "You should only use this with primitive values and never with object values". As they're just three types useful in this place, would it be possible to split the declaration to cover exactly these types, so that errors like
badArray: tProp(types.array(types.string), []), // must be () => []

could be avoided?

thanks! will be out in 0.26.0

out now


Popup message stuck on hover event

Bug Report
When using the popup functionality on a button connected with a click event the popup sometimes creates a div but it won't remove it when hovering out of the button so when hovering again, another div will show on top of the current one.
Steps
Expected Result
popup should disspear after mouse move out of the button/popup
Actual Result
The popup content remains unchanged, like stuck there.💣
Version
"semantic-ui-react": "0.83.0",

Testcase
As below pic, it's obviously my mouse move out of the Popup box, but the Popup didn't appear.

I use the Popup component as below.
<Popup
...
onClose={this.onclose}
trigger={}
/>
The experiment result is:
If I hover my mouse on the Popup element, then it pop up 'words' as expected.
After that if I click the Button to trigger something, and slowly(or in normal speed) move my mouse out of the Popup element, the hovering 'words' will disappear as expected.
However,
If I hover my mouse on the Popup element, then it pop up 'words' as expected.
After that if I click the Button to trigger something, and move my mouse out of the Popup element fast enough, the hovering 'words' will not disappear but keep showing as my mouse is still hovoring on it.
Update:
For better description,
I specially add a callback function this.onclose for props:   onClose?: (event: React.MouseEvent, data: PopupProps) => void
To test whether the onClose() event is triggered.
In my experiment result,
the onClose() is triggered in the first case(slow move out) as expected, but not triggered in the second case(move out fast).

This can be a duplicate of #3257, can you try the latest release?
Can please make a minimal repro case on codesandbox and add clear steps to reproduce?


chore: remove deprecated action

Hi, I'm Marco from the Rust Infra team 👋
As described in https://github.com/rust-lang/simpleinfra/issues/445 we want to delete the simple-ci GitHub action.
This PR substitutes the action with the equivalent commands 👍
Let me know if you have any questions 🙏

Lgtm, thanks!


validation: customization class check

This pull requests adds for customizations a check of classes/memberOf/@key against source or customization specs.

will be surpassed by #1391


Kate - CONSIDER MERGING GJB CULTURES 62528, 62527

Kate's notes:

62528
Hausa Unspecified

REASON: According to wikipedia page for Hausa Language:  "Zazzaganci in Zazzau is the major Southern dialect"; according to SCCS pinpointing sheets, Zazzagawa Hausa are those in the Zaria (also known as the "Zazzau Emirate") region. So, Zazzagawa Hausa = Southern Hausa, and lat long for "Hausa Unspecified" (GJB 62528) is even FARTHER south than lat long for "Zazzagawa Hausa" (GJB 62527)

62527
Hausa Zazzagawa

Question: language for 62527 right now is Arawa dialect of Hausa (araw1280), which is also what D-PLACE lists as language for Hausa Zazzagawa. However, Arawa is a North Hausa dialect and Zazzagawa are Southern Hausa... so is this correct? Should language just be changed to Hausa, no dialect? No glottolog info for Zazzaganci dialect.
See Parlametrics issue 7 : https://github.com/theglobaljukebox/parlametrics/issues/7
--Stella


Add site for MADICES 2

This PR moves the 2022 site into its own section and adds a skeleton for MADICES 2, with the new organizers.

Closes #27


zdns: init at 20210327-8c53210

Motivation for this change
CLI DNS lookup tool
https://github.com/zmap/zdns
Related to #81418
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117989 run on x86_64-linux 1

1 package built:

zdns


I was wondering how your recursive descent parser handles operator associativity, and the following part of the parser led me to discover this "issue":
...
// add = mul ("+" mul | "-" mul)*
static Node *add(Token **rest, Token *tok) {
...

"+" and "-" seems to be right-associative, instead of the more natural "left-associative".

I think this is not about operator precedence but about the order of evaluation. Your code depends on an implementation-defined behavior.
+ and - are left-associative, so A+B-C is interpreted as (A+B)-C. But it doesn't mean A+B is evaluated before C. - can evaluate the right-hand side first and then the left-hand side. The language spec doesn't guarantee any evaluation order for most binary operators (except && and || for the obvious reason).
So, don't do this:
return println_id(1) + println_id(2) + println_id(3);
``

Instead, do this:

int x = println_id(1);
int y = println_id(2);
int z = println_id(3);
return x + y + z;


Build LLaVA v1.5

Are you planning to develop a new version?
I want to contribute together

First of all, thank you for showing interest in the project.
Yes, I have plans to update it to version 1.5. It should be possible by the end of October.
Feel free to go ahead and work on it, and you can submit a pull request (PR) when you're ready. If you'd like to coordinate or have any questions, you can also reach out to me at<EMAIL_ADDRESS>


[fix] doc for importing table

The target table id is missing on the current doc. This will fix the issue.
Test Plan

[x] acceptance tests

[ ] …

References

@ryanking @alldoami Would you check this?

/ok-to-test sha=0668ba6

Also, fyi @yohei1126, rk doesn't work at CZI anymore, so it'll be me mainly reviewing PRs until Snowflake starts to take more ownership of it.

OK thanks. updated the branch.

/ok-to-test sha=ce79745


[WIP] Firestore platform interface (v2)

Description
Continuation of the WIP for the cloud_firestore federation; platform interface + core plugin changes.
This v2 attempts to address the concerns raised in https://github.com/FirebaseExtended/flutterfire/pull/1568.
This is still incomplete, but I've implemented the minimal scaffolding code so I can run the firestore core plugin tests on top of the new implementation. I'm using that test output to track progress, and ensure feature parity with the old version.
Missing things:

Actual MethodChannel implementations for most of the functionality; for now:

00:01 +9 -23: Firestore Query document pagination FieldPath assertions [E]
  UnimplementedError: DocumentReferencePlatform::get() is not implemented
  package:cloud_firestore_platform_interface/src/interfaces/document_reference_platform.dart 59:5  DocumentReferencePlatform.get
  package:cloud_firestore/src/document_reference.dart 77:90                                        DocumentReference.get
  cloud_firestore_test.dart 1113:67                                                                main.<fn>.<fn>.<fn>

00:02 +23 -23: Some tests failed.
Tests in the cloud_firestore_platform_interface package.
Document all public members
Actual dartfmt and flutter analyze

Related Issues

https://github.com/flutter/flutter/issues/45293

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Some more tests are passing now; after adding the Transaction implementation:
00:01 +27 -19: Some tests failed.

00:02 +36 -10: Some tests failed.

Added DocumentReference implementation.
00:01 +46: All tests passed!

(Currently fixing dartfmt and analyzer)

(Closing in favor of https://github.com/FirebaseExtended/flutterfire/pull/1670)


[GURPS] 2.7.6

Changes / Comments

Updated the hover names for macro help to show the correct usage of the macro. Example change Macro: @{hit_points_max} or Macro: @{NAME|hit_points_max}
Bio\Misc Tab. Apply Size Modifier checkbox. The apply modifier now works with Hit Points, Striking ST, and Lifting ST.
Added some additional feedback by updating the tooltips for points per level and warning notes if you didn't spend the correct amount.
Reported and suggested by Niccy.
GCA4 Import Bugfix. If an advantage has a melee or ranged attack with NO skill level (like the Leech advantage), this breaks the import.
Added a method to handle that case. Reported by Lloyd J.
Huge thanks to Paulo for providing the Portuguese translations and contributing several bugfixes and updates to the character sheet.
Other Languages currently being translated are French and Russian, huge thanks to our volunteer!

Files Changed

GURPS\gurps.html
GURPS\gurps.css
GURPS\translation.json

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[x] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Platform.WriteFile adds extra \0 character on Windows

Description
When I use StereoKit's Platform.WriteFile to write a file to the filesystem, the resulting file ends up getting an extra \0 character appended.
Here's the code to reproduce the issue:
using StereoKit;
using System;
using System.IO;

// Initialize StereoKit
SKSettings settings = new SKSettings
{
    appName = "FileEndsInNull",
    assetsFolder = "Assets",
};
if (!SK.Initialize(settings))
    Environment.Exit(1);

// Create assets used by the app
Pose cubePose = new Pose(0, 0, -0.5f, Quat.Identity);
Model cube = Model.FromMesh(
    Mesh.GenerateRoundedCube(Vec3.One * 0.1f, 0.02f),
    Default.MaterialUI);

File.WriteAllText("system-written.txt", "Hello World!");
Platform.WriteFile("platform-written.txt", "Hello World!");

// Core application loop
while (SK.Step(() =>
{
    UI.Handle("Cube", ref cubePose, cube.Bounds);
    cube.Draw(cubePose.ToMatrix());
})) ;
SK.Shutdown();

When I open both of the files (system-written.txt and platform-written.txt) created from the demo code above, I find that one of the files has an extra '\0' character.

Platform / Environment

Windows 11
Flatscreen simulator
C#
Using the latest StereoKit .NET Core template
StereoKit 0.3.6 and 0.3.7-preview.4

Also
It looks like this behavior changed from v0.3.5 => v0.3.6. SK 0.3.5 didn't have the appened \0

Thanks for pointing this out! Just put in a fix for it, should work a lot better now when the next build goes out :)

Awesome thanks!

This is now in v0.3.7-preview.5!


ansible: build-packet-ubuntu1604-armv8-2 permission error

From the latest ansible run:
`fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "Command failed rc=1, out=, err=hostname: you must be root to change the host name\n"}

That error message was from the wrong line, and the machine is executing the playbook successfully now, therefore closing


Local build broken

I've cloned the latest version (85.0.4183.83) and attempt a local build as described here:
https://github.com/adieuadieu/serverless-chrome/blob/master/docs/chrome.md#locally
but sudo docker build   -t "headless-chromium:$CHROMIUM_VERSION"   --build-arg VERSION="$CHROMIUM_VERSION"   "build" is aborted with:
[0:30:37] Still working on:
[0:30:37]   src/third_party/angle/third_party/VK-GL-CTS/src
________ running 'vpython src/build/landmines.py' in '/build/chromium'
Hook 'vpython src/build/landmines.py' took 82.88 secs
________ running 'vpython src/third_party/depot_tools/update_depot_tools_toggle.py --disable' in '/build/chromium'
________ running 'vpython src/tools/remove_stale_pyc_files.py src/android_webview/tools src/build/android src/gpu/gles2_conform_support src/infra src/ppapi src/printing src/third_party/blink/renderer/build/scripts src/third_party/blink/tools src/third_party/catapult src/tools' in '/build/chromium'
________ running 'vpython src/buildtools/ensure_gn_version.py git_revision:7d7e8deea36d126397bda2cf924682504271f0e1' in '/build/chromium'
`/build/chromium/src/buildtools/linux64/gn --version` returned 1:
/build/chromium/src/buildtools/linux64/gn: /lib64/libc.so.6: version `GLIBC_2.18' not found (required by /build/chromium/src/buildtools/linux64/gn)

WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be created.
use_relative_hooks is deprecated, please remove it from DEPS. (it was merged in use_relative_paths)
use_relative_hooks is deprecated, please remove it from DEPS. (it was merged in use_relative_paths)
Error: Command 'vpython src/buildtools/ensure_gn_version.py git_revision:7d7e8deea36d126397bda2cf924682504271f0e1' returned non-zero exit status 1 in /build/chromium
The command '/bin/sh -c sh /build.sh' returned a non-zero code: 2

It shouldn't matter since I'm building with docker but for what it's worth my OS is Ubuntu 18.04.

I found a similar issue trying to build just the headless chrome from the build/build.sh script; there were several executables called gn available in other directories, just not in the path the build script expected.  I used packages/lambda/builds/chromium/build/src/buildtools/linux64/gn and it appeared to work. This was in AWS Linux 2.

Hi @timo-a this should be fixed now, over the last few months I noticed that every few months Chromium would update is GLIBC requirement and a newer version of the amazonlinux AMI would be required in order to build it, as older AMI releases did not have the newer GLIBC library.


Fix --config resolving

Stricter CLI exposes the -c and --config flags, similar to ESLint, however they weren't functional.
The default behaviour of not specifying a config path correctly finds the root config, but when specifying a path it'd throw an error claiming to not find the file.
Additionally, fixes an import to fix allow opting into the debug logger.
const logger = isCi ? getNullLogger() : getDebugLogger();

What's the process for contributing, versioning, and publishing now that this is open source? I don't see a guide in the README.md.

TravisCI is configured to publish a new version once it finds a new tag (see https://github.com/atlassian/stricter/blob/master/.travis.yml#L20-L21).
I.e. you merge the changes into master, update the version in package.json and add a changelog. After that you create and push a new tag. Once it lands, TravisCI will deploy a new version automatically.

@Li0liQ You better not rotate your npm keys then, or did you use an Atlassian bot user for publishing?


Fix wrong example in the help

The p is necessary for position, the v is not a valid option. And since v will be discarded, and position is not specified, the application will just exit.

Awesome, thanks tangogu! I'm just about to do another pass on this so I'll accept you changes then get it integrated on our side. =) Cheers!


Alpha.7 sending embed/message to TextChannel

General Troubleshooting

[x] I have checked for similar issues.
[x] I have updated to the [latest JDA version][download].
[x] I have checked the branches or the maintainers' PRs for upcoming bug fixes.

Bug Report
When you send a message/embed to a text channel it occurs.
Expected Behavior
the message should be send successfully.
Code Example or Reproduction Steps
textChannel.sendMessage('').queue(); that's it.
Code for JDABuilder or DefaultShardManagerBuilder Used
a simple jda builder, nothing different from old version i used.
Exception or Error
[JDA RateLimit-Worker 2] ERROR net.dv8tion.jda.internal.requests.Requester - There was an unexpected error while executing a REST request
java.lang.ClassCastException: class net.dv8tion.jda.internal.entities.TextChannelImpl cannot be cast to class net.dv8tion.jda.internal.entities.PrivateChannelImpl (net.
dv8tion.jda.internal.entities.TextChannelImpl and net.dv8tion.jda.internal.entities.PrivateChannelImpl are in unnamed module of loader 'app')
        at net.dv8tion.jda.internal.entities.EntityBuilder.createMessage(EntityBuilder.java:1369)
        at net.dv8tion.jda.internal.requests.restaction.MessageActionImpl.handleSuccess(MessageActionImpl.java:616)
        at net.dv8tion.jda.internal.requests.RestActionImpl.handleResponse(RestActionImpl.java:268)
        at net.dv8tion.jda.api.requests.Request.handleResponse(Request.java:259)
        at net.dv8tion.jda.internal.requests.Requester.execute(Requester.java:237)
        at net.dv8tion.jda.internal.requests.Requester.execute(Requester.java:141)
        at net.dv8tion.jda.internal.requests.Requester.execute(Requester.java:124)
        at net.dv8tion.jda.internal.requests.ratelimit.BotRateLimiter$Bucket.run(BotRateLimiter.java:478)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)

https://github.com/DV8FromTheWorld/JDA/commit/ac3104d3b0706e3f48c2da1c7094642174b72880 this change made this bug.

probably #2039 will fix this issue.


[Element] Random Instance Input Event doesnt saved managed instances list

Describe the bug
Selecting instances in Manage Instances List doesnt save to the element, shown when opening the menu again.
To Reproduce
Steps to reproduce the behavior:

Add random_instance_input_event element to the map
Select it and open the Manage Instances List(instances) window
Select instances in your level
Exit window
Open window and see the instances are deselected

Fixed #553


Support for official Rails 6 Release

Thanks so much for this wonderful gem.
It looks like this isn't compatible with Rails 6 official that was released yesterday:
spec.add_dependency 'activerecord', '>= 3.2', '< 6'
Is this intentional? I've been running it with the RC1/RC2 releases without issue.

Hi @stephendolan, thank you for kind words!
I'll fix this today 👍

I just released a new version 0.7.4. It should support Rails 6. Try it and if it doesn't help let me know, please.  Have a great time 👍


breaking openai library update in 09-building-image-applications

Describe the bug
There are some breaking changes in openai library between version 0.28.x and version 1.x.
In sample 09-building-image-applications the requirements.txt does not specify any version.
Using pip pulls the most recent openai library (aka some 1.x version)
However the python code is still on version 0.28.x which results in invalid code.
The pull request fixes the python code and documentation:

rename of openai.error.InvalidRequestError into openai.InvalidRequestError

To Reproduce
Steps to reproduce the behavior:

sample 09-building-image-applications
install python libraries via pip
open python files, shows invalid code

Expected behavior
Code, documentation and libraries shall be in sync.

Thanks for the fix @bmerkle , in review!


With WebGL, adding child text to button renders text to other buttons

Creating multiple Phaser.Buttons and giving them Phaser.Text children will result in both the buttons and children to be rendered and subsequent labels to be rendered on previously created buttons.
This problem is only reproducible when using WebGL (and not Canvas) as Phaser's renderer.
This bug is seen as a regression between 2.4.3 and 2.4.4 (introduced by 99751a5).
Example code:
http://phaser.io/sandbox/rscQDbmR
function create()
{
    var buttonStyle = { font: "32px Arial", fill: "#ffffff" };

    var button1 = game.add.button( 0, 0 );
    var buttonLabel1 = game.make.text( 0, 0, "Button1", buttonStyle );
    button1.addChild( buttonLabel1 );

    var button2 = game.add.button( 0, 32 );
    var buttonLabel2 = game.make.text( 64, 256, "Button2", buttonStyle );
    button2.addChild( buttonLabel2 );

    var button3 = game.add.button( 0, 64 );

    game.add.tween( button2.position ).to( { x: 256 }, 2500, Phaser.Easing.Linear.None, true );
    //game.add.tween( buttonLabel2.position ).to( { y: 128 }, 1500, Phaser.Easing.Linear.None, true );
}

99751a5 says something about a new PIXI BaseTexture skipRender member. I don't really understand it or its need here, but unsetting it on buttons does seem to do the job:
button1.texture.baseTexture.skipRender = false;
Maybe there can be a little clarification before this issue is closed?

It's because the Buttons don't have any textures, so they're given the __default texture which the WebGL renderer is told to ignore (because it's breaks sprite batching and is a waste of draw calls).
I guess the reason we didn't spot this in testing is because all the Button examples use a texture for the button.
I think we ought to harden-up the skipRender check, so it's only enabled if the texture is using the default blank image AND has no children. It's not as guaranteed to be accurate (because the children may not render either), but it would catch cases like this.

This is now fixed in the dev branch. Please pull and have a test (you'll need to build, I only updated the source). Your example code above works fine now though.

Fix works as expected.


mini.files: Allow to open mini.files with terminal buffer

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.files
Description
When opening mini.files with a terminal buffer, one gets the following error message:
E5108: Error executing lua (mini.files) `path` is not a valid path ("/<somePath>/Terminal 1")
stack traceback:
        [C]: in function 'error'
        ...023/.local/share/nvim/lazy/mini.files/lua/mini/files.lua:2642: in function 'error'
        ...023/.local/share/nvim/lazy/mini.files/lua/mini/files.lua:708: in function 'open'
        [string ":lua"]:1: in main chunk
E21: Cannot make changes, 'modifiable' is off

MiniFiles.open(vim.api.nvim_buf_get_name(0)) -- currently a terminal buffer

Suggestion:
Open the current working directory instead (vim.fn.getcwd()).
Thanks, @echasnovski !
Neovim version
0.10.1
Steps to reproduce

:term
:lua MiniFiles.open(vim.api.nvim_buf_get_name(0))

Expected behavior
Opens vim.fn.getcwd() instead.
Actual behavior
Throws error
E5108: Error executing lua (mini.files) `path` is not a valid path ("/<somePath>/Terminal 1")

Thanks for the suggestion!
This works as expected because open() is called not with existing directory path. To open explorer in current directory, use either one of:

MiniFiles.open().
MiniFiles.open(vim.fn.getcwd()).
Custom wrapper that checks if the the buffer is for the file and acts accordingly:_G.open_smart = function()
  local buf_name = vim.api.nvim_buf_get_name(0)
  local path = vim.fn.filereadable(buf_name) == 1 and buf_name or vim.fn.getcwd()
  add_to_log(path)
  MiniFiles.open(path)
end

Thank you, @echasnovski !


Use proper types from <sys/types.h> in struct definition

I noticed a few places where int types are used when standard system typedefs are available which would be more appropriate.
Examples.

fields pid, ppid in struct Process. Should be pid_t instead of "unsigned int".
field uid etc - Should be uid_t.
field create_time - Should be time_t (I think).

Most of these are available in <sys/types.h> and we should use them wherever possible.

I took care of pid_t type fields in the last refactor (https://github.com/nibrahim/cpslib/commit/ad7964a8b3c834f367cc9423a1d2b261f4935f54).


Fix for missing CRD error message

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1226
Special notes for your reviewer:
Release note:

/release-note-none

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
e854d9b72c8439794e822d2401ee918a80457ebb
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


about the question  i don't understand when i see the torials

Sounds like Indexer nodes are optional, and you can ingest using Realtime nodes directly?
Indexer node how to HA?
Without using Indexer, the Realtime nodes are not HA?
If using Indexer then you don't need Realtime nodes?

Please drop a mail to druid-user group for any general questions.
https://groups.google.com/forum/#!forum/druid-user
Github Issues are meant for bugs and feature requests.


Bad user experience from tooltip of shapes.

I was working with Excalidraw and hovered over the horizontal stack that has different shapes to select. As we know it's inconvenient to reach out to the shape to select it, I looked for the key combinations.
The shortcut keys for selecting a rectangle shape is 'R' or '2'. The issue here is that it only works for 'r' or '2'. If I hit 'r' with caps lock on, the shape will not be selected. I assumed from the tooltip that it should work with 'R' which it is not.

I think this could be a bad user experience?

I'd love to contribute if this adds a value to the project. Thanks!

Should work with upper case letters as well I would say :)
Sure.. go for it.

Actually, I don't think so. It'll preclude using Shift+<key> shortcuts.

Thanks @dwelle, it makes sense. We definitely don't want to preclude Shift+<key> shortcuts. However, if the user has their capslock turned on then pressing P key will not work.
It will be just a better UX to check if the capslock is turned on when P is pressed as the keyCode for P is the same for caps locks on and off. Here, I am assuming there are not any plans to add CapsLock + <key> shortcuts in excalidraw.

Mhm... I've done some testing and it seems CapsLock can be detected after all, and the event only differs in key prop AFAIK. So I made a quick hack: https://github.com/excalidraw/excalidraw/pull/2373


Add story for disabled focused Button (without fix)

In Firefox, clicking the first button does not make it appear disabled; only a second click will do that (it can be a click in the exact same place).

Tests behavior without #584 (see #585 for behavior with fix).

Decision in Mattermost was to not merge the story.


KazooRetry: Do uniform jitter over the whole backoff interval

The previous implementation would add a fixed amount of jitter around
the calculated back-off time. Retry attempts were thus clustered
around the exponentially spaced backoff points.
This patch does exponential backoff but uniformly spreads the retries
over an interval [0, backoff**attempt]
The following graphs show the connection rate/s when trying to open 20k new connections
to ZK. Each client was configured with, backoff=2, delay=10 and max_delay=180. The ZK in question is rate-limited and that explains the ceiling you see on the second graph.
Old Jitter
The connections attempts come in herds after the current delay interval has passed.
After over 30mins only about 10k connections had been established and that is where I cut-off the graph.

Uniform Jitter
The connection attempts reach the rate-limit then after 8 minutes the connection rate
falls below the limit and the remaining clients connect over a period of 5 mins. The whole
process takes 13 minutes.

I've changed the commit message so it should pass the commit message guidelines.

Awesome, merged! Thank you @andreasgudmundsson again for demonstrating with those graphs

Thanks for merging the request @jeffwidman. Do you have plans for making a new release?

Do you have plans for making a new release?

There's a couple of submitted PR's that I'm waiting on the owners to rebase/address minor review points and it'd be nice to land those first. So I'll wait a week, and then I'm traveling the following week for work, so probably the week after (3 weeks from now) I'd be willing to cut a release because that way if there's a bug in one of the recently submitted PRs, I'll have the time to merge a fix and cut a second bugfix release. If I forget, please ping me on here.

If I forget, please ping me on here.

Ping

Hi @andreasgudmundsson , the 2.6.0 release of Kazoo is now live!


HipGraph support

This PR adds HipGraph support.
With graph:
ran model in 3.23 ms
total 5.25 ms

Without graph:
ran model in 17.38 ms
total 18.95 ms

HIPGraph works only for a single device for now.

I am not really sure about NOSTAT envvar. The reason it's added is op_estimate = sym_infer(self.op_estimate, var_vals) which takes ~1ms each step. I think we would like have an option to disable this, since it takes a lot of time. Should we have something like NOSTAT?

With jit cache it's about ran model in 3.23 ms. sym_infer for global_size/local_size is still a bit expensive. I think this change might be reasonable, since we already have jit_ctx.

Btw not sure about NOSTAT envvar. op_estimate = sym_infer(self.op_estimate, var_vals)  takes some time to calculate (0.5ms for each gpt-2 step) while I think not really needed in all cases.

Similar to CachedAllocator, this is quite complex looking. Can the hooks into the JIT be simpler?

I think now it should be better after small refactor. Also speed is a bit better.
Tested quantised llama on 7900xtx, it's also faster 59.73 tok/sec vs 40.37 tok/sec.

I think instead of having this be different cases in the JIT, the JIT should always used a BasicBatchExecutor (which just calls the kernels sequentially). This way this codepath is tested.

The current timings are ran model in 2.43 ms total 7.49 ms. I am going to leave this PR functionality as it is (unless other review comments), cuz it's already big to review.
I am going to refactor JIT a bit in the next PR to enable parallel execution cpu+gpu (send some amount of commands to the gpu while cpu updating others params of following cuda/hipgraph). I have a patch which splits jit execution into batches (sizes of the batches are logarithmic 4,8,16,32...), so both cpu and accel are loaded. This gives ran model in 2.39 ms total 5.61 ms. Regular jit executions (not cuda/hipgraph) should also benefit from this change, but not perf diff is not that huge.

Nice! BatchExecutor is a good abstraction


Fix post-commit hook not working for private repos

We were failing to build the repo when a user has git@github.com:user/repo as the repo, but we’re matching against github.com/user/repo in the post-commit hook. This fixes to the webhook to support both SSH & HTTP style URL's.

Looks good. Will address regex URL in #2128


Option to show hidden files but still respect .gitignore

It'll be great if we have this option to include hidden files (like .babelrc) while respecting .gitignore (or other cvs ignore rules).

NVM. It works already.


plugin crashes/dosent work in the latest arch release 0.27.2

toggle group isn't grouping as it should group.
attached this video on how it isn't working
https://litter.catbox.moe/1sfj6h.mp4
crashes when ungrouping

coredumpctl --> https://paste.rs/duCaY
hyprland crash log --> https://paste.rs/ijaVU, https://paste.rs/mzDpU

hyprctl version -->
Hyprland, built from branch  at commit b08b72358ad549fd066e5be0fc3aa4c9df367607 dirty ().
Tag: v0.27.2

flags: (if any)

ps : This time I recompiled the plugin against the corresponding hyprland release.

Hey, thanks for reporting this, I have also encountered an issue on v0.27.2, though for some reason it was slightly different to what you reported, and I haven't experienced any hard crashes, for me I only noticed that when I grouped 2 windows, moving the cursor to where the child window (that should now be groupped under the parent) was somehow shown that window through the group.
I haven't yet had the time to investigate this further, but I will give it a look later today, or some time tomorrow.

Hey thanks for the prompt response!.
now I changed to the latest hyprland-git version it seems to be working again albeit with graphical gliches like this.

Also there hasn't anymore hard crashes after switching to the git branch but it works weirdly and sometimes clients refuse to be grouped tab.
hyprctl version :
Hyprland, built from branch main at commit 375e8385eeabbcdae197e392394849e2cbb6f3ed dirty (Fix background occlusion ignoring monitor position (2771)).
Tag: v0.27.2-32-g375e8385

flags: (if any)

Thanks again for looking into this

Yeah, that glitch is the issue I was talkig about. When you hover over the right side, the window actually shows up event though it's supposed to be in a group.
I already did a bisect and found the hyprland commit that caused this, but I'm not home rn so I'll look into writing up a fix in later when I get back.
Btw, the reason the plugin worked without recompilation is essentially a mirracle. The Hyprland ABI is not stable, and can't be relied on, if nothing changes in the files we're using, then it generally works, but any change to compilation arguments, or compiling with different tool, or indeed a change in the original source could cause really weird problems which are almost impossible to debug, so recompiling is crucial every time, don't just trust that nothing will go wrong.
You could probably set up a pacman hook if you're forgetting, that could auto recompile after hyprland gets updated.

Should be fixed in https://github.com/ItsDrike/hyprland-dwindle-autogroup/commit/c1c883a237c58b8736f1f46f383490f0621b136c

Hey Thanks for the quick fix! . Now its working great with the latest git , now being snappier than before.
Although there is a niche nitpick that the group title bar disappear when a client is moved inside (the moved client's titlebar only) the tab. This behavior isn't observed when moving an already tabbed client into another tabbed client.Maybe this is a hyprland issue or on how the title-bars displayed using the default behavior.
attached recording for reference.

https://github.com/ItsDrike/hyprland-dwindle-autogroup/assets/87846149/fce2aa5b-5edb-491a-825b-760c2a20757a

Fixed in c38652c

Dude that was fast 🫡 can't thank you enough.
closing the issue as the plugin is working perfectly as intended


docs: update readme with app provider links

Updating the readme to provide links to Polaris and App Bridge providers.
This PR also serves to kick off changelog and version release automation.
In theory, once this PR is merged the patch version will be bumped. And the release process can be started.

https://github.com/Shopify/core-issues/issues/40727


Announce 4.56

Announcement ready, fun with mac builds due to homebrew change.

Squashed as 03a190470b0e09cfcf94420a272974f6f8d1b324


dynamically linked build

The old build system dynamically linked debug builds by default. We can't currently easily do this with bazel.
I would like the ability to specify desired linking type when building because a dynamically linked build is far more flexible a thing in the development cycle -- primarily because of what's possible with LD_PRELOAD -- load a profiler, load an alternative implementation of a library (e.g. malloc) and compare its results to previous, etc.
I imagine this will require making the arg to the linkstatic params in many of our cc_librarys configurable rather than statically True. Need to also understand instances of:
    features = select({
        "@platforms//os:linux": ["fully_static_link"],
        "//conditions:default": [],
    }),

It may be easier to avoid bazel altogether and just adopt the old Makefile vere used to the new repo structure

I have a CMake configuration almost working...


adding sstults to CODEOWNERS

Description
Completing adding @sstults as a maintainer. CODEOWNERS must be updated with the MAINTAINERS.md file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-project/admin can you please give @sstults the permissions to maintain this repo?

@opensearch-project/admin can you please give @sstults the permissions to maintain this repo?

Hi @macohen
Can you confirm we have required votes and 0 vetos from current maintainers?
Thanks!

@gaiksaya, I can confirm that on behalf of myself and @gsingers. Thanks!

Checking with OSPO on new guidelines for adding external maintainers.

@sstults has been added as maintainer, pending acceptance from him.

@sstults once you accept the invite from github as a maintainer on the repo, the CODEOWNERS file check will update so I can merge this PR and that will complete the process of making you a maintainer. Thanks!

Thank you @macohen I just did it.


workflow: only re-generate the manifests if any of the inputs changed

RISK - we would lose the ability to detect accidental output changes if ossbuild-mpp changes or any of the python modules that are included by this.

This is not needed anymore, we are done to 6min for this job so let's keep running it.


Arm Controller

Current problems with the arm controller: joint1 angle > 180 radians, taking slow paths to coordinates (fixable by changing angles by 90 degrees).


Nothing happens when I try to use the Default field in a customized IDocumentFilter

Hey guys,
I'm trying to generate a custom IDocumentFilter for one operation that I have. When I map a path parameter using PartialSchema it works fine, but when I try to use the BodyParameter with Schema = new Schema { Type = "string", Default = "test" } is not rendering when going to the Swagger UI.
Just wanted to know if this is a issue or to accomplish this I need to make in a different way.
Best regards,
Furlan.

For better clarification:
new NonBodyParameter // THIS WORKS
{
   Default = "test",
   Name = "test1",
   Type = "string",
   In = "path"
},
new BodyParameter // THIS ONE DOESN'T WORK
{
    Schema = new Schema { Type = "string", Default = "test" },
    Name = "test2",
    In = "formData"
}

This code generates what you see in the image above:

@furlanrapha BodyParameter have to be in "body", not in "formData".

Thanks @Igmat!
You are correct, I used the wrong In type.


[BUG] - Unable to Use CLI Flags in Dictu Program

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Arguments to dictu programs are successfully passed into the System.argv value however if an argument is a flag, dictu short circuits and produced the output below.
➜  tmp ./program.du -f
error: unknown option `-f`
Usage: dictu [options] [[--] args]
   or: dictu [options]

    -h, --help        Show this help message and exit
    -v, --version     Display Dictu version
    -c, --cmd=<str>   Run program passed in as string

Expected Behavior
No response
Steps To Reproduce
Write a dictu program and execute it with a flag.
Anything else?
No response

Thanks for this!


Support for downloading pre-signed URL for jdbc driver in case of AKS

AKS cluster uses S3 bucket to host JDBC driver jars for mssql as they are not publicly downloadable unlike postgres jars.
As part of this change, we want to add support to download pre signed url's.

Resolved with #116


pull request for e2e test at 11/16/2016 17:26:03

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Idea: Use Variable in "VRM Site ID"

May thers a possibility to also use a Variable into VRM Site ID like {{flow.siteID}}? I often copy Boards from one to another Dashboard. So if i can set a global Variable i have to set it only once:-)

Nice idea! I've added it to the code and created a new release.

Thanks!!!!


Create a new pull request by comparing changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 94.673%

Files with Coverage Reduction
New Missed Lines
%

js/src/offcanvas.js
2
94.63%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1963

Relevant Lines:
2027

💛  - Coveralls


Missing Project webhook types

During my attempt to implement automated project webhooks management, I discovered that some of the events are missing in the file:
    [PublicAPI]
    public enum EventType
    {
        [Description("file.translated")]        FileTranslated,
        [Description("file.approved")]        FileApproved,
        [Description("project.translated")]        ProjectTranslated,
        [Description("project.approved")]        ProjectApproved,
        [Description("translation.updated")]        TranslationUpdated,
        [Description("string.added")]        StringAdded,
        [Description("string.updated")]        StringUpdated,
        [Description("string.deleted")]        StringDeleted,
        [Description("suggestion.added")]        SuggestionAdded,
        [Description("suggestion.updated")]        SuggestionUpdated,
        [Description("suggestion.deleted")]        SuggestionDeleted,
        [Description("suggestion.approved")]        SuggestionApproved,
        [Description("suggestion.disapproved")]        SuggestionDisapproved
    }

The missing ones are for instance: file.added or file.updated.
Is there a particular reason why they were not included in the client?

Hi @PatrykPlewaOfficial, thanks for reporting this!
probably some mistake has occurred, there is no reason not to include these types here.
Would you like to raise a PR?

@PatrykPlewaOfficial thank you!

Came up with #121.
Please verify the spelling because it's super easy to make a mistake 😃


sse.before_request not working

Hi, I've imported default blueprint sse from flask_sse
after

@sse.before_request
def check_access():
    if request.args.get("channel") == "analytics" and not g.user.is_admin():
        abort(403)

Running the app with flask and accessing URL at http://localhost:5000/events sse.before request will not be run, don't know why. I've checked with debugger.
Has this something to do with flask:see or with blueprints in general?

This is related to blueprints in general. See the API documentation for Blueprint.before_request.

@singingwolfboy I understand, but before closing.
I found this workaround:
@app.before_request
def before_request():
    if request.path == "/events":
        if current_user.is_anonymous:
            abort(403)

But of course is not optimal, because I want a before_app event triggered only for sse non for the entire flask app.
Btw: app.before_request of course works as expected!

I'm gonna close it now,
very stupid mistake (not well explained in the doc.
Need to put @see.before_request and every other changes BEFORE registering to the flask app
Example:
@sse.before_request
def check_access():
    if request.args.get("channel") == "analytics" and not g.user.is_admin():
        abort(403)

app.register_blueprint(sse, url_prefix="/events")

Thanks btw for the hint @singingwolfboy


What's the DB type (in-memory or SQLite) used in the experiments of VLDB publication

Dear authors of ResilientDB,
Your VLDB publication ResilientDB: Global Scale Resilient Blockchain Fabric was an excellent one, and I really appreciate that your team kindly open source this great work.
Sorry about spamming the issues of this repo, but may I know which DB (in_memory_db or Sqlite) was used in the experiments of the paper?
Thanks!

We used in_memory db for the paper.


Create IG route for Domestic standing order

Description

[ ] Create Route on Ig routes project openbanking-demo routes
[ ] Create if necessary specific groovy script to implement on IG the domestic standing orders payments.
[ ] Methods to support: GET, POST

Endpoints

Endpoints

Acceptance criteria

[ ] The route is deployed in Ig with no errors.
[ ] Proper response expected by the spec
[ ] Errors expected match with the OBIE specs
[ ] Route documented

[ ] Route source commented
[ ] Add the route documentation to the wiki route section

Hey team! Please add your planning poker estimate with ZenHub @andra-racovita @mariantiris


Rails5

Hey!
Here 2 helpers for the console:

As you know, before_filter is deprecated in rails 5. So, deprecation appeared on every console start;
I'm not sure about what the hell view_context is, but with it in the console block I receive an exception. After removing it all working as planned. I tested few decorators, all is working well.

Watching this PR.


Does OpenSSL use invalid CRLs to revoke certificates？

I created two CRLs [test1.crl, test2.crl] and a certificate chain revoked by these CRLs. When “last update” of test1.crl is later or “next update” of test2.crl is earlier than current time, the verification results of OpenSSL 1.1.1d are “CRL is not valid” and “certificate revoked”. I wonder if OpenSSL uses these invalid CRLs to revoke certificates?
Thank you for your answer.
The command I used:
openssl verify -show_chain -CAfile root.pem -CRLfile test1.crl -crl_check_all leaf.pem

and
openssl verify -show_chain -CAfile root.pem -CRLfile test2.crl -crl_check_all leaf.pem

Results:
test1.crl:
C = GB, ST = Berkshire, L = Newbury, O = My Company Ltd
error 11 at 0 depth lookup: CRL is not yet valid
C = GB, ST = Berkshire, L = Newbury, O = My Company Ltd
error 23 at 0 depth lookup: certificate revoked
error leaf.pem: verification failed

test2.crl:
C = GB, ST = Berkshire, L = Newbury, O = My Company Ltd
error 12 at 0 depth lookup: CRL has expired
C = GB, ST = Berkshire, L = Newbury, O = My Company Ltd
error 23 at 0 depth lookup: certificate revoked
error leaf.pem: verification failed

The files I used:
root.pem:
-----BEGIN CERTIFICATE-----
MIIDNDCCAhygAwIBAgIJAPU0AU3ad04vMA0GCSqGSIb3DQEBCwUAMEcxCzAJBgNV
BAYTAkNOMQswCQYDVQQIDAJTSDENMAsGA1UECgwEU0pUVTENMAsGA1UECwwERERT
VDENMAsGA1UEAwwETkNSTDAeFw0yMDAzMjYwODI3NDlaFw0yMzAxMTQwODI3NDla
MEcxCzAJBgNVBAYTAkNOMQswCQYDVQQIDAJTSDENMAsGA1UECgwEU0pUVTENMAsG
A1UECwwERERTVDENMAsGA1UEAwwETkNSTDCCASIwDQYJKoZIhvcNAQEBBQADggEP
ADCCAQoCggEBAPNLlu+KPCcjj1KiZ1/sUFvFRDt3Z7WZTWjOYeJUFvycHNcYN9cE
laGJ32hfjgaPw9u3cOgs0JJHwIhlQkNhSexUvgGatw336H/3FjPQCJKs48lDJG13
sDF7TK1MvG5wcF1pgRkfvoRSWOyr30aqoeQHaRnqMnT0lWBy26mmV6mgM7LPeNq8
E6jh6aLy7uep3+rO/Ef7LvFi/QWqy+vVVmr5MljXtFyWI+aLs4uFtZZ6rFw5Va4U
Y6OffwchjkVex1eML4D593fobkmkubxZEm2o2Upi/Eiech7CM8HuwgqrAwoIVxi6
FlObraD90sUSUKUwohvl03tkjCTXakXF2TUCAwEAAaMjMCEwEgYDVR0TAQH/BAgw
BgEB/wIBAzALBgNVHQ8EBAMCAeYwDQYJKoZIhvcNAQELBQADggEBACb6hOtUCqD5
sH4VucCO4FYFHM6nfBvB9vx+c2RPC/psam9clOvL5llrUhY070pXbZnd2hwxfnzj
cdr448sVyJkHosukzZj/MyEBV9BERTUMOaY4etQxM2L33uyzn5++/NeRC2Yd53AL
vY/s4znat7txqBK/izvLemLerp1Z5E58VFzLOvYNz+7vEoxMmNaU55TGh88VJIvo
THaZ3LflTc7hv9eUWin0LTV0mg7cvM+/qWrM2N2hyOukztF5gCcMEgoVkpEgUCJP
WsrvOumtDNuXnPr80r4N54n5TaQCTBG22Tj89klc6jUji63+UR9KKACCV44KT8hc
+0ecJPmXqEU=
-----END CERTIFICATE-----

leaf.pem:
-----BEGIN CERTIFICATE-----
MIIDITCCAgmgAwIBAgIBATANBgkqhkiG9w0BAQsFADBHMQswCQYDVQQGEwJDTjEL
MAkGA1UECAwCU0gxDTALBgNVBAoMBFNKVFUxDTALBgNVBAsMBEREU1QxDTALBgNV
BAMMBE5DUkwwHhcNOTYwODAxMDAwMDAwWhcNMjAxMjMxMjM1OTU5WjBMMQswCQYD
VQQGEwJHQjESMBAGA1UECBMJQmVya3NoaXJlMRAwDgYDVQQHEwdOZXdidXJ5MRcw
FQYDVQQKEw5NeSBDb21wYW55IEx0ZDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCC
AQoCggEBAL+N0yePi18I/+MxN/31iBehb2rO5s8MzykUz3aGp3BG/5uEFueqoYZN
CNLA38wIUT/ry8wIw+jlTNj29L7Q9uOX8+10XgF4VTVtN14KT0s7tZ5dLjGRD7ft
fZF03ifbGYp39fW2Wjutjo4Jyop+Bm7g6SrSJB3uaioITpZh8Xf7MHo+kNjJKPsu
ZlVVNQ3T5WQWzoskcpRRIujv7U/NATuRzXODUzqnw+HGavu2qTX3falo5i0dzzrt
9yCtLKqtC+0oX+kZPIi3ib/o20fY3hEXwYstq5sKpvV25xgKTbtwRN1KlMIhfSQN
uFXIg/Rd6rbd9P60zPYxzOTwMsaEysECAwEAAaMTMBEwDwYDVR0TAQH/BAUwAwEB
/zANBgkqhkiG9w0BAQsFAAOCAQEAKhf5CQGxsJCzkFJv26ggzi2HxN/X/eXcwJyy
3gfPP0JZNLzRb6bmracLui58LyCX+0tmY5TA1G3V94Vdu2LIUMRoANwKszTxhW/n
8oNvXDji+E62EsivCtoPgYRAwFE0q4flvcWzDwGlqCfEdaG1uqYGLlLxW8gmHdFs
pKJf4yCzQOn04RmReXOhaAtyUT+xp9AUzawzr2PPGA75x7B07HT4ezLPWy+l1X0o
gMBOWm3AwrwTD8k1B488NiKivCYjBn6UPG0r9/gKxSvdEJEJ6SyM8+Jw+f7lij8i
55LYqy8oyPPknQOAWzB+KZkCbqkcBGJLEPR35agBN/SDSdioXA==
-----END CERTIFICATE-----

test1.crl:
-----BEGIN X509 CRL-----
MIIBtjCBnwIBATANBgkqhkiG9w0BAQ4FADBHMQswCQYDVQQGEwJDTjELMAkGA1UE
CAwCU0gxDTALBgNVBAoMBFNKVFUxDTALBgNVBAsMBEREU1QxDTALBgNVBAMMBE5D
UkwXDTIwMDgwNjIwMTU1OVoXDTIxMDIyMjIwMTU1OVowFDASAgEBFw0yMDA0Mjgy
MDE1NTlaoA4wDDAKBgNVHRQEAwIBADANBgkqhkiG9w0BAQ4FAAOCAQEAMp4pWn0h
Vb2qRVP/xP6a18pUhsPu44vcqePDH+aSq3TuapTEQe8N4m2XLhCZVgqjYvNf6NHQ
fLFRgRu8Wn5xTPQqCpUL0R8OzSpfvJTepW+7JyqLnj9FakHmfwVDqvd0Ciefc9WQ
7BU6pCzMq9aX6GCJFTSniSs/29AaZHm/atWIDnAh22bndngV+6fpIBHXmaE4oJXn
rbDM/pNyhEUErg5khX+NNH11XqVUDbpjcunfmoCR1+m588xqZBMkgI4A8xAw7ua8
bqZfyGlSm3gBs7c1ZQwKpj8ccsLcFbqhgOTJji2tNdQjWgkydUss0Xgkz56dkCV7
J1vRmTpKuIHQ/g==
-----END X509 CRL-----

test2.crl:
-----BEGIN X509 CRL-----
MIIBtjCBnwIBATANBgkqhkiG9w0BAQ4FADBHMQswCQYDVQQGEwJDTjELMAkGA1UE
CAwCU0gxDTALBgNVBAoMBFNKVFUxDTALBgNVBAsMBEREU1QxDTALBgNVBAMMBE5D
UkwXDTIwMDExOTIwMTgwM1oXDTIwMDMwOTIwMTgwM1owFDASAgEBFw0yMDA0Mjgy
MDE4MDNaoA4wDDAKBgNVHRQEAwIBADANBgkqhkiG9w0BAQ4FAAOCAQEA4TmIOR52
0fTR7ttw3ZDN0mbPhPNFtpspMhbQjn1zpTuUlK51HWW03AJsNmq0MbYjE7a7pprx
ZpnWGl6evF5auZnC5K7O+17syUbjdzaKC3tHd0dCvYCbaAC/qq6C+BYY8AUMjagk
vKgm/0A5Gs1nht74Y1RxtcqUWSlt0DF48PYRrGZZ9jK2U1+zytmJqpM5lY1zOL1q
mLp/M2I+Zx9YMWXT+15e+AU1p+iEO39tUm8SpzKetV6RZCHYcnvVcfcl4eDMjCe5
s+xVxisk67nnxrQnJubmF19WusYvIMl9KolvdS25LEKAP5MEy8xU0zpaJiVrcgse
DKyLDeNe9LQZLw==
-----END X509 CRL-----

The question would be more interesting when you have two CRLs
and one is expired but the other is not, then the current one should be used,
not the expired one, right?

Didn't you already ask the same question in #11859  ?
Anyway, the fact that no non-expired CRL is available for the CA,
is enough reason to fail the check, it is just an additional information
that the certificate was revoked. but the CRL needs to be valid in any case.
Usually the check fails without looking at the expired certificate at all,
but as you can see, the callback in apps/verify.c ignored the error and continues:
        /*
         * Pretend that some errors are ok, so they don't stop further
         * processing of the certificate chain.  Setting ok = 1 does this.
         * After X509_verify_cert() is done, we verify that there were
         * no actual errors, even if the returned value was positive.
         */
        switch (cert_error) {
        case X509_V_ERR_NO_EXPLICIT_POLICY:
            policies_print(ctx);
            /* fall thru */
        case X509_V_ERR_CERT_HAS_EXPIRED:
            /* Continue even if the leaf is a self signed cert */
        case X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT:
            /* Continue after extension errors too */
        case X509_V_ERR_INVALID_CA:
        case X509_V_ERR_INVALID_NON_CA:
        case X509_V_ERR_PATH_LENGTH_EXCEEDED:
        case X509_V_ERR_INVALID_PURPOSE:
        case X509_V_ERR_CRL_HAS_EXPIRED:
        case X509_V_ERR_CRL_NOT_YET_VALID:
        case X509_V_ERR_UNHANDLED_CRITICAL_EXTENSION:
            ok = 1;
        }

        return ok;

That is done for better information of the user.

I don't believe OpenSSL looks at the reason, so once a certificate is on a CRL, it is "sticky" and the cert is revoked.  If an "expired" CRL says "cert-a was revoked" then it doesn't matter if any other CRL is examined.

Marking as inactive, to be closed at the end of 3.4 dev, barring further input


Prompts in vectorstore?

If I use a vectorstore for RAG already, and I have a lot of prompts/templates, it's compelling to treat the retrieval of the most suitable system prompt or prompt template like RAG.
Is this something that's easy to set up with prompt Poet?

A potential approach:

I use a vectorstore for RAG already... I have a lot of prompts/templates
As long as the prompts do not rely on interpolating runtime data--I would embed these prompts into your vectorstore.

Create a function that retrieves these prompts from vectorstore given any arbitrary runtime data-- ex. get_rag_prompt(user_query, ...).
Create a main prompt template that takes this function and any runtime data you need to pass to the function.
Within the template, invoke this function and bake the retval into (any number of) prompt parts.
main_template.yml.j2: where retval is a string-like object
{% set rag_prompt = get_rag_prompt(user_query) %}
{% if rag_prompt %}
- name: rag_prompt
  content: |
    {{ rag_prompt }}
{% endif %}

main_template.yml.j2: where retval is a list of string-like objects
{% set rag_prompt = get_rag_prompt(user_query) %}
{% for el in rag_prompt %}
- name: rag_prompt_{{ loop.index }}
  content: |
    {{ el }}
{% endif %}

Alternatively, you can embed the entire prompt poet template (yaml + jinja) and retrieve it but I doubt the semantics of the yaml and jinja will work out.
Open to other ideas!


Update to last version of slingshot

closes #141
changes proposed in the pull request:

Update dependencies
Adding react-router-redux for router time-travel support
Hash bundles in production build to support cache busting for JS and CSS. Simplified index.html handling via html-webpack-plugin. Minifying index.HTML in production build

@thetonymaster

Coverage remained the same at 93.333% when pulling bede14b8282c13328bcb65399b0be977b3cbe54a on update-to-last-version-of-slingshot into 0d1a34f06524c7517995dfb394a99d3efffe147a on master.

Coverage remained the same at 93.333% when pulling 5fb3d6774fcf9f0249555922bcb62619e7b518cc on update-to-last-version-of-slingshot into 0d1a34f06524c7517995dfb394a99d3efffe147a on master.

Coverage remained the same at 93.333% when pulling 986465e3c753cb6bdda25be18a483ec69da5545b on update-to-last-version-of-slingshot into 0d1a34f06524c7517995dfb394a99d3efffe147a on master.

Coverage remained the same at 93.333% when pulling c6da7b9b0c7c720fa2d41724c551ad27d0215fe4 on update-to-last-version-of-slingshot into 0d1a34f06524c7517995dfb394a99d3efffe147a on master.


Optimize Spark History Server for loading large number of applications on startup

EventLogFileReader object is created in multiple forms. While loading initially, it is given FileStatus which is being ignored and recomputing the FileStatus. This recomputation turned out to be very expensive when we were attempting to load 260k+ applications on startup.
Modified the code to use FileStatus if it is provided directly. If not, then compute it from the given path.

👀 @catalinii @rohit-menon @akhurana001 #compute-data-platform

Can we add any tests?

@rohit-menon It was not a functional issue but a regression failure on a large number of applications. The current test-suite looks pretty comprehensive for functionality tests: https://github.com/lyft/spark/blob/lyft/3.0/core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala. Let me know if you have any ideas to add a regression test

🚀

🚀

💨

💨

@s-pedamallu you need to merge this in master

@s-pedamallu you need to merge this in master


(promote) release: build v5.4.5099

Test plan: automated release PR, CI will perform additional checks

:green_circle: Release has been promoted, see tag: https://github.com/sourcegraph/deploy-sourcegraph-k8s/tree/v5.4.5099.
:no_entry: Do not under any circumstance delete the branch holding the tagged commit (i.e. release-v5.4.5099).
:arrow_right: You can safely close that PR and delete its a associated branch.


Add original width and height

We need to have the original width and height of the image, and it seems to be impossible to get this information from the library without reloading the original image as an image. This is a big overhead, because you can also extract this information from within the lib.
I added two lines that append the width and height to the file object, is this the best place to put it?

Thanks for your contribution, @l-hendriks.
Adding the properties to the file object would not be the ideal location.
I've pushed a new version that provides the original image width+height in the callback data.
Since the callback data wasn't well documented, I've also updated the README.

Hi Sebastian,
Thanks for that! I agree the location is not be ideal, but I didn't want to change too much on the library. Have a nice weekend!

Thanks @l-hendriks ☺


feat(react): export react component types

This PR adds support to use React components both as value and type.
Example usage:
import { BlDialog } from "@trendyol/baklava/dist/baklava-react";

const Component = () => {
  const dialogRef = React.useRef<BlDialog>(null);

  return (
    <BlDialog ref={dialogRef}>...</BlDialog>
  )
}

Fixes #307

Do you see any risk of this change to break current React implementations?

Do you see any risk of this change to break current React implementations?

No, it only brings type support which was previously inferred as any. There shouldn't be any breaking change.


Add IOUringDatagramChannel and so also support UDP

Motivation:
We can also support UDP / Datagram based on io_uring, so we should do it
for maximal performance
Modifications:

Add IOUringDatagramChannel
Add tests based on our transport testsuite for it

Result:
UDP / Datagram is supported via io_uring as well now

Any comments for this one ?


Refactor code to support multiple project type

Resolves: https://github.com/python-poetry/roadmap/issues/3

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

I am going to close this one, since you have created another PR on the same topic


replace caddr_t with char*

to fix issue 1447
Not sure what else is needed for this PR (my first on public github :P)
With this fix, it builds and runs for me - works great.

Codecov Report

Merging #1452 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #1452   +/-   ##
======================================
  Coverage    5.84%   5.84%
======================================
  Files         161     161
  Lines        8919    8919
======================================
  Hits          521     521
  Misses       8398    8398

Flag
Coverage Δ

#unittests
5.84% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/adapters/net.cpp
1.57% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fba443...3d2c2ff. Read the comment docs.

doh! I made the change in my fork's 'master' branch... killing this PR since I can't redirect it to source from a proper branch.