Fix error when trying to convert text message partial payload to UTF-8

There was an issue with "not valid UTF-8 data" error being returned sometimes for incoming text messages that were split into multiple frames. If incoming text message consists of multiple frames, buffered partial payload may not necessarily represent a valid UTF-8 string, only a whole received message must represent a valid UTF-8 string. So we have to check if buffered payload of text message can be converted to a UTF-8 string only after receiving all frames of incoming text message, and only then try to convert to UTF-8 string and return error if it was not valid.

Thanks! Makes sense. Appreciate the fix.

Can this same error happen with the native engine using URLSession.webSocketTask? I have a scenario using the native websocket that sometimes results in this error receiving a large payload:
2020-07-09 16:19:35.522322-0700 [] nw_protocol_copy_ws_definition_block_invoke [C2.1:5] received invalid utf-8 sequence
2020-07-09 16:19:35.523424-0700 [] nw_read_request_report [C2] Receive failed with error "Bad address"
2020-07-09 16:19:35.524531-0700 Connection 2: received failure notification
2020-07-09 16:19:35.525757-0700 [] nw_read_request_report [C2] Receive failed with error "Socket is not connected"
2020-07-09 16:19:35.526124-0700 [] nw_content_context_copy_protocol_metadata called with null context
2020-07-09 16:19:35.526408-0700 [] nw_content_context_copy_protocol_metadata called with null context, dumping backtrace:
        [arm64] libnetcore-1880.120.4
    0   libnetwork.dylib                    0x00000001b03fbe80 __nw_create_backtrace_string + 120
    1   libnetwork.dylib                    0x00000001affe93d8 nw_content_context_copy_protocol_metadata + 548
    2   CFNetwork                           0x00000001b11b30b0 _CFHTTPServerResponseEnqueue + 29872
    3   libdispatch.dylib                   0x00000001065a9d10 _dispatch_call_block_and_release + 32
    4   libdispatch.dylib                   0x00000001065ab18c _dispatch_client_callout + 20
    5   libdispatch.dylib                   0x00000001065b2968 _dispatch_lane_serial_drain + 724
    6   libdispatch.dylib                   0x00000001065b35b4 _dispatch_lane_invoke + 492
    7   libdispatch.dylib                   0x00000001065bf0f0 _dispatch_workloop_worker_thread + 1344
    8   libsystem_pthread.dylib             0x00000001ada4b714 _pthread_wqthread + 276
    9   libsystem_pthread.dylib             0x00000001ada519c8 start_wqthread + 8
2020-07-09 16:19:35.527667-0700 Blink[32470:8174263] [websocket] Read completed with an error Socket is not connected


[Feature]: Hope authentication support jwt

What is the new or updated feature that you are suggesting?
Hope authentication support jwt.
Why should this feature be included?
Server-side sessions come with pros and cons. Some users prefer the tradeoffs/benefits provided by client-side sessions (e.g. JWT).
This also makes it easier to choose alternative data stores (such as those unsupported by Prisma) without having to modify the auth system.

You could create a JWT and store it in a cookie instead of storing the session inside a DB or something like that.
let sessionStorage = createCookieSessionStorage({
  cookie: {
    name: "session",
    path: "/",
    secrets: ["secret"],
    secure: process.env.NODE_ENV === "production"
  }
});

// to write it
let session = await sessionStorage.getSession(cookieHeader)
session.set("jwt", yourJwt)
let cookie = await sessionStorage.commitSession(session)

// to read the JWT
let session = await sessionStorage.getSession(cookieHeader)
let jwt = session.get("jwt")
let data = await parseJWT(jwt)

However, at that point you may not need JWT at all, just store the data directly in the sessionStorage returned by createCookieSessionStorage and you will have the same without adding a JWT serialize/parse step.

@sergiodxa  Is the cookie created using the createCookieSessionStorage signed just like a jwt is signed? If yes, then which one is more secure the jwt or the default signed cookie? And is it ok if store properties like userId, username, image, prefs etc in the cookie session storage?


[share]: make Share an instantiable object

Plugin
share_plus
Use case
Currently every method on share are static but they do not need to be. This is less convenient for testing and ioc.
Proposal
Make Share a real object by having its method as instance methods.

I personally don't see the advantage.
My approach with all 3rd party code, specially when it talks to platform implementations, is to always wrap it in a service class or similar you 100% control. That way, I don't have to worry about static methods, singletons, etc. or possible api changes.
Looking at the other plugins implementations, some allow instances (like DeviceInfo or NetworkInfo) while some use static methods as in Share (like PackageInfo).
At the end of the day, all of them use an internal static singleton, with a factory constructor, e.g.
https://github.com/fluttercommunity/plus_plugins/blob/58596acafa27ee258925e3a8a15493d13ad94995/packages/connectivity_plus/connectivity_plus/lib/connectivity_plus.dart#L24-L27
So you may have multiple instances, at the end it is the same singleton.
I'll be open to discuss further, but I don't think it is a priority for us to make this breaking change.

My approach with all 3rd party code, specially when it talks to platform implementations, is to always wrap it in a service class or similar you 100% control.

I'm not sure what makes you think I'm not already doing that. However, if I want to test the wrapper, I need to pass each static function in the constructor, which is less convenient than just passing an object. Singletons are also an anti pattern.

I'll be open to discuss further, but I don't think it is a priority for us to make this breaking change.

This is just a "would have been nice to have" for me, no biggie.

Singletons are also an anti pattern.

Sure, but we are talking about a plugin that talks to a platform implementation, not a typical OOP use-case. At the end, the plugin implementation uses a singleton internally.
Something that we could do, is to make all plugins accessible via a .instance static property. e.g. Share.instance.share(). That way, share() won't be a static method, you could still mock the Share class directly, and you can still access it without having to create an instance of the Share class, making the Share constructor private.
This is something that could be done with the upcoming Share cleanup: https://github.com/fluttercommunity/plus_plugins/issues/2819

FYI, this is now being done in https://github.com/fluttercommunity/plus_plugins/pull/3404


If a bind value is passed of type array, this needs to trigger the special binder to inject a repeating query section.
One way it could do this is by detecting the brackets of the values part of the query, then converting it. Like the following:
Source SQL:
insert into User ( `id`, `name`, `email` )
values (:id, :name, :email)

Converted SQL:
insert into User ( `id`, `name`, `email` )
values (:id_00001, :name_00001, :email_00001),
(:id_00002, :name_00002, :email_00002),
(:id_00003, :name_00003, :email_00003),
(:id_00004, :name_00004, :email_00004),
(:id_00005, :name_00005, :email_00005)

Solution:
insert into User (`id`, `name`, `email`)
values ( :__dynamicValueset )

Expands into the converted SQL perfectly.


language server should be able to fufill requests even without textdocument/didOpen Notifications

The LSP Spec says the following:

... Note that a server’s ability to fulfill requests is independent of whether a text document is open or closed.

For example, I see no hover when I hover over any token in this file: https://github.com/lpil/exercism/blob/HEAD/ocaml/hello-world/hello_world.ml, unless I manually make my client send this didOpen notification with the file contents. The spec says that language servers should still be able show hovers, etc. even without this notification.

Thanks for drawing attention to this. I looked at the part of the spec you refer to but I think it's actually unclear what the behavior should be here. The spec says that the ability to fulfill requests is independent of whether a document is open. It's not clear whether that actually means that all functionality should be available or if they are just referring to the server being available for other requests in general.
The reason that the server behaves the way it does now is because it relies on merlin to provide functionality like hover details. Merlin requires that files are loaded into it and synchronized before requests are made. Keeping files loaded in merlin has some memory overhead; it's not free. The way it works now, these files are loaded lazily.
The only real way to make the server operate the way you are suggesting is if we were to eagerly crawl the source tree and load all files in the project directory. I actually did something like this in an earlier version but it cause problems for some users on very large projects.
One solution would be to make the loading of files in the project directory happen eagerly by default but allow users to disable it. But I'm really not sure it's worth it.
Is there any particular reason why you can't have the client send the didOpen notification? What is the use case for where you don't want to do that? It doesn't seem like case comes up in the behavior for the vs code client at least.


Fix indentation of weave script

I was confused for a while because the else lines up with the wrong if.
I checked the rest of the script and don't see anything else with the same problem.

There is really no need for a PR for this kind of stuff.


SSL Implementation

Hello,
I followed your steps in order to run the server.
How can I add an ssl certificate to this server. What i have understood is that google chrome can't run camera and microphone unless the website is https.
Thanks in advance
Regards

It should work as long as you run it on http://localhost:8080.
You have to setup a Stunnel4 instance in front of it.
I will take a look and see if we can create a SSL proxy using node's SSL modules, not sure when I will have time though....

Hey,
thanks @KaptenJansson for your reply
I successfully implemented Stunnel and it worked
but now i have another issue, an error occurs while accessing the website with https.
Messages:
Failed to start signaling: Failed to execute 'pushState' on 'History': A history state object with URL 'http://<IP_ADDRESS>/r/769453476' cannot be created in a document with origin 'https://<IP_ADDRESS>'.
Any idea on how to fix it.
Thanks in advance!

aha we update the URL of the browser after joining the room in AppRTC, this is hard (if possible) when going through a proxy.....
Not sure how to solve that one. But as I said, you should be able to use AppRTC in Chrome and Firefox on http as long as you serve it on localhost:8080 (gum should work).

Closing this for now as I do not have time for this.
But as mentioned, it does work as long as you run the GAE instance on http://localhost:8080.

Why don't we make it client level change rather than passing full url and trying to push
Why can't we pass just room id  in the json instead of room link. I think then updating url won't cause this error . I hope this clears up soon. I haven't poked around in the files yet . But I am sure it won't be a big change.

Feel free to submit a PR, this application is designed for GAE and we have not considered using a development server (that's what dev_appserver.py is) as a production hosting solution.


Scenario: Using webhook to upload generated PDF to a pre-signed AWS S3 URL.

Scenario: Using webhook to upload generated PDF to a pre-signed AWS S3 URL.
The webhook middleware provides a Content-Disposition header. However, when I specify one via Gotenberg-Webhook-Extra-Http-Headers it is not considered. The webhook client processes the extra headers first and then internally generated headers, thus it appears not to be possible to override Gotenberg's content disposition headers.
See:
https://github.com/gotenberg/gotenberg/blob/d4c47cecf2ca1c35dc504073ce818862aa1bb180/pkg/modules/webhook/client.go#L46-L49
and
https://github.com/gotenberg/gotenberg/blob/d4c47cecf2ca1c35dc504073ce818862aa1bb180/pkg/modules/webhook/client.go#L72-L74
I can understand the rationale for preventing Gotenberg-Webhook-Extra-Http-Headers to override the client's headers. However, this precludes specifying a Content-Disposition when uploading to a service like AWS S3
Originally posted by @gstark in https://github.com/gotenberg/gotenberg/discussions/494

Hello @gstark,
Indeed, I did not want the user to mess with « default » headers, but it seems that in some cases it may actually be required.
Out of curiosity, what’s wrong with the Content-Disposition header from Gotenberg?

The Content-Disposition header from Gotenberg uses a UUID filename.
I dug a little deeper and it does appear that setting Gotenberg-Output-Filename applies and sets the filename part of the content-disposition header I care most about. With this, I have no need to update the header.
It might help to make a documentation update to /docs/modules/webhook to refer back to /docs/modules/api#output-filename-multipart to detail how the Content-Disposition header is generated and how it might be modified.

Thanks for the heads up @gstark, I've updated the documentation.


Day 7

Reference: https://adventofcode.com/2022/day/7

Initial plan for the task at hand.

Create enum Day7FileType(DIR, FILE)
Create class Day7File

With properties:
type: Day7FileType
size: int
name: str
parent: Union[Day7File, None]

Create file tree based on instructions and information from the input file


Fix typos in ErrorHandlingRationale.rst

"kindof" is an accepted alternate form of "kind of".  The other fixes are welcome, though.

The rest of the article uses "kind of" form. Anyway I reverted this change.

Thank you, looks great.


fix (JobForm) Fixes issue where the enabled flag would always be truthy

The issue would occur even if the schedule had been manually disabled.
closes DCOS-15615

Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

LGTM 💯 ✨


Fixed case branches worrying about type

For issue https://github.com/liquidata-inc/dolt/issues/529

Test naming fixed!


fix sort/radix_sort (#395)

(Put an X inside the [ ] to denote check mark [X].)

[ ] If creating a new file :

[ ] added links to it in the README files ?
[ ] included tests with it ?
[ ] added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

[x] if done some changes :

[x] wrote short description in the PR explaining what the changes do ?
Use position as a loop variable instead of is_done to fix the bug that isn't to be find easily.
[x] Fixes #[issue number] if related to any issue
#395

[ ] other

Pull Request Test Coverage Report for Build 731

3 of 5 (60.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 71.495%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

algorithms/sort/radix_sort.py
3
5
60.0%

Totals

Change from base Build 729:
0.02%

Covered Lines:
4304

Relevant Lines:
6020

💛  - Coveralls


Authentication for SOCKS5 proxy?

Does OkHttp support authentication for SOCKS proxies as of now? I looked into the documentation (http://square.github.io/okhttp/javadoc/com/squareup/okhttp/Authenticator.html) and it looks like this is just for HTTP proxies?

Yep, exactly. Actually our SOCKS support is all pretty limited. Right now we're relying on the SOCKS implementation that's built into the JVM; but we have been tempted to do our own in the application layer. Are you interested in spending a week or two to contribute code?

Yup, I'd be glad to. I guess the
        out.write(NO_AUTH);
        out.write(USER_PASSW)

bit from https://github.com/square/okhttp/issues/1359 should be most relevant. How exactly would I go about it?

You'll need to implement SOCKS completely first, so we can stop relying on the built-in proxy that Java gives us. That'll require a mechanism to test your implementation also, kind of like MockWebServer. Once that's all in, then authentication should just slide in!

I tried using what https://github.com/fengyouchao/sockslib did and it seems to work.
with a custom factory that returns sockslib.client.SocksSocket

@drallieiv I would appreciate it if you  could please add a code example of how to use sockslib for socks5 + authentication.
Thanks!

Maybe this will help https://stackoverflow.com/a/56422925/9466638

Won't fix.  We have had multiple Socks PRs that have languished.

Hi, no one contacted me about any of that. I'll have a look at the pull requests


Merging #1 seems to have broken stuff

https://ember-api-docs-staging.herokuapp.com/
currently 404s with some revision of the assets that aren't even in the S3 bucket. I think the original code @tomdale wrote rewrote the assets because it got it from the client app, not the fastboot app. The fastboot app is what's being requested from index.html, when it should be the client code.
cc @habdelra

No prob, but when reading from the ember deploy context, let's not read the
context object directly. We should use this.readConfig('distDir') instead
of context.distDir (same for fastbootDistDir), and let's test for the
existence of the
assetMap.json files first. (That's where I was blowing up).
On Thursday, February 25, 2016, Stanley Stuart<EMAIL_ADDRESS>wrote:

https://ember-api-docs-staging.herokuapp.com/
currently 404s with some revision of the assets that aren't even in the S3
bucket. I think the original code @tomdale https://github.com/tomdale
wrote rewrote the assets because it got it from the client app, not the
fastboot app. The fastboot app is what's being requested from index.html,
when it should be the client code.
cc @habdelra https://github.com/habdelra
—
Reply to this email directly or view it on GitHub
https://github.com/fivetanley/ember-cli-deploy-fastboot-build/issues/2.


Address review comments of #113

In preparation of a demo, https://github.com/Qiskit/qiskit_sphinx_theme/pull/154 was created to include only the copy edit changes from review in https://github.com/Qiskit/qiskit_sphinx_theme/pull/113. We should address the remaining review comments in #113 or close it and open a new PR.

Closed by #166


Request to have metrics emitted on health check failures

What should we add or change to make your life better?
Requesting metrics in some of the default classes such as:
https://github.com/microsoft/reverse-proxy/blob/04b1fe8d8cd0f25b814805c2fb91c68fb26c7f29/src/ReverseProxy/Health/DestinationHealthUpdater.cs#L43
https://github.com/microsoft/reverse-proxy/blob/04b1fe8d8cd0f25b814805c2fb91c68fb26c7f29/src/ReverseProxy/Health/ActiveHealthCheckMonitor.cs#L197C31-L197C31
https://learn.microsoft.com/en-us/dotnet/core/diagnostics/metrics-collection
Specifically, today, I'm looking for a way to have alerts go off when our health checks fail without reimplementing YARP's default implementations. More generally it would be nice if YARP had metrics to complement the Log statements.
Why is this important to you?
We are able to set up alerts on metrics but not on individual log messages. Metrics can alert the on-call engineers to look at the logs for further information.

here is a quick list I put together by searching for Log. and removing some that didn't look relevant:
src\ReverseProxy\Configuration\ConfigProvider\ConfigurationConfigProvider.cs:
   70:             Log.LoadData(_logger);

   88:                 Log.ConfigurationDataConversionFailed(_logger, ex);

  110:                 Log.ErrorSignalingChange(_logger, ex);

src\ReverseProxy\Forwarder\ForwarderHttpClientFactory.cs:
  40:             Log.ClientReused(_logger, context.ClusterId);

  60:         Log.ClientCreated(_logger, context.ClusterId);

src\ReverseProxy\Forwarder\ForwarderMiddleware.cs:
  50:             Log.NoAvailableDestinations(_logger, cluster.ClusterId);

  62:             Log.MultipleDestinationsAvailable(_logger, cluster.ClusterId);

  79:             ForwarderTelemetry.Log.ForwarderInvoke(cluster.ClusterId, route.Config.RouteId, destination.DestinationId);

src\ReverseProxy\Forwarder\HttpForwarder.cs:
  150:                     Log.NotProxying(_logger, context.Response.StatusCode);

  154:                 Log.Proxying(_logger, destinationRequest, isStreamingRequest);

  171:                         Log.RetryingWebSocketDowngradeNoConnect(_logger);

  179:                         Log.RetryingWebSocketDowngradeNoHttp2(_logger);

  214:             Log.ResponseReceived(_logger, destinationResponse);

  490:                 Log.InvalidSecWebSocketKeyHeader(_logger, key);

  922:         Log.ErrorProxying(_logger, error, ex);

src\ReverseProxy\Health\ActiveHealthCheckMonitor.cs:
   61:                 Log.ExplicitActiveCheckOfAllClustersHealthFailed(_logger, ex);

  116:         Log.StartingActiveHealthProbingOnCluster(_logger, cluster.ClusterId);

  142:             Log.ActiveHealthProbingFailedOnCluster(_logger, cluster.ClusterId, ex);

  156:                 Log.ErrorOccuredDuringActiveHealthProbingShutdownOnCluster(_logger, cluster.ClusterId, ex);
  158
  159:             Log.StoppedActiveHealthProbingOnCluster(_logger, cluster.ClusterId);

  176:             Log.ActiveHealthProbeConstructionFailedOnCluster(_logger, destination.DestinationId, cluster.ClusterId, ex);
  177

  187:             Log.SendingHealthProbeToEndpointOfDestination(_logger, request.RequestUri, destination.DestinationId, cluster.ClusterId);
  189:             Log.DestinationProbingCompleted(_logger, destination.DestinationId, cluster.ClusterId, (int)response.StatusCode);

  197:             Log.DestinationProbingFailed(_logger, destination.DestinationId, cluster.ClusterId, ex);

src\ReverseProxy\Health\DestinationHealthUpdater.cs:
   43:                     Log.ActiveDestinationHealthStateIsSetToUnhealthy(_logger, destination.DestinationId, cluster.ClusterId);

   47:                     Log.ActiveDestinationHealthStateIsSet(_logger, destination.DestinationId, cluster.ClusterId, newHealth);

   85:             Log.UnhealthyDestinationIsScheduledForReactivation(_logger, destination.DestinationId, reactivationPeriod);

  100:             Log.PassiveDestinationHealthResetToUnkownState(_logger, destination.DestinationId);

src\ReverseProxy\LoadBalancing\LoadBalancingMiddleware.cs:
  59:             Log.NoAvailableDestinations(_logger, proxyFeature.Cluster.Config.ClusterId);

src\ReverseProxy\Model\ProxyPipelineInitializerMiddleware.cs:
  40:             Log.NoClusterFound(_logger, route.Config.RouteId);

src\ReverseProxy\WebSocketsTelemetry\WebSocketsTelemetryMiddleware.cs:
  56:                 WebSocketsTelemetry.Log.WebSocketClosed(

  80:                 WebSocketsTelemetry.Log.WebSocketClosed(

@timmydo Thanks for reporting this. We believe there's value in making some of these metrics, but perhaps not all of them (e.g. error conditions that should really be addressed immediately).
If you could provide a list of the ones that are the highest priority to add metrics for, that would be great.

Triage: perhaps another interesting metric might be a catch-all "this request couldn't be proxied" metric.

Counters for these files above look to be higher priority, with higher priority being to logs that would be error or warning:
src\ReverseProxy\Forwarder\ForwarderMiddleware.cs
src\ReverseProxy\Health\DestinationHealthUpdater.cs
src\ReverseProxy\Health\ActiveHealthCheckMonitor.cs
src\ReverseProxy\LoadBalancing\LoadBalancingMiddleware.cs

having counters for successful requests is useful also to validate whether no errors is a data-missing scenario or no errors. Also, you can measure the reliability.


[security] voter - suppress MoreSpecificImplementedParamType on voteOnAttribute

partially resolves https://github.com/psalm/psalm-plugin-symfony/issues/107

Thanks ! Can you make a release @seferov ? :)

@VincentLanglet sure. Here it is https://github.com/psalm/psalm-plugin-symfony/releases/tag/v2.1.1


导入时出错

from zhihu import Account
Traceback (most recent call last):
File "", line 1, in
File "C:\Python27\lib\site-packages\zhihu_init_.py", line 1, in
from zhihu.models import answer
File "C:\Python27\lib\site-packages\zhihu\models_init_.py", line 22, in
from zhihu.error import ZhihuError
File "C:\Python27\lib\site-packages\zhihu\models\zhihu.py", line 6, in
from ..auth import need_login
File "C:\Python27\lib\site-packages\zhihu\auth.py", line 6, in
from zhihu.models.account import Account
File "C:\Python27\lib\site-packages\zhihu\models\account.py", line 6, in
from ..models import Model
ImportError: cannot import name Model

都说了是用python3了

fixed


type arguments should not be null

After change 45021, these tests fail in dartdevk:
language_2/bug32353_test
Uncaught Error: type arguments should not be null: ...

language_2/recursive_mixin_test:
Uncaught Error: type arguments should not be null: ...

A few things were going on here:

This fix needs to be made to dartdevk https://dart-review.googlesource.com/c/sdk/+/19024

dartdevk needs to ignore synthetic mixin classes rather than trying to compile them (it has its own unrolling shared with dartdevc. Eventually dartdevk may be able to migrate to CFE/Kernel's unrolling, but for now it needs to ignore it.)


Figure size/aspect for projections is not working anymore with the last version of Matplotlib

Description
I was trying to make a new environment with updated packages, but I faced a colorbar extend warning with the new version but the biggest problem is the size/aspects of the figures that are not good anymore for projections. I think it is coming from the last version of Matplotlib 3.3. Here is the problem with a random example:
Steps to reproduce
import proplot as plot
import xarray as xr

da = xr.tutorial.open_dataset('air_temperature').air - 273.15
clim = da.groupby(da['time.season']).mean('time')

f, axs = plot.subplots(proj='cyl', ncols=2, nrows=2)

for i, ax in enumerate(axs):
    m = ax.contourf(clim.isel(season=i), levels=plot.arange(-30,30,5), extend='both', cmap='CoolWarm')

    ax.format(
        labels = True, coast = True, borders = True, lonlines=30, latlines=15,
        latlim=(clim.lat.min().values, clim.lat.max().values),
        lonlim=(clim.lon.min().values, clim.lon.max().values),
        title=clim.isel(season=i).season.values
    )

f.colorbar(m, label='Near-Surface Air Temperature [°C]')

/data/mlalande/miniconda3/envs/phd_v2/lib/python3.8/site-packages/proplot/figure.py:1158: MatplotlibDeprecationWarning: The 'extend' parameter to Colorbar has no effect because it is overridden by the mappable; it is deprecated since 3.3 and will be removed two minor releases later.
return super().colorbar(*args, cax=cax, **kwargs)

Actual behavior:

Expected behavior
And with my previous environment I was having this:

Proplot version
I passed from: (work.txt)

proplot 0.5.0
matplotlib 3.1.3

to: (phd_v2.txt)

proplot 0.6.4
matplotlib 3.3.0

I tried to downgrade matplotlib to 3.2, it actually does solve the problem but I still have another issue with the colorbar extend that doesn't work in certain cases (I didn't succeed to reproduce with a simple example...).

This is not pretty... will try to address it in the next few days.

Solution was simpler than I thought -- see #235


BUG: add linkchecking CI

Someone pointed out a broken link (see https://github.com/scientific-python/tools.scientific-python.org/pull/63), so apparently the netlify linkchecker doesn't work.
This came up in the specs repo, but only on the theoretical level, thus I open this issue here as we actually had broken links in this repo.

I've had good success with using lychee to cook up my own CI solution for this:
lychee --dump ${URL}/sitemap.xml | grep "${URL}" | sort > links.txt
cat links.txt
cat links.txt | xargs lychee -v --no-progress --max-concurrency 2 --include-fragments

But they also provide a GitHub action for it.


Mechanical Manual is Gone

I watched Logdotzip's 2nd video about this datapack, and he showed  a mechanical manual with a crafting recipe. I tried it in-game, and it wasn't there. I also looked around in the files for crafting, and it isn't there either.

I tried to have an update with the manual before LDZ posted the video, but it's taking longer to implement than expected. I'll have it out sometime this weekend.

Ok, thanks! I'm looking forward to when that happens.  Also, is there a chance that like, in most mods, that the player starts the game with the manual?

It gives you the manual the first time you make the Machine Crafter (specifically as a reward for getting the advancement).

Thanks for clearing all this up. Makes a lot more sense now! 😄


Create kubernetes cluster on AWS using Ubuntu Core

attempt to create a kubernetes cluster on AWS using Ubuntu Core.  Until Ubuntu Core is available for MaaS this is our only way to trial this OS.

got a node up and running last week but its DNS resolution was pretty broken.  ie:  only worked with tools that use the systemd dns resolver which isn't everything.  going to try again today and see if I can get anywhere.

DNS resolution works now after node recreation.  there is data in /etc/resolv.conf.  I don't know what went wrong last time but its fine now.
snap installs work kind of.  I'm installing wget (sudo snap install demo-wget) and the binary is installed and worked but its not being installed to anywhere in the $PATH.  which is a bit useless.
it also seems cloud-init doesn't work.  I'll be exploring that more but actually I think that's a known issue.

cloud-init kind of works.  when I pass in an invalid cloud config segment, ubuntu-core sees the config is wrong, throws an error and carries on correctly.  if I pass in a valid cloud config segment then the supplied cloud config segment seems to get executed and then the rest of the cloud-init execution goes haywire and public keys don't get added to the authorized key file.  I don't know what else is wrong because I can't access the node.

rkt doesn't have a snap so we can't use rkt here.  bummer.

okay!  that worked.  I'm guessing I had a typo of some sort that was messing with the cloud-init process.  onward.

#cloud-config
write_files:

content: test
path: /home/ubuntu/test

ubuntu-core isn't going to be available in MaaS until april.  mothballing this until then.

closed until we


Build a Runtime Module using Substrate

Substrate is a framework for building blockchain logic through composition of runtime modules. The Substrate Runtime Module Library already includes useful modules for basic functionality such as assets (tokens), balances, staking, and more. Members of the community have been extending the functionality of Substrate-built chains through their own modules, such as NFTs (substratekitties), or TCRs.
This task is to create a Substrate runtime module which can be re-usable among projects in the ecosystem. Some ideas of extensions could include privacy-focused transactions, opaque balances using zk-snarks, quadratic voting, harberger tax on assets, or new auction mechanisms.
Requirements
A correct submission will:

Be open source (under a permissive license which will let others use it).
Have a step-by-step guide on how to use the module in a substrate chain (how to import the crate, and integrate it with other modules and finally run the chain).
The module must function as intended, have no compiler errors and be well documented.

Update: We are aiming to release it on mid May. The code is ready, documentations still need more work.

We are still aiming to release it on mid May.

The status is the same as we are still aiming to release it on mid May.

Ok @xlc please update as soon as you have a chance! :)

The code will be available next Monday. and we will provide some tutorials of how to use it next week.

It is open sourced: https://github.com/cennznet/cennznet/blob/master/prml/generic-asset/src/lib.rs
The rustdoc already contains usage and documentations. We can write an article about it maybe next week.

@Web3Foundation We are contributing GenericAsset module back to Substrate https://github.com/paritytech/substrate/pull/2790

Looks awesome @xlc and @Web3Foundation 👌

@xlc is this still in progress?

@Web3Foundation I believe this bounty is completed as it has been successfully merged into the Substrate code base.

Yes it is completed.

Great; @xlc if you submit work on here i'll be able to payout.

@Web3Foundation, @xlc is no longer employed by Centrality (the developers of this module). How should we proceed?

@wilfred-centrality if there is a need / want from centrality to claim this bounty please have the relative developer claim the bounty on gitcoin. Otherwise we can pay directly to @xlc; let us know.

Thanks for the help @Web3Foundation, we'll have @holygits accept the bounty on Centrality's behalf

@Web3Foundation may I be added as a worker to the issue via gitcoin? I'm unable to progress this from my end

Hey there. Chris from Gitcoin Community here.
@Web3Foundation can you please remove @xlc from the bounty? (Remove Worker) - then @holygits should be able to apply to this bounty.
If you need any assistance - please let me know!
Thanks,
Chris

@kuhnchris / @wilfred-centrality @holygits done.

@Web3Foundation thanks for that. @holygits will claim when he's back from leave

Closing, since we already have quite a lot of runtime modules and this issue is no longer maintained. Feel free to apply for funding via the open grants program.

Closing, since we already have quite a lot of runtime modules and this issue is no longer maintained. Feel free to apply for funding via the open grants program.


Connections not properly closed on Kernel shutdown

I experience propblems because of too many open connections during unit tests.
These connection are at half from ongr which doesn't close the connection on kernel shutdown => Garbage collection doesn't free it.
The used PHP Version is 7.1.12
Bundle is 2.0.6

Could you elaborate a bit more on the specific issue you are facing?

If I understand correctly => if you have a ton of functional tests instantiating rebooted kernels, and therefore reinstantiating the Redis instances, they will start failing in the end indicating Redis has run out of sockets or something?

@applike-ss I've just typed a bit in a related report at https://github.com/snc/SncRedisBundle/pull/412#issuecomment-380919445. As said there I'm not all too excited about changing or extending perfectly fine code just to facilitate test suites if it is easier and more correct to fix the test suite instead.
What is your take on that?

@curry684 i do understand your point, but it is not the test case/suite that creates the problem.
In my Opinion, whenever a Bundle is shut down, all connections that this bundle initiated should be properly closed instead of relying on php to close them.
Doctrine is a good example for this behaviour. When it shuts down, it gathers all entity managers and clears their state. Afterwards it gathers all connections and closes them.
I believe, it shouldn't break anything anyway, since the connection wouldn't be used after a bundle shutdown anyway.

You are right, having lots of tests using redis, we are facing an issue with connection count increasing to the maximum of the machine running the tests.

@applike-ss check out #415 - should be a solution you're looking for.

@supersmile2009 thanks a lot. Looking forward for it to be merged.

Fixed in 2.x by #415 but keeping this issue open to better investigate how to do this in 3.0 without making a service needlessly public.

Like @dkarlovi mentioned on #415 it is possible to create env-specific service for test environment and declare it public instead of making public the original service.
However I'm not sure if there's anything else except unit tests that's using Kernel's shutdown feature. Method's docBlock says "This method is mainly useful when doing functional testing." But I'm particularly concerned about things like PPM - I haven't had a chance to try it yet, so I don't know whether it uses shutdown.
If shutdown is indeed only a unit tests thing, than a public service prefixed by test. and auto generated in a compiler pass is a perfect solution.
However if it's not the only case of shutdown usage, then we should probably also add a bool config option like snc_redis.session.close_on_sutdown. (default - false)
This way public service will be generated in test env + when this option is set to true, if someone needs it not just in test environment.

@supersmile2009 if you wish to support PPM, the official was to do it is to tag the service with kernel.reset.


First impressions - how do I disable most of the UI?

(Please take this in the spirit that it is intended. I've skimmed the docs and installed django-filer in a project where I'm looking for a replacement for Django FIlebrowser. I always think it's valuable to share first impressions - even if they later turn out to be misinformed)
So installation was a breeze. Having to specify a unique related name is a minor pain and it can probably be abstracted away - you could use <app_label><model_name><field_name> but allow overriding?
Anyway - that's minor. My aim is a simple, user-friendly image field for a staff-facing admin. My users are my clients and their staff. I'm using Django 1.8 but with the flat admin from 1.9.
First thought about the admin widget - it's takes up a lot of screen space and putting it on the same row as other fields isn't going to work: ('name', 'logo', 'photo',), It doesn't blend with the other widgets and rather takes over the screen. I'll probably want to fix that with CSS or by overriding the widget markup.
Labelling the main button 'upload images' is confusing as clicking this is also how you browse for already uploaded images. You either need separate 'browse' and 'upload' buttons or find a more general label for this button.
Having a default folder called 'unsorted uploads' implies there is a way to sort uploads? I couldn't see any way to move files to new folders. It's also confusing as it appears to be a subfolder of 'root' but then it seems to BE the root directory. You usually don't see a folder icon for the folder you're in. It probably looks more intuitive when there are more folders but the initial view is confusing.
Furthermore - when I click into the folder - I lose the drop target. So the way I would expect to upload files into this folder (navigate into it then upload) doesn't work. Again - once I added a new folder it made a bit more sense but UX first impressions are fairly important. Possibly - making 'unsorted uploads' look less like it's a normal folder and this might be less perplexing. It's not really a folder - unless you regard it as the root folder?
So I added a folder and uploaded a file. The 'edit image details' screen is interesting but I immediately switch to the docs to see how I can override it. You see - it has way too much on it. Every field means time spent explaining to the user what that's for and from a brief glance I would only need to expose a single field to my users in most cases - alt tag (and half of them never use that). Sometimes title will be useful but not in every case. Filesize and dimensions are useful but nearly everything else is just going to clutter the screen and confuse my users. It's great having them there for the times I need them but I'd really like the docs to explain quickly and simply how to hide them and present the fewest possible options.
I hope this is helpful. I understand my requirements (mainly for maximum UX simplicity) might different to yours but hopefully they are not uncommon goals and sharing my initial thoughts is of some use.

Interesting (and mostly valid, IMHO) points. I also have a couple of them ;-). My main concern is, that filer more or less is styled like django-admin-tools, but should more align to django defaults, when these are not installed.
The "edit image details" is overblown, that's true, but most clients never land there ;-) You forgot the "Subject Location", which can be a really great tool! But yea, why not "alt text" and "replace file" fields, and that's it.
Thinking further, one could implement a "FILER_USE_REDUCED_UI" setting, and then really strip down widget and admin. Some time ago (2010) we used a custom "filer_enhanced" (haha) module, that did some of these things, but, maintainance, ...etc...

still an issue for us. But things got a little better, at least filer now works with plain normal django (withou djangocms-admin-styles).


Error doing job: Task exception was never retrieved

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

Component/platform:

Description of problem:
Sat Apr 27 2019 16:40:00 GMT-0600 (Central Standard Time)
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity_platform.py", line 365, in _async_add_entity
await entity.async_update_ha_state()
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 225, in async_update_ha_state
self._async_write_ha_state()
File "/usr/local/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 248, in _async_write_ha_state
state = self.state
File "/usr/local/lib/python3.7/site-packages/homeassistant/components/hue/sensor.py", line 40, in state
return 10 ** ((self.sensor.lightlevel - 1) / 10000)
TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:
This is occurring after upgrading to 3.7.3 version 0.92.1

Duplicate of #23456
Will be fixed in 0.92.2

Thanks.

On Apr 27, 2019, at 5:01 PM, Jason Hu<EMAIL_ADDRESS>wrote:
Duplicate of #23456
Will be fixed in 0.92.2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


rgb quize contributed

@Mridul2820  kindly merge the pull request by verifying it, if any changes please let me know!!
and don't forget to add a hacktoberfest-accepted label to get the benefits as a maintainer.

Hi @vidhanshu please add your project files in projects/javascript/rgb-quize folder and also move the assets in the same folder
And You need to add your project details in the main README.md File
You can follow this Example: example-readme-details

sure !


Use associated data as IV for Aes256Cbc

Unfortunately the WrapKey request does not support nonces.  Adding the field would break many application so I chose this approach for the first implementation.

Replaced by: https://github.com/trussed-dev/trussed/pull/149


Clip.none ignored during overscroll on Android

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Create a scrollable view that's larger than the screen bounds
Give the view some padding on the scroll direction
Configure the scrollable to use clipBehavior: Clip.none
Run it on Android, or simulate Android platform defaults

Expected results
The view should overscroll (stretch) normally.
Actual results
During the stretching overscroll effect, the bounds outside the scrollview disappear (are clipped) until the view is no longer being overscrolled.
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:flutter/foundation.dart';

void main() {
  // Test this code in other platforms
  debugDefaultTargetPlatformOverride = TargetPlatform.android;
  runApp(const AppBarApp());
}

class AppBarApp extends StatelessWidget {
  const AppBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Padding(
          padding: const EdgeInsets.symmetric(vertical: 100),
          child: SingleChildScrollView(
            clipBehavior: Clip.none,
            child: Column(
              children:
                  List.generate(20, (i) => ListTile(title: Text('Item $i'))),
            ),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
Screencast from 2023-08-25 16-38-34.webm

Logs
Logs
No relevant logs

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 3.14.0-9.0.pre.93, on Fedora Linux 38 (Workstation Edition) 6.4.11-200.fc38.x86_64, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[!] Android Studio (not installed)
[✓] IntelliJ IDEA Community Edition (version 2023.2)
[✓] Connected device (2 available)
[✓] Network resources

! Doctor found issues in 1 category.

Thanks for filing the issue. I can see this on Android whilst it doesn't appear on iOS platform. Adding demo video with enabling Overlay guideline  in Devtools Widget Inspector to see the issue more clearly.
Also, the issue is only reproducible on master channel. On stable 3.13.1, the issue doesn't happen. Marking this as a regression issue.

Demo

master
stable

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.13.1, on macOS 13.5 22G74 darwin-x64, locale en-VN)
    • Flutter version 3.13.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e1e47221e8 (23 hours ago), 2023-08-22 21:43:18 -0700
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (3 available)
    • iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.2 19H218
    • macOS (desktop) • macos                                    • darwin-x64     • macOS 13.5 22G74 darwin-x64
    • Chrome (web)    • chrome                                   • web-javascript • Google Chrome 116.0.5845.96

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.14.0-9.0.pre.115, on macOS 13.5 22G74 darwin-x64, locale en-VN)
    • Flutter version 3.14.0-9.0.pre.115 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6d22a11b62 (3 hours ago), 2023-08-27 19:57:26 -0400
    • Engine revision 0593c0455f
    • Dart version 3.2.0 (build 3.2.0-97.0.dev)
    • DevTools version 2.26.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 13.5 22G74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 116.0.5845.110

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Looks related to https://github.com/flutter/flutter/issues/133445

@huycozy the examples in your videos are not the same. On stable it is using the GlowingOverscrollIndicator, not the StretchingOverscrollIndicator, which is the new default on the master channel.

This is caused by the SingleChildScrollView. Swapping it out for a ListView shows no issue. I am guessing the clipBehavior in SingleChildScrollView is not passed on to the Scrollable that then passes it on to the overscroll indicator. Looking at fixing this now.

the examples in your videos are not the same. On stable it is using the GlowingOverscrollIndicator, not the StretchingOverscrollIndicator, which is the new default on the master channel.

Oh, that's right. Thanks for clarifying this!


project_creation folder management

Hi,
I know that cloudresourcemanager.v1.project API doesn't support folders and so I've to move the project by hand from org to folder, but after that I can't update deployment (for example to change iam bindings on project or create service account) because I've the following error:
ERROR: (gcloud.deployment-manager.deployments.update) Error in Operation [operation-1505398303589-55926db218288-6c7b630d-56dd0f1d]: errors:
- code: RESOURCE_ERROR
  location: /deployments/<deployment>/resources/project
  message: '{"ResourceType":"cloudresourcemanager.v1.project","ResourceErrorCode":"403","ResourceErrorMessage":{"code":403,"message":"User
    is not authorized.","status":"PERMISSION_DENIED","details":[{"@type":"type.googleapis.com/google.rpc.ResourceInfo","resourceType":"FOLDER","resourceName":"FolderId{toLong=<folderid>,
    getResourceType=FOLDER}"}],"statusMessage":"Forbidden","requestPath":"https://cloudresourcemanager.googleapis.com/v1/projects/<project>","httpMethod":"PUT"}}'

Thanks

I think what is happening is that when you are updating the deployment, it is attempting to move the project back under the organization, out of the folder. You can check by looking at the project resource's update.finalProperties. If they have parent.type equal to organization, then it is attempting the move.
The 403 is because the service account DM is running under does not have permission to move the project. If you want the move, then give the service account the permission to move the project.
If you don't want the project to move, then a work around is to modify project.py to emit the parent property of your folder (as the template does not currently support folders).
So:
    'parent': {
          'type': 'organization',
          'id': context.properties['organization-id']
      }

Would become:
    'parent': {
          'type': 'folder',
          'id': context.properties['folder-id'] # Or hard code the folder-id here. If not hard coded, update project.py.schema to make organization-id optional.
      }

Hi, thank for the quick reply.
I confirm what you say, but at the same time I advice to improve documentation (overall):

the folder type is not documented (doc. says "The only supported parent type is "organization")
when and how to use "type: gcp-types/.." and "action: gcp-types/..."
which of the methods of the above APIs are valid with DM
some types are not listed (example deploymentmanager.v2.virtual.enableService)

Thanks

Thanks for your feedback Davide. I have just committed a change to the project creation template that adds parent-folder-id as another supported option.
The actions feature is still in alpha and we plan to documentation when we launch it to GA.
deploymentmanager.v2.virtual.enableService was intended to be a stop gap for us to support enabling apis till we launch actions. We will be moving over to using actions instead of virtual types.


⚠ Mobitopup has degraded performance

In 87ddb9e, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3003 ms

Resolved: Mobitopup performance has improved in 0d46739.


Fix Lint/ErbNewArguments code snippet formatting

The documentation code snippet does not render as code, but as plaintext.
Indenting it causes it to be interpreted as a block of code.
Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
~Commit message starts with [Fix #issue-number] (if the related issue exists).~
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
~Added tests.~
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I haven't generated a changelog entry, but I don't think this needs one, since it's just fixing broken formatting in docs, and not actually altering any content. I'm glad to create one if it needs one.

I haven't generated a changelog entry, but I don't think this needs one, since it's just fixing broken formatting in docs, and not actually altering any content. I'm glad to create one if it needs one.

No changelog necessary for a documentation change :)

Thanks!


Support for trailing closure syntax.

Search Terms
trailing closure
Suggestion
Both Kotlin and Swift support trailing closures (see Swift Documentation), which when a method's final argument is a function type, allows you to specify the lamda/closure/callback simply as a block of code, example:
function foo(callback: () => void) {
  callback();
};

foo() {
  console.log("I'm a callback, look at me!");
}

Use Cases
If TypeScript had support for trailing closures, JSX/TSX could be replaced entirely with core language features (rather than the current state of JSX/TSX being external and not part of the language) (See SwiftUI and TornadoFX). It would allow for react-like code to be written without external knowledge, and workaround the parsing ambiguity that causes things like type-casting to be disabled in a .tsx file.
It would also keep TypeScript aligned with other modern languages in terms of syntax, reducing the friction of people from Kotlin/Swift worlds learning TypeScript.
Examples
(See the example from above)
Example of how JSX/TSX can be replaced:
With TSX
function MyComponent() {
  return <div>
    <SomeOtherComponent/>;
  </div>;
}

With Trailing Closures
function MyComponent() {
  return div() {
    SomeOtherComponent();
  };
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

[x] This feature would agree with the rest of TypeScript's Design Goals.

I would say it goes against these goals:

Align with current and future ECMAScript proposals.
Avoid adding expression-level syntax.

And this non-goal:

Exactly mimic the design of existing languages. Instead, use the behavior of JavaScript and the intentions of program authors as a guide for what makes the most sense in the language.

This is definitely out of scope of TypeScripts goal (be JavaScript with types).

@MartinJohns, that's fair. I guess this is more of a suggestion for TC39?

Yes, check out https://github.com/samuelgoto/proposal-block-params


feat(commonTests): add implementsShorthandProp

Current coverage is 24.61% (diff: 100%)

Merging #530 into master will decrease coverage by 74.24%

@@             master       #530   diff @@
==========================================
  Files           107        107
  Lines          1751       1751
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1731        431   -1300
- Misses           20       1320   +1300
  Partials          0          0

Powered by Codecov. Last update 4c028d8...66f10b0


Allow usage of 'role PUBLIC' in GRANT/REVOKE:

To generate this kind of query:
REVOKE CONNECT ON DATABASE database1 FROM PUBLIC;

I created following puppet code:
postgresql::server::database_grant { 'revoke connect on database1':
    ensure => 'absent',
    db => 'database1',
    privilege => 'CONNECT',
    role => 'PUBLIC',
}

This generate following error:
Error: /Stage[main]/Profile::Postgresql_gis/Postgresql::Server::Grant[revoke ALL on schema public to public:]/Postgresql_psql[grant:revoke ALL on schema public to public:]: Could not evaluate: Error evaluating 'unless' clause, returned pid 7360 exit 1: 'ERROR:  role "PUBLIC" does not exist

because PUBLIC is a "implicit" role and is not listed in pg_roles table.
To fix this I modify query that test if role exists.

Puppet call the SQL function : has_database_privilege() to check privileges. This function works with 'PUBLIC' role but you need to specify 'PUBLIC' as lowercase : 'public'. See https://www.postgresql.org/docs/9.1/static/functions-info.html

@david22swan Can you take a look at this PR ? Is there anything I can do to help merging this PR ?

@Vampouille Sorry for your PR being left to lie for so long.
In order to get this merged we would require test coverage to be added to ensure that your change works correctly and allow us to catch any error's that occur to it in the future, and for the documentation to be updated to include a reference to it.

@david22swan Can you reconsider this PR ? I don't known how to write units tests and even don't known what to test is this case. Do you have some link to other PR that add tests for the database_grant resource ?
Additionally, this PR does not add a new feature, it just fix a bug in this puppet module:
With postgres this works :
REVOKE CONNECT ON DATABASE application_db FROM PUBLIC;

With this puppet module this does not work:
postgresql::server::database_grant { 'revoke connect on application_db':
  ensure    => 'absent',
  db        => 'application_db',
  privilege => 'CONNECT',
  role      => 'PUBLIC',
}


[Protection Level] Table "Gen. Journal Line" Function "RenumberAppliesToDocNo" remove local

Please remove local - we have renumbering functions especially for recurring ones and used the standard function for it and want to avoid having unnecessary duplicates.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Polyfill does not work in an ES module context

When running as an ES Module, the global this is always undefined.

The best version I've got:
var polyfilledGlobalThis =
  this !== undefined ? this :
  typeof window === 'object' ? window :
  typeof global === 'object' ? global :
  undefined /* or maybe throw? */;

Function(‘return this’)() absolutely works in an ES Module context.
Ether way, proposal repo polyfills aren’t for production use. Use https://npmjs.com/globalthis


Examples with npmjs waku eth pm

Updated the eth-pm examples to use js-waku from npmjs.

Please be sure to follow https://cbea.ms/git-commit/for commmit messages.


Read possible state categories from HoI4 install (and mods)

Instead of hard coding the slots per state category, read those in from the necessary HoI4 files. Make sure to support HoI4 mods while doing so (if only by checking blankMod).

Complete, except for the mod support. As no other sections support mods in that way, it'll be left out for now.


Fix winelib tests builds.

@pchome

hack

Looks like here is the right place to start.
LO_DEFAULT:

That's a good question. In case it's configured as native, it will be handled by this:
https://source.winehq.org/git/wine.git/blob/0c790adf300dd37f624029023bc6de53cb21373c:/dlls/ntdll/loader.c#l2502
When it's set to builtin, but its file is found during filesystem lookup, Wine will try to load it as builtin first. The attached hack works around that. loader.txt Wine will not use its builtin when configured with b or b,n, but leave current behaviour for default settings. A solution for upstream would need more thoughts.
There is also WINEDLLPATH environment variable. It currently does not work for replacing existing Wine builtin DLLs, but that could probably be changed. (If we could have a solution not requiring DLL overrides at all that would be even better, but I don't have much hopes for that, at least short term).

@jacekcw
Thanks, I'll try this patch. I've thought about hardcoding DXVK dll names for my local usage, so any solution is fine atm.


Multiple telemetry subsription breaks the telemetry.attitude_euler()

I'm working with Holy Bro Durandal connected to embedded Arm computer with a serial connector to Telem1.
Problem is that telemetry.attitude_euler() will stop working if I subscribe to more than 6 telemetry streams. It is easy to see how it breaks from log pics below:
6 streams subscribed

7 streams subscribed

The most noticeable thing is the reduced output of Euler angle events, and that the angle is fixed near the initial angle. By "near" I mean that minor change to angle fraction is there, but it seems to be "random"
I did not found any particular stream that would cause this, my experience is that the number of subscriptions will break it.
Here is a simplified test script
#!/usr/bin/env python3

import asyncio

from mavsdk import System

async def run():
    # Init the drone

    # mavsdk_server is started separately with command  to get the log output
    # mavsdk_server -p 50050 serial:///dev/ttyTHS1:115200

    drone = System(mavsdk_server_address="localhost", port=50050)  #
    await drone.connect(system_address="serial:///dev/ttyTHS1:115200")
    # system_address not used when mavsdk_address is set

    # Start the tasks
    # If more than 6 task are created euler angle stops "working", showing
    # only initial angle with minor changes that does not reflect the real angle
    asyncio.ensure_future(print_euler(drone))
    asyncio.ensure_future(print_battery(drone))
    asyncio.ensure_future(print_gps_info(drone))
    asyncio.ensure_future(print_in_air(drone))
    # asyncio.ensure_future(print_position(drone))
    asyncio.ensure_future(print_flight_mode(drone))
    asyncio.ensure_future(print_status_text(drone))
    # asyncio.ensure_future(print_health(drone))

async def print_battery(drone):
    async for battery in drone.telemetry.battery():
        print(f"Battery: {battery.remaining_percent}")

async def print_gps_info(drone):
    async for gps_info in drone.telemetry.gps_info():
        print(f"GPS info: {gps_info}")

async def print_in_air(drone):
    async for in_air in drone.telemetry.in_air():
        print(f"In air: {in_air}")

async def print_position(drone):
    async for position in drone.telemetry.position():
        print(position)

async def print_euler(drone):
    await drone.telemetry.set_rate_attitude(1)
    async for euler in drone.telemetry.attitude_euler():
        print(euler)

async def print_flight_mode(drone):
    async for flight_mode in drone.telemetry.flight_mode():
        print(flight_mode)

async def print_status_text(drone):
    async for status_text in drone.telemetry.status_text():
        print(status_text)

async def print_health(drone):
    async for health in drone.telemetry.health():
        print(health)

if __name__ == "__main__":
    # Start the main function
    asyncio.ensure_future(run())

    # Runs the event loop until the program is canceled with e.g. CTRL-C
    asyncio.get_event_loop().run_forever()

I'm using
mavsdk==0.15.0
python 3.8.6

I'm using
mavsdk==0.15.0
python 3.8.6

I have the same problem but for me it happens at 8 streams, 7 it is still working fine. From the 8th stream the Euler angles are frozen with small changes in the last digits. And for me, angular velocity values behaves the same, too.
My setup is Durandal FC, NVidia Jetson Nano companion computer and serial connection between them.

I have the same problem but for me it happens at 8 streams, 7 it is still working fine. From the 8th stream the Euler angles are frozen with small changes in the last digits. And for me, angular velocity values behaves the same, too.
My setup is Durandal FC, NVidia Jetson Nano companion computer and serial connection between them.

Thanks for the report. It's funny that it only impacts the euler angles :thinking:.
Would anybody feel like trying to reproduce this in C++? So that we would know if that needs to be debugged in Python or in C++ (MAVSDK-Python calls MAVSDK-C++) :see_no_evil:

Thanks for the report. It's funny that it only impacts the euler angles :thinking:.
Would anybody feel like trying to reproduce this in C++? So that we would know if that needs to be debugged in Python or in C++ (MAVSDK-Python calls MAVSDK-C++) :see_no_evil:

@Safranek42 mentioned that:

And for me, angular velocity values behaves the same, too.

@JonasVautherin @julianoes
I am also getting the issue of values freezing when I try to use more than 5-6 subscriber methods, here is the list of methods I am using at the sametime:
telemetry.gps_info()
telemetry.battery()
telemetry.health()
telemetry.health_all_ok()
telemetry.status_text()
telemetry.gps_info()
telemetry.raw_gps()
telemetry.attitude_euler()
telemetry.velocity_ned()
telemetry.position()
telemetry.flight_mode()
telemetry.in_air()
telemetry.armed()
telemetry.landed_state()
If I decrease the number of subscribers to 4, then the values are coming fine and not freezing.


vit imagenet training precision issues with amd w6800 gpu + rocm 5.0

per discussion in #2012, breaking this out into a stand-alone issue.
pip install "jax[tpu]>=0.2.16" -f https://storage.googleapis.com/jax-releases/libtpu_releases.html

# rollback to old scenic
git clone https://github.com/google-research/scenic.git
cd scenic
git reset --hard 791ffdd5d6e8fcb2b410ad2fb8c89701ce833c67
pip install .

The local python install will need a tweak at line 688 in ~/.local/lib/python3.8/site-packages/scenic/model_lib/base_models/model_utils.py
import functools
@functools.partial(jax.vmap, in_axes=[0, 0], out_axes=0)

After that, set the batch size to 128 in scenic/projects/baselines/configs/imagenet/imagenet_vit_config.py
python3 scenic/main.py  --config=scenic/projects/baselines/configs/imagenet/imagenet_vit_config.py --workdir=/OUTPUT_DIR

Per discussion in that thread, Nvidia/TPU devices converge to the same result at 100 epochs, whereas the AMD device (a w6800 with rocm 5.0) converges to a lower number (~80% accuracy of the tpu/nvidia baseline).  Per my notes, had similar difference with rocm 4.5 and the same GPU last year.
I am using this specific version of scenic in order to use the tf-dataset 5.1.0 version of imagenet (the dataset handlers were reworked in February).  Going to work on updating to the latest scenic soon.

@reza-amd
On the assumption that this is a numerical bug, I think the obvious debugging step would be to compare the numerical outputs of a single training step and see if they diverge significantly between AMD GPU and a reference implementation. If so, I would try to minimize the computation to a small reproducer.
(I unfortunately cannot help you with this myself, since I don't have access to the necessary hardware.)

I have pulled scenic forward to 86a01bc062f63e5495f7e632edc478e3facd497e and am running ablations there.  I cannot use the ROCm jax build script, see #10162.  Will try again with a more recent jax when I get a chance.

ROCm 5.2 working, will try again after https://github.com/google-research/scenic/issues/460 is resolved!

will try to reproduce with 5.7 or later!


Change /api/run/data endpoint to comply with HTTP spec

The HTTP POST verb response is defined in rfc7231 (https://datatracker.ietf.org/doc/html/rfc7231#section-4.3.3) as;
...the origin server
   SHOULD send a 201 (Created) response containing a Location header
   field that provides an identifier for the primary resource created created
   (Section 7.1.2) and a representation that describes the status of the
   request while referring to the new resource(s)....
...For cases where an
   origin server wishes the client to be able to cache the result of a
   POST in a way that can be reused by a later GET, the origin server
   MAY send a 200 (OK) response containing the result and a
   Content-Location header field that has the same value as the POST's
   effective request URI...

At present, a successful POST to  /api/run/data returns a response;
HTTP/1.1 200 OK
Set-Cookie: horreum.teams=user!dev-team;path=/;SameSite=Lax
Set-Cookie: grafana_user=user@example.com;max-age=60;path=/;SameSite=Lax
Content-Type: application/json
Location: /run/16
Content-Length: 2

If we want to keep the current semantics, I think we should change the Location header to a Content-Location header

I have no issue with changing this to 201, implemented in 78492e4f7651abbce9cd5595e39144f9662f5c66


Main clock gate potential timing issues

The top-level ibex clock gate (core_clock_gate_i) directly factors the debug_req_i and various irq signals into it directly.  This could cause timing issues in various implementations.  The enable into such a clock gate often needs to be an early signal especially as the gate itself will sit a few levels up the clock tree rather than at the same level as a gate for a set of flops.
One method to deal with this is to make the enable itself a flop (which is then clocked by the un-gated version of the clock).  Some care needs to be taken to ensure the enable actually switches the clock on at the appropriate point as it will be delayed one cycle vs the combinational implementation.
On the other hand if things are being clocked slowly enough it may be no problem!

This is also related to how we handle power-down in WFI (issue #258)

We haven't seen any timing issues with this in our OT synthesis runs, nor had any reports from external parties flagging it up as a problem.


final edits on Timesheet app blog post

Category

[x] Content fix
[ ] New article

Hi @LuiseFreese thanks for merging but looks like some of my images didn't come through properly. Anything I need to do to fix it? Darren


Fix windowing over time bugs

This PR fixes two windowing bugs:

Incorrect output when intermediate indexes in windowing-over-time operations are empty: #357

Make windowing-over-time output conform with Pandas windowing-over-time. E.g. The code below give output as 10, but the current output is 15.

from streamz import Stream
from streamz.dataframe import DataFrame
import pandas as pd

stream = Stream()

example = pd.DataFrame({"amount":[]})
sdf = DataFrame(stream=stream, example=example)

sdf.window("2h").sum().stream.sink(print)

stream.emit(pd.DataFrame({"amount":[5,5,5]}, index=[pd.Timestamp("2050-01-01 00:00:00"),
                                                    pd.Timestamp("2050-01-01 01:00:00"),
                                                    pd.Timestamp("2050-01-01 02:00:00")]))

@martindurant Does this look good now?

OK, accepting this. I feel like we could still use more testing here, there are probably more edges.

@martindurant, can we cut a release, please? Because these are pretty major windowing-over-time bugs we're seeing in our production pipelines.
Sorry for the continual tagging in advance!

0.5.6 now on pypi

Just curious, does the regro-cf-autotick-bot take care of the conda release automatically? I see that the previous releases were handled by the conda-forge streamz-feedstock.

Yes: https://github.com/conda-forge/streamz-feedstock/pull/13


Change the taskbar icon to the Google Music icon (or similar)

Currently Google Music Electron uses the generic "electron" icon for the taskbar item on Windows. It would be much nicer if it used a non generic "Google Music inspired" icon instead.

I don't follow your example -- the icon should be a pair of headphones in the tray. Can you provide a screenshot?

I was referring to the "taskbar" icon, not the taskbar icon. This also applies to the "window icon", i.e. the one that is shown (on Windows) on the top left side of the window title bar, and which when clicked shows the "Restore, Move, Size, Close" dialog. Both icons show the generic, green-blue "electron icon". It would be nicer if it showed a music inspired icon instead (e.g. the one on the

system tray).

Ah, nice catch. Yea, we should add support for that.

Cool. Nice to see that you understood what I meant even though I said "I was referring to the "taskbar" icon, not the taskbar icon" when I meant "I was referring to the "taskbar" icon, not the system tray icon" :-)

Taking a look at this now

This has been patched/released in 1.20.0. I think we might need larger icons since it's being scaled up in the Windows tray but I would like to se what size OS X needs as well.


NEXT-8984 - Mobile Offcanvas Menu triggers underneath Actions

Description: If the Fitler on Mobile are open and you want to close it but the Filter button is directly under the Close Button of the Offcanvas both are triggered. The Close Button is triggered and the Offcanvas is closed. But after less then a second the Filter Button is triggered too, which causes the Offcanvas to open up again.
This Problem can be reproduced with all the Offcanvas if a any kind of action is placed underneath.
Environment: Shopware 6.2
Steps to reproduce: Scroll till the mobile Filter Button is located where the offcanvas close button will appear, once you find the right spot open the offcanvas and close it again.
Expected result: Offcanvas should close.
Actual result: Offcanvas closes and opens right after

Cannot reproduce this in Linux Chromium 85.0.4183.102 and Firefox 80.0.1.


[AutoRelease] t2-containerservicefleet-2024-09-26-88968(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/5520
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=982
BuildTargetingString
azure-mgmt-containerservicefleet
Skip.CreateApiReview

issue link:https://github.com/Azure/sdk-release-request/issues/5520


Fix for when factory class does not exist

Summary
Laravel artisan make:model generates a model which is automatically given the HasFactory trait.
If the Factory class has not also been created, an error is thrown causing model analysis to stop. This pull request checks if an error is thrown when looking for the factory class, and returns if one is found.
Not sure if you require a test for this or not. Let me know and I will look at adding one.
Type of change
[ x ] Bug fix (non-breaking change which fixes an issue)

I think it's good to silently fail, it's not our job to fix/detect problems imho

Forgive me, but I don't quite understand.
The check which laravel-ide-helper does to see if the helpers should be used is by looking for the inclusion of the HasFactory trait. If i run:
php artisan make:model Book

then the model file is created, with the HasFactory trait automatically added, but no factory is generated. If I run php artisan ide-helper:models at that point, no model properties will be generated for the new Book model, as it fails at the point which factories are checked for.
It seems that the script shouldn't stop when the factory isn't found, but should continue to generate model properties as normal.
Alternatively, there could be a different check for the use of a factory? Happy to amend the pull request if there is a preferred fix.
The only other remedy I can think of is to either create a Factory class for every model or manually remove the HasFactory trait from each model which doesn't have a factory class already.

Yeah I meant to say I approve this PR

Ah, apologies. Thanks very much

Sorry, I did not notice that the issue was solved here but i think we don't need to call factory() merthod because it create a new instance regardless of whether the factory is exist or not.
anyway the default namespace of the factories is \Database\Factories and if anyone need to customize it will use newFactory() method so I created a new PR. to resolve this. #1196

Thank you for the PR, though after considering we went with https://github.com/barryvdh/laravel-ide-helper/pull/1196 !

No problem. Apologies for the delay in adding tests etc. The other solution seems to work nicely.
Thanks for the feedback.


rust-script exports CARGO_TARGET_DIR to script process

I have a rust-script that calls cargo install --path . as a child process. I expected that process to create a target directory, but that didn't happen. IIUC, this is because rust-script sets CARGO_TARGET_DIR to ~/.cache/rust-script/binaries. It also seems to set a bunch of other cargo related environment variables.
I think this is a bug, since cargo commands from within a rust-script should work the same way as they would if executed from outside of a rust-script. I would expect rust-script to not modify the environment of the script process in any way. (Except maybe for some variables prefixed with RUST_SCRIPT_ for some reason.) Or is this somehow necessary to make rust-script work?

I believe you are right, and we should use the --target-dir CLI option to avoid exporting CARGO_TARGET_DIR.
Does https://github.com/fornwall/rust-script/pull/28 look ok and work for you?

Yes, we should probably use the --target-dir cargo CLI option instead of exporting the CARGO_TARGET_DIR environment variable. Does https://github.com/fornwall/rust-script/pull/29 look ok and work for you?
Thanks for reporting!

Hi @fornwall! Thanks for the quick fix.
Yes, just tested this in my scenario and it does work. Awesome!
It'd be great to also get this released on crates.io.
And finally, thanks a lot for working on rust-script, I use it all the time with great joy!

Great! Version 0.16 that includes this change is now published on crates.io: https://crates.io/crates/rust-script/0.16.0

Great! Just tested that the released version also works. Thanks a lot for the quick release! :tada:


Sign on Ledger does not work

I am using polkadot.js with my ledger and I want to teleport some KSM to Statemine chain. But when I press "Sign on Ledger", I get the error message "Not supported".
Parity Polkadot v0.9.13
api v6.11.1
apps v0.98.2-142
ledger kusama app v8.9130.0

We have already upgraded to v8.9130 and provided the changes to Ledger two weeks ago.
Reference: https://github.com/LedgerHQ/app-kusama/pull/14
have you tried upgrading your device?

already using v8.9130 still showing not supported.
<img width="574" alt="ksm" src="https://user-images.githubusercontent.com/96330747/147662830-81a5450e-e7a6-4565-83b2-c5c199822719.PN

G">

already using v8.9130 still showing not supported.


Change Koji URLs used in staging

recheck

Why not make this become part of packit-service configs?

Do you mean to have koji_build_logs_url and koji_build_web_url in the config?

Do you mean to have koji_build_logs_url and koji_build_web_url in the config?

Yes, exactly. Though I'm not sure how much that would complicate things.


Responsiveness Issue (1024x768)

Aqui está normal

Here there is a problem rendering the image ("Draft Code Hero Image React") and it is exceeding the maximum width of the content... Try adjusting its proportions using % or try adjusting using Flex.

It worked to adjust the maximum width!

It worked to adjust the maximum width!


Correcting concentrations using density information

use debugging and a full walkthrough.  Develop a test for this would be helpful too!

Using the actual amounts of chemicals in a given reagent (grams and milliliters of chemicals) we can make a close approximation of the total volume of the solution after the addition of chemicals.  This approximation was demonstrated by Josh.  More information coming.
I will type out the necessary changes and a summary of the places where things are needed to be changed and the collaborators where the changes are needed.  This will include the formulas for the density calculations and associated with change for corrected density calculations.

The relevant work showing the models for calculating concentration can be found here:
https://www.wolframcloud.com/objects/jschrier0/Published/2019.06.08_volume_correction.nb
denoted all of the newly added concentration information as v1-conc and v1-mmol and v1-M
These values have been added to the dataframe and are undergoing debugging.  Historical conversation record can be retraced here:
Joshua Schrier [Jun 8th at 12:26 PM]
In today's episode of perovskite mythbusters, we've demonstrated a solution to our known problem (for the past year!) that we compute stock solution concentrations (and subsequent values used for ML) in the wrong way.  A simple algebraic model that uses experimental densities of the pure solids from CSD is sufficient to correct this to the level of precision measured in stock solution preparation at LBL.  A full writeup, including action items is in the notebook:
https://www.wolframcloud.com/objects/jschrier0/Published/2019.06.08_volume_correction.nb
this episode is brought to you by a saturday morning cappucino at Prince Coffee
10 replies
Joshua Schrier  [9 days ago]
Fwiw, I remember Emory suggested this would work well, back in December.
Ian Pendleton  [9 days ago]
Solid demonstration.  Thank you for putting this together.  Ill think about what changes are needed to the current code and if we can get a volunteer ill help them push the update.
Ill think about this over the next couple days.  Really cool and way easier than alternatives.  Super excited to put this problem behind us.
Ian Pendleton  [9 days ago]
I agree that this is a top priority and the problem looks tractable given our team.
Ian Pendleton  [9 days ago]
I also really appreciate all of the comments in the notebook.  Thank you Josh!
Ian Pendleton  [9 days ago]
@jschrier @GaryC  Can we aim to discuss next steps and challenges with the dev team and invested interested parties asap? -- particularly with attention to easy ones to overcome that are high impact?  This problem had the potential to sprawl, but the model1 fixes are high impact and straight forward to fix.  Im pumped, this is compelling and looks really easy!  Whoot.
Joshua Schrier  [9 days ago]
FWIW: Model 2 does away with experimental data entirely...just atomic structures and van der Waals spheres. I suspect it would be 4 lines in Mathematica 12, but I'm still on 11.3 because it breaks ECL.  Also I ran out of cappuccino.  But its far more complicated to implement in python (and at least 4x as complicated in Mathemica :slightly_smiling_face: ), and model 1 is more in line with existing ESCALATE infrastructure, especially the chemical inventory.  So let's just stop there. (edited)
Joshua Schrier  [9 days ago]
You'll notice that the volume model could be described by a dot product of the vector of masses (for each component) with the correspondingly ordered vector of [molar volumes]=[1/density] (for each component)
Joshua Schrier  [9 days ago]
I don't suspect we need any extensive "all-hands" meetings. If @ipendlet and @GaryC want to chat briefly for 15 minutes, then lets do so on Monday, ~ 12:45. @ipendlet is probably the right human for this particular job (with @Michael Tynes as a backup), as there is some chemistry knowledge involved.  Everyone else can continue as usual. (edited)
Joshua Schrier  [9 days ago]
Actually, the person we really want in the room is @Mansoor Ani, because all the stock solution definitions in the Chemical Inventory page are expressed in these "fake" molarities, and we'll need to be careful about correcting that (or move entirely to a mass-based definition of the stock solutions)
Joshua Schrier  [9 days ago]
It also opens up the posibility that the stock solutions we are using now (which have the lowest amount of GBL) are not necessarily the highest concentration of PbI2 (once we apply the volume corrections). But we can check that.

Copy of notebook.
2019.06.08_volume_correction.nb.zip

How non-ideality is a minimal issue (continuation of the investigation of model 2 in the previous notebook) https://www.wolframcloud.com/obj/jschrier0/Published/2019.06.11_nonideal_mixing_gbl_fah.nb


redis.clients.jedis.exceptions.JedisDataException: Please close pipeline or multi block before calling this method.

Hello,
I am batching some commands using pipelining and I sync them with a timer.
Scenario:

Pipeline commands to redis (in process() method)
JedisConnectionException occurs (inside flush(), return Jedis resource)
Pipeline new commands by re-using the same pipeline with pipeline.setClient(mJedis)
On performing sync() on the pipeline, Jedis throws the below exception
redis.clients.jedis.exceptions.JedisDataException: Please close pipeline or multi block before calling this method.

void process() {
    mPipeline.evalsha(...);
    // other application code
}

// Timer based flush
void flush() {
    try {
        if (mJedis == null) {
            mJedis = sJedisPool.getResource();
            mPipeline.setClient(mJedis);
        }
        mPipeline.sync();
    } catch (JedisException je) {
        mJedis.close();
        mJedis = null;
    }
}

I do not want to lose the already pipelined commands, so i do not do mPipeline=mJedis.pipelined() inside flush()
Jedis version:
2.9.0
Redis version:
3.2.6
Java version:
1.9

Please ask this question in the mailing list. github is used for design discussions and bugs mainly.
http://groups.google.com/group/jedis_redis

@marcosnils : Thanks for pointing to the google group, I have posted it there. Can you please answer it?
https://groups.google.com/forum/#!topic/jedis_redis/1UM6z-lYMwg

Actually I have simple question regarding Jedis behaviour: When we are in Pipeline, should the commands set zadd etc throw JedisConnectionException before sync() operation is fired (i know it may not be possible because we haven't sent the data across)?
I pipeline several thousand commands before firing sync() and if this command returns JedisConnectionException, I have no way of retrying the previous command.


Concept for expressing reputation policy & data

	"name": "reputation"
	"repsystem": "https://fulmo.org/bos-score.html"
	"ratings": "https://fulmo.org/bos-score.csv""

The "repsystem" label and values could be bikeshed in that instead of URLs, there could be an ID # system and resource looking up the specs for any registered reputation system...
The "ratings" would be a list of all ratings the LSP currently has available. If the rep system uses cryptographically signed ratings, then this list could include ratings from any peer about any other peer, as they are all verifiable.
Peers could check for updates to the ratings list and add new ratings to the list after each order, or channel close, or any reason they want that fits the chosen reputation system.
This is the most basic reputation API I could think of. You simply share which system you use, and any ratings you want to share that abide by that system.
Next elaboration might be to support expressing multiple systems and multiple lists, then map schemas and weightings for schemas, systems, and peers. (web of trust)

@BitcoinErrorLog would you have separate schema for reputation, or would you nest that under existing policies

closing as its obsolete/implemented elsewhere


Move to node16 from node12

Fixes #232

This PR assumes that you create a new release barecheck/code-coverage-action@v2 after merging.

Hey @rvalitov! Thanks for making this contribution!
Changes look good, is there a specific reason why we need v2 version? If it's backward compatible with everything we already have I think we can keep v1 without asking everyone to upgrade.

I followed the way how all other GitHub Actions repositories handled this situation. They released a new version. I'm not sure if there was some specific reason, because it's backward compatible. But are you sure you can rerelease an action without changing a version? I'm not sure about GitHub Actions, but some repositories do not allow to modify existing release, the only way is to make a new version. What do you think?

What we have here, instead of the version we use the branch - Basically, all code updates inside the branch will be applied. Basically, if you just followed the docs and used:
- name: Generate Code Coverage report
  id: code-coverage
  uses: barecheck/code-coverage-action@v1
  with:
    barecheck-github-app-token: ${{ secrets.BARECHECK_GITHUB_APP_TOKEN }}
    lcov-file: "./coverage/lcov.info"
    base-lcov-file: "./coverage/base-lcov.info"
    send-summary-comment: true
    show-annotations: "warning"

Just by merging it will work, I just tested and changed seem fine so I am deploying this new version, try to just rerun action on your side and see if everything is fine ;)


Update pom.xml

Fixes #issue

It's a good idea to open an issue first for discussion.

[ ] I have followed Sample Format Guide
[ ] pom.xml parent set to latest shared-configuration
[ ] Appropriate changes to README are included in PR
[ ] API's need to be enabled to test (tell us)
[ ] Environment Variables need to be set (ask us to set them)
[ ] Tests pass:   mvn clean verify required
[ ] Lint  passes: mvn -P lint checkstyle:check required
[ ] Static Analysis:  mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
[ ] Please merge this PR for me once it is approved.

@Prem51 I'm assuming you opened this PR in error.


[$250] Web - Chat - Temporary thread message disappearance when deleting a thread message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.58-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/
Open a chat
Send a message in the chat
Click on "Reply in thread" to create a thread message
Delete the threaded message

Expected Result:
A thread message should remain visible and not disappear after deleting it
Actual Result:
When the user deletes a thread message, it disappears for a short while and then reappears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/3c526c02-1b86-4831-8557-40220d894b0d
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021856693071374545175
Upwork Job ID:<PHONE_NUMBER>374545175
Last Price Increase: 2024-11-20

Issue OwnerCurrent Issue Owner: @thesahindia

Proposal
Please re-state the problem that we are trying to solve in this issue.
when a user delete a thread comment, it takes time for "Deleted message" to display
What is the root cause of that problem?
here: https://github.com/Expensify/App/blob/6d4c6bd95976dec1eff4f1a70c16c4980bf428ff/src/libs/actions/Report.ts#L1452-L1460
we are setting this in the pending action, which cause the issue:
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
What changes do you think we should make in order to solve the problem?
if we want to immediately display the "Deleted message" , set that pendingAction to null

Proposal
Please re-state the problem that we are trying to solve in this issue.
When the user deletes a thread message, it disappears for a short while and then reappears
What is the root cause of that problem?
This arises from https://github.com/Expensify/App/pull/43518, the reportID now contains the reportID of the report where the action belongs to (the ancestor tree is lifted 1 level above).
So when we delete the comment, reportID does not point to the current thread report >> isDeletedParentAction is false because it compares the reportID with childReportID >> Comment is hidden instead of [Deleted message]:
https://github.com/Expensify/App/blob/77b483c50f3669540fa37b530afd87ba709baf3a/src/libs/actions/Report.ts#L1433
https://github.com/Expensify/App/blob/e05545549299f2f0ce6117cbfb62b97fbf15d39a/src/pages/home/report/ReportActionItemFragment.tsx#L108-L110
What changes do you think we should make in order to solve the problem?

Let's hold this for https://github.com/Expensify/App/pull/51721 where they introduced isThreadFirstChat prop. This will help determining isDeletedParentAction based on whether it is rendered by ReportActionItemParentAction instead of relying on reportID.

Updated Proposal
Please re-state the problem that we are trying to solve in this issue.
When the user deletes a thread message, it disappears for a short while and then reappears
What is the root cause of that problem?
This arises from https://github.com/Expensify/App/pull/43518, the reportID now contains the reportID of the report where the action belongs to (the ancestor tree is lifted 1 level above).
So when we delete the comment, reportID does not point to the current thread report >> isThreadParentMessage is false because it compares the reportID with childReportID >> shouldHideOnDelete is true causing the message to be hidden for a while:
https://github.com/Expensify/App/blob/cfc41bc42ba95bd6928d4e2456c460f6366e0c43/src/pages/home/report/ReportActionItem.tsx#L1015
What changes do you think we should make in order to solve the problem?

Thanks to https://github.com/Expensify/App/pull/51721, we don't rely on reportID to check for isThreadParentMessage which is no longer correct. Instead, we use isThreadReportParentAction which is  based on whether it is rendered by ReportActionItemParentAction.
So we need to update:
shouldHideOnDelete={!isThreadReportParentAction}

@thesahindia Part of the root cause is still correct but I adjusted the solution. Please check again.

Still working through proposals

Waiting for assignment from @marcochavezf.

Thanks for the review @thesahindia! Assigning @mkzie2 🚀

@thesahindia The PR is here.

Payment summary:

Contributor: $250 for @mkzie2 via Upwork
Reviewer: $250 for @thesahindia via New Expensify

Contributor has been paid out.


The email is not returning while sign in with Facebook.

Describe the bug
I've passed the email in the scope but still didn't get it while sign in with Facebook.
To Reproduce
Steps to reproduce the behavior:
<LoginSocialFacebook
appId={process.env.REACT_APP_FB_APP_ID || 'key'}
scope="public_profile, email, user_birthday"
fieldsProfile={
'id,first_name,last_name,middle_name,name,name_format,picture,short_name,gender,email'
}
onLoginStart={() => {
console.log("Login STart : ");
}}
redirect_uri={REDIRECT_URI}
onResolve={({ provider, data }: IResolveParams) => {
console.log("Provider : ", provider);
console.log("Data : ", data);
}}
onReject={err => {
console.log("Error Facebook : ", err);
}}
return_scopes
>
<Button
className="meta-button"
variant="outlined"
startIcon={svgIcon("metaIcon")}
disabled={!isLocationAllowed}
>
Sign in with Meta

Expected behavior
Other than email I'm getting all the fields.
Screenshots

Additional context
Do we need business verification for getting an email while sign in with faceook?.

Have you tried logging in https://react-social-login.netlify.app?

Yes, I'm able to login in that website. But can you please let me know then what I missed in my code?

Sure. It is my code:
<LoginSocialFacebook
	appId={""}
	onLoginStart={onLoginStart}
	fieldsProfile={"id,first_name,last_name,middle_name,name,name_format,picture,short_name,email"}
	redirect_uri={REDIRECT_URI}
	onResolve={({ provider, data }) => {}}
	onReject={(err) => { console.log(err); }}
>
	<FacebookLoginButton />
</LoginSocialFacebook>

Lets me know if it works

Still not able to get an email, do we need to require business verification for email permission?

I am not sure, maybe you need to configure your Facebook application

I've already configured it but not sure why it's not returning

Have you added email in the permission config?

Yes but in the document it says we don't require business verification for email permission but I think you did it that's why it's auto granted.

Oh, yes. For a long time, I don't create any new applications on Facebook, a lot of policies have been updated, but you can try to verify the business email.

Yes let me try that.

Ok, now I will close this issue due to it doesn't relevant to the library. Please comfortable continuing this thread if you have any questions.