Adds T00:00:00+00:00 after date in YYYY-MM-DD format

We're testing this plugin for use with a large spreadsheet and noticed that the Begin Date and End Date fields end up with T00:00:00+00:00 in ArchivesSpace after the date in YYYY-MM-DD format. This doesn't happen for YYYY or YYYY-MM date types.
Is there a workaround or something we're doing wrong that's causing this? I can clean it up in the EAD after export but would prefer to not have it in AS in the first place if possible.
Thank you!

Hi,
I'll take a look at this ASAP, and get back to you; the code may not be triggering the correct conversion algorithm.

@amberjewel : With the very small test case I created
test_dates.xlsx
I was unable to reproduce your issue.  Which version of ArchiveSpace are you working with?  Would you be able to attach an example of your spreadsheet?
Thanks,
Bobbi

Hi, the attachment didn't come through :-(
(I tested on v1.5.3, btw, but that shouldn't have mattered...)

I've attached it again. Hopefully it will go through this time. It looks
like it's successfully attached to the e-mail. I can try it another way if
need be.
On Tue, Sep 19, 2017 at 11:48 AM, Bobbi Fox at Harvard LTS <
<EMAIL_ADDRESS>wrote:

Hi, the attachment didn't come through :-(
(I tested on v1.5.3, btw, but that shouldn't have mattered...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-330634933,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUOduEilU6_numvz6H12Wf4hJK7dZks5skAx-gaJpZM4PcvER
.

aspace_import_excel_test2.xlsx

There we go. I'm adjusting to GitHub as a user - I've only ever lurked before.

Got it!  I may not be able to get back to you before tomorrow.
Cheers,

Thank you. We're trying to test this every which way before we go live with the plugin, and I appreciate any assistance.

Testing every which way is a good idea 😄
Here's what I see so far:
In my tiny test, the date cell is formatted as "general".
In your spreadsheet, the date cell is formatted as "Custom" "Type: yyy-mm-dd"  I'm not an excel guru (she's out today 🙁 ), so I don't know what the customizing does, but perhaps behind the scenes those yyy-mm-dd becomes a DateTime object, resulting in that time information being included when my code comes to process it, whereas perhaps when it's general, it comes through to my code as a date simple string?
I see that when I try to add a row in your spreadsheet, it converts 1984-04-06 to a Date, no matter what I do about it!  This doesn't happen with my spreadsheet; I don't know enough about Excel to know how to turn it off!
Hopefully tomorrow I can grab a small amount of our Excel guru's time, because if we can figure out how to turn that off, it will go faster for you than waiting for me to make a change in the ingest code, test it, put it up on GitHub, etc.
Til tomorrow,
Bobbi

Hi Bobbi,
Thanks! We've been having trouble with the date fields for the exact same
reason. Our Excel guru hasn't been able to turn off the automatic date
feature, so I hope yours has some suggestions.
Thank you again for looking into this!
Amber
On Tue, Sep 19, 2017 at 12:59 PM, Bobbi Fox at Harvard LTS <
<EMAIL_ADDRESS>wrote:

Testing every which way is a good idea 😄
Here's what I see so far:
In my tiny test, the date cell is formatted as "general".
In your spreadsheet, the date cell is formatted as "Custom" "Type:
yyy-mm-dd" I'm not an excel guru (she's out today 🙁 ), so I don't know
what the customizing does, but perhaps behind the scenes those yyy-mm-dd
becomes a DateTime object, resulting in that time information being
included when my code comes to process it, whereas perhaps when it's
general, it comes through to my code as a date simple string?
I see that when I try to add a row in your spreadsheet, it converts
1984-04-06 to a Date, no matter what I do about it! This doesn't happen
with my spreadsheet; I don't know enough about Excel to know how to turn it
off!
Hopefully tomorrow I can grab a small amount of our Excel guru's time,
because if we can figure out how to turn that off, it will go faster for
you than waiting for me to make a change in the ingest code, test it, put
it up on GitHub, etc.
Til tomorrow,
Bobbi
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-330656051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUNWucEqy36lDEpmzgSzBa74uEpxdks5skB0agaJpZM4PcvER
.

Hi, Amber,
Just as I was getting ready to go home for the night, a different Excel guru cruised by.
She suggested that the automatic date stuff might be caused by you using a different version of Excel than the one we used to create the template.  Some investigation showed that the begin and end date columns are defined in our template as having the format "General"; if the columns are set to "Text", the automatic date stuff doesn't happen!
It will take me a little while tomorrow to get the enhanced template up on github (there is a vetting process, like doing some testing, you know 😃 ).  Be warned that if (at least in the version of Excel I'm using) you change the formatting of those columns with cells of the YYYY-MM-DD format already entered, you'll get some VERY strange results.

Hi Bobbi,
Thanks! I was starting suspect a version issue might be at the heart of the
situation. I was playing around with those dates and also got the very
strange results when I tried to change them to general with the dates
already inside.
By the way, I just tested the plugin with an almost 12,000 row spreadsheet,
and I have to say that this plugin is fantastic. I appreciate all of the
work that went into it because it's making the work at our small shop
infinitely easier for a huge finding aid on a tight deadline.
On Tue, Sep 19, 2017 at 1:25 PM, Bobbi Fox at Harvard LTS <
<EMAIL_ADDRESS>wrote:

Hi, Amber,
Just as I was getting ready to go home for the night, a different Excel
guru cruised by.
She suggested that the automatic date stuff might be caused by you using a
different version of Excel than the one we used to create the template.
Some investigation showed that the begin and end date columns are defined
in our template as having the format "General"; if the columns are set to
"Text", the automatic date stuff doesn't happen!
It will take me a little while tomorrow to get the enhanced template up on
github (there is a vetting process, like doing some testing, you know 😃
). Be warned that if (at least in the version of Excel I'm using) you
change the formatting of those columns with cells of the YYYY-MM-DD format
already entered, you'll get some VERY strange results.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-330662918,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUCcRrlkGYcAlfVlEEeT9TUCjoMsgks5skCNNgaJpZM4PcvER
.

Hi, Amber,
In one of those "D'OH!" moments, it occurred to me that I could upload the revised template here, so you could try it out.  Here you go!  You Get It First 😃
aspace_import_excel_template.xlsx
And thanks for your kind words; it's so rewarding to be working on something people actually use and need.

Thank you! I might have a chance to try it out this afternoon.
On Wed, Sep 20, 2017 at 11:26 AM, Bobbi Fox at Harvard LTS <
<EMAIL_ADDRESS>wrote:

Hi, Amber,
In one of those "D'OH!" moments, it occurred to me that I could upload the
revised template here, so you could try it out. Here you go! You Get It
First 😃
aspace_import_excel_template.xlsx
https://github.com/harvard-library/aspace-import-excel/files/1318791/aspace_import_excel_template.xlsx
And thanks for your kind words; it's so rewarding to be working on
something people actually use and need.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-330939641,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUG-5glFu_zVdFCuMN9lRkGrJoApyks5skVjlgaJpZM4PcvER
.

I wanted to let you know that we did get a chance to check out the new
version of the spreadsheet, and our versions of Excel did not override the
date columns this time around, so using Text instead of General was a
definite success.
I haven't had a chance to get a spreadsheet into our test instance of AS,
though, because systems is testing the upgrade to 2.0 at the moment. Out of
curiosity, do you have any idea if the plugin will work with 2.0 or above?
On Wed, Sep 20, 2017 at 11:56 AM, Amber D'Ambrosio <
<EMAIL_ADDRESS>wrote:

Thank you! I might have a chance to try it out this afternoon.
On Wed, Sep 20, 2017 at 11:26 AM, Bobbi Fox at Harvard LTS <
<EMAIL_ADDRESS>wrote:

Hi, Amber,
In one of those "D'OH!" moments, it occurred to me that I could upload
the revised template here, so you could try it out. Here you go! You Get It
First 😃
aspace_import_excel_template.xlsx
https://github.com/harvard-library/aspace-import-excel/files/1318791/aspace_import_excel_template.xlsx
And thanks for your kind words; it's so rewarding to be working on
something people actually use and need.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-330939641,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUG-5glFu_zVdFCuMN9lRkGrJoApyks5skVjlgaJpZM4PcvER
.

Hi, Amber,
The plugin should work with 2.x (at least I coded it to do so, and tested it locally!).
Cheers,
Bobbi

Hi Bobbi,
That's great to hear. Once again, you have my deepest appreciation for what
you have done here with this plugin.
Cheers!
Amber
On Mon, Sep 25, 2017 at 8:17 AM, Bobbi Fox at Harvard LTS <
<EMAIL_ADDRESS>wrote:

Hi, Amber,
The plugin should work with 2.x (at least I coded it to do so, and tested
it locally!).
Cheers,
Bobbi
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-331914569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUOlbp6Dmbp6J5aYq_D7jjeb-yQCFks5sl8QWgaJpZM4PcvER
.

Hi Bobbi,
I have a follow-up question about the plugin. We were able to load a
spreadsheet of almost 12,000 rows once successfully but since then have
kept bumping into what seems to be a time-out error of some sort as we test
further. This doesn't happen with spreadsheets of 5000 rows or fewer. Are
there any settings in any of the code or in AS that we might be able to
manipulate to avoid that?
We can break the spreadsheet into smaller chunks if need be, but I thought
I'd check first since it did work once. When it worked our test instance
was still on v1.5.4 but now is on v2.0. Systems is going to upgrade us to
v2.1.2 soon to see if that has any impact.
I appreciate any insight you might have.
Amber
On Mon, Sep 25, 2017 at 8:28 AM, Amber D'Ambrosio <
<EMAIL_ADDRESS>wrote:

Hi Bobbi,
That's great to hear. Once again, you have my deepest appreciation for
what you have done here with this plugin.
Cheers!
Amber
On Mon, Sep 25, 2017 at 8:17 AM, Bobbi Fox at Harvard LTS <
<EMAIL_ADDRESS>wrote:

Hi, Amber,
The plugin should work with 2.x (at least I coded it to do so, and tested
it locally!).
Cheers,
Bobbi
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-331914569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUOlbp6Dmbp6J5aYq_D7jjeb-yQCFks5sl8QWgaJpZM4PcvER
.

Hi Amber,
I'm Dave, a co-worker of Bobbi's.  Would you be able to provide us with the spreadsheet?
I think what's happening is that you're hitting the time-out just because something in 2.x got slower or similar, and just fell past the boundary.  I'd like to verify this; it certainly might be something else, after all.  If that is the problem, chunking it up is probably the right move; I don't think there's really a meaningful way to stream-process Excel files, afaik.

Hi Dave,
I'm attaching the latest version of the spreadsheet. Thank you for looking
into this.
On Wed, Sep 27, 2017 at 11:16 AM, pobocks<EMAIL_ADDRESS>wrote:

Hi Amber,
I'm Dave, a co-worker of Bobbi's. Would you be able to provide us with the
spreadsheet?
I think what's happening is that you're hitting the time-out just because
something in 2.x got slower or similar, and just fell past the boundary.
I'd like to verify this; it certainly might be something else, after all.
If that is the problem, chunking it up is probably the right move; I
don't think there's really a meaningful way to stream-process Excel files,
afaik.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/harvard-library/aspace-import-excel/issues/9#issuecomment-332610471,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANcrUJum9lNSQ6mYh7MSR324R1K1UHSaks5smpD-gaJpZM4PcvER
.

Hmm, if it's attached here, I think github swallowed it - if you want to email it to dave UNDERSCORE mayo AT harvard DOT com, I'll poke at it (maybe tomorrow!)

At harvard DOT edu, that is!
From: pobocks<EMAIL_ADDRESS>Reply-To: harvard-library/aspace-import-excel<EMAIL_ADDRESS>Date: Wednesday, September 27, 2017 at 3:09 PM
To: harvard-library/aspace-import-excel<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [harvard-library/aspace-import-excel] Adds T00:00:00+00:00 after date in YYYY-MM-DD format (#9)
Hmm, if it's attached here, I think github swallowed it - if you want to email it to dave UNDERSCORE mayo AT harvard DOT com, I'll poke at it (maybe tomorrow!)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_harvard-2Dlibrary_aspace-2Dimport-2Dexcel_issues_9-23issuecomment-2D332625050&d=DwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=4JGa5VtTknXYK4u1_QXigeqoIeLZKZx44Vc_775eJ9Q&m=iR-58104wF7tR0ed0Z6q4LpxuN5acbf7INZVYWCiERo&s=9GOJl9tIDgTjyDzF2OcgkN2OJlkGtyZNSqMGzZwp_aE&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADhpb5I-5FMOLDxuSfRjM0Cy6cH4uKVJ0zks5smp1wgaJpZM4PcvER&d=DwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=4JGa5VtTknXYK4u1_QXigeqoIeLZKZx44Vc_775eJ9Q&m=iR-58104wF7tR0ed0Z6q4LpxuN5acbf7INZVYWCiERo&s=HlCDCCRPm69rup2IAoB8EGQO-9e9XyGIekX82XVa1UM&e=.

I've committed the template spreadsheet; now at v1.4.


Unable to set downstream headers on websocket requests

1. What version of Caddy are you using (caddy -version)?
Caddy 0.10.10 (+5cca9cc Mon Nov 06 01:47:44 UTC 2017) (unofficial)
commit 5cca9cc18e9935de16be7991ae26d490e8030a2c
2. What are you trying to do?
downstream_header Server "caddy" for websocket
3.   Please paste any relevant HTTP request(s) here.
General:
Request URL:ws://localhost:9999/CCMWa/signalr/connect?transport=webSockets&clientProtocol=1.4&connectionToken=tq2ydI4ZC6kXwEpc%2B1WizvNGPQNjxkgJ1pAdfIbE7892bJILr1gJNIeU50EAn7q4XeFy%2BoUOTWzTbBI%2B3c1Tvw%2F4PVskz0dM3gvytodrAQYqr%2BRsV3eod3eVluRe6RYj&connectionData=%5B%7B%22name%22%3A%22chat%22%7D%2C%7B%22name%22%3A%22queuestatistics%22%7D%5D&tid=2
Request Method:GET
Status Code:101 Switching Protocols

Response Headers:
Access-Control-Allow-Headers:Origin, X-Requested-With, Content-Type, Content-Language, Accept, Accept-Language
Access-Control-Allow-Methods:GET, HEAD, POST, PUT, OPTIONS
Access-Control-Allow-Origin:*
Connection:Upgrade
Date:Mon, 06 Nov 2017 02:17:30 GMT
Sec-WebSocket-Accept:uu+DllUD6caQQ9tlvD5X/ZCYJOY=
Server:
Upgrade:Websocket
X-Content-Type-Options:nosniff
X-Content-Type-Options:nosniff
X-Frame-Options:SAMEORIGIN
X-XSS-Protection:1; mode=block

Request Headers:
Accept-Encoding:gzip, deflate, br
Accept-Language:en-AU,en;q=0.9,en-GB;q=0.8,en-US;q=0.7,de;q=0.6
Cache-Control:no-cache
Connection:Upgrade
Cookie:grafana_user=shannon.wynter%40neds.com; grafana_remember=94c88da44134363b075d452b9f7b6ccb3282e781ff0d328b8f871e9a9d23d34c3350e1b31fd1b8b8af0c80a6fdc20840238db8; grafana_sess=caa53f948340d4c3
DNT:1
Host:localhost:9999
Origin:http://localhost:9999
Pragma:no-cache
Sec-WebSocket-Extensions:permessage-deflate; client_max_window_bits
Sec-WebSocket-Key:kTzJNd28kGCJ9bz7HyHXFw==
Sec-WebSocket-Version:13
Upgrade:websocket
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.75 Safari/537.36

6. What did you expect to see?
The empty server header sent by the buggy microsoft service getting set to "caddy"
7. What did you see instead (give full error messages and/or log)?
The empty server header is still an empty server header
8. How can someone who is starting from scratch reproduce the bug as minimally as possible?
Caddy config:
http://localhost:9999 {
        proxy / http://localhost:9991 {
                header_downstream Server "caddy"
                header_upstream Connection {>Connection}
                header_upstream Upgrade {>Upgrade}

                header_upstream Host {host}
                header_upstream X-Real-IP {remote}
                header_upstream X-Forwarded-For {remote}
                header_upstream X-Forwarded-Proto {scheme}
        }
}

Go source:
package main

import (
	"flag"
	"html/template"
	"log"
	"net/http"

	"github.com/gorilla/websocket"
)

var upgrader = websocket.Upgrader{}
func hi(w http.ResponseWriter, r *http.Request) {
	// Emulate dodgy windows server
	c, err := upgrader.Upgrade(w, r, map[string][]string{"Server": []string{""}})
	if err != nil {
		log.Print("upgrade:", err)
		return
	}
	c.Close()
}

func home(w http.ResponseWriter, r *http.Request) {
	homeTemplate.Execute(w, "ws://"+r.Host+"/hi")
}

func main() {
	flag.Parse()
	log.SetFlags(0)
	http.HandleFunc("/hi", hi)
	http.HandleFunc("/", home)
	log.Fatal(http.ListenAndServe("localhost:9991", nil))
}

var homeTemplate = template.Must(template.New("").Parse(`
<!DOCTYPE html>
<html><head><meta charset="utf-8"><script>
window.addEventListener("load", function(evt) {
var ws = new WebSocket("{{.}}");
ws.onopen = function(evt) {console.log("open");}
});
</script></head>
<body>
Check your console
</body>
</html>
`))

It's a little brute force, and completely inelegant...
diff --git a/caddyhttp/proxy/reverseproxy.go b/caddyhttp/proxy/reverseproxy.go
index 78fbb6b..ac0997a 100644
--- a/caddyhttp/proxy/reverseproxy.go
+++ b/caddyhttp/proxy/reverseproxy.go
@@ -26,10 +26,13 @@
 package proxy

 import (
+       "bufio"
+       "bytes"
        "crypto/tls"
        "io"
        "net"
        "net/http"
+       "net/textproto"
        "net/url"
        "strings"
        "sync"
@@ -320,6 +323,37 @@ func (rp *ReverseProxy) ServeHTTP(rw http.ResponseWriter, outreq *http.Request,

                var backendConn net.Conn
                if hj, ok := transport.(*connHijackerTransport); ok {
+                       // Convert the replay into a buffered reader so we can do some magic on it
+                       reader := bufio.NewReader(bytes.NewBuffer(hj.Replay))
+
+                       // Read of the server response header that ReadMimeHeader can't grock
+                       httpResp, err := reader.ReadBytes('\n')
+                       if err != nil {
+                               return err
+                       }
+
+                       // Grock the headers
+                       tp := textproto.NewReader(reader)
+                       mh, err := tp.ReadMIMEHeader()
+                       if err != nil {
+                               return err
+                       }
+
+                       resp := &http.Response{Header: http.Header(mh)}
+                       respUpdateFn(resp)
+
+                       // Write us a new buffer
+                       ob := bytes.NewBuffer(httpResp)
+                       resp.Header.Write(ob)
+
+                       ob.Write([]byte{'\r', '\n'})
+
+                       // With whatever was left over
+                       reader.WriteTo(ob)
+
+                       // Convert it to a bunch of bytes
+                       hj.Replay = ob.Bytes()
+
                        backendConn = hj.Conn
                        if _, err := conn.Write(hj.Replay); err != nil {
                                return err

Hi @freman -- thanks for looking into this and finding a possible solution :)
Can you please try with Caddy 2 (currently in beta on the v2 branch) and see if this is still an issue? We've greatly improved the reverse proxy a lot already, so if this is still a problem it should be easy to fix now.

I'll close this as stale - if it comes up as an issue again with Caddy v2, we can always reopen it!


feat: overwrites broken-backlinks

https://jira.corp.adobe.com/browse/SITES-22728 Overwrite broken-backlinks
PATCH https://spacecat.experiencecloud.live/api/v1/sites/{siteId}/broken-backlinks
Request body
{
  "manualOverwrites": [
		{
		"brokenTargetURL": "https://www.a1.com",
		"targetURL": "https://www.b1.com" },
		{
		"brokenTargetURL": "https://www.c1.com",
		"targetURL": "https://www.d1.com" }
   ]
}

To remove all overwrites, send an empty array.
It will ovewrite/override the existing value (tagerURL) when the same brokenTargetURL is provided.

example:

:tada: This PR is included in version 1.49.0 :tada:
The release is available on:

v1.49.0
GitHub release

Your semantic-release bot :package::rocket:


Adding import guards for bioscrape and libroadrunner

This PR adds checking for import error when bioscrape or libroadrunner aren't installed. Unit tests are also added to test expected behavior.  Thus addressing the issues in #95 and #114
This PR also changes how missing simulator is handled:
R = CRN.simulate_with_bioscrape(timepoints, initial_condition_dict = x0)
# Return R = None when no simulator is found also raise a Warning

if R:
    plt.sca(ax1)
    plt.plot(R["time"], R[str(protein1)], ":", label = f"protein1 [g1c]={g1c}", color = color)
    plt.plot(R["time"], R[str(protein2)], label = f"protein2 [g1c]={g1c}", color = color)

This also means all examples with simulations were refactored, i.e. try-except blocks were removed everywhere.
@WilliamIX please sign off this interface change.

I like the changes! Not sure what the codecov check fail is all about (didn't look too much into it)

I like the changes! Not sure what the codecov check fail is all about (didn't look too much into it)
codecov has two thresholds: absolute threshold (what's the coverage change on all of the code), that passed; and relative threshold (what's the coverage change on the lines affected by this PR), this one failed.
Also, we can slowly change all the example notebooks that work better with this change.
I've refactored all of the examples to work with this new structure.

@zoltuz for some reason I cannot switch to this PR and look at it locally - I think all the changes look good, but wanted to test them first. Any idea what could be going wrong?

@zoltuz for some reason I cannot switch to this PR and look at it locally - I think all the changes look good, but wanted to test them first. Any idea what could be going wrong?

Good question! This what I've found: https://stackoverflow.com/questions/52022623/cannot-clone-repo-fatal-remote-did-not-send-all-necessary-objects
I've tried on a freshly cloned repo and it worked for me:

Maybe you need to update your git?
ps: I've used github CLI: https://cli.github.com/

Runs on my computer now (had to reclone biocrnpyler...weird). Merging with Squash just to try it.


Update stable version in repo from 1.0.2 to 1.0.3

Think about update stable version to 1.0.3
Version: stable=1.0.2 (203 days old) => latest=1.0.3 (15 days old)
Installs: stable=224 (64.93%), latest=121 (35.07%), total=345
Click to edit

This issue seems to be outdated
This issue suggests to update the stable version of this adapter to 1.0.3 but the current stable version is already 1.0.3.
So this issue should be closed.


Sage docs link updates

Description
Revises links in documentation to point to the new Github repo path(s):

moves "Release Notes" and "Changelog" links permanently to sidebar
updates versions and package links in header/assistant
open to any and all suggestions on emoji replacements 😀

NOTE: Not sure what happened, but it looks like a rebase I did added a bunch of unrelated files from the version bump on master

Before
After

Closes #128

I believe this needs to be rebased against latest from dev and pointed there for the merge.

I believe this needs to be rebased against latest from dev and pointed there for the merge.


Same message requested 3 times to different peers

Running a beacon node I noticed that gossipsub requested the same message xrVD3p06bJm56KPkSJWWD0/pWzU 3 times to different peers in different IWANT
>>> Requesting peer beacon_block IWANT 16Uiu2HAmEgvXJ3APeHgeCBtqKXQ6hDsK7gdmjUMptJNSGpXwsQfq [ 'xrVD3p06bJm56KPkSJWWD0/pWzU' ]
>>> Gossipssub - block 2046788 (new)            1.16s late 6mUXHQ4NY/dXTaWbf1MYTonuIeE Prysm/v1.4.4/29d48dfe7eb38959752048aec700f31c3abf7484 16Uiu2HAmEgvXJ3APeHgeCBtqKXQ6hDsK7gdmjUMptJNSGpXwsQfq
Eph 63962/4 1.178 [CHAIN]            info: Received block: 2046788
Eph 63962/4 1.180 [CHAIN]           error: Block error slot=2046788, errCode=BLOCK_ERROR_PARENT_UNKNOWN
Eph 63962/4 1.441 [CHAIN]            info: Received block: 2046787
Eph 63962/4 1.445 [CHAIN]           error: Block error slot=2046787, errCode=BLOCK_ERROR_PARENT_UNKNOWN
Eph 63962/4 1.797 [CHAIN]            info: Received block: 2046786
Eph 63962/4 1.810 [CHAIN]           error: Block error slot=2046786, errCode=BLOCK_ERROR_PARENT_UNKNOWN
>>> Requesting peer beacon_block IWANT 16Uiu2HAmEgvXJ3APeHgeCBtqKXQ6hDsK7gdmjUMptJNSGpXwsQfq [ 'xrVD3p06bJm56KPkSJWWD0/pWzU' ]
>>> Gossipssub - block 2046788 (already known)  1.85s late 6mUXHQ4NY/dXTaWbf1MYTonuIeE Prysm/v1.4.4/29d48dfe7eb38959752048aec700f31c3abf7484 16Uiu2HAmEgvXJ3APeHgeCBtqKXQ6hDsK7gdmjUMptJNSGpXwsQfq
Eph 63962/4 2.045 [CHAIN]            info: Received block: 2046785
>>> Requesting peer beacon_block IWANT 16Uiu2HAmEgvXJ3APeHgeCBtqKXQ6hDsK7gdmjUMptJNSGpXwsQfq [ 'xrVD3p06bJm56KPkSJWWD0/pWzU' ]
>>> Gossipssub - block 2046788 (already known)  2.61s late 6mUXHQ4NY/dXTaWbf1MYTonuIeE Prysm/v1.4.4/29d48dfe7eb38959752048aec700f31c3abf7484 16Uiu2HAmEgvXJ3APeHgeCBtqKXQ6hDsK7gdmjUMptJNSGpXwsQfq

Shouldn't the seenCache apply to all peers? The tag (already known) means that the seenCache contained that messageID. Maybe it was a race condition?

Not applicable to current gossipsub version


Bezüge zu Kirche ...

sometimes labels for persons are missing
relation types are missing
Geburtsdatum / Sterbedatum needs to be changed to Beginn / Ende
Nachname should be "name"

Are there any examples?

eg here https://viecpro-frontend.acdh-ch-dev.oeaw.ac.at/de/detail/persons/219685
or here https://viecpro-frontend.acdh-ch-dev.oeaw.ac.at/de/detail/persons/323043

this is the response i get from the backend

this is what is shown in the frontend (with adapted translations)

Which information is missing?


Function for converting Node to real type

When you use e.g. Element.querySelectorAll, you get a NodeList, and converting this to an array of Node-type makes it impossible to further use e.g. querySelector, since this is a method of Element / Document, and not on Node. In JS is this not a problem, because you can use all methods of the real type (on your own risk, since they may not exist if the node is not the type you expect), but this is not possible in bs-webapi, as far as I could tell.
So could it be possible to add a function that converts a Node-type to its real type? E.g. something in the spirit of this:
type nodeConcrete =
  | Element(Dom.element)
  | Attribute(Dom.attr)
  | Text(Dom.text)
  | CDATASection(Dom.cdataSection)
  | EntityReference
  | Entity
  | ProcessingInstruction(Dom.processingInstruction)
  | Comment(Dom.comment)
  | Document(Dom.document)
  | DocumentType(Dom.documentType)
  | DocumentFragment(Dom.documentFragment)
  | Notation
  | Unknown;

let getNodeConreteType: Dom.node => nodeConcrete =
  node =>
    switch (Node.nodeType(node)) {
    | Element => Element(node)
    | Attribute => Attribute(node)
    | Text => Text(node)
    | CDATASection => CDATASection(node)
    | EntityReference => EntityReference
    | Entity => Entity
    | ProcessingInstruction => ProcessingInstruction(node)
    | Comment => Comment(node)
    | Document => Document(node)
    | DocumentType => DocumentType(node)
    | DocumentFragment => DocumentFragment(node)
    | Notation => Notation
    | Unknown => Unknown
    };

Then you could have 'switched' on getNodeConreteType and got the actual type. I don't if it is possible to just somehow coerce Node-type into the other types, or if this is against the type-system? Or is this not how it is intended to use Node?

Hey. yeah, this should be possible, and a great idea I think. It does go against the type system, but that can be circumvented using Obj.magic, as long as you know what you're doing. You can see this same idea being used by Js.Types.classify, for example.
I'm not entirely sure what the API for something like this should be, but I think I'd prefer a lightweight approach that uses polymorphic variants and leaves it outside the Impl functor so that it's not inherited by everything that implements the Node interface.
Feel free to try your hand at a PR for this, or continue to ask questions if you have them :)


edit strings for consistency, branding (AWS)

Consistent converge_by statements
Consistent capitalization
Applied AWS branding patterns to all terms

Looks great! Let's chat briefly with folks tomorrow to identify a standard for us to use going forward, then merge this.

Thanks @jamescott !


Axis discovers DoorBird devices. Doorbird not discovered

Home Assistant release (hass --version):
0.74.2
Component/platform:

axis

discovery

Description of problem:
Axis shows up in the configurator and offers to configure a DoorBird, which is not related to Axis, so it fails.

I have this in the config
doorbird:
  devices:
    - host: <IP_ADDRESS>
      username: ########
      password: #######
      name: Front Doorbird
      monitored_conditions:
        - doorbell
        - motion
discovery:
  ignore:
    - axis

But it still during Discovery finds the Axis component
I tried turning off Discovery, but that breaks my Konnected sensor discovery.
This issue is a rehash of https://github.com/home-assistant/home-assistant/issues/8861

You can ignore axis discovery
discovery:
  ignore:
    - axis

see https://www.home-assistant.io/components/discovery/

I tried that... But it still discovers Axis
This is my config
Discover some devices automatically
discovery:
ignore:
- axis
When I add the doorbird config even with the Discovery above it fails.

Solved by itself somehow... All working.


Enabling Structured Logs breaks AzureDiagnostics logs

If you have a central log analytics and has a single diagnostic setting for the Firewall and follow this article to enable Structured logs, sure the Policy Analytics starts populating, but that breaks the logs going into Azurediagnostics table. So if you have the resource specific and then query AzureDiagnostics table for say Category == "AzureFirewallNetworkRule", it won't show any logs. Which means all the Azure firewall workbook etc you setup won't show any traffic. This also breaks the Sentinel connector for Azure Firewall. If its not enabled, you can't enable while the diagnostic is set to resource specific. If its connected, then it shows no logs being fed into Sentinel.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 72b36309-606f-282e-2825-85adffa9453c
Version Independent ID: cea78a40-9455-0d1c-fe67-d6358fba000e
Content: Azure Firewall Policy Analytics
Content Source: articles/firewall/policy-analytics.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@ramuvr
Thank you for your feedback! We will review and update as appropriate.

@ramuvr
Thank you for the feedback. I went through your question above. As we primarily monitor this channel for documentation enhancements and bugs and as your question is more related to product bug/limitation. It will be helpful if you could post this question on Microsoft Q&A forumor file a support request with us.
Hope this helps. Please let me know if you have any additional questions. Thank you!


unlist nuget package

Maybe this page could inform the reader about how to unlist a specific version of a nuget package.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1e7b39d-59f3-f390-26ec-404ccb8e97be
Version Independent ID: eba35a17-7cc0-2a6b-2421-24a7fba46d28
Content: Deleting NuGet Packages from nuget.org
Content Source: docs/nuget-org/policies/deleting-packages.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

@MohammadMQ - the doc calls out

nuget.org does supports unlisting a package, which can be done in the package management page on the web site.

Looking at your package - MKValidator.Mohammad_Mukammil, I can see that you have unlisted packages in the past which leads me to believe this document was sufficient and/or the website is intuitive enough to perform this action.

Hi Karann
Thanks for your reply.
The MKValidator.Mohammad_Mukammil account at nuget is not mine. I have no control over it. I just used it as an example.
However I found out myself how to unlist a nuget package. This document is not at all sufficient in informing the user as how to unlist a nuget package. The whole process of unlisted a nuget package requires many steps that aren't mentioned here.

@MohammadMQ - thanks for the feedback. We also accept pull requests from the community to improve our docs. Start by selecting the "Edit" button on the top left of the page you wish to contribute to.

This document now contains steps as of https://github.com/NuGet/docs.microsoft.com-nuget/pull/1945. Thanks for doing this, @MohammadMQ.


[Fix #11320] Fix a false positive for Lint/RequireParentheses

Fixes #11320.
This PR fixes a false positive for Lint/RequireParentheses when assigning ternary operator.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Duplicate interface definition for class 'RCTSwiftLog'

Was getting the following error when building with this library: Duplicate interface definition for class 'RCTSwiftLog'.
I'm assuming it's because react-native-ios-modal, which I also installed, also creates RCTSwiftLog.
I commented out the .h, .m, and .swift for RCTSwiftLog in this library and things started compiling for me again. Maybe there's a way to only declare RCTSwiftLog once between the two.

I'm gonna try making the classes private, maybe it'll fix it? (Or change the names as a temp. fix 🤣)
I'll try and find a solution haha

@raphaelrk hello! i've published a patch, it should be fixed now 😊
(please let me know if you have any other issues)

Wow that was so fast!! Thank you @dominicstop 😊


Package Request: snore

Project description
snore is sleep with feedback
Metadata

source URL: https://github.com/clamiax/snore
license: mit
platforms: linux

I'm confused by your name... lol


breaking(nova-react-test-utils): add support for Relay

Joint work with @jakobkhansen, more details to come
Questions for reviewers:

Should we have a single index.ts file that folks could import from or should we create two entry points like @nova/react-test-utils/apollo and @nova/react-test-utils/relay or keep the current version where we just differentiate functions by name

@ansemb

I like having @nova/react-test-utils/apollo and @nova/react-test-utils/relay.
I wouldn't mind having the index.ts only for relay, hence have @nova/react-test-utils (relay) and @nova/react-test-utils/apollo as I think relay should be considered default going forward, though that might also feel weird.

This is how it works right now actually. Because we set the main field as ./lib/relay/index.ts when importing without subpath it will use relay version. I decided to keep both subpaths for consistency tough


SEO - Meta descriptions

Summary
Updated and added meta rendering functionality to head tag:

partials/head.html: conditional check for description availability
partials/head-meta.html: rendering of meta descriptions
config.toml: inclusion of descriptions for pages that don't have an md file
*.md: meta description added for all pages provided by SEO team
internal/writing-a-blog-post.md: added template code for meta description

Ticket Link
Per SEO team, added meta description functionality and used provided google doc to add meta tags:
https://mattermost.atlassian.net/browse/MAR-212

Hello Mattermost reviers - just wanted to do a check in on this to see if maybe we could get an ETA or status on this one. If there's anything I can do to help, please let me know.

Hello Mattermost reviers - just wanted to do a check in on this to see if maybe we could get an ETA or status on this one. If there's anything I can do to help, please let me know.

Hi @cwarnermm, I was hoping you could maybe check in on this PR and see about helping me facilitate its progress towards approval.

Status Update: I have a commit in queue to resolve all issues except the following which require additional feedback:

Confirmation on the default/home page meta description
Direction on the logic/content structure for meta descriptions in the head.html include (see comments on the file for details - I am unable to comment on the revision request for some reason)

@lawrencejohnson Please push your commit. My other comments aren't blocking.


How to disable automatically added newline character?

LOG macro will automatically add newline charactor to the output message. how to disable it?

the code out.append(msg.message() + '\n');  seems to be a problem. it cause a repeated message.
if a message is : "(5,5)"  . then the final message will be :  "(5, 5)(5,5)\n"
related api link: https://github.com/KjellKod/g3log/blob/master/API.markdown#override-the-log-formatting-in-the-default-sink

The log macro doesn’t add it. The code above adds it.
For custom formatting reasons (and more) g3log is made to be extensible with custom made sinks. Please read the documentation about this
you can then format the output any way you like. A simple solution would be to have the existing default logger and copy-and-adjust it to your specific needs.
To have custom formatting the logging sink should receive the logging message and not a std::string. Ref the docs + unit tests


⚠ Samsung has degraded performance

In 5b21904, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2403 ms

Resolved: Samsung performance has improved in e8c3eff.