Update immer library to current master (0a718d2d76bab6ebdcf43de943bd6c7d2dbfe2f9)

I observed random crashes with the stacktrace pointing into the immer library. It was not immediately clear why exactly it was crashing as I had no debugger attached, so I currently hope that upgrading immer to the latest version fixes this issue. Looking into the changes in the affecting files (e.g. src/immer/detail/hamts/node.hpp) there is a chance that these fix potential crashes.

Initially the PR was updating to f891a27b106030c5bed385f464ee871713528a14, but an additional fix was required to make it compile for ARM. The fix was merged upstream after a few minutes, so this PR now updates immer to 0a718d2d76bab6ebdcf43de943bd6c7d2dbfe2f9


🔷 [Epic] Developer Home/Dashboard Screen

Description
(Overview of milestone or function governed by this epic)
Resources
(Relevant documentation, Figma links, and other reference material)

Item 1
Item 2
Item 3

@ravigautham what's the scope of this initiative? Does this intent to track the home, learn, use, and ecosystem pages?

@charleslavon
This overall initiative is for the new global navigation for the near.org gateway (logged in) experience that Corwin is building in his prototype. The Developer Dashboard/Home screen would be a net new screen that we'd need to build as a result of that new navigation. So I've called it out as a separate epic here.


added storj.model.Bucket test case

added test case for the storj.model.Bucket class
added test case for the storj.model.Frame class
added test case for the storj.model.Shard class

coverage increased to 31%.
this PR also includes #17 so please review that one first.
@super3 @frdwrd @Miskerest review needed after #17.
thank you!

Coverage increased (+2.1%) to 27.486% when pulling f0d7a0d28f0e4ed1c1db99a6a70e304d8fd483cf on steenzout:unit_test_model into 2007b22ad6927fa8b91ef083ad4bdd71c28a9c55 on Storj:master.

This one looks good to me as well.

Coverage increased (+5.4%) to 30.741% when pulling 64c24d59cafcbc103a9352b75102dee08c574b68 on steenzout:unit_test_model into 2007b22ad6927fa8b91ef083ad4bdd71c28a9c55 on Storj:master.

Coverage increased (+6.3%) to 31.646% when pulling 6d4e45bb9f64d11085518cfcb8d04cb94fc7b7f1 on steenzout:unit_test_model into 2007b22ad6927fa8b91ef083ad4bdd71c28a9c55 on Storj:master.


Test performance of parallel83 routine for AVX512

(Instead of two separate calls, one first for parallel82 followed by parallel81)

I assume this is part of something more?


Installer

Investigate self-installing package (jnlp?)
possibility to bundle with Winboard or other soft? (licensing etc?)

Consider http://www.oracle.com/technetwork/java/javase/javawebstart/index.html

May be treated by #400 where a solution should exist


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.14 to before v5.4.133",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0c3fc4d5fa26092853278145aca9b21fa52a3e93",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ef0a06acc6b16388640ad367eedfa2a17f1945db"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "0c3fc4d5fa26092853278145aca9b21fa52a3e93",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "ef0a06acc6b16388640ad367eedfa2a17f1945db",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "coresight: tmc-etf: Fix global-out-of-bounds in tmc_update_etf_buffer()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.133 by commit ef0a06acc6b16388640ad367eedfa2a17f1945db, it was introduced in version v4.14 by commit 0c3fc4d5fa26092853278145aca9b21fa52a3e93. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001350


[SPARK-45093][CONNECT][PYTHON] Error reporting for addArtifacts query

What changes were proposed in this pull request?
Add error logging into addArtifact  (see example in "How this is tested"). The logging code is moved into separate file to avoid circular dependency.
Why are the changes needed?
Currently, in case addArtifact is executed with the file which doesn't exist, the user gets cryptic error
        status = StatusCode.UNKNOWN
        details = "Exception iterating requests!"
        debug_error_string = "None"
>

Which is hard to debug without deep digging into the subject.
This happens because addArtifact is implemented as client-side streaming and the actual error happens during grpc consuming iterator generating requests. Unfortunately grpc doesn't print any debug information for user to understand the problem.
Does this PR introduce any user-facing change?
Additional logging which is opt-in same way as before with SPARK_CONNECT_LOG_LEVEL environment variable.
How was this patch tested?
>>> s.addArtifact("XYZ", file=True)
[New:] 2023-09-15 17:06:40,078 11789 ERROR _create_requests Failed to execute addArtifact: [Errno 2] No such file or directory: '/Users/alice.sayutina/apache_spark/python/XYZ'
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/alice.sayutina/apache_spark/python/pyspark/sql/connect/session.py", line 743, in addArtifacts
    self._client.add_artifacts(*path, pyfile=pyfile, archive=archive, file=file)

[....]

  File "/Users/alice.sayutina/oss-venv/lib/python3.11/site-packages/grpc/_channel.py", line 910, in _end_unary_response_blocking
    raise _InactiveRpcError(state)  # pytype: disable=not-instantiable
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
        status = StatusCode.UNKNOWN
        details = "Exception iterating requests!"
        debug_error_string = "None"
>

cc @HyukjinKwon, @nija-at

From PR script:
starting python compilation test...
python compilation succeeded.

starting black test...
black checks failed:
Oh no! 💥 💔 💥 The required version `23.9.1` does not match the running version `22.6.0`!
Please run 'dev/reformat-python' script.

Should I do something about it or is it a known problem?

Ah, the master branch and your branch should be synced to the latest master brnach. Black was latenly upgraded.

Updated fork's master

Mind running dev/reformat-python one more last time? Seems like there's a diff between old and new black versions.

Done, thanks!

Merged to master.


Finds the user and campains but does not show on the app, new twitch security?

so it does work, it logs in but it doesn't bring on the app the claims i could get,

BUT in cache there is the "logos" for the drops, so much that i can see the war thunder one
am i doing something wrong, or new security?

SCRATCH THAT...... firewall blocked part of twitch


[haxe]Inconsistent message position between build and diagnostics

version: haxedevelop <IP_ADDRESS>

editor config:

I have turned off the DisplayStdIn because it always produces the following error when i press Ctrl+s

the position seems to be produced by diagnostics:

the position when press F8(build):

Haxe?

4.0.0-preview.4+0cfe8f712


Is this section regarding optional parameters actually correct?

[Enter feedback here]
In this section regarding optional parameters; is this actually correct?
The commented section indicates the next statement does not compile but it's the exact same as the one that is indicated as correct
// info(int2Str(Additions::AddThreeInts(1, 2, 99)));
vs
info(int2Str(Additions::AddThreeInts(1, 2, 99)));
public class Additions
{
static public int AddThreeInts(int _i1, int _i2 = 2,int _i3 = 3)
{
return _i1 + _i2 + _i3;
}
}
// This code calls the AddThreeInts method.
// No way to skip the first optional parameter (so it can default)
// while also specifying the value of the second optional parameter.
// The next statement does not compile.
// info(int2Str(Additions::AddThreeInts(1, 2, 99)));
// Settle for overriding both optional parameters.
info(int2Str(Additions::AddThreeInts(1, 2, 99)));
// Output is "102".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2deb3461-0602-b91a-d92d-c2dc7c69c197
Version Independent ID: 92e2d8ec-9543-ee7c-042c-524e03bf230e
Content: Classes and methods - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/dev-ref/xpp-classes-methods.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @RobinARH
Microsoft Alias: rhaertle

I updated both code examples in that section and the new content should go live this evening. Thanks for letting us know. - Robin


Set limit to image file size when loading images in rich push

At this time, the SDK downloads images for displaying in rich push without a limit to the file size.
Luckily, the OS protects the app a little bit by having a timeout incorporated so if it takes too long to download a file for a rich push, the OS will call UNNotificationServiceExtension.serviceExtensionTimeWillExpire(). The SDK then cancels image downloads at this time and displays the rich push without an image.
However, it's good for the SDK to provide limits to the image file size to improve the app experience for our customers:

Preserve data bandwidth and battery of customers devices.
Increase the chances that an image will download successfully by not attempting to download files too large.

Idea:

There is a delegate function that we can set that notifies you of how big the image might be when downloading and how much has been downloaded thus far. We can use this to cancel the download if it's too large for our liking:

func urlSession(_ session: URLSession,
            downloadTask: URLSessionDownloadTask,
            didWriteData bytesWritten: Int64,
           totalBytesWritten: Int64,
           totalBytesExpectedToWrite: Int64) {
  if totalBytesWritten > maxFileSizeBytesAllowed {
    downloadTask.cancel()
  }
}


Merge efforts?

There is also:
https://github.com/ethereum/pyethapp/blob/develop/pyethapp/rpc_client.py
which has support for python ABI contract proxies:
https://github.com/ethereum/pyethapp/blob/develop/pyethapp/rpc_client.py#L219
Any ideas on the best way to merge these efforts?

I found that the most important thing was to tease out dependence on pyethereum (which both ethjsonrpc and pyethapp/rcp_client require.)  In practice a python Ethereum dapp really only wants the minimum amount of Ethereum required to talk to a node. It doesn't need all of the extra capability that is only used by Ethereum nodes.
Requiring pyethapp turned out to make it tricky for a lot of folks using OSX to install python dApps, and last time I checked it was impossible (ok, REALLY hard) under Windows. Unfortunately, at the moment "teasing it out" meant that some code needed to be duplicated (the abi module, for instance, as well as code to sign a transaction) which was not an awesome solution - but had the upside that suddenly the dApps were multi-platform.
Actually - I suspect the best starting place would be to separate pyethereum itself into a library containing only the stuff a client needs, and another containing the Ethereum node underpinnings too.

just throwing this out there in case you haven't heard of it but @tcoulter has built https://github.com/ethereumjs/testrpc which attempts to serve the same goal
just another tool at your disposal


some comments can crash the markdown parser

Current behavior
comments ported from old.metaculus.com including a left angle bracket followed by any character are broken:
e.g. my comment here
It contains the string <4% which appears to crash the markdown engine
Note that if you enter a < in WYSIWYG mode, it's fine because it auto escapes it as \<; only a < which got ported from the old app (or entered directly via the raw input mode) triggers this issue.
Expected/desired behavior
All comments on old.metaculus.com should be visible on the new site

I'll add that writing a "<" in markdown mode also crashes the wysiwyg editor, with a rather cryptic message.

We should either improve the error message, or escape the "<" even in markdown, or not crash on it.

Ready for testing on dev and prod

lgtm


multiprocess and kernel space question

Hello, I want to use IORING_OP_FUTEX_WAKE and IORING_OP_FUTEX_WAIT to implement a multiprocess mutex. One question I have is whether the kernel allocates a separate kernel space for each process when multiple processes simultaneously instantiate io_uring_queue_init, or do all processes share a single kernel space where all io_uring requests are handled?

Each ring is using its own memory, there's nothing shared across rings. But for futex operations, that should not matter, all that matters is that the futex itself is located in memory that both can access.

Thank you


feat: add config for running in a date window

Description
Add a startDate and endDate parameters, which are used to configure the behavior of executing the auto-comment workflow. Either or both startDate and endDate can be provided, and the current time is checked agains these dates to determine if the workflow can be executed.
The startDate and endDate parameters are not  required, and as such, this feature is backwards compatible.
Motivation and Context
I want to support the case where we auto-comment only within a specific date-window. For example, if the company is on a company-wide holiday, I want to configure the auto-commenter to message out that the company is on break and what that means for providing support during this time.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

For now I've managed to workaround this using a separate step to check the date and fail the workflow if it isn't within the expected range. I'll post this here in case there are others looking to do something similar.
      - name: Checks that current date is between date range
        id: check-dates
        run: |
          today=$(date +'%s')
          start=$(date -d 2022-11-24 +%s)
          end=$(date -d 2022-11-28 +%s)
          if [[ $today -gt $start && $today -lt $end ]] ; then
            exit 0
          else
            exit 1
          fi


V8 - 'Unable to retrieve legacy attribute key for method: getIndexedSearchTable' thrown

The exception 'Unable to retrieve legacy attribute key for method: getIndexedSearchTable' is being thrown when this is called to added an attribute category:
AttributeKeyCategory::add('store_order',AttributeKeyCategory::ASET_ALLOW_SINGLE, $pkg)
(use Concrete\Core\Attribute\Key\Category as AttributeKeyCategory;)

If the following lines are commented out in the add function of Concrete\Core\Attribute\Category\CategoryService, the exception doesn't seem to be thrown anymore by the example above:
$indexer = $category->getController()->getSearchIndexer();
if (is_object($indexer)) {
$indexer->createRepository($category->getController());
}
(but I have no idea what these lines are doing)
I also believe this exception is being thrown from the use of the add function in Concrete\Core\Attribute\Key\Key, something to do with:
https://github.com/concrete5-community-store/community_store/blob/master/src/Attribute/Key/StoreOrderKey.php#L92

Is this still an issue on the latest develop branch? I have been more concerned about attribute types working at the moment but I know that I'd done some work on community store installation; I believe everything had been working up to the actual setting of attributes (which was next on my list.)
Additionally, a lot of compatibility work has gone into the attributes system between last week and today, so trying again with a clean install + installation of community store might yield interesting results.

I reckon I did this testing just before you checked in some more fixed.
I'll re-test asap.

I'm still hitting this error on install unfortunately, using a fresh install of the latest code from the develop branch.
Sorry I can't be more help than the above, I'm a bit stumped myself.

I don't know if this is related but I seem to have currently issues running fresh installations. Sample content installation failed totally while the empty installation went through but now I have errors on page.
All pages are broken, styles are missing and no JS is being loaded. The frontend of the site shows this:
Uncaught exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'ak_is_desktop' in 'where clause''

And when I access the dashboard main page, I don't see any errors but when I open up the raw source, I can see this at the very bottom (which also ends the execution of the page):
An exception occurred while executing 'SELECT p.cID FROM Pages p LEFT JOIN PagePaths pp ON (p.cID = pp.cID and pp.ppIsCanonical = true) LEFT JOIN PageSearchIndex psi ON p.cID = psi.cID LEFT JOIN PageTypes pt ON p.ptID = pt.ptID INNER JOIN Collections c ON p.cID = c.cID INNER JOIN CollectionVersions cv ON p.cID = cv.cID LEFT JOIN CollectionSearchIndexAttributes csi ON c.cID = csi.cID WHERE (ak_exclude_nav <> 1 or ak_exclude_nav is null) AND (p.cParentID = ?) AND (p.cPointerID < 1) AND (p.cIsTemplate = 0) AND (cvIsApproved = 1) AND (p.cIsActive = ?) ORDER BY p.cDisplayOrder asc' with params ["2", true]

I don't know if these are related but this just seemed like the closest issue thread, so I posted this here.
And this was with a fresh installation with the current codebase from GitHub.
All seem to be related to the attributes rework (as these columns do not seem to be available) but did not investigate further because I have no idea what has happened with the attributes and how they are meant to work from now on.

Whoops. Couple things.

The indexed search table error @Mesuva points out should be fixed in the
latest commit when installing the Community Store package.
The inability to install period is now fixed as well.

On Mon, Jun 6, 2016 at 7:52 AM, Antti Hukkanen<EMAIL_ADDRESS>wrote:

I don't know if this is related but I seem to have currently issues
running fresh installations. Sample content installation failed totally
while the empty installation went through but now I have errors on page.
All pages are broken, styles are missing and no JS is being loaded. The
frontend of the site shows this:
Uncaught exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'ak_is_desktop' in 'where clause''
And when I access the dashboard main page, I don't see any errors but when
I open up the raw source, I can see this at the very bottom (which also
ends the execution of the page):
An exception occurred while executing 'SELECT p.cID FROM Pages p LEFT JOIN PagePaths pp ON (p.cID = pp.cID and pp.ppIsCanonical = true) LEFT JOIN PageSearchIndex psi ON p.cID = psi.cID LEFT JOIN PageTypes pt ON p.ptID = pt.ptID INNER JOIN Collections c ON p.cID = c.cID INNER JOIN CollectionVersions cv ON p.cID = cv.cID LEFT JOIN CollectionSearchIndexAttributes csi ON c.cID = csi.cID WHERE (ak_exclude_nav <> 1 or ak_exclude_nav is null) AND (p.cParentID = ?) AND (p.cPointerID < 1) AND (p.cIsTemplate = 0) AND (cvIsApproved = 1) AND (p.cIsActive = ?) ORDER BY p.cDisplayOrder asc' with params ["2", true]
I don't know if these are related but this just seemed like the closest
issue thread, so I posted this here.
And this was with a fresh installation with the current codebase from
GitHub.
All seem to be related to the attributes rework (as these columns do not
seem to be available) but did not investigate further because I have no
idea what has happened with the attributes and how they are meant to work
from now on.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/concrete5/concrete5/issues/3898#issuecomment-223983128,
or mute the thread
https://github.com/notifications/unsubscribe/AAgNwTdWlnmfgmwpvk0yOdu92OrmCbQdks5qJDRGgaJpZM4IqgVJ
.


Low unicast receive rate (0.00 < 0.90). Sent: 115. Received: 0

After I run the command:
ros2 launch crazyflie launch.py
It gets:
[crazyflie_server-4] [WARN] [1721896512.858730928] [crazyflie_server]: [all] Motion capture rate off (#: 59, Avg: 120.4, Min: 52.3, Max: 211.1)
[crazyflie_server-4] [WARN] [1721896512.911636612] [crazyflie_server]: [cf0] High latency: 26.8 ms
[crazyflie_server-4] [WARN] [1721896512.956708947] [crazyflie_server]: [cf0] Low unicast receive rate (0.00 < 0.90). Sent: 115. Received: 0
[crazyflie_server-4] [WARN] [1721896512.956784759] [crazyflie_server]: [cf0] Low broadcast receive rate (0.00 < 0.90). Sent: 236. Received: 0
[crazyflie_server-4] [WARN] [1721896513.858070545] [crazyflie_server]: [all] Motion capture rate off (#: 58, Avg: 120.5, Min: 100.5, Max: 147.8)
[crazyflie_server-4] [WARN] [1721896513.918592215] [crazyflie_server]: [cf0] High latency: 34.0 ms

hi! so these are warnings of the server so no errors yet. What is your question exactly? Do you want to know the reason of these warning?


Crashing with Connector, I'm assuming its when both a fabric & forge mod integrate this at the same time.

Here is the log, the game is crashing on startup.

Ok funky github formatting didnt work with link, here we go: https://gist.github.com/SlayDigger/c83953db9acdf040078c2c979721cc23

The log contains no errors.

On line 445, the game crashes not long into startup


Update react to ^17.0.2

Update the pear dependency react to be the current version of 17.0.2.

Resolved in 1.1.3


DE on data subset

When running DE on a subset of a dataset with lots of batches, seems like I need to re-index the batches of subsets so that it is consecutive from 0 ~ n_batches. Perhaps this can be done automatically within the DE function.

de_celltype = {}
for tissue in np.unique(adata.obs["tissue"]):
    sub_adata = adata[adata.obs["tissue"] == tissue]
    de_celltype[tissue] = vae.differential_expression(
        sub_adata, groupby="Propagated.Annotation", batch_correction=True
    )

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-143-b1df721788f5> in <module>
      2 for tissue in np.unique(adata.obs['tissue']):
      3     sub_adata = adata[adata.obs['tissue']==tissue]
----> 4     de_celltype[tissue] = vae.differential_expression(sub_adata, groupby = 'Propagated.Annotation', batch_correction=True)

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/scvi/core/models/rnamixin.py in differential_expression(self, adata, groupby, group1, group2, idx1, idx2, mode, delta, batch_size, all_stats, batch_correction, batchid1, batchid2, **kwargs)
    187             batch_size=batch_size,
    188         )
--> 189         result = _de_core(
    190             adata,
    191             model_fn,

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/scvi/core/models/_utils.py in _de_core(adata, model_fn, groupby, group1, group2, idx1, idx2, all_stats, all_stats_fn, col_names, mode, batchid1, batchid2, delta, batch_correction, **kwargs)
     59             cell_idx2 = (adata.obs[groupby] == group2).to_numpy().ravel()
     60
---> 61         all_info = dc.get_bayes_factors(
     62             cell_idx1,
     63             cell_idx2,

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/scvi/core/utils/differential.py in get_bayes_factors(self, idx1, idx2, mode, batchid1, batchid2, use_observed_batches, n_samples, use_permutation, m_permutation, change_fn, m1_domain_fn, delta, cred_interval_lvls)
    168         eps = 1e-8  # used for numerical stability
    169         # Normalized means sampling for both populations
--> 170         scales_batches_1 = self.scale_sampler(
    171             selection=idx1,
    172             batchid=batchid1,

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/torch/autograd/grad_mode.py in decorate_no_grad(*args, **kwargs)
     47         def decorate_no_grad(*args, **kwargs):
     48             with self:
---> 49                 return func(*args, **kwargs)
     50         return decorate_no_grad
     51

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/scvi/core/utils/differential.py in scale_sampler(self, selection, n_samples, n_samples_per_cell, batchid, use_observed_batches, give_mean)
    392             idx = np.random.choice(np.arange(self.adata.shape[0])[selection], n_samples)
    393             px_scales.append(
--> 394                 self.model_fn(self.adata, indices=idx, transform_batch=batch_idx)
    395             )
    396             batch_idx = batch_idx if batch_idx is not None else np.nan

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/torch/autograd/grad_mode.py in decorate_no_grad(*args, **kwargs)
     47         def decorate_no_grad(*args, **kwargs):
     48             with self:
---> 49                 return func(*args, **kwargs)
     50         return decorate_no_grad
     51

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/scvi/core/models/rnamixin.py in get_normalized_expression(self, adata, indices, transform_batch, gene_list, library_size, n_samples, batch_size, return_mean, return_numpy)
     82         scdl = self._make_scvi_dl(adata=adata, indices=indices, batch_size=batch_size)
     83         if transform_batch is not None:
---> 84             transform_batch = _get_batch_code_from_category(adata, transform_batch)
     85
     86         if gene_list is None:

/data/yosef2/users/chenling/miniconda3/envs/scvi-tools/lib/python3.8/site-packages/scvi/model/_utils.py in _get_batch_code_from_category(adata, category)
    131     batch_mappings = categorical_mappings["_scvi_batch"]["mapping"]
    132     if category not in batch_mappings:
--> 133         raise ValueError('"{}" not a valid batch category.'.format(category))
    134     return np.where(batch_mappings == category)[0][0]

ValueError: "0" not a valid batch category.```

#### Versions:
<!-- Output of scvi.__version__ -->
> VERSION

<!-- Relevant screenshots -->

Hi @chenlingantelope!
I think my open PR #817 fixes this.
Can you pip install that branch and let me know?
pip install git+https://github.com/yoseflab/scvi-tools.git@transformbatch_fix
Thanks!

Hi,
I have experienced the same issue above, but when running
adata_scvi.layers["scvi_normalized"] = model_scvi.get_normalized_expression(adata_scvi,library_size = 10e3, batch_key="library", transform_batch=['my_batch'])
I have installed scvi-tools using following commands
git clone https://github.com/scverse/scvi-tools
pip install -e .
my scvi-tools version is 1.1.3
any ideas how to solve this issue?

Hi, the issue points to that transform_batch=['CHR0211'] is not an existing batch category. The function has changed in the meantime from the error message above. Please provide adata.obs[batch_key].value_counts if you think the category should exist.

Hi,
Thanks for the reply.
I used library as batch_key and here is the result for adata.obs[batch_key].value_counts .

Can you check the version of scvi-tools installed?


:headers should not be wrapped in :params

Thanks a lot for this project! You've saved me (and probably many others) countless hours of brainless rewriting of tests.
But, I have one issue currently: We have quite a lot of tests in our test suite, where we only set the :headers but not the :params:
get users_path, headers: { my_header: 'gugus' }

The tool currently does not correctly recognize that the :headers part should not be wrapped within :params, because the resulting code is:
get users_path, params: { headers: { my_header: 'gugus' } }

I'm probably going to open a PR later for fixing this problem.

I just noticed that the :xhr attribute has the same problem and is also wrapped within :params. I'm quickly going to change that in my PR too.


How to change title of push notification  in ios

i have changed title in notification response but still showing my app name on push notification on ios 10. it is working fine on android
here is my notification response for ios
{"additionalData":{"coldstart":false,"notification_type":"promotion","nid":"10789","type":"news_feed_item","foreground":true,"aps":{"alert":"hello","title":"check"}},"message":"hello","title":"check","sound":"default"}

@ajaysaini95700 you can't change the title of the notification on iOS. iOS always uses your apps icon and name as part of the notification.


BertForQuestionAnswering: Predicting span on the question?

Hello,
I have a question regarding the BertForQuestionAnswering implementation. If I am not mistaken, for this model the sequence should be of the form Question tokens [SEP] Passage tokens. Therefore, the embedded representation computed by BertModel returns the states of both the question and the passage (a tensor of length passage + question + 1).
If I am not mistaken, the span logits are then calculated for the whole sequence, i.e. they can be calculated for the question even if the answer is always in the passage (see the model code and the squad script). I wonder if this behavior is really desirable. Doesn't it confuse the model?
Thank you for your work!

This is the original behavior from the TF implementation.
The predictions are filtered afterward (in write_predictions) so this is probably not a big issue.
Maybe try with another behavior and see if it improve upon the results?


fix(timeseries): handle if all data is null

handle the case where all the values have a null value, show no data for this time range in the chart

:tada: This PR is included in version 1.98.0 :tada:
The release is available on:

npm package (@release-1.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Dynamically filter profiles (only for data review purposes)

Harmonization table
Result flags table
Methods Table
etc.
Purpose: To easily review subsets of full TADA profile + TADA flags by relevant groupings

This is related to: https://github.com/USEPA/TADAShiny/issues/68


Add missing Port

Hey! You have an amazing library here!
Just a suggestion, you should add some missing ports to the package, like: COBAL (Colombia Balboa)

AL Barash  port as well


executor: rework collide mode

Collide code is very old and primitive. It served us well, but I think it needs to be rewritten and improved.
First, collide needs to run in a separate process, because there is too much interference with the original run. Second, we need to be smarter as to what calls need to be collided. Collide should not interfere with minimization (#105). We should collide calls harder during smash (e.g. collide with different start delays). Don't enable coverage collection during collide.
Another idea: collide a call with itself (the same call in a different thread), the same call obviously works on the same resource.

#355 is somewhat related

Here is one bug that may be a good litmus test to assess improvements in concurrency support (in particular creation of reproducers):
https://syzkaller.appspot.com/bug?extid=dc3dfba010d7671e05f5
See the discussion:
https://groups.google.com/g/syzkaller-bugs/c/0cjMx2KTyRs/m/ABVfQoRVCgAJ
It happens very infrequently (there are several manifestations) and no reproducers (also can't reproduce it manually).
Maybe if we run syz-manager with just rdma syscalls and improved colliding mode, it will be able to trigger it better and create a reproducer.

Please rebase onto #2791 and run go test ./executor ;)

Here is another good candidate for reproducing very narrow race conditions:
https://syzkaller.appspot.com/bug?extid=0fa13b1412bfc003747b
https://syzkaller.appspot.com/bug?extid=1b2037f5a8232ce7d60c
It was hit only 3 times in 5.4 in total.
The root cause seems to be this:
The use is in the issue_discard_thread() thread, which is stopped by f2fs_destroy_segment_manager(). And the memory block is freed by f2fs_destroy_node_manager().
f2fs_fill_super() has the following code in the error handling path:
...
free_nm:
f2fs_destroy_node_manager(sbi);
free_sm:
f2fs_destroy_segment_manager(sbi);
...
So it freed the memory used by issue_discard_thread() before stopping it.
And reliable reproducer would probably need a sleep in in issue_discard_thread() probably after "do {".


Issue in stack creation in AWS

Description:
Observing below issue when triggered a build for Ubuntu. Stack creation not completed within 60min.
Cloudfomation stack status shows as below
Failed to receive 1 resource signal(s) within the specified duration
https://testgrid-live.private.wso2.com/admin/blue/organizations/jenkins/RELEASES%2Fintg-test-wso2ei-master/detail/intg-test-wso2ei-master/26/pipeline/177
[13:51:49,470] Error on infrastructure creation for deployment pattern 'DeploymentPattern{id='b72b0e14-c071-4fcb-a659-bd0e50d6b5f7', name='prod-wso2ei-intg-deployment', createdTimestamp='2019-03-29 12:31:10.0', modifiedTimestamp='2019-03-29 12:31:10.0', product='Product{id='bb8b1f8c-29b9-4fc1-a3a4-b26f901eb128', name='intg-test-wso2ei-master'}'}', in TestPlan org.wso2.testgrid.common.exception.TestGridInfrastructureException: Error occurred while waiting for stack prod-wso2ei-intg-deployment-flsh5x
	at org.wso2.testgrid.infrastructure.providers.AWSProvider.doProvision(AWSProvider.java:278)
	at org.wso2.testgrid.infrastructure.providers.AWSProvider.provision(AWSProvider.java:161)
	at org.wso2.testgrid.core.phase.InfraPhase.provisionInfrastructure(InfraPhase.java:108)
	at org.wso2.testgrid.core.phase.InfraPhase.executePhase(InfraPhase.java:73)
	at org.wso2.testgrid.core.phase.Phase.execute(Phase.java:60)
	at org.wso2.testgrid.core.TestPlanExecutor.execute(TestPlanExecutor.java:83)
	at org.wso2.testgrid.core.command.RunTestPlanCommand.executeTestPlan(RunTestPlanCommand.java:280)at org.wso2.testgrid.core.command.RunTestPlanCommand.execute(RunTestPlanCommand.java:135)at org.wso2.testgrid.core.command.CommandHandler.execute(CommandHandler.java:130)
at org.wso2.testgrid.core.Main.main(Main.java:47)

Caused by: org.awaitility.core.ConditionTimeoutException: Condition org.wso2.testgrid.infrastructure.providers.aws.StackCreationWaiter$StackCreationVerifier was not fulfilled within 60 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:136)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:79)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:27)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:840)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:802)
	at org.wso2.testgrid.infrastructure.providers.aws.StackCreationWaiter.waitForStack(StackCreationWaiter.java:64)
	at org.wso2.testgrid.infrastructure.providers.AWSProvider.doProvision(AWSProvider.java:246)
	... 9 more

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Task:
https://github.com/wso2/product-ei/issues/3433

This is an issue with the userdata section of the cloudformation template you are using. This isn't a testgrid framework/deployment issue.
To further debug, we need to look at userdata logs. Please attach them here.


Update index.yml

Securely deliver virtual desktops and applications remotely with maximum control to any device from a flexible cloud virtual desktop infrastructure (VDI) platform. Bring together Microsoft 365 and Azure to provide users with the only multi-session Windows 11 and Windows 10 experience, with exceptional scale and reduced IT costs.

@ju-shim
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hello, thank you for contributing - however, the update you propose is too long for the "description" meta tag. I can't approve this change, but feel free to file a new pull request with a simpler sentence that states the purpose of the doc (not a pitch/long message about the product/feature).
Also, if you are an employee of Microsoft, please make updates in the private repository. If you have questions, message me on Teams.
Thank you for your contribution!
#please-close


Custom pattern matching in ruleset throws a panic

 parameters-snake-case:
        id: parameters-snake-case
        description: Request and response parameters must be in snake_case
        given: $.paths[*][*].parameters[*].name
        formats:
            - oas3
            - oas3_1
            - oas2
        resolved: true
        recommended: true
        type: validation
        severity: error
        then:
            function: pattern
            functionOptions:
                match: ^[a-z]+(_[a-z]+)*$
        category:
            id: parameters
            name: Parameters
            description: Parameters are essential for API operations. This rule ensures that parameter names follow the snake_case convention.
        howToFix: Ensure all parameter names are in snake_case format, using underscores to separate words.

I added the above ruleset, when I try to test it against a camelCase parameter, it breaks. the regex checks out , can you help please ?
This is the stack trace

--------------------------------------------------------------
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x18 pc=0x105b66280]

goroutine 5 [running]:
github.com/daveshanley/vacuum/cmd.processResults({0x140008b0008, 0xfe, 0x105dd0ff0?}, {0x1400014e008, 0x279, 0x279}, 0x0, 0x1, 0x0, 0x0, ...)
     /home/runner/work/vacuum/vacuum/cmd/lint.go:521 +0xc20
github.com/daveshanley/vacuum/cmd.lintFile({{0x16b04f7e6, 0x20}, {0x0, 0x0}, 0x0, 0x1, 0x0, 0x0, 0x1, 0x0, ...})
     /home/runner/work/vacuum/vacuum/cmd/lint.go:374 +0x594
github.com/daveshanley/vacuum/cmd.GetLintCommand.func2.1(0x0?, 0x0, {0x16b04f7e6, 0x20})
     /home/runner/work/vacuum/vacuum/cmd/lint.go:242 +0x2a8
created by github.com/daveshanley/vacuum/cmd.GetLintCommand.func2 in goroutine 1
     /home/runner/work/vacuum/vacuum/cmd/lint.go:207 +0x1634
     ```

This has been resolved in v0.13.2 The problem was the category not being read in properly.


make vlt for BOOM core failed

make STARSHIP_CORE=BOOM vlt FAILED
The following error occurs when Makefile executing the verilator command:
%Error: /home/starship/asic/sim/spike_difftest.boom.v:30:114: Can't find definition of 'io_commit_uops_1_debug_pc' in dotted variable: 'Testbench.testHarness.ldut.tile_prci_domain.tile_reset_domain_boom_tile.core.rob.io_commit_uops_1_debug_pc'
   30 |     if (cosim_commit(0, $signed(Testbench.testHarness.ldut.tile_prci_domain.tile_reset_domain_boom_tile.core.rob.io_commit_uops_1_debug_pc),
      |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~
        /home/starship/asic/sim/spike_difftest.v:50:1: ... note: In file included from 'spike_difftest.v'

Have you executed make patch first?

Yes, enableCommitLogPrintf: Boolean = true, is enabled in riscv-boom repo.

I also changed the file config/build.mk like this:
STARSHIP_TH 	?= starship.asic.TestHarness
STARSHIP_TOP	?= starship.asic.StarshipSimTop
STARSHIP_CONFIG	?= starship.asic.StarshipSimConfig

Does this configuration apply to the BOOM core?

Could you please check if the io_commit_uops_1_debug_pc exists in the RoB module?

I believe the StarshipSimConfig is using the BOOMSmallConfig now, which only utilizes 1 decode port. Therefore, it should be safe to remove all references to uops_1 ports. The spike_difftest.v file is part of the legacy code from our previous work, and we are planning to update the entire framework in November.

Oh, it's a little weird.
I checked the verilog file generated by firrtl BOOM.StarshipSimTop.StarshipSimConfig.top.v and notice the ROB module only has a bunch of signals like io_commit_uops_0_xxx.
However, the error message contains many signals related to io_commit_uops_1_xxx. and io_commit_uops_2_xxx.

Yes, you can remove all uops_1 and uops_2 checks in the spike_difftest.v, as they were used in the past when we still used the MediumBOOMConfig.

Oh, thank you ~


Group samples by threshold(s) on quantitative variables

Use case: The user would like to split the samples into two groups based on a specific threshold and see the exact sizes of the groups.
Currently there's group to quartiles. That's quick and practical, but not specific enough.
It would be nice to support multiple breakpoints. However, it quickly becomes a bit complicated, because it should be possible to define open/closed ranges, etc.

Closed by https://github.com/genome-spy/genome-spy/commit/dd9e5cf5394d9733c50741369f226dec348be591


Trailing whitespaces are not stripped from the long URL

Not sure if this is on purpose or not but this was reported to me by one of my users.  For example, if you enter into the long URL 'http://google.com/ ' then the link will be saved as 'http://google.com/ '.
I think the simple solution would be to add the following somewhere:
$url =  trim ( $url , " \t\n\r\0\x0B" );
But where exactly?  I was also thinking that this could be a plugin just for those who want it but, again, I'm not sure where to insert it.
Some help please?

Yep, strange. Need review.

I updated one of my old plugins that fixed a different problem:
https://github.com/adigitalife/yourls-fix-long-url
It now also removes trailing spaces but not other possible types of whitespaces.

Indeed, leading and trailing whitespace should be stripped (eg shortening https//www.google.com/ makes http://%20https//www.google.com/%20 as of now). I'll look into this.


Warnings/Fix suggestions

First of all, very very good job on the work done so far with this plugin, I have almost given of on using nvim with csharp before seeing this plugin.
I have one small issue, and am wondering if its something that can be improved. Looking at this example

decision if this warning is valid or not aside, If I want to disable this specific kind of warning by code say (this one is IDE0058) is there a way to do this? If not is it possible to add such functionality?

I've learned this has nothing to do with this plugin (sorry for bothering you)
it was
omnisharp-roslyn -> .editorconfig -> create something like
root = true

[*]
indent_style = space

[*.{cs,csx}]
dotnet_diagnostic.IDE0008.severity = none
dotnet_diagnostic.IDE0058.severity = none


How to do code coverage ?

Hello,
I have followed the guide to use vue-test-utils with mocha.
It work great, no problem.
Then I wanted to add code coverage, since my initial config (based on the official vue+webpack template) came with it.
But I can't seem to make it work. I have followed mocha-webpack guide on code coverage and it doesn't work.
Can you add an example of code coverage in the official example ?
Thanks a lot for your hard work !

Hi @lionel-bijaoui
I agree, it would be nice to add these to the docs 😀

Vue-test-utils with jest also need an official example 😀

@zhouweicsu What kind of example are you interested in? Project structure? package.json jest config?

I can document the process with Jest if you like; I've got a running setup locally. Would that help, @eddyerburgh ?

I've opened a PR for this repo; I'll add similar code to the example repo too, and link here when it's done.

^^ As promised, similar code in the vue-test-utils-jest-example repo. Please comment and review, and enjoy the holidays! 🎅

I'm reopening, because we still need to add docs on code coverage with mocha-webpack

I won't be able to pick that part up; I've no experience with Mocha, I'm afraid, and I'm sure there are others better positioned to explain it's usage.

I think we could just add a link to the mocha-webpack docs—https://github.com/zinserjan/mocha-webpack/blob/master/docs/guides/code-coverage.md, I'll make a PR

The mocha-webpack document is an explanation for testing js file.
IMHO,
I think the method to test vue file is necessary.

We've added code coverage to the official repo, thanks @38elements 🙂

The mocha-webpack docs are not clear on how to use it with vue-cli. It has a webpack.config-test.js, but we have to set it up using vue.config.js. I tried this, but didn't work:
// vue.config.js

const path = require('path');

const publicPath = process.env.BASE_URL;
const isCoverage = process.env.NODE_ENV === 'coverage';

module.exports = {
  lintOnSave: false,
  publicPath,
  configureWebpack: {
    devServer: {
      port: process.env.PORT || 23045,
      // To accept requests from Docker Apache proxy
      disableHostCheck: true,
      publicPath,
    },

    resolve: {
      alias: {
        '#': path.resolve(__dirname, 'tests/unit'),
      },
    },

    module: {
      rules: [].concat(
        isCoverage ? {
          test: /\.(js)/,
          include: path.resolve('src'), // instrument only testing sources with Istanbul, after ts-loader runs
          loader: 'istanbul-instrumenter-loader',
          query: {
            esModules: true,
          },
          enforce: 'pre',
        } : [],
      ),
    },
  },
};

// .nycrc
  "nyc": {
    "include": [
      "src/**/*.js"
    ],
    "instrument": false,
    "sourceMap": false
   }

There is also this question on Stack Overflow: https://stackoverflow.com/questions/53782097/generating-nyc-coverage-report-for-vuejs-project-with-vue-cli-plugin-unit-mocha
Basically the same issue.

I've had so much trouble with trying to get this to work for me with using mocha. I decide to do one last search and found @roopen219 answer and added the items below to my package.json under nyc section. I added include and extension and it finally worked for me. Thank you!.
//package.json

  "nyc": {
    "instrument": false,
    "sourceMap": false,
    "include": [
      "src/**/*.{js,vue}"
    ],
    "extension": [
      ".js",
      ".vue"
    ]
  }


add topics

I suggest adding the topics assert, assertion in the About section.

Thank you for your kind suggestion.
I added some topics, including assert, assertion, fortran, and others.


Deprecate and disable error-prone gradle.settingsEvaluated call after evaluation

Deprecate and disable error-prone gradle.settingsEvaluated call after evaluation, similar to what was done to project.afterEvaluate. It's error-prone because we get no warning if that callback will never execute.
Expected Behavior
Similar failure to failAfterProjectIsEvaluated:
https://github.com/gradle/gradle/blob/1138d3f69d5153604111359ddfe9d7c512a7abef/subprojects/core/src/main/java/org/gradle/api/internal/project/DefaultProject.java#L1065-L1069
Current Behavior
[crickets], i.e. nothing happens when we call gradle.settingsEvaluated { ... } from a project's build.gradle file.
Context
A similar change was done to project.afterEvaluate recently:
To deprecate: Commit https://github.com/gradle/gradle/commit/a3b0a839c2c809f2fcf2494274da1edaa13d66c2
To fail: Issue https://github.com/gradle/gradle/issues/15873 -> PR https://github.com/gradle/gradle/pull/16070
cc who done this: @jjohannes @donat @lacasseio
Related issues
https://github.com/gradle/gradle/issues/17914 -> because @runningcode is asking for the opposite as far as I understand.
https://github.com/gradle/gradle/issues/17295 -> because @grossws mentioned this usage in https://github.com/gradle/gradle/issues/17295#issuecomment-951212731 as a workaround to access the settings object.
Additional thoughts
Maybe all lifecycle callback methods should have the same failure mechanism to prevent their usage at the wrong time. It's really easy to move a method call to the wrong phase/time in the Gradle lifecycle.

Sorry for the late reply!
This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

We should clarify the exact state of Project.afterEvaluate and indeed have a consistent behaviour for Gradle.settingsEvaluated.
Relates to:

#17914
#3411
#15873

This feature request is in the backlog of the relevant team and is prioritized by them.

We're not ready to make a decision if we want #20047 or #17914 at the current moment, but we agree that the current behavior should be changed. Isolated Projects may also impact this decision.

Thanks for the update!


Dawn2 genesis file for testnet3 stat-531

Adding staked balance of 10000 to init accounts.

Closing request as the genesis contents are no longer relevant.


Define rules outside? Minor release? #helpwanted

Hello @Clayton7510 , I read in one of the comments/descriptions that with a new minor release, rules can also be defined outside the java code, when will the release be available?
Regards,
Ritika

Closing since this is discussed in Issue #9 and Issue #84.


add a section for comman fruits names

Is your feature request related to a problem? Please describe.
i want to add a new section for command fruits names
Describe the solution you'd like
similar to birds name . i will add cards for fruits.

@sapatevaibhav kindly assign this issue to me.

i would like to contribute to this issue... kindly assign me i am GSSOC'24 contributor

Go to #21.


Multiple source read binlogs of the same job are all assigned to SubTask-0, which may have performance problems.

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Multiple source read binlogs of the same job are all assigned to SubTask-0, which may have performance problems.

As shown in the above two figures, the jobs running in our production environment have several sources, and all sources are assigned to the same subtask. When there are many sources, performance problems may occur.
Solution
When a job has multiple subtasks, different sources can be randomly assigned to different subtasks for execution to prevent all sources from being executed on one subtask.
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Closing this issue as it has been migrated to Apache Jira.


Collect Github Forks

Additionally, in your GitInsight back-end applications implement a new analysis. It should be able to list all forks of a repository on GitHub. To do so, it should call the GitHub REST API and collect a list of all forks from a given repository. That is, when your GitInsight REST API receives a GET request with a GitHub repository identifier of the form <github_user>/<repository_name> or <github_organization>/<repository_name>, then besides the two already existing analyses of cloned Git repositories your application contacts the GitHub REST API to collect the number of forks of that repository.
To connect to the GitHub REST API, you need an Access Token. Read this documentation on how to receive an Access Token for the GitHub REST API. Remember and double check on how Rasmus demonstrated to handle secrets like access tokens in .Net projects. That is, do not store the access token directly in your source code. It should never end up in your source code repository that is publicly shared with the world.

#100
#99


Create Outputs-Cannot-Contain-ListKeys-Variables.json

Add example of case that is expected to fail.
@bmoore-msft, per the discussion over here seems that in Bicep, when the output of listKeys is assigned to a variable, and then an output, no alert is triggered. But, I thought I had seen ARM-TTK properly catch this in the past.... Proposing this test case to confirm or deny my memory.
If this test case passes, we could merge this PR in as confirmation. But if it fails, I expect the fix would be done on the bicep side.

Oops, looks like ARM-TTK won't catch this case after all.

Output cannot have secrets.


nest anchor within paragraph instructions modification

wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing a element to make it more clear

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #17406

@nikrb @RandellDawson So are we agreeing on changing 'your' to 'the' and removing the other change?

@bannon-tanner You are correct.  Only change 'your' to 'the. Go ahead and revert the other change, so we can approve this PR and get it merged.

I made the change on the user's behalf to avoid waiting any longer.

@Nirajn2311 or @nikrb  Feel free to merge this PR.

Thank you @bannon-tanner for your contribution. Looking forward to more contributions from you! 🎉


Add security section to contributors faq

Added nine questions/answers particular to Security from a contributor's perspective.

Nice. Where did this content come from? Is it good to go?

Thanks for the feedback, yes GTG - I came up the questions based on what I would ask if I was thinking about writing a library - and then researched using internet tools.


CB-10910 Add Cruise Control to the Knox Topology template

Added Cruise Control to the exposed services list and the Knox topology template.
Testing:

Updated the unit test for ExposedServices
Tested manually

retest this please

We need icon on the ui side

Created a separate ticket for the icon.

retest

ExposedServiceCollectorTest unit test failed @benyoka

ExposedServiceCollectorTest unit test failed @benyoka

Looks like there are 5 test cases in ExposedServiceCollectorTest.java where the expected map does not contain CRUISE-CONTROL, but the tested function's return value does.


How does yolo replace dpm

I use object-detection by dpm，but the effect is not good。And，the yolo-v3 worked very well。So I want to use object-detection by yolo。But it seems that yolo does not send topics（/obj_xxx/image_obj） to node(/obj_xxx/ranging).So what should I do?thanks~~

You should check the README.md in the package of vision darknet detect
https://github.com/CPFL/Autoware/tree/master/ros/src/computing/perception/detection/vision_detector/packages/vision_darknet_detect

You should check the README.md in the package of vision darknet detect
https://github.com/CPFL/Autoware/tree/master/ros/src/computing/perception/detection/vision_detector/packages/vision_darknet_detect

Thank you very much for your reply!The Video(https://www.youtube.com/watch?v=pO4vM4ehI98) shows that yolo can publish /obj_xxx/image_obj, but in my practice it is found that yolo publishes /detection/vision_objects, the topic will be subscribed to /obj_xxx/ranging, and used to track?Thank you again for your reply~~

DPM is now considered deprecated, and will be removed.
Just as @yukitsuji mentioned
The output is shown here:
https://github.com/CPFL/Autoware/tree/master/ros/src/computing/perception/detection/vision_detector/packages/vision_darknet_detect#published-topics
Fusion is also changing. Please follow:
https://github.com/CPFL/Autoware/issues/1501
for updates.


Docker Build Failure

Describe the bug
7
COPY package.json pnpm-lock.yaml ./
8
9
RUN corepack enable pnpm && pnpm install
! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-9.4.0.tgz
Progress: resolved 0, reused 0, downloaded 1, added 0
âERR_PNPM_FETCH_404â GET<EMAIL_ADDRESS>Not Found - 404
This error happened while installing a direct dependency of /app
No authorization header was set for the request.
10
11
Copy the rest of your app's source code
12
COPY . .
13
Link to the Bolt URL that caused the error
?
Steps to reproduce
npm run dockerbuild
Expected behavior
Completed Build
Screen Recording / Screenshot
No response
Platform
MAC OS Sequoia
Docker Desktop 4.36.0 (175267) is currently the newest version available.
Remote source location
https://github.com/coleam00/bolt.new-any-llm.git
Revision[ba29e59]
(https://github.com/coleam00/bolt.new-any-llm/commit/ba29e5927f7300b67d1398155d476157fa5460fc)
Tags
BOLT-AI:DEVELOPMENT
BOLT-AI:LATEST
Provider Used
No response
Model Used
No response
Additional context
No response

I also am having issues getting the docker to build, though I'm using docker build instead of npm. Here's the issue I see
"Creating Service...
Starting creation of new service...
Pulling image bolt-ai-production
[ERROR] Rolling back changes because of -- Image pull error: Error response from daemon: pull access denied for bolt-ai-production, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
[OPERATION FAILED]. CHANGES HAVE BEEN ROLLEDBACK."


Package azureml-* for conda-forge?

Hey all
I've recently become involved with a project that needs azureml-defaults, and it's a bit of a pain to use well in a conda-environment, because of some very specific version pinnings & ranges, and pip just trampling over the conda-environment (uninstalling package versions it doesn't like), potentially breaking the environment.
Right now, to avoid such collisions - i.e. to get to a point where conda installs as many packages as possible (with only those not packaged for conda-forge yet coming from pip) - takes a bunch of painful iteration, and it would be cool to just avoid that by having the azureml-packages in conda-forge.
I haven't found any sources for azureml-defaults, so I'm asking here first (hoping it's the right issue tracker) if this is desired at all? I'm experienced in packaging things for conda-forge, so that wouldn't be a huge issue, but it (normally) depends on availability of the sources.
There are rare cases for which conda-forge will consider binary repackaging, but even in those cases, we'd need the dependency metadata in a reasonably accessible form. It's possible to reverse-engineer this from observing what pip install azureml-defaults does, but that's not scalable.
I still did that as a one-time exercise (tf-addons is superfluous for this argument, but I don't want to redo this), and below is the outcome. Everything between the comment after tqdm and the pip-section is coming in as a dependency of azureml-defaults=1.36.0 (or tf-addons). It's very likely that I made minor mistakes (and I left out lower bounds completely), but just to show the principle.

Sample env.yml
name: mlflow-env
channels:
- conda-forge
- defaults  # only necessary for tensorflow on windows
dependencies:
- python =3.8
- pip
- mlflow
- numpy
- scikit-learn
- tqdm
- tensorflow =2.6
# avoid pip (un)installing packages unnecessarily
- adal <=1.2.7
- applicationinsights
- azure-core <2
- azure-graphrbac <1
- azure-identity =1.7.0
- azure-mgmt-authorization <1
- azure-mgmt-containerregistry
- azure-mgmt-keyvault <10
- azure-mgmt-resource <15
- azure-mgmt-storage <16
- backports.tempfile
- cloudpickle <2
- cryptography <4
- configparser =3.7.4
- contextlib2
- distro
- flask =1.0.3
- fusepy <4
- isodate
- jeepney
- jmespath <1
- jsonpickle <3
- msal_extensions ~=0.3.0
- ndg-httpsclient <=0.5.1
- pathspec <1
- portalocker ~=1.6
- psutil =5.8.0
- pyarrow <4
- pyopenssl <21
- typeguard
- wrapt <=1.12.1
- pip:
  - azureml-defaults==1.36.*
  - tensorflow-addons==0.14.*

Xref: #20339 #19960

Thanks for the feedback, we’ll investigate asap.

Thanks for the quick responses! Just to clarify, it's not necessary that the azure team does the packaging of azureml for conda-forge (though co-maintainership would be welcome!) - it's simply about the fact whether this would be desirable for azureml, and thus whether (ideally) the sources can be made publically available (or at least the dependency metadata).

@azureml-github We have our own repo https://anaconda.org/microsoft for Microsoft conda packages. Feel free to talk to me if you need help.

Closing legacy issue. @h-vetinari please create a new issue if you have the same ask for AzureML SDK v2 packages.
https://learn.microsoft.com/en-us/azure/machine-learning/concept-v2


Update manage-windows-devices.md

Made changes to the URL as from august 1st the current Intune Azure Portal experience will be retired

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/2466

@Sirkkuw Please merge this PR. Thanks


Filter out deleted accounts

PR Overview
This PR will address the following Issue/Feature: #55 in dbt_quickbooks_source
This PR will result in the following new package version:  0.16.0

We are removing deleted records, changing the transformation reporting, which requires a breaking change.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:

[x] dbt run –full-refresh && dbt test
[NA] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[x] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[x] Detailed validation steps have been provided below

Detailed Validation
Please share any and all of your validation steps:

All integration validation tests passed.

Upstream Source Package Updates

Deleted records have been previously been brought into the dbt_quickbooks package. To ensure accuracy in reporting, the following updates were made in the v0.11.0 release of dbt_quickbooks_source:
We introduced the _fivetran_deleted field to filter out deleted records from the following staging models:

stg_quickbooks__account
stg_quickbooks__bundle
stg_quickbooks__customer
stg_quickbooks__department
stg_quickbooks__item
stg_quickbooks__vendor

As this will filter out deleted records that were previously being counted and we are adding a new field to these staging models, this will be a breaking change here and in dbt_quickbooks.
Because deleted records are now being removed from these staging tables that then flow into dbt_quickbooks reports, these are breaking changes for this package.

Documentation update

Added the _fivetran_deleted field to the above corresponding seed files in integration tests.

If you had to summarize this PR in an emoji, which would it be?

🧢

@fivetran-avinash I realized I pasted the wrong screenshot yesterday. It's fixed now!

@fivetran-avinash as we discussed the failure is expected because of the udpates and after I redid tests there is no discrepancy between warehouses. Just some minor doc updates are left!


[Source Request]

Source website

Name: Mavanimes
Link: https://mavanimes.co/
Language(s): french

Other details
This is a site with a lot of choice and it would be nice if it was added 😁
Especially since for the moment there is only one source of anime in French.

I agree I hope someone add it

Same, I will look for it if i have some time


Base Components

[x] Card
[x] Input

[x] Checkbox
[x] Selectbox
[x]  Text

[x] Image
[x] Buttons
[x] Accordion

[x] Accordion Header

Completed.  #28


event section need to have proper #css

I can change the UI of event section with proper CSS.
Request you to please assign me this task , so that I can start working on this project.

I want to contribute in this

Please assign me as I issued this pr first.


winutil load is never the latest version

Either through the Winutil shortcut on dekstop, or online via the address  irm christitus.com/win | iex
I never upload the latest version of Winutil, as it does not have the date in the upper right part of the version.

Either through the Winutil shortcut on dekstop, or online via the address irm christitus.com/win | iex I never upload the latest version of Winutil, as it does not have the date in the upper right part of the version.

Thank you !!


CSRF in github-auth

I noticed this issue while I was working on #541. OAuth web application flows require a randomly generated state parameter to authenticate callback (redirection) requests from the client. Without this security check, adversaries can orchestrate a denial of service attack using the callback endpoint. For more info see:

https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#web-application-flow
https://stackoverflow.com/questions/26132066/what-is-the-purpose-of-the-state-parameter-in-oauth-authorization-request

TL;DR:

Just emailed you; thanks.

Clarified offline that this is low severity. We should still fix it quickly. 😬

It's not clear how to fix this. The state is exposed to the client; it's not a secret. We don't preserve any state between requests, and any state we did preserve would need to be shared between three servers. That's the least of it, really. The /github-auth endpoint hands out these strings. Since we don't authenticate those requests, it's not clear the state can do anything to help.
We could consider a rate limit.

In my opinion, this and the token pool solidifies the need for separate state storage such as a key-value database like Redis.

We could consider a rate limit.

How would state storage solve the problem? If one endpoint gives out tokens as fast as you want, and another consumes them, it doesn’t matter whether they are single use or not.
It’s more like putting a fence around it. We probably could limit to one token per 30 sec per IP, and 5 per 30 seconds overall, without much inconvenience to anyone.

You're right, rate-limiting the auth endpoint makes sense.


Adapter Interface should not enforce constructor

https://github.com/cloudflare/cloudflare-php/blob/master/src/Adapter/Adapter.php#L26
interface Adapter
{
    /**
     * Adapter constructor.
     *
     * @param Auth $auth
     * @param string $baseURI
     */
    public function __construct(Auth $auth, string $baseURI);

An interface should not enforce any constructor as this is an implementation-issue

In addition, it would be much nicer if the interface was the PSR interface (\Psr\Http\Client\ClientInterface) so that we could use any Http client.


Possible typo in note

Hi
I think there is a typo in the first note:
(...) If you're collection is configured (...)
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0afec182-d90d-9f34-90a7-1e70b99b3220
Version Independent ID: 63cc67a6-6baf-e4ed-34aa-2fb87b9a189b
Content: Create Excel reports from a work item query - Azure DevOps Server
Content Source: docs/report/create-status-and-trend-excel-reports.md
Product: devops
Technology: devops-analytics
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@l-diazs - Thank you for calling out the typo. I'll get it corrected later today.


adds "omitempty" only to optional field from input type model

Fix #77
omitempty tag option will only be added to input type model.

@crazydadz
Thank you for PR and sorry for being late. I want to merge this PR. Is it possible to resolve the conflict?

@Yamashou I reupdate the PR so it can be merged.


Handle internal error in POST requests

Context
Currently, when an exception occurs we're not seeing the proper error page, but a blank page instead. This is because we haven't configured the 500 page to show for POST requests (only GET).
Changes proposed in this pull request
Adds request routes for all HTTP methods. I've taken this from https://github.com/alphagov/content-publisher/commit/d97db8f4f9bcfcb9def8d4c4a1217e3ceac99d02, because when in doubt you should always copy @kevindew's code.
Guidance to review
Write a bug, deploy to QA, observe the error.
Link to Trello card
https://trello.com/c/YtFlMRNo

Per the (excellent) original commit message, does this also need a skip_before_action :verify_authenticity_token in the ErrorsController? Hitting reload on a POSTed error might have unexpected results otherwise.

@duncanjbrown I wondered about that, but I think we're alright because we never use protect_from_forgery in the ErrorsController or ApplicationController. Content Publisher does do that, so it needs it.

@duncanjbrown I wondered about that, but I think we're alright because we never use protect_from_forgery in the ErrorsController or ApplicationController. Content Publisher does do that, so it needs it.

Is there any reason not to have it on ApplicationController?

@duncanjbrown We don't use ApplicationController for anything, except content and errors.


Add nlog-ntfy integration to docs

I wrote an integration for the C# .NET logging framework NLog. It provides an Ntfy target and layoutrenderer as an extensions for NLog.
See the repository for more information.

Interesting. Thank you


docs: add section about computed url for data fetching

🔗 Linked issue

❓ Type of change

[X] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Adds a section for computed getters as URL. Similar to watch, but triggers a fetch every time the computed URL changes.
📝 Checklist

[ ] I have linked an issue or discussion.
[X] I have updated the documentation accordingly.

Thank you ❤


Reduce warm lambda processing time and add SAM framework

Hi, we would like to propose the following changes to your repo:
Performance optimisation
clamscan loads virus databases each time it is executed. The actual scan operation takes an order of magnitude less time to complete.

By starting ClamAV as a daemon and loading the virus databases only once, the execution time on warm lambdas improves drammatically:

Deployment optimisation
Managing the deployments and AWS resources and policies manually is hard to track and prone to human error. Infrastructure as code greatly reduces the risk of resource management and traceability.
The deployment process described in the README.md is written in a template file that can be deployed via SAM.
This PR can be split into two if necessary.
Thank you for building this tool 🙏

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi folks,
I am currently testing this and the PR requires aws-sam-cli to be installed on the local machine (referenced in the Makefile).
So to make all work again with this PR, a
sudo pip install aws-sam-cli

Is required.
I tried to use a virtualenv/pipenv to install this, but this is not picked up by the Makefile.
Would it be a better option to include aws-sam-cli in the Docker Image and run it from there instead of relying on the existence on the build machine?
Regards,
Florian.


Craft 4 Support

This PR just adds the minor changes required for Craft 4 support. The changes also requires PHP 8, consistent with the syntax changes required and Craft 4's minimum requirements.
I'd probably also suggest renaming the repo to craft-codemirror from craft3-codemirror, as I don't think a separate fork is required for Craft 4 support, and it'd only make sense to maintain separate branches if you want to continue to support a version that doesn't require PHP 8.

thanks for the contribution!


Issues as Comments

Following blog: http://blog.higher-order.com/blog/2016/04/02/a-comonad-of-graph-decompositions/ has its comments on the github issue tracker (e.g. https://github.com/runarorama/runarorama.github.com/issues/22). When a comment is added this is update. It would be good if this is possible in HubPress also.

It looks like this blogger uses Octopress, and a custom extension they offer to do this. There appears to be a github.js file that may be related when you inspect the element.

It will be great if you can automatically create the relevant issue on posting with the relevant link at the bottom.
Also some github js framework links:

https://github.com/michael/github
http://fitzgen.github.io/github-api/
https://github.com/akshaykumar6/github-js
https://github.com/philschatz/octokat.js
https://akshaykumar6.github.io/github-js/

We could implement this in HubPress too.
Actually we can't rebuild the HTML with a webhook or something similar.
A solution could be :

Create an issue when the user publish a post,
The title of the issue will be the title of the post,
We will add a label (slug of the title) to the issue
Add a script in the HTML template  of the post to call the Github API https://developer.github.com/v3/issues/#list-issues with the label of the issue.
Add an entry in the Settings page of HubPress to choose Disqus or GitHub

But the biggest problem are themes, actually i use themes made by Ghost users with a minimum of changes.
With this issue, we will have to change every themes, changing the CSS and maybe some JS

This is one of those times where you need to balance the cost vs value of
an enhancement.
And unfortunately the cost to implement this feature is probably too high
for the value it will bring for other users. :(
Sent from Mobile.


Quantity to 0

Hello is it possible to make the quantity set to 0 first at the first time?

Have you tried? I believe it is.


Date Standardization

Is your feature request related to a problem? Please describe.
When resources are created in the SDK, the device stores at least some dates without a time or timestamp i.e the Patients BirthDate e.g YYYY-MM-DD.
The current implementation stores the date as is, in local time and timezone information. These dates are also synced as is, we need to investigate that the dates uploaded to the server do not lose timezone information. e.g a device in GMT+3 syncing to a server in GMT-4 should auto adjust the date information
Describe the solution you'd like
The server/app implementation should be able to standardize all the date information.

We can either have all data uploaded by the apps adjusted to GMT+0 before upload and have the server parse all dates as GMT+0 or
Dates sent to the server should be in ISO 8601 format and should include the timezone information

I think solution 2 is good we can go with ISO 8601 @maimoonak what do you think

Checking the tables (SyncedResourceEntity, Patient.resource)  in sqlite database I see that sdk already stores timezone info, and the indexes are created on millis timestamp. So for datetime fields there would be no issue, however, the birthdate is a date (date-only) field and can not have timezone https://www.hl7.org/fhir/patient.html. So what we would do for such fields?
{"resourceType":"Patient","id":"3","meta":....."lastUpdated":"2021-03-10T13:18:22.074+00:00",...."birthDate":"1988-08-04",.....}]}

Thanks @maimoonak for your input. I think we are already complying with the ISO 8601 date format for resources synchronization.
cc: @rkodev

If birth dates are dates only, that shouldn't be a problem, we can assume it's the same date in all timezones, I think that's ok since we don't have more information. I don't think we usually record time of birth (@isabelcshaw is that common enough to plan for it now or can we wait until we see this requested?)

@pld I've never seen a need to record time of birth. For the CHW workflows, we only record a self reported DOB - and, in some cases, age (and estimate a DOB) if they don't know the actual date. Unless I'm misunderstanding this question, I don't see any use case for time of birth unless a future facility/ANC/PNC app requires it, which I think would be rare.

@ekigamba can you check @maimoonak comment here

@rkodev I think what you proposed should work. Standardizing all dates without timezone to GMT before sharing them i.e.

On the API
Client to server upload

I see @pld also suggests that we can assume the dates being OK and disregard any timezone differences where we only have a date

@ekigamba I think given @maimoonak and @syedowaisali90's comments, and the fact we're already storing tz info, we're leaning towards option (2) in @rkodev's description: store all dates w/tz info in ISO 8601

@pld the Patient.birthDate of type date https://www.hl7.org/fhir/datatypes.html#date does not have timezone per the specification. The Google Android FHIR SDK also saves the date without any timezone information.
I think this will apply for any other Resource property of type date. Any inconsistencies will affect any age/date calculations across the system. I cannot accurately say if the impact will be significant but it would be good to have this resolved/decided before we start recording any such data

OK I might be missing something then, if it's a date it wouldn't have a tz to begin with so we wouldn't have to worry about standardization.
If it's a datetime it will include tz info and we can store it.

@pld Yea, I think this should be OK

I think as we already saving the consistent date and tz info then we don't need to remain this issue open anymore. @rkodev


Return yParity from eth_getBlockByNumber

Description
The outputs of eth_getBlockByNumber are not standardized across clients because of the yParity field
Acceptance Criteria
Return yParity from eth_getBlockByNumber
Steps to Reproduce (Bug)
Send the following JSON-RPC request to a Besu node and then either a Geth, Reth, or Nethermind Node, and compare the outputs:
{"method":"eth_getBlockByNumber","params":["0x10b7cfb",true],"id":1,"jsonrpc":"2.0"}

Geth, Reth, and Nethermind include a field called yParity in the output. Besu does not.
Expected behavior:
Standardized outputs between all clients
Actual behavior:
yParity key missing in the output of eth_getBlockByNumber
Frequency:
Always

Already fixed, coming in next weeks release - https://github.com/hyperledger/besu/pull/6119

Thanks, I searched issues, but didn't search PRs 😄


how to modify dpdk code

i try to modify dpdk printf code and make dpdk and nff-go,but i run nff-go code,the output still display the old code result
env dpdk 18.09
centos 7.9

need to make clean and make in nff-go catalogue not in nff-go/dpdk make clean and make


Always display timezone of the other person in the chat window - Reported by @Santhosh-Sellavel

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open Any User Chat with the same timezone as yours.  OR (Create two test accounts User A & B with the same timezone settings. And Open User B's chat logged in as User A )
Navigate to User Details by clicking on the chat header

Expected Result:
Timezone should be displayed at bottom of chat in all 1:1 chats.
Actual Result:
Currently timezone is displayed at bottom of chat only if your timezone doesn't match the timezone of the other person.
Eg. Sonia is in PST, Vic is in AEDT. So in the Sonia-Vic chat both see each other's local time at the bottom of the chat window:

Sonia is in PST, and Francois is in PST. So the Sonia-Francois chat doesn't display local time at the bottom of the chat:

Showing timezone in some cases but not in others feels unintentional. Let's make it consistent by showing the other person's local time at the bottom of a 1:1 chat in all cases regardless of the participants' timezones.
Workaround:
Click on the profile icon of the person you're chatting with to open their Details panel which lists their timezone and local time.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.38-0
Reproducible in staging?: y
Reproducible in production?: y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by:  @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643993593833769
View all open jobs on GitHub

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

This is not a bug.

I know this is on purpose and we don't display the timezone if they are the same. But to me as a user, it looks broken. I don't know if the other person is in my same timezone or not. I rather see the timezone in every chat.

I don't think I've ever seen any chat/email systems display sender's timezone on the message timestamp. If we were to be the first to do that, it would be confusing to users since there isn't a precedent for this.
Currently we show the message timestamp in your timezone. If the other person in the chat is in a different timezone then their timezone is displayed at the bottom of the window.
Victoria is in AEDT, I am in PST so I'm shown her current time:

If they're in the same timezone as you, then their time isn't displayed. Nikki and I are both in PST:

I think it makes sense to either leave it as it is or display local time at the bottom of every chat (so my chat with Nikki would show her time too). @iwiznia do you think we should make this change?

I have no idea where some people are or if where they are it's the same time zone as where I am. I went to a chat and wanted to know if they could be online based on their time and did not see it there, to me it looked like a bug because all other chats seemingly have it.
So yeah, I think we should always show the other user's timezone, no matter if they are in the same timezone as you or not.

Made some tweaks to the original post

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal
Here is the restriction we make to hide the other user's time, removing this check would be enough to handle this one.
https://github.com/Expensify/App/blob/58f0168373e022440a01a966a0bae772f01dda1e/src/libs/reportUtils.js#L230

Posted to Upwork: https://www.upwork.com/jobs/~01fb9158fbedf74de3

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Current assignee @chiragsalian is eligible for the Exported assigner, not assigning anyone new.

Proposal from Upwork
Hi!
This seems like it's not a bug, but the way the front end is coded.
I.e:- When time zones match render time at the top and when they are different, render it at the bottom.
This can be fixed by merging the different timezone logic from bottom with the one at the top.
Eg: { timezoneOfUser1==timezoneOfUser2?  : }
Or remove the logic of checking timezones completely and just use new Date(timestamp) which will return the Date & Time object in users native timezone

I like @Santhosh-Sellavel 's proposal.
cc: @chiragsalian
:ribbon: :eyes: :ribbon:  C+ reviewed

Yup it lgtm too.
Feel free to create the PR @Santhosh-Sellavel.

📣 @Santhosh-Sellavel You have been assigned to this job by @chiragsalian!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@Santhosh-Sellavel please don't forget to apply in Upwork!

Done @kadiealexander !

Paid @Santhosh-Sellavel for his fix + reporting bonus, and paid @parasharrajat for C+. Thanks team!


Index Error: Map::at when Calling .backward()

Hi there,
I am trying to run the Pyjuice example 1 notebook for training a Probability Circuit and I have been consistently getting the below Index Error: Map::at.
I am using Cuda 12.1, Torch 2.2 and Triton 2.3 but I've replicated the error with all versions of Torch and Triton supported by Pyjuice.
I'm not sure if this is a bug or a problem with my configuration but if you've run into this before any help would be greatly appreciated.
All the best,
Josh
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[13], line 14
     11 lls = pc(x)
     13 # Backward pass
---> 14 lls.mean().backward()
     16 train_ll += lls.mean().detach().cpu().numpy().item()
     18 # Perform a mini-batch EM step

File /opt/conda/lib/python3.11/site-packages/torch/_tensor.py:525, in Tensor.backward(self, gradient, retain_graph, create_graph, inputs)
    515 if has_torch_function_unary(self):
    516     return handle_torch_function(
    517         Tensor.backward,
    518         (self,),
   (...)
    523         inputs=inputs,
    524     )
--> 525 torch.autograd.backward(
    526     self, gradient, retain_graph, create_graph, inputs=inputs
    527 )

File /opt/conda/lib/python3.11/site-packages/torch/autograd/__init__.py:267, in backward(tensors, grad_tensors, retain_graph, create_graph, grad_variables, inputs)
    262     retain_graph = create_graph
    264 # The reason we repeat the same comment below is that
    265 # some Python versions print out the first line of a multi-line function
    266 # calls in the traceback and some print out the last line
--> 267 _engine_run_backward(
    268     tensors,
    269     grad_tensors_,
    270     retain_graph,
    271     create_graph,
    272     inputs,
    273     allow_unreachable=True,
    274     accumulate_grad=True,
    275 )

File /opt/conda/lib/python3.11/site-packages/torch/autograd/graph.py:744, in _engine_run_backward(t_outputs, *args, **kwargs)
    742     unregister_hooks = _register_logging_hooks_on_whole_graph(t_outputs)
    743 try:
--> 744     return Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
    745         t_outputs, *args, **kwargs
    746     )  # Calls into the C++ engine to run the backward pass
    747 finally:
    748     if attach_logging_hooks:

File /opt/conda/lib/python3.11/site-packages/pyjuice/model/tensorcircuit.py:24, in _pc_model_backward_hook(grad, pc, inputs, record_cudagraph, apply_cudagraph, **kwargs)
     22 def _pc_model_backward_hook(grad, pc, inputs, record_cudagraph, apply_cudagraph, **kwargs):
     23     grad = grad.permute(1, 0)
---> 24     pc.backward(
     25         inputs = inputs,
     26         ll_weights = grad / grad.sum() * grad.size(1),
     27         compute_param_flows = pc._optim_hyperparams["compute_param_flows"],
     28         flows_memory = pc._optim_hyperparams["flows_memory"],
     29         record_cudagraph = record_cudagraph,
     30         apply_cudagraph = apply_cudagraph,
     31         **kwargs
     32     )
     34     return None

File /opt/conda/lib/python3.11/site-packages/pyjuice/model/tensorcircuit.py:346, in TensorCircuit.backward(self, inputs, ll_weights, compute_param_flows, flows_memory, input_layer_fn, cache, return_cache, record_cudagraph, apply_cudagraph, allow_modify_flows, **kwargs)
    344     g.replay()
    345 else:
--> 346     _run_inner_layers()
    348 # Compute backward pass for all input layers
    349 for idx, layer in enumerate(self.input_layer_group):

File /opt/conda/lib/python3.11/site-packages/pyjuice/model/tensorcircuit.py:313, in TensorCircuit.backward.<locals>._run_inner_layers()
    310     self.inner_layer_groups[layer_id-1].forward(self.node_mars, self.element_mars, _for_backward = True)
    312     # Backward sum layer
--> 313     layer_group.backward(self.node_flows, self.element_flows, self.node_mars, self.element_mars, self.params,
    314                          param_flows = self.param_flows if compute_param_flows else None,
    315                          allow_modify_flows = allow_modify_flows)
    317 else:
    318     raise ValueError(f"Unknown layer type {type(layer)}.")

File /opt/conda/lib/python3.11/site-packages/pyjuice/layer/layer_group.py:52, in LayerGroup.backward(self, *args, **kwargs)
     49 def backward(self, *args, **kwargs):
     51     for layer in self.layers:
---> 52         layer.backward(*args, **kwargs)

File /opt/conda/lib/python3.11/site-packages/pyjuice/layer/sum_layer.py:298, in SumLayer.backward(self, node_flows, element_flows, node_mars, element_mars, params, param_flows, allow_modify_flows)
    295         parpids = self.partitioned_parpids[partition_id]
    296         cs_block_size = self.cs_block_sizes[partition_id]
--> 298         self._backward(
    299             node_flows, element_flows, params, node_mars,
    300             element_mars, param_flows,
    301             chids = chids, parids = parids, parpids = parpids,
    302             cs_block_size = cs_block_size,
    303             partition_id = partition_id,
    304             allow_modify_flows = allow_modify_flows
    305         )
    307 else:
    308     # Partial evaluation
    309     for partition_id in range(self.num_bk_partitions):

File /opt/conda/lib/python3.11/site-packages/pyjuice/layer/sum_layer.py:1090, in SumLayer._backward(self, node_flows, element_flows, params, node_mars, element_mars, param_flows, nids, cids, pids, pfids, chids, parids, parpids, cs_block_size, local_ids, partition_id, mode, allow_modify_flows)
   1087     mode = self.BLOCK_SPARSE
   1089 if mode == self.BLOCK_SPARSE:
-> 1090     self._backward_block_sparse(
   1091         node_flows, element_flows, params, node_mars, element_mars, param_flows,
   1092         nids, cids, pids, pfids, chids, parids, parpids, cs_block_size, local_ids,
   1093         partition_id = partition_id, allow_modify_flows = allow_modify_flows
   1094     )
   1096 elif mode == self.SPARSE:
   1097     self._backward_sparse(
   1098         node_flows, element_flows, params, node_mars, element_mars, param_flows,
   1099         nids, cids, pids, pfids, chids, parids, parpids, cs_block_size, local_ids,
   1100         partition_id = partition_id, allow_modify_flows = allow_modify_flows
   1101     )

File /opt/conda/lib/python3.11/site-packages/pyjuice/layer/sum_layer.py:1270, in SumLayer._backward_block_sparse(self, node_flows, element_flows, params, node_mars, element_mars, param_flows, nids, cids, pids, pfids, chids, parids, parpids, cs_block_size, local_ids, partition_id, allow_modify_flows)
   1268 # Flows w.r.t. input elements (product nodes)
   1269 if chids is not None:
-> 1270     self._backward_block_sparse_ele_flows(
   1271         node_flows, element_flows, params, node_mars, element_mars,
   1272         chids = chids, parids = parids, parpids = parpids,
   1273         cs_block_size = cs_block_size, local_ids = local_ids,
   1274         partition_id = partition_id, allow_modify_flows = allow_modify_flows
   1275     )
   1277 # Flows w.r.t. parameters
   1278 if param_flows is not None and nids is not None:

File /opt/conda/lib/python3.11/site-packages/pyjuice/layer/sum_layer.py:1575, in SumLayer._backward_block_sparse_ele_flows(self, node_flows, element_flows, params, node_mars, element_mars, chids, parids, parpids, cs_block_size, local_ids, partition_id, allow_modify_flows)
   1572 grid = (triton.cdiv(batch_size, BLOCK_B), triton.cdiv(layer_n_nodes, TILE_SIZE_M))
   1574 if TILE_SIZE_M >= 8 and TILE_SIZE_K >= 8 and BLOCK_B >= 8:
-> 1575     self._bk_triton_block_sparse_ele_kernel[grid](
   1576         node_flows = node_flows,
   1577         element_flows = element_flows,
   1578         node_mars = node_mars,
   1579         element_mars = element_mars,
   1580         params = params,
   1581         chids = chids,
   1582         parids_start = parids_start,
   1583         parids_increment = parids_increment,
   1584         parpids_start = parpids_start,
   1585         parpids_increment = parpids_increment,
   1586         local_ids = local_ids,
   1587         batch_size = batch_size,
   1588         partial_eval = partial_eval,
   1589         ptr_inc_step = ptr_inc_step,
   1590         allow_modify_flows = allow_modify_flows,
   1591         BLOCK_B = BLOCK_B,
   1592         TILE_SIZE_K = TILE_SIZE_K,
   1593         K_NUM_TILES = K_NUM_TILES,
   1594         TILE_SIZE_M = TILE_SIZE_M,
   1595         BLOCK_SIZE_M = BLOCK_SIZE_M,
   1596         BLOCK_SIZE_K = BLOCK_SIZE_K,
   1597         TL_DOT = TL_DOT,
   1598         num_warps = 2, # TODO: test for different devices
   1599         num_stages = 1
   1600     )
   1601 else:
   1602     self._bk_triton_block_sparse_ele_csmm2_kernel[grid](
   1603         node_flows = node_flows,
   1604         element_flows = element_flows,
   (...)
   1626         num_stages = 1
   1627     )

File /opt/conda/lib/python3.11/site-packages/pyjuice/utils/kernel_launcher.py:58, in FastJITFunction.__getitem__.<locals>.wrapper(*args, **kwargs)
     56     kernel[(grid0, grid1, grid2)](*aligned_args)
     57 else:
---> 58     kernel = self.jit_fn[grid](*args, **kwargs)
     59     self.cache[signature] = kernel

File /opt/conda/lib/python3.11/site-packages/triton/runtime/jit.py:167, in KernelInterface.__getitem__.<locals>.<lambda>(*args, **kwargs)
    161 def __getitem__(self, grid) -> T:
    162     """
    163     A JIT function is launched with: fn[grid](*args, **kwargs).
    164     Hence JITFunction.__getitem__ returns a callable proxy that
    165     memorizes the grid.
    166     """
--> 167     return lambda *args, **kwargs: self.run(grid=grid, warmup=False, *args, **kwargs)

File /opt/conda/lib/python3.11/site-packages/triton/runtime/jit.py:416, in JITFunction.run(self, grid, warmup, *args, **kwargs)
    414     # compile the kernel
    415     src = ASTSource(self, signature, constants, configs[0])
--> 416     self.cache[device][key] = compile(
    417         src,
    418         target=target,
    419         options=options.__dict__,
    420     )
    422 kernel = self.cache[device][key]
    423 if not warmup:

File /opt/conda/lib/python3.11/site-packages/triton/compiler/compiler.py:193, in compile(src, target, options)
    191 module = src.make_ir(options)
    192 for ext, compile_ir in list(stages.items())[first_stage:]:
--> 193     next_module = compile_ir(module, metadata)
    194     metadata_group[f"{src.name}.{ext}"] = fn_cache_manager.put(next_module, f"{src.name}.{ext}")
    195     module = next_module

File /opt/conda/lib/python3.11/site-packages/triton/compiler/backends/cuda.py:199, in CUDABackend.add_stages.<locals>.<lambda>(src, metadata)
    197 stages["ttir"] = lambda src, metadata: self.make_ttir(src, metadata, options)
    198 stages["ttgir"] = lambda src, metadata: self.make_ttgir(src, metadata, options, self.capability)
--> 199 stages["llir"] = lambda src, metadata: self.make_llir(src, metadata, options, self.capability)
    200 stages["ptx"] = lambda src, metadata: self.make_ptx(src, metadata, options, self.capability)
    201 stages["cubin"] = lambda src, metadata: self.make_cubin(src, metadata, options, self.capability)

File /opt/conda/lib/python3.11/site-packages/triton/compiler/backends/cuda.py:173, in CUDABackend.make_llir(src, metadata, options, capability)
    171     add_external_libs(src, names, paths)
    172 # TritonGPU -> LLVM-IR
--> 173 ret = translate_triton_gpu_to_llvmir(src, capability, tma_infos, runtime.TARGET.NVVM)
    174 if len(tma_infos) > 0:
    175     metadata["tensormaps_info"] = parse_tma_info(tma_infos, metadata["ids_of_folded_args"])

IndexError: map::at

Hi Josh,
This seems to be a bug coming from triton but not pyjuice. See for example https://github.com/triton-lang/triton/issues/155. Please consider upgrading your CUDA driver and check if all triton run tests can pass.
Feel free to follow up if the error persists.
Best,
Anji

Hi Anji,
Thank you for such a prompt response. It seems like the error is persisting as my driver is up-to-date and other than my gpu (NVIDIA T4, Compute Capacity 7.5) not supporting bfloat16, the tests for Triton pass and I can run their tutorial code just fine. I'm not familiar with Triton so I'm not sure what could be going on (maybe the pyjuice .backward method requires certain data types?).
Do you have a development docker image I could build to see if that works? I am using AWS sagemaker so I can spin up whatever environment/ hardware you recommend.
Thanks so much, excited to experiment with the library as PCs seem like they could be perfect for my use case.

Josh

As an update, I tried using a higher compute capacity rated GPU (8.5) that supported bfloat16. It looks like the code runs properly now. Triton says their library requires a GPU >= 7.0 but it seems like pyjuice needs one >= 8.0.

Thanks for the update! I've using GPUs with high compute capabilities and I didn't realize this.


survey template extractor fail with 500

survey template extractor fail with http error 500

@muzammil-ali1 - did this get fixed as part of the other survey issue you were working on ?

yes this has been fixed with #4467