CORTX-30701: Fixed community build issues

Signed-off-by: Mukul Malhotra<EMAIL_ADDRESS>Describe your changes in brief
Fixed checkout command to checkout from a tag
Changes

[ ] Why is this change required? What problem does it solve?
[ ] If proposing a new change then please raise an issue first

How Has This Been Tested? (Optional)

[x] Please describe in detail how you tested your changes.
[ ] Include details of your testing environment, and the tests you ran to
[ ] How your change affects other areas of the code, etc.

Screenshots (if appropriate)
Checklist

[x] tested locally
[ ] added new dependencies
[x] updated the docs
[ ] added a test

View rendered doc/community-build/docker/cortx-all/README.md

LGTM!

will create a new PR


StyleCop 6.1.0 marking as syntax error SA102 C# 6 null-conditional “?.” operator

I have StyleCop 6.1.0 running in Visual Studio Enterprise 2017. And StyleCop still marks a as syntax error SA102 legal C# 6 null-conditional "?." operator!
Any way to suppress this outdated StyleCop behavior?

+1, seeing same issue.


Redirect response '301 Moved Permanently'

When I run the below code:
import httpx
from stream_read_xbrl import stream_read_xbrl_zip
#A URL taken from http://download.companieshouse.gov.uk/en_accountsdata.html
if name == 'main':
url = 'http://download.companieshouse.gov.uk/Accounts_Bulk_Data-2023-03-02.zip'
with
httpx.stream('GET', url) as r,
stream_read_xbrl_zip(r.iter_bytes(chunk_size=65536)) as (columns, rows):
r.raise_for_status()
for row in rows:
print(row)
I am getting the below error
HTTPStatusError: Redirect response '301 Moved Permanently' for url 'http://download.companieshouse.gov.uk/Accounts_Bulk_Data-2023-03-02.zip'
Redirect location: 'https://download.companieshouse.gov.uk/Accounts_Bulk_Data-2023-03-02.zip'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/301

Hi @hinas-source,
It looks like you're fetching from HTTP, but the server is redirecting to HTTPS, and httpx does not follow redirects by default. So you have 2 choices.
You could fetch from HTTPS in the first place, as in this:
import httpx
from stream_read_xbrl import stream_read_xbrl_zip

if __name__ == '__main__':
    url = 'https://download.companieshouse.gov.uk/Accounts_Bulk_Data-2024-03-26.zip'
    with httpx.stream('GET', url) as r:
        r.raise_for_status()
        with stream_read_xbrl_zip(r.iter_bytes(chunk_size=65536)) as (columns, rows):
            for row in rows:
                print(row)

Or, you can configure httpx to follow the redirect, as in this:
import httpx
from stream_read_xbrl import stream_read_xbrl_zip

if __name__ == '__main__':
    url = 'http://download.companieshouse.gov.uk/Accounts_Bulk_Data-2024-03-26.zip'
    with httpx.stream('GET', url, follow_redirects=True) as r:
        r.raise_for_status()
        with stream_read_xbrl_zip(r.iter_bytes(chunk_size=65536)) as (columns, rows):
            for row in rows:
                print(row)

(Neither of these use the exact same URL as in your question, as I think it no longer exists - it returns a 404)

Thank you for you help @michalc

No problem!

`---------------------------------------------------------------------------
UnexpectedSignatureError                  Traceback (most recent call last)
Cell In[5], line 9
5 url = f"https://download.companieshouse.gov.uk/Accounts_Bulk_Data-2024-01-20.zip"
6 with
7         httpx.stream('GET', url) as r,
8         stream_read_xbrl_zip(r.iter_bytes(chunk_size=65536)) as (columns, rows):
----> 9     df = pd.DataFrame(rows, columns=columns)
10     if isinstance(df, pd.DataFrame):
11         df1 = df
File c:\Users\AppData\Local\Programs\Python\Python312\Lib\site-packages\pandas\core\frame.py:832, in DataFrame.init(self, data, index, columns, dtype, copy)
830         data = np.asarray(data)
831     else:
--> 832         data = list(data)
833 if len(data) > 0:
834     if is_dataclass(data[0]):
File c:\Users\AppData\Local\Programs\Python\Python312\Lib\site-packages\stream_read_xbrl.py:556, in (.0)
553         yield queue.popleft().result()
555 with ProcessPoolExecutor(max_workers=num_workers) as executor:
--> 556     yield _COLUMNS, (
557         row + (zip_url,)
558         for results in imap(executor, _xbrl_to_rows, ((name.decode(), b''.join(chunks)) for name, _, chunks in stream_unzip(zip_bytes_iter)))
559         for row in results
560     )
File c:\Users\AppData\Local\Programs\Python\Python312\Lib\site-packages\stream_read_xbrl.py:546, in stream_read_xbrl_zip..imap(executor, func, param_iterables)
545 def imap(executor, func, param_iterables):
--> 546     for params in param_iterables:
547         if len(queue) == num_workers:
548             yield queue.popleft().result()
File c:\Users\AppData\Local\Programs\Python\Python312\Lib\site-packages\stream_read_xbrl.py:558, in (.0)
553         yield queue.popleft().result()
555 with ProcessPoolExecutor(max_workers=num_workers) as executor:
556     yield _COLUMNS, (
557         row + (zip_url,)
--> 558         for results in imap(executor, _xbrl_to_rows, ((name.decode(), b''.join(chunks)) for name, _, chunks in stream_unzip(zip_bytes_iter)))
559         for row in results
560     )
File c:\Users\AppData\Local\Programs\Python\Python312\Lib\site-packages\stream_unzip.py:460, in stream_unzip(zipfile_chunks, password, chunk_size, allow_zip64)
457         else:
458             raise UnexpectedSignatureError(signature)
--> 460 for file_name, file_size, unzipped_chunks in all():
461     yield file_name, file_size, unzipped_chunks
462     for _ in unzipped_chunks:
File c:\Users\AppData\Local\Programs\Python\Python312\Lib\site-packages\stream_unzip.py:458, in stream_unzip..all()
456     break
457 else:
--> 458     raise UnexpectedSignatureError(signature)
UnexpectedSignatureError: b'<htm'`
I am getting this error

@hinas-source  This seems like a different issue - can you raise a new issue at https://github.com/uktrade/stream-read-xbrl/issues?


Navigate with dynamic route

Hello,
I am having a problem to navigate to another url for dynamic route configured.
Currently i have
<router-link v-if="mode===undefined" class="btn btn-primary btn-flat btn-social" tag='a' :to="{ path: url.add}"> {{ $t('add') }} </router-link>
where my url.add is dynamic  for eg for below route is :'university/add'
My route is configured as
{
      path: '/:lang',
      component: {
        template: '<router-view></router-view>'
      },
      beforeEnter: Trans.routeMiddleware,

      children: [
      {
        path: "university",
        component: {
          render(c) {
            return c("router-view");
          }
        },
        meta: { label: "University" },
        children: [
          {
            path: "",
            component: TheContainer,
            children: [
              {
                path: "", name: ":mode", component: load('setup/University'), meta: { requiresAuth: true }
              },

              {
                path: ":mode", component: load('setup/University'), props: true, meta: { requiresAuth: true }
              },
              {
                path: ":mode/:id", name: "", component: load('setup/University'), props: true, meta: { requiresAuth: true }
              }
            ]
          }
        ]
      }...
	  ]
}

I have tried($i18nRoute({ path: url.add})) this but it is not working:
 <router-link v-if="mode===undefined" class="btn btn-primary btn-flat btn-social" tag='a' :to="$i18nRoute({ path: url.add})"> {{ $t('add') }} </router-link>

I'll try to look into it if possible

I have the same problem in vue3 :
path: "/:lang",     component: {       render(c) {         return c("router-view");       },     },
with warnings :

Unfortunately that guide is not adapted for Vue 3. I was planning to write a new one for quite some time but for now I just don't have much time. Hopefully it'll be addressed soon. In any case, thank you for your feedback!

OK maybe do you have any idea ?

I would love to help but I haven't checked Vue 3 yet :)


Autocomplete should be inside the Screen

📒 Description
For some situation, the number of items in AutoComplete is huge, then the view is out of screen. This PR will calculate the suitable size and make sure that the content is always visible. Therefore, the Create button is always visible too.
🕶 Types of changes
Bug fix (non-breaking change which fixes an issue)
🤯 List of changes

[x] Calculate suitable size for autocomplete

👫 Relationships
Close #3176
🔎 Review hints

Setup long entry in AutoCompleteView -> Select the TE at the end of list (Easy testing) -> Search AutoComplete in Project, Desciption, Tag,  Workspace and Client -> if the list is always inside the Main Screen -> 💯

When you type in text and there are no matches the size of the list is too big (like it would show a few items.

Sorry for this naive bug 🤯. It has been fixed now 👍

Now this works great! 2 thumbs up 👍 👍

@NghiaTranUIT For me Create a new project button is hidden behind the taskbar. Can you please check if that's not a real issue?

I see your problem, it means that I should get the Visible Frame (exclude the Dock bar size) rather than get the full size of the window. Thank for the screenshot, I will create a ticket for it 👍


Mail.Ru easyjson library security concerns

Hello,
I would like to bring to your attention a concern regarding one of the dependencies used in the swaggo/swag library, specifically the easyjson library.
The easyjson library is developed by Mail.ru, a company controlled by the Russian government. Due to security policies and compliance checks within our company, we are not allowed to use any libraries or software developed by entities associated with the Russian government.
Request
To ensure the security and compliance of our projects, we kindly request that you consider replacing the easyjson library with an alternative solution. One viable option could be to use the standard encoding/json package provided by Go, which is well-supported and maintained.
We understand that this may require some changes to the codebase, and we appreciate your efforts in maintaining the security and integrity of the swaggo/swag library.
Potential Impact
Updating the dependency to a more secure and compliant library will help in:

Enhancing the security of projects using swaggo/swag.
Ensuring compliance with various organizational and governmental policies.
Maintaining trust and reliability in the swaggo/swag library within the global developer community.

Thank you for your attention to this matter. We appreciate your consideration and look forward to your response.

As far as I can see easyjson is using only in example directory and does not required for proper package operation.

This project is an Open Source and is maintained by a community, not a government.
The library is an indirect requirement and it comes from go-openapi and there is no way to remove it. If your company policy is so strict, you can write OAS specs by hand.
Thanks for raising the concern.


Use phi to resolve caches after an if/else block

int a = 4;
if (rand() % 2 == 0) {
	a = 3;
} else {
	a = 6;
}

After an if/else statement variable caches could be in two possible states (i.e. above), hence a phi should be used to resolve the possible states rather than having to reload the value.

The produced LLVM would be something along the lines of:
0:
	// presume %1 hold the result of rand() % 2 == 0
	br i1 %1, label %2, label %X
2:
	br label %X
3:
	br label %X
4:
	%5 = phi i32 [ 3, %2 ], [ 6, %3 ]

Note the final line is simply to show the value resolving, even though the value is not later used in the code example.

Implemented in #47


Cluster Explorer fails with HTTP Error 500 when cluster agent is down

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a custom cluster on Rancher v2.5.2.
Attach a one node RKE cluster with all roles by using the docker run... command.
Pause the cattle cluster agent on the node by running a command similar to docker pause k8s_cluster-register_cattle-cluster-agent-7c9b787668-r5mz9_cattle-system_c012e40d-b5fe-4b1b-857f-a36d1f678b11_1
For the newly created cluster, click the Cluster Explorer button.

Result:
Get 500 error:

Other details that may be helpful:
Would expect Rancher to failover to using the cattle node agent if the cattle cluster agent is not functional.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.5.2
Installation option (single install/HA):
HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Custom 1.18.8
Machine type (cloud/VM/metal) and specifications (CPU/memory):
cloud aws t3.medium (2 CPU, 4GB RAM)
Kubernetes version (use kubectl version):

 kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:04:18Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

Docker version (use docker version):

docker version
Client: Docker Engine - Community
 Version:           19.03.13
 API version:       1.40
 Go version:        go1.13.15
 Git commit:        4484c46d9d
 Built:             Wed Sep 16 17:02:52 2020
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.13
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       4484c46d9d
  Built:            Wed Sep 16 17:01:20 2020
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.3.7
  GitCommit:        8fba4e9a7d01810a393d5d25a3621dc101981175
 runc:
  Version:          1.0.0-rc10
  GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

gz#14596

I think I am facing the same issue. There is no k8s_cluster-register* nor cluster-agent-* running on my my control nodes and I also am seeing this error. If I am reading the documentation correctly they should be running. Can one start them manually somehow?
This is on rancher 2.5.3.

My problem was(/is) that calico did not set up a route on some nodes to the service network <IP_ADDRESS>/16. This specific issue was fixed by manually adding the route on nodes with no route to <IP_ADDRESS>/16.
The above problem caused a myriad of problems, but the biggest one was no upstream dns in the k8s cluster.

Reproduced on v2.5.5
Expected:
Given an HA Rancher management instance and an HA downstream cluster control plane, the access to the cluster provided by the Cluster Explorer UI is resilient to the failure of a single downstream master node.
Actual:

Shutting down the master node that hosts the cluster agent will result in the Cluster Explorer to fail with a 500 error.
Cluster Explorer resumes working after approx. 5 minutes once Kubernetes has rescheduled the cluster agent pod to another node.
Access to the cluster via the Cluster Manager UI is not affected by the node failure

Reproduced on v2.5.5
Expected:
Given an HA Rancher management instance and an HA downstream cluster control plane, the access to the cluster provided by the Cluster Explorer UI is resilient to the failure of a single downstream master node.
Actual:

Shutting down the master node that hosts the cluster agent will result in the Cluster Explorer to fail with a 500 error.
Cluster Explorer resumes working after approx. 5 minutes once Kubernetes has rescheduled the cluster agent pod to another node.
Access to the cluster via the Cluster Manager UI is not affected by the node failure

The following temporary workaround will make the Cluster Explorer UI tolerate the failure of a single downstream master node (as in: highly available) instead of becoming unavailable for approx. 5-6 minutes. The workaround is of temporary nature because the changes will be overwritten during the next automated agent update.
kubectl -n cattle-system patch deploy cattle-cluster-agent -p "$(cat ./cluster-agent-ha.yaml)"

cluster-agent-ha.yaml:
spec:
  replicas: 2
  template:
    spec:
      affinity:
        podAntiAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
          - labelSelector:
              matchExpressions:
              - key: app
                operator: In
                values:
                - cattle-cluster-agent2
            topologyKey: "kubernetes.io/hostname"

Facing the same issue, i fixed it by edit the cluster config, then save it (change or not change). i guess it maybe cause by cluster agent had been broken, so re-save it make rancher to recreate it.

Seeing the same one a single master node cluster using Rancher v2.5.7 as well...

got the same problem in a downstream cluster (3 nodes (2 vCPUs 2GB RAM), each got all 3 roles assigned) after some time deploying these workloads:

MetalLB
Nginx-Ingress-Controller
Rancher2 Monitoring
Longhorn

This error shows Up when trying to go on the cluster exporter of the downstream cluster:
HTTP Error 500: Internal Server Error
from /k8s/clusters/c-tjlp6/v1/schemas

I'm having the same problem. 3 masters/workers, 4 workers-only in my cluster. I haven't deployed any workloads yet. This is after a fresh install.
HTTP Error 500: Internal Server Error
from /k8s/clusters/c-vhgwn/v1/schemas

My issue was I changed my port for access when upgrading.
Steps to resolve my issue:

Change to my system project in My Cluster
Open Resources > Secrets
Replace old URL Address with the new one(Mine was only the port)
Open Workloads
Open Cattle-Cluster-Agent Workload > Edit CATTLE_SERVER with the correct URL
Save and redeploy
7 Open Cattle-Node-Agent Workload > Edit CATTLE_SERVER with correct URL
Save and redeploy

I can now open my Cluster Explorer for my cluster.

We are seeing the same problem with the Cluster Explorer for the downstream clusters (downstream cluster is AKS) in Rancher 2.5.7. CATTLE_SERVER is pointing the to the correct URL.
HTTP Error 500:
from /k8s/clusters/c-cwdxs/v1/schemas

Hi!
We just upgrade to Rancher-2.5.9 by using RKE-1.2
And we have 3 clusters:

the rancher server: both cluster explorer and cluster manager is working good
downstream cluster 01 (not migrated v1.18.20-rancher1-1, yet): both cluster explorer and cluster manager is working good
downstream cluster 02 (migrated v1.20.10-rancher1-1): cluster explorer not working

Please, what do we need to do to fix the HTTP Error 500: from /k8s/clusters/c-5kfnw/v1/schemas?

Hi @adrianovieira! For a workaround, try restarting (deleting the Pod) for the cattle-cluster-agent, from the Cluster Manager interface. This restores Cluster Explorer dashboard for me in Rancher 2.5.9 created clusters, until it happens again.


add none or noop filter

Add none filter
filter('none', function() {
    return function(input) {
        return input;
    };
});

It useful for plugins which use filter name in options
somePlugin({
    listFilter: 'none' //default 'somePluginASCsort'
})

Of course, you can add the filter to somePlugin, but then it will have to be named somePluginNone, that it is not conflict with other filters

So in the "plugin" you can define which filter it should use? Shouldn't the plugin then be clever enough to not use a filter when you pass false or something?
I personally don't see the big utility of / demand for a none filter. It's a very simple filter that can be added on a per-project basis.

Agree with @Narretz we are going to pass on this. Closing.


Code break caused by numpy 2.0

Code break caused by numpy 2.0 in most of the notebooks in Textbook that use numpy, suggest to specify version
[/usr/local/lib/python3.10/dist-packages/numpy/__init__.py](https://localhost:8080/#) in __getattr__(attr)
    395
    396         if attr in __expired_attributes__:
--> 397             raise AttributeError(
    398                 f"`np.{attr}` was removed in the NumPy 2.0 release. "
    399                 f"{__expired_attributes__[attr]}"

AttributeError: `np.unicode_` was removed in the NumPy 2.0 release. Use `np.str_` instead.

Thanks very much for your feedback @mclim09 . Our lead developer is currently on leave, but we'll look into this when he's back.

Appreciate your help @jtrauer. Thank you very much!

@mclim09 I've been able to reproduce this based on the information provided, but we have updated the repository to include a requirements file so you can build an environment that won't have these issues.  Thanks for reporting!


Responses should support a description

Problem statement
The Responses: of a swagger:route should have support to add a description (which is required by the Swagger specification).
Having a comment on the response type adds a description in the definitions but not on the responses.
Swagger specification
See http://swagger.io/specification/#responseObject
Steps to reproduce

Declare a swagger:route with Responses:
No description can be set (just a named response)
The description property is missing on the responses object in the generated JSON

I was looking at adding this (which would fit right here: https://github.com/go-swagger/go-swagger/blob/master/scan/validators.go#L603) but I changed something that made my responses outputs looks like:
          "200": {
            "$ref": "#/responses/pet"
          },
          "500": {
            "$ref": "#/responses/pet"
          }

and I believe they were previously outputting the schema as a reference - which I mocked up below:
          "200": {
            "schema": {
              "$ref": "#/responses/pet"
            }
          },

Whatever the change was, description is no longer required by the parser at http://editor.swagger.io/#/ .  In fact, when including a description, I get a warning that the field is ignored.

I also wanted to point out that the reference is url encoded, so spaces turn into %20.  I was thinking about parsing value portion of the line based on the first space, so any text after the first space would become the description.  I am not sure what I changed in my comment or build command that stopped outputting schema, but I don't think I understand the problem well enough to code a solution.

I see what the change was - I had a definition instead of a response and just missed that that changed.
I took a stab at a fix in the PR linked above.

I think this is fixed on master now, please close when confirmed

Hi, thx. for the replies and your work!
I still can't get it working though. Do you have an example how and where the description should go?

in your operation
// responses:
//   200: body:someModel and the rest is description

Before closed, the documentation at https://github.com/go-swagger/go-swagger/blob/master/docs/generate/spec/route.md#example should probably be updated to reflect this new feature

Thx, I got it working so the description is added to the responses of the operation when using body:myNamedResponse.
I wonder though, why I still need to add a wrapper struct for the response and cannot just use a swagger:model annotated struct. It's nothing serious but I could save a struct per response and the responses in the generated Swagger JSON would get smaller.
Example:
type authenticateResponse struct {
	// ID of the authenticated user
	// Required: true
	ID bson.ObjectId `json:"id"`
	// Authentication token
	// Required: true
	Token string `json:"token"`
}

// swagger:response authenticateResponse
type authenticateResponseWrapper struct {
	// in: body
	Body authenticateResponse
}

// swagger:route POST /login authentication login
//
// Login user
//
// Logs a user in by creating an authentication token `token` ...
//
//     Consumes:
//     - application/x-www-form-urlencoded
//
//     Responses:
//       200: body:authenticateResponse On login success
//       401: body:errorMessage Invalid credentials
func authenticateHandler(w http.ResponseWriter, r *http.Request) {
  // ...
}

So the question is: is the body: prefix needed to split for a description or could you generally do that and thus allow responses with a ref to a response and a description in an operation.

You can use a model directly by defining your example as follows:
// swagger:model authenticateResponse
type authenticateResponse struct {
	// ID of the authenticated user
	// Required: true
	ID bson.ObjectId `json:"id"`
	// Authentication token
	// Required: true
	Token string `json:"token"`
}

You might need to generate the spec using the include models flag: --scan-models. This way you can prevent having to use a wrapper struct.
Let me know if this works and if you have any further questions on this topic.

Thanks @GlenDC, I missed the --scan-models option when generating the spec. Now it works as I'd expect.


MINOR: Make AbstractConfig logger protected

Inherited configs (Producer, Consumer, Streams, Kafka, Log) could use the logger of the AbstractConfig as well.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

cc @tuvtran @rayokota

Why would you want to use the same logger?

I think this is not necessary, will close this one.


Huge PR

Semicolons are bad!

Semicolons are bad!

Fake news.

I prefer we go all in and use punkify for maximum semicolon goodness.


Update Foundation.md

LFenergy foundation added

 You should sign our Contributor License Agreement in order to get your pull request merged.

All is well.

All is well.

All is well.

I tried to address your suggestions. However I think that foundation is still relevant. What is in the name: Linux Foundation. More work needs to be done to rename the documentation and Website.

All is well.

All is well.

All is well.

All is well.

Thanks for your input @rlemmers


Added "sourceURL" rule that troubleshoot broken link after processing

Please, merge my pull request.
Added "sourceURL" rule that troubleshoot broken link after processing to original stylesheet url in DevTools Style Inspector that greatly simplifies styles debugging. It's working in the browsers which supports "sourceURL" declaration (in particular Google Chrome and modern webkit-based Opera Browser).
See screenshot:

merged in https://github.com/LeaVerou/prefixfree/commit/053f00a8bbc02cce473fd920df9a415fa417a609


Baffled by "ControlData"

Not really an issue with pyemu, but can  I change NOPTMAX for pst class using pyemu?

it is baffling!  the ControlData class overloads the setters and getters to try to protect from invalid values (like setting noptmax = "junk".  This was supposed to un-baffle and provide access to all of the * control data section entries by name, so noptmax can be accessed like this: pst.control_data.noptmax = -1

Well, that's simple enough! Thanks
On Thu, Apr 11, 2019 at 1:43 PM jwhite-usgs<EMAIL_ADDRESS>wrote:

it is baffling! the ControlData class overloads the setters and getters
to try to protect from invalid values (like setting noptmax = "junk".
This was supposed to un-baffle and provide access to all of the * control
data section entries by name, so noptmax can be accessed like this: pst.control_data.noptmax
= -1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jtwhite79/pyemu/issues/76#issuecomment-482306268, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOSbxB79Zd0ge3rIVCkgTa8C8TQfjClDks5vf55cgaJpZM4cqyRE
.

--
Wes Kitlasten
United States Geological Survey
2730 N. Deer Run Road
Carson City, NV 89701
(775) 887-7711
orcid: 0000-0002-2049-9107


[Feature Request] Restart network service

Is it possible to call a service to restart the network? Thanks!

There's a button entity available to reboot each configured network, check the device page for the network or look for the entity named button.<SSID>_reboot


multiple instances

Are multiple editor instances possible?
Is it just a matter of calling pell.init a couple of times with different root IDs?

@sauer2 by the looks of the int function you are correct. Just call init multiple times.

@DylanPiercey Unfortunately that doesn't work, it breaks the toolbar. (There is only one toolbar on the top of the page.) Renaming those classes on the other hand causes an error that breaks the text widget itself.

Great issue, will definitely implement this.


Add quickstart guide

Description
What is the current behavior?

Quickstart guide is missing in README.md

closes: #68
What is the new behavior?

Add Quickstart guide
Fix typos

Does this introduce a breaking change?
No
Checklist

[x] Created tests which fail without the change (if possible)
[x] Extended the README / documentation, if necessary

Codecov Report
Patch and project coverage have no change.

Comparison is base (8e071b8) 60.92% compared to head (6eb64ae) 60.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   60.92%   60.92%
=======================================
  Files          40       40
  Lines        2380     2380
  Branches      228      228
=======================================
  Hits         1450     1450
  Misses        882      882
  Partials       48       48

Flag
Coverage Δ

UTO
60.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@jwitz  could you review this as well please?


Fix all Pipeline Module Parameters being sent to cuda:0

so, it seems that internally, PipelineModule calls self.to('cuda') (L189).
This appears to send the model parameters to GPU0, for every visible gpu running the deepspeed script, and makes scaling up difficult.
Instead, we can send the parameters to the current device with self.to(f'cuda:{self.global_rank}').
I'm actually unsure as to why the entire model's parameters are getting sent to one single GPU at this stage at all - aren't they meant to be partitioned equally across all GPUs?
Would appreciate anyone clearing this up for me.

Actually it should be sending to local_rank, have made the changes

Actually it should be sending to local_rank, have made the changes


depreciation update

Based upon depreciation messages, syntax was updated to reflect new commands.
tested and working on my system.

I have updated the PR to pass the build check.


spec: decide whether we want to allow struct initialization of  type param type

I have been wondering ever since if we really should support the example in this issue, which we current do, or disallow it:
https://github.com/golang/go/issues/48538
Consider this program, a modification of the example in the issue:
package p

type C interface {
        ~struct{ b1, b2 string }
}

func f[T C]() T {
        var x T = T{
                b1: "a",
                b2: "b",
        }

        x.b1 = "y" // <== this line gives an error, everything else is fine if it is removed.

       return x
}

Everything compiles fine if we remove the one marked line.  Basically, we are allowing a variable of typeparam T to be initialized with structural fields, because the type param is constrained to a single structural type, which is a struct type with b1 and b2 fields.  But we don't allow the marked line, which seems very similar.  Why are we allowed to initialize the b1 and b2 fields of x, but not directly assign to x.b1?
I think we should decide on this before 1.18 release, so we don't get stuck with backward compatibility of a possibly inconsistent design with our current state.
=====
Robert's list of possible alternatives:

do nothing
disallow struct literals where the type is a type parameter (even if it has a structural type)
allow x.b1 if there is a structural type
allow x.b1 if all types in the type parameter have a b1 field

2 is the conservative approach. Both 3 and 4 seem consistent with what we have. 1 seems a bit inconsistent.

cc: @ianlancetaylor @findleyr

For 1.18 I believe we should do either (2) or (3), whichever is easier.
In the long run I believe that we should do (4), except that we should permit x.b1 if a) all the types in the type set have a field named b1, and b) all the b1 fields have an identical type.

FWIW, I also verified that it is currently possible to read the variable from a structural constraint (example):
package main

import (
	"fmt"
)

type structuralConstraint interface {
	~struct{ b1, b2 string }
}

type myStruct struct {
	b1 string
	b2 string
}

func getT[T structuralConstraint]() T {
	return T{
		b1: "a",
		b2: "b",
	}
}

func main() {
	t := getT[myStruct]()
	fmt.Println(t.b1, t.b2)
}

The above example prints:
a b

@akutz That example shows using a composite literal with a structural constraint of struct type, which does indeed work today.  But it doesn't show reading a field.  The only code I see that reads the field is in main, where it is working with a fully instantiated type, not a type parameter with a structural constraint.

Yes, I was just about to comment as well.  I should have maybe mentioned in the original issue report above, but reading x.b1 in generic function f above also does not work.

This is working on the type-checker and compiler side.
Decision: To make it consistent we are going to support struct field references for type parameters with struct structural types as well (issue #50417).


Which Api is used

hi,
i got a google notification that i use some deprecated Api: [URGENT Action Required] Your Google Apps account is using the discontinued Documents List API
the only tool im aware of we using is skicka, so which ape did you use?
thanks in avanced,
mark

Hm, interesting. Skicka definitely does not use the Documents List API; it just uses the Drive API, so there shouldn't be any problems from the Documents List API going away.
It's possible that the application client id that you created from https://console.developers.google.com for skicka had usage of that API enabled (though skicka doesn't use it.)  FWIW in the next day or so an update to skicka will land that moves away from user-created client ids to a skicka-specific one, which would address this if that's the case.

ok, thanks for the info.
i will look in our console if the old api is enabled.
mark


Add Makefile

Add Makefile so that we dont need to remember commands and we can save time

We have a basic makefile


:memo: As last year, we replaced the URL with the store's URL.

Issue

None.

Overview (Required)

Since the app is already available in the store, we have replaced it with a link to the store as we did last year.

Links

https://github.com/DroidKaigi/conference-app-2022#android

Oops...it was already addressed, so I'll close it. 🙇


Added error handling for invalid certs

A self-signed cert caused iam_ssl.py to fail. This try/except loop brings in better error handling so that the watcher doesn't simply fail.

Hey @mikegrima - This PR just adds a try/except block in the iamssl watcher.  Maybe we could use the new exception persisting feature you wrote for this?
Could you take a look, and merge/modify?

This was merged in #413


Support equality checking on arbitrary types

Is your feature request related to a problem? Please describe.
At the moment, the == operator is not supported for values whose type is given by a type parameter (see screenshot from an IQ# session below). Since all types in Q# are value types, however, we should be able to support == between arbitrary types, including type parameters.
Additional context

Here is roughly the list of things that would need to be done:

Qubit equality comparison in compiler and runtime
Array equality comparison in compiler and QArray
Tuple equality comparison in compiler and QTuple
UDT equality comparison in compiler and [runtime (UDT class) or code gen]
Basic callable equality comparison in compiler and runtime
Partial application equality comparison in runtime
Let me know if you are up for picking some of that up.

Since there are good reasons to want to prevent equality on callable types, but a generic type parameter 'T could potentially be instantiated as a callable type, it looks like this is blocked by #557.

However, we could add equality comparisons for all of the other concrete types relatively easily (excludes callables and type parameters)... maybe that should be a new issue.

I'm going to transfer this issue to the qsharp-language repo, since that's now the proper place for language suggestions.


[docs] Fix Project Properties misprint

Signed-off-by: Yurii Serhiichuk<EMAIL_ADDRESS>
Fixes a tiny misprint in the docs.
Context

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thank you @xSAVIKx!


Performance demo on jsbin no longer works

I'm getting the same error with the latest version. If I revert to https://github.com/brianmhunt/knockout-fast-foreach/commit/ce7a29ee9896f6a2a148a9fe9f5dbe955c8d9766 it's okay.
knockout-min.js:63 Uncaught TypeError: Unable to process binding "fastForEach: function (){return {data:list,afterQueueFlush:afterQueueFlush} }"
Message: undefined is not a function

http://jsbin.com/heteca/6
Cheers.

Thanks @4ver – the problem is #13, namely that I have not yet copied over some private KO functionality for virtualElements to this project. It'll still work with knockout-debug until I get a chance to fix it.
I've updated the links to a version of the JSBin that uses the -debug version, so will close this. But please let me know / reopen if I've missed the issue here. :)
Cheers

Thanks, everything works perfectly now.


Collection-level append, extend, shuffle, reverse

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Finish implementing CRUD ASAP

[x] Create Operation
[x] Read Operation
[x] Update Operation
[x] Delete Operation

Refer: JSM

Basic CRUD has been implemented and tested.


[Wave Collect] [Xero] Organization page -  UX inconsistencies

Coming from - https://github.com/Expensify/App/pull/40984#pullrequestreview-2033355487
Bug 1: when opening the org page for the first time, no org is shown as selected.

Expected:

Bug 2: selecting an org should close the RHP.
https://github.com/Expensify/App/assets/29673073/d09f5215-a099-4259-8ef5-2e714bbd1dd5

Hit production 2 weeks ago. Payment for Rushat will be central, we can close.


To str convertion of the datetime fields

Hi,
if a standard pipeline use implies using a get_dict method from NewsArticle class to convert a class instance to dict and then save it to json file, then the fields
'date_download': self.date_download,
'date_modify': self.date_modify,
'date_publish': self.date_publish
need to be casted to string in the get_dict method. Otherwise there is a problem that datetime fields are not json serializable.

Serializing to JSON works well for instance in the common_crawl script. Can you please provide a minimal example where this does not work?

It happens running simple downloadfromurl.py
TypeError: Object of type 'NewsArticle' is not JSON serializable
The problem vanishes when:

I change get_dict() method in NewsArticle with datetime conversion to string
'date_download': str(self.date_download),
'date_modify': str(self.date_modify),
'date_publish': str(self.date_publish),
save not an object, but it's dictionary
json.dump(article.get_dict(), outfile, indent=4, sort_keys=True)

If I save like you have in the commoncrawl example
json.dump(article.dict, outfile, indent=4, sort_keys=True)
I get this error:
TypeError: Object of type 'datetime' is not JSON serializable
I run everything on 3.6.

if you add default=str to the json.dump method (see commoncrawl.py:102), this will solve the issue. but from a user perspective, it's better to have a get serializable dict method. will add that. thanks for pointing this out.

@fhamborg Have you updated it in Git? I am still facing the same issue.

I can't figure out where I am going wrong
import json
from newsplease import NewsPlease
url = 'testurl'
basepath = '/Volumes/Data/StartUp Data/NewsExtractor/Custom/ExtractedData'
article = NewsPlease.from_url(url)
with open(basepath + article['filename'] + '.json', 'w') as outfile:
json.dump(article, outfile, indent=4, sort_keys=True)
Error:
Traceback (most recent call last):
File "second.py", line 16, in
with open(basepath + article['filename'] + '.json', 'w') as outfile:
TypeError: 'NewsArticle' object is not subscriptable

this seems to be a different issue. note that your original issue contained "TypeError: Object of type 'datetime' is not JSON serializable", which was fixed using https://github.com/fhamborg/news-please/commit/93deacbab98bbabae28f13a30fc06e66ff2e4d3a. now you get "TypeError: 'NewsArticle' object is not subscriptable". please open a new issue for your new issue.


Allow Redis 5.x

Aside from https://github.com/redis/redis-rb/pull/1133 (which I'll merge in a sec), the test suite pass with redis = 5.0.0.beta4.

Redis 5.0 is out now. Would love to see this get merged & released.

I took the liberty to merge since I can't possibly see a problem with this.
However I have no idea whether @dhh or @jeremy have plans for a release (I wouldn't want to release an unfinished feature or anything like that).


Add additional tests for interpreterFlags

Addresses https://github.com/swiftlang/swift-package-manager/pull/8138#discussion_r1855175099

@swift-ci Please test


Console app crashes

This makes the console app crashes when calling the executable of the application via script or task scheduler.
https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blobs-list?tabs=dotnet

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49364b8c-01b5-5180-7537-c221c79d5b3d
Version Independent ID: 95ec5f30-8c53-b349-3b3c-71109ae84741
Content: List blobs with Azure Storage APIs
Content Source: articles/storage/blobs/storage-blobs-list.md
Service: storage
Sub-service: blobs
GitHub Login: @tamram
Microsoft Alias: tamram

@krisrajzlive Thank you for your feedback . We will investigate and update the thread.

@krisrajzlive  Firstly, apologies for the delay in responding here and any inconvenience this issue may have caused. I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. Please share the screenshot of the error message and detailed information of the issue  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


hide class missing in alerts?

<div class="alert hide alert-success" is not working in V4 alpha.2.

Migration docs - Responsive utilities

Got it. Thanks.

@fchiumeo Nice work :smile:


Allow state modification while evaluating watch expressions

So in Vue I will get a recursion error when I modify state in a watcher, but not in a computed or watchEffect.
I found the following traces in Vue's source:
In the scheduler's queue function:
  if (watcher === Dep.target && watcher.noRecurse) {
    return
  }

And in the Watcher creation:
  watcher.noRecurse = !cb

It also stands out to me that watcher.lazy seems to be true in these cases/


grab workflow from image

is there a way to grab/load the ComfyScript from an existing image?

Yes. Actually I have a widget for this. Unfortunately, there is a bug in the old versions of VS Code Notebook and one cannot drag files into it. It's fixed in the preview version and I'm using it. A stable version should be released now. I'll upload the code later. Though it still can't show syntax highlights properly in VS Code.

cool thanks!

It's now uploaded. ComfyScript / ComfyUI / Stable Diffusion web UI images and workflow JSON are supported.
Docs: https://github.com/Chaoses-Ib/ComfyScript/blob/main/docs/UI/Solara.md

love it! thanks

mm... tried using it, got this:
Set state = <ResultState.RUNNING: 4> for key '2' (previous value was <ResultState.STARTING: 2>)<PHONE_NUMBER>640)
No render phase triggered, already rendering
'utf-8' codec can't decode byte 0x89 in position 0: invalid start byte
Traceback (most recent call last):
  File "e:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\solara\hooks\use_thread.py", line 84, in runner
    value = f()
            ^^^
  File "e:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\solara\components\file_drop.py", line 75, in handle_file
    on_file(wired_files[0])
  File "E:\custom_nodes\ComfyScript\src\comfy_script\ui\solara\metadata.py", line 20, in on_file
    image = Image.open(bin)
            ^^^^^^^^^^^^^^^
  File "e:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\PIL\Image.py", line 3274, in open
    filename = os.path.realpath(os.fspath(fp))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen ntpath>", line 675, in realpath
  File "<frozen ntpath>", line 542, in normpath
  File "<frozen os>", line 826, in fsdecode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x89 in position 0: invalid start byte
Set state = <ResultState.ERROR: 5> for key '2' (previous value was <ResultState.RUNNING: 4>)<PHONE_NUMBER>816)
Render phase: 2 'main' of _AppLayoutEmbed(children = ...)

Dragging that same image to the UI works fine.

Fixed. Forgot to test images after adding support for JSON.

awesome! just tried it, and it works wonderfully. 🙌


Default to String for custom types that do not have a mapping

Would be nice if DateTime for an example could by default be readable as a string for users that did not register any custom adapters.

@martinbonnin It's not so simple.
If we missing adapter but we have mapping configuration in apollo plugin:
customTypeMapping {
        DateTime = "java.util.Date"
    }

compiler generates models with the java.util.Date rather then String. But when we reading response field value of DateTime we are reading it as a String and then we will fail as we can't just assign String to java.util.Date and we don't have the way to convert it.
So the only solution is next: if we missing mapping in apollo plugin (build.gradle), string will be used by default as type in generated models for custom scalar types

If there's no adapter, I don't expect anyone to put customTypeMapping in build.gradle. So this would really be a 'zero configuration' thing to make it easier to start using the project.
Agree with using a default return type if no mapping is defined. Maybe use 'Object' instead of 'String' so we could return directly what's in the json ?


/app/www/artisan bookstack:update-url PDOException

Describe the Bug
Try to replace the domain in the database in a newly setup docker environment with:
docker exec -it bookstack-local php /app/www/artisan bookstack:update-url http://xxx.xxx http://localhost:xxxx
get the following error:
   PDOException

  SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed: Try again

  at /app/www/vendor/laravel/framework/src/Illuminate/Database/Connectors/Connector.php:70
     66▕         if (class_exists(PDOConnection::class) && ! $this->isPersistentConnection($options)) {
     67▕             return new PDOConnection($dsn, $username, $password, $options);
     68▕         }
     69▕
  ➜  70▕         return new PDO($dsn, $username, $password, $options);
     71▕     }
     72▕
     73▕     /**
     74▕      * Determine if the connection is persistent.

      +7 vendor frames
  8   /app/www/app/Console/Commands/UpdateUrl.php:102
      Illuminate\Database\Connection::getPdo()

  9   /app/www/app/Console/Commands/UpdateUrl.php:70
      BookStack\Console\Commands\UpdateUrl::replaceValueInTable()

Steps to Reproduce

Setup service over docker
Change URL in database with docker exec -it bookstack-local php /app/www/artisan bookstack:update-url http://xxx.xxx http://localhost:xxxx
Get error

Expected Behaviour
Replace URL in database
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
BookStack v22.07.3
PHP Version
No response
Hosting Environment
Docker

Hi @grugel-maintro,
Based on that error I'd say that your BookStack instance does not have visibility of the database host system.
I'd expect you'd also be getting errors on container start-up as database migrations are attempted.

Since there's been no follow-up I'm going to close this. If the issue remains and is something you still require to be fixed respond to my previous comment and this can then be re-opened.


In some situations orca doesn't read the search settings label when we enter VSCode settings

Issue Type: Bug
CC: @isidorn
CC: @joanmarie
Steps to reproduce:

Launch orca.
Launch VSCode.
Go to preferences:open settings(UI) pressing ctrl+, .

Actual results:
Orca stays mute.
Expected results:
Orca should read: "search settings editor".

type for example "status" in the search field.
Move to the clear button pressing tab, and press enter or space bar to activate the button.

Actual results:
Focus moves to search field but orca doesn't read anything.
Expected results:
The focus should move to the search field and the orca should read the label of that field.
VS Code version: Code - Insiders 1.64.0-insider (5554b12acf27056905806867f251c859323ff7e9, 2022-02-02T17:16:05.517Z)
OS version: Linux x64 5.16.4-arch1-1
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2344)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
15.54GB (1.06GB free)

Process Argv
-n --crash-reporter-id bcecf5e0-97d1-4830-b28c-0943c4adab1c --crash-reporter-id bcecf5e0-97d1-4830-b28c-0943c4adab1c

Screen Reader
yes

VM
0%

DESKTOP_SESSION
gnome-xorg

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome-xorg

XDG_SESSION_TYPE
x11

Extensions (37)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.2.2

EditorConfig
Edi
0.16.4

prettier-vscode
esb
9.2.0

shell-format
fox
7.2.2

rest-client
hum
0.24.6

vscode-docker
ms-
1.19.0

csharp
ms-
1.24.0

vscode-aks-tools
ms-
0.0.11

vscode-kubernetes-tools
ms-
1.3.6

python
ms-
2022.0.1762517795-dev

vscode-pylance
ms-
2022.1.6-pre.1

remote-containers
ms-
0.218.0

remote-ssh
ms-
0.70.0

remote-ssh-edit
ms-
0.70.0

azure-account
ms-
0.9.11

powershell
ms-
2021.12.0

vsliveshare
ms-
1.0.5330

vsliveshare-audio
ms-
0.1.91

oracledevtools
Ora
21.3.0

vscode-boot-dev-pack
Piv
0.1.0

vscode-concourse
Piv
1.30.0

vscode-manifest-yaml
Piv
1.30.0

vscode-spring-boot
Piv
1.30.0

fabric8-analytics
red
0.3.5

java
red
1.3.0

vscode-commons
red
0.0.6

vscode-xml
red
0.18.2

vscode-yaml
red
1.3.0

sonarlint-vscode
Son
3.2.0

vscodeintellicode
Vis
1.2.16

vscode-java-debug
vsc
0.38.0

vscode-java-dependency
vsc
0.19.0

vscode-java-pack
vsc
0.21.0

vscode-java-test
vsc
0.34.0

vscode-maven
vsc
0.35.0

vscode-spring-boot-dashboard
vsc
0.2.0

vscode-spring-initializr
vsc
0.8.0

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30422396
pythontb:30258533
pythonvspyt551cf:30291413
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstartedc:30421358
vscop453:30404998
vsclayoutctrc:30405799
pythonvsnew555:30426298
vscscmwlcmc:30428972

I can not reproduce this with VoiceOver or NVDA. The "Search Settings" always gets read. @rzhao271 can you just double check if you properly set the aria-label on the Preferences input
@joanmarie I believe this is an issue on the Orca side because things are working with VoiceOver and NVDA. Can you double check when you find the time?

Looks like another case of Orca getting events and silently updating focus. Will see what I can do.

I've just made in change in Orca master which solves the problem. As with other such changes, there's a risk of introducing unwanted chattiness for badly behaved web apps and browser implementations -- and possibly for well-behaved ones doing something I've not thought about grins. Thorough testing for such side effects is strongly encouraged.

Thanks @joanmarie
Let's see what @jvesouza says and if it is fixed we can close this.
If there are other issues that came up as part of this we can revert the change, I do not think it is critical to fix imho.

It's working correctly.
However I found another small problem that may or may not be associated with this one.
If I type something in the search field orca correctly announces the number of elements that satisfy the search. If I press the tab key and press enter to activate the clear button, the focus moves to the search field as expected and the orca announces that N items were found, where N is the same number of elements found when I typed something in the search before I press the tab key.

@jvesouza awesome!
The new issue you found sound like a VS Code bug.
@rzhao271 can you verify if the clear action updates the aria-label properly. It seems like the aria-label gets stale with old results.

@rzhao271 great, thanks for fixing it this fast 👏
@jvesouza can you just verify tomorrow and let us know if it is good for you know.
Closing this issue since Raymond pushed a fix.

I generated a version from the repository, or at least I hope I did, and if I did everything right the problem was fixed. What caught my attention is that the orca is reading more information when I hit the clear button. After the information that the button is a push button, the orca reads something like grade.
It was present in previous versions but I forgot to mention.

@jvesouza great that the problem is fixed -> verified.
As for the reading of "grade" we are not appending this from the VS Code side. Can you share exactly what unnecessary part is read?

@isidorn  @joanmarie
When I move the foco to the clear input button orca reads the following:
'Clear Settings Search Input push button grayed.'.
Unless I'm mistaken, the word 'grayde' read by the orca would indicate that the button is disabled, but this word is always read whether or not the button is disabled.

I checked and we properly set aria-disabled="true" on an action once it is disabled (grayed). Once the action is enabled we remove that property. Might that be confusing Orca? Should we instead set aria-disabled="false" then @joanmarie

@isidorn: Orca doesn't look at ARIA properties in that case; it looks at accessible states. From what is being described here, setting it to false rather removing the property would not have any impact. Instead, it sounds like there is a bug in which toggling aria-disabled doesn't result in an accessible state-changed event. As a result, AT-SPI2 tells Orca the widget is still disabled because nothing told AT-SPI2 that had changed so its cached value isn't updated.
If you have a moment (right now I don't), please file a bug against Chromium with concrete steps to reproduce the problem. If you're able to assign the bug (via the owner field) please do; otherwise please CC me. In either case, please use my igalia.com email address.
Thanks!

@isidorn  @joanmarie
I don't know if this information can help, but it looks like the orca is reading the menus correctly. When for example I have changed files, the 'save all' menu is not read by the orca as 'grayde'. However, if all files have no pending changes, the 'save all' menu is read as 'grayde'.

@jvesouza "Save All" gets greyed out when there are no pending changes. So this is expected behaviour.
As for the initial "Clear" action being read as greyed I can reproduce this with VS Code insiders.
I can not reproduce it with Chrome 98. So it seems like Chrome has fixed this issue in later versions.
@jvesouza can you try going to https://vscode.dev/github/microsoft/vscode that will load up the vscode workbench and try to reproduce there in Chrome browser. It works for me. So it seems we just need to pick a later Chrome version with the fix.

@isidorn Confirmed.

@jvesouza great, then I suggest no action and we will sooner or later pick this fix up. Especially since it is not a big blocker, I suggest we do not look into back porting it.


Control external monitors brightness

Description of the new feature / enhancement

Ideally, there would be some kind of slider appearing at the keyboard shortcut or dedicated buttons
need to control several monitors at once
it would be nice to have additional triggers for changing brightness, like day of time, sunset\sunrise in your location or integration of hardware light sensor or even webcam (there is one project for this http://sven.killig.de/BLUntrl/)

Scenario when this would be used?
I work all day long and need to reduce screen brightness in the evening to reduce eyestrain
Supporting information
Windows do not support such functionality for external monitors but a couple or 3d party apps do. To name a few - Monitorian (Get in Win Store) and ClickMonitorDDC. All they work through Display Data Channel interface (DDC)

Tracked in https://github.com/microsoft/PowerToys/issues/1052


npm run ionic:serve: Cannot find module 'buffer-shims'

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[X ] 2.x
[ ] 3.x
I'm submitting a ...  (check one with "x")
[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
npm run ionic:serve works just fine before I tried to get a build on ios. After I created a build. I tried to do npm run ionic:serve again. Then gives me this error:
module.js:471
    throw err;
    ^

Error: Cannot find module 'buffer-shims'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)

Expected behavior:
Should just serve fine.
Steps to reproduce:
Try to build ios first:
sudo ionic cordova platform remove ios
sudo ionic cordova resources --icon
sudo ionic cordova platform add ios
sudo ionic cordova build ios --release
Then after build do:
npm run ionic:serve
Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.5.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.5.0

local packages:

    @ionic/app-scripts              : 2.0.2
    @ionic/cli-plugin-cordova       : 1.4.1
    @ionic/cli-plugin-ionic-angular : 1.3.2
    Cordova Platforms               : android 5.2.2 ios 4.4.0
    Ionic Framework                 : ionic-angular 2.3.0

System:

    Node       : v6.9.2
    OS         : macOS Sierra
    Xcode      : Xcode 8.2.1 Build version 8C1002
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 5.3.0

rm -r node_modules; rm package-lock.json; npm install in your shell

This issue was moved to ionic-team/ionic-app-scripts#1131

Well, that worked. Thanks @wbhob!

Can you please close the app scripts issue @jgw96?