HBASE-25242 Add Increment/Append support to RowMutations

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
checkstyle
2m 41s
master passed

+1 :green_heart:
spotbugs
4m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
checkstyle
2m 41s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  6s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
5m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

50m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 91a483642a51 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 671129df56

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
compile
2m 18s
master passed

+1 :green_heart:
shadedjars
6m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 55s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
2m 20s
the patch passed

+1 :green_heart:
javac
2m 20s
the patch passed

+1 :green_heart:
shadedjars
6m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  6s
hbase-client in the patch passed.

+1 :green_heart:
unit
139m 55s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 13s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 22s
hbase-rest in the patch passed.

181m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 58fa26e1202d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 671129df56

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/testReport/

Max. process+thread count
3914 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 30s
master passed

+1 :green_heart:
compile
3m 12s
master passed

+1 :green_heart:
shadedjars
9m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 52s
the patch passed

+1 :green_heart:
compile
3m 22s
the patch passed

+1 :green_heart:
javac
3m 22s
the patch passed

+1 :green_heart:
shadedjars
9m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

+1 :green_heart:
unit
132m  4s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  6s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 17s
hbase-rest in the patch passed.

186m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cc2699fa241c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 671129df56

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/testReport/

Max. process+thread count
4342 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Can you please review this? @Apache9

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
checkstyle
2m 44s
master passed

+1 :green_heart:
spotbugs
4m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
checkstyle
2m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  9s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
5m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 50s
The patch does not generate ASF License warnings.

49m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 6a3d025ecfc0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 09aaa68be4

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s
master passed

+1 :green_heart:
compile
2m 36s
master passed

+1 :green_heart:
shadedjars
6m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
2m 38s
the patch passed

+1 :green_heart:
javac
2m 38s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 12s
hbase-client in the patch passed.

+1 :green_heart:
unit
130m 56s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  6s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 13s
hbase-rest in the patch passed.

174m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ab26bf9a3b6f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 09aaa68be4

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/testReport/

Max. process+thread count
4178 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  3s
master passed

+1 :green_heart:
compile
2m 19s
master passed

+1 :green_heart:
shadedjars
7m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
2m 19s
the patch passed

+1 :green_heart:
javac
2m 19s
the patch passed

+1 :green_heart:
shadedjars
7m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
203m  8s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 40s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  2s
hbase-rest in the patch passed.

247m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d78ec5723f01 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 09aaa68be4

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/testReport/

Max. process+thread count
3671 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Ping @Apache9 . Thanks.

I just changed the patch regarding the following:

Add testing for Append and keep the last else branch throwing DoNotRetryIOException
Use DoNotRetryIOException instead of AssertionError
Use ArrayList instead of LinkedList

Can you please take a look at this? @Apache9

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s
master passed

+1 :green_heart:
checkstyle
2m 42s
master passed

+1 :green_heart:
spotbugs
4m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

-1 :x:
mvninstall
1m 37s
root in the patch failed.

+1 :green_heart:
checkstyle
0m 32s
hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)

-0 :warning:
checkstyle
0m 29s
The patch fails to run checkstyle in hbase-server

+1 :green_heart:
checkstyle
0m 37s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 14s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
1m 49s
The patch causes 42 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
3m 38s
The patch causes 42 errors with Hadoop v3.2.1.

-1 :x:
hadoopcheck
5m 27s
The patch causes 42 errors with Hadoop v3.3.0.

-1 :x:
spotbugs
0m 25s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m 42s
The patch does not generate ASF License warnings.

28m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux cf002ae4a2ba 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-general-check/output/buildtool-patch-checkstyle-hbase-server.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-general-check/output/patch-javac-3.1.2.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-general-check/output/patch-javac-3.2.1.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-general-check/output/patch-javac-3.3.0.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
master passed

+1 :green_heart:
compile
2m 35s
master passed

+1 :green_heart:
shadedjars
6m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

-1 :x:
mvninstall
2m  2s
root in the patch failed.

-1 :x:
compile
0m 27s
hbase-server in the patch failed.

-0 :warning:
javac
0m 27s
hbase-server in the patch failed.

-1 :x:
shadedjars
4m 51s
patch has 14 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 19s
hbase-client in the patch passed.

-1 :x:
unit
0m 29s
hbase-server in the patch failed.

+1 :green_heart:
unit
3m 48s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m  6s
hbase-rest in the patch passed.

38m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 56aac97fd528 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Default Java
AdoptOpenJDK-11.0.6+10

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/testReport/

Max. process+thread count
2538 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
master passed

+1 :green_heart:
compile
2m 20s
master passed

+1 :green_heart:
shadedjars
7m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

-1 :x:
mvninstall
1m 52s
root in the patch failed.

-1 :x:
compile
0m 27s
hbase-server in the patch failed.

-0 :warning:
javac
0m 27s
hbase-server in the patch failed.

-1 :x:
shadedjars
5m  8s
patch has 42 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

-1 :x:
unit
0m 26s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 36s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 48s
hbase-rest in the patch passed.

38m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a8f55497933a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Default Java
AdoptOpenJDK-1.8.0_232-b09

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/testReport/

Max. process+thread count
1904 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I made a mistake and the compile in the last QA failed.. Just fixed it and pushed the latest patch.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s
master passed

+1 :green_heart:
checkstyle
3m  4s
master passed

+1 :green_heart:
spotbugs
5m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 15s
the patch passed

+1 :green_heart:
checkstyle
0m 35s
hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)

+1 :green_heart:
checkstyle
1m 25s
The patch passed checkstyle in hbase-server

+1 :green_heart:
checkstyle
0m 46s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
21m  1s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
7m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 50s
The patch does not generate ASF License warnings.

61m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 6852841e4b90 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 29s
master passed

+1 :green_heart:
compile
3m 34s
master passed

+1 :green_heart:
shadedjars
9m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 41s
the patch passed

+1 :green_heart:
compile
3m 17s
the patch passed

+1 :green_heart:
javac
3m 17s
the patch passed

+1 :green_heart:
shadedjars
9m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 23s
hbase-client in the patch passed.

+1 :green_heart:
unit
137m 48s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  5s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 18s
hbase-rest in the patch passed.

193m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5a892764f1f1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/testReport/

Max. process+thread count
3807 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
compile
2m 18s
master passed

+1 :green_heart:
shadedjars
7m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 48s
the patch passed

+1 :green_heart:
compile
2m 18s
the patch passed

+1 :green_heart:
javac
2m 18s
the patch passed

+1 :green_heart:
shadedjars
7m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  7s
hbase-client in the patch passed.

+1 :green_heart:
unit
203m 42s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 42s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  2s
hbase-rest in the patch passed.

248m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c9540b7d6ab0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/testReport/

Max. process+thread count
3482 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
master passed

+1 :green_heart:
checkstyle
2m 38s
master passed

+1 :green_heart:
spotbugs
4m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
checkstyle
0m 34s
hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)

+1 :green_heart:
checkstyle
1m 12s
The patch passed checkstyle in hbase-server

+1 :green_heart:
checkstyle
0m 39s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  2s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
5m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 50s
The patch does not generate ASF License warnings.

49m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux b30081543b7b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  0s
master passed

+1 :green_heart:
compile
2m 37s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
2m 37s
the patch passed

+1 :green_heart:
javac
2m 37s
the patch passed

+1 :green_heart:
shadedjars
6m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 10s
hbase-client in the patch passed.

+1 :green_heart:
unit
132m 24s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  3s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 16s
hbase-rest in the patch passed.

175m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1404b2479835 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/testReport/

Max. process+thread count
4249 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
compile
2m 19s
master passed

+1 :green_heart:
shadedjars
7m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
2m 18s
the patch passed

+1 :green_heart:
javac
2m 18s
the patch passed

+1 :green_heart:
shadedjars
7m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

+1 :green_heart:
unit
203m 27s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 43s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  1s
hbase-rest in the patch passed.

247m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a70c19d67ac2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c9156e7891

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/testReport/

Max. process+thread count
3496 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thank you @apurtell
Can you please review this? @Apache9

I just added the following comment:
https://github.com/apache/hbase/pull/2630/files#diff-e4052cd5a1f1c93375e3fbc931dc4df220deebc78c0d53fd2435b47fd04cd807R1005-R1008
Can you please take a look at this? @Apache9
Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
checkstyle
2m 42s
master passed

+1 :green_heart:
spotbugs
4m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
checkstyle
0m 34s
hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)

+1 :green_heart:
checkstyle
1m 13s
The patch passed checkstyle in hbase-server

+1 :green_heart:
checkstyle
0m 42s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 16s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  4s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
5m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 50s
The patch does not generate ASF License warnings.

50m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux ea1818d3ced7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d81b541493

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 36s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 30s
master passed

+1 :green_heart:
compile
2m 46s
master passed

+1 :green_heart:
shadedjars
6m 51s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 10s
the patch passed

+1 :green_heart:
compile
2m 45s
the patch passed

+1 :green_heart:
javac
2m 45s
the patch passed

+1 :green_heart:
shadedjars
7m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-client in the patch passed.

-1 :x:
unit
152m 18s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 12s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 23s
hbase-rest in the patch passed.

199m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b17ef623b750 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d81b541493

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/testReport/

Max. process+thread count
3918 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 34s
master passed

+1 :green_heart:
compile
2m 25s
master passed

+1 :green_heart:
shadedjars
6m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 40s
the patch passed

+1 :green_heart:
compile
2m 19s
the patch passed

+1 :green_heart:
javac
2m 19s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  5s
hbase-client in the patch passed.

-1 :x:
unit
161m 26s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 25s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 45s
hbase-rest in the patch passed.

204m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 73bcaa17acb1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d81b541493

Default Java
AdoptOpenJDK-1.8.0_232-b09

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/testReport/

Max. process+thread count
3863 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Are the failed UTs related? TestAsyncTable?

Seems the failed UTs for TestAsyncTable are not related to this patch.
But it looks like the root cause of the failed UTs are that we don't wait until AsyncTable.put() completes at the following lines:
https://github.com/apache/hbase/blob/d81b54149390565960a3721cbd5f1bfd6a6de61d/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTable.java#L998
https://github.com/apache/hbase/blob/d81b54149390565960a3721cbd5f1bfd6a6de61d/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTable.java#L1055
We need to call get() method to wait until AsyncTable.put() completes as follows:
table.put(...).get();

I will fix it and re-push it.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 22s
master passed

+1 :green_heart:
checkstyle
2m 41s
master passed

+1 :green_heart:
spotbugs
4m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
checkstyle
0m 34s
hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)

+1 :green_heart:
checkstyle
1m 11s
The patch passed checkstyle in hbase-server

+1 :green_heart:
checkstyle
0m 39s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
5m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

49m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux bfaf1b8558ca 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d81b541493

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/7/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 12s
master passed

+1 :green_heart:
compile
2m 39s
master passed

+1 :green_heart:
shadedjars
6m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
2m 39s
the patch passed

+1 :green_heart:
javac
2m 39s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 13s
hbase-client in the patch passed.

-1 :x:
unit
138m  2s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m  6s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 43s
hbase-rest in the patch passed.

182m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6a62fd8c1aa7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d81b541493

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/7/testReport/

Max. process+thread count
4174 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I don't think the failed UTs in the last QA are related to this patch, but I will trigger QA again just in case.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 12s
master passed

+1 :green_heart:
checkstyle
3m  3s
master passed

+1 :green_heart:
spotbugs
5m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 18s
the patch passed

+1 :green_heart:
checkstyle
0m 34s
hbase-client: The patch generated 0 new + 276 unchanged - 1 fixed = 276 total (was 277)

+1 :green_heart:
checkstyle
1m 23s
The patch passed checkstyle in hbase-server

+1 :green_heart:
checkstyle
0m 50s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 18s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
21m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
7m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 48s
The patch does not generate ASF License warnings.

65m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a3bc474bfd4e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Max. process+thread count
95 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 38s
master passed

+1 :green_heart:
compile
3m 31s
master passed

+1 :green_heart:
shadedjars
9m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 16s
the patch passed

+1 :green_heart:
compile
3m 15s
the patch passed

+1 :green_heart:
javac
3m 15s
the patch passed

+1 :green_heart:
shadedjars
9m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 27s
hbase-client in the patch passed.

-1 :x:
unit
137m 14s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m  4s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 13s
hbase-rest in the patch passed.

192m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4ac48571b6d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/testReport/

Max. process+thread count
4218 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 46s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 47s
master passed

+1 :green_heart:
compile
2m 32s
master passed

+1 :green_heart:
shadedjars
7m 51s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  7s
the patch passed

+1 :green_heart:
compile
2m 35s
the patch passed

+1 :green_heart:
javac
2m 35s
the patch passed

+1 :green_heart:
shadedjars
7m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 13s
hbase-client in the patch passed.

-1 :x:
unit
144m  4s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 28s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
4m  1s
hbase-rest in the patch passed.

194m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux da7413adfbf6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
AdoptOpenJDK-1.8.0_232-b09

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/testReport/

Max. process+thread count
4008 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-thrift hbase-rest U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2630/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I don't think the failed UTs are related to this change. The failed UTs were successful locally. I will merge this PR.


Shipt Shopper App

This is not a code issue I am reporting on. I am just a former React developer turned shipt shopper (mainly because I'm a bad dev), but there are some serious issues with State management in the shipt shopper app. It has issues that affect the productivity and efficiency of every single order, and no matter how hard I try I can't seem to contact the right people who care. So here I am. Resurrecting my github account to make a comment on this repo.
I love working for shipt, and the issues aren't even really that bad, but when I have to troubleshoot the same things every single order it starts to build and makes me wonder why certain things aren't being addressed. Anyway. I'm happy to chat with any engineer who is interested, shit maybe you're already working on the problems I'm dealing with, but I figured I'd reach out here anyway.

Thanks for reaching out and helping to improve the shopper app experience. I've sent you an e-mail to get some more details on what you're seeing.


update installation docs to install from url

this provides a bit more of a convenient UX to users to install the release manifests.

/assign @nan-yu


All the reporting parameters of Job information needs to be added in capabilities in driver creation .

This will allow the driver creation failures to be properly mapped to the Job results.

done


Add ability for BlockNodes to store data

The Issue
Currently, BlockNodes cannot store data besides just what makes them unique. This is because there needs to be some way to tell if a specific block-node is already present at a given location and to make sure there graphs don't end up with duplicate nodes.
However, this limitation limits BlockNodes usefulness to just indicating connections. It would be useful if BlockNodes could hold additional data about themselves much like BlockEntitys, but with the advantages that come with BlockNodes (multiple in one block-space, direct association with a node and graph).

One way to do this might be to have separate node-position data that must be unique for every BlockNode in a block.

This would run into problems with things that move or copy blocks and BlockEntitys, like Create contraptions. However this could probably be addressed by having the BlockEntity store a copy of its position as cached and then, if the BlockEntity is loaded from NBT at a different position than its cached position, then it knows that it has been either copied or moved. If another BlockEntity like it exists at the old position, then it was copied, otherwise, it was moved. Then it can either copy or move its node data accordingly.
However, if someone wants to store information without relying on BlockEntitys at all, then it will be much harder to support block-moving.

I don't really see any way to properly handle block-moves if the block doesn't have a BlockEntity, short of just mixing into Create, WorldEdit, etc.


[documents] Check for input PDF with PyMuPDF when it's source content

So far, we have used the content reading feature of PyMuPDF. When a source PDF is read, the library actually extracts all the localization and text information from the document. Two options are then available:

skipping the model inference and use this
combining it with the model inference to improve our predictions

I think we should skip inference in that case, why would we loose time to have worst performances ?


pre-commit hook

Hi,
This is just to let you know that I developped a pre-commit hook based on your lib:
https://github.com/Lucas-C/pre-commit-hooks-safety
It is not yet fully functional : a small limitation in pre-commit is a blocker, but I intend to fix it in this issue:
https://github.com/pre-commit/pre-commit/issues/426

Alternatively, is there a way to analyze a single requirements file instead of the whole current environment ?

Thanks @Lucas-C, that's awesome. You can read a single file from stdin using the --stdin flag, although I'm not quite sure it this will work in this context.
Also, there's a small bug right now using stdin. I'm going to fix that next.

FYI: I've added the pre-commit hook to the README.
Also, since this is super useful: Is there some way safety could make that easier in general?  Maybe we could just add a function to safety to support this better.

The --from-file suggestion from https://github.com/pyupio/safety/issues/6 sounds great !
It would be even cleaner than a workaround in pre-commit/pre-commit#426

To have a perfectly seamless integration with pre-commit, a CLI option like this would be the best:
parser.add_argument('filenames', nargs='*', help='filenames to check')

This way, the python-safety-dependencies-check hook could be configured to only run when requirements files are modified, and thoses files would be passed to the safety command.

Could you check #6 if that solves the problem?

Looks perfect ! I just added a couple of comments to the commit: https://github.com/pyupio/safety/commit/2884da8c

Closing this: the hook now works perfectly, even with multiple requirements in a repo.


Use pytest and coverage

I can see that a file package_test.py is in the top-level, but we could potentially make use of pytest to make the testing process much more standardized.
Testing for code coverage (https://pypi.org/project/pytest-cov/) might also be of interest for maintainability. If this is of interest, let me know.

Yes, you are right. We can add the pytest to make the testing process. But I am not familiar with this tool. You can please proceed. We can discuss further if you need any clearification.

I noticed that the tests contain hard coded file paths . Would it make sense to instead include the testing data as part of the repository? Or perhaps reference some data publicly available on the web?
In terms of integration testing with geoserver, it might also make sense to spin up a geoserver docker container as part of the test run. There's a library pytest-docker for just that sort of thing.
Let me know what you think. This package has been super helpful for me already and I'd like to contribute!

Hi @dvignoles, Thank you for addressing this issue. Please sure you can integrate the docker container as a part of the test run. Thank you.

I think this is resolved now with #151. I will also close this issue for now.


c3js/c3 PR 1576 -- Uncaught TypeError: Cannot read property 'x' of null

6608 is a broken line of code carried over from c3js/c3 - see PR 1576 and https://github.com/c3js/c3/issues/1235
If there are no data, flowStart.x gives Uncaught TypeError: Cannot read property 'x' of null
Fix as suggested by jakerella is to replace line with:
} else if (flow.orgDataCount === 1 || (flowStart && flowStart.x) === (flowEnd && flowEnd.x)) {

I appreciate the PR. However I believe the proper course of action is to wait on https://github.com/c3js/c3/issues/1235 as I don't want to maintain a custom version of C3.
Also note that this repository is simply a build script; the proper place for this pull would have been https://github.com/pubnub/eon-chart.


How can i associate my own AzureDNS servers for the container

for example I have mycompany.com DNS Zone hosted in Azure
is it possible to get FQDN to my container group with cg1.mycompany.com?
the reason I am asking this question is that I saw a way to specify the name servers in this example
https://docs.microsoft.com/en-us/rest/api/container-instances/containergroups/createorupdate#examples
hence wondering if I can associate AzureDNS directly to the container with mycompany domain

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff247151-29f6-4a55-61b2-e5eae2d48927
Version Independent ID: 159517fe-202c-967d-f572-49c4f6988c46
Content: Azure Container Instances container groups
Content Source: articles/container-instances/container-instances-container-groups.md
Service: container-instances
GitHub Login: @dlepow
Microsoft Alias: danlep

@mganeshphani , Thanks for your question. We are checking on this and will respond to you soon.

@mganeshphani As per this doc, Container groups deployed to a virtual network don't currently support exposing containers directly to the internet with a public IP address or a fully qualified domain name.
@dlepow Can you please share your insights on this? Thanks :)

@dlepow Did you get a chance to take a look at this one? Thanks :)

I mean I am just wondering if I can associate a custom domain name to the
container group, like I do for the webapp..
On Tue, Apr 23, 2019 at 12:54 PM Karishma Tiwari - MSFT <
<EMAIL_ADDRESS>wrote:

@dlepow https://github.com/dlepow Did you get a chance to take a look
at this one? Thanks :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/29626#issuecomment-485908433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFPMMID3KFRPOX3MGE5MBNTPR5ENXANCNFSM4HGZIBSA
.

--
Ganesh Phani Majeti.

@mganeshphani - Apologies for my delay responding. I believe use of a custom domain is supported for container groups, but as @Karishma-Tiwari-MSFT notes, you can't make this association for a container group deployed in an Azure VNet. My understanding is you'd need to configure a dnsNameLabel for the container group (so the container group is initially exposed at mydnslabel.azure-container.io). And you'd use the dnsConfig settings to set up the DNS servers, and use your domain provider to add the mapping records.
Currently there is only the API support you note, or you could use a Resource Manger template to configure the dnsConfig settings. I'm not aware of examples beyond the one you located. Please let us know if this helps?

@mganeshphani Any update? Did that help?

Do we have a documentation link for custom domain configuration?
On Thu, Apr 25, 2019 at 12:12 PM Karishma Tiwari - MSFT <
<EMAIL_ADDRESS>wrote:

@mganeshphani https://github.com/mganeshphani Any update? Did that help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/29626#issuecomment-486759530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFPMMIF6FIC7T53LZHFBVGLPSHRBRANCNFSM4HGZIBSA
.

--
Ganesh Phani Majeti.

@mganeshphani I am not aware of any other document with custom domain configuration info.
@dlepow Are you aware of any doc on this? Should we have this requirement added to our doc backlog?

@mganeshphani  Unfortunately, this is a doc gap currently in Azure Container Instances, and I've created a work item for our doc backlog. This sounds like a useful future addition. Thanks again for your feedback!
@Karishma-Tiwari-MSFT - please close


use ConnectionId more widely

Basically this replaces instances of Vec used to represent
connection IDs, with ConnectionId.
This also implements a few additional traits for ConnectionId to make
its use a bit easier.

This doesn't yet change the public API (well, no more than e0394a87cd75f30caa4ce1863bed3017ef0f7e94 does), but I think we should update accept(), connect(), retry(), etc... at some point to use ConnectionId instead of &[u8].
Also, in the server examples/app,  there are a couple more clones of IDs than there were before, because of some lifetime issues I ran into. Will probably need more sleep to figure out a better way around that though :)

RIP hex_dump. Printable ConnectionId is nice usability win.

I merged this now, but I still want to try to figure out the clone thing in the server examples/apps later on.


Adding various data searching function

↗ Related/Fixed issues

Related: #253
Fixed: #264

📄 Description
Adds a search page.
Motivation and context

[x] Implement Search data retrieval for repos
[x] Implement Search data retrieval for users
[x] Implement Search data retrieval for code
[x] Implement Search data retrieval for issues
[ ] Implement Getting instances of search query in code
[x] Implement Search data templates for repos
[x] Implement Search data templates for users
[ ] Implement Search data templates for code
[x] Implement Search data templates for issues
[ ] Implement Search data templates for prs
[x] Implement Search data presentation for repos
[x] Implement Search data presentation for users
[ ] Implement Search data presentation for code
[x] Implement Search data presentation for issues
[ ] Implement Search data presentation for prs
[x] Implement repos search page
[x] Implement users search page
[x] Implement code search page
[x] Implement issues search page
[ ] Implement Context Based Searching and Jump To
[ ] Fix Ctrl+/ keyboard accelerator [Need Help]

📸 Assets (if appropriate):

@onein528 @DeveloperWOW64 I'll need help with the Data Templates because I'm not experienced with XAML. I would be needing data templates for issues, code, users, and repos.

Half way there!

I couldnt review right now. but i will definitely do asa possible

No worries, I still have quite a lot of work to do, most of it is quite difficult.

you seem that some search result model files are created in v4 namespace. but please move v3 folder. v4 folder is for graphql api and updated those models by generator and models that created manually will be deleted by generator.

your changes are quite cool. i will commit some more updates.

you seem that some search result model files are created in v4 namespace. but please move v3 folder. v4 folder is for graphql api and updated those models by generator and models that created manually will be deleted by generator.

I understand, I will move them in my next commit.

Repo Search is operational:

LOVE IT! I LOVE IT! cool.

@arihant2math I'm working on this. Please note that my changes would be a breaking change.

I'm going to finish it up, do you mind waiting for a bit (I'll be doing what I did to repos to the rest of the pages)

Ah, I got already started. But I can. Before doing so, can you solve merge conflicts?

@arihant2math

@onein528

Ah, I've got already started. But, not at all, I can.

You can put your changes on a branch and wait for a bit and then fix merge conflicts.

Before doing so, can you solve merge conflicts?

I created the fork via gh so I can't do it via terminal and gh isn't allowing me to do it via the gui (its telling me that I either need write access or I have to discard all my commits). Do you know the relevant git commands to use?

Updates:

Are you not be displayed this?

If not, you can use them:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line

I couldn't commit my change into this branch. Did yoy enabled 'Allow edits from maintainers.' when creating PR?

You would need to resolve them because I need write access.
Maintainers can now edit.
However, while I am very excited about the pr, this pr is very much still a draft and I don't think this should be merged until I fix some of the inherently visible problems with the issues page which are due to the search query not returning all the necessary info. Furthermore the code search has not been implemented yet, because I just started implementing displaying yesterday, and due to some complications it will take a day or two.

i can give you write access for a while

Also, do you know where I can find the glyph values for the octicons? I can only find the name not the hex.

Install octicon and see glyph map in CharacterMapUwp

You would need to resolve them because I need write access.
Maintainers can now edit

Thanks. I will take a look.

What. What? I merged this by mistake with meaningless commit title.............. I AM SORRY.

I'll write this PR in README credit section.

@arihant2math I reverted it. Can you re-open PR with this fork branch?


Control measures with no Altitude/Depth attributes

There are several control measures that do not carry the X or X1 attributes, denoting base and high/low altitude or depth, which probably should, especially for 3D representation.
Some include:
Submarine Action Areas

25150502 Submarine Action Area (SAA)
25150503 Submarine-Generated Action Area (SGAA)

Aviation Axes of Advance

25151401 Friendly Airborne/Aviation
25151402 Attack Helicopter

Aviation Directions of Attack

25151406 Friendly Aviation

Airspace Control Measures

25170800 Base Defense Zone
25172000 Weapons Free Zone

Airspace Control Points

25180500 Air Control Rendezvous
... through...
25182500 Orbit - Random Closed

Subsurface Control Points

25211200 Acoustic Countermeasure
... through...
25212200 Trial Track

Subsurface Stations

25214900 General Subsurface Station
... through...
25215500 Surface Warfare Unmanned Underwater Vehicle Subsurface Station

Sea Subsurface Returns

25218700 Nombo
... through...
25219200 Wreck, non-dangerous

FYI @ottenw

Some of these are by design, but there are a few members of the committee that will review them and submit change proposals.
FYI @elefteriou @mcgrane @ottenw


Statsbeat in Azure Application Insights: Python Updates

Currently the Python related regions and configurations are missing. It would be good to mention the following information for Python

By default the stats is enabled, it can be disabled via setting environment variable APPLICATIONINSIGHTS_STATSBEAT_DISABLED_ALL to true
If enabled, for non EU the stats goes to westus-0.in.applicationinsights.azure.com and for EU westeurope-5.in.applicationinsights.azure.com
Hence the above mentioned outgoing connection needs to be open accordingly in firewall while deploying the solution in a restrictive environment

Reference issue in opencensus-python: opencensus-ext-azure: what is the purpose of statsbeat_metrics and how it can be disabled

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d363e71-bbb2-3c77-938c-c77e243cca20
Version Independent ID: 89d4ed3e-2ba1-1d5b-aa67-f06ab7db89b9
Content: Statsbeat in Azure Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/statsbeat.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @AaronMaxwell
Microsoft Alias: aaronmax

@prabdeb Thanks for your feedback.
Assigning to content author  @AaronMaxwell for review.

Thanks for your dedication to our documentation. This issue has been triaged and approved. The PR is mentioned in the chat above. #please-close


preview of data lost #94

@mijar @katush Please check on your side.

remove the divs if there are no columns in table view, check the width of the element after adding first column (it is slighty smaller)

I have update please check once now. @mijar @katush

it's not working now...I added a few columns from the artists ID type, filtered something, added it again and it is not showing the whole dataset..

After you filtered and added why would it show the whole dataset? It Will it only show the portion of current data available, is not it?

solved, it was related to a different issue but combining codes with master helped - the fix was already there.


Upgraded evaluation footer

Plugin idea based around upgrading the footer:

show L=10  element list of <X> for lists of points, lists of polygons, etc.
allow previewing lists by clicking an icon (👁 maybe)
show A=action for actions
allow previewing actions by clicking an icon
allow viewing the full value of numbers (all 16 decimals, and NaN vs ±Infinity) by default or by clicking an icon

All this data is already passed back from the worker, it's just not displayed completely

Closed by #509


MSDKUI-1684: Fix warning icon after device orientation

Originally, RouteDescriptionItem had an icon by default. With this commit, RouteDescriptionItem checks if the icon is required  before showing it.

Codecov Report

Merging #89 into master will increase coverage by 0.83%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   88.38%   89.21%   +0.83%
==========================================
  Files          89       59      -30
  Lines        5493     3525    -1968
==========================================
- Hits         4855     3145    -1710
+ Misses        638      380     -258

Flag
Coverage Δ

#ios
89.21% <100%> (+0.83%)
:arrow_up:

Impacted Files
Coverage Δ

MSDKUI/Classes/RouteDescriptionItem.swift
92.48% <100%> (+0.03%)
:arrow_up:

MSDKUI_Demo/IconButton.swift

MSDKUI_Demo/OptionsViewController.swift

MSDKUI_Demo/ManeuversOverviewViewController.swift

MSDKUI_Demo/GuidanceDashboardViewController.swift

MSDKUI_Demo/ExtensionArray.swift

MSDKUI_Demo/RouteViewController.swift

MSDKUI_Demo/ExtensionUITableViewCell.swift

MSDKUI_Demo/ExtensionBundle.swift

MSDKUI_Demo/ExtensionNMAMapMarker.swift

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924f807...9894c25. Read the comment docs.


Please stop writing "WARNING: No active editor during save. Nothing saved." to the Helm output channel

Currently when ANY document is saved and there is no active editor, the extension logs WARNING: No active editor during save. Nothing saved. to the Helm output channel (and forces the output channel to show itself 😢)
This is causing issues with GitLens' new settings editor (since it is a previewHtml -- not an editor) and it saves settings which seems to cause vscode to fire an onDidSaveTextDocument event.
Here is the offending line:
https://github.com/Azure/vscode-kubernetes-tools/blob/43210bbc8edac9cb075a63f26fd51fb11ba3285f/src/extension.ts#L162
Also here is where it is forcing the output panel to show each time something is logged -- I hope this can be removed too.
https://github.com/Azure/vscode-kubernetes-tools/blob/43210bbc8edac9cb075a63f26fd51fb11ba3285f/src/logger.ts#L20

Thanks for flagging this.  I've noticed that some of the Helm bits can be a bit over-enthusiastic.  I'll figure out why it wants to warn about this and get it fixed so it errs on the side of non-noisiness.

@eamodio If you want to test with the proposed fix in the PR, please grab it from my fork and let me know if it still gives you grief!  Thanks again for flagging this.

Awesome -- thank you for the quick fix! A few people thought GitLens was broken because of it, so will be wonderful to have it fixed.

@eamodio To close the loop - this update is now published in the gallery (as 0.1.5), so your users can now take the fix.  Sorry for the delay (travelling!).


Headings, list and so on not working...

Hi there, first of all, thank you very much for this nice project!
I used your library, but it partly works.
For example, making words italic or bold works well, but headings, list and so on unfortunately not.
I simply added the following line:

as described by your documentation.
Do you know what might cause the problem not showing headings and bullet list correctly?
I also added prism.js for syntax highlighting, which works ok.
I hope you have the time to give a solution.
Thank you.

I see it's conflicting with Bulma css! That's a bummer 😕
Any idea how to fix that?

Found the solution for Bulma css here!

A single class to handle WYSIWYG generated content, where only HTML tags are available

<md-block class="content">
    <!-- Generated markdown here -->
</md-block>

I'm happy again, hope you too!

What Markdown renderer are you using that generates <md-block as html for headings? that's atypical for a Markdown content generator so I'm curious if there's some advanced options that allow you to specify the CSS class which is included when it renders headings?
I have a jekyll pwoered site and my site uses the kramdown engine, which is consistent with Github Pages.
not trying to push ChatGPT but this is probably a perfect question for it. you might actually be surprisedd to hear what it has to say about bulma and with more information you could try to hae it come up with a solution for you. if you prompt it with " i'm tryign to setup a ____ -based site using the bulma css framework. haedlines that should have classes title and subtitle aren't. can you help?


Update Plugin Artifacts Links for v0.141.6

Automated changes by create-pull-request GitHub action

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Progress on Motion Sensors?

I see the readme only talks about the contact sensors working with this method so far.  Has anyone had success getting this to work for the motion sensors?

I can confirm that the motion sensors DO lose their mac. I just had one replaced and am might try to do a bootloader firmware upload.

I can confirm that the motion sensors DO lose their mac. I just had one replaced and am might try to do a bootloader firmware upload.

Any word on success of this? I'm considering trying to change my motion sensor batteries before they give up, but I don't want to risk it unless I have a good idea they can be recovered.

Sorry if not the right place for this...  Total GitHub noob.
Anyway – I have the files and the hardware – (flasher/programmer) and some dead contact sensors – confused about the process.
Any chance on getting a dumb guys easy to follow step by step?
If have the time – Thanks so much.
From: neothermic
Sent: Friday, May 14, 2021 9:06 AM
To: sycophantic/wyzeback
Cc: Subscribed
Subject: Re: [sycophantic/wyzeback] Progress on Motion Sensors? (#8)
I can confirm that the motion sensors DO lose their mac. I just had one replaced and am might try to do a bootloader firmware upload.
Any word on success of this? I'm considering trying to change my motion sensor batteries before they give up, but I don't want to risk it unless I have a good idea they can be recovered.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

https://forums.wyzecam.com/t/unbricking-wyze-contact-sensor-pcb-reset-pin/146856/102
On Sat, May 15, 2021 at 06:16 Nethead28 @.***> wrote:

Sorry if not the right place for this... Total GitHub noob.
Anyway – I have the files and the hardware – (flasher/programmer) and some
dead contact sensors – confused about the process.
Any chance on getting a dumb guys easy to follow step by step?
If have the time – Thanks so much.
From: neothermic
Sent: Friday, May 14, 2021 9:06 AM
To: sycophantic/wyzeback
Cc: Subscribed
Subject: Re: [sycophantic/wyzeback] Progress on Motion Sensors? (#8)
I can confirm that the motion sensors DO lose their mac. I just had one
replaced and am might try to do a bootloader firmware upload.
Any word on success of this? I'm considering trying to change my motion
sensor batteries before they give up, but I don't want to risk it unless I
have a good idea they can be recovered.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sycophantic/wyzeback/issues/8#issuecomment-841649118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJSF4J423AEWY4EMJ5BK3RDTNZQ2ZANCNFSM44KMUC2A
.

Confirmed - it works on motion sensors too.  I made a new wyzeback_motion.py to patch the firmware:
`#!/bin/python3
import sys
if len(sys.argv) < 2:
print('wyzeback_motion')
print('Usage: ' + sys.argv[0] + ' ')
print('e.g. ' + sys.argv[0] + ' 77A5DBDD')
else:
newmac = sys.argv[1].upper()
f=open('wyzesense_motion_77A5DBDD.bin','rb')
patched=f.read().replace(b'77A5DBDD',bytes(newmac, 'utf-8'))
f.close()
filename='patched_' + newmac + '.bin'
f = open(filename,'wb')
print('Writing: ' + filename)
f.write(patched)
f.close()
`

Confirmed - it works on motion sensors too. I made a new wyzeback_motion.py to patch the firmware:

Excellent news! Thank you, now I needed to review what hardware I need to do the flashing.

your scripts  don't work
it won't run
tried on  3 different machines and I get errors
with both the   door and motion script
tried it with  py installed as command line
tried it without m  it just gives errors every single time
https://i.postimg.cc/MpVVF9B5/wyzeback-script-errors.png

your scripts don't work it won't run tried on 3 different machines and I get errors with both the door and motion script tried it with py installed as command line tried it without m it just gives errors every single time
https://i.postimg.cc/MpVVF9B5/wyzeback-script-errors.png

This is a collaborative space, so please try not to be so absolute with your comments - the scripts worked fine for me when I last used them - I suspect you need to try running the python scripts with python, for example instead of "script.py" try "python script.py" .
You will need python installed.

your scripts don't work it won't run tried on 3 different machines and I get errors with both the door and motion script tried it with py installed as command line tried it without m it just gives errors every single time
https://i.postimg.cc/MpVVF9B5/wyzeback-script-errors.png

This is a collaborative space, so please try not to be so absolute with your comments - the scripts worked fine for me when I last used them - I suspect you need to try running the python scripts with python, for example instead of "script.py" try "python script.py" .
You will need python installed.

can you be more literal I donlt understand what you mean
give me an exact syntax
I already have python installed  on my other machine as command line
I open CMD as admin
I type py
I get the  python prompt >>>
then what?
nothing will run from there
it only works if I run from  CMD and switch directories

your scripts don't work it won't run tried on 3 different machines and I get errors with both the door and motion script tried it with py installed as command line tried it without m it just gives errors every single time
https://i.postimg.cc/MpVVF9B5/wyzeback-script-errors.png

This is a collaborative space, so please try not to be so absolute with your comments - the scripts worked fine for me when I last used them - I suspect you need to try running the python scripts with python, for example instead of "script.py" try "python script.py" .
You will need python installed.

OK I got the FW patched for my motion sensor
I got my FTDI board, and set it to 3.3v logic (using the  serial UART TTL adapter method because I don't have other programmer board)
I installed the TI flasher program
I can see it detect my com port/ FTDI board
But I can not find a pin out for the test pads on the motion sensor though
there are 2 pads diagonal from one another in the corner of the board ,one labeled "T" and one labeled "R" and one other pad looks like it is labeled M4
https://i.postimg.cc/k4V4X06W/Screenshot-20220104-162926.png
so I went under the assumption that the pad labeled "T" was the TX and the pin labeled "R" was the RX
I soldered a JST connector onto the "T" and "R" pads ( so I can unplug it and have a connector case I need to reflash it again)
however when I tried to put it into bootloader mode by grounding the pad labeled "R"
the red light did not come on solid ,(it says in your instructions that you need to ground the RX pin) , so then I tried to ground the pad labeled "T" at power up instead
this worked and the red light came on solid
so it looks like in your picture the pad labeled "T" is the TX
but on mine the when I ground the pin labeled "T" on power up it puts it into bootloader mode
so then I connected up the TX and RX to the pads and tried to flash the board but it will not get detected in the flash programmer program
I have tried it a bunch or times and I tried reversing the TX and RX connections and I get no luck either way , the programs says to try changing the baud rate but I can not find any setting for changing the baud rate , in setting there are only 2 options and both are checked
should the "use 2 wire JTAG" option be checked? ,because it is
maybe I soldered to the wrong pads?
I assume the "T" pad is one of the right pads either TX or RX , but maybe the one labeled "R" is not the right pad , neither TX nor RX and is in fact some unused pad?
any ideas as to why this is not working , or which other pad to try?
I guess my assumption that T= TX and R= RX was wrong then
unless it is my FDI board ,but I don't think so
I don't really want to  go about randomly soldering to all the other pads ,
I was wondering if anyone would know the pin out for  motion sensor for  RX and TX

Wondering - Has anyone actually flashed a motion sensor with updated firmware to fix MAC address?


Reading response body in middleware

I would like to write every response to a log before returning it.
I tried to accomplish this using middleware. However, the call_next method returns a StreamingResponse. When I read it using the same code as in StreamingResponse.__call__, the response obviously can't be sent to the client anymore.
Is there any way to accomplish what I'm trying to do?

Yes, it is possible; you’ll want to study this docs page: https://fastapi.tiangolo.com/tutorial/custom-request-and-route/

This was super easy, thanks a lot!

Yes, it is possible; you’ll want to study this docs page: https://fastapi.tiangolo.com/tutorial/custom-request-and-route/

Now, I can't access this page. T T

Yes, it is possible; you’ll want to study this docs page: https://fastapi.tiangolo.com/tutorial/custom-request-and-route/

Now, I can't access this page. T T

The new link should be https://fastapi.tiangolo.com/advanced/custom-request-and-route/

@phy25 Thanks for posting the new link; I've now fixed it above.

Thanks for the help here everyone! :clap: :bow:
Thanks for reporting back and closing the issue :+1:


Italics not working

My Setup

Operating System: Windows 10
App Version: 3.0.7*
Installation type: exe

* NOTE The website currently links to 3.0.6 but the client reports that 3.0.7 is the latest. I think the website needs to be updated!

[X] I have tested with the latest version
[X] I can simulate the issue easily

Description
Italics do not work across multiple lines.
Using italics for part of a word/phrase is also problematic. Observe in Rocket Chat:
You cannot put "_quotes_" around _italics_.
Nor can italics be used p_art_ially...
...unless there is a _leading sp_ace.
Repro:

Launch Rocket Chat
Type in a multi-line message
Press Ctrl+a and Ctrl+i to italicize the text
Send the message

Current Behavior
Text appears with an underscore at the beginning and end of the text.
Expected Behavior
Text is italicized.

Please report this here: https://github.com/RocketChat/Rocket.Chat/issues
It has nothing to do with Rocket.Chat.Electron

You're sure it's the server and not the client?

Definetly.
The Client just sends the message to the server and the server tries to parse it.
You could try it yourself. Open your server-address in your browser and paste the same message. You will encounter the same problem.

Fair enough. Thanks!

@yuppox I can't move this issue to the server repository because there we collect more info about the server itself. Please let me know if you're going to open an issue, because our team is reviewing the message parsing/rendering to tackle exactly this kind of problem right now.


Support Intel compiler

We should make the tester able to target the Intel compiler (icc).
From playing around with icc and looking at the help documents:

We should be able to implement most of the Intel compiler interface on top of the existing gcc support;
We'd want to teach the tester about some of the more esoteric optimisation flags icc supports that gcc doesn't, eg the whole difference between -x, -ax, -arch, -march etc;
If we're targeting Windows at any point, we'd need to teach it the different argument convention on Windows;
We'd probably need to indirect through a Bash script that sources the requisite variables and invokes the compiler, but I don't think the tester would need to know about this.

So far, using icc as a gcc style compiler through a wrapper script seems to work, so this support would mainly be teaching the optimisation selector about icc's various exciting different optimisation levels.


AWS is rolling out updates to AWS Lambda execution environment

Hey,
Not sure if this exactly belongs here but just want to flag it for discussion.
Is there anything we need to worry about with this notification from AWS?
https://aws.amazon.com/blogs/compute/upcoming-updates-to-the-aws-lambda-execution-environment/

posted on the Zappa Slack AWS channel

@dansayo I am not able to see the Zappa Slack, is there any way for me to access or could you share what has been posted? Thanks!

so to test this now all we need to do in the AWS console is apply the layer arn:aws:lambda:::awslayer:AmazonLinux1803 to current zappa deployed lambdas if im reading the docs right?

posted on the Zappa Slack AWS channel

I can't also get sign in, how can I request access? Thanks!

The lambda-packages repo used by zappa is probably where most of the concern would be https://github.com/Miserlou/lambda-packages/issues/102

@kikeh @xoelop there's a link on the repo homepage to the slack join tool; https://slack.zappa.io/

@gricey432 Great! Thanks!

Have done some basic tests on our dev with the new layer and there doesnt seem to really be any dramas so far.

We tested and this breaks our app as things currently stand. This is due to our reliance on crypography from lambda-packages, which is compiled against current version of Amazon Linux for Lambda. I think we will either have to start including a custom compile, upgrade lambda-packages, or work on this particular enhancement https://github.com/Miserlou/Zappa/issues/1861

Could we accept pull request https://github.com/Miserlou/Zappa/pull/1842 so that we can have layers support in Zappa. I was able to use the feature in the pull request and configure
"layers": ["arn:aws:lambda:::awslayer:AmazonLinux1703"],

in my Zappa settings file so that we could defer the OS upgrade.

You can also just manually set it via the AWS UI from what ive seen, a function update doesnt seem to be getting rid of that.

FYI, we also found out that if you use Python 3.7 (which means there are no lambda-packages to fall back to, which does happen with python 2.7/3.6 - it will use an older lambda-package of your binary and warn you about it), AND deploy Zappa from Linux, then cryptography works just fine. This is because Zappa in that case doesn't use manylinux, nor lambda packages, and relies on loc virtual env version, which includes the correct abi3 binary. Perhaps lambda-packages should now be made optional in Zappa, PRs welcome.

@nikbora What about older version of python 2.7 / 3.6, etc.? If we do not use lambda-packages, will the manylinux versions run on the old and new AWS environment?


Upgrade jQuery > 3.4

https://github.com/edx/edx-bootstrap/network/alert/package-lock.json/jquery/open

Done; we're on 3.5 now.


abnormal sperm radial spoke morphology

Add new term:
abnormal sperm radial spoke morphology (a child of abnormal sperm axoneme morphology MP:0009838)
DEF: any structural anomaly of the T-shaped protein complex that links an outer microtubule doublet of the sperm flagellum axoneme with the sheath that surrounds the central pair of microtubules; it is composed of a stalk that attaches to each doublet microtubule and a globular structure (spoke head) that projects toward the central pair of microtubules
SOURCE: PMID: 34871179, GO:0001534
Annotations from: J:320661, J:319365, J:293391, J:322334 and J:257803

Added new term:
abnormal sperm radial spoke morphology MP:0031438