Spells

Added upcast, count, and reroll fields to spellData

Once we merge this in I'll create a PR for the casper-data spell branch

Once we merge this in I'll create a PR for the casper-data spell branch


[iOS] React Native Version Mismatch using react native init template (0.62.2)

Description
When installing an empty app from react-native init using React Native 0.62.2 on a physical device, I receive the following error if I try to enter remote debugging via the debug menu.
console.error: "React Native version mismatch..

JavaScript version: 0.61.5
Native version 0.62.2

Make sure that you have rebuilt the native code. If the problem persists try clearing the Watchman and packager caches with `watchman watch-del-all && react-native start --reset-cache`."

<stack trace>

The app behaves normally when not in remote debug mode. When run in a simulator, remote debugging works as expected. This is true even when both the sim & physical device are served by the same packager instance.
Note: I first ran into this upgrading an existing project from 0.61.5, but since I can reliably reproduce with a new template on 0.62.2 I'm filing here and not in react-native-community/upgrade-support
React Native version:
$ npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 10.15.3
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 2.17 GB / 16.00 GB
    Shell: 5.0.16 - /usr/local/bin/bash
  Binaries:
    Node: 13.12.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 11.4/11E146 - /usr/bin/xcodebuild
  Languages:
    Java: javac 14 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.2 => 0.62.2
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

npx react-native init DummyApp
Open DummyApp.xcworkspace in XCode
Launch Debug configuration on physical iOS device
Shake device - select Debug in the menu
Bundle will reload, and app will report the version mismatch error.

Expected Results
Debug mode on physical device should launch with no errors, as the simulator does
Snack, code example, screenshot, or link to a repository:
package.json:
{
  "name": "DummyApp",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "android": "react-native run-android",
    "ios": "react-native run-ios",
    "start": "react-native start",
    "test": "jest",
    "lint": "eslint ."
  },
  "dependencies": {
    "react": "16.11.0",
    "react-native": "0.62.2"
  },
  "devDependencies": {
    "@babel/core": "^7.6.2",
    "@babel/runtime": "^7.6.2",
    "@react-native-community/eslint-config": "^0.0.5",
    "babel-jest": "^24.9.0",
    "eslint": "^6.5.1",
    "jest": "^24.9.0",
    "metro-react-native-babel-preset": "^0.58.0",
    "react-test-renderer": "16.11.0"
  },
  "jest": {
    "preset": "react-native"
  }
}

Podfile:
platform :ios, '9.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

def add_flipper_pods!(versions = {})
  versions['Flipper'] ||= '~> 0.33.1'
  versions['DoubleConversion'] ||= '1.1.7'
  versions['Flipper-Folly'] ||= '~> 2.1'
  versions['Flipper-Glog'] ||= '0.3.6'
  versions['Flipper-PeerTalk'] ||= '~> 0.0.4'
  versions['Flipper-RSocket'] ||= '~> 1.0'

  pod 'FlipperKit', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitLayoutPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/SKIOSNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitUserDefaultsPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitReactPlugin', versions['Flipper'], :configuration => 'Debug'

  # List all transitive dependencies for FlipperKit pods
  # to avoid them being linked in Release builds
  pod 'Flipper', versions['Flipper'], :configuration => 'Debug'
  pod 'Flipper-DoubleConversion', versions['DoubleConversion'], :configuration => 'Debug'
  pod 'Flipper-Folly', versions['Flipper-Folly'], :configuration => 'Debug'
  pod 'Flipper-Glog', versions['Flipper-Glog'], :configuration => 'Debug'
  pod 'Flipper-PeerTalk', versions['Flipper-PeerTalk'], :configuration => 'Debug'
  pod 'Flipper-RSocket', versions['Flipper-RSocket'], :configuration => 'Debug'
  pod 'FlipperKit/Core', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/CppBridge', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FBCxxFollyDynamicConvert', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FBDefines', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FKPortForwarding', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitHighlightOverlay', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitLayoutTextSearchable', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
end

# Post Install processing for Flipper
def flipper_post_install(installer)
  installer.pods_project.targets.each do |target|
    if target.name == 'YogaKit'
      target.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '4.1'
      end
    end
  end
end

target 'DummyApp' do
  # Pods for DummyApp
  pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
  pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
  pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
  pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/'
  pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
  pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'ReactCommon/callinvoker', :path => "../node_modules/react-native/ReactCommon"
  pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga', :modular_headers => true

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

  target 'DummyAppTests' do
    inherit! :complete
    # Pods for testing
  end

  use_native_modules!

  # Enables Flipper.
  #
  # Note that if you have use_frameworks! enabled, Flipper will not work and
  # you should disable these next few lines.
  add_flipper_pods!
  post_install do |installer|
    flipper_post_install(installer)
  end
end

target 'DummyApp-tvOS' do
  # Pods for DummyApp-tvOS

  target 'DummyApp-tvOSTests' do
    inherit! :search_paths
    # Pods for testing
  end
end

What I've Tried

Remove node_modules and npm install
watchman watch-del-all && npm start -- --reset-cache
Search for references to this version in project root with grep -ir "0\.61\.5" . - no results
Kill all running node processes & try again; reboot PC & try again
Use react-native-clean-project to do a npx react-native clean-project-auto
Clean/rebuild workspace in XCode
Uninstall all RN apps signed by this developer profile on the physical device, reboot device & reinstall only test app
rm -rf ~/Library/Caches/CocoaPods; rm -rf Pods #inside the project ./ios folder; rm -rf ~/Library/Developer/Xcode/DerivedData/*;
pod deintegrate; pod setup; pod install

This seems to have resolved following an update to @react-native-community/cli-debugger-ui @ 4.7.0

I believe it happens when you running metro bundler with different project (your second project is using 61.5 probably)


Add UPFDeployment controller

Adding UPFDeployment controller with:

unit tests for non-Reconciler functions. More tests will be added once we defined the setup for Integration and Func testing.
SecurityContext added to Deployment.Spec.Template.Spec.Containers
UPFDeployment status fields OperationStatus and OperationUpTime updated after upfdeployment is created
multiple DNNs are possible to be provided in the spec
logging added
checking if all required NADs exist in a namespace before creating a deployment object
reconcile periodically to update UPFDeployment status in the case underlying pods status changes.

I am using the following API file before the updated file is checked in the API repo:
upfdeployv1alpha1 "github.com/nephio-project/nephio-pocs/nephio-5gc-controller/apis/nf/v1alpha1"
Tested with two UPFDeployments in different namespaces:
upf-1                 free5gc-upf-1-7cb78c8b78-x22d8                1/1     Running   0          14h
upf-2                 free5gc-upf-2-55fc6c977b-6qd7h                1/1     Running   0          33m

Logs:
 k logs pod/free5gc-upf-1-7cb78c8b78-x22d8 -n upf-1
RTNETLINK answers: File exists
2023-04-05T22:18:39Z [INFO][UPF][Util] UPF log: /free5gc/free5gc-upfd/log/upf.log
2023-04-05T22:18:39Z [INFO][UPF][Util] Config: /free5gc/config/..2023_04_05_22_18_38.1725034701/upfcfg.yaml
2023-04-05T22:18:39Z [INFO][UPF][Util] UPF config version [1.0.0]
2023-04-05T22:18:39Z [INFO][UPF][Util] Set log level: info
2023-04-05T22:18:39Z [INFO][UPF][Util] DNN routes added, main routing table:
2023-04-05T22:18:39Z [INFO][UPF][Util] DstIp               Gateway        Iface     Priority RtProto   Type
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /24   <IP_ADDRESS>        n6-2      0        kernel    unicast
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /24   <IP_ADDRESS>        n6-1      0        kernel    unicast
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /24   <IP_ADDRESS>        n4-1      0        kernel    unicast
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /32       <IP_ADDRESS>        eth0      0        boot      unicast
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /24       <IP_ADDRESS>      eth0      0        boot      unicast
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /16       <IP_ADDRESS>        upfgtp    0        static    unicast    <<< DNN internet
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /16       <IP_ADDRESS>        upfgtp    0        static    unicast    <<< DNN private
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /24       <IP_ADDRESS>        n3-1      0        kernel    unicast
2023-04-05T22:18:39Z [INFO][UPF][Util] <IP_ADDRESS> /0          <IP_ADDRESS>      eth0      0        boot      unicast

ConfigMap
❯ k get cm/free5gc-upf-1-upf-configmap -n upf-1 -o yaml
apiVersion: v1
data:
  upfcfg.yaml: |2

    info:
      version: 1.0.0
      description: UPF configuration

    configuration:
      ReportCaller: false
      debugLevel: info
      dnn_list:
      - cidr: <IP_ADDRESS>/16
        dnn: internet
        natifname: n6
      - cidr: <IP_ADDRESS>/16
        dnn: private
        natifname: n6
      pfcp:
        - addr: <IP_ADDRESS>

      gtpu:
        - addr: <IP_ADDRESS>
        # [optional] gtpu.name
        # - name: upf.5gc.nctu.me
        # [optional] gtpu.ifname
        # - ifname: gtpif
  wrapper.sh: |
    #!/bin/sh

    ### Implement networking rules
    iptables -A FORWARD -j ACCEPT
    iptables -t nat -A POSTROUTING -s <IP_ADDRESS>/16 -o n6-1 -j MASQUERADE  # route traffic comming from the UE  SUBNET to the interface N6
    iptables -t nat -A POSTROUTING -s <IP_ADDRESS>/16 -o n6-2 -j MASQUERADE  # route traffic comming from the UE  SUBNET to the interface N6
    echo "1200 n6if" >> /etc/iproute2/rt_tables # create a routing table for the interface N6
    ip rule add from <IP_ADDRESS>/16 table n6if   # use the created ip table to route the traffic comming from  the UE SUBNET
    ip route add default via <IP_ADDRESS> dev n6-1 table n6if  # add a default route in the created table so  that all UEs will use this gateway for external communications (target IP not in the Data Network attached  to the interface N6) and then the Data Network will manage to route the traffic
    ip rule add from <IP_ADDRESS>/16 table n6if   # use the created ip table to route the traffic comming from  the UE SUBNET
    ip route add default via <IP_ADDRESS> dev n6-2 table n6if  # add a default route in the created table so  that all UEs will use this gateway for external communications (target IP not in the Data Network attached  to the interface N6) and then the Data Network will manage to route the traffic

    /free5gc/free5gc-upfd/free5gc-upfd -c /free5gc/config//upfcfg.yaml
kind: ConfigMap
metadata:
  creationTimestamp: "2023-04-05T22:08:35Z"
  name: free5gc-upf-1-upf-configmap
  namespace: upf-1
  resourceVersion: "332199"
  uid: 26d195db-45e4-40ee-b565-c4f10d2fed23

Makes sense to squash to keep the history clean. Should I squash locally or it will be done on merge?

/retest

/ok-to-test

I don't think GitHub can automatically squash...

/test ?


refactor: add core.utils.bounds_to_geometry to reuse in factories

At 5 places piece of code is used to convert bounds to geometry. This PR adds titiler.core.utils.bounds_to_geometry and updates core, mosaic and xarray factories to use the function instead.
cc @vincentsarago –– totally fine if you decide to close this PR – it may or may not be essential to the immediate focus of the project.

🙌 this is great.
I'll try to merge this week but I'm pretty hands down and focused on one other project right now


 I would rather expect the selected text to be replaced with a new line when pressing enter

@BoyanH yeah, that should be the behavior. More precisely the contents of the selection should completely disappear and then the new line inserted at the end of the previous selection on the first enter key and then 6 times new line.
Try with multiple simple text editors and you should get the result I'm talking about.

@BoyanH and I looked it over and we found the problem. There wasn't any check for what happens if the enter key is pressed, but when there is a text selection. I made a pull request with the changes.

A test for the fix would be very nice to see. I see some other changes mentioned in the PR, so perhaps adding the test for the whole rewritten selection behavior might be better.
What error did you get? I can run the test case with this simple call:
python test_uix_textinput.py

if it's about where to place the test, well since it works with the keys, I'd add it under the already existing TextInputGraphicTest.test_text_validate() which might even inspire you (or perhaps you will have a better approach). :)

That's the error I get when I run the file this way.
  File "test_uix_textinput.py", line 48, in test_text_validate
     self.assertTrue(ti.text_validate_unfocus)
 AttributeError: 'TextInput' object has no attribute 'text_validate_unfocus'

That just means you probably don't have up-to-date version of Kivy, because that attribute is just another Kivy property here:
https://github.com/kivy/kivy/blob/21a68562be135338c6aaef0f3a3f6641f4473af4/kivy/uix/textinput.py#L2488
The test runs fine on Travis, Appveyor and locally with the latest master, therefore I don't think it's some weird bug with the graphic unittest.

Turned out I had forgotten to properly compile the project.
python setup.py build_ext --inplace -f

That or I installing nose and running make test fixed it. Now the test runs fine. Sorry about the trouble.

No problem, glad to help anyone who's interested in testing. In the end, it should mean less troubles for us in the future :)


Added information on xrefs for overloads, generic types to template

Added information on xrefs for overloads, generic types to template
See #7857
@imba-tjd

I've updated the topic to add the ref service, if you'd like to take a look, @BillWagner.


write tests with test-assembler?

https://luser.github.io/rust-project-docs/test-assembler/test_assembler/

We can use cookie-factory and quickcheck as we have already done on the matroska crate


Fix NullReferenceException in ProjectItemInstance.SetMetadataObject

Sometimes when SetMetadataObject is executing, RemoveMetadata can set the backing collection to null which causes a NullReferenceException.  This change adds an atomic "remove if empty" operation to the CopyOnWritePropertyDictionary<T> which will clear the dictionary without resetting the reference to null.
Fixes #2264

@dotnet-bot test Windows_NT Build for Full please

Looks good for perf:

Test
Type
Overall
Significant?
Value

DotnetConsoleProject
Evaluation: Time (ms)
:white_check_mark:
yes
27.1678 -> 27.1347 (-0.122%)

DotnetConsoleProject
Evaluation: Memory
:ok_hand:
no
4723473 -> 4723555 (0.002%)

DotnetWebProject
Evaluation: Time (ms)
:white_check_mark:
yes
41.3583 -> 40.6659 (-1.674%)

DotnetWebProject
Evaluation: Memory
::ok_hand:
no
6182080 -> 6182005 (-0.001%)

DotnetMvcProject
Evaluation: Time (ms)
:red_circle:
yes
78.9432 -> 79.0985 (0.197%)

DotnetMvcProject
Evaluation: Memory
:ok_hand:
no
8460725 -> 8460784 (0.001%)

Picasso
Evaluation: Time (ms)
:white_check_mark:
yes
233.7267 -> 227.7558 (-2.555%)

Picasso
Evaluation: Memory
:ok_hand:
no
32198955 -> 32199690 (0.002%)

SmallP2POldCsproj
Evaluation: Time (ms)
:red_circle:
yes
36.7586 -> 36.9414 (0.497%)

SmallP2POldCsproj
Evaluation: Memory
::ok_hand:
no
5187470 -> 5187357 (-0.002%)

Generated_100_100_v150
Evaluation: Time (ms)
:white_check_mark:
yes
1395.2903 -> 1393.0043 (-0.164%)

Generated_100_100_v150
Evaluation: Memory
::ok_hand:
no
174567744 -> 174567416 (0%)

LargeP2POldCsproj
Evaluation: Time (ms)
::ok_hand:
no
653.6549 -> 652.9236 (-0.112%)

LargeP2POldCsproj
Evaluation: Memory
:ok_hand:
no
68739778 -> 68740345 (0.001%)

roslyn
Evaluation: Time (ms)
:white_check_mark:
yes
5246.9899 -> 5223.9444 (-0.439%)

roslyn
Evaluation: Memory
::ok_hand:
no
579757569 -> 579755978 (0%)


Issue about Basel dataset

Hello Xiaohang,
Thanks for the great work ! I tried to reproduce the survival prediction results  in your paper, though I browse the Basel dataset download from the zenodo, I can't find the PVs about the patient, except age and ER.status, could you tell you how to get the clinical data in the Basel dataset?
Best wishes!
Siqi

Hi Siqi,
The treatment information may be found in column 'Post-surgeryTx' in Basel_PatientMetadata.csv. Expression data may be found in Data_publication/BaselTMA/SC_dat.csv in SingleCell_and_Metadata.zip. Data are available through https://zenodo.org/record/3518284
Best regards,
Xiaohang

Thank you for your reply, I got treatment information and part of expression data, but I can't find about HER2 yet, could you tell you how to get the HER2 in the file?
Best wishes!
Siqi


fix(ui): adjust language in onboarding network step

Description:
Adjust language in onboarding network step
Motivation and Context:
Improve usability of Network onboarding step
How Has This Been Tested?
Manually
Screenshots (if appropriate):
With testnet selected:

With mainnet selected:

Types of changes:
Enhancement
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.01%) to 21.345% when pulling 6584d6f7313a7a1a031802413305ff2ac10e3917 on mrfelton:fix/network-selection-language into fa7a6384560a1d9624bbc2737b16f3c8c41fcee6 on LN-Zap:next.

Coverage decreased (-0.01%) to 21.345% when pulling 6584d6f7313a7a1a031802413305ff2ac10e3917 on mrfelton:fix/network-selection-language into fa7a6384560a1d9624bbc2737b16f3c8c41fcee6 on LN-Zap:next.


Support data sets in data provider

Even primitive detection (without pointing the method the provider belongs to) of yielded keys as named dataset
    (yield_expression
      (array_element_initializer
        (string
          (string_value) @dataset )))

could prove helpful in tests where yield is used in data provider.
At the moment I need some free time to answer myself how to pass the data set here
https://github.com/olimorris/neotest-phpunit/blob/5799a4ea84450af14461d24edbde43913f9b3008/lua/neotest-phpunit/init.lua#L137-L141
or into any better place and (optionally) how to list detected data set on the summary view. Any hints (as well as PR) can be helpful.

Any news on this? Let me know if I can help at all


[STORM-2932] the naming of topology localityaware configs are confusing

https://issues.apache.org/jira/browse/STORM-2932
The names are confusing. I think we should delete "percent"

The changes look okay to me.  I just want to be sure that you are aware that this is a breaking change and the consequences of that.  Because this config went into 2.x and has not been released it is probably not a big deal, but if someone has started to use it they would need to change their settings.

@revans2 Yes you are right. I assumed that this can be changed since 2.x is not released.

@revans2 @Ethanlm
I don't think this is a deal. We didn't release Storm 2.0.0 officially, and also that's added just 4 months ago hence even early-adopter may exist, the possibility for end-users to utilize these parameters is really low.


could someone provide me the link of MSMARCO/triples.train.small.tsv

I am new to this I just want to first run the code and study how the code works but i dont have the dataset MSMARCO/triples.train.small.tsv  if someone has it please provide me the link

The MSMARCO dataset is available here: https://microsoft.github.io/msmarco/Datasets.html


Updated several test dependencies from years-old versions

I noticed that several test dependencies were on years-old 0.x major versions of packages. npm audit pointed out several security vulnerabilities. These version bumps:

Bring down security audit results to 0 vulnerabilities.
Give us much newer and shinier Istanbul coverage reports.

npm test works as before. Tests pass.

Coverage increased (+0.08%) to 94.318% when pulling 5c1f97c69f0351c7cff8990d5534f22b58aafdda on Antrikshy:master into d7f4ea63df949c0a1f2f53d1b3c14d7dc393a8d8 on peterolson:master.

Thanks!


vic daily steps ?

Bug Reports

Version of VIC :5.0.1 Feb1,2017
gcc and g++
linux ubuntu 16.4?

I want to run vic 1step per day
so I set the MODEL_STEPS_PER_DAY=1, SNOW_STEPS_PER_DAY=1, RUNOFF_STEPS_PER_DAY=1,
FULL_ENERGY=FALSE, FROZEN_SOIL=FALSE, and FORCE_STEPS_PER_DAY=1.
but when I run vic,he tell me "the specified number of snow model steps per day (1)< the minimum number of subdaily steps per day (4). make sure that the global file defines SNOW_STEPS_PER_DAY of at least (4)."
my question:
1.what is the"subdaily steps per day" ? can I set it to (1) ?
2.how can I run vic for 1 step per day? how to set the parameters?

VIC 5 requires that you supply forcings at a maximum timestep of 6 hours (e.g. MODEL_STEPS_PER_DAY=4). This is specified in https://vic.readthedocs.io/en/master/Documentation/Drivers/Classic/ForcingData/.

thank you very much    !
if I use vic 4 ,I will set 1step per day?

This is not totally clear in the documentation. The description for MODEL_STEPS_PER_DAY says that it "should be > 4 for FULL_ENERGY=TRUE or FROZEN_SOIL=TRUE" (https://vic.readthedocs.io/en/master/Documentation/Drivers/Classic/GlobalParam/). However, when this is not the case and VIC is run in "water balance mode" (FULL_ENERGY=FALSE) , it is still not possible to set 1 step per day and use daily forcings.
This is an important difference between VIC 4 and VIC 5. It is not straightforward to migrate from one version to the other if you have always work with daily forcings. You will need to carry out the time disaggregation with MetSim beforehand, for example.
I would suggest a clearer description for MODEL_STEPS_PER_DAY so the user knows it since the beginning. Or even mentioning this in https://vic.readthedocs.io/en/master/Documentation/Drivers/Classic/ForcingData/

这是来自QQ邮箱的自动回复邮件。

您好，我已经收到您的邮件。十分感谢。

@pyested - if you're up for updating the documentation as you suggest, we'd be happy to take a look.


feat:add hychain service

#111
#49  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alex-klikatech and the rest of your teammates on  Graphite

Merge activity

Sep 26, 3:23 PM EDT: @anthonyra started a stack merge that includes this pull request via Graphite.


Add AMO link to readme

I already have a custom addon collection, so I've added a link to the addon on AMO for people to add to their own collections.

Thanks!

No thank you, the addon is great and makes reddit usable on mobile web :)


Analysing Locust4j - Performance test

I'm exploring Locust for performance test our applications. Would like to reuse the existing Java page objects(selenium web elements) instead of rewriting in Python.
Issue: I try to invoke a particular count of users, by entering in the textbox "Number of total users to simulate" (on the locust ui) but actually runs into an infinite loop spawning users forever.

How do I control the no. of requests.
Is this a right approach, where I'm trying to fire Selenium events instead of http get/post requests
Attaching the code snippet
testcode.TXT

Thanks,
Sirisha

Because the "execute" method runs in an infinite loop, you can't control the number of requests. Instead, you have control of thread-concurency and request per second(aka RPS).
If you really want to control the number of requests, try to keep a counter of requests and do nothing but sleeping in the "execute" method when the threshold exceeded.

BTW, performance testing using Selenium and WebDriver is generally not advised.
See aslo, https://www.selenium.dev/documentation/en/worst_practices/performance_testing/

Because the "execute" method runs in an infinite loop, you can't control the number of requests. Instead, you have control of thread-concurency and request per second(aka RPS).
If you really want to control the number of requests, try to keep a counter of requests and do nothing but sleeping in the "execute" method when the threshold exceeded.
Thanks for the quick response!
We also have developed a prototype in python for firing selenium events. But in python, there seems to be no problem as The no. of users input on the locust UI spins up exactly the sam
locustfile_python.TXT
e count of browsers through selenium. How is it controlled in Python.
Attaching the code for reference.


Create new batched ID query methods

For all endpoints that request something by ID and support passing multiple of these, there should be new methods that collect the method calls for some short amount of time, and then collect all the requested IDs, send a request with all of these (obviously limited by the number of IDs you can pass at once, which is usually 100) and return the correct responses to the respective callers.
Acceptance criteria

uses "any user" auth context
must be a completely new method per resource; does not replace any existing ones
has a configurable wait time in milliseconds (investigate if 0 as default still does anything, otherwise take some short like ~50 as default)
can fall back to single queries if the "big" request fails (for example due to invalid or non-existent IDs)
starts a maxed out request immediately if the endpoint's maximum number of ID arguments is reached
does not fail or lose any requests if more than the endpoint's maximum number of ID arguments is reached

Example
const ids = ['1', '2', '3'];
const streams = await Promise.all(ids.map(id => api.streams.getStreamByIdBatched(id)));
console.log(users);
// output is expected to contain streams of the users with the IDs 1, 2, 3 in the correct order
// if any of the streams is offline, `null` is returned in the appropriate place
// e.g. if users 1 and 3 are live and user 2 is not, the result should be like: [HelixStream, null, HelixStream]

Partially addressed in https://github.com/twurple/twurple/commit/48f251f4b10f4ae36a521640125c57b5a2eb14e6 and released in 6.2.0-pre.0. Missing parts are configurability (although I tested the default of 0 and it works well) and the request-per-ID fallback.


Version/<IP_ADDRESS> remove toobox

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
POC how to remove toolbox library.
Very easy.
For some reason my dart code analysis does not work on the main branch so there, can't do it.
✅ Checklist

[x] Code migrated

🕵♂ Notes for Code Reviewer
Code was simply moved from the library to the main app
1 dependency in the lib was moved over to pubspec: url_launcher
1 built-in code repo was moved to pubspec: flutter_pagewise
This one, was just added as source files to the repo from humazed.
Some very small utility functions I moved directly into the file.
All migrated classes are in lib/utils/old_toolbox
🙈 Screenshots
👯♀ Paired with
nobody

gah wrong branch


add samp image

All Submissions:

[x] Have you ensured there aren't other open Pull Requests for the same update or change?
[x] Have you created a new branch for your changes and PR from that branch and not from your master branch?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

I moved this image from https://quay.io/repository/parkervcp/pterodactyl-images?tab=tags&tag=game_samp to here because there is a error with it because it is to old and it does not include GLIBCXX_3.4.22

what is needed:

So I made the image myself wit hwhat I found on Quay.io and now it is in there:

i have not tested the image I just saw someone in the discord with that problem
New Image Submissions:

[x] Have you added your image to the Github workflows?
[x] Have you updated the README list to contain your new image?

The persone with the problem has confirmed this image fixt his problem, id:351916271304048650


Cc check add proxy+shim version

Coverage increased (+0.6%) to 52.546% when pulling 40af051d0b4a064b2b794f16d56951543b9076a6 on jodh-intel:cc-check-add-proxy+shim-version into d4be3b1ba3f3e132726b6495d2140da7aaecb8fa on clearcontainers:master.

lgtm


select in wrapper

When you view the Illusion example in different browsers you can notice a difference in the rendering of select.
It would be great if the element in your example is wrapped by default and applied by default styling.

https://github.com/timble/illusion/releases/tag/v4.0.0


differences between nGPT and nTransformers

https://github.com/lucidrains/nGPT-pytorch/blob/cb7185c66197de878ae478f4ec66d82e14c7c9a0/nGPT_pytorch/nGPT.py#L452-L454
https://github.com/lucidrains/nGPT-pytorch/blob/cb7185c66197de878ae478f4ec66d82e14c7c9a0/nGPT_pytorch/nTransformer.py#L414-L420
It seems that there are some key differences between the forward() implementations in nGPT and nTransformer.
The mask parameter is not passed to the attention layer in nGPT, and l2norm is not applied to the outputs.

@rotem154154 ah, nice catch with the mask
the l2norm in nGPT is actually absorbed into the Residual module for reuse in another project

@rotem154154 are you seeing something with nGPT?

I haven’t tried the model yet, just noticed the differences while reviewing the code.

@rotem154154 sg Rotem, let me know if you see anything interesting, whatever you can say of course

Ok, I think I found something—not a bug, just a suggestion for improvement.
I tried using parameters similar to GPT-2 124M from Karpathy's llm.c and ended up with 162M. The main difference seems to be the weight-tying:
https://github.com/karpathy/llm.c/blob/7ecd8906afe6ed7a2b2cdb731c042f26d525b820/train_gpt2.py#L140
It could be nice to have a boolean option to enable weight tying :)

@rotem154154 do you mean tying the logit projection with the token embeddings? that was brought up in a previous issue and the flag is here

@rotem154154 is weight tying even used that much in actual large language models being trained these days?

@rotem154154 yes please do
and also if you hit some negative result (some unreported metric is bad) also let me know, through email or otherwise
thank you

from the claims in this paper, either one camp or the other will have egg on their face, so to speak.

Why is there two files: nGPT and nTransformers？  and what is the difference？ tks~！ @lucidrains @rotem154154


Swap to sinon stub from homerolled fakeConfig

Description
Finished part 3 of #321 to use sinon instead of the manual fake. Along with removing the old exportAPI test helper.
cc @mattseddon
Design
Originally I was thinking of using sinon mocks but after reading though the documentation [1] it appears that these are more correctly called stubs in sinon land, heh [2].
I also turfed the exportAPI helpers for the extension tests and adopted the sinon spy instead [3], pretty happy with the results!
Work

[x] use sinon stub for fakeConfig
[x] refactor fakeConfig name to stub
[x] remove exportAPI concept and use sinon spies instead

Research

https://sinonjs.org/releases/v11.1.1/mocks/#when-to-not-use-mocks
https://sinonjs.org/releases/v11.1.1/stubs/#when-to-use-stubs
https://sinonjs.org/releases/v11.1.1/spies/#using-a-spy-to-wrap-all-object-method
https://stackoverflow.com/a/38152098

@mattseddon thanks for the feedback!


Enable Screen Sharing via boot_command in templates

I felt like adding Screen Sharing (along with SSH) might be useful to have as a default in this template. If you agree (?), I can also go and make the equivalent change for Monterey in this same PR.
The reason to enable Screen Sharing this way is because in Monterey 12.1, Apple made a change where setting Screen Sharing via automated means (like launchctl load-ing the screensharing service, or the kickstart ARD setup command) would not enable all the necessary TCC rights to have functional screen sharing. Either SIP would need to be disabled, or the machine enrolled in MDM, to push out the config. So, doing it manually via the checkbox in sysprefs seemed like the best way here.

FYI tart run --vnc-experimental bypasses any restrictions. @edigaryev please correct me if I'm worng.

@fkorotkov Good point, I had forgotten about --vnc-experimental! It lets you connect to a virtual screen of the VM itself. I guess the advantage of using the OS's screen sharing / VNC is you can easily share copy/paste and drag/drop files, easily resize/rescale, etc.


Release 0.3

Publish version 0.0.3

@rultor release, tag is 0.3.

@rultor release, tag is 0.3.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release, tag is 0.3.

@rafamizes Oops, I failed. You can see the full log here (spent 2min)
+ chmod a+x /home/r/script.sh
+ /home/r/script.sh
+ set -e
+ set -o pipefail
+ shopt -s expand_aliases
+ alias 'sudo=sudo -i'
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export head=git@github.com:dartoos-dev/flutter_brand_palettes.git
+ head=git@github.com:dartoos-dev/flutter_brand_palettes.git
+ export tag=0.3
+ tag=0.3
+ export head_branch=master
+ head_branch=master
+ export author=rafamizes
+ author=rafamizes
+ sed -i 's/^\(version:\).*/\1 0.3/' pubspec.yaml
++ date +%F
+ sed -i '/\[Unreleased\]/a\\n## [0.3] - 2021-05-22' CHANGELOG.md
+ mkdir -p /home/r/.pub-cache
+ mv ../credentials.json /home/r/.pub-cache/credentials.json
+ flutter pub publish -f

\u001b[1m  ╔════════════════════════════════════════════════════════════════════════════╗\u001b[22m
\u001b[1m  ║                 Welcome to Flutter! - https://flutter.dev                  ║\u001b[22m
\u001b[1m  ║                                                                            ║\u001b[22m
\u001b[1m  ║ The Flutter tool uses Google Analytics to anonymously report feature usage ║\u001b[22m
\u001b[1m  ║ statistics and basic crash reports. This data is used to help improve      ║\u001b[22m
\u001b[1m  ║ Flutter tools over time.                                                   ║\u001b[22m
\u001b[1m  ║                                                                            ║\u001b[22m
\u001b[1m  ║ Flutter tool analytics are not sent on the very first run. To disable      ║\u001b[22m
\u001b[1m  ║ reporting, type 'flutter config --no-analytics'. To display the current    ║\u001b[22m
\u001b[1m  ║ setting, type 'flutter config'. If you opt out of analytics, an opt-out    ║\u001b[22m
\u001b[1m  ║ event will be sent, and then no further information will be sent by the    ║\u001b[22m
\u001b[1m  ║ Flutter tool.                                                              ║\u001b[22m
\u001b[1m  ║                                                                            ║\u001b[22m
\u001b[1m  ║ By downloading the Flutter SDK, you agree to the Google Terms of Service.  ║\u001b[22m
\u001b[1m  ║ Note: The Google Privacy Policy describes how data is handled in this      ║\u001b[22m
\u001b[1m  ║ service.                                                                   ║\u001b[22m
\u001b[1m  ║                                                                            ║\u001b[22m
\u001b[1m  ║ Moreover, Flutter includes the Dart SDK, which may send usage metrics and  ║\u001b[22m
\u001b[1m  ║ crash reports to Google.                                                   ║\u001b[22m
\u001b[1m  ║                                                                            ║\u001b[22m
\u001b[1m  ║ Read about data we send with crash reports:                                ║\u001b[22m
\u001b[1m  ║ https://flutter.dev/docs/reference/crash-reporting                         ║\u001b[22m
\u001b[1m  ║                                                                            ║\u001b[22m
\u001b[1m  ║ See Google's privacy policy:                                               ║\u001b[22m
\u001b[1m  ║ https://policies.google.com/privacy                                        ║\u001b[22m
\u001b[1m  ╚════════════════════════════════════════════════════════════════════════════╝\u001b[22m
\u001b[1m\u001b[22m

Error on line 3, column 10 of pubspec.yaml: "version" field must have three numeric components: major, minor, and patch. Instead of "0.3", consider "0.3.0".
  ╷
3 │ version: 0.3
  │          ^^^
  ╵
\u001b[31mpub finished with exit code 65\u001b[39m
container 78552ba4d96b730377284bbb7cdf90df5e7fa44a6d3c524deefb0eb6e69382c6 is dead
Sat May 22 02:55:51 CEST 2021

@rultor release, tag is 0.3.0.

@rultor release, tag is 0.3.0.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release, tag is 0.3.0.

@rafamizes Done! FYI, the full log is here (took me 2min)


[$500] iOS/ Android - Attachment - Image looks cropped In the Preview page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Go to a chat
Click on the "+" sign
Select add Attachment
Select a screenshot (mad from your phone)

Expected Result:
Attached screenshot should fully visible in Preview page
Actual Result:
Attached screenshot is not  fully visible in Preview page
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS
Android

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause
https://user-images.githubusercontent.com/93399543/158041612-333a3bd5-c49f-4f2a-a514-0ff64db34d59.mp4

Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Current assignee @timszot is eligible for the Engineering assigner, not assigning anyone new.

@timszot were you able to work out which PR affected this?

Posted to Upwork!
External: https://www.upwork.com/jobs/~01fe2aa229cf3ecd0d
Internal: https://www.upwork.com/ab/applicants/1503501207937069056/job-details

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

Triggered auto assignment to @AndrewGable (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Price doubled! Get those proposals in! 📢

Proposal
We are using  various places and we are using additional top spacing for it so because of that image is cutting.
File name: AttachmentModal.js : Passing additional props
isAttachmentModal={true} ==> Additional Props
<Modal
  type={this.state.modalType}
  onSubmit={this.submitAndClose}
  onClose={() => this.setState({isModalOpen: false})}
  isVisible={this.state.isModalOpen}
  backgroundColor={themeColors.componentBG}
  onModalHide={this.props.onModalHide}
  propagateSwipe
  isAttachmentModal={true}
>

File name: BaseModal.js: We can ignore modalPassingStyle with props which we are passing.
Additional condition added !this.props?.isAttachmentModal &&
const modalPaddingStyles = !this.props?.isAttachmentModal && StyleUtils.getModalPaddingStyles({
                            safeAreaPaddingTop,
                            safeAreaPaddingBottom,
                            safeAreaPaddingLeft,
                            safeAreaPaddingRight,
                            shouldAddBottomSafeAreaPadding,
                            shouldAddTopSafeAreaPadding,
                            modalContainerStylePaddingTop: modalContainerStyle.paddingTop,
                            modalContainerStylePaddingBottom: modalContainerStyle.paddingBottom,
                        });

Before Resolve

After Resolve

We are using various places and we are using additional top spacing for it so because of that image is cutting.

@dharmik
Can you elaborate on this more?  I am expecting the following,

What exactly causes this crop effect?
Also how your solution will address the issues.

Also removing the entire modalPaddingStyles could break something in other platforms.

Proposal
This issue comes from src/components/ImageView/index.native.js when the calculation for imageHeight is not correct. Because we use the react-native-image-pan-zoom package, we need to calculate the correct width and height of the image. As you see below the height of the image of overflowing the headers and/or the button action below. So the solution is to get the correct height on the available space.
Roughly the calculation to get the available space is,
for preview without action dimension height - top insets safe area - header height
for preview with action dimension height - top insets safe area - header height - bottom action
Also we need to fix the problem with excess top padding on modal container on Android by set shouldAddTopSafeAreaPadding true only on iOS.

https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/styles/getModalStyles.js#L86
            shouldAddTopSafeAreaPadding = Platform.OS === 'ios';

Preview image without action

For the problem above we need to get the top insets of screen from `react-native-safe-area-context` cause the excess height is equal to the top insets. To do that we only need use `withSafeAreaInsets` hoc and access the top insets from props.
+        this.overflowHeight = props.insets.top;

Update the rest the code the calculate the height and the cropHeight property used by ImageZoom component.
https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/components/ImageView/index.native.js#L79
-                imageHeight = Math.round(this.props.windowHeight - variables.contentHeaderHeight);
+                imageHeight = Math.round(this.props.windowHeight - variables.contentHeaderHeight - this.overflowHeight);

https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/components/ImageView/index.native.js#L105
-        const windowHeight = this.props.windowHeight - variables.contentHeaderHeight;
+        const windowHeight = this.props.windowHeight - variables.contentHeaderHeight - this.overflowHeight;

Result

Preview image with action

For preview images with action, we can add more value to this.overflowHeight. So the button itself has 52 height and also margin: 20 we take the top and bottom margin which 40, so the total is 92.
            this.overflowHeight += variables.componentSizeLarge + 40;

Result

@Santhosh-Sellavel
Actual cause of issue:
We calculate image height according to WindowHeight, ContentHeaderHeight. so we are calculating
imageHeight = Math.round(this.props.windowHeight - variables.contentHeaderHeight);
but in page there is additional space which is ...modalPaddingStyles
so because of that image calculation is wrong and it cute.
I am checking ...modalPaddingStyles is it actually needed?

👀  this one.

Thanks for the proposals!
@dharmik yes we need the ...modalPaddingStyles. Removing it causes UI breakages.
@mollfpr Proposal looks good, I would like to see the complete proposal, please.
Handling both cases preview with send action & without action. Thanks!
cc: @AndrewGable

Also @AndrewGable, Can we loop in the design to get a confirmation of how it should look?
With & Without Send Action?

cc @Expensify/design

It looks like these screenshots would be correct:
Without send action

With send action

cc @Santhosh-Sellavel
Are we want to fix this also? On Android the header is too wide.

If yes, we can change the value
https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/styles/getModalStyles.js#L86
https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/styles/getModalStyles.js#L117
-            shouldAddTopSafeAreaPadding = true;
+            shouldAddTopSafeAreaPadding = Platform.ios;

This will only add insets.top from SafeArea to iOS, since only on iOS SafeAreaView apply padding to left and right. If this shouldAddTopSafeAreaPadding is true, will add insets.top to modal style.

For the solution, first we create the overflowHeight. In here we also need create props to flag if the modal has bottom action or not.
        // Add safe area padding top since all modal is added by `insets.top` from `shouldAddTopSafeAreaPadding` on `getModalStyles`
        // Double it on Android cause currently is applied `insets.top` twice
        // Double if `shouldAddTopSafeAreaPadding` from `getModalStyles` still has default value `true` for modal type
        // `CENTERED_UNSWIPEABLE` and `CENTERED`
        this.overflowHeight = Platform.OS === 'ios' ? props.insets.top : props.insets.top * 2;

        // Adjusment to borderBottomWidth from header component
        this.overflowHeight += 1;

        if (props.hasBottomAction) {
            // If has bottom action we add more with the button size + the top and bottom margin
            this.overflowHeight += variables.componentSizeLarge + 40;
        }

after we got the value, we can update the imageHeight and the cropHeight of ImageZoom component.
https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/components/ImageView/index.native.js#L79
+                imageHeight = Math.round(this.props.windowHeight - variables.contentHeaderHeight - this.overflowHeight);

https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/components/ImageView/index.native.js#L105
+        const windowHeight = this.props.windowHeight - variables.contentHeaderHeight - this.overflowHeight;

The only things left is pass the props hasBottomAction from AttachmentModal > AttachmentView > ImageView.
https://github.com/Expensify/App/blob/b347866b2af95bd2c51eb6bb65098bd1d756e7d0/src/components/AttachmentModal.js#L178
                            <AttachmentView sourceURL={sourceURL} file={this.state.file} hasBottomAction={!_.isEmpty(this.props.onConfirm)} />

@mollfpr
I see your proposal here
Here is the expected outcome https://github.com/Expensify/App/issues/8115#issuecomment-1082377765.
The OP should match the expected outcome on mobile, and also make sure your proposal doesn’t affect the existing web/desktop layout. Kindly test & see.
If the existing proposal is up to date addresses the issue, let me know.
If there are any changes kindly update your proposal & let me know.
Thanks!

Thanks can you cleanup submit a proposal in a separate comment.

cc: @AndrewGable
I think this proposal here over-engineered two many changes for a visual correction.
I see the @dharmik proposal here is a lot cleaner almost narrows down the root cause as StyleUtils.getModalPaddingStyles which adds the extra space to cause this breakage. And I believe modifying the modalStyles should solve the issue. So let's wait for a better proposal.
Please post your thoughts if any thanks!

Let's wait until we see one you can approve @Santhosh-Sellavel 👍

@Santhosh-Sellavel This issue only specific to iOS and Android so
Instead of using extra props
isAttachmentModal={true} ==> Additional Props
we can add condition for device OS bases
const modalPaddingStyles = !(Platform.OS === 'ios' || Platform.OS === 'android') && StyleUtils.getModalPaddingStyles({
It will resolve with cleaner code.
https://github.com/Expensify/App/issues/8115#issuecomment-1078943772

@Santhosh-Sellavel I have another proposal.
In here we add function onLayout to get the available height.
https://github.com/Expensify/App/blob/50496a0a0d7dd283f9936988cda95abf69741342/src/components/ImageView/index.native.js#L108-L118
+                    onLayout={(event) => {
+                        const layout = event.nativeEvent.layout;
+                        this.calculateImageSize(layout.height);
+                    }}

Now we add the height that we got from View layout to calculateImageSize function. Instead of using this.props.windowHeight, we use the height that we got from View layout.
https://github.com/Expensify/App/blob/50496a0a0d7dd283f9936988cda95abf69741342/src/components/ImageView/index.native.js#L60
-    calculateImageSize() {
+    calculateImageSize(viewHeight) {
        if (!this.props.url) {
            return;
        }
        ImageSize.getSize(this.props.url).then(({width, height}) => {
            let imageWidth = width;
            let imageHeight = height;
            const aspectRatio = (imageHeight / imageWidth);

            // Fit the image to windowWidth
            imageWidth = Math.round(this.props.windowWidth);
            imageHeight = Math.round(imageWidth * aspectRatio);

            // Resize the image to max dimensions possible on the Native platforms to prevent crashes on Android. To keep the same behavior, apply to IOS as well.
            const maxDimensionsScale = 11;
-            imageHeight = Math.min(imageHeight, (this.props.windowHeight * maxDimensionsScale));
+            imageHeight = Math.min(imageHeight, (viewHeight * maxDimensionsScale));

            // reduce the imageHeight to windowHeight if imageHeight is greater than the windowHeight
-            if (imageHeight > (this.props.windowHeight - variables.contentHeaderHeight)) {
-                imageHeight = Math.round(this.props.windowHeight - variables.contentHeaderHeight);

+            if (imageHeight > (viewHeight)) {
+                imageHeight = Math.round(viewHeight);
                imageWidth = Math.round((1 / aspectRatio) * imageHeight);
            }

            this.setState({imageHeight, imageWidth});
        });
    }

Now the only left to do is to remove the calculateImageSize inside the interaction. We call the calculateImageSize function after the image thumbnail shows up.
https://github.com/Expensify/App/blob/50496a0a0d7dd283f9936988cda95abf69741342/src/components/ImageView/index.native.js#L48-L58
Result

@mollfpr there is more space in the header area android refer to your screenshot. Compare it with https://github.com/Expensify/App/issues/8115#issuecomment-1082377765.

@Santhosh-Sellavel Yes, there’s more space. But above solution is take the thumbnail view which the available height and set it to ‘ImageZoom’. So it’s doesn't need to change anything on the styles.
I’ll add solution too for the exceeded space on Android if you like.

Adding @jliexpensify to keep an eye on this while I'm away for the next few days, in case we need to hire anyone.

Will review this ASAP (today or by tomorrow).

-            shouldAddTopSafeAreaPadding = true;
+            shouldAddTopSafeAreaPadding = Platform.ios;

What is Platform.ios ?

What is Platform.ios ?

Sorry, I mean this code
shouldAddTopSafeAreaPadding = Platform.OS === 'ios';

@Santhosh-Sellavel

Price doubled! Get those proposals in 📣

@Santhosh-Sellavel Hi, any feedback for my proposal https://github.com/Expensify/App/issues/8115#issuecomment-1086152772?

Sorry @mollfpr, this change is fine https://github.com/Expensify/App/issues/8115#issuecomment-1092301401
But I am not on board with this https://github.com/Expensify/App/issues/8115#issuecomment-1085535267

Kadie and I are both OOO for the next 2 weeks so re-assigning to keep this moving!

Not overdue Melvin

Proposal
Get the container height from the initial view, in this way we able to get the available height of view container either from viewing the image or adding a image attachment with button action.
https://github.com/Expensify/App/blob/ad637d3dd7dbb03cfdc6ebcb9196944c4f6165bb/src/components/ImageView/index.native.js#L126-L137
+                    onLayout={(event) => {
+                        const layout = event.nativeEvent.layout;
+                        this.setState({
+                            containerHeight: layout.height,
+                        });
+                    }}

https://github.com/Expensify/App/blob/ad637d3dd7dbb03cfdc6ebcb9196944c4f6165bb/src/components/ImageView/index.native.js#L75
-            const containerHeight = Math.round(this.props.windowHeight - variables.contentHeaderHeight);
+            const containerHeight = this.state.containerHeight;

For extra space on header modal on Android will be fix with this proposal https://github.com/Expensify/App/issues/8115#issuecomment-1086152772
Result
iOS
https://user-images.githubusercontent.com/25520267/165134245-d9f2770d-96b6-472a-b10b-d623048c5020.mov
Android
https://user-images.githubusercontent.com/25520267/165134317-c0a3d65e-06fd-4882-a451-6a6ef750c932.mov
https://user-images.githubusercontent.com/25520267/165134367-91e644cc-7093-4dca-9aaf-8a6033e518c1.mov

Thanks, @mollfpr
Will review this tomorrow!
cc: @AndrewGable

@AndrewGable
@mollfpr Proposal looks good to me.
🎀 👀 🎀 C+ reviewed

Asking @thienlnam about this issue because I thought we had some more overall plan for these type of issues.

Ok good to go 👍

@AndrewGable @thienlnam Just curious, is I eligible for the pay for solving this https://github.com/Expensify/App/issues/8363 issue? 😅
Since it’s different with my proposal here https://github.com/Expensify/App/issues/8115#issuecomment-1108799245 for solving the initial issue, and here https://github.com/Expensify/App/issues/8115#issuecomment-1086152772 for solving the a gap on Android.

@AndrewGable @thienlnam Just curious, is I eligible for the pay for solving this #8363 issue? 😅
Since it’s different with my proposal here #8115 (comment) for solving the initial issue, and here #8115 (comment) for solving the gap on Android.

I'm afraid not since it's well within the scope of the same issue! If then I would get an additional C+ too 😅 ?
As far as I can see the only thing that's maybe eligible is reporting bonus for #8363 Reporter.

@jboniface - Mind taking a look into that?

@AndrewGable @Santhosh-Sellavel @mollfpr it looks like #8363 was closed as duplicate. I don't think it makes sense to pay for it.

Thanks, @jboniface Can you set up a job for this one or send invites. I can't find the Upwork link for this one. Thanks!

yep, it must have expired https://www.upwork.com/jobs/~017240c85f844e057f

Thanks, @jboniface Applied!

Hired @Santhosh-Sellavel and @mollfpr for $1000 each, please accept and confirm here then I'll pay tomorrow
https://www.upwork.com/jobs/~017240c85f844e057f

Done,
@mallenexpensify Thanks!

@mallenexpensify applied!

Issue not reproducible during KI retests. (First week)

@Santhosh-Sellavel and @mollfpr paid $1k/each (note to self.. @mollfpr 's contract was set as milestone (likely by mistake by me) in case it looks different)


--owner name dave seems odd

Describe the feature
Adding name/email to groups has a bit of an odd syntax today: --owner name dave to assign the name dave. Is this following some CLI convention?
My initial feel is that --owner-name dave or --owner "name:dave" would seem more appropriate, but I might be wrong 😄

i agree the name dave is odd


Added more granular instrumentation to bdg-utils.

Migrates @nfergu's metrics work from https://github.com/bigdatagenomics/adam/pull/514 to BDG utils.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-utils-prb/21/
Test PASSed.

@fnothaft @nfergu This is great stuff ! Just as another Spark App writer, is there any quick start documentation on how to use this ?

@shivaram ah! Good Q! I don't think there is right now, but we can add that!

Thanks, @nfergu, for writing the code and @fnothaft for shepherding it into bdg-utils. Outstanding contribution.

@shivaram - good point re. the documentation. Now that this is in bdg-utils I will add some to the readme. In the mean time you can find some basic docs in the MetricsContext class.

@shivaram - I've added some documentation here: https://github.com/bigdatagenomics/bdg-utils (see the Instrumentation section)


Clean and update dependency

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (11af648) to head (cd80023).
Report is 12 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         5    +1
  Lines           44        50    +6
=========================================
+ Hits            44        50    +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to set the window size...I'm a novice

Please Google "Selenium set window size". This will tell you how to do this for a "web driver". To get Helium's web driver, you can use get_driver(). If you want to set the window size when starting the browser (instead of when it already runs), you may find this interesting.
For further questions, please ask on StackOverflow.

Thank you for your reply, I have got it.


Get capo, tuning, and key

Thanks for writing this scraper!  I think it would be nice to get the capo, tuning, and key from the tab meta data.  I looked in the JSON response and noticed these are easily accessible.

Thanks! I would be a great idea!

Done and available in<EMAIL_ADDRESS>🎉 Thank you again @hougrammer !


Adding variables

Currently Bilobe does not support variables. Adding variables would improve the usability of this language and will allow users to create more complex programs. My thoughts on the syntax for creating a variable could look like this:
let variable123

Once the variable variable123 has been created, it could be assigned via:
variable123 = "hello world!"

Variables can then be placed into functions like lnp:
lnp(variable123)

Would really like to see this feature!!
Thanks!

Started with that...
I thought Bilobe to be unique... So the variable declaration will be like this: so car = 103

No problem - My comment was an example :) "so" looks good.

Yea, but might take time to come out... Because I alone need to think of the way it needs to go

Any updates?

Nothing much.... A bug fix made.... Working on variables


unused_variables: SELECTION-SCREEN TABs

REPORT zfoobar.
SELECTION-SCREEN BEGIN OF SCREEN 100 AS SUBSCREEN.
PARAMETER p_input TYPE c.
SELECTION-SCREEN END OF SCREEN 100.
SELECTION-SCREEN:
  BEGIN OF TABBED BLOCK scr_tab FOR 10 LINES,
    TAB (10) scr_tab1 USER-COMMAND scr_push1 DEFAULT SCREEN 100,
  END OF BLOCK scr_tab.
p_input = 'X'.

would this not typically also have some code to control the tab?
like
SELECTION-SCREEN BEGIN OF SCREEN 100 AS SUBSCREEN.
PARAMETERS p_input TYPE c.
SELECTION-SCREEN END OF SCREEN 100.

SELECTION-SCREEN:
  BEGIN OF TABBED BLOCK scr_tab FOR 10 LINES,
    TAB (10) scr_tab1 USER-COMMAND scr_push1 DEFAULT SCREEN 100,
  END OF BLOCK scr_tab.
p_input = 'X'.

INITIALIZATION.
  scr_tab1 = 'Hello'.
  scr_tab-prog = sy-repid.
  scr_tab-dynnr = 100.
  scr_tab-activetab = 'PUSH1'.

For me "unused" means that you can remove the variable, which is not possible in either case.
You are right that TAB is most likely used to put a text/icon. But TABBED BLOCK is only necessary if you want to switch tabs via code.

hmm, yea, good point

@mbtools try again, latest version

👍


⚠ Visual-Crew_Builder has degraded performance

In 061f706, Visual-Crew_Builder (https://visual-crew-builder.ai) experienced degraded performance:

HTTP code: 200
Response time: 2673 ms

Resolved: Visual-Crew_Builder performance has improved in 27b8527 after 8 minutes.


RTL not working in gmail

(This issue might also exist in services other than gmail)
When rendering an email with dir: 'rtl', the email is not displayed correct in gmail.
I solved this by adding "direction: ${dir}" to the  tag's style.

Thanks for the report. What tag are you referring to?

Sorry, I was referring to the  tag.

Just tested on gmail, and it seems like that's indeed the case. Will submit a fix for this soon.


Validate fails with commit hash

When I use this manifest the vcs validate command is successful
repositories:
  vcstool:
    type: git
    url: https://github.com/MaxandreOgeret/vcstool2.git
    version: master

However, when I replace 'master' with a commit-hash: the vcs validate command fails.
=== vcstool (git) ===
Invocation of command 'validate' on client 'git' failed: UnboundLocalError: local variable 'version_type' referenced before assignment (

I noticed that there is also a ticket for this in the origina vcs tool from Dirk Thomas.
By the way: the vcs import command works as expected.

Hey ! Thanks for your issue and sorry for the delay, Ill look into it.


Update index.md patch-2

Fixes #21879
Internal review URL

@HaoK  3 minute review please

Oops sorry I missed this @Rick-Anderson  looks great!


Is there any way to focus the panel content?

Hello!
First of all, thanks for the lib!
I am trying to focus on the content of a Panel (we are opening the panel from a sidebar).
When clicking on a sidebar item, the panel does not get focused.
I would appreciate it if you could provide some information about the focus provided by the API or another approach I should consider to be able to focus on the content of a panel when the panel is active.
Codesandbox
To check what element is active dynamically:

Open the Console.
Click the Create live expression button (it looks like an eye icon).
In the text box that appears, type document.activeElement.
Now click/tab around the page and see the live expression update to reflect which element is currently focused.

Thanks!

@mathuo  thanks for your work!
Just a note, I have being using the onDidActiveChange event. I found an issue, when having a couple of panels in a group, when moving one panel to another group, the event on the listener gives you the wrong active panel.
Here is a codesanbox, Panel 2 is active, if you move Panel 2 out of the group, the Panel 1 event listener says that the panel 1 is active for a bit before setting it to false.

v1.10.0 has a few substancial changes around how events are fired and how things are made "active" and focused.
Hopefully this demo is useful in understanding the events https://dockview.dev/demo/
Do let me know if things are still not covered as expected though.

@mathuo the updated fixed the issue regards moving the groups thanks!!!
But the focus method on panel (like mentioned on the first message here) still does not seems to be do what it says (focus the panel), is this intentional?


Add grpc_retry_test

Signed-off-by: Leonid Lygin<EMAIL_ADDRESS>

Description of the Change
This adds a test for gRPC retries.

Benefits
Now this functionality is tested

Possible Drawbacks
These two tests require 70s to run on my machine. Maybe it is somehow possible to override the timeouts, so that the functionality can be tested with fewer time

Usage Examples or Tests [optional]

Alternate Designs [optional]

JIRA issue
https://jira.hyperledger.org/browse/IR-586

These two tests require 70s to run on my machine.

Ready for a re-review, removed the SCOPED_TRACEs, added a custom error message, and re-formatted parts where clang-format CI job wasn't happy

@MBoldyrev UNAVAILABLE was added to the list in order to fix a weird synchronisation bug when a network only has two nodes (https://jira.hyperledger.org/browse/IR-586)

@MBoldyrev UNAVAILABLE was added to the list in order to fix a weird synchronisation bug when a network only has two nodes (https://jira.hyperledger.org/browse/IR-586)

It is not directly related to this PR IIUYR. And it appears not a trivial change, because simply adding it to the list of retryable statuses increases the time taken by integration tests a lot. So I'd better add the test in this PR, and addressed the new status retrying in another (which I'm already working on).


Swift's 5 Result type

Hi,
I'm huge fan of the project. It is really well done and using it is a breeze.
Today, Apple released Xcode 10.2 with Swift 5 and now we have Result type built into the language. How do you think it influences the project? Should it replace Interstellar's Result type or would you like to keep them both by conforming to ResultType protocol?

I already created a pr for it at #74
it needs a bit more work though

@JensRavens Will you be working on it later ?

My current state is more or less that this will probably never be merged. For swift 5 there's the way better alternative of just using the new native producers - they're more performant and more flexible.
If you need this though, feel free to take over and do a PR.

Hello @JensRavens I'm interested by this but I don't know what the "new native producers" you're referring to are. Could you tell me what they are, and how they make it unnecessary to use the built in Result type?
Thank you

Swift 5 has the combine framework which can do anything Interstellar can do. So it’s not a replacement for result but for the whole framework.


[BUG] tab org-cycle appears no longer bound/working in org-journal Journal mode

Describe the bug
On visiting my org-journal file, tab no longer seems to open or close headings a la org-cycle.
To Reproduce
2 things about my journal flie:

It is yearly
It is encrypted (so org.gpg extension)

Visit file normally via org-journal-new-entry (bound to CMD-j in my system), selecting the journal file in Deft, or byopening the file normally. For some reason, the org-cycle, tab binding which worked until very recently does not work. Tab to org-cycle headings works fine in normal (non-journal) org-mode files fine.
nb: C-c C-f and C-c C-b for opening forward and previous entries does work - sp there is a workaround.).
Expected behavior
Tab on a headline should org-cycle headings. At the moment it merely does nothing (a particular problem if the journal flie opens up completely folded by date)
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: OSX 12.3.1
Emacs Version 29.0.50  (installed via homebrew dfrosted)
Mac is M1 chipped

Your Emacs Configuration
The part relevant to org-journal.

;; Org Journal config
(use-package org-journal
  :straight t
  :defer t
  :custom
  (org-journal-dir "~/Library/Mobile Documents/iCloud~com~appsonthemove~beorg/Documents/org/journal")
  (org-journal-file-type 'yearly)
  ; (org-extend-today-until 01)
  (org-journal-file-format "journal-%Y.org")
  (org-journal-date-format "%Y-%m-%d %a")
  (org-journal-created-property-timestamp-format "%Y-%m-%d")
  (org-journal-encrypt-journal t)
  (org-journal-enable-cache t)
  (org-journal-carryover-items nil))

Does it work if you open your journal file in org-mode instead of org-journal-mode?

Strangely, if I open the file via Deft (even in Journal mode), it works fine. The issue seems to be with it opening via the org-journal-new-entry command (which I have keymapped to M-j).
Switching the file to org mode when it is not working makes it work (as does then flipping it back to org-journal-mode).
Why it's not working after the new entry command is issued has me a bit stumped. (I did a recent straight-pull-all so imagine it updated from a much earlier version of the package then.).

As far as I know, we aren't doing anything with the tab key. No idea what's happening here, honestly.

Oh, I believe you. Bit stumped myself, as all I can think of it's some weird change made in org-mode or perhaps the origami plugin I use for ledger and uses outline mode is somehow interfering with things. Will poke around a bit more. Like I said, the strangest thing is it only seems to affect the file when I trigger it via the new journal entry command, which is... strange... =]

Do let me know what you find out! Poking at org-journal's internals is always interesting.

I've found that if I'm in org-journal-mode and run outline-hide-sublevels then the issue presents itself. Not sure why that causes an issue to be honest, but wanted to provide some details that might be helpful.

I'm having the same issue.
Changing the org-journal-time-prefix to an empty string with:
(setq org-journal-time-prefix "- "
Stops it from happening for me.
However, doing this leads to another bug where my TODOs from the previous day wont get carried over and I get an error that says: "wrong-type-argument number-or-marker-p nil"
The same as this issue: https://github.com/bastibe/org-journal/issues/65

Hi. I had the exact same issue. But it seems to be fixed after I set org-fold-core-style to overlays instead of the default text-properties, so (setq org-fold-core-style 'overlays). Just for context, and maybe to further look into the issue, the reason I made this change is actually because of an issue I had with the consult package and I followed a solution from https://github.com/minad/consult/issues/563. Maybe this helps.

I'm having the same problem. I have isolated the symptom:

It only happens after executing org-journal-new-entry
And  (org-cycle) will not work for all the journal entries but the last one (newly created journal entry)
Perform M-x org-journal-mode will remove the problem
I have org-journal-time-prefix set to "** "
org-fold-core-style to 'text-properties

Yes, setting org-fold-core-style to 'overlays and re-execute M-x org-journal-mode, and adding another journal entry,
I still can org-cycle the other entries' visibility. The problem is solved with the fix.


Add volunteer and elderly befriendee contacts

As a voluntary organisation manager, I can add volunteer and elderly befriendee contacts.

Add classification of two different types of persons
Add commands to add each type

#32
#34


Add example for evaluation DMOs that are already aggregated (e.g., per day)

Please consider also using the Discussion tab for general questions or ideas, in particular if they are not linked to the development, but rather scientific questions/discussions.
Describe the issue
A clear and concise description of what the issue is.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

change naming from gait sequences to WB in text and variables, explain how both evaluation approaches from WBA paper would be implemented

I already adapted the naming and some of the structure. What is missing, is the part of the example that shows the "aggregate then error" approach. For this we should probably move the detailed explanations on how the error calculation works up into the new part (or have a completely seperate section that explain the details?). Whatever you think is best to keep everything readable


Is it possible to run an IFrame?

Is it possible to run an IFrame using this library?

Can you elaborate more?


python 3 print fix

Hi there,
I added parentheses to make PySceneDetect (more) compatible with Python 3.
Cheers,
tpltnt

Hi @tpltnt thanks for the fix.  Note that the code you modified is for the experimental GUI and still under development, so this will be moved to a separate branch in the future (until it's completed).
Thanks again for the pull request, and your interest in the project.


Create automated test runner

This will run to make sure that the pull requests are building successfully.

@syahnur197 FYI


[Feature Request] camera enhancement: Smooth Skin

add Smooth Skin.
Smooth Skin. It is needed!
No Smooth Skin, People can only use closed source and violations of user privacy Camera App
Like the B612 camera, Beauty Skin.

There's a Face Retouch mode when the device supports that CameraX extension. We aren't going to implement our own. Pixels currently only have the Night extension, but Galaxy phones have HDR, Night, Portrait, Face Retouch and Auto.

https://github.com/FossifyOrg/Camera/assets/42504385/9324cd07-e0b7-47e6-ba48-c1ce65c4f0a7.MP4


feat: add ChainInfo singleton state variable in authority

Description
Initialize a new ChainInfo state variable in the authority store to allow dynamically adding new chain info without upgrade
Closes: https://github.com/zeta-chain/node/issues/2270

E2E tests fail in the CI but pass locally on my machine 🤔


ZeroDivisionError: integer division or modulo by zero

Dear Luis,
Thank you for making this code publicly available.
I do encounter an error while trying to train on the CEDAR dataset though, perhaps you could help me?
The error looks like this:

The script I use to start training looks like this:
python3.7 -m  sigver.featurelearning.train \
    --dataset cedar \
    --model signet \
    --dataset-path  /data/signature_matching/data/processed/sigver_datasets/cedar.npz \
    --users 10 20 \
    --epochs 2 \
    --logdir /tmp/signet

The cedar.npz dataset has been preprocessed as has been indicated in the README.
Hope you can help me with this.

Dear Luis,
Thank you for making this code publicly available. I do encounter an error while trying to train on the CEDAR dataset though, perhaps you could help me?
The error looks like this:
The script I use to start training looks like this:
python3.7 -m  sigver.featurelearning.train \
    --dataset cedar \
    --model signet \
    --dataset-path  /data/signature_matching/data/processed/sigver_datasets/cedar.npz \
    --users 10 20 \
    --epochs 2 \
    --logdir /tmp/signet

The cedar.npz dataset has been preprocessed as has been indicated in the README.
Hope you can help me with this.

@MuadDev @luizgh Are there any changes for train.py in feature learning for cedar dataset?
I'm also facing the same issue while working with this

The problem seems to be the combination of the parameters "epochs" and "lr_decay_times" (this one defaults to 3).
For this project, I used a step decay for the learning rate (like the original resnet papers), with a default of 3 decays. So if you train with, say 60 epochs, it would decay at 20, 40 and 60. The problem here is that you are asking to train for 2 epochs, and using the default of 3 decays, which won't work: this line: In line https://github.com/luizgh/sigver/blob/master/sigver/featurelearning/train.py#L71, will tell the scheduler to change the learning rate each 0 epochs, which won't work.
So your options are: 1) increasing the number of epochs; 2) Decreasing "lr_decay_times", 3) Changing the learning rate scheduler (nowadays I use cosine annealing for my projects: https://pytorch.org/docs/stable/generated/torch.optim.lr_scheduler.CosineAnnealingLR.html)

It is very kind of you to reply for our doubt.
I proceeded like wise and i got the output.
Can i ask for one help sir, i was unable to get GPDS image Dataset, Is
there any chance that you are having that dataset.
Thank you so much sir
On Wed, 23 Mar, 2022, 6:04 pm Luiz Gustavo Hafemann, <
@.***> wrote:

The problem seems to be the combination of the parameters "epochs" and
"lr_decay_times" (this one defaults to 3).
For this project, I used a step decay for the learning rate (like the
original resnet papers), with a default of 3 decays. So if you train with,
say 60 epochs, it would decay at 20, 40 and 60. The problem here is that
you are asking to train for 2 epochs, and using the default of 3 decays,
which won't work: this line: In line
https://github.com/luizgh/sigver/blob/master/sigver/featurelearning/train.py#L71,
will tell the scheduler to change the learning rate each 0 epochs, which
won't work.
So your options are: 1) increasing the number of epochs; 2) Decreasing
"lr_decay_times", 3) Changing the learning rate scheduler (nowadays I use
cosine annealing for my projects:
https://pytorch.org/docs/stable/generated/torch.optim.lr_scheduler.CosineAnnealingLR.html
)
—
Reply to this email directly, view it on GitHub
https://github.com/luizgh/sigver/issues/21#issuecomment-1076324380, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANQXM4UDVRJES22LPGEZ6XDVBMFTVANCNFSM4Y6G4ZPA
.
You are receiving this because you commented.Message ID:
@.***>


Broken Links

Hi Wes & Scott,
Thanks for the great podcast.
I'm a web dev student and really enjoy your show.
I found a couple of broken links on ep. 140.
It seems like both of them are missing 'https://' in the url.
Please refer to the screenshot below.

once again, thanks for the great podcast and your contributions.

This has been a consistent issue, so you all would probably wanna know about this: @wesbos, @stolinski (@avclark?)
There are a few pending PRs fixing individual episodes.

@wesbos this is fixed on our end. i just submitted a PR with some fixes.

If you wanna accept the fixes that were already submitted:
Episode 140: #331
Episode 142: #339
Episode 146: #349
Episode 150: #354 (duplicates: #355, #356, #357)
#360 takes care of episodes 148 & 152. (144 apparently didn't have a problem)


Fatranslation update in index.rst

Signed-off-by: EmSad<EMAIL_ADDRESS>

Hi - could you please rebase and just check in the files that need changed?

Hi - Sure, thanks.


Move kind related blocks under group in sprites

We have various blocks related to kind that are scattered accross multiple toolbox (sprites, arrays, ...). Group them under "kind" in sprites.

Only moving the get all kind in array category.

@riknoll @Jaqster can we do this for this release? the "array of sprites of kind" block is pretty unintuitive to locate currently:

we can leave the arrays category as-is but also have the reporter block available under sprites, which would match the tilemap array block ("get array of all tile locations"):

@riknoll @Jaqster can we do this for this release? the "array of sprites of kind" block is pretty unintuitive to locate currently:

we can leave the arrays category as-is but also have the reporter block available under sprites, which would match the tilemap array block ("get array of all tile locations"):

Yes! Super useful block that no one knows about. I have no idea why we put it there.

Yes! Super useful block that no one knows about. I have no idea why we put it there.

Sounds good to me.

Sounds good to me.

I could see an argument for putting both blocks in Arrays and coloring them yellow (they are array types).
But I'm also okay if we want to keep them in their respective categories to make it more discoverable for users.

I could see an argument for putting both blocks in Arrays and coloring them yellow (they are array types).
But I'm also okay if we want to keep them in their respective categories to make it more discoverable for users.

If we want to put the "array of sprites of kind" reporter block into Sprites, then I think we should remove the "set sprite list to array of sprites of kind" statement block from the Arrays category.

If we want to put the "array of sprites of kind" reporter block into Sprites, then I think we should remove the "set sprite list to array of sprites of kind" statement block from the Arrays category.


Opencv3 compilation issue with C API

Please state the information for your system

OpenCV version: 3.1 and also dev version
Host OS: Linux (Ubuntu 16.04-64 bits)
Compiler & CMake: GCC 5.3.1 & CMake 3.5.1

In which part of the OpenCV library you got the issue?
C-API
Expected behaviour
Correct compilation
Actual behaviour
Compilation error:
/tmp/ccDODlVK.o: In function `cvPointFrom32f':
main.c:(.text+0x54d): undefined reference to `cvRound'
main.c:(.text+0x563): undefined reference to `cvRound'
/tmp/ccDODlVK.o: In function `cvReadInt':
main.c:(.text+0xe68): undefined reference to `cvRound'
/tmp/ccDODlVK.o: In function `cvEllipseBox':
main.c:(.text+0x10d4): undefined reference to `cvRound'
main.c:(.text+0x10f6): undefined reference to `cvRound'
collect2: error: ld returned 1 exit status

Code example to reproduce the issue / Steps to reproduce the issue
Please try to give a full example which will compile as is.
#include "opencv/cv.h"
int main()
{
    return 0;
}

Compilation line:
gcc -Wall main.c -o main -I/usr/local/include/opencv -I/usr/local/include -L/usr/local/lib  -lopencv_imgproc -lopencv_core -lm

OpenCV is a C++ library now and actively uses C++ features, like exceptions and so on.
Direct support for C compilers has been dropped some years ago, so you should not create C applications using OpenCV.
"C-API" is not supported and should be removed totally (but we have a lack of resources to port this legacy C code to C++, so some of this code still exists right now). Also huge part of fresh OpenCV functionality is missing in "C-API".
There is no plan to fix this in OpenCV directly.
If you want to use OpenCV from C application code you need to find some implementation of C bindings which wraps OpenCV C++ functionality (al least these bindings should catch exceptions and return exit codes for user application).

I had the same problem trying to use someone else code from OpenCV 2.4.
I ended up just installing OpenCV 2.4, and using that.


Extract configuration

With this PR I'm saving all the configurations on a specific global struct, rather than in a lot of separate variables.
Next step is to split the WiFi setup from the configuration step, so that we can tackle issues like: https://github.com/esprfid/esp-rfid/issues/439 https://github.com/esprfid/esp-rfid/issues/437 https://github.com/esprfid/esp-rfid/issues/319 https://github.com/esprfid/esp-rfid/issues/251 by managing WiFi setup/disconnect/reconnect in a separate place.
Also while cleaning up (just a little bit) I've removed stuff that wasn't used anywhere and ordered everything in alphabetical order. It's always tricky to decide how to order variables, but the alphabetical seems the easiest to understand for other people and not messing too much when changing stuff :)

Nicely done

9


why is it deprecated?

Is there a replacement for rehoo. Does hoogle support the functionality now?
Update: It looks like hoogle 5 isn’t able to combine .hoo databases. Hrm.

I think Hoogle 5 needs some work still to support the same use cases as Hoogle 4.  For now, Nix has regressed back to 4 because of this, for example.

Yes, I was the one that made the change. :)
But it looks like the guys fixed it by patching hoogle so it can create one binary file from multiple inputs, rendering the binary concatenation unnecessary.

@Profpatsch Ah, thanks for that!  I'm now using your change in my DockerHub image that provides a fully-loaded local Hoogle.
I'll be glad when I can abandon this project, and cross one more thing off the todo list. :)


Use default bounding box for FullGridCellList

As suggested in https://github.com/trixi-framework/TrixiParticles.jl/pull/660 by @svchb, it would be more convenient if the minimum and maximum coordinates of the semidiscretization would automatically be used for the bounding box.
Here, we want to create a cell list template without a bounding box, and the semidiscretization should set the bounding box when copying the NHS.
cell_list = TrixiParticles.PointNeighbors.FullGridCellList()
semi = Semidiscretization(fluid_system, boundary_system,
                          neighborhood_search=GridNeighborhoodSearch{2}(; cell_list))

Here, we want to use a larger bounding box, so the semidiscretization should not overwrite an existing bounding box of the cell list.
cell_list = TrixiParticles.PointNeighbors.FullGridCellList(; min_corner, max_corner)
semi = Semidiscretization(fluid_system, boundary_system,
                          neighborhood_search=GridNeighborhoodSearch{2}(; cell_list))

That would make the copy_neighborhood_search API awkward.
copy_neighborhood_search(min_corner=..., max_corner=...)

would only use min_corner and max_corner to set the bounding box when there is none in the template.
When the cell list already has a bounding box, these arguments would have to be ignored, or the second snippet above would not work. This sounds like a bad API to me.

Well I would suggest rather modifying this:
semi = Semidiscretization(fluid_system, boundary_system, data_type=CuArray)
function Semidiscretization(systems...; neighborhood_search=NeighborhoodSeach(data_type), data_type=nothing)

So it defaults to FullGridCellList with the default bounding_box when data_type=CuArray is set.
In case a non default bounding box needs to be set
nhs = NeighborhoodSearch(data_type=CuArray, min_corner, max_corner)
semi = Semidiscretization(fluid_system, boundary_system, data_type=CuArray)

or the option to use it like it is now.
That would allow switching between GPU/CPU with just modifying data_type in examples since the boundary box can still be provided and then be ignored for neighborhood search that don't require them.

Good idea, but I don't like the fact that a different data type would silently change the underlying NHS implementation, which could be confusing, especially for performance comparisons. @LasNikas what do you think?
Note that this is supposed to be more or less temporary, as we want to have a GPU-compatible NHS with unbounded domain in the future. But it will probably not happen soon.

Also note that FullGridCellList is slightly faster on CPUs as well, and the fully parallel update is significantly faster on a lot of threads.

See our statement of need so we basically want competing things but in the end this means to me we want to have:

a high-level API which hides unnecessary implementation details for new users
an API flexible enough to set-up most details without touching the source code


[Feature] Consider adding some sort of progress bar

Consider adding some sort of progress bar or indicator that the containers are being synced/are synced.

Hi,
This is done in version 1.1.0


groupBy (permanently?) enters a broken state when used as transducer

While groupBy is one of the Ramda functions documented as being usable as a transducer, and I believe this worked years ago when I last tried it, now it appears to pass through every item into every group list. After this, every subsequent use of groupBy (as a transducer or otherwise) will be cloned as the starting accumulator for each group.
I'm guessing there was an update to reduceBy at some point that broke the arity to cause this but haven't quite gone through all the layers of indirection to narrow it down.
Repro
const {groupBy, into, range} = require('ramda');

const evenOdd = x => x % 2  === 0 ? 'even' : 'odd';
// this works fine.. if done *first*
groupBy(evenOdd, range(1, 10); // got expected {"odd":[1,3,5,7,9],"even":[2,4,6,8]}

into({}, groupBy(evenOdd), range(1, 10));
// expected: {"odd":[1,3,5,7,9],"even":[2,4,6,8]}
// actual: {"odd":[1,2,3,4,5,6,7,8,9],"even":[1,2,3,4,5,6,7,8,9]}

// It appears to simply pass through all values for each key returned by the group function. After this, any
// subsequent use by `groupBy`, even in the non-transducer form, appends the results to of the previous list:

groupBy(x => String(x.length), ['a', 'ab', 'abc']);
// expected {"1":["a"],"2":["ab"],"3":["abc"]
// actual: '{"1":[1,2,3,4,5,6,7,8,9,"a"],"2":[1,2,3,4,5,6,7,8,9,"ab"],"3":[1,2,3,4,5,6,7,8,9,"abc"]}'

comparing countBy
const evenOdd = x => x % 2 === 0 ? 'even' : 'odd';
R.into({}, R.countBy(evenOdd), R.range(1, 10)); // { odd: 5, even: 4 }

Update: just tried the same against 0.27.2 and it worked as expected, so this can at least be narrowed down to a bug introduced in 0.28.x. Thanks!

Thank you for this detailed report.

@customcommander  Sure thing. Mostly because I couldn't leave it well enough alone, I poked at it a bit more and noticed that reverting the most recent commit to that module fixes the issue; I went ahead and submitted a PR that does so as well as throws in a new test case.
If you'd rather fix it on the reduceBy side, feel free to close the PR; I just figured since I did the digging I might as well save someone else the busywork of doing the quickfix.

Damn, do I want to stop supporting transducers altogether.  The code complexity is much higher than it would otherwise be because of them.

@CrossEye Aw, I love the transducer support! Though you're not wrong that the internal implementations can be.. a bit mindbinding in JS (moreso than the clojure equivalents, even), so I totally see where you're coming from.
Though, to play devil's advocate for a sec, at a glance it look like a lot of the complexity is coming from adding on the transducer support to things that are actually reducers, which is sort of doing a transform+reduce on top of what is already a reduce? I was tempted to bring this up earlier, but held off since it's a bit beyond the scope of the bug. But hey, why not while it's on my mind 😀 .
leaning into transducers
Since transducers are already transform + reduce, it might actually simplify Ramda over the current dispatcher/wrapper stuff to make transducers the core of the operators that support both usages; once you implement the transform, the normal, non-transducer equivalents are easily expressed in terms of a transducer.
For example, here's a groupBy  from one of my projects that uses a minimalist transducer library (I ripped out all the library-specific util functions so I may have added a bug somewhere):
function groupByXF(keyFn) {
  return function groupByTransformer(xform) {
    return {
      keyFn,
      xform,
      groups: new Map(),
      '@@transducer/init'() { return this.xform['@@transducer/init'](); },
      '@@transducer/step'(value, input) {
        const key = this.keyFn(input);
        if (this.groups.has(key)) {
          this.groups.get(key).push(input);
        } else {
          this.groups.set(key, [input]);
        }
        return value;
      },
      '@@transducer/result'(value) {
        for (const groupEntry of this.groups.entries()) {
          value = this.xform['@@transducer/step'](value, groupEntry);
          if (value && value['@@transducer/reduced']) {
            value = value['@@transducer/value'];
            break;
          }
        }
        return this.xform['@@transducer/result'](value);
      }
    };
  };
}

export function groupBy(keyFn, col) {
  if (arguments.length > 1) {
     // you can optimize a bit more than this by overriding the step/result functions instead of passing to into,
    // which would skip the final "copy the groups to the object", but I apparently didn't bother when I wrote this!
    return into({}, groupByXF(keyFn), col);
  } else {
    return groupByXF(keyFn);
  }
};

That's the whole thing! Which allows stuff like
groupBy(x => `length ${x.length}`, ['a', 'ab', 'abc']);
// => { 'length 1': [ 'a' ], 'length 2': [ 'ab' ], 'length 3': [ 'abc' ] }

into([], compose(groupBy(x => x.length), take(2)), ['a', 'ab', 'abc']);
// => [ [ 1, [ 'a' ] ], [ 2, [ 'ab' ] ] ]

...that said, for reduce applications like groupBy, Ramda is already going even further than clojure does; despite being the origin of transducers as a thing, clojure's group-by is just reduce! It's literally
=> (source group-by)
(defn group-by
  "Returns a map of the elements of coll keyed by the result of
  f on each element. The value at each key will be a vector of the
  corresponding elements, in the order they appeared in coll."
  {:added "1.2"
   :static true}
  [f coll]
  (persistent!
   (reduce
    (fn [ret x]
      (let [k (f x)]
        (assoc! ret k (conj (get ret k []) x))))
    (transient {}) coll)))

So.. you could probably get away with that too? It can be kinda nice, though. For one thing, you don't necessarily need to coerce the key to a string if you aggregate the groups using a Map or similar...


App crashes when tapping on "Donate"

In the main settings page, a tap on "Donate" causes a crash and the app closes immediately.
Environment: Lumia 950 XL; Windows 10 mobile, Creators Update, no insider.

This is fixed here 9661c083c598e2a31d76702fe9061829005d6b61


Would Ravenbrrok MPS system work with Crystal?

I came across a talk with someone using boehm GC and added MPs to get compression and incremental collection.  Would a memory management system like MPS work with crystal and crystals C API?
Here is a link to the project. https://www.ravenbrook.com/project/mps/master/manual/html/guide/overview.html

I curious, which talk was that if you have a link?

https://youtu.be/8X69_42Mj-g


How to implement naive batch gradient descent ?

Hi, everyone. I have a question about the implement of gradient descent. I have found several optimizers, like ada_grad, adam, sgd and so on, they're perfect. But I'm attempting to implement the naive gradient method batch gradient descent that is with the fix learning rate and acts on the whole examples in each batch. How to do it? Wait for your help. Thanks very much.

Thank you for posting a question!
However, GitHub issues are for bug reports / feature requests.
Please consider asking in StackOverflow (with chainer tag).
We actively monitor it, and many others can help, too.

Tks. I've posted the question on the StackOverflow, wait for your help.

Thank you!


Automatically delete old data

This PR allows users to specify a cutoff date after which old data will be thrown out in order to keep things performant/avoid accumulating too much data. This feature is disabled by default.
I tested this on CDH 5.3 with MapReduce 2.5.0 and Spark 1.5.2.
@krishnap

Don't need to use raw SQL. Ebean has cascading delete if all table has a one column primary key.

Also, the build seems to be failing because the sql statements should be compatible across Mysql and H2.
We should maintain two versions of sql evolutions. One for testing(h2) and the other for development(mysql). Take a look at this patch for how I tried to separate them.
https://github.com/linkedin/dr-elephant/pull/84/commits/81446c48b7ddcf8c91b8d00a6cd3f6c67c129965
I created two subfolders under evolutions, one for mysql and another for h2 and placed respective evolutions under them. Then in the compile script, I made sure we use h2 for testing and include  mysql evolution in the zip package.

Isn't this better achieved through administrative policies in mysql ?

@stiga-huang yes it has a cascading delete but does it have a batch delete? I haven't been able to find one. All suggestions I've seen recommend raw SQL for batch operations.

@shankar37 what exactly did you have in mind?

We haven;t set it up yet but our DBA said he can set up purging of old
records as a maintenance task in the mysql DB itself. I can get more
details if you are interested.
On Tue, Jul 26, 2016 at 6:01 AM, Paul Bramsen<EMAIL_ADDRESS>wrote:

@shankar37 https://github.com/shankar37 what exactly did you have in
mind?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/dr-elephant/pull/112#issuecomment-235127862,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMlRI6k8kFDXTtK1U4P4-KYqIzLXcREOks5qZVVFgaJpZM4JTPHj
.

@paulbramsen
Yep, but since the delete method is inside the loop, each batch will just contains few results. I prefer to make things simple.
However, the real obstacle is that the primary key of table yarn_app_heuristic_result_details consists of two columns. To utilize Ebean's cascading delete, we need to add a single column, e.g. auto increase id, as primary key for this table. Evolution may not be able to do this.


VTS L1 Enhancement - Header file 3.0.0 updates - Device Setting - CompositeIn

This task is to consider the latest header file updates and consider if there are any changes in L1 concerning the newest header files available at tag 3.0.0

There are no changes in L1 concerning the newest header files available at tag 3.0.0


Add traffic endpoints.

Add endpoints from the traffic API.

@phadej, thanks for the quick feedback. I think I've addressed everything as requested. Let me know what you want me to change the example repo to if you want it changed.

@phadej I believe I've addressed the outstanding feedback. Let me know if I haven't.

@mergifyio rebase