[Windows] [V-Sync] [Nvidia] Very bad flickering and spasms in fullscreen mode (Update)

When using "gamer settings" for V-Sync on nVidia Hardware on Windows 10...
...Visual Code will flicker and spasm like crazy in fullscreen mode. Heaving many blocks all over the place blinking 10+ times per seconds. VS Code looks like having a seizure then.
I could pinpoint the problem down to why I have this issue on my home computer only. It's because I'm playing games there, too, and have the 3D settings optimized for it (see below).
(It could be difficult to visually capture the symptoms correctly, but I am assuming it shouldn't be too hard to find a VS Code developer with nVidia hardware of current, last, or last-last generation. I am experiencing this issue myself with a GeForce 970 GTX desktop GPU.)
PROBLEM CAUSE:
The problem is when  "Fast Sync"  is enabled as the default V-Sync setting in the nVidia driver settings.

(Background info:
There are two very distinct methods to displaying real-time graphics:

No sync, i.e. drawing as fast as you can -> this is the most lag-free way, but produces ugly "tearing" artifacts
Sync to monitor refresh, i.e. after drawing to a second framebuffer you wait until the monitor is in it's "v-sync" phase, then quickly switch the framebuffers around -> this has no "tearing" whatsoever, but introduces 1, 2, or even more frame(s) of input lag (as the game simulation could have drawn 3, 4, 5, ... more frames in that time, but is waiting for the monitor's "v-sync" phase instead))

"Fast Sync" is a technique Nvidia introduced in the last year or so to combine the advantages of both variants. It will draw "as fast as it can" into the second framebuffer continously, and then - in the monitor's "v-sync" phase - quickly switch the framebuffers so that the most current render gets displayed on the monitor.
The advantage is, that this introduces 1 frame lag at maximum, while still preventing the awful "tearing" artifacts one would get not waiting for the "v-sync" phase.
Quick guess: Because of this setting, VS Code renders far too many screen refreshes per frame and is supposed to max out at 60 fps or such.

VSCode Version: 1.29.1
OS Version: Windows 10 1809 October 2018

Steps to Reproduce:

Have an nVidia GPU from 2015+
Activate "Fast Sync" globally in nVidia settings
Toggle VS Code to fullscreen (F11)

WORKAROUND:
To the side of "Global Settings" there is another tab with "Progam Settings" where one could override the global settings for one particular application with a "profile".
You have to manually browse to "%LOCALAPPDATA%\Programs\Microsoft VS Code" and choose "Code.exe" as application, as this is not detected by the nVidia driver panel as "last used 3D application".
However, if you then override "Vertical sync" to "Use the 3D application setting" (or possible another), the issue goes away.
P.S.: I refrained from using VS Code in my preferred fullscreen mode for more than half a year now, because I only now detected the REAL culprit. :(((
P.P.S.: I couldn't even find any bug reports that looked like the issue I was experiencing.

We are building exploration builds that use a much newer version of Electron (our UI framework). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux: Download
Windows: Download

We are building exploration builds that use a much newer version of Electron (our UI framework). I wonder if this issue reproduces with one of these builds, could you try? Download:

Windows: Download

Subjectively perceived it flickers NOT THAT MUCH as the current VS Code version.
But it is still impossible to work with in fullscreen mode nonetheless.
I captured some footage with my cellular and converted it to a GIF to demonstrate the implications.
To fit into the 10MB limit of github it is downscaled to just 320px width - but I think you get the idea:

NOTE: The SPEED of flickering and popping up and disappearing again of UI elements (like the menu bar or context menus) is MUCH HIGHER than the GIF reveals!
As you cannot recognize my zoom-in to the about box at the end anymore, I just copied it (there was one update to your linked WINDOWS build ready that I installed beforehand these tests):
Version: 1.31.0-exploration (user setup)
Commit: 37818ac3597b4afda264b05226b0b77fb8e85f41
Date: 2018-12-13T07:43:53.389Z
Electron: 4.0.0-beta.9
Chrome: 69.0.3497.106
Node.js: 10.11.0
V8: 6.9.427.24-electron.0
OS: Windows_NT x64 10.0.17763

Just downloaded the Insider Build:
Version: 1.31.0-insider (user setup)
Commit: 2803a8655cf5e05066a4ee47cce303eefca6408c
Date: 2018-12-20T09:10:39.545Z
Electron: 3.0.10
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
-> SAME ISSUES 👎
P.S.: I don't understand why I'm supposed to test an even older Electron/Chrome version, as the issue even appears in 4.0.0-beta.9 / 69.0.3497.106 - see comment above.

It will probably go away if you run "code --disable-gpu" from the command line?

It will probably go away if you run "code --disable-gpu" from the command line?

Yes. 👍
Tested in Electron 3 (Insiders) and Electron 4 (Exploration).

/duplicate https://github.com/microsoft/vscode/issues/15211


Fix the hang issue in Travis CI build triggered by the [Feature] tag

Some class related parser tests may cause Travis build to hang if they are running with CrossGen'ed assemblies. This is an issue to the CrossGen utility, and it's tracked by https://github.com/dotnet/coreclr/issues/9745.
To work around the issue, we made the following changes to our build:

For pull request and push commit, build without '-CrossGen' and run the parsing tests
For daily build, build with '-CrossGen' but don't run the parsing tests

The recent [Feature] tag support allows us to run the full build in PR or Commit-Push CI builds. The parser tests should run in those [Feature] tag builds, so we need to make sure the [Feature] tag builds don't use -CrossGen before running the tests.
Two other changes:

Skip inheritance tests during daily build.
Update badge only in daily build.

The failures in AppVeyor are all *-PSSessionConfiguration related, not caused by this PR.


Investigate issue with Rate Limiting

The rate limiting logic has caused the healthchecks from EKS to cause a denial of service to all clients of the API. More investigation is needed, but it looks like we need two fixes:

Whitelist the IP address spaces of EKS so it doesn't get rate limited
Ensure that when rate limiting happens, only the problematic client gets rate limited, not all clients everywhere. The whole point of rate limiting is to prevent denial of service, not cause it 😅

Let's just not have a rate limit for /healthz, I think that would solve the operational issues

Alright, to remove rate limiting, it looks like we need to add @limiter.exempt to that particular endpoint. Then we need to figure out whether rate limiting applies to all clients and make that not the case


Helm chart for BOINC?

BOINC has Docker images for finding a COVID-19 vaccine (Rosetta@Home project).
https://hub.docker.com/u/boinc
Can we get a Helm chart for Kubernetes admins to deploy this more easily?

feel free to reach out to the BOINC community about this proposal. I'm sure they'd be interested.
transferred to helm/charts as this is a request for a new chart rather than a feature request for helm.


Updates and revisions to the oneAPI samples involving oneMKL DFT domain

Existing Sample Changes
Description
This pull request

updates Libraries/oneMKL/computed_tomography/computed_tomography.cpp according to the recommended usage for oneMKL DFT APIs, starting from oneMKL-2025.0;
modifies the content of Libraries/oneMKL/fourier_correlation

updating it to the recommended usage for oneMKL DFT SYCL APIs, starting from oneMKL-2025.0;
revising, correcting and generalizing the operations at play therein. The README file was updated accordingly and captures the essence of the changes suggested herein in more details.

No new dependency is introduced,
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
The samples were executed (as documented), on an Intel(R) Data Center GPU Max 1550 GPU machine. The typical output was updated in the README for the "Fourier correlation" samples.

@jimmytwei, please comment or merge it.

@raphael-egan Getting this compile error in computed_tomography. Can you take a look?
make icpx computed_tomography.cpp -fsycl -o computed_tomography -DMKL_ILP64  -qmkl=sequential -fsycl-device-code-split=per_kernel -lsycl -lOpenCL -lpthread -lm -ldl
computed_tomography.cpp:294:67: error: cannot pass object of non-trivial type 'std::vectorstd::int64_t' (aka 'vector') through variadic method; call will abort at runtime [-Wnon-pod-varargs]
294 |     ifft2d.set_value(oneapi::mkl::dft::config_param::FWD_STRIDES, strides);
|                                                                   ^
computed_tomography.cpp:295:67: error: cannot pass object of non-trivial type 'std::vectorstd::int64_t' (aka 'vector') through variadic method; call will abort at runtime [-Wnon-pod-varargs]
295 |     ifft2d.set_value(oneapi::mkl::dft::config_param::BWD_STRIDES, strides);
|                                                                   ^
2 errors generated.
make: *** [GNUmakefile:16: computed_tomography] Error 1

@raphael-egan Getting this compile error in computed_tomography. Can you take a look?
make icpx computed_tomography.cpp -fsycl -o computed_tomography -DMKL_ILP64 -qmkl=sequential -fsycl-device-code-split=per_kernel -lsycl -lOpenCL -lpthread -lm -ldl computed_tomography.cpp:294:67: error: cannot pass object of non-trivial type 'std::vectorstd::int64_t' (aka 'vector') through variadic method; call will abort at runtime [-Wnon-pod-varargs] 294 | ifft2d.set_value(oneapi::mkl::dft::config_param::FWD_STRIDES, strides); | ^ computed_tomography.cpp:295:67: error: cannot pass object of non-trivial type 'std::vectorstd::int64_t' (aka 'vector') through variadic method; call will abort at runtime [-Wnon-pod-varargs] 295 | ifft2d.set_value(oneapi::mkl::dft::config_param::BWD_STRIDES, strides); | ^ 2 errors generated. make: *** [GNUmakefile:16: computed_tomography] Error 1

@jimmytwei which oneMKL version did you use? You will need the 2025.0 release since we updated the sample to match the new API introduced in the 2025.0 release.

@lhuot I'm using the oneMKL version bundled with the 2025.0 LKG HPC Toolkit so I'm assuming that version should contain the correct 2025.0 oneMKL drop.

Just verified that the code sample works if you run with oneapi-vars.sh from the oneAPI specific version folder. It sets the right MKLROOT path.
However, with setvars.sh, the wrong MKLROOT path is set and you can get the compile error above.


Added GTx CS1301 Course Sequence to extras/courses

GTx CS1301, "Computing In Python" is proposed as a supplemental course in the OSSU curriculum and as a potential future candidate for the Introduction to Computer Science course. It is an online-adapted version of the on-campus Introduction to Computing course for Georgia Tech computer science students. The online version is comprised of four parts, delivered on-demand via edX. The course is self-paced with 16 weeks of effort, and is 100% free to audit with all materials included. It covers all introductory CS topics discussed in MIT 6.00.1x from a language-agnostic perspective, while providing additional instruction and support in learning Python as a language. Students who complete this course will have an understanding of basic CS topics and a working knowledge of Python 3 they can immediately apply to interesting problems.

Reference discussion: https://github.com/ossu/computer-science/pull/521
This PR adds CS1301 as a supplementary course to extras/courses as discussed in PR#521.

Thanks!


Removing a virtual machine from OneFlow

Description
After removing the virtual machine from the OneFlow service. The service starts to delete all other virtual machines.
To Reproduce
Create new OneFlow Service and terminate-hard some VM from OneFlow Service
Details

Version: <IP_ADDRESS>

Additional context

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

@al3xhh Greetings. As I understand it, the problem is that the service is not updated and function done_wd_cb from LifeCycleManager.rb is called endlessly?

Hello @Red967
Thanks for reporting the bug. Indeed it was related with done_wd_cb. I have already fixed it and it will be released in future releases.
Here you can check the commit.
Best,
Álex.


Implement ssh-agent support using jsch-agent-proxy

Currently, Roddy does not support SSH-agent. According to https://github.com/hierynomus/sshj/issues/33 this feature is long been implemented already by a combination of SSHJ with jsch-agent-proxy.

Also interesting:  https://github.com/ymnk/jsch-agent-proxy/blob/master/examples/src/main/java/com/jcraft/jsch/agentproxy/examples/SshjWithAgentProxy.java

@dankwart-de : Was this not in https://github.com/eilslabs/Roddy/pull/148? Can it be closed?


Put attack on hold when VPN is disabled

I'd like to suggest the next improvement:
It could be much safer to put the attack on hold when VPN is disabled.
I'm using my Windows 10 to run db1000n together with some VPN application. Sometimes when I have network issues my VPN application can be closed or disabled automatically, but db1000n continues attack. It leads to situations when another side could understand that my IP sends too many requests.
I'd like to have some argument, that allows to pause the attack if my IP belongs to my original country. The logs could show the message like: "Please turn on VPN". It could be good to check my current IP every 1-5 seconds

would it work for you if the app would just crash/exit in that scenario and you had to restart it? assuming that you'd have to restart your vpn app anyway it feels like I could kill 2 birds with one stone that way (see linked issue above)

It will work for me.
I understand that some calls can be sent to the goal under attack, and my real IP can be leaked, but I think it's a good reason to stop attack ASAP

That is best idea hopefully that will work with linux too lol !

Implemented it in https://github.com/Arriven/db1000n/commit/8951bbb66d98262e869bd4ca15ffc68fe6480c09
You'll need a combination of --strict-country-check and --country-check-interval <interval> to have a desired effect
The release should be available soon, I just want to check if everything works correctly first


Slider tap target size

Description

This PR is to add MaterialTapTargetSize to Material Slider and Material Range Slider, to address issue #33795
This includes:

Updating MaterialTapTargetSize to list Slider and Range Slider
Updating Material slider and range_slider to use MaterialTapTargetSize
Updating slider_test and range_slider_test debug fill properties for materialTapTargetie

Related Issues

#33795

Tests
I added the following tests:

DiagnosticsProperties

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

OK, we're going to close this PR for now, then.  Please feel free to re-open it or create a new PR when you pick it back up again.
Thanks for helping!


Arcane Warrior no Arcane Weapon

Respec.

Did not help.

It became a passive power… check you main attack status


Making some code cleanups

Hi @gsmet here are a few cleanups here and there. Mostly around creating empty arrays or lists with one element. This probably wouldn't be a visible performance improvement though :smiley:

Yes, I'll create a JIRA and address the suggestions.

Merged, thanks!


Could not GET 'https://repo.spring.io/libs-snapshot/com/journeyapps/zxing-android-embedded/4.1.0/zxing-android-embedded-4.1.0.pom'. Received status code 401 from server: Unauthorized

Description of the problem:
I have the error when build project:
Could not GET 'https://repo.spring.io/libs-snapshot/com/journeyapps/zxing-android-embedded/4.1.0/zxing-android-embedded-4.1.0.pom'. Received status code 401 from server: Unauthorized
Disable Gradle 'offline mode' and sync project
I use the version 4.1.0 of zxing-android-embedded
Android Studio 4.1.1

This project does not use the repo.spring.io repository. Make sure you use the jcenter() one.

This project does not use the repo.spring.io repository. Make sure you use the jcenter() one.

jcenter() is missing from the last repositories list in your screenshots, try adding it there.

jcenter() is missing from the last repositories list in your screenshots, try adding it there.

this resolve my problem, i add jcenter() in repositories!
Thanks @rkistner

this resolve my problem, i add jcenter() in repositories!
Thanks @rkistner


chore: support py3.13

relates to https://github.com/Homebrew/homebrew-core/pull/193794

hey @chenrui333, thank you so much for your effort. I understand how critical it is to homebrew, so I decided to not deal with ping-pong in this PR and did a proper project update here https://github.com/cycodehq/cycode-cli/pull/255. starting from the next release Python 3.13 will be supported and the patch could be removed from homebrew-core. thank you again!


Rendering

Render Markdown in plugin description
Render emoticones in plugin description
Split author from description
Display more plugins on homepage

@jekyllbot: merge


Noticeable delay while selecting text when ALE is enabled

Information
VIM version
VIM - Vi IMproved 8.1 (2018 May 17, compiled Jun 17 2018 23:04:26)
macOS version

Operating System: macOS High Sierra (10.13.5)
:ALEInfo
Current Filetype: nerdtree
Available Linters: []
Enabled Linters: []
Linter Variables:

Global Variables:

let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = v:null
let g:ale_command_wrapper = v:null
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = v:null
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = v:null
let g:ale_list_vertical = v:null
let g:ale_loclist_msg_format = v:null
let g:ale_max_buffer_history_size = v:null
let g:ale_max_signs = v:null
let g:ale_maximum_file_size = v:null
let g:ale_open_list = v:null
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 1
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = v:null
let g:ale_sign_error = '❌'
let g:ale_sign_info = v:null
let g:ale_sign_offset = v:null
let g:ale_sign_style_error = v:null
let g:ale_sign_style_warning = v:null
let g:ale_sign_warning = '🤔'
let g:ale_statusline_format = v:null
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1

What went wrong
Noticeable delay while selecting text when ALE is enabled
Reproducing the bug
Steps for repeating the bug:

Open a Ruby file (or run :set ft=ruby)
Double-click on a word to select it - it won't work
Double-click on it again, it will work after 1-2 seconds

I've recorded a quick GIF demonstrating it:

Thank you.

Full profiler results: https://gist.github.com/lucascaton/0749f64e23a24103edc1ea27ac0ff888

It looks like it's coming from here: https://github.com/macvim-dev/macvim/blob/master/runtime/ftplugin/ruby.vim#L56
MacVim seems to add several plugins! 😮
https://github.com/macvim-dev/macvim/tree/master/runtime/ftplugin

I was able to solve the issue by disabling balloonexpr:
autocmd FileType ruby,eruby set noballooneval

https://github.com/lucascaton/vimfiles/commit/4582661f1c77f4d42bda2b5fe4450c08f2158388
More info: https://stackoverflow.com/a/1111363/1445184
Thanks @w0rp! :D

Someone should patch Vim some day so it runs that program asynchronously. The system call is the costly thing.
https://gist.github.com/lucascaton/0749f64e23a24103edc1ea27ac0ff888#file-profile-log-L312


Updating the Ini.

Just wondering how to get the settings for updated versions of the file.
I feel like there should also be a signature scanning tool.
That way if the particular version of the dll is not available already (Ini on git last updated Oct 11, 2018 at the time of writing this) it could then scan and attempt to find the right addresses to patch.
Is there an explanation of how to find these addresses to patch and what they do?
I already have a signature scanning library from another project I could try it out, or does the maintainer have a tool they run to already do this?
Cheers

See °issue#1314 where at 2021.02.03.@14:30 MarioPedroSpo refers to AsmTron's AutoUpdater.
▪ https://github.com/stascorp/rdpwrap/issues/1314
▪ https://github.com/asmTron/rdpWrap/blob/master/binary-download.md

Yes sorry I forgot to update my comment, the AutoUpdater bat works for me.
But I saw it on a different issue.


Icon size?

Is there any way to change icon size? Mine are very small... I have 4 densities (hdpi to xxxhdpi).

My menu icons are also really small Ive bumped them up so mdpi to hdpi hdpi to xhdpi etc but only helps a little, think it's needs a scale type is this possible?


Add wreq into stackage.

Hi @bos,
I would love to use wreq in a tool of mine which is part of stackage.
Are you interested into having wreq in stackage and being listed as maintainer?
(You basically just have to do a PR on that file: https://github.com/fpco/stackage/blob/master/build-constraints.yaml and add yourself with the package)
If not I can add it next to my packages for now.
Please let me know
Thanks!

I'm not interested in stackage, but thank you for asking.

I hope you won't mind me putting your package under my name.
I'll put a note, "maintained in behalf of ..." or something.

That's fine by me.

Great!
Thanks a lot.


(Fixes #783) Check if block is real before checking if it's a shadow

Resolves
Issue #783 -  Opening dropdown in a block in the flyout and switching categories causes js error - link
Proposed Changes
This checks if this.sourceBlock_ is real before checking this.sourceBlock_.isShadow().
Reason for Changes
This prevents the error TypeError: this.sourceBlock_ is null, which prevents the stage from being panned after it is triggered.
Test Coverage
I don't see what tests are needed. Upon using npm install to recompile, doing the steps that would replicate the error instead work as intended.

I'd usually prefer to format that as this.sourceBlock_ && this.sourceBlock_.isShadow() but your way should work to

@Airhogs777 Your way also works and is more compact, so I've added it.

@rschamp (Pinging you since you're the assignee)
With the recent commits, should I close this PR, re-apply my bugfix, and open a new PR? Or will merging this PR not cause any problems with those?

@Tymewalk After we merge #791 there may be conflicts that prevent this PR from being automatically merged to develop. If there are no conflicts, then we can just merge it as-is. If there are conflicts, you don't have to close this PR, you can just merge develop into your branch and fix the conflicts, and then push your branch again. That will make this PR merge-able again.

And I should add that we were holding off on merging other PRs to prevent additional conflicts being added to #791, since it is already so large.

@rschamp All right, I'll keep an eye out for that. Thanks :smile:

I've moved the check one line higher, as requested by @rachel-fenichel.

@rschamp looks good to me.


mac work fine but "password" always request on client certificates

Hello,
Thanks for that amazing too. Everything is working smoothly, except that when I connect to the website using chrome, after I select the client certificate I always get this popup asking for my password. Is there a way to get ride of it ?
I followed the instruction :
mkcert -install
then mkcert "*.exemple.com" example.com localhost <IP_ADDRESS>
followed by  mkcert -client -pkcs12 "*.example.com" example.com locahost <IP_ADDRESS>
I use the export variable also for node.

It happens only from a new window, maybe it's required by chrome to access the keystore ?
Thanks.

How did you install the client certificate?
If you move it from the System keychain to the login one, does it solve it?

Hello @FiloSottile ,
It's the same. Both ( CA and client ) are in the login keychain but it still ask me for the password.
Thanks


Improve/create documentation for ReactTestUtils.renderIntoDocument()

This issue was originally reported by @the-spyke via facebook/react/issues/10330
There is almost none documentation about how to actually use .renderIntoDocument() method. I can't find find answers on those questions on Jest's website or enzyme's (I know that it's not Facebook) either.

If I render a component into a DOM in a test, how will it be destroyed?
Should I clean up by myself?
What tools to use for this?
Just .unmountComponentAtNode()?
Where I will get the container to pass in?
What about additional component trees like in Popovers?
What are the best ways to test that there aren't any parts left after my component were unmounted?

It will be nice to see such information before people will met memory leaks in their tests, and also help to establish good practices for writing tests.
Additional notes:

Calling .renderIntoDocument() returns you an instance
This instance was rendered into freshly created DOM element, which now represents a detached tree
There's also a reference to the instance in ReactDOM's internal map
So, even if you remove all your references to this instance, on every call to .renderIntoDocument() you will get 1 detached tree hanging in memory + 1 instance of a React component with all its props not available for garbage collection

@bvaughn is this issue open ?


Add a unit test for MergeLabels in storage/remote/codec.go.

This PR is about adding a unit test for MergeLabels in storage/remote/codec.go.
Signed-off-by: Hu Shuai<EMAIL_ADDRESS>

@csmarchbanks Thanks for your review, I have modified it. PTAL.


NR-31186 Typescript integration

Summary
Ticket URL: https://issues.newrelic.com/browse/NR-31187
Description:
This PR has the new quickstart integration named "Typescript"
A concise description of the changes being introduced. If you are submitting a PR for a
new quickstart please review the pre merge checklist section to validate this PR is ready for review.

Pre merge checklist

[ ] Did you check you NRQL syntax? - Does it work?
[ ] Did you check your dashboard image quality? -  Do they look good?
[ ] Did you check that your alerts actually work?
[ ] Did you include an InstallPlan and Documentation reference?
[ ] Did you check your descriptive content for voice, tone, spelling and grammar errors?
[ ] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots
Attach images of any visual changes, such as a dashboard here.

@akristen , Request you to kindly review the content in this PR

@pkosanam, That typescript logo is showing up as a big blue square, there might be something wrong with the image!

Thank you very much @aswanson-nr , I will make sure, @pkudikyala will fix it.. 👍

@pkosanam, That typescript logo is showing up as a big blue square, there might be something wrong with the image!

@aswanson-nr, I have updated the docs URL and logo, kindly review it.


Reverse temporary changes that allowed checks to pass

[ ] reverse this commit 87bb2f2008b669195eb39b71d97569288462eea2
[ ] remove this PMD comment from PlayPen.java:

private ImageView mPlayOrderButton; // NOPMD

These were added temporarily to get the build running so that branch commits can be disabled except for successful PR merges.


[core][parser] Require chrono 0.4.22

Evade known vulnerability RUSTSEC-2020-0159.

@Enet4 I noticed some deprecation warnings for chrono calls inside dicom::core::value
Would you mind if I corrected those ?

@jmlaka Sure, that would be much appreciated!


Annotation upload progress info

Hi,
There is no information what's the progress of uploading annotation. Sometimes it took very long time and it can be confusing for the user. The only option how to check the status is to watch active job in queues or the upload button is gray.
BW,
karellat

Related: #1520


arch: arm: aarch32: fix section alignment behind rodata start marker

Proposed fix for issue #39978.
This commit assigns the __rodata_region_start marker to the ROMABLE region
prior to the inclusion of linker/common-rom.ld, linker/thread-local-storage.ld and
linker/cplusplus-rom.ld. Prior to this fix, the __rodata_region_start marker was
properly aligned and indicated the expected memory location for the start of the
rodata section and similar sections, but it was disconnected from the ROMABLE
region into which the subsequent sections are being integrated, resulting in place-
ment of those sections right behind the previous section in the ROMABLE region
and therefore at addresses below the __rodata_region_start marker.
For the sake of consistent behaviour, the end marker of the text region
has been modified accordingly.
Signed-off-by: Immo Birnbaum<EMAIL_ADDRESS>

With this  #40842 and #40848 could be reverted. Not sure though if that should be part of this PR. If not it may be forgotten.

Additionally reverted #40842 and #40848 and the test have passed.

Great! Can you add "Fixes ..." to PR message so that issues get closed automatically.


Clarify opening sentence in Additiona - 2 - User Data Interaction

Trivial change to ensure I understand the workflow.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

to main, thank you!


fix: Rework type collector into compilation unit collector

Fix #251
Fix #348
The UniqueTypesCollector has three problems: 1) global state (#251), 2) collecting types instead of compilation units (which is the unit of granularity that we actually print), and 3) that it's simply incorrectly implemented (#348).
This PR entirely replaces the UniqueTypesCollector with the CompilationUnitCollector. It solves 1) by making it an event handler which is passed in, no more global state! It solves 2) by simply collecting compilation units, which is in fact a whole lot easier. It solves 3) by hopefully being correctly implemented :)
Note that there's still a slight problem with the collector: it will crash if whatever is passed into it is on a higher level than a type (e.g. a package or a module). We don't have any processors that deal with such high-level elements, so I'll simply fix that separately later.

@slarse, since this PR fixes one issue that we talked about before, is it ok if I review it?

@fermadeiral
I had a look and I do not see any special problem with the PR. That would be good if you have a look as well and merge it if you see no problem.

@khaes-kth LGTM too!

@fermadeiral I was certain I had assigned you to review this as well. My intention was for both you and @khaes-kth to review it as it's a rather significant change, but apparently that worked itself out on its own :)


feature requested: add helper function to get hresult message

Until now we can't fetch error message string from winrt::hresult directly, but generally winrt::hresult_error contains message data. So we can indeed use a workaround:
winrt::hresult hr;
try {
    winrt::throw_hresult(hr);
} catch (const winrt::hresult_error &e) {
    display(e.Message());
}

That's because, as far as I known, cpp/winrt already have ability to fetch error message from calling some raw COM interfaces. But it's weird to use exception to do this thing. cpp/winrt can easily provide a helper function for it. What do you think?

You can manually call FormatMessage to get the error message for an HRESULT. Also, no need to throw the exception: winrt::hresult_error(hr).message()

Thank you! I somehow didn't notice this constructor. This works well.


app: register metrics of components

Good catch! Will inspecting the metrics on the current testnet 61, I also noticed a small regression in that we're no longer capturing some concurrent connection stats:

I don't expect these changes will resolve that, but will proceed with release as planned today. I'll follow up separately to track down the root cause on the regression in the screenshot above.

I think those should have moved to the penumbra_compact_block crate, but I don't see a register_metrics method there. Maybe I forgot to add that while splitting up RPCs.


adds teardown step for test system-fixture

I noticed that the system-fixture was missing a teardown step for testing.
I added a few high level API tests for my hobby project with mock.ring.request and used utils/system-fixture and utils/system-state from the test_utils.clj to configure my database and handler. The tests passed, but I noticed that when I ran clj -X:test from the CLI the process would hang, or if ran the (run-tests) function in the repl mutiple times I would get a "bind address already in use" error.
I figure the fixture starts up the whole integrant system including the http-server, which doesn't exit. In any case, adding this teardown step worked locally for me, and seems to align with the practices listed on the use-fixtures documentation.
I don't know clojure super well yet so not sure if there is a better way to be doing this, but figured I would open a PR since this was helpful for me.

Oh yeah, that's a good catch and thanks for doing the PR!


[CXF-7001] Update JAX-RS SpringBoot starter to support JAX-RS Applications

I'm not happy with the setJaxrsResources method. Can we refactor and rename it?

I agree, I'd just override createJaxrsServer, if AppPath is there then complete it otherwise delegate to the superclass, I can take care of it while working on your patch

Can you please create another PR related to JavaDocs and SpringBoot version update, thanks

Never mind, spring boot version was already set to 1.5.2.RELEASE on master, I'll merge javadocs updates


"Base64 Convert" is broken

I use Base64 converter to decode a base64-encoded string. When I encode the result, it differs from the original. Sample code below.
//Base64: codeunit "Base64 Convert";
Base64String := 'iVBORw0KGgoAAAANSUhEUgAAAAUAAAAHCAIAAABPxRC5AAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAAEnQAABJ0Ad5mH3gAAAAgSURBVBhXY/iPCkB8BhhA8EFSYECkPIQDBAgWCPz/DwAmK02zB8YDEgAAAABJRU5ErkJggg==';
Message(Base64String);
lTxtType := base64.FromBase64(Base64String);
message(base64.ToBase64(lTxtType));
The latter message gives us:
77+9UE5HDQoaCgAAAA1JSERSAAAABQAAAAcIAgAAAE/vv70Q77+9AAAAAXNSR0IA77+977+9HO+/vQAAAARnQU1BAADvv73vv70L77+9YQUAAAAJcEhZcwAAEnQAABJ0Ae+/vWYfeAAAACBJREFUGFdj77+977+9CkB8BhhA77+9QVJgQO+/vTzvv70DBAgWCO+/ve+/vQ8AJitN77+9B++/vQMSAAAAAElFTkTvv71CYO+/vQ==
BC 15.2

As a further clarification, we want to write the base64 string as binary data into a MediaSet, but I have not found a way to do this with the very limited toolset (dotnet wrapper codeunits) available to us.

@JesperSchulz

Anything ?

I've looked into our Base64 module and it looks as if it's sufficiently tested:
https://github.com/microsoft/ALAppExtensions/blob/master/Modules/System Tests/Base64 Convert/src/Base64ConvertTest.Codeunit.al
In that test codeunit, you will also find the following test, which kind of does the same as you are doing:
    [Test]
    procedure ToAndFromBase64Test()
    var
        ConvertedText: Text;
        ConvertedBackText: Text;
    begin
        // [SCENARIO] The convertion to base-64 string and then from it back results in the initial string.

        // [WHEN] The string is converted to base-64
        ConvertedText := Base64Convert.ToBase64(SampleTxt);

        // [WHEN] The string is converted back from base-64
        ConvertedBackText := Base64Convert.FromBase64(ConvertedText);

        // [THEN] The value is the same as the initial one
        Assert.AreEqual(SampleTxt, ConvertedBackText, 'The converted back value is not the same as the initial one.');
    end;

We take a string, Base64 convert it and covert it back, which yields the same result. I would hence claim, that the implementation isn't broken. But we'll look into your specific issue to see what's going on there.

Good day and thanks for your reply.
Yes, converting to base64 and then back does seem to work, at least for a non-binary string, but converting from 64 to binary and then back does not. If this relates to how text variables work and is impossible to do, we would appreciate help in how to write the binary representation of the base64 string into a mediaset.

@navdotnetreqs can you try using the overloads of ToBase64 and FromBase64 that accep streams (InStream and OutStream respectively)?
This are the functions that are supposed to be used for binary content.

Hi and thanks for your reply.
Using FromBase64(Text,OutStream) I managed to solve the problem in question by writing the base64 data to a blob field in a temporary record (company information picture), and then creating an instream to the same blob, and then using mediaset.ImportStream.
Thank you for your help.

I am experiencing the same issue.
So the TempBlob table was removed... and to achieve the same functionality as before we need to "abuse" another table with a blob field to mimic the old TempBlob behaviour. This sounds like a bad joke.

Nevermind, actually simple... if you know how:
procedure ImportLabelFromBase64(Base64Text: Text; Description: Text)
var
        TempBlob: Codeunit "Temp Blob";
        Base64Convert: Codeunit "Base64 Convert";
        LabelInStream: InStream;
        BlobOutStream: OutStream;
    begin
        TempBlob.CreateOutStream(BlobOutStream);
        Base64Convert.FromBase64(Base64Text, BlobOutStream);
        TempBlob.CreateInStream(LabelInStream);
        Label.ImportStream(LabelInStream, Description);
    end;


Is this approach depreciated?

This document says it outlines how to access OneDrive for business, but it seems out-dated, based on this: https://developer.microsoft.com/en-us/graph/blogs/upcoming-deprecation-of-discovery-service-api/
What is the correct approach for getting access to OneDrive for Business?
Needs more clarity

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78d44c1c-08a2-3cbf-90e4-497a9a98d7b6
Version Independent ID: c51d78c1-3982-a9fa-819f-a48852a60575
Content: Using Azure Active Directory to sign-in - OneDrive API - OneDrive dev center
Content Source: docs/rest-api/getting-started/aad-oauth.md
Product: onedrive
GitHub Login: @JeremyKelley
Microsoft Alias: JeremyKe

@ghufs Yes the discovery service is deprecated, please use Microsoft Graph to access OneDrive for business
https://docs.microsoft.com/en-us/graph/


JWT implementation

Create an application compose by frontend and backed.
These applications have to show the use of JWT and roles both in access layer and data layer.

Use case
Description

RHBK Installation
Install RHBK in GitOps model

RHBK Realm Configuration
Configure the RHBK in GitOps model

Frontend
Create an application with ReactJS

Backend
Create an application with the backend. This application should use Quarkus

Authentication
Integrates frontend application with RHBK

Authorization
RHBK should avoid the communication between fronted and backend for no logged users.

Filter data by role
The data access have to use the user role to filter the data, depending on the user role.

[ ] RHBK Installation: This issue is covered in other section
[ ] RHBK Configuration:
[ ] Frontend
[ ] Backend
[ ] Authentication
[ ] Authorization
[ ] Filter data by role

I just have to complete the configuration section


Dataverse 5.5

@4tikhonov I'm sorry, but I will not accept this PR.

It's huge. It's noisy. It's hacky. The code quality of the scripts isn't sufficient from my point of view. (See Shellcheck output for example)
It copies files into places that lived in other places before and does not clean up the old glassfish parts.
It introduces new (somewhat random) docker-compose files, SQaaS related stuff etc, all undocumented. It also ignores the existing "docker-compose persona".
There is no documentation included for the new release or features.
It introduces the controlled vocabulary specials in the standard image. I really don't like that - it would be ok to create a new flavor with its own tag, but we should have a vanilla version and a feature one.
The Jenkinsfiles are nice, but there are already CI pipeline files in place. They should be adapted.

As I'm working on #186 and now that https://github.com/gdcc/dataverse/tree/develop+ct is in place, we should go for that. Maybe we can even achieve adding the images to upstream.
I'm going to close this PR now. Again: thanks for your work.

Ok, I think we need a meeting to discuss how to leverage EOSC Synergy stuff with Dataverse Kubernetes. I understand that you want to keep vanilla version in the current state.


[Enhancement] Error message enhancement on the monitoring dashboard

Describe the bug

Parent issue https://github.com/harvester/harvester/issues/1531
To Reproduce
Steps to reproduce the behavior:

Go to '...'

Expected behavior

Prometheus configuration has been editable after #1531 fixed.
We should enhance the error message on the monitoring of dashboard on this issue.
Support bundle

Environment:

Harvester ISO version:
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

Currently, users can debug the monitoring system status by referring to the doc https://docs.harvesterhci.io/v1.1/troubleshooting/monitoring, will consider how to track its status via particular CRD in the future.


Ft remove bongo #260

closes:#260
Brief summary of the change made

Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?

Pull Request checklist
Please confirm you have completed any of the necessary steps below.

[ ] Meaningful Pull Request title and description
[ ] Changes tested as described above
[ ] Added appropriate documentation for the change.
[ ] Created GitHub issues for any relevant followup/future enhancements if appropriate.

Can you also remove the Bongo leftovers from services.php ?

Hey @munyanezaarmel Looks good, change wise. However, looks like you have started this branch based on your Laravel Pint branch. Could you please rebase this branch off of main ?


Fix pre/postincrement of parenthesized array access (fixes #558)

This fixes #558, that pre-/postincrement expressions containing parenthesized array accesses like (x[0]) are mistranslated. Parenthesized expressions are now "unwrapped" first in ArrayRewriter.needsAssignableAccess so that the outermost prefix or postfix expression can be considered with the actual array access expression. Test cases are also added to ArrayRewriterTest.
One thing I noticed is that, after this fix, these two expressions will have the same translated code:
x[0]++;     // (*IOSIntArray_GetRef(x, 0))++;
(x[0])++;   // (*IOSIntArray_GetRef(x, 0))++;

But:
((x[0]))++; // ((*IOSIntArray_GetRef(x, 0)))++;

And this is because ComplexExpressionExtractor parenthesizes an expression if its parent is a pre-/postfix expression, but does nothing if it is already a ParenthesizedExpression.

Thanks for the fix!


Provide statically linked binary without any dependencies

I'd like to put a restic binary on the USB disk that serves as backup storage as I fear that next time my system crashes, I won't easily find a rescue CD (like Knoppix, Grml) that has Go installed.
Grep told me that there is a "-ldflags" option in build.go but I can't get it to pass "-static" or similar to the linker. It should be fairly easy for you to add a "make static" target in the Makefile, I guess.

Hi, thanks for asking. For once, installing Go on e.g. grml is easy, you should be able to install it via apt-get install golang. Otherwise, you could just extract a pre-compiled tar from golang.org and use that to compile restic.
I can understand your desire to have a pre-compiled version of restic, so that you don't have to fiddle around with compiling it when you urgently need to restore a backup. The binary produced by the Go compiler is by default already nearly static, only the most basic things like libc and libpthread are linked dynamically:
$ ldd restic
	linux-vdso.so.1 (0x00007fff23df4000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f872b0e3000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f872ad38000)
	/lib64/ld-linux-x86-64.so.2 (0x0000563622743000)

The binary was produced by just running go run build.go, without any extra parameters. It should run on any recent (< 5 years old) Linux without having to install any libraries.
I think that's enough for a USB stick for disaster recovery, do you agree?

Your ldd output is indeed ok, mine shows a dependency to libgo.so.7 and I feared that that might not be available on a rescue disk in 1-2 years anymore:
$ ldd restic
    linux-vdso.so.1 (0x00007ffc299d5000)
    libgo.so.7 => /usr/lib/x86_64-linux-gnu/libgo.so.7 (0x00007f5e76914000)
    libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f5e7660f000)
    libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f5e763f8000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f5e76054000)
    /lib64/ld-linux-x86-64.so.2 (0x00005581c9009000)
    libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f5e75e37000)

My system is a Debian unstable with gccgo 5.3.1:
Linux james 4.3.0-1-amd64 #1 SMP Debian 4.3.3-7 (2016-01-19) x86_64 GNU/Linux
Ah, I read your comment and installed "aptitude install golang" and recompiled and now the binary looks better, no libgo and no libpthread anymore:
$ ldd restic
    linux-vdso.so.1 (0x00007ffff35aa000)
    libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0381ca5000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f0381901000)
    /lib64/ld-linux-x86-64.so.2 (0x0000563a75aa3000)

Maybe add a comment to the README which compiler is the better/recommended one?

Good idea, thanks!


Is there a recommended solution for re-writing relative paths?

When I @import from an npm package whose stylesheet includes a relative link to a font, the font link is broken upon import.

I had a similar issue (described here in more detail) and found rework-npm to not be handling relative paths well. Playing around with what would fix it, if I change this line in getImport
contents = parse(contents, { source: path.relative(root, file) });
to call path.resolve instead, it works fine for me.


Need REST API to List Orders

As a user
I need a way to view all my orders
So that I can keep track of my purchase history
Details and Assumptions
•	The base URL would be /orders
Acceptance Criteria
Given the server is available
When I call the URL `GET/orders`
Then it should return all the orders in the database

Hey team! Please add your planning poker estimate with Zenhub @even1111112 @PepperandSummer @un-poco @yjhsieh2022

#24