\big, \bigg et al macros

There is some funny behaviour with all \big, \bigg and so on macros. For example:
\documentclass{article}
%\usepackage{fontspec}
\begin{document}
$\begin{array}{*{17}c}
() & [\,] & <> & /|\backslash & \lmoustache\,\rmoustache & \arrowvert\vert & \Vert\,\Arrowvert &
\uparrow\downarrow & \updownarrow & \Uparrow\Downarrow & \Updownarrow & \langle\rangle &
\lbrace\rbrace & \lceil\,\rceil & \lfloor\,\rfloor & \lgroup\rgroup & \bracevert  \\
%
\Bigg(\Bigg) & \Bigg[\,\Bigg] & \Bigg<\Bigg> & \Bigg/\Bigg|\Bigg\backslash &
\Bigg\lmoustache\,\Bigg\rmoustache & \Bigg\arrowvert\Bigg\vert & \Bigg\Vert\,\Bigg\Arrowvert &
\Bigg\uparrow\Bigg\downarrow & \Bigg\updownarrow & \Bigg\Uparrow\Bigg\Downarrow &
\Bigg\Updownarrow & \Bigg\langle\Bigg\rangle & \Bigg\lbrace\Bigg\rbrace &
\Bigg\lceil\,\Bigg\rceil & \Bigg\lfloor\,\Bigg\rfloor & \Bigg\lgroup\Bigg\rgroup &
\Bigg\bracevert
\end{array}$
\end{document}

The output with Computer Modern Math looks ok. Using Latin Modern Math (uncommenting package fontspec) gives different wrong results for XeLaTeX and for LuaLaTeX.  I am using up-to-date TL2017 and Linux (Ubuntu)

I tried, but cannot reproduce the issue. I have updated my TeX Live (MacTeX) to the last possible minute. I just added [4ex] to your array in order to space the rows and geometry not to have an overfull box.
\documentclass{article}
\usepackage[a4paper,margin=2cm]{geometry}
\usepackage{ifxetex,ifluatex}

\ifxetex
  \usepackage{fontspec}
\else
  \ifluatex
    \usepackage{fontspec}
  \fi
\fi

\begin{document}
\ifxetex
  XeTeX
\else
  \ifluatex
    LuaTeX
  \else
    pdftex
  \fi
\fi

\bigskip

$\begin{array}{*{17}c}
() & [\,] & <> & /|\backslash & \lmoustache\,\rmoustache & \arrowvert\vert & \Vert\,\Arrowvert &
\uparrow\downarrow & \updownarrow & \Uparrow\Downarrow & \Updownarrow & \langle\rangle &
\lbrace\rbrace & \lceil\,\rceil & \lfloor\,\rfloor & \lgroup\rgroup & \bracevert  \\[4ex]
%
\Bigg(\Bigg) & \Bigg[\,\Bigg] & \Bigg<\Bigg> & \Bigg/\Bigg|\Bigg\backslash &
\Bigg\lmoustache\,\Bigg\rmoustache & \Bigg\arrowvert\Bigg\vert & \Bigg\Vert\,\Bigg\Arrowvert &
\Bigg\uparrow\Bigg\downarrow & \Bigg\updownarrow & \Bigg\Uparrow\Bigg\Downarrow &
\Bigg\Updownarrow & \Bigg\langle\Bigg\rangle & \Bigg\lbrace\Bigg\rbrace &
\Bigg\lceil\,\Bigg\rceil & \Bigg\lfloor\,\Bigg\rfloor & \Bigg\lgroup\Bigg\rgroup &
\Bigg\bracevert
\end{array}$
\end{document}

Compiling with pdflatex, xelate and lualatex gives the following results

Confirmed, on MacOSX it works fine, but my examples were created under Linux

I don't understand the remarks about computer modern math and latin modern math: fontspec doesn't change the math setup (at least not the delimiters) and you are not loading unicode-math, so I would expect that your example use the standard cmm fonts (cmex10.pfb etc) and this what happens. (I would not expect the wrong glyphs and I don't get them on windows).

As I already wrote when running under Linux with loading fontspec, latex uses lmm and not cmm.With cmm all is fine.

It doesn't for me. Can you show the log-file of a lualatex compilation of the example with fontspec?

FOO.log

You are loading unicode-math, and with it I can reproduce the issue.

With unicode-math the issue is easy to explain: \lmoustache and \rmoustache are not in the font, \arrowvert and the other "curious" outputs are not defined by unicode-math and so you get whatever the old mathcodes points to. The issue should be moved to the unicode-math issue tracker.


Split pipelines so docs updates woudl not trigger all builds

Description
Split pipelines so docs updates woudl not trigger all builds. Currently all package update starts all builds
Changes proposed in this pull request:

splitting to docs and ci pipelines

Docs job was not triggered in PR, is it fine?

Docs job was not triggered in PR, is it fine?

yes, new yml files have to be added in Azure interface. i think the simplest way would be merge now and fix in case of any problems


Added feature to publish benchmark data to bigquery table.

Closes: #434
Earlier we were storing benchmark data in /tmp/<some-file>.ndjson file locally, but now we need to perform the benchmarks in the CI pipeline and hence we need the data to be persisted. With this PR we are publishing the benchmark data in the Bigquery table - astronomer-dag-authoring.Benchmark.load_files_to_database
Publishing is not enabled by default, because developers can run benchmarks locally but this data may not be intended to be published. In order to allow the publishing of data, an environment variable needs to be created ASTRO_PUBLISH_BENCHMARK_DATA.
Note - We assume the existence of a table in the Bigquery, and the schema of the table is tightly coupled with profiling data to be stored. If we decide to change the profiling data in the future, we may need to alter the table schema.

@sunank200 - yes, the metrics are more useful to us if we make them queriable, we can later decide to do a weekly comparison on them and alert if they are less than a certain threshold.


Chore/documentation improvements

PR Checklist

[x] This comment contains a description of changes (with reason)
[x] Referenced issue is linked
[ ] If you've fixed a bug or added code that should be tested, add tests!
[x] Documentation in docs is updated

Description of changes

missing functions added to API documentation
examples for minimal configurations added to utils module
removed old example_config.json and documentated how to import minimal configs
updated oktoberfest logo to contain the text as path instead of font
fixed wrong documentation of missedCleavages key and other minor config documentation errors

Technical details

Additional context

🥳


IWYU code action

We could add a "add include for XXX" code action when selecting any node where the include is likely missing.
We can get the include from the index in apply() but avoid the index lookup in prepare() by simply checking if no redecls are directly included. We need to check for IWYU directives/standard library, but that should cover most cases.
Precision doesn't have to be super high if we don't add a diagnostic.

Is this a dupe of #79?

Isn't this already implemented as a hint ?

Isn't this already implemented as a hint ?

Not really, clangd currently only offers inserting the header if definition for a symbol is missing (i.e build would fail, there's a real diagnostic).
But absence of diags doesn't imply file is IWYU complaint. It might still be depending on a symbol transitively. This issue suggests, offering a code action in such cases for inserting the direct header declaring/defining the symbol in such cases.

This is likely to be made easier with the implementation of IWYU missing header diagnostics (as they can share the same infra) and might be a different way to make use of the feature for users that don't want "strict" IWYU mode.

This is done: https://clangd.llvm.org/guides/include-cleaner


snabbvmx top crashes

Using snabbvmx top crashes:
root@deva-node10-lab:~# ./snabb/src/snabb snabbvmx top
program/snabbvmx/top/top.lua:6: module 'program.lwaftr.coutners' not found:
	no field package.preload['program.lwaftr.coutners']
	no file './program/lwaftr/coutners.so'
	no file '/usr/local/lib/lua/5.1/program/lwaftr/coutners.so'
	no file '/root/snabb/lib/luajit/usr/local/lib/lua/5.1/program/lwaftr/coutners.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
	no file './program.so'
	no file '/usr/local/lib/lua/5.1/program.so'
	no file '/root/snabb/lib/luajit/usr/local/lib/lua/5.1/program.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
file not found: core/main.lua: No such file or directory
file not found: core/main.lua: No such file or directory

Stack Traceback
===============
(1) Lua function '?' at file 'core/main.lua:168' (best guess)
	Local variables:
	 reason = string: "program/snabbvmx/top/top.lua:6: module 'program.lwaftr.coutners' not found:\
\9no field package.preload['program.lwaftr.coutners']\
\9no file './program/lwaftr/coutners.so'\
\9no file '/usr/local/lib/lua/5.1/program/lwaftr/coutners.so'\
\9no file '/root/snabb/lib/luajit/usr/local/lib/lua/5.1/program/lwaftr/coutners.so'\
\9no file '/usr/local/lib/lua/5.1/loadall.so'\
\9no file './program.so'\
\9no file '/usr/local/lib/lua/5.1/program.so'\
\9no file '/root/snabb/lib/luajit/usr/local/lib/lua/5.1/program.so'\
\9no file '/usr/local/lib/lua/5.1/loadall.so'"
	 (*temporary) = C function: print
(2) global C function 'require'
(3) main chunk of file 'program/snabbvmx/top/top.lua' at line 6
(4) global C function 'require'
(5) Lua field 'run' at file 'program/snabbvmx/snabbvmx.lua:17'
	Local variables:
	 args = table: 0x40db2960  {}
	 command = string: "top"
	 modname = string: "program.snabbvmx.top.top"
(6) Lua function '?' at file 'core/main.lua:67' (best guess)
	Local variables:
	 program = string: "snabbvmx"
	 args = table: 0x40db2960  {}
(7) global C function 'xpcall'
(8) main chunk of file 'core/main.lua' at line 230
(9)  C function 'require'
(10) global C function 'pcall'
(11) main chunk of file 'core/startup.lua' at line 3
(12) global C function 'require'
(13) main chunk of [string "require "core.startup""] at line 1
	nil

Fixing that typo results in:
root@deva-node10-lab:~# ./snabb/src/snabb snabbvmx top 24483
core/shm.lua:37: shm open error (24483/apps/lwaftr/in-ipv4-frag-reassembled.counter):No such file or directory
file not found: core/main.lua: No such file or directory
file not found: program/snabbvmx/top/top.lua: No such file or directory
file not found: program/snabbvmx/top/top.lua: No such file or directory
file not found: core/main.lua: No such file or directory

Stack Traceback
===============
(1) Lua function '?' at file 'core/main.lua:168' (best guess)
	Local variables:
	 reason = string: "core/shm.lua:37: shm open error (24483/apps/lwaftr/in-ipv4-frag-reassembled.counter):No such file or directory"
	 (*temporary) = C function: print
(2) global C function 'error'
(3) Lua field 'open' at file 'core/shm.lua:37'
	Local variables:
	 name = string: "/24483/apps/lwaftr/in-ipv4-frag-reassembled.counter"
	 readonly = string: "readonly"
	 create = boolean: false
	 path = string: "24483/apps/lwaftr/in-ipv4-frag-reassembled.counter"
	 mapmode = string: "read"
	 size = number: 8
	 stat = nil
	 fd = nil
(4) Lua upvalue 'open_counter' at file 'core/counter.lua:62'
	Local variables:
	 name = string: "/24483/apps/lwaftr/in-ipv4-frag-reassembled.counter"
	 n = number: 11
	 (*temporary) = table: 0x41e76538  {1:0, 2:0, 3:0, 4:0, 5:0, 6:0, 7:0, 8:35,900,842,806, 9:2,584,860,682,032 (more...)}
(5) Lua local 'open_counter_list' at file 'program/snabbvmx/top/top.lua:58'
	Local variables:
	 t = table: 0x41b10628  {1:in-ipv4-packets, 2:in-ipv4-bytes, 3:out-ipv4-packets, 4:out-ipv4-bytes (more...)}
	 ret = table: 0x41b13720  {out-ipv4-bytes:2,584,860,682,032, out-ipv4-packets:35,900,842,806, in-ipv4-packets:0 (more...)}
	 (for generator) = C function: builtin#6
	 (for state) = table: 0x41b10628  {1:in-ipv4-packets, 2:in-ipv4-bytes, 3:out-ipv4-packets, 4:out-ipv4-bytes (more...)}
	 (for control) = number: 6
	 _ = number: 6
	 name = string: "in-ipv4-frag-reassembled"
(6) Lua upvalue 'open_counters' at file 'program/snabbvmx/top/top.lua:64'
	Local variables:
	 tree = string: "/24483"
	 open_counter = Lua function '?' (defined at line 52 of chunk program/snabbvmx/top/top.lua)
	 open_counter_list = Lua function '?' (defined at line 55 of chunk program/snabbvmx/top/top.lua)
	 counters = table: 0x41b13668  {lwaftr:table: 0x41b13690}
	 (*temporary) = table: 0x41b13690  {}
(7) Lua field 'run' at file 'program/snabbvmx/top/top.lua:212'
	Local variables:
	 args = table: 0x40a2f070  {1:24483}
	 opts = table: 0x41b112c0  {}
	 target_pid = string: "24483"
	 instance_tree = string: "/24483"
(8) Lua field 'run' at file 'program/snabbvmx/snabbvmx.lua:17'
	Local variables:
	 args = table: 0x40a2f070  {1:24483}
	 command = string: "top"
	 modname = string: "program.snabbvmx.top.top"
(9) Lua function '?' at file 'core/main.lua:67' (best guess)
	Local variables:
	 program = string: "snabbvmx"
	 args = table: 0x40a2f070  {1:24483}
(10) global C function 'xpcall'
(11) main chunk of file 'core/main.lua' at line 230
(12)  C function 'require'
(13) global C function 'pcall'
(14) main chunk of file 'core/startup.lua' at line 3
(15) global C function 'require'
(16) main chunk of [string "require "core.startup""] at line 1
	nil

Thanks for the report.
Apparently the issue is cause due to not being table to find the "in-ipv4-frag-reassembled" counter. It's possible to use snabb snabbvmx top with a plain snabb lwaftr run instance. I would suggest to run the lwaftr this way to reproduce the issue. Then check in /var/run/PID/ counters directory if the counter exists. Perhaps the counter name was renamed (or lacks the counter suffix).


Fix: Fixed an issue were installing a font would freeze the app

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #12474

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Changes
Created RunPowershellCommandAsync method which uses async/await to wait for the powershell command to complete.
I replaced the non async method wit the async method in all places where i knew how to test it. In 5 places the non async method is still used.
Steps used to test the changed - noticeable freezes

Install Font

Select multiple *.ttf files
Install them with the Install button from the command bar or menu flyout

Run With Powershell

Select a powershell script
Execute it with the button from the command bar

Set Files as the default file manager

(There was a noticeable freeze on the toggle button, animation is now smooth)
Open Settings > Advanced
Toggle ‘Set Files as default file manager’

Open Format Drive

(Files was not responding while the format dialog was open, now you can continue to use Files while the dialog is open)
Format drive from the sidebar
Navigate to empty drive > Format drive
Format drive from drives widget

Mount VHD Disk

Select a *.vhd file
Mount disk via menu flyout

Steps used to test the changes - no freeze but code has changed

Open in VS action

Navigate to a git repository with a .sln file
Click Open in VS

Open in VSCode action

Navigate to a git repository
Click Open in VSCode

@mafra99 thank you


Adding own action button

I want implement a template button, that has variables like {{first_name}}, whenever the user clicks on that button, it adds the {{first_name}} at current cursor position

sry for the delay, hope helpful for you: template button example

Hi! I'd like to create a button which creates a test html when pushed, how do I do this?


add welcome  bot

Fixes Issue: #334

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.

review/ @MonalikaPatnaik


No gap on top of video...

It seems as if the nice gap on top of the player has now gone in Build #509. Would love to see an option to bring it back, as it looks really strange gone.

@LiamBM That isn't a YTC change, it was YouTube that reverted the change. The gap wasn't suppose to be there in the first place.

@Yonezpt Hmm strange. I guess this is a feature request then.

@LiamBM In that case it would be best if you'd change the title to reflect a feature request instead of an issue.

An option has been added to add the gap.


Does AppTx name not get used for any kind of registration?

https://github.com/tendermint/basecoin/blob/master/types/tx.go#L198
I'm wondering if the name field is used for anything besides printing response information back to the CLI. if this is the case maybe we can figure out a way to eliminate it, or label its function more clearly. I was under the impression that app txs need to be registered in some capacity and this name would invoke looking up a certain command or registered transaction.

Yeah, when an apptx comes in, the executor looks for a registered plugin with that name. Then passes the data to that plugin.
So, you need to register the plugin with a name and the apptx better have the same name as the plugin


AdditionalProperties does not work as expected

Hi everyone,
Given:
schema = {
  properties: {
    prop_1: { type: 'string' },
    prop_2: { type: 'string' }
  },
  additionalProperties: false
}

I want the below to be valid
data = {prop_1: 'xxx'}
data = {prop_2: 'xxx'}
data = {prop_1: 'xxx', prop_2: 'xxx'}

I want the below to not be valid
data = {prop_x: 'xxx'}

But it does not work that way :)
My code:
JSON::Validator.new(schema, data).validate

I cannot reproduce your issue. Using json-schema 2.5.2 and MRI 2.2.3 all data is validated as expected, the first three pass, the last one causes a validation error complaining about the disallowed property prop_x.
What version of json-schema and which Ruby are you using?

additionalProperties also doesn't work for me. I'm using version
json-schema  4.0.0
Ruby ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-darwin21]
Rails 7.0.5


dts: arm: nxp_rt118x: Complement full LPUART/GPIO devices and ocram spaces

Complement full LPUART and GPIO devices, and ocram spaces

agree to make the commit title/message to say rt118x

Commit message needs to be updated to be more specific. Something like the following:
dts: arm: nxp_rt118x: Complement full LPUART and GPIO devices, and ocram spaces
You should also likely edit the title of the PR, just to make it clearer for reviewers

Thank you for reminding. I have correct the title for this PR.

Sorry to be such a stickler on this, but please include rt118x somewhere in the commit title. Currently the title doesn't really make it clear which device is being touched.
Something like
dts: arm: nxp_rt118x: Complement full LPUART and GPIO devices, and ocram spaces
or
dts: nxp: rt118x: Complement full LPUART and GPIO devices, and ocram spaces
In terms of relevance, it is much more important which SOC series devicetree we are touching than the fact the SOC definition is for an ARM based part

Sorry to be such a stickler on this, but please include rt118x somewhere in the commit title. Currently the title doesn't really make it clear which device is being touched.
Something like dts: arm: nxp_rt118x: Complement full LPUART and GPIO devices, and ocram spaces or dts: nxp: rt118x: Complement full LPUART and GPIO devices, and ocram spaces
In terms of relevance, it is much more important which SOC series devicetree we are touching than the fact the SOC definition is for an ARM based part

Sorry, I didn't notice that the first commit message you said also needs to be modified, I will change the commit message today.
Thank you for your stickler , it make me do better.😎

@lucien-nxp can you address the merge conflict

@lucien-nxp can you address the merge conflict

Sure, I have rebased my PR to the newest.


Improve forwarding

Add RAT test link for manually open in the CWA.
Add information about the settings to enable other Android browser to open the link in the CWA
Add apple-app-site-association to root folder
npm audit fix

Related to https://github.com/corona-warn-app/cwa-wishlist/issues/532


Standardize Liveblocks base URL config

We currently have these (hidden) config options:

liveblocksServer (in client)
serverEndpoint (in client, for Comments)
liveblocksBaseUrl (in our Node client)
liveblocksAuthorizeEndpoint (in our Node client)

These are all URL paths for each specific use case, but they all typically must be in sync and point to the same server backend in order to work.
We should deprecate all these different config options and replace them with a single new one:

baseUrl: "https://api.liveblocks.io"

…and then derive all of these various concrete URLs from that base value.
Context
See also, this comment and this discussion that followed it.

Fixed by #1240 , will land in 1.5.


Fix reading stale file data when replacing task

Description

Use .originalMarkdown in guard when replace task (discussed with @claremacrae already)
Adjust formatting of guard print when replace task
Fix reading stale file data when replacing task

Here, "stale file data" is defined as "not in sync with what the user is seeing on the screen", aka, "not in sync with the MarkdownView of the file that they have edited".
what happens is before reading the file, all open views that view the file that the task is contained in are forced to save.
please note I am not in favour of this as a solution and am very open to alternatives. I open this PR for discussion
Motivation and Context

To fix repro case discussed recently in #984
How has this been tested?

Locally in my vault with the specific repro case and seeing it no longer repro.
Screenshots (if appropriate)
Types of changes

Changes visible to users:

[X] Bug fix (prefix: fix - non-breaking change which fixes an issue)
[ ] New feature (prefix: feat - non-breaking change which adds functionality)
[ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (prefix: docs - improvements to any documentation content)
[ ] Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)

Internal changes:

[X] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[ ] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
[ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

[X] My code follows the code style of this project and passes yarn run lint.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] My change has adequate Unit Test coverage.

Terms

[X] My contribution follow this project's contributing guide
[X] I agree to follow this project's Code of Conduct

whoops, let me rebase this ...

whoops, let me rebase this ...

done :)

Thank you! I am trying this out.

please note I am not in favour of this as a solution and am very open to alternatives. I open this PR for discussion

OK - what don't you like about it?

OK - what don't you like about it?

It forces a save. If future versions of Ob allow a feature to disable autosave ... or altogether autosave is removed.
so it's a diff type of user data integrity concern ...

another issue I thought of is if there are multiple views all looking at the file that the task is in - which one has the "correct" data?

another issue I thought of is if there are multiple views all looking at the file that the task is in - which one has the "correct" data?

That's a good point.
I'm still testing this.
It does work really well for the cases where the inconsistent data was caused by un-saved edits... I'm trying to figure out potential pitfalls to test, but not making much progress.
I think I'll stop now and pick it up again tomorrow...

I have found I can get the output message even with the file auto-saved.
Here is my input: sample tasks for anti-corruption tests.md
And here is a video (no audio):
https://user-images.githubusercontent.com/4840096/219970608-df279721-52a1-49a8-a032-eebe9fccfb78.mov

WebStorm has been bleating about a missing await in File.ts, so I added that to see if it would fix the above - it didn't.
Here is the diff:
Index: src/File.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/File.ts b/src/File.ts
--- a/src/File.ts	(revision 3ca997eda0b621f25a0137e6390e4feea9a2295c)
+++ b/src/File.ts	(date<PHONE_NUMBER>977)
@@ -53,7 +53,7 @@
         newTasks = [newTasks];
     }

-    tryRepetitive({
+    await tryRepetitive({
         originalTask,
         newTasks,
         vault,

With this diff, the correct line does eventually get updated:
Index: src/File.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/File.ts b/src/File.ts
--- a/src/File.ts	(revision 3ca997eda0b621f25a0137e6390e4feea9a2295c)
+++ b/src/File.ts	(date<PHONE_NUMBER>835)
@@ -162,7 +162,7 @@
                         `Tasks: Unable to find task in file ${originalTask.path}.\n` +
                             `Expected task:\n${originalTask.toFileLineString()}.\nFound task:\n${line}.`,
                     );
-                    return;
+                    return retry();
                 }
                 break;
             }

The console output is a little confusing, as:

it first says it cannot update,
then it finds the cache is missing,
and then reads the updated file,
updates the task,
and re-reads the edited file with the edited task

I think that one issue with saving the leaves inside Obsidian is what if an edit to an open note came from outside Obsidian?
How would the auto-saving of all views of that note behave, if they thought they didn't have any edits, but there was an in-coming edit to the note from an external source...
For example, in testing, I do a lot of reverting of edits to markdown files from inside an IDE
But a more realistic case for users is when a sync program updates a file's contents, and Tasks has not yet had time to re-parse the file.

I have tried really hard to make the following clear and unambiguous. I doubt very much that I have succeeded, but I wanted to get it out of my head, and off my machine.
Just to note: I do have some refactoring ideas in mind that will make this relatively easy to implement in a clear way:

reducing complexity in tryRepetitive()
and hopefully enabling adding of some tests for the logic
and also allowing the same code to be used in tryRepetitive() and the Live Preview extension code.

Ideas for next possible solution of not finding task to toggle
Improve the algorithm for finding the task line in the file that exactly matches the line the user toggled

Try the following with the auto-saving code commented out
Instead, allow the 10-times retry code to act

Obsidian should work in the normal way, eventually saving and parsing
Keep the newly-added check for whether the found task line matches the task line being toggled/updated
Instead of giving up on the retry on 1st attempt if the exactly matching task is not found, keep trying
Don't print any messages out until the last attempt fails

Make sure the 10-times time out times add up to at least 2 seconds, or maybe a bit more, as that will ensure that any uncommitted edits were saved by the end of the attempts
If the last retry attempt fails:

Write out the error message from the 10th attempt, saying the line we were looking for, and the closest one found
Then have one last search, this time reading the file to find any exact matches for the line being searched for, based on string equality alone

So ignoring section info and task index info

This will enable us to fix the issue/warning to do with toggling tasks in callouts in Live Preview:

obsidian-tasks/LivePreviewExtension.ts at 5b0831c36a80c4cde2d64a6cd281bb4b51e9a142
It would also fix When a block-referenced task is made complete, it is completed after rewriting the contents of another task. · Issue #688

A refinement on the string-equality along last-ditched attempt just above would that if there is more than one exact-matching line in the file, then compare the section headings, to favour the line with section headings matching.

Other related improvements

Trivia: Remove the . from the end of task lines
Put in a specific message if the 'found' task is empty, to say that no match was found at all
Try to figure out how to prevent clicking on the checkbox of an un-found task being broken in reading mode by the addition of the error-checking/anti-corruption fix
When writing important info about mismatched task lines to the console, display in a notice too, so all users will get the info.
When writing out info that no matching task found, give the user actionable information, that is a Help message rather than in Error message.

Perhaps tell them to close the file and re-open it???
Or can we just tell them to wait a second or two?
Tell them that if they copy-and-paste to search in Obsidian for the task that was not toggled, then they need to not paste in the characters before the checkbox, so the search in Obsidian will work

The above idea is derived from this travis_simon Tweet.

@jessitron
Just renaming my variables from errorMessage to helpMessage is already making a difference in their quality. Rock on.

I'm going to do some more work in this area, including fixing some of the underlying problems, so I've merged, to build on this work.


Replace deprecated GetModuleFilename in Build.cs

This caused Visual Studio project file generation to fail in UE 4.12

Thanks for the catch!


Menu of examples

Resolved by https://github.com/softwareengineerprogrammer/geothermal-ui/commit/c51c0ed91cfdd80fe7dc8a7690622347a3759925


sample/drivers/counter/alarm: adapt test to driver change PR #25367

Due to counter driver implementation change introduced with PR #25367
"driver/counter/counter_ll_stm32_rtc.c: Add 1 tick to alarm"
It is necessary to adapt sample test (sanitycheck)
to take into consideration 1 tick precision/tolerance.
Fixes #25366

Commit added to #25367


[PATCH]Read synchronously for larger files while concatenating

Same changes as in https://github.com/broccolijs/broccoli-concat/pull/128, but uses this.inputPaths[0] to get base directory instead of this.inputNode as suggested here

released as v3.7.2 🎉


Silent events still play the annoucement sound

Description

Been hearing blobalarm.ogg and outbreak annoucements with no text on the chat. It's either that or fake alarms, but still weird
Reproduction

Screenshots

Additional context

Couldn't replicate locally by triggering events myself. They are properly not announced.
Perhaps only randomized events, or actually just false alarm.

Is this still an issue?
If not I propose changing this to a feature request for a bool for events on whether to announce them or not, and which grid to announce to if possible.
This would allow you to secretly run events on a grid like meteors without warning the crew (or starting zombies), similarly you could trigger an event like meteors that affects all local space, but only notify anyone in station, no local shuttles.


No function called

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.

Example Code
from langchain.chat_models import ChatOpenAI
from langchain.embeddings import OpenAIEmbeddings
from langchain.prompts import ChatPromptTemplate
from langchain.schema.output_parser import StrOutputParser
from langchain.schema.runnable import RunnableMap
from langchain.schema.messages import HumanMessage, SystemMessage
from langchain.vectorstores import DocArrayInMemorySearch
from langchain.utils.openai_functions import convert_pydantic_to_openai_function
from typing import List
from pydantic import BaseModel, Field
class PopulationSearch(BaseModel):
"""Get the population size based on the given city"""
city: str = Field(description="city")
population_function = convert_pydantic_to_openai_function(PopulationSearch)
model = ChatOpenAI(
temperature=0,
model_name="gpt4-turbo"
)
response = model.invoke("What is the population of Wuhan?", functions=[population_function])
print(response.additional_kwargs)
Description
The result is {}. Why is it empty value?
The screenshots are as follows:

System Info
Python version is 3.11
LangChain version is 0.0.343
Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Hi @Rainismer,  the model name wasn't populated correctly, try this:

from langchain.chat_models import ChatOpenAI
from langchain.embeddings import OpenAIEmbeddings
from langchain.prompts import ChatPromptTemplate
from langchain.schema.output_parser import StrOutputParser
from langchain.schema.runnable import RunnableMap
from langchain.schema.messages import HumanMessage, SystemMessage
from langchain.vectorstores import DocArrayInMemorySearch
from langchain.utils.openai_functions import convert_pydantic_to_openai_function
from typing import List
from pydantic import BaseModel, Field

class PopulationSearch(BaseModel):
    """Get the population size based on the given city"""
    city: str = Field(description="city")

population_function = convert_pydantic_to_openai_function(PopulationSearch)
model = ChatOpenAI(
    temperature=0,
    model_name="gpt-3.5-turbo"
)
response = model.invoke("What is the population of Wuhan?", functions=[population_function])
print(response.additional_kwargs)


added content to enable the pipeline for advance modernization

Added content to Enable the Pipeline for Advance Modernization Code

can you please work on the merge conflicts and resubmit

Merge remote-tracking branch 'upstream/dev' into dev
added content to enable the pipeline for advance modernization


[FLINK] support flink 1.17

Problem
Support flink 1.17
Solution
Run integration tests for three latest releases within branches 1.15, 1.16 and 1.17.

Note: All schema changes require discussion. Please link the issue for context.

[ ] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
One-line summary:
Checklist

[x] You've signed-off your work
[x] Your pull request title follows our guidelines
[x] Your changes are accompanied by tests (if relevant)
[ ] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Codecov Report

Merging #1947 (88f840e) into main (21c0450) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff            @@
##               main    #1947   +/-   ##
=========================================
  Coverage     81.68%   81.68%
  Complexity      103      103
=========================================
  Files            85       85
  Lines          3610     3610
  Branches         29       29
=========================================
  Hits           2949     2949
  Misses          626      626
  Partials         35       35

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Errors building proj 6.0.0 or later

This repo was a huge help because we needed vertical datum calculations from the proj library in our Android app.
I am having trouble building proj after version 5.2.0.   The build scripts of those versions use sqlite3 to build proj.db.  I modified proj.Dockerfile with the following in bold (after successive errors with pkg-config, then sqlite3 binaries, etc.), but it still can't find sqlite3.h even though it should be placed in /usr/include based on my manual tests in a working docker image for 5.2.0.   Is there a way to append the include path in the docker build?
Changes to proj.Dockerfile
RUN apt-get update && apt-get -y install
wget \
pkg-config \
sqlite3 \
libsqlite3-0 \
libsqlite3-dev
I also tried adding this line to the Dockerfile but that caused a bunch of other errors:
ENV CPATH $CPATH:/usr/include
Excerpt from build output:
#9 14.95 libtool: compile:  arm-linux-androideabi-g++ -DHAVE_CONFIG_H -I. -DPROJ_LIB="/proj-build/share/proj" -DMUTEX_pthread -I../include -Wall -Wextra -Winit-self -Wunused-parameter -Wformat -Werror=format-security -Wno-format-nonliteral -Wshorten-64-to-32 -Wshadow -Werror=vla -Wdate-time -Wnull-dereference -Wextra-semi -Wcomma -Wfloat-conversion -Wdocumentation -Wno-documentation-deprecated-sync -Wunused-private-field -Wmissing-prototypes -Wmissing-declarations -Wnon-virtual-dtor -Weffc++ -Woverloaded-virtual -Wweak-vtables -Wdeprecated -Wabstract-vbase-init -Winconsistent-missing-destructor-override -fno-operator-names -Wzero-as-null-pointer-constant -DPROJ_COMPILATION -g -O2 -fvisibility=hidden -MT gridinfo.lo -MD -MP -MF .deps/gridinfo.Tpo -c gridinfo.cpp -o gridinfo.o >/dev/null 2>&1
#9 15.40 iso19111/factory.cpp:66:10: fatal error: 'sqlite3.h' file not found
#9 15.40 #include <sqlite3.h>
#9 15.40          ^~~~~~~~~~~

I am also attempting to build a later version of the PROJ library (9.1.1), and I can provide some suggestions (even though this issue is months old).
First, I suggest using BAD to build a version of SQLite3 for Android.  I have successfully built SQLite 3.40.0 without any modifications of the dockerfile.
Next, update the PROJ docker file to pull the SQLite3 dependencies from the previously built docker image:
FROM bad-sqlite3:3.40.0-$ARCH AS sqlite3-dep
COPY --from=sqlite3-dep /sqlite3-build /sqlite3-build

Later versions of PROJ have switched to cmake, so you'll need to modify your configure line to use cmake instead:
RUN ./cmake -DSQLITE3_INCLUDE_DIR=/sqlite3-build/include -DSQLITE3_LIBRARY=/sqlite3-build/lib/libsqlite3.so -DCURL_INCLUDE_DIR=/curl-build/include -DCURL_LIBRARY=/curl-build/lib/libcurl.so  -DENABLE_TIFF=OFF ..

The build process can locate SQLite3, and continue on from there.  However the build will then fail due to some issues with pthreads.
Perhaps you'll get further than I have.  Good luck!


Add missing pylibmc client methods; adds graceful handling of memcached errors

The most straight-forward part of this that I think you'll agree with is that you weren't wrapping some of the base pylibmc client methods with @invalidate_cache_after_error.
Also changed this to log errors as warnings with exception info (in case of a logging config like raven/sentry) and instead of raising the error, treat them as cache misses.

Any chance on this getting merged into master sometime soon?

i defenitly agree to wrap with that decorator missed methods, but i'm not sure about returning None in case of error. For instance if i try to set value to cache and server is down (problem with network etc) i'm expecting to get real error with traceback instead of silent None.

@gusdan That is why it logs a warning, and I could be easily convinced to change that to an error.  However let me explain that for our use case of caching mostly static replies from web services that do not change, that if a cache miss occurs we want our clients to make a call to the service to get that information instead of failing hard because of a caching error.  Our caching layer is to help with performance but should not cause requests to fail out right, and returning None is the way to treat it as a cache miss.  Since this library is already a wrapper of pylibmc that would leave me with two options:  Keep a fork of this library for our projects to use or to write my own extra wrapper layer above this to catch those errors and treat them as cache misses (yuck!).
By logging a warning or an error we can hook into the Python logging configuration w/ the Django settings to specify a Sentry server and other ways of alerting us that the caching layer is having problems, but without explicitly trying to fail the request.   That is our use case -- and I encountered this problem heavily before I got deep into memcached configuration and realized that increasing the AWS host size isn't going to increase the compiled key space for memcached, so we were overrunning the key space and running into all kinds of caching errors related to it (whereas having more smaller nodes in the cluster actually increases the key space in a properly configured cluster).
I suppose it comes down to your use case if you would prefer that cache errors bubble up as real exceptions, or if your applications already handle cache misses gracefully then alerting and moving on is probably your preferred strategy.

By default django memcache backend does raise errors. If memcache stoped we have 500 error it's bad. But if we stop raising errors and for instance don't connect our logger to senty we won't see any errors and we will think "everything is ok, system works as usually" but memcache is not working and our system is working under high load and using more resources (cpu/machines) than needed.
So i still think it's better to explicitly raise errors as django does it by default. Of course i agree that in your case when cache is not important part of system and we have sentry handler in root logger we can skip raising errors. But it looks like specific design for specific architecture and i don't think it should be default behavior.

Well there is some gray area to what you are saying about the Django default, because while I agree that the default for the code that is specifically checked into the django.core.cache.backends.memcache you are right -- it will raise any error that the client library raises.   As the Django documents suggest "After installing Memcached itself, you’ll need to install a Memcached binding. There are several Python Memcached bindings available; the two most common are python-memcached and pylibmc."  In the case of python-memcached, which is the library we converted away from in order to move to Auto Discovery, we find that:
"It turns out that socket operations that fail in python-memcached don’t return an error or raise any exceptions. Calling .get() on a dead server returns None on failure, the same thing that is returned when there’s no value."
So immediately upon switching to some wrappers of pylibmc found that additional errors were being raised whereas before they were not, you can see that the default choice for Django memcache is doing some exception handling here:   https://github.com/linsomniac/python-memcached/blob/master/memcache.py#L1045
What about having a Sub-Class of ElastiCache that didn't raise the errors and then a user of this library could pick the desired behavior for their application by selecting which cache backend to use?


Explorer not displaying the recursive relationship correctly

I'm running this query both in KuzuExplorer (latest, see screenshot) and CLI (0.4.2). Explorer does not seem to draw the output recursive rel as expected. Here's the query:
MATCH (p1:Person)-[o1:Owns]->(a1:Account)-[r:Transfer* SHORTEST]-(a2:Account)<-[o2:Owns]-(p2:Person)
WHERE p1.email =<EMAIL_ADDRESS>AND p2.email =<EMAIL_ADDRESS>RETURN *;

The output is as follows on the shell and contains 3 internal edges that bind to r:

However the output on Explorer shows only 1 edge (the middle edge). The other two edges are not drawn:

The table view of Explorer seems to have the correct output with 3 edges:

You can replicate by cloning the datasets and graph here: https://github.com/kuzudb/cypher-workshop/tree/main (except I made 2 changes to the datasets: 1) Removed the last transfer in transfer.csv "5,8,257,47231669"; and 2) changed the address of "+10,Rhea,"1919 Joshua Square Suite 643, Carmen Town, WY<EMAIL_ADDRESS>so that Rhea lives in the same address as George (georodaw366@hotmail.com). This creates a second 5-length path between George and Edward (ezimmerman@yahoo.com).

There are two issues.

The kernel seems to return edges in both directions, which @andyfengHKU will address.
Explorer is handling multiple edges between nodes incorrectly. It should not draw these edges with overlaps. I am working on fixing it.

Also, it might be nice to add a feature to trace/highlight each path returned from recursive query. I will create a new issue for this.

Overlapping edge handling has been addressed in #164.

This is fixed with the latest nightly build 0.4.3-dev.47 and dev version of Explorer:


Fix for combined change types

Filtering out timed_segment and new_profile from combined change types

 <2> [uploader] [device] final bugfixes for initial Tandem prod release

LGTM Third time's the charm?


[Feature Request]: Add "Ecotop light" to device description

The Screenshot of the integration says "Therminator von Solarfocus", in my case this should read  "EcoTop Light von Solarfocus",

I assume this could be accomplished by selecting the Solarfocus System during setup of the integration.

Will be done with #48

fixed


email address<EMAIL_ADDRESS>is restricted and not a valid contact

ERROR:
Your message to the group<EMAIL_ADDRESS>couldn't be delivered.
The group AzureFilesMigration only accepts messages from people on its allowed senders list, and your email address isn't on the list.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85596de7-35df-052e-577d-91113e780798
Version Independent ID: 3cde97c4-8b1c-9754-c814-fba341d03b08
Content: StorSimple 8000 series migration to Azure File Sync
Content Source: articles/storage/files/storage-files-migration-storsimple-8000.md
Service: storage
Sub-service: files
GitHub Login: @fauhse
Microsoft Alias: fauhse

@javester
Thanks for your Question! We are currently investigating and will get back on this.

@javester The PR request has been raised
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


feat: trigger annotation modified event on textbox moving

This should close #274 , set invalidated attribute as true on textbox moving

Looking quickly at this, we don't want annotation calculateCachedStats to be re-calculated everytime textBox moves, that is not efficient at all

Looking quickly at this, we don't want annotation calculateCachedStats to be re-calculated everytime textBox moves, that is not efficient at all

Is it fine for you to do it on mouse up event?

@sedghi, please take a look again. Events are being triggered on mouse up callback right now.

I don't understand how does movingTextBox is true when mouse up. I don't think that fixes your problem


Implement verification of CopyValueInst and DestroyValueInst.

[semantic-arc] Implement simple verification of the ownership qualification of copy_value, destroy_value.
rdar://28851920

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

The linux failure looks unrelated.

@swift-ci Please smoke test linux platform


Version 1.4.3. breaks docs generate because of missing TableType parameter.

Hello, we are having issues with generating docs with the versions 1.4.2 and 1.4.3, although dbt run and dbt test passes without problem. The command fails with
Encountered an error while generating catalog: 'TableType'
dbt encountered 1 failure while writing the catalog

but the only connected messages in the log are such as :
[0m11:37:35.551755 [debug] [ThreadPool]: Athena adapter: Table 'abc_xyz' has no TableType attribute - Ignoring

for 5 (of 140) our tables. No other warn or error message in the log.
Also, we see no difference in Athena settings for these particular tables.
Used libraries:

boto3==1.26.101
pyathena==2.24.0
dbt-core==1.4.5

Revert to version 1.4.1 helps - it passes without any issue.

@junckritter Could you run dbt -d docs generate? and copy the output?
The issue could be releate to this line: https://github.com/dbt-athena/dbt-athena/pull/174/files#diff-629c67ee6aeee24555537b786b7560cbf4d17496c1388aa932de34081c76f668R254
Could you tell us more about the tables where it breaks?
Ideally for those table you  run this:
import boto3
glue = boto3.client('glue')
table = glue.client.get_table(
    DatabaseName='your_db',
    Name='your_table_name'
)

and the you copy the content  of table (trimming out sensitive data of coure), that could help us to find it more about the table that we are dealing with. Many thanks!

I can confirm that the param 'TableType' is missing in the received dictionary, unlike for other our tables. The probable cause is way of the creation for problematic tables - they were created from the code using API (i.e. boto3). All the others were created either via Glue Crawler or with Athena's CREATE TABLE query. It is even mentioned in the docs that this param would be missing when the table is created via API.


Is the CPU usage supposed to be this?

The paper says "low-resource voice conversion". Using the provided infer script, my CPU usage is at 55% with a Ryzen 7 3800x 8 core
Is there any reason the inference script is high on CPU? Are there any quick optimizations to be made here? Voicemod is achieving real time conversion with 8-10% cpu usage in comparison, so I was expecting this to work similarly or better

Would really love an answer as to how to optimize this

AFAIK Voicemod doesn't use any ML or AI models, it's just plain algorithms of audio processing (echo, pitch, distortion etc.) that's why it's so fast

@mlatysh Interesting, that's my suspicion but they advertise AI voices all over the places. Though entirely possibly they mean something else entirely


Implement hedging policy

Hedged executions can be made at the same time as the initial execution, or after some delay between attempts.
Factory methods:

WithDelayFn(fn, maxExecutions) - so that callers can compute a delay that matches the p95 latency.
WithBackoff(min, max, maxExecutions)
With(executions) - in this case, maxExecutions would be sent at the same time.

Features:

Indicate whether a result came from a hedge (or a retry)

This is now in main.


Investigate xtend requirement

We already are using some es6 transforms, can we get away with using object.assign? Or doing something ourselves?
Possible Solutions
Use Object.assign, see if the tests pass on IE and phantomjs
Tests
Run all the tests on IE and phantomjs

Looks like it's here to stay, at least while IE still requires it.
PhantomJS is a soft requirement, and can be removed in support for Chrome Headless


 Love your project!

Thanks! Was just a simple oversight by me.


SCHEMA: Uniformize rules

This PR aims to achieve consistency throughout the schema.

[x] Use consistent syntax for issues ({issue: {code: ..., message: ..., level: ...}})
[x] Use requirement level as a bare string on fields sidecar rules unless there are additional subfields
[x] Eliminate redundant checks when encountered
[x] Conform modality strings (currently have "mri" and "MRI"
[x] Conform all selector and check expressions according to the current state of #1080

I believe this is good to go. Nothing currently backwards incompatible, but some additions motivated by a couple of checks.

Bump @rwblair.

Haven't merged any of the function injections into the context eval space so most of these will fail in schema prototype validator. No need to put the cart in front of the horse if our expression language is done changing, I'd be fine with merging these right now.
Should there be a version bump?

Haven't merged any of the function injections into the context eval space so most of these will fail in schema prototype validator. No need to put the cart in front of the horse if our expression language is done changing, I'd be fine with merging these right now.

However works best for you. I could factor out the expression changes, if you'd rather those be a separate PR.

Should there be a version bump?

Probably. I'll do that.

Will the NIRS branch need to be updated with changes introduced here? If yes, would you mind going the extra mile and taking that on @effigies?

master merged cleanly into bep030. Looking at the PR, I don't see any of the violations I was cleaning up in here.


Message inputText is not being converted from ascii in local debugger

I have been messing with the local debugger, and it seems that the input text is being output as an ascii array. For example if I put "emmaniii" into the input, I get 101,109,109,97,110,105,105,105 when accessing the inputText variable.
Is this intended?

getFrameMessage formats this
  const inputText = inputTextBytes     ? Buffer.from(inputTextBytes).toString("utf-8")     : undefined;


Extract git-crate in order to prevent circ. dependencies

Requirements:

establish ssh-trust to target server
express git url for https & ssh
user credentials per git-server
git global config
switch origin between https / ssh


store.dispatch(actionCreator()) in history listener makes action creator work weirdly

// history.js
history.listen((error, nextState) => {
     store.dispatch(aC()); // making this 'setTimeout(() => store.dispatch(aC()), 0)' solves problem
});

// actionCreator.js
export function aC () {
    return dispatch => {
        dispatch(aC1()); // => suddenly call this function body again, kind of 'recursively'
        dispatch(aC2());
    }
}

I was debugging this and found this behavior. Am I supposed to leave store.dispatch out of history listener?

Yes this may lead to some trouble. We are trying to keep history and the store in sync. Which uses a combination of history.listenand store.subscribe. So dispatching something in your history.listen function may very well screw some things up.
If you want to do some dispatching work on history/route changes you may have to fallback to using React lifecycle methods or hooking in your own middleware to listen for redux-router actions.


Review date/time support in generated Java code

Currently, Sysl-generated Java code works with Joda-Time to managed date/time information. Java 8 has better date/time support and so we should think about what the right solution looks like.

Where I'm working at the moment there will be a need to support java 7 for a while yet, as well as java 9, therefore I would suggest providing support for both Joda and native Java types, and use some kind of feature toggle or configuration option to the java generator to switch between the two.


Features/page visit time

Initial page visit time feature implementation.
First time "typescripting" so want to get initial feedback before adding tests.
Spec for feature can be found here: https://microsoft-my.sharepoint.com/personal/yossiy_microsoft_com/Documents/Functional Spec - Page visit time.docx?d=w088104dc384f4ac8b944948f5dc3d1c3
Changes include:

Added trackPageVisitTime() method to send metric of time spent viewing a page.  Currently sending a CustomMetric, but will send a dedicated metric in next phases.

Added ability to auto-track page visit time. If auto-track is enabled (for phase 1 default is disabled):
a. When trackPageView() is called, the SDK also calls trackPageVisitTime() for the previous page visited (if exists).
b. Added PageVisitTimeManager class which is in charge of storing pages visited using session storage in order to achieve 2a.
c. PageVisitTimeManager exposes 3 methods: restart, stop, and start.  Stop returns previous page viewed (if exists in session storage) and clears storage.  Start adds page passed in to session storage (along with current time for start time).  Restart calls stop, stores return value, calls start, and returns the value stop returned.

Hi @giladsu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Gilad Suberri). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Thank you Gilad! Looking forward to seeing tests in place and the whole feature checked in and going live!

Thanks for contributing, @giladsu! Could you add details about the proposed feature and API usage scenarios to the description of this pull request?

:shipit:


Add refile_to_headline

#196
Haven't written a test yet but would appreciate feed back on whether it looks like a good implementation, thanks

This looks ok. I don't think you need to throw an error, just let it refile to the end of the file if there's no headline found.

just fixed the lint, I see that there are no tests yet, I'm pretty confused on how I would write one for this. Could you give me an example of how one might look here?  I've taken a look at the agenda and template spec.

It's a bit tricky to write tests for this because it manages multiple buffers. It's ok to not have test for this for now.

Looks good, thanks!


It works from command line but not from within a python script

Hello, thanks for pproxy, it's very useful. One problem I am facing is that the following command works well (I can browse the internet normally)...
C:\tools>pproxy -l http://<IP_ADDRESS>:12345 -r socks5://<IP_ADDRESS>:9050
Serving on <IP_ADDRESS>:12345 by http

...but the following script, with the same schemes and settings, doesn't work (I get the error at the end of this issue):
import asyncio
import pproxy

server = pproxy.Server('http://<IP_ADDRESS>:12345')
remote = pproxy.Connection('socks5://<IP_ADDRESS>:9050')
args = dict( rserver = [remote],
             verbose = print )

loop = asyncio.get_event_loop()
handler = loop.run_until_complete(server.start_server(args))
try:
    loop.run_forever()
except KeyboardInterrupt:
    print('exit!')

handler.close()
loop.run_until_complete(handler.wait_closed())
loop.run_until_complete(loop.shutdown_asyncgens())
loop.close()

The error I got:
http_accept() missing 1 required positional argument: 'httpget' from <IP_ADDRESS>

It is a bug that occurs with http server api. Please upgrade to v2.7.4 to get it fixed. Thanks

@qwj it's working as expected now! Thanks!


Notifications fires multiple times. then web app opened in multiple tabs in each tab

Is it possible to check scope for each Pushy Instances?

Hi @failhunterby,
Thanks for reaching out. We'd be glad to assist.
If the notification arrives multiple times, please ensure you aren't sending to multiple Pushy device tokens belonging to the same user.

So. it was an scope issue, ill checked your source code, find serviceWorkerScope option, set is as "/" and it works. TY

Hi @failhunterby,
Thanks so much for letting us know how you managed to resolve the issue.
We've just released version 1.0.11 of the Pushy Web SDK which changes the default service worker scope from ./ to /. This effectively works around the issue you encountered with multiple device registrations when calling Pushy.register() from multiple subdirectories.
If you're using JavaScript modules, install version 1.0.11 of the Pushy Web SDK from npm using the following command:
npm install pushy-sdk-web@latest --save

Alternatively, import version 1.0.11 by adding the following line to the  tag:
<script src="https://sdk.pushy.me/web/1.0.11/pushy-sdk.js"></script>

Please let us know if there's anything else we can help with.


Fix issue 15884 Encode wstring/wchar[]/dstring/dchar[] as JSON string

This fix will now encode all string types, mutable and immutble, as JSON strings:
    wchar[] wstr = "a"w.dup;
    JSONValue testValw = wstr;
    assert(testValw.type == JSON_TYPE.STRING);

https://issues.dlang.org/show_bug.cgi?id=15884

For now, I've considered static arrays out of scope for bug 15884 so let's just get the simple cases done. It's easy to convert a static (or any) array to a dynamic one by just adding a pair of [].

@DmitryOlshansky I saw you had merged PR#4176 from @BBasile before. This is an extension of that. Please check.

LGTM

Auto-merge toggled on


This is not fixed yet by PR #2902 but I think it possibly could be fixed using the work in that PR. Still investigating.

@alissapajer here's structure_test_deep:
{ "a": 1, "b": { "ba": { "innermost": true }, "bb": ["x", false, { "foo": "bar" }], "bc": 0.5 }, "c": [] }
{ "a": 2, "b": { "ba": { "innermost": false }, "bb": ["y", true, { "foo": "baz" }], "bc": 60 }, "c": [true, false, "maybe"] }
{ "a": 3, "b": { "ba": true, "bb": ["z", { "foo": "quux" }] }, "c": null }

@garyb is this issue blocking all use of the structure editor? Or are you able to use the structure editor in some contexts?

My $.02 -> is that the structure editor would still be usable in a lot of contexts. Getting into this state is possible with nested data and multiple operations - which we can advise users against to begin with.  Hence moving this to the 4.4 epic. @garyb if you disagree ,please do comment. Thanks

It's fine applying one edit, quite slow applying two, and explodes like this on three. Adding cache cards in between edits will help, but unless we force that it's a bit risky to let through IMO.

Right - can we add a caveat  around > one edit for now and address in 4.3.x (i take it this was a column - rename correct?)

@alissapajer, @wemrysi, @garyb -> This is back in scope, based on the commentary at https://github.com/slamdata/slamdata/issues/2386. It seems that the options are

either fix this and release structure editor.
or do not release structure editor.
So we need some investigation on this and an opinion on level of effort.

@alissapajer So the qscript generated here is still very large.  Doesn't appear to contain any joins (good!), and generates very quickly, but it's large.  Do we consider this provisionally-fixed?

@djspiewak let's consider this fixed when the generated qscript is correct (regardless of its size). The logical plan is also pretty big. If the qscript is correct, but there are connector-specific bugs, then we can open separate issues for those.

How does this query run against mimir and mongo?

Thinking about this more, if the qscript is correct but we can identify areas where it could be smaller, then I'm thinking we should close this issue when qsu lands, but then open a new issue tracking the too-verbose qscript.

Ironically the easiest way to test this might be to just run the query.  Haven't done that yet against any backend.

@garyb When you get a chance, can you re-test the structure editor on quasar 27.0.0 or higher?  I tried compiling the query in the OP (modulo the new function names) and it now compiles in less than a second (from the REPL), and the qscript looks reasonable.  I'd be very interested to know whether or not the underlying issue is resolved, and if the structure editor is now usable at reasonable depth.

(Moving this from a Slack message I sent to Daniel)
Ok, so unfortunately it's still kinda slow quite quickly, but it doesn't completely explode now: https://gist.github.com/garyb/6ffc22924376c59ef28b128660371ae8
It takes a few minutes to run this 4-step structure edit for me.
(Something else we discussed is that the initial example here returns the empty set)
None of these 4 operations seem to have any issues when I've tried applying them at various levels of the structure, but doing the flatten operation does seem to always result in an empty set. I'll dig into that a bit more and provide a minimalish example.

@garyb can you open new issues for any new findings regarding structure editor queries? We're going to close this one out when we add a test showing that the initial query in this issue compiles. And then we can dig into other bugs separately.

Results:
Query time: 194.6s
 a  | b.bc | b.bd   | b.bb[0] | b.bb[1] | b.bb[2].foo | b.be[0] | b.be[1] | b.be[2] | b.be  | b.ba  | b.bb[1].foo |
----|------|--------|---------|---------|-------------|---------|---------|---------|-------|-------|-------------|
  1 |  0.5 |   true | x       |   false | bar         |         |         |         |       |       |             |
  2 |   60 |  false | y       |    true | baz         |    true |   false | maybe   |       |       |             |
  3 |      |        | z       |         |             |         |         |         |  null |  true | quux        |

Also an absurd amount of qscript…

Ok, proud developer moment… That 400k node qscript generates in just 56 seconds.  Most of the 200s total runtime on the query is in evaluation.

I'm satisfied that the issue described in the OP is sorted for the moment (which is to say, horrendous compilation times).  @garyb When you get a chance, can you open a fresh issue for the performance of the queries involved in the structure editor?  This is probably going to end up being a bit of a serious investigation, but maybe we can find some query tweaks which will allow it to collapse a bit more.

Some random math…
7 * 7 * 7 * 9 = 3087
This is the amount of expansion you're going to get due to the number of inner-references you have.
The outer freemap has about 18 operations.  So we actually have an even more horrible expansion:
18 + 7 * 18 + 7 * 7 * 18 + 7 * 7 * 7 * 18 = 7200 operations
But that's without including guards, and there are guards everywhere.  What's worse is guards double up their parameters.  Each operation is going to have at least one guard, which is a doubling per guard:
18 * 2 + 2 ^ 18 * 7 * 18 * 2 + 2 ^ 18 * 7 * 7 * 18 * 2 + 2 ^ 18 * 7 * 7 * 7 * 18 * 2 = 3,765,436,452
I'm actually kinda impressed that we ONLY ended up with 400,000 nodes.  My guess is that I'm overestimating the number of guards with doubled contents, or under-estimating the value we can get out of Hole.
Either way, this query is nuts.  One way that we could probably bring it down a bit is to be less crazy with guards.  Or at the very least, allow them to collapse together.

@djspiewak is there a reason you reopened this?

Ah, probably because of this comment https://github.com/quasar-analytics/quasar/pull/3180#issuecomment-346902943

My plan was to just let it close with the PR.


@conda-forge-admin update team

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I updated the team with maintainers from master.


Hardcoded connection string in import migrator

https://github.com/CartoDB/cartodb/blob/78922fb2e887ceda09f1acfd536ba2839d3ea08c/lib/importer/lib/cartodb-migrator/migrator.rb#L28

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Consider a FixerClient to seperate the HTTP infrastructure code.

FixerClient will act as a wrapper around HttpClient, this will help in following

Allows to neatly implement a Singleton access to HttpClient.
Moves GetFixerUrl from Fixer Facade
Allows to expose a public method such as UseHttps()  to support https connection #11

I like this idea 👍
I may not have much time to work on this with the holiday period coming up, but if you'd like to raise a PR, or even some sample code in here I'd be happy to take a look 😃
I'd like to keep the public API as small as possible and have the Fixer class manage all singleton access to this new FixerClient if possible, though I think this is what you're suggesting anyway!
Cheers.


Port Weather_CLI to be able to run on Windows

Description
It will help expand the potential user base for Weather_CLI if it could be run on Windows as well as Linux.  If it is possible and someone can figure out a way to do it, the documentation should be changed to include the method.
Request
Update the documentation file Weather_CLI_DOC with step-by-step instructions on how to get Weather_CLI to work on Windows.
Suggestion
WSL looks like a good possible solution.

WSL is definitely the way to go for this.  Here is a proposed solution to be added to the docs:
Windows Install (only need to do this once!):

Open PowerShell
Install WSL (Windows Subsystem for Linux) with this command wsl --install
Enter in a Username and Password (it can be anything you like)
When it is completely finished, exit out of PowerShell

Windows Run

Open PowerShell
Type command wsl -e ./weather-cli

But, I cannot verify if this works.  If someone using Windows would try this and report problems, it would be very helpful in solving this issue.


MXNet C++Interface, run image-classification-predict.cc example cannot exits normally

When I run the MXNet C++Interface example image-classification-predict.cc in windows7 with visual studio 14 2015, it cannot exits normally.
If I comment the mxnet predictor free api MXPredFree(pred_hnd);, then it exit successfully.

Can you describe the error in more detail?


VUID 04451 Introduces new validation errors for all apps running on MoltenVK (and any other portability platform)

Due to the nature of VUID 04451, any existing app running on a portability platform (e.g., MoltenVK, gfx-rs) running validation will encounter new validation errors. This issue is to confirm that this is indeed the intended behavior, which will require all of the aforementioned apps to update.
While this makes sense functionally (as the portability validation will not occur if the extension is not enabled), we were surprised by the new error, which means that other folks will almost certainly be surprised as well. Perhaps some additional messaging or communication would be helpful to ensure developers targeting a portability platform are better prepared for this change?
For reference, VUID 04451 states:

If the VK_KHR_portability_subset extension is included in pProperties of
vkEnumerateDeviceExtensionProperties, ppEnabledExtensions must include
"VK_KHR_portability_subset".

FYI @mark-lunarg @karl-lunarg

It feels like existing applications (such as vkcube) should not be impacted by this; that would be compatibility breaking. There should be some way to not have those devices in vkEnumerateDevices by default unless the app expects it.

From my understanding this is expected behavior. If a driver exposes VK_KHR_portability_subset, it is telling the app (again, from my understanding), it does not adhere to the vulkan spec proper, and the app must enable the extension to effectively say, "yes, I'm aware this is not a proper Vulkan implementation I'm running on, and I will make the appropriate queries to make sure I don't crash."
In the case of vkcube, it was only impacted on platforms that expose VK_KHR_portability_subset (e.g., where we encountered it, MoltenVK), and I believe that is the expected behavior.
There are others (@billhollings?) who can explain this far better than I can, though.

Just an FYI, vkCube was updated recently to show the proper way to query for these extensions and no longer throws this validation error itself.

@ncesario-lunarg But how is an app from before the existence of the extension even supposed to look for it. Say I install something with portability implementation, I do not want it to break all my games and stuff, right?

@krOoze I interpret the issue you are raising (selecting from conformance and non-conformant options) as different from the original issue (legacy apps being confronted by a new and unexpected validation error).
If you want to summarize the discussion into a separate issue, that would be helpful.
And thanks for raising the issue you have!

Alright, it is now Issue #18.

Thanks!

This issue can now be closed. With the implementation of the VK_KHR_portability_enumeration extension in the Vulkan loader, Vulkan applications will no longer get unexpected validation errors.


Switch from excluding to explicitly including form fields in ModelForms

It's discouraged to use exclude =  instead of explicitly including available fields in ModelForms. Especially in Oscar we should always use the explicit white-listing approach, because a custom deployment might override the model and inadvertently make a new field available.
We have been switching to the preferred syntax when we stumbled upon the old syntax. But it just caused an issue in my work, and there's not many forms left, so let's get that sorted by switching to the white-list syntax with fields = .

Implemented in PR #1682

PR is merged.


Upgrade dashboard and fix space handling. Fixes #334, Fixes #343

@mikedanese @colemickens I did not dig through too much for why the space to | handling was done the way it was done but it introduces bugs where the value of a config item has space Ex: "VM Network" gets converted to "VM|Network" which breaks terraform. I tested it for vSphere and the JSON generated looks fine and the deployment works.


Replaced deprecated datetime.utcnow() with datetime.now(datetime.UTC)

Fixes: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
datetime_now = datetime.datetime.utcnow()
warning that shows due to change in the behavior of datetime module in latest python

Yes. You are right @kurtmckee. Sorry for hurrying in opening the PR without understanding the complete picture.


Earlgrey: increase support for unpacked arrays in yosys

Some files of earlgrey uses unpacked arrays (e.g. ibex_multdiv_fast, ibex_wb_stage). Yosys doesn't have enough support for them to correctly generate working bitstream on HW. We need to extend support  for them to be able to parse earlgrey without changing unpacked arrays to packed.

Fixed in uhdm-plugin: https://github.com/SymbiFlow/yosys-symbiflow-plugins/pull/145. Closing.


create julianum.txt

This is for eu Domain

Official Website: https://julianum.de/
Mail Domain: julianum.eu

@BitClientDE Pull request merged. Thank you!


HW5

Lets see if i got the correct in 1 try.

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 3

Complexity increasing per file
==============================
- Src/BootCamp.Chapter1/ArrayOperations.cs  9

Clones added
============
- Src/BootCamp.Chapter1/ArrayOperations.cs  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 3

Complexity increasing per file
==============================
- Src/BootCamp.Chapter1/ArrayOperations.cs  9

Clones added
============
- Src/BootCamp.Chapter1/ArrayOperations.cs  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 3

Complexity increasing per file
==============================
- Src/BootCamp.Chapter1/ArrayOperations.cs  8

Clones added
============
- Src/BootCamp.Chapter1/ArrayOperations.cs  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 3

Complexity increasing per file
==============================
- Src/BootCamp.Chapter1/ArrayOperations.cs  8

See the complete overview on Codacy


How to configure HeroTransitions/Hero, with this Example, Get reference of view controller

@mohanbright,
Closing this as this project has been deprecated in favour of Native Flow controllers / Coordinator pattern.
Don't hesitate to reach out if you have any questions :)


Serve public Whitehall assets from asset manager

We've introduced a new endpoint for the Asset Manager API to allow us to add Whitehall assets. This new endpoint is necessary, because, for now, we need Whitehall to tell Asset Manager the URL path at which the asset should be served. We haven't yet added this endpoint to gds-api-adapters nor is Whitehall using it.
We've also introduced a new Asset Manager route and controller to serve these publicly-accessible Whitehall assets based on the functionality in Whitehall's PublicUploadsController. No such assets exist at the moment and in any case no requests for such assets should be made at the moment.
The image placeholder used when an asset is being virus scanned is now served by Asset Manager as a Rails pipeline asset (see https://github.com/alphagov/govuk-puppet/pull/6502 & https://github.com/alphagov/asset-manager/pull/199); whereas the HTML placeholder is still served by Whitehall. There are a couple of small differences in the behaviour when an asset does not exist or is being virus scanned - see commit notes for details.

@chrisroos & @chrislo: I'm not 100% sure I've captured everything I need to in this PR, but I think there's enough here to ask you to have a look and see what you think.

@chrisroos: Thanks for reviewing.
I'll get the branch rebased against master, resolve the conflicts and force push in preparation for merging.


[BEAM-4006] Futurize transforms subpackage

This pull request prepares the transforms subpackage for Python 3 support. This PR is part of a series in which all subpackages will be updated using the same approach.
This approach has been documented here and the first pull request in the series (Futurize coders subpackage) demonstrating this approach can be found at #5053.
R: @aaltay @tvalentyn @RobbeSneyders @charlesccychen

Yes, sorry for that! Should now be cleaned up :-).

Run Python PostCommit

Run Python PostCommit

Run Python PostCommit

Run Python PreCommit

Run Python PostCommit

Unfortunately, this change is seen to produce a ~15% regression in internal Dataflow benchmarks.  We have to investigate this regression before merging.
CC: @tvalentyn

Unfortunately, the ifilter change here (https://github.com/apache/beam/pull/5729#discussion_r201973087) doesn't fix the regression.

I did not benchmark changes in c270644 yet, but doing bisection on previous version of the PRs shows that the largest contributor to regression is the line from __future__ import division in util.py. I still don't understand the reason why it causes the regression. One place where we may have missed to modify division is https://github.com/Fematich/beam/blob/c2706447a6a602614c2f9bf36db1a666fa938819/sdks/python/apache_beam/transforms/util.py#L277 but changing division there to integer division does not seem to help. Looking further.

With latest round of experiments, we finally got to the bottom of this performance regression, see: https://issues.apache.org/jira/browse/BEAM-4858. I will also put some details inline in util.py.

I'm taking a look at c270644. I don't believe @total_ordering was an issue, but I'll see if the change makes a difference, I also started working on a microbenchmark but stopped pursuing that direction once I saw that  window.py changes were not the main offender. I'll take a look at your microbenchmark as well.
Since we now know how to make a have Py3-compatible version of this change that performs comparably well, the rest of performance testing won't take much time.

Run Python Dataflow ValidatesRunner

Thank you @Fematich and all the reviewers!


KiCad version

Hi, I'm using KiCad 5.1.5 on Ubuntu 20.04 and can't open the schematics. Which version you are using? Thanks, nice project!

Yes, I can use the PDF and make my own design, because I want to use only your high voltage generator for another function. But I want to know exactly what transistor you used, because I looked for one with similar characteristics (MOSFET N-CHANNEL 200V 1A) on Mouser and Digikey, and they are very expensive and with packages that do not work for me. Did you buy it at LCSC? could you provide the link? Thanks

You can look into the production files here https://github.com/cnlohr/cnixxi/blob/master/nixitest1/nixitest1-revB.zip
The inner CSV has the BOM.
nixitest1.csv
I ended up going with a C2938374 for the high-power switch and C845589 for the individual segments.


KAFKA-14443: Close topic creation Admin clients in MM2 connectors

The MirrorCheckpointConnector, MirrorHeartbeatConnector, and MirrorSourceConnector all create internal topics, but leak the Admin client used to do so. Instead, this Admin client should be persisted with the lifetime of the connector, and closed when the connector is stopped.
Additionally, generalize some types from ForwardingAdmin to Admin where the subtype is not a requirement.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

cc @OmniaGM @tombentley @mimaison
This is a regression introduced in #12577 and should be merged to all branches which have that feature (AFAIU, only trunk presently.)

@OmniaGM I believe that failure is flaky, as I cannot reproduce it locally. Those sorts of flaky failures are what got me looking at this code in the first place, coincidentally.
@C0urante Thanks for your suggestion on making these sorts of leaks more difficult, given the complexity and number of resources being managed by the connector/task instances, that we should certainly look into it.
I thought about the Mirror*Config::close solution that you proposed, and didn't like the idea of the config container being also responsible for managing the lifetime of the objects it creates. I didn't like it being responsible for creating the resources either, as you pointed out: it's too easy to leak the reference.
I experimented with an alternative solution, to have a reusable (across task/connector classes) BackgroundResources class which handles all instantiation and cleanup of the AutoClosable resources used in an MM2 connector/task. It simplifies the stop() methods, and doesn't appear to incur too much boilerplate in the start()` methods, maybe with a shorter name it could be even better.
I have two concerns here:

This change may be scope-creep for this PR, and maybe better handled as a lateral refactor after the release blocker bug is resolved. I am happy to continue iterating on the wider solution in this PR or a separate one, so let me know if you think the scope is still reasonable.
I wonder if the BackgroundResources class is in danger of becoming a "god object" which does everything. At the moment everything passes checkstyle, but if we add too many other pluggable interfaces or closeable resources, this class could be doing too much.

This change may be scope-creep for this PR, and maybe better handled as a lateral refactor after the release blocker bug is resolved.

Just my 2 cents as the 3.4 release manager -- unless this refactor helps to stabilize the actual feature as-is or fixes a suspected issue, please save this for a followup PR and avoid increasing the scope here: both to reduce the possibility of introducing new bugs with a nontrivial last-minute refactor, and of course to help ensure this fix is merged in a timely manner.
Happy to discuss further especially since I have absolutely zero context on the particular issue or this part of the codebase in general, but just keep in mind how close we are to the end of the 3.4 release. Thanks 🙂

@ableegoldman Thanks for taking a look--I agree that a more thorough refactoring can wait for a follow-up PR.
@gharris1727 I really like the general approach in the new BackgroundResources class and would love to still try to get something like it merged, but agree with your (and Sophie's) concerns about scope creep, especially with the upcoming release.
Given that adding any sort of meaningful tests for a fix to this issue would require a non-negligible refactoring, and the simplicity of the original fix proposed here (which simply added a few instance variables to a few classes, all of which were closed later), I think we can revert this PR to its original approach and file a follow-up PR for more sophisticated resource-tracking later. We can plan to merge it to trunk only after the 3.4 branch has been cut.

The integration test failures, though worrying, do not appear to be caused by these changes and have been occurring for some time now. I've filed https://issues.apache.org/jira/browse/KAFKA-14453 to note that they're flaky, and feel comfortable merging this as-is.


Routes and other modifications with the new dashboard

username.cartodb.com should redirect to the user dashboard in the maps view if the user is logged in.
username.cartodb.com should redirect to the public user dashboard in the maps view if the user is not logged in.
username.cartodb.com should redirect to the public user dashboard in the maps view if the username is not the user's username.

That doesn't belong to the frontend code, a backend guy should take care of this.
cc @Kartones @juanignaciosl @javisantana

I can take care of this, routes are my old friends. But yes, this are Rails responsabilities

New path /maps shows your public profile's maps page, as now the index path / performs redirects according to specified settings above, so current menu link doesn't works:

@viddo, @xavijam pointed me to you to change it, could you do it in this branch whenever possible? Afterwards I'll release the branch myself.

Since I'm changing how the URLs are created #2542 I would prefer to either do this fix there, or fix it after that is done, to avoid double work. ETA today (unless I run into unexpected trouble).

Fine by me, then I'll PR this and push after lunch. is not such a big thing and if your ETA is today or tomorrow...

Agree, I'll adhere to the new URL in my branch and it will get fixed promptly. :+1:


Dependencies not showing platform component of .NET 5 TFM

The gallery is only showing NetCoreApp 5.0 under the dependencies node and not net5.0-windows10.19041.
I have a package that multi-targets both net5.0 and net5.0-windows10.19041. I'd expect both to show up on the website; they are distinct dependency groups in the NuSpec:

The fix is now in PROD. Thanks for bringing this to our attention, @clairernovotny!
https://www.nuget.org/packages/System.Reactive/5.0.0-preview.220


updated cred_helper.py to match spec, updated tag_array_64x184 mock_a…

…rea to force upload of LEF/Liberty
Do not merge. If this works, I'll send up a separate PR for just the cred_helper.py change.

Re-started Jenkins with the changes: https://jenkins.openroad.tools/job/megaboom-Public/view/change-requests/job/PR-142/3/


More descriptive bootmenu entries

This creates more descriptive boot menu entries using a similar naming scheme as GRUB's implementation.
Tested only on openSUSE Tumbleweed, but should work on MicroOS as well

I can't help it.  Maybe we need a snapper info command or a parameter to snapper list to only list one snapshot. Meanwhile sed -ne 's/.*<\(type\|date\|description\|key\|value\)>\(.*\)<.*/snapshot_\1="\2"/p' < info.xml  should do

I found the snapper list command that's quite configurable with the --columns option, I use this instead now
Is the new code better?  However, when using snapper list there already is an update_snapper() function. And whith --disable-used-space it seems to be fast enough. So could actually pick the info from there by means of jq and a while loop as found in several places in the script.
I think it would also make sense to move mangling the title to a separate function.  However, when using snapper list there already is an update_snapper() function. And whith --disable-used-space it seems to be fast enough. So could actually pick the info from there by means of jq and a while loop as found in several places in the script.
I think it would also make sense to move mangling the title to a separate function. Something like is_transactional || adjust_title_and_sorting

I oriented on how you read json files, now it's just one call.
I reused and expanded your update_snapper function, please check if you're happy with all changes :)

check https://github.com/openSUSE/sdbootutil/pull/17

merged via #17


ci: install cargo before dependencies install

PR Checklist

[x] A description of the changes is added to the description of this PR.
[ ] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes
The CI has been failing quite a while lately. It seemed quite random, but the jobs that don't fail actually just retrieve cache, so by luck, they are not affected.
Debugging a bit the issue in https://github.com/fpgmaas/deptry/pull/794, spotted that the following error was returned when invoking cargo commands:
error: the 'cargo' binary, normally provided by the 'cargo' component, is not applicable to the '1.80-x86_64-unknown-linux-gnu' toolchain

Explicitly adding cargo through rustup fixes that.
Also adding --no-self to pdm install because we already build the project when invoking maturin develop, so it's not necessary to do both.

Gonna merge this one, to avoid keeping a broken CI and unblock other PRs.


aws import does not pick up AWS_DEFAULT_PROFILE

When I run aws sts get-caller-identity, I can see the right profile got used, but when I run terraformer import aws --resources=xx --regions=us-east-1, I always got the default profile applied, not sure if anyone else is also running into such issue.
terraformer import aws --resources=xx --profile=xx --regions=us-east-1 does not work for me either though.

you need to configure either the provider with the credentials file and profile, or you need to set the environment variables for aws the  AWS_SHARED_CREDENTIALS_FILE must be set I found.
i.e
provider "aws" {
   # Configuration options
  region     = "eu-west-2"
  shared_credentials_file = "/Users/<user>/.aws/credentials"
  profile = "default"
}

or
export  AWS_SHARED_CREDENTIALS_FILE="~/Users/<user>/.aws/credentials"
# optional
export AWS_SECRET_ACCESS_KEY=<>
export AWS_ACCESS_KEY_ID=<>
export AWS_DEFAULT_REGION= <>


feat(plugins/statsd) new metrics and more flexible configuration

Summary

Now each metric supports configurable stat type,
sample rate and customer identifier if applicable.
New metrics upstream_latency, kong_latency and status_count_per_user.

Full changelog

Schema updated to support new metrics
Schema updated to support stat_type, sample_rate and consumer_identifier
Added new schema checks and test

Issues resolved
FIX #1533
NOTE: depends on the PR on https://github.com/Mashape/kong/pull/2367

@shashiranjan84 should this be targeting master or next? seems like this is based off next; as it stands it brings a lot into master thats unrelated to this PR?

Wait, I opened it for next. Let me check what went wrong.  @p0pr0ck5 If needed I'll send a new one against next

Opened against wrong branch. Sending a new PR against next


Update README.md

New Pull Request Checklist

[ ] I have read and understood the CONTRIBUTING guide

[ ] I have read the Documentation

[ ] I have searched for a similar pull request in the project and found none

[ ] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[ ] I have added the required tests to prove the fix/feature I am adding

[ ] I have updated the documentation (if necesarry)

[ ] I have run the tests and they pass

[ ] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
...

Current coverage is 77.15% (diff: 100%)

Merging #1770 into master will not change coverage

@@             master      #1770   diff @@
==========================================
  Files            27         27
  Lines          2653       2653
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2047       2047
  Misses          606        606
  Partials          0          0

Powered by Codecov. Last update 5ea33a7...8f06947

Replaced by #1735


Using a custom embedder

Hello,
I would like to use a custom embedding model hosted via the HuggingFace library other than the ones already available via the Verba interface (Mini-LM, Ada Embedder, and Cohere Embedder), but I can't seem to find a way to do that.
I tried connecting a Weaviate cluster but I don't know how I can add custom embedders to it as well.
I have the same inquiry about LLMs available via the HuggingFace interface and the possibility of using other ones in Verba other than LLAMA.
Could you please provide me with some guidance regarding this matter? I'd be most thankful!
Thank you in advance.

I'm also looking for this feature. I tried to hack into the Llama generator to use falcon-7b model from HuggingFace, but things seem not to be working. If anyone has already done it please let us know!
Thanks guys.

Maybe this help
https://github.com/weaviate/Verba/issues/128#issue-2216314195

Great point! It would be a good idea to add some Resources for custom components!

I try this way:
File: manager.py
from transformers import AutoTokenizer
encoding = AutoTokenizer.from_pretrained("sentence-transformers/all-MiniLM-L6-v2")
encoding = tiktoken.encoding_for_model("gpt-3.5-turbo") # replace this code
...
item_tokens = encoding.encode(item_dict["content"], add_special_tokens=False)
...
truncated_content = encoding.decode(item_tokens[:remaining_space])

Good point! It is definitely something that can be improved! Your code will be helpful, thanks

Closing this for now


wip: OIDC kubeconfig remake

What this PR does / why we need it: This will add functionality to create oidc kubeconfigs and connected rbac in this repo.
Only a draft so far. The functionality is there, but I need to add some migration scripts and documentation.
Which issue this PR fixes (use the format fixes #<issue number>(, fixes #<issue_number>, ...) to automatically close the issue when PR gets merged): fixes #
Public facing documentation PR (if applicable)

Special notes for reviewer:
Checklist:

[ ] Proper commit message prefix on all commits
[ ] Updated the public facing documentation
Is this changeset backwards compatible for existing clusters? Applying:

[ ] is completely transparent, will not impact the workload in any way.
[x] requires running a migration script.
[ ] requires draining and/or replacing nodes.
[ ] will break the cluster.
I.e. full cluster migration is required.

I think this should have everything it needs now.


Adding new fonts

New fonts

Open sauce one
Open sauce two
Open sauce sans
Bluu next
Argentum Sans (from #504)

There’s a test broken so don’t worry about that. Can we split each font into separate PRs so it’s easier to review? Also it seems like your yarn cache is polluting the PR and we wouldn’t want that to be committed.


Ignore applying action when the status of chaos is running and the chaos is common chaos

Signed-off-by: cwen0<EMAIL_ADDRESS>What problem does this PR solve?
fix https://github.com/pingcap/chaos-mesh/issues/283
What is changed and how does it work?

Check the status of chaos, If the status is running, the controller-manager will ignore this applying action and just return ctl.Result{}, nil
format some logs

Check List
Tests

Manual test (add detailed scripts or steps below)

2020-02-26T06:18:09.349Z        INFO    controllers.NetworkChaos        Reconciling networkchaos        {"reconciler": "networkchaos"}
2020-02-26T06:18:09.349Z        INFO    controllers.NetworkChaos        Reconciling a common chaos      {"reconciler": "networkchaos", "action": "netem", "name": "network-delay-example", "namespace": "chaos-testing"}
2020-02-26T06:18:09.349Z        INFO    controllers.NetworkChaos        Performing Action       {"reconciler": "networkchaos", "action": "netem"}
2020-02-26T06:18:09.450Z        INFO    controllers.NetworkChaos        Try to apply netem on pod       {"reconciler": "networkchaos", "action": "netem", "namespace": "default", "name": "web-show-86c4979d6f-tv9cr"}
2020-02-26T06:18:09.451Z        INFO    util    Creating client to chaos-daemon {"node": "kind-worker4"}
2020-02-26T06:18:09.619Z        DEBUG   controller-runtime.manager.events       Normal {"object": {"kind":"NetworkChaos","namespace":"chaos-testing","name":"network-delay-example","uid":"c24f7122-585f-11ea-ae52-0242ac110002","apiVersion":"pingcap.com/v1alpha1","resourceVersion":"18195"}, "reason": "ChaosInjected", "message": ""}
2020-02-26T06:18:09.641Z        DEBUG   controller-runtime.controller   Successfully Reconciled {"controller": "networkchaos", "request": "chaos-testing/network-delay-example"}
2020-02-26T06:18:09.641Z        INFO    controllers.NetworkChaos        Reconciling networkchaos        {"reconciler": "networkchaos"}
2020-02-26T06:18:09.641Z        INFO    controllers.NetworkChaos        Reconciling a common chaos      {"reconciler": "networkchaos", "action": "netem", "name": "network-delay-example", "namespace": "chaos-testing"}
2020-02-26T06:18:09.641Z        INFO    controllers.NetworkChaos        Common chaos is already running {"reconciler": "networkchaos", "action": "netem", "name": "network-delay-example", "namespace": "chaos-testing"}
2020-02-26T06:18:09.641Z        DEBUG   controller-runtime.controller   Successfully Reconciled {"controller": "networkchaos", "request": "chaos-testing/network-delay-example"}

Codecov Report

Merging #285 into master will decrease coverage by 0.05%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage    60.4%   60.35%   -0.06%
==========================================
  Files          36       36
  Lines        1985     1985
==========================================
- Hits         1199     1198       -1
- Misses        692      693       +1
  Partials       94       94

Impacted Files
Coverage Δ

pkg/chaosdaemon/netem_linux.go
17.5% <0%> (ø)
:arrow_up:

pkg/utils/coalescer.go
0% <0%> (ø)
:arrow_up:

pkg/chaosdaemon/server.go
44.44% <0%> (ø)
:arrow_up:

pkg/chaosdaemon/netem_server.go
100% <100%> (ø)
:arrow_up:

pkg/chaosdaemon/time_server.go
100% <100%> (ø)
:arrow_up:

pkg/chaosdaemon/iptables_server.go
100% <100%> (ø)
:arrow_up:

pkg/chaosfs/server.go
82.25% <100%> (ø)
:arrow_up:

pkg/chaosdaemon/container-kill.go
100% <100%> (ø)
:arrow_up:

pkg/ptrace/ptrace_linux.go
65.55% <0%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc58db...672f2b4. Read the comment docs.

/merge