Feature Request: Support for different pending time for different start

I'd like to request for a feature that allows user to define different pending time for different state.
Currently there's only 1 pending time config for all states. That means if I choose arm_home or arm_away, they all gonna use the same pending time.
My use case is that when I select arm_home, I'd like to arm the system right away (so pending time is 0) but when I arm_away, I'd like to have a pending time of 30 seconds. Also when alarm is triggered, it'll be good if we can have a different pending time as well.
Thanks!

That's part of the MQTT Manual Control Panel component in Home Assistant.  The pending time for arm_away and arm_stay are currently the same in the HASS component, which I also agree should be configurable.  However, this is a feature of Home Assistant.  This application only reflects what the HASS component itself signals through MQTT.
Take a look at the documentation for the Home Assistant component: https://home-assistant.io/components/alarm_control_panel.manual_mqtt/.  If you want to update the HASS component you can do a PR on that code and change it or request the feature.
However, this application can't provide that feature as its only an interface for the HASS component and must work with its behavior.

But in the app settings there's a pending time config that you can set, I thought that's a different pending time only for the UI? That's the pending time i was talking about

I'm making changes to HA manual alarm control panel to support different pending time for different state, once that's done I'll port it over to MQTT alarm control panel. But I don't think this app is getting the pending time from HA right?

Sorry for the confusion, but those times must be set to the same as those used the Home Assistant component to work properly.  The application initially is set to the component defaults because it can't read those from MQTT, I only get the states from Home Assistant, but pending times or trigger time are not sent from Home Assistant.  So for this there is a bit of manually setting those to be the same.  Hope that makes sense.

pending_time (Optional): The time in seconds of the pending time before arming the alarm. Default is 60 seconds.

In the application the pending_time is being used before arming the alarm fully as shown in the small countdown timer on the red or yellow round buttons for arm home, arm away.  This is how much time you have before the alarm mode is set.  It's also used to show the enter the code dialog if the alarm is going from arm away or arm home to triggered because of some sensor being triggered for example. The pending time is still pending_time within Home Assistant.

trigger_time (Optional): The time in seconds of the trigger time in which the alarm is firing. Default is 120 seconds.

In the application the trigger_time is really being used because the application triggered state is set from Home Assistant.
If you change the Home Assistant manual alarm control panel then you need to also update the application settings to reflect the same.  There are only two supported times, pending_time and trigger_time to change.
Does all that make sense ?
If you get a chance to port over your MQTt alarm control panel changes, I will update the application to reflect those in the settings.  I have to change my code to support those changes.

If none of this makes sense, we can hash it out over Skype or Hangouts because it's probably much easier.  Let me know.

Thanks for the explanation, that all make sense. I'll keep you updated with my progress on having different pending time for different states

@thanksmister the change to support pending time per state is merged: https://github.com/home-assistant/home-assistant/pull/9358
It'll be in 0.55

Thanks @snjoetw I will update the alarm control panel once 0.55 is released.  Thanks!


valgrind complains nc_test/tst_small.c

When running the test program tst_small.c, one of valgrind's complains is about "uninitialised" bytes.  The cause points to file nc_test/tst_small.c, line 106
105	 /* Create null-terminated text string of correct length. */
106	 strncpy(att, source, t);

To make a string null-terminated, a line below is needed after line 106.
107	 att[t] = '\0';

@WardF this ticket can be closed.
The suggested line of code was added to the test at some point. Valgrind and the address santizer are both happy with tst_small.c.


GDScript: Added error messages to some compilation errors

added some messages to avoid empty compiler errors

If these bugs are not meant to ever be encountered by users, I suggest suffixing them with "(please report)".

@Calinou done :+1:

Thanks!


⚠ Spryr has degraded performance

In a30f87f, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4396 ms

Resolved: Spryr performance has improved in 7e352ab after 7 minutes.


tisting issues

i want to know how can i leave and issue that i saw :) help me!

wtf?

i saw and issue, so the question is, if it's posible to select an specific are of code to indicate where exactly the issue is, or the issue its has to be just a globlal bug or something like that


Turn off WEBGL_get_buffer_sub_data_async.

It's broken in large demos right now. I will spend some time debugging this later.

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


fatal error: 'ggml-common.h' file not found

System:
Apple M2 Max, Sonoma v14.1.1
What I did:
CMAKE_ARGS="-DLLAMA_METAL=on" pip install "sqlcoder[llama-cpp]"
sqlcoder launch
Error:
ggml_metal_init: error: Error Domain=MTLLibraryErrorDomain Code=3 "program_source:3:10: fatal error: 'ggml-common.h' file not found
#include "ggml-common.h"
^~~~~~~~~~~~~~~
" UserInfo={NSLocalizedDescription=program_source:3:10: fatal error: 'ggml-common.h' file not found
#include "ggml-common.h"
^~~~~~~~~~~~~~~
}
llama_new_context_with_model: failed to initialize Metal backend

Thanks for reporting this! Looking into this and will fix soon. llama.cpp recently had a new release, so I suspect we'll have to update our install instructions


Remove the multiple environments endpoints from Allowed Audience Values from OAuth2 Provider when we have a CDR per namespace

Feature Story (optional)
Related to issue: https://github.com/SecureBankingAccessToolkit/SecureBankingAccessToolkit/issues/255
Is your feature request related to a problem? Please describe.
We have to remove the multiple environments endpoints from Allowed Audience Values from OAuth2 Provider when we have a CDR per namespace.
So instead of this list:
"allowedAudienceValues": [       "https://obdemo.dev.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token",       "https://obdemo.nightly.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token",       "https://obdemo.andra-racovita.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token",       "https://obdemo.mariantiris.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token",       "https://obdemo.christian-brindley.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token",       "https://obdemo.bohocode.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token",       "https://obdemo.jorgesanchezperez.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token",       "https://obdemo.joycegilding-forgerock.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token"     ]
we should have only:
"allowedAudienceValues": [       "https://obdemo.<env>.forgerock.financial:443/am/oauth2/realms/root/realms/alpha/access_token"     ]
Describe the solution you'd like.
In pending...
Describe alternatives you've considered
In pending...
Additional context (optional)
No response

Hey team! Please add your planning poker estimate with Zenhub @BohoCode @dbadham-fr @frlaura-jianu @mariantiris

Now fixed


I am getting a TopicsNotExistError even when the topic does exist

Bug Report
I am getting a TopicsNotExistError even when the topic does exist:
$ kafka-topics.sh --list --zookeeper zookeeper:2181
ttest
...other topics...

Environment

Node version: v8.10.0
Kafka-node version: v3.0.1
Kafka version: 2.12-2.1.0

For specific cases also provide

Number of Brokers: 1
Number partitions for topic: 1

Include Sample Code to reproduce behavior
const kafka = require('kafka-node');

const client = new kafka.KafkaClient({kafkaHost:'kafka:9092'});
const consumer = new kafka.Consumer(client, [{topic: 'ttest', partition: 1}], {autoCommit: false});
consumer.on('message', console.log)
consumer.on('error', console.log)

The above prints:
  kafka-node:KafkaClient Connect attempt 1 +0ms
  kafka-node:KafkaClient Trying to connect to host: kafka port: 9092 +2ms
  kafka-node:KafkaClient Sending versions request to kafka:9092 +7ms
  kafka-node:KafkaClient broker socket connected {"host":"kafka","port":"9092"} +2ms
  kafka-node:KafkaClient missing apiSupport waiting until broker is ready... +2ms
  kafka-node:KafkaClient Received versions response from kafka:9092 +6ms
  kafka-node:KafkaClient setting api support to {"21":{"min":0,"max":1,"usable":false},"22":{"min":0,"max":1,"usable":false},"23":{"min":0,"max":2,"usable":false},"24":{"min":0,"max":1,"usable":false},"25":{"min":0,"max":1,"usable":false},"26":{"min":0,"max":1,"usable":false},"27":{"min":0,"max":0,"usable":false},"28":{"min":0,"max":2,"usable":false},"29":{"min":0,"max":1,"usable":false},"30":{"min":0,"max":1,"usable":false},"31":{"min":0,"max":1,"usable":false},"32":{"min":0,"max":2,"usable":false},"33":{"min":0,"max":1,"usable":false},"34":{"min":0,"max":1,"usable":false},"35":{"min":0,"max":1,"usable":false},"37":{"min":0,"max":1,"usable":false},"38":{"min":0,"max":1,"usable":false},"39":{"min":0,"max":1,"usable":false},"40":{"min":0,"max":1,"usable":false},"41":{"min":0,"max":1,"usable":false},"42":{"min":0,"max":1,"usable":false},"produce":{"min":0,"max":7,"usable":2},"fetch":{"min":0,"max":10,"usable":2},"offset":{"min":0,"max":4,"usable":0},"metadata":{"min":0,"max":7,"usable":1},"leader":{"min":0,"max":1,"usable":false},"stopReplica":{"min":0,"max":0,"usable":false},"updateMetadata":{"min":0,"max":4,"usable":false},"controlledShutdown":{"min":0,"max":1,"usable":false},"offsetCommit":{"min":0,"max":6,"usable":2},"offsetFetch":{"min":0,"max":5,"usable":1},"groupCoordinator":{"min":0,"max":2,"usable":0},"joinGroup":{"min":0,"max":3,"usable":0},"heartbeat":{"min":0,"max":2,"usable":0},"leaveGroup":{"min":0,"max":2,"usable":0},"syncGroup":{"min":0,"max":2,"usable":0},"describeGroups":{"min":0,"max":2,"usable":0},"listGroups":{"min":0,"max":2,"usable":0},"saslHandshake":{"min":0,"max":1,"usable":1},"apiVersions":{"min":0,"max":2,"usable":0},"createTopics":{"min":0,"max":3,"usable":false},"deleteTopics":{"min":0,"max":3,"usable":false},"saslAuthenticate":{"min":0,"max":0,"usable":0}} +1ms
  kafka-node:KafkaClient broker is now ready +0ms
  kafka-node:KafkaClient updating metadatas +2ms
  kafka-node:Consumer consumer ready +1ms
  kafka-node:KafkaClient updating metadatas +2ms
{ TopicsNotExistError: The topic(s) ttest do not exist
    at new TopicsNotExistError (/root/kafka/node_modules/kafka-node/lib/errors/TopicsNotExistError.js:11:9)
    at loadMetadataForTopics (/root/kafka/node_modules/kafka-node/lib/kafkaClient.js:916:14)
    at async.series (/root/kafka/node_modules/kafka-node/lib/kafkaClient.js:885:5)
    at /root/kafka/node_modules/async/dist/async.js:3888:9
    at /root/kafka/node_modules/async/dist/async.js:473:16
    at replenish (/root/kafka/node_modules/async/dist/async.js:1006:25)
    at iterateeCallback (/root/kafka/node_modules/async/dist/async.js:995:17)
    at /root/kafka/node_modules/async/dist/async.js:969:16
    at /root/kafka/node_modules/async/dist/async.js:3885:13
    at KafkaClient.wrappedFn (/root/kafka/node_modules/kafka-node/lib/kafkaClient.js:471:14)
  topics: [ 'ttest' ],
  message: 'The topic(s) ttest do not exist' }

Interestingly, if I try to get a list of topics, none is returned:
const kafka = require('kafka-node');

const client = new kafka.KafkaClient({kafkaHost:'kafka:9092'});
client.once('connect', function () {
    client.loadMetadataForTopics([], function (error, results) {
      if (error) return console.error(error);
      console.log(results);
    });
});
client.on('error', console.error);
// prints: [ {}, { metadata: {}, clusterMetadata: { controllerId: -1 } } ]

I believe this is a timing issue perhaps.   You may need a +2ms delay.

Same issue.
For me, it's because the nameserver I'm using doesn't support querying metadata using [], which causes the internally cached metadata to be empty.
So I replace the [] with the topic I wanted to subscribe to in the initial query and the error disappeared.


PMID:39358553

New term: decreased cellular ribosome content
A cellular phenotype observed in the vegetative growth phase of the life cycle in which the total ribosome content (monosomes + polysomes) in a cell is lower than normal.
New term: increased cellular ribosome content
A cellular phenotype observed in the vegetative growth phase of the life cycle in which the total ribosome content (monosomes + polysomes) in a cell is higher than normal.

adding under "decreased level of macromolecular complex during vegetative growth"
made  decreased/increased cytosolic ribosome content
can't add equivalence axioms as parent does not have them


Modify reparenting guide and add to left nav for http://vitess.io.

Also fix broken link in overview.

LGTM great stuff!

I ran publish-site.sh for this. I'm not sure if you've got it working on your machine.


PALMSpy - timezone specifciation

Add user specified timezone to overrule GPS data estimated timezone:

Reflect on possible approach
Creare issues in PALMSpy repository

Closing because facilitating PALMSpy does not have priority at the moment


evaluate running integration tests during the CI build

It would be great to run the integration tests after each commit.

:+1: for doing this at the point that we migrate to doing builds on TeamCity

agreed.


I added my personal website

Thanks @hellstabber sorry for the delay

No problem @nunocoracao. Thank you for your beautiful project


Adding select "No my country"

Adding select "No my country", that allows user to enter phone number without formatting (isValid key should be always 'true' in this way)

I think you can set a condition in your component and use a native input field in that case

I think you can set a condition in your component and use a native input field in that case


Data import and export

Allow import and export of preferences and data to db with google. Use an xml or json format

Shared preferences strategy implemented, remaing to implement sql strategy


ML model

Made a Machine Learning model using Logistic Regression with an AUC-ROC score of 0.99 on the test dataset.

thanks for making your contributions


make_generator_variability won't work for multiple existing clusters

I wrote this section with the assumption that any existing variable resources will only have 1 cluster per region. The code doesn't work when more than one cluster is specified (I'm still not sure if multiple clusters of existing variable resources would ever be needed).

Closing because current data implementation doesn't have more than one cluster per region.


[WIP] Refactor baselines: add generic trainer and common utils

Motivation and Context
This PR aims to bring modularity and improve reusability of habitat_baseline,  by introducing abstraction to the current experiment process and collecting common utilities. This is an early draft and all suggestions are welcomed :)
Since the amount of code changed is relatively large, here's a breakdown of what does this PR do, what directions am I particularly looking for suggestions/opinions, and what needs to be done before merging.

What does this PR do?

Provide a trainer template (BaseTrainer) and  create trainer registry.  I went through a couple of related repos (Horizon, stable_baselines, Pythia) and chose a high-level structure similar to this in stable_baselines (suggestions on implementation details are welcomed 😄 ). This will  make it more straightforward to add new trainers. Note that this is complementory to #144 , as that one is more specific to ppo and aims to make it extensible to new tasks.
Collect trainer-independent utilities, such as env creation, batch transpose, and tensorboard logging, and move them to habitat_baselines/common/ to give better reusability.
Merge logics in train_ppo and evaluate_ppo into one ppo_trainer.py file. Now launch commands for training/evaluation look like this:

python  habitat_baselines/run.py --exp-config /path/to/config/ppo.yaml --run-type train

Unify env_config, baseline_config, and previous command-line args into one config system so that it can be passed and stored in a single place.
Here's a directory tree that might help visualize the structural changes:

habitat_baselines/
 ├── __init__.py
+├── common/                      	# directory that includes reusable functionalities
+│   ├── base_trainer.py           	# trainer template
+│   ├── env_utils.py
+│   ├── tensorboard_utils.py
+│   ├── trainer_registry.py
+│   └── utils.py
 ├── config/
+│   └── pointnav/
+│       └── ppo.yaml
 ├── rl/
 │   ├── __init__.py
 │   ├── ppo/
 │   │   ├── __init__.py
 │   │   ├── policy.py
 │   │   ├── ppo.py
+│   │   ├── ppo_trainer.py  		# trainer class for ppo (train and eval)
-│   │   └── utils.py
 │   └── requirements.txt
+├── run.py                             # main entry point to all experiments
-├── evaluate_ppo.py
-├── train_ppo.py
 └── ...

Places I'm looking for opinions/suggestions:
All comments are welcomed. Though as this is an early draft, I'm particularly looking for opinions on level of abstraction, structural changes and config mechanism changes.
(e.g. what generic method should be included in BaseTrainer)

Things need to be delivered before merging:

[ ] Polishing, docs, typing, header
[ ] Use saved configs in eval(), and make compatible with old checkpoints
[ ] Rebase after #144  landed
[ ] Fix imports in habitat_baselines __init__

How Has This Been Tested
Current tests pass and train/eval run properly from run.py

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

For now this PR is expected to fail CI test.
This command below in  circle-ci run api tests will have to be modified accordingly for it to pass.
python -u habitat_baselines/train_ppo.py  ...

Maybe change to something like this when PR lands:
python -u habitat_baselines/run.py --exp-config habitat_baselines/config/pointnav/ppo.yaml --run-type train

For CI, can you rebase on latest habitat-api changes? Thanks

Master branch CI is passing: https://circleci.com/gh/facebookresearch/habitat-api.

CI test python -u habitat_baselines/run.py --exp-config habitat_baselines/config/pointnav/ppo_train_test.yaml --run-type train is trying to load checkpoint:
FileNotFoundError: [Errno 2] No such file or directory: 'data/checkpoints/ckpt.0.pth'

FileNotFoundError: [Errno 2] No such file or directory: 'data/checkpoints/ckpt.0.pth'
Looks like I didn't check for dir existence, thanks for spotting that.

Updated PR: fixing merge conflict and modified README.
Changes from @abhiskk 's suggestion:

RolloutStorage now is in it's own file

Changes from @mathfac 's comments:

Now trainer config won't be passed into envs as a child config node.
Saved checkpoint config will be loaded to provide more info at evaluation time.
Merging of saved config and eval config now has proper order: eval_opts > saved_opts > eval_base_config > saved_base_config.


CP Selection is not working when drawing multiple NURBS

I tried to implement a sample multi_nurbs_2d_test.c in branch fix/cp_nurbs3d_selection .
In this sample, CP Selection does not seem to be working.
What could be the cause of this?
Let's investigate using this branch and add what we can infer,

See:
https://github.com/mi-lib/roki-gl/blob/main/example/shape/nurbs_2d_test.c

I merged the main branch and checked the sample nurbs_2d_test.c.
Hmm... I see, it was my mistake.
In my sample multi_nurbs_test.c,
After checking the CP name and the NURBS curve name from the SelectionBuffer, only the CP name was being obtained. The name of the NURBS curve could not be obtained.
I also got the names of the curves, like in the updated nurbs_2d_test.c and it worked as expected.
Thank you for showing me how to use it.

This issue has been resolved, It's okay to close it.


[Enhancement] Support delete sql for cloud native primary key table with sort key

Fixes #issue
refer to: https://github.com/StarRocks/starrocks/pull/25644
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 5 / 13 (38.46%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/delta_writer.cpp
5
13
38.46%
[324, 325, 326, 327, 328, 329, 330, 383]

[BE Incremental Coverage Report]
:disappointed: fail : 5 / 13 (38.46%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/delta_writer.cpp
5
13
38.46%
[324, 325, 326, 327, 328, 329, 330, 383]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 5 / 13 (38.46%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/delta_writer.cpp
4
12
33.33%
[323, 324, 325, 326, 327, 328, 329, 382]

:large_blue_circle:
src/storage/lake/rowset_update_state.cpp
1
1
100.00%
[]

@Mergifyio backport branch-3.2

@Mergifyio backport branch-3.1


Discord activity is wrong

Description

Max players is stuck at zero, and the time played seems to reset whenever someone joins/leaves
Reproduction

i guess just go play ss14 and check discord
Screenshots

It uses engine max players which servers almost never config. Just needs an event if content wishes to override but pre sure there's an open issue for it.

oh


dataset.class name with get/set

This is a very simple request.
Could the dataset.class have a name or description field which is a simple string with a get/set?
Right now working with multiple datasets stored as lists requires me to maintain a separate list with names/desc.
How else are people labeling their charts when posting multiple datasets to a chart.

DataSet is meant to contain a mini-batch. It doesn't make any sense to give it a specific name.
And it has a facility to store metadata (getExampleMetaData/setExampleMetaData) that is per-example.
If you need to store some kind of description, why not just use a List of pairs instead of two lists?

I'm really confused about how this api is supposed to work then. Maybe you could clear it up.
Lets say a I create a method that generate two INDArrays representing features and labels.
I need to run this method some number of times and pass those pairs into a network and later a chart.
Is there a method for encapsulating the data pairs?
your suggestion regarding the examplemetadata should work though.

Ideally you aren't building them yourself, and instead use the given API's for data reading. If you need to read custom data it is preferred to create a custom Reader instead of trying to skip all of this and go directly to creating the tensors yourself.
If you insist on doing so, note that they have to have the minibatch size as the leading dimension.
A DataSet object then is composed of up to 5 elements:

Features
Labels
Feature Mask (may be null)
Label Mask (may be null)
Metadata (may be null)

In most cases people don't care about the meta data though, so it isn't part of its constructor.

Thanks for your feedback. dl4j is a great resource as a result of the countless hours invested. The examples and documentation are the weak links for beginners like me.


Programatic way to open request

There is a programmatic way to open a service request?, using a API or similar?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43a60f94-0826-8cdf-04b3-c5f20d299720
Version Independent ID: 7d1dcfe7-4e68-6b98-1003-9154e7a0b22d
Content: How to create an Azure support request
Content Source: articles/azure-portal/supportability/how-to-create-azure-support-request.md
Service: azure-supportability
GitHub Login: @ganganarayanan
Microsoft Alias: kfollis

@ediazrod Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

I'm looking for this same information. @SaurabhSharma: Any update on this?

See the Overview section of this page.
You can also create and manage requests programmatically, using the Azure support ticket REST API.
Learn more at: https://docs.microsoft.com/rest/api/support/

Whoops! I see it now. Thank you!

We will close the issue for now. If there are further questions , please revert and we will be glad to assist you.


chore(snapshot): adding the design doc for mountable snapshots

Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
What this PR does?: It adds a design for a new feature
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
In the drawbacks section I posed the question of whether we should maybe use annotation to indicate that we are mounting a snapshot instead of creating a new PV as a clone of the snapshot. I'd like a second opinion on whether this is a good idea or what a good alternative could be (for example, we could create a new api-resource although I don't think that would be such a good idea).
Also a PVC requires the Storage to be set, however, it is a little bit useless in this case especially when mounting snapshots. Any suggestions on handling that better would be appreciated.
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@wowditi Can you please provide an update on the plans for taking this forward? Are you willing to work on this?

Hi @wowditi I run Product Mgmt for the OpenEBS project.
You've put a lot of amazingly impressive & detailed work into your PR and it received a bunch of good reviews from our English team. Overall very positive.
LVM-localPV is now getting a major focus in the OpenEBS product as it's being unified into the core platform as a central component, rather than being managed as a separate external Data-Engine.
Additionally, LVM-LocalPV now has ~50,000 Daily Active Users and +150,000 product installations. So it's now a very well validated part of the platform. Hence we're are unifying it into the main product.
We'd really like to work on developing your PR and integrate the design into the new unified product.
Are you still interested and willing to support your PR?

Hi,
Sorry I forgot about this since my company started using the ZFS variant since it already had the features we need.
I do not have a lot of spare time currently, but I could probably help since it wasn't that much work from what I remember.
About the design document, the implementation details are indeed very technical currently and I can make those a bit more high level.
After using the ZFS localpv I also noticed that this is basically the same behaviour as what they refer to as cloning, should I rewrite the document to call it cloning and remove the drawback?

I see at least a few things that aren't talked about in this document:

There is an idea in the document that if the PVC for snapshot is created with a capacity(resource)  - we could extend the lvm if the defined storage size is larger then that of the snapshot (with a maximum of the size of the original volume). If the snapshot is thick and is extended to a cap of original LV size, it'll become invalid in view of LVM. How do we deal with that during PVC provisioning.
If say there is a volume V1 of size S, a snapshot of V1 is created of size 50% i.e. S/2. Now a PVC P is provisioned with snapshot. If the snapshot is configured to auto-extend, the snapshot size at some point becomes larger than size of P. How does that affect the pvc P ?
If a mounted snapshot becomes invalid (100% of original LV size), how does that impact the pvc which is bound to it?

This hasn't yet progressed based on last set of clarifying questions. Keeping a track of it.


prototype changes

Changes to the Landing Page About Section:
-- removes repo GdK
-- removes repo Berlin Open Source
++ adds repo Stadtpuls
++ adds repo icon for Stadtpuls
-- removes github const user (wasn't used)
== changes the text in the prototype section (not 100% final as it needs confirmation from Ben)
== changes the header image
== renames "unit counter" to "Zähler"

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Gradual Rollouts versions upload command

What this PR solves / how to test:
This PR implements the new Gradual Rollouts versions upload command for internal-use only. Therefore, it is hidden from the help output.
The command is essentially the same as deploy and, for now, has been duplicated so as not to touch the deploy command implementation at all and, while we agree on the differences, the diff should be more readable this way. The PR is marked as draft and will be refactored to abstracted functions of shared implementation at a granular level before being marked as ready for review. This should allow internal use of the prerelease builds before going through that effort.
Please find the prerelease build instructions in a bot comment below. Specifically for this command you can run:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7506244142/npm-package-wrangler-4744 versions upload

Author has addressed the following:

Tests

[ ] Included
[ ] Not necessary because:

Changeset (Changeset guidelines)

[ ] Included
[ ] Not necessary because:

Associated docs

[x] Issue(s)/PR(s): https://docs.google.com/document/d/1Kn0EpTXzu2ANMznbEehBVRCkhYky1WbFEc9K79OIfBc
[ ] Not necessary because:

Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

the only feedback i have here is from the DX side. once you upload the new version, it would be great if you could capture it from wrangler without needing to make another API call to the version (similar to what already happens with wrangler publish/deploy. suggestion:
 ⛅ wrangler 0.0.0-31389017
---------------------------

Your worker has access to the following bindings:
- Vars:
  - FOO: bar
Total Upload: 257.61 KiB / gzip: 46.15 KiB
Uploaded example-script (1.39 sec)

Verison: 9f893230-f98a-4390-a940-abea253f2e08


command line options aren't overriding config file options

Command line options should have higher priority. This used to work once.

working for me. Give me an example

Sorry, my fault.


Error when referencing a Managed Identity in the identity block of a storage account

Bicep version
Bicep CLI version 0.21.1 (d4acbd2a9f)
Describe the bug
Deployment fails when directly referencing an UAI in the identity block of a storage account.
Exception Details:      (DeploymentFailed) At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.
        Code: DeploymentFailed
        Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.
        Exception Details:      (InvalidTemplate) Deployment template validation failed: 'The template resource 'demodatastore' at line '1' and column '3176' is not valid: The template function 'reference' is not expected at this location. Please see https://aka.ms/arm-functions for usage details.. Please see https://aka.ms/arm-functions for usage details.'.
                Code: InvalidTemplate
                Message: Deployment template validation failed: 'The template resource 'demodatastore' at line '1' and column '3176' is not valid: The template function 'reference' is not expected at this location. Please see https://aka.ms/arm-functions for usage details.. Please see https://aka.ms/arm-functions for usage details.'.

To Reproduce
Steps to reproduce the behavior:
resource DemoDataStorageUserIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2023-01-31' = {
  name: 'demodatastore'
  location: storageLocation
}

resource DemoMLStorage 'Microsoft.Storage/storageAccounts@2022-09-01' = {
  name: 'demodatastore'
  kind: 'StorageV2'
  location: storageLocation
  sku: {
    name: 'Standard_LRS'
  }
  identity: {
    type: 'UserAssigned'
    userAssignedIdentities: DemoDataStorageUserIdentity // throws "The template function 'reference' is not expected at this location"
    // userAssignedIdentities: {
    //   '${DemoDataStorageUserIdentity.id}': {} // This works!
    // }
  }
  properties: {
    accessTier: 'Hot'
  }
}

Additional context
Deployment works when indirectly referencing the resource ID of the UAI.

Seems to be in line with the docs and as expected:
"Gets or sets a list of key value pairs that describe the set of User Assigned identities that will be used with this storage account. The key is the ARM resource identifier of the identity. Only 1 User Assigned identity is permitted here."
https://learn.microsoft.com/en-us/azure/templates/microsoft.storage/storageaccounts?pivots=deployment-language-bicep
Most resources use the pattern of supplying the identifiers for the identities, and not the identity object itself.

I see, but then maybe it's an issue with the Bicep linter? It didn't show me any error and suggested me to directly reference the UAI. The mentioned error gets first thrown when trying to deploy it.

This definitely looks like a gap in Bicep's type analysis to me.

@anthony-c-martin This behavior seems to be the same for all resources that has an identity block so I take it that's not RP specific and on a more generic level.


Magenta color shows on Sprite Editor totals

Need to fix the font so magenta doesn't show up at the end of the sprite total values.

This is now fixed. Added extra background color to the end of each font character.


Added OSD tag support

Description
With this feature is able to return only rules that could be fixed on OSD clusters.
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Testing steps
make test

Codecov Report

Merging #316 into master will increase coverage by 0.70%.
The diff coverage is 80.85%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   51.58%   52.29%   +0.70%
==========================================
  Files          12       12
  Lines        1070     1090      +20
==========================================
+ Hits          552      570      +18
- Misses        433      435       +2
  Partials       85       85

Impacted Files
Coverage Δ

server/server.go
61.11% <65.38%> (+1.58%)
:arrow_up:

content/content.go
76.62% <100.00%> (ø)

content/parsing.go
71.42% <100.00%> (+0.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580ad7a...993e5cb. Read the comment docs.


community: Modularize code for method HuggingFacePipeline.from_model_id

Thank you for contributing to LangChain!

[x] PR title: "community: Modularize code for method HuggingFacePipeline.from_model_id"

[x] PR message:

Description: Replaced blocks of if statements with a dictionary approach. This will help add further HuggingFace tasks in an easier and modular manner. Note that currently only 4 tasks are supported, so more tasks are yet to come.
Issue: N/A
Dependencies: N/A
Twitter handle: None

[x] Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.

closing as stale / no response - if still an issue would recommend reopening against the huggingface partner package instead of the deprecated community i ntegration!


add nonce prop to LiveReload and ScrollRestoration

This is a duplicate of https://github.com/remix-run/remix/pull/2043, which had merge conflicts.
Adds the nonce prop to LiveReload and ScrollRestoration so one can use a Content Security Policy

What do you guys think about this? Any possibility of getting this added?

Hi @dusty, usually when a PR go stale, its considered a good practice to nudge its author instead of opening a duplicate 😬
The original PR have been updated, and will get some attention from the team shortly.

Thanks!


Error detection in tasks 2.0 doesn't show notification in problems pane

VSCode Version: Version 1.14.0-insider
OS Version: macOS Sierra 10.12.2

I've cloned the eslint-starter example, and am running the npm: run lint task with the ESLint stylish problem matcher.
When an error is detected, I see the following:

I am not automatically guided to the problems panel when the task completes, and there is no UI element that directs me to look there, even though there is an error.
I would expect to see a notification like the following to guide me:

Nice idea.

This needs UI work.

We have this already! The problems pane shows an error count badge.


Small code cleaning as followup after launching new Table endpoint

@rafatower CR please, as comments I think were yours :o)

:+1:

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Icon: Update Icons [Gestalt-8459]

Pull Request Instructions
Thanks for creating a PR! 🎉

Please follow this template and delete items/sections that are not relevant to your changes, including these instructions.
Make sure your PR title matches our format: {ComponentName}: Description (mention platform if relevant). If there are changes to multiple components, use {ComponentName}, {OtherComponentName}: Description (mention platform if relevant).
Each PR needs a label indicating which semantic version should be applied:

Major: Breaking changes to existing components (e.g. removing a prop, removing a prop value, removing a component).
Minor: New components, non-breaking changes to existing components (e.g. adding a new prop, adding a new prop value).
Patch: Bugfixes, internal refactors that don't change the component's API, most dependency upgrades, all docs updates.

If you're updating a dependency, please also include the dependencies label.

Pull Request Template
Summary
What changed?
At a high level, what changes does this PR introduce?
Why?
What is the purpose of this PR? Please include the context around these changes for Future Us. In addition to what is changing, we need to know why these changes are needed. Imagine someone is looking at these changes a year from now and needs to know why they were made.
Links

Jira
[TDD](link to Paper doc)
[Figma](link to Figma file)

Checklist

[ ] Added unit tests
[ ] Added documentation + accessibility tests
[ ] Verified accessibility: keyboard & screen reader interaction
[ ] Checked dark mode, responsiveness, and right-to-left support
[ ] Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

run yarn tsc! haha

ran - no updates, because they're existing icons


Clear group cache for person when they are updated

I think you may need to add some code to ensure normal authentication doesn't get applied to this endoint?

There is no normal authentication guarding those endpoints as far as I know


KNode crashes daemonsets on node on init

Hi,
Thanks for creating this project. I've installed it on some of our clusters and moving docker to a different volume on AKS really mitigates the issues reported at:
https://github.com/Azure/AKS/issues/1373
My issue is that when KNode starts, after the init stage, it crashes the other daemonsets on the node, specifically in my case those are:

Prometheus Exporter
Node Managed Identity (https://github.com/Azure/aad-pod-identity)

Those pods cannot come back up and, unless I delete them manually, they get into a CrashLoopBackOff state. If deleted they come back up without any issues.
This can be mitigated by human intervention when a cluster does not run the autoscaler but unfortunately this cannot be controlled if a cluster is using the autoscaler.
Also the way the other daemonsets fail is quite strange. In the case of NMI I get the following error:
time="2020-03-04T08:53:33Z" level=info msg="Starting nmi process. Version: 1.5.3. Build date: 2019-10-12-00:23. Log level: info."
time="2020-03-04T08:53:33Z" level=info msg="CRD lite informers started "
time="2020-03-04T08:53:33Z" level=info msg="Initialized health probe on port &[8080]"
time="2020-03-04T08:53:33Z" level=info msg="Started health probe"
time="2020-03-04T08:53:33Z" level=info msg="Listening on port 2579"
time="2020-03-04T08:53:33Z" level=fatal msg="Error creating http server: listen tcp :2579: bind: address already in use"

which I don't think is right as if the port was in use already the pod would not start after being deleted.

Interesting, in the past this wasn't a problem after a reboot. I'll investigate further and get back to you @luigibk. Thanks for reporting this!

@juan-lee I think I'm seeing the same, any ideas?


Fix NPE in type validation when using collection returning functions

In 1.5.0-Alpha3 we slightly changed the validation of expressions in entity views which might lead to a NPE when using a function that returns a Collection.
Environment

Version:            1.5.0-Alpha3
JPA-Provider:       -
DBMS:               -
Application Server: -

Fixed via 7b10b152c6cf8c3875df38a7586682dc4d2b787e


[installation failed]

Installation was failed when running npm run make_cmdline
here's part of the log:
18 verbose node v13.5.0
19 verbose npm  v6.13.4
20 error code ELIFECYCLE
21 error errno 2
22 error wenyan-lang@ make_cmdline: `node ./tools/make_cmdline.js && pkg ./build/wenyan.js --out-path ./build`
22 error Exit status 2
23 error Failed at the wenyan-lang@ make_cmdline script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 2, true ]

I wondered what the problem is

Hi there, thanks for the report. I haven't run into this issue. Maybe it's something wrong with the pkg packager? Meanwhile you can still run the cmdline tool by using node ./build/wenyan.js
Thanks.


BCEL-330 Remove unnecessary references to Constants

remove unnecessary references to Constants.

I ended up reverting this PR since it breaks source and binary compatibility.


[adminapi] Admin API

So in progress I don't even wanna open the PR, but I like leaving notes to myself.

[x] fix hyperlinks, they go to the public api models.
[ ] expose AllowedList and make sure generated form works for ArrayField
[x] expose ProductCategory
[ ] at least pretend you care about testing
[x] hide from reverse_js ?
[ ] expose Step as an embed in Plan
[x] expose *Slug
[ ] router registration instead of viewsets?
[ ] refactor URL reversing
[ ] IP access limits
[ ] schema?

@cdcarter I like the direction this is headed, I'll review and probably 👍 when you say it's ready for that.


Webpack 5 Native Workers generates an unusable chunk for node targets

Bug report

What is the current behavior?
Using native workers with the async-node target generates a chunk that can't be used since it doesn't transform any of the require statements, generate any common chunks, or include the webpack runtime. This makes the chunk impossible to run as it references relative modules that don't exist.
If the current behavior is a bug, please provide the steps to reproduce.
I have created a repo to demonstrate the issue here: https://github.com/Khauri/vigilant-pancake
I've included the dist folder. dist/worker.js is generated from worker.js and imports an arbitrary file that's also imported in the main index.js. If you look at dist/worker.js you'll see it calls require('./isWorker.js') which is not available in the dist folder.

What is the expected behavior?
I would expect that the generated chunk have some kind of runtime code and interoperability with the main chunk.

Other relevant information:
webpack version:  5.21.1
Node.js version:  10.16.3 and 12.6.3 tested
Operating System:
Additional tools:

Worker integration only works with import { Worker } from "worker_threads" and not with require

Interesting? Are there any plans to support cjs? Or at the very least show a warning if you use a cjs require? It still seems odd to me that a new bundle is created.
Also it seems like using a URL object inside of new Worker() is not supported on versions of node <=12.16.
That may be worth mentioning in the docs if it's not already mentioned.

I added this info to the documentation.
We might add support for CommonJS eventually (depends on progress in commonjs tree shaking, as this need to be analysed), but note that Node.js neither supports CommonJS as it's using import.meta.url.

Is/would it be possible to enable this feature in a different way? Possibly some kind of magic comment?
Currently I'm using babel with @babel/preset-env's modules field set to "cjs" in order to force convert all modules to commonjs, but because this transpilation happens before webpack does any of its static analysis, it gets rid of the import {Worker} from 'worker_threads' too soon.
If I disable this option in babel and fully convert the one file it's used in to esm then it'll correctly generate the chunk, but at runtime I get an error:
ES Modules may not assign module.exports or exports.*, Use ESM export syntax instead: ./some-dependency-of-worker.js

The file it's pointing to is a cjs dependency and is not the file I converted to an esm and none of its dependencies are esm and neither the file nor its dependencies mix import and module.exports.

The error probably happens because some Babel plugin injects imports. This might happen because sourceType is not set to ambiguous

@Khauri Can we close?


hidden element is taking up space

This directive creates a hidden element:
<input type="file" ngf-select="" ng-model="filesToUpload" tabindex="-1" style="visibility: hidden; position: absolute; width: 0px; height: 0px; z-index: -100000;">
The problem is it is taking up 1x1px and is adding a scroll bar to my page. Can you add a class to this element so it can be customized? Also why not just add display:none to the element?

What version of the plugin are you using?
display:none would make the element not being clickable in some browsers.

"ng-file-upload": "4.2.1"

upgrade to the latest


dead link (Google Billion Word Dataset for Torch)

Hi, I'd like to use your language model for my research. I can't train it because the link to the Google Billion Word Dataset for Torch is down. Is there a mirror somewhere?

You can try using the original data.  1 Billion Word Dataset


Change the cluster style

Hi there,
Can we change the cluster icon and add a svg instead of the default image:

So far I tried to play with the inputs IconInfo, ClusterIconInfo and Styles without success.
That would be truly awesome :)
Thanks!

Yes, that is certainly possible. IconInfo will change the image for an individual marker, ClusterIconInfo for a cluster. Take a look at the sample page, it has samples for custom marker images. Take a look at https://github.com/infusion-code/angular-maps/blob/master/src/components/cluster-layer.ts also, it show how to dynamically create an SVG cluster icon based on the data (for the dynamic stock marker images) (CreateDynamicSizeMarker)
To use custom cluster SVG, you have to implement a callback and set it in x-cluster-layer CustomMarkerCallback. The callback is (m: Array, i: IMarkerIconInfo) => string. This will be called for each cluster and the arguments are an array with  the markers in the cluster and the MarkerIconInfo that you have set using the IconInfo property. You can use this method to generate arbitrary svg based on the data passed in (I am usually using this to to pie chart clusters or similar). The return value of the callback should be either an SVG string or a data: string for an image, either way.
If you do not need icons that change depending on the content of the cluster, you can just provide the SVG string in the url property of the IconInfo, specify MarkerTypeId.RotatedImageMarker and use IconInfo.rotation = 0. I've not tried this, but it should work. The logic for creating a marker can be found in https://github.com/infusion-code/angular-maps/blob/master/src/models/marker.ts
Hope that helps. Let me know...


Update enabling AWS-Generated CATs with new screenshots

Issue #, if available:
Description of changes: Interfaces of Billing and Cost Allocation Tags page have been updated quite significantly since the time the Cost 100 lab was initially created. Updated the step of enabling AWS-Generated cost allocation tags with new screenshots of updated interfaces.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Is this ready to merge?


If-Match, If-None-Match not conformant with RFC2616

The special case of "" for the matchHash should not include quotes.  For example:
If-None-Match: *
is correct, but
If-None-Match: ""
is not correct.
See https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.26
This can be fixed by using the following function:
function formatHash(hash) {
if (hash === "*") {
return hash;
}
return '"' + hash + '"';
}
Usage example:
headers = { "If-Match": formatHash(matchHash) };

Thank you for the info. The fix is merged and should take care of this problem. Thanks!


Wrong hint for step 24 of Cafe Menu project

Describe the Issue
Wrong code hint in step 24 of Cafe Menu project.
Using two style selectors for the same element instead of one (as required), the hint says that the element does not have the property.
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-basic-css-by-building-a-cafe-menu/step-24
Your code
div {
  width: 300px;
}
div {
  background-color: burlywood;
}

Expected behavior
I would expect to be told that I need to use a single style selector instead the hint says

Your div should have a burlywood background.

Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

Although, I agree that hint should say something like,

add burlywood background in your created div from previous challenges.

I am against allowing two of the same selectors as accepted answer, not only it's bad practice. it may damage user experience, when they don't receive something developer intended to display in the DOM, because of selectors.
  width: 300px;
}
div {
  background-color: burlywood;
}

This seems to be the same on almost any step that has a user change the css. You can just add a second selector with the correct properties, and it fails. Typically, unless explicitly stated, we try to allow any valid code to pass the tests. Using a second selector applies the correct properties, so I think it should pass.
The tests for these are doing something like this:
const divBackground = new __helpers.CSSHelp(document).getStyle('div')?.getPropertyValue('background-color');
assert(divBackground === 'burlywood');

It's checking the CSS for the correct code. It looks at the first div it finds and checks if the property is there (pretty sure anyway). The helper functions live here. That test is using the getStyle method. In that method, it uses find() to find the first matching selector. Perhaps we could filter for the selector so it gets them all, and then look through all of those to see if the property is there. I think that might fix this issue across the entire curriculum. I don't think it would break anything else, but I'm not 100% sure.

I think one issue may be that up until now there is no where specified that a second property can or should be added to the same selector. As a quick patch we can add a sentence in the description saying to add the new property to the same selector.

I am still in favor of making the tests more lenient. There was quite a bit of back and forth in those linked issues @Sboonny, as well as in many other issues I'm sure - but the general consensus, in my observation, seems to consistently conclude that valid code should pass. You have to consider it on a case-by-base basis, though - if it's something absurd, we don't necessary need to accommodate.
I actually don't mind just fixing this with your suggestion @Sboonny. The problem is, we likely have dozens or maybe even hundreds of steps that have this issue - I found a handful in the dozen or so steps after this one. So the combination of our general history of making tests more lenient, and the fact that fixing these one at a time would not be fun, makes me stick with my original opinion.

I found a handful in the dozen or so steps after this one. So the combination of our general history of making tests more lenient, and the fact that fixing these one at a time would not be fun, makes me stick with my original opinion.

Ya, I agree.😓
I was over excited, because it's rare to find small issue for first-time-only, but with the issue being redundant and overtaxing. It's better going the lenient way.🤝👍

a good first issue could be adding the specification that the property should be added to already existing selector.


feature request: Feeding daily input

We have preemies and our nutritionist needs daily total input. It would be nice to have a dashboard item showing feedings daily totals.

There is now a "Feeding Amounts" report on master. Give it a try and let me know if you have any issues.

I see it, but it is showing the amount of a single feeding. not the totals for the day.
let me know if anything would be helpful to show.

we log feeds in ml.

I got caught up with a weird Plotly issue and didn't actually finish the functionality (: This should be fixed now. It also wasn't adjusted for timezone.

Works for me now. Thank you!!
On Wed, May 29, 2019, 4:49 PM Christopher Charbonneau Wells <
<EMAIL_ADDRESS>wrote:

I got caught up with a weird Plotly issue and didn't actually finish the
functionality (: This should be fixed now. It also wasn't adjusted for
timezone.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cdubz/babybuddy/issues/68?email_source=notifications&email_token=ABF63OF335JD65XXTWHR7L3PX3243A5CNFSM4HQH4FV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQXSSA#issuecomment-497121608,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABF63OHHFHWBRURMQCXMCRDPX3243ANCNFSM4HQH4FVQ
.


More typed arguments in withLatestFrom

Feature Request
Is your feature request related to a problem? Please describe.
Currently the max number of supported arguments in withLatestFrom is 5. Adding more than that results in any types.
Describe the solution you'd like
Add more function exports to the withLatestFrom.ts.
I'll gladly create a PR if above is an accepted solution.

I'm in two minds about adding more signatures, at this stage. Version 7 is currently being worked on and the focus of that version is improving the types - as we'll no longer be constrained by having to support TypeScript 2.8.
See https://github.com/ReactiveX/rxjs/issues/5066
On of the principal aims will be to solve this needs-more-args problem once and for all - by having signatures that support an arbitrary number of arguments.
That said, if withLastestFrom has fewer typed arguments than most of the other signatures, I wouldn't be opposed to adding more to bring it into line. If they all have five typed arguments, I think we should just leave it as is. TBH, I think more than five arguments to withLastestFrom is pretty edge-case-y.

Thanks for the explanation and pointing to the existing issue. Hopefully it will get better in v7.
However I don't think having more arguments is "edge-case-y" - it really depends on complexity of the application. In my case I have multiple UI components collecting input from user across a wizard-like steps. I use withLatestFrom to aggregate all of this data into a single request. Are there better ways of doing it? I could probably extract that into selectors (ngrx) but I would only do this to work around the typing issue.

Well,  I'm not saying it's wrong. I'm just saying that it's an edge case and I think this being the first time the issue has been raised - AFAICT - in a number of years attests to that.
Anyway, if you want, you can take advantage of TypeScripts interface module merging to add signatures with more typed parameters in userland. You should be able to add as many as you need - while you wait for v7 - by doing something like this:
declare module "rxjs/internal/operators/withLatestFrom" {
  export declare function withLatestFrom<
    T,
    O2 extends ObservableInput<any>,
    O3 extends ObservableInput<any>,
    O4 extends ObservableInput<any>,
    O5 extends ObservableInput<any>,
    O6 extends ObservableInput<any>,
    O7 extends ObservableInput<any>
  >(
    v2: O2, v3: O3, v4: O4, v5: O5, v6: O6, v7: O7
  ): OperatorFunction<T, [
    T,
    ObservedValueOf<O2>,
    ObservedValueOf<O3>,
    ObservedValueOf<O4>,
    ObservedValueOf<O5>,
    ObservedValueOf<O6>,
    ObservedValueOf<O7>
  ]>;
}

This is a perfect workaround for now. Thanks!

Update:
I haven't been able to make this work as suggested, by merging definitions. Doing as suggested overwrites the definitions so Typescript only sees the declarations for that module in my typings.d.ts. Adding an export to declare module fixed the issue and now they are merged but then it stills shows any type as the output for some reason, even though it identifies the signature correctly. Not sure if I'm missing something or it's Typescript.
I ended up copying all of the signatures from withLatestFrom.d.ts to my typings.d.ts and also adding the extensions - now it seems to work.

I would not have put it in a .d.ts file. I would have put the snippet into a .ts file.

https://stackoverflow.com/a/45517745/6680611

I've had time to try it and this seems to be fine for me - with RxJS 6.5.4 and TypeScript 3.7.4:
import { ObservableInput, ObservedValueOf, of, OperatorFunction } from "rxjs";
import { withLatestFrom } from "rxjs/operators";

declare module "rxjs/internal/operators/withLatestFrom" {
  export function withLatestFrom<
    T,
    O2 extends ObservableInput<any>,
    O3 extends ObservableInput<any>,
    O4 extends ObservableInput<any>,
    O5 extends ObservableInput<any>,
    O6 extends ObservableInput<any>,
    O7 extends ObservableInput<any>
  >(
    v2: O2,
    v3: O3,
    v4: O4,
    v5: O5,
    v6: O6,
    v7: O7
  ): OperatorFunction<
    T,
    [
      T,
      ObservedValueOf<O2>,
      ObservedValueOf<O3>,
      ObservedValueOf<O4>,
      ObservedValueOf<O5>,
      ObservedValueOf<O6>,
      ObservedValueOf<O7>
    ]
  >;
}

const source = of(1).pipe(
  withLatestFrom(of(2), of(3), of(4), of(5), of(6), of(7))
);

Closing this, as it's going to be addressed in v7 and there is a userland workaround.
if you have problems with the workaround, feel free to comment in this issue, though.


Add Gentoo and OpenRC Support

Hello, i've added support for Gentoo Linux. Would it be possible to merge it as this script is really helpful but lacks of support for Gentoo Linux users. Since Gentoo is flexible about the init system, i've also added support for OpenRC. The overhead for the support of 2 init systems isn't too big as i've wrapped a simple function around it.

I wouldn't usually agree to that, but first of all, thank you for doing things properly! 👍

Thanks for your response. I've fixed that issue with the uninstall. Didn't really notice as the scripts installs OpenVPN anyways each time you redo the process.
I've also added Gentoo into this description for the error and updated Readme.md. Somehow i forgot about this.
Surely it is your project but the support for Gentoo and OpenRC doesn't seem like a big change to the script for me. It's just the additional init function, few replaced strings and a couple more IFs.

Is there any chance of this ever being merged or you decided against it?

Sorry, I'm abroad so I have less time for GitHub stuff as you can see on my graph 🙂
I also I have to see how to setup a Gentoo VM to test this PR...

Gentoo is not supported natively on:

Digital Ocean
Vultr
GCP
AWS
Hetzner
...

That's why I was against this initially. First, that means very few people would actually use the script on Gentoo. Secondly, that means I can't easily test it on Gentoo, and that's a problem...

AWS AMIs: http://www.dowdandassociates.com/products/pygoscelis-papua/

Thanks @tidux

Errors I see:
+ sed -i 's/^RANDFILE/#RANDFILE/g' pki/openssl-easyrsa.cnf
sed: can't read pki/openssl-easyrsa.cnf: No such file or directory

+ /etc/init.d/iptables-openvpn start
 * Caching service dependencies ...                                                                                [ ok ]
 * Starting  ...                                                                                [ !! ]
 * ERROR: iptables-openvpn failed to start

This workaround should be skipped on Gentoo since it does not seem to be affected:
# Workaround to remove unharmful error until easy-rsa 3.0.7
# https://github.com/OpenVPN/easy-rsa/issues/261
sed -i 's/^RANDFILE/#RANDFILE/g' pki/openssl-easyrsa.cnf


Breaking block quotes

Working on my Changelog.rst for Nuitka, I discovered this breaking change done by rstfmt 0.0.6:
From this code:
python 2.6::

   Pystone(1.1) time for 50000 passes = 0.48
   This machine benchmarks at 104167 pystones/second

it creates:
python 2.6:

.. code::

   Pystone(1.1) time for 50000 passes = 0.48
   This machine benchmarks at 104167 pystones/second

The later is wrong, this is not code (I think Python is the default). When I run it again, it does not complain about invalid Python, but if I add it, it does. The rst2pdf however complains very loudly about this rest code for that reason. So I think, this reveals 2 bugs in rst2fmt, fist missing default language, second turning block quotes to code, which is not correct. I am merely quoting program outputs with block quotes.
On a side note, I was deeply impressed by the black integration you are using there, very nice, and it found a bunch of syntax errors in my code snippets, good job there, making that happen, very appreciated. For now, I will do a search and replace to fix these up, but I can use the end result otherwise I believe.

I have updated to 0.0.7 from PyPI (for which code is on dev, but not on master) but the issue here is still present.

The issue is still present, but I checked in the official docs, and it says this that the change I am complaining about is absolutely valid: https://docutils.sourceforge.io/docs/ref/rst/directives.html#id44
It's just that rst2pdf will not accept it that way, but that's just a search and replace away. That's not your issue. Not sure yet about Nikola, but I guess it either works there, or it's their issue as well.
The other issues I can confirm are all solved. I am going to add it to my development requires and commit hook to have the automatic formatting. Big relief, thanks for your hard work on this.


A few Win7 issues

Hitting enter rather than make a valid selection:
C:\Users\John\My Documents\GitHub\folie>folie.exe
<open> Select a serial port:
   0 = COM255
   1 = COM61
←[J←[2K
2016/10/20 11:47:08 strconv.ParseInt: parsing "": invalid syntax

If the selection is made '1' without a terminating  then strange EOL characters.
C:\Users\John\My Documents\GitHub\folie>folie.exe
<open> Select a serial port:
   0 = COM255
   1 = COM61
1[J←[2K

Selecting the appropriate COM61 port produces "[connected]" as normal, first letter of "upload" produces bad characters but command is accepted and then fails to upload:
C:\Users\John\My Documents\GitHub\folie>folie.exe
<open> Select a serial port:
   0 = COM255
   1 = COM61
1←[J←[2K
[connected]
upload [J←[2K
  700b ......+
Failed: 1f

Failed: 00
v00
Failed: 1f

Failed: 00
#0000
Failed: 1f

Failed: 00
R .
Failed: 1f

Failed: 00
W .
Failed: 1f

Failed: 1f
E writing: 1/3 ←[J←[2K
Failed: 1f

Failed: 1f

Failed: 1f
2/3
Failed: 1f

Failed: 1f

Failed: 1f
3/3
Failed: 1f

Failed: 1f

Failed: 1f
done.
▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼yy

BOOT0 is set and reset hit doesn't change what is happening.

Still issues:
C:\Users\John\My Documents\Github\folie>folie.exe -v
Select a serial port:
1 = COM255
2 = COM40
2←[J←[2K
[connected: COM40]
!u f103-blink [J←[2K
724b >7f.>7f<79+>00>ff<1f
Failed: 1f
Failed: 00
V00 >02>fd<1f
Failed: 1f
Failed: 00
#0000 >92>6d<1f
Failed: 1f
Failed: 00
R >7f<1f>73>8c<79<79W >7f.>7f<79+>43>bc<1f
Failed: 1f

ff>00<1f
Failed: 1f
E writing: 1/3 >31>ce<1f
Failed: 1f
08>00>00>00>08<1f
Failed: 1f
ff>00>50>00>20>45>02>00>08>43>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>0
2>00>08>00>00>00>00>00>00>00>00>00>00>00>00>00>00>00>00>43>02>00>08>43>02>00>08>
00>00>00>00>43>02>00>08>43>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00
08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>0
2>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>
41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00
08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>0
2>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>
41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00
08>41>02>00>08>41>02>00>08>41>02>00>08>41>02>00>08>89<1f
Failed: 1f
2/3
Failed: 1f

Failed: 1f
Failed: 1f
3/3
Failed: 1f
Failed: 1f
Failed: 1f
done.
recv: "\x1f"
▼recv: "\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f"
▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼
▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼recv: "
x1f"
▼recv: "\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f\x1f
\x1f\x1f\x1f"
▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼▼

Is this the same F103 µC which works properly from a Mac, or a different µC board?

Same device.

Ok, so it looks like we're not there yet on Windows.
Not the very very latest folie code, from what I can tell from the output.
But that's probably irrelevant here. I'll need to investigate further...

Please try another USB interface, if you have one, non-FTDI if possible. That unit may not have been configured properly - at least that's what I ran into here with a BUB3.

Update - looks like this hasn't been solved yet - troubles with timing, it appears.
May have to wait until issue #22 has been addressed.

This is most likely the same issue as #36, which has been fixed by an update in the go-serial package. I'll include the fix in the next Folie cycle. Closing this issue for now.


APIError(code=-2010): Order would trigger immediately.

Trying to create a stop loss limit order and getting the error that I wrote in the title. I tried different quantity and price values (passing them or writing them manually). My clipboard contains "2000" as well.

According to binance's documentation, this error appears when there is a problem with the stop price:
"Order would trigger immediately."   --  The order's stop price is not valid when compared to the last traded price.
The maximum stop price allowed has to be equal or lower than maxPrice (which is 10 million for ETHUSDT). How can I figure out what is considered a valid stop price compared to the last traded price? (or is this not the reason for the error at all?)


soc: arm: st_stm32: h7: support DT-defined MPU regions

Adds the ability to define MPU regions in the DTS.
Some MCUs (i.e. H730) require the MPU region to be configured before it's used (e.g. FMC PSRAM).
In combination with #45969, it is possible to configure the required MPU region for the FMC on
H730 MCU so that the FMC could be used with an external display.
For example:
	fmc_ext_mem: fmc_ext_mem@64000000 {
		compatible = "zephyr,memory-region", "mmio-sram";
		reg = <0x64000000 DT_SIZE_M(64)>;
		zephyr,memory-region = "PSRAM2";
		zephyr,memory-region-mpu = "IO";
	};

Fixed by https://github.com/zephyrproject-rtos/zephyr/pull/46663/

Why not merge existing and older PRs? I don't mind as changes are identical.

Sorry, it appears that I didn't check very well the existing PR before submitting #46663.


[Question] How to check my data is secured ?

I'm using this lib and I'd like to check that the data are stored securely on my iOS and Android devices.
What is the easiest way to do this?

Hopefully @mCodex gives us an input about this topic?

This may be a little bit late, but I would recommend checking out the following resources for local storage security testing

Android
iOS


Enhances spo page section add extend zoneEmphasis options. Closes #6037

Extends spo page section add extend zoneEmphasis options. Closes #6037

Hi @Jwaegebaert thank you very much for the review. I hope I have made all the requested changes. 😀

Seems like I forgot to submit my approval before merging this one. Nicely done @mkm17! No worries about the oversight I mentioned, that's totally on me. I ran into some issues during the final review, and it looks like not all the changes went through but I got it working in the end.


Development workflow documentation for the current state of the world.

Note the modules section and the integration tests section isn't too much of a concern since we're changing those pretty soon anyways, at least ideally. The current state of how to run integration tests isn't great and we should be looking into improving that.

@ash211 @foxish @iyanuobidele

Do we also want to link the proposal, https://github.com/kubernetes/kubernetes/issues/34377 and the JIRA here?

@foxish good idea but I think just the JIRA will suffice since the proposal is attached to it.

Sounds good. Rest LGTM.

@aash addressed clarification, good to merge?


v3.0 beta Some variables gives no feedback

$(qlabfb:n_num) and $(qlabfb:r_num) doesn't work, there is no feedback. Passcode is used.
Latest bets used.

Sorry, it seems there is a bug with qlab, because no number are automatically assigned when adding a new file.


(Fix) Display proper amount of tokens bought

Closes #847

@fernandomg looks like one unit test is failed.

FAIL  src/components/stepTwo/StepTwoForm.spec.js
● StepTwoForm › should render StepTwoForm for Minted Capped Crowdsale

Could you take a look?

I've just bought 20 tokens, with no problem: https://ropsten.etherscan.io/tx/0x12a946ed095075b625ce096f92f004d34ff3f498af93640145def8a786c9a968
Running locally, pointing to ropsten. Netlify link is not working for me.

@fernandomg I still can not buy from display-proper-amount-of-tokens-bought-#847 branch without whitelist. Example: https://ropsten.etherscan.io/tx/0x811e37a6c9da06eb576b5a1fd088803bbdbd959c64bf3bb90de635a3d5284bfb.
It is from http://localhost:3000/invest?exec-id=0xed512c68f71b91f6710db02adffdb886686a8c64e4c18b82ee30692375b8527d&networkID=3
But I can do it with the previous wizard 2.0 beta: https://5af093921f12b70ce2f90775--architect-coin-64174.netlify.com/invest?exec-id=0xed512c68f71b91f6710db02adffdb886686a8c64e4c18b82ee30692375b8527d&networkID=3
Are you able to buy from branch display-proper-amount-of-tokens-bought-#847 for exec-id: 0xed512c68f71b91f6710db02adffdb886686a8c64e4c18b82ee30692375b8527d?


Heron submission works incorrectly with kubernetes with special characters

Heron client give appropriate error message when topology name same has special character like "_"
when submitting to a kubernetes cluster , but it submits it anyways.

I recall getting an exception message when trying to submit a topology to kubernetes which didn't follow it's naming constraints (alphanum+-_ in up to 64 characters), so I think this is ok now

Correct, I believe there is now name validation in the Kubernetes scheduler. Closing the issue.


Translate instructions in code comments

Hello, I've seen that many leves haven't translated the instructions that is given by means of line coments.
I'd like to help with that technical translation.

If you want to translate level related things, just go to http://codecombat.com/i18n, and then find the level you want to translate. By the way, thank you for doing it :+1:

Comment token remains unchanged without any minimal hint. Is it possible to get it dinamically?

Which level is it?

I've tested change level and got it on first 3, and one from the second world. So... I think it's on all that the -- down's change automatically to #. In coffe script it can make hints won't appear on first level, and on the next levels, It says that syntax is wrong without any hint at all.

I don't think this is related to translations, is it?

Nope it seems language changing related

I think I have another bug somewhere for changing code languages not necessarily reloading the code properly–that seems to be what's going on?


Add DevExpress XPO ORM to readme.md

ORM/eXpress Persistent Objects (XPO) - PROJECT_LINK
PROJECT_DESCRIPTION
eXpress Persistent Objects (XPO) is an Object-Relational Mapping (ORM) tool that handles all aspects of database creation and object persistence, allowing you to concentrate on your application's business logic rather than database complexities.

Publicly available community forum or other place for discussions and support

See in the DevExpress Support Center under the Frameworks (XAF & XPO) category on the right.

Generally useful to the community
At least 1 year on the market
Stable

First released in 2003 (history) and being used by thouthands of DevExpress non-DevExpress .NET  developers. It is at the core of another DevExpress XAF product for 13 years too.

Free trial or preview

Fully functional and free-of-charge, available from Nuget.org or free DevExpress trial installer.

Actively maintained (even if that just means acknowledging open issues when they arise)

Monthly minor releases with bug fixes and minor improvements, two major releases per year. See details under the .NET products category.

Documented

Comprehensive offline and online documentation: https://documentation.devexpress.com/CoreLibraries/1998/DevExpress-ORM-Tool, hundreds of KB Articles in the DevExpress Support Center and code examples on GitHub, online and offline demos

Tests

Thouthands of unit tests internally. Public performance tests online.

@quozd , Hello, do you need more information to be able to merge this? Thank you for your help in advance.

Hey, Could you please merge in the Master and remove all changes except for the one to add the library and probably squash the commits? We usually fix CI build issues in separate PRs to keep scope of changes limited and focused so that we can review and react faster.


Make the user serializer configurable for LoginView

So that's easily overridable when hosting more than one instance
of LoginView in the same project.

oh, merged it a bit early. strictly speaking this is not a bugfix, so it should be 3.6.0
and we need to amend the version number also in setup.py. then i can release it

Thanks for merging, I'm not in a hurry to have a release with this included but still created a PR for 3.6.0 :)


feat(card): adding tooltip to the card extra actions

Closes https://github.com/carbon-design-system/carbon-addons-iot-react/issues/3526
Summary

adding tooltip to the card extra actions

Change List (commits, features, bugs, etc)

feat(card): adding tooltip to the card extra actions

Acceptance Test (how to verify the PR)

tooltips can be passed from the props

Regression Test (how to make sure this PR doesn't break old functionality)

card should work with out any issues

Things to look for during review

[ ] Make sure all references to iot or bx class prefix is using the prefix variable
[ ] (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
[ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
[ ] All strings should be translatable.
[ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
[ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
[ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
[ ] Changes or new components should either write new or update existing documentation.
[ ] PR should link and close out an existing issue

It does not explicitly state it in the spec but the dropdown convention is for the 3 dot which is how it is shown through out the spec. @dianatran18 is it cool to allow for different type of dropdown icons for the card?

@dianatran18 is it allowed for different type of dropdown icons for the card ?

merging issues, the branch seems to be not clean. So fixing the issue in https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3540


[LIVY-491][LIVY-492][LIVY-493] Add Thriftserver module and implementation

What changes were proposed in this pull request?
The PR contains an implementation of a JDBC API for Livy server based on the Hive Thriftserver. The implementation is based on the version 3.0 of Hive Thriftserver.
This initial PR contains the thriftserver module added to Livy and its implementation. It doesn't contain any binding for starting it, this will be added later.
How was this patch tested?
added integration tests as UTs

cc @jerryshao

travis failure now is intermittent, but I am not sure how to retrigger a build. Anyway it is a timeout in a job which passed in the commit before, and the last commit modifies only the timeout for the tests in the thriftserver module, so it completely unrelated to the timeout which occurs in the last failed job.

thank you very much for looking at this @vanzin , really appreciated.

@mgaido91 close and reopen this PR could trigger the travis to run again.

@mgaido91 what's the key purpose to copy thrift related codes to Livy? In Spark2 because we don't want to rely on Hive thrift library, also don't want to be to hacky to change the Hive related codes, so we copied the code to Spark. But here in Livy do we have a such requirement?

@jerryshao thanks for you review.
The main reason for copying the classes from Hive are:

We need to override private methods, so either we do it using reflection and kind of rewriting some methods using reflection or copying the Hive code and doing some very small changes about visibility and very small changes in order to make the code easier to extend (this is the least important reason);
Avoid metastore access from the server, which is otherwise intrinsic in Hive codebase;
This needs further investigation, but the UGI management which is performed automatically by Hive may need to be removed/adjusted in order not to interfere with the one performed by Livy.

I think that the 1 issue can be easily addressed by cooperating with the Hive community, but the other 2 points may be more critical to address. I'd consider the current situation as a workaround which will be replaced by using only Hive's artifacts once we can  solve the 3 points above with the help of the Hive community.

Codecov Report

Merging #104 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
- Coverage      71.4%   71.21%   -0.19%
- Complexity      796      797       +1
============================================
  Files            97       97
  Lines          5476     5479       +3
  Branches        816      816
============================================
- Hits           3910     3902       -8
- Misses         1036     1045       +9
- Partials        530      532       +2

Impacted Files
Coverage Δ
Complexity Δ

...rver/src/main/scala/org/apache/livy/LivyConf.scala
93.79% <100%> (+0.14%)
21 <0> (ø)
:arrow_down:

...e/livy/server/interactive/InteractiveSession.scala
67.18% <100%> (ø)
43 <1> (+1)
:arrow_up:

...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala
52.94% <0%> (-2.95%)
0% <0%> (ø)

...c/main/scala/org/apache/livy/repl/ReplDriver.scala
30% <0%> (-2.5%)
0% <0%> (ø)

...main/java/org/apache/livy/rsc/ContextLauncher.java
81.86% <0%> (-2.46%)
18% <0%> (ø)

rsc/src/main/java/org/apache/livy/rsc/Utils.java
83.33% <0%> (-2.39%)
16% <0%> (ø)

...ain/java/org/apache/livy/rsc/driver/RSCDriver.java
80.25% <0%> (-0.85%)
43% <0%> (ø)

rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java
79.28% <0%> (-0.6%)
12% <0%> (ø)

.../scala/org/apache/livy/sessions/SessionState.scala
59.45% <0%> (ø)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551dd5c...f25f84e. Read the comment docs.

@vanzin I updated the description adding some comments on what was done in the Hive classes. Let me know if something else is needed. Thanks.

Sorry I'm quite busy these days, will take a review before the end of this week.

Hi @mgaido91 , would you please provide us a diff about what you changed to the Hive code? Currently I don't know which part is changed in Hive code, and which part is just simply pulled from Hive.
I think we can merge as it is and play it locally to see how it is. but I agree with Marcelo that we should not ship or suggest user to use it until it is stable enough.

I agree with Marcelo that we should not ship or suggest user to use it until it is stable enough.

I agree too. I think at very least, we should complete all the JIRAs under LIVY-489 to consider the first version of it to be ready. Then more testing is needed too in order to make it stable. Only then we can consider to ship/suggest this.

would you please provide us a diff about what you changed to the Hive code?

Here is the diff. Please notice that now this diff is quite large because of the removal of some Hive dependencies.
hive-diff.txt

One unrelated flaky issue. I'm going to merge this so that we could verify it locally. @mgaido91 you can continue the work based on this. Thanks!

Thanks @jerryshao and @vanzin


TAF reports do not show in Jenkins in online web report

🐞 Bug Report
Affected Services [REQUIRED]
Is this a regression?
?
Description and Minimal Reproduction [REQUIRED]
TAF reports do not show in Jenkins

This is a limitation for LF Jenkins, please download report to local by zip link


PEAR-2024 - Replace sample_type with new properties in the portal

Description
Checklist

[x] Added proper unit tests
[x] Left proper TODO messages for any remaining tasks
[x] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks good 👍


Fix logging error while load configs

Closes: https://github.com/metarhia/impress/issues/1142

Landed in 3089a93


Change visibility of Function "CreateText" in CodeUnit "Reservation Engine Mgt." to External

Change visibility of Function CreateText in CodeUnit Reservation Engine Mgt. to External.
External CreateText(ReservEntry : Record "Reservation Entry") : Text[80]
The existing Methods can't be called with a temporary record.

Yes the methods don't support passing temp. records. Thanks!


How would I capture on entering a screen event

Upon entering a screen I need to do something, how would I track this event? Looks like none of componentDidMount or componentDidUpdate or render is called when navigating back.

Given componentWillMount, and/or componentDidMount won't be called on navigation back event I suppose you are talking about StackNavigator, correct?
This is expected behaviour, since component is mounted already, even when navigating back.
Instead, look here at onTransitionStart / onTransitionEnd  event handlers

This is duplicate of #51


temp fix for - cannot read property 'source' of undefined

This will have to do until someone can find a better way. Don't really have the time to look into it, plus I will soon be moving away from having to use inline code.

Haven't tried to fix this by myself, but this fix works for me.
Any chance it gets merged into master any time soon?

Haven't tried to fix this by myself, but this fix works for me.
Any chance it gets merged into master any time soon?

I have tried to contact dustinjackson multiple times through email about help with this repo but no luck. He's not on very often so I am not sure.


Add a copyright statement

The repository has a LICENSE file but there is no information on who holds the copyright to RiboViz. Add this to the README.md file.

Commit d1a0cb0 adds copyright based on contributors recorded in commits:

*RiboViz is Copyright (2016-2020) The University of Edinburgh; Rutgers University; University of California, Berkeley; The University of Pennsylvania.


Ability to get privacy settings

Thank you, but this is outside the scope of node-steam-tradeoffers.


Redundant ampersand when trying to remove query param

Version
4.0.6
Reproduction link
https://codesandbox.io/s/priceless-https-bvip5
Steps to reproduce

Open reproduction link, take a look at the url and just wait for 2 timeouts.
When second timeout is passed you'll notice unnecessary ampersand sign at the end of the current url.

What is expected?
When I pass undefined or empty array as a query parameter value then I expect query parameter will be completely removed from the current url.
What is actually happening?
Query parameter was properly removed but unnecessary & sign still presents at the end of the url.

I believe that's because of this line: https://github.com/vuejs/vue-router-next/blob/ecd52e017ac30fa996d4796974371374f65640d1/src/query.ts#L92
It doesn't take into account the passed value and appends & sign right away no matter whether the value is null or undefined.

@posva ok, I'm going to submit a PR with the fix a little bit later.
To be honest, I feel the current implementation of stringifyQuery is slightly verbose so I did a little refactoring and made it more declarative.
What do you think about the following implementation?
export function stringifyQuery(query: LocationQueryRaw): string {
  return Object.entries(query).reduce((acc: string[], [key, value]): string[] => {
    const values: LocationQueryValueRaw[] = Array.isArray(value)
      ? value.map(v => v && encodeQueryValue(v))
      : [value && encodeQueryValue(value)]

    key = encodeQueryKey(key)
    const pair = values.reduce((acc: string[], chunk): string[] => {
      if (chunk === undefined) return acc
      if (chunk === null) return [...acc, key]
      return [...acc, [key, chunk].join('=')]
    }, [])

    return [...acc, ...pair]
  }, [])
    .join('&')
}

I think it's more straightforward, we just specify all the edge-cases in the second reduce and do not worry about separators anymore as they would be added automatically by joins.
That implementation has passed all tests and also takes into account the issue we were talking about above.

Let's not refactor with that version for performance and compatibility reasons


Change assembly version

Help me !
I see inductance inductance error

The

current in the coil is faulty

Hi,
If you think you found a bug, please create an issue with some example circuit code to reproduce it.
Yours sincerely,
Sven


Missing information on basic paging

While we have a topic dedicated to paging large result sets with the paging cookie Page large result sets with FetchXML
I don't see anything about the simple approach to get the next page by simply setting the page attribute value. i.e. <fetch page='2' > without a paging cookie.
For example:
<fetch count='2' page='1' >
  <entity name='account' >
    <attribute name='name' />
    <order attribute='name' />
  </entity>
</fetch>

Changing page to 2 will bring the next 2 records.
Paging cookie is an optimization for large result sets, but it adds a good deal of complexity to what could be very simple, especially for ad hoc queries.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a55426bf-e3ed-2d4f-d2e9-1edf60ebe6c6
Version Independent ID: d26739ec-4b1e-77da-7ba3-fa87e7723300
Content: Use FetchXML to query data (Common Data Service) - PowerApps
Content Source: powerapps-docs/developer/common-data-service/use-fetchxml-construct-query.md
Service: powerapps
GitHub Login: @brandonsimons
Microsoft Alias: jdaly

FetchXML queries can return as many pages as required without using Paging Cookie if the number of rows in the entities is less than 12500 rows. If we try to retrieve pages of rows after the first 12500 rows, then we will get an error that Paging Cookie is required.

In the documentation here:
https://docs.microsoft.com/en-us/powerapps/developer/common-data-service/org-service/page-large-result-sets-with-fetchxml
It's written:
When you use the paging cookie with FetchXML, make sure that you use the correct encoding. The following example shows the correct encoding when using the paging cookie with FetchXML
Without explanation on how to convert the paging cookie returned in the http response to this form. It took from me couple of hours to find that the returned paging cookie is doubly html encoded, so I had to decode it twice and then escape the xml special characters to get the paging-cookie provided in the example

@JimDaly Thanks for your feedback. We are closing this issue because we are either unable to find relevant information or reproduce this. If you're still experiencing the issue described here, please reopen or create a new issue.


Warning in nix-shell

When starting nix-shell for the second time, I get:
$ nix-shell
trace: No index state specified for nix-haskell-haskell-template, using the latest index state that we know about (2021-01-05T00:00:00Z)!trace: To make project.plan-nix for hoogle a fixed-output derivation but not materialized, set `plan-sha256` to the output of the 'calculateMaterializedSha' script in 'passthru'.
trace: To materialize project.plan-nix for hoogle entirely, pass a writable path as the `materialized` argument and run the 'updateMaterialized' script in 'passthru'.
trace: No index state specified for cabal-install, using the latest index state that we know about (2021-01-05T00:00:00Z)!
trace: No index state specified for ghcid, using the latest index state that we know about (2021-01-05T00:00:00Z)!
trace: To make project.plan-nix for haskell-language-server a fixed-output derivation but not materialized, set `plan-sha256` to the output of the 'calculateMaterializedSha' script in 'passthru'.
trace: To materialize project.plan-nix for haskell-language-server entirely, pass a writable path as the `materialized` argument and run the 'updateMaterialized' script in 'passthru'.
trace: No index state specified for ormolu, using the latest index state that we know about (2021-01-05T00:00:00Z)!

Good point, I added a note about it https://github.com/jonascarpay/jonascarpay.github.io/commit/c588c0f7416309197091bcfec08b7d953bab4913


Add signer to support signing windows artifacts

Signed-off-by: Zelin Hao<EMAIL_ADDRESS>Description
This PR will enable our sign script to sign for windows distribution and also the jenkins library signArtifacts to be able to sign for windows platform.
For windows signing with the scripts, the signed artifacts will be stored in a subfolder called signed and keep its origin name. E.g.: the original unsigned file path is /tmp/opensearch.exe, the signed artifacts will be stored with file path /tmp/signed/opensearch.exe.
Issues Resolved
#1430
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2156 (6c1fe26) into main (ad5674b) will increase coverage by 5.43%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2156      +/-   ##
=============================================
+ Coverage     94.56%   100.00%   +5.43%
=============================================
  Files           204         6     -198
  Lines          4253       105    -4148
  Branches         29        19      -10
=============================================
- Hits           4022       105    -3917
+ Misses          225         0     -225
+ Partials          6         0       -6

Impacted Files
Coverage Δ

src/run_sign.py

src/sign_workflow/sign_args.py

src/sign_workflow/sign_artifacts.py

src/sign_workflow/signer_pgp.py

src/manifests/build_manifest.py

src/test_workflow/perf_test/perf_args.py

src/ci_workflow/ci_target.py

src/ci_workflow/ci_check_list_dist.py

src/manifests/build/build_manifest_1_1.py

src/git/git_repository.py

... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5674b...6c1fe26. Read the comment docs.

Move back to draft as rpm signing PR #2190 has modified signing workflow already.

I will be working based on the comments above and the conflict we had on this PR with the RPM temporary signing PR #2196

Added the abstract Signer class and separate signer class for PGP signing and windows signing. The hierarchy of the python signing workflow should look much better now.

This is strange. Tests passed locally for the sign_workflow.
~/workplace/test/opensearch-build[sign-for-windows] pipenv run pytest tests/tests_sign_workflow/
.............................                                                                                [100%]
29 passed in 94.33s (0:01:34)

Also not sure why tests for other workflows failed though I didn't modify any of them.
Looking into these test failures.

Fixed the tests failure for sign_workflow. Still not sure how tests of other workflows failed though.
FAILED tests/tests_system/test_temporary_directory.py::TestTemporaryDirectory::test_chdir_false
FAILED tests/tests_system/test_temporary_directory.py::TestTemporaryDirectory::test_chdir_true
FAILED tests/tests_system/test_temporary_directory.py::TestTemporaryDirectory::test_keep_false
FAILED tests/tests_system/test_temporary_directory.py::TestTemporaryDirectory::test_keep_true
FAILED tests/tests_system/test_temporary_directory.py::TestTemporaryDirectory::test_path
FAILED tests/tests_system/test_temporary_directory.py::TestTemporaryDirectory::test_remove_readonly
FAILED tests/tests_system/test_zip_file.py::TestZipFile::test_extractall_preserves_permissions
FAILED tests/tests_test_workflow/test_test_component.py::TestTestComponent::test_checkout
FAILED tests/tests_test_workflow/test_bwc_workflow/bwc_test/test_bwc_test_runner_opensearch.py::TestBwcTestRunnerOpenSearch::test_component_not_in_test_manifest
FAILED tests/tests_test_workflow/test_bwc_workflow/bwc_test/test_bwc_test_runner_opensearch.py::TestBwcTestRunnerOpenSearch::test_without_bwc_test
FAILED tests/tests_test_workflow/test_bwc_workflow/bwc_test/test_bwc_test_runner_opensearch_dashboards.py::TestBwcTestRunnerOpenSearchDashboards::test_component_not_in_test_manifest
FAILED tests/tests_test_workflow/test_bwc_workflow/bwc_test/test_bwc_test_runner_opensearch_dashboards.py::TestBwcTestRunnerOpenSearchDashboards::test_without_bwc_test
FAILED tests/tests_test_workflow/test_integ_workflow/integ_test/test_integ_test_runner_opensearch.py::TestIntegTestRunnerOpenSearch::test_component_not_in_test_manifest
FAILED tests/tests_test_workflow/test_integ_workflow/integ_test/test_integ_test_runner_opensearch.py::TestIntegTestRunnerOpenSearch::test_without_integ_test
14 failed, 569 passed in 80.94s (0:01:20)