Feat/initial settings page layout change

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/27407
PROPOSAL: https://github.com/Expensify/App/issues/27407#issuecomment-1718778644
Tests

[x] Verify that no errors appear in the JS console

Navigate to settings page Verify the layout matches the design in https://github.com/Expensify/App/issues/27407
Navigate to Preferences Verify the layout is same as before
Navigate to WS list  page and Verify the layout is same as before
Navigate to Status page and Verify the layout is same as before
Navigate to Lounge Access Verify the layout is same as before
Navigate to  Security, Verify the layout is same as before
Navigate to Teachers Unite page Verify the layout is same as before

Offline tests

Navigate to settings page Verify the layout matches the design in https://github.com/Expensify/App/issues/27407
Navigate to Preferences Verify the layout is same as before
Navigate to WS list  page and Verify the layout is same as before
Navigate to Status page and Verify the layout is same as before
Navigate to Lounge Access Verify the layout is same as before
Navigate to  Security, Verify the layout is same as before
Navigate to Teachers Unite page Verify the layout is same as before

QA Steps

[x] Verify that no errors appear in the JS console

Navigate to settings page Verify the layout matches the design in https://github.com/Expensify/App/issues/27407
Navigate to Preferences Verify the layout is same as before
Navigate to WS list  page and Verify the layout is same as before
Navigate to Status page and Verify the layout is same as before
Navigate to Lounge Access Verify the layout is same as before
Navigate to  Security, Verify the layout is same as before
Navigate to Teachers Unite page Verify the layout is same as before

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/104348397/c9e424e6-fde9-45d6-a9fd-798623c6ec1e

Mobile Web - Chrome
https://github.com/Expensify/App/assets/104348397/fa699845-7d8e-4765-a671-448922bacdea

Mobile Web - Safari
https://github.com/Expensify/App/assets/104348397/e64b4158-fdc9-4183-944e-0f3becab54bc

Desktop

iOS
https://github.com/Expensify/App/assets/104348397/52f653dc-03df-44cd-a22e-1b9f6af9e78a

Android

Settings
Preferences
WS list
Security
LougeAccess
Teachers Unite
Status

On hold Waiting for response to this https://github.com/Expensify/App/issues/27407#issuecomment-1719440440

@narefyev91 Review changes when you got the chance,
Context - This PR refactors the IllustratedHeaderPageLayout and StaticHeaderPageLayout to make the code DRY, and implement new layout for InitialSettings Page

@roryabraham PR is open for review, Can you take a loot and let me know if there are any changes. Thanks

@ishpaul777 can you please fix merge conflicts

We also need here design team to take a look on current result and expected behaviour cc @shawnborton

No issues found during testing - the only thing is having platform specific code inside some files - like !Browser.isSafari() - which we currently did not have for the same flows. Maybe worse trying to find solution without having it in the code

Thanks for the review @narefyev91, the safari specific code you refering to was added as part of this PR. Please check this https://github.com/Expensify/App/pull/26873#pullrequestreview-1618889173 for context why this was added

If everything looks good to you, Can you approve so that melvin assign @roryabraham for review.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.74-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Error: Cannot find module 'reducers'

Hello,
I did:
git clone https://github.com/choonkending/react-webpack-node.git
npm install
npm run devHotLoader
Error is:
Error: Cannot find module 'reducers'
My node v = node v5.0.0
My npm v =  npm  v3.3.9
Did I forget something?

@Pasta Thanks for raising this!
Just tested and verified that this issue does exist. Sorry about this, I'm currently looking into refactoring the codebase to be better, and part of that is removing hotloader and using react-transform-hmr instead. In the meantime, use  npm run watch to compile and npm run dev to start server.
If you like, I'd be happy to have a PR for using react-transform-hmr

@Pasta Shouldn't have this issue anymore. Closing this issue, but feel free to comment.

same here with the current version and node 5.11.1.
ERROR in ./store/configureStore.js
Module not found: Error: Cannot resolve module 'reducers' in /app/store
 @ ./store/configureStore.js 19:16-35

> babel-node --presets es2015,stage-0 --ignore node_modules,public "server/index.js" "index.js"

/public/assets/server.js:55825
	var _reducers = __webpack_require__(!(function webpackMissingModule() { var e = new Error("Cannot find module \"reducers\""); e.code = 'MODULE_NOT_FOUND'; throw e; }()));
	                                                                               ^

Error: Cannot find module "reducers"


Roll engine to c3504b519fcd95179ea832460758712ecd0e433d

This picks up a change which fixes deps files generated by the snapshotter.

LGTM


fix: Custom sql issue in table viz with raw records

SUMMARY

This issue was happened because in backend, when we validate sql, we got wrong sql string from columns.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER:
Best JSON Viewer and JSON Beautifier Online - 22 June 2022 - Watch Video
TESTING INSTRUCTIONS

Create a Table with Raw Records as the type
Drag in a metric
Add a column using Custom SQL
You can try adding a constant or just type out any column name

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up


TOURNAMENT:completed not rising

Hi, don't know what am I doing wrong but...
const engine = new Tournament(tournamentID, TPlayers, tournamentSettings);

engine.on('TOURNAMENT:completed', function () {
    console.log(chalk.bold.gray('Tournament completed.'));
});

engine.on('TOURNAMENT:updated', function (data, done) {
    done();
});

engine.start();

TOURNAMENT:completed - doesn't rising when the last game was played
not shure mb I use it incorrectly

Thanks for the report.

I've fixed the issue, and updated the demo.

Version 3.0.3 should work fine.
Thanks @leoni4


Doesn't save the generalConfig.yml file

For example, if the save-period integer is 0, it will not reset it to 10 after reloading it and saving it.

Fixes, commit


HorizontalBar functionality for issue #73

based on tomsouthall's implementation

Sounds good!

I think this is not compatible with v2 :(

@thiagof @Kyle-Falconer it looks like this is meant for v1.

I forked it off V2 and worked off that branch as instructed.
On Thu, Mar 17, 2016 at 5:58 AM Evert Timberg<EMAIL_ADDRESS>wrote:

@thiagof https://github.com/thiagof @Kyle-Falconer
https://github.com/Kyle-Falconer it looks like this is meant for v1.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/nnnick/Chart.js/pull/2117#issuecomment-197867783

This has been implemented in version 2.1.0 with PR #2448


fix: update various package README files

:tada: This PR is included in version 1.0.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to mute left or right channel in stereo audio file

I am trying to use Audio context from wavesurfer object to play one channel at a time. But it doesnt seem to be working By using wavesurfer.backend.setFilter() and passing channelSplitter object am able to play left channel but the other one never get played.
Wavesurfer.js version(s):2.0.0-beta02
Browser version(s):Chrome latest 70.0.3538.67
Use behaviour needed to reproduce the issue:
Load a single audio mp3 file which has 2 channels .

accidentally closed

2.0.0-beta02

always try latest version.

Here is what it should look like .

The only issue I have so far is the timeline characters appear to be cutoff. Not a show stopper but something i'd like to get resolved.

thanks for feedback.

I am able to mute channel for the stereo audio file with backend 'WebAudio'. But If I wanted to use backend 'MediaElement', then how can I mute left or right channel as with 'MediaElement' I can not use the setFilter method.
Can someone please help me?

I want to same thing on backend 'MediaElement'  and also need to Amplify audio in selected region.
Can anyone help me?

Did anyone find a resolution to make this work with Html 5 Audio and the latest wavesurfer version?


add missing Content-Transfer-Encoding

for you always use quoted-printable Transfer Encoding，the header should always be present.

:+1: Would be great if this could get merged, this needs to be a default.

Sorry for the delay here. This looks good to me. Thanks for sending it over!


Upgrade alinof-timer

Fix homepage

Thank you for the contribution. It was merged directly as 2d7d5e4d1b9b08a2aeecd42c683e1fd3023ba76a to keep commit history cleaner. Your contribution is still credited to you.


PSX Checksum Errors

Hello,
No matter what game I download from PSX, the checksum does not match the meta data file that was just downloaded 1-2 minutes prior.
Mister forum indicates others are seeing this, and it may not be just PSX issue. https://misterfpga.org/viewtopic.php?t=5612&sid=dcdbd3d46104fae7370ca2bcbb015235&start=60
For what its worth, Amiga CD32 did work just now, after failing at PSX.

Sourcing IA_USER/IA_PASS was broken when script was used directly from MiSTer menu. It has been now addressed, can you retry?

I just tried with the latest version to download psx games directly from the mister menu and I am still getting check sum issues


Changing certain Text

Is there any way we can change the text "Mulligan" and "Mana" to something else?
It would be nice if we could, unless there is a way and I haven't found it yet.

The next big step for the client will be to make the client much more moddable, to have custom HTML for each mod for example. Then this should definitely be possible.
Until then, you should be able to modify this line: https://github.com/Cardshifter/Cardshifter/blob/master/extra-resources/mods/Cyborg-Chronicles/Game.groovy#L34 . Changing that line to MANA = createResource("Java") should show the resource name as "Java" instead in some places at least (and still using the identifier MANA in the mod setup script)

Ahhh, so i was doing it correctly. Thanks. It seems I changed wayyyyy to much lines :)

Can you post your Game.groovy file? Then I hope I can be of assistance.

http://pastebin.com/0Ue69cy4
here it is. though, all i did was change what you said.

Ah, okay, there's a little bit more that needs to be changed apparently.
First of change MANA = createResource("MORALE") to MORALE = createResource("MORALE")
Then change all mana and MANA occourences to morale or MORALE respectively.
Such as the occourances at line 131 and 169.
Then let me know if there are more problems

No such property: MANA for class
is what i got

Does it show a more detailed error message, with a stacktrace?
(By the way, out of pure interest, how did you hear about this project?)

i think so, i dont really remember.
and i didn't really hear about this project, i was just searching for web based trading card game engines or source and i stumbled upon this project right after i found sandscape.


HTML turns into HTFumo

It's funny and caught me off guard lol, but since I work in web dev it might get annoying/confusing in the long run
Page in question: https://stackoverflow.com/questions/7050586/how-to-use-inline-javascript-in-html

I think this is a good point. I thought it would be a funny side effect, but I have also seen words containing "ML" or "AI" be replaced often enough that it can be annoying. Some examples include HTML, XML, and YAML.
One way to fix this would be to additionally match trailing spaces before or after the terms "AI" and "ML". Another way would be to let users add or remove terms. I am leaning towards the second approach because it would also address https://github.com/astral4/ai2fumo/pull/1.

We could do this with regex word boundaries like \bML\b, since the key of the replacement dictionary is passed into a regex replace.


need help using the software

hello, i will like ton use the ss7maper to test my security by sms interception , can you please provide a documentation or anything as a guide on using the tool to intercept sms

This is the wrong place for such questions. This issue tracker is for ss7MAPer, not about SS7 in general.


Server/Shadow: Fix invalid ALIGN in shadow_client_send_bitmap_update

Some of the code in shadow looks like ‘ X + X % 4'. I think the purpose is to align variables up to multiples of 4, but it is not correct.
On the other hand, the code in shadow_client_send_bitmap_update which adjusts nXSrc/nYSrc/nWidth/nHeight. I think the purpose is to extent the left/top/right/bottom of the rect to multiples of 4. It does right thing when it adjust nXSrc and nYSrc, but it should not change nXSrc and nYSrc when adjusting nWidth and nHeight

LGTM

LGTM, +1


regression error in reaction.sql

Discussed in https://github.com/rdkit/rdkit/discussions/4484

Originally posted by yoer77 September  6, 2021
diff -U3 /home/postgres/contrib/rdkit/Code/PgSQL/rdkit/expected/reaction.out /home/postgres/contrib/rdkit/Code/PgSQL/rdkit/results/reaction.out
--- /home/postgres/contrib/rdkit/Code/PgSQL/rdkit/expected/reaction.out    2021-07-09 21:48:50.000000000 +0800
+++ /home/postgres/contrib/rdkit/Code/PgSQL/rdkit/results/reaction.out 2021-09-06 15:54:04.354110745 +0800
@@ -20,15 +20,15 @@
 (1 row)

 SELECT reaction_from_smarts('[c1:1][c:2][c:3][c:4]c[c1:5]>CC(=O)O>[c1:1][c:2][c:3][c:4]n[c1:5]');
-                              reaction_from_smarts
----------------------------------------------------------------------------------
- c([cH:4][cH:3][cH:2][cH2:1])[cH2:5]>CC(=O)O>n([cH:4][cH:3][cH:2][cH2:1])[cH2:5]
+                       reaction_from_smarts
+-------------------------------------------------------------------
+ c([c:4][c:3][c:2][c:1])[c:5]>CC(O)=O>n([c:4][c:3][c:2][c:1])[c:5]
 (1 row)

 SELECT reaction_from_smarts('C(F)(F)F.[c1:1][c:2][c:3][c:4]c[c1:5]>CC(=O)O>[c1:1][c:2][c:3][c:4]n[c1:5]');
-                                  reaction_from_smarts
-----------------------------------------------------------------------------------------
- c([cH:4][cH:3][cH:2][cH2:1])[cH2:5]>CC(=O)O.FC(F)F>n([cH:4][cH:3][cH:2][cH2:1])[cH2:5]
+                           reaction_from_smarts
+--------------------------------------------------------------------------
+ c([c:4][c:3][c:2][c:1])[c:5]>CC(O)=O.FC(F)F>n([c:4][c:3][c:2][c:1])[c:5]
 (1 row)

 SELECT reaction_from_smarts('c1ccc[n,c]c1>>c1nccnc1');

other test case is ok:
============== running regression test queries        ==============
test rdkit-91                     ... ok         2238 ms
test props                        ... ok           46 ms
test btree                        ... ok          510 ms
test molgist                      ... ok         1100 ms
test bfpgist-91                   ... ok           64 ms
test sfpgist                      ... ok           50 ms
test slfpgist                     ... ok           68 ms
test fps                          ... ok           64 ms
test reaction                     ... FAILED     2710 ms
test fmcs                         ... ok          120 ms

=======================
 1 of 10 tests failed.
=======================

I don't know if it's a bug, so i put it here first.
Version: Release_2021_03_4

confirmed.
This is already fixed on master, but I'll get the fix into the next patch release.

Should now be fixed, I'll wait for the CI builds to close the issue though.


Add webhook for GitKraken Boards

Hey @niconoe, one more thing I forgot to ask about: could you add a webhook to this repo for me so I can sync issues with GitKraken Boards? It should just take a couple minutes to set up.
Now that I have a larger number of small projects, I wanted to be able to see all my issues in one place. GitHub Projects can do this, but requires transferring repos to a single owner or organization. It looks like GitKraken Boards can do this by just adding an OAuth application and webhooks.
Steps

Make an account and give it access to the pyinaturalist repo.

Go to 'Create a synced board' in the lower left and add pyinaturalist:

Go to ⚙-> Users in the upper right and add me to the board:

Back on the GitHub repo, you should then see at least one webhook for GitKraken under Settings -> Webhooks. You can remove those if you ever need to revoke access for some reason in he future.

Also let me know if you have any alternative suggestions for a free Kanban-style board that can sync with GitHub issues and PRs. Thanks!

No problem, @JWCook. I'm currently experiencing difficulties creating a GitKragen account (I try to sign-in using GitHub - I guess that's the easiest - but get an infinitely loading page). I've tries a few things (logging out/in of GitHub, restarting my browser, ...) without success so far, I'll try again in a couple of hours!

I'm actually seeing the same thing now, so it's not just you. It was working perfectly a few days ago! Maybe that's a sign I should look around for other options. Thanks for trying, anyway!

Looks like there was just a new release yesterday, and some others are having the same problem. Just bad timing, I guess!

It appears to have been fixed. Could you try again when you get the chance?

@niconoe Would you mind giving this another try when you get the chance? Thanks!

Finally done! And sorry for missing the notification 16! days ago.

Sweet, thank you! This definitely makes it easier to manage issues across multiple projects.
Looks like it's 90% working now, but a couple automation features require additional permissions. I think you can do that by going here: https://github.com/apps/gitkraken-boards/installations/new
And selecting pyinaturalist from the 'Only Select Repositories' drop-down:

@niconoe
Sweet, thank you! This definitely makes it easier to manage issues across multiple projects.
Looks like it's 90% working now, but a couple automation features require additional permissions. I think you can do that by going here: https://github.com/apps/gitkraken-boards/installations/new
And selecting pyinaturalist from the 'Only Select Repositories' drop-down:

Hey @JWCook, that should be in order now!

Perfect, thanks!


Stop downloading after 12 pictures

Instaloader  - Python 3.8 - Windows 10
Script stop downloading after 12 pictures and show this error
JSON Query to graphql/query: HTTP error code 401. [retrying; skip with ^C]
JSON Query to graphql/query: HTTP error code 401. [retrying; skip with ^C]
Errors or warnings occurred:
JSON Query to graphql/query: HTTP error code 401.

This usually happens when you aren't logged in with Instaloader.
Check this out for getting session file https://instaloader.github.io/troubleshooting.html#login-error


ARROW-3035 [Rust] Examples in README.md do not run

Failing CI is unrelated and not worth re-running...

Merged, thank you!


harvester crd shortname missing plurals

Description:
currently, harvester CRD short-name is missing plurals, for example, the user should be able to get virtualmachinetemplates by typing either vmtemplates or vmtemplate, however vmtemplates short-name is not added for now.

link to PR https://github.com/rancher/harvester/pull/114

validated


Additional string in scalar dataset

Description
Closes #1576.

Readiness checklist

[ ] I added unit tests for new functionality or bugfixes.
[ ] I added integration tests for new functionality or bugfixes.
[ ] I added compatibility tests for new functionality or bugfixes.
[ ] I made spot refactoring.
[ ] I updated the documentation.
[ ] I ran task all, and it passed.
[ ] I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
[ ] I checked comments rendering with task godocs.
[ ] I ensured that the title is good enough for the changelog.
[ ] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[ ] I marked all done items in this checklist.

@chilagrow do we need that one?

Quite certainly not. Let me close


Feature suggestion: Exclude tracks by genre

Some type of music will always be instrumental, like most Jazz and classical music. It would be great to exclude tracks by genre (user definable) from automated and batch searches.

I'm not sure this would be worth the additional complexity.
Tracks without lyrics will eventually become excluded automatically by virtue of lyrics not being found in the regular autosearches. If you really want to skip those tracks you can always manually mark them as instrumental. This would be even simpler to do in bulk with #113

This feature would save some calls, though... the online databases would probably appreciate it.

I think #202 would be a better implementation of this, since it would provide the flexibility to do exactly what you suggest here but without being tied specifically to genre (so users can check the genre tag if they want, but could also check their own custom tag, or the file path, or whatever).


1.3.x copy() performance cherry-picks

@bourey please take a look and see if this would help with 1.3.x performance.


fix(button): remove View to fix style prop

Remove wrapper View to make the style prop on Button behave as expected.
Rename ButtonProps to ButtonSpecificProps.
Update ButtonProps include ViewProps.

Closes #170

Good stuff. Nice to see this cleaned out. Buttons seem to behave the same as before which is nice. Is this a breaking change? Nonetheless, I think we should add a changeset explaining that we now export the full button props.

I believe it's not a breaking change, but I worked around this bug by wrapping a Button in a View, so there's probably some project code which can be removed after this fix.
I agree - I'll add a changeset 💪


[ZD3408278][AF-1046] 'zat' errors out on 'clean' with "uninitialized" FileUtils

✌
Description
When running ZAT commands under certain Ruby versions, the FileUtils class wasn't being auto-loaded, resulting in a NameError.
c:/Ruby23/lib/ruby/gems/2.3.0/gems/zendesk_apps_tools-2.8.3/lib/zendesk_apps_tools/command.rb:128:in `clean': uninitialized constant ZendeskAppsTools::Command::FileUtils (NameError)
Did you mean?  FileTest
        from c:/Ruby23/lib/ruby/gems/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in `run'
...

References

Ticket: https://support.zendesk.com/agent/tickets/3408278

Risk

N/A

/cc @bryan-flynn-zd


🚀 - Pivot table control

Which @taiga-ui/* package(s) are relevant/releated to the feature request?
No response
Description
Hi, pivot table with OLAP datasource is a must have control. Is any plans to implement it?

Here, as well, we would need a well-defined feature request, otherwise it's too abstract to consider. Please add specification of desired functionality.

The pivot grid control should provide the same OLAP explorer features, as Excel, including filtering and sorting.

DevExtreme is a commercial solution with different scope. It's not the goal of Taiga UI to provide such high level components. Taiga UI has all the necessary lower level components and APIs to make those however. If somebody is willing to make it and release a separate package, we would definitely promote it on our portal, but it's not something we will be implementing here. A bugbounty or a personal contract with somebody interested might be an option if you want this functionality in Taiga UI/Angular but don't have the resources to develop such solution yourself.


ImmutableBitmap's batchiterator.advanceIfNeeded skips over target in certain conditions

Describe the bug
advanceIfNeeded does not handle the case of runs with zero length (unlike contains and other methods of ImmutableRoaringbitmap).
This means that target that is contained the bitmap cannot be located through the combination of advanceIfNeeded(target) followed by nextBatch.
To Reproduce
If it is a bug you encountered while working with the library, you should produce a code sample that allows us to reproduce the problem. Your code should be complete and immediately executable:
For example, this is a good example:
    @ParameterizedTest
    @ValueSource(ints = {10, 11, 12, 13, 14, 15, 18, 20, 21, 23, 24})
    public void testBatchIteratorWithAdvancedIfNeededWithZeroLengthRun(int number) {
       MutableRoaringBitmap bitmap = MutableRoaringBitmap.bitmapOf(10, 11, 12, 13, 14, 15, 18, 20, 21, 22, 23, 24);
       bitmap.runOptimize();
        BatchIterator it = bitmap.getBatchIterator();
        it.advanceIfNeeded(number);
        assertTrue(it.hasNext());
        int[] batch = new int[10];
        int n = it.nextBatch(batch);
        int i = Arrays.binarySearch(batch, 0, n, number);
        assertTrue(i >= 0, "key " + number + " not found");
        assertEquals(batch[i], number);
    }

RoaringBitmap version:
1.0.0 as well as on master.
Java version:
Java 21

See the PR for the corresponding unit tests. https://github.com/RoaringBitmap/RoaringBitmap/pull/689

Also, RunBatchIterator.advanceIfNeeded could use binary search instead of linear search to speed up the search over runs.

Seems like the issue is also present in the Roaringbitmap's batchiterator also.
https://github.com/RoaringBitmap/RoaringBitmap/pull/691
Should I reopen this issue or create a new one?


Automated Package Upgrade

:tada: This PR is included in version 5.0.517 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Avoid user does not exist error when detecting schedule actions when the commit author is an external user

When repo is a mirror, and commit author is an external user, then GetUserByEmail will return error.
reproduce/test:

mirror Gitea to your instance
disable action and enable it again, this will trigger DetectAndHandleSchedules

ps: also follow #24706, it only fixed normal runs, not scheduled runs.

Thanks for the suggestion from @wolfogre
We should use repo owner as the user instead of commit author.

Actually, I still think the repo owner is better than the gitea-action user. It's not a technical issue, but a design one.
"gitea-action" means the operation is do by Gitea Actons, like a commit has been pushed and the pusher is "gitea-action", and it shouldn't trigger another Actions run. So it's weird to say that the actor is "gitea-action" since it should never trigger Actions runs.
Whichever, both of them are better than the commit author.
I'm OK with this, since the actor of a scheduled run is not shown.

@wolfogre
What about the permission when running the job? Do they have difference?

@wolfogre What about the permission when running the job? Do they have difference?

No, the permission when running the job is not decided by the trigger user.


PI-3483: Make changes to coord_comparison private

This addresses comments on #3546. At a minimum, this causes coord_comparison to have the same behaviour as it did previously. The internals of the function still refer to coords rather than, say, ancillary variables. Ideally there would be a more generic name to use as keys for the generic function (preferably one less cumbersome than 'dimensional metadata').

#3562 aims to replace, following the above discussions.
Can we close this ?

@pp-mo Sounds fair to me.


Regular expression catastrophic backtracking in bottle.Router.rule_syntax

Hi there!
I'm working on a static analysis tool called Dlint. A rule I've recently written looks for catastrophic backtracking in the Python re module. Looks like this has come up before in #1155.
After running this rule against your code base I found one issue:
$ python -m flake8 --select=DUO138 bottle.py
bottle.py:302:19: DUO138 catastrophic "re" usage - denial-of-service possible

If we look at the rule_syntax expression we can indeed confirm it has catastrophic cases:
    rule_syntax = re.compile('(\\\\*)'
        '(?:(?::([a-zA-Z_][a-zA-Z_0-9]*)?()(?:#(.*?)#)?)'
          '|(?:<([a-zA-Z_][a-zA-Z_0-9]*)?(?::([a-zA-Z_]*)'
            '(?::((?:\\\\.|[^\\\\>]+)+)?)?)?>))')

Under normal cases the expression runs quickly:
$ python -c "import bottle; list(bottle.Router.rule_syntax.finditer('<abc:def:' + '.' * 64 + '>'))"

But if we craft a special subject string we can cause it to catastrophically backtrack:
$ python -c "import bottle; list(bottle.Router.rule_syntax.finditer('<abc:def:' + '.' * 64 + '<'))"

The culprit here is this portion of the expression:
((?:\\\\.|[^\\\\>]+)+)?

Due to mutually inclusive alternation, a long string of dots (.) will backtrack this expression. Changing the expression to the following should fix the issue:
((?:\\\\.|[^\\\\.\\\\>]+)+)?

If this breaks intended functionality there may be other ways to fix the expression.
Let me know if you have any questions, and I hope you'll check out Dlint! Note that the DUO138 catastrophic backtracking check hasn't been released to PyPI yet as I'm still ironing out some kinks. Installing from the Github repository itself will provide the new rule, though.

The pattern should match "everything up until the next non-excaped >". It is not about literal dots and the proposed fix won't work, unfortunately.
I'm not sure if this is really an issue, because route definitions are usually short, controlled by the developer, and evaluated only once. #1155 is way more serious and I have no idea how to fix that yet.  Any help would be welcomed.
For this one, would removing the inner + help? It would probably slow down the good case, but prevent the catastrophic runtime in the bad one?
((?:\\\\.|[^\\\\>])+)?

Forgot to mention: Tools being able to detect these issues are a HUGE win and I hope python adds ways around these errors in the future. Most mitigations against catastrophic backtracking are not possible in python because the regular expression engine lacks support for certain features. No idea how to fix #1155 because of that :/

For this one, would removing the inner + help? It would probably slow down the good case, but prevent the catastrophic runtime in the bad one?

Unfortunately removing the inner + would not fix this issue:
>>> re.match(r'((?:\.|[^\>])+)?>', '.' * 64 + '<')
... Spins ...

The issue is that the alternation or branch (|) has overlapping characters: \. and [^\>]. Since [^\>] is anything BUT > it can be . which matches the other side of the branch and can result in exponential backtracking.

The pattern should match "everything up until the next non-escaped >". It is not about literal dots and the proposed fix won't work, unfortunately.

To match "everything up until the next non-escaped >" could we simply do ([^\>]+)?>' or even [^\>]+> which will match everything except > until the next >. This is a common pattern.
I'm confused about significance of the literal dot. If they aren't important we can just let [^\>] match literal dots too.
Thoughts?

I think you misinterpret what the regular expression actually does. Count the backslashes. The python String (\\\\.|[^\\\\>]) resolves to the regular expression (\\.|[^\\>]). The backslashes are escaped and resolve to literal backslashes. The dot is not escaped, it matches any character but the newline. In words: "Backslash followed by any single character, OR any single character other than backslash or >". There is no literal dot in the expression and no overlap between the left and right side of the |.
Removing the inner repetition should fix the backtracking issue.
>>> re.compile('(\\\\*)(?:(?::([a-zA-Z_][a-zA-Z_0-9]*)?()(?:#(.*?)#)?)|(?:<([a-zA-Z_][a-zA-Z_0-9]*)?(?::([a-zA-Z_]*)(?::((?:\\\\.|[^\\\\>])+)?)?)?>))').match('<abc:def:' + 'x'*64 + '>').groups()
('', None, None, None, 'abc', 'def', 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
>>> re.compile('(\\\\*)(?:(?::([a-zA-Z_][a-zA-Z_0-9]*)?()(?:#(.*?)#)?)|(?:<([a-zA-Z_][a-zA-Z_0-9]*)?(?::([a-zA-Z_]*)(?::((?:\\\\.|[^\\\\>])+)?)?)?>))').match('<abc:def:' + 'x'*64 + 'NOT-GT').groups()

That seems to work as expected, and no longer hang for large invalid input.

Ah, I see. Normally I use raw strings (e.g. r'...') for regular expressions to avoid all the backslash escaping. Yes, I believe (\\\\.|[^\\\\>]) will work then - the literal \ at the beginning of one branch and disallowed from the other branch should prevent catastrophic backtracking. And removing the additional + avoids nested quantifiers :+1:

I finally understood this issue a bit better today and was able to (hopefully) fix three backtracking issues in bottle with your help. Thanks a lot for that!

Glad we got everything figured out! I know, catastrophic backtracking regular expressions caused some catastrophic backtracking in my brain for a long time before I fully understood them :)

Hi @defnull , I've submitted this PR to back-port the fix here to the 0.12 branch: https://github.com/bottlepy/bottle/pull/1402


Segfault in plugin based converters

🐛 Bug

I am seeing segfaults in the three sets of tests that deal with plugins:
test_pooling:
[ RUN      ] Converters.ATenAdaptiveAvgPool2DConvertsCorrectlyWithDynamicInput
...
Thread 11 "test_pooling" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff1bfff700 (LWP 7989)]
0x00007fff96c8c763 in void at::parallel_for<at::native::(anonymous namespace)::adaptive_avg_pool2d_single_out_frame<float>(float*, float*, long, long, long, long, long, long, long, long)::{lambda(long, long)#1}>(long, long, long, at::native::(anonymous namespace)::adaptive_avg_pool2d_single_out_frame<float>(float*, float*, long, long, long, long, long, long, long, long)::{lambda(long, long)#1} const&) [clone ._omp_fn.1] () from /home/narens/Developer/opensource/TRTorch/bazel-TRTorch/external/libtorch/lib/libtorch_cpu.so
(gdb) bt
#0  0x00007fff96c8c763 in void at::parallel_for<at::native::(anonymous namespace)::adaptive_avg_pool2d_single_out_frame<float>(float*, float*, long, long, long, long, long, long, long, long)::{lambda(long, long)#1}>(long, long, long, at::native::(anonymous namespace)::adaptive_avg_pool2d_single_out_frame<float>(float*, float*, long, long, long, long, long, long, long, long)::{lambda(long, long)#1} const&) [clone ._omp_fn.1] () from /home/narens/Developer/opensource/TRTorch/bazel-TRTorch/external/libtorch/lib/libtorch_cpu.so
#1  0x00007fff9243243e in ?? () from /home/narens/Developer/opensource/TRTorch/bazel-TRTorch/external/libtorch/lib/libgomp-75eea7e8.so.1
#2  0x00007fff958a76db in start_thread (arg=0x7fff1bfff700) at pthread_create.c:463
#3  0x00007fff953b8a3f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

test_interpolate:
[ RUN      ] Converters.ATenUpsampleLinear1dConvertsCorrectlyWithoutAlignCorners

Thread 1 "test_interpolat" received signal SIGSEGV, Segmentation fault.
0x00007fff977a9425 in void c10::function_ref<void (char**, long const*, long)>::callback_fn<at::native::(anonymous namespace)::cpu_kernel_vec<at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#4}::operator()() const::{lambda()#1}, at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#2}::operator()() const::{lambda()#2}>(at::TensorIterator&, at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#4}::operator()() const::{lambda()#1}&&, at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#2}::operator()() const::{lambda()#2}&&)::{lambda(char**, long const*, long)#1}>(long, char**, long const*, long) ()
   from /home/narens/Developer/opensource/TRTorch/bazel-TRTorch/external/libtorch/lib/libtorch_cpu.so

test_serialization:
[ RUN      ] CompiledModuleForwardIsCloseSuite/ModuleTests.SerializedModuleIsStillCorrect/1

Thread 1 "test_serializat" received signal SIGSEGV, Segmentation fault.
0x00007fff977a9425 in void c10::function_ref<void (char**, long const*, long)>::callback_fn<at::native::(anonymous namespace)::cpu_kernel_vec<at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#4}::operator()() const::{lambda()#1}, at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#2}::operator()() const::{lambda()#2}>(at::TensorIterator&, at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#4}::operator()() const::{lambda()#1}&&, at::native::(anonymous namespace)::fill_kernel(at::TensorIterator&, c10::Scalar)::{lambda()#2}::operator()() const::{lambda()#2}::operator()() const::{lambda()#2}&&)::{lambda(char**, long const*, long)#1}>(long, char**, long const*, long) ()
   from /home/narens/Developer/opensource/TRTorch/bazel-TRTorch/external/libtorch/lib/libtorch_cpu.so

To Reproduce
Steps to reproduce the behavior:

Build libtrtorch on master
Run test suite

Expected behavior

These tests should not be segfaulting here
Environment

Build information about the TRTorch compiler can be found by turning on debug messages

PyTorch Version (e.g., 1.0): 1.5.1
CPU Architecture: x86_64
OS (e.g., Linux): Ubuntu 18.04
How you installed PyTorch (conda, pip, libtorch, source): Bazel fetch of libtorch
Build command you used (if compiling from source): bazelisk test //tests -c opt --test_output=errors --jobs=5
Are you using local sources or building from archives: archives
Python version: 3.6
CUDA version: 10.2
GPU models and configuration: TITAN V
Any other relevant information:

Additional context

Seems like this is an issue specifically with 1.5.1 I cannot replicate on commit cc2f2fd68a9a7eee19822b8aa23e0437b1bd29a0

Narrowed down the issue to TensorRT 7.1

Issue is still relevant, currently have a WAR in the compiler to allow people to continue to use adaptive_avg_pool in dynamic mode but there is a pref regression as we were forced to move onto CPU until the issue of instantiating Tensors during TensorRT runtime can be solved.


Tabular: Moved .fillna calls in fit_summary to a copy of leaderboard

Issue #, if available:
Description of changes:
Moved .fillna calls in fit_summary to a copy of leaderboard
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-331-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-331/1/index.html


use handleid in renderer instead of a weak handle

The renderer only need a weak handle, so it can work with the HandleId
Tiny perf improvement
This was already done for the sprites

next question would be to replace the type uuid by a smaller unique id: uuid is backed by a u128, but a u64 would be largely enough to have a unique id for asset types, and make the HandleId enum the same size for both variants

next question would be to replace the type uuid by a smaller unique id: uuid is backed by a u128, but a u64 would be largely enough to have a unique id for asset types, and make the HandleId enum the same size for both variants

Yes, I think this is reasonable. We can only have u64::MAX entities anyways.

Moved the uuid to a u64 internally, but still kept the same api where you need to provide a Uuid on the derive because it's prettier... and I didn't want to change the derive macro without other opinions.
This wins around 3 fps on many_sprites and many_cubes...

This wins around 3 fps on many_sprites and many_cubes...

Wow, that's way more than I expected.

Moved the uuid to a u64 internally, but still kept the same api where you need to provide a Uuid on the derive because it's prettier... and I didn't want to change the derive macro without other opinions.
This wins around 3 fps on many_sprites and many_cubes...

3fps out of how many? :) Cool!

many_cubes
many_sprites

before
80~84
67~68

after
84~86
68~70

In some places in the code, functions and such are still called 'uuid' which feels incorrect as uuid is something specific and this is not a uuid anymore.
Also, I haven't thought about the consequences and I'm imagining that @cart has. :)

Yup, before taking the step to yank all references and use of uuid, I was waiting for someone who may have ideas about unexpected consequences...
and then, for the derive, having a uuid does look nicer than having a random u64...

I think the asset type should keep using an uuid. A u64 is not enough to be almost certain that the type id's chosen by different plugins are globally unique across all plugins. If this is not the case, trying to use plugins with conflicting type id's will cause surprising and incorrect results that may be hard to debug.

trying to use plugins with conflicting type id's will cause surprising and incorrect results that may be hard to debug.

Nop, it panics. there is a check when adding a new asset type that panics if its ID is already registered

That will still prevent the plugins from being used at the same time.

Neither uuid or u64 are a perfect solution to prevent collisions...
Until we have an plugin catalogue capable of warning of collisions, I'm not sure that will be a solved issue

Some assorted thoughts:

I like the idea of trying to reduce the runtime cost of handles.
I would like to retain type safety on the renderer side. Weak handles should be "cheap enough" to use in this context. If they aren't (clearly there is currently a cost here), thats something worth resolving.
Uuid should always only mean "actual uuid". TypeUuid should continue being a real Uuid.  It is the standard way to avoid collisions in a distributed context.
Its worth considering "exchanging" a UUID for a "runtime atomically incrementing id" for assets, which could be much smaller.
In the very near future I'll be picking up the "asset preprocessing" area. Some or all of this code might change as a result.
bevy_reflect owning something like UniqueAssetId feels wrong.
I'd like to explore treating assets as entities. In that world, we'd be using entity ids (potentially inside a typed handle) in place of HandleIds.

In that world, we'd be using entity ids (potentially inside a typed handle)

For context / cross-linking, this is the kinded entities idea from #1634.


connect-swift can't compile for watchOS

Hey team 👋
We're working on adopting connect-swift and are running into some issues compiling connect-swift for our watchOS app.
For context, we are attempting to perform unary requests from a watchOS app using the URLSessionHTTPClient and grpc-web protocol. However, connect-swift imports CFNetwork (only 1 explicit import here AFAIK) which is unavailable on watchOS, so we can't actually compile for our watchOS target.
In addition, Technote TN3135 describes the 3 specific circumstances when low-level networking is allowed on watchOS. watchOS blocks low-level networking outside of these specific circumstances, impacting aspects of URLSession including URLSessionStreamTask and URLSessionWebSocketTask.
With this limitation on low-level networking, it's likely stream requests will fail even if we can compile and run on watchOS. This is OK for our immediate use-case as we only need to execute unary requests, but a consideration for the future.
Is watchOS support, or at a minimum, the ability to compile and execute unary requests, a reasonable prerequisite for a stable v1.0 release?

Quick update with some additional checks required to compile for watchOS:

@available(watchOS 6, *) for accessing AsyncStream APIs
@available(watchOS 9, *) for runtime support for parameterized protocol types

👋🏽 thank you for flagging this. I'm out of town through the first week of December, but can investigate when I'm back if @eseay doesn't get to it before then. Alternatively, feel free to submit a PR in the meantime 🙂

Hey @scottybobandy - Thank you for contributing https://github.com/connectrpc/connect-swift/pull/227! I also spent some time investigating this, and I opened a PR to introduce CI validation for watchOS, tvOS, and iOS (rather than only for macOS) as a follow-up: https://github.com/connectrpc/connect-swift/pull/231

In addition, Technote TN3135 describes the 3 specific circumstances when low-level networking is allowed on watchOS. watchOS blocks low-level networking outside of these specific circumstances, impacting aspects of URLSession including URLSessionStreamTask and URLSessionWebSocketTask.
With this limitation on low-level networking, it's likely stream requests will fail even if we can compile and run on watchOS. This is OK for our immediate use-case as we only need to execute unary requests, but a consideration for the future.

I read through the technote you linked, and I think the circumstances in which streaming is allowed by watchOS are tied to application-level features (such as doing networking while streaming audio). That said, there isn't much we can/should do from a networking library perspective, since after your PR Connect will work if it's being used within the boundaries set by watchOS. Relatedly, the tests being run in the PR pass on watchOS because of this detail in the technote:

When writing watchOS networking code, test it on a real device; the simulator always allows low-level networking.

I think between #227 and #231 we should be covered :)


Questions on how to organize training data and generate bounding box ground truth

Sorry for asking this question,
My training set is CT images consisting of kidney and kidney tumor, whose ground truth is labeled in voxel level. Now I want to do 3D object detection of tumor. I'm wondering how should I organize my training data to feed into the network. And should I generate bounding box ground truth for tumors manually or your library supports to generate bounding box ground truth automatically?
Thanks you in advance!
Best wishes

in the experiments has demo you can learn

I'm trying to do the same thing... will report back if I figure out how..

I do not see a demo in experiments showing expected training data hierarchy input, specifically for bboxes and/or voxel-level ground truth (if possible). Anyone have luck figuring this out?

you can run, experiments/toy_exp/generate_toys.py  . It will create the toy data.

Found it, thank you!

I am looking at the 3D LIDC example.  Is it possible to specify the format of the data which is returned by preprocessing.py? I would like to avoid the preprocessing of the big LIDC dataset just to see how to prepare my data.
I saw this:
"Images are saved as numpy arrays and the meta-information for the corresponding patient is stored
as a line in the dataframe saved as info_df.pickle."
Just a small example and description of the data preparation for the 3D data would be really helpful. I looked and generated the toy example dataset, but I am interested in 3D data.


[auto release] fix for changelog

fix for https://github.com/Azure/azure-sdk-for-python/pull/35919

/check-enforcer override


feat: Assertion verification

Adds option to provide assertion verification keys and support for signing keys on assertion input
(supports rs256 and hs256 keys)
Includes bats tests for both key types

Specifying the keys directly as arguments puts the key at more risk of exposure. Arguments will be recorded to disk in the command history, could be exposed on multi-tenant systems, logged, etc. This is particularly concerning since you appear to be supporting not just public keys, but private keys as well.
@elizabethhealy Would it be reasonable to accept a file path or use environment variables instead of specifying the keys as arguments?

This suggestion from @jentfoo aligns with an open issue we have to generally improve CLI security: https://github.com/opentdf/otdfctl/issues/417

@jentfoo @jakedoublev
using a file name as input instead makes sense, so in that case the format of the assertions provided would be [{"id":"assertion1","type":"handling","scope":"tdo","appliesToState":"encrypted","statement":{"format":"json+stanag5636","schema":"urn:nato:stanag:5636:A:1:elements:json","value":"{\"ocl\":\"2024-10-21T20:47:36Z\"}"},"signingKey":{"alg":"RS256","key":"my_private_rs256key.pem"}}]

@jentfoo @jakedoublev using a file name as input instead makes sense, so in that case the format of the assertions provided would be [{"id":"assertion1","type":"handling","scope":"tdo","appliesToState":"encrypted","statement":{"format":"json+stanag5636","schema":"urn:nato:stanag:5636:A:1:elements:json","value":"{\"ocl\":\"2024-10-21T20:47:36Z\"}"},"signingKey":{"alg":"RS256","key":"my_private_rs256key.pem"}}]

@elizabethhealy Could the entire assertion JSON be stored and read into the command from a file instead of just the keys referenced by the assertions? I'm thinking that would be aligned with what the CLI does for client credentials so --with-client-creds-file creds.json expects the entire {"clientId":"id","clientSecret":"client_secret"} stored in ./creds.json instead of --with-client-creds-file '{"clientId":"id","clientSecret":"secret_file.txt"}' where just the secret is present in ./secret_file.txt.

@jakedoublev so --with-assertions, --with-assertions-from-file, --with-assertion-verification-keys, --with-assertion-verificiation-keys-from-file and its up to the user to decide whichever is best for them, it will still supports passing in keys directly but also give a safer option

@elizabethhealy and I discussed and we will update --with-assertions to parse either from JSON (backwards-compatible) or try to read from a file (more secure) before reporting an error if neither is successful. This new decrypt flag --with-assertion-verification-keys will only read the entire JSON (including in-lined PEMs) from a file and not support JSON in the flag value/argument.


Failed to add extension due to workbox-build version

When trying to add this extension to my project (quasar ext add ssg), I encounter the following error:
 App • Installing "ssg" Quasar App Extension

 App • Installing quasar-app-extension-ssg...
 App • [sync] Running "npm install --save-dev quasar-app-extension-ssg" in /home/ryey/coding/solid-fixer

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/workbox-build
npm ERR!   peerOptional workbox-build@">= 6" from<EMAIL_ADDRESS>npm ERR!   node_modules/@quasar/app-vite
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/quasar-app-extension-ssg
npm ERR!       dev quasar-app-extension-ssg@"*" from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/workbox-webpack-plugin
npm ERR!     peerOptional workbox-webpack-plugin@">= 6" from<EMAIL_ADDRESS>npm ERR!     node_modules/@quasar/app-webpack
npm ERR!       peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!       node_modules/quasar-app-extension-ssg
npm ERR!         dev quasar-app-extension-ssg@"*" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/quasar-app-extension-ssg
npm ERR!   dev quasar-app-extension-ssg@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /home/ryey/.npm/_logs/2023-11-26T18_26_22_257Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /home/ryey/.npm/_logs/2023-11-26T18_26_22_257Z-debug-0.log

 App • ⚠  Command "npm" failed with exit code: 1

 App • ⚠   FAIL  Failed to install quasar-app-extension-ssg

It looks like a dependency version conflict, of workbox-build. I see there are PRs (by bot) to update that dependency, so probably that will resolve the issue?
Though, to be honest, I'm not sure why the webpack part is there, i.e. (excerpt from above):
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/workbox-webpack-plugin
npm ERR!     peerOptional workbox-webpack-plugin@">= 6" from<EMAIL_ADDRESS>npm ERR!     node_modules/@quasar/app-webpack
npm ERR!       peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
I'm using Vite, and the previous message also says vite, but for some reason it is installing dependency for webpack well.

The fix is available in<EMAIL_ADDRESS>Please, let me know if you have any issues.

Thanks. I have tested it just now, and adding SSG works.
However, when trying to build static pages, there are errors. I'll open another issue as it's a different one.


Merge master into bigquery and add BigQuery to README and TESTING

As per title this PR does one more fetch of master changes. Last commit (c0167ab) adds info on the BigQuery module to both README.md and TESTING.md.
After this I think we are ready to merge bigquery into master.

One nit comment, otherwise looks good to me.  Feel free to merge.

@ajkannan Thanks for the suggestion, I couldn't find a better link so I put storage's. I'll change it.


Show Currently Editing Script(along with the script type possibly)

What are you currently saying right now?


EventLoopBase: Start/stop event loop only once

Maintainer merge checklist

[x] Title is descriptive/clear for inclusion in release notes.
[x] Applied a Component: xxx label.
[ ] Applied the api-deprecation or api-break label.
[ ] Applied the release-highlight label to be highlighted in release notes.
[x] Added to the milestone version it was merged into.
[ ] Unittests are included in PR.
[x] Properly documented, including versionadded, versionchanged as needed.

The failing tests is due to the interaction between pyinstaller and pytest-cov. One of them must have updated and broke something.

Can we not use pyinstaller development version https://github.com/kivy/kivy/blob/master/.ci/windows_ci.ps1#L91?

https://github.com/kivy/kivy/pull/7513 should resolve it. The issue is probably that the dev version I used had a problem.

Ok. I'll rebase once https://github.com/kivy/kivy/pull/7513 gets merged.


The static side of subclasses should not be restricted by the static side signature of superclasses

TypeScript Version:  4.0.0-beta

Search Terms:
ts2417, "static side incorrectly extends"
Code
// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
class base {
    static foo(v: string) { }
}

class sub extends base {
    static foo(v: number) { }
}

Expected behavior:
It should pass.
Actual behavior:
It raised 2417: Class static side 'typeof sub' incorrectly extends base class static side 'typeof base'.
However static functions are never considered "inherited" or "same". base.foo and sub.foo are totally different. Many other languages also allow this behavior.
Playground Link:
https://www.typescriptlang.org/play?ts=4.0.0-beta
Related Issues:

Duplicate #4628


Non-Static Functions

Currently if you try to define a non-static C# function, things will blow up in our invoker pipeline with an error "Non-static method requires a target.". We should either allow this, or make this an early compilation error.
I actually had an MVP ask me about this. He asked why we had the restriction, and mentioned that he wanted to be able to do local testing with dependency injection. I'm not sure how that would work really, but it made me question our restriction.
The core SDK allows both static and non-static. We could choose to do the same. It would simplify method signatures.

We could relax this restriction. This was an early decision made because it reduces a fair amount of complexity, but it's definitely something we can do.
I would like to better understand the scenario, but although the current behavior does add a bit of friction, it does not prevent local testing with DI for the actual function logic.

Truly, statics make local mocking / IoC injection of unit tests all but impossible.

I second that.

Did this get fixed and released?

@StingyJack yes. This is now supported.

@fabiocav - Is there a trick to making it work then? Trying to debug a new Function from VS and its telling me it cant find the function.
public class FunctionExecutor
{
    [FunctionName("My_Functions_DbCleanup_ExecuteCleanup_Run")]
    public void Run([TimerTrigger("03:00:00", RunOnStartup = true)]
        TimerInfo myTimer, ILogger azLogger)
    {
            //  etc...

[2/12/2019 9:30:46 PM] A ScriptHost error has occurred
[2/12/2019 9:30:46 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'My_Functions_DbCleanup_ExecuteCleanup_Run'.
[2/12/2019 9:30:45 PM] Executed 'My_Functions_DbCleanup_ExecuteCleanup_Run' (Failed, Id=498dbd0d-418b-486c-a000-4fdf51bffec2)
[2/12/2019 9:30:45 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'My_Functions_DbCleanup_ExecuteCleanup_Run'.
[2/12/2019 9:30:46 PM]   Function had errors. See Azure WebJobs SDK dashboard for details. Instance ID is '498dbd0d-418b-486c-a000-4fdf51bffec2'
[2/12/2019 9:30:46 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'My_Functions_DbCleanup_ExecuteCleanup_Run'.

If I change the class and Run() method to static then the function executes.

Nothing special required. What version of the Core Tools/Runtime are you using?

The project is .net 4.7.2,   VS is up to date.  Is there a specific component you would be looking for the version of?
I was clicking about in ILSpy before I left the office and trying to figure out what that func.exe and Microsoft.Azure.WebJobs.Script dll's want for the FunctionName attribute value. I tried just "Run" as that is what I think the FunctionShortName it derives when doing the lookup just before tossing that "unable to resolve" error. The problem is definitely looking like a name mismatch but its kinda hard to follow without debugging through parts of it.  Is there any trace or diagnostic I can enable to dump out the function names it is able to resolve so I can try to appease it?

@fabiocav - I spent a few hours now trying different combinations and toying with this, but it does not seem to be possible to use non-static functions. The Microsoft.NET.Sdk.Functions package is v1.0.13
The namespace is My.Programs.AzFunctions, and the class name is FunctionExecutor and the method name is Run.
if I set the FunctionName attribute to FunctionName("Run") the func.exe output is
[2/14/2019 9:02:26 PM] Found the following functions:
[2/14/2019 9:02:26 PM] My.Programs.AzFunctions.FunctionExecutor.Run
[2/14/2019 9:02:26 PM]
[2/14/2019 9:02:26 PM] Host initialized (2263ms)
[2/14/2019 9:02:26 PM] A ScriptHost error has occurred
[2/14/2019 9:02:26 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'Run'.
[2/14/2019 9:02:26 PM] Executed 'Run' (Failed, Id=769581ef-8200-46b0-ac05-2f101ceca8e6)
[2/14/2019 9:02:26 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'Run'.
[2/14/2019 9:02:27 PM]   Function had errors. See Azure WebJobs SDK dashboard for details. Instance ID is '769581ef-8200-46b0-ac05-2f101ceca8e6'
[2/14/2019 9:02:27 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'Run'.
[2/14/2019 9:02:27 PM] The next 5 occurrences of the schedule will be:

If I use [FunctionName("FunctionExecutor")]
[2/14/2019 8:59:20 PM] Found the following functions:
[2/14/2019 8:59:20 PM] My.Programs.AzFunctions.FunctionExecutor.Run
[2/14/2019 8:59:20 PM]
[2/14/2019 8:59:20 PM] Host initialized (2082ms)
[2/14/2019 8:59:20 PM] A ScriptHost error has occurred
[2/14/2019 8:59:20 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'FunctionExecutor'.
[2/14/2019 8:59:20 PM] Executed 'FunctionExecutor' (Failed, Id=551a32f7-bc7f-48eb-bcb4-4fa4b75e5cdd)
[2/14/2019 8:59:20 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'FunctionExecutor'.
[2/14/2019 8:59:20 PM]   Function had errors. See Azure WebJobs SDK dashboard for details. Instance ID is '551a32f7-bc7f-48eb-bcb4-4fa4b75e5cdd'
[2/14/2019 8:59:20 PM] Microsoft.Azure.WebJobs.Script.WebHost: Unable to resolve function name 'FunctionExecutor'.
[2/14/2019 8:59:20 PM] The next 5 occurrences of the schedule will be:

When using [FunctionName("My.Programs.AzFunctions.FunctionExecutor.Run")] (to give it the name of the function it seems to be able to discover)
[2/14/2019 9:03:50 PM] No job functions found. Try making your job classes and methods public. If you're using binding extensions (e.g. ServiceBus, Timers, etc.) make sure you've called the registration method for the extension(s) in your startup code (e.g. config.UseServiceBus(), config.UseTimers(), etc.).
[2/14/2019 9:03:50 PM] Host initialized (1046ms)
[2/14/2019 9:03:50 PM] Host started (1114ms)
[2/14/2019 9:03:50 PM] Job host started
[2/14/2019 9:03:50 PM] The following 1 functions are in error:
[2/14/2019 9:03:50 PM] My.Programs.AzFunctions.FunctionExecutor.Run 'My.Programs.AzFunctions.FunctionExecutor.Run' is not a valid function name.

... so either the merge linked to this does not resolve the stated problem, or I dont have that merge compiled in whatever tooling is present.


fix buffer points

Small fix when buffering points, merging right away.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.19%. Comparing base (67a1699) to head (7d3e61d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   80.19%   80.19%
=======================================
  Files          11       11
  Lines        1737     1737
=======================================
  Hits         1393     1393
  Misses        344      344

Files
Coverage Δ

src/spatialdata_plot/pl/render.py
93.98% <100.00%> (ø)


[Bug]: Logic library management. If you view the physical library, the database name is incomplete when it is long

ODC version
4.3.2
OB version
no related
What happened?
Logic library management. If you view the physical library, the database name is incomplete when it is long
What did you expect to happen?
Logic library management. If you view a physical database, if the database name is long, display the overall database name
How can we reproduce it (as minimally and precisely as possible)?
Logic library management. View the physical library to view the longer database name
Anything else we need to know?
No response

Fixed In Commit fc75f558b0aaf21cf50eca18601554a40e30be6a
------
畅晚
Fri Nov 22 11:04:32 2024 +0800


error: ‘BN_MASK2’ undeclared

It was defined in OpenSSL 1.0.2 in openssl/bn.h as:
Line 189: #  define BN_MASK2        (0xffffffffffffffffL)
or
Line 218: #  define BN_MASK2        (0xffffffffffffffffLL)
or
Line 247: #  define BN_MASK2        (0xffffffffL)
But it has been removed in OpenSSL 1.1.0. How can I replace it?

BN_MASK2 is an implementation detail. Your code should not be
using it. What are you trying to do with it?

I solved my problem.
I'm fix incompatibility errors of a repository and it was one of them.
Who wrote that code was using BN_MASK2 improperly.
Thanks for your time :)


[Issue #29] - Improve diagnostics of Process reading in the native code

This change should significantly improve the diagnostics info for #29 in some corner cases. All the issues below may lead to #29 or to "Failed to read PEB" (e.g. JENKINS-8614 in Jenkins tests)
Native:

[x] Enable CRT in the Release build. It makes the DLL 5 times bigger (<10 KB => 50KB), but allows doing fine-grain logging. I can make it a non-default behavior if it is preferred
[x] Return explicit error if the process is no longer running
[x] Return explicit error if we try to poll the 64bit process from a 32bit JVM (probably it is a way to do it in WinP by dirty hacks, but I would not expect any other stuff in Jenkins to work reliably in such case - leads to #29 or PEB error)
[x] Return explicit errors if the Process Memory region is not readable && we want to read EnvVars from there. For newly created processes it will lead to #29 (Header is ready, but memory region is not ready)
[x] Return explicit error if the code is messed up, and the Environment pointer is incorrect (e.g. we read RTL_USER_PROCESS_PARAMETERS incorrectly, leads to #29)

Java:

[x] Enable stacktraces and core dumps for the build failure
[x] More tests

Work is in progress, because AppVeyor JVM was crashing, need to investigate. likely it is due to the isWow64() method, where I oversimplified the pattern once the simple approach worked.
@reviewbybees

So yes, I should not have removed the intelligent import code, which has been proposed for https://msdn.microsoft.com/en-us/library/ms684139.aspx . AppVeyor is not running builds as a desktop App, hence it captured the API misusage.

Self-:bug:

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@reviewbybees @kohsuke Ready for review. I would especially appreciate feedback regarding CRT inclusion feasibility. Effectively it is required for fine-grain logging only, which I could disable for the release build (and maybe make it configurable via system property). OTOH, 40KB should not be a problem in 2017 since it needs to be loaded only once.

@reviewbybees done

@kohsuke said he is fine with CRT inclusion. @reviewbybees done => Merging


Bind to other than <IP_ADDRESS> address

Hi,
is it possible to add an extra parameter like
--web-ip
so one can specify other than <IP_ADDRESS> IPs?
Thanks

For anyone else looking for an updated answer on this, it seems that the default is now <IP_ADDRESS> (and the parameter is named --web-host).  The documentation is ambiguous, as noted here:  https://github.com/node-inspector/node-inspector/issues/852


fix: Make Extra a byte slice

Description:
Make Extra a byte slice.
Related Issues:
Fixes #14
Checklist:

[x] Review the CONTRIBUTING.md documentation.
[x] Add a reference to a related issue in the repository.
[x] Add a description of the changes proposed in the pull request.
[x] Add unit tests if applicable.
[x] Update documentation if applicable.
[x] Add a note in the CHANGELOG.md if applicable.
[x] Sign the Google CLA.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.17%. Comparing base (9f5cfd4) to head (79961a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   70.07%   70.17%   +0.10%
==========================================
  Files           1        1
  Lines         284      285       +1
==========================================
+ Hits          199      200       +1
  Misses         57       57
  Partials       28       28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Detect non-verbose flags being used in F# scripts or YML CI files

Please rebase this PR 🙏 Thanks

Please rebase this PR pray Thanks

Done

@realmarv I raised 2 nits before this can be merged; but please before addressing them, please pull, because I added a commit to your branch

@realmarv also PR's CI is red

CI is still red

CI is still red

It's green now


[Question] whether the custom plugin supports the custom format

Question

hi. Not currently supported. But you can make it happen!


Tag a release so distros can package boomerang properly

As a distro packager I fully agree with this.

Ok, I've tagged a v0.3.99-alpha testing release.
The plan is to gather some feedback, maybe some error reports and go for more fleshed out v0.4.0 release on 25th April


fix(logical topn): logical group top n incorrectly planned as `logi…

…cal top n`
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
The existing planner may transform logical group top n into logical top n in prune_col
Checklist

[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
#6594

😇 Add a test case to cover it?

done


[Bug] $$.each cannot break out of loop. DOM7

This is a (multiple allowed):

[x] bug

[x] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 1.5.2

Platform and Target: CHROME WEB BROWSER, CORDOVA-CROSSWALK, ANDROID.

Live Link or JSFiddle/Codepen: https://codepen.io/anon/pen/xgqpmj

What you did
DOM7 $$.each does not match expected behavior - how do you break out of the each statement in DOM7?
in JQuery if you return false it will break out but in DOM7 if you return false; it acts like continue; and moves onto next item in array.
Expected Behavior
expect $$.each to break out of loop when return false callback is hit.
Actual Behavior
$$.each when it hits return false .each just continues to next item in array - example in code pen above.
Expected to hit 'test' in array and break out of loop but you can see if just continues with the other items in the array

Yes, looks like a bug to me. Very weird behavior of $$.each

jQuery implementation for reference https://api.jquery.com/each/


[bug] The specified go version file at: go.mod does not exist

The go-version-file input to the Go builder passes the value to setup-go but since the project is checked out to a different directory than the GITHUB_WORKSPACE setup-go will fail to find the file.
The path given to setup-go needs to be joined with inputs.path where the project is checked out in secure-project-checkout.
https://github.com/slsa-framework/slsa-github-generator/blob/7e31fad1e6c846162e8b794a6ca0d04417a17e0d/.github/actions/secure-project-checkout-go/action.yml#L62

@raghavkaul is this the problem you encountered on scorecard a couple weeks back?
Let's create e2e test for this one, if we don't have one already. I can squeeze this in the next release (this week)

Seems that the fixing code is not contained in v1.9.0

Seems that the fixing code is not contained in v1.9.0

Yes, this still hasn't been released :(

We plan to release very soon. /cc @ramonpetgrave64 We have one or two more issues to address


Support and utility for pairing (commissioning)

This adds support for the reverse-engineered (well, just read the network logs) commissioning process as a library call and an example program that spews nice messages to it and crudely displays newly paired devices.
A first commit fixes a race condition that happens when a program (like the example) aggressively starts accessing multiple resources on the server "simultaneously". (Not that the requests would actually overlap because they're CONs and CoAP doesn't by default allow more than one of them at a time, but still, the application can leave that scheduling to the libraries).

Thanks for the PR @chrysn! Is this still WIP or ready for review? I'm thinking about the lint errors.

Just went through the lint errors (took me a moment to find which tool the bot uses). If the checks pass this time, it's ready for review.

Thanks, the Hound seems pleased! Am a bit curious though about why Travis isn't building this?

@chrysn I have released this as 4.1 on pypi. Thank you for your contribution and thank you @lwis for the review! :+1:


How to set Visual mode selection (and other) colors?

Visual mode selection uses white background (unlike standard VSCode selection) and when the text is white I can't see the selected text which makes it unusable. Also, when the file have Syntax Highlighting (su multiple colors) I do see the text but not very good, depending on the colors.
How can I customize the colors? I tried the highlight commands (Visual and others) but they don't seem to work and I couldn't find any VSCode settings either. I tried looking at the source code and it seems there is some code that deals with color codes conversion of various highlights but the commands just don't seem to have any effect on VSCode (while the same commands do affect a standard Neovim).
So how can I set colors for the selection as well as potentially other VSCode/Neovim colors?

this isn't a support channel

Actually, I believe this is a bug. Instead of doing reverse of colors like VSCode selection does vscode-neovime just change the background to white, so when the text is white it can't be seen.
Just before filing a bug I wanted to verify I'm not missing any setting (my guess I don't miss and it is a bug).
So should I file this as a bug instead?

On my system, the nvim visual selection uses the same highlight as vscode's selection. You might have weird syntax highlighting coming from your init.vim.

@theol0403 Does it use both the same background and foreground? So the Visual mode selection alters the foreground color of the text like VSCode selection does?

This shows nvim's visual selection and then vscode's selection.
https://user-images.githubusercontent.com/16546293/165633449-b7dbe32f-be33-4a35-8d0c-bae381ea9f03.mp4


BaseAzureViewModel does not support EntityDataAlwaysLatest

The BaseAzureViewModel requires T to be of type EntityData and since there is no inheritance between EntityData and EntityDataAlwaysLatest, there is no way to actually use models inheriting from EntityDataAlwaysLatest with the BaseAzureViewModel.

We're currently looking to remove the BaseAzureViewModel in favor of the ConnectedObservableCollection instead.
Check it out in the 1.1 branch.


Add fielded search

refs #645; close that ticket after rake task has been run.

checked in chrome, firefox, safari.

Coverage remained the same at 100.0% when pulling 75b76fadf492e70edeb1cc93bfb257b42c992ea0 on 645-fielded-search into e0053c73148e5ad5ca915c5972216506f4f0d4db on master.

looks good in edge.
not good in ie 11:

fixed ie11. ready for review.


SAE layer lndex question

https://huggingface.co/EleutherAI/sae-llama-3-8b-32x-v2
from sae import Sae
sae = Sae.load_from_hub("EleutherAI/sae-llama-3-8b-32x-v2", hookpoint="layers.24")
What is the "layers.24" mean here? the 24th or 25th  transfomer hidden states output? I assume the transfomer layer index start from 1, and embedding layer index is 0.

I assume the transfomer layer index start from 1, and embedding layer index is 0.

This is not true. The layers are zero-indexed. We simply use get_submodule to select the appropriate layer.


[WIP] 255 standard dependency injection

Description
Implemented changes to support standard .Net Core Dependency Injection
@amanbha: First draft for the changes we discussed yesterday. Tests are partially commented out. Manual test was  #successful.
Issue reference
#255
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@chleit Thanks for the contribution and first draft, I will review these.

@chleit just fyi, sorry for the delay, I am still looking at it.

cc @malotho  as well.


Uplift to React 16

Issue Type

[ ] New Feature
[x] Enhancement
[ ] Bug
[ ] Other

16 Migration Guide
https://github.com/cerner/terra-core/wiki/React-16-Migration-Guide

Blocked by:

[ ] https://github.com/cerner/terra-clinical/pull/272
[ ] https://github.com/cerner/terra-framework/pull/73


[otbn,dv] Add dist to offset in sw_no_acc test

This commit makes it more likely to pick beginning or end of the Scratchpad memory in DMEM.
Signed-off-by: Canberk Topal<EMAIL_ADDRESS>This change is for fixing a coverage hole in daily regression. Resolves https://github.com/lowRISC/opentitan/issues/14973

Update: This PR needed a little bit more changes but now works as expected.

Changed waiting until not BusyExecute to waiting until we are Idle (because TLUL accesses while not Idle are already blocked, we want to see an access that is faulty because of an access to an undefined region)
Disabled scb_tl_err_chk configuration bit because if we check TLUL accesses in sw_no_acc_test, we'd definitely get True which then blocks us from updating the scoreboard (which samples the covergroup).
Changed top addr from 8FFF to 8FFC because we sample with aligned addresses.


feat: languages

Pull Request

Added languages to the user profile.

linked issues:

Hacksbr/resume-api#43 - Fully

App


Prioritize upcoming data sets

@ravinepal
We have several potential data sets that we can include. Can you take a minute and prioritize them?
Here are the data-set issues that I believe need prioritizing:
#181 -- forest and watershed
#185 -- earthquake
#186 -- flood
#187 --  foreign aid
We also have older issues that haven't been addressed. If some of those have data and are more important, having them go first would be good.

sorry @cliftonmcintosh I missed this earlier. Thanks for the reminder. I'd say pls go ahead with these:
#181 -- forest and watershed
#185 -- earthquake
I'll soon clean data fro flood and foreign aid and share.

#187 -- foreign aid
#186 -- flood
#185 -- earthquake

closing this for now. We can create a new issue when we are ready.


OTST_TI_FULFILLMENT_Enhancement

Description
This scenario includes interaction with the following APIs:
Post /offers, the request is related to one passenger and is based on a tripSearchCriteria, containing
Origin
Destination
departure time
Post /bookings, the request is based on one of the offerId contained in the response of the Post /offers response.
Post /bookings/{bookingId}/fulfillments, the request contains the bookingId produced by the previous interaction.
Scenario
Generate and send a Post /offers request related to one passenger with a tripSearchCriteria, containing
Origin
destination
departure time
Generate and send a Post /bookings request using one offer in the Post /offers response, defined by the offerId contained in the response of the previous interaction
Generate and send a Post /bookings/{bookingId}/fulfillments request using the booking.id contained in the response of the Post /bookings and retrieve the pdf documents in the fulfillments.fulfillmentDocuments.content field
SFR

OTST meeting outcome :
A fullfilment scenario already exist, but with basic validation.
It is necessary to enhanced it with more display and assertion. This scenario will manage the enhancement.
Wait for candidate to define the SFR

OTST meeting:
Should the scenario check the ticket issued (like the PDF content) ?
If yes is there a common PDF ticket standard is used or as many structure as railways ?
Is it part of OSDM scope to check the PDF file generated ?
At minimum a pdf ticket must be generated. But des the requester could selecte dthe type of ticket (PDF, Mobile) and ask only a dedicated one like Mobile. In this case the provider will not send the mandatory PDF ticket as not requested ?
To be check with EC team.
If a Railway support multiple fulfillment options (mobile, PDF, raw data) should all of them be tested ?
The default scenario will be with PDF fullfilment.
Other flavors of the scenario would be to configure the fullfilment option we are willing to receive (and check the response received)


HARP-7072: Reimplement "all", "any" and "none" as flow operators.

Move the implementation of common control flow operators to
FlowOperators.ts. This will allow ExprEvaluator to potentially
cache previous computed expressions containing these operators.
Signed-off-by: Roberto Raggi<EMAIL_ADDRESS>

Codecov Report

Merging #1026 into master will decrease coverage by <.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
- Coverage   44.84%   44.84%   -0.01%
==========================================
  Files         240      240
  Lines       22435    22433       -2
  Branches     5097     5093       -4
==========================================
- Hits        10062    10060       -2
  Misses      12373    12373

Impacted Files
Coverage Δ

...datasource-protocol/lib/operators/FlowOperators.ts
77.14% <66.66%> (-7.86%)
:arrow_down:

...here/harp-datasource-protocol/lib/ExprEvaluator.ts
81.73% <91.66%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c08414...5908571. Read the comment docs.


Lambda is showing http request as separated context

Hi,
Sorry to open a blank issue but I don't know which issue type to choose.
I've manually instrumented a .net lambda function and an aspnet api which call a step function which in turn invokes the lambda.
So the flow is: api -> sf -> lambda -> other http calls.
I see the traces correctly on x-ray but the last part of the flow is represented separately on the map.

I attached the screenshot to represent better the situation. In the first one we see the link from step function and the lambda (the step function is not instrumented, it might be retrieved from the instrumented api that calls it). And then in the last one we see the lambda, with the custom service name that I configured in the code, that calls the other services. I was expecting to see these links from the first screenshot where we see the lambda called by step function.
Where could be the issue here?
Thanks

Hi @ciolial, as far as I see, you have some trace link issues with AWS XRay, right? If so, this shouldn't be OTEL issue.


Two Factor Authentication

Add a way to log in on 2fa-enabled accounts
'subtasks': [{'subtask_id': 'LoginTwoFactorAuthChallenge'

Supported since v1.2.7


Is there a way to have at least 2 different sources of push notifications?

The first source is Exponea (pushes get delivered by APN)
The second is my backend (pushes get delivered by FirebaseMessaging)
Right now there is only the first source in my app. I use ExponeaFlutterAppDelegate like this:

And I want to add another source of push notifications. I'm going to use FirebaseMessaging to deliver pushes from my server. I'm going to modify my code like this:

I'm wondering how I can combine 2 sources at the same time? So if the push belongs to Exponea then I don't have to do anything additional to handle it (just use the current implementation). Otherwise, if the push doesn't belong to Exponea then I want to listen to pushes somewhere in the dart code by using FirebaseMessaging.onMessage() or FirebaseMessaging.onMessageOpenedApp()
any help would be appreciated. Thank you

Hi, thanks for asking.
Yes, there is a possibility to have multiple push notification providers, but the implementation on the app side is little tricky.
There are no such callbacks to listen to for received push notifications on Flutter Exponea SDK, so you need to implement that to send them to flutter/dart code. Also Combining this plugin with FirebaseMessaging is not necessary, you can just modify your FirebaseMessagingService on Android platform and AppDelegate by overriding ExponeaFlutterAppDelegate's methods. Hope this helps.
Regards


[Bug] Flink restapi watching threads accumulate and blocked

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
1.8
Scala Version
2.12.x
StreamPark Version
2.1.1
Flink Version
1.14
deploy mode
yarn-application
What happened
The large amount of waiting threads in the Flink REST API watching executor leads to the accumulation of waiting, causing the failure of the streaming application state monitoring.
Error Exception
No response
Screenshots

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

We maintained around 700 jobs and frequently encountered thread blocking issues. Only by restarting the service can we recover.


Getting this error when setting up with 32gb and 64gb cards

I'm getting this error right before the reboot step.  So after reboot, the CAM drive does not show up on windows.
Error: The location 62535680 is outside of the device /dev/mmcblk0.

I'm getting something similar
Error: The location 62521344 is outside of the device /dev/mmcblk0

I'm getting this error with an 8gb card.  It looks like the root partition is taking up the all available space on the card.  When the backingfiles partition is created, it attempts to be created one sector above the last sector on the card.  The backingfiles partition tries to start with sector 15523840.  Below is the info from parted:

Model: SD SL08G (sd/mmc)
Disk /dev/mmcblk0: 15523840s
Sector size (logical/physical): 512B/512B
Partition Table: msdos
Disk Flags:
Number  Start   End        Size       Type     File system  Flags
1      8192s   97889s     89698s     primary  fat32        lba
2      98304s  15523839s  15425536s  primary  ext4

I think I know why I ran into this issue.  I did not run the powershell script to configure the sd card in Windows.  Instead, I manually configured the wifi config file and added an ssh.txt file.  Apparently, by default, Raspbian will resize the root partition to fill the drive on the first boot.  This is disabled by the setup-piForHeadlessConfig.ps1 script.
@lolento , @pqi8  did you configure the card in Windows?  If so, did you run the powershell script to do the configuration?

I just read issue #22 and see that these issues appear to be the same.  @cimryan made comments in #22 that should fix the issue (updated instructions).

Yep, this is fixed with the updated instructions for HDMI and Keyboard setup to edit the cmdline.txt.

Confirmed the error is gone when removing the built in resize from cmdline.txt. However the USB drive still isn't mounting to the host.
root@teslausb:~# mount -a -v
/proc                    : already mounted
/boot                    : already mounted
/                        : ignored
/backingfiles            : already mounted
/mnt/cam                 : ignored
/mnt/archive             : already mounted
/var/log                 : already mounted
/var/tmp                 : already mounted
/tmp                     : already mounted

root@teslausb:~# ls -la /backingfiles/
total 56235672
drwxr-xr-x  3 root root        4096 Oct 17 15:36 .
drwxr-xr-x 23 root root        4096 Oct 17 15:36 ..
-rw-r--r--  1 root root<PHONE_NUMBER>4 Nov  3  2016 cam_disk.bin
drwx------  2 root root       16384 Oct 17 15:36 lost+found

root@teslausb:~# cat /etc/fstab
proc            /proc           proc    defaults          0       0
PARTUUID=7fd599a5-01  /boot           vfat    defaults,ro          0       2
PARTUUID=7fd599a5-02  /               ext4    defaults,noatime,ro  0       1
# a swapfile is not a swap partition, no line here
#   use  dphys-swapfile swap[on|off]  for that

/dev/mmcblk0p3 /backingfiles ext4 auto,rw,noatime 0 2
/backingfiles/cam_disk.bin /mnt/cam vfat noauto,users,umask=000 0 0
//MYIPHERE/TeslaCamFiles /mnt/archive cifs credentials=/root/.teslaCamArchiveCredentials,iocharset=utf8,file_mode=0777,dir_mode=0777 0

tmpfs /var/log tmpfs nodev,nosuid 0 0
tmpfs /var/tmp tmpfs nodev,nosuid 0 0
tmpfs /tmp    tmpfs nodev,nosuid 0 0

Not sure where the mount logic or file creation logic changed to break this.

@lolento @firedfly are you confirming that it's now mounting properly as a USB drive, or just that it doesn't error out?

@lolento @firedfly are you confirming that it's now mounting properly as a USB drive, or just that it doesn't error out?

Yes, I redid the setup with a 32gb card and now, on both Windows and Tesla, I can see both "Cam" drive and "Music" drive (each at 16gb)

I can do that when I get home today.

Thx! Mine is a 64GB card btw.

It looks like the original issue here is resolved, so I'm moving the bit about the drives not showing up to a new issue.


PowerRename does not work with many selected files

Microsoft PowerToys version
0.69.1
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
PowerRename
Steps to reproduce

Select 100,000 files in Windows Explorer.
Right-click and select PowerRename. Wait for the PowerRaname window to appear.
If the PowerRename window appears, attempt to rename the selected files.

✔ Expected Behavior
The familiar PowerRename dialog should appear to allow renaming. At the very least, an error message should be displayed.
❌ Actual Behavior
After a long time, the circular awaiter icon stopped and nothing else (that I am aware of) happened.
Other Software
No response

I needed to rename a BUNCH of files so I wrote a console app to do it.  Here it is if anyone has a need :)
RenameProject.zip

Hi Cinnamon!
No I do not still have the issue. I needed to handle renaming millions of files, so I wrote the Rename console utility (above) to do it. That was an important task, but I haven't needed to do it again.


Implement correction for gpsTime

This subtracts 18 seconds from the gpsTime used as epoch.
Resolves #135

LGTM, is the windows build expected to fail?

No, but it works now, after updating go-version.


webidl.o not found in opam installation

I wrote an example app using webidl, and I am now trying to compile it using dune. My dune file looks like this:
(executables
 (names main)
 (libraries core async webidl ppx_deriving.runtime)
 (preprocess
  (pps ppx_jane ppx_deriving)))

I then sadly get the error:
gcc: error: /home/avatar/.opam/4.09.0/lib/webidl/webidl.o: No such file or directory

Which is correct, that file isn't there. The directory only contains
./META
./webidl.cmx
./webidl.cmt
./webidl.cmi
./webidl.cmo

Am I trying to use this incorrectly?

Indeed, once I manually compiled webidl and copied the .o file over to the opam directory, everything worked fine.


Can you please share trained model for SL and HDR which are giving you similar performance compare to the paper?

Sorry but I did not retrain this on the full dataset.
In principle you could copy the weights from the tensorflow version if you want to obtain that result.