Missing visual issues

[ ] #255

[ ] #254

[ ] Set background color to #2b2b2b for calcite-mode-dark main (https://main--esri-eds--esri.aem.page/fr-fr/about/about-esri/overview#développement-durable)

[ ] Fix call to action second button to have the alternative style (https://main--esri-eds--esri.aem.page/fr-fr/about/about-esri/overview)

Button alt styles, aem.js has primary | secondary options based on strong | em. Is that carrying over? I think this is a good pattern to follow.

RE: button styling. Using strong | em does work, with limits right now.
But I've noticed that some block where brought over and kept the <calcite-button> in tact. Any reason we didn't do that for all buttons?

RE: button styling. Using strong | em does work, with limits right now.
But I've noticed that some block where brought over and kept the <calcite-button> in tact. Any reason we didn't do that for all buttons?

There's logic in some blocks that does the conversion, maybe we can discuss those blocks and see what we want to do with them.

CTA second button alternative style is ready, but relies on some content changes.


SV update

Thanks for the update, but it seems that you've based your changes on an older version, so there are several conflicts with existing translations. Since I don't understand the language, I can't resolve those conflicts myself, would you be able to resolve those on your end and make another pull request please?

Thank you for the translations!


Can we somehow preserve comments when decompiling?

I'm not sure how important this is to customers. Although we do see that for Az CLI decompile is a top 5 or 6 used command. As a low cost solution, I imagine we could capture all of the comments in the ARM file, then pop all of the comments to the top. This wouldn't be a perfect solution, but it would also prevent us from worrying about:
apiversion...
//a line that is just a comment
more lines of code
some line of arm code... //some comment after a bit of code
more lines of arm code

I feel like moving all the comments to the top is worse than just not supporting comments at all. Code comment text rarely contains information about the context to which it's attached, so moving comments around destroys a lot of their value unfortunately.
For example:
{
  "variables": {
    "someName": "hello",
    // don't set this to 0 or bad things happen
    "veryImportantCount": 1,
    "completelyUnimportantCount": 2
  }
}

After decompiling (this is just a simple template - imagine one with 10s of resources, modules, vars, params, etc.) :
// don't set this to 0 or bad things happen
var someName = 'hello'
var veryImportantCount = 1
var completelyUnimportantCount = 2

That's a great point! Yea it doesn't seem like this is going to be done any time soon. Thanks for the feedback though


export personal note pdf

'Comments' could use the same logic; but I'm unsure how the model works there (and most doc is incorrectly claiming to be a category there)

Please add a title 'Personal note' to pdf - like in 2.3.

(just a note: personal note pdf export seems to be broken on demo.openslides)

done


Training log file for flava full

🚀 The feature, motivation and pitch
Hi guys,
If possible, can you attach the training log file of the flava full model in the readme.md section?
Thank you!
Alternatives
No response
Additional context
No response

Hi @rishabhm12 thanks for the issue. I don't think it makes sense to upload the full training log as it is quite large; also it won't really translate anyways if you are working with a different dataset.
Yes, this is the correct checkpoint to use for fine-tuning. If the image losses are not decreasing as expected you can try modifying your trainer params to account for the different dataset. For instance the learning rate differs for fine-tuning on SNLI and VQA V2 datasets (full details can be found in section B.2 of the paper).

Hi @ebsmothers ,
Thanks for the reply. Sure, I'll play around with diff hyper params and check for the losses again. Closing this issue, will get back as and when I have more questions (if any)


Pachyderm Init Containers in CrashLoopBackOff due to argument list too long error when after ~2000 services in namespace

What happened?:
New pods are not running due to error in Init Container:
Init Containers:
init:
Container ID:  docker://0deade6d4fc11be9af5cde7198e600405ae759291aa244cb2fa8b152747743be
Image:         pachyderm/worker:1.9.12
Image ID:      docker-pullable://pachyderm/worker@sha256:d00490adf160fe2cb62aa1835087a647d8d555089584ce2a9418e350be36e1b0
Port:          <none>
Host Port:     <none>
Command:
/pach/worker.sh
State:          Waiting
Reason:       CrashLoopBackOff
Last State:     Terminated
Reason:       Error
Exit Code:    1
Started:      Tue, 09 Jun 2020 20:20:35 +0100
Finished:     Tue, 09 Jun 2020 20:20:35 +0100
Ready:          False
Restart Count:  15

When checking the log of the init container:
standard_init_linux.go:211: exec user process caused "argument list too long"                                     stream closed

It started to happen when we created a staging environment for pachyderm that would trigger deployment of pipelines and after some weeks each pipeline had around 250 versions in history, which translated in 250 services/endpoints per pipeline and ~2000 in total in kubernetes.
CAUSE/Quick FIX solution
It happens because the environment variables for services is too long when having ~2000 services, it could be fixed by setting enableServiceLinks to False (https://github.com/kubernetes/kubernetes/issues/84539) or by removing some services.
What you expected to happen?:
Pachyderm should delete services/endpoints from previous versions of the pipeline.
How to reproduce it (as minimally and precisely as possible)?:
Deploy ~2000 versions of a pipeline and the pipeline will not be able to launch the pod to ready due to init container error by the environment variables created for each service in kubernetes in that namespace.
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.10-eks-aae39f", GitCommit:"aae39f4697508697bf16c0de4a5687d464f4da81", GitTreeState:"clean", BuildDate:"2019-12-23T08:19:12Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Pachyderm CLI and pachd server version (use pachctl version):
$ pachctl version
COMPONENT           VERSION
pachctl             1.10.4
pachd               1.9.12

Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
aws

OS (e.g. from /etc/os-release):

Others:

Thanks for reporting this @ronaldosaheki. Pachyderm's old behavior—not deleting k8s services when pipelines are updated—was a bug that should be fixed in Pachyderm >1.10.3 (also reported in https://github.com/pachyderm/pachyderm/issues/1732 and https://github.com/pachyderm/pachyderm/issues/4071). I think if you update your cluster (which seems to be on 1.9.12) then that should hopefully solve the problem.
I'm marking this issue closed because we're not planning to take any further action on it, but please feel free to re-open if needed.


error for add public void onCompletion

hi
why get error
@Override
public void onCompletion() {
if (mCurrentState == CURRENT_STATE_ERROR) {
// add the logic you need
}
if ("quit fullscreen") {
super.onCompletion();
}
}

or where add code ? i want after click this icon

try play video

I can't write you in freelancer.com
farkhadgojazadeh

can fix this problem ?

Yeah I can help you if you provide a little more information. you've set a string as a condition. Therefore compiler doesn't know what you want from it

you have skype ?


CLI install fails with new UserInfo system

https://github.com/concrete5/concrete5/commit/397ed1749e5cfe6f8190d03f1fe2bb3edd65c8d6 breaks installation of concrete5 via the CLI installation.
This is caused by the use of the DatabaseManager parameter in the new class constructors: we don't use the same DatabaseManager instance used by the Database facade, and the new DatabaseManager instance is not able to connect to the database at install time.

A possible approach to fix this is #3145

It looks to me that we really want connection and not manager at all. We
should be able to just hint on connection here. @mlocati, I want to get
away from using aliases and facades in the core. I know I have been a major
proponent of facades and aliases, and I think that they add some value for
the end user, but we should avoid using them in the core in favor of using
the service locator or dependency injection.
On Mon, Nov 23, 2015 at 2:34 AM Michele Locati<EMAIL_ADDRESS>wrote:

A possible approach to fix this is #3145
https://github.com/concrete5/concrete5/pull/3145
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5/issues/3144#issuecomment-158899994
.

I think that such core changes should be done very wisely. First of all, concrete5 is a project targeted to a very large audience; secondarily we can't assume that package developers have to spent most of their time trying to keep their knowledge up to date with rapidly changing core changes.

Couple things:

I made these changes in order to make it much easier to swap out the avatar handling (primarily so we could use concrete5.org user avatars on our documentation sites, but it should lend itself to lots of community improvements.) I also took the opportunity to begin to refactor one of the larger, more irritating classes (UserInfo).
The changes should be completely backward compatible.
Connection should indeed be the variable that we automatically pass in. That was an oversight. Connection is now being passed in (as of the latest commit) and installation via the web browser works as it has.
Sadly, this didn't fix the issue posted about here – mostly because I'm not really sure how the database command line connection naming works. The $connection variable is being automatically passed in, but it's not the instance that is set by the Database::extend() method. This will have to be fixed but I imagine it can be fixed by either reworking Database::setDefaultConnection and/or some additional code in the command line installer.

@mlocati I think it's good that we have people keeping that in mind. To be clear, I am arguing for more DI and not for removing facades. I think facades add a lot of value to c5, I just think that we should be using DI instead where possible (which should be everywhere).

@aembler I'll take a look at that, I might have some commits in my branches that aren't up to date.
In the service provider we tell the application how to resolve an instance based on the FQN of the class. In PHP 5.5+, this looks something like this:
<?php
$app->bind(Connection::class, 'database/connection');

so now when the application sees that Connection is a dependency, it's basically just running $app->make(Connection::class).
I'll get this working.

Yeah I understand all that. I'm doing that throughout all this new code. The problem is that the connection that's being injected isn't the same one being set in the installation command.
Sent from my iPhone

On Nov 23, 2015, at 3:55 PM, Korvin Szanto<EMAIL_ADDRESS>wrote:
@aembler I'll take a look at that, I might have some commits in my branches that aren't up to date.
In the service provider we tell the application how to resolve an instance based on the FQN of the class. In PHP 5.5+, this looks something like this:
bind(Connection::class, 'database/connection');
so now when the application sees that Connection is a dependency, it's basically just running $app->make(Connection::class).

I'll get this working.

—
Reply to this email directly or view it on GitHub.

365d6e13b232ef2306fbc8edf6c74b73e218992d fixes this issue, I avoided making the managers singletons when updating the database service provider because we already track singletons of these objects in the facade layer.


Adding an OpaqueSecretSelector

rancher/dashboard#1031
Demo:

Unfiltered secrets:

Notes:

I updated the providers to deal with compilation issues but I don't expect them to work until I update the Output crds.
I created the clusterOutput page just to demo, this will get updates with the Output crd changes.

This solves the very specific current problem but isn't reusable for much of any other use case.  Why limit the whole component to Opaque secrets instead of defaulting to any (and having an optional type filter prop)?  What if I just want a secret name and don't need to pick an individual key from it?
Some of the values it's used for here in logging seem likely to come from a secret I might have made with type=kubernetes.io/tls that would be inexplicably missing from my list of choices.
(I also am not particularly sold on the names of the values keys you have to populate the selection into, but that's not a ui problem)

I addressed your feedback. I made this a generic secret selector.


List git repos that have unpushed commits

I use dirty-git to list all my "procrastination repos", and it works fine. But this is also useful to list work-in-progress repos before reinstalling a system. Wouldn't it be great to list unpushed commits as well?

Yes this makes sense, but it could slow down the process (with those network round trips) so should be behind a flag.
I have always handled this personally by checking tags. Every time I release something, I tag it. So if the latest commit does not have a tag, (dirty-git --unreleased) then I assume it has not been pushed (but yeah, obviously this won't work for a lot of workflows).

Yeah, many repos just have a master branch without any tag. Sort of "rolling release".
I'm okay to make it optional, but I don't understand why it would slow down because of the network. Do you mean we should run git fetch for every repo?

I didn't think it was possible to find out if changes had been pushed to a remote without asking the remote. But turns out I was wrong. This info is cached locally:
git log origin/master..HEAD # works without internet connection

It shouldn't add any extra time to the scan, so I'm keen for this to be default behaviour!

You're right, since Git allows distributed development, each developer keeps locally the entire project history, and thus the non pushed commits.
So, OK, let's go for the default behavior :wink:
Before starting any dev, can I ask you why you didn't choose to use NodeGit, the Node.js bindings to Git? Not a criticism, just wondering. I find it more robust to extract complexity in existing libraries. Especially when it is well maintained and widely used like NodeGit.
Would you mind if I rely my further devs on that lib?

This started as a quick hack together I made one day, and then @jhermsmeier cleaned it up considerably and added a lot of features and did some major restructuring.
It works well enough for my purposes now, so have barely touched it. I'm open to other deps, as long as it makes it simpler, not more complicated. But really, I don't care, as long as it keeps working.
@nagromc If you get excited about this project, and want to take it over, you're more than welcome!

Nope, not working, lists stuff that IS pushed so again, not working

Okay, I'll archive the repo then.


Remove build status image from README.md

Chatted w/ @RickWinter -- Since this is in the README.md we want to keep it visible in the repo but not have it in the documentation. We may need to do some work to comment these things out.

This seemed like a quick change but there's more complexity underneath (show in GitHub, don't show in docs). Closing this PR and opening this issue to track the design: https://github.com/Azure/azure-sdk-for-c/issues/947


Move client file metadata to FileMetadata table

This has been updated now to add the property name directly into the FileMetadata table. The getClientFileMetadata field has also been updated to get the metadata based on the property name. Because we haven't run the migration yet which updates the existing FileMetadata rows with the property name, it means that we won't be able to get any historic FileMetadata This shouldn't be a problem, as the only time we call the getClientFileMetadata field is for a current upload, we don't have anything at the moment that needs to read historic metadata.

This has been updated now to add the property name directly into the FileMetadata table. The getClientFileMetadata field has also been updated to get the metadata based on the property name. Because we haven't run the migration yet which updates the existing FileMetadata rows with the property name, it means that we won't be able to get any historic FileMetadata This shouldn't be a problem, as the only time we call the getClientFileMetadata field is for a current upload, we don't have anything at the moment that needs to read historic metadata.


tor is out of date.

15 days out of date so far.
Will be orphaned if no response.

@IslandAlpha

Would anyone like to maintain this package?

Sorry for the delay, I switched off of KISS as my daily driver since it doesn't meet all my needs as of now.
Do you mind if I stay as the maintainer for this package?

Tor will be updated by the end of the day

Sure thing. You should be able to update the package via a chroot of KISS. Just unpack the install archive (as root) and chroot into it. :+1:


feat: add bugsnag.apiKey plist location

Goal
Adds the new location to search for API key (bugsnag.apiKey) in plist file.
Changeset

Updated checks in both fastlane plugin scripts to check for new location and fallback to previous one.

Tests

Amended tests to use new location and added a legacy check for BugsnagAPIKey

Checked @tomlongridge's changes to use the new API key location in the Info.plist (bugsnag.apiKey, fallback to the old BugsnagAPIKey), LGTM. Added some further changes to the order of precedence so have removed myself as reviewer.


[INFRA-19844] Enable probot autolabeler

Waiting for INFRA enablement
R: iemejia

I had almost the same suggestion than @sunjincheng121 however there is a small refinement to do over that one, do not put prefixes e.g. extensions-java-sorter use better sorter the other paths are matched by the other tag rules the specific rule for java and for extensions.

Forgot to mention, Can we sort the elements of the file so it can be easier to maintain too.

I've added @iemejia and @sunjincheng121 suggestions. I did use a prefix though to make it usable in maintaining labels. I hope the auto-labeler can handle them. Prefix used are:

extensions: ext/ (example: ext/jackson)
io: io/ (example: io/mongodb)
runners: run/ (example: run/flink)

I also sorted the labels. Squashed commit.

Added the main labels already to the repo (not the sub labels)

Merged manually to do the extra adjustments. I did not want to bother anymore with those.
Since INFRA apparently enabled the action now is time to see those auto labels appearing :)


[HOLD for #47984]Copilot – 3-dots menu on Copilot does not response

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to Account settings> Security> Add Copilot
Click on the 3-Dot menu of added Copilot

Expected Result:
3-Dots menu should open
Actual Result:
3-dots menu does not response
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/60fa1c9f-2655-40a4-a375-14b17881f8bc

View all open jobs on GitHub

@johncschuster  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
3-dots menu does not response
What is the root cause of that problem?

We are displaying the three dot as a icon, so click on it do nothing:
https://github.com/Expensify/App/blob/83835702a43ee9299475e406fa7aa10027e05584/src/pages/settings/Security/SecuritySettingsPage.tsx#L103-L104

What changes do you think we should make in order to solve the problem?

We should remove:
https://github.com/Expensify/App/blob/83835702a43ee9299475e406fa7aa10027e05584/src/pages/settings/Security/SecuritySettingsPage.tsx#L103-L104

Add interactive prop to:
https://github.com/Expensify/App/blob/83835702a43ee9299475e406fa7aa10027e05584/src/pages/settings/Security/SecuritySettingsPage.tsx#L94

                interactive: !isEmptyObject(pendingAction)

What alternative solutions did you explore? (Optional)

It should be fixed in https://github.com/Expensify/App/pull/47984

Thanks, @truph01! I've put this one on hold while we wait for that PR.

Still holding

Still holding

Still holding

Still on hold

Still on hold

It looks like the linked PR was just merged. Once deployed we should retest this one.

Looks like the linked PR has been deployed to staging. @IuliiaHerets, can we get a retest on staging to see if this behavior persists?

Asked for a retest

Not reproducible
https://github.com/user-attachments/assets/8e1f6a28-d397-4d96-9d30-e9132e56b07a

Ok! In that case, let's close this one up 👍


Request for double column read mode to identify spread pages to display alone and implement a page offset toggle

需求 / Requirement
I would like the double column read mode to be able to identify spread pages and display them alone as a single page while still displaying two single pages together when reading a gallery before or after a spread page. In addition, I would like a page offset toggle for the double column read mode that will display the first page of a gallery alone while continuing to display the rest of the pages in a double column, unless it is a spread page. The offset toggle will be useful to fix alignment issues when pages are expected to be on a particular side.
建议实现 / Suggested implements
Spread pages can be identified as pages that are wider than they are taller (page width > page height). The offset toggle can be added as a menu bar item, next to the turn page interval button and settings button.  The offset toggle can also be added to settings menu that appears once double column setting is enabled. While in desktop layout, the offset toggle could also be bound to a shortcut key.
备注 / Addition details
examples of similar features can be found in the following places:
on the mangadex.org reader as the offset double spreads button
on the houdoku this feature is implemented as a toggle between three options: offset first page, offset all, no offset
https://github.com/xgi/houdoku
The following link shows example images of how pages may be mis-aligned either due to a spread and a single page appearing together,
or an uneven amount of pages for a given gallery.
https://github.com/xgi/houdoku/issues/171
The various forks of tachiyomi have this feature as the shift one page over button
https://tachiyomi.org/
https://tachiyomi.org/forks/
自查步骤 / Verify steps

[X] 您已仔细查看并知情 常见问题 中的内容 / You have checked Q&A carefully
[X] 您已搜索过 Issue Tracker，没有找到类似内容 / I have searched on Issue Tracker, No duplicate or related open issue has been found
[X] 您确保这个 Issue 只提及一个问题。如果您有多个功能请求，烦请发起多个 Issue / Ensure there is only one feature request in this issue. Please make mutiply issue for mutiply bugs
[X] 您确保已使用最新版本测试，并且该问题在最新版本中仍未实现 / This feature have not supported in latest version

I will implement this by 2 steps maybe in next version:
1、Add a new read setting Always display spread pages alone, if it is ebabled, JHenTai will display them alone as a single page while still displaying two single pages together when reading a gallery before or after a spread page, otherwise  spread page is the same as normal page.
2、Add a new button in top menu bar(with a shortcut key in desktop platform) if double column mode is enabled, users can switch page offset between these two mode, and mode A is used by default.

You can check if that is enough first, and i will check if it is easy to implement.

This looks exactly enough. Thank you for your hard work and fast response.

v7.2.2 has supported Display first page alone, you can use shortcut key 'M' to toggle offset when double column is enabled.
But for display spread pages alone, i have checked houdoku's implemention, it's only aimed at downloaded local gallerys. But JHenTai need to deal with online gallerys, downloading gallerys and downloaded gallerys.

For online gallerys and downloading gallerys, display spread pages alone is impossiable because some images' information is unknown when loading, we don't know their height or width(so we can't identify a image as a spread page). Imagine we want to jump to page 100, we don't know which image should lie at page 100 because we don't know how many spread pages exists before.
For downloaded gallerys , i guess houdoku use all images' information to compute before layout. Maybe i will implement like this later because it may require a lot of work because i have't store images' information now after downloading.

Here is what I believe is the implementation display spread pages alone from the Tachiyomi fork TachiyomiJ2K
https://github.com/Jays2Kings/tachiyomiJ2K
I believe that it also deals with online gallerys, downloading gallerys and downloaded gallerys.
Code regarding a wide image or spread page begins to appear on line 350 starting with a comment. Here, a spread page is referred to as fullPageSpread
https://github.com/Jays2Kings/tachiyomiJ2K/blob/21a2705c724a1251c2e57dce946809ef0c330d7c/app/src/main/java/eu/kanade/tachiyomi/util/system/ImageUtil.kt#L491
Here is another fork of tachiyomi that is called TachiyomiSY which also has display spread pages alone and specifically deals with online gallerys, downloading gallerys and downloaded gallerys from e-hentai and exhentai.
https://github.com/jobobby04/TachiyomiSY/tree/ee47d74b5e2473091a45919aa8c19d75d4176031
The code regarding double-page spread can be found here starting with a comment on line 130
https://github.com/jobobby04/TachiyomiSY/blob/ee47d74b5e2473091a45919aa8c19d75d4176031/core/src/main/java/tachiyomi/core/util/system/ImageUtil.kt#L130
Apologizes for not also including implementation of display spread pages alone by TachiyomiJ2K and TachiyomiSY the first time.

I downloaded TachiyomiSY and found a significant difference with JHenTai: when jumping to 100, TachiyomiSY jumps to 100th image while JHenTai jumps to page 100. Maybe i will change to this mechanism too for double column mode. It's will cost a lot of time because it means maybe i must rewrite double column mode totally. I will try to find a easy way to solve it :)

Thank you. I hope that you find a solution that you are satisfied with.

Basically supported in v7.3.0 and i will optimize later if there're any bugs.


Add renaming for assertFormsetError and assertQuerysetEqual

Description
In #33990 (PR: https://github.com/django/django/pull/16110) the following test methods get renamed for Django 4.2:

assertFormsetError --> assertFormSetError
assertQuerysetEqual --> assertQuerySetEqual

django-upgrade should help to automate these changes.

Thanks for creating an isue! Yeah that seems useful, but I don't think we should add a fixer here until after it's in a release candidate, at least.

@adamchainz Maybe I had too much drive here on the DjangoCon Europe sprint 🏎, so I already created a PR (See #253) as suggested by @carltongibson in the Django ticket.
You might delay merging it.


fix: update mini-accounts, ilp-packet

remove incoming expiry timer

Codecov Report

Merging #19 into master will decrease coverage by 0.24%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   68.59%   68.35%   -0.25%
==========================================
  Files           6        6
  Lines         414      414
  Branches       83       85       +2
==========================================
- Hits          284      283       -1
  Misses         91       91
- Partials       39       40       +1

Impacted Files
Coverage Δ

src/plugins/server.ts
90.47% <ø> (ø)
:arrow_up:

src/plugins/client.ts
75% <0%> (-6.82%)
:arrow_down:

src/account.ts
75.41% <100%> (+0.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20337ba...f9349df. Read the comment docs.


TLS certificate common vulnerabilities

Feature request
Include common TLS certificate vulnerabilities and mis-configurations...
Poor strength ciphers etc...
Wildcard certificates...
POODLE etc...

@c0dewhacker could you please share more information about these issues? Where did you identify them and any scanner that your used? Steps to reproduce if possible?


Disconnecting Github account after signing up with it is odd/buggy

Context
Please explain here below what you were doing when the issue happened
I was performing smoke OB03 on staging and decided to do some extra QA. So you sign-up with the Github button, and get directed to your dashboard. That's OK.  All you'll see is a "Disconnect your Google+ Account". But I don't have a Google account connected, I have a Github account connected!

Furthermore, if you click that option, which I should not be able to because I have not yet set a password, the changes save fine:

Oddly enough, even after disconnecting, I am still able to logout and log back in again. So at least that's not broken.
Steps to Reproduce
Please break down here below all the needed steps to reproduce the issue

Create an account with github login
Go to account settings, see there is no section about github auth but instead one about Google+ (first bug)
Click "Disconnect from Google+" (which is really github and shouldn't be available anyway because you have set no password, second and third bugs) and save changes.

Current Result
Please describe here below the current result you got
See above...
Expected result
Please describe here below what should be the expected behaviour
A github-linked account should talk about "disconnecting from Github" in it's account settings, not Google. Additionally, this should be prohibited if the account has set no password. This expected behavior is present for Google-linked accounts.
Browser and version
What internet browser (Chrome, Firefox, etc) and version was you using and version
Chrome, version 53
Additional info
Please add any information of interest here below
SMOKE_OB03

cc @CartoDB/builder-backend

Thanks for the detailed report Andrew! This is a mix of unimplemented functionality (disconnecting GitHub accounts) and a bug (it shows the disconnect Google instead).

I'm taking over this since I have the time now. Will post updates.

Ok so this is what I gathered:
There is no way of disconnecting a GitHub account from CARTO currently. To fix it we need to increase the level of access required. It might no be worth it. We can forget the Github account id though.
We'd need a design for it in any case.

Ok so I think that this issue if out of scope for now since we don't have a way to disconnect Github accounts and the bugs described can be attributed to misleading UI rather that actual feature bugs.
When product decides we implement this we'll make a ticket for it. Feel free to reopen if you disagree.
Thanks!


GBA Roms don‘t start until restart the OS

I use the latest release of Arkos 1.5. (01052021)
This issue cames after Scraping Covers and install the new Firmware Update
The GBA ROMs only start when I have restarted the device manually.
(Hardware: RG351P)
Sincerly

Is this only after scraping or is it after every boot?

Is this only after scraping or is it after every boot?

I think it’s only After scraping, cuz i can‘t reproduce the error now.
Its works fine now.

I think it’s only After scraping, cuz i can‘t reproduce the error now.
Its works fine now.

It sounds like the system ran low on resources after scraping and a restart was needed to clear things up.  While this doesn’t usually happen, it’s not uncommon either.  Enjoy!

It sounds like the system ran low on resources after scraping and a restart was needed to clear things up.  While this doesn’t usually happen, it’s not uncommon either.  Enjoy!


Don't manage the admin database with puppet

What are you seeing
When working on integration tests with mongodb::server::create_admin=true I noticed prefetch of databases failed.
The error was fixed in the provider, but it bot me thinking 'why do we manage the admin database end not just the admin user?'
I have tried to bring up mogodb 4.4 trough 7.0 without auth, and it seems the admin database is always there.
Given this there should be no reason to manage the database with puppet.

I noticed that creating the admin user fails when auth is disabled, on one hand, I wanted to fix this. On the other, does it even make sense to create an admin user when auth is disabled?

My tought is that if mongodb allows it, this module should too.


feat(conf): add concurrency_timeout option

Summary

Currently, our Kong Gateway used a fixed timeout value (60s) for concurrency jobs.
However, some concurrency jobs may take longer. For example, a declarative config reconfigure case:

Operator pushed config A, and Kong is applying it. This job will take 65s.
Operator pushed config B (e.g. changed a plugin config), and Kong will wait for the job A, but timeout after 60s.
Operator thought config B was applied, but not. The operator went for a cup of coffee.

feat(conf): add concurrency_timeout option
Sets the timeout (in ms) for which a concurrency
job (e.g. declaractive reconfigure) should wait
for mutex before giving up. After the timeout,
Kong gateway would skip the job, and log an error
message.
If you happen to see "timeout acquiring ... lock"
log entries, try to adjust this value accordingly.
Please be careful that setting a large value might
result in a long list of concurreny jobs in queue,
which could overflow the queue.
It is fine to timeout if a job is safe to be
overriden by subsequent jobs, like declaractive
reconfigure. Do not touch this option unless you
clear about it.
Checklist

[x] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #FTI-5969

Duplicate of already closed PR:
https://github.com/Kong/kong/pull/13027

I we want to do something, I would limit the change totally to reconfigure_timeout and call it that. Changing concurrency library default value can have unwanted side-effects elsewhere.


[REVIEW] Awesome Semantic Search

https://github.com/Agrover112/awesome-semantic-search

@eddiejaoude and @nhcarrigan I thought this was fixed?

Interesting, I thought it was too, here was the fix https://github.com/EddieHubCommunity/support/blob/main/.github/workflows/stale.yml#L20

I think my project was reviewed in a live-stream

Reviewing on a live stream https://www.youtube.com/watch?v=w0ELpv3Z4Wk
Looks good, some thoughts:

suggest removing the wiki as it is only 1 page and move it to the readme or docs folder
great to see the project board being used, some items are not converted to issues yet, I suggest being consistent
suggest having the different languages readmes as links at the top of each


Fix vscode config string [phab:D1905]

Created by djrenren at 2017-08-25 20:06:38:
I was reading the wrong value out of the settings store for the vscode plugin. Now,
the settings being read matches the metadata in package.json so help text can be provided

schroederc accepted this revision at 2017-08-25 20:07:42

djrenren closed via commit 1677182a721f0933e0245bcd2c0834a4fc7acd7b at 2017-08-30 22:03:50


Fix incorrect text

Short Description

One part of the texts was incorrect

Changes

Change the text of minimal_investment_income.multiple.yes

Feedback

No feedback needed

Closed because change has been pushed to master already


fix: Revert "feat: Adds the Featured Charts dashboard (#28789)"

This reverts commit 95706d9be2b5414ed496ad762ba1996041429e01.

SUMMARY
Noticed that ephemerals don't have any example data. This reverts the PR that could have caused this in case if we don't find a fix forward before we finish with 4.1
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

In the PR, bring up an ephemeral and verify that examples now show up.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Taking this out of draft state to see if it helps CI pass. If it does (or at least if it gets far enough) I'll spin up an ephemeral to make sure it works as expected :)

/testenv up

Hmm... the epehemeral still doesn't have examples. Maybe this PR isn't the root cause?

Hmm... the epehemeral still doesn't have examples. Maybe this PR isn't the root cause?

hmm weird. @eschutho were there any other changes from that and the 4.1 branch?

hmm weird. @eschutho were there any other changes from that and the 4.1 branch?
Oh strange. That was the one that I reverted from 4.1, but let me see what else might have changed.


Micrometer support

After some reading, research, and experimentation, I've written up what I've found and what I propose for our path forward wrt Micrometer:
https://github.com/oracle/helidon/wiki/Options-for-Micrometer-in-Helidon


fix(json): timestamppb encoding

Reorders the JSONMarshaler's message type assertions so timestamppb types are encoded as strings.
Fixes #59

Closing this PR in favor of rewriting the tests against the existing protos in ./examples.


Tooltips specification and behaviors

From a design review:

After the tooltip is triggered (using a 150ms fade in with the material deceleration curve), keep tooltip displayed for as long as the user is holding the tap.
After the user lifts the tap, keep the tooltip visible for 1.5 seconds
After 1.5s, fade out the tooltip at 150ms, using the material acceleration curve.
Condition: if the user lifts the tap and interacts with the UI before the 1.5s timer has been fulfilled, the tooltip would dismiss immediately upon that interaction be fading out over 150ms using the material acceleration curve. That way the tooltip isn't in the way when they're trying to do something else.
Condition: Lifting and then tapping the tooltip during this 1.5s delay will simply dismiss the tooltip using the same 150ms animation. Tapping anywhere else on the screen will simultaneously dismiss the tooltip AND trigger the action that was tapped.

We need to add a global route to the PointerRouter to implement the first condition.  @Hixie thinks we should dispatch to these global routes after dispatching to the per-id pointer routes.


fix: apply first version of eslint rules

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


UDS+ Test Data Only Testing Method

The current version of UDS+ synthetic testing assumes the one developing and testing the UDS+ product, and the organization submitting the data are the same entity. This is not always the case. An EHR vendor, like Epic, will develop and test their UDS+ product, then deliver that to a health center who will use it to submit UDS+ data.
Can HRSA define some sort of testing only track for EHR vendors to do testing directly with HRSA? We would suggest a test-data only testing environment and less stringent interconnection agreement, as the EHR vender would never actually submit any real patient information.
This would reduce the burden and IT cost on the health centers, as the work of testing and validating would be shifted to the EHR vendor. This way we would not need to stand up any special testing environments with one of our customers to do integration testing.
The way the synthetic testing process is written today, we will need to partner with our customer and build custom test environments on their IT stacks, which is much more work than having the vendor do testing with HRSA directly.
We realize this is a big ask, and a different direction than how the current ISA / synthetic testing process was written. However, we think this is worth having.
We'd expect the yearly updates to the UDS Manual, and any future IG changes, would mean vendors would want to test their updates against HRSA's system yearly.

Ticket will be sent to ONC/HRSA BPHC leadership to discuss.


Unable to create a closed loop line using a single line with RapID V2  (Safari browser)

Description
Unable to create a way and close the loop using a single Way. I click '2' to select 'line,' and attempted to draw a square with four nodes but once I attempt to close the loop, the final result is a 'U' shape with 4 nodes instead of a square, so I have to create another line to close the loop. This issue is noteworthy because it adds extra steps and slows the process of editing the geospatial data using RapID V2.
Version
2.0-alpha
What browser are you seeing the problem on? What version are you running?
Safari v15.6
Steps to reproduce

Click '2' to add a line.
draw a square with 4 nodes
attempt to close the loop by clicking the end-node to the starting-node
the final result is U shape with 4 nodes

The browser URL at the time you encountered the bug
https://mapwith.ai/rapid-v2-alpha#background=Maxar-Premium&datasets=fbRoads,msBuildings&disable_features=boundaries&map=21.32/-18.95730/49.10903

Yea, this is an interesting chicken-and-egg problem where - when the user enters Draw Line mode and is about to start drawing the line, there is nothing to select.  Once the user starts drawing the line, the rendering code doesn't realize that the new line should be selected.  That's what it needs in order to actually draw the child vertices, including the ones at the beginning/end that you'd need to click on to complete the line.
This worked differently in v1 because the information about "what is selected" lives with the current mode, and the mode would change constantly as the user draws more pieces of the line, and the "selected" state was updated just by css classing the line.

I have included a new state in the renderer scene called 'drawing'- if the scene contains ways or nodes that are in the midst of being drawn, we always show their vertices no matter what. This allows for the correct snapping behavior.
Also, we were correctly checking for whether we were clicking on the original node in the way, but then utterly failing to actually update the way with that final node location. This meant that id you drew a box, you'd end up with a 'U' shape instead. :-p
Fixed in f54831dab.


Support max_read mount parameter

Closing since it sounds like this in deprecated: https://github.com/libfuse/libfuse/blob/ba3b225a126ebb3c6d4fe27c9f7c73aa4167001e/include/fuse_common.h#L446

Closing since it sounds like this in deprecated: https://github.com/libfuse/libfuse/blob/ba3b225a126ebb3c6d4fe27c9f7c73aa4167001e/include/fuse_common.h#L446


Fix value for THAMOS_RUNTIME_ENVIRONMENT

Signed-off-by: Francesco Murdaca<EMAIL_ADDRESS>2022-02-23 08:49:37,058 [34] DEBUG    thamos: Debug mode turned on
2022-02-23 08:49:37,058 [34] DEBUG    thamos: Thamos version: '1.20.0'
2022-02-23 08:49:37,062 [34] WARNING  thamos.lib: Development dependencies will not be installed - see https://thoth-station.ninja/j/no_dev
2022-02-23 08:49:37,063 [34] CRITICAL root: Traceback (most recent call last):
  File "/opt/app-root/bin/thamos", line 8, in <module>
    sys.exit(cli())
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/opt/app-root/lib64/python3.8/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/app-root/lib64/python3.8/site-packages/thamos/cli.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/opt/app-root/lib64/python3.8/site-packages/thamos/cli.py", line 335, in install
    thamos_install(
  File "/opt/app-root/lib64/python3.8/site-packages/thamos/lib.py", line 1078, in install
    with cwd(thoth_config.get_overlays_directory(runtime_environment_name)):
  File "/opt/app-root/lib64/python3.8/site-packages/thamos/config.py", line 670, in get_overlays_directory
    runtime_environment_config = self.get_runtime_environment(
  File "/opt/app-root/lib64/python3.8/site-packages/thamos/config.py", line 449, in get_runtime_environment
    raise NoRuntimeEnvironmentError(
thamos.exceptions.NoRuntimeEnvironmentError: No runtime environment with name '""' was found in the configuration file; configured runtime environment names: ubi8

error: build error: error building at STEP "RUN /tmp/scripts/assemble": error while running runtime: exit status 1

I tested already @harshad16 and the image was created with this fix.


Problem flashing ASUS Chromebook Flip CR1100FKA

Hi folks,
I am trying to install Linux on an ASUS Chromebook Flip CR1100FKA. After successfully running the script, I have the alternative boot loader Tiancore available, but unfortunately not the legacy loader SeaBIOS. I am not sure if it is normal to have the UEFI BOOT loader installed when the BIOS boot loader should be installed? Can you give me some hints on how to debug this further?
Thanks in advance
Harm

there is no problem, newer boards/platforms no longer support booting SeaBIOS, so they use Tianocore as the AtlFw bootloader


Handle multiple subscriptions

There can be multiple subscription per operator, which wasn't handled correctly when getting namespaces, and broke must gather results (missing logs)
ECOPROJECT-1751

/lgtm

/lgtm


number of i2c handles

Is there a compelling reason for limiting the maximum number of I2C-handles to 64 and if not, could it be increased (e.g. to 512)? I have a situation where this becomes limiting (a modular construct where each of the up to 48 modules with up to 10 I2C-devices receives its own I2C-bus via 6 TCA9548 muxes). I can program my way around this limitation but it would be nicer if I didn't have to
Beat
PS: Thanks for pigpio which is just wonderful!

I'm looking into implementing the I2C APIs in a client and found it a bit odd that not every device address on a bus could be reached without exhausting the handle resources.  Without impacting the current APIs or the user code built on them, would it be possible to add a new API that allows changing the address on the same handle?  Something like i2cAddress(handle, addr).

Frankly I never expected there would be a use for so many handles.  Anyhow it's something people seem to request quite often so I'll accept the demand and increase the slots to 512.
Unless someone wants a larger number?

Additional handles are not necessary and would consume more memory.  A single client/context can safely share the same handle.  What is needed is a method to change the I2C_SLAVE address on the current handle.
I would be willing to provide a PR to add the API to the Python client, pigpio.c and pigs (and anything else that is impacted) if you agree.  Of course this will take me a few weeks and I may need your guidance.

I really don't see that the effort of creating a PR would be worthwhile.  Changing the number of I2C slots uses an extra 7k bytes of memory which is trivial compared to the effort of doing anything else.
@guymcswain I have little time to devote to pigpio.  I am quite happy to add you as a collaborator which would allow you to steer pigpio in any direction you want.

@joan2937 Allow me some time to give you a more thoughtful response but in general I would be happy to help you maintain this wonderful repository.  I would feel uncomfortable, however, to steer in any direction without you providing some guiding principles or vision.  Thank you.

Fixed in version V73.


Maintaining?

Hi,
If you don't mind can i officially take over this project and maintain it?
Of course u will get your credits.

I would also suggest this project be renamed pytorch-js


[controller] reset Device state for usage in accessories

Problem
The controller::Device class is currently tightly assuming the device state and forcing a commssion flow starting from PASE.
Change overview
Reset the state in OperationalCertProvisioned so that we can call this function to start from CASE.
Testing
How was this tested?

CI build and unit tests.

@msandstedt The change follows our discussion in https://github.com/project-chip/connectedhomeip/pull/9103. Though it's kind of hack it unblocks us.
@mspang @andy31415 PTAL.

I had offline discussion with Tennessee and here is his comments:

I think you misunderstood Michael's comment
My point in the original comment is that reimplementing Device with subset functionality for each example is problematic
Separate from that I agree with Michael's points but I would say that just hacking the PASE state machine is not quite right. I agree with Michael that changes are few. Since I do not have much time this week, I suggest you work with Spang and Michael on resolution. I think the interaction peer change also was helpful, and overall, we will need to incrementally "separate" device/controller but we have to unblock device to device. I just want to make sure we dont make too many "compromise" changes that make the final solution hard to maintain (that is, as hard or harder to maintain than the problematic code we have now)

Personally I believe the delegate class https://github.com/project-chip/connectedhomeip/pull/9103 is not an elegant solution.
The correct way out is to remove Device class from our controller generated code and use InteractionModelEngine as the only entrypoint to send ZCL or BDX messages. We'll add another class to manage the pairing process and setup the symmetric  credentials.
This approach requires rewriting a large amount of code. As an unblocker, this hack looks quite acceptable compared to https://github.com/project-chip/connectedhomeip/pull/9103. If we are using a temporary solution anyway, I'll prefer a smaller change.

Personally I believe the delegate class #9103 is not an elegant solution.
The correct way out is to remove Device class from our controller generated code and use InteractionModelEngine as the only entrypoint to send ZCL or BDX messages. We'll add another class to manage the pairing process and setup the symmetric credentials.

InteractionModelEngine is for the IM, which is a layer above Message Layer. BDX is a protocol handler that does not relate  at all to IM. I disagree that InteractionModelEngine should be the entrypoint for everything.

While a 1 line change, what test failed? What is this fixing? What new test is added to confirm that this doesn't regress?

Unit test added. It's testing calling EstablishConnectivity after manually calling OperationalCertProvisioned. We'd expect a CASE session to be setup in this case. Before the change it will report ERROR_INCORRECT_STATE.


Endoc 167 document cli

This is pushed to staging now. I have more to do on this ticket but at least this shows the direction. https://entando.github.io/entando-docs/next/docs/reference/entando-cli.html is the main CLI page and I've reworked the initial jhipster page to leverage it https://entando.github.io/entando-docs/next/tutorials/backend-developers/generate-microservices-and-micro-frontends.html.

@joewhite101 and @w-caffiero-entando This is ready for review. The big gap for ENDOC-167 is what to document about the ent bundler itself but that will be its own PR.

@joewhite101 , good to know, thanks.


png output returns a png with png written on it

Here is a screenshot from the readme of it:

Here is the exact image any location I try produces:

This started yesterday, as far as I am aware.

Fixed! Thank you for reporting


How do I use Flipper with Renative?

How do I use Flipper with Renative? There is no mention of it in the docs and Renative obscures the setup in the official documentation: https://fbflipper.com/docs/getting-started/react-native-android/
I am using Renative version 0.35.4

I think we will need react-native-tvos engine to add the support. I think the maintainer of that repo has tried pretty hard to get it set up for us there.
https://github.com/react-native-tvos/react-native-tvos/issues/293

We'll have to create a plugin for it, since it needs native code injections. It would need something similar to this

Thanks for the reply @mihaiblaga89, I think this would be a huge enhancement to Renative.

1.0.0-rc.18.
Flipper can be configured in renative. json via flipperEnabled property, by  default it is enabled for android based platforms and ios.  For tvos is flipper  disabled because  it has a lot of dependencies that are built for iOS only.

Closing as answer has been provided, feel free to reopen if needed


Add schema for new DMN records

With Camunda 8.0, there are three new records available for DMN: decision, decision requirements (i.e. DRG), and decision evaluation.
We should support the new records to enable exporting and consuming of them.

@saig0 I will take a look at it

@saig0 please check #176


extract-bc doesn't create .bc file

I compiled a program using wllvm.
Using extract-bc to create .bc file, but it doesn't work.
It doesn't show error message.
Any have idea this problem?

Not without more details. What does the sanity checker say?

I resolved this problem. I used python2 and it doesn't works.
It works using python3.

Should work with either. Can you show me it not working for python 2?


change dateformatter

hi
how can change date formatter to jalali and change style number ??
thanks for help ??

Have you looked at the tutorial?
CellView.xib

Changing the font
Go there and change the font of the text to what ever you want.

Changing the date formatter
Look at the delegate setup function
func configureCalendar(calendar: JTAppleCalendarView) -> (startDate: NSDate, endDate: NSDate, calendar: NSCalendar)
You provide you own calendar in there. Setup the calendar to what ever you want it to be.

sorry i want change month name ? but i can not change ??

 You can the sign the CellView.xib however you want.

yes

Damn!  that calendar looks awesome!! Hey, can you post up your calendar picture on this link? I want other people to see the cool stuff they can do with it. --> https://github.com/patchthecode/JTAppleCalendar/issues/2

So have you found a solution to your question now? Or do you still need help

Hey, if you are able to build your calendar, can i use your image as an example in my documentation?

yeah .sure

Cool. when you are finished with you. You can upload the image here -> https://github.com/patchthecode/JTAppleCalendar/issues/2


Changing profile photo creates unneeded/unwanted duplicates in clones photo album.

From @Gadget-Guru on December 19, 2013 4:35
Each time a profile photo is changed on any hub, either existing or new upload, an additional duplicate is created in all the other clones photo albums. If you switch back to one of the existing profile photos, another duplicate is created. Since changing the profile photo on one hub doesn't automatically change it for the clones, the result is an annoying amount of multiples being created when visiting each clone to make the change.
When clicking on these duplicates from the clone while using Enhanced Photo Albums, the following message is displayed: "Image cannot be loaded. Make sure the path is correct and image exist."
I think we need the profile photo for clones to change automatically when changing it for the primary, but if that's not possible at this time, we should at least stop creating multiples for clones.
Copied from original issue: friendica/red#247

@Gadget-Guru This issue is closed because Redmatrix evolved into Hubzilla. When this is still an issue in the most recent version of Hubzilla, please recreate this issue over there. We're sorry for any inconvenience this will maybe give you.


Executable fails if project was never opened in Godot

Steps taken:

Install prerequisites
clone git
./build.sh
./Godot_v3.5.1-stable_x11.64

Crash log:
log.txt
After opening the project in Godot and re-running build.sh, the executable runs without crashing.

I don't use that build script anymore.


Operation guide

Hello，sir! I am learning the OFDM communication system ,and I download your MATLAB program, but I can't operate it. I will get an error after running. Can you provide an operation instruction?Thank you!

Hi! for some code is in old version of matlab, if anyone still do want to learn and run all of it  ,you need to add some old function files or change the use of them, i think.


feat(localizations): Add spanish localization

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[x] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x ] npm test runs as expected.
[x] npm run build runs as expected.

Adding Spanish (Spain) localization :)

Many thanks for the submission @waldothedeveloper - it's always awesome seeing the community contribute to the repo :)

My pleasure Nikos! Happy to contribute to such a fantastic auth tool! Kudos to the entire Clerk team!


Update to latest release-1.4 SHA for istio.io/pkg to get better HTML rendering for commands.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio_release-1.4
92a2f6633baf8dd71c0173d3a347e31b94d27330
link
/test e2e-simpleTests-distroless_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Back-port from convergence: fixups to module importing for custom pac…

…kage

Assuming this PR has been well tested.


Add a fixture/test for yarn 4

Moves yarn-3-pnp-nonzero to yarn-4-pnp-nonzero, so that we have a yarn 4 fixture and test, now that yarn 4.0.0 is released: https://yarnpkg.com/blog/release/4.0.

@joshwlewis why change the yarn 3 test to yarn 4 instead of keeping the yarn 3 one and adding a new yarn 4 one?

@colincasey there were two yarn 3 tests already, and we've already got the entire matrix of zero/nonzero pnp/modules cases covered. Was trying not to grow the list of integration tests.

@colincasey I've changed my mind, since the yarn 4 work had some surprising breakages. I've added the yarn 3 test back in and also added another yarn 4 test.


Windows 10 / git-bash issue

I have the following error whn trying to use crossterm-powered app from git bash on Windows 10:
$ app.exe
Getting mode failed
Error: The handle is invalid. (os error 6)

I'm running the app with elevated permissions (as admin).

Are you running the key_events example? Because I see the error happing there

The windows console functions only work on windows consoles, Git Bash is MinTTY which is not a Windows console and thus it fails to execute some WinAPI functions.

Yes, I think that's the situation: I was running my cli app under git-bash, and it's utilizing MinTTY. The tricky thing it it's not known at compile time inder which console the user will be executing the app, so I'd expect the windows compile target to support CMD, PowerShell and MinTTY, as well as new ConPTY interface. I understand that's not what crossterm currently provides.

Most of the functionalities are working in gitbash tough, only functionalities that are really platform specific like input, cursor position, terminal-resize won't work. Styling, cursor movement and such should still be working because git bash supports ANSI escape code which crossterm tries to use before going over to WinAPI, this check is done at run time.
Currently, crossterm can detect if the console is a console that supports WinAPI, that's why it uses ANSI codes on Windows 10 and git bash.  However, as said above reading input is a platform specific thing, on UNIX libc is used and for Windows, WinAPI is used. There is no such thing as reading input with ANSI codes.
I will see if there are ways to work around this.

Cool, thanks!
I really needed just a simple menu, maube there's a way to implement it less playform-dependent way?
My code in particular that's causing the issue is here: https://github.com/MOZGIII/rebootinto/tree/master/tui

Your link is the root of the project :), where is the issue specifically caused?

The relevant codepath is here:
https://github.com/MOZGIII/rebootinto/blob/ceb8e37516dbb54b960508c53bd63ca7cecc9ff1/tui/src/main.rs#L34-L54
ui.run:
https://github.com/MOZGIII/rebootinto/blob/ceb8e37516dbb54b960508c53bd63ca7cecc9ff1/tui/src/ui.rs#L32-L82

Overall the app is extremely trivial, it initializes it's "core backend" (implements app's "payload", not relevant for the issue) and the it goes directly to the UI rendering. I'm using tui, and I have a layer that allows me switch tui backend (as well a input abstraction backend) at compile time. I had to experiment with different tui backlend to see if other implementation have the same issues. Btw the terminus from the PR with windows support behaves the same way as crossterm, both with git-bash and that other powershell issue that I had. I'm now thinking this may be a tui issue.

Closing in favor of https://github.com/TimonPost/crossterm/issues/168