Avatar spoofing not working with Slack when following documentation

Describe the bug
With a local mediaserver setup and validated along with webhooks enabled, avatars are not being displayed from Telegram to Slack.
My matterbridge.toml
[general]
MediaDownloadPath="/var/www/matterbridge"
MediaServerDownload="http://{redacted}/media"

[slack]
[slack.collidervc]
RemoteNickFormat="{LABEL} | @{NICK}"
MessageSplit=true
WebhookUrl="secret-in-env-file"
Debug="true"

[telegram.Telegram]
Token="secret-in-env-file"
RemoteNickFormat="({PROTOCOL}) {NICK} "
MessageFormat="HTMLNick"
EditSuffix=" (edited)"
Label="Telegram | Testing Relay"
MessageSplit=true

[[gateway]]
name="gateway1"
enable=true

[[gateway.in]]
account="telegram.Telegram"
channel="-572179530"

[[gateway.out]]
account="slack.collidervc"
channel="collider-bot-testing"

I have validated that avatar PNGs are being downloaded to /var/www/matterbridge and I have also validated that they are publicly available from the MediaServerDownload url.
Here are my logs from matterbridge which show the dowload is successful but Avatar is still empty
time="2021-07-27T10:45:06Z" level=debug msg="Trying to download "1843720526.png" with size 3373" func=HandleDownloadSize file="bridge/helper/helper.go:159" prefix=telegram
time="2021-07-27T10:45:06Z" level=debug msg="Download OK "1843720526.png" 3373" func=HandleDownloadData file="bridge/helper/helper.go:175" prefix=telegram
time="2021-07-27T10:45:06Z" level=debug msg="<= Sending message from Collider on telegram.Telegram to gateway" func=handleRecv file="bridge/telegram/handlers.go:173" prefix=telegram
time="2021-07-27T10:45:06Z" level=debug msg="<= Message is config.Message{Text:"test", Channel:"-572179530", Username:"Collider", UserID:"1843720526", Avatar:"", Account:"telegram.Telegram", Event:"", Protocol:"", Gateway:"", ParentID:"", Timestamp:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}, ID:"80", Extra:map[string][]interface {}{}}" func=handleRecv file="bridge/telegram/handlers.go:174" prefix=telegram
time="2021-07-27T10:45:06Z" level=debug msg="mediaserver path placing file: /var/www/matterbridge/bb735cc0/1843720526.png" func=handleFilesLocal file="gateway/handlers.go:158" prefix=gateway
time="2021-07-27T10:45:06Z" level=debug msg="mediaserver download URL = http://{redacted}/media/bb735cc0/1843720526.png" func=handleFiles file="gateway/handlers.go:112" prefix=gateway
time="2021-07-27T10:45:06Z" level=debug msg="=> Sending config.Message{Text:"test", Channel:"-572179530", Username:"Collider", UserID:"1843720526", Avatar:"", Account:"telegram.Telegram", Event:"", Protocol:"telegram", Gateway:"gateway1", ParentID:"", Timestamp:time.Time{wall:0xc03816cc8ef21770, ext:487920212311, loc:(*time.Location)(0x339f980)}, ID:"80", Extra:map[string][]interface {}{}} from telegram.Telegram (-572179530) to slack.collidervc (collider-bot-testing)" func=SendMessage file="gateway/gateway.go:479" prefix=gateway
time="2021-07-27T10:45:06Z" level=debug msg="=> Receiving config.Message{Text:"test", Channel:"collider-bot-testing", Username:"Telegram | Testing Relay | @Collider", UserID:"1843720526", Avatar:"", Account:"telegram.Telegram", Event:"", Protocol:"telegram", Gateway:"gateway1", ParentID:"", Timestamp:time.Time{wall:0xc03816cc8ef21770, ext:487920212311, loc:(*time.Location)(0x339f980)}, ID:"", Extra:map[string][]interface {}{}}" func=Send file="bridge/slack/slack.go:195" prefix=slack
time="2021-07-27T10:45:06Z" level=debug msg="=> Send from telegram.Telegram (-572179530) to slack.collidervc (collider-bot-testing) took 260.931679ms" func=func1 file="gateway/gateway.go:488" prefix=gateway

I have sent multiple chats from different users to wait for the avatar to download, but still nothing is displayed
I'm also a bit confused as per slacks documentation: You cannot override the default channel (chosen by the user who installed your app), username, or icon when you're using Incoming Webhooks to post messages. Instead, these values will always inherit from the associated Slack app configuration.
To Reproduce
Steps to reproduce the behavior: use setup as above
Expected behavior
Avatar to display from Telegram to Slack when Mediaserver is present
Screenshots/debug logs

Environment (please complete the following information):

OS: Running matterbridge via docker on a Linux VM
Matterbridge version:  1.22.4-dev da4dcec1

Could be that slack changed/deprecated this.
Can you try with adding a static IconURL ? like
iconurl="http://{redacted}/media/bb735cc0/1843720526.png" to your [slack.collidervc] config?

@42wim tested with above and manually setting the iconurl works in slack. When I removed that config they stopped showing.
Is there any other logs or config I should share to see what's going on?

When iconurl was set it was present in the request in chat.go:233
Now that it's removed it's not adding any url for the icon even though my mediaserver is setup and the users have icons
slack-go/slack2021/08/02 10:35:17 users.go:354: GetUsersContext: got 45 users; metadata { [] []}
slack-go/slack2021/08/02 10:35:42 chat.go:233: Sending request: blocks=%5B%7B%22type%22%3A%22section%22%2C%22text%22%3A%7B%22type%22%3A%22mrkdwn%22%2C%22text%22%3A%22removed+manual+icon%22%7D%2C%22block_id%22%3A%22matterbridge_c43skora0v1vioqhme2g%22%7D%5D&channel={redacted}&link_names=1&text=removed+manual+icon&token=xoxb-{redacted}&unfurl_links=true&username=Telegram+%7C+Testing+Relay+%7C+%40Brian
slack-go/slack2021/08/02 10:35:42 websocket_managed_conn.go:387: Incoming Event: {"type":"message","subtype":"bot_message","text":"removed manual icon","suppress_notification":false,"username":"Telegram | Testing Relay | @Brian","bot_id":"B027R3HH2FK","team":"TBCBBPCRE","bot_profile":{"id":"B027R3HH2FK","deleted":false,"name":"ColliderRelayBot","updated":1626785964,"app_id":"A0279CNSQLD","icons":{"image_36":"https:\/\/a.slack-edge.com\/80588\/img\/plugins\/app\/bot_36.png","image_48":"https:\/\/a.slack-edge.com\/80588\/img\/plugins\/app\/bot_48.png","image_72":"https:\/\/a.slack-edge.com\/80588\/img\/plugins\/app\/service_72.png"},"team_id":"{redacted}"},"blocks":[{"type":"section","block_id":"matterbridge_c43skora0v1vioqhme2g","text":{"type":"mrkdwn","text":"removed manual icon","verbatim":false}}],"source_team":"{redacted}","user_team":"{redacted}","channel":"{redacted}","event_ts":"1627900542.001000","ts":"1627900542.001000"}

@42wim I'm really glad to look into this myself. Wondering if you have any inclines on what or where the issue might lie?
I know that Telegram only downloads avatars if a Media Server is present (See here). I've confirmed that the avatar gets downloaded to my Media server, and that the path to the Icon is publicly available on my server. What I'm not seeing is the avatar url present in the slack message.
Any pointers appreciated, happy to do the work on my end and put up a PR


2.20.2 introduces a breaking change/bug.

I have a repro for this here:
https://github.com/dwjohnston/eslint-import-order-repro
On a file like this:
import foo from '.'
import bar from '..'

console.log(foo, bar)

On version 2.20.1 this is valid, but on 2.20.2 this will give
`..` import should occur before import of `.`eslintimport/order

This is an intentional change made in https://github.com/benmosher/eslint-plugin-import/pull/1658 . It is a bug fix that introduces more warnings. According to https://github.com/eslint/eslint/blob/master/README.md#semantic-versioning-policy it belongs to a minor release.

Fair that it perhaps should have been a minor.
However, I'm releasing a v2.21.0 shortly, so i'd rather roll forward than backwards.


chore: enable network thread

Motivation
Enable network thread and batch attestation work, if it works well this is a candidate to release v1.11
Description
Please confirm this is not an issue anymore (on feat3) mainly on the test mainnet #5604 and we have all good metrics in #5896
Closes #5604

Metrics look good, please review on feat3
rss increased and got stablized at ~8.2GB (but it was up to 9GB in my old branch), this is from the test mainnet node

The below is max rss of unstable vs this branch

number of validators per node
unstable
this branch

mainnet - no validator.
6.3GB.
8.2GB.

goerli - 1k
5.3GB.
6.6GB.

goerli - 16.
5.3GB.
6.8GB

goerli - 64.
5.2GB.
6GB.

goerli - 1.
5.4GB.
6.2GB.

goerli - no validator.
5GB.
6GB.

so it's ~2GB increase on a test mainnet node subscribing to all subnets cc @philknows

LGTM. At least we will be a better network peer for an additional 2GB of memory. Great work!


Train SegNet

Hi @zijundeng and everybody,
First of all, thank you for your codes. I am a very beginner in semantic segmentation area.
I want to run your codes using SegNet model, but I didn't find the "train.py" for SegNet. Then, I simply try to modify "train.py" from folder "train/cityscapes-psp_net" and change the net in line 42.
from : net = PSPNet(num_classes=cityscapes.num_classes)
to be : net = SegNet(num_classes=cityscapes.num_classes)
But, I found this error and still cannot solve the problem.
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 1. Got 31 and 32 in dimension 2 at /opt/conda/conda-bld/pytorch_1525909934016/work/aten/src/THC/generic/THCTensorMath.cu:111
Please, kindly your suggestion.
Thank you.

It seems that two feature maps mismatch in the "height" dimension. You can
use " torch.nn.functional.upsample" to make sure that the two feature maps
are in the same spatial size.
Best regards,
Zijun
muralabmahmuds<EMAIL_ADDRESS>于2018年8月21日周二 下午4:44写道：

Hi @zijundeng https://github.com/zijundeng and everybody,
First of all, thank you for your codes. I am a very beginner in semantic
segmentation area.
I want to run your codes using SegNet model, but I didn't find the
"train.py" for SegNet. Then, I simply try to modify "train.py" from folder
"train/cityscapes-psp_net" and change the net in line 42.
from : net = PSPNet(num_classes=cityscapes.num_classes)
to be : net = SegNet(num_classes=cityscapes.num_classes)
But, I found this error and still cannot solve the problem.
RuntimeError: invalid argument 0: Sizes of tensors must match except in
dimension 1. Got 31 and 32 in dimension 2 at
/opt/conda/conda-bld/pytorch_1525909934016/work/aten/src/THC/generic/THCTensorMath.cu:111
Please, kindly your suggestion.
Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zijundeng/pytorch-semantic-segmentation/issues/46,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWj5K8Fi4nacqTK9Wj750LIOYzKgfFOKks5uS8hegaJpZM4WFWSV
.

Dear @zijundeng Thank you for your kind reply.
I am searching about "torch.nn.functional.upsample" but I still could not understand how to use it and where should I put it to solve my above problem.
Would you give an example of how to follow your suggestion regarding "torch.nn.functional.upsample", please?
Thank you very much!


Eliminated method useIsEqualToInsteadOfIsSameAs() from AbstractSeqTes…

…t class and prepared code for elimination this method from related classes: ArrayTest, HashSetTest, ListTest, QueueTest, StreamTest and VectorTest

Codecov Report

Merging #2170 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2170   +/-   ##
=========================================
  Coverage     97.47%   97.47%
  Complexity     5260     5260
=========================================
  Files            92       92
  Lines         12027    12027
  Branches       1582     1582
=========================================
  Hits          11723    11723
  Misses          148      148
  Partials        156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4273847...e3d0436. Read the comment docs.

@danieldietrich, @valery1707 Could you please look at changes I've made?

Many thanks, also to the reviewers! Good work.


Text Sets: Lists

Summary
Updates content in list text sets
Relevant Technical Choices

To-do

User-facing changes
Content on lists in text sets should match figma: https://www.figma.com/file/NHHMwIfxMnz39NxqkrFb7R/Stories---Post-Stable?node-id=2%3A35243
Testing Instructions
Verify content on lists matches figma

Addresses #4903

The only thing I see here is the plus signs might need to be more center aligned (looks like -2) does the trick.

The only thing I see here is the plus signs might need to be more center aligned (looks like -2) does the trick.

Great catch, should be fixed!


[FEATURE REQUEST] Add manual connect_notify_local method to glib::SignalGroup

Currently to listen to notify signals of the properties of the target object of a glib::SignalGroup, we are forced to use the regular connect_local, which is a bit annoying. It would be cool to have a connect_notify_local to make things simpler to use.

More info here: https://github.com/melix99/telegrand/pull/462#discussion_r1108776250

Do you want to provide a PR for this?


[SPARK-29601][WEBUI] JDBC ODBC Tab Statement column provide ellipsis for big SQL statement

What changes were proposed in this pull request?
Provide Ellipses in Statement column , just like description in Jobs page .
Why are the changes needed?
When a query is executed the whole query statement is displayed no matter how big it is. When bigger queries are executed, it covers a large portion of the page display, when we have multiple queries it is difficult to scroll down to view all.
Does this PR introduce any user-facing change?
No
Before:

After:

How was this patch tested?
Manual

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@srowen @wangyum  Could you review this PR?

@srowen i have done the changes.Could you review?

Test build #4916 has started for PR 26364 at commit bcaa83e.

Test build #4916 has finished for PR 26364 at commit bcaa83e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master


Update thumbnail photo sync description

Image API team introduced changes to the sync and we want to reflet it in the documentation

@billmath
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


SlipLink cannot be created. Bad format.

Thanks for the great introduction. I just tried it. But I get an error when I want to shorten URLs "SlipLink cannot be created. Bad format.". Any advice for me?
Regards,
Ramón

Can you show me the format of the link you are trying to add. Both the shortlink and the target?

Interesting, it worked fine for me.

Did you, by chance, change the regex for the post validation? Found here: https://github.com/aws-samples/amazon-api-gateway-url-shortener/blob/master/api.yaml#L356

No, we haven't changed anything...

Hey @websenat sorry for the delay. I have been unable to recreate the issue. My recommendation is to loosen or remove the regex to see if there is still an issue.

Closing due to inactivity, please re-0pen if there are still issues.

Sorry for the delay.
So we have now rebuilt the complete URL Shortener again and changed the ReEx schema to "^http.*" before the build, i.e. everything that starts with http is valid. still does not work.
The error is the same.
Thanks for support,
Ramón

Has there been any progress on this?  I'm having the same issues as the OP on a fresh installation.


[firebase_admob] Support the v2 Android embedder plugins API

@amirh
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/320. Any further collaboration will be done there.

To avoid confusing with project https://github.com/flutter/flutter/projects/59 this issue will remain open here till resolved.


Fixes issue 288

r? @vinipsmaker
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Fix incorrect docs in remote API for the option of SecurityOpt

This fix tries to fix the issue in remote API docs for v1.15 (Docker 1.3.x) and v1.16 (Docker 1.4.x) where SecurityOpts was used but the actual field should be SecurityOpt.
This SecurityOpt field is verified through the source code in v1.3.0 and v1.4.0:
https://github.com/docker/docker/blob/v1.3.0/runconfig/config.go#L35
https://github.com/docker/docker/blob/v1.4.0/runconfig/hostconfig.go#L98
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

LGTM

LGTM


Feat/int test gutenberg

This PR adds resolver integrity integration tests by making similar GraphQL requests to Gatsby & WPGraphQL and comparing the results. wp-graphql-gutenberg is used as a testing schema here to help cover more types of fields and also ensure wp-graphql-gutenberg works properly with this plugin.
Along the way I found and solved 2 bugs:

Fields that are encoded JSON were being parsed for Gatsby images which shouldn't be happening (so this PR fixes #149)
The WPGQL Node type is an interface type of all possible WPGQL node types. Since not all of those are Gatsby node types, fields of this type were not being registered properly as Gatsby node connections. This PR adds a check to the default resolver to see if a connected node exists as well as adding the __typename field to all interface fields during query generation and node sourcing.

Published in<EMAIL_ADDRESS>


Replace as reset

I was reading some code, and wondering why the author was using Map<String, Metric> every place instead of MetricSet, and I finally realized it was because he couldn't use register/registerAll because he was permitting "resets" by doing replacements. Like so:
for (Map.Entry<String, Metric> entry : metrics.entrySet()) {
    String metricName = entry.getKey();
    Metric metric = entry.getValue();
    try {
        registry.register(metricName, metric);
    } catch (IllegalArgumentException e) {
        synchronized (registry) {
            registry.remove(metricName);
            registry.register(metricName, metric);
        }
    }
}

I can tell from the issue history that there's been some contention around the idea of Metric.reset(), but I wonder if this approach might provide a path for that. That is, by providing a set of APIs like registry.replace and registry.replaceAll that are semantically similar to registry.register and registry.registerAll, but never throw the IllegalArgumentException, instead binding the existing name to a new Metric instance.
Anything that already had a reference to the old Metric would still have it, but as long as the Reporters weren't some of those things, that's pretty close to a universally applicable reset operation.

Hi @randomstatistic, I was wondering of this solution too.
If to reset the metrics upon any time a reporter reports (assume a single reporter only for now), simply remove the metric from the registry as well (that is, inside the report(..) method of a reporter).
And then anyone asking for the same metric using the name would get a new metric and hence in a way we successfully reset the metric.
But the danger is as you said:
"Anything that already had a reference to the old Metric would still have it"
which seems likely right? and hence causing the reporter to miss the updates?
since someone could be updating a metric which actually doesn't exist in the reporter now.


LuckPerms-Bungee Crash/PermissionCheckEvent

My server runs fine for a few hours, however; after those few hours we start to get some errors. Eventually after a while it crashes.
Here's the errors: https://pastebin.com/yMShTZXn

https://pastebin.com/1qa7gB9V
Here's another one. Could someone please help?

A few questions:
Are you running a cracked server?
Are you running a server network with Bungee?
If so, what database and messaging service have you set up?
Feel free to respond on the discord, just let us know who you are and be ready to link this page!

A few questions:
Are you running a cracked server?
Are you running a server network with Bungee?
If so, what database and messaging service have you set up?
Feel free to respond on the discord, just let us know who you are and be ready to link this page!

Are you running a cracked server? No
Are you running a server network with Bungee? Yes those are from the Bungee
If so, what database and messaging service have you set up? MySQL/phpMyAdmin
I already tried contacting on discord and I was directed here. Could you maybe speak to me personally on discord? Riley#2020

The exception messages posted above are triggered when a plugin checks for a permission on a player which LuckPerms doesn't have any loaded data for.
This can occur:

When other plugins alter UUIDs during or sometime after the login process
When other plugins check for permissions after a player disconnects from the proxy
If due to some bug, LuckPerms unloads data for a user prematurely, or doesn't load any data in the first place.

However, the errors above don't give much of an indication as to which of these it is.
The whole proxy crashing is different to those exceptions being printed - I'd need to see the crash log to comment further on that.
You full log file might prove more useful in finding the issue.

I've also made the logging a little less verbose: c71742a996473d11582256133d935448f417099f

Good to know that BungeeChat is not the only plugin "causing" these errors. So @FisherGee I think it should be absolutely clear that it's not a BungeeChat issue.

Good to know that BungeeChat is not the only plugin "causing" these errors. So @FisherGee I think it should be absolutely clear that it's not a BungeeChat issue.

I removed BungeeChat though and I haven’t seen any of those errors yet. I’ll keep you updated.

Your full log file might prove more useful in finding the issue.

That's why Luck closed the issue btw.

I've made some commits to hopefully fix this.
Please test and let me know :)

I've made some commits to hopefully fix this.
Please test and let me know :)

Thanks, however; we just removed BungeeChat and that seemed to do the trick.

Apparently it's fixed soooo, gonna close.


Hotfix: Overide getExtras Method with placeholder

This is a fix that was discussed in https://github.com/react-native-toolbar-android/toolbar-android/issues/57 and was originally presented by @the-smart-home-maker
I just whipped it into a pr. This is currently breaking for me as well and i don't want to resort to editing code after yarn install
Not quite sure how these changes get merged upstream as it seems that react-native needs to update the dependency for this fix to propagate.
Happy to change anything here.

@connectdotz mind taking a look and telling me what else may need to get done?


feat!: Make node 14 the minimum supported version

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Not sure why renovate-bot is failing the CLA check 🤷♂


Overflow

After using this for awhile I noticed this

I was able to buy sword and shield of 175 level which is cool, but fights not happen pretty slowly

I'm exploring some fixes for this here in case someone wants to try it up and see how it plays.

@vito-laurenza-zocdoc I think that's a known issue with cargo install.
Can you try again passing the --force flag to cargo install?

I tried with --force. I see a new timestamp on the file in ~/.cargo/bin/rpg-cli. I can still reproduce the overflow.
$ rpg

    hero[165]@home
    hp:[xxxxxxxxxx] -1899234251/-1899234251
    xp:[x---------] 6142/63583
    att:-1854956476   def:4340737   spd:1113458
    equip:{sword[75],shield[75]}
    item:{}
    2078088g

ok, can you try running rpg --reset ? It's likely that you are running with the hero with overflowed stats from the previous version.

ok, can you try running rpg --reset ? It's likely that you are running with the hero with overflowed stats from the previous version.

I meant to mention that I did --reset before grinding levels again.

ok, can you try running rpg --reset ? It's likely that you are running with the hero with overflowed stats from the previous version.

I meant to mention that I did --reset before grinding levels again.

I think I had $RPG_CLI pointing to a different binary. I'm trying again.


ci: retry failed stages only once after a failure

Retrying failed build stages 3 times is excessive and wasteful in most
cases. To account for transient cluster creation failures, one
additional retry should be sufficient to overcome issues coming from
cluster creation issues.
Additionally we have added a 3 minute wait before retrying.

I have also noticed that the time it tasks for 3 retries is well over 120 mins (the job timeout). When this timeout is reached the job is aborted leaving the cluster resources behind. Instead of reducing the number of retries I could have increased the timeout to 3 hours. But i feel that if the job does not PASS in two attempts, there is a very very low chance that it'll PASS in the third.

bors retry


len function python tutorial

Populate common-built-in-functions/len.py with a tutorial and challenge.

Can I be assigned?


Deploy from VSC running on local computer to Docker Container on the server fails with error Bad Gateway and Container status is set to unhealthy

Hi All,
I have 2 issues:

Deployment from VSC to the Docker Container fails with error "Bad Gateway"

As I am deploying code from VSC that runs locally on my laptop to the Docker Container that is installed on VM on server I get the error in VSC "Bad Gateway".
it happens randomly, this means, that it works for several minutes (20-30 mins) and then error Bad Gateway pops in the VSC debugger window.
Docker Container goes into the unhealthy state, even though Docker inspect does not report any issue (see attached file Damjan_error.txt)
restart of container resolves the issue

Debugging of AL code is super slow when any parameter or table field is added in the Watcher window. This started to happen as we installed Docker and all containers on the Server.

when the debugger is active and non parameter is added into the Watcher window inside VSC the debugger behaviour works as expected, takes about 1 second to go to the next line (F11) in the code.
as any parameter or table field, etc is added in the Watcher window the responsiveness of the debugger becomes super slow (takes 3-6 seconds to jump to the next line in code), if Watcher window is hidden that it work again as expected.

System environment:

Virtual Machine ESXI Hypervisor, 128GB RAM, SSD, CPU 6-Cores, virtualization is enabled, Hyper-V is used for VMs
One Docker Desktop is installed on the server where 12 containers are deployed with BC19 (OnPrem)
12 containers, each container has been dedicated of 12GB RAM
NGIX used as reverse proxy upstream to the containers and SSL termination for hosting multiple machines.
health check is enabled; default settings, which have been changed to
VSC is running on local machine (laptop) - it works the same as on internal network as it does over the VPN (home office).

Logs from Docker and from the affected Docker Container (event logs) are attached.
Thank you
BR Damjan
Logs.zip

2 questions:
Does the container have a SSL certificate?
What authentication are you using?

container uses SSL certificate, but we are planning to use HTTP and SSL will be configured for NGINX
authentication type is set to NavUserPassword

I just read this thread https://github.com/microsoft/vscode-java-debug/issues/305
I have few JS in the project....not sure it this has anything to do with slow debugger
Thank you
BR Damjan

I don't know whether that could be related.
Does all the containers work fine until you start debugging?
Can you repro this in a simpler setup - create a local container and debug?

Hi Freddy,
issue is resolved with this parameter: doNotCheckHealth = $true;
it works like a charm both in Google Chrome and FireFox. Debugger is super fast:), like an instant blink of an eye and it jumps in next line in the code, also all entries in the Watcher window are update at once as code is positioned on the next line.
for now, we will have enabled that parameter in the Container config. I hope that is fine.
Thank you
BR Damjan

Which reminds me that when Tobias Fenster added Traefik support, he also added a new CheckHealth script:
https://github.com/microsoft/navcontainerhelper/blob/master/ContainerHandling/traefik/CheckHealth.ps1
Which is probably something like that you would need to make health checks work on the other side of NGINX.
Sorry for not seeing this earlier.

One more thing, I just found out we are running Docker Desktop and not Docker Enterprise. Does the version of Docker relate to issues we have, in particular we are having random errors as developers are deploying app from locally installed VSC (bad gateway).

No
There is also nothing called Docker Enterprise anymore - it is Mirantis Container Runtime.
Personally, I use Docker Engine.
https://freddysblog.com/2021/10/30/docker-and-business-central/


Update README

Closes #60
This PR updates the README file, adds a LICENSE, and cleans up spacing in the other files to make them all uniform

@googlebot I consent.


Docs: connecting to azure data explorer

I have a few questions regarding to the code about connecting to data explorer.

Is it correct that this piece of code provide a connection to data explorer?
What do the three parameters mean?
How and where can the parameter values be found for the user?
Does TSItoken stand for time series insight token and if so, why is this referred to time series insight?

           const cluster = new ADX.ADXTrenderClient(                 "https://help.kusto.windows.net/",                 authContext.getTsiToken,                 "Trender"             );

`

I'm looking for the same info, there needs to be a good example for using this with your own cluster, authenticating, running a querying and rendering it


[backport] Fixes spectral normalization chainerx conversion

Backport of #7698

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 79e20a73eb1c0074dae0d8d278cff1d984cb11de, target branch v6) failed with status FAILURE.


Make enter and tab key work again in crossterm backend

It looks like new crossterm returns a dedicated enum item for the enter and tab key instead of the \n and \t character.
Fixes #394.

Whoops, thanks for noticing!


0 Kb/0 Gb In Panel

https://media.discordapp.net/attachments/938001780543987727/956432943964889118/unknown.png

Not script related.


Endless loop, if no HX711 is connected

I use the code on my ESP8266 and the tare command doesn't finish, if no Hardware is connected. This results in unwanted watchdog-Resets.
For me the hardware should be optional and recurrent reset is not an option.
My changes:
void HX711_ADC::tare()
{
uint8_t rdy = 0;
doTare = 1;
tareTimes = 0;
int okcounter = 200;
while(rdy != 2) {
rdy = update();
if (okcounter-- == 0){
// Prevents from endless loop and watchdog-firing, if no HX711 is connected
break;
}
}
}

Hi, I see what you mean, and I agree that it should be possible to run the code without HW. However, I think a timeout will be more reliable than a counter. Could you please try the mod below, and let me know if it works for you:
in HX711_ADC.h: (below #define DATA_SET)
#define TARE_TIMEOUT (DATA_SET * 100) + 500 // tare timeout time in ms, no of samples * 100ms (10SPS) + 500ms margin

in HX711_ADC.cpp:
void HX711_ADC::tare()
{
	uint8_t rdy = 0;
	doTare = 1;
	tareTimes = 0;
	long timeout = millis() + TARE_TIMEOUT;
	while(rdy != 2) {
		rdy = update();
		if (millis() > timeout){
			break; // Prevents endless loop if no HX711 is connected
		}
	}
}

Change not implemented.


Memory requirement for quantization process? OOM unresolved.

Could you share the numbers for different models?
I ran into OOM when running mistral 7b or Vicuna 7b on 1 A100 40GB. It OOMed after running AWQ for 2 or 6 datapoints. Following the example here: https://github.com/casper-hansen/AutoAWQ?tab=readme-ov-file#examples
Even using multigpu (2 or 3) it OOM at the same iteration. from nvidia-smi it seems it didn't use the other GPUs and mostly ran on the first GPU. Is this the correct way to enable multigpu? CUDA_VISIBLE_DEVICES=0,1

+1


[STORM-2144] Fix Storm-sql group-by behavior in standalone mode

Fix group-by to not rely on monotonic group-by keys

+1 LGTM

Found storm-jms version issue while checking Travis CI failing. Will submit a patch shortly.

Other than that I'm +1. IMHO, standalone mode also needs to have some abstraction or introduce something to not creating source code by manipulate string directly.

@HeartSaVioR you are right, its very tedious to maintain. Right now its kind of a bridge to translate sql to java so that sql abstractions can be executed in storm core. IMO we should get out of standalone mode in future and add support in storm-sql to directly translate to storm-core topologies via the streams api proposed in STORM-1961 (https://github.com/apache/storm/pull/1693).

+1 for replacing code generation with an abstract API as it is hard to maintain. But that can be a different task and it is not related to this PR.

+1. Isn't standalone mode still helpful for devs instead of just moving to abstract API.

I guess Calcite itself can provide interpreter for handling query. If then standalone users can just move to Calcite interpreter, and standalone mode could be removed. I'm planning to find it from Calcite.

I guess Interpreter seems to be candidate for replacement of standalone more on storm-sql.
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/interpreter/Interpreter.java
Unit tests are here.
https://github.com/apache/calcite/blob/master/core/src/test/java/org/apache/calcite/test/InterpreterTest.java
It still need to register tables and functions to root schema but storm-sql is same.

Spend some time to look into it but it looks like breaking changes are needed.
Interpreter expects static input table before initializing Interpreter, which is valid for most of case, but Storm SQL standalone mode works like streaming, emitting input tuples and receive the outputs.

Thanks @arunmahadevan for the fix.

Pushed to master branch also.


az apim api import to existing API clears serviceUrl when the optional --service-url parameter isn't provided

Describe the bug
az apim api import to existing API clears serviceUrl when the optional --service-url parameter isn't provided
Clearing/removing/blanking the serviceUrl property of an APIM API is a risk that the runtime breaks down.
Related command
az apim api import

Errors
N/A
Issue script & Debug output
az apim api import
  --service-name apim-something-weu
  --resource-group rg-something-weu
  --path /ecommerce
  --specification-format OpenApiJson
  --specification-path C:\something\ecommerce.json
  --api-id ecommerce-v1
  --api-version v1
  --api-version-set-id 'ecommerce'
  --description "sinterklaas"
  --display-name eCommerce

Expected behavior
Ensure properties that are not provided, as they are (intentionally) optional, won't be changed via the resulting resource provider deployment.
Environment Summary
azure-cli                         2.62.0

core                              2.62.0
telemetry                          1.1.0

Extensions:
azure-devops                       1.0.0
maintenance                        1.6.0

Dependencies:
msal                              1.28.1
azure-mgmt-resource               23.1.1

Additional context
We aim to have this split

APIM configuration via BICEP infra templates

including API definition (paths, API level policies), (API) Products, subscriptions and such

On the API solution (deploy-time pipeline) we take the OpenAPI spec, and (re)import the operations into the predefined APIM API

The serviceUrl is to be configured and maintained in the former, also to have an environment agnostic OpenAPI specification file. Currently that is impossible as I can't instruct the az apim api import to stay "hands of" the serviceUrl that was configured, and is no cleared as result, breaking the runtime and resulting into unavailability.
Can be reproduced via

Checking the serviceUrl of an API after az apim api list --resource-group rg-something-weu --service-name apim-something-weu
(re)import that API, without specifying a --service-url
Check again the serviceUrl of the same API, which is now converted into a null value.

The error directly after that
GatewayError:
   at forward-request

Backend service URL is not defined.

Thank you for opening this issue, we will look into it.

Any update about this bug @yonzhan


Fastnlight: Watch UPGOALIA

Fastnlight requests the watch of the watch_keyword UPGOALIA. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

UPGOALIA has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Rejected by Spevacus in Charcoal HQ. Reason: 'By author request'


你好作者，我想请问一下，关于子流程类型无法运行的问题

目前其他工作流类型都是可以的，创建工作流中包含了sub_process和其他类型的任务时，其他类型的任务能正常工作，完成，sub_process就一直处于提交成功的状态，t_escheduler_process_instance表中有数据，worker线程没有日志显示，想请问这一块的功能是已经测试通过的还是说还未完善？我的项目版本是4月24从master拉取下来的，在你们正式发布1.0.2之前的版本，期待作者的回复，谢谢

Sub process function is test successfully, we need more information for this issue, for example: some images and logs.

The master handles commands. Work process runs by adding a new command, and so does the sub-workflow. If the master has errors, it is likely that the command of the sub-workflow is wrong.

感谢回复，不过子流程不嵌套在其他工作流程中时，是可以运行的，里面的任务都是能够成功执行的
------------------ 原始邮件 ------------------
发件人: "bao<EMAIL_ADDRESS>发送时间: 2019年5月9日(星期四) 下午2:39
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [analysys/EasyScheduler] 你好作者，我想请问一下，关于子流程类型无法运行的问题 (#260)
The master handles commands. Work process runs by adding a new command, and so does the sub-workflow. If the master has errors, it is likely that the command of the sub-workflow is wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

can you post the master's error log?  it will be helpful for solving this issue.

可以，我直接回复邮件，照片附在邮件中，github中可能看不到，这是一个工作流，里面有两个task任务，如下图，名称为子流程的task是一个子流程，运行时报如下错误
------------------ 原始邮件 ------------------
发件人: "bao<EMAIL_ADDRESS>发送时间: 2019年5月9日(星期四) 下午2:58
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [analysys/EasyScheduler] 你好作者，我想请问一下，关于子流程类型无法运行的问题 (#260)
can you post the master's error log?  it will be helpful for solving this issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

好的，这是一个工作流，里面有两个task任务，如下图，名称为子流程的task是一个子流程，运行时报如下错误

the errors are due to data structure not matched with data base.
because of some misoperations, the code in master on Apr.24 is unstable.
We recommend that you upgrade to version 1.0.2 that would be stronger.

好的谢谢，我将尝试最新的
------------------ 原始邮件 ------------------
发件人: "bao<EMAIL_ADDRESS>发送时间: 2019年5月9日(星期四) 下午5:51
收件人<EMAIL_ADDRESS>抄送: "冰山☆詠遠愛"1029942482<EMAIL_ADDRESS>主题: Re: [analysys/EasyScheduler] 你好作者，我想请问一下，关于子流程类型无法运行的问题 (#260)
the errors are due to data structure not matched with data base.
because of some misoperations, the code in master on Apr.24 is unstable.
We recommend that you upgrade to version 1.0.2 that would be stronger.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Package not found when install rust-mode through Melpa

After added the required info in  ~/.emacs.d/init.el,
and enter
M-x package-install rust-mode
I got the error message:
http://melpa.milkbox.net/packages/rust-mode-20200513.812.el: Not found
Did you guys have similar error message when install?
My rust env is:
➜  ~ cargo --version cargo 1.44.0 (05d080faa 2020-05-06) ➜  ~ rustc --version rustc 1.44.0 (49cae5576 2020-06-01)
Thanks!

Actually I just found the solution:
 M-x package-refresh-contents
and case solved.
Source: stackover flow


 In the documentation of eventId it says:

If two events with the same Uuid are appended to the same stream in quick succession EventStoreDB will only append one copy of the event to the stream.

But if I just write a simple snippet like this:
UUID id = UUID.randomUUID();
eventStoreDBClient.appendToStream("name", EventData.builderAsBinary(id, "type1", "data".getBytes(UTF_8)).build()).join();
eventStoreDBClient.appendToStream("name", EventData.builderAsBinary(id, "type1", "data".getBytes(UTF_8)).build()).join();

System.out.println("### " + eventStoreDBClient.readStream("name").join().getEvents().size());

Then it'll print ### 2 (i.e. two events were appended)
If I change it to:
EventData eventData = EventData.builderAsBinary(UUID.randomUUID(), "type1", "data".getBytes(UTF_8)).build();
eventStoreDBClient.appendToStream("name", eventData).join();
eventStoreDBClient.appendToStream("name", eventData).join();

System.out.println("### " + eventStoreDBClient.readStream("name").join().getEvents().size());

Then it'll print ### 1 (i.e. one event was appended).
In my world, these two code snippets ought to yield the same result (i.e. printing ### 1). Since I'm new to ESDB I'm not sure if it's a bug or not, but it seems like very strange behavior to me.
I'm using version 1.0.0 and ESDB running in Docker (image is eventstore/eventstore:21.2.0-buster-slim).

The patch is available on the latest snapshot version of the client if you are interested: https://github.com/EventStore/EventStoreDB-Client-Java/issues/68#issuecomment-827502978


fix bug: failed to git clone docker-containerd

One of the repos cloned by the build process contains Windows
line endings and depending on the local user's git config may
cause further clone failures.  By forcing autocrlf to false,
we preserve the original files so that they show unmodified.
Edit: this comment is no longer completely accurate.  The cloned repo does contain Windows line endings, but adding a git autocrlf flag can't fix the issue because the cloned repo uses .gitattributes "eol" flag to enforce the line endings.

somehow doing this changed my snap-pelion-edge/.git/config file to be owned by root:root. I don't think we want that, right?

Interesting, although I do see how this modifies the wrong user's git-config.  It should be modifying "user" gitconfig, not the caller's gitconfig (i.e., /home/user/.gitconfig).

somehow doing this changed my snap-pelion-edge/.git/config file to be owned by root:root. I don't think we want that, right?

Interesting, although I do see how this modifies the wrong user's git-config.  It should be modifying "user" gitconfig, not the caller's gitconfig (i.e., /home/user/.gitconfig).

@ryannowarm does this newer PR work for you?

@ryannowarm does this newer PR work for you?

Re-running build test now

Re-running build test now

Build works for me.  Looks good.

Build works for me.  Looks good.


Cat thread_pool API

I was wondering why the thread_pool cat call is commented out. As a monitoring interface, these calls could help understanding the status of the cluster.

@nbuso mostly because of time constraints :)
When I started development for the cat apis section, I expected that parsing of the output would be pretty straight forward, almost like split on whitespace, and everything will work out. It isn't as easy as that :)
Some of the values might contain a space(node name), some of the values are right aligned, some left aligned and so on.
I still hope to get back at this and have it generic for all cat apis, but haven't really found the time.

@lmenezes

I expected that parsing of the output would be pretty straight forward, almost like split on whitespace, and everything will work out. It isn't as easy as that :)

Hmm,
and with /_cat/thread_pool?format=json ?

@kevinliteon honestly I didn't know I could request format=json. that makes things much easier yes :)
On the other hand, I have somehow abandoned development for kopf. Since ES 5 won't allow site plugins anymore, and I don't wan't to transform kopf into a kibana plugin, I have started developing a kopf replacement, as a standalone app. It's far from being feature equivalent with kopf, but I hope to have a public first release soon -> https://github.com/lmenezes/cerebro
I will integrate the cat api in there as well, it's actually one of the easy ones. thanks for the heads up :)


Create advanced configuration modules for Azure Front Door

Create the following modules:
azurerm_frontdoor_custom_https_configuration
azurerm_frontdoor_rules_engine

Closing as in 5.4.6


Improve the handling of separation between window title and status

Before, it was always separated by space, now the separator can be changed or removed via global option
Now, the separator is only added if there is an actual status to display. Works for custom separator icons only.

This is a decision made by the theme, see #168

OK, understood, the theme wants window status indicators always separated by spaces.
But this PR also has another part to it, a bug fix IMHO. Similar to what #265 does to status modules.
Let's say user sets active window icon to null. Then the icon is not shown, but the separator space is added nevertheless to the window info. IMO, there should be no separator if status icon is removed, correct?
Would this PR be considered if only that part is left?

if you can find a could way to remove the space if it's empty yes.
Best way I could come up with is using this echo "[${icon:+ $icon}]"

Please see #270


NTR: vasodilation by nitric oxide

Dear Biocurators,
I am writing to request a new GO term, which arose whilst annotating paper PMID: 21768538 (Wu et al., 2011).
It is demonstrated in Figure 6 in this paper that miR-92a expression affects the regulation of vasodilation by nitric oxide.
Therefore, I wish to request the term:   ‘vasodilation by nitric oxide’
I am planning to subsequently request regulation terms via TermGenie in order to capture the effect of miR-92a on this process.
These terms would subsequently become siblings to terms such as (as well as others):
GO:0003121: regulation of vasodilation by epinephrine
GO:0003122: regulation of vasodilation by norepinephrine
GO:0003124: regulation of vasodilation by neuronal epinephrine
DbxREFs: GOC:BHF, GOC:BHF_miRNA, GOC:bc
I will look forward to hearing from you with regard to my request.
Thank you,
Barbara
cc: @RLovering
cc: @rachhuntley

Hi Barbara,
I’m afraid I have a couple of comments about this term too :-)
‘vasodilation’ is already a regulation term; it is a child of ‘regulation of blood vessel size’ and defined as “An increase in the internal diameter of blood vessels, especially arterioles or capillaries, usually resulting in a decrease in blood pressure.”. Therefore ‘vasodilation by nitric oxide’ would already capture the fact that the size of blood vessels is modified (increased = regulated) by nitric oxide. You wouldn’t need further regulation terms (and we wouldn’t want ‘regulation of regulation’ terms in the ontology). Unfortunately, I can see that the confusion may have arisen from the current existence of ‘regulation of vasodilation’ terms with several children. Some of them have a dbxref GOC:cardio so Ruth may remember something about them. I wasn’t around at the time, so I may have to check with other editors in case we need to edit the vasodilation branch - or in case I’m missing the point here…
Thanks,
Paola

@RLovering

Hi Paola,
Thank you for this overview.
Can I just confirm that this means that I only need to request 'vasodilation by nitric oxide', which would become is_a child term of 'vasodilation', which would be synonymous with ‘regulation of blood vessel size resulting in an increase in the internal diameter of blood vessels'?
But this also means that in order to make the annotation, which I intended, I also need to request the sibling term 'vasoconstriction by nitric oxide' (not to say 'negative regulation of vasodilation'!). However, I have just checked on Protein2GO and regulation terms for vasoconstriction are also abundant!
Thanks,
Barbara
@rachhuntley
@RLovering

Hi Barbara,
Given the confusion, I'd rather wait until I can clarify before adding terms or annotations. It seems we have a mix of terms under 'regulation of blood vessel size' - mostly old terms - my gut feeling is that we may have to edit the branch to better reflect the biology and current ontology procedures. I'll bring this up for discussion with my fellow editors and will keep you posted. Feel free to comment again if you don't hear from me within a few days.
Thanks,
Paola

Thanks, Paola!
Ok, I'll will look forward to hearing some news regarding this!
Barbara
@rachhuntley
@RLovering

Note for self -
'regulation of blood vessel size' sits directly under (is_a) 'biological regulation' -
it should be more specifically is_a 'regulation of biological quality'
and still NOT have regulation children

I just looked at this paper again and 'vasoconstriction by nitric oxide' would not actually be correct, because, based on Figure 6D, nitric oxide causes vasodilation.
But silencing of KLF2 by miR-92, which happens upstream, results in a decrease in the level of vasodilation:
miR-92a  ---|  KLF2  -->  eNOS  -->  nitric oxide synthesis  -->  vasodilation
@rachhuntley
@RLovering

Sounds like it may fit a LEGO model better than classical annotation...
(Barbara, not sure how familiar you are with LEGO, so my comment may be addressed to Ruth and Rachael instead.)

After discussing with Barbara, we think having synonyms of regulation of blood vessel size for vasodilation and vasoconstriction is confusing. What size is this referring to; length, width? It seems as if there should be an additional parent "regulation of blood vessel diameter".

Perhaps:
'regulation of blood vessel size' -> 'regulation of blood vessel diameter' as that seems to be the intention. Synonyms on vasodilation and vasoconstriction could be changed to fit.

At the editors call yesterday, we briefly went over the 'regulation of blood vessel size' branch. It was agreed that it needs a revamp. It won't be a quick fix I'm afraid. I will of course keep existing annotations into account. I'll start looking into this now and will post updates as I go. It might be more prudent for Barbara to hold onto annotating to these terms for the moment - they're confusing anyway!

Notes for self:

'reg. of blood vessel size' is indeed a descendant of 'reg. of biological quality', so that's ok
'reg. of blood vessel size' points to the OBA term 'blood vessel size', so I'll have to look into whether OBA has the more appropriate descendant of 'tube diameter' that I could use

Thank you for this update, Paola.
We have left all of the uncertain annotations from this paper (PMID:21768538) on hold.
@rachhuntley
@RLovering

Let’s start at the top - regulation of blood vessel size:
[Term]
id: GO:0050880
name: regulation of blood vessel size
namespace: biological_process
def: "Any process that modulates the size of blood vessels." [GOC:ai]
is_a: GO:0003018 ! vascular process in circulatory system
is_a: GO:0035150 ! regulation of tube size
intersection_of: GO:0065007 ! biological regulation
intersection_of: regulates OBA:0000032 ! blood vessel size
relationship: part_of GO:0008015 ! blood circulation
“size” is generic here - of course a generic tube may increase its size by becoming longer as well as wider, but blood vessels specifically become wider (vasodilation) or narrower (vasoconstriction), so we need to link to a diameter term here. It appears that OBA doesn’t have a specific term yet; the one we need is
OBA:NEW blood vessel diameter
is_a OBA:0000032 blood vessel size
is_a OBA:0000171 tube diameter
@cmungall , is there an OBA TG instance that I could use to request this? Otherwise could you please point me in the right direction.
We could then rename GO ’regulation of blood vessel size’ as ‘regulation of blood vessel diameter’, change the intersection to point to the new OBA term, and go from there. (We’d also need to redefine it and place it under GO:0035296 ’regulation of tube diameter’, whose def, btw, may do with some changes - currently “Ensuring that a tube is the correct width.”)
Thanks,
Paola

http://oba.termgenie.org/

Actually, I'd like to try a different route for OBA, using DOSDPs
This may be much more opaque at first, but we're improving it. Go to:
https://github.com/obophenotype/bio-attribute-ontology/blob/master/src/ontology/modules/entity_attribute.tsv
Edit the file, add a new line, use the next ID (+1 from previous line)

@cmungall , I confirm I have permission to access TG OBA (but I'll try to follow your other suggested route, as recommended). However, FYI, there are ~22 unsatisfiable classes, preventing TG OBA to function.

@cmungall done. Let's see how many attempts this will take :-)
Note the last line in the file was for OBA_0000110, but OBA IDs at the top of the file went as high as OBA_0000182, so I choose OBA_0000183 for my new term (this doesn't exist yet, as far as I can tell).

Hi @cmungall ,
Not sure if the OBA term made it. Anyway I requested it in imports_request.obo,
+relationship: needs OBA:0000183 ! blood vessel diameter
Thanks,
Paola

Hi @cmungall , any update on this please? :-)
@BarbaraCzub , FYI, I won't have a chance to work on this for a few days now, as I'll be on leave.
Thanks,
Paola

Hi Paola, thanks for the update on this.
Enjoy your leave and I'll wait to hear from you afterwards.
Thanks,
Barbara
@paolaroncaglia

Hi Paola,
I was not sure, as I was following the conversation, where your term requests were supposed to make it, but I just had a look on QuickGO and the vasodilation and vasoconstriction are now defined as 'an increase/decrease in the internal diameter...' whereas the previous definitions were ‘regulation of blood vessel size resulting in an increase/decrease in the internal diameter of blood vessels' (however, there is nothing in the change log about these definitions having being modified recently...). Anyhow, does this mean that regulation terms for both vasodilation and -constriction are now valid? And/or are you planning to make further changes to these terms/definitions?
Thank you,
Barbara
@RLovering
@rachhuntley
@dosumis

@paolaroncaglia

Hi Barbara (and @cmungall ),
As far as I can see, the term OBA:0000183 ! blood vessel diameter hasn’t been committed yet; the pull request at https://github.com/obophenotype/bio-attribute-ontology/pull/11 is still open. (Barbara, Chris was busy with grant submissions and traveling to meetings lately, hence - possibly - the delay.) Ideally, I would like to start editing this branch from the top down, so I’d like to wait for the OBA term to be available and then go from there to do the necessary GO edits.
As for definitions of vasodilation and vasoconstriction, I didn’t do any change in this branch, and I’m not aware that others did (as apparently confirmed by the change log). We editors are still of the opinion that current regulation terms for vasodilation and -constriction should not be valid. If you look at ‘regulation of blood vessel size’ and search for its children (http://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0050880#term=children), you will see that both ‘vasodilation’ and ‘regulation of vasodilation’ are is_a children of the parent term - a good indicator that something is wrong. same for ‘vasoconstriction’ and its regulation. So yes, I am still planning to make changes in this ontology branch :-)
Thanks for your patience with this,
Paola

Hi Paola,
Thank you for the update and for clarifying the situation. I see what you mean about the continuing need to tidy up this branch! However, I would vote for including the regulation terms in the new restructured branch. If you look at the example, which I pasted in above (miR-92a ---| KLF2 --> eNOS --> nitric oxide synthesis --> vasodilation), when annotating the silencing of KLF2 by miR-92a, it would not be wrong to add the AE causally_upstream_of negative regulation of vasodilation, but it would be incorrect in this case to say causally_upstream_of vasoconstriction. But, as you suggested, perhaps to should be annotated using LEGO?
Thanks,
Barbara
@rachhuntley
@RLovering

Or perhaps...  AE part_of negative regulation of vasodilation?
Anyway, just a thought!
Barbara

Note for self - OBA term was committed a few hours ago. Next week I'll check if the term is available or if I have to add it again in imports_requests.obo.

Note for self: OBA:0000183 ! blood vessel diameter doesn't seem to be available yet, so I requested it again in imports_requests.obo - just now. Will need to check after 24 hours or so.

Dear Paola,
I hope you are well. Following a team discussion re: vasodilation and -constriction, we would like to emphasise that it is important to specify (within the definitions for these processes) that they involve the constriction and/or relaxation of smooth muscle cells. I.e. factors, which influence the vessel diameter, should be distinguished to make it clear that the changes in diameter do not occur e.g. due to proliferation of endothelial cells, which form the vessel. These aspects are not identified within the current vasodilation and -constriction definitions, which are 'A decrease in the diameter of blood vessels, especially arteries, usually causing an increase in blood pressure' and 'An increase in the internal diameter of blood vessels, especially arterioles or capillaries, usually resulting in a decrease in blood pressure.' respectively.
I hope you will find this helpful!
Kind Regards,
Barbara
@paolaroncaglia
@rachhuntley
@RLovering

Hi Barbara,
Thanks for the input - yes that will be very helpful in trying to disentangle this biological node.
I will keep it in mind.
Best,
Paola

Hi @cmungall
Sorry to bug you again, but I still can't see OBA:0000183 ! blood vessel diameter... could you advise please? :-)
Thanks,
Paola

Hello, I was wondering whether there has been any progress on this issue? Are there any conclusions to whether regulation terms for 'vasodilation' could be created, or is 'vasodilation' a regulation term in itself? Re: PMID:21768538, Figure 6.
Thanks,
Barbara

Hi @BarbaraCzub ,
This issue wasn't forgotten, I just haven't had a chance to address it yet. Thanks for the reminder. I'll look into it again soon and will keep you posted.

Thanks @paolaroncaglia

Started with adding GO:0097746 regulation of blood vessel diameter
(and with fixing the def of ‘regulation of tube diameter’). More work needed.

Thank you @paolaroncaglia
So it seems to me the annotation, which I will ultimately be making, will be 'regulation of blood vessel diameter by/in response to NO', rather than 'regulation of vasodilation by NO'. And, I admit, this will be much clearer.

More work: edited the ‘regulation of blood vessel size by renin-angiotensin’ node.

Edited and rehoused ’vasoconstriction’ and ‘vasodilation’ - just those two terms, not their regulation ones or their children; more work needed.

Hi @BarbaraCzub ,
I haven't examined the paper you wish to annotate, but if you'd like to use the new term GO:0097746 'regulation of blood vessel diameter', that's ready to use. You could add the information on NO as an extension.

Hi Paola
to be clear are you suggesting AE: part_of response to NO

Hi @RLovering ,
If the paper shows that the diameter of the blood vessels changes in response to NO, then yes, I'd suggest to annotate to 'regulation of blood vessel diameter' with an AE: part_of response to NO. Hope that helps.

Hm... I have just re-read this paper and I am not convinced that this is how I should capture this information.
Nitric oxide (NO) positively regulates blood vessel diamater (NAS), and there is experimental evidence in the paper in Figure 6, which shows that:

miR92a negatively regulates NO biosynthesis (which I had annotated)
miR92a negatively regulates blood vessel diamater
These effects are not direct, but depend on prior silencing of KLF2 by miR92a:

miR92a  --|  KLF2  -->  eNOS (NO synthase)  -->  vasodilation
So the annotations would be:
miR92a: negative regulation of blood vessel diameter
KLF2: positive regulation of blood vessel diameter
eNOS (NO synthase): positive regulation of blood vessel diameter
I will not include the AE: part_of response to NO, as the levels on NO depend on miR92a anyway.
Please let me know, if you disagree.
@paolaroncaglia I think I will wait until this branch has been tidied up as I need the positive and negative regulation terms, which atm exist as 'vasodilation' and 'vasoconstriction', for which regulation terms exist also...

Notes for self: I will approach the revamp of the vasodilation/vasoconstriction branch from the bottom up. To-do list:

[ ] for clarity, rename ‘vasodilation by acetylcholine involved in regulation of systemic arterial blood pressure’ as ‘acetylcholine-mediated vasodilation involved in regulation of systemic arterial blood pressure’ (as agreed on an editors’ call); keep old name as exact synonym;

[ ] similarly, rename ‘vasodilation by norepinephrine-epinephrine involved in regulation of systemic arterial blood pressure’ as ‘norepinephrine-epinephrine-mediated vasodilation involved in regulation of systemic arterial blood pressure’; keep old name as exact synonym;

[ ] rename ‘vasodilation of artery involved in baroreceptor response to increased systemic arterial blood pressure’ as ‘artery vasodilation involved in baroreceptor response to increased systemic arterial blood pressure’; keep old name as exact synonym;

Then, looking at ‘regulation of vasodilation’ and children/descendants:

[ ] rename ‘envenomation resulting in modulation of vasodilation in other organism’ as ‘envenomation resulting in vasodilation in other organism’ (1 annotation, correct under the new naming); keep old name as related synonym;

[ ] rename ‘modulation of vasodilation in other organism’ as ‘vasodilation in other organism’ (no annotations); keep old name as related synonym; move it under (is_a) ‘vasodilation’ and delete link with ‘regulation of vasodilation’;

[ ] merge ‘regulation of vasodilation by circulating epinephrine’ and ‘regulation of vasodilation by neuronal epinephrine’ (no annotations, no mappings, no inferences) into their parent ‘regulation of vasodilation by epinephrine’; make sure all resulting synonyms are related;

[ ] rename ‘regulation of vasodilation by epinephrine’ (no annotations) as ‘epinephrine-mediated vasodilation’; keep old name as related synonym; change synonym scope of ‘regulation of vasodilation by adrenaline’ from exact to related; place it under (is_a) ‘vasodilation’ and delete link to ‘regulation of vasodilation’;

[ ] merge ‘regulation of vasodilation by circulating norepinephrine’ and ‘regulation of vasodilation by neuronal norepinephrine’ (no annotations, no mappings, no inferences) into their parent ‘regulation of vasodilation by norepinephrine’; make sure all resulting synonyms are related;

[ ] rename ‘regulation of vasodilation by norepinephrine’ (no annotations) as ‘norepinephrine-mediated vasodilation’; keep old name as related synonym; change synonym scope of ‘regulation of vasodilation by noradrenaline’ from exact to related; place it under (is_a) ‘vasodilation’ and delete link to ‘regulation of vasodilation’;

[ ] the branch ‘regulation of relaxation of vascular smooth muscle’ is also problematic as ‘relaxation of vascular smooth muscle’ itself is_a ‘negative regulation of smooth muscle contraction’. Given that ‘regulation of relaxation of vascular smooth muscle’ and its pos. and neg. children have no annotations, I’d like to merge all 3 into ‘relaxation of vascular smooth muscle’ (making sure all resulting synonyms are related) and make the def. of ‘relaxation of vascular smooth muscle’ clearer by changing it to “A negative regulation of smooth muscle contraction resulting in relaxation of vascular smooth muscle. The relaxation is mediated…”;

[ ] create GO:NEW ‘positive regulation of blood vessel diameter’ (“Any process that increases the diameter of blood vessels.”) and place ‘vasodilation’ (“An increase in the internal diameter of blood vessels…”) under it (is_a) rather than under ‘regulation of blood vessel diameter’;

[ ] similarly, create GO:NEW ‘negative regulation of blood vessel diameter’ (“Any process that decreases the diameter of blood vessels.”) and place ‘vasoconstriction’ (“A decrease in the internal diameter of blood vessels…”) under it (is_a) rather than under ‘regulation of blood vessel diameter’;

(@BarbaraCzub, these are the new terms you need, so keep watching this space please, I will add the new GO IDs in a separate comment as soon as they’re ready.)
The list of to-do items below needs further examination:

[ ] look at exp. annotations of ‘negative regulation of vasodilation’ and suggest new homes for them, possibly ‘negative regulation of blood vessel diameter’; then eliminate term, possibly by merging it into ‘vasodilation’;

[ ] same for ‘positive regulation of vasodilation’;

[ ] then look at ‘regulation of vasodilation’; it should have no children left; look at its annotations (and InterPro mappings!) and suggest new homes for them; then eliminate term, possibly by merging it into ‘vasodilation’;

[ ] Then work on vasoconstriction.

Hi @paolaroncaglia , thank you for this update. I will look forward to these new GO terms becoming available.

Hi @BarbaraCzub , here are the new terms:
+id: GO:0097755
+name: positive regulation of blood vessel diameter
+id: GO:0097756
+name: negative regulation of blood vessel diameter

Thanks @paolaroncaglia

Following up on the strategy outlined above, I will:

[ ] Merge ‘negative regulation of vasodilation’ into ‘negative regulation of blood vessel diameter’.
FYI, my rationale for choosing to merge into ‘negative regulation of blood vessel diameter’ rather than ‘vasoconstriction’ is the following:
‘vasoconstriction’ specifically means constriction of smooth muscle cells that line the vessels;
I looked at a couple of annotations to ‘negative regulation of vasodilation’:

PMID:18671723 “naofen interferes with NO production” => upstream of dilation or constriction => negative regulation of blood vessel diameter;
PMID:24309216 “adenosine A1 antagonist DPCPX … failed to reduce vasodilatation induced by CGS21680” => not entirely clear, so safe to say upstream of dilation or constriction => negative regulation of blood vessel diameter.
‘negative regulation of vasodilation’ had 11 experimental annotations, they are in the attached table annotations_need_checking.xlsx. If curators wish to rehouse them under more specific terms, they’ll be given a chance to do so, see below.

[ ] Merge ‘positive regulation of vasodilation’ into ‘positive regulation of blood vessel diameter’.
Rationale for doing so is similar to the above and supported by looking at a couple of annotations (PMID:23826814 and PMID:23232926).
‘positive regulation of vasodilation’ had 55 experimental annotations, they are in the attached table annotations_need_checking.xlsx, see below;

[ ] Merge ‘regulation of vasodilation’ into ‘regulation of blood vessel diameter’.
Again this is backed up by looking at some annotations (PMID:17916776 and PMID:12730558).
‘regulation of vasodilation’ had 7 direct experimental annotations, they are in the attached table annotations_need_checking.xlsx, see below.

[ ] ‘regulation of vasodilation’ has 5 InterPro mappings. I’ll need to look at them and suggest changes.

[ ] Then work on vasoconstriction :-(

[ ] When the clean-up of this branch is complete, I’ll contact the relevant MODs to let them know of the changes and point them to the spreadsheet in case they wish to rehouse any of their annotations.

Thanks Paola this sounds right

annotations_need_checking.xlsx

@asangrador @almitchell @happy-lorna @ndrawlings @EBI-Hsinyu
Following changes of GO terms related to ‘vasodilation’, I merged GO:0042312 ‘regulation of vasodilation’ into ‘regulation of blood vessel diameter’. This affects InterPro because GO:0042312 ‘regulation of vasodilation’ has 5 InterPro mappings, which I suggest to move instead to GO:0042311 ‘vasodilation’. The mappings are:
IPR000147
IPR000332
IPR000356
IPR000670
IPR001483
Thanks in advance for looking into this.

Hi Paola
so for O35607 Bmpr2 which is annotated to GO:0045906 negative regulation of vasoconstriction this should be annotated with the GO term: negative regulation of blood vessel diameter.
but this doesn't imply whether the blood vessel diameter is smaller or larger as a result. How are we supposed to indicate this. The diameter size is an important aspect of human system, and neg reg of vasoconstriction does not mean vasodilation
Sorry for taking so long to appreciate this. I think this is why the terms were created despite the problem with negative negative.
Ruth

Hi @RLovering ,
I haven't fully revised the vasoconstriction branch yet, but I'll keep your comment above in mind. (Neg reg of vasoconstriction means that the diameter does not decrease, so it's certainly not the same as neg reg of diameter ;-) perhaps you meant 'reg. of diameter', but I will look into terms and annotations and formulate a plan, I do agree that these terms are problematic but hopefully annotation procedures will become clearer to us all if we focus on what the processes are and what it is that regulates them instead. Plus, LEGO is probably the best way forward here.)

@RLovering , @BarbaraCzub
Looking at the vasoconstriction branch highlights yet more work to do. At first sight, the areas in need of revision are not only the existing regulation terms, but also the link with ‘vascular smooth muscle contraction’ (currently is_a ‘vasoconstriction’). Quickly put: vasoconstriction refers to decrease in diameter of a whole blood vessel; the vessel is made of endothelial + muscle cells; ‘vascular smooth muscle contraction’ should be part_of ‘vasoconstriction’, not is_a. (And the reciprocal ‘vasoconstriction’ has_part ‘vascular smooth muscle contraction’ should be added, too.) (Note that ‘relaxation of vascular smooth muscle’ correctly is part_of ’vasodilation’ already.) Are there cases where vascular smooth muscle cells contract without causing vasoconstriction?
As for vasodilation, the vasoconstriction node contains many terms (though, luckily, only 57 manual experimental annotations) so revising everything is not a quick thing. I’ll have a word with David Hill. Thanks for your patience…

@RLovering , @BarbaraCzub, @rachhuntley
I discussed this ticket briefly with @ukemi. He has some thoughts about it, and agrees that it would be a really good case for LEGO. I'm handing it over to him so he can continue where I left, as I'm wrapping up my ontology tickets. Thanks.

Discussed with @RLovering
Decisions:

[x] Merge 'regulation of blood vessel size' and 'regulation of blood vessel diameter'
[x] Change label: GO:0097746 regulation of blood vessel diameter -> blood vessel diameter homeostasis
[x] Change label: GO:0002034 regulation of blood vessel diameter by renin-angiotensin ->     maintenance of blood vessel diameter homeostasis by renin-angiotensin

Obsolete:
GO:0097756 negative regulation of blood vessel diameter -> consider: vasoconstriction
GO:0097755 positive regulation of blood vessel diameter -> consider: vasodilation

Dear all,
The proposal has been made to obsolete
GO:0097756 negative regulation of blood vessel diameter -> consider: vasoconstriction: 16 EXP
GO:0097755 positive regulation of blood vessel diameter -> consider: vasodilation: 45 EXP
Contributor   (Assigned by)
AgBase | 7
MGI | 2
RGD | 43
UniProt | 9
There are no mappings; these terms are not in any subsets.
We are opening a comment period for this proposed obsoletion. Since there are many annotations to be reviewed, we’d like to proceed and obsolete this term on November 27th, 2020. Unless objections are received by November 27th, 2020, we will assume that you agree to this change. You can add comments to the ticket: https://github.com/geneontology/go-ontology/issues/12253
Thanks, Pascale

Fixed AgBase annotations.

Fixed UniProt annotations.


Update lib references

Updated Library references to not bound with a specific version.
When tools/references are updated (like Microsoft.Extensions.Configuration.UserSecrets was updated to 1.0.0) the documentation turns outdated

Hi @Tanato, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Looks fine to me :shipit:

@Tanato thanks


Wrong IP count in logs

Hello and good day,
I have done some research on the issue of the script logging incorrect numbers of connected IPs, which several other people have reported, and I would like to share my findings.
My setup consists of a master server and some nodes. Occasionally, some IPs connected to a node or the master server are missing from the Telegram logs. Restarting the Marzban service on the affected server fixes the issue temporarily, but it reoccurs after some time (hours or days) with the same or different nodes.
Moreover, when the script encounters a connection problem with a server, it attempts to reconnect to that server. However, I have noticed through Telegram logs that the script sometimes fails to detect connection problems, so it does not try to reconnect. This causes a drop in connected IPs. When the script finally detects and reconnects to the problematic server, everything returns to normal.
I am not sure if this is a problem with the Marzban or the Houshmand script, but I have observed that when the script reports a connection problem with a server, the users on that server remain connected.
I hope this helps to understand and resolve the problem.

Hi that's right the problem is, if there is problem in sending logs the only way to find out that, is the websocket connection was corrupted. As a result, it's not possible to accurately understand what the problem was (disconnection or some internal issue).
(it's possible the Marzban panel connections with your nodes is disconnected and the logs are not sent to panel properly, I have to test this)
But its possible to do something for example, every 1 hour the connections to get logs (for nodes) will be disconnected and reconnected again.
I think this is how the problem can be solved.

I think it's a smart move to make the script reconnect to all servers periodically. I've been using a cron job since yesterday and I've set it to run every hour. This way, it forces the script to reconnect to all servers and so far, everything has been working well👌👍

Hi sorry if I'm late.
I made some changes to save disable users in a file and after any restart at first script will, enable them and then do other jobs
These changes will make you use Cronjob without problems.
Please clone the project again and check with the new changes to see if your problems are solved.


NEXT-14677 does not work or does not display new reply-to field

PHP Version
8.1.15-3+ubuntu18.04.1
Shopware Version
<IP_ADDRESS>
Expected behaviour
https://github.com/shopware/platform/commit/eabfb20af2c36881f99ebc55e025821e80688037
Shop should show and set reply-to.
additional source: https://issues.shopware.com/issues/NEXT-24953
Actual behaviour

Modal does not show the Reply-To field, instead the from-field is visible
If setting the from-field, the shop will send the email with the from address instead of the reply-to address.

From the source code I can see, the element for reply-to is missing.

I have tested custom and from, but these will set the from-address instead of the reply-to-address.
From: "Max Mustermann"<EMAIL_ADDRESS>
How to reproduce
Upgrade an existing shop to the current version, clear all caches and indexes, then access the flow builder contact and try to set the reply-to.

Update: Also in a newly installed Shopware version <IP_ADDRESS> the problem exists.
as reference: https://issues.shopware.com/issues/NEXT-14677

Update: Version <IP_ADDRESS> still broken


Fix BMI chart

I have fixed BMI Chart
#Description
Replaced the BMI chart image by creating a table of the BMI chart and inserting it using innerHTML property when the form is submitted.
Fixes #(23)

I have fixed the BMI chart by replacing the chart image with a chart table.

@AshutoshSingh2021 Please make a new PR. You have deleted some code in script.js and made some unwanted changes that creates conflicts. Please add and change your codes in particular part and leave the rest as it is.


Buttons not displaying

The title is pretty self-explanatory. Currently, I'm trying to implement buttons into my discord-rich presence. However, trying to do so, I haven't gotten them to appear. I believe my implementation is correct, but I'm just confused if this is an issue on my end or not. Since I haven't been able to get them to appear at all.
Example of how I'm implementing my buttons:

Show more code than this

Show more code than this

There isn't really much to show here, here is how I'm setting up the presence with the ready handler:

Furthermore, to show that the buttons do not exist:

Show more code than this

There isn't really much to show here, here is how I'm setting up the presence with the ready handler:
Furthermore, to show that the buttons do not exist:

Can you send them the whole implementation to take a closer look?

Here ya go, apologies if it is a little scuff:
import hxdiscord_rpc.Discord;
import hxdiscord_rpc.Types;
import sys.thread.Thread;

class DiscordClient
{
    // Callbacks for the client.
    public static var onReady = cpp.Function.fromStaticFunction(_onReady);
    public static var onDisconnected = cpp.Function.fromStaticFunction(_onDisconnected);
    public static var onError = cpp.Function.fromStaticFunction(_onError);

    public static var currentPresence:DiscordRichPresence;
    public static var isInitialized:Bool = false;
    public static var applicationID(default, set):String = "1284932517710794782";
    private static function set_applicationID(newID:String):String
    {
        if (newID is String && isInitialized && newID != applicationID) {
            applicationID = newID;
            Discord.Shutdown();
            _createApplication();
        }
        return applicationID;
    }

    /**
     * Create a new discord client with the defaults.
     */
    public static function initialize():Void
    {
        // Create application
        _createApplication();
    }

	/**
	 * Shutdown the current discord client.
	 */
	public static function shutdown():Void
    {
        Discord.Shutdown();
    }

    /**
     * Incase you make any changes to the presence then call this to update.
     */
    public static function updatePresence():Void
    {
        Discord.UpdatePresence(cpp.RawConstPointer.addressOf(currentPresence));
    }

    /**
     * Create a new client with the given application ID.
     */
    private static function _createApplication():Void
    {
        // Begin the initialization of the client.
        isInitialized = false;
        trace('[Discord]: Client is being initialized...');

        final handlers:DiscordEventHandlers = DiscordEventHandlers.create();
        handlers.ready = onReady;
        handlers.disconnected = onDisconnected;
        handlers.errored = onError;

        Discord.Initialize(applicationID, cpp.RawPointer.addressOf(handlers), 1, null);

        Thread.create(() -> {
            while (true) {
                #if DISCORD_DISABLE_IO_THREAD
                Discord.UpdateConnection();
                #end
                Discord.RunCallbacks();

                Sys.sleep(2);
            }
            Discord.Shutdown();
        });

        trace('[Discord]: Client is now initialized! RPC Version: ${Discord.RPC_VERSION}');
        isInitialized = false;
    }

    /**
     * Private handler for when the client is ready.
     * @param request The discord user's information when client is ready.
     */
    private static function _onReady(request:cpp.RawConstPointer<DiscordUser>):Void
    {
        final username:String = request[0].username;
        final globalName:String = request[0].globalName;

        currentPresence = DiscordRichPresence.create();
        currentPresence.type = DiscordActivityType_Playing;
        currentPresence.state = "testing state";
        currentPresence.details = "testing details";
        currentPresence.largeImageKey = "test";

        final button:DiscordButton = DiscordButton.create();
        button.label = "TEST";
        button.url = "https://www.x.com/";
        currentPresence.buttons[0] = button;

        trace('[Discord]: Client: ($globalName) $username has their client ready!');
        Discord.UpdatePresence(cpp.RawConstPointer.addressOf(currentPresence));
    }

    /**
     * Private handler for when the client disconnects.
     * @param errorCode The disconnection code.
     * @param message The message that was responded with.
     */
    private static function _onDisconnected(errorCode:Int, message:cpp.ConstCharStar):Void
    {
        trace('[Discord]: Disconnected ($errorCode:$message)');
    }

    /**
     * Private handler for when the client errors.
     * @param errorCode The error code.
     * @param message The message that was responded with.
     */
    private static function _onError(errorCode:Int, message:cpp.ConstCharStar):Void
    {
        trace('[Discord]: Error ($errorCode:$message)');
    }
}

Maybe try this implementation.
package utf.util.discord;

#if hxdiscord_rpc
import hxdiscord_rpc.Discord;
import hxdiscord_rpc.Types;
import openfl.Lib;
import sys.thread.Thread;

/**
 * Utility class for handling Discord Rich Presence integration.
 */
@:nullSafety(Off)
class DiscordUtil
{
	/**
	 * Discord Application ID.
	 */
	@:noCompletion
	private static final APPLICATION_ID:String = '1284932517710794782';

	/**
	 * Deamon Thread.
	 */
	@:noCompletion
	private static var deamonThread:Thread;

	/**
	 * Indicates if Discord Rich Presence is initialized.
	 */
	public static var initialized(default, null):Bool = false;

	/**
	 * Initializes Discord Rich Presence.
	 *
	 * Sets up the Discord Rich Presence, starts a background thread for updates,
	 * and ensures proper shutdown on application exit.
	 */
	public static function init():Void
	{
		if (initialized)
			return;

		final handlers:DiscordEventHandlers = DiscordEventHandlers.create();
		handlers.ready = cpp.Function.fromStaticFunction(onReady);
		handlers.disconnected = cpp.Function.fromStaticFunction(onDisconnected);
		handlers.errored = cpp.Function.fromStaticFunction(onError);
		Discord.Initialize(APPLICATION_ID, cpp.RawPointer.addressOf(handlers), 1, null);

		if (deamonThread == null)
		{
			deamonThread = Thread.create(function():Void
			{
				while (true)
				{
					#if DISCORD_DISABLE_IO_THREAD
					Discord.UpdateConnection();
					#end

					Discord.RunCallbacks();

					Sys.sleep(2);
				}
			});
		}

		if (Lib.application != null && !Lib.application.onExit.has(shutdown))
			Lib.application.onExit.add(shutdown);

		initialized = true;
	}

	@:noCompletion
	private static function onReady(request:cpp.RawConstPointer<DiscordUser>):Void
	{
		final discriminator:String = request[0].discriminator;
		final username:String = request[0].username;

		if (Std.parseInt(discriminator) != 0)
			Sys.println('(Discord) Connected to User "$username#$discriminator"');
		else
			Sys.println('(Discord) Connected to User "$username"');

		final discordPresence:DiscordRichPresence = DiscordRichPresence.create();
        currentPresence.state = "testing state";
        currentPresence.details = "testing details";
        currentPresence.largeImageKey = "test";

		final button:DiscordButton = DiscordButton.create();
		button.label = "Test 1";
		button.url = "https://example.com";
		discordPresence.buttons[0] = button;

		Discord.UpdatePresence(cpp.RawConstPointer.addressOf(discordPresence));
	}

	@:noCompletion
	private static function onDisconnected(errorCode:Int, message:cpp.ConstCharStar):Void
	{
		Sys.println('(Discord) Disconnected ($errorCode:$message)');
	}

	@:noCompletion
	private static function onError(errorCode:Int, message:cpp.ConstCharStar):Void
	{
		Sys.println('(Discord) Error ($errorCode:$message)');
	}

	@:noCompletion
	private static function shutdown(exitCode:Int):Void
	{
		if (deamonThread != null)
			deamonThread = null;

		Discord.Shutdown();
		initialized = false;
	}
}
#end

Your code might be faulty tbh.

Your code might be faulty tbh.

Yeah honestly it might be, I'll try out your implementation real quick see if that makes any difference.

Unfortunately I still can't get it to work 😔, I'll see if I can figure something out


Add country

Hi! Could you please add Moldova as MD? Thank you.

Hi,
Moldova is already added as "Moldova, Republic of" which is the ISO 3166 standard name
https://www.iso.org/obp/ui/#iso:code:3166:MD
But you can overwrite that in code by doing this
const { overwrite, getName } = require('country-list');
overwrite([{
  "code": "MD",
  "name": "Moldova"
}])

console.log(getName('MD')); // Moldova


Add PreviousArgs sub-cmd in settings

Proposed changes
This PR adds the previousArgs sub-cmd in settings command.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the CLA
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Coverage remained the same at 100.0% when pulling 359ebd6bf0ed510a3c6b9c296e0a5d94b6e3f8d9 on fisuda:hardening/settings into 8544f85b25853f2a4611974e2377ec611336feea on lets-fiware:main.


MRG: Do regularization in PCA space

We currently do covariance regularization on the full rank data. Thus rank-deficient covariance matrices become full rank. This PR changes it so that regularization is done in the lower-dimensional space, then projected back out, which should preserve the original rank.
This probably has some small impact on full-rank MEG data (e.g., 306 channels with a handful of projs) but the impact is magnified by Maxwell filtering due to the larger rank reduction.

[x] Something is fishy with the loglik values, which are pretty uniformly -39 in the tests across all methods.
[x] Need to check examples
[x] Try on SSS'ed data

Can you explain what are the benefits exactly? Sounds like you've thought this through and came to some insight.

Yes, it makes sense, do you see a big difference in the inverse results?

Okay I think this is ready for review/merge. We should probably wait for 0.18 just to be safe / have time to test it, though, so I'm going to leave set as WIP until we release.

On second thought, I think the tests are pretty convincing, so I'd be happy putting this in 0.17. Let's see if @agramfort @dengemann you are convinced, too :)

Updated examples:

https://10065-1301584-gh.circle-artifacts.com/0/html/auto_examples/inverse/plot_covariance_whitening_dspm.html
https://10065-1301584-gh.circle-artifacts.com/0/html/auto_examples/inverse/plot_lcmv_beamformer.html
https://10065-1301584-gh.circle-artifacts.com/0/html/auto_examples/visualization/plot_evoked_whitening.html
https://10065-1301584-gh.circle-artifacts.com/0/html/auto_tutorials/plot_brainstorm_phantom_elekta.html
https://10065-1301584-gh.circle-artifacts.com/0/html/auto_tutorials/plot_compute_covariance.html
https://10065-1301584-gh.circle-artifacts.com/0/html/auto_tutorials/plot_whitened.html

It looks like most did not change. I did change bst_phantom_elekta to use method='shrunk', which no longer increases the cov rank to 306 (hooray!).

Okay I also fixed the diagonal_fixed estimator defaults in compute_covariance to match those of mne.cov.regularize (I think it was a bug that they did not -- eeg=0. by default for example). I also fixed the FIFF constant checks (and added some constants) because I realized we were missing some for Maxwell filtering.

Talking to @dengemann to be safe we should probably wait for 0.18 to merge this. So I'll set to WIP for now. (Also apparently Travis is unhappy so I have some work to do anyway.) Also I'm not 100% sure the diagonal_fixed result is correct. Need to check.

Fixed the "problem" with the plot_evoked_whitening.py example. The differences were caused in the changes in defaults, which seems okay. URLs above will updated soon to reflect commit a30e48b.

It probably makes sense to get #5146 in after this, as it makes clear exactly what is happening to your data rank at each step (SSP, cov reg, etc.)

@larsoner this looks terrific. Do we have some SSS data example here that shows some more drastic low rank computation? I feel we'd need some example that covers the complaints we received from maxfilter users.

@wmvanvliet FYI this is the continuation of my #4637 that we abandoned last year as we had a few doubts that we could not remove just before the release. @larsoner kept his promise to look into it if I would not insist merging it. Awesome we're getting there! I will run the current code tomorrow with a few pathological SSS recordings I collected over the last 2 years to see where this gets us.

Do we have some SSS data example here that shows some more drastic low rank computation? I feel we'd need some example that covers the complaints we received from maxfilter users.

Yes I modified this example already:
https://10075-1301584-gh.circle-artifacts.com/0/html/auto_tutorials/plot_brainstorm_phantom_elekta.html

@larsoner thank you! I'll checkout diverse SSSd data with it tomorrow. Let's see where we get, perhaps we can merge it before the end of the week.

After playing with several datasets my impression is that this PR does not make things worse than they are. Instead for certain SSS'd the default looks now correct, hence things are improved. As noticed before, the speedup is practically meaningful. I'd suggest to merge this and then work on the outstanding issues in #4676 which are not magically addressed by this PR -- just for expectation management. I'll approve and suggest @agramfort to take his tour.

pushed a cosmit.
now with the inverse method the inverse problem are automagically solved in low rank space? or we still have square whitener even if rank is low?

This does not change the behavior of inverse operators / LCMV. So it's still stored square IIRC though at some point gets reduced internally (at least for minimum norm)

Your cosmit broke a test

to get your forgiveness (if I may ask) let me merge this one...


2.0.0: loop in build dependencies

Describe the bug
Looks like it is th loop in build dependencies because libppd requires pkgconfifig(libcupsfilters) and on building cups-filters 2.0.0 is required pkgconfifig(libppd). 🤔
Both build time requirements are unconditional so it is not possible to build one of those components first without second one and after building second one rebuild first one with enabled build stage dependency of second one.
https://github.com/OpenPrinting/libppd/blob/2.0.0/configure.ac#L122-L125
https://github.com/OpenPrinting/cups-filters/blob/2.0.0/configure.ac#L120-L123
Probably only way to build libppd is to build it against pkgconfifig(libcupsfilters) 1.x and than build libcupsfilters 2.x and again rebuild libppd however after that it is not possible to bootstrap both components.

Closing. I didn't notice that separation of libcupsfilters 2.0.0.


User is prompted for allowing sys.openapi calls in tools repos when using outlook mail tool.

Electron built from commit id https://github.com/gptscript-ai/desktop/commit/59351d72bdcd4eab1b1e454c535ae0d965c37fa5
Steps to reproduce the problem:

Create an assistant with  outlook mail tool.
2.Start conversation  wit this assistant and ask question about your emails.

Notice that  user is prompted  allowing sys.openapi calls in tools repos couple of times:

Expected Behavior:
We should be able to auto accept these sys.openapi calls

PR is ready for this. I'll move it to Testing once it is merged.

Merged. These confirmation prompts should look much better in the UI now.

This issue is not seen anymore when testing with build - 523bf344
User is not prompted for allowing sys.openapi calls in tools repos when using outlook mail /calendar tools.


EXT-X-MAP tags are not marshaled or unmarshaled

Looks like the EXT-X-MAP, which is used to specify the initial segment in fMP4 streams, don't get marshaled or unmarshaled:
alias HLS.Playlist
alias HLS.Playlist.{Master, Media}

content =
  """
  #EXTM3U
  #EXT-X-VERSION:7
  #EXT-X-TARGETDURATION:6
  #EXT-X-MEDIA-SEQUENCE:0
  #EXT-X-DISCONTINUITY-SEQUENCE:0
  #EXT-X-MAP:URI="muxed_header_video_track_part_0.mp4"
  #EXT-X-PROGRAM-DATE-TIME:2024-07-05T20:12:34.845Z
  #EXTINF:5.007755555,
  muxed_segment_0_video_track.m4s
  #EXT-X-PROGRAM-DATE-TIME:2024-07-05T20:12:35.422Z
  #EXTINF:4.996144444,
  muxed_segment_1_video_track.m4s
  """

manifest = Playlist.unmarshal(content, %Media{})

%HLS.Playlist.Media{
  target_segment_duration: 6,
  uri: nil,
  finished: false,
  type: nil,
  media_sequence_number: 0,
  version: 7,
  segments: [
    %HLS.Segment{
      uri: %URI{
        scheme: nil,
        userinfo: nil,
        host: nil,
        port: nil,
        path: "muxed_segment_0_video_track.m4s",
        query: nil,
        fragment: nil
      },
      duration: 5.007755555,
      relative_sequence: 0,
      absolute_sequence: 0,
      from: 0,
      ref: #Reference<0.640784525.3053715459.151562>,
      discontinuity: true
    },
    %HLS.Segment{
      uri: %URI{
        scheme: nil,
        userinfo: nil,
        host: nil,
        port: nil,
        path: "muxed_segment_1_video_track.m4s",
        query: nil,
        fragment: nil
      },
      duration: 4.996144444,
      relative_sequence: 1,
      absolute_sequence: 1,
      from: 5.007755555,
      ref: #Reference<0.640784525.3053715459.151563>,
      discontinuity: false
    }
  ]
}

I took a stab at implementing this and made some progress but wasn't sure how to handle the following part of the RFC:

It applies to every Media Segment that appears after it in the Playlist until the next EXT-X-MAP tag or until the end of the Playlist.

Are there other tags that behave similarly that I could look at? Or ideas on how this should be implemented?

Hi @samrat! Promising. So one similar tag is the x-discontinuity one. On key difference is that we need to associate segments to their x-map tag, as when we download the bytes of that segment we also need to prepend the ones of the header provided by x-map. The discontinuity tag is associated with one segment only, whereas this one is implicitly associated to each of the segments following the tag, so while decoding we need to preserve this mapping, which is a new thing for this library.
I would add that logic here, add a new field in the segments (something like header_uri or similar) and add that value, so each segment is independent. When marshalling, we emit that tag only when it changes.
The responsibility of downloading, caching and prepending the bytes of the header to the segment when the header_uri field is not nil is left to the HLS plugin.

Thanks for the pointers @dmorn ! I've created a draft PR with the changes I've made so far. Happy to make any changes if you already have some feedback.

add a new field in the segments (something like header_uri or similar)

I called it map as this seems to follow the convention of how the tag names are mapped to field names in the Segment struct. But I also get the "map" is a bit generic and might be confusing. Do you think header_uri still makes sense given that it can have both URI and byterange?


Add NUCLEUS_SKIP_SSL_VERIFY for environments

This adds an environment variable to skip SSL checks.

lgtm

Nice, just waiting for tests to pass 🙂


Failure status in blocks

Propagate parties failure status in blocks
Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

ignoring version lint error because I modified the latest version


Feature: npm publish

prepare package.json for publishing to npm

Coverage remained the same at 96.667% when pulling 15b68b061147376e8a278b501fa94790abb37829 on feature/npm-publish into ca626e631df02233ed16408238daf86dabe84633 on master.


docs(v2): describe adding additional Prism syntax highlighting languages (DO NOT MERGE)

As discussed on Discord with @endiliey this PR:

[X] adds instructions on how to add additional Prism syntax highlighting languages
[X] makes minor changes to the highlighting section to keep it readable-as-a-whole
[ ] needs testing or updating before merging because of the issue below

Open Issue
Successfuly tested inside the docusaurus repository without problems.
However, for new init-generated websites there is no prismjs directory inside node_modules, thus breaking this instruction. Reproduce by running:
npx @docusaurus/init@next init my-website classic
ls my-website/node_modules/prismjs

Question: is this to be expected and if so, do we want users to yarn install prismjs themselves? If so, does that mean that "their" bundle size will increase significantly?

Question: is this to be expected and if so, do we want users to yarn install prismjs themselves? If so, does that mean that "their" bundle size will increase significantly?

well ofc they had to install prismjs themselves. But i think increase in size is expected, theoretically only for each lang required.

Thanks, just wanted to make sure all information is known. I have rebased so this can be merged unless you would like to see changes.

Thanks for your help on this one 💯