lightning warning repeatedly without exit while certs are wrong

Bug Report
Please answer these questions before submitting your issue. Thanks!

What did you do? If possible, provide a recipe for reproducing the error.
tidb-lightning.toml with wrong certs in security section

tidb.tls = "false"

What did you expect to see?
Import successfully and no error

What did you see instead?
lightning output warning repeatedly, and it can't be stopped by ctrl-c

root@agent:/data1/cy/src/tidb-lightning# ./bin/tidb-lightning -c tidb-lightning.toml
Verbose debug logs will be written to tidb-lightning.log

[2020/11/10 07:04:59.497 +00:00] [INFO] [client.go:166] ["[pd] create pd client with endpoints"] [pd-address="[db-pd.tidb1326054958621003776.svc:2379]"]
[2020/11/10 07:04:59.505 +00:00] [WARN] [base_client.go:180] ["[pd] failed to get cluster id"] [url=http://db-pd.tidb1326054958621003776.svc:2379] [error="[PD:client:ErrClientGetMember]error:rpc error: code = Unavailable desc = connection error: desc = \"transport: authen
tication handshake failed: x509: certificate signed by unknown authority (possibly because of \\\"crypto/rsa: verification error\\\" while trying to verify candidate authority certificate \\\"TiDB CA\\\")\" target:db-pd.tidb1326054958621003776.svc:2379 status:TRANSIENT_FA
ILURE"]
[2020/11/10 07:05:00.505 +00:00] [WARN] [base_client.go:180] ["[pd] failed to get cluster id"] [url=http://db-pd.tidb1326054958621003776.svc:2379] [error="[PD:client:ErrClientGetMember]error:rpc error: code = Unavailable desc = connection error: desc = \"transport: authen
tication handshake failed: x509: certificate signed by unknown authority (possibly because of \\\"crypto/rsa: verification error\\\" while trying to verify candidate authority certificate \\\"TiDB CA\\\")\" target:db-pd.tidb1326054958621003776.svc:2379 status:TRANSIENT_FA
ILURE"]
[2020/11/10 07:05:01.506 +00:00] [WARN] [base_client.go:180] ["[pd] failed to get cluster id"] [url=http://db-pd.tidb1326054958621003776.svc:2379] [error="[PD:client:ErrClientGetMember]error:rpc error: code = Unavailable desc = connection error: desc = \"transport: authen
tication handshake failed: x509: certificate signed by unknown authority (possibly because of \\\"crypto/rsa: verification error\\\" while trying to verify candidate authority certificate \\\"TiDB CA\\\")\" target:db-pd.tidb1326054958621003776.svc:2379 status:TRANSIENT_FA
ILURE"]

Versions of the cluster

TiDB-Lightning version (run tidb-lightning -V):
./bin/tidb-lightning -V
Release Version: v4.0.8-10-g51d0e7b
Git Commit Hash: 51d0e7bf56f7b5007fbdb310be7b7ef5e68ffcc9
Git Branch: master
UTC Build Time: 2020-11-10 04:38:28
Go Version: go version go1.13.15 linux/amd64

TiKV-Importer version (run tikv-importer -V)
(paste TiKV-Importer version here)

TiKV version (run tikv-server -V):
(paste TiKV version here)

TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

Other interesting information (system version, hardware config, etc):

Operation logs

Please upload tidb-lightning.log for TiDB-Lightning if possible
Please upload tikv-importer.log from TiKV-Importer if possible
Other interesting logs

Configuration of the cluster and the task

tidb-lightning.toml for TiDB-Lightning if possible

[lightning]

status-addr = ":8289"

server-mode = false

index-concurrency = 2
table-concurrency = 6

level = "info"
file = "tidb-lightning.log"
max-size = 128 # MB
max-days = 28
max-backups = 14

[security]
ca-path = "2768/client-ca.crt"
cert-path = "2768/client-tls.crt"
key-path = "2768/client-tls.key"

[checkpoint]
enable = true
schema = "tidb_lightning_checkpoint"
driver = "file"

[tikv-importer]
backend = "local"
addr = "<IP_ADDRESS>:8287"
sorted-kv-dir = "/data2/sortkv"

[mydumper]
read-block-size = 65536 # Byte (default = 64 KB)

batch-import-ratio = 0.75

data-source-dir = "s3://cy-massive-data/uuid_1t_csv?region=us-east-1"
no-schema=true

case-sensitive = false

strict-format = false

filter = ['*.*', '!mysql.*', '!sys.*', '!INFORMATION_SCHEMA.*', '!PERFORMANCE_SCHEMA.*', '!METRICS_SCHEMA.*', '!INSPECTION_SCHEMA.*']

[mydumper.csv]
separator = ','
delimiter = '"'
header = false
not-null = false
null = '\N'
backslash-escape = true
trim-last-separator = false

[tidb]
host = "db-tidb.tidb1326054958621003776.svc"
port = 4000
user = "root"
password = "12345678"
status-port = 10080
pd-addr = "db-pd.tidb1326054958621003776.svc:2379"
log-level = "error"

tls = "false"

build-stats-concurrency = 20
distsql-scan-concurrency = 100
index-serial-scan-concurrency = 20
checksum-table-concurrency = 16

[tidb.security]
ca-path = "2768/client-ca.crt"
cert-path = "2768/client-tls.crt"
key-path = "2768/client-tls.key"

[post-restore]
checksum = "required"
analyze = "optional"
level-1-compact = false
compact = false

[cron]
switch-mode = "5m"
log-progress = "5m"

tikv-importer.toml for TiKV-Importer if possible
inventory.ini if deployed by Ansible

Screenshot/exported-PDF of Grafana dashboard or metrics' graph in Prometheus for TiDB-Lightning if possible

When there are no certs configured, it will output another warning repeatedly
[2020/11/10 07:53:29.222 +00:00] [WARN] [base_client.go:180] ["[pd] failed to get cluster id"] [url=http://db-pd.tidb1326054958621003776.svc:2379] [error="[PD:client:ErrClientGetMember]error:rpc error: code = Unavailable desc = connection closed target:db-pd.tidb1326054958621003776.svc:2379 status:TRANSIENT_FAILURE"]

sounds like pingcap/br#275 (= pingcap/ticdc#562).

It still outputs the warnings for 100 secs with the above PR https://github.com/pingcap/tidb-lightning/pull/468. But the users could ctrl-c to stop the lightning now.


Julia agent-based modeling

https://juliadynamics.github.io/Agents.jl/stable/

Add a nextjournal example for this?

Add a nextjournal example for this?

Nextjournal is not reliable.

Nextjournal is not reliable.

Replaced by https://github.com/NTUMitoLab/BEBI-5009/issues/2


Not able to deploy hdfs app in DCOS due to name resolution errors between datanode and namenode

Run this command -
dcos package install hdfs
It deploys name nodes but data nodes do not show up in the cluster. Looking at the data node task mesos logs, I see these errors like this --
ERROR datanode.DataNode: Initialization failed for Block pool BP-1713926224-<IP_ADDRESS>-1462585594024 (Datanode Uuid null) service to namenode2.hdfs.mesos/<IP_ADDRESS>:50071 Datanode denied communication with namenode because hostname cannot be resolved (ip=<IP_ADDRESS>, hostname=<IP_ADDRESS>): DatanodeRegistration(<IP_ADDRESS>, datanodeUuid=4240027a-63a6-413d-b2f1-7cc156b9aea0, infoPort=50075, ipcPort=50020, storageInfo=lv=-56;cid=CID-dea5b94a-0f35-4158-a249-ef2c1b09d787;nsid=1554246596;c=0)
Some more details about DCOS env -
5 nodes in the cluster
All nodes EC2 - Centos 7
--> systemctl | grep dcos
dcos-ddt.service                                 loaded active running   Diagnostics: DC/OS Distributed Diagnostics Tool
dcos-epmd.service                                loaded active running   Erlang Port Mapping Daemon: DC/OS Erlang Port Mapping Daemon
dcos-mesos-slave.service                         loaded active running   Mesos Agent: DC/OS Mesos Agent Service
dcos-minuteman.service                           loaded active running   Layer 4 Load Balancer: DC/OS Layer 4 Load Balancing Service
dcos-spartan.service                             loaded active running   DNS Dispatcher: An RFC5625 Compliant DNS Forwarder
dcos.target                                      loaded active active    dcos.target
dcos-gen-resolvconf.timer                        loaded active waiting   Generate resolv.conf Timer: Periodically update systemd-resolved for mesos-dns
dcos-logrotate.timer                             loaded active waiting   Logrotate Timer: Timer to trigger every 2 minutes
dcos-spartan-watchdog.timer                      loaded active waiting   DNS Dispatcher Watchdog Timer: Periodically check is Spartan is working

i had wrong resolver when i created DCOS cluster. This issue does not exist anymore


Embedded Resources failure with .NET Core 3.0 RC1

Sample repo is here: https://github.com/matkoch/msbuild-embedded-resource-bug
Relevant csproj definitions are here: https://github.com/matkoch/msbuild-embedded-resource-bug/blob/master/ConsoleApp3/ConsoleApp3.csproj#L9-L12

Microsoft.CSharp.CurrentVersion.targets(100, 9): [MSB3041] Unable to create a manifest resource name for "templates/Build.cs". Could not find a part of the path '/Users/matt/code/ConsoleApp3/ConsoleApp3/templates/templates/Build.cs'.

Note that templates directory gets added twice to the path. This worked with 3.0.100-preview8-013656 at least.

This should be fixed after rc1.

Duplicate of #4695


Implement inputstreamhelper

Types of changes

Displays informative dialogs if required InputStream components are unavailable
Automatically installs Widevine CDM on supported platforms

Keeps Widevine CDM up-to-date with the latest version available
Checks for missing depending libraries by parsing the output from  ldd

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] I have read the CONTRIBUTING document.

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change

Note that the latest version of libwidevine is broken on the Raspberry Pi, this PR should be put on hold until a fix is available.
Here's the report and here the explanation.
Google Translate: "The new libwidevine now decodes the YUV images differently (UV are juxtaposed instead of one above the other).
The kodi internal GL / GLES renderer recognizes what the reason is that it is going on Odroid. RBPI (uses its own h / w renderer) can indeed do that, but needs a) a bit of development and b.) A new firmware. Something will come in the next few days."

@corna This has been fixed in the latest Milhouse builds.
https://forum.kodi.tv/showthread.php?tid=298461&pid=2701351#pid2701351

Both Netflix (this plugin) and Amazon Prime Video (plugin.video.amazon-test) work with the latest libwidevine downloaded by inputstreamhelper from the latest Chrome recovery image on a RPi 3.

I can confirm - latest libwidevine working fine.


AddBranch() is never explained in the documentation

AddBranch() is never explained in the documentation.
For Instance, in your CLI Demo App:
        app.Configure(config =>
        {
            config.SetApplicationName("fake-dotnet");
            config.ValidateExamples();
            config.AddExample(new[] { "run", "--no-build" });

            // Run
            config.AddCommand<RunCommand>("run");

            // Add
            **config.AddBranch<AddSettings>("add", add =>**
            {
                add.SetDescription("Add a package or reference to a .NET project");
                add.AddCommand<AddPackageCommand>("package");
                add.AddCommand<AddReferenceCommand>("reference");
            });

@dlandi to clarify: You are referring to the fact that branches are never really explained on the website, right?

The AddBranch() method, itself, appears undocumented. If there is documentation for it then please let me know where.
Thanks. And great job so far on this library. I am using it in a real project.
-dennis

The AddBranch() method, itself, appears undocumented.

I feel like I'm a bit slow today, sorry. Do you mean in-code (xml) documentation that appears in your IDE?

OK. Here is the in-code comments for AddBranch()

As a newcomer to this library, I need a little more documentation. In my opinion, the explanation should go on your website since you are using it in your sample code to show how your library works.
I really can't decipher what this code is doing by the semantics. Does AddBranch and a command "link" to a command "chain"; or a branch to a tree?
A little more explanation somewhere would be helpful.
-dennis

The requirements of a PR to address this issue is:

Explain the usage of AddBranch on the following page: https://spectreconsole.net/cli/composing, see:

Suggested fix to consider:
Consider splitting out the example into two sections, first giving a code example without the use of a branch eg:

And then giving a second example that uses the AddBranch method, providing an adequate explanation of what it does (eg. composition of nested commands / inherited command settings)

Upvote :)
I'm using this as well and it seams to work. But just because i tried it using the example,
But for instance, can i chain AddBranch methods to build up a more complex command line
For example:
cli branch1 command1 branch2 command1

Using the following code.
var app = new CommandApp();
app.Configure(config =>
{
  config.AddBranch<DefaultCustomerSettings>("branch1", branch =>
  {
      branch.AddCommand<COmmand1>("command1"));
      branch.AddBranch<CreateCustomerCommand>("branch2", branch2 => ....);
  });
});

They definitely chain together @martijnvanschie, see:  https://github.com/spectreconsole/spectre.console/blob/a32dc8030b17e1205d01a24957a13431b4cf33dc/src/Tests/Spectre.Console.Cli.Tests/Unit/CommandAppTests.Branches.cs#L250
Given that nobody's submitted a PR following my suggestion above, I'll do it myself in due course.

Hi @FrankRay78 .
Thank you for the clarification. It has been quite helpful, especially with understanding the inheritance of settings, as I was struggling with the compiler error I received. :)


Multiverse Error

https://pastebin.com/ftwmWUyH

TravelAgent is non existant in 1.14

Please read my comment on #1998. Ticket closed. Duplicate of #1998


feat: add dubbo-spring-boot-tracing-otel-otlp-starter

What is the purpose of the change

add dubbo-spring-boot-tracing-otel-otlp-starter
add OtlpAutoConfiguration to exporter.

samples: https://github.com/apache/dubbo-samples/pull/844
otlp arch:

result:

Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

@songxiaosheng @AlbumenJ PTAL

test in local is normal

There seems to be a problem with the online unit test recently.
Recently, all PR unit tests have failed.

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.2@14b68d7). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 1e3d3cd differs from pull request most recent head 5b51326. Consider uploading reports for the commit 5b51326 to get more accurate results

@@          Coverage Diff           @@
##             3.2   #12299   +/-   ##
======================================
  Coverage       ?   69.32%
  Complexity     ?        2
======================================
  Files          ?     1607
  Lines          ?    66258
  Branches       ?     9719
======================================
  Hits           ?    45935
  Misses         ?    15871
  Partials       ?     4452

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat: add option to disable animated insets

Summary
Fixes #268
and other reports about unnecessary re-renders.
From version 2.8.4 Unistyles is automatically animating bottom insets for Android. This can now be disabled with following config:
UnistylesRegistry
  .addConfig({
    disableAnimatedInsets: true // android only
  })

This feature already works differently on branch 3.x but anyone can disable it without any additional effort.

thank you very much ✌


Web - Being able to request OTP and  login with Phone number with an alphabet at  the end

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to new.expensify.com
Enter phone number mixing with an alphabet at middle or at the end
Click to continue.

Expected Result:
User must get the error message for invalid phone number or email
Actual Result:
User is being able to request OTP and login with correct OTP
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/68a74160-0c7f-4369-af60-467893650ab6
https://github.com/Expensify/App/assets/93399543/5f0edf0f-6692-4b7e-87d9-7c90a5963efa
Expensify/Expensify Issue URL:
Issue reported by: @monikapokhrel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689436172870739
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.

Adding alphabets at last of phoneNumber we are still able to login.

What is the root cause of that problem?

There is only check for !parsedPhoneNumber.possible for mobile number and parsedPhoneNumber returns us possible: true for +911234567890a. And under parsedPhoneNumber we have number key which has filtered number without alphabets in parsedPhoneNumber.number.e164: +911234567890. Thus we are able to login as we are using it.

What changes do you think we should make in order to solve the problem?

We can add a condition to check if entered number has alphabets or not using Str.isValidPhone(phoneLogin) when parsedPhoneNumber.possible is true we can show error message.

Code Snippet
```js
if (!Str.isValidPhone(phoneLogin) && parsedPhoneNumber.possible) {
    setFormError('common.error.phoneNumber');
    return;
}
```

What alternative solutions did you explore? (Optional)

We can update the awesome-phonenumber library to not return true for phonenumber with any unwanted characters/special characters.

What will happen to the reporting bonus since this is closed for another issue?

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: (https://www.upwork.com/freelancers/~01b035610d04d15c6e)


"Run Functional Tests" Task Aborted without Reasons After Running Some Tests

I have a "Run Functional Tests" Task that just got aborted after running for some time. I could see the tests being run, but it just then stopped without any obvious reasons, and all the tests that were run ended up not having any results attached to them.
This happens on any number of tests in a very random fashion. It is very frustrating since after waiting so long for the task, we don't get any results back if it dies prematurely.
Attached is the log for one example. File "5_Run Chrome SPB Tests on $(Win7).log" shows that it ran for roughly an hour, then just died. I was watching the screen the entire time, so I can confirm that it indeed executed the majority of the 77 tests it was supposed to run.
And no, please don't tell me I need to configure one test per task. I have hundreds of tests that can (and should be run) in one task.
Attempt2.zip

Hi
Sorry about this. I am looking into this and will revert soon.
Thank you,
Deepak.

We are working over mail on this issue.

This is resolved now. The issue was due to the timeout setting in the task.


Slash escape bug

Fix bug where a slash (/) character in the serialisedProps causes
the whole page to break when being added to the bottom of a page.
To replicate this issue, add a <script></script> to the data being returned for a component.
See https://stackoverflow.com/questions/35841447/force-json-stringify-to-escape-forward-slash-i-e
for more details about escaping '/' character in JSON.

Hey, thanks for submitting this! I haven't had any time to think about this project, so I'm glad you opened the PR. I'll merge it now and release a new version.

@wildlyinaccurate cheers Joseph!


bind-address=<IP_ADDRESS>

Allow you to connect an external application such as SequelPro or MySQL Workbench.

@gray0018 thanks for your PR, I'm reviewing now, updating tests etc, and will get back to you


Add new acceptance test to soak test BFT chains

PR description
This PR adds a new long-running acceptance test that is designed as a soak test for BFT chains.
It is disabled by default (i.e. acceptanceTestCliqueBft does not run this test) but can be run as an individual acceptance test with ./gradlew acceptanceTestBftSoak.
The current acceptance test tasks for gradle have not been updated to run the new test to ensure that PRs do not require an hour-long test before being mergeable. It is intended to be run manually by anyone who wants to easily run a soak test of the latest code on a QBFT or IBFT chain. Future discussions with the maintainers might decide to add the test somewhere else in the release pipeline.
By default the test runs for 60 minutes, but can be run for much longer by configuring the acctests.soakTimeMins system property in build.gradle. It has been tested for runs of up to 6 hours so far.
Here's a summary of what the test does:

Creates a 4-validator QBFT chain with berlin fork
Starts the nodes
Deploys a smart contract to create some initial state
Attempts to deploy a shanghai contract and checks that it fails
Lets the chain continue mining empty blocks for a proportion of the total run time (e.g. for a 60 minute run it will do this step for 10 minutes)

Every minute it checks that the chain height is increasing, with some tolerance allowed

Stops a node and checks the chain continues to mine blocks

Again every minute it checks that the chain height is increased, but with more tolerance for the slower mining rate

Stops another node and checks the the chain now stalls
Starts both of the stopped nodes. Waits for the chain to continue mining blocks again
Stops all of the nodes one-by-one, upgrading them from berlin to london fork
Checks that the chain continues mining new blocks once the nodes have restarted
Does another check that the state of the smart contract deployed at step 3 is correct (periodic updates are made to the state of the contract in between the other steps so the last check is to make sure the state is correct from the latest update)
Upgrades the chain from london to shanghai
Attempts to deploy the shanghai contract that failed at step 4 and checks that it was successful

If the test is configured to run for twice as long (e.g. 2 hours) each of the main steps runs for twice as long. The test cannot be configured to run for < 1 hour as the timings for the nodes resyncing & QBFT rounds being agreed upon after the chain has stalled have minimum reliable values. There's not theoretical upper limit to how long the test can run for.
Future additions I'd like to add to the test:

~Upgrade the chain from london to shanghai and check that the shanghai contract is deployed successfully~ Added under the latest commit

Also, for reference, just wanted to point out a mainnet/engine api-focussed test that is along similar lines (upgrading to shanghai). For example, this request includes a tx that uses push0: https://github.com/hyperledger/besu/blob/main/acceptance-tests/tests/src/test/resources/jsonrpc/engine/shanghai/test-cases/14_shanghai_newPayloadV2_push0_tx.json

Yeah there are certainly a couple of different approaches used in the tests currently. The BFT acceptance tests use the web3j gradle extension to compile source .sol files at build time with specific EVM/compiler versions. That feels a little better than having to hard-code pre-compiled contracts into test files, although really I think both are perfectly valid. The thing I feel most strongly about is having the option to invoke arbitrary numbers of transactions during a test (i.e. not use pre-created transaction payloads with hard-coded nonces in).

hit a failure in starting the cluster in a BFT AT https://github.com/hyperledger/besu/actions/runs/9104377722/job/25028115138
BftMiningAcceptanceTest > shouldStillMineWhenANonProposerNodeFailsAndHasSufficientValidators(String, BftAcceptanceTestParameterization) > 1: ibft2 FAILED
Nothing in the stack trace to tell me whether it's a port conflict.
But - line 450 is waiting for the ports file so that makes me think it is
at app//org.hyperledger.besu.tests.acceptance.dsl.node.BesuNodeRunner.waitForFile(BesuNodeRunner.java:51)
at app//org.hyperledger.besu.tests.acceptance.dsl.node.ProcessBesuNodeRunner.startNode(ProcessBesuNodeRunner.java:450)
That's the only thing stopping me from approving this, that I don't want to add any more flakiness into the ATs.
if you refactor that method @matthew1001 so that port 0 can be used for existing tests, and the deterministic port can be used for the soak test, I'll approve

the "compile" error is this
* What went wrong:
Execution failed for task ':checkMavenCoordinateCollisions'.
> Duplicate maven coordinates detected, .:besu:24.5-develop-be7c665 is used by both :acceptance-tests:tests and :acceptance-tests:tests:shanghai.

Yeah was just looking at that issue @macfarla It turned out that the approach I used of setting jar { enabled = false } prevented the shanghai contract from being available on the classpath at test runtime. So I re-instated the jar build, but that has re-introduced the earlier error I was seeing where the acceptance-tests:tests and acceptance-tests:tests:shanghai generate the same maven artifact coordinate.
I don't believe we actual publish acceptance test artifacts to maven, and the coordinate it says is clashing is .:besu:24.5-develop-be7c665, which looks like an incomplete artifact coordinate. The other ones we publish are things like org.hyperledger.besu.internal:rlp:24.5-develop-be7c665.
I've just pushed an update which modifies the coordinate-check task. I'm not a gradle expert so I think I'm probably missing a better/simpler fix.

Compilation is looking OK again now @macfarla

Yeah was just looking at that issue @macfarla It turned out that the approach I used of setting jar { enabled = false } prevented the shanghai contract from being available on the classpath at test runtime. So I re-instated the jar build, but that has re-introduced the earlier error I was seeing where the acceptance-tests:tests and acceptance-tests:tests:shanghai generate the same maven artifact coordinate.
I don't believe we actual publish acceptance test artifacts to maven, and the coordinate it says is clashing is .:besu:24.5-develop-be7c665, which looks like an incomplete artifact coordinate. The other ones we publish are things like org.hyperledger.besu.internal:rlp:24.5-develop-be7c665.
I've just pushed an update which modifies the coordinate-check task. I'm not a gradle expert so I think I'm probably missing a better/simpler fix.

@usmansaleem can you review the gradle changes?


clear upstream packages

Remove in favor of upstream pkgs:

pcmsolver
qcelemental
qcengine
i-pi
f2c
mvapich

See https://github.com/markuskowa/NixOS-QChem/issues/56

I just found right now a bug in QCelemental with @eljost, that definitely requires a patch. See also https://github.com/MolSSI/QCElemental/pull/265
Maybe keep QCelemental for now?

OK, that patch should then go into nixpkgs/master and NixOS-QChem/release-21.05.
I will wait with the merge of this PR until we have cleared all packages on our list.

I am going to merge this now, since nixpkgs-unstable has caught up.


Update dependency versions

Changes in this PR

Get the latest framework version v5.25.299[1].
Get the latest org management version v1.3.59[2].

[1] https://github.com/wso2/carbon-identity-framework/tree/v5.25.299
[2] https://github.com/wso2-extensions/identity-organization-management/tree/v1.3.59

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6000851651

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6000851651
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6007678403

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6007678403
Status: cancelled

Closing this PR since the framework bump will be done from [1].
[1] https://github.com/wso2/product-is/pull/16544


Make issues.force_push_codes message shorter

Also removes stray dot and whitespace.
Trying to make base message shorter; I don't envy translators, the message can easily get multi-line in English, I'm sure that is even bigger problem in other languages.

make lg-tm work


Needs a working anti cheat plugin

Project is lacking the anti cheat plugin.

Build it yourself
Its not that hard

Right now this repository just houses the proof-of-concept.
If you're genuinely interested in using the project for practical purposes please let me know and I can work with you to transfer what I have already to a Java plugin. Right now I don't have the time to do it myself, but if you need help with understanding some code I'd be happy to facilitate that.
Thanks,
Jón


⚠ ClamAV has degraded performance

In 9be6027, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 245 ms

Resolved: ClamAV performance has improved in 2900ec6.


Numerical greaterThanOrEqual and lessThanOrEqual do not check for equality

Basically, it is just this:

    /// Value is greater than provided min with the default error
    /// message
    member _.greaterThan (min : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.greaterThan field min
        x.greaterThan min msg field input

    /// Value is greater than or equal to provided min with the default
    /// error message
    member _.greaterThanOrEqualTo (min : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.greaterThanOrEqualTo field min
        x.greaterThan min msg field input

    /// Value is less than provided max with the default error message
    member _.lessThan (max : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.lessThan field max
        x.lessThan max msg field input

    /// Value is less than or equal to provided max with the default
    /// error message
    member _.lessThanOrEqualTo (max : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.lessThanOrEqualTo field max
        x.lessThan max msg field input

Which needs to be this:

    /// Value is greater than provided min with the default error
    /// message
    member _.greaterThan (min : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.greaterThan field min
        x.greaterThan min msg field input

    /// Value is greater than or equal to provided min with the default
    /// error message
    member _.greaterThanOrEqualTo (min : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.greaterThanOrEqualTo field min
        x.greaterThanOrEqualTo min msg field input

    /// Value is less than provided max with the default error message
    member _.lessThan (max : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.lessThan field max
        x.lessThan max msg field input

    /// Value is less than or equal to provided max with the default
    /// error message
    member _.lessThanOrEqualTo (max : 'a) (field : string) (input : 'a) =
        let msg field = ValidationMessages.lessThanOrEqualTo field max
        x.lessThanOrEqualTo max msg field input

These functions already exist, but just have never been called: https://github.com/pimbrouwers/Validus/blob/71f7fc539d7b1249d5c86ceae876b5e807abe521/src/Validus/Core.fs#L72

Thanks for fixing this @pimbrouwers!!! ❤


DO NOT MERGE

Motivation

Changes

Screenshots

Just getting my hands a little bit dirty. Was reading https://github.com/dfinity/gix-components/pull/393 with Maxims.


Participate -quick followup question

Thank you for posting the Participate section - and also thank you for the syntax info, you're right, I am interested in that, and actually kind of reassured that it wasn't too far off, but I like the simple actual syntax.
Just one modification if easy and you have time, to make things a bit more distinct - but just consider your time, can be ok as is:
Under the Calendar section, would it be possible to just reduce the line spacing between each of the twobold-faced item headers and their respective information statements that follows such as (a) below - OR add an indentation for each of the information statements.  (btw, Yes- you're right, the non-renderable characters in that section were (word doc style) bullets!). I didn't put anything in syntax below, (and I don't actually know how to show intentional line spacing gaps) but I was just trying to show visually what I meant by creating a bit of visual space.
(a)
ReproNim ‘First Fridays’ Webinar Series
Webinars occur on the first Friday of every month throughout the academic year
ReproNim ‘First Thursdays’ Virtual Office Hour
Virtual Drop-in Office Hours occurs on the first Thursday of every month throughout the year
I have a meeting shortly, so will be on something else for a little bit, back on thereafter. Thanks!

https://github.com/ReproNim/repronim.org/issues/84
https://github.com/ReproNim/repronim.org/pull/88
@juliebates The spacing was because I made each item a heading section, by removing the headings and just using bold directly, I think I've got what you want. Could you please have a look before I merge?
https://deploy-preview-88--repronim.netlify.app/participate/#calendar

Yes, that looks great - thank you!
Actually I do things (that I don't understand!) with headers in html on the current site to try and fenegle some spacing without really knowing what I'm doing, so what you did to accomplish this seems a bit familiar  ;-)


delete empty npm-shrinkwrap.json

The file was empty and is causing npm install in this repo to fail. @isaacs

@isaacs would you mind publishing another release (or I guess overwriting the Github tag)? CitGM fetches from GitHub, so installing this module currently fails.


Provide an ESM build

It would be appreciable to add an ESM output to the webpack.config.js and reference it in package.json module field.
That way, ESM-enabled bundlers like rollup could make use of it.

The plan is to convert the entire project to ES modules in a future version. Duplicate of #622.


Fix cyclic reference errors while reducing identifiers

Fixes #71230

@vnen @vonagam Don't ask my how or why, but it didn't work the last time around.

As long as you can still open large projects using cyclic dependencies, this sounds like a perfect solution, right?

It is because of change in Enums PR, there was a line in compiler, not connected to enums, which made compiler ignore reduced value of constant if they are meta type.
I think there are some gotchas about usage of that incomplete reduced value in other constants (arrays, dictionaries, callables). Need to check.

Here's the line in question:
https://github.com/godotengine/godot/blob/60d031777b2a922cba03210181c9ba7ad3a6f3ab/modules/gdscript/gdscript_compiler.cpp#L216
So basically, if a thing is a metatype, it usually is a constant. If it's constant, we expect a reduced value. Right now that is being inefficient, because it really ought to check whether it's an enum so it can use the underlying constant dictionary.
But is there a way that we can also use some reduced value for class metatypes?

Hm... Cannot reproduce an issue with usage of class inside other constants. Strange, I had same PR ready six days ago, but decided to not to publish - I thought I encountered some issue, but now I'm not sure, maybe I just imagined it. So, I guess, it is ok.

not using the enum's underlying reduced value

No, as I said in the comment to that line of that PR, enum value gets used, the only inefficiency is that compiler needs to do lookup again to resolve which thing the identifier refers to. In my "PR" I had this line to avoid this small bother and to show that this line is specifically about classes:
- if (p_expression->is_constant && !p_expression->get_datatype().is_meta_type) {
+ if (p_expression->is_constant && !(p_expression->get_datatype().is_meta_type && p_expression->get_datatype().kind == GDScriptParser::DataType::CLASS)) {

No, as I said in the comment to that line of that PR, enum value gets used, the only inefficiency is that compiler needs to do lookup again to resolve which thing the identifier refers to. In my "PR" I had this line to avoid this small bother and to show that this line is specifically about classes:

Sorry, yeah, that's what I meant. It still works, it's just inefficient because it does the lookup again. You should create a PR adding that extra requirement :)

I thought I encountered some issue, but now I'm not sure, maybe I just imagined it. So, I guess, it is ok.

There was a lot of code change in the last days. I'm sure it's not just your imagination. I was the first surprised to see that my PR worked.

It can go in this PR to show why it became possible, but if Adam does not want it - I can open such small PR.
Also next line - error message - should be updated, since it is just shallow script now, not full one.
Just as an example, I had it updated to:
vformat(R"(Error while getting cache for script "%s".)", p_identifier_datatype.script_path)

Updated the error message with your snippet, @vonagam.

@vonagam I added the if (p_expression->is_constant && !(p_expression->get_datatype().is_meta_type && p_expression->get_datatype().kind == GDScriptParser::DataType::CLASS)) { line in GDScriptCompiler::_parse_expression.
I added you as a co-author too, as you contributed more lines than me in this PR. :P

Thanks!


Updating dependencies

Motivation
Update upstream dependencies
What
This PR bumps many of the dependencies in Unified push to more decent versions.  Some dependencies had code changes and will be bumped at a later time.
Verification Steps
This PR relies on a PR from aerogear-parent to be available.

run MVN install on this PR https://github.com/aerogear/aerogear-parent/pull/86
Build UPS
Run UPS
Configure iOS and Android apps
Send a APNS Push Message
Send a Firebase Push Message
Verify messages were received on targets
Verify the node.js sender
Verify the Java sender

Checklist:

[ x] Update AeroGear BOM
[ x ] Update dependencies
[  ] Update AeroGear bom to include the released version of the PR
[  ] Update version information for release

Progress

[  ] Finished task
[  ] Release on GitHub
[  ] Release on DockerHub

I won't have the time or the expertise to review this one I'm afraid :-/ Maybe @pb82 and/or @ziccardi might be good reviewers?


Feature request: Comparision to sanity

Hi, it'd be very helpful to also have a comparision with sanity, since they are said to be similar.

We have the full Sanity comparison posted here: https://payloadcms.com/compare/sanity
You can locate others @ payloadcms.com/compare.


add STIX fonts

[x] brew cask audit --download {{cask_file}} is error-free.

[x] brew cask style --fix {{cask_file}} reports no offenses.

[ ] The commit message includes the cask’s name and version.
Because of the weird URL layout used for the download files (a Past Releases folder that doesn't include the latest version, and a Current Releases folder that does, so downloads would presumably break on a new version anyway), I just added a :latest version.

[x] Named the cask according to the token reference.

[x] brew cask install {{cask_file}} worked successfully.

[x] brew cask uninstall {{cask_file}} worked successfully.

[x] Checked there are no open pull requests for the same cask.

[x] Checked the cask was not already refused in closed issues.

[x] Checked the cask is submitted to the correct repo.

Since the directory has a version 2.0.0, :latest won’t stop the cask from breaking anyway.
Please add a version, and an appcast.

Whoops, didn't notice that. Added.

Thank you for your contribution.


HiDPI Support ?

Application looks very small in HiDPI screen (3200x1800).
is there any tweak to configure messenger to support HiDPI in Gnome 3.16 ?

Same issue. I also have a 3200x1800 panel on my 13" laptop and the text is extraordinarily tiny.
I'm running GNOME 3.18.2
I love the app, please fix :(

I might try to fix that if I have some time, but cant test since I dont have a screen like that.

Running messengerfordesktop --force-device-scale-factor=2 in the Linux terminal worked for me using 2880x1620 display.


Status api

run scale-tests

run scale-tests

rerun tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2e79db6). Click here to learn what that means.
The diff coverage is 31.46%.

@@            Coverage Diff            @@
##             master     #471   +/-   ##
=========================================
  Coverage          ?   29.13%
=========================================
  Files             ?       51
  Lines             ?    10527
  Branches          ?        0
=========================================
  Hits              ?     3067
  Misses            ?     7176
  Partials          ?      284

Impacted Files
Coverage Δ

http/master.go
0% <0%> (ø)

http/pool.go
55.44% <0%> (ø)

http/wsserver.go
58.49% <20%> (ø)

http/wsclient.go
65.57% <35.71%> (ø)

http/server.go
33.09% <52.94%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e79db6...dcca495. Read the comment docs.

run functional-tests-backend-elasticsearch


Andorid startup issue

I'm having the following issue on Android on app startup
using version 1.0.13
2020-06-24 10:17:01.856 13085-13169/com.**.**** E/[ERROR][Leanplum]: [com.leanplum.Leanplum::getContext::351]: Your application context is not set. You should call Leanplum.setApplicationContext(this) or LeanplumActivityHelper.enableLifecycleCallbacks(this) in your application's onCreate method, or have your application extend LeanplumApplication.
2020-06-24 10:17:01.856 13085-13169/com.**.****  E/[ERROR][Leanplum]: [com.leanplum.Leanplum::getContext::351]: Your application context is not set. You should call Leanplum.setApplicationContext(this) or LeanplumActivityHelper.enableLifecycleCallbacks(this) in your application's onCreate method, or have your application extend LeanplumApplication.
2020-06-24 10:17:01.857 13085-13169/com.**.****  E/[ERROR][Leanplum]: [com.leanplum.internal.Util::handleException::882]: INTERNAL ERROR, java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.pm.ApplicationInfo android.content.Context.getApplicationInfo()' on a null object reference
2020-06-24 10:17:01.857 13085-13169/com.**.****  E/[ERROR][Leanplum]: [com.leanplum.Leanplum::getContext::351]: Your application context is not set. You should call Leanplum.setApplicationContext(this) or LeanplumActivityHelper.enableLifecycleCallbacks(this) in your application's onCreate method, or have your application extend LeanplumApplication.
2020-06-24 10:17:01.857 13085-13169/com.**.****  W/[WARNING][Leanplum]: [com.leanplum.internal.Util::getVersionName::381]: Could not extract versionName from Manifest or PackageInfo.
2020-06-24 10:17:01.857 13085-13169/com.**.**** E/[ERROR][Leanplum]: [com.leanplum.Leanplum::getContext::351]: Your application context is not set. You should call Leanplum.setApplicationContext(this) or LeanplumActivityHelper.enableLifecycleCallbacks(this) in your application's onCreate method, or have your application extend LeanplumApplication.
2020-06-24 10:17:01.858 13085-13210/com.**.****  E/[ERROR][Leanplum]: [com.leanplum.Leanplum::getContext::351]: Your application context is not set. You should call Leanplum.setApplicationContext(this) or LeanplumActivityHelper.enableLifecycleCallbacks(this) in your application's onCreate method, or have your application extend LeanplumApplication.

@alradadi Can you post your MainApplication class ? You need to add this two lines to your onCreate method
Leanplum.setApplicationContext(this);
LeanplumActivityHelper.enableLifecycleCallbacks(this);

yes that was the issue. thank you


Adapt screen: usability issues

From Jonathan (milestone 0.3.0):
It's not clear to a novice what to do in this (primary AiM adapting) screen.  There is a big plus sign on the top right which seems to drop down a three-item menu, but I can't tell what the icons in it mean, and they seem to be greyed out.  I can't seem to get any info on what they do by long pressing them, the menu button (of the phone, off-screen) does nothing... there is just no way to get any help from here.  Should there be?
I can in fact touch a word and when I do I get a blue box over it and the empty space below it.  If I press it again it seems to copy the word down below it.  After playing a bit more and editing some words, I find that now when I select a word by touching it, it doesn't just select the word and the empty area below it, it goes straight to copying the word and giving me a way to edit it.  Feels like I somehow "changed mode", but I have no idea how, or why, and there is no on-screen indication of that mode change, if such it really is.  Is this expected and desired behaviour?
Touching the blue less than sign top left exits me back to the "Adapt It Mobile" screen.  Oddly the contents of the project folder are not visible.  There was no indication that a "save" operation happened.  Turns out one did, but seeing my edited document "disappear" was not confidence-building.
[EB] Much of this screen should feel familiar to someone who has used Adapt It desktop before. However, it would be nice to have some sort of walkthrough help -- possibly using a framework like Joyride (http://zurb.com/playground/jquery-joyride-feature-tour-plugin) -- that points out the elements of the UI and how to start interacting with it.

Update on this issue:

I did some more investigation into joyride.js, and it appears to have quite a few dependencies on other ZURB foundation libraries; I think a lighter weight library with no other dependencies is probably in order.
There are a couple other libraries for creating walkthroughs listed here: https://plus.google.com/111385978199979527499/posts/Mh6hQM3psu1. This list is a little out of date, though, and some of the libraries also have dependencies (on Twitter bootstrap, etc.)
LinkedIn has a library called hopscotch, that appears to be well supported, doesn't appear to have any dependencies, and looks pretty easy to use (read -- I've already gotten it to work).

I think I'll develop the walkthrough using the hopscotch library, as it seems to be working well so far.


Allow meeting name, speaker, topic to be passed as part of URL

Previously, calls to http://slide.lansing.codes#javascript would create a slide for the Javascript meetup.  The name should also be tied to the API calls to retrieve upcoming events and other available information.  Currently only the meetup.com API is expected to be supported, but support for other event organizing APIs would be a future improvement.

It looks like meetup is moving to graphQL for their API access and placing it behind a MeetUp Pro subscription.  I'm not sure this can still be accomplished with the MeetUp Pro requirement.

It looks like meetup is moving to graphQL for their API access and placing it behind a MeetUp Pro subscription. I'm not sure this can still be accomplished with the MeetUp Pro requirement.

I think we can query against the Lansing Codes Firestore database. That would allow us to use our own internal identifiers (e.g. demo-night or javascript) instead of Meetup-specific group names and avoid needing to use a Meetup Pro subscription altogether. 😎
Here's a link to what the Firestore database looks like:
https://github.com/lansingcodes/api#using-the-data


adds support for 'data-test-selector' attribute

Adds (optional) attribute bindings for data-test-selector to the sortable-group and sortable-item component.
Not a critical change, rather an improvement for test ergonomics in consuming applications, by following a widely adopted convention around testing with page objects.

Seems like a good idea to me. What do you reckon @acburdine?

Thanks. To be clear: feel free to close this PR if you don't think it's within the scope of the sortable components. One can add the attribute bindings with a reopen in the consuming application. It's just not as user friendly as if the component would support that convention out of the box.

@cspanring SGTM 👍
Had to look up what the test selector was all about (hadn't used them before), but now it makes sense 😄
Thanks for the PR!


[SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly

What changes were proposed in this pull request?
As described  in SPARK-29542 , the descriptions of spark.sql.files.* are confused.
In this PR, I make their descriptions be clearly.
Why are the changes needed?
It makes the descriptions of spark.sql.files.* be clearly.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.

@wangyum

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Oh, In fact, all the parameters started with spark.sql.file are only effective on spark data source table.
Such as:

spark.sql.files.openCostInBytes
spark.sql.files.ignoreCorruptFiles
spark.sql.files.ignoreMissingFiles
spark.sql.files.maxRecordsPerFile

Is it conventional  that files represent data source?

ok to test

Test build #112442 has started for PR 26200 at commit dd28b09.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17410/
Test PASSed.

Test build #112442 has finished for PR 26200 at commit dd28b09.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112442/
Test FAILed.

Test build #112473 has started for PR 26200 at commit 7ecb7b6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17440/
Test PASSed.

Test build #112475 has started for PR 26200 at commit 4a56b2e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17442/
Test PASSed.

Test build #112475 has finished for PR 26200 at commit 4a56b2e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112475/
Test FAILed.

Test build #112473 has finished for PR 26200 at commit 7ecb7b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112473/
Test PASSed.

Looks like the title needs to be updated to contain at least [SQL]. I'm not sure modifying description of config in code should be labeled as [DOC].

Looks like the title of PR needs to be updated to contain at least [SQL]. I'm not sure modifying description of config in code should be labeled as [DOC] in the title of PR.

Thanks.

Test build #112502 has started for PR 26200 at commit 1de48df.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17468/
Test PASSed.

Test build #112506 has started for PR 26200 at commit 7e115d8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17472/
Test PASSed.

Test build #112502 has finished for PR 26200 at commit 1de48df.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #112506 has finished for PR 26200 at commit 7e115d8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112506/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112502/
Test FAILed.

retest this please

Test build #112518 has started for PR 26200 at commit 7e115d8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17482/
Test PASSed.

Test build #112518 has finished for PR 26200 at commit 7e115d8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112518/
Test PASSed.

Merged to master and branch-2.4.


virt-operator: Deploy common-instancetypes

/area instancetype
What this PR does / why we need it:
The common-instancetypes project provides a set of useful instance types and preferences for use when creating VirtualMachines within KubeVirt. Until now operators and users would need to deploy these resources from the upstream project tree, from a specific release or by using the SSP operator.
This PR moves the deployment of the cluster-wide common-instancetypes resources to virt-operator so that they are consistently available across KubeVirt deployments.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9899
Special notes for your reviewer:
Release note:

cluster-wide [`common-instancetypes`](https://github.com/kubevirt/common-instancetypes) resources can now deployed by `virt-operator` using the `CommonInstancetypesDeploymentGate` feature gate.

/retest

/cc

/cc

@fossedihelm You are right about the sha256 sums not being updated automatically, that is still missing and needs to be added, but first we need to add a CHECKSUMS file to the common-instancetypes releases.

@fossedihelm You are right about the sha256 sums not being updated automatically, that is still missing and needs to be added, but first we need to add a CHECKSUMS file to the common-instancetypes releases.

Thank you @0xFelix So this is something that will be addressed with a follow-up PR :)

/test-required

What is the benefit keeping the common instancetypes out of this repository? I would expect having the defined by Go code, we are trying to do less and less bash and other things...

IMHO a separate kustomize repo has several benefits over defining these resources statically in go within this repo:
While not implemented in this initial PR it should enable to to allow operators to deploy modified versions of these resources within their environments, at present SSP allows this through a custom URL to a target kustomize repo but there are various ways we could enable this in virt-operator. Having these resources defined in go within the core repo makes this very awkward for operators.
common-instancetypes also provides namespaced copies of the resources allowing end users to modify and deploy their own versions of these resources easily.
Finally, from a project maintenance perspective the separate repo also keeps the responsibility of maintaining and releasing these resources outside of the already crowded core kubevirt/kubevirt repo.

I defer to @davidvossel on this one as I know he had an idea about this.

I defer to @davidvossel on this one as I know he had an idea about this.

@xpivarc I appreciate that you and @davidvossel have both expressed concerns with the bundling approach taken here but I honestly don't think this is an issue worthy of blocking the feature from landing while it's alpha and off by default.
If there are no concerns with the higher level concept of virt-operator deploying default VirtualMachineCluster{Instancetypes,Prefereces} or concerns with the actual implementation (other than the bundle approach) then I think we should go ahead and land this alongside an issue tracking the bundle issue in v1.2.0.
FWIW I also appreciate that review bandwidth is especially limited at the moment within the approval team given the impact of wider world events but so is the available development time of myself and others who have worked on this feature. We have put a lot of work into this PR thus far and to have it blocked on such a trivial part of the implementation that can easily be replaced before the feature GAs is disappointing to say the least.
Apologies for the rant, just setting out my position on this. Hopefully the renewal of SIGs and possible changes to the design proposal process in the future will lessen the burden on folks both during the cycle and more importantly at feature freeze so we don't discover apparent blockers like this so late on.

/approve

/retest-required


Visual Studio Code open ameba issue on a separate window

For example if I write this simple code:
# TODO: Write documentation for `Web`
module Web
  require "kemal"

  VERSION = "0.1.0"

  get "/" do
    "Hello World!"
  end

  Kemal.run
end

It gives a:
syntax error in 'STDIN:4:3': can't require inside type declarations
on another windows on save only, so you have to undo the save and correct.

Sorry, I didn’t understand what the issue is. There is a syntax error which needs to be corrected. Does ameba plugin somehow prevent you editing the file? Some screenshots could be useful

The syntax error, instead of showing contextually to the line, override the
file and become the first and only line of the file until you undo the save
action.
The if you ctrl-z (undo), you return to the originale file and can modify.
This Is dove of you have format on save option enabled.
Il ven 27 dic 2019, 17:47 Vitalii Elenhaupt<EMAIL_ADDRESS>ha
scritto:

Sorry, I didn’t understand what the issue is. There is a syntax error
which needs to be corrected. Does ameba plugin somehow prevent you editing
the file? Some screenshots could be useful
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/crystal-ameba/vscode-crystal-ameba/issues/4?email_source=notifications&email_token=AGMSOV2K3LY4DSI622QCLR3Q2YWT3A5CNFSM4J75MFX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXOOSY#issuecomment-569304907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMSOV7SI7522NYW3CCZKSTQ2YWT3ANCNFSM4J75MFXQ
.

I don't have any issues locally using the latest vscode plugin, crystal and ameba linter:

It correctly shows me the error, the file can be saved and edited.
Would be nice to have some screenshot/gif to better understand your issue.

Installed Crystal on Ubuntu (Crystal v0.32.1)
Installed Ameba from source (Ameba v0.11.0)
Created a project i(crystal init app web)
Open in VSCode (I have crystal-ameba and crystal-language extension by F. Aguilar)

If I have format on save option or try to format with CTRL + MAIUSC + I it screw like this:

I try to disable your plugin and the problem went again. So probably the problem is with @faustinoaq plugin......what are you using for syntax higlight crystal?

This plugins doesn’t do syntax highlighting, and does not format sources.
@faustinoaq could you please take a look? This is probably related to “Crystal Language” extension.

@veelenga But in your screenshot I see syntax highlighting in crystal file: what are you using?


Improve titles of award tiles that represent placings

Using 1st, 2nd etc would be clearer.

Also in the field of description should be description nit the tutle of the award

3d


WIP: add unit test for mxjob controller

What this PR does / why we need it:
To improve the overall test coverage by adding unit tests for mxjob controller
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1497
Checklist:

[ ] Adding job test form v1beta1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.5%) to 38.26%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller.v1/mpi/mpijob_controller.go
2
75.16%

Totals

Change from base Build<PHONE_NUMBER>:
1.5%

Covered Lines:
2348

Relevant Lines:
6137

💛  - Coveralls


pkg/trace/config: ensure secrets in environment variables get loaded

This change fixes a bug where secrets in environment variables where
ignored by trace-agent.

process-agent counterpart: https://github.com/DataDog/datadog-agent/pull/3564


Grant a permissive license

As of today this project is not published under any license. This makes usage legally doubtful if not even impossible.
Please consider releasing this project under a permissive license.

This was published to maven central under Apache 2, and that metadata should be in the POM for the latest 1.0.1.RELEASE. The actual LICENSE file isn't part of that release tag in the repo, it's been added in master though. I need to re-arrange some things to get the "badge" to show up in github, but for anyones use they should be fine with 1.0.1.RELEASE today under Apache 2.

Hi @william-tran ,
thanks for the update!
A more prominent reference to the project's license on the homepage would be great. Maybe you could name it in the readme.md file and link to dist/license.txt?

Just saw your updates to the project's readme file. Looks great to me, thanks! :-)


APM: Always set trace chunk tags to non-nil to prevent panic

What does this PR do?
Always set trace chunk level tags to be non-nil

Motivation
There is a subtle bug where the probabilistic sampler tries to write to the trace level chunk and the map may be nil (causing a panic). This only occurs when the trace-agent receives a chunk without a pre-existing "decision maker" (_dd.p.dm tag), which explains why none of the existing unit or end to end tests caught this behavior as _dd.p.dm is nearly always included. I was only able to catch this while manually testing the probabilistic sampler with a mixed setup where the trace began with an OTEL tracer before having the context passed to a datadog tracer.

Additional Notes

Possible Drawbacks / Trade-offs
Maybe it's better to just be more defensive throughout the code where we write to this map, but this approach seems sufficient to me for now?

Describe how to test/QA your changes
I've added an integration test that verifies this fix so no manual QA should be required here.

So those tags will always be present but when we have a very old version of the tracer and a new agent or in an OTEL setup right? I assume that in that case, creating the map all the time will increase slightly memory, but with a small order of magnitude compared to a trace so it should be acceptable, right?

Yeah it means a single extra pointer allocation per trace chunk which should be negligible.

Which makes me realize, aren't we supposed to have micro benchmarks on PRs?

hmmm we are: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/501299415 it looks like the job is failing for some reason (but we didn't notice since the job itself passed?) I'll take a closer look


HELP WANTED: Maintainers/Collaborators/Contributors!

It's becoming obvious that the real bottleneck to the project is myself. I have a lot of things I'd like to get done, and this is only one of many hobby projects (The only one so far with any success). I take far too long to respond to issue and PR comments, and I have limited access to resources. Every project has a sweet spot in the ratio between userbase size and developer team size. At the moment, the ~1:10,000 ratio really isn't going to cut it. I need help!
I note several frequent PR and issue openers/commenters who do great work in investigating bugs and fetaures, and it has been suggested at least once in the past that this project could be well served by having more maintainers. (where maintainers == users with write-access to the repository).
To this end, I'd like to reach out and find users who would be willing to share the responsibility for maintaining this tool.
There is so much I'd like to do with this project, and I think it's high-time that it gets a real team. The C and C++ development workflow for VSCode still has a long way to catch up, but I think it can be a formidable contender in the C++ IDE space. I see CMake Tools (among others) being a cornerstone of that goal, and producing a good tool requires good people behind it. I can't do this on my own anymore and haven't been able to for quite a while.
Having a flourishing and appreciative userbase is so rewarding, and I'm so glad I've come this far, but I can't keep going it alone.
I need help with:

Feature development: There's a good stack of feature requests in the backlog that I'd like to get to.
Bugfixes: There are quite a few moving parts, and things break, especially with the many disparate systems that CMake Tools supports.
Automated Test Development: I've neglected to do a lot of work in the automated testing phase. Testing this extension is a bit harder than I expected, but it's completely possible.
Continuous Development/Integration: There is an existing open PR to add CI systems to the extension for proper testing, and I hope that we can see CI merged into the project soon.
Documentation: Even if you have no familiarity with TypeScript, you can help write and maintain the documentation. There's a lot to cover, and any help would be appreciated.
Issue and Release Triage: Having recently passed 100 open issues, I'm starting to feel buried. I tried using releases and milestones previously but fell behind.
macOS: Halp. I don't have one, and all macOS issues just spin in circles until someone else can identify the exact problem or send a PR.

Without further delay: This is my call to action. If you are interested, please send an email to<EMAIL_ADDRESS>Include in the email your GitHub username, area of interest from above, and any other details of particular interest.
Thanks for reading!

This is only somewhat related to the above, but I would suggest that for now, all new PRs should be based on the latest refactor branch, since that is going to be the new structure of the project.
I don't see much sense in committing anything to the dev branch ATM, since it has to be rewritten for the new structure anyway.
On the topic of Maintainers/Collaborators/Contributors, I would be interested, but I can't really promise any consistent input, since I have many other things to do. This would also be pretty much my first project with TypeScript. Just putting that out there.

Thanks @Randshot. Since you're still pretty new to this, I'll wait on giving you write access just yet. Keep up sending PRs and commenting on issues, though: It's a real help.
Don't worry about expectations of consistent contribution. Even I can't maintain consistency in this project, so I wouldn't be expecting that of others.
And don't worry about not knowing TypeScript: This is also my first project in it. I found it a joy to work with after dealing with the treacherous untyped-ness of most scripting languages. Just poke around the codebase and make yourself familiar. Also check out the dev-docs (Maybe a bit out-of-date).

I'm going to close this up, although anyone stumbling on here is still welcome to email me.


Option to save Port Forwarding rules permanently

Putty provides an option to save Port Forwarding Rules along with the SSH session information permanently. It would be good to have similar feature.

Duplicate of #2395


Display artifact on uppermost plot time scale

Version: 0.9.2
Platform: All
Description
The waveform x-axis label is sometimes drawn outside of the x-axis bounds.  When the x-axis changes, this extra text is not cleared and can appear to give false information.
Expected Behavior
Only the actual x-axis labels should be displayed with no extraneous data.
See the forum

Investigated, but no conclusion yet.  See https://github.com/pyqtgraph/pyqtgraph/issues/732

Fixed in 0.9.3.


Is casbin-ex production-ready?

Hello,
very excited to see this Casbin port to Elixir, thank you for making this happen :)
I noticed some of the Casbin ports are denoted as "production ready" in the docs.
Any sense where this port stands in terms of production readiness?
Thank you!

@ngoclinhng

Yes, it definitely is (even though it is still far from completed). We have been using it in production for taskbook since the beginning and have no issues with it.

My apologies for the late reply to you both @hsluoyz @dbi1

@ngoclinhng great! Thanks for the reply :)


Exposing JSX Components

So I am trying to expose all my React components in the bundle to global of the browser (window). I am using the webpack's expose-loader to do so.
I have full success in exposing plain JS modules but when I try to expose JSX modules, it gives me an error:
Module parse failed: ~/project/src/components/list.jsx Line 20: Unexpected token <
You may need an appropriate loader to handle this file type.
...

The error only shows up for the 3rd loader entry that uses expose. If that loaders entry is removed, React components build just fine.
Here's the webpack config file:
module.exports = {
  entry: "./src/components/index.js",

  output: {
    filename: "bundle.js",
    path: __dirname + "/web"
  },

  module: {
    loaders: [
      {
        test: /\.jsx$/,
        exclude: /node_modules/,
        loaders: ["babel-loader?presets[]=react,presets[]=es2015"],
      },
      {
        test: require.resolve("react"),
        loader: "expose?React"
      },
      {
        test: /list.jsx$/,
        loaders: ["babel-loader?presets[]=react,presets[]=es2015", "expose?List"]
      }
    ]
  }
};

I have tried to use babel-loader before the expose loader to try to fix the error but no luck, same error. Has anyone had any success exposing React components globally using web pack before.

Was able to solve it by switching the loaders:
  {
    test: /list.jsx$/,
    loaders: ["expose?List", "babel-loader?presets[]=react,presets[]=es2015"]
  }


Update Contact.html

Issue Resolved: Accessibility & Mobile Responsiveness
This code addresses the issues related to accessibility and ensures that the form remains user-friendly and responsive across different screen sizes.

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


update license

Signed-off-by: Adam Stokes<EMAIL_ADDRESS>

Why assign additional copyrights to us? I thought having Canonical asisgned was sufficient?

Just giving credit where its due.


up-tck: Upgrade Communication Protocol from Socket to gRPC

Change the Test Manager-->Test Agent Communication Pattern to gRPC with Protobuf

We can drop this.  gRPC is efficient way but the current communication (socket+json) is working fine.


Upgrade libgit2 to v0.23.4

The main reason for the upgrade is to enable use of SecureTransport for
https transport.
You can find a full diff here:
https://github.com/libgit2/libgit2/compare/7c63a33ffe1198b77b481974cd0e74e9ace1745c...e8feafe32007ebd16a61820c70abd221655d053c
and the changelog changes:
https://github.com/libgit2/libgit2/compare/7c63a33ffe1198b77b481974cd0e74e9ace1745c...e8feafe32007ebd16a61820c70abd221655d053c#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

:+1:


Panic due to race condition in Write

There is still a problem with concurrency in the Write function. Take the following snippet:
	lbls.mutex.RLock()
	c.tempLabels.mutex.Lock()
	for k, v := range lbls.store {
		c.tempLabels.store[k] = v
	}
	c.tempLabels.mutex.Unlock()
	lbls.mutex.RUnlock()

	// ...

	c.tempLabels = newLabels()

The c.tempLabels variable is re-initialized after it is unlocked, but if another go routine has already locked the mutex before this line executes then it will end up calling c.tempLabels.mutex.Unlock() on the new instance of c.tempLabels which will panic because that mutex is not locked since it is newly created.
I think a better solution is to add a reset function which re-creates the internal map (protected by a mutex) without destroying the actual mutex.

I created a PR which seems to fix the issue:
https://github.com/blendle/zapdriver/pull/14


add default email for apollo user

Coverage increased (+0.09%) to 50.625% when pulling 6cbee9edeeaadc18442e9e5fdd74aff2461672af on lepdou:email into 98d4693b9391d34e5e957128c3e4303edc95a921 on ctripcorp:master.

Codecov Report

Merging #747 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #747      +/-   ##
============================================
+ Coverage     47.02%   47.11%   +0.09%
- Complexity     1543     1546       +3
============================================
  Files           352      352
  Lines          9683     9683
  Branches        959      959
============================================
+ Hits           4553     4562       +9
+ Misses         4790     4781       -9
  Partials        340      340

Impacted Files
Coverage Δ
Complexity Δ

...ervice/service/ReleaseMessageServiceWithCache.java
85.71% <0%> (+1.19%)
24% <0%> (+1%)
:arrow_up:

...work/apollo/biz/message/DatabaseMessageSender.java
66.66% <0%> (+16.66%)
8% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d4693...6cbee9e. Read the comment docs.


Ability to write KQL queries for Application Insights

Similar to Log Analytics we would like to write custom KQL queries for Application Insights.
When Selected Application Insights as a Service in Metrics Tab we would like to see an edit text box to type KQL queries and plot the result set based
At the moment it is limited to InfluxDB datasource query language.

You could use cross workspace query feature for using KQL to query an Application Insights workspace.

Pick the Azure monitor/Log analytics data source Instead of Application Insights.

assuming your appInsights workspace is named "fabrikamapp", in a resource group "Fabrikam" in the "AI-Prototype" subscription.
app("AI-Prototype/Fabrikam/fabrikamapp").requests | count

If your log analytics & Application Insights are in the same workspace then:
app("fabrikamapp")

Refer MSFT docs here: https://docs.microsoft.com/en-us/azure/azure-monitor/log-query/cross-workspace-query#querying-across-log-analytics-workspaces-and-from-application-insights


Cannot get ACC_MEM register data.

Hi,
I'm testing this cool library with Arduino Pro mini and DWM1000.
BasicReceiver.ino works fine.
But when I tried to get ACC_MEM register data additionally I cannot get it properly.
To print ACC_MEM, I made a following function modifying DW1000Class::readBytes()
and called the function from loop() of BasicReceiver.ino when the 'received' variable is true.
BasicReceiver.ino
if (received) {
    DW1000.printAccMem();
    ....
}

DW1000.cpp

void DW1000Class::printAccMem() {
    Serial.println("[ AccMem Start ]");
    byte cmd = 0x25;
    unsigned int n = 4064;
    byte header[3];
    int  headerLen = 1;
    int  i;
    header[0] = READ | cmd;

    SPI.beginTransaction(*_currentSPI);
    digitalWriteFast(_ss, LOW);
    for(i = 0; i < headerLen; i++) {
        SPI.transfer(header[i]);
    }
    for(i = 0; i < n; i++) {
        byte data = SPI.transfer(JUNK);
        char message[50];
        sprintf(message, "Data %d : %d", i, data);
        Serial.println(message);
    }
    delayMicroseconds(5);
    digitalWriteFast(_ss, HIGH);
    SPI.endTransaction();

    Serial.println("[ AccMem End ]");
}

The result is all zeros as follows.
[ AccMem Start ]
Data 0 : 0
Data 1 : 0
Data 2 : 0
Data 3 : 0
....
Data 4062 : 0
Data 4063 : 0
[ AccMem End ]
When I change the 'cmd' value from 0x25 to others (such as 0x15),
it prints proper non-zero values.
Do you get any clue why I cannot print the ACC_MEM(0x25) value?
Thank you

Polling Accumulator CIR memory data is really a "strange" operation for general ranging application.By default,this memory is powered off.
To enable Accumulator CIR output,FACE ,AMCE ,RXCLKS in PMSC_CTRL0 must be set.

if the host system wants to read the Channel Impulse Response Estimate (CIRE) for diagnostic purposes then, the receive clock needs to be present to access the accumulator memory.
-- page 181 of DW1000 User Manual

In normal operation this bit should be set to 0 to allow the
PMSC to control the accumulator clock as necessary for normal receiver operation. If the host
system wants to read the accumulator data, both this FACE bit and the AMCE bit (below) need
to be set to 1 to allow the accumulator reading to operate correctly.
-- page 182 of DW1000 User Manual

After basic initalizing of DW1000 and before your operation,add init code refer to the following:
// libdw1000 on stm32
uint8_t pmscctrl0[LEN_PMSC_CTRL0];
dwSpiRead(dev, PMSC, PMSC_CTRL0_SUB, pmscctrl0, LEN_PMSC_CTRL0);
pmscctrl0[0] &= 0xF3;
pmscctrl0[0] |= 0x48;
pmscctrl0[1] |= 0x80;
dwSpiWrite(dev, PMSC, PMSC_CTRL0_SUB, pmscctrl0, LEN_PMSC_CTRL0);

Polling Accumulator CIR memory data is really a "strange" operation for general ranging application.By default,this memory is powered off.
To enable Accumulator CIR output,FACE ,AMCE ,RXCLKS in PMSC_CTRL0 must be set.

if the host system wants to read the Channel Impulse Response Estimate (CIRE) for diagnostic purposes then, the receive clock needs to be present to access the accumulator memory.
-- page 181 of DW1000 User Manual

In normal operation this bit should be set to 0 to allow the
PMSC to control the accumulator clock as necessary for normal receiver operation. If the host
system wants to read the accumulator data, both this FACE bit and the AMCE bit (below) need
to be set to 1 to allow the accumulator reading to operate correctly.
-- page 182 of DW1000 User Manual

After basic initalizing of DW1000 and before your operation,add init code refer to the following:
// libdw1000 on stm32
uint8_t pmscctrl0[LEN_PMSC_CTRL0];
dwSpiRead(dev, PMSC, PMSC_CTRL0_SUB, pmscctrl0, LEN_PMSC_CTRL0);
pmscctrl0[0] &= 0xF3;
pmscctrl0[0] |= 0x48;
pmscctrl0[1] |= 0x80;
dwSpiWrite(dev, PMSC, PMSC_CTRL0_SUB, pmscctrl0, LEN_PMSC_CTRL0);

Were you able to get the ACC_MEM data? Even after initialization and setting the PMSC, I read the ACC_MEM as zero.


Add Background Fetch

Spec: https://wicg.github.io/background-fetch/
https://github.com/WICG/background-fetch
https://www.chromestatus.com/feature/5712608971718656
https://developers.google.com/web/updates/2018/12/background-fetch

Available at https://caniuse.com/#feat=mdn-api_backgroundfetchevent


Is it possible to embed approve dialog box in Approval Tasks menu of tekton dashboard?

Is it possible to embed approve dialog box in Approval Tasks menu of tekton dashboard?
So I do not need to open http://automatiko-approval-task.default/ to approve.

This is definitely something that would make working with approvals way easier but it is more of an issue in Tekton dashboard to allow such integration. Would you mind opening issue there and link me there?
Currently the only integration is via the extension and that is what automatiko approval tasks already provide. Not much I can do without some work done in Tekton dashboard.

I post here
https://github.com/tektoncd/dashboard/issues/2412

great, thanks, let's continue discussion there, will close this issue.


Windows compiling

The terminios.h dependency requires cygwin is there any plan on changing this?

Would it be possible to compile .exe for the rest of us who are mere users?

@sergeevabc, do you expect it to run inside the CMD prompt (and which – one that supports ConPTY or the legacy console), or Windows Terminal, or some other terminal emulator?


XGBoost ELUC predictor

Checked what the land use percentages represent: I believe they are the percentage of the cell, not the percentage of the total land. That means they do not sum up to 1, and that probably because some cells contain lakes or seas.
Trained an ELUC predictor using XGBoost on UK, Brazil, and UK and Brazil together.

Merging for the sake of progress. Feel free to keep commenting


Update converted file's path with extension .html

Hi there,
Thanks a million for the plugin. I was wondering if it wouldn't make sense to not only update the contents with the converted HTML but also update the converted file's path with the .html extension. I am using your plugin with markdown-collections and when I loop through them using the {{path}} variable in handlebars I still get the old .md link.
Happy to help with a PR, thanks in advance,
Stephan

Nevermind, brain fart on my end. Of course, I need to do the markdown conversion first and then build the collections form the html files. Sorry!


when clause not working on .css file

Testing #177738
tried to change one of the when clauses in my package.json of my extension to:
        {
          "command": "ctxkey-extension.helloWorld4",
          "when": "editorLangId != .css"
        }

and this did not work. I still saw present 4 on a .css file. Not sure if .css is an allowed file type but was inferring based on this section in the doc:
Inequality        |      !=      |      "resourceExtname != .js"

The same: Oh, I'm really sorry, the instruction should've said "it shows in anything that's NOT json - so this works as intended.

Hi! Just to clarify what happened here is I tried to change the value to .css and then it didn't work as intended because present 4 still appeared even when I was on a .css file which given the clause "show present 4 when the editor is not .css" is false. This is a bit more tangential to your issue since I ended up expanding my testing to ask something outside your parameters so maybe this is a separate bug unrelated to your new changes. Sorry this issue is a bit confusing

Oh, should've read the description first, sorry 😅
So the problem in this particular case is that editorLangId has value css for a CSS file -- that's why your when-clause evaluates to true and you see the command.

I use this awesome tool inspect context key values - https://code.visualstudio.com/api/references/when-clause-contexts#inspect-context-keys-utility

Let me know if you have any questions/feedback; I can also review PRs related to when-clause changes in your extension :-)

ah understood thank you! And I will send any of when-clauses I need to add to my extension. Appreciate it!


Which version of ipython is needed for Spyder 2.2.0?

From<EMAIL_ADDRESS>on 2013-01-19T07:50:13Z
Hello,
I am preparing a Debina package for the 2.2.0~beta1.
In the README there is a reference to IPython 0.13+ with qtconsol
In installation.rst a reference to IPython 0.12+
so my question is:
ipython >= 0.12 or 0.13
and
ipython or ipython + qtconsole.
thanks
Frederic
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1229

From<EMAIL_ADDRESS>on 2013-01-24T16:18:23Z
This issue was updated by revision 486dc632837a .
The requirement should be for ipython 0.13+ with qtconole.
Status: Fixed

From ccordoba12 on 2013-01-24T16:53:27Z
Frederic, just to clarify it here, Spyder 2.2 requires IPython 0.13+. We are using some features not present in 0.12 which I myself submitted upstream. See here: https://github.com/ipython/ipython/pull/2007/
Summary: Which version of ipython is needed for Spyder 2.2.0?  <span class="oldvalue"> (was: which version of ipython with spyder 2.2.0) </span>
Labels: MS-v2.2 Cat-Miscelleneous


compile error: no such field: java

I have a JAXB generated field. whose datatype is "Double". when i try to map this field using Orika, I am getting the error(compile error: no such field: java). However it is working fine if i change it from (Double) to primitive type (double).
Here is the mapping of my nested class element
.field("employmentDetails.incomes{netIncomeAmount}", "employerList{incomeType.netIncome}")
I defined "netIncomeAmount" as xs:double. XJC generated the field as "Double". while mapping the fields, orika throws the compile error: no such field: java exception.
I appreciate any comments.
Thanks
Vasu

I figured why we get this exception. If i change my destination field type also to a non primitive type of Double, then it started working.