Is it possible to export selected rows?

First of all, thanks for the great plugin!
I'm wondering if it's possible to export selected rows in the admin interface, rather than the entire model. For example, I can perform a search model/?q=test and click Export, then only the searched fields would be exported. However, if I select say, 3 rows, by checking them, the plugin doesn't export just those 3 rows, but rather the entire model.

Does the plugin support what I'm looking for?
Once again, thanks!

@miceno is right, documented here: https://django-import-export.readthedocs.org/en/latest/getting_started.html#admin-integration
Closing.

@manelclos , I suggest we be explicit, Is it available in the documentation or not ?
Thanks

@huxaiphaer yes it is, see how to use actions here: https://django-import-export.readthedocs.io/en/latest/getting_started.html#exporting-via-admin-action


Remix buildpack

https://remix.run/

Closing this one in favor of: https://feedback.coolify.io/posts/3/buildpack-remix


Adds MDX support and a Tab component for the different examples

Added MDX Support while needing to reimplement some remark-Plugins.
Reworked the Table of Contents due to the new data structure.
Side effect: I also fixed ToC reloading on every link click when the page is first visited and react/gatsby routing didn't take place yet.
Side effect: I fixed that the document headers are not hidden behind the top document bar for mobile and small desktop screensize.
Added a granular Tabs component and a tailored ExampleTabs component for the domain with the fixed three different approaches.
Copy-Toastr is not a faithful reimplementation. I like the "new" one better :).

TODO after deployment (prod/staging):

[ ] Verify if the plugin @darth-knoppix/gatsby-plugin-feed still works with the html field, given that we now process mdx and feed reader look as clean as before.

Couldn't fix, waiting for new version:

[ ] The article http://localhost:8000/docs/hotchocolate/api-reference/language/ currently throws the error Invalid DOM property 'xmlnsXLink'. Did you mean 'xmlnsXlink' from the generated mermaid graphic. This is supposedly fixed in mdx 2.0 https://github.com/mdx-js/mdx/issues/1148

Awesome, can't wait for this one :)

Awesome, can't wait for this one :)

Cannot wait to see it in action 👍

Cannot wait to see it in action 👍

The tabs currently look like this:
Desktop:

Mobile (iPhone SE):

The tabs currently look like this:
Desktop:

Mobile (iPhone SE):

@alex

The tabs currently look like this:
Desktop:

Mobile (iPhone SE):

this is really cool!!

@alex

The tabs currently look like this:
Desktop:

Mobile (iPhone SE):

this is really cool!!

we could even play around with a dropdown in the mobile version. this may scale better with more than three tabs

we could even play around with a dropdown in the mobile version. this may scale better with more than three tabs

we could even play around with a dropdown in the mobile version. this may scale better with more than three tabs

That certainly an improvement. I decided not to do it yet, as we currently don't have more than three tabs and ExampleTabs is tailored for the three different approached.
I would improve it when the scenario comes up :).

we could even play around with a dropdown in the mobile version. this may scale better with more than three tabs

That certainly an improvement. I decided not to do it yet, as we currently don't have more than three tabs and ExampleTabs is tailored for the three different approached.
I would improve it when the scenario comes up :).

Very cool to see progress on the tabs component, just let me know when I could start the review.

Very cool to see progress on the tabs component, just let me know when I could start the review.

@rstaib ready for review :)

@rstaib ready for review :)

I checked rss/atom/feed files and they are valid and working:

They are even looking better than the current prod ones. Only thing we could improv are the headings for rss, the old ones link to the website if clicked, but this is more a nice to have.
There are still some issues, which all will be fixed in a follow up, because they provide the business value and are only small issies:
Tabs still don't look great:

Copy button is not fixed properly when scrolling:

Tabs with text before code look bad:

I checked rss/atom/feed files and they are valid and working:

They are even looking better than the current prod ones. Only thing we could improv are the headings for rss, the old ones link to the website if clicked, but this is more a nice to have.
There are still some issues, which all will be fixed in a follow up, because they provide the business value and are only small issies:
Tabs still don't look great:

Copy button is not fixed properly when scrolling:

Tabs with text before code look bad:

Added a new commit 7b770ceaabc22fa5e681c6a57be9e1e404fd6609 which fixed the horizontal scrolling in the pre tag for small viewports (i.e. language indicator and copy button no longer scroll) and added some margin when a tab begins with a paragraph.

Added a new commit 7b770ceaabc22fa5e681c6a57be9e1e404fd6609 which fixed the horizontal scrolling in the pre tag for small viewports (i.e. language indicator and copy button no longer scroll) and added some margin when a tab begins with a paragraph.

/AzurePipelines Run

/AzurePipelines Run

@fredericbirke at the moment we should not have any text in tabs. If so, then we should probably rewrite the section.

@fredericbirke at the moment we should not have any text in tabs. If so, then we should probably rewrite the section.

@fredericbirke can you point me to the file where you found text inside a tab!? thanks

@fredericbirke can you point me to the file where you found text inside a tab!? thanks

@fredericbirke can you point me to the file where you found text inside a tab!? thanks

http://localhost:8000/docs/hotchocolate/defining-a-schema/unions-and-interfaces/#interface-definition

@fredericbirke can you point me to the file where you found text inside a tab!? thanks

http://localhost:8000/docs/hotchocolate/defining-a-schema/unions-and-interfaces/#interface-definition

@fredericbirke we should rewrite that. But for now we keep it look ugly.

@fredericbirke we should rewrite that. But for now we keep it look ugly.


Cloudflare is challenging RSS bots

RSS reader
Any
All PatchnotesRSS pages

Describe the bug
RSS buttons in patch notes leads to URL like https://steamdb.info/api/PatchnotesRSS/?appid=XXX , which shows RSS XML in the browser. Problem is, this URL is not in exclusion list for Cloudflare protection. This leads to a situation, that all RSS readers available fails to load this feed, because instead, they are served with HTML page informing about requirement of using newest browser and having JavaScript enabled.
Basically, while RSS is meant to be read by simple robots, whole SteamDB is protected by sophisticated filter requiring browser with real user behind it.
I would love to use RSS feeds to be notified about updates to my favorite games.

Should be fine now.


refactor!: Chi: Use u64 for freedom

Removes all degenerate cases for Chi (see #102).
Degrees of freedom k is usually defined as a positive integer. Storing k as a NonZeroU64 avoids all degenerate cases from the start (k < 0, k == 0, k == NaN), and the overhead of casting to an f64 for some operations should be minimal.
NonZeroU64 also allows memory layout optimizations (similar to the nullptr optimization). E.g. std::mem::size_of::<Result<Chi, ChiError>>() is now == 8, when before it was greater than 8.
Also removed all tests that used k = 0, k = NaN, k = +/- INF and other non-integer k (e.g. k == 2.5)

Statically is a great way to remove those cases, thanks!


Results Inconsistency with Official sample_t2i.py Code

Hello,
I have been working with the hunyuan dit library and I've noticed that the results I'm getting are not completely consistent with the ones produced by the official sample.py code.
I've tried troubleshooting the issue on my end, but it seems that there might be an underlying issue with the library itself. I'm not entirely sure what is causing this discrepancy and I would appreciate your assistance in resolving this.
If you are willing to collaborate with us in resolving this issue, we would be very grateful. Once we identify and fix the problem, your contribution can be acknowledged in the hunyuan dit library.
Looking forward to your response and the possibility of working together on this.
Best regards,
Richard

Hello again. As promised, I've made some fixes to the code. Could you please test it again to see if the inconsistencies are still present?


upon trying to make successfull Httpwebrequest  to https://api.postcode.eu/nl/v1/addresses/postcode ends up in authentication failed error.

Hi @janssenr , could you please guide me understanding in why I am failing to make an Httpwebrequest  to PostCode API
[

]
also please refer to the screen shots I have made available here . Anticipating for a quick Reply.

I see you have changed the original code?
Why did you change the original code?
The original code is working (on my computer) ;)

What error do you get?
Because I changed my code to yours, and that's also working.
Or did you change more code?
I cannot see which value you are using for AuthenticationLevel (None, MutualAuthRequired or MutualAuthRequested).
But all three are working on my side.

Did you enter the appKey and AppSecret in the Web.Config?

Hi @janssenr , I did , request to connect with for few minutes for a quick fix at Teams call.

@vidhuamit0606 do you want a call with me?

Hi @janssenr , please take a look at the error I got

What is the error? I don't see the error.

Hi @janssenr , please take look at the error

earlier scrshot was to make you aware of request structure (headers)

Hi @janssenr , can we quickly using TeamViewer

I'm in a meeting at the moment. After this meeting we can.
Can you sent me TeamViewer details?

Meeting is over. So you can sent me TeamViewer details.

Hi @janssen, please connect using credentials as
771 456 777/2wm23s

please share your ID as well to connect

Hi @janssenr are you able to take control now

System.Net.ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12;
Can you try to add this line of code to DoRestCall (before var req)

No response received


Incorrect widget is set for 'declared' fields

Describe the bug
Where we have a resource with a declared field, the default widget is used which can cause problems on export.
To Reproduce
Declare this resource
        class EBookResource(ModelResource):
            published = Field(column_name="published")

            class Meta:
                model = EBook
                fields = ("id", "published")

Save a book with a published date.
Export the book and the published date will be None.
This issue is here.  The declared field never has the correct widget set.

See also #1876 - we cannot infer the widget type if no attribute is provided, so default widget will be used.


Update aws-cli and mc tests to use data-dir

Update dockerfile and Readme

Updated.

Fixed review comments.


bgclang builds broken

Original issue: https://charm.cs.illinois.edu/redmine/issues/1642

The bgclang builds in autobuild have been broken since 7/21/17. Seems like an upgrade to the bgclang compilers might have done this? Or perhaps our test script broke and is no longer loading the bgclang compiler environment properly anymore.
checking machine name... pamilrts-bluegeneq-clang
checking "cp command as"... cp -p
checking "C++ compiler as"... "bgclang++ -Wno-deprecated-declarations     "
checking "whether C++ compiler works"... "no"
Cannot compile C++ programs with bgclang++ -Wno-deprecated-declarations
 (check your charm++ version)
*** Please find detailed output in charmconfig.out ***
make[1]: *** [conv-autoconfig.h] Error 1
make[1]: Leaving directory `/gpfs/vesta-fs0/projects/CharmRTS/nbhat/autobuild/pamilrts-clang-nosmp/charm/pamilrts-bluegeneq-clang/tmp'
make: *** [headers] Error 2
-------------------------------------------------

Original date: 2017-07-26 12:42:05

Assigning to Nitin because he's in charge of the autobuild on BGQ.

Original date: 2017-07-26 22:59:13

charmconfig.out showed that bgclang was not found:
bgclang++ -Wno-deprecated-declarations -I../include -I. -I/bgsys/drivers/ppcfloor/comm/include -I/bgsys/drivers/ppcfloor/spi/include -I/bgsys/drivers/ppcfloor -I/bgsys/drivers/ppcfloor/spi/include/kernel/cnk -I/soft/libraries/alcf/current/xl/ZLIB//include -c test.cpp -o test.o
./configure: line 2212: bgclang++: command not found
This happened because of a recent change in my vesta programming environment i.e I had removed " +mpiwrapper-bgclang" from my ~/.soft. I added it back and was now able to build successfully. This should be seen in tonight's autobuild.


add dispensed_at filter to dispenses list

https://github.com/edenlabllc/ehealth.api/issues/1045

Changes Unknown when pulling b15eecdd2b32fccd50a7734c206be10ca91ba769 on medication_dispense_list#1045 into ** on master**.


Remove the release counts from artist search results

Discogs doesn't give me an easy way to retrieve these as quickly as I want to for the artist search results, so drop it. While I'm at it, add an image icon.

Done.


migrate StringHelper class to namespace common

Hej, if no one is working on this, I can take this

ok, assigned

it would be common namespace

Hej @cieslarmichal is it going to be common::StringHelper:: or just common:: without module name?

Hey @00thirdeye00 just common


misc: migrate all packages to ESM-only

Breaking changes

For plugin authors or others who write server-side code that imports from Docusaurus packages: please migrate your code to ESM as well in order to continue importing our code. We will help migrate a few widely used community packages.

Motivation
Resolve #5379. Since we are now Node 14+, we can work on migrating our packages to ESM to be in sync with the JS community, especially Remark/Rehype.
The current TS tranpilation is not good enough so E2E tests are failing. From the release notes of TS 4.5, there would be prioritized support for ESM, so we can wait to upgrade TS.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
E2E tests, local dev preview

It's almost working! Currently blocked by import-fresh which uses CJS require. Seems the ESM support is stalled: https://github.com/sindresorhus/import-fresh/issues/22

FYI we'd also need to require Node >= 14.14, not just >= 14
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

When I check for features it doesn't seem 14.5 and 14.18 have a big difference besides some class fields stuff... I guess that Sindre Sorhus gist was just playing it safe by recommending the last minor version (while 14.14 is not the last minor version now)? 12.20 is also in the list, so I guess it would be fine. We have CI checks anyways

We have CI checks anyways

CI checks are "14", I suspect it's different than "14.0". We'll figure out later what min version to recommend ;)

@slorber what does import-fresh do anyways? Is it used for watch mode?

importFresh(configPath) ensures notably that when file watchers trigger a site reload, imported JS modules (like config) are not cached and we actually load a fresh config, including the recent updates

I see... I saw somewhere that a common practice is to add unique query strings to each import call in the ESM world, but I also saw there's no proper GC in this case and risks OOM

Yes, the former cached modules will likely stay in the cache forever.
Isn't it possible to keep using importFresh and mixing ESM with some CJS here and there?
Or will we have to ask our users to convert their config/sidebars to ESM too?

Isn't it possible to keep using importFresh and mixing ESM with some CJS here and there?
Or will we have to ask our users to convert their config/sidebars to ESM too?

Config files can stay as CJS as long as they don't try to require any Docusaurus package. I don't know if it would always work; worth trying. importFresh would never work because we use it to load plugins, which are now ESM-only.

There's an interesting suggestion of using worker threads to import fresh modules by killing the worker thread👀 I think workers can offer a new perspective of how Docusaurus works, but not sure if we want such architectural changes.

I like the direction this is going in, but I really don't think ESM is near ready enough.

I like the direction this is going in, but I really don't think ESM is near ready enough.

Well we gotta make this move. MDX v2 is ESM-only, so we either have to build it as CJS and re-publish it, or we stay on v1 forever. A lot of remark/rehype plugins are ESM only as well

Closing because of too many conflicts. We will revisit this in the future, and probably do it progressively (e.g. migrating tests first, then core, then plugins, then utils)


SSL problem with Debian Buster

On Debian Buster I get following error when I try to access a https via normal get request.
{"errno":"EPROTO","code":"EPROTO","syscall":"write"}
Request error:Error: write EPROTO<PHONE_NUMBER>77792:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1536:SSL alert number 40

request.get({
url: "https://warnung.bund.de/bbk.mowas/gefahrendurchsagen.json",
followAllRedirects: true
}, (err, resp, body) => {}});
if you change  /etc/ssl/openssl.cnf it will solve the problem locally:
[system_default_sect]
MinProtocol = TLSv1.2
CipherString = DEFAULT@SECLEVEL=2
to:
[system_default_sect]
MinProtocol = TLSv1.2
CipherString = DEFAULT@SECLEVEL=1

This is unlikely to be a problem with request. What is likely to be happening is certificates on your server are not secure.


Get.toNamed is not working when  I'm on the same page with the same page to go to

Hello, my friends.
I have a page that details a product. Where you go to this page by an item.When i click on this item I go to the details page of this item using the following:
Get.Get.toNamed(ProductDetailsPage.routeName);
Inside the product details page I have a set of similar items where also these elements when you click on one of them you should go to the details of the item using the same expression before:
Get.Get.toNamed(ProductDetailsPage.routeName);
But he doesn't work for me.
Library include:
import 'package:get/get.dart' as Get;
The problem only occurs when I click on the item and I am inside the details page but when I am outside the details page and I click on the item it works well.
When I click on the item and I'm inside the details page, I'm also supposed to go to a details page for the item pressed on it.
Future toNamed(
String page, {
dynamic arguments,
int id,
bool preventDuplicates = true,
}) {
/// I think the problem is from here.
if (preventDuplicates && page == currentRoute) {
return null;
}
return global(id)?.currentState?.pushNamed(page, arguments: arguments);
}

sorry I'm forget use preventDuplicateds
Get.toNamed(ProductDetailsPage.routeName,preventDuplicates: false);

sorry I'm forget use preventDuplicateds
Get.toNamed(ProductDetailsPage.routeName,preventDuplicates: false);


podman: 1.3.2 -> 1.4.1

Motivation for this change
Bump podman to latest release (https://github.com/containers/libpod/releases)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build podman


Support for BMP280 sensor

Hi, impressive work you have done. I try to understand how to make a sensornode with a BMP280 pressure/temperature sensor, but I get lost in the number of examples. So if you can help me a little...?
What example node should I use as a starting point? And where do I put library, setup and loop functions for this sensor? I like to use the EnigmaIOT MsgPack example because I have no experience with Cayenne.
Thx in advance.
Aernout

Right now I'm preparing a how-to-start guide to help others to begin programming their own nodes. It will take a while though. I hope less than one month.
Anyway I will leave some guidelines here. Let me know if it is useful and what challenges you find. It will be useful for my guide.
You can start with a regular Arduino Sketch where you design what you want your node does. A simple setup() and loop() is enough. You can use Serial.printf() where you will finally place message sending.
Point of start is EnigmaIOT JSON Controller Template. It is an empty but already configured template where you can add your code.
Inside BasicController.cpp there are a setup () and loop ()methods where you can insert your code. You can rename CONTROLLER_CLASS_NAME if you like, but it is not mandatory.
You can look at EnigmaIOT-Sensor-Controller example. It is very close what you need but using DS18B20 instead of BMP280.

@ator1811 First version of how to guide is finished in dev branch. Check it there. I will be releasing last version before 1.0 in a few days anyway.

How to guide is released in main branch: https://github.com/gmag11/EnigmaIOT/blob/master/docs/howto.md


xComputer cannot join domain

Under Windows 2016 server, domain join fails with a mysterious message of password not strong enough. Difficult to understand, since the password of a machine account is automatically generated.
The powershell command Add-Computer (echoed in the module with Write-Verbose and then ran by hand) works prefectly if ran under the Administrator account, but it appears to fail under the LocalSystem account used by DSC.
I have read similar reports elsewhere https://social.technet.microsoft.com/Forums/windowsserver/en-US/cb6f2595-c37e-41e2-952d-9d9ae7ea8865/running-powerhshell-addcomputer-as-localsystem-fails?forum=winserverGP but none of the suggestions made have worked so far.

Hi @ramon-garcia - are you able to try using the PsDscRunAsCredential parameter to the resource to have it applied under the context of the Domain Admin to see if that resolves the issue? See this page for more info:
https://docs.microsoft.com/en-us/powershell/dsc/runasuser


Increase accuracy re trademark clauses

Slightly increase accuracy of trademark info:

use not directly forbideen by certain licenses, rather rights not granted
trademark is universal for such licenses, documentation was too specific re related non-grants
CC0-1.0 is one of those licenses with explicit non-grant
BSD and OFL license have no-endorsement clauses, which are a different thing

Make sense to me.

BSD and OFL license have no-endorsement clauses, which are a different thing

Do you think it makes sense to add that as a property?

@mlinksva must accept the GitHub Contributor License Agreement.

You''ll need to click "details" above, and work through the CLA flow to get the CLA test to pass.

@benbalter I did click details and accepted immediately after making PR, but check not updated to passing. At https://cla.github.com/github/choosealicense.com/accept/mlinksva I now see "You accepted this agreement for github/choosealicense.com on December 14, 2015."
Do I need to amend the PR to get it to check again?

Do I need to amend the PR to get it to check again?

If you could, I think that should fix it (and merging in master should fix the other failing test).

@benbalter probably not add a property for no endorsement clauses. I don't think it's a particularly useful detail when choosing a license. But I don't feel strongly at all.

Empty commit fixed CLA detection, but "External link https://help.github.com/articles/github-terms-of-service failed" seems somewhat unlikely. Should the external link checker be trying multiple times?

"External link https://help.github.com/articles/github-terms-of-service failed" seems somewhat unlikely.

Not sure what's going on there. I trigged a new build via the Travis UI, and it came back green. I'd say :+1: as far as I'm concerned whenever you're ready.


Child components registering taps when scrolling

I have a list of TextInputs inside a KeyboardAwareScrollView. I am seeing many situations where, when I start to scroll the list of inputs, the view does scroll, but then when I remove my finger, the TextInput is focused, causing the keyboard to display. I only want to focus on a TextInput when I tap. Do I need to put an eventDefault somewhere to prevent this behavior? At times, the onScroll event doesn't even seem to fire even though the view has started to scroll.

Can you test a regular scrollview with text input? This seems a RN upstream issue.

@alvaromb  I'm sorry, I never saw the notification for your comment. I ended up using a Text component wrapped with a Touchable* component, and then just replace it with a TextInput component when the onPress is fired. I could never identify if this is specific to RN or this library, but it can be closed.


Port already in use

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/blazor-tutorial/run
Operating System: linux
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
Port is already in use by process "dotnet". If I kill the process it automatically starts again.
Error message:
at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
Unhandled exception. System.IO.IOException: Failed to bind to address http://<IP_ADDRESS>:5000: address already in use.
---> Microsoft.AspNetCore.Connections.AddressInUseException: Address already in use
---> System.Net.Sockets.SocketException (98): Address already in use
at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, String callerName)
.....
watch : Exited with error code 134
watch : Waiting for a file to change before restarting dotnet...
When I go to http://localhost/5000, I'm automatically redirected to https://localhost:5001 (httS !!)
I do see some text WELCOME and a link to "Learn about building Web apps with ASP.NET Core", but the menu icons on the left are missing and the page looks very simple. Not as shown on the website.
Sorry I'm a noob, maybe there's something else running from a previous attempt I tried with .Net?
If I edit LaunchSettings.json and use a different port, everything works fine.
kind regards,
MiguelL

@danroth27 @Pilchie can you help here?

@pranavkm any ideas?  Looks like maybe you ran a new mvc app first and it's still running.
@mjl38 what process did you kill above? The dotnet watch one?  It looks like you've got another app still running on your system maybe from another tutorial or command?

Thank you all for answering.
Yes I probably tried another example application some weeks ago, but I think I rebooted my PC when I had the problem and still could not use port 5000 after that.
Strangely enough it now all seems to be working fine and I no longer have more than one "dotnet" running when I run the sample app.
Doing a "netstat -tulpn" would show several dotnet services running. The only one that allowed itself to be killed was the "dotnet watch" one, but of course that's the one I was trying have making use of port 5000.
I must have done something wrong, that's obvious, but can no longer reproduce.
regards,
MiguelL


⚠ Bofrost.de has degraded performance

In ff2b3a9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1197 ms

Resolved: Bofrost.de performance has improved in f4d4216.


Bugfix: allow new-style method animation to be used in animation groups

Motivation
New-style method animations (using the .animate syntax) can't currently be included in AnimationGroup or Succession.
Overview / Explanation for Changes

With this change, animations in the list are checked whether they are a _AnimationBuilder -- and if so, the corresponding animation is built and added to self.animations.
Oneline Summary of Changes

- Bugfix: allow new-style method animation to be used in animation groups (:pr:`PR NUMBER HERE`)

Testing Status

Added a test for AnimationGroup and Succession, passing locally.
Acknowledgements

[x] I have read the Contributing Guidelines

Reviewer Checklist

[x] Newly added functions/classes are either private or have a docstring
[x] Newly added functions/classes have tests added and (optional) examples in the docs
[x] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
[ ] The oneline summary has been included in the wiki

Perhaps there should be a single function to handle this stuff that could be used in AnimationGroup and in Scene, something like
def handle_animation(anim):
    if isinstance(anim, _AnimationBuilder):
        return anim.build()
    elif isinstance(anim, Animation):
        return anim

    raise TypeError(...)

Perhaps there should be a single function to handle this stuff that could be used in AnimationGroup and in Scene, something like
def handle_animation(anim):
    if isinstance(anim, _AnimationBuilder):
        return anim.build()
    elif isinstance(anim, Animation):
        return anim

    raise TypeError(...)

dd54e1fc now delegates building of an animation from an animation factory to a dedicated prepare_animation function.

dd54e1fc now delegates building of an animation from an animation factory to a dedicated prepare_animation function.


[non-admin] Update CAM configuration for a cluster-scoped resource whitelist

ResourceQuotas are cluster scoped resources that namespace scoped resources (Pods) depend on their existence in order to be properly restored. A more common example are PersistentVolumes. Generally, a user cannot list all PVs in the cluster, but CAM requires this to help make intelligent decisions about migrating PVCs in a given namespace.
Our plan to address this is to expose a list of cluster-scoped resources as a configuration option to allow an admin to control which cluster-scoped resources will automatically be migrated in non-admin migration.

ResourceQuotas are created in the namespace for which they apply. So the whitelist wouldn't be needed for them. As for the general whitelist, how will that interact with velero in the case where velero itself (or the plugins) pulls resources in? PVs connected to PVCs are pulled in by velero explicitly. Same with CRDs. For others, such as SCCs, the plugin pulls those in as required to prevent migration failure.

Following up from some thoughts I've had after discussing this with Scott in slack... the more I've thought about this, I think that instead of passing this list of included resources in as annotations to the plugins, we should consider this to be an alwaysInclude list. In fact, it makes me wonder if we should add a new include field into the migplan spec. This would allow us to enable the ability to add label selector usage and other items in the API.

@sseago the more I dig into this, I'm realizing it probably just makes more sense while I'm doing this to expose the full capabilities of the includes/excludes list in Velero. What do you think about a new field on the MigPlanSpec:
type IncludesExcludes struct {
  IncludeNamespaces []string
  IncludeResources []string
  ExcludeNamespaces []string
  ExcludeResources []string
  IncludeClusterScoped bool
  LabelSelector map[string]string
}

That just exposes these fields to be passed into the Velero backup? And then for now the UX doesn't have to change, we can still use IncludeNamespaces but also leave the door open to more customized migrations down the road.

After discussing this further with Jeff, I think it's a bad idea to expose these APIs on the migplan at this moment and will make the validations for non-admin even more difficult than they already are. If we exposed LabelSelector then we would need to validate everything with the label selector can be read by the non-admin user. Not impossible, but no need to add the extra complexity right now.
In fact, the best way to solve this is to simply expose a whitelist for the admin on the MigrationController CR and have the tenant controllers respect this whitelist.
This means NO changes to the MigPlan spec today.

After discussing with Scott... the best way to achieve the same requirement is to make this a blacklist instead of a whitelist. This allows us to document up front which list of cluster-scoped resources will be automatically pulled in for a non-admin migration:

PersistentVolumes
ClusterResourceQuotas
ClusterRoles
ClusterRoleBindings
SecurityContextConstraints

Then, if a non-admin wishes to disable some of these resources to be automatically included (if a ns-scoped resource references it) they can simply list in the blacklist what they wish to exclude.
We will then just pass this in as excludedResources

@dymurray except we need to exclude PersistentVolumes from that list (those aren't optional). What about CRD? Do we include CRD in the list?

@sseago I updated to include CRDs. I don't think we should exclude PVs from that list. It might be desired an admin doesn't want a non-admin to migrate any storage and 9/10 times a non-admin user won't have access to PVs on a cluster.
Obviously we will want to document that if you exclude PVs and someone migrates a PVC backed app then all the data will be lost in a copy scenario and in a move scenario nothing would happen.
I know this seems counter-intuitive as we are giving an admin the ability to really screw up things, but if a user doesn't have access to PVs it might be desired from an admin standpoint to not automatically give them the ability to mutate those resources.

I wonder if when we add PersistentVolumes to excludeResources if we should also exclude PersistentVolumeClaims at the same time. Skipping both would fail more cleanly than just skipping PVs. This should probably also short-circuit PV discovery and the hasPVs checks in the controller so we won't even bother trying to create stage pods, etc.

Also, note that PVs and PVCs wouldn't go onto the same place. Those would show up by removing PVs and PVCs from the includeResources block on the stage backup, while all of the others on the list would show up by adding them to the excludeResources block on the initial backup.


docs: update CONTRIBUTING.md     FIXES #128

Signed-off-by: Stephen Steiner<EMAIL_ADDRESS>Description
Updated CONTRIBUTING.md to be more clear regarding the pre-commit script process.
Motivation and Context
The doc didn't make it clear that if pre-commit changed any files, that a failure would occur and that it is normal for this.
How Has This Been Tested?
Docs only, no testing needed
Types of changes

Docs

Checklist

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

Not sure I follow. Are you recommending that we simply link to another set of docs within the README as opposed to a CONTRIBUTING doc within each repository?

Affirmative @ntwrkguru . My opinion is:

detailed example of contribution somewhere in the https://github.com/PaloAltoNetworks/terraform-best-practices
README here: one or two paragraphs and a link to that
CONTRIBUTING can be deleted from this repo as a separate file


Script not returning robots and information.

The guidance in the Roomba2 plug-in directions is not yielding the intended result.
Expected Behavior
Expecting to return two robots with BLID and passwords.
Current Behavior
Code is running but not returning information.
Steps to Reproduce (for bugs)

Versions

Homebridge: 4.2.8
Node:       16.17.1
Plugin:        1.3.1

Configuration

Homebridge Log / Command Output

hoobs@hoobs:~$ sudo npm install -g dorita980
[sudo] password for hoobs:
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>request-promise has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

changed 126 packages, and audited 127 packages in 36s

3 packages are looking for funding
  run `npm fund` for details

4 high severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
hoobs@hoobs:~$ cd /usr/lib/node_modules/dorita980
hoobs@hoobs:/usr/lib/node_modules/dorita980$ sudo npm run get-password-cloud<EMAIL_ADDRESS>password

><EMAIL_ADDRESS>get-password-cloud
> node ./bin/getPasswordCloud.js

Usage: npm run get-password-cloud <iRobot username> <iRobot password> [Gigya API Key]
hoobs@hoobs:/usr/lib/node_modules/dorita980$

@Yeaori I wonder what version of node and npm you're using.
Try typing:
node --version
npm --version

Where you are showing the output:
> node ./bin/getPasswordCloud.js

It should be showing:
> node ./bin/getPasswordCloud.js<EMAIL_ADDRESS>"password"

A shot in the dark, but perhaps try running the command like this instead:
sudo npm run get-password-cloud --<EMAIL_ADDRESS>password

@Yeaori Perhaps also give the latest beta version of the plugin a try. You should be able to obtain your Roomba's password using its IP address. See the README Setup instructions for this plugin.


Directive on thead was triggered twice

Like this:
<table ng-table="tableParams" class="table ng-table-responsive">
       <thead scroll-float scroll-float-top="40">
       </thead>
</table>

directive scrollFloat will be triggered twice.
Is it allowed directive bind on thead?

So when you use ngTable you normally either let the directive generate the thead element of your table. ie you don't specify the thead directly. In the scenario where you want to customize the header you would then either supply a template for a specific th cell, or a template responsible for rendering the entire thead.
So what is your use case for wanting to define the thead "inline" in the code snippet above?

Cause I make a directive named scrollFloat used to force thead or other elements fixed to browser.It's a common directive and I think it's a goods way to realize it by directive. Maybe I could realize it by factory or other ways , while I just like to have a try.

Have you tried creating a custom header template like in the demo: http://ng-table.com/#/demo/5-8
By doing it this way, you might resolve your problem

Hi,
the THEAD tag is created even if it's present. Look the source of the mentioned example to see the bug.
On your directive the line
04-controller.js:88 -> angular.forEach($element.children, function(e) {

Sould be
angular.forEach($element.children(), function(e) {

Right ?


Fix bug when logging outside of hangfire.

https://github.com/AnderssonPeter/Hangfire.Console.Extensions/issues/1
Fix bug for serialization to seq.
https://discuss.hangfire.io/t/serilog-seq-with-hangfire-console/7428/2

A few questions.

what is the point of PerformContextValueXX?
why are you passing null to PerformContextValue? (im not home so I can't check what it does)

Peter,
The "PerformContextValueXX" was my mistake. That was your original class that I renamed.
I removed it.
The LogEventPropertyValue was switched to  ScalarValue.
and I took that from this example.
Br


bugfix: correct node rank

What does this PR do?
Corrected the logic of calculating rank from dividing by num_nodes to num_gpu_per_meachine
Fixes #19436

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ yes ] Is this pull request ready for review? (if not, please submit in draft mode)
[ yes ] Check that all items from Before submitting are resolved
[ yes ] Make sure the title is self-explanatory and the description concisely explains the PR
[ yes ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19437.org.readthedocs.build/en/19437/

I think this is a common problem that almost everyone who uses multiple machines and multiple cards for training will encounter. Should a quick fix be released?

Hey @cauyxy,
Would you mind adding a test ?
Best,
T.C

Hey @cauyxy, great catch !
Would you mind adding a test ?
Best, T.C

Just like the previous one, it might take me some time if I were to do it myself. Can you help me out?😊

i have added test for dist training when gpu_per_node > node_num


godot, godot-mono: Update checkver to rely on GitHub Releases

Download URLs are from GitHub Releases, so it makes more sense to use checkver from GitHub.
This also fixes checkver as it recently broke due to design changes on the Download page.
I ran checkver.ps1 locally to update the manifest and make sure it works as expected.

[x] I have read the Contributing Guide.

/verify


Everything is a file?

Like Plan 9, you dig?

I think the way it deals with Name Spaces should also be considered: http://www.cs.bell-labs.com/sys/doc/names.html

http://antfarm.9gridchan.org/ANTSFAQ


slurm mandatory partition and non-mandatory qos are not always mandatory and non-mandatory.

See Parsl/libsubmit#66

@tomglanzman has encountered this now (see comment on the corresponding libsubmit issue)


Expose some simple api functions

Adding minimal plugin api
Changes:

Adds accessable api functions to this plugin: copy-as-html
Fixes the desktop-only file read error (tested on my own android mobile)
Added wait for promises completion to the ppIsProcessing flag

Added Functions

Note: These functions are added to the plugin instance itself.
Note: All functions are async! They return promises you must await!

Convert View
Convert a markdown view to an html element.
Params:

{MarkdownView} view The markdown: view to convert
{{convertSvgToBitmap: boolean, removeFrontMatter: boolean}} options: The options to pass to the converter.

Return:
Promise<HTMLElement>: A promise for an html element with the result of the markdown as html
Convert Markdown
Convert a raw markdown string to an html element.
Note: This may cause tabs to open and close temporatily in the background, this is nessicary to render the items property without using the current view.
Params:

{string} markdown: The raw markdown content string to convert
{string | undefined} sourceFilePath: The source file to use for fetching frontmatter, links, embeds, etc.
{{convertSvgToBitmap: boolean, removeFrontMatter: boolean}} options: The options to pass to the converter.

Return:
Promise<HTMLElement>: A promise for an html element with the result of the markdown as html
Credits

mvdkwast for the base plugin: copy-as-html

Hi @MeepTech,
Thanks for your contribution. The idea of having an API for rendering markdown to HTML is great. I've regular questions about this on Discord, and I've seen several similar implementations in other plugins, so this would probably be useful. Ideally this functionality would be exposed directly by Obsidian (have some option to do a complete render with the MarkdownRenderer).
Where I have my doubts is about tying other plugins to this one directly. Maybe it would be better if we made this code available as an npm package ?
I'm also curious about your use-case for these APIs. Can you tell me more ?

Hello back @mvdkwast, and thanks for the timely response!

Where I have my doubts is about tying other plugins to this one directly. Maybe it would be better if we made this code available as an npm package ?

I think I agree with you here, though I'm not too familiar with how to do this myself. Can you recommend any articles or offer any assistance here for how I'd look into modifying this change into an npm package?

I'm also curious about your use-case for these APIs. Can you tell me more ?

Sure thing!
My current personal use case is for testing other plugins in obsidian easily and viewing the results in a collective note.
I use your plugin to convert sections of a document into html and then get the inner text to help make comparisons of results easy and to ignore styling in results providing false error positives.
I am also using the exposed apis in my collective meta-scry plugin here that covers a lot of ways to de-compile and re-compile your notes into data (mostly a personal project):
https://github.com/Meep-Tech/obsidian-metadata-scry-plugin
I can also think of other use cases, such as providing previews for RESTful endpoint access to notes and for serialization of dataviewjs queries into html.

All very interesting  use-cases !
About converting this to a package, I never did this myself, so I would have to do some research. The approach would be basically to move all the rendering code to this package, and make this plugin and yours use the lib. I'll try to find some time this week to see how this can work.

@mvdkwast I think i've found out how to publish plugins as a lib. I'll look into it sometime this week some more.

Hi @MeepTech, closing this PR as it's been a while and it seems that I won't be able to find any time soon to work on this.


python-cli: support expiration

Closes https://github.com/preludeorg/libraries/issues/351

This code does not work.

The date time in the SDK is not JSON-convertable
The functionality just simply doesn't work. Why? Backbone required an updated query to ensure the insert succeeded. Expires, as a property, wasn't even in the SQL command at all. How did you test this?

I have fixed both areas and did a quick smoke test validation.


Deriving text input actions: replace text vs. append text - 2 different actions?

Deriving text input actions is currently only creating replace text action (select all, paste or input text to replace the old text).
Append text could be also possible, adding more text into existing text could be another type of action.

In the proposed protocols, TESTAR allows users to use a boolean variable to choose if they want to perform a typing or pasting action by replacing the existing text or adding the text to the end.
https://github.com/TESTARtool/TESTAR_dev/blob/e978aed623ecb068dba755402065a1b278ae3469/core/src/org/testar/monkey/alayer/actions/StdActionCompiler.java#L251
https://github.com/TESTARtool/TESTAR_dev/blob/e978aed623ecb068dba755402065a1b278ae3469/core/src/org/testar/monkey/alayer/actions/StdActionCompiler.java#L322
For now, we will close this issue and open new and more specific typing issues if needed. For example, the Replacing text action always uses the Ctrl + A combination #377
Or future challenges with action abstraction :)


Fragments on List-types syntax checking

Hi,
I have a scema with a field of type [Bar] (GraphQLList of a GraphQLObjectType derived class called Bar). This works fine, and querying with GraphiQL works fine, except the syntax checking complains about the type on the fragment type.
Am I doing it wrong? Is my GraphQL implementation/scema (graphql-dotnet) wrong? Or is there a bug in the syntax checking for fragment types in GraphiQL?
Below, the first [ of [Bar] is marked with error message "Expected Name, found [".
query foo {
  bars {
    ...F1
  }
}

fragment F1 on [Bar] {
  baz
}

EDIT: Now found that Relay does not like the syntax either (same error) so I guess I am doing something wrong.

query foo {
  bars {
    ...F1
  }
}

fragment F1 on Bar {
  baz
}

Should work.
F1 as a selection set applies to Bar, so that's what it is marked as. It can be included on a field that is any non-null/list modification of Bar, including [Bar].

@MartinLorensen  Could you please share the code for schema with a field type "Bar" (GraphQLList of a GraphQLObjectType derived a class called Bar)? That is for my reference. Thank you.


Nice piece of work...

I came across your project after having a bit of a hard time with the "official mediasoup-android" lib, which seems to be abandoned.
This lib is stuck at M94, max M98, but that was it (since Google "decided" to no longer support the "use_custom_libcxx" flag).
So I was surprised to find this nugget here. Thanks for sharing. It took me 30 minutes to remove the old android libmediasoup solution in my Java project and replace it by your lib.
I have some minor important "issues" and two more severe:

With M114 now finally my OnePlus "has" a H.264 hardware codec, but I cannot make the lib use it, even I provide an encoder object in my PeerConnectionFactory option to the Device() and even if I favour it in "codec".
I can receive DataChannel from another publisher using Mediasoup JS. But I can't send. Or better: My sendings disappear. I can follow them until they seemingly leave (Trace on Android saying: "DcSctpTransport0->SendData(sid=0, type=0, length=19)). None of these messages are received by my consumer(s). Meanwhile I thought it would work, and in fact it worked once but it is not reliable.

Would be great if you could provide some hints, how to tackle this.

I found the reason for H.264 not working. It's a pretty nice bug chain. I'm willing to share details or even create a PR, if you are interested.

Excellent. Please share more details.

Oh, I just now found your add on regarding RTCComponentFactory and MediaConstraintsOption. This is different from how it was in this project https://github.com/haiyangwu/mediasoup-client-android. Maybe using this renders my patches obsolete, let me check that.
So please all following is with the proviso that the use of your supplementary classes does not shift the whole picture.
Anyway, I created my own PeerConnectionFactory (HardwareEncoders only) and provided this to
mMediasoupDevice = new Device(mPeerConnectionUtils.mPeerConnectionFactory);

My Kotlin is bad, but I thought this provided PeerConnectionFactory was not taken over into the local variable in the constructor of the device.
https://github.com/crow-misia/libmediasoup-android/blob/c8f74f5cad64c51381fbfa1d8fd9335db0ec4d8d/core/src/main/java/io/github/crow_misia/mediasoup/Device.kt#L151
I changed this, so that I have the custom PeerConnectionFactory object in the local variable of Device.kt of the same name. It is used later.
The following call:
mMediasoupDevice.load(String.valueOf(getRouterRtpCapabilityResponse));

finally ends up in nativeLoad, from which it dives into core/deps/libmediasoupclient/src/Device.cpp, function Load.
While all load functions up to here just took a string rtpCapabilities, now for the first time an additional PeerConnection::Options object appears, which is - according to the traces - a nullptr, because nobody was giving that to the function. But exactly this object is supposed to carry my custom peerConnectionFactory:
void Device::Load(json routerRtpCapabilities, const PeerConnection::Options* peerConnectionOptions)

In fact, the PeerConnectionFactory is currently provided to the lib a couple of lines later, when the "createSendTransport" is called. That means that it comes  too late and all means to determine the local codec caps have been run already. H.264 hardware codec was ruled out already.
So I patched all responsible files and headers to carry the PeerConnectionFactory to the final load function in core/deps/libmediasoupclient/src/Device.cpp earlier. The patch is for sure not that elegant, since it re-uses JavaToNativeOptions and needs the rtcConfig for that, but I guess you will see, what my aim was. It works for me.
While reviewing this, I think now, that even if I would use your way of dealing with the PeerConnectionFactory (mentioned above), it would come to the same end, if not changed like so or similar.
Here is the patch.
diff --git a/core/src/main/java/io/github/crow_misia/mediasoup/Device.kt b/core/src/main/java/io/github/crow_misia/mediasoup/Device.kt
index 3d64c9a..f377312 100644
--- a/core/src/main/java/io/github/crow_misia/mediasoup/Device.kt
+++ b/core/src/main/java/io/github/crow_misia/mediasoup/Device.kt
@@ -1,6 +1,7 @@
 package io.github.crow_misia.mediasoup

 import org.webrtc.PeerConnection
+import org.webrtc.PeerConnection.RTCConfiguration
 import org.webrtc.PeerConnectionFactory

 /**
@@ -30,9 +31,9 @@ class Device(
     /**
      * Initialize the Device.
      */
-    fun load(routerRtpCapabilities: String) {
+    fun load(routerRtpCapabilities: String, configuration: RTCConfiguration) {
         checkDeviceExists()
-        nativeLoad(nativeDevice, routerRtpCapabilities)
+        nativeLoad(nativeDevice, routerRtpCapabilities, configuration, this.peerConnectionFactory.nativePeerConnectionFactory )
     }

     /**
@@ -119,7 +120,7 @@ class Device(
     private external fun nativeIsLoaded(nativeDevice: Long): Boolean
     private external fun nativeGetRtpCapabilities(nativeDevice: Long): String
     private external fun nativeGetSctpCapabilities(nativeDevice: Long): String
-    private external fun nativeLoad(nativeDevice: Long, routerRtpCapabilities: String)
+    private external fun nativeLoad(nativeDevice: Long, routerRtpCapabilities: String, configuration: PeerConnection.RTCConfiguration, peerConnectionFactory: Long)
     private external fun nativeCanProduce(nativeDevice: Long, kind: String): Boolean
     private external fun nativeCreateSendTransport(
         nativeDevice: Long,
@@ -148,6 +149,6 @@ class Device(
     ): RecvTransport
 }

-fun PeerConnectionFactory.createDevice(): Device {
-    return Device(this)
+fun PeerConnectionFactory.createDevice(peerConnectionFactory: PeerConnectionFactory): Device {
+    return Device(peerConnectionFactory)
 }
\ No newline at end of file
diff --git a/core/src/main/jni/device.cpp b/core/src/main/jni/device.cpp
index c50836e..d40a588 100644
--- a/core/src/main/jni/device.cpp
+++ b/core/src/main/jni/device.cpp
@@ -75,13 +75,16 @@ extern "C"
       .value_or(nullptr);
   }

-  JNI_DEFINE_METHOD(void, Device, nativeLoad, jlong j_device, jstring j_routerRtpCapabilities)
+  JNI_DEFINE_METHOD(void, Device, nativeLoad, jlong j_device, jstring j_routerRtpCapabilities, jobject j_configuration, jlong j_peerConnectionFactory)
   {
     MSC_TRACE();

     handleNativeCrashNoReturn(env, [&]() {
       auto capabilities = JavaToNativeString(env, JavaParamRef<jstring>(env, j_routerRtpCapabilities));
-      reinterpret_cast<Device*>(j_device)->Load(json::parse(capabilities));
+        PeerConnection::Options options;
+        JavaToNativeOptions(env, JavaParamRef<jobject>(env, j_configuration), j_peerConnectionFactory, options);
+
+        reinterpret_cast<Device*>(j_device)->Load(json::parse(capabilities), &options);
     });
   }

diff --git a/core/src/main/jni/device.h b/core/src/main/jni/device.h
index 64e260f..278d532 100644
--- a/core/src/main/jni/device.h
+++ b/core/src/main/jni/device.h
@@ -26,7 +26,7 @@ extern "C"

   JNI_DEFINE_METHOD(jstring, Device, nativeGetSctpCapabilities, jlong j_device);

-  JNI_DEFINE_METHOD(void, Device, nativeLoad, jlong j_device, jstring j_routerRtpCapabilities);
+  JNI_DEFINE_METHOD(void, Device, nativeLoad, jlong j_device, jstring j_routerRtpCapabilities, jobject j_configuration, jlong j_peerConnectionFactory);

   JNI_DEFINE_METHOD(jboolean, Device, nativeCanProduce, jlong j_device, jstring j_kind);

Released v0.13.0 with your fixes.
Added RTCConfiguration to load method.
The PeerConnectionFactory.createDevice method is just a helper method, so there is no point in adding parameters.
It is equivalent to new Device(peerConnectionFactory) .

Thanks. Will give it a try.

The PeerConnectionFactory.createDevice method is just a helper method, so there is no point in adding parameters.
It is equivalent to new Device(peerConnectionFactory)

I agree. If the peerConnectiomFactory given in the constructor is available during the Device.load function, there is no need to provide it otherwise. But IMHO this was not the case before my admittedly clumsy patch. I know this for sure since I was dependent on a hardware encoder, which I instantiated in my peerConnectiomFactory. That was not available at nativeLoad.

Perfect. That works. Thanks for fixing it.
Two things, though:

A question: Now, that rtcConfig and peerConnectionFactory are there, when the device loads, does it still make sense to provide them again in the mediaSoupDevice.createSendTransport function? I would make them at least optional and take the already known values given in the device constructor and load function for this. But this is not war deciding at all.

The RTCComponentFactory uses a WebRtcLogger, which seemingly doesn't proper log. I suppose this is from the libwebrtc-ktx, which I don't have touched for now. Not a big deal, but maybe somewhen you are working on this and have an eye for fixing this too:

These lines for instance
        WebRtcLogger.d(TAG, "decoderFactory: %s", decoderFactory)
        WebRtcLogger.d(TAG, "encoderFactory: %s", encoderFactory)

        decoderFactory.supportedCodecs.forEach {
            WebRtcLogger.d(TAG, "decoderFactory supported codec: %s %s", it.name, it.params)
        }
        encoderFactory.supportedCodecs.forEach {
            WebRtcLogger.d(TAG, "encoderFactory supported codec: %s %s", it.name, it.params)
        }

are rendering this output:
07-03 12:03:13.128 25089 25089 D VotixSoup-RTCComponentFactory: decoderFactory: %s
07-03 12:03:13.128 25089 25089 D VotixSoup-RTCComponentFactory: encoderFactory: %s
07-03 12:03:13.141 25089 25089 D VotixSoup-RTCComponentFactory: decoderFactory supported codec: %s %s
07-03 12:03:13.141 25089 25089 D VotixSoup-RTCComponentFactory: decoderFactory supported codec: %s %s
07-03 12:03:13.146 25089 25089 D VotixSoup-RTCComponentFactory: encoderFactory supported codec: %s %s
07-03 12:03:13.146 25089 25089 D VotixSoup-RTCComponentFactory: encoderFactory supported codec: %s %s

and some more samples available, but I'm sure you see it :)

What value is in the parameter logHandler of MediasoupClient.initialize?
I checked with io.github.crow_misia.webrtc.log.DefaultLogHandler and it was replaced without problems.
 Then it works. Thanks

``


Add a Http Client wrapper

This PR stops re-exporting bits of elastic_reqwest and wraps them up in a common Client API. The samples have been updated appropriately.
Once this is sorted the current API surface should be cleaned up with some proper tests and refactored into separate modules for better maintainability.

The RequestBuilder.params method should only clone the client params if its internal params are none.
So if you make subsequent calls to params it should be you the same value you returned last time you called it.


stop using node's url lib

the url lib stops me from using this on cloudflare workers, which doesn't use node
please make a new release with this fix as soon as you can realistically can, so i can use it
for some reason this library just crashes or something on cloudflare

some functionalities broke when the new school year started, so i managed to fix them which will be released in the next patch. if you're still having problems, please create an issue here with the error and i'll take a look at it

in the end i ended up manually making the soap requests, because almost none of the soap libraries worked on cloudflare pages/workers


BarChart Tooltip Overlapped with Line and Cut Off At The Edge

Description
Issue 1: The tooltip is shown behind the line chart when pressing the bar chart item
Issue 2: The tooltip content is cut off from the screen when it has long text
Expect the tooltip is shown on top of everything and auto adjust the content to avoid overflow issue.
Steps to reproduce

Snack or a link to a repository
No response
version of react-native-gifted-charts
1.4.47
React Native version
0.75.3
Platforms
Android, iOS
Workflow
None

Issue 1: Suggest increase zIndex of tooltip to 200000


Missing math scope in hyperref

Originally from @sleepymalc  in https://github.com/microsoft/vscode/issues/193248
Steps to Reproduce:

Open a LaTeX file
Type \hyperref[\( \)]{\( \)}
Open Developer: Inspect Editor Tokens and Scopes
Move cursor within \( \):

It's expected that it should contain at least one of math scopes such as follows:

Duplicate of #69. This was fixed upstream early November.
The LaTeX grammar in the main still points to a commit on September 16
https://github.com/microsoft/vscode/blob/48e93f756b764991ede33ad09781a863aca6907a/extensions/latex/syntaxes/LaTeX.tmLanguage.json#L7
I guess the fix will find its way to the next VS Code release.

I'm not familiar with how everything integrates, so should I expect a fix in the next VS Code update?

Yes, the fix will be integrated into the next VS Code update.
vscode-latex-basics only provides the LaTeX grammar and is also used by https://github.com/James-Yu/LaTeX-Workshop
If you use LaTeX-Workshop for typesetting LaTeX, you should already see the fix.

Great to hear that the issue is already fixed! I pull the LaTeX grammar into VS Coe about once per month, which means I'll be pulling in the changes next week and that they will be in the VS Code version that is released at the end of January.


Icon rcProgressBar Not displaying progress at all

So I have been working with the library for a little bit and I can't get progress to show on the icon progress bar. It works perfectly fine for all other versions of the bar. For example, this code snippet is directly from the example code, and the progress displays correctly when I switch it to just a RoundCornerProgressBar, but once I add the Icon in, it displays the colors and everything else correctly, but shows no progress..
<com.akexorcist.roundcornerprogressbar.IconRoundCornerProgressBar         android:layout_width="250dp"         android:layout_height="30dp"         android:layout_marginBottom="8dp"         android:layout_marginStart="8dp"         android:layout_marginTop="8dp"         app:layout_constraintBottom_toBottomOf="parent"         app:layout_constraintStart_toStartOf="parent"         app:layout_constraintTop_toTopOf="parent"         app:rcBackgroundColor="@color/white"         app:rcBackgroundPadding="2dp"         app:rcMax="100"         app:rcProgress="50"         app:rcProgressColor="@color/murica_flag_blue"         app:rcRadius="0dp" />

Same question，solved？

There is a bug of this library, ivProgressIcon layouts incorrectly in IconRoundCornerProgressBar.java
Before call setProgress and setMax methods, you must layout this view
       progressView.measure(View.MeasureSpec.UNSPECIFIED, View.MeasureSpec.UNSPECIFIED);
       progressView.layout(0, 0, progressView.getWidth(), progressView.getHeight());

Icon size is required in XML
app:rcIconSize="dimension"


potion effect negative amplifier not allowed

There are some potion effects that accept a negative amplifier such as the Jump Boost Potion Effect, but I'm unable to build a Potion Effect with a negative amplifier because the builder does not accept negative amplifier values.

The API javadocs have to be adjusted as well. https://github.com/SpongePowered/SpongeAPI/blob/bleeding/src/main/java/org/spongepowered/api/effect/potion/PotionEffect.java#L138

Please re-open this as SpongeAPI issue: https://github.com/SpongePowered/SpongeAPI/issues


Ensure no labels in Prepare for IC for inference

Small fix for IC inference flow. This should allow us to log the dataset for IC inference. We will then have further updates to the watch function (to come)
# 🔭🌕 Galileo log: Log dataset
dq.log_image_dataset(inf_dataset, split=INF_SPLIT_NAME, inference_name=INF_NAME, imgs_remote_location="gs://galileo-public-data/CV_datasets/ImageNet10_animals_train_val/inference")

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a95c76e). Click here to learn what that means.
The diff coverage is 92.85%.

:exclamation: Current head d195e15 differs from pull request most recent head 4ed3bf6. Consider uploading reports for the commit 4ed3bf6 to get more accurate results

@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage        ?   84.23%
=======================================
  Files           ?      167
  Lines           ?    13404
  Branches        ?        0
=======================================
  Hits            ?    11291
  Misses          ?     2113
  Partials        ?        0

Impacted Files
Coverage Δ

...uality/loggers/data_logger/image_classification.py
73.33% <83.33%> (ø)

tests/loggers/test_image_classification.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Nice! Can we please also add a test that verifies that we raise the error you showed in the OP?

Hmm I'm not sure that's necessary or maybe I don't follow. This fix now prevents that error from being raised. So if you remove my fix but keep the same test, it would raise a "you can't set labels" error. But now we just ignore the labels if it's inference and so the assertion passes and we don't raise that error.

This fix now prevents that error from being raised. So if you remove my fix but keep the same test, it would raise a "you can't set labels" error. But now we just ignore the labels if it's inference and so the assertion passes and we don't raise that error.

Ah, thanks for explaining. I misunderstood the intent as to raise an error (from a different part of code than was being touched), which is why I was surprised the new test passed.
The PR makes more sense now 🙂.

Thanks elboy!!


[Feature Request] Add an option to remove voteskip

Is your feature request related to a problem? Please describe.
The problem arises in smaller servers when people enter a large playlist or queue a large number of songs and then disconnect. It creates the need for admin/DJ intervention and when it's a smaller server there may not be one online. I understand the need for voteskip for larger servers where trolling would be an issue.
What is your ideal solution to the problem?
Create an option in the config file to enable or disable voteskip or give the option to allow everyone to forceskip.
How would this feature be used?

It would allow people in smaller to skip songs without forcing other people to tab to discord.
Help reduce the management of smaller servers.
Avoid trolling from people who join and input a large playlist and then leave.

Additional Info
I just want to express my appreciation for creating this bot. Thank you so much, after some of the popular discord bots began to get taken down, this was the only solution to have a bot that can play both yt and sc!
Checklist

[X] I have checked the documentation to make sure this feature doesn't already exist
[X] I have searched for similar feature requests
[X] I have confirmed that my requests is not on the list of things that will not be added
[X] I am running the latest version of the bot:

This is already implemented and will be available in the next release. You will be able to change the skip % needed, so you could set it to 0 to allow anybody to skip.


[feature] can we run on real device iOS

There are several challenges we need to overcome before we can achieve this.
Please know there there will be some limitations to what will be possible on the device, such as permission changing.

Here is how we achieved this recently.

We took the "Copy Detox Framework" run script from the demo-react-native example project.
As I ran into code signing issues, I replaced it by manually embedding the Detox.framework into the project.
I added a new script that recursively code signs each framework and dylib inside Detox.framework.
I copied and embedded the XCTest.framework also in the project as Earlgrey was complaining about it.
I set up the detoxServer and detoxSessionId in the launch arguments of the scheme.
The device and laptop was on the same network of course. The laptop's IP was set up correctly in the appdelegate and in the detoxServer launch argument.
I set up the same port and sessionId in the detox config (in package.json)
Also added an "ios.none" config there.
I ran "detox run-server" manually
Then, I ran "detox test --configuration ios.none".

And now, about the problems. After setting these all up, the app was running, it connected to the server, the tests started to run. And each of them failed. :|
During investigating what could be wrong, it suddenly started to work. Without any code change. The same pattern repeated on of my colleagues machine. (It failed the tests first, then it passed them half an hour later.)

@simonracz did you run a react-native app? in debug mode ? Loading the bundle from the debug node server may take time, and detox may reach the default timeout and fail.

If you mean the Mocha runner time out, then no, it wasn't that.
We tried both release and debug mode. It was the demo-react-native sample. No modifications were made to it, apart from the project file modifications mentioned above.
The first test line is "await expect(element(by.id('welcome'))).toBeVisible();". This failed with an Earlgrey assertion. It found the view with the id welcome, however it failed the visibility test.
I started to debug the runtime view hierarchy. For example, I stopped the process and called "po [GREYElementHierarchy hierarchyStringForAllUIWindows]".
For this view it showed the AX.id correctly, but the AX.frame was (0,0),(0,0). Sadly, I don't have saved logs.
After it started to work, the AX.frame was correct.
I wasn't able to reproduce it since then.

I was able to reproduce this "Earlgrey fails the visibility test" issue.
In fact I spent half-a-day on chasing this. I was able to narrow it down to the following.
The matched view is rejected, because it's accessibilityFrame is zero. It's frame is correct. It is an RCTView, which inherits from UIView. From to the docs "The default value for this property is CGRectZero unless the receiver is a UIView object or is a subclass of UIView, in which case the value is the frame of the view."
So, this shouldn't happen unless someone manually touches the accessibilityFrame. I looked at the react-native source-code, they never touch the accessibilityFrame. Neither does Earlgrey (except is it's tests).
I restarted, cleared, rebuilt, killed everything. Nothing helped.
I don't think this is a Detox issue. I wrote it down only that in case you encounter it, let's share our findings.

After spending more than a day on this bug I found the issue.
Since some iOS version (don't know yet exactly when, but 10.3.2 and 10.3.3 are affected) Apple introduced a bug/feature around accessibility.
The accessibilityFrame is not set, nothing isAccessible etc. unless the user is really using some accessibility features, e.g. voiceover.
Earlgrey heavily depends on accessibility. I don't know why haven't anyone else found this, opened a bug about it yet.
I'll open a bug report on Earlgrey and also open radar. I want to determine first the exact iOS version when this was introduced.

@simonracz
Interesting. XCUITest also uses accessibility for its operation. It’s worth investigating how the system allows that for those cases but doesn’t for ours. Most likely an end var.

Made a radar about it. http://www.openradar.me/radar?id=5043342748418048

@simonracz
This is probably an intentional change. There is no need to calculate these values on a real device, running production software (I don't mean a release build). We need to find out how the system differentiates between running from Xcode and otherwise. I will take a look soon.

I have found a way to force accessibility.
I will push soon to Detox.

@LeoNatan is it possible to run on real device now ? I couldn't find any docs on it

@LeoNatan This will be so helpful to have! Thanks for putting in the work. Can't wait to get my hands on it.

Running on devices is not supported yet.

@pachun Please do not unassign members of the team from issues. Leave the issue management to us. Thanks.

@LeoNatan I have no idea how that happened. Sincerest apology. 100% unintentional. All I meant to do was thank you.

Cheers!
We plan to support Detox on device soon.

@LeoNatan, are there any updates on the iOS real devices support? We are really looking forward to this functionality...

Nothing to announce yet. It’s in our backlog and we intend to investigate this eventually, but it’s not on the top of our priorities. There are some challenges that we haven’t solved yet.

Really looking forward of this too. My app need turn on the real device to check the camera.

I think I've solved the first hurdle (but a big one), which is setting environment variables when running on device. 🎉
Using a modified ios-deploy, I was able to embed environment variables.
Steps ahead: sign Detox dylib with the same signature as the user's app and send to device storage, then try to inject it using DYLD_INSERT_LIBRARIES environment variable.

Could anyone please walk me through how significant is managed on test clouds?

Any information when the testing on real android devices will be ready?

Checking in to see if there's been any progress with this?

No new progress. We've done a POC and it's technically feasible.
An actual implementation is planned, but there is no timeline.

@LeoNatan since it can tun on a real device will it be possible to somehow integrate Detox tests into firebase test lab? Especially now with iOS support announced, could be very powerful.

Unfortunately we have not yet implemented real device support.

I work for Bitbar (mobile devops cloud) and we tried out Detox in our cloud successfully. We even had a post about it (link below). We believe real device execution is faster and more robust to running mobile tests. We are interested in helping to implement the cloud solution for iOS real device support once you have something working.
https://bitbar.com/its-time-to-detox-your-mobile-tests-on-bitbar-cloud/

Hey @aknackiron,
This is exciting!
Please contact me at<EMAIL_ADDRESS>so we can continue discussing this offer seriously.

Guys, any news on this? Thanks

We're having a difficult time testing React Native \w Appium and are looking for alternative test frameworks/SaaS offerings which we can use to test our iOS/Android apps on a real device farm.

#metoo

We tried out WIX's solution and our cloud supports Detox on real Android and iOS devices. Android side is out of the box, iOS needs some extra setup from our side. Not to make this into a sales post, please get in touch with me directly at<EMAIL_ADDRESS>Our cloud supports also almost any other frameworks out there, not only Detox, Appium or native frameworks.

@DanielMSchmidt
While extensibility is very important, the magnitude of work required for this to work on a real device is beyond the scope of plugins. It involves touching all parts of detox and some JS extensions will not suffice. This is one of these cases which should come build-in into Detox. I am not sure extensibility like that is possible or feasible. I don't think an entirely new category of device will be able to be added as an extension.
@EdwardDrapkin
My POC was to test the current delivery method of Detox on a real device.
Right now, we use an environment variable DYLD_INSERT_LIBRARIES to inject the Detox library without requiring the user's project be changed or changing it ourselves. That's good for many reasons:

Detox should not be uploaded to the app store, so a clear solution is always better
A lot of our users are not familiar with Xcode, so making changes to the project is difficult
Changing the IPA on behalf of the user requires resigning of the package, which we cannot do
The same binary can be checked with newer versions of Detox without requiring rebuild of the binary

Doing this on the simulator is relatively easy, as Xcode provides the simctl utility, which we can use to install and run binaries on the device.
For a real device, no such official utility exists, despite there being support for it (Xcode does it, obviously, as well as iTunes). So I tested a third-party utility called ios-deploy, which allows for some similar capabilities. One hurdle I found right away was providing an environment variable, which is not normally possible to do on a device. But again, Xcode is able to do it, and ios-deploy has an option to launch in a debugger mode (which means it's a controlled launch, just like Xcode does). So I was able to modify the source of ios-deploy to add the environment variable and was able to launch an unmodified app and load our framework.
This is a big step, but only the first one. There are many features that would break. applesimtutils obviously can't run on a real device, so permission dialogs cannot be handled. Going to background and foreground will probably not be possible. Since my POC, some features have been added which make assumptions that the tested process is running on the same machine as the tester and just go to the disk and take files; that will clearly not work, so all those systems need to be rewritten to use file access APIs which we don't have in Detox yet. No one has tested how Earl Grey works on arm yet with real UIKit (simulator and device UIKit have internal differences). That's a lot of hurdles to overcome before we can say we support real devices.
But, with ios-deploy, it is probably possible to achieve some sort of running POC at some capacity with relatively not much work. But from this point to a point where we can feel confident to write "we support real iOS devices" is far.

I highly doubt @aknackiron will share his implementation if bitbar uses it, as that is a paid service.
Maybe I am wrong :smile:. But even if that is the case I would be personally wary to use that implementation until it was "blessed" by some of the main contributors here. It is exciting to see the ball move forward nevertheless.

My apron is ready for blessing.

@aknackiron, could you share that back to the community?

As mentioned earlier, we have not added anything to Leo's implementation. I don't know if these steps have been shared elsewhere than in Slack.

Any update on this? Running on real devices is crucial for us to setup automated performance testing. If this can be working reliably on Bitbar our team would love to use it. @aknackiron Do you have a guideline for setting all this up? What are the limitations of testing on device using Bitbar?

Detox's real iOS device support is not ready for prime time and is currently not on Detox roadmap. We have not developed anything on top of Detox.
Know that at current state (last we checked), you don't get screenshots and you can't relaunch app with Detox on real iOS devices.
If you still want to try out, we can do a project with you, but you'll have to get in touch with our sales... :-/

Well...called that. Last October he has a working implementation, now real device support is "not ready for prime time" whatever that means. He is not willing to share any changes to the community and instead insisted he did not make any to the original implementation, but you need to contact sales to walk through a project. This is nothing more than a sales ploy for BitBar. Unfortunately.

Guys, please keep the discussion civil. If you'd like to see device support in the open source project, you are welcome to contribute; we will guide you. But please do not include rude comments.

@LeoNatan fair. But the unwillingness to share a repro (that many have asked for in this thread) and instead directing you to contact a sales department does not feel like "contributing to the open source project". 🤷♂

Detox is licensed under the MIT license. This is a permissive license. As long as there is contribution, anyone is free to clone the project privately and extend it as they see fit; if they decide not to share their extensions, that is part of the contract too. While I understand your frustration, your comment was out of line and unacceptable in this community.

Hey Guys ..any direction would be helpful. We have a huge framework written in Java/Appium and one our goal is to execute tests on real devices. We are trying to transition everything to detox( as our new app is react native and all the backend is NodeJs). we successfully ran few tests and works well with our complete simulator setup and found it little more powerful than appium at various instances , Now we wanted to run this on real device( test devices which we have ) as cloud is out of the financial bucket to spend for this activity.  Do we start and try what @simonracz had suggested or any other workable workarounds for this to make it happen today. Thanks

@LeoNatan my company would greatly benefit from this feature.
And I am interested in helping. I could dig into it and create a PR once I have something.
Could you guide me or maybe give me some hints on this, so I could get started? Thanks!

This comment mentions everything I've done in POC to get it to work on a real device, as well as challenges I've met or think will be difficult to tackle. Here is more info:
The general gist of how we inject Detox into apps on simulators is as follows:

Take a user's .app and install it on simulator
Launch app with DYLD_INSERT_LIBRARIES environment variable to ask the operating system to load the Detox dylib
We pass launch arguments to the process to control how Detox functions.

We believe this is a good process that requires nothing from "Xcode-challenged" users and we would like to keep as much as possible of it. So, from a possible solution, we need the following requirements:

Be able to install an app on a device
Be able to inject an environment variable—only possible when running a process through debugserver
Be able to pass launch arguments—only possible when running a process through debugserver

Other considerations:
• On the simulator we are able to load the Detox dylib from any folder on the Mac machine—this is not possible on iOS obviously, so need to be able to somehow send the Detox dylib somewhere accessible within the app sandbox
• In order for the iOS kernel to allow the loading of dylib, it has to be signed with the same codesign identity as the hosting app
• Permissions will not be editable (no Apple~Simulator~DeviceUtils yet :stuck_out_tongue_winking_eye:)
I did a POC to check what is needed in general to run on device. With my own fork of ios-deploy I was able to install a test app on a device, set environment variables before launch and then launch the process with arguments. In my POC, I used a script that took the original .app, extracted the signing information, embedded the Detox dylib inside the bundle and resigned it. This obviously requires the certificate private key, which is not optimal for a testing cloud. So a research has to be done to see how to pass this dylib somehow without modifying the app bundle. Perhaps ios-deploy can do this and I didn't see. If this hurdle is solved, we are in a good shape to have a device driver for real devices.

It seems that you have a practical solution, but it is troublesome. Could you first provide a manual configuration solution, let us study together, and then consider the adaptation of the cloud test platform? I can't wait to try!
Your contribution is admirable!

@LeoNatan these are indeed similar constraints to what idb has to work with.
Essentially the constraints about going through a debugserver to get anything done w.r.t app launching on devices holds on iOS Devices.

On the simulator we are able to load the Detox dylib from any folder on the Mac machine—this is not possible on iOS obviously, so need to be able to somehow send the Detox dylib somewhere accessible within the app sandbox

If the detox lib is part of the App bundle, then you are able to dynamically link it, even using preloads like DYLD_INSERT_LIBRARIES, it's essentially a directive to dyld like any linker directive in the main app image.
The regular use-case here is splitting up an application into a smaller main executable that is loaded on launch and then other dylibs for features within an application. This is used to improve launch time so that that only the main dylib needs to be loaded when the app is launched and additional features can be linked only when they are needed.

We decided to go that route to ease the setup and potential deployment issues of our users. They don't change their project and the system automagically adds the required Detox code in runtime.
Once we are able to sign applications with Detox for running on device (in order to add the Detox dylib inside the bundle), it will be trivial to modify the signed entitlements to allow debugger attach.

hey @LeoNatan I was wondering, how big are changes which are trying to save users from in this

We decided to go that route to ease the setup and potential deployment issues of our users. They don't change their project and the system automagically adds the required Detox code in runtime.

scenario?
there's amazing xcodeproj project which lets you do pretty much anything you want with xcode project.
so is there another problem on they way if we can implement a solution which manipulates over user's project in the cloud w/o bothering a user to configure detox manually and then maintain parallel versions of the app (with and w/o detox libs)

@maxkomarychev Yes, I am familiar with that project, thank you. We used to use xcodeproj before settling to the current system. In some ways, it was terrible (not xcodeproj, but our previous solution). Detox would make a change in the user's project; since a lot of our users are ... "Xcode challenged" (to be as politically correct as I possibly can in this late hour), they would not understand the changes, and revert some or make changes of their own. We used to have problems with people complaining about changes. Changes done using xcodeproj were hard to change if we wanted to make a change in Detox. Big mess. We won't be going back to that system, sorry.
In your cloud proposed method, signing would still be an issue. We could sign it with an internal certificate, but that cannot guarantee a 100% functioning app (for example, is an app uses iOS extensions, using application groups and accessing files in the group container, etc.). Also, since Detox does not have a centralized backend, every user that would like to run Detox on a device would require them setting up this cloud on their own. I find it easier to just do everything locally (including signing with their own certificate).

Is there any work happening on this one?

No work, sorry.
We are working on rewriting large portions of the project, which should in theory make running on hardware device easier.

Is this happening in open source or is it more of an internal wix effort?

Detox is an open source project, so the changes will be available once ready.

Hi,
How is this feature going? Do you have any updates?
Thanks

This is not a priority for us. No updates right now.

But it is part of the roadmap
https://github.com/wix/Detox/blob/master/docs/More.Roadmap.md#ios-physical-device-support
is there any plan to make it available at some point?
Thx

Referencing @LeoNatan's answer https://github.com/wix/Detox/issues/95#issuecomment-541563023
This is not a priority for us as we still see Simulators as a good enough tool for our testing. The Detox iOS rewrite will make this potentially easier to support, but we'll still need to put some effort into it as a separate task once the rewrite is done.
Re the roadmap, you are right, but it needs a refresh.

The roadmap document isn't really maintained. As part of the rewrite, we need to go over documents and remove some of the more esoteric ones which we don't actively maintain (such as the roadmap one).

Hi @rotemmiz and @LeoNatan ,
Thanks for your replies and for giving me a bit of the context with your current situation, I will keep an eye to the latest releases.
Kind Regards

With the pending rewrite, some of the more peculiar deployment issues should be solved (no need for ios-deploy and ability to easily set an environment variable), but some issues will still remain, such as deploying the Detox dylib on device and signing it correctly so it can be loaded on device. Those aren’t particularly hard to solve but require thinking and perhaps additional requirements from the user. Once we finish the rewrite effort, we can revisit this topic.

@LeoNatan  Is not clear for me if till today is possible or not to run on real devices from documentation https://github.com/wix/Detox/blob/master/docs/APIRef.Configuration.md I'm not seeing how to do it

Well, clearly it is not possible, as evident by the discussion here.

thanks! just want to be sure . Is something that would be possible to provide soon? @LeoNatan

Not currently planned, as stated many times before. We are working on overhauling Detox’ internals for iOS, which will make it easier.

I see the discussion kind of repeat itself, but still, 7 months since last reply, are there any plans on supporting ios physical device in the near future?

Not in the very near future, but we keep this thread open for a reason. We are moving the pieces slowly toward that goal.

@LeoNatan I was following #2198 and I just noticed it was merged and published as 18.0.0 but couldn't find any release notes yet.
Does it bring real device support? Can we now run on services like AWS Device Farm?

No. Running on iOS hardware will take a lot more work.

There is no need to ask about this every few months or after every release. The issue is open, and we haven't forgotten about it. Once the work has been done and we are ready to add this support, we will surely write about it here in the issue, as well as in the release notes. Thanks


chore: removed extra wrappers for home page and rename health endpoint

Issue #179 : Create api/health endpoint

/deploy-review

/deploy-review

/deploy-review


[CL: Simulator] Simulator for CreatePosition, WithdrawPosition, CollectFees

Part of: https://github.com/osmosis-labs/osmosis/issues/4027
What is the purpose of the change
Simulator for CreatePosition, WithdrawPosition, CollectFees
Brief Changelog
n/a
Testing and Verifying
sim tested
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)

Also wanted to post the sim results, i think its a fairly good outcome
 "concentratedliquidity": {
  "CollectFees": {
   "failure": 28,
   "ok": 93
  },
  "CreateConcentratedPool": {
   "failure": 2,
   "ok": 121
  },
  "CreatePosition": {
   "failure": 29,
   "ok": 109
  },
  "WithdrawPosition": {
   "failure": 60,
   "ok": 43
  }

@czarcas7ic Addressed feedbacks. Ready for Re-Review


Access to logs

How would I troubleshoot docker logs  not working?
It returns an empty result.
How do I get access to logs in the VM? Specifically the apache log.

Awesome. Thanks! I am still learning docker...


Fix path to where views are published.

Sorry, one more small (but important) fix.
Laraval will automatically pick up overwrites from resources/views/vendor/<package-name>/ (where <package-name> is set as the second parameter of $this->loadViewsFrom()).
Anything outside of the vendor directory in resources/views is treated as a regular view, and will not overwrite a vendor-supplied view.

I think in this case also necessary to get rid of IFs from here:
https://github.com/gaaarfild/laravel-notifications/blob/master/src/Notifications.php#L241

You might be right. Something like this instead?
/**
 * Format filtered messages as HTML alerts.
 *
 * @return string
 */
public function toHTML()
{
    $view = config('laravel-notifications.view', 'laravel-notifications::bootstrap3');
    if (view()->exists($view)) {
        return view($view, ['messages' => $this->filtered])->render();
    }

    return '';
}

Then we can change the config value of laravel-notifications.view to null by default. That way if someone was to add a view to that config value it would pull their view, otherwise, it will pull whatever view laravel-notifications::bootstrap3 happens to point to. (If the view was published, then resources/views/vendor/laravel-notifications/bootstrap3.blade.php, otherwise, vendor/gaaarfild/laravel-notifications/views/bootstrap3.blade.php.)

@mikemand I just thought that we can think about views in resources/views/vendor/<package-name> as published. So we don't need to use if.
If they are published, we will take views from that folder, otherwise from vendor/<vendor>/<package-name>/views.

The only problem with taking out the if in that case is that if someone were to put a different view name in the config, it wouldn't be loaded at all anymore.
Or maybe I am missing your point entirely?

If he will change name in config, he should create this view in resources/views/vendor/<package-name> yes?

No. That would only be for if they published the view using the command: php artisan vendor:publish --provider="Gaaarfild\LaravelNotifications\LaravelNotificationsServiceProvider" --tag="views"
Right now, it is published to resources/views/laravel-notifications/ instead of the correct path of resources/views/vendor/laravel-notifications/. That's all my PR is fixing.
The if you are talking about is used if someone were to supply a view name directly to the toHTML method.

Nice. Merging and thank you :)

Not a problem. Sorry about misunderstanding your comment.
I do agree that the if should be looked at, however. Right now it looks like the config value won't do any good because it will be looking for a view in resources/views/laravel-notifications/ instead of letting the user set his own path.
(For example, ->toHTML('partials.messages.foundation') would look for a view in resources/views/laravel-notifications/partials/messages/foundation.blade.php. It should look for a view in resources/views/partials/messages/foundation.blade.php.)

I just thought that if we setting config, it should contain only filename but not path. So we can restrict usage of template file only inside resource/views/vendor/<package-name>


sudo apt install fails when fish shell is default

Encountering error when trying to install Setting up dotnet-sdk-2.0.0-preview2-006497 on a Ubuntu 16.04 based machine having fish installed as default shell.
See: https://github.com/dotnet/core/issues/711#issuecomment-313911366
/cc @livarcocc @egilh

Dupe of https://github.com/dotnet/core-setup/issues/2613?

It does look like a dupe. Closing this one.


Add proj6

Add project 6 which focus on the distributed transaction.

@rebelice I added some description about the Percolator protocol.


Enable watchdog CONFIG_OMAP_WATCHDOG

Tried enabling CONFIG_HW_WATCHDOG from meta-balena https://github.com/balena-os/meta-balena/pull/1349
but this change needs to be handled in each BSP separately unfortunately.
Probably CONFIG_OMAP_WATCHDOG in u-boot

@ZubairLK is this issue intended for having watchdog available in u-boot or in userspace?


strict sphinx agrifood

Resolves https://github.com/Azure/azure-sdk-for-python/issues/33518

Failing mypy and tests, don't have enough context to fix. Tracked by https://github.com/Azure/azure-sdk-for-python/issues/32816

/check-enforcer override


[TCFMM-3] Add specification

Description

Related issue(s)

Resolves TCFMM-3
:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Tests

[ ] If I added new functionality, I added tests covering it.
[ ] If I fixed a bug, I added a regression test to prevent the bug from
silently reappearing again.

Documentation

[ ] I checked whether I should update the docs and did so if necessary:

README
Haddock

Stylistic guide (mandatory)

[ ] My commits comply with the policy used in Serokell.
[ ] My code complies with the style guide.

@Martoon-00 I've updated the spec with the notes from last meeting, please review the last 4 fixups.
Summary of the fixups:

explained how the procotol fees work and under which conditions are they applied
deleted maximum_liquidity_present field, removed admin entrypoints, updated entrypoints' docs regarding protocol fees.
added docs for the increase_observation_count entrypoint
fixed some links (maybe we could extend xrefcheck's copy-paste protection checks to scan "reference-style" links as well :smile: )

to scan "reference-style" links as well

Oh that sounds interesting, I'll mention this use case.

@Martoon-00 I believe I've addressed your last batch of comments, please have another look :)

Thanks for addressing those points, looks good!


Revert Cypress PR

Description
Due to the time limitation of the LTS and the this PR still has some test failure to be fixed. We decided temporyly remove those PR from master and work on the bug fix on a saperate branch.
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

Close this PR and replace with https://github.com/aws/amazon-freertos/pull/2881


give event model String length 255 and change event_attr to text type…

give event model String length 255 and change event_attr to text type to handle various different length of event content.
event_attrs could be pretty long and would be truncated if exceeds the length limit of VARCHAR

Thanks a lot!