Field specific form errors

When I was adding extra developers to check pagination for #80, I noticed I had to keep scrolling to the top in order to check the errors. I wanted to make this more intuitive.
In #32, I discussed using a yaml file to store utility classes for easy references. I extracted helpers I use privately into a super small gem classy-yaml to provide this feature. I needed this feature because I wanted to avoid adding custom css classes.
I know adding gems to a project is a big risk, so I completely understand wanting to swap it out and/or pull that logic into this project directly. I made it to use with my other projects, so no lost work.
I also made sure classy-yaml can work with a ViewComponent sidecar yaml file (the README covers this), so with this gem, it would be possible to clean up other components that use a hash for the class names and then custom getters.
This was another unprompted feature, so I'm good with whatever you want to do with this PR!

Yikes, forgot to check the tests. I'll get those checks cleared up in case this PR is a direction you want to go 👍

Follow up... is it possible to move the error label next to the actual label? So this screenshot would read "Email can't be blank" in red above the input field?

OK, this is super cool!
I'm a bit wary on depending on your gem because it is so new. Do you have any idea what kind of effort and amount of code it would take to bring it into this codebase?
I'm not 100% against using the gem, I just want to make sure I understand the full picture.

Oh I can bring it on over if that's what you'd prefer, I don't take it personally. It's small in scope so it wouldn't be hard. I  do plan on still adding tests and making it more "complete" though, as it's definitely useful outside of a single project

Updated view:

It was more trouble than it was worth trying to retrieve the field name from the error proc, and this does look less repetitive

Making progress! My last request is to make the label red, too, if possible. Also, did you push the design change yet? I'm not seeing it locally.
As for the gem, let me sleep on it. I love the idea of supporting something new and exciting (and the tests help!). But I'm a little wary of being left with supporting it if it becomes abandoned.

Making progress! My last request is to make the label red, too, if possible. Also, did you push the design change yet? I'm not seeing it locally.
As for the gem, let me sleep on it. I love the idea of supporting something new and exciting (and the tests help!). But I'm a little wary of being left with supporting it if it becomes abandoned.

Made the label red! It was more of a pain than you'd think but I think the solution covers most cases. As far as why you weren't seeing the design change, I'm not sure... it should all be pushed and it has been working for me.
I'm fine with whatever you choose! I don't have enough GitHub history to plea my commitment so I understand the wariness. All I can say is it's useful to me long term so regardless of what you choose I don't view it as wasted effort at all 👍

And please resolve conflicts and/or merge in main.

 My head isn't on right today... give me a few minutes and I'll clear it all up

So close! Thanks for continuing to iterate on this. I know I'm being picky :)

Oh I'm enjoying the back and forth. I'm here to learn so this is perfect.
I went ahead and made those changes. I'm still not confident in my PORO design or the tests I constructed, but I gave it an attempt. I'm happy to make more changes so don't hold back!

Agreed, it's the cleanest way I've handled form errors and I'm definitely going to be swapping over my code to this

I love how this turned out. Thanks again for the PR!


feature: osmo-notify-frontend: Add a grid table page to show notifications list.

Description:
This PR adds a page for showing notification grid, we implemented the graphql and apollo client for making graphql frontend calls.
We also implemented the the environment files for getting various data based on environment.
Related changes:
Implement graphql & apollo for frontend.
Add notification gird page and show all the notifications.
Add environment files for dev & prod.
TODO:

Right now filter functionality doesn't work, we need to work on that.
Pagination functionality doesn't work right now, We need to work on that.

Screenshots:
Notification Grid:

Result Dialogue:

Data Dialogue:

@PrinceYadav2  See if you can add status as human readable values instead of the enum values in different colors like status in JLR


Rename all instances of plugin to app.

I had to email travis-ci support about getting CI working again. There seems to be some weird issue.

You do not have permission to publish "generator-studio-plugin".

Got this error attempting to deprecate. I don't believe my npm account has the creds to do this.


agent: Remove leftovers from IPv6 /96 prefix requirement

The requirement for the Kubernetes -node-cidr-mask-size to be a /96 has been
lifted a while ago but there were still some remaining leftovers hinting that
it exists. Remove them.
Fixes: #6804

This change is

test-me-please

Coverage increased (+0.002%) to 44.506% when pulling 7c5cbaa69b52991fe5ed8f93ed6b268db30bb55e on pr/tgraf/remove-ipv6-96-mask into 1810709a25e50d8db9101d1ede71be8568220317 on master.

test-me-please


Mili library Windows bug

Describe the bug
@Kathleen discovered a bug in the Mili library for Windows builds.  Kevin Durrenberger is also in the loop and will update the Mili git repository.

FWIW, I've already recompiled the Mili library for windows.

Great! Thanks!

@biagas can we just close this then?

Yes, it was Windows-specific code that needed to be fixed in mili.


catch up arakoon from specific node

Can you add a feature to arakoon to cath up the arakoon for a specific node?
This would be a nice feature when 2 of the 3 arakoons are not able to collapse due to Failure("success") error. Uses the collapsed node to catch up from would help us. Now we need to try multiple catch up to get the correct node.
thx!

(#233)


New found lag when pressing tab and when waiting for options

Out of nowhere it seems that tab completion is slower now? I feel like I'm crazy, but all of sudden the autocomplete options are taking a bit long and pressing Tab takes a minute until it actually puts in the completed text. I tried it on a bunch of random files/buffers
It seems that any time I push Tab it calls ^I as that is what is says on the bottom right.
(I have not changed anything in my zsh/nvim config in a few days and it was definitely fine before)

There's no big changes recently, It is always happenning?
What did you map the <tab> for?
I'll need a minimal vimrc for reproducing this issue. And a scrrentcast if it's possible.

I found the problem line
imap <expr> <Tab> (pumvisible() ? "\<C-n>" : (neosnippet#mappings#expand_or_jump_impl()!=''?neosnippet#mappings#expand_or_jump_impl():"\<Tab>"))

(this was copied from another issue)
Though before testing this I tried it with neosnippet disabled but didn't see a difference until I simply commented this line.

If neosnippet#mappings#expand_or_jump_impl() is the cause you might need to open an issue on neosnippet.

His last commit was on Mar 31 (https://github.com/Shougo/neosnippet.vim/commits/master), so that's weird to have it appearing now. Anyhow, I'll just disable it and move on. Thanks!


development on expath/xspec seems to have stalled

how about pointing to xspec/xspec instead

@duncdrum Sorry you are going to have to be a bit more explicit about what it is you would like...

@adam the readme point to expath/xspec as the source for xspec code. Development seems to have moved to xspec/xspec which is 117 commits ahead of the expath repo and active. Maybe the plugin should switch source repos?


Save enrollment IP address

Currently CSR submission originating IP address is not saved. It could be saved in the filesystem attributes and shown in the user interface as well.

Fixed with 789d80d71256f03023ce9ceb18fee94ebd95861e


fix: bug in loading 'db_resnet50_rotation' model from ROT_ARCHS in zoo.py

fix: bug in loading 'db_resnet50_rotation' model from ROT_ARCHS due to ValueError raised when first checking whether the model is in ARCHS in line 36

@jasonantonio10 Thanks a lot for the PR :+1:
But this fix is already built into #896  :)

Thanks! As @felixdittrich92, this will be fixed when merging #896, so closing this to avoid duplicates/divergences


Update how-to-change-the-build-output-directory.md

Removed incorrect statement about obj folder creation when using MSBuild from command line.

@ghogen
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Remove version: CrystalDewWorld.CrystalDiskInfo.AoiEdition version 9.2.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Duplicate;


human sort list fix https://github.com/PCMDI/click/issues/10

Pull Request Test Coverage Report for Build 994

14 of 15 (93.33%)  changed or added relevant lines in 1 file are covered.
16 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 75.492%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pcmdi_metrics/io/base.py
14
15
93.33%

Files with Coverage Reduction
New Missed Lines
%

tests/basepmpdriver.py
1
90.63%

tests/basepmp.py
15
55.32%

Totals

Change from base Build 981:
-0.3%

Covered Lines:
3145

Relevant Lines:
4166

💛  - Coveralls


PA for NonlinearForm and dealing with Essential BCs

So for my application, we currently make use of a ParNonlinearForm and and a class derived from the NonlinearFormIntegrator within a Newton Raphson solver in order to solve our PDEs. In particular, we make use of the ParNonlinearForm::Mult and ParNonlinearForm::GetGradient operators to build our RHS vector and A matrix. I'm currently working on a PA form of the above, and lately I've been working with @YohannDudouit on what on a PA formulation for my system should look like using libCEED.
Now, I've been paying attention to the pa-vector-divergence class and now PR #1159 since they appear a good path forward for me and my code. I was wondering what might be the best way to handle dealing with essential boundary conditions for the PA style code when making use of a NonlinearForm form derived class. It appears to me that potentially the easiest would be to have the NonlinearForm::GetGradient return a pointer to the PANonlinearFormExtension class. Then once you have that you could make a call to the FormLinearSystem() operator potentially similar to what's found in the BilinearFormExtension class
   Operator *oper;
   Operator::FormLinearSystem(ess_tdof_list, x, b, oper, X, B, copy_interior);
   A.Reset(oper); // A will own oper

which as far as I can tell is what is done for the BilinearForm class when PA is used. You can then use the operator passed back to you in your Krylov solver. However, I really don't have any experience using the BilinearForm class, so I'm not too sure if I'm missing something else that might be needed as well when doing this for a NonlinearForm class instead.

@rcarson3 You may also want to take a look at how it is done in the PETSc classes. See PetscBCHandler https://github.com/mfem/mfem/blob/master/linalg/petsc.cpp#L2169 and how the essential dof handler is used in the Jacobian setup (GetGradient) https://github.com/mfem/mfem/blob/master/linalg/petsc.cpp#L4085 and  function evaluation https://github.com/mfem/mfem/blob/master/linalg/petsc.cpp#L4148

@stefanozampini thanks for pointing those functions out to me, so it looks like PETSc is doing something fairly similar to what the NonlinearForm is doing to apply the essential BCs. The function evaluator or the ParNonlinearForm::Mult sets the DOF that are essential to 0. Then within the NonlinearForm::GetGradient function the OperatorHandle::EliminateRowsCols is also called which for a SparseMatrix object goes through and calls the SparseMatrix::EliminateRowCol function which zeros out the row and cols but preserves the diagonal value.
Now the Operator::FormLinearSystem differs from the above by internally creating a ConstrainedOperator object, and then it makes a call to the ConstrainedOperator::EliminateRHS function which fixes the RHS terms by doing the following:
   /** @brief Eliminate "essential boundary condition" values specified in @a x
       from the given right-hand side @a b.
       Performs the following steps:
           z = A((0,x_b));  b_i -= z_i;  b_b = x_b;
       where the "_b" subscripts denote the essential (boundary) indices/dofs of
       the vectors, and "_i" -- the rest of the entries. */
void EliminateRHS(const Vector &x, Vector &b) const;

It's just not entirely clear to me what would be the best choice for a PA operation where we never actually construct the full sparse matrix. I'm leaning towards the Operator::FormLinearSystem being the correct approach, since it only needs to be applied once, while I feel the current method used in  NonlinearForm::GetGradient would probably need to be applied every time the PA operator is applied within your krylov solver. I could be missing something since this is based on my search of the code trying to figure out what each class NonlinearForm and BilinearForm is performing.
If it turns out that BilinearForm way of doing things is the better choice I would like to make sure with those more familiar with that class that these lines of code from the PABilinearFormExtension class :
void PABilinearFormExtension::FormLinearSystem(const Array<int> &ess_tdof_list,
                                               Vector &x, Vector &b,
                                               OperatorHandle &A,
                                               Vector &X, Vector &B,
                                               int copy_interior)
{
   Operator *oper;
   Operator::FormLinearSystem(ess_tdof_list, x, b, oper, X, B, copy_interior);
   A.Reset(oper); // A will own oper
}

could more or less be ported over to what's being done with the PANonlinearFormExtension class that exists in PR #1159 . However like I said earlier I'm really not familiar with the internals of the BilinearForm  and PABilinearFormExtensionclass class, so I'm not sure if I'm missing something else that should be included.

If you use a PetscNonlinearSolver, and wrap the Gradient operator you return with a MATSHELL matrix in PETSc (see SetJacobianType below), then PETSc will take care of zeroing out values before and after the Jacobian application, which will be performed through your PA Mult method. Below is a pseudo-code you may want to try. You can send me an email if you want to discuss more in details, or ask @jandrej (he knows some of these details related to supporting  matrix-free preconditioning in PETSc through MFEM)
MyNonlinearOp::Mult(x,y) -> just apply the nonlinear operator (do it as if there are no essential dofs)
MyNonlinearOp::GetGradient(x) -> return the mfem::Operator which applies the PA form (again, this operator does not need to know about essential_dofs)

...

MyNonlinearOp op;
PetscNonlinearSolver solver(op)
solver.SetBCHandler(see PetscBCHandler class on how you construct it)
solver.SetJacobianType(Operator::ANY_TYPE) // this will instruct PETSc to just wrap the action of your operator in a PETSc MATSHELL object which also takes care of zeroed out rows and columns
....
/* if you then want to construct a preconditioner for the PA operator, you can use the PetscPreconditionerFactory class (see examples/petsc/ex10p) */
solver.SetPreconditionerFactory(...)

Hi @stefanozampini I am also interested in bchandler, which appears to be very useful.  If I have multiple unknowns in my Vec x, could I set the essential_dofs for each unknown through PetscBCHandler::Eval? Another questions is, if I have a time-independent essential boundary condition, which means I assume my first Vec x satisfies it, is there a simple way to enforce it in the nonlinear solver (like the linear case in ex1) or is it safer to still use bchandler in each Newton iteration? Thanks again.

@stefanozampini I'll take a look at closer look at PETSc then as a potential optional dependency for my users. If I run into any issues I might bug @jandrej first, since I can just talk with him in person.
I'm also going to start working on a native MFEM solution for the NonlinearForm class.

@jandrej, @pazner, can you comment on the handling of essential b.c. in #1159?

For my purpose, there is no need to handle essential bc in the PA. The proper solution for mfem would be to handle it the same way as we do in the ::Mult for the FA form aka zero out the tdof indices in the resulting vector. This only applies to the MatVec case of course!

OK, I see. This is something we should work to add either as part of #1159 or in a follow-on PR. I think it will be fairly straightforward and it should not require any interface changes.

I am also interested in bchandler, which appears to be very useful. If I have multiple unknowns in my Vec x, could I set the essential_dofs for each unknown through PetscBCHandler::Eval?

@tangqi What do you mean by multiple unknowns? the Eval method is supposed to populate the local part of the true dof vector that corresponds to true essential dofs. See the comment here https://github.com/mfem/mfem/blob/master/linalg/petsc.hpp#L472

Another questions is, if I have a time-independent essential boundary condition, which means I assume my first Vec x satisfies it, is there a simple way to enforce it in the nonlinear solver (like the linear case in ex1) or is it safer to still use bchandler in each Newton iteration?

The point of having the BCHandler is to forget about BC in residual/jacobian computation. What do you mean by safer? If you have essential BCs, you always want to eliminate those dofs
Here is how it works down the hood for the residual evaluation of a TimeDependentOperator https://github.com/mfem/mfem/blob/master/linalg/petsc.cpp#L3644

Thanks @stefanozampini for explaining. I think I made some mistakes in my current way of forcing the essential boundary condition in my implicit code. I "zero out" those tdof indices in the return vector of ReducedSystemOperator::Mult, but I did not impose the essential boundary condition on some components. I will impose my boundary condition explicitly through bchandler. Thanks!
Here I  mean I have multiple components including streamfunction, vorticity and magnetic potential as a block vector, but I think I should be able to apply the boundary condition through Eval by a simple for loop among different components, unless there is an easier way to do so I miss.

PetscBCHandler interface works well for me. Thanks!

@rcarson3, is this resolved?

@tzanio I'd like to see #1159 add in a function to do this as @v-dobrev suggested, but for all intents and purposes we can close this discussion and move the discussion of the addition of such a function over to #1159.


Proposal: rename event custom saving methods

The methods in question are

get_as_string_to_store(),
load_from_string_to_store(),
is_valid_event_string()

They are very complicated, not very intuitive and so similar that you can mix them up. On the other hand, they will rarely be used by users as shortcodes work fine for most events.

Closed by https://github.com/coppolaemilio/dialogic/commit/3e6c8248875f57615ec79d839b0eb988ab161936


Dashboard monthly report visualization

There are a number of TODO comments and some cleanup that would be nice. Eventually, would be nice to move this into BridgeAppSDK, but given our timeframe I wanted to get this in and the elegant and flexible solution would take a bit longer. Tested on device.

One nit, otherwise looks good


Tweet Activity tab isn't getting colored, remains white.

The colors of this remain white, it's very annoying to see it on there :P
https://gyazo.com/e8fa4c682cb92f3ca2c172c16badbd77

Also when i'm on my profile my default (twitter theme stuff go to blue)


remove node-xmpp MUC events

@astro hey
could you remove the node-expat notifications to node-xmpp MUC in the project settings?
thanks

Done!


A few registry functions

Add a few registry functions.
To note :

SafeRegistryHandle is reused from the framework as the functions are desktop-only.
I added the ACCESS_MASK variants for registry directly in the AdvApi32 as it felt like the most discoverable way and mirror what would have happened with header files.
Same for the reserved keys.

In both cases placing them in a specific class would have hidden them from intellisense.
Placing the reserved key in the safehandle class would have made some sense but as i'm reusing Microsoft.Win32.SafeHandles.SafeRegistryHandle it's impossible.

Looks perfect.


Question. Did you compare ParallelWaveGan or MelGan with WaveRnn in fidelity of the generated samples?

Hi, thanks for this great repo.
I was wondering if you compared the performance of ParallelWaveGan or MelGan with other AR models like WaveRNN or WaveGlow. I know they are slower as they are AR models, but I'm curious whether the AR models are inferior to ParallelWaveGan or MelGan in terms of the generated audio samples' quality.

Hi @Kyubyong.
In ICASSP 2020, Dr. Okamoto in NICT compared the quality between WaveGlow and PWG in both TTS and analysis-synthesis conditions.
I hope you can access the following presentation.
https://2020.ieeeicassp-virtual.org/presentation/poster/transformer-based-text-speech-weighted-forced-attention
P.S.
I really appreciate you for your great open-source libraries, such as g2p.
Thank you for sharing your great tools!

Thanks @kan-bayashi ! I think I need to register first to access the presentation, but I enjoyed the paper, instead. I've read WaveRNN is better than WaveGlow in quality and training time (WaveGlow is painfully slow to train), but do you think WaveRNN is better than PWG as well?

Oh, here is the additional MOS result.

Picture from https://2020.ieeeicassp-virtual.org/presentation/poster/transformer-based-text-speech-weighted-forced-attention

In terms of quality, I think WaveRNN is a bit better than PWG.
But PWG is the reasonable choice in terms of training speed, inference speed, and the quality.

Makes perfect sense! After all, I guess NAR models like PWG or MelGan is a bit underperform AR models, though the former is superior to the latter in training speed. Thanks!


fix 100% error and undefined in UI

fixes #168

bit ugly with if/else checks. will welcome feedback for improvement

thanks, I think we should have at least 1 explicit "Type" in the json to identify the load test type
but that can be a different cleanup I suppose

is it ok to merge this with the failed codecov check?
also, about the first PR build circle/ci failure:
gometalinter --concurrency=2 \
--deadline=180s --enable-all --aggregate \
--exclude=.pb.go --disable=gocyclo --line-length=132 . ./fhttp ./version ./stats ./fnet ./fgrpc ./periodic ./echosrv ./histogram ./ui ./log
WARNING: failed to make httprunner_test.go a relative path: lstat httprunner_test.go: no such file or directory
httprunner_test.go:78::error: Number go routine before test 37 (test)
Makefile:36: recipe for target 'local-lint' failed

not sure why an error was raised during linting, any thoughts on it?

#178 for ⭕


[CSL-2125] Migrating to GHC-8.2.2 and LTS-10.4

Currently I can build this using only ./scripts/build/cardano-sl.sh --no-nix command (Nix requires some updates).
What's done:

stack.yaml GitHub extra-deps are rewritten using new stack-1.6.* syntax (it made stack.yaml a little shorter).
Some packages are removed from extra-deps because they are in LTS-10.4 snapshot.
Bumped up dependencies to universum-1.0.4, log-warper-1.8.6 and serokel-util-0.6.0.
All compilation errors fixed.
perl coloring of output is removed from scripts/build/cardano-sl.sh since GHC-8.2.2 has its own coloring.
allow-newer option set to true because some packages require dependency updates.

Moving to GHC-8.2.2 raised a lot of warnings of case -Wsimplifiable-class-constraints. It looks like that:
cardano-sl/core/Pos/Core/Block/Union/Types.hs:49:20: warning: [-Wsimplifiable-class-constraints]
    • The constraint ‘Bi BlockHeader’ matches an instance declaration
      instance (Bi a, Bi b) => Bi (Either a b)
        -- Defined in ‘cardano-sl-binary-1.0.3:Pos.Binary.Class.Core’
      This makes type inference for inner bindings fragile;
        either use MonoLocalBinds, or simplify it using the instance
    • In the type signature:
        blockHeaderHash :: Bi BlockHeader => BlockHeader -> HeaderHash
   |
49 | blockHeaderHash :: Bi BlockHeader => BlockHeader -> HeaderHash
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I tried to fix as many as possible. But it's not that easy. Because without such constraints code won't compile (and our project structure is not advanced enough to fight with this issue). We probably should disable such warnings for now and fix them as a separate issue.

I fixed all review comments. Unfortunately, tests didn't work for me locally 😞 I will investigate whether I did break something.

Currently I see that a lot of tests are failing. I will try to fix tests but not sure how much success I will have..

Okay, it was fast. Tests are fixed now 👍

@ChShersh updating stack2nix should fix GHC 8.2.2 compatibility. Let me know how it goes.

@domenkozar I just finished running pkgs/generate.sh. I see this result:

Though command ./scripts/build/cardano-sl.sh --nix doesn't work for me :(
What else should I change in order to verify that things build with nix?

Ah it also needs nixpkgs bump. Let me take a look.

@ChShersh I have pushed nix fix, but you will need to address appveyor (Windows):
In the dependencies for lzma-<IP_ADDRESS>:
    lzma-clib must match -any, but the stack configuration has no specified version (latest matching
              version is 5.2.2)
needed due to cardano-sl-1.0.3 -> lzma-<IP_ADDRESS>
Some potential ways to resolve this:
  * Recommended action: try adding the following to your extra-deps in C:\w\stack.yaml:
- lzma-clib-5.2.2
  * Set 'allow-newer: true' to ignore all version constraints and build anyway.
   I will perform this clean-up as well.

Note CI test failures: https://buildkite.com/input-output-hk/cardano-sl/builds/1486#5ae6eb90-3b1b-4faa-b5c5-b98ebdd63f13/55-7011

@ChShersh stack2nix build issue should be fixed by https://github.com/input-output-hk/cardano-sl/pull/2462.

@domenkozar @gromakovsky I've rebased on latest develop after #2462 is merged. But Ci still fails 😞
But CI still fails. Some strange error on buildkite/cardano-sl/cardano-x86-64-linux  (maybe I messed up with default.nix generated by pkgs/generate.sh). And Appveyor CI fails because it reached max build limit time or absence of output for long time (I guess), though everything builds on Windows now perfectly.

One build failure is because (I think) stack2nix doesn't yet support the allow-newer option in stack.yaml.
Try working around it with this change to default.nix:
diff --git a/default.nix b/default.nix
index 5aed30693..e22e81a86 100644
--- a/default.nix
+++ b/default.nix
@@ -77,6 +77,12 @@ let
       # Due to https://github.com/input-output-hk/stack2nix/issues/56
       hfsevents = self.callPackage ./pkgs/hfsevents.nix { inherit (pkgs.darwin.apple_sdk.frameworks) Cocoa CoreServices; };

+      # TODO: remove; current problem is in engine-io-wai needs base < 4.10
+      # Pending issues:
+      # * https://github.com/ocharles/engine.io/issues/37
+      # c.f. allow-newer: true in stack.yaml.
+      engine-io-wai = doJailbreak super.engine-io-wai;
+
       mkDerivation = args: super.mkDerivation (args // {
         enableLibraryProfiling = enableProfiling;
         enableExecutableProfiling = enableProfiling;

Okay, stack2nix seems working as well as buildkite builds. AppVeyor CI fails for unknown reason to me (probably build is too long). I removed allow-newer from stack.yaml because the only blocking issue was resolved.
@gromakovsky @int-index @volhovm please review again.

I am not sure whether [CSL-2125] Debug release.nix eval commit should remain in this PR (I suppose it was only for debugging).

Yes, [CSL-2125] Debug release.nix eval can be removed from this PR.
appveyor fails due to reaching 1h limit. Not sure yet what do to do about it.

For some strange reason darwin buildkite builds started to fail.

Uh:

Building library for cardano-sl-auxx-1.0.3..
--
  | <command line>: cannot satisfy -package-id cardano-sl-1.0.3-1v4mt0d7XcwIdcwb4EVdfd:
  | cardano-sl-1.0.3-1v4mt0d7XcwIdcwb4EVdfd is unusable due to shadowed dependencies:
  | cardano-sl-block-1.0.3-GyVyRnl3hS56mRAvJfAkNU cardano-sl-delegation-1.0.3-8Grd87P9PXj6ueGrBj0yEl cardano-sl-infra-1.0.3-JqS9I8tvnzfN9IqDdwiXr cardano-sl-networking-1.0.3-4Ebi9gtHZbn4cSMxKMBzGI cardano-sl-ssc-1.0.3-8pyO6b5FrgPAe0OFynb61W cardano-sl-txp-1.0.3-7yKfBTz0QkQ73H43SUpecp cardano-sl-update-1.0.3-B2SqxGmGfYipsfeNqY64A plutus-prototype-<IP_ADDRESS>-FqLcIRKMngr6vOZoxm953u serokell-util-0.6.0-HfRWsPLArQG7XI4YbXEBqA

release-dot-nix CI build will be fixed as part of DEVOPS-652.

Rebasing on top of develop should fix release-dot-nix CI.

Looking at this it seems like there is a performance regression in GHC 8.2.x for cardano projects:

GHC 8.2.2 build

starts compiling first haskell package at 9min
compiles servant packages at 33min
fails at 60min

GHC 8.0.2 build

starts compiling first haskell package at 7min
compiles servant packages at 31min
succeeds at 47min

(non-scientific conclusion): So previously cardano packages took ~16min to compile while now they take at least 27min

I don't really understand CI problem on buildkite because I've updated default.nix using pkgs/generate.sh and I can see o-clock in default.nix...

According to https://github.com/appveyor/ci/issues/517#issuecomment-369671019 our time limit on appveyor should be 90min, so we can try rebuilding this :)

@domenkozar Okay, I will try to do this again.

Ok, so Windows CI no longer hangs by timeout. Instead it has some linker errors. buildkite build fails because log-warper has if inside it's dependencies in .cabal files and stack2nix can't handle this. I'm working on workaround for this.

Appveyor error is same as CSL-2344

Seems like it was addressed in develop - rebase should solve it.

I rebased on recent develop but the error is still there :disappointed:

We should also probably rename cardano-sl-wallet-new :/

Looks like something related to Appveyor CI and cardano-sl-wallet-new is going on here: https://github.com/input-output-hk/cardano-sl/pull/2626
Maybe I can try again after that PR is merged.

Start your day with new GHC build error on Windows...
The previous on Windows CI was fixed (probably) but now I see another error.
I discovered this discussion:

http://haskell.1045720.n5.nabble.com/Windows-Builder-Disabled-td5845021.html

Relevant part:

The pagefile is probably set to auto, but that means a certain % of the disk, if it needs more for some
Reason it won’t grow beyond this maximum.

Maybe it can help this issue somehow.

I recommend renaming cardano-sl-wallet-new to csl-w just to try this out.

@domenkozar didn't help

Is it possible to upgrade the urgency on this? @avieth spent hours debugging a concurrency issue only to find that its a known issue https://github.com/simonmar/async/issues/81 that been fixed in the next LTS.

@erikd I think we just need a hero to solve the conflicts and to please the CI (that's the hardest part). I think we would benefit from running weeder across the entire codebase (we need to be aware of some caveats, for example weeder cannot detect packages like autoexporter as being in use due to their use only via PRAGMAs) and see if we end up in a better place.
We had a similar situation this summer which was resolved by painfully weeding out either unused deps or packages that has "unique reverse dependency" by which I mean those packages that, if removed, would cause transitively other packages to be removed 😁 . The linked PR should have an half-baked script I have used with success this summer.

+1 - once deps are weeded out, we need to fix MAX_PATH on windows (which @georgeee and others tried to already tried fixing it)

Closing in favor of https://github.com/input-output-hk/cardano-sl/pull/2745


docs(AWS): update docs to show additional configs and troubleshooting

Updates to the AWS security hub docs for further clarification around options that may be familiar coming from the other integration.

@carlosmmatos can you check the pylint issue?


Adding a project of Calculator

Hey,@HarshwardhanPatil07 I can add the project of calcualator
Please assign me!!

Done


Remove trailing slash from html_url if present

For consistency, the html_url field of the pages preview API will begin returning URLs with trailing slashes in all cases. Because many sites hardcode things like {{ page.url | prepend: site.github.url }}, we need to maintain backwards compatibility, and have site.github.url continue to not have a trailing slash.
This PR simply strips the trailing slash from the calculated URL or API response, if it's present, so that we never have a trailing slash. Ever.

@parkr how does this look to you? Looks like tests are failing because 2.0.1 was released, but not in the latest version of the Pages gem.
I'm going to suggest we merge this here, cut 2.0.2, and bump the pages gem once with both, since 2.0.1 contains no in-production changes.

LGTM. I need to figure out a better way to test against the github-pages gem. Maybe just forcing the version.rb file to contain whatever github-pages depends on...


rework initialization

This PR reworks (and hopefully simplifies) task initialization.
With SendCell and Delegate I think we got the tools to not use a trait (object) for initialization.
I'm pretty happy so far, it feels like much reduced boilerplate already.
For now the PR:

[x] drops the Application trait
[x] drops Drivers and InitializationArgs
[x] introduces SendCell, a struct that helps passing around non-Send types, runtime-checking that an object stays on the same executor
[x] introduces riot_rs::embassy::network_stack(), which is now used to get to the network stack Stack object instead of passing it through the Drivers struct
[ ] we need a new macro for the tasks
[x] review & document SendCell. it's currently more of a PoC, we need to make sure it's sound, and polish the API
[x] introduce Delegate, which can be used to provide hooks e.g., for the UsbBuilder
[x] use Delegate to provide a hook into the UsbBuilder
[x] review & document Delegate

I'm aware that this is a pretty large PR as is. I'll split it up once we agree on the direction.

Thanks for the review!
I've incorporated everyting and split the PR into #84, #85, #86, #87.


How to order items in makeset?

Is there a way to order items in makeset()?
There are some confusion in docs.
In this doc -> Returns section, it says that
: Returns a dynamic (JSON) array of the set of distinct values that Expr takes in the group. The array's sort order is undefined.
But in another doc, it says that: Like makelist, makeset also works with ordered data and will generate the arrays based on the order of the rows that are passed into it.
I also tried some methods, but no ordering in the makeset() result.
method 1:
let topCities =
requests
   | distinct client_City
   | order by client_City asc;

topCities
| summarize makeset(client_City)

method 2:
requests
   | distinct client_City
   | order by client_City asc
   | summarize makeset(client_City)

And the result like this: ["","Hong Kong","Chicago","Boydton","Campinas","Des Moines"].
but I want the items should be ordered like this: ["","Boydton","Campinas","Chicago","Des Moines","Hong Kong"]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa4abe74-27fa-93a8-ffc6-a2d75a8291da
Version Independent ID: e37207e6-a781-e2b1-7fee-c020568f3b41
Content: Analytics - the powerful search and query tool of Azure Application Insights
Content Source: articles/azure-monitor/app/analytics.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

Hi @imeya ,
Thank you for reaching out. Could you please try below syntax:-
`requests
| summarize makeset(client_City) by client_City
| distinct client_City
| order by client_City asc
`

thank you. But what I want is that the result is a set(in 1 row like ["a","b","c"]), not in many rows like in row1: a, in row 2, b.

Hi @imeya ,
I tried to reproduce the issue with the steps you mentioned.  here are my findings;
Correct statement with regards to makeset would be , it would  returns a dynamic (JSON) array of the set of distinct values that Expr takes in the group. The array's sort order is undefined.
Meanwhile we are working on to correct this document.
Though for a workaround for this , you can use blow query -
requests | summarize makeset(client_City) by client_City | distinct client_City | order by client_City asc
which will give you result in rows and later you can concat the result in one row(comma seperated).

thanks again. then how to concat the result in one row, with comma seperated?

Hi @imeya ,
Try this code , it should give you what you are looking for.
requests | summarize makeset(client_City) by client_City | distinct client_City | order by client_City asc | summarize makelist(client_City)

@MohitVerma-MSFT, thank you very much. Please correct the document. And actually, we can directly use makelist() which supports ordering.

Yes, Makelist preserve the ordering of the input items. I have corrected the document and it will be published soon.
I am closing the issue.


Error when use MediaRecorder when session is connecting

I'm trying to use MediaRecorder when i publish my video, i'm actually using  "capturer" in the publisher options and " TextureViews" as an option in the Session of Opentok. But it gaves me error in the media recorder:
Error on start Media Recorder -19
I hope answers
Thnks

Hi @papitis ,
Please, could you add more info about the error you are getting? Do you want to record the publisher stream or the entire screen?
Using MediaRecorder with TextureViews should not be a problem.
Best,
Marina

Hi @papitis
Using MediaRecorder with TextureViews should not be a problem. We are going to try to reproduce the scenario you comment.
Best,
Marina

I use Texture Views, I'd appreciate your help.

Hi @papitis
Is your issue fixed?
As we commented, we are going to try to reproduce it.
Best,
Marina

Yes i'm still having problem with this feature of opentok when i want to
use MediaRecorder on publisher video.
Please you give me a favor if you reproduce that issue.
Thanks
2017-12-19 7:04 GMT-05:00 marina serrano<EMAIL_ADDRESS>
Hi @papitis https://github.com/papitis
Is your issue fixed?
As we commented, we are going to try to reproduce it.
Best,
Marina
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opentok/opentok-android-sdk-samples/issues/158#issuecomment-352730468,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFTifzPjIFwp7Roqc3mPe0O5hirU4jv0ks5tB6Y6gaJpZM4Qk-PT
.

Yes i'm still having problem with this feature of opentok when i want to use MediaRecorder on publisher video.
Please you give me a favor if you reproduce that issue.
Thanks

Hi, some new for this issue?
Best,
Angelo

Hi!
First, let me give you some hints on how we have recorder the publisher stream in the past.

You can use the MediaProjection API to record the screen too.
If using the MediaRecorder, you don't need to use a CustomCapturer, you can setup the MediaRecorder in the Activity, and feed it with the input surfaces for the publisher.
You can skip MediaRecorder or MediaProjection and use MediaCodec to directly save the pubilsher video frames using a video encoder. In this case, you would need to build your own capturer with will save frames to the video using the MediaCodec and to render them in the view. This option is the most difficult of these three. I recommend you use any of the others above.

For reproducing your issue,  we need some more details in order to be able to reproduce the exact issue. How are you setting up the MediaRecorder? I strongly recommend you to move the recorder code out of the CustomCapturer and drop it on your Activity code.

Hi @papitis
First of all, sorry about the delay checking your response.
Is your issue fixed?
Best,
Marina

@papitis Closing due to inactivity, please re-open if the issue still persists.


app_ssh.host_key_fingerprint property should specify required format

Thanks for submitting an issue to cloud_controller-ng. We are always trying to improve! To help us, please fill out the following template.
Issue
This job property should either specify that the required format is md5, or accept additional formats like SHA256.  Providing example(s) in the job spec would be nice, BOSH lets you specify examples in a job spec the same way you can specify a default value for the property.
Context
Most people generate the fingerprint using commands like ssh-keygen -lf /path/to/pubkey.  This used to output the fingerprint in md5 format, but with newer versions of OpenSSH it will default to SHA256. http://superuser.com/a/929567/207377

Done efdbc4f318c6912cf15eaf187db9dc7686c60092

Thanks!


stats: look for candidate-pair

instead of candidatepair. Firefox 53 changed the native stat type.
(and chrome still uses legacy stats)

maybe I should care about FF52 since its ESR...


Double scrollbars showing on Windows.

Two scrollbars are showing on Windows. I think it's caused by .scrollable having overflow-y: scroll;
This can be fixed by setting it to overflow-y: auto

Fixed in https://github.com/cdes/figma-material-design-icons-plugin/commit/330892154d42fc7d2f66c26014bad74546f813e2


fix typos found by the typos-cli crate

This fixes various typos inside cargo. They were found by typos-cli. A few different typos were left out as they seemed either intentional or were needed. Typos found in LICENSE-THIRD-PARTY were left alone as well.
r? @epage

@bors r+

:pushpin: Commit cab6d30c1dfb549fd48e8d18c40dca949c2a89e8 has been approved by epage

:hourglass: Testing commit cab6d30c1dfb549fd48e8d18c40dca949c2a89e8 with merge 08bef9dfb7b14da4e33056fca5a340edc1759f79...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 08bef9dfb7b14da4e33056fca5a340edc1759f79 to master...


You can empty/fill a closed liquid container using a mop

Title
https://user-images.githubusercontent.com/94384139/218269819-93d99435-a4c6-4900-b51c-ba673eebae26.mp4

can also be done in chem master or any reagent dispenser
im guessing solution container doesnt check if the item is sealed before inserting a reagent


Use new objc class macro

objc added a class macro which caches access to the class. So basically we can simply replace all Class::get("x").unwrap() with class!(x). The unwrap isn't needed anymore because the macro will panic if it fails. Note also that this macro should eventually (through procedural macros) be able to link directly to the class.
I'd be happy to send a PR which performs this replacement, but cases like https://github.com/tomaka/winit/blob/master/src/platform/ios/mod.rs#L173 need to be clarified (do these ever actually fail?).

Nah, those never fail, at least in a sane world. I'd be happy to see a PR for this, so thanks in advance.


Need to configure LiveReload protocol and remix dev origin independantly.

What version of Remix are you using?
2.0.1
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
We run our dev server in a docker container using tilt. This is to emulate our production environment locally, and because we need to run other services that remix talks to.
To achieve this we copy changed files into our docker file which triggers the dev server to reload.
Remix and the dev server are run from within the cluster, and we configure the dns at our gateway. So the browser always communicates with https://myhost which gets routed internally within the cluster to remix etc. Remix can then communicate with the dev server on localhost (within the cluster).
The problem is that with v2, the websocket that updates the browser from the dev server complains about mixed content (ws not wss), and the only way to fix this is to specify REMIX_DEV_ORIGIN=https://myhost. However, this inadvertently breaks our build system because https://myhost doesn't exist within the cluster - so the dev server can't ping the app server. This seems to be because the hot reload protocol is being inferred pased on REMIX_DEV_ORIGIN.
To solve this we are currently patching ./node_modules/.pnpm/@remix-run+server-runtime<EMAIL_ADDRESS>with the follwing:
/**
 * @remix-run/server-runtime v1.19.3
 *
 * Copyright (c) Remix Software Inc.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE.md file in the root directory of this source tree.
 *
 * @license MIT
 */
'use strict';

Object.defineProperty(exports, '__esModule', { value: true });

async function broadcastDevReady(build, origin) {
    let url = new URL("http://<IP_ADDRESS>:8002");
    url.pathname = "ping";
    let response = await fetch(url.href, {
        method: "POST",
        headers: {
            "Content-Type": "application/json"
        },
        body: JSON.stringify({
            buildHash: build.assets.version
        })
    }).catch(error => {
        console.error(`Could not reach Remix dev server at ${url}`);
        throw error;
    });
    if (!response.ok) {
        console.error(`Could not reach Remix dev server at ${url} (${response.status})`);
        throw Error(await response.text());
    }
}
function logDevReady(build) {
    console.log(`[REMIX DEV] ${build.assets.version} ready`);
}

exports.broadcastDevReady = broadcastDevReady;
exports.logDevReady = logDevReady;

This basically just hardcodes the dev origin to http://<IP_ADDRESS>:8002 within broadcastDevReady.
Expected Behavior
Allow specifiying protocol for <LiveReload />  independantly of REMIX_DEV_ORIGIN. Or allow specifying independant origins for dev and app servers.
Actual Behavior
No hdr/hmr.

I think it would be helpful if we could simply pass the URL to the LiveReload component directly (use REMIX_DEV_ORIGIN as default).
BTW: Instead of patching server-runtime, you can simply copy the source for the LiveReload component and inline it your app. It's in remix-react/components.tsx

I think it would be helpful if we could simply pass the URL to the LiveReload component directly (use REMIX_DEV_ORIGIN as default).

Yeah that sounds reasonable :+1:

BTW: Instead of patching server-runtime, you can simply copy the source for the LiveReload component and inline it your app. It's in remix-react/components.tsx

Thanks that works nicely.


TCP2 endpoint refactoring

Removed dynamic endpoint allocation and place the needed endpoint struct in tcp connection struct. This avoid issues with memory allocation if we run out of memory.
Also noticed that the local address was incorrectly accessed, this was seen when log level was set to debug.

@jukkar
I started to check and there's a problem to compile samples/net/sockets/tcp sample.
Could you please check?

I started to check and there's a problem to compile samples/net/sockets/tcp sample.
Could you please check?

Fixed

I would still reduce/minimize the work around the local_addr in the second patch/commit, might be simpler/cleaner to just get it and work with it.

Not trivial to get rid of local_addr, so I will postpone any effort for that. I am trying to get into data retransmission work but so far I have sidetracked too much :)


Update mime

#151 but with corrected history

+1 for this.
WASM support in static servers like browser-sync and lite-server that depend on this down the tree would be amazing.

If the change was simply just adding WASM it would have been released already. Instead, it is changing a lot of widely used extensions too. If anyone wants to see it land sooner, please help assess the impact of the changes listed above :+1:

Yeah, makes since given this package is so fundamental.

So I realized that we took on some changes with mime 1.4.1 because of a security issue, so had to accept the churn in that version. There have been some issues opened in the main Express repo with issues due to that churn, but we didn't want to revert due to security. What I'm getting at is a new comparison between 1.3.4 and 1.6.0 instead of 1.4.1 and 1.6.0. Here is the new comparison of changes types:
-deb	application/x-debian-package
+deb	application/octet-stream
-dll	application/x-msdownload
+dll	application/octet-stream
-dmg	application/x-apple-diskimage
+dmg	application/octet-stream
-exe	application/x-msdownload
+exe	application/octet-stream
-iso	application/x-iso9660-image
+iso	application/octet-stream
-jpm	video/jpm
+jpm	image/jpm
-markdown	text/x-markdown
+markdown	text/markdown
-md	text/x-markdown
+md	text/markdown
-msi	application/x-msdownload
+msi	application/octet-stream
-otf	font/opentype
+otf	font/otf
-ttc	application/x-font-ttf
+ttc	font/collection
-ttf	application/x-font-ttf
+ttf	font/ttf
-wav	audio/x-wav
+wav	audio/wav
-wmz	application/x-msmetafile
+wmz	application/x-ms-wmz
-woff	application/font-woff
+woff	font/woff
-woff2	application/font-woff2
+woff2	font/woff2

All the font changes are definitely known and may or may not cause issues, but I think they are acceptable. Removing those leaves us with the following:
-deb	application/x-debian-package
+deb	application/octet-stream
-dll	application/x-msdownload
+dll	application/octet-stream
-dmg	application/x-apple-diskimage
+dmg	application/octet-stream
-exe	application/x-msdownload
+exe	application/octet-stream
-iso	application/x-iso9660-image
+iso	application/octet-stream
-jpm	video/jpm
+jpm	image/jpm
-markdown	text/x-markdown
+markdown	text/markdown
-md	text/x-markdown
+md	text/markdown
-msi	application/x-msdownload
+msi	application/octet-stream
-wav	audio/x-wav
+wav	audio/wav
-wmz	application/x-msmetafile
+wmz	application/x-ms-wmz

Further, the two markdown I think are a normal move forward, so removing:
-deb	application/x-debian-package
+deb	application/octet-stream
-dll	application/x-msdownload
+dll	application/octet-stream
-dmg	application/x-apple-diskimage
+dmg	application/octet-stream
-exe	application/x-msdownload
+exe	application/octet-stream
-iso	application/x-iso9660-image
+iso	application/octet-stream
-jpm	video/jpm
+jpm	image/jpm
-msi	application/x-msdownload
+msi	application/octet-stream
-wav	audio/x-wav
+wav	audio/wav
-wmz	application/x-msmetafile
+wmz	application/x-ms-wmz

So we can split those into two groups: ones that are now application/octet-stream: deb, dll, dmg, exe, iso, msi; and ones that changed in general: jpm, wav, and wmz.
My understanding is that jpm wasn't correct in the first place, so that sound then be OK.
Looking at wmz it seems like that extension has meant so many various things over time, so probably whatever it is coming through now is meaningless anyway.
The wav change seems big, though it's just removing the x- classification from the type. Research with browsers seems to be that audio/wav is the better choice to serve under vs audio/x-wav so makes sense.
Now that just leaves all the ones that became application/octet-stream. Just looking around there are no "real" types for any of those in the first place. If this will actually be an issue remains to be seen, since most clients (like web browsers) won't even handle any of those types of files, and simply download + save, as which point the served type is lost. So it does seem fine.
TL;DR through review of the changes looks acceptable so it will absolutely be included in the next minor release 👍

Any chance this could be merged / released? WebAssembly, which uses the wasm files extension and should be server with the mime type application/wasm. If the mime type is incorrect, streaming compilation fails within the browser.

Latest version of send (at least as seen through live-server), serves .wasm files with type octet-stream instead of application/wasm, as required in the standard for streaming WASM modules). Not having the right MIME type causes an error (by design):

If the Response is not CORS-same-origin, does not represent an ok status, or does not match the application/wasm MIME type, the returned promise will be rejected with a TypeError.

Is this PR planned to fix this? Will this be eventually merged?

I (or someone who wants to volunteer) just needs to rebase this PR so it is mergable to merge. As for releasing send releases are tied to Express releases. A new Express minor is not yet being prepped since the research on this issue was completed for the mime change impacts, so I haven't rebased the PR myself yet since I don't have a timeline for a new Express minor version this would go into.

This was noted in some other issues but not in this PR, so I want to add it here if people are find their way here:
The types provided by this module are the default types, not the only possible types. This module exposes the underlying Mime instance you can configure with your own types to add / remove / change them as-needed. This module updates to the latest mime ever minor release and web standards move and the mime module didn't provide the wasm type map at the time of our last minor.
To add this (or any other type you want / need), just add a single line your program:
send.mime.types['wasm'] = 'application/wasm'

@dougwilson
Thanks for the quick response,
I'm not involved in the development of live-server, but digging through the code I figured out it was using send to resolve mime types, so eventually I tried to see if I can get to the "root" cause.
live-server doesn't have a mechanism for mime type exceptions (yet, it is a requested feature though) and doesn't seem to make any exceptions of its own internally, and even if it did, I would in turn need to ask to the developers of the vscode-live-server extension (which doesn't have a mechanism for MIME type exceptions, and I'm not involved in, as well) to apply this special case. And they in turn possibly point back and say that either live-server or send should have had it in the first place etc.
As you can see there's a complex chain of dependencies here that's not very easy to control.

As you can see there's a complex chain of dependencies here that's not very easy to control.

I definitely understand. We already have this PR and are planning to add it. As much as is my control I try to give the users of my module all the tools they need to kot wait for me. Just commenting here creates unnecessary noise when a large part of the issue is with those other modules preventing you from using the features this module offers you. If those are unwilling to allow you to customize the mime types, there is nothing further I can do to help you. You'll either need to use something else or wait until the next minor Express release planning begins and this gets included in that process.

May I ask why a release of express is a block on this PR?

I was looking for wasm mime type support in live-server and end-up here. Any news or schedule about this PR?


Add roadmap to kueue website

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/assign @moficodes

I prefer leaving this tentative roadmap in the README.

@ahg-g, thoughts?

No strong thoughts

What other projects have their roadmap on their docsite?
I am not sure if thats the best place for it.
github repo is probably better.

Adding a roadmap to Website is not a rare matter, like https://kubevela.io/docs/roadmap/. But respect all your advices, feel free to close this if you think not necessary right now. ^_^

let's come back to this after the 0.3 release.

At the least, the roadmap should be updated I think.

/retest

/close for now. Create a new PR if needed because we progressed a lot.

/close


Create group UI should be unified accordingly

Describe the issue:

The existing Group creation UI is not properly unified

It should be similar to a UI as follows

How to reproduce:

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [wso2is-7.0.0-m3-SNAPSHOT-src.zip]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

@DonOmalVindula Shall we close this issue as this should now be fixed with https://github.com/wso2/identity-apps/pull/4859?

Yes... will close this issue


Add exclude option for build.copyPublicDir

Description
When I use vercel to deploy the vite application, I need to write files to the public folder, so I added the .gitkeep file, but vite also uses .gitkeep as a package file.
This problem is because I need to use the web program packaged by vite as a cli tool, but I also want to deploy it to the vercel server for users to view the effect. In order to facilitate API requests, I use the public folder.
Suggested solution
export default defineConfig({
  build: {
    // add exclude option
    copyPublicDir: { exclude: ['.gitkeep'] }
  }
})

Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I don't think we need a new feature for this since it could be fixed with a post-build step to remove the .gitkeep? We usually try to reduce the API surface area.
But also, (depending on your usecase) could you dynamically create the library instead of using .gitkeep?

The plubic folder will also be used for development, dynamic creation seems a bit cumbersome, remove .gitkeep with a post-build step will be great, thanks!
The. getkeep file is not very large, so preserving it is not a problem, I just hope this option can handle various situations, I brought up a PR and if it's not needed, it can be turned off.

I think we'd want to make public more opinionated, in that it simply copies it entirely to dist. So I think it's best to not add this new option.
It could also be done as a Vite plugin with the generateBundle hook to manually remove the unwanted files too.
I'll see if others have thoughts on this though.

Yeah, this application scenario is really limited, so only the .gitkeep file was ignored in the latest PR

Let's close this issue, I also think it is better to avoid adding extra complexity to Vite core if possible. See also https://github.com/vitejs/vite/issues/14304#issuecomment-1807713187


Reproducer for HHH-16613 @Lazy @ManyToOne @Cacheable association is retrieved as initialized

https://hibernate.atlassian.net/browse/HHH-16613
This is only a reproducer, feel free to edit it as you see fit 😉😃

superseded by https://github.com/hibernate/hibernate-orm/pull/6700


Image Picker, take a picture and record from the same screen

Use case
Many apps allow you to use the camera controller from one screen, where you can decide to take a picture with one tap on the main action button or record a video with a long press.
The image_picker is a very beautiful package, but you can't do these two actions on the same screen.

Proposal
Would it be possible to have this feature included in the image_picker package?

We can add a new methods pickMedia to allow both mediaTypes to be picked.


ReferenceError: Can't find variable: requestIdleCallback (Safari)

Description:
Safari doesn't officially support the requestIdleCallback api yet (can be enabled via experimental WebKit features).
The requestIdleCallback api is still under consideration by WebKit.
Example:

Work Around:
polyfill the the requestIdleCallback api
requestidlecallback-polyfill
aFarkas/requestIdleCallback

The ReadMe states that the requestIdleCallback api will only be used for browser that support it, but that seems to not be the case. I provided a work around for anyone that runs into this, but it seems like something that should be addressed. I don't mind working a changeset to fix this behavior, unless the maintainers of this project have a different idea for how to resolve this issue.


Return value from loading state reducer

https://github.com/brianegan/flutter_architecture_samples/blob/54704bd915f0f14ec64dd04317971bcd978c6cc0/redux/lib/reducers/loading_reducer.dart#L14
Thanks for a great redux sample. One thing confuses me, and I wonder if it's an issue. Why isn't this line return true or return false based on the action?

Hey there! In that example, it's using a TypedReducer to return that value in response to a TodosLoadedAction. In the loading case, we don't need data from the action, but just use it as a signal to know we can set loading to false.

Ah, I think my mistake was in parsing this:
bool _setLoaded(bool state, action) {
  return false;
}

What it's actually indicating with the return value is that it's no longer loading, not whether the data is successfully loaded or not. My mistake! Thanks!


fix ignore_file_pattern

fix https://github.com/modelscope/modelscope/pull/866
v1.14.0 is ok
v1.15.0 ignore_file_pattern not effect
@wenmengzhou @liuyhwangyh May you help review this pr? Thanks.

cc @yingdachen

ref https://github.com/vllm-project/vllm/pull/5588/files#diff-80b1b037d9c7cb0506fdcb6a8ca72b0fb26d88fe2e3f62a058d1c45fd7cc5143R403

thanks for you contribution, We will review this PR this week asap

hi  @zhyncs  can you provide a test case for this fix?

hi  @zhyncs  can you provide a test case for this fix?

ok

hi @zhyncs can you provide a test case for this fix?

@wenmengzhou done

Hi @wenmengzhou Both lint and unit test have passed. May you help review the pr? Thanks.

Hi @wenmengzhou Both lint and unit test have passed. May you help review the pr? Thanks.

cc @liuyhwangyh

Sorry I didn't notice that the user wasn't set when I reverted the commit yesterday, which caused it to display
Co-authored-by: root <root@kunkun>.
kunkun is my girlfriend's name. My apologies for the inconvenience.


Bug. "Traceback (most recent call last)"

GPU 3070
CPU - I7
OS - Windows 11
Unable to generate, throws an error.
Traceback (most recent call last):
File "C:\Neural networks\Stable Diffusion\stable-diffusion-webui\venv\lib\site-packages\gradio\routes.py", line 337, in run_predict
output = await app.get_blocks().process_api(
File "C:\Neural networks\Stable Diffusion\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 1015, in process_api
result = await self.call_function(
File "C:\Neural networks\Stable Diffusion\stable-diffusion-webui\venv\lib\site-packages\gradio\blocks.py", line 843, in call_function
raise ValueError("Need to enable queue to use generators.")
ValueError: Need to enable queue to use generators.

in webui-user.bat,remove "no-gradio-queue ".moreover,don't use vpn.

@Agnyy Try to update webui to the latest version and restart it. Tell me if you will still have a problem after that.


Fixing bug so Zap bypasses config page if there is only one zcl package

Codecov Report

Merging #1082 (03b4d06) into master (b57cef1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   65.53%   65.53%
=======================================
  Files         170      170
  Lines       17681    17681
  Branches     3801     3801
=======================================
  Hits        11587    11587
  Misses       6094     6094

Impacted Files
Coverage Δ

src/pages/ZapConfig.vue
0.00% <0.00%> (ø)


Improve LIKE performance for "contains" style queries

Which issue does this PR close?
This is will have some trivial conflicts after #6118, it's part of #6107
Rationale for this change
Lots of context in #6107, this makes LIKE queries which are simply "conatins" significantly faster.
Running
 cargo bench -p arrow --bench comparison_kernels -F test_utils -- 'like.*contains'

Gives a max of ~50% speedup, but the default haystack size is 4 characters, if you increase that to 400, the performance improvement is quite marked!
➤ cargo bench -p arrow --bench comparison_kernels -F test_utils -- 'like.*contains'
   Compiling arrow-string v52.2.0 (/Users/samuel/code/arrow-rs/arrow-string)
   Compiling arrow v52.2.0 (/Users/samuel/code/arrow-rs/arrow)
    Finished `bench` profile [optimized] target(s) in 4.09s
     Running benches/comparison_kernels.rs (target/release/deps/comparison_kernels-95ab196215ed59e6)
like_utf8 scalar contains
                        time:   [888.14 µs 889.44 µs 891.07 µs]
                        change: [-80.213% -80.152% -80.091%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
  5 (5.00%) high mild
  9 (9.00%) high severe

Benchmarking like_utf8view scalar contains: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.9s, or reduce sample count to 50.
like_utf8view scalar contains
                        time:   [89.263 ms 89.328 ms 89.402 ms]
                        change: [-50.303% -50.217% -50.124%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  4 (4.00%) high mild
  3 (3.00%) high severe

nlike_utf8 scalar contains
                        time:   [890.63 µs 895.93 µs 902.48 µs]
                        change: [-80.369% -80.298% -80.223%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) high mild
  6 (6.00%) high severe

ilike_utf8 scalar contains
                        time:   [31.714 ms 31.793 ms 31.876 ms]
                        change: [+1.9043% +2.1414% +2.4089%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

nilike_utf8 scalar contains
                        time:   [31.459 ms 31.508 ms 31.560 ms]
                        change: [+0.8653% +1.0474% +1.2321%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

What changes are included in this PR?
Use memchr (which was already a dependency) instead of str.contains.
Are there any user-facing changes?
AFAIK, no.

What I am hoping is that we can investigate / fix the measured regressions and then merge it in 🚀

I can the benchmarks on the exact same spec of GCP machine (c2-standard-8), and got slightly different results:
group                                              contains-performance                   master
-----                                              --------------------                   ------
ilike_utf8 scalar complex                          1.00    305.2±1.28µs        ? ?/sec    1.00    305.7±0.70µs        ? ?/sec
ilike_utf8 scalar contains                         1.11   1685.4±4.02µs        ? ?/sec    1.00   1515.0±8.44µs        ? ?/sec
ilike_utf8 scalar ends with                        1.00    233.9±0.71µs        ? ?/sec    1.00    234.3±0.31µs        ? ?/sec
ilike_utf8 scalar equals                           1.16    248.6±0.28µs        ? ?/sec    1.00    214.2±0.27µs        ? ?/sec
ilike_utf8 scalar starts with                      1.11    279.6±0.95µs        ? ?/sec    1.00    251.2±0.28µs        ? ?/sec
ilike_utf8_scalar_dyn dictionary[10] string[4])    1.00     49.1±0.22µs        ? ?/sec    1.79     88.0±0.15µs        ? ?/sec
like_utf8 scalar complex                           1.00    287.3±1.08µs        ? ?/sec    1.00    288.4±0.90µs        ? ?/sec
like_utf8 scalar contains                          1.23   458.9±11.91µs        ? ?/sec    1.00    373.6±0.36µs        ? ?/sec
like_utf8 scalar ends with                         1.00    234.4±0.21µs        ? ?/sec    1.00    234.3±0.54µs        ? ?/sec
like_utf8 scalar equals                            1.00    217.1±0.20µs        ? ?/sec    1.00    217.1±0.20µs        ? ?/sec
like_utf8 scalar starts with                       1.00    234.4±0.59µs        ? ?/sec    1.08    253.5±0.24µs        ? ?/sec
like_utf8_scalar_dyn dictionary[10] string[4])     1.00     49.0±0.07µs        ? ?/sec    1.80     88.0±0.15µs        ? ?/sec
like_utf8view scalar complex                       1.01    531.2±1.22ms        ? ?/sec    1.00    523.6±3.52ms        ? ?/sec
like_utf8view scalar contains                      1.00    134.6±0.37ms        ? ?/sec    2.97    399.7±0.46ms        ? ?/sec
like_utf8view scalar ends with                     1.01     59.0±0.21ms        ? ?/sec    1.00     58.5±0.12ms        ? ?/sec
like_utf8view scalar equals                        1.03     30.1±0.05ms        ? ?/sec    1.00     29.4±0.09ms        ? ?/sec
like_utf8view scalar starts with                   1.00     54.0±0.12ms        ? ?/sec    1.02     55.2±0.13ms        ? ?/sec
nilike_utf8 scalar complex                         1.00    304.9±0.70µs        ? ?/sec    1.00    305.2±0.59µs        ? ?/sec
nilike_utf8 scalar contains                        1.12   1684.7±5.21µs        ? ?/sec    1.00   1509.5±5.93µs        ? ?/sec
nilike_utf8 scalar ends with                       1.00    234.2±1.14µs        ? ?/sec    1.00    234.2±0.50µs        ? ?/sec
nilike_utf8 scalar equals                          1.16    248.7±0.32µs        ? ?/sec    1.00    214.2±0.43µs        ? ?/sec
nilike_utf8 scalar starts with                     1.11    279.5±0.26µs        ? ?/sec    1.00    251.3±0.47µs        ? ?/sec
nlike_utf8 scalar complex                          1.00    285.8±0.44µs        ? ?/sec    1.01    287.2±0.62µs        ? ?/sec
nlike_utf8 scalar contains                         1.24   461.9±10.51µs        ? ?/sec    1.00    373.9±0.67µs        ? ?/sec
nlike_utf8 scalar ends with                        1.00    234.2±0.20µs        ? ?/sec    1.00    234.3±0.25µs        ? ?/sec
nlike_utf8 scalar equals                           1.00    217.1±0.20µs        ? ?/sec    1.00    217.0±0.25µs        ? ?/sec
nlike_utf8 scalar starts with                      1.00    234.3±0.22µs        ? ?/sec    1.08    253.6±0.36µs        ? ?/sec

The only cases which should have changed in this PR are:
group                                              contains-performance                   master
-----                                              --------------------                   ------
like_utf8 scalar contains                          1.23   458.9±11.91µs        ? ?/sec    1.00    373.6±0.36µs        ? ?/sec
like_utf8view scalar contains                      1.00    134.6±0.37ms        ? ?/sec    2.97    399.7±0.46ms        ? ?/sec
nlike_utf8 scalar contains                         1.24   461.9±10.51µs        ? ?/sec    1.00    373.9±0.67µs        ? ?/sec

I'll try to work out why the first and last are marginally slower with this PR.

The problem here I think is that the haystack length is only 4 characters! While of course some haystacks will be that short, I personally don't think that's the only case we should consider.
Running
cargo bench -p arrow --bench comparison_kernels -F test_utils -- --save-baseline `git rev-parse --abbrev-ref HEAD` '^(like|nlike).*scalar contains'
git checkout contains-performance
cargo bench -p arrow --bench comparison_kernels -F test_utils -- --save-baseline `git rev-parse --abbrev-ref HEAD` '^(like|nlike).*scalar contains'
critcmp master contains-performance

With different haystack lengths gives very different results from those shown above:
With haystack length=10
group                            contains-performance                   master
-----                            --------------------                   ------
like_utf8 scalar contains        1.00    375.5±4.54µs        ? ?/sec    2.43    912.8±6.32µs        ? ?/sec
like_utf8view scalar contains    1.00     89.6±1.94ms        ? ?/sec    2.01    179.8±1.80ms        ? ?/sec
nlike_utf8 scalar contains       1.00    374.3±2.67µs        ? ?/sec    2.43    911.1±1.95µs        ? ?/sec

With haystack length=20
group                            contains-performance                   master
-----                            --------------------                   ------
like_utf8 scalar contains        1.00    229.6±1.50µs        ? ?/sec    4.46   1024.3±6.95µs        ? ?/sec
like_utf8view scalar contains    1.00     88.9±0.79ms        ? ?/sec    2.07    184.4±2.52ms        ? ?/sec
nlike_utf8 scalar contains       1.00    230.6±3.77µs        ? ?/sec    4.44   1025.1±6.38µs        ? ?/sec

With haystack length=100
group                            contains-performance                   master
-----                            --------------------                   ------
like_utf8 scalar contains        1.00    377.3±2.50µs        ? ?/sec    4.51  1701.4±17.41µs        ? ?/sec
like_utf8view scalar contains    1.00     89.4±0.39ms        ? ?/sec    2.02    180.6±2.29ms        ? ?/sec
nlike_utf8 scalar contains       1.00    376.6±1.74µs        ? ?/sec    4.58  1724.9±15.14µs        ? ?/sec

With random haystack length=0..400
IMHO this is by far the most representative benchmark (happy to submit a PR to make this change permanent if you agree).
Using the following in create_string_array_with_len
                let length = rng.gen_range(0..max_str_len);
                let value = rng.sample_iter(&Alphanumeric).take(length).collect();

group                            contains-performance                   master
-----                            --------------------                   ------
like_utf8 scalar contains        1.00   882.0±29.67µs        ? ?/sec    3.33      2.9±0.08ms        ? ?/sec
like_utf8view scalar contains    1.00     89.8±2.13ms        ? ?/sec    2.04    182.9±3.11ms        ? ?/sec
nlike_utf8 scalar contains       1.00   867.1±11.87µs        ? ?/sec    3.39      2.9±0.06ms        ? ?/sec

These benchmarks were all run on my M3 mac, but that's pretty consistent with the GCP VM. I ran the last benchmark ("With random haystack length=0..400") on GCP to confirm:
group                            contains-performance                   master
-----                            --------------------                   ------
like_utf8 scalar contains        1.00  1661.6±16.26µs        ? ?/sec    3.22      5.4±0.02ms        ? ?/sec
like_utf8view scalar contains    1.00    132.4±0.21ms        ? ?/sec    2.92    386.5±0.46ms        ? ?/sec
nlike_utf8 scalar contains       1.00  1659.9±14.95µs        ? ?/sec    3.22      5.3±0.01ms        ? ?/sec

Summary
I guess we could do some special casing in the contains logic to use str.contains for very short haystacks, but personally I don't think it's worth it — it would make the kernel a bit slower in all cases.
Personally I think this change is good as is and we should update the benchmark code to use more representative haystacks.
LMK what you think.

Personally I think this change is good as is and we should update the benchmark code to use more representative haystacks.

I agree we should update the benchmarks (which we have done in https://github.com/apache/arrow-rs/pull/6147 -- thank you)
I took the liberty of merging up from main with this PR and will rerun the benchmarks just to be sure

I am still messing around with benchmarks (I had some problems with my scripts which I have now fixed). I expect results to complete soon


Maker Page - the left logo does not link back to Find the Masks main page

On www.findthemasks.com/makers - the left logo does not link back to the FTM main page

should this just redirect to findthemakers.com instead?

Wouldn't we want it to redirect to Find the Masks?
Use case: Maker finds makerspace and then wants to find facility to accept fabricated PPE - how do they get back to the main page without opening a new tab/window and navigating to it?
With that said, maybe there is already another way to get back to the main FTM page?

I'm thinking that findthemasks.com/makers should redirect to -> findthemakers.com now that that domain is setup. Then there's a button in the top left to go back to findthemasks, does that sound right?

Perfect. Also, when I was thinking about this, I didn't realize there was a big yellow FTM button there on the right, lol! I'll close this issue.


setup test env on KinD

This help with setting up the test env on KinD locally.
Run test env locally:
 make python-pb docker-image cluster load-docker-image deploy

Verify:
kubectl get po
NAME                                       READY   STATUS    RESTARTS   AGE
redis-549497986b-m5wfr                     1/1     Running   0          19s
train-conductor-grpc-85d94bcd74-zws4d      1/1     Running   0          19s
train-conductor-watcher-69f77f7f65-ndmjc   1/1     Running   0          19s
train-conductor-watcher-69f77f7f65-sc988   1/1     Running   0          19s

Closing the PR because project is going to take a different direction.


Remove hard-coded battery capacity from modem logic

Currently the modem code is hard-coded to 28kWh.
Todo:

Adjust callback endpoint of SmartEVSE, to accept battery capacity as input
Adjust pyPLC, so extract battery information from modem

Please assign to myself

https://github.com/serkri/SmartEVSE-3/pull/160 should solve this issue ✅
Of course feedback always welcome! Especially on my creative MODEM_DENIED state.


When muted={true} the fullscreen volume control won't unmute

Current behavior
When I set muted={true} and try to unmute in the fullscreen player the sound won't unmute.
Expected behavior
I should hear sound after unmuting from the fullscreen controls.
Platform
Which player are you experiencing the problem on:

iOS

Changing the volume setting to 0.0 rather than using muted={true} to achieve muting in advance of video playback has the same impact. The audio controls in the fullscreen view cannot be used to unmute the audio.

https://github.com/guliash/react-native-video-example/tree/muted_fullscreen
Demo.

When muted={true}  and controls={true} the muted btn not work in iOS ? Have nothing to do with fullscreen.  Has no one solved the problem？

Also having this issue - when muted={true}, pressing unmute on the controls doesn't unmute
If muted={false} - sound works fine when pressing play on a video

Try this PR
https://github.com/react-native-community/react-native-video/pull/1654

@CHaNGeTe tested your code changes with my project and issue is fixed for me - hope #1654 can be merged soon. Thanks for fixing!

Check on 4.4.3

Thank you! Happy to see this got fixed.


Wrap private file level method in anonymous namespace

Fix one of the warnings from #510.
The endTag method is a private file level helper function (non-class member). It is not meant to be shared with other translation units. As such, it can be wrapped in an anonymous namespace to protect it from being accessed from other translation units.
From the GCC Warnings page under -Wmissing-declarations:

Warn if a global function is defined without a previous declaration. Do so even if the definition itself provides a prototype. Use this option to detect global functions that are not declared in header files. In C, no warnings are issued for functions with previous non-prototype declarations; use -Wmissing-prototypes to detect missing prototypes. In C++, no warnings are issued for function templates, or for inline functions, or for functions in anonymous namespaces.

That doesn't seem to be fully in the spirit of the warning flag. The flag was meant to find methods that have no prototype in a header file.
The help text for the flag even suggests using an anonymous namespace.
In terms of protection, you have less protection by declaring a prototype in the source file. There's nothing stopping anyone from declaring an equivalent extern prototype in their own source file, and thereby gain access to such a method. Using an anonymous namespace makes that impossible. They would have to modify the original file to gain access to the method.

In terms of protection, you have less protection by declaring a prototype in the source file. There's nothing stopping anyone from declaring an equivalent extern prototype in their own source file, and thereby gain access to such a method. Using an anonymous namespace makes that impossible. They would have to modify the original file to gain access to the method.

If that's the case, why isn't this being done for every non-public, implementation-only function?

Well, in terms of the projects here at Outpost Universe, because we only recently realized the benefits of wrapping functions in anonymous namespaces.
I sort of felt this realization only happened within the last few months, thought searching GitHub, it seems we started making use of anonymous namespaces back about June 2018.
Granted, most of the work done since then has been refactoring old code, rather than developing or extending new API code. That may explain why we haven't been using the technique much yet. Though in the case of the op2ext, we did expand library capabilities using that technique in the last year. The op2ext entries from the above search should provide the most detail about the technique. In particular: https://github.com/OutpostUniverse/OP2Utility/pull/177#issuecomment-419167719
I should point out that I've since become more used to wrapping functions in an anonymous namespace, and would actually recommend that as a good design, rather than dumping a bunch of private methods in the header file, where they affect a much greater compilation area. The distinction of how to implement the methods is largely dependent on whether or not they need direct access to object state.
For a more recent example, op2ext used the technique back in November to implement some file level variables:
https://github.com/OutpostUniverse/op2ext/blob/bb6b6a224561afd79dccafd7a187f44809e5db45/srcStatic/Log.cpp
And of course, as a workaround for the random number generator problem:
https://github.com/OutpostUniverse/OPHD/pull/167
In that case we do actually want to consolidate uses into a single instance, rather than keep instances separate. However, the compile problem you encountered there shows what happens when you have a name collision in two separate compilation units for a global variable. Once translation units are linked together, re-use of the same name in the same project can be a problem. Wrapping methods in anonymous namespaces helps protect against that.
So yeah, the idea looked odd to me at first. Though once I started using it and understood it better, I've come to find it may actually be a good practice. I've since noticed anonymous namespaces being used in a number of libraries where I felt the quality of implementation was pretty good. I'm kind of getting the feeling wrapping private top level helper functions into anonymous namespaces may be a best practice.

Well, I really meant "Why isn't everybody doing it?" or "why isn't this taught in academia?", but nice write-up none-the-less. 😛
Turns out it's compiler specific, disabled by default, and is mostly a C concern, not a C++ one. (See my comments on #510)

My guess is it's not more wide spread because many people aren't aware of the issue, and they aren't aware of the issue because there are so many other potentially more important issues that they need to learn first.

The C-concern listed in that issue is rather different than the current warning being addressed. The issue addressed here is very much a C++ concern. It relates to the default linkage of file level globals, and potential name collisions at link time. As the matter is concerned with visibility of symbols (at link time), there is no particular difference between functions and variables, they are all treated the same.
Not including a prototype (or extern variable declaration) in a header impacts compile time name visibility issue. This is separate from the link time name visibility. The linkage of a symbol is concerned with the link time name visibility.

The following article contains a nice summary of linkage:
Internal and External Linkage in C++

For a slightly silly example to illustrate linkage issues:
Moral.h
float doGood(float extent); // extent: 0.0 (minimal) to 1.0 (very good)
float sin(float extent); // extent: 0.0 (minimal) to 1.0 (way bad)

Math.h
float sin(float radians);
float cos(float radians);

Main.cpp
// Let's simplify things by not adding header confusion
// Forward declaration
float sin(float);

int main() {
  sin(1.0); // Which function is called?

  return 0;
}

:wink:

The above example is a little different from what we're dealing with, since both all functions are probably assumed to be public, and are being called from a third file. In that case you have a real name collision problem. If instead, one of those functions was a private support function, which just happened to conflict with a public method name, that's the case we're really dealing with. This may be different yet again from the case of two private support functions, and no sharing from a third file.

Given the silly example and my immediate thought was: "Well, duh, that's why namespaces exist!" I now get what you're talking about. I'd just never used unnamed namespaces in such a way before. I'd used them in order to hide a global variable that I didn't want users to be able to access; but never thought about using them for functions. (Every example I've seen only uses them for variables!)


Add Timer tests and fix progress

Description
#610 fixed a bug with Timer; this PR adds some tests for this and other Timer functions.
Adding these tests exposed a bug with progress, which is also fixed in this PR.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:
If something is unclear, please submit the PR anyways and ask about what you thought was unclear.

[x] This branch is based on the latest master
[x] I have added an entry under [next] in CHANGELOG.md
[x] I have formatted my code with flutter format
[ ] I have made corresponding changes to the documentation
[ ] I have added examples for new features in doc/examples
[x] The continuous integration (CI) is passing

Thanks all :) as before, if there aren't any big issues feel free to merge whenever you'd like since I don't have write access here.

Thanks all :) as before, if there aren't any big issues feel free to merge whenever you'd like since I don't have write access here.

Thanks all :) as before, if there aren't any big issues feel free to merge whenever you'd like since I don't have write access here.

Sure thing, we are just waiting for at least one more approval :)

Thanks all :) as before, if there aren't any big issues feel free to merge whenever you'd like since I don't have write access here.

Sure thing, we are just waiting for at least one more approval :)


[otbn,iss] Fix URND ISS vs RTL timing

Due to a recent functional change RTL URND was one step ahead of ISS.
This fixes it so they remain in sync.
Fixes #12563
Signed-off-by: Greg Chadwick<EMAIL_ADDRESS>

Not super beautiful, but it's nice to see that it's this easy to get everything working

Yes, I am slightly puzzled why it is needed but it's not too much of a hack so better to spend time elsewhere.


How to implement variable row height?

The documentation indicates a feature of fixed-data-table is that you can have variable row heights.
None of the examples show this and it isn't obvious how to accomplish this task.
I have a button in the row to expand for showing more detail.
When I render the Cell in the column (I check for the presence of props.rowIndex in a Set containing indices of items that have been expanded), I change the height of the cell (and each other cell in the table row) to be larger. This doesn't seem to have any effect as the row height doesn't change for the row at all.

You need to use rowHeightGetter defiend at the table level.

rowHeightGetter is exactly what I was looking for. Thanks!


Consistent whitespace between functions and classes

Starsim code is inconsistent with whitespace following function. The styleguide does not currently offer advice. Is there a preference for one or two lines of whitespace to separate subsequent functions? Two lines of whitespace before a class definition or other major structure?

Here's the PEP8 standard: https://peps.python.org/pep-0008/#blank-lines

I recommend we just follow PEP8:

Surround top-level function and class definitions with two blank lines.
Method definitions inside a class are surrounded by a single blank line.

The style guide does cover this point :grin:
https://github.com/amath-idm/styleguide#35-blank-lines-gsg35
In my view, the style guide is consistent with the spirit of PEP8 (emphasis mine):

Extra blank lines may be used (sparingly) to separate groups of related functions. Blank lines may be omitted between a bunch of related one-liners (e.g. a set of dummy implementations).
Use blank lines in functions, sparingly, to indicate logical sections.

In a typical Python library (like requests), the vast majority of methods (around 80% from a quick scan) are only a few lines, so you can typically see multiple methods on the screen at once. Within methods, blank lines are indeed used "sparingly". Here, it would of course be overkill to use two blank lines between methods.
For Starsim, because we're manipulating higher-level things in more complex ways, we do not typically use blank lines within functions or methods "sparingly", and it's rare for multiple methods to fit within one screenful. One way I've seen this solved in other higher-level libraries like scikit-learn is to move long (100+ line) blocks of code to top-level functions (see e.g. here), and then just reference those functions from within short class methods.
I think that's a valid approach, though I personally prefer our current one. What I don't usually see in "gold standard" Python libraries is 100+-line methods with lots of blank lines within them, and then only separated by a single blank line. So I think we could keep our current long methods but with spacing as if they're top-level functions, or we could be more disciplined about keeping our methods very short (aiming for ~<20 lines) and then only use a single line between them. What I wouldn't be in favor of keeping long methods but reducing the space between; it makes it much harder to visually parse where one method ends and the next one begins.
I agree that shorter methods are probably better in an ideal sense, but I feel all of us (@RomeshA and @pausz probably being exceptions :D) have been using this less-CSish, more-researchish style for a long time, and I think it'll be hard to switch. I'm not necessarily opposed to trying, but I think it would be a lot of work, will probably be applied inconsistently, and am not personally convinced the payoff is worth it! (I'd like to give a counterexample to this argument though, which is that when @RomeshA split up the very long cv.BaseVaccination.apply() method into multiple subcomponents, that significantly increased usability and readability. So it's definitely something we should at least be mindful of!)

Closing for now.


Making Window alerts optional

Sometimes I would like the user to click one of the buttons but there not to be a window alert (message box popup). I intend to alert the user on the screen via markup. Is it possible please that if the relabel option is empty then you skip the alert()?
example:
exolve-relabel:
    confirm-check-all:

Sure, will get to this in the next version.

I've done this now, in v0.95. If a confirm-* message is relabeled as empty, that alert is skipped.

Closing out old bugs that I did take some action on. If I haven't fixed every aspect as expected, apologies, but please open a new bug (hard for me to parse out what remains to be fixed).


Should new active span be created using current active span as a parent?

Hi! I'd like to discuss whether it makes sense to instantiate new active spans using possibly existing current active span as a parent. To illustrate this idea, here's an excerpt from TracingRestTemplateInterceptor.java
    @Override
    public ClientHttpResponse intercept(HttpRequest httpRequest, byte[] body,
                                        ClientHttpRequestExecution execution) throws IOException {

        ActiveSpan span = tracer.buildSpan(httpRequest.getMethod().toString())
                .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT).startActive();
...

Which with described idea changes to (notice asChildOf call):
    @Override
    public ClientHttpResponse intercept(HttpRequest httpRequest, byte[] body,
                                        ClientHttpRequestExecution execution) throws IOException {

        ActiveSpan span = tracer.buildSpan(httpRequest.getMethod().toString())
                .asChildOf(tracer.activeSpan())
                .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT).startActive();
...

What I'm currently trying to solve with this idea is creating a span that covers an operation that includes several outgoing HTTP requests.

@pavolloffay can you tell me where automatic linking is done in the interceptor? Because with tracer.buildSpan we do not inject any parent context? At least I don't see it on the master branch.

Statement  .asChildOf(tracer.activeSpan()) is not necessary the active span should be added as parent automatically.

When you say automatically, where is that in the code exactly? I tried to look for that piece of code on the master branch, but was not successful. Currently, for me, it does not work.

The tracer implementation should do it.


fix writing points dims to netcdf

Closes  #482

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a913761) 81.14% compared to head (167af11) 81.11%.

Files
Patch %
Lines

src/lookup.jl
66.66%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   81.14%   81.11%   -0.03%
==========================================
  Files          61       61
  Lines        4227     4231       +4
==========================================
+ Hits         3430     3432       +2
- Misses        797      799       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Documentation for Route Configuration

Added basic guides for working with route configuration

Is this one ready now?

Yes, it is ready for review

LGTM


Add CI for Automated Releases

I noticed a renewed interest in maintaining this via https://github.com/MChambers1992/CopyPasta2/issues/13
Figured I'd open a PR as I've had a working deployment pipeline for a year-ish or so now just so I can stay up to date with things.
I'd suggest reverting or modifying the README changes I made along with the local.lua changes as I assumed the project was abandoned and I'd pick up maintenance of it!

Hey thanks for the PR, really appreciate it. Can you revert the files as part of the PR that you suggested? Also in terms of setting the GitHub Action up does your fork have an example of what that setup looks like? I've seen this tutorial that I planned to follow for it https://wowpedia.fandom.com/wiki/Using_the_BigWigs_Packager_with_GitHub_Actions

Hey thanks for the PR, really appreciate it. Can you revert the files as part of the PR that you suggested? Also in terms of setting the GitHub Action up does your fork have an example of what that setup looks like? I've seen this tutorial that I planned to follow for it https://wowpedia.fandom.com/wiki/Using_the_BigWigs_Packager_with_GitHub_Actions

my fork has the setup already added with a release shown as apart of it. I havent ever really set this up to target Curseforge but for targeting Github, this works already as is!
I'll update the fork later in the day to clean up this PR to merge

@srhinos if you update the PR based on the changes in your fork I'd be happy to merge them


Czech & Slovak translation

Language
Czech & Slovak
Can you help with the translation?
Yes, sure! 👍

Hi @michalzelinka  thanks for your interest. A branch named "lang/cs" has been created and you can see 5 string files in "cs.lproj", same goes for "lang/sk"
For each file you will see several "some identifier here" = "some text in English here"; and only "some text in English here" part need translation. Besides, /* ... */ are comments and they don't need translation.
When you done, just create a PR for Czech or Slovak.
Thanks!

@username0x0a thank you so much for your contributions to make Unshaky accessible to more people. And sorry I seemed to at the wrong person above...


USB Sound card does not appear in HA

The problem
When a sound card is connected, it appears well when dmesg is run but does not appear anywhere on HA (Audio Add-ons, ha audio info).
What is version of Home Assistant Core has the issue?
core-2021.4.6
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
system
Link to integration documentation on our website
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
`ha audio logs` output:
https://imgur.com/a/K9nddQg
I can't copy the text inside the terminal add-on.

Additional information
No response

looks good

@pvizeli No, there are many ”Connexion Died”.

you don’t see it with ha audio info?

No, there is only the Dummy Output.

  card:
  - driver: module-alsa-card.c
    index: 0
    name: alsa_card.usb-Generic_USB_Audio_201405280001-00

@balloob Does I need to add this in configuration.yaml?

No. This is output of ha audio info.

No. This is output of ha audio info.

@balloob Okay. I have :

I've opened a clean and precise issue #77