Import-Module : Could not load file or assembly System.Collections.Immutable

Steps to reproduce
I'm running into the following error while trying to use System.Collections.Immutable reference package in PowerShell binary module.
Import-Module : Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
At line:1 char:1
+ Import-Module ./CmdletPacking.psd1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : InvalidOperation: (:) [Import-Module], FileLoadException
+ FullyQualifiedErrorId : FormatXmlUpdateException,Microsoft.PowerShell.Commands.ImportModuleCommand

csproj contents:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
    <AssemblyName>SampleCmdlet</AssemblyName>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="PowerShellStandard.Library" Version="5.1.0-preview-06" />
    <PackageReference Include="System.Collections.Immutable" Version="1.6.0"/>
  </ItemGroup>
</Project>

psd1 file contents:
@{

# Script module or binary module file associated with this manifest.
RootModule = 'bin/CmdletPacking.dll'
RequiredAssemblies = 'bin/System.Collections.Immutable.dl'
}

bin contents:
CmdletPacking.deps.json				CmdletPacking.pdb				System.Collections.Immutable.dll		System.Memory.dll				System.Runtime.CompilerServices.Unsafe.dll
CmdletPacking.dll				System.Buffers.dll				System.Management.Automation.dll		System.Numerics.Vectors.dll

Expected behavior

Actual behavior

Environment data

Name                           Value
----                           -----
PSVersion                      6.2.4
PSEdition                      Core
GitCommitId                    6.2.4
OS                             Darwin 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

This happens with System.Collections.Immutable version > = 1.6.0.

It's likely that PowerShell can't load System.Collections.Immutable.dll because it already has that assembly loaded. You should see it in $PSHOME. Let us know what the output of the following is:
gci $PSHOME | ? { $_.Name -eq 'System.Collections.Immutable.dll' } | % { [System.Reflection.Assembly]::LoadFile($_.FullName).GetName() }

You won't be able to load your version and PowerShell's version at the same time, and since PowerShell uses its version very early on, it's always going to win. The best solution is probably to pin your version to the lowest version used by any of the PowerShell versions you want to support.
Also, if you're putting together a binary module (i.e. using the DLL dependency from C#/.NET rather than from PowerShell script), you probably don't want RequiredAssemblies but instead should put your DLL next to the RootModule and let PowerShell's assembly resolve event handler do the dependency resolution for you.
I'm actually about to publish a blog post relevant to this.
A few extra points:

PS 6.2.4 is out of support; you should upgrade to either 6.2.5 or preferably 7.0.1
PSStandard is now available with version 5.1.1 too
If you can provide the full stack trace of the error, it will be much easier to determine specifically what's going on. In PS 6 you'll need to do $error[0] | fl * -force, in PS 7 it's as simple as Get-Error.

@rjmholt thanks for the response. Yes, you're correct. Seems like PS has installed a version of System.Immutable.Collections.
gci $PSHOME | ? { $_.Name -eq 'System.Collections.Immutable.dll' } | % { [System.Reflection.Assembly]::LoadFile($_.FullName).GetName() }

Version        Name
-------        ----
<IP_ADDRESS>        System.Collections.Immutable

By removing the Required assemblies, I was able to import the module. However, when I try to execute the cmdlet the execution fails with the same error.
Cmdlet Code:
    [Cmdlet(VerbsDiagnostic.Test,"SampleCmdlet")]
    [OutputType(typeof(FavoriteStuff))]
    public class TestSampleCmdletCommand : PSCmdlet
    {
        [Parameter(
            Mandatory = true,
            Position = 0,
            ValueFromPipeline = true,
            ValueFromPipelineByPropertyName = true)]
        public int FavoriteNumber { get; set; }

        public static readonly ImmutableList<string> BODY_HEADERS = new string[] { "string1", "string2" }.ToImmutableList();

       ....

Cmdlet invocation:
Import-Module ./CmdletPacking.psd1
Test-SampleCmdlet -FavoriteNumber 22 -Verbose
VERBOSE: Beginsss!
Test-SampleCmdlet : Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Could not find or load a specific file. (Exception from HRESULT: 0x80131621)
At line:1 char:1
+ Test-SampleCmdlet -FavoriteNumber 22 -Verbose
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Test-SampleCmdlet], FileLoadException
+ FullyQualifiedErrorId : System.IO.FileLoadException,CmdletPacking.TestSampleCmdletCommand

Complete Error message:
$error[0] | fl * -force

PSMessageDetails      :
Exception             : System.IO.FileLoadException: Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Could not find or l
                        oad a specific file. (Exception from HRESULT: 0x80131621)
                        File name: 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' ---> System.IO.FileLoadException: Could not load file or assembly 'Sys
                        tem.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
                           at System.Runtime.Loader.AssemblyLoadContext.LoadFromPath(IntPtr ptrNativeAssemblyLoadContext, String ilPath, String niPath, ObjectHandleOnStack retAssembly)
                           at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
                           at System.Reflection.Assembly.LoadFrom(String assemblyFile)
                           at System.Reflection.Assembly.LoadFromResolveHandler(Object sender, ResolveEventArgs args)
                           at System.AppDomain.InvokeResolveEvent(ResolveEventHandler eventHandler, RuntimeAssembly assembly, String name)
                           at CmdletPacking.TestSampleCmdletCommand.ProcessRecord()
                           at System.Management.Automation.Cmdlet.DoProcessRecord()
                           at System.Management.Automation.CommandProcessor.ProcessRecord()

TargetObject          :
CategoryInfo          : NotSpecified: (:) [Test-SampleCmdlet], FileLoadException
FullyQualifiedErrorId : System.IO.FileLoadException,CmdletPacking.TestSampleCmdletCommand
ErrorDetails          :
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo : {}

We plan to support PowerShell modules for the Powershell >=6.0 version. Is there a way we could make this work with my current package configuration?

Is there a way we could make this work with my current package configuration?

There is, but the ease of it depends on the circumstances.
The easiest way to fix the issue is to downgrade your dependency versions to support System.Collections.Immutable v 1.2.3.
Otherwise, I'm planning to publish a blog post on the PowerShell Team blog in the next week that goes over a number of other ways to make this work. All the other techniques though are more complicated.
PS 6 is planned to go out of support in about 3 months (by 2020-06-01), so it might be worth evaluating whether implementing a more complex solution is worth it for that kind of support duration.
Worth taking a look at https://github.com/PowerShell/PowerShell/issues/12920.
I'll mark this as a duplicate of https://github.com/PowerShell/PowerShell/issues/2083.

@rjmholt

The best solution is probably to pin your version to the lowest version used by any of the PowerShell versions you want to support.
I tried testing System.Collection.Immutable 1.5.0 on PS 6 and PS 7 versions, Powershell is able to import the assembly in both the versions whereas if I upgrade the version to 1.7.0, the Import breaks on Powershell 6. Based on this can we safely assume that Powershell modules with System.Collection.Immutable dependent assembly works if System.Collections.Immutable version <= Powershell's System.Collection.Immutable version?

Could you please share your doc link here when you publish it? Thanks a lot for the quick response, very much appreciated :)

Another thing to try is building your module against the Microsoft.PowerShell.Sdk package -- the only problem is that that will mean you'll have to target netcoreapp3.1

Blog post has been published: https://devblogs.microsoft.com/powershell/resolving-powershell-module-assembly-dependency-conflicts/


Bugs in python_package

In setup.py

URL should not be included
Only include license if a license file is generated
Review classifiers

In prompts:

Provide a 2 list example/default for package dependencies

Should you be able to use a template if only a .git folder exists?

Ultimately yes, currently no.
Resolving #13 would make this possible.


Remove GSL optional dependency

[Current coverage][cc-pull] is 92.86%

Merging [#171][cc-pull] into [master][cc-base-branch] will increase coverage by 0.76%

@@             master       #171   diff @@
==========================================
  Files            68         71     +3
  Lines          4098       4382   +284
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3774       4069   +295
+ Misses          324        313    -11
  Partials          0          0

3 files (not in diff) in python/test were created. more
File ...rce/end_criterion.py (not in diff) was modified. more

Misses -11
Partials 0
Hits +11

[][cc-pull]

Powered by Codecov. Last updated by [3a0aa6e...0d5c362][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ORNL-CEES/Cap/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ORNL-CEES/Cap/compare/3a0aa6edf882c0210c3e47dadaf53825c178db1a...0d5c36247fc68a0bae033e3eb74a52d1d4fcc84c
[cc-pull]: https://codecov.io/gh/ORNL-CEES/Cap/pull/171?src=pr


sos fail to submit task

Following commands:
sos run /restricted/projectnb/casa/xqtl-pipeline/pipeline/TensorQTL.ipynb cis \
    --genotype_file /restricted/projectnb/casa/skandoi/ROSMAP_DLPFC/PDP_rnaseqc/ROSMAP_NIA_WGS.leftnorm.filtered.filtered.plink_files_list.txt   \
    --phenotype_file /restricted/projectnb/casa/skandoi/ROSMAP_DLPFC/PDP_rnaseqc/dlpfc_batch_all.rnaseqc.low_expression_filtered.outlier_removed.tmm.expression.bed.processed_phenotype.per_chrom.recipe \
    --covariate_file /restricted/projectnb/casa/skandoi/ROSMAP_DLPFC/Covariate_data_preprocessing/dlpfc_batch_all.rnaseqc.ROSMAP_xqtl_covariates.ROSMAP_NIA_WGS.pca.projected.resid.PEER.gz \
    --cwd /restricted/projectnb/casa/skandoi/ROSMAP_DLPFC/TensorQTL/rnaseq_eQTL/  \
    --container /restricted/projectnb/casa/xqtl-pipeline/container/singularity/TensorQTL.sif \
    --walltime 100h \
    --numThreads 20 \
    --mem 40G -J 50 -c csg.yml -q neurology -s build -n

failed to submit task and produce following errors:
INFO: Checking cis_1:
INFO: te67a6852f0a3d644 restart from status failed
INFO: te67a6852f0a3d644 started
WARNING: Check output of bash ~/.sos/tasks/te67a6852f0a3d644.sh failed: Command 'bash ~/.sos/tasks/te67a6852f0a3d644.sh' returned non-zero exit status 1.
ERROR: Failed to submit task te67a6852f0a3d644: Command 'bash ~/.sos/tasks/te67a6852f0a3d644.sh' returned non-zero exit status 1.
ERROR: [cis_1]: [te67a6852f0a3d644]: Task te67a6852f0a3d644 returns status failed
[cis]: Exits with 1 pending step (cis_2)

This is most likely due to using -n with -J 50 -c csg.yml -q neurology -s build -n
However, when redoing the same command without the -n, the problem persists, which may be due to cache in ~/.sos.
When redoing the command without -s and -n, the problem disappear even without removing the cache


First tests and Github Action

Create a test suite and write one test that tests the proper creation of verification_configurations (should we renamed this back to presentation_request_configurations)?
Add github action to run the test suite on Pull Request.

Closed with #245, test suite and github action run. Test coverage to be increased in future work.


What to do with paymentResponse?

Testing with apple pay is working on physical device. But I am unsure if I need to do further processing with the paymentResponse(TransactionIdentifier type) to make sure the transaction was valid. I get the following object returned from the transaction:
{
   "data":"string",
   "signature":"string",
   "header":{
      "publicKeyHash":"string",
      "ephemeralPublicKey":"string",
      "transactionId":"string"
   },
   "version":"EC_v1"
}

Hi, you need to ask your payment provider what they waiting for response...
because from sdk you can get token which include this object but like a string


Is it possible to add continuous scroll instead of a button ? thanks

Is it possible to add continuous scroll instead of a button ?
Button is also fiddly as well, sometimes appears, sometimes doesn't
thanks

You mean an infinite scroll?
You could make changes to the watchForScroll listener in ProductList component. Instead of setting setScrollAtBottom(true); you can just fire the onFetchMore() method. Also remove the button and replace it with a text.


[ISSUE #4211] Add JavaDoc for eventmesh.runtime.admin APIs (not in dashboard)

Fixes #4211.
Motivation
Please see https://github.com/apache/eventmesh/issues/4211.
Modifications
Write comments for classes and methods in the org.apache.eventmesh.runtime.admin package which haven't been integrated in the eventmesh-dashboard.
Some webhook related classes are also commented in order to provide help for others to understand, such as the logic of which implementation to use for WebHookConfigOperation interface.
Example:

No changes are made in codes except the redundant toString() is removed in RedirectClientByIpPortHandler.
Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@mxsm Thank you for your valuable opinion. For the existing single-line comments in the code, I hope they can be presented in natural language to reduce the time others spend on inspecting the source code. This way, one can more directly understand a relatively complex data structure and its purpose for being used here.
For instance, in this picture, the specific meaning of traversing keys and values in nested iterations requires looking at the property definitions of the entity class to understand. However, single-line comments can precisely indicate different levels and directly inform readers about the relationship between these entity classes and the concept of "client group."

By doing so, readers only need to go through the comments to understand the workflow of this handler and to clearly divide sections for retrieval, validation, processing, and response logic.
Of course, I will also consider your suggestions to further streamline single-line comments with relatively clear meanings.
As for what you mentioned about "class properties", if you are referring to the attributes of entity classes, rest assured that I have hardly added comments for class properties, except for improving the existing ones to better express their purposes.
Lastly, I will squash multiple commits into a new branch for the pull request. Thank you for your excellent suggestions.

@mxsm I have streamlined and reduced existing single-line comments. 😉

@mxsm @pandaapo @xwm1992 PTAL~😊


Update rustfmt and formatting

Coverage decreased (-0.5%) to 79.117% when pulling d16afb90eac11e25f2662206f5bf188fbd736eda on task/updateFmt into 79052d5cb675d76e524b2764af3c66507cd8ef4c on develop.


Support localization

This PR adds support for localization for toolkit. However, there are more strings needs to moved in the file and get translated later on.

Useful initializers:

String(localized:comment:)
Text(_:format:)
Int.formatted(_:)


How do I build cblas64.dll?

Discussed in https://github.com/microsoft/vcpkg/discussions/27160

Originally posted by sildeag October  9, 2022
./vcpkg install lapack only builds lapack.dll and blas.dll there does not seem to be anywhere to customized options and it uses GNU compiler not MSVC.
I wanted lapack64.dll, blas64.dll, and cblas64.dll.  All were produced using git repo for LAPACK but the cblas64.dll had errors so I only was able to build lapack64.dll, blas64.dll, and cblas64.lib (not dll).
I first tried MSVC 2022 community ed. directly but it had issues with EXTERNAL system function ETIME.  I then tried Qt Creator 8 with MSVC 64-bit Debug, then vcpkg.
Using MSVC 2022 Community C++ with Qt Creator 8 cblas64 generates errors:
 1>cblas_sdot.obj : error LNK2019: unresolved external symbol SDOTSUB referenced in function cblas_sdot
     1>cblas_sdsdot.obj : error LNK2019: unresolved external symbol SDSDOTSUB referenced in function cblas_sdsdot
     1>cblas_snrm2.obj : error LNK2019: unresolved external symbol SNRM2SUB referenced in function cblas_snrm2
     1>cblas_sasum.obj : error LNK2019: unresolved external symbol SASUMSUB referenced in function cblas_sasum
     1>cblas_isamax.obj : error LNK2019: unresolved external symbol ISAMAXSUB referenced in function cblas_isamax
     1>cblas_scasum.obj : error LNK2019: unresolved external symbol SCASUMSUB referenced in function cblas_scasum
     1>cblas_scnrm2.obj : error LNK2019: unresolved external symbol SCNRM2SUB referenced in function cblas_scnrm2
     1>cblas_ddot.obj : error LNK2019: unresolved external symbol DDOTSUB referenced in function cblas_ddot
     1>cblas_dsdot.obj : error LNK2019: unresolved external symbol DSDOTSUB referenced in function cblas_dsdot
     1>cblas_dnrm2.obj : error LNK2019: unresolved external symbol DNRM2SUB referenced in function cblas_dnrm2
     1>cblas_dasum.obj : error LNK2019: unresolved external symbol DASUMSUB referenced in function cblas_dasum
     1>cblas_idamax.obj : error LNK2019: unresolved external symbol IDAMAXSUB referenced in function cblas_idamax
     1>cblas_cdotu_sub.obj : error LNK2019: unresolved external symbol CDOTUSUB referenced in function cblas_cdotu_sub
     1>cblas_cdotc_sub.obj : error LNK2019: unresolved external symbol CDOTCSUB referenced in function cblas_cdotc_sub
     1>cblas_icamax.obj : error LNK2019: unresolved external symbol ICAMAXSUB referenced in function cblas_icamax
     1>cblas_zdotu_sub.obj : error LNK2019: unresolved external symbol ZDOTUSUB referenced in function cblas_zdotu_sub
     1>cblas_zdotc_sub.obj : error LNK2019: unresolved external symbol ZDOTCSUB referenced in function cblas_zdotc_sub
     1>cblas_dznrm2.obj : error LNK2019: unresolved external symbol DZNRM2SUB referenced in function cblas_dznrm2
     1>cblas_dzasum.obj : error LNK2019: unresolved external symbol DZASUMSUB referenced in function cblas_dzasum
     1>cblas_izamax.obj : error LNK2019: unresolved external symbol IZAMAXSUB referenced in function cblas_izamax
Qt_6_4_0_MSVC2019_64bit\bin\Debug\cblas64.dll : fatal error LNK1120: 20 unresolved externals

Any help would be appreciated.

Should cblas be added to vcpkg as a new port？

I have sent instructions to the builders of lapack so that they can include notes on how to successfully make all the dlls including CLAS64.dll on Windows 11 using MSVC 2022 Community Ed.  I have the dlls so no longer need this added.  I used MSYS2 64bit and MSVC 2022.


Little issue in some transition effects, a thin vertical line scroll in vertical along the slideshow

Hi jssor
I think this little bug came out from the last update, before that it was ok (1-2 months)
http://www.renieriarchitetto.com
if you look the slideshow on the homepage and wait some transitions you will see a vertical line scroll in vertical along the middle of the slideshow at the end of its translation.
I'm using the last version of firefox
thanks
bye

No big deal, it's correct. As your slider is responsive, it will scale base on the window size.
When slideshow plays, width/height of each block may be not integer value, that makes the browser has 1px tolerance to render it.
I see you have transition that plays image in from outside, I guess it would look better if you have transition to play image out from inside.

ok thanks


version: Add QEMU and kernel with virtiofs 3.0

This adds QEMU and the kernel with virtiofs 3.0 at the versions.yaml
file.
Depends-on: github.com/kata-containers/packaging#710
Fixes #2051
Signed-off-by: Gabriela Cervantes<EMAIL_ADDRESS>

/test
lgtm


mssing md5?

Initially had an error that pointed to md5 but should it be _md5? this is the error im receiving any help would be appreciated.
File "C:\Program Files (x86)\JetBrains\PyCharm 2016.2\helpers\pydev\pydevd.py", line 1556, in
globals = debugger.run(setup['file'], None, None, is_module)
File "C:\Program Files (x86)\JetBrains\PyCharm 2016.2\helpers\pydev\pydevd.py", line 940, in run
pydev_imports.execfile(file, globals, locals)  # execute the script
File "C:\Program Files (x86)\JetBrains\PyCharm 2016.2\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "D:/git_repo/security-analysis/Fennell_Work/Connect_DB_Test.py", line 276, in
create_webshrinker()
File "D:/git_repo/security-analysis/Fennell_Work/Connect_DB_Test.py", line 243, in create_webshrinker
response = webshrink.lookup("https://lon-capa.msu.edu")
File "C:\Python35-32\lib\site-packages\webshrinker_init_.py", line 187, in lookup
(response, result) = self.request_json(url)
File "C:\Python35-32\lib\site-packages\webshrinker_init_.py", line 122, in request_json
response = self.request(method, parameter)
File "C:\Python35-32\lib\site-packages\webshrinker_init_.py", line 88, in request
url = self.signed_url(method, parameters)
File "C:\Python35-32\lib\site-packages\webshrinker_init_.py", line 75, in signed_url
hash = md5.new(to_hash).hexdigest()
AttributeError: 'builtin_function_or_method' object has no attribute 'new'

The Python package was updated to use hashlib which solved this issue, I'm going to close it out. The version was bumped to 2.1 for this fix.


Fix exit scene behavior (when exit is anticipated)

In this PR, we fix the following situations:

Start Scene somewhere. Then start scene at another line. Confirm Kill it. Before this change, this resulted in a new scene being created and after that being immediately destroyed. The Manim Shell was left in a weird state.
Preview a Manim Cell. While previewing issue "Start scene" somewhere else and confirm Kill it. Before this change, the progress notification would remain frozen in the last position indefinitely.
Preview a Manim Cell. While previewing, manually open a new terminal, start manimgl in there. The first session should automatically exit, while the second is booting up.

Known limitations

We currently don't detect when the user forces the shell to exit by other means, e.g. by clicking on the trash bin. This may result in indefinite progress bars when force-quitting the shell during previewing. This can be tackled in a future PR.

It seems like I am now unable to start a terminal at all on my device. Could this be because I am running inside a conda environment where manimgl is installed?

Cold you check again if it's working now? And make sure to have a clean state, sometimes during extension development VSCode has some caching issues during reload, so start with a fresh new instance. (at least this was sometimes a problem for me)

Could this be because I am running inside a conda environment where manimgl is installed?

No, I don't think this would be an issue. We are only erroring in case we are trying to spawn a new shell but receive an TerminalShellExecutionEndEvent. We're not even checking if there's anything special about the user's environment. We just want to see the manim welcome string and then the first In [1]: statement and then we know we have successfully started.
So, when you receive this error message, the terminal should also open up automatically. What does it show?
Does this problem only occur with this PR, not already with #45? So on main, it's working for you, just not here?

It seems like I am now unable to start a terminal at all on my device. Could this be because I am running inside a conda environment where manimgl is installed?

This can happen if you e.g. place your cursor here:

class SquareToCircle(Scene):
    def construct(self): <--- here, on the `construct` method
<--- here, on empty lines just before the line with `construct` method
<---
<---
        ## Set up
        circle = Circle()
        circle.set_fill(BLUE, opacity=0.5)
        circle.set_stroke(BLUE_E, width=4)
        square = Square()
        #

The fix is easy - we just need to add this logic to startStopScene.ts
I just overlooked this edge case the first time when I wrote it

@Splines , I just tried this branch - I have the error

@Splines , you wrote 3 points above.
I checked:

works 👍
I still get: "No active Manim session found to exit."
auto-exits👍. But I still get: "No active Manim session found to exit."

Thoughts:

I love (!) the integration right with the VSCode notifications!!

question: do we need to kill old Manim window before starting a new one?
Can't we have multiple Manims running at the same time - just in multiple terminals?
Do we need to auto-exit from the previous one if the user opens a new terminal and types manimgl? That doesn't sound permissive to the user..

Thanks for testing this out @VladimirFokow! As a few things have changed in the meantime, would you mind checking it out again? And if it doesn't work, could you attach respective log files, where each of them tries to do as minimal things as possible? (e.g. one for each scenario)

why do we need to kill the old Manim window before starting a new one?
Can't we have multiple Manims running at the same time - just in multiple terminals?

In theory it'd be possible to spawn multiple Manim instances. But the situation I try to avoid is the following:

User wants to preview some code, so Manim is started in a new terminal.
User manually opens up another terminal and types in manimgl. This is fine and should already work: we detect the new terminal as "Manim host" when we see the ManimGL string in the Terminal (this exact capitalization), followed by the first IPython cell. So this new terminal will be used to preview cells. At this state it'd be perfectly fine to have multiple Manim sessions open.
Now image we didn't kill the session that is still running in the first terminal. The user decides to quit the second terminal and switches over to the first one. They expect that "Preview Manim Cell" will use this terminal now, which is not the case. The problem is that Manim was already spawned in this terminal, but later we used the second terminal. So from the point of view of the code, we don't know that manim is still running in the first one. And we didn't retrieve the ManimGL string from that terminal a second time, so we don't know that this is a "Manim host". Therefore, clicking on "Preview Manim Cell" would again open a new Manim session and the user would be confused.

In theory, supporting the scenario would be possible. But that'd require even more state management, e.g. we'd have to track the terminals and multiple Manim executions across different terminals. I just didn't want to do that, which is why I settled with this limitation (which I don't think is a serious limitation: why would you want to have two Manim previews open at the same time anyways?)

currently this happens:
Log:
Manim Notebook.log
https://github.com/user-attachments/assets/3300d0dd-fca6-4de4-bc12-09e954a0eb3b
from manimlib import *

class MyScene(Scene):
    def construct(self):
        ## Test
        print('1')

@VladimirFokow Ready for another review ;)

1, 2 don't work.
Log: Manim Notebook.log

I suspect this might have broken it:
https://github.com/bhoov/manim-notebook/pull/64

Just that we're at the same page: what does "before" in It worked before. refer to? Now with main merged back into this one, what is different compared to your first comment:

works 👍
progress notification disappears 👍, but I still get: "❌ No active Manim session found to exit."
it auto-exits 👍, but I still get the same as above: "❌ No active Manim session found to exit."

Could you maybe attach some logs for the specific cases 1, 2 and 3?

on commit 58f06caae32c9158bec1a2c14d501b9b7cf53e7a:

1 doesn't work:

Manim Notebook.log
https://github.com/user-attachments/assets/43d8e942-a4a6-4ccb-85b2-e62df1e24624

Works on: 409c90643ca414ad1d1b2006b64d0d7b51cf1357
https://github.com/user-attachments/assets/35d90f53-a68f-49ba-b9f9-52a64136b281

Thank you for the reports! If in 58f06ca you place a logging statement right before the return here:
https://github.com/bhoov/manim-notebook/blob/58f06caae32c9158bec1a2c14d501b9b7cf53e7a/src/manimShell.ts#L334-L336
Will it show up for you in the log, even though you press Kill it?

Ok, so as I expected... And with 627ca8a, the log will show ❌ User selection undefined, but shouldn't be?

Nevermind, found the error, will fix it

It should work now, right?

still doesn't..

ok, I can confirm, doesn't also work on my machine, will investigate

Ok, apparently I'm a bit unconcentrated 😅 Now it should work with 9879a7e

great, now 1 works again!

but the above mentioned errors in 2 and 3 still persist

Ok, at least 1 works now ;) Could you send me logs for 2 and 3 based on the current state, i.e. 9879a7e?

3
Manim Notebook.log
https://github.com/user-attachments/assets/9f0e0cea-6eb7-4937-9a11-43d5055a581d

Ah ok, yeah the reason is that I send a keyboard interrupt to close the active running session (but stay in IPython), then send an exit() command to exit the scene. But of course that doesn't work on MacOS since already the keyboard interrupt closes everything.... So that's why we get the error since after closing (via Ctrl+C), it won't find an active shell to close 😅
Another idea might be to just force-kill the respective VSCode terminal. Then the behavior should be independent on Linux or MacOS.

I like killing the terminal because then the user won't have the dangling terminals after every restart

ok will implement this now

first interrupt, then force-kill?

because just force killing may cause some bad state?

If I force-kill the 1st manim terminal,
when starting the 2nd, I have this hanging:

Yes, this is a known limitation from an earlier PR because we don't detect when terminals are manually disposed by the user. But it's not a problem programmatically since at the required step we know we now throw away the terminal, so we can just reset the state at that point.

In e10359e I fixed the try-catch error handling which I have done just outright wrong as I was used to how other languages handle the catch blocks. Here, instead we have to check for isinstanceof.
Now with 22663a7, I reworked the exit mechanism to force-quit.

ah. I think we can finally put this PR to rest 😅😅

One last problem I just discovered is that when previewing a long command, then using the command to quit the scene, the scene will continue to finish rendering and only then exits the ManimGL preview window. Will investigate.

the scene will continue to finish rendering

Even if I manually delete the terminal, this still happens

What about now?

If I quit in the middle of long-running previewing, now:

/Users/vladimir/.pyenv/versions/3.11.6/lib/python3.11/multiprocessing/resource_tracker.py:254: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown

If I quit in the middle of long-running previewing, now:

But not by trashing the terminal manually. You use the Quit Scene command provided by us, right?

This is the behavior I get as of 293b93d
https://github.com/user-attachments/assets/3ac8e853-6b17-4fea-b520-5aeefbe24398

/Users/vladimir/.pyenv/versions/3.11.6/lib/python3.11/multiprocessing/resource_tracker.py:254: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown

How do you even see these error messages now that the terminal is disposed almost immediately (after sending keyboard interrupt and a small delay of 250ms)?

By trashing manually - it's awful

even if I got that warning, I trashed the terminal, so the warning is also trashed
the scene still continues to run
the progress bar is stuck at the point when I trashed it

I would vote to revert the last commit & merge

please read this carefully:
https://github.com/bhoov/manim-notebook/pull/48#issuecomment-2450405618

By trashing manually - it's awful

As I wrote earlier, this PR does not deal with the case where you trash the terminal manually. See the title of this PR: when exit is anticipated. This could something for a subsequent PR, but this one is not dealing with it. Only using the commands that we provide in the extension.

okay, good that we got this clear
(I thought you asked at some time and then deleted it)

(I thought you asked at some time and then deleted it)

What is "it" in "deletet it"? Your conversation? Now, not at all, I've just marked one of the message as off-topic, that's all ;)

How do you even see these error messages

when I press Ctrl+C manually - I see it

when I run the stop command - the terminal isn't deleted, so it's there in the terminal

hm.. now it's disposed.. let me check again

Sorry, but I'm not sure how the current behavior looks like at your end. You use Quit preview and the terminal still stays up running?
If the behavior is indeterministic for you, I think I know why and could fix that...

I just want to check one more thing, could you please send me the log for just , that'd be awesome.

Start scene at any line. (But don't preview code)
Then use Quit preview

My behavior on commit 293b93dd1df14c92fdde9835d99f60ab3c7e05ee:

preview long-running scene
in the middle: "Manim Notebook: Quit preview"
the terminal is NOT disposed. In that terminal I see the warning

I see that some resourced leaked:

The fact that you see this when you press Ctrl+C shows that this is a Manim-problem and not ours, I guess. And this shouldn't be a big problem, we're trashing the terminal afterwards anyways and Python itself will do some resource-cleanup as well. And even if something leaks... well, then it leaks and the next time you start VSCode this leakage is probably gone...
But where this is of course a problem is when this hinders us somehow from disposing the terminal altogether. Could you maybe record a video for me to better understand what is going on at your end?

But it should always be possible to just force-quit any task. I mean we're in a terminal so we can stop anything if we want to. When using manimgl via the command line I'm employing Ctrl+C all the time if I don't want to continue to watch my preview. That's why I'd like to be able to quit any preview via the extension as well. It's the user's power: of course you might risk some leakage when you quit mid-preview, but is that really an issue? This is just a leakage warning; yes: possibly a small leakage did occur. But it's probably also so small as to go unnoticed. In the end, the OS will free up resources anyways in much deeper layers...

Log 1:
Manim Notebook.log
https://github.com/user-attachments/assets/6935e115-d882-40d4-844c-af33dc836cef

Log 2:
Manim Notebook.log
(sorry, accidentally clicked twice, but it shouldn't matter)
https://github.com/user-attachments/assets/7afabfb5-8e3a-4a56-80ad-d1a669ceae31

we even ask the user to confirm Kill it. It's their choice

ok

Log 2:

Thank you very much! In the background there is a trace shown for startStopScene, is that relevant? Or was it from a previous session?

The issue was again how MacOS handles the keyboard interrupt. It will end the whole IPython session, which is why a TerminalShellExecutionEndEvent is triggered. This in turn calls this.resetActiveShell()  which sets this.activeShell = null;. Therefore, we didn't have the reference to the active shell anymore. On Linux, we still have this reference since a TerminalShellExecutionEndEvent is never triggered in this case due to Ctrl+C just exiting the command inside the IPython kernel, but not the whole IPython kernel itself. Therefore, I didn't encounter this problem.
Now to mitigate this, I temporarily store the last active shell before sending the keyboard interrupt. This way, when it comes to disposing the terminal, we still have a valid reference. See 9abc645

Just by the way, when you start the Record Log File command. You don't always have to select the log level. Just press Esc. If you've set it once to Trace it will stay in this setting for the next runs.

Just by the way, when you start the Record Log File command. You don't always have to select the log level. Just press Esc once clicked on the command. If you've once set the log level to Trace it will stay in this setting for the next runs.

oh, thanks!
could you please add it to the readme as well?

Sorry I revoked my comment since it wasn't true. You can't just press Esc. While the default for the extension will stay the same (when not reloading the window, just using the command multiples times), you still have to select the extension in the dropdown, otherwise the global default will be considered (which is Info).

This fixed the issue: https://github.com/Manim-Notebook/manim-notebook/pull/48#issuecomment-2450533185

Sorry I revoked my comment since it wasn't true. You can't just press Esc. While the default for the extension will stay the same (when not reloading the window, just using the command multiples times), you still have to select the extension in the dropdown, otherwise the global default will be considered (which is Info).

I think I just tested it, and got the opposite result..
Anyway, it's not important. We won't change the readme

Since you've already approved: just write a comment once you approve this PR ;)

can merge

Wohoo, nice that it works now for you as well 💫 Lesson learned, exiting is not as easy as expected ;) This would be a lot easier if there was a fix for https://github.com/3b1b/manim/discussions/2236
A future PR can now tackle the case where the user manually disposes a terminal. In this case, we want to detect this event and then reset the state accordingly.

And thanks a lot for your on-going manual testing support in this one @VladimirFokow ❤

I should have done all this myself,
I just didn't have the capacity to dive into the code yet

Don't worry there will be enough future issues waiting for you ;)

please no😅
Let's try writing code without any issues the 1st time)

Let's try writing code without any issues the 1st time)

Haha, that's the goal, but rarely achievable in real life (I speak from experience, even with a nice testing harness, there will still be bugs). Otherwise it'd be too boring 😅

And just a little remark for the future @bhoov @VladimirFokow : you don't have to review code in PRs that are marked as draft 😇. Just to not waste any time since those PRs are usually a little bit of my playground until I finalize them. Beforehand, lots of things won't work even though the PR itself might look like all the features are implemented.


feat: implement retry strategies ♻

Now the task can be set up to retry on failure. By default, we only make a single execution attempt.
The retry mechanism is implemented in https://github.com/kamilsk/retry/v5 . I chose this package over https://github.com/eapache/go-resiliency because retry has a much more flexible API, provides a ton of strategies and backoff algorithms and the strategies are nicely defined via an interface, making extensions and customisations very easy.
Unfortunately, the last update to retry was in February 2021 so I might yet regret this decision but for the time being I feel like this is the superior choice over go-resiliency.

This partially implements #5. More work is still needed to incorporate all features from that pull request, namely being able to cancel long-running tasks.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (026eb05) to head (14a4f2b).

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           51        65   +14
=========================================
+ Hits            51        65   +14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


pipeline inference bug

Hello Developers,
I've encountered a bug where inference for InternLM-XComposer2-4kHD using the pipeline works correctly only with lmdeploy==0.5.0. Higher versions produce unexpected outputs with the same fine-tuned model. Could you please look into this?

Does the logger prints same prompt_token_id when you using different versions of lmdeploy and setting the log level to INFO ?

@irexyc Completely different, I put some screenshot for your reference, the later is normal result.

With the prompt_token_id in your log, I think the problem is the first doesn't match the right chat template.
Lmdeploy use the folder name to match template by default, I'm not sure if it is related the change of matching rules.
You can try initialize the pipeline by specifically setting the  chat_template_config
pipeline(..., chat_template_config=ChatTemplateConfig('internlm-xcomposer2'))

@irexyc Thank you for your solution; it indeed fixed the issue. Version 0.5.0 supports the chat template 'internlm-xcomposer2-4khd', while later versions should use 'internlm-xcomposer'.


Git mobile fixes

[x] Add badging to settings nav
[x] Change loading logic so new repos show up on mobile
[x] Scrollviews on more screens on mobile (really route-tree should do this maybe by default)

Best to look w/ whitespace on https://github.com/keybase/client/pull/8665/files?w=1

@keybase/react-hackers

well i figured this is common logic so... i dunno, any suggestions?


Update Somerville DIBELS rules with "Benchmark" => "CORE"

Who is this PR for?
Somerville educators.
What problem does this PR fix?
Didn't realize earlier that DIBELS benchmark value of "Benchmark" means "CORE".

selfie


feat: MB.js 2.0.0-Alpha "port"

ok, will have to talk to josh to set this up propperly on the server


attacks can be mitigated, not migrated

@int-ua Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@int-ua This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.


Move stats examples to the equivalent maven path.

Yes we would like to move all the code to follow the maven preferred path.


Profile Setting not available

Bug Report

Profile setting option in navbar redirects to 404 page

Steps to Reproduce

Signin/Login in your account
Go to Navbar>Profile Setting

Supporting Video
https://user-images.githubusercontent.com/59157988/148006438-ceb479aa-4e12-4a34-8e12-3de73ab1747b.mp4

Thanks for the mention @tusharjain0022
Will be adding the profile view soon.

Fixed with #4


Merge one working branch (UpdateCheckConditions) into another

Two of my own working branches, want to ensure everything works as intended.

I'm going to discard this branch and just reproduce the changes in a new branch.


How to precache Firebase?

Library Affected:
workbox-sw, workbox-build, etc.
Browser & Platform:
Google Chrome v51.0.1 for Android, or "all browsers"
Issue or Feature Request Description:
How to precache Firebase?
When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

What do you mean by "Firebase" in this context? Are you asking about the JavaScript library files, data from a Firebase datastore, or something else?

Thanks for your response. I mean the data from firebase data store.

As of right now, the best approach would be to interact with Firebase via its REST API, and set up a runtime caching policy to cache the data.
The Firebase Realtime API uses websockets to communicate with the server, and websockets can't be intercepted by service workers.
Offline support for the Realtime API has been attempted via helper libraries that run outside the service worker; the most robust that I'm aware of uses https://github.com/PolymerElements/app-storage to mirror the Firebase data in IndexedDB.


Autofill not working on 2-letter words

Any idea why? Everything else is ok, but when a crossword includes an empty 2-letter word, the autofill instantly says no solutions.  1-letter is ok and anything above 2 is ok.

Line 845 in cross.js inside runSolvePending should have a for loop starting at 2, not 3. It works after set to 2.


[DDW-659] Review and fix incorrect :global instances in scss files

This PR fixes incorrect :global instances in scss files.
Testing Checklist

Slack QA thread
[ ] Test all UI components as the changes applied were affecting whole application

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@aleksandardjordjeviciohk Hi Aleks.
The dot near the bell is missing. Confirmed at Windows and Linux.
Screenshot1
Screenshot2
Looks good at Dev Build

@aleksandardjordjeviciohk Hi Aleks.
The dot near the bell is missing. Confirmed at Windows and Linux.
Screenshot1
Screenshot2
Looks good at Dev Build

Fixed @dmitrii-gaico


GetCellValue does not return raw value, even with the option RawCellValue: true

Unless I am reading the doc from, I suppose by passing the GetCellValue with the option RawCellValue set to True:
	cell, err := f.GetCellValue(sheet, cellLoc, excelize.Options{
		RawCellValue: true,
	})

I can get the raw text of what has been written in the cell.
Does not seem to be the case though.
The above line would gimme me the result of the formula, a number, in var cell but I need is the formula string, like =SUM(O4,N4)
So, is this a bug, or am I not looking correctly, in which case what should I do to get exactly what has been written in the Cell?
Thank you

Thanks for your issue. Please use SetCellFormula to get the formula from the cell and use GetCellType to determine which cell is a formula cell.

You mean to use GetCellFormula right?
Well, the thing is if the Cell contains =SUM(O4,N4), then the formula will be O4+N4.
I need the formula string due to the fact that that my Cell has [LET](https://support.microsoft.com/en-us/office/let-function-34842dd8-b92b-4d3f-b325-b8b8f9908999) function, which cannot be parsed (yet), so I need the raw string formular to run it through a custom LET parser that I wrote.
But I cannot because if the formula has LET, it will not work properly. But I cannot get the ră string formular.
Basically, I just want to know how (or is it possible) to get the Raw string fomular.
Thank you.

Thanks for your issue. Please use SetCellFormula to get the formula from the cell and use GetCellType to determine which cell is a formula cell.

You mean to use GetCellFormula right?
Well, the thing is if the Cell contains =SUM(O4,N4), then the formula will be O4+N4.
I need the formula string due to the fact that that my Cell has [LET](https://support.microsoft.com/en-us/office/let-function-34842dd8-b92b-4d3f-b325-b8b8f9908999) function, which cannot be parsed (yet), so I need the raw string formular to run it through a custom LET parser that I wrote.
But I cannot because if the formula has LET, it will not work properly. But I cannot get the raw string formular.
Basically, I just want to know how (or is it possible) to get the Raw string fomula.
Thank you.

Any update on this?
I just want to get the raw raw formular, not the formula that has been passed. Thank you.

Hi @pgalbavy-itrs, thanks for your feedback, could you provide your input file attachment without confidential info?

Will try - it turned out the cell was formatted by the user with some weird combination of languages and numeric types. I will have to go find a copy of the XLSX file before they fixed it on our advice.


undefined reference to `reflect.unsafe_New'

Hello!
I have tried to compile my own project which has a dependency of "reflect2" package with the most recent gccgo but failed with a message of "undefined reference". Is it possible to make it compile using gccgo?
Details shown below:
What version of "reflect2" is used to compile?
The most recent commit (commit 333559e1834b0c1840d283d79220bf121d704022).
What version of Go are you using (go version)?
go version go1.16.3 gccgo (GCC) 11.0.1 20210423 (prerelease) linux/amd64

Additionally, gccgo --version tells:
gccgo (GCC) 11.0.1 20210423 (prerelease)
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

What operating system and processor architecture are you using?
$ cat /etc/issue
Arch Linux \r (\l)
$ uname -a
Linux 5.11.16-arch1-1 #1 SMP PREEMPT Wed, 21 Apr 2021 17:22:13 +0000 x86_64 GNU/Linux

What did you do?
Trying to build some code that depends on this package.
What is expected to see?
The code successfully compiles.
What you see instead?
/usr/bin/ld: /home/lam/.cache/go-build/fd/fd4891df5167b3e9b000124e5b53c9fccc0f3aa55647fda5583b97f1c087b5d9-d(_go_.o): in function `github_0com_1modern_x2dgo_1reflect2.UnsafeSliceType.UnsafeMakeSlice':
/home/lam/go/pkg/mod/github.com/modern-go/reflect2@v1.0.1/unsafe_slice.go:78: undefined reference to `reflect.unsafe_NewArray'
/usr/bin/ld: /home/lam/.cache/go-build/fd/fd4891df5167b3e9b000124e5b53c9fccc0f3aa55647fda5583b97f1c087b5d9-d(_go_.o): in function `github_0com_1modern_x2dgo_1reflect2.unsafeType.UnsafeNew':
/home/lam/go/pkg/mod/github.com/modern-go/reflect2@v1.0.1/unsafe_type.go:48: undefined reference to `reflect.unsafe_New'
/usr/bin/ld: /home/lam/go/pkg/mod/github.com/modern-go/reflect2@v1.0.1/unsafe_type.go:48: undefined reference to `reflect.unsafe_New'
/usr/bin/ld: /home/lam/go/pkg/mod/github.com/modern-go/reflect2@v1.0.1/unsafe_type.go:48: undefined reference to `reflect.unsafe_New'
/usr/bin/ld: /home/lam/go/pkg/mod/github.com/modern-go/reflect2@v1.0.1/unsafe_type.go:48: undefined reference to `reflect.unsafe_New'
/usr/bin/ld: /home/lam/go/pkg/mod/github.com/modern-go/reflect2@v1.0.1/unsafe_type.go:48: undefined reference to `reflect.unsafe_New'
/usr/bin/ld: /home/lam/.cache/go-build/fd/fd4891df5167b3e9b000124e5b53c9fccc0f3aa55647fda5583b97f1c087b5d9-d(_go_.o):/home/lam/go/pkg/mod/github.com/modern-go/reflect2@v1.0.1/unsafe_type.go:48: more undefined references to `reflect.unsafe_New' follow
collect2: error: ld returned 1 exit status

Thanks for your patient and effort.

For some reason, in GCC 11 reflect.unsafe_New function was renamed to reflect.unsafe__New with two underscore. Compare:
mymedia@freesia:~$ nm -D --defined-only /usr/lib/gcc/x86_64-linux-gnu/10/libgo.so | grep 'unsafe_*New'
0000000000f05d00 T internal..z2freflectlite.unsafe_New
0000000000f05cc0 T reflect.unsafe_New
0000000000f03150 T reflect.unsafe_NewArray
mymedia@freesia:~$ nm -D --defined-only /usr/lib/gcc/x86_64-linux-gnu/11/libgo.so | grep 'unsafe_*New'
000000000100c920 T internal_1reflectlite.unsafe__New
000000000100c8e0 T reflect.unsafe__New
000000000100ca30 T reflect.unsafe__NewArray


Do we want feedback buttons on pages of the site?

I've recently got the page feedback buttons to work on the CNCF Glossary site (see at the bottom of the page). They feed events into our cncf.io Google Analytics 4 property which we can later create reports on to see which pages get good feedback, which do not.

Would we like this feature activating for the TAG Runtime site? If not, please just close this issue.

Sure, where would that feedback go to?

It would be recorded as events in the CNCF.io Google Analytics property. We could then produce reports on it.


Fix crash on close in some X11 drivers

On some X11 driver implementations, calling XCloseDisplay from a different thread causes memory corruption, resulting in a crash. Change window proxy to be a weak reference so that the XCloseDisplay is always called from the main window.

Can you rebase this on master to make sure that travis passes?

Rebased and travis passes now.

Thanks


default_route_settings 429 (Too Many Requests)

Description
Please provide a clear and concise description of the issue you are encountering, your current setup, and what steps led up to the issue. If you can provide a reproduction, that will help tremendously.
I added this to get the detailed metrics:
default_route_settings = {
  detailed_metrics_enabled = true
}

Requests to the API Gateway now fail with 429 (Too Many Requests). I expect this is because the throttling_burst_limit and throttling_rate_limit have defaulted to 0.
⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Terraform:

Provider(s):

Module:

Reproduction
Use this configuration
default_route_settings = {
  detailed_metrics_enabled = true
}

Code Snippet to Reproduce
default_route_settings = {
  detailed_metrics_enabled = true
}

Expected behavior
I get the detailed metics and throttling defaults to API Gateway defaults.
Actual behavior
It seems throttling is defaulted to 0?
Terminal Output Screenshot(s)

Additional context

There is also an issue with subsequent deployments that have the default_route_settings completely removed. The API Gateway now has throttling stuck on 0 and can't go back to 'Unconfigured'. I think I need to delete the whole API Gateway and redeploy.

Same problem here, at the end I end up without using any part of this group:
data_trace_enabled
detailed_metrics_enabled
logging_level

Because looks like these values are wrong:
      throttling_burst_limit   = lookup(default_route_settings.value, "throttling_burst_limit", null)
      throttling_rate_limit    = lookup(default_route_settings.value, "throttling_rate_limit", null)

see https://github.com/hashicorp/terraform-provider-aws/issues/5690 - you may want to set these values to "-1"

@bryantbiggs please reopen this issue, because you don't even tried your solution and you are pointing ppl to wrong and not working approach, you are not able to set these values to -1.

@cojack - you are correct on my previous mis-statement regarding setting "-1", however there isn't anything we can do to alleviate this in this module, its is completely on the AWS API side https://github.com/hashicorp/terraform-provider-aws/issues/14742

I will be glad if this issue will remain open, until hashicorp fix it on their side, thanks in advance.

it is not a Terraform issue, its is an AWS API issue. Once AWS provides a means to mitigate this issue, then the AWS provider must update and finally we can update (if needed, sometimes for fixes like this there are no module changes required)


editor.gotoLocation.many setting help text

Testing #71087
VS Code version: Code - Insiders 1.33.0-insider (b9bcca2b9830df592892d63201704026c18dcbe5, 2019-03-26T08:08:11.421Z)
OS version: Darwin x64 17.7.0
A couple of nits with this text:

I don't think we by default use the UK version of behavior so drop the u, drop the - from -commands, and capitalize the Go Tos to match what is in the UI:
Controls the behavior of the "Go To" commands such as Go To Definition, when multiple targets exist.

Thanks @chrisdias


HIVE-27575: MASK_HASH UDF generate a log per row

What changes were proposed in this pull request?
Avoid too many logs from being written.
https://issues.apache.org/jira/browse/HIVE-27575
Why are the changes needed?
Prevent disk-full or overhead.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
I checked the log is written only once.
hive-hiveserver2-859d7686f7-xwhrh: 2023-08-07T22:35:11,886  INFO [6a60330d-5988-48fb-9a94-23d9f6e5f334 HiveServer2-Handler-Pool: Thread-59] generic.MaskHashTransformer: Use SHA256 for masking

@ayushtkn Could you please review this PR? This is a follow-up of #3750. I know some environments heavily use this UDF because this is implicitly used with Ranger.

Thanks. I decided to address only the logging part. I wonder if it could be not the best to access Configuration every row. But I postpone checking or improving that part until I am sure that we should fix it.


Experiment with other dimensionality reduction techniques

https://scikit-learn.org/stable/modules/random_projection.html#random-projection

https://scikit-learn.org/stable/modules/classes.html#module-sklearn.manifold I've been told by a friend that MDS or ISOmap would do a much better job of embedding a 3D dataset on a 2D plane.


Bottomless replication requires synchronous call to S3

The issue applies both to namespace loading and metastore loading during startup.
This causes cold start to take over 10s in some cases since it requires multiple roundtrips to S3.

Agreed, this is a major issue for us too at the moment. Our load tests suffer quite a bit because of this, as spawning multiple tenant DBs in a short span causes some of the db creation requests to wait for as long as 30s and this is the case even when a single db cold start time with bottomless is quite manageable for us at 2 secs since we have a local cluster minio where our bottomless backups go to. Currently our way around this is to disable sqld bottomless backups and asynchronously trigger a bottomless backup using cli after namespace creation, which is quite hacky and we would like to move away from it.


Bad column type in MySQL

using varchar(64000) is not valid for MySQL and if auto-migrate is enabled, it would raise an error asking for the column type to be either TEXT or BLOB. Changing that to text in the model fixes the issue.
I'm not sure how to do this via a PR since go modules require the module name and path to be changed to the fork's and therefore the PR is not going to just include the model file but a bunch of other files and go.mod that refer to this repo.

Fixed, thanks for report


Synced master and releases/v1

Cherry picked all the test-related commits made to correct flaky tests.
issue

Small question about the changes in package-lock.json. Rest LGTM


Update Schneider quirks using spec docs

Proposed change
This is a start of using the leaked Schneider Electric specification docs posted by @uvNikita in #1705, linked here again for convenience: https://drive.google.com/file/d/1rM9iVhAB-AlWwWhvpEtcReSpEATi7aVH/view
So far I have looked at the light related specs and updated the attributes with the information for the specs docs.  More improvements could probably be made by incorporating info from the other device types too, but I only have light-related devices in my home (dimmers, switches, etc) so I can't test any other changes right now.
The comments have a number of grammar issues etc, but I copied them verbatim from the spec, so if there are any ambiguous statements, your guess is as good as mine!
Additional information
This PR renames some python variables/constant names to match the spec.  I doubt that anything is using these in code already; if so, this could be a breaking change.  I suppose @cspurk is the only person I know of that might be using this?
Checklist

[x] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

@dflemstr thank you for you work on this.
I have one question, my dimmer presents itself as "NHROTARY/UNIDIM/1" and it doesn't seem like these new changes apply to it. Could it be because it needs to be added to this file? https://github.com/zigpy/zha-device-handlers/blob/dev/zhaquirks/schneiderelectric/dimmers.py
If I understand it correctly, the signature/name of my dimmer is listed here:

@uvNikita You are right that extra changes are needed for your device to be supported. Another class should be created for your device, since it has a slightly different device signature.  I didn't add all the devices from the spec, I only adjusted the ones that already were in zha-device-handlers to the spec.

I added support for your device like this in zigbee2mqtt to give you an idea: https://github.com/Koenkk/zigbee-herdsman-converters/pull/7454
I'm not sure if I will have time to make the equivalent change here though since adding devices in zha-device-handlers is a lot more involved compared to zigbee2mqtt

Just wanted to add that ELKO devices is selling this devices under its name after it was acquired by schneider. I hope we can have this device included also


Update inference-with-keras.ipynb segmentation mask function

Improve segmentation mask rendering

Closing this PR due to lack of activity. This change is out of sync: recommend restarting update with synced notebook.


Add longst compendiums statistic to stats page

Depends on https://github.com/stianjensen/wikipendium.no/pull/251.

s/longst/longest

rebased

The commit message says longst instead of longest.

I think the sorting on the compendiums are the wrong way around:

ping

The commit message is now Add longst compendiums statistic to stats page but should be Add longest compendiums statistic to stats page.
If no user has edited a compendium in the last 24 hours we get this

With a link to /users/None. If someone's named that he might get a lot of credit he doesn't deserve ^^

ping


Image processor mixin

What does this PR do?
This is part of a series of PRs to introduce the ImageProcessor class for vision models.
Adds an alias for the FeatureProcessorMixin as ImageProcessorMixin. This mixin provides the saving/loading functionality for the processing classes.  Much of the logic will be exactly the same between the two, and so a more general class is needed for feature extractors and image processors. Otherwise we are likely to have confusing inheritance in the code e.g. class XxxImageProcessor(FeatureExtractorMixin.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Click to the download link waiting page laod

Hi,
I test a file download. It's work fine if I am using 'cypress open', but when I use 'cypress run', I have this error.
Can I prevent the page load ?

Hey,
Thanks for the issue. However, the issue is not related to the plugin. Read more about cypress here


adding cmu's course

Course summary is as follows
This course provides a place for students to practice the necessary mathematical background for further study in machine learning — particularly for taking 10-601 and 10-701. Topics covered include probability, linear algebra (inner product spaces, linear operators), multivariate differential calculus, optimization, and likelihood functions. The course assumes some background in each of the above but will review and give practice in each. Some coding will be required: the course will provide practice with translating the above mathematical concepts into concrete programs.

adding CMU's maths background course into the list

#7

@Neklaustares-tPtwP


GCE Jenkins Job

Jenkins job to run terraform code against Google Compute Engine.
See: https://trello.com/c/88BhiP5e

Can we wrap this into the main Deploy DNS job? I dislike it being called something generic, then specifically downloading the govuk-dns repo, I think that's confusing.

@surminus Conflated job yamls.  There are a few amendments to be made in the govuk-dns repo. See trello.

Are we aware of the fact that all the credentials exported in the Jenkins build script appear in clear text in the log file, available to anyone with access to Jenkins?

@afda16 anyone with access to Production Jenkins will be able to log on to the server and view the credentials file anyway. Our approach here is to limit access to the Jenkins job itself.

I think other than a few comments to address this looks OK

Oh, can we also make the job available in Integration and Staging for testing purposes?

@surminus Sure.  I noticed the govuk-test-dns-deploy service account.  Did you create this?  If so could you please add the secrets?

I think once govuk_jenkins::job::deploy_dns is moved to all environments than just production this will be fine to merge

@surminus Could you please elaborate?


Cannot fetch the data

What happened?
when we load the page, we expect to get the covid-19 stats. But it fails to load.

How can we reproduce this bug?
By changing the links
Desktop Information (Optional)
NONE
Urgency (Optional)
None

@whiteHatpro would like to work under JWOC.

fixed @whiteHatpro .


Use AbortController to abort fetches and more.

See discussion (thanks @andersk for pointing this out, and @gnprice for nudging me to look closer!).
With https://github.com/facebook/react-native/pull/24419, React Native (v0.60) gained a polyfill for the AbortController Web API; see the MDN doc.
The MDN doc leads with this:

The AbortController interface represents a controller object that allows you to abort one or more Web requests as and when desired.

But it's not constrained to only work with "Web requests"; Anders links to a Google developer doc that says this:

It's deliberately generic so it can be used by other web standards and JavaScript libraries.

This sounds like it's not an abomination to use it for more basic control-flow needs that have nothing to do with fetch or its friends. In particular, we can use this mechanism to break out of the while (true) loop in tryUntilSuccessful (soon to be renamed to tryFetch in, I think, https://github.com/zulip/zulip-mobile/pull/4166), when we want to abort. (In that PR, that particular need is answered with a local stateful boolean variable—it's nice to know there's a standard, well-documented way of doing it.)
And, of course, we'll actually be able to abort fetch requests.
Fingers are crossed that this React Native polyfill works; there's some history of RN-shipped polyfills being buggy.

I think the article linked from this tweet from Dan Abramov is probably worth reading, at least in part, if only just because it's Dan Abramov. I haven't read it yet. To quote the tweet:

I should probably clarify the technical aspect that I don’t earnestly believe Promises should be cancelable. It doesn’t work with the read-only design. If you’re interested in reasonable modern approaches to cancellation, this is a good read. https://vorpus.org/blog/timeouts-and-cancellation-for-humans/

Related: #3881

I've just filed #4659 for an implementation plan to expose easy methods for canceling fetches; after that work is done, we'll just have to call those methods in the right places. (tryFetch after #4193 may be such a place.)


Should we maintain keychain or not?

Hi guys!
I've opened this issue to discuss if we should remove keychain integration to store the Google Photos token, and store it in LevelDB instead.
Historically gphotos-uploader-cli used gnome-keyring to store this token in an efficient and secure way. @nmrshll decided to do it this way (I'm guessing) because he handn't any other DB available. But now we can use the LevelDB database (needed for tracking uploaded items) to store the token.
PROS:

Easy to implement, we can remove github.com/99designs/keyring dependency.
Seamless usage. Users don't need any keyring (kwallet, gnome-keyring).
Headless / Docker friendly. It make easier to be used in a docker.

CONS:

Less secure, the token will not be encrypted on LevelDB.

What do you think? Should we remove keychain integration?

If having 99designs/keyring as a dependency doesn't cause any problems I think we should keep it because it provides multiple secure credential stores and LevelDB is less secure. I wouldn't make that trade.
I guess the only issue here is that none of the current credential stores are headless friendly, but maybe we could add an option to work around it? Here's what I propose:
With SecretsBackendType set to auto (the default) this will actually pick file for headless systems (like Docker). The only problem with this store is that it keeps prompting the user for a password (not headless friendly):
https://github.com/nmrshll/gphotos-uploader-cli/blob/7850870eae1178a013811be4f5c82e27e50bf281/datastore/tokenstore/repository_keyring.go#L56
https://github.com/nmrshll/gphotos-uploader-cli/blob/7850870eae1178a013811be4f5c82e27e50bf281/datastore/tokenstore/repository_keyring.go#L114-L122
But I worked around this on my Docker image with this simple change: https://github.com/rfgamaral/gphotos-uploader-cli/commit/0158c317f7d07098027408bcd9183f619216438f
Maybe we could add some kind of option to gphotos-uploader-cli to disable the password function prompt (like I did above) for SecretsBackendType: file (or when auto picks file)?

@rfgamaral but in this case your are not suppliying any password to encrypt file. So the file is plain-text (like LevelDB approach). Wouldn't it be the same if you provide this password as a parameter to gphotos-upload-cli?
I mean adding a new configuration field SecretsBackendKey that could be used in case of file is selected as backend. WDYT?

@rfgamaral but in this case your are not suppliying any password to encrypt file.

I'm actually supplying an empty password (i.e., ""), if that encrypts file or not, I'm not sure.

I mean adding a new configuration field SecretsBackendKey that could be used in case of file is selected as backend. WDYT?

You could do that, yes, but what would be the point really? I mean, the password is there, in the configuration file, as plain text, visible to anyone. That or an hard-coded password (empty string or something else) is practically the same thing in terms of security.
It doesn't really matter how we supply the password to the prompt function, if we don't prompt the user to type the password every time, we are making it less secure by design.
But let me make you a different question...
For headless systems, like Docker, is it really that import to encrypt the authorization token?  Anyone with physical access to your browser will be able to get your token, it's right there. There's not much difference when using this in a headless server or a Docker container IMO.

I found testing for keystore at runtime to be pretty easy -- imo i would test for the keystore by platform ( linux = gnome keyring, apple = keychain, windows = ??), and then fallback to leveldb by default (since leveldb is a build dep).
If you like the approach i can code it up, i did something similar for another PR

I'm still a bit concerned about storing the oAuth access token in plain text. Once you have this token you can do all the actions you like until it is expired. If we keep refresh token in the same way, we should do it, this mean that the time that a third person could use it is bigger. So I'm not sure about keeping the token in plain text.
It's not the safest approach, but in order to discourage this I would like to add a parameter to supply the encryption key for file backend. Then in headless / docker you can supply this key in runtime. If someone steal the image, this would have the token in an encrypted form.
Obviously, if someone have access to the running docker, he/she can get the encryption key. But IMO this is better than storing the token in plain...
@tonymet @rfgamaral What do you think?

I might be wrong but in this particular case - in general, nothing sensitive as an access token should be stored as plaintext - I honestly don't think it makes a whole lot of difference.
It doesn't matter if the token is plain text or encrypted. If someone has access to your Docker container (not image), they also have access to the encryption key and can decrypt the access token. I can't see a way for you to supply the encryption key without user interaction, and that's the important bit for a true headless implementation. In the end, you're just making it slightly harder for someone to have access to the access token, which is pointless against someone determined to get it.
And if someone has access to the Docker container, you have much bigger problems than worrying about an access token to your Google Photos.

I still think that what I said above is somewhat important and relevant but I just thought of something else when I finished writing that post.

Then in headless / docker you can supply this key in runtime.

Supplying the encryption key in run time is kinda pointless IMO (reasons on post above). But what we could do is supply the encryption key in build time, hidden from everyone. How could we do this? One possible solution:

Change terminalPrompt to read a specific environment variable, the encryption key (make it random, long, and hard to guess).
Add that environment variable to the CI build server.
Only the CI build server (and people with access) would know how to decrypt the access token.

As for my Docker image - since I have build my own binaries anyway - I'd just have to supply my own encryption key to that environment variable. Only I, my Docker build server (and people with access) would know how to decrypt the access token.
This would put the trust of the access token on the users compiling the binaries instead of the users simply running the binaries. If you put the trust on the users running the binaries you'd have the same problem as mentioned above, access to encrypted file would probably mean access to the machine, thus bigger problems, thus encrypted or plain text would be irrelevant.
What do you think?

@pacoorozco I just made this change for my Docker image: https://github.com/rfgamaral/gphotos-uploader-cli/commit/4dd58168547b05b2dea5d59c09c652c74749903b

I like this approach @rfgamaral ! What do you think if I add a --headless flag? If it's set the SecretsBackendType is set to file and the terminalPrompt is set to your implementation.
I think this approach has the best of the two worlds :-D How do it sounds to you?

@pacoorozco How exactly would that flag be used? In run time or build time? Can you provide an example?

I was thinking to use the flag on run time.
$ KEYRING_ENCRYPTION_KEY=verySecretKey; ghotos-uploader-cli --headless

or, in your case:
$ docker run -r KEYRING_ENCRYPTION_KEY=verySecretKey gphotos-docker

Note: This not solve that users on host/docker would be able to see this encryption time, as far as they can access it, but it will be the only ones affected. In case you use a proper docker service you can encrypt this var using secrets.
So in unsafe environments, you are probably going to use it.

Personally I'm not really fond of that... You're forcing the users to always pass those extra options to the CLI, making everything more complex and harder to mantain. IMO, we should explorer other options.
P.S.: I wanted to write a few more things (I have a different suggestion but it would be at build time) but I'm on my phone and don't have much time now.

The idea of an headless mode is to fully automate the process and if you do it that way, you'll have the encryption key as plain text somewhere (for instance a cron job - not everyone uses Docker).

Yes, you're right, but I think this approach is safer than using a fixed key or define it in build time, not everybode knows/wants to build the CLI.
So, using this CLI in headless mode is NOT safe, but If someone wants to use it, he/she can do it.

Yes, you're right, but I think this approach is safer than using a fixed key or define it in build time(...)

At build time, only a limited number of people will know the key. At run time, you have no way to control that. If you want to use this tool for automated uploads, the key will be in plain text. If you don't automate but run the command like that in the shell, the key will be stored in the shell history. This is not safer than using a fixed key that practically almost no one knows.

(...)not everybode knows/wants to build the CLI.

No, they don't, but they don't need to if you bake this into the official binaries with a key that only the build server knows about it (and of course, people with access, which should be very limited anyways).

So, using this CLI in headless mode is NOT safe, but If someone wants to use it, he/she can do it.

So what's the point really? Why make the tool more complex and more confusing to use for no good reason!?

The goal should be to make a simple tool for everyone to use easily without worrying to much about it, but the way I see it, you're doing the opposite. I'm starting to realize we don't see eye to eye. I'm sorry, but I really don't think this is the right direction and I'm going to redirect my efforts in providing a good user experience for my Docker image users based on my fork of gphotos-uploader-cli.

I can't agree:

At build time, only a limited number of people will know the key.

People are not intended to build its own CLI. They want to install it using snap, brew or binaries. So doing it in build time it doesn't seem an option.

At run time, you have no way to control that. If you want to use this tool for automated uploads, the key will be in plain text. If you don't automate but run the command like that in the shell, the key will be stored in the shell history. This is not safer than using a fixed key that practically almost no one knows.

You should run it in a safe environment. I don't recommend to run this (with --headless flag) in a shared computer. So, you are limiting the circle of trust to the people that has root access to the host running the CLI. Otherwise, they are not able to see your process parameters or environment variables.
There are ways to avoid the the key goes to shell history (e.g. supplying it inside the config file). The same approach is followed by mysql docker. IMO if this shell history is only accessible by me, I don't care about it, because I'm delegating security to the fact that they need to access to my account.

No, they don't, but they don't need to if you bake this into the official binaries with a key that only the build server knows about it (and of course, people with access, which should be very limited anyways).

I'd know the key of everyone. I don't want to have this responsibility. This is open source, so all code should be open... I'm sorry, but I don't think that people are going to be fine if we encrypt a file that they doesn't know how to decrypt. Let's imagine that the key was leaked, how can we replace all of them?
It's better that we delegate this to the users. Users cn supply its own key, they are responsible of ensuring it is not leaked.

The goal should be to make a simple tool for everyone to use easily without worrying to much about it, but the way I see it, you're doing the opposite.

Headless is one of the use cases that we are trying to cover. And we've been working to bring gphotos-uploader-cli closer to headless use case (see #71 and this thread). When you are familiar with docker, you are used to put environment varaibles with your secrets (or mounting it as volumes) like everybody is doing with mysql docker or postgres docker.
There is another approach that we've not tested. Using secrets seems you can share sensitive data without exposing it. But this is under docker development scope (aka you :-D)

The thing you are failing to understand is that everything you proposed is completely pointless and doesn't provide any security at all.
The current implementation prompts the user for a password every time it needs one to encrypt/decrypt the token. This is the safest you can get and you're placing the responsibility entirely in the user. If you don't want to have any responsibility at all, you might as well close this issue and don't change anything.
Everything else you proposed stores the encryption key in plain text, in one way or another and that is something that goes against something you initially said:

I'm still a bit concerned about storing the oAuth access token in plain text.

Now, the point of this issue was to make this tool more headless friendly and the point of an headless mode is automation. If you implement something that requires you to pass the encryption key as a parameter, you'll be storing the encryption key as plain text somewhere. This doesn't solve anything.

There is another approach that we've not tested. Using secrets seems you can share sensitive data without exposing it. But this is under docker development scope (aka you :-D)

That only works with Docker swarms, it's not an option for my Docker image.

Honestly, I think this discussion is becoming longer than it needs to be and you're creating a problem that doesn't exist. IMO you are too worried about security when there's nothing to worry about, which is something I've tried to explain from the very beginning.
People are most likely using gphotos-uploader-cli to upload their personal photos to Google Photos from their own personal computers or their own NAS. These are most likely local machines, stored on people's homes. The only way for the token to be leaked/compromised is if people are hacked or someone gains physical access to their machines. Otherwise your token is safe, encrypted or not.
If you are hacked or if someone that shouldn't has physical access to your machine, you have much bigger problems to worry about than an access token being leaked, especially when that token only has access to the Google Photos API.
In other words, if someone is able to access my Docker container and read the access token, they can also access my browser and read all my cookies (thus accessing all the access tokens for my logged in accounts). What do I think I should be more worried about? The tokens or that someone that shouldn't gained access to my computer?

One last thing, I'm going to revert https://github.com/rfgamaral/gphotos-uploader-cli/commit/4dd58168547b05b2dea5d59c09c652c74749903b. It was a pointless change because the value of the environment variable was never stored in the compiled binary and the default was an empty string (basically the same thing that was before).
In a way, I could add instructions to my users to set that environment variable to the Docker container and let them encrypt the access token with their own encryption key, placing the responsibility completely on them, just like you wanted. However, it's pointless, because the encryption key will still be stored in plain text right there on the host machine, it doesn't provide any security at all.
The way I see it, we still haven't found the best solution for this problem. Well, kinda, cause I don't really think this is a problem at all ¯_(ツ)_/¯

Please leave gnome-keyring as an option to store the token.
PS: by the way, thanks to all contributors here!

Rclone for example stores the token in plain text, just set the file permissions on that file to prevent other users to read it.
If a system has been compromised it means that the attacker has root access, and if so a password entered by the user, which can be sniffed, is not much safer than file permissions.


Interest in taking over project

Hi there!
It seems you've moved on from this project (which is completely understandable), and allowed the domain to expire. However, the tool you've created is very useful to many people, myself included. Because I'm uniquely interested in development of GroupMe-related open source software (see my projects such as MeBots, Yalebot, and countless other bots I've developed for GitHub), I believe I would be uniquely qualified to maintain this project, find it a new domain, and keep it running into the future.
Let me know if you have any questions and if you're willing to consider my offer. @psweeney101

Hi Erik, SearchMe was down for a few days while I transferred the domain. It's back up and running at https://thesearchmeapp.herokuapp.com/ now and I intend on continuing to maintain it moving forward. Thank you for the offer.


Steven/upgrade form

included checkboxes in the form to indicate which days you want repeating appointments (default weekly repeating)
upgraded databases to include weekday parameters necessary
note: requires a rake db:migrate

lgtm


Is this random enough? If not, safe to use having it check for duplicates in a loop?

https://github.com/ArekkuusuJerii/Poller/blob/91fef672a036f128580d88aef04cf36dd692bafa/database/poller_sqlserver.sql#L174-L204

Yes it is


Update for julia 1.0

Drops travis 0.5 tests, adds tests for 0.7 and 1.0

Dup of https://github.com/JuliaIO/MAT.jl/pull/86. Please help with the extra copying issue in that PR instead.


Update to 0.3.0 failed

System: Atom 1.0.6, OSX 10.10.4
npm ERR! Darwin 14.4.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/klay6683/.atom/.apm/.apmrc" "--userconfig" "/Users/klay6683/.atom/.apmrc" "install" "/private/var/folders/tt/k11390b92vl_dygt4m0s7gjr008bbb/T/d-115712-90062-a03xu3/package.tgz" "--target=0.22.0" "--arch=x64"
npm ERR! node v0.10.35
npm ERR! npm  v2.5.1
npm ERR! file /Users/klay6683/.atom/.apm/atom-space-pen-views/2.1.0/package/package.json
npm ERR! code EJSONPARSE

npm ERR! Failed to parse json
npm ERR! Unexpected end of input
npm ERR! File: /Users/klay6683/.atom/.apm/atom-space-pen-views/2.1.0/package/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse

npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/tt/k11390b92vl_dygt4m0s7gjr008bbb/T/apm-install-dir-115712-90062-bfktdn/npm-debug.log

This seems to occur in atom-space-pen-views's package.json outside the atom-tab-numbers package. The file most likely got corrupted during download. Look at atom-space-pen-views and try reinstalling the corrupted dependency.

I managed to install the update now.


Visual Studio Code cache directory added

Reasons for making this change:
Visual Studio Code can be used instead of Visual Studio for Unity development. This change adds the VSC cache folder to be ignored, same as it was already done for Visual Studio.

@gerardreches thanks for the contribution, but we have an existing template for Global/VisualStudioCode.gitignore which we consider to be handled differently to .vs/.


Support cluster scoped resources broadly

As a follow on to https://github.com/cloud-bulldozer/kube-burner/pull/338, delete and patch jobs assume that the object is namespaced.
The RFE https://github.com/cloud-bulldozer/kube-burner/issues/340 suggests using the Rest Mapper to deterine the scope.
Changes:

added a isNamespaced helper to determine if the GVR is namespaced or and cache schema
updated patch.go and delete.go to check if an object is namespaced and use the appopriate
method.

Fixes https://github.com/cloud-bulldozer/kube-burner/issues/340

Thanks for the update!, I'm missing to add the isNamespaced conditional to create.go so we can take advantage of this function and remove some unnecessary logic.

Good catch. I've reputed an update with this fixed up.

Also, once we remove all references to obj.Namespaced, can you remove the references to field from the documentation?

Done

Hey @darkmuggle, we recently merged some heavy changes on the CI, can you rebase the PR please?

I think we can add a namespaced field the the obj struct and use it, rather than perform a call to isNamespaced whenever we need to check if an object is namespace

Rather than add a namespaces field, the last push evaluates whether the GVK is namespaced or root scoped and sets Namespaced to false if root scoped. Namespaced comes with the embedded struct for free. Having both a namespaced and Namespaced seemed redundant.
The thing I don't like about this approach is that a user could create an object definition that is namespaced with a cluster GVK and erroring on it would be more correct; however the assumption is that objects are namespaced by default so it didn't seem bad.

I like the new approach :), it determines if an object is namespaced in the setup stage of each type of job, nice, that won't alter the workload's outcome.
I just sent you a suggestion to fix the current issues. (you can see them in the test outputs).


Add points with disabled expand-animation

What does this PR do?
This PR brings "points" back, with disabled active-state animations, so that single disconnected data points are visible for time-series charts.

Defaults look good, 🚢 away


aws-saml cannot load readline

I get the following error when i run..
Traceback (most recent call last):
  File "/Users/zaro0508/.virtualenvs/test5/bin/aws-saml", line 8, in <module>
    sys.exit(main())
  File "/Users/zaro0508/.virtualenvs/test5/lib/python3.6/site-packages/awscli_saml/main.py", line 32, in main
    import awscli_saml.assume_role as assume_role
  File "/Users/zaro0508/.virtualenvs/test5/lib/python3.6/site-packages/awscli_saml/assume_role.py", line 7, in <module>
    import readline  # needed for terminal raw mode (> 4096 characters)
ImportError: dlopen(/Users/zaro0508/.virtualenvs/test5/lib/python3.6/readline.so, 2): Library not loaded: /usr/local/opt/readline/lib/libreadline.7.dylib
  Referenced from: /Users/zaro0508/.virtualenvs/test5/lib/python3.6/readline.so
  Reason: image not found

My environment:
➜  pip freeze
awscli-saml==1.1.1
boto3==1.13.6
botocore==1.16.6
docutils==0.15.2
jmespath==0.9.5
python-dateutil==2.8.1
s3transfer==0.3.3
six==1.14.0
urllib3==1.25.9

➜ brew info readline
readline: stable 8.0.4 (bottled) [keg-only]
Library for command-line editing
https://tiswww.case.edu/php/chet/readline/rltop.html
/usr/local/Cellar/readline/8.0.1 (48 files, 1.5MB)
  Poured from bottle on 2019-11-13 at 11:18:27
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/readline.rb

I don't have ver 7 on my machine.  The latest version of readline is ver 8.0.1 and and there doesn't seem to be a brew formula for ver 7 to install.  Maybe the dependency needs to be updated?   Do you know of a workaround?

Not the preferred solution but a workaround that seemed to work for me is to copy the ver 8 lib and name it ver 7.
cp /usr/local/opt/readline/lib/libreadline.8.0.dylib /usr/local/opt/readline/lib/libreadline.7.dylib

ls -l /usr/local/opt/readline/lib/
total 1920
-r--r--r--  1 zaro0508  staff   40396 Nov 13 11:18 libhistory.8.0.dylib
lrwxr-xr-x  1 zaro0508  staff      20 Dec 19  2018 libhistory.8.dylib -> libhistory.8.0.dylib
-r--r--r--  1 zaro0508  staff   46008 Dec 19  2018 libhistory.a
lrwxr-xr-x  1 zaro0508  staff      20 Dec 19  2018 libhistory.dylib -> libhistory.8.0.dylib
-rw-r--r--  1 zaro0508  staff  239220 May  9 08:06 libreadline.7.dylib
-rw-r--r--  1 zaro0508  staff  239220 Nov 13 11:18 libreadline.8.0.dylib
lrwxr-xr-x  1 zaro0508  staff      21 Dec 19  2018 libreadline.8.dylib -> libreadline.8.0.dylib
-r--r--r--  1 zaro0508  staff  406912 Dec 19  2018 libreadline.a
lrwxr-xr-x  1 zaro0508  staff      21 Dec 19  2018 libreadline.dylib -> libreadline.8.0.dylib
drwxr-xr-x  3 zaro0508  staff      96 Nov 13 11:18 pkgconfig

Unfortunately I do not have a Mac and so cannot test this. (I do know that the docker version works on Mac.)
You might try commenting out the import altogether. https://github.com/rivethealth/aws-cli-saml/blob/1a00dc783def25cfa91a301df726bd8c69862e15/awscli_saml/assume_role.py#L7
It was needed for input to support more than 4KB.

With 2.0.0, if you provide the SAML response as a env variable or command line parameter, readline is no longer loaded.

thanks @pauldraper.  I've verified that this issue was happening when using python ver 3.6.3.  I used pyenv to install python ver 3.6.9 and it no longer occurs.  I also verified that this error does not happen when using python 3.7.3 and 3.8.0.


groups: admin channel management is broken

Be a group admin
Go to Members & Group Info
Go to Channels
Attempt to create sections and order channels
Attempt to set channels to default
Observe that channels move around randomly while trying to order them, don't move between sections easily, setting a channel as default doesn't always stick, if you have a lot of channels it's hard to organize between sections.

This UI is extremely frustrating to use.

More stuff:

If you rename a section and don't make a change it wipes the old name (even if you don't click enter)
Setting default channels works 5% of the time?

@urcades To consider for redesign.

Fixing in #1770

@patosullivan See what your index mismatch fix addresses from this issue.


Add toggleable trajectories to RViz plugin

Alternative to #422.

Mhh, I cannot push to the original branch since this was not a PR by @ojura. Closing this and opening #456 with a branch from my fork instead.


[mesheryctl] system login fails for users with pre-authenticated sessions

mesheryctl system login with provider choice of Meshery results in login failure, <@U02JTMLASF4>, for users that already have an established session.
Slack Message

No further context needed here, right, @theBeginner86?


[release-1.13] unify timeout logic across service and virtual service

Manual backport of https://github.com/istio/istio/pull/40320

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio_release-1.13
e204b146cae5c895dd06eb25a2a8a41e4de0e272
link
true
/test integ-security_istio_release-1.13

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security_istio_release-1.13


add the publishing to gpr and release pipeline

create release per tag created in the main branch.
we can depend on openfeature sdk in the provider (on any branch/commit as following using jitpack) after merging this :

api("com.github.spotify:openfeature-kotlin-sdk:[BRANCH_NAME]-SNAPSHOT") // or commit hash

or on a release
api("com.github.spotify:openfeature-kotlin-sdk")

@fabriziodemaria true. btw, it's important to not mistake jitpack with the create release step. releases of the github is a different thing than jitpack. jitpack is just a tool that lets us depend on a jvm/android lib in github. basically they do all the local checkout and localMaven stuff internally.


Consider depending on a stable release of express dependency

As discussed in #112, we currently depend on an alpha release of express, which is probably not ideal. We should determine what (if any) breaking changes this alpha release has introduced, and whether we're depending on those. If not, we should probably depend on the latest stable release (4.x) instead.

Express is used for the web api which we don't use internally (except for development). I think that's why it was so permissive. However, we don't know how others are using this tools, so makes sense to me to use a fixed non-alpha release.

A beta just came out yesterday. Central uses 4.16.

Addressed by https://github.com/enketo/enketo-transformer/commit/6b0e4c3ad30ed2f814ac900fbfa6c2b973822070