push.ha doesn't correctly count current failures if there is a previous failure

We have a 7 node store configured with push.ha.max.node.failure=1. Node 6 was failing for a while but fetch and swap was still working thanks to the push.ha configuration. But just as we got node 6 back we lost node 2. Still the fetch for the other 6 nodes was successful, but apparently HandleFetchFailureResponse doesn't count the number of failed nodes correctly:
2017-03-10 09:15:08,708 ERROR [pool-9-thread-1] voldemort.store.readonly.swapper.AdminStoreSwapper|tcp://redacted-node0.net:6666: tcp://redacted-node0.net:6666 : Error on Node redacted-node2.net:6666 [id 2] during push :
java.util.concurrent.ExecutionException: voldemort.store.UnreachableStoreException: Failure while checking out socket for redacted-node2.net:6666(vp1):
[...]
2017-03-10 09:15:08,710 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.AdminStoreSwapper|tcp://redacted-node0.net:6666: tcp://redacted-node0.net:6666 : About to attempt: DisableStoreOnFailedNodeFailedFetchStrategy
2017-03-10 09:15:10,164 ERROR [pool-9-thread-1] voldemort.client.protocol.admin.AdminClient: Node iad1b-sn0003.iad.audsci.net:6666 [id 4] returned failed HandleFetchFailureResponse: We cannot use pushHighAvailability because it would bring the total number of nodes with disabled stores to more than 1...
2017-03-10 09:15:10,164 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.AdminStoreSwapper|tcp://redacted-node0.net:6666: tcp://redacted-node0.net:6666 : Finished executing: DisableStoreOnFailedNodeFailedFetchStrategy; swapIsPossible: false
2017-03-10 09:15:10,164 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.AdminStoreSwapper|tcp://redacted-node0.net:6666: tcp://redacted-node0.net:6666 : About to attempt: DeleteAllFailedFetchStrategy
2017-03-10 09:15:10,165 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.DeleteAllFailedFetchStrategy: Deleting fetched data from node Node redacted-node0.net:6666 [id 0] in zone 0 partitionList:[0, 7, 14, 21, 28, 35, 42, 49, 56, 63, 70, 77, 84, 91, 98, 105, 112, 119, 126, 133, 140, 147, 154, 161, 168
2017-03-10 09:15:12,549 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.DeleteAllFailedFetchStrategy: Deleting fetched data from node Node redacted-node1.net:6666 [id 1] in zone 0 partitionList:[1, 8, 15, 22, 29, 36, 43, 50, 57, 64, 71, 78, 85, 92, 99, 106, 113, 120, 127, 134, 141, 148, 155, 162, 169
2017-03-10 09:15:14,304 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.DeleteAllFailedFetchStrategy: Deleting fetched data from node Node redacted-node3.net:6666 [id 3] in zone 0 partitionList:[3, 10, 17, 24, 31, 38, 45, 52, 59, 66, 73, 80, 87, 94, 101, 108, 115, 122, 129, 136, 143, 150, 157, 164, 1
2017-03-10 09:15:16,107 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.DeleteAllFailedFetchStrategy: Deleting fetched data from node Node redacted-node4.net:6666 [id 4] in zone 0 partitionList:[4, 11, 18, 25, 32, 39, 46, 53, 60, 67, 74, 81, 88, 95, 102, 109, 116, 123, 130, 137, 144, 151, 158, 165, 1
2017-03-10 09:15:18,394 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.DeleteAllFailedFetchStrategy: Deleting fetched data from node Node redacted-node5.net:6666 [id 5] in zone 0 partitionList:[5, 12, 19, 26, 33, 40, 47, 54, 61, 68, 75, 82, 89, 96, 103, 110, 117, 124, 131, 138, 145, 152, 159, 166, 1
2017-03-10 09:15:20,627 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.DeleteAllFailedFetchStrategy: Deleting fetched data from node Node redacted-node6.net:6666 [id 6] in zone 0 partitionList:[6, 13, 20, 27, 34, 41, 48, 55, 62, 69, 76, 83, 90, 97, 104, 111, 118, 125, 132, 139, 146, 153, 160, 167, 1
2017-03-10 09:15:27,276 INFO [pool-9-thread-1] voldemort.store.readonly.swapper.AdminStoreSwapper|tcp://redacted-node0.net:6666: tcp://redacted-node0.net:6666 : Finished executing: DeleteAllFailedFetchStrategy; swapIsPossible: false
2017-03-10 09:15:27,277 ERROR [pool-9-thread-1] shell-job: Exception during push for cluster URL: tcp://redacted-node0.net:6666. Rethrowing exception.

I suspect the problem is due to the fact that this was the first time node 6 was back. This might be an edge case which isn't sufficiently tested.

Hi @bitti,
First of all, let me tell you a bit of background about BnP HA. We have been using BnP HA in production for about a year now, with several tweaks and fixes along the way. It "works" for us, but it has a lot of rough edges, and many known limitations.
It's great that you're trying it out, and hopefully that can pave the path forward to making it better outside of LinkedIn.
This is the crux of the situation:

2017-03-10 09:15:10,164 ERROR [pool-9-thread-1] voldemort.client.protocol.admin.AdminClient: Node iad1b-sn0003.iad.audsci.net:6666 [id 4] returned failed HandleFetchFailureResponse: We cannot use pushHighAvailability because it would bring the total number of nodes with disabled stores to more than 1...

This means the HA code thinks there is another node which is down, so it will not allow this one to go into "HA mode" as well. The way the HA code keeps track of that is via a HdfsFailedFetchLock implementation. The only such implementation available at this time is: HdfsFailedFetchLock, which can be configured via the push.ha.lock.implementation server config. With this implementation, the server code will store the state of the cluster in HDFS (which is not such a great place to store this, but it is the decision that was made in order to avoid pulling in ZK as a new dependency or some other homegrown solution). This state is stored in the path determined by the push.ha.lock.path server config. If you have left over directories there (from a previous invocation of BnP HA), then it can trip up future invocations. At this time, this state needs to be cleaned up manually during the recovery process.
Hope that helps.
I'm sure you'll have more questions. Feel free to keep them coming. I've got to run for now...
-F

Sure that helps! We still have the node-6 ha-lock files lying around on hdfs, so that's probably the issue. I try to make sure that we clean them up after each push. Or is there any worth to keep/archive them for debugging purposes?
Btw. is this documented somewhere? Or can we add documentation for this and some other push.ha aspects?

We have internal documentation which has been in flux. Now that the feature has somewhat stabilized, it would be good to have some public doc as well which would be more suited to the open-source. Alas, we don't have that yet, though I guess the original commit message for the feature could serve as a starting point: https://github.com/voldemort/voldemort/commit/c2db8fd9b0afe714f6f88908c769b66485d28825
Regarding your question at hand: the node-6 directory must be deleted after the node is properly recovered (which is a whole other can of worms, since it's not currently automated). The after-lock-release directory can be kept around for traceability, or can be cleared out periodically/systematically (it does not have any impact on the BnP HA behavior).

Yes I also started from that commit message. The thing is that this message seems currently be the only documentation available outside of linkedIn.
Do you really have to do manual cleanups after a server fix? Why not just simply cleaning up the corresponding lock directory before attempting a push? What do you do for transient errors, e.g. network problems, when no manual fix was necessary to get the "node properly recovered"?

Hi @bitti,
Typically, when restoring a node, you would need to copy data onto the new healthy node. In some types of failure scenarios, you can copy it from the bad node, which is somewhat easy (glossing over some details here). If, however, the down node is completely unrecoverable, then you need to restore the data from peer nodes, which are partitioned differently. This is something we do here but is more of a headache.
Besides the above, there may also be concerns around data consistency. For example, if you resurrect a node back to a healthy state which contains some old data, this means that a fraction of the queries will be served by stale data. Again, this is something we take care of here at LinkedIn with a carefully executed runbook and some tooling, but I'm afraid the situation is not as robust in open-source.
We ought to release the runbook and the missing pieces of this story...
-F

Thanks for the information and I'm looking forward to the runbook and any documentation you could provide for the community.
You didn't answer though what you do for transient problems, i.e. when no manual intervention is required. I'm thinking about just automatically cleaning up all {push.ha.lock.path}/{push.ha.cluster.id}/node-*/{push.store.name} directories before pushing a specific store, to ensure that stale lockfiles won't let recovered nodes get basically "blacklisted".
But it wonder if this would be the right way to go about it? I surely can't clean up just {push.ha.lock.path}/{push.ha.cluster.id} because there might be pushes of other stores in progress in parallel.

Yeah, so for transient node issues, the concern is again about data consistency. If you're ok with serving partially stale data coming from a previous push, then you can simply bring that node back online as is, delete the HDFS shared state directory, and let BnP refresh the cluster wide data on its next push.

So to be clear: a failed fetch during a successful push.ha will always set the node with the stale data in OFFLINE_SERVER state? And to bring this node back to NORMAL_SERVER it has to be restarted? Or is there some admin command for that? Or is it enough to clean the stale lockfiles?
But I don't understand why this should imply stale data. I'm ok with a server getting into OFFLINE_SERVER mode after a failed run. But if we get a successful fetch in a later push I of course would like to have it automatically back. If I understand your comment in c2db8fd correctly a push should even work in OFFLINE_SERVER mode when we use the admin port for pushing.

It seems it's not enough to clean up the ha lock files, but the server needs to be manually set back into NORMAL state by issuing a vadmin.sh meta set offline=false -u tcp://some.node:6667, or do I misunderstand something? Currently we are using server Version 1.10.14.

You are correct,
You also need to have a way of successfully restoring the data on the node that was down. That can be done with a new BnP job run, if you're willing to accept serving stale data in the mean time. Or it requires copying files from peer nodes, for which there isn't a very good solution available in the open-source at this time.
-F

I see. So a node in OFFLINE_SERVER will never fetch updated data? Shouldn't it be possible to enable the readonly.fetch.enabled flag even in offline mode to get a complete BnP run? It makes sense to block an offline server from delivering data when one wants to prevent serving outdated data, but why are updates are also prevented? (Note that we use the Admin port 6667 for pushes)

Hi,
That is what we'd like to explore. The original intent was to flip that flag and allow pushes to go into an offline node, but we have not tested this strategy so far, so it may have rough edges.
Exciting stuff ;) !
-F

I see. I might try it out when I encounter the problem next time. (Even though stale data isn't really a big problem for us.) On the other hand our nodes are running more stable now so it might take a while till I get the chance.
In the meantime I would love to close this ticket if you could push some documentation of the current behaviour? (Otherwise I could try to do it, but it surely wouldn't be as good as yours...)


test test

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38 seconds
load time: 661 seconds
storage size:<PHONE_NUMBER>1 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221219124028_clickbench_pr_65159.html


Move GRPC and SNMP into otel format

Closes #693 #692
Adds in grpc support for otel, also snmp values.
Note: currently does not support logs and traps into otel. Maybe send these over as traces?
Uses the WithEndpointURL conn for grpc, this was an easy way to get http/https values working. Is there a need to support loading TLS stuff?
Tested with
Ktrans flags:
-format otel -otel.protocol grpc -otel.endpoint http://localhost:4317/

otel-contrib:
receivers:
  otlp:
    protocols:
      grpc:
        endpoint: <IP_ADDRESS>:4317

Also moves all the otel values to gauges, as this more closes matches the values ktrans polls for.

Note: currently does not support logs and traps into otel. Maybe send these over as traces?

Not as pressing but I think at some point it could be cool for ktranslate to accept webhooks from our alerting engine and convert them into events into otel format. Have not heard anyone asking for that. Just a thought/comment on my part.

Uses the WithEndpointURL conn for grpc, this was an easy way to get http/https values working. Is there a need to support loading TLS stuff?

I'm always a fan of doing this in the secure way if possible. However, I have not heard customers/partners asking for this so it would highly depend on the level of effort to do it.

@i3149 confirmed this is working as expected, TLS support would be greatly appreciated but not a deal breaker at the moment.


pscompletions: Add version 3.2.6

Closes #12921

[x] I have read the Contributing Guide.

The project looks quite new, it doesn't fit criteria for Extras bucket in terms

Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)

The manifest has a lot of mistakes, it won't be ready for the extras bucket.

The manifest needs to be changed to this:

Improved Manifest
{
    "version": "5.0.5",
    "description": "A completion manager for better and simpler use powershell completions.",
    "homepage": "https://github.com/abgox/PSCompletions",
    "license": "MIT",
    "notes": [
        "Use the module by running:",
        "Import-Module PSCompletions",
        "Add it to your $PROFILE to make it permanent"
    ],
    "url": "https://psg-prod-eastus.azureedge.net/packages/pscompletions.5.0.5.nupkg",
    "hash": "37d1f8f6b5abb2026c6d0af70302658bb8f1484521eb68d769d91a901a6a8d72",
    "pre_install": [
        "Remove-Item \"$dir\\_rels\", \"$dir\\package\", \"$dir\\*Content*.xml\" -Recurse",
        "if (!(Test-Path \"$persist_dir\\data.json\")) { Copy-Item \"$bucketsdir\\Extras\\scripts\\pscompletions\\data.json_\" \"$persist_dir\\data.json\" }"
    ],
    "psmodule": {
        "name": "PSCompletions"
    },
    "persist": [
        "completions",
        "data.json"
    ],
    "checkver": {
        "url": "https://www.powershellgallery.com/packages/PSCompletions",
        "regex": "\\<h2\\>([\\d.]+)\\</h2\\>"
    },
    "autoupdate": {
        "url": "https://psg-prod-eastus.azureedge.net/packages/pscompletions.$version.nupkg"
    }
}

And this file needs to be included in the scripts/pscompletions directory of the Extras bucket.

data.json_
{
    "list": [],
    "alias": {},
    "aliasMap": {},
    "config": {
        "url": "",
        "enable_completions_update": 1,
        "enable_module_update": 0,
        "disable_cache": 0,
        "function_name": "PSCompletions",
        "SpaceTab": "😄",
        "WriteSpaceTab": "😎",
        "OptionTab": "🤔",
        "horizontal": "═",
        "vertical": "║",
        "top_left": "╔",
        "bottom_left": "╚",
        "top_right": "╗",
        "bottom_right": "╝",
        "item_text": "Blue",
        "item_back": "Black",
        "selected_text": "white",
        "selected_back": "DarkGray",
        "filter_text": "Yellow",
        "filter_back": "Black",
        "border_text": "DarkGray",
        "border_back": "Black",
        "status_text": "Blue",
        "status_back": "Black",
        "tip_text": "Cyan",
        "tip_back": "Black",
        "trigger_key": "Tab",
        "between_item_and_symbol": " ",
        "status_symbol": "/",
        "filter_symbol": "[]",
        "enable_menu": 1,
        "enable_menu_enhance": 1,
        "enable_tip": 1,
        "enable_tip_when_enhance": 1,
        "enable_completions_sort": 1,
        "enable_tip_follow_cursor": 1,
        "enable_list_follow_cursor": 1,
        "enable_tip_cover_buffer": 1,
        "enable_list_cover_buffer": 0,
        "enable_list_loop": 1,
        "enable_selection_with_margin": 1,
        "enable_enter_when_single": 0,
        "enable_prefix_match_in_filter": 0,
        "list_min_width": 10,
        "list_max_count_when_above": -1,
        "list_max_count_when_below": -1,
        "width_from_menu_left_to_item": 0,
        "width_from_menu_right_to_item": 0,
        "height_from_menu_bottom_to_cursor_when_above": 0,
        "comp_config": {}
    }
}

Now, PSCompletions is qualified, it's time to complete the request.
@Ryanjiena I have submitted the latest version of pr (Ryanjiena/Extras/pull/1) for PSCompletions to you, please merge it.


Allow custom _worker.bundle and _build-metadata.json files for advanced framework use cases

What this PR solves / how to test
This is pretty much untested—here be dragons 🐉
Fixes #5579
Author has addressed the following

Tests

[x] TODO (before merge)
[ ] Included
[ ] Not necessary because:

Changeset (Changeset guidelines)

[x] TODO (before merge)
[ ] Included
[ ] Not necessary because:

Public documentation

[x] TODO (before merge)
[ ] Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
[ ] Not necessary because:

Now we have wrangler.toml (and the potential for main and rules — I don't know if they're actually hooked up yet?), what does _worker.bundle give users that they couldn't reasonably express with config options and source themselves?

from meeting with @pi0: would enabling a runtime flag via this feature disable the binding config ui in the dash?

I hate to be the one to ping on here but it is a huge blocker for us to be able to skip double wrangler transforms for Nitro build output.

Closing in favour of a new approach from @petebacondarwin


Zoom will crash when experimental release v0.36.0 installed.

Microsoft PowerToys version
v0.36.0
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce

with powertoy experimental release v0.36.0 installed
open zoom(https://zoom.us/download#client_4meeting)
zoom crashes with following logs.
uninstall powertoy and zoom will work fine.

80b2a4b5-1a19-4402-9d53-8b3874d342fa
Zoom.us
<IP_ADDRESS>1
Zoom.exe
Windows 10 Enterprise Build 18363
Microsoft Remote Display Adapter
xxxx
Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
1
zh-cn
2021-04-23T02:38:07Z
0x112f7c39
C:\Windows\System32\quartz.dll
0x11280000
10.0.18362.1316
11
740
571
60468
34
32543
21243
65085
52504
2048
1913

✔ Expected Behavior
Zoom should work fine in step2
❌ Actual Behavior
zoom crashes  in step2
Other Software
zoom 5.6.3 (751)

Seems to be working fine on Zoom 5.6.3 (799)

@yuyoyuppe can you verify if this works on a newer build.

I've created a meeting in Zoom 5.6.1 and it worked w/o any issues


Add Time

When we schedule events from python interactively (for instance when the browser is already playing something), we will need to keep the kernel and the front-end in sync. With this PR the browser sends the time at every beat to python, which can observe the corresponding trait.
When running on localhost, there won't be much delay, but when running e.g. on Binder we will probably have to estimate the delay and try to compensate for it (of course it won't be as interactive).
Happy to hear your thoughts.

Sending time every measure is probably a better idea.

That's great @davidbrochart!
I haven't thought much yet about how best to deal with Tone event scheduling from the server side and the issues caused by high latency client/server roundtrips. I guess it becomes harder when mixing both server-side and client-side (jslink widgets) events.
I think that the approach you propose here might be already helpful for doing some cool things! Eventually, it would be nice to implement this logic into a (singleton) Transport widget that exposes start, stop, pause and loop methods, i.e., similarly to #7 where I've tried to mimic Tone's API (which I find very well designed) in Python.
I was thinking about another approach where we would delegate as much as possible event scheduling to the Tone library itself. Actually, scheduling / triggering events from javascript does not ensure that it is in sync with the playing audio and that's why Tone provides exhaustive API to deal with that. This approach would imply implementing fine-grained widget wrappers around Tone classes and possibly re-implementing in Python much of the logic already implemented in Tone. It would represent a fair amount of work, but that might be worth it!
Would you mind waiting for #7 and #9 before consider merging this PR? There's some heavy refactoring going on.

Would you mind waiting for #7 and #9 before consider merging this PR? There's some heavy refactoring going on.

Sure, I'm not even sure we should merge this PR as-is, but maybe as you said as part of a Transport widget.
I'm not saying we should do all the scheduling from Python, because it wouldn't be sample-accurate, but rather have some kind of integration with Tone's scheduling (which is sample-accurate), that would allow the back-end to "follow" the front-end.

Agreed, both approaches are complementary I guess.

@davidbrochart I'm closing this PR as I ended up implementing in #70 a generic approach that allows observing / linking time (i.e., the transport time or the time of the main audio context) as well as other Tone.js properties at a user-defined sampling interval, which was inspired by this PR. Thanks!


Data source error - Table: TenantOfficeLicenses - The column 'Any' of the table wasn't found

https://docs.microsoft.com/en-us/microsoft-365/admin/usage-analytics/enable-usage-analytics?view=o365-worldwide
Step 7: I am able to successfully login, but when I attempt to connect to my data, I receive the following error:
Data source error{"error":{"code":"ModelRefresh_ShortMessage_ProcessingError","pbi.error":{"code":"ModelRefresh_ShortMessage_ProcessingError","parameters":{},"details":[{"code":"Message","detail":{"type":1,"value":"The column 'Any' of the table wasn't found."}}],"exceptionCulprit":1}}} Table: TenantOfficeLicenses.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65732911-21e9-0902-51fa-0d3ae0caaa7a
Version Independent ID: 3682fff5-36fc-1d69-96ef-88f7f73225d5
Content: Enable Microsoft 365 usage analytics - Microsoft 365 admin
Content Source: microsoft-365/admin/usage-analytics/enable-usage-analytics.md
Service: o365-administration
GitHub Login: @Sirkkuw
Microsoft Alias: sirkkuw

@kmthrush - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome, let us know if it is something that can be called out in the docs.
If you don't mind please keep us posted here on the resolution so we can get the applicable information you are discovering back into the docs.


Update fingerprints.yml

Added fingerprint for Ring Alarm Extender

Hey, thank you for your request. Please reach out to<EMAIL_ADDRESS>to start the WWST certification process and let them know you opened this PR.
Feel free to also review the https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/README.md if you have not already had the opportunity to as well. Thank you.

Hi,
I’m not an OEM and therefore the WWST certification process isn’t appropriate for me. I was just proposing the addition of a fingerprint that would benefit me and others (in the SmartThings forum) who have this device.


Failed to resolve: com.github.smart-fun:XmlToJson:1.4.4

added the required lines in build.gradle. But fails to Sync.

ok. my bad. maven dependency added under buildscript> repositories instead of allprojects> repositories,


Elementum custom listen interfaces (VPN) makes streaming don't work. Re-enabling it don't work unless I reinstall whole plugin.

Machine: Windows PC
Steps to replicate:

You have your plugin with default settings. Everything works perfectly, streaming, downloading etc.
Go to settings -> BitTorrent -> Uncheck "Auto-assign network IP"
Go to settings -> BitTorrent ->  Listen interfaces -> Select network interface -> Choose interface that your VPN created
Redo previous step for Outgoing interfaces
Now streaming/downloading don't work (it founds seeds/peer, but cannot connect to them). Even if you disable "Auto-assign network IP" it don't work. Only way to make it work is to reinstall whole plugin.

Is this a bug or am im missing something?
I have Windows App from VPN provider which probably covers my whole connection, but I'll be calmer if I can bind this interface only with Elementum.
@edit
I found that it is okay if I blank outgoing interface. With inbound interface only it run okay.

@theyv Elementum is passing interfaces to libtorrent 'as is'. It can be libtorrent limitation, because it is pretty old.

Let me try different options here.


MLTE Evaluation Protocol

The MLTE Evaluation protocol is the process for MLTE evaluation and should consider

Determining when and how to administer the pre and post surveys
Training on MLTE goals and how to use MLTE
Coaching thorough using the MLTE process

Here is a first draft of the evaluation protocol - below in markdown, and attached in a Word document. Looking forward to comments and changes!
MLTE Evaluation Protocol
Draft 16 May 2024
Step 1: Project Familiarization

Participants need time to become acquainted with their projects.
This will vary by project and team; for participants who are completely new to a project, one week of familiarization is recommended before MLTE is introduced.

Step 2: Initial Survey

Once participants have onboarded and familiarized themselves with their projects, the MLTE team should have them fill out the survey.

Step 3: MLTE Introduction

The MLTE team gives participants an introduction to MLTE, focusing on the process.
This will likely require a ~1 hour meeting including the following content

MLTE overview
Negotiation card demonstration
Time for questions/interaction with participants

Prior to this meeting, the team should set up a central location where negotiation cards can be saved and viewed by all participants and the stakeholders.

Step 4: Project Progression

This step does not involve the MLTE team; participants need time to work on their projects at their own pace. Likely ~2-3 weeks.

(OPTIONAL) Step 5: Testing with MLTE

If a project progresses to the point where it has a functioning model that can be tested, the MLTE team should schedule with the participant for a demonstration of MLTE testing capabilities.
This likely will involve another ~1 hour meeting in which the team conducts an overview and then demonstration of MLTE test capabilities, then a hands-on portion with time to answer questions and help participants as needed.

Step 6: Final Survey

At the end of the project or after ~1 month of work on it (whichever comes first), the MLTE team should have participants take the survey again.

Comments attached.
MLTE_Eval_Protocol_v1-glewis.docx

Updated! Jenny couldn't comment here but she also gave me some edits and I've included those as well.
MLTE_Eval_Protocol_v2.docx

I just have some minor comments. I think we are good to go!
MLTE_Eval_Protocol_v2-glewis.docx

MLTE_Eval_Protocol_May_2024.docx
MLTE_Eval_Protocol_May_2024.pdf
MLTE Evaluation Protocol
23 May 2024
Step 1: Project Familiarization

Participants need time to become acquainted with their projects.
This will vary by project and team. We recommend that participants have access to the code base, familiarization with the project goals, and an understanding of data sources before MLTE is introduced (generally one week of familiarization).

Step 2: Initial Survey

Once participants have onboarded and familiarized themselves with their projects, the MLTE team will ask participants to fill out the survey.

Step 3: MLTE Introduction

The MLTE team gives participants an introduction to MLTE, focusing on the process.
This will likely require a ~1 hour meeting including the following content:

MLTE overview
Negotiation card demonstration
Time for questions/interaction with participants

Prior to this meeting, the team will set up a central location where negotiation cards can be saved and viewed by all participants and the stakeholders.

Step 4: Project Progression

Participants need time to work on their projects at their own pace. Likely ~2-3 weeks, with weekly check-in meetings between the MLTE team and developers, and between the MLTE team and product/project owners, to understand how MLTE is being used and provide coaching as needed.

(OPTIONAL) Step 5: Testing with MLTE

If a project progresses to the point where it has a functioning model that can be tested, the MLTE team will schedule a meeting with the participant for a demonstration of MLTE testing capabilities.
This will involve another ~1 hour meeting in which the team conducts an overview and demonstration of MLTE test capabilities, with a hands-on portion with time to answer questions and help participants as needed.

Step 6: Final Survey

At the end of the project or after ~1 month of work on it (whichever comes first), the MLTE team will ask participants to take the survey again.


Support for redirection with Private Link enabled Azure MySQL DB

[Enter feedback here]
This option of redirection does not work with Private Link. It should be mentioned in the docs. We tried it even with support team.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e4a9d32-64e1-9fe5-5d05-6dd8ce921703
Version Independent ID: 63ac51f0-f4a7-7219-2797-e08523bdf18d
Content: Connect with redirection - Azure Database for MySQL
Content Source: articles/mysql/howto-redirection.md
Service: mysql
GitHub Login: @savjani
Microsoft Alias: pariks

Thanks @sumitkute for reporting this. We have added this limitation to the document. It will be merged and live in a day or so.

Thanks @sumitkute for reporting this. We have added this limitation to the document. It will be merged and live in a day or so.

@BhargaviAnnadevara-MSFT - the document is live. Could you please help close this issue. thanks !!

@BhargaviAnnadevara-MSFT - the document is live. Could you please help close this issue. thanks !!

@savjani Thank you for the correction.
@sumitkute We will go ahead and close this issue for now. Please get back to us if any other issue.

@savjani Thank you for the correction.
@sumitkute We will go ahead and close this issue for now. Please get back to us if any other issue.


Choose single comment or double comment on certain types of files

In python, I have a preference for single hash comments for the licence. Unless there is a good practice guide or recommendation for having double hash comments, it would be nice to be able to choose from the command line.

This should work now.


Screen is flashing

Hi,
while loading the model. I can see like Screen is flashing here is the model example
https://media.flixcar.com/3dfw/p/player/index.html?arid=1825115
can you help me with this @elalish
thanks

If you are talking about this issue with the TV screen I think you just need to move the "picture" plane a little bit away from the frame of the TV.

Agreed, that looks like z-fighting. Ideally models like this should be authored as a single shiny, textured surface. Putting a glass layer over the image might sound more physically realistic, but in practice it only makes things worse.


Regression in v0.6 when decoding an PostgreSQL enum in a PgRecordDecoder

I don't have a complete reproduction at the moment although I could work on it.
The basic issue is that we're using a custom PostgreSQL enum, i.e. CREATE TYPE MyEnum AS ENUM ( ... ), and try to decode that from a PgRecordDecoder using try_decode. On the rust side the enum derives sqlx::Type nothing else special. In v0.5 this works fine, but in v0.6 it hits the following error:
error occurred while decoding column variables: custom types in records are not fully supported yet: failed to retrieve type info for field 4 with type oid 25101253

Where oid 25101253 is our enum. The error comes from: https://github.com/launchbadge/sqlx/blob/8fd7ee72a62449af592bf3c43d360a3d64f6195c/sqlx-core/src/postgres/types/record.rs#L136
Which was added in https://github.com/launchbadge/sqlx/pull/1855 (hence my comment there).

I just tried partially reverting #1855 with the following patch and that fixes the issue. Would that be an acceptable change?
diff --git a/sqlx-core/src/postgres/types/record.rs b/sqlx-core/src/postgres/types/record.rs
index 352bdb72..c2b1bcce 100644
--- a/sqlx-core/src/postgres/types/record.rs
+++ b/sqlx-core/src/postgres/types/record.rs
@@ -132,8 +132,7 @@ impl<'r> PgRecordDecoder<'r> {
                 }

                 let element_type =
-                    element_type_opt
-                        .ok_or_else(|| BoxDynError::from(format!("custom types in records are not fully supported yet: failed to retrieve type info for field {} with type oid {}", self.ind, element_type_oid.0)))?;
+                    element_type_opt.unwrap_or_else(|| PgTypeInfo::with_oid(element_type_oid));

                 self.ind += 1;

@abonander that's unfortunate, but it's still a clear regression. Is there a middle road we can take? Maybe delay the creation of the error to the point where it previously panicked? This way at least the custom enum within a record will keep working.

Thank you for reporting this error. I was busy for a few weeks but still intend to refactor SQLx to fully support custom types. I am sorry for the regression.
I'll try to look into this in the next days.

@demurgos any update on this? I could look into this myself if you don't have the time.

This is still preventing up from updating, any news?

This is still preventing us from updating, any news?

Me too— is this issue planned for 0.7?

+1, any resolution here?


ARROW-3254: [C++] Add SOURCES option to ADD_ARROW_TEST to be able to combine multiple test files into a single executable

I also moved arrow/test-util.h to arrow/util/testing.h and moved some of the implementation of that file into arrow/util/testing.cc, so that many of these auxiliary test functions are only compiled once.

Argh Windows is a constant source of problems. @pitrou apparently if you combine a DLL (like arrow.dll) with a static library (like the auxiliary testing static library I created here) it will gripe about duplicated inline symbols. I think we should revert to statically linking the tests on Windows to avoid this madness

I'd like to step back a bit:

having multiple test files allow parallelizing (an important feature when developing, especially now that Parquet tests have been added to the bunch - some of them are quite slow)
linking should be fast if Arrow is linked as a shared library
the test executables should be small if Arrow is linked as a shared library

The fact that we do/did static linking for tests is an anomaly, and is IMHO the real source of the slowness and disk consumption.

It appears that the issue is that the symbols in the DLL have dllimport linkage while in the static lib they have dllexport: https://akrzemi1.wordpress.com/2016/11/28/the-one-definition-rule/. I'm going to fire up my windows box and see if I can fix it

linking should be fast if Arrow is linked as a shared library

My understanding is that code coverage doesn't work if you don't statically link

Reading https://github.com/apache/kudu/blob/master/CMakeLists.txt#L422, it seems that maybe the coverage issue goes away if you use Clang

Do you mean codecov-generated code coverage results?

Yeah, apparently there is an issue with code coverage data generated when compiling with --coverage and using gcc. Read this commit message for more information about this https://github.com/apache/kudu/commit/48799d3fed53c79a5163fd9c4cd9cbae80a9f2d6

I'll revisit this after https://github.com/apache/arrow/pull/2997 is merged


Apply a minor update to remote.md

Changes

Replaced the example of inherent communication between server and clients:
-> Since the default character movement is client-authoritative, with client being the network owner, the current example could be misleading.

Switched pairs with generalized iteration.

Checks
By submitting your pull request for review, you agree to the following:

[x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
[x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
[x] To the best of my knowledge, all proposed changes are accurate.

Nice clarification! We appreciate your contribution.


Backend for Contact us form

Is your feature request related to a problem? Please describe.
We have created the frontend for the Contact us form using HTML and CSS. Add the Backend code to handle the response after submit button.
Describe the solution you'd like

You need to add a function in views.py to send an email to the admin.
Add the path/route to the url.py file.

@khannakshat7  I can work on this but where is the HTML and CSS file.
Assign this to me under GSSOC'21.

I'd like to work on this I have a great experience with Django and created multiple websites with it can you assign this to me I'm a gssoc 21 participant

Hey!! Contact page is on all the pages including the homepage so wouldn't be good if a separate page is made for the contact ?
On homepage a chatting bot can be added which will take us to the contact form if the user problem is not solved by the bot.

@shivaamm Yes create a new seperate page for contact

@khannakshat7 sir you have assigned us all. Who is supposed to work not this?

@shivaamm Yes create a new seperate page for contact

Alright Thanks

@khannakshat7 sir you have assigned us all. Who is supposed to work not this?

Anyone who raises the first PR without conflicts will be merged

@khannakshat7 I have pulled the changes, but there is no contact form? It the form remaining to be merged?

@khannakshat7 I have pulled the changes, but there is no contact form? It the form remaining to be merged?

Yes wait for some time it will be merged soon

I'm on it. I am doing the Backend part. Please assign this to me under gssoc21.

@khannakshat7 I'm on it. I am doing the Backend part. Please assign this to me under gssoc21.


Update Fuse.js configuration to adjust search threshold

What is the context of this PR?
This PR fixes #3347
This PR updates the Fuse.js configuration to address an issue where only the first 30 characters in the list seem to be searched.
The previous threshold setting of 0.2 was too restrictive, causing the search to miss relevant entries when queries became longer. With this update, users can now set the search threshold between 0 and 1, allowing for greater flexibility and improving search accuracy across different query lengths.
How to review this PR
Describe the steps required to test the changes (include screenshots if appropriate).

Run the search functionality with the updated configuration.
Perform a search for "South Georgia and the South Sandwich Islands" with the updated threshold.
Verify that the search result appears when searching for "South Sa" and similar queries.

Checklist
This needs to be completed by the person raising the PR.

[x] I have selected the correct Assignee
[x] I have linked the correct Issue

The description now needs updating with the latest changes

I think there may be an issue with this not working as expected, I upped the threshold to 0.8 in the example and was still getting the same results. So you may need to make sure that is being passed into the config correctly

Im not sure this is defaulting to 0.2, when removing the setting of the param from the example the results are a lot stricter. Also the attribute is still being set just without a value which I dont think we should be doing

@precious-onyenaucheya-ons @rmccar
Sorry, I ran out of time to look at this on Friday after running into some git permission issues Precious is aware of but I wanted to take a look before you have stand up in the morning. I'm not sure if I've misunderstood the ticket and the requirements - it wasn't entirely clear for me but this doesn't look like it's working to me. Could be I'm not looking at it correctly but once I hit around 32 characters in the search box it no longer returns the results I'd expect. I've taken some screen shots to illustrate what I experienced.

"South Georgia and the South San" - returns what i'd expect
"South Georgia and the South Sand" - doesn't seem to return anything
"South Georgia and the South Sandw" - gives me some results, but doesn't seem to be based on anything I've searched for
"South Georgia and the South Sandwich Island" - still appears to give me results not based on my search
"South Georgia and the South Sandwich Islands" - suddenly seems to kick back in to life and return an expected result.

I tried playing with the thresholds but this didn't seem to make any difference to the issues I've described above.

I'd also like to second @admilne's findings. I've also done some additional testing with some of my own examples.
I created a new JSON file with only examples of search terms which are longer than 32 characters. It seems like the search threshold doesn't change the results when typing. Whats more worrysome is the fact that words outside of the 32 character soft limit aren't picked up by fuse.

In this picture, you can see this is a search term. You can also see the word characters in the search terms which is the 54th character in the field

Characters does not return anything in this scenario
This might seem like an edge case but say there was a scenario where a user wanted to match this:
Ultra HD 4K Smart Television Model XYZ1234567890
based on the model number which is outside of 32 characters
You can test my changes in: feature/3282/increase-search-threshold-adi

South Georgia and the South Sand

After the changes that have been made with the distance param these issues seem to have fixed by upping the threshold to 0.4 in my testing. But the issues Andrew highlighted still seem to be an issue

I'd also like to second @admilne's findings. I've also done some additional testing with some of my own examples. I created a new JSON file with only examples of search terms which are longer than 32 characters. It seems like the search threshold doesn't change the results when typing. Whats more worrysome is the fact that words outside of the 32 character soft limit aren't picked up by fuse.

In this picture, you can see `this` is a search term. You can also see the word `characters` in the search terms which is the 54th character in the field

Characters does not return anything in this scenario
This might seem like an edge case but say there was a scenario where a user wanted to match this:
Ultra HD 4K Smart Television Model XYZ1234567890
based on the model number which is outside of 32 characters
You can test my changes in: feature/3282/increase-search-threshold-adi
Edit: Actually in even more testing, back to the original example (testing in countries-multiple), if you type "sandwich islands", you'd expect "South Georgia and the South Sandwich Islands" to appear but nothing appears
Edit 2: Even weirder, if you search for "thi" in the search box in my example, you get matches for "thi" beyond 32 characters? Not sure if this is because its previously matched "thi" at the beginning.

These issues seem to have fixed by upping changing the distance to 500 in my testing without changing the threshold at all. So maybe we need to parameterise the distance not the threshold. But the issues Andrew highlighted still seem to be an issue. There might be an issue with the length of the query string entered which would cause the issues Andrew has found. This all needs bit more testing to make sure we get a balance between the distance and threshold. Testing with ignoreLocation might also be something we want to look into.

Ive found an issue with the component search on the DS. It finds the list of components when you start typing the name of a component but no longer goes to that page when you click the suggestion. There is this error in the console:


Fix docker 1.13.1

Docker changed a link.
See https://jira.mesosphere.com/browse/DCOS_OSS-3623.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@346c7c2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #976   +/-   ##
=========================================
  Coverage          ?   84.74%
=========================================
  Files             ?       28
  Lines             ?     1639
  Branches          ?       60
=========================================
  Hits              ?     1389
  Misses            ?      247
  Partials          ?        3

Impacted Files
Coverage Δ

tests/test_dcos_e2e/backends/docker/test_docker.py
100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346c7c2...1a42b07. Read the comment docs.


Add bintray upload support to javaSE & java EE

This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Update bintray.properties file then try to run gradle bintrayUpload for javaSE and javaEE and make sure it actually uploads to bintray.
Summary
This PR adds bintray support to javaSE and javaEE in a way that is similar to how it works for Android.
CLA

[x] I have signed the CLA

Codecov Report

Merging #988 into feature/sdl_java_base will increase coverage by 0.05%.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##             feature/sdl_java_base     #988      +/-   ##
===========================================================
+ Coverage                    44.27%   44.32%   +0.05%
- Complexity                    3541     3542       +1
===========================================================
  Files                          430      430
  Lines                        19603    19603
  Branches                      2137     2137
===========================================================
+ Hits                          8679     8690      +11
+ Misses                       10492    10480      -12
- Partials                       432      433       +1

Impacted Files
Coverage Δ
Complexity Δ

...smartdevicelink/encoder/VirtualDisplayEncoder.java
28.97% <0%> (+4.54%)
8% <0%> (ø)
:arrow_down:

...tdevicelink/Dispatcher/ProxyMessageDispatcher.java
61.76% <0%> (+8.82%)
4% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed59f1f...649af9b. Read the comment docs.


mayhem integration

@evanrichter This seems to be failing:
https://github.com/mayhemheroes/llvm-ir/actions/runs/2783441452
https://mayhem.forallsecure.com/mayhemheroes/llvm-ir/parse-bc/1
INFO: Seed:<PHONE_NUMBER>
INFO: Loaded 1 modules   (106513 inline 8-bit counters): 106513 [0x5647ed0692b0, 0x5647ed0832c1),
INFO: Loaded 1 PC tables (106513 PCs): 106513 [0x5647ed0832c8,0x5647ed2233d8),
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
INFO: A corpus is not provided, starting from an empty corpus
#2      INITED cov: 13 ft: 14 corp: 1/1b exec/s: 0 rss: 44Mb
error: file doesn't start with bitcode header
==21== ERROR: libFuzzer: fuzz target exited
    #0 0x5647eb2e07e1  (/parse_bc+0x5f37e1) (BuildId: de7da075c53d900ee41f37f4c80fd1bacc39619d)
    #1 0x5647ec78e228  (/parse_bc+0x1aa1228) (BuildId: de7da075c53d900ee41f37f4c80fd1bacc39619d)

should the harness be catching this exception?


Bugfix/ravenscroftj/user agent

As per the issue I opened a couple of weeks back I have updated webutil so that whenever it uses requests it sets a default user agent string. I've modified test utils and some of the silo-specific granary tests to be able to deal with this new behaviour.
I initially went with a webutil user agent but since this library is maintained as part of oauth-dropins I decided that the oauth-dropins user agent string was probably more appropriate.
Link to original issue I opened with bridgy here

Thanks for this! I'll tweak the logic a bit, and I'll actually switch the default user agent back to webutil, since that's more appropriate for granary and Bridgy to send than "oauth-dropins ...", but otherwise lgtm, thanks again.


Settings wiki page is broken

The Settings page on the wiki is broken. To be fair, I don't think you can find it anywhere aside from the list of all the wiki pages, so it's probably fine to just remove the page.
It looks like the images were removed in https://github.com/SolastaMods/SolastaUnfinishedBusiness/commit/79078320fde23075f2176597e37b103f55d7561a and never replaced. If those images are still good, maybe they can just be re-added.
I stumbled across the Settings page trying to find out what else the mod offers aside from character and monster options (I had seen mention of a 6 player mode elsewhere) so I'd love to see this page or another page updated to contain that info, if possible.

I’m counting on volunteers to do so. Deleted the page meanwhile.


Change caches that use string keys to use the hash code instead

Caches that use string keys are failing to look up the cached values. This should be changed to use the hash codes of the strings.

Apparently this had another cause and is actually working as expected.


SQLite driver missing since 7.1.0

System information:

Ubuntu Linux 18.04
DBeaver version 7.1.0

Connection specification:

Database name and version - some random SQLite DB
Driver name - according to Dbeaver org.xerial:sqlite-jdbc:RELEASE
Do you use tunnels or proxies (SSH, SOCKS, etc)? Nope

Describe the problem you're observing:
I try to connect to a SQLite DB. As soon as I create the new connection, DBeaver somehow wants to download some drivers. The error message is:
Error resolving dependencies
  Maven artifact 'maven:/org.xerial:sqlite-jdbc:RELEASE' not found

Network connection is alright. It was working properly before in 7.0.x.
Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

Error resolving dependencies
Maven artifact 'maven:/org.xerial:sqlite-jdbc:RELEASE' not found
Maven artifact 'maven:/org.xerial:sqlite-jdbc:RELEASE' not found

hi @mosesontheweb ,
could you try to reset driver to default?

Hi, well I did, but no success.
However, I was able to solve it that way, that I deleted this default entry, downloaded the corresponding SQLite JDBC driver from bitbucket and added the location to the libraries of this driver. This actually solved my issue for now, however, it is strange that the previous default entry wasn't working in 7.1.0, but versions before had no problems with that.
Regards, Thomas

dBeaver version 7.1.0
macOS High Sierra version 10.13.6
I also have a similar problem trying to connect to a Redshift DB. I'm getting a "Maven Artifact not found" error, and the pop-up that prompts you to download the driver doesn't do anything. A co-worker with an earlier version of dBeaver was able to download the driver from the pop-up.

@cindymeliyen this issue is resolved in scope of #9065
@mosesontheweb still cannot reproduce the issue against the current version. If it is still actual for you - feel free to reopen the ticket

I had similar error with SQLite driver but my miss was that I am behind a vpn, maybe you are behind a firewall or there is proxy settings to set. I removed the vpn and it worked smoothly

I was not on VPN, but did not realise that I was behind a proxy server. Paused it, everything worked fine, resumed it. Worth checking.

hi @mosesontheweb , could you try to reset driver to default?

Although I tried to reset the driver, the download progress bar also appeared, but the download failed again after a while, why is this?


Rollout improved example converter

Rolls out improved TF example converter.

RandomInteger.java has
.action(%!v(PANIC=Format method: runtime error: invalid memory address or nil pointer dereference))
Are we printing a go panic in the example?

Yeah let me have a closer look.

Thanks for spotting @VenelinMartinov blocked on https://github.com/pulumi/pulumi-java/issues/1341

Resolved panics by upgrading AWS pinned reference to 6.x.


New Validator Does Not Exist Despite Successful Creation Tx

Describe the bug
A clear and concise description of what the bug is.
If you review the following link you can see my new validator is alive and well but on Big Dipper it says it does not exits.
https://akash.aneka.io/validators/akashvaloper14s4tlmlvy0vsps05csf8l80m7nqxmau3dfh330
To Reproduce
Steps to reproduce the behavior:

Go to 'https://akash.bigdipper.live/validator/akashvaloper14s4tlmlvy0vsps05csf8l80m7nqxmau3dfh330'
See error:
Validator Details -
Validator does not exist.

Expected behavior
A clear and concise description of what you expected to happen.
It should display the validator details same as:
https://akash.aneka.io/validators/akashvaloper14s4tlmlvy0vsps05csf8l80m7nqxmau3dfh330
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

@lightiv thank you for the report. We will look into it. Thanks!

@lightiv thank you for the report. We will look into it. Thanks!

@lightiv seems this is fixed from our latest deployment. Can you confirm if this can be closed?

@lightiv seems this is fixed from our latest deployment. Can you confirm if this can be closed?

Thanks, it is fixed now.

Thanks, it is fixed now.


Genome alignment<EMAIL_ADDRESS>

I did not add an optional --tmpdir for HISAT2, as it either does not need it or does not seem to support it.


Added confirmation prompt

A confirmation prompt may be useful to prevent the execution of sensitive Laravel artisan commands.
I am making the pull request after suggestion on this tweet, cheers.
https://twitter.com/abdelkader_mh/status/1535212593098399745

@freekmurze I have updated "Amend" the pull request with the request changes above.

Thanks!


In the Async Example not clear how to support add action which needed to call out to server

In the example http://fluxxor.com/guides/async-data.html the addaction updates the list locally. Let say the list has many users adding to it so the add method would need to reload the list with its entry updated. How would that be done, since the actions shouldn't initiate other actions .

Why not just modify the ADD_BUZZ_SUCCESS event so that it doesn't accept the id of submitted item, but the list (of all items, retrieved from server). And onAddBuzzSuccess smth like this:
 onAddBuzzSuccess: function(payload) {
     this.words = payload.updatedWord;
     this.emit("change");
 },


Provide scaler for Elastic Metricbeat metrics

Provide scaler for Elastic Metricbeat metrics.
https://www.elastic.co/beats/metricbeat

Hi, I am interested this issue, could you please give more details about it?

It looks like I've misread and it's just a way to use agents to get metrics into a variety of output systems such as Elasticsearch and more so I will close this issue, sorry.
I'm opening https://github.com/kedacore/keda/issues/1756 for Elasticsearch instead.


0.14.12 Settings Changes Breaks Start Script

Running factorio-init/factorio start with 0.14.12 experimental version gave me this error:
Unable to start Factorio
Could not start Factorio

I ran `factorio-init/factorio invocation' and saw that the script was trying to run this command:
/opt/factorio/bin/x64/factorio --config /opt/factorio/config/config.ini --port 34197 --start-server-load-latest --server-settings /opt/factorio/data/server-settings.json --autosave-interval 10 --autosave-slots 3 --allow-commands admins-only

Reading the changelog for 0.14.12, I saw that the autosave-interval and autosave-slots (as well as allow_commands, afk_autokick_interval, and auto_pause) are now settable only in server-settings. I think this is what is causing the issue.

This pull request fixes the issue.


[APP-4420] Add backoffice chart

Add a label automerge to automatically merge the PR after approval and passed checks.
Description
Already applied this in testing2, it works:

│ datafold-backoffice-679dcfcbf4-xllpw [2024-11-19 22:10:12,372][PID:1][INFO][datafold.cli.ws_client] Connected to server: wss://portal.datafold.io/backoffice/v1/ws                        │

I ended up using terraform apply -replace="helm_release.datafold" because I could not get terraform to pick up the chart changes when I was debugging.
Very interested in understanding how we're rolling out the helm chart version upgrade on all our environments.

ALso let's update the PR title.


Users can now send images in chat prototype

#330
Now:

Journal integrated.
Now:

Defined a separate function for sending data through the presenceObject making it easier to accommodate future updates.
Also noticed a slight discrepancy in the code given in https://github.com/llaske/sugarizer/blob/dev/docs/tutorial_step7.md

@llaske Are there any other improvements I could make in this PR?

@llaske  Are there any changes I should make with respect to this PR?

@llaske Are there any changes I should make with respect to this PR?

@llaske  I have made the requested changed. Can you please review this PR?

Could you solve conflict on last dev branch?

done @llaske

Nice work.
Few remarks:

The icon quality is bad, should be nice to use the "standard" Sugar icon to include an image
It will be better to put the icon into the toolbar
The user should not be able to integrate an image before connection
You broke compatibility with a client that do not include this feature. So an "old" version of the app will not be able to communicate with this new version
Please fix conflict

Now :

Icon changed. This is the icon used in record activity as well as QRcode activity.
Image Upload icon moved to toolbar
The icon is online visible when the user connected, therefore they cannot integrate an image before connection
Conflict fixed

An old version of the app will still be able to exchange text messages with a newer version since I'm only sending a new member "type" in the message object. It just won't be used anywhere.
In the case that a user on the newer version sends an image, the old version will display the base64 code of the image. Currently, I see no way of dealing with this bug. Even with changes to the Sugarizer server, note that the userInfo object that is sent to the server does not contain the application version so the server won't be able to decipher what to send to a socket. so this is just a glitch that's gonna persist unless everyone in the neighborhood updates to the new version.

Nice. The image is good now.
There is still a conflict: If an old client try to send a message to the new client, the new client don't display the old client message (just ignore it). BTW old client is able to display new client message (expect images but it's okay).

Hm...I'll look into it

Done @llaske
Now older versions can interact with the new one

@llaske I have made the requested changes, can you please Review this PR?

Done @llaske

Ok. Nice.


remote address ratelimit metrics cannot be converted to prometheus format

ratelimit.service.rate_limit.gateway-conformance-infra/same-namespace/http.httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*_httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*.masked_remote_address_<IP_ADDRESS>/0.remote_address.over_limit

. is a key word in statsd we should avoid to use it in descriptor.
Originally posted by @zirain in https://github.com/envoyproxy/gateway/issues/4272#issuecomment-2358493167

needs to be fixed upstream ?

yes, need to fixed upstream first.

wait https://github.com/envoyproxy/ratelimit/pull/716

xref: https://github.com/envoyproxy/ratelimit/pull/773


[BT] fixes (IDFGH-8253)

A set of small fixes on Bluetooth.

Thanks for your contribution.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, @tgotic, thanks for you contribution, this kind of coding style issues are indeed prevalent in the Bluedroid codebase, and it's challenging to thoroughly identify and address all of them. Making only a small subset of fixes wouldn't result in substantial improvements. Therefore, we've decided not to merge this pull request.
Thank you again for your contribution. Our team will work on addressing these coding style issues collectively in the future.

Thanks for contribution again.


Unicode apostrophes

The rules on the rule page use unicode apostrophes, instead of the ascii ones.

Thanks for letting me know, I was just copying delta's doc. I fixed this locally, so I'll close this.

test

t
t
t


Release v1.84.0

Description 📝
Change log
Added:

Jan 2023 Marketplace Apps
Type-to-confirm to more destructive actions

Changed:

Standardized usage of dismissible banners and notices
Aligned left modal title
Standardized Disk IO -> Disk I/O formatting across app

Fixed:

Linodes Landing Extra Padding
Broken URL for Peppermint Marketplace App

How to test 🧪

Test Banners and notices
Test all core functionalities

How do I run relevant unit or e2e tests?

yarn cy:run

@hana-linode Oh interesting. Running locally it does not 404, but using our internal preview link, the image 404s. I'm not sure how this will translate to staging

I'm still testing the app but the Apache Airflow logo looks fine on my end also:

Apache Airflow log is working for my end as well..


Remove unexpected [tags=disable-validation]

Fixes missing code snippet in https://gradlex.org/build-parameters/#disable-build-parameter-validation

Oh indeed that not the expected paths. Do you prefer opening a new PR or simply updating this one?

I don't mind :o)

I've update the PR


Disabling text selection

This edit disables text selection on the page, eliminating situations where long presses accidentally select text. To my knowledge, this doesn't mess with any other touch functionality.

We use .less for developing, so i changed original .less file with your merge. Thank you.


fix: Created issue template for fix types

Issue: https://github.com/WikiPortal/DoodleCollab/issues/2

LGTM but please ask for assigning you before working


[SPARK-6428][MLlib] Added explicit type for public methods and implemented hashCode when equals is defined.

I want to add a checker to turn public type checking on, since future pull requests can accidentally expose a non-public type. This is the first cleanup task.

Test build #28912 has started for   PR 5102 at commit 52bc2d5.

This patch merges cleanly.

Test build #28912 has finished for   PR 5102 at commit 52bc2d5.

This patch fails to build.

This patch merges cleanly.

This patch adds the following public classes (experimental):

case class TaskCommitDenied(jobID: Int, partitionID: Int, attemptID: Int) extends TaskFailedReason

class ExecutorSource(threadPool: ThreadPoolExecutor, executorId: String) extends Source

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28912/
Test FAILed.

Test build #28915 has started for   PR 5102 at commit 617f19e.

This patch merges cleanly.

Test build #28915 has finished for   PR 5102 at commit 617f19e.

This patch passes all tests.

This patch merges cleanly.

This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28915/
Test PASSed.

LGTM. Merged into master.


action:install skips first additional argument

Not sure if this is a bug or that first additional arguments meant something, but when running this:
dotnet <dll> action:install some arguments here
or this:
dotnet <dll> some arguments here action:install
The resulting command line for the service is this:
dotnet <dll> arguments here action:run
Note that the "some" argument is missing from the command line.

Thanks for reporting the problem, I won't have time to look at this for a while but I'll keep it in mind when I'll find some time.  That said, I didn't really have time to build a self contained app and check if the behavior for those is still correct. For my case at least, it behaves correctly now.
Also I don't expect any problems considering the simplicity of the change, but just so you know, I couldn't be bothered to install net471 SDK right now so I only tested against netcoreapp2.0.


libfilezilla: 0.19.3 -> 0.20.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libfilezilla/versions.
meta.description for libfilezilla is: '"A modern C++ library, offering some basic functionality to build high-performing, platform-independent programs"'.
meta.homepage for libfilezilla is: '"https://lib.filezilla-project.org/"

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.20.0 with grep in /nix/store/z3dl0yrdwwdsf5i2z8ijlb6n9jyssr89-libfilezilla-0.20.0

directory tree listing: https://gist.github.com/ec98c383734c08f32c1216ef507470f1

du listing: https://gist.github.com/f7a12a24e36bb910f5980172b5edb366

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
filezilla
libfilezilla

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z3dl0yrdwwdsf5i2z8ijlb6n9jyssr89-libfilezilla-0.20.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libfilezilla https://github.com/r-ryantm/nixpkgs/archive/63a1e02a929d4285b8b110f78c9872895c82cd8a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z3dl0yrdwwdsf5i2z8ijlb6n9jyssr89-libfilezilla-0.20.0
ls -la /nix/store/z3dl0yrdwwdsf5i2z8ijlb6n9jyssr89-libfilezilla-0.20.0/bin

cc @pSub for testing.

Superseded by #81917 86217


[Bug]: Plugin thinks, Rich Presence is not enabled, but it is.

What happened?

In dicord, the activity has not changed.
IDE version
2024.2
Plugin version
2.1.3
What operating system are you using?
Windows
Relevant log output
No response

This error means the plugin detects a running discord client without an IPC file. This can be caused if you launched Discord as administrator, for instance, or if you're using a custom Discord client that is not working as the original one.

I didn't start Discord as an administrator and I'm using the original client. When I start discord an administrator I get a message in PyCharm.

After restarting PyCharm and Discord it worked. I don't know why, but is does.

Can you run the following command in a CMD and give me the output?
FOR %I IN (0,1,2,3,4,5,6,7,8,9) DO (IF EXIST "\\?\pipe\discord-ipc-%I" (echo IPC %I found) ELSE (echo IPC %I not found))

After restarting PyCharm and Discord it worked. I don't know why, but is does.

Strange, I don't think that this could be an issue with the plugin, as it tries to reconnect every 5s, so it might be more a Discord-related issue 🤔

C:\Users\USER>FOR %I IN (0,1,2,3,4,5,6,7,8,9) DO (IF EXIST "\?\pipe\discord-ipc-%I" (echo IPC %I found) ELSE (echo IPC %I not found))
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-0" (echo IPC 0 found )  ELSE (echo IPC 0 not found ) )
IPC 0 found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-1" (echo IPC 1 found )  ELSE (echo IPC 1 not found ) )
IPC 1 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-2" (echo IPC 2 found )  ELSE (echo IPC 2 not found ) )
IPC 2 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-3" (echo IPC 3 found )  ELSE (echo IPC 3 not found ) )
IPC 3 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-4" (echo IPC 4 found )  ELSE (echo IPC 4 not found ) )
IPC 4 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-5" (echo IPC 5 found )  ELSE (echo IPC 5 not found ) )
IPC 5 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-6" (echo IPC 6 found )  ELSE (echo IPC 6 not found ) )
IPC 6 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-7" (echo IPC 7 found )  ELSE (echo IPC 7 not found ) )
IPC 7 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-8" (echo IPC 8 found )  ELSE (echo IPC 8 not found ) )
IPC 8 not found
C:\Users\USER>(IF EXIST "\?\pipe\discord-ipc-9" (echo IPC 9 found )  ELSE (echo IPC 9 not found ) )
IPC 9 not found
Thank you for your efforts! 😄

So yes, an IPC file is detected, but the plugin cannot connect to it. There is nothing more I could do about that; it's not an error with the plugin, unfortunately :/
I'm glad a restart fixes it, but it's not optimal.

Thank you for your efforts! 😄

You're welcome!


refactor(FileMiddleware): add format information, minor code refactoring

What kind of change does this PR introduce?
add format information, minor code refactoring
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing

Thanks


Support for web ontology language (OWL)

The Web Ontology Language (OWL) is a family of knowledge representation languages for authoring ontologies, created by W3.
The languages' syntax is simply "xml".
The languages' file extension is ".owl".
With this in mind the addition was trivial.
Thanks
Guy

Just out of curiosity, if it is highlighted as XML why do you want to add it as a language? why not add it as a new extension for XML?

It is a widely used language, and it would interesting to be able search and gather stats about its use.
Also it is distinct from xml, it just uses for the xml syntax for interchange.

Okay, thanks for answering my question :-)

This looks good. Thanks @phuicy.

It'll be another week or so before these changes are live on GitHub.

Brilliant thanks


Split baseline profiles into their corresponding artifacts

https://github.com/skydoves/landscapist/blob/main/bash/baseline-profile-amender.sh


Fix/aws here map

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Changes:

Fixed issue caused when swapping destinations and one of them (the first) was empty
Moved up attribution label up when on mobile so it's more likely for it to be on screen

Working on creating CloudFormation template due to known issue in "Deploy to Amplify" button that doesn't work consistently on monorepos (like this one).
Will mark the PR ready for review once that's done.

Temporarily removed deploy button since blog post was already published, will reintroduce once "Deploy to Amplify" button is working.


Getting AttributeError: 'str' object has no attribute 'items'

rasa NLU version: 0.8.0a5 (cloned today from latest master branch)
Used backend / pipeline: Mitie pipeline
Operating system (windows, osx, ...): osx
Issue: I get the below error when i try to start the server  by executing -m rasa_nlu.server -c config.json --server_model_dirs=./model_20170405-151522
Traceback (most recent call last):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/Users/shahbaz/Documents/tincan-cloud/rasa_nlu/rasa_nlu/rasa_nlu/server.py", line 105, in
app = WSGIServer(('<IP_ADDRESS>', rasa_nlu_config['port']), create_app(rasa_nlu_config))
File "/Users/shahbaz/Documents/tincan-cloud/rasa_nlu/rasa_nlu/rasa_nlu/server.py", line 96, in create_app
rasa_nlu_app.data_router = DataRouter(config)
File "rasa_nlu/data_router.py", line 72, in init
self.model_store = self.__create_model_store()
File "rasa_nlu/data_router.py", line 121, in __create_model_store
for alias, model_path in list(model_dict.items()):
AttributeError: 'str' object has no attribute 'items'
I took a look into recent commits and I think the issue may be because of the following commit: link

@shahbazahmed1269 thanks for the report, let me have a look at that.

@tmbo If it may help, I have created a pull request (PR #264)  on how I fixed the above error.


get reference to fastlane folder the more correct way

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Description
Update to get the fastlane folder the more correct way (that will even find it if the folder starts with a .)

@KrauseFx omg when are we getting fastlane fidget spinners?


Outputting function as root dd/dump object does not behave consistently

Seems to be related to call-stack examination.
Currently seems to (generally) output correctly for module-level functions, but breaks with class-level.
Before closing issue, should also examine functions in nested classes, as well as outputting a default value in event of future call-stack examination issues.

Currently works when dumping a function and a function on an object. But fails to find the function name if the function is deeper within an object. EX: dump(obj_a.prop_b.do_work) will not be able to find the name of do_work. But, should we really be dumping things in this manner anyway? It seems more likely to just dump obj_a and then inspect.

Was determined that they should be functionality that is included. Should be fully fixed as there is an entirely new way of getting the dumped variable's name that is way simpler and handles making nested calls inside the dump.


Support Pytorch > 1.1.0

Issue description
Installation with pip fails with
ERROR: Could not find a version that satisfies the requirement torch<1.2.0,>=1.1.0 (from snorkel) (from versions: 0.1.2, 0.1.2.post1, 0.1.2.post2) ERROR: No matching distribution found for torch<1.2.0,>=1.1.0 (from snorkel)
Code example/repro steps
pip install snorkel
Results in error as above. torch versions listed are not available.
Any reason torch 1.4 cannot be used?
Expected behavior
Successful install
System info

How you installed Snorkel (conda, pip, source):
pip
Build command you used (if compiling from source):
OS:
Windows 7 x64, Windows 10 x64, RHEL 7.5
Python version:
3.7.4
Snorkel version:
Current (0.9.3)
Versions of any other relevant libraries:
None, clean environment

Additional context
There seems to be little development and no releases for months now, that's why the requirements are impossible to meet anymore, is the project dead?

At the moment, snorkel requires torch>=1.1.0,<1.2.0.
We have an upgrade planned but also welcome community support here!

@blackr2d try installing with python=3.6, this should fix it. Also on their readme, they mention enabling the Linux kernel on Windows

Fonduer would also benefit with an upgrate on snorkel's torch dependency to be something like "torch>=1.3.1,<2.0.0".

Hi all — torch>=1.2 is now supported in the latest release, snorkel==0.9.5.

Thank you! Confirmed working.


Investigate how other organizations handle open source collaborations

Someone investigate how other organizations handle open source collaborations. Contact FaithTech for recommendations. Contact Robert Clementz for ideas

What specifically are we wanted to find out? Copyright notices, signing certificates, etc.?


Data discrepancy found

Invalid release year 3003 for Lost in Translation it should be 2003:)

Issuse resolved in v<IP_ADDRESS>


Automated cherry pick of #5652: proxysetting: forbid deletion of DIRECT setting

Cherry pick of #5652 on release/3.1.
#5652: proxysetting: forbid deletion of DIRECT setting

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@5bcc2a4). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/3.1   #5657   +/-   ##
=============================================
  Coverage               ?   7.45%
=============================================
  Files                  ?     583
  Lines                  ?   98301
  Branches               ?       0
=============================================
  Hits                   ?    7331
  Misses                 ?   90397
  Partials               ?     573

Flag
Coverage Δ

#aFlag
7.45% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcc2a4...ef7674a. Read the comment docs.


Rewrite rule()

Rewrite rule() to remove imperative code

Got it, thx

Got it, thx

Closing this as it has been completed

Closing this as it has been completed


Security defaults: Authentication methods under Deployment considerations

Is the Authentication methods table under Deployment considerations current? I believe call to phone and text message to phone are available in other circumstances not listed there? (Eg: Available for Office 365 apps but not registered Azure apps)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfac0ecf-e5a9-c5ff-f8c2-ce27789708f5
Version Independent ID: 0f5e0cc9-a54f-a5c8-192d-d60a6a4db3ff
Content: Azure Active Directory security defaults
Content Source: articles/active-directory/fundamentals/concept-fundamentals-security-defaults.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@Staja
Thanks for your feedback! We will investigate and update as appropriate.

This article is only comparing Security Defaults and the equivalent Conditional Access policies. Per-user MFA is not a recommended path unless that is your only option and is covered in other articles.

#please-close


Implement Snackbar component

❓ What type of PR is this?

[ ] Refactor ♻
[x] Feature ✨
[ ] Bug Fix 🛠
[ ] Optimization 🚀
[ ] Documentation Update 📄
[ ] CI/CD 🤖

💬 Description

This PR includes a Snackbar component class with methods of creation and removal.
This is responsible for creating a snackbar in the DOM.
🎟 Related Tickets & Documents

Related Issue #1

🃏 Added/updated tests?
We encourage you to keep the code coverage percentage at 90% and above.

[x] Yes
[ ] No, because this is not necessary.
[ ] No, and this is why: I haven't write it yet.
[ ] I need help with writing tests

📚 Resources for Reviewers

See the documentation of Snackbar - https://github.com/free-bird-operation-project/quiz-manager/wiki/Snackbar

🌿 What branch would you like to merge this into?

feature/components
📷 [optional] What gif best describes this PR or how it makes you feel?

Just like the Button component, Snackbar's files were merged into one single file. There are so many changes happening while editing into a single file. Here are some:

using static parameters when queuing multiple messages
handling multiple messages gracefully

Impressive! ❤


Improve StaticArrays support

Versions

Bump DI to v0.6.11

DI extensions
ForwardDiff:

Add unprepared pushforward to avoid allocating similar(xdual) in the preparation object. This should make pushforward(f, backend, x, tx) alloc-free on SArray.
Pass custom tag to DerivativeConfig, JacobianConfig, GradientConfig and HessianConfig (this is an internal, like so much else).
Restrict unprepared shortcuts to the situation where we have both no chunksize and no tag (otherwise we need to put this stuff in the config anyway).

DI tests

Add ForwardDiff tests on static_scenarios()

DIT source

Modify benchmarks and type stability to make them work with SArrays (take mysimilar(res) instead of res, as in correctness tests)

Codecov Report
Attention: Patch coverage is 14.16667% with 103 lines in your changes missing coverage. Please review.

Project coverage is 16.04%. Comparing base (9ee81a4) to head (f2ad32c).

Files with missing lines
Patch %
Lines

...t/DifferentiationInterfaceForwardDiffExt/onearg.jl
11.68%
68 Missing :warning:

...t/DifferentiationInterfaceForwardDiffExt/twoarg.jl
2.85%
34 Missing :warning:

...ferentiationInterfaceForwardDiffExt/secondorder.jl
75.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (9ee81a4) and HEAD (f2ad32c). Click for more details.
HEAD has 121 uploads less than BASE

Flag
BASE (9ee81a4)
HEAD (f2ad32c)

DIT
24
0

DI
99
2

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #571       +/-   ##
===========================================
- Coverage   97.47%   16.04%   -81.44%
===========================================
  Files         108       76       -32
  Lines        4836     3135     -1701
===========================================
- Hits         4714      503     -4211
- Misses        122     2632     +2510

Flag
Coverage Δ

DI
16.04% <14.16%> (-82.62%)
:arrow_down:

DIT
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


support for Windows zip format

Support For artifact archiving in windows zip format

@Atul-source also please complete the DCO as described here

This PR fixes #35


Workflow

Ooo I love this direction, @ashygee! 😄 What if we kept the circles (instead of squares)? I think circles would align nicely with the Actions marketing icons and open circles are kind of a brand element for GitHub.

Before
After

@colebemis we discussed that but went with squares to differentiate from forking and branching

Ah, I see. That makes sense. Okay, I'm good with this new icon. Added to the viewer ✅


pull request for e2e test at 11/26/2016 15:56:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: support sidecar initContainers

This is a proposal to solve the  issue #381. If you approve this design, or if we choose another, I will write tests to cover the code.

Sidecar containers are a new type of containers that start among the Init containers, run through the lifecycle of the Pod and don’t block pod termination. Kubelet makes a best effort to keep them alive and running while other containers are running.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Thanks @ihor-hrytskiv for the PR and contribution! 😄
@hessjcg is OOO this week, but will review this first thing next week when he is back

Hi, nice work, @ihor-hrytskiv. Thank you for contributing.
I would like to suggest a bigger change: Instead of creating a new option in the custom resource for sidecar container, the operator should check the Kubernetes API version. The operator always use InitContainer sidecars if they are supported.
I will going to review the code in more detail over the next few days. I think there may an issue with the logic to maintain the list of ports in use. I'll more review comments soon.
-Jonathan

Hi, nice work, @ihor-hrytskiv. Thank you for contributing.
I would like to suggest a bigger change: Instead of creating a new option in the custom resource for sidecar container, the operator should check the Kubernetes API version. The operator always use InitContainer sidecars if they are supported.
I will review the code in more detail over the next few days. I think there may an issue with the logic to maintain the list of ports in use. I'll more review comments soon.
-Jonathan

Hi @hessjcg, thanks, I'll try to add this functionality as soon as possible

Hi @hessjcg, take a look please

Nice work. I pushed a commit that updates the integration tests so that they run on the k8s versions 1.28 and latest. I'm going to work on running the end-to-end tests now.

@hessjcg We no longer run integration tests on forks due to the security issues with the pull_request_target GitHub actions trigger we used to use.
So there are two options here:

Merge the PR and monitor integrations tests on the continuous build on main closely, revert or send follow up PR to fix tests.
Copy the forked branch to your own internal branch and have the tests run on it and then merge this PR and delete your copy branch,

@jackwotherspoon, Good point. I'm going to run the e2e tests in my dev environment, and if they pass, then I will merge and monitor the e2e tests on main.  I would like to build a way to run e2e tests on PRs again, but that will have to wait.

E2E tests passed: E2E Test Github Action. I'm going to approve and merge this PR.

@utmaks Thanks for raising this! 😄
Do you mind creating a new issue on this repo so we can get this addressed and fixed.
Thanks in advance.


sqlite: foreign key constraint checking

Enables foreign key constraint checking for SQLite.

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

@lnielsen please add BETTER or FIX. Thanks


Immer does not work properly with arrow function getter

🐛 Bug Report
If getter in class is arrow function (or bind in constructor), it's result is not handled with immer
Link to repro
https://codesandbox.io/s/immer-arrow-bug-usfy6z
To Reproduce
Steps to reproduce the behavior:
import { produce, immerable } from "immer";

class Dictionary<K extends string, V> {
  [immerable] = true;

  private _data: Record<K, V>;

  public constructor(data: Record<K, V>) {
    this._data = data;
  }

  public get = (key: K): V | undefined => { // <-- Note arrow function here
    return this._data[key];
  };
}

const dictionary1 = new Dictionary({ "1": ["foo"] });

const dictionary2 = produce(dictionary1, (draft) => {
  draft.get("1")?.push("bar");
});

console.log(dictionary1.get("1")); // --> ["foo", "bar"]
console.log(dictionary2.get("1")); // --> ["foo", "bar"]

Observed behavior
Prints
["foo", "bar"] // <-- original mutated
["foo", "bar"]

Expected behavior
Prints
["foo"] // <-- original not mutated
["foo", "bar"]

Environment
We only accept bug reports against the latest Immer version.

Immer version:
[x] I filed this report against the latest version of Immer
[x] Occurs with setUseProxies(true)
[x] Occurs with setUseProxies(false) (ES5 only)

when immer drafts an object, it doesn't run the constructor again. So the
function pointer between the old and new object is shared, it's the same
pointer. Since you forcibly point it to the original object, that is what
it will be operating upon, as that is what this refers to in that
specific function's context.
On Fri, Apr 14, 2023 at 7:28 PM Nikita Balikhin @.***>
wrote:

🐛 Bug Report
If getter in class is arrow function (or bind in constructor), it's
result is not handled with immer
Link to repro
https://codesandbox.io/s/immer-arrow-bug-usfy6z
To Reproduce
Steps to reproduce the behavior:
import { produce, immerable } from "immer";
class Dictionary<K extends string, V> {
[immerable] = true;
private _data: Record<K, V>;
public constructor(data: Record<K, V>) {
this._data = data;
}
public get = (key: K): V | undefined => { // <-- Note arrow function here
return this._data[key];
};}
const dictionary1 = new Dictionary({ "1": ["foo"] });
const dictionary2 = produce(dictionary1, (draft) => {
draft.get("1")?.push("bar");});
console.log(dictionary1.get("1")); // --> ["foo", "bar"]console.log(dictionary2.get("1")); // --> ["foo", "bar"]
Observed behavior
Prints
["foo", "bar"] // <-- original mutated["foo", "bar"]
Expected behavior
Prints
["foo"] // <-- original not mutated["foo", "bar"]
Environment
We only accept bug reports against the latest Immer version.

Immer version:
I filed this report against the latest version of Immer
Occurs with setUseProxies(true)
Occurs with setUseProxies(false) (ES5 only)

—
Reply to this email directly, view it on GitHub
https://github.com/immerjs/immer/issues/1033, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN4NBDNUPNCY4NZCIJF35DXBGCLHANCNFSM6AAAAAAW6WCMSU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Indicate that Portainer Agent is proprietary

I just found about the Portainer Agent being NOT Free (as in freedom) and open source software:

No, the agent is closed-source. Thanks for your will to help though.

(https://github.com/portainer/portainer/issues/2535#issuecomment-459065621)
Please document this visibly. I think the documentation is very deceptive:
Here it is said that the software is free but actually meaning it's free as in free beer but not as in freedom:
https://www.portainer.io/products-services/portainer-community-edition/
Portainer CE is 100% free and after more than 15 versions,
And here is documented why the agent should be used and why it's better than using direct Docker API but not a single word about it being closed source
https://www.portainer.io/installation/
https://portainer.readthedocs.io/en/stable/agent.html#agent
I think this is very unfortunate. I don't see why anybody would want to use a direct Docker API connection with more than one swarm node. IMO the agent should be available only to subscribed customers who want to buy proprietary extensions OR it being proprietary should be documented clearly (I don't think this is enough: https://portainer.readthedocs.io/en/stable/faq.html?highlight=closed#where-can-i-find-the-source-code-of-the-portainer-agent).
There seems to be some work on creating a truly free replacement for Portainer agent: https://github.com/wallezhang/portainer-agent

Hi @natlibfi-arlehiko
Thanks for the update, we'll update our website to make this information clearer.


Add support for 32-bit jump instruction

BPF_JA | BPF_JMP32
Documentation references:

https://github.com/ietf-wg-bpf/ebpf-docs/pull/42
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/Documentation/bpf/standardization/instruction-set.rst?id=245d4c40c09bd8d5a71640950eeb074880925b9a

Resolved by: https://github.com/iovisor/ubpf/pull/166


Simulation disappears when sensor-view is outside the screen

The bug
This bug happens on every robot that has a simulation, sensor-view and robot-view.
The simulation turns white, when the sensor-view is below the bottom of the screen and you try opening the robot-view.
The sensor-view can be too long or just be dragged below the bottom of the screen.
See screenshots
To Reproduce

open the simulation
open the sensor-view and drag it below the bottom of the screen
try opening the robot-view

Screenshots
The program (can be empty too)

Sensor-view goes below the bottom of the screen

after trying to open the robot-view

Additional context
This happens pretty quickly when adding too many variables or just two or more image variables, because every pixel value is displayed in the sensor-view when executing the code.
So it would be good thinking about an alternative way of displaying the variables or at least the image variables because they need a lot of space in the sensor-view

works


Double-free with FilePath in Xcode 13 beta

Originally reported as https://bugs.swift.org/browse/SR-14895 by @Frizlab.

FilePath crashes (double-free) with the following code
import Foundation
import System

if #available(macOS 12.0, *) {
	let relative = FilePath("Versions")
	_ = FilePath("/a/b/c").appending(relative.components)
	print(relative)
}

Demo repo: https://gitlab.com/frizlab-demo-projects/pathcrash
It does not crash when using SystemPackage version 0.0.2 instead of System (either in release or debug compilation mode).
Configuration: macOS 12.0 Beta (21A5268h) with Xcode 13.0 beta (13A5155e)

Note it only crashes when using the pre-built System framework in macOS 12 beta, not when using SystemPackage via SPM.

This is due to a bug in the compiler (it doesn't emit consuming annotations in swift interface files), which will hopefully be fixed soon.

Seems fixed in macOS 21A5304g, Xcode 13 beta 5 (13A5212g).
The issue can probably closed (I don’t seem to have the permission to do that).