more snapshot tests

Current coverage is 89.93% (diff: 100%)

Merging #1711 into master will not change coverage

@@             master      #1711   diff @@
==========================================
  Files            31         31
  Lines          1143       1143
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1028       1028
  Misses          115        115
  Partials          0          0

Powered by Codecov. Last update a1a3e55...2a04b5f


tls: bad certificate error emitted on server every time agent connects

Whenever a node connects to a server, it does so first using the OS CA bundle, before retrying with the cluster CA bundle. The original connection is expected to fail, as the cluster CA is not usually part of the OS CA bundle. This failure causes a log message that frequently causes users to think that there is something wrong with their cluster:
Sep 22 23:32:04 ip-172-31-35-30 rke2[12958]: time="2021-09-22T23:32:04Z" level=info msg="Cluster-Http-Server 2021/09/22 23:32:04 http: TLS handshake error from <IP_ADDRESS>:44528: remote error: tls: bad certificate"
We should make this log message debug only, and maybe emit a more specific message when agents connect to tell the user what's going on.

I dont think we can do that, since the TLS handshake happens before forwarding the request to the cacerts handler, then the listener will send this message, and there is no way to identify that early if this request is coming from a startup agent just a normal tls handshake error, of course we can still catch any handshake error by doing something like:
// Create a HTTP server with the registered request handlers, using logrus for logging
	server := http.Server{
		Handler:  handler,
		ErrorLog: log.New(&writerAdapter{logrus.StandardLogger().Writer()}, "Cluster-Http-Server ", log.LstdFlags),
	}

and then:
var tlsHandshakeError = "http: TLS handshake error"

func (a *writerAdapter) Write(data []byte) (int, error) {
	if strings.Contains(string(data), tlsHandshakeError) {
		logrus.Debugf("HANDSHAKE ERROR %v", string(data))
	}
	return a.Write(data)
}

but do we really want to turn off all TLS handshake errors and make them in debug log mode only? @brandond

I've literally never had this error help me with anything, and it causes a ton of confusion. If there is a legitimate problem with the client trusting the cluster CA certificate, that is reported client-side; also capturing it server-side isn't worth the added confusion.


Bad markdown code syntax

 Issue by leekelleher
Tuesday Nov 24, 2015 at 00:06 GMT
Originally opened as https://github.com/Wyamio/Wyam.Web/issues/10

Hey @daveaglick,
I was reading over the Concepts page: http://wyam.io/getting-started/concepts
and noticed the last paragraph had a few references of ILookupIDocument, which looked a bit strange. But it gets mentioned 3 times, so thought something didn't look right.
I checked the markdown for the page, and the code snippet looked fine, (and renders fine on GitHub)
ILookup<T, IDocument>

But on the wyam.io the raw HTML is rendered as...
ILookup<t, IDocument></t,>

I haven't looked into why, how or which module is causing the error. I just wanted to flag it up with you, (otherwise I'd forget).

 Comment by daveaglick
Tuesday Nov 24, 2015 at 02:31 GMT

Thanks for pointing this out! At first glance, I think it's and issue of the Markdown processor sometimes recognizing and escaping reserved HTML characters like < and sometimes not. Solution is probably to escape reserved HTML chars within the Markdown module after processing. I've opened an issue at wyamio/wyam#136 and will circle back here to verify once it's implemented.

 Comment by daveaglick
Saturday Dec 05, 2015 at 21:06 GMT

This looks like it's resolved in the most recent version of Wyam (which includes an update to the Markdown processor) and the new website (that will get pushed out whenever I finally get the next release nailed down). I'm going to close the issue, but I'll keep an eye out to make sure this doesn't resurface once the new site goes live. Thanks again!


The term "Component" is very confusing in the examples

Since components are a thing in Azure ML, the examples using this name to describe a job is very confusing.
Perhaps job or step would be a better term here.
jobs:
component_a:
type: command
component: file:./componentA.yml
inputs:
component_a_input:
type: uri_folder
path: ./data
outputs:
  component_a_output:
    mode: rw_mount

component_b:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a6583bb-6db4-fcff-8cd6-61cd8d378fb1
Version Independent ID: e0c00fbb-3ad5-d23d-1d0d-b21316a32938
Content: Create and run component-based ML pipelines (CLI) - Azure Machine Learning
Content Source: articles/machine-learning/how-to-create-component-pipelines-cli.md
Service: machine-learning
Sub-service: core
GitHub Login: @xiaoharper
Microsoft Alias: zhanxia

@Iyer-Narayan
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@xiaoharper
Can you please check and add your comments on this doc update request as applicable.

feedback taken. waiting for more customer signals before make change.

#Please- close

@Iyer-Narayan
We are going to close this thread, if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.
#Please-close


Can't reformat .shader files? or I am doing wrong step.

.shader files are already associated by default to ShaderLab syntax. ( see issue #2 )
But you can 'Configure file association' to overwrite that (see "file.associations" in your settings.json

I know, high light works right, auto complete check. but reformat? are u sure it works?

Hm, sorry I misunderstand you question... Yes, it would be interesting to have a format option for shader files. But ShaderLab syntax is owned by vscode

e.... Apologize for my pool English, thanks.


What files do I need to include cmakepp without downloading it?

One example shows how to download cmakepp when it is not available, directly from cmake. While that is very neat, I'm concerned about relying on github (and a working internet connection) for a build. Is there a release I can just drop in the project directory?

You can always clone the repo pointing at an specific stable commit, then symlink to it in your project. But I'm with you, having a release tag with a tarball would be great. I don't know if @toeb considers cmakepp stable enough to tag a release.

Hi,
sure you can download a release from the release section on the github page.  I have already created a couple.  There are compressed files containing the cmake source and a "compiled" version of cmakepp which just puts all functions into a single cmake file of about 1MB size which works standalone.
See https://github.com/toeb/cmakepp/releases
You can generate this single file yourself by cloning the repository cd to the cmakepp repository and typing
cmake -P cmakepp.cmake cmakepp_compile /path/to/target/file.cmake

This will compile all the functionality of cmakepp into the specified target file

Thanks!


Add "Kilroy Saves the Game"

Your checklist for this pull request
Author name
Author: @fisherjacobc (Jacob Fisher)

About your game
What is your game about?
My game is about a robot breaking down, and kilroy getting a replacement bolt to save the day.

How do you play your game?
For the most part there are instructions throughout the game, but movement is from WASD. Then, for selecting the "drawer" you press K. In the "practice field" map you also hae

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for your PR!

Very cool game! The starting animation and the existence of a cutscene and some plot makes it a great and unique game! If you're a teenager and you haven't received one, you are also eligible to receive a new Sprig device grant by filling out this form. Also if you haven’t already, feel free to join the HackClub slack and share your game and talk to other teenagers in the #sprig channel


Fix for: Cannot read property 'number' of undefined

PropTypes is no longer part of react and is removed in react 16.0.0-beta.5 (the version react-native 0.49.3 uses)

thanks! :)


Allow wrap model to hf format

Allow wrapping open_lm models so that transformers.AutoModelForCausalLM.from_pretrained works without registering Open_lm models, which allows our model to interface with HELM without substantial code changes.
Change Params to be serializable.

What about using https://github.com/mlfoundations/open_lm/pull/20

Don't think this mixin will work with our checkpoints as it requires a little bit of additional processing, and it doesn't work with transformers.AutoModelForCausalLM which is what HELM is using for huggingface models.

It seems like the discussion with Niels concluded 2 weeks ago. Are we waiting on anything to merge this?


ABSL_HAVE_ADDRESS_SANITIZER use in Tensorflow headers breaks build for MSVC 16.11 with /fsanitize=address

System information

TensorFlow installed from (source or binary): source, but does not really matter
TensorFlow version (use command below): 2.5

Describe the current behavior
When compiling in MSVC with address sanitizer TF enables code guarded by ABSL_HAVE_ADDRESS_SANITIZER.
That guarded code (header includes, calls of functions) break the compile.
I would guess this happens since till recently only clang and gcc had sanitizers, and I presume they support all the functionality TF uses.
Describe the expected behavior
Either ABSL_HAVE_ADDRESS_SANITIZER  should be fixed to be 1 only on gcc/clang or TF should use the ABSL_HAVE_ADDRESS_SANITIZER  only when gcc/clang are used. On MSVC this causes a ton of problems.
Alternatively ask MSFT if they plan to add all the headers soon, I doubt it, but if they do you can close as WONTFIX.
Contributing

Do you want to contribute a PR? (yes/no): no
Briefly describe your candidate solution(if contributing): I would discuss this with Abseil team and decide to either fix a macro in Abseil, or define a TF_SOMETHING macro that logically maps to ABSL_HAVE_ADDRESS_SANITIZER==1  &&  compiler_is_not_msvc

Standalone code to reproduce the issue
Include any header that will transitively include headers that use ABSL_HAVE_ADDRESS_SANITIZER  and compile on MSVC 16.11 with /fsanitize=address
Example of problematic header:
cpu\include\absl\base\internal\dynamic_annotations.h

This is not strictly related to TensforFlow - I get the same error when trying to use abseil directly in my project with ASan enabled on MSVC.

I've also reported this issue to Microsoft. Feel free to upvote the report.

@DoDoENT Thank you very much for taking time to report this and make MS issue.
Did you use the latest Abseil?
If so I can skip the request from @sushreebarsa  for testing 2.6 since if it is not fixed in latest Abseil it is for sure still broken in TF.

I'm using 202103.24.2. However, after hardcoding the include directory path in my CMakeLists.txt to C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\crt\src just to test the build in case MSVC added that path correctly to default includes, but abseil still doesn't build.
This time I get the following error:
absl/container/fixed_array.h(432): error C3646: '__attribute__': unknown override specifier

As far as I see, the line 432 of fixed_array.h is
   private:
    ABSL_ADDRESS_SANITIZER_REDZONE(redzone_begin_);  // line 432
    alignas(StorageElement) char buff_[sizeof(StorageElement[inline_elements])];
    ABSL_ADDRESS_SANITIZER_REDZONE(redzone_end_);

and ABSL_ADDRESS_SANITIZER_REDZONE is defined as
#define ABSL_ADDRESS_SANITIZER_REDZONE(name) \
  struct {                                   \
    char x[8] __attribute__((aligned(8)));   \
  } name

in case when ABSL_HAVE_ADDRESS_SANITIZER is defined (i.e. when ASan is detected). I think this attribute should be set differently with MSVC - ideally with alignas specifier, which is compiler agnostic.
I believe this is an abseil bug that needs to be resolved.

This is not related to TF, so I'd move we close this

I agree. I reported that directly to abseil.

When ABSL releases a new stable version with this patched, we'll patch it into TF


fix HTTP 406 bug importing to Elasticsearch 7.16

The import function misses JSON header against Elasticsearch 7.16
This request in Import() returns HTTP 406:

unexpected response code during index creation: 406

This request of each worker also returns HTTP 406:

PUT returned unexpected response: 406

Adding the JSON header fixes the issue.

Appreciated


Set the min-width value to 0 in order to limit the column width

Goal: Fix the columns from expanding outside of the row when using the flex grid. Fixes #9845
The current implementation was using initial instead of 0. The comment above suggests using 0 instead of initial.
Example: http://codepen.io/natewiebe13/pen/YZGaOy

Note: Build is failing due to an Access Denied from browserstack.

Makes sense to me.


Navigating away from the environments page and returning causes them to reload

Dev Home version
0.1201.466.0
Windows build number
10.0.26100.1
Other software
OS Build Version: 10.0.26100.1.amd64fre.ge_release.240331-1435
.NET Version: .NET 8.0.3
Steps to reproduce the bug
Leave the environment page after they are loaded, and upon return they need to be loaded again.
Expected result
I expected the environments to be present since they had been previously loaded.
Actual result
The environments had to be reloaded.

I had left the environments page, cloned the dev home repository and run the configuration, then when I returned to the environments page it had to reload. I'm hoping this information might help if the repro is elusive.


Bugfix for 'no-des' configure option

Building with "no-des" fails at crypto/cms/cms_kari.c
../libcrypto.a(cms_kari.o): In function `cms_RecipientInfo_kari_encrypt':
cms_kari.c:(.text+0x647): undefined reference to `EVP_des_ede3_wrap'

Using:
$ uname -s -r -v -m -p -i -o
Linux 2.6.32-573.18.1.el6.x86_64 #1 SMP Wed Jan 6 11:20:49 EST 2016 x86_64 x86_64 x86_64 GNU/Linux
~/sandbox/openssl-1.0.2g

The provided commit adds conditional directive and allows the build to complete.
RT openssl.org [#4432]

Fixed by 96bea0002b4. Closing this.


add a map in front page

Using leaflet.js I guess, we have to add a map in the sidebar of the ListPage that represent the lands of the list with map pins.

map is added using leaflet.js


500 error after update

when I log on admin area I receive this error
Argument 1 passed to App\Twig\SourceCodeExtension::getTemplateSource() must be an instance of Twig\TemplateWrapper, instance of __TwigTemplate_2cbf7fc5651a791395a7872583630b929ff0fd2ae3fa9cc8e5edc91b3a4ac77e given, called in /var/www/ ....
could you recheck in your side if this admin area it is working

TypeError
in src/Twig/SourceCodeExtension.php (line 95)


Reduce risk of uninit ac in luma_ac and encode_coeffs

luma_ac
In various pred_cfl_ac I've added checks that ac[..].len() must be exactly as long as needed, i.e. plane_bsize.width() * plane_bsize.height(). The multiplication got repetitive, so I've added plane_bsize.area().
Those prediction functions are in assembly. I haven't checked whether they initialize exactly plane_bsize.area() and nothing else, but I don't see a reason why they wouldn't, it would be a bug otherwise. Anyway, it's not a safety issue in pratice, since the allocated memory behind ac is the same size as before.
encode_coeffs
get_nz_map_contexts initializes context up to eob which is u16. Other code used usize for eob. To be type-safe sure it can't be longer than u16 anywhere (therefore reading past what get_nz_map_contexts could init), I've changed eob to be consistently u16 everywhere. It's never more than 1024 in reality.
get_nz_map_contexts used to write coeffs[scan[i]], but that had two issues:

It could not guarantee that all coeffs are initialized and contiguous to make an initialized slice.
It was unnecessary performance cost. Writing at scan's positions was a needless step, because they were also always read as coeffs[scan[i]]. Since all uses of the coeffs wanted a coefficient for scan[i], I've made them get it from coeffs[i] rather than coeffs[scan[i]]. scan acted only as an unnecessary shuffle. This is faster, guarantees a contiguous slice, and does not change the behavior.

It looks very nice, but I'd like to have @barrbrain opinion :)

Thanks for x86 fixes. As you can see, I'm non ARM, and conditionally-compiled x86 is a blind spot for me.

I don't expect this to change outputs at all. Hopefully tests already cover this, but you can verify by running compression and check file hashes before/after.

maybe doing a quick AWCY run is a good idea too:)

Unfortunately, we have build issues on AWCY presently.
I have confirmed unchanged output on  test sequence at default settings:
ffmpeg -loglevel error -f lavfi -i testsrc=duration=10:size=320x240:rate=30 \
  -pix_fmt yuv420p -f yuv4mpegpipe - | rav1e -o >(sha256sum) -y -


perf(codegen): u32 indexes in LineOffsetTable for source maps

#4641  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Revised #140 - TypeScript types should allow optional options on follow

Revises #140 by @brabster with support for additional function overrides.

Fixes #139.
Thanks to  @brabster for highlighting this issue and raising the initial PR.

You're welcome, thanks for revising & accepting it!


Outdated FAQ entry reg. free download of keys via mobile data?

Where to find the issue

Describe the issue

Hoping that this is the correct context to submit a ticket for your FAQ
Your current FAQ states

Important: Mobile/cellular data that are transmitted during the usage of Corona-Warn-App is free of charge and will not be deducted from your data plan!

However, since cwa 1.7 the frequency of DEK key downloads was increased to a 4-hour-schedule.
According to this comment

the current agreement includes one update per day in the so-called zero rating

Is this true? If yes, the FAQ entry needs to be corrected.
Suggested change

Clarify which of the conflicting informations is true. Ensure that the FAQ has the latest and true information.

Since hourly keys will only be downloaded if connected to WiFi (because of this agreement), I don't think this needs to be update.
If CWA downloads the one daily key via mobile data, the user will not be charged.

@ndegendogo, @Ein-Tim
Does this solve this issue: https://www.coronawarn.app/en/faq/#risk_update_24? Admittedly, there is a lot of information in the FAQs and it is not so easy to put it in an organized way. DS

Corona-Warn-App Open Source Team

@ndegendogo, and yes, this is the correct place to discuss FAQs. Thanks! DS

Since hourly keys will only be downloaded if connected to WiFi

Is this really true?
See also this comment by @sin-azucar

apparently it's trying to download something

@ndegendogo,

Q: Hourly keys will only be downloaded if connected to WiFi?
A: This seems to be the current implementation, however, will bring this question to the developers in order to confirm.

Best wishes,
DS

Corona-Warn-App Open Source Team

@ndegendogo
I am 100% sure the App does not download hourly files via Mobile Data.
See: https://github.com/corona-warn-app/cwa-app-ios/pull/1468#issuecomment-722449837

Thanks @dsarkar

@dsarkar
Did the devs give you an answer?

@Ein-Tim, @ndegendogo, will come back to you. I think the answer I got  is not directly related to your question. It was confirmed that via mobil data only one update is made per day. Will clarify and re-phrase the question again these days. Thanks for your patience. DS

@ndegendogo
https://www.coronawarn.app/en/faq/results/#no_risk_update_ios "[Apple/iOS]: My risk status hasn't been updated for over a day. An internet connection was available, what's wrong?" says:
"Important: Mobile/cellular data that are transmitted during the usage of Corona-Warn-App is free of charge and will not be deducted from your data plan!"

https://www.coronawarn.app/en/faq/results/#risk_update_24 "How often is the risk status updated?" says:
"Since CWA version 1.7, exposure checks are run up to 6 times per day when a Wi-Fi connection is present. The repeated daily check is performed automatically. While using mobile data, the check is only performed once every 24 hours due to the zero rating commitment of the network providers."

https://www.coronawarn.app/en/faq/results/#mobile_data_costs "When I'm not connected to a Wi-Fi network, will I be charged for any mobile data transmitted via the app?"
confirms all this. In addition @thomasaugsten stated in https://github.com/corona-warn-app/cwa-app-android/issues/4753#issuecomment-1050696149 about 4 weeks ago
"Traffic of the CWA are free of charge on mobile data plans."

I can't see any discrepancies. Do you still think that something needs to be changed in the FAQs?

@MikeMcC399 you are right. The FAQ has improved a lot since I submitted this ticket.
Closing as resolved.


HttpClient doesn' t transfer any data if chunkedTransferEncoding = false and contentLengthisn't set

Dart 2.7.0
Flutter on Android

I needed to make an HTTP Post request without data chuncking.
On my first attempts I didn't set the contentLength  because I didn't had to do it with chunked transfer so far.
The request was executed but with an empty body.
After setting the length it worked like here:
      final request = await client.postUrl(Uri.parse(endPointUrl));
      request.headers.chunkedTransferEncoding = false;
      request.headers.contentType = ContentType.json;
      request.headers.set('accept-encoding', 'gzip,deflate');
      var content = utf8.encode(asJson);
      request.contentLength = content.length;
      request.add(content = content);

      final response = await request.close();

As it took me quite some time to figure this out, I see this either as  a bug, because the chunked version doesn't behave like the non chunked one without throwing any assert or exeception, or at least there should be a hint in the API docs of request.headers.chunkedTransferEncoding so that people know that they have to set a length.

Hi, this behavior is described in Section 4.3 of the HTTP/1.1 specification (RFC 2616):

The presence of a message-body in a request is signaled by the inclusion of a Content-Length or Transfer-Encoding header field in the request's message-headers. A message-body MUST NOT be included in a request if the specification of the request method (section 5.1.1) does not allow sending an entity-body in requests.

Based on this language, it seems sensible that Dart would not send a body in this case. You must either use a transfer encoding or set a content length.
The other part of this is what should happen one tries to send a body when no body is allowed (neither a transfer encoding nor a content length). It seems here that Dart silently ignores the attempt. It could potentially throw an exception. Alternatively some appropriate language could be added to the documentation, although we don't want to describe every aspect of the HTTP/1.1 specification.
Another case would be if the content-length was set, and too much data is attempted sent, or the sink is closed too early. What happens then?

I only wonder why this is allowed in chunked transfer? I guess an assert in case you select parameter values that don't make sense  would be helpful.


Bewest/fix cli

provide new tool for determine-basal with --switch enabled args.

Some usage notes: most of these produce errors in ways I find helpful.
 2362  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json
 2363  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  bad
 2364  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  meals.json
 2365  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  bad meals.json
 2366  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --auto-sens bad meals.json
 2367  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --no-auto-sens bad meals.json
 2368  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --no-auto-sens meals.json
 2369  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --no-auto-sens
 2370  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --no-auto-sens meals.json
 2371  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --no-auto-sens bad meals.json
 2372  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --auto-sens bad meals.json
 2373  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --auto-sens model.json  meals.json
 2374  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --auto-sens model.json
 2375  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  -h
 2376  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  --help
 2377  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json -h
 2378  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json sdfkj
 2379  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json glucose.json
 2380  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  -ok
 2381  openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json
 2382  oref0-determine-basal -h oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json
 2383  oref0-determine-basal  oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json
 2384  oref0-determine-basal  oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json   -h
 2385  oref0-determine-basal  -h monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json
 2386  oref0-determine-basal  "-h" monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json
 2387  oref0-determine-basal  "help" monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json

It also now aggregates all errors, here's an example:
$ openaps use determine-basal shell oref0-monitor/iob.json monitor/temp-basal-status.json glucose.json oref0-monitor/profile.json  missing  alsomissing
Optional feature Meal Assist enabled, but could not read required meal data.
Optional feature Auto Sensitivity enabled.  Could not find specified auto-sens: missing
{ [Error: ENOENT: no such file or directory, open 'missing'] errno: -2, code: 'ENOENT', syscall: 'open', path: 'missing' }
BG data is too old, or clock set incorrectly Wed May 04 2016 06:23:12 GMT-0700 (PDT) vs Wed May 04 2016 21:00:08 GMT-0700 (PDT)
[
  {
    "msg": "Optional feature Meal Assist enabled, but could not read required meal data.",
    "file": "alsomissing",
    "error": {
      "syscall": "open",
      "errno": -2,
      "code": "ENOENT",
      "path": "alsomissing"
    }
  },
  {
    "msg": "Optional feature Auto Sensitivity enabled.  Could not find specified auto-sens: missing",
    "error": {
      "syscall": "open",
      "errno": -2,
      "code": "ENOENT",
      "path": "missing"
    }
  },
  {
    "msg": "BG data is too old, or clock set incorrectly Wed May 04 2016 06:23:12 GMT-0700 (PDT) vs Wed May 04 2016 21:00:08 GMT-0700 (PDT)"
  }
]

Looking for reviewers?  @mddub.

For adding a switch for non-active neutral temps:
diff --git a/bin/oref0-determine-basal.js b/bin/oref0-dete
index dcc7ee0..03fc432 100755
--- a/bin/oref0-determine-basal.js
+++ b/bin/oref0-determine-basal.js
@@ -27,6 +27,12 @@ if (!module.parent) {
         default: true

       })
+      .option('always-neutral-temp', {
+        alias: 't',
+        describe: "always set temps (to current profile i
+        default: true
+
+      })

This would allow the following use/report:
openaps use determine-basal shell --no-always-neutral-temp oref0-monitor/iob.json monitor/temp-basal-status.json monitor/glucose.json oref0-monitor/profile.json

openaps report add oref0-enacted/enacted-temp-basal.json JSON determine-basal shell --no-always-neutral-temp oref0-monitor/iob.json monitor/temp-basal-status.json monitor/glucose.json oref0-monitor/profile.js

In general, any use can be saved as a report by changing the word use into report add file.json JSON, this includes any switches or other arguments given to the use itself.

This is performing quite well and to my knowledge is needed to release dev to master.  I'd like to get this merged tonight/tomorrow, and do a release of oref0 by Monday.

👍 Besides my nits this looks great. Huge improvement for introducing options in the future too.

LGTM as well.  👍 to merge this once you've addressed @mddub's comments or decided not to.

For now after looking at it again, I'd prefer not to introduce another variable.  Might handle in dev.


Joining the organisation

Description
A brief description of the question or issue:
Opening this issue to join your esteemed organisation.

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your github profile for everyone else to see, you can do this by finding your name in the github organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practicing:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

Thank you so much @eddiejaoude :)


sample code throws an error

hello, your sample code throws an error
{
	"resource": "/E:/Flutter/Nicolas Zein/Projects/Zandu/zandu-wholesale-mobileclient-enduser-0003/lib/utils/app_rating.dart",
	"owner": "dart",
	"code": "missing_function_parameters",
	"severity": 8,
	"message": "Functions must have an explicit list of parameters.\nTry adding a parameter list.",
	"source": "dart",
	"startLineNumber": 16,
	"startColumn": 1,
	"endLineNumber": 16,
	"endColumn": 11,
	"tags": []
}

also this:
{
	"resource": "/E:/Flutter/Nicolas Zein/Projects/Zandu/zandu-wholesale-mobileclient-enduser-0003/lib/utils/app_rating.dart",
	"owner": "dart",
	"code": "expected_executable",
	"severity": 8,
	"message": "Expected a method, getter, setter or operator declaration.\nThis appears to be incomplete code. Try removing it or completing it.",
	"source": "dart",
	"startLineNumber": 16,
	"startColumn": 11,
	"endLineNumber": 16,
	"endColumn": 12,
	"tags": []
}

It's possible, the reason is that I've put all parameters just to expose them. If you want a working example, here is it :
https://github.com/Skyost/rate_my_app/blob/master/example/lib/main.dart#L65


Export to Pelican

This allows you to export your JRNL to Pelican formatted Markdown. The exported files have the necessary metadata at the top, and then contain the body of the entry. Files are saved with .md extension.
These can then be used as source content to generate the files of a Pelican blog.
Example file:
Title: RAM?
Date: 2013-07-30 12:02:00
Tags: computer, RAM

8GB of RAM for my desktop??...

Recreated against the 2.0-rc1 branch as #347. (This is against the master branch, so based on 1.9.6). Closing this.


fixed errors for 8.14 & warnings for 8.13; broke things for <8.12

This PR fixes a couple minor issues that were preventing make all from succeeding with Coq v8.14. I also made a few edits to reduce warnings in v8.13 (which involved adding #[export] in front of Hints). There are still warnings when compiling with 8.14 (which can be fixed using the same approach), but this breaks things for v8.13.
Which versions of Coq do you want to "support"? The README says 8.10-8.12. The current code will compile for 8.12, 8.13, 8.14. While testing, I found out that I broke things for versions < 8.12 with my call to Rtrigo_facts.cos_pi_minus in this commit (sorry!!). Do you want me to remove this from the repo so you're still compatible with versions 8.10 and 8.11?
If you don't want to support 8.13/8.14, then you can reject this PR. Just let me know what you decide because it impacts which versions I'll support for SQIR :)

I think we should aim to stay up-to-date with Coq. However, we want to make sure that all of our attendant repos (e.g., VQO, Shor's) still build with this new version, too. Have you checked that?

I'll merge this.
A few notes:

We always want to support the current version of Coq. 8.12 to 8.14 is fine. (I'm hoping we can update to 8.15 when it comes out without breaking 8.12 support.)
These changes should be in quantumlib. Hopefully we can adjust the external libraries in SQIR and QWIRE to use quantumlib this week; VyZX already uses it. Are these changes reflected there?
We should also probably flag commits that correspond either to specific papers or the last version of the repo to compile with Coq 8.xx.
I'll update the README.


Using raw db connection for creating object

Hi Xorm team,
Firstly thanks for writing this awesome ORM tool! Golang is still in its initial stages so its good to see some mature code out there!
I am using Google's Cloud offering and they have a CloudSql proxy (which talks mysql internally). Although since your constructor does not take an actual db object (and say that it's SQL) I cannot use xorm unless I deconstruct either yours or cloudsql proxy code.
This is how I currently instantiate an object in my code:
  config.Addr = instanceName                                                                                config.User = dbUser                                                                                config.Passwd = dbPass                                                                                config.DBName = dbName                                                                                db, err = cloudsqldialer.DialCfg(&config)
The code for cloudsql is here: github.com/GoogleCloudPlatform/cloudsql-proxy
Any help appreciated

I think maybe you can copy mysql dialect and change something to do that. XORM needs to know the SQL syntax which you are using, MySQL or Postgres. So a raw *DB is not enough. But if XORM know the raw *DB and the it's MySQL syntax it will work. But it also has some work to do.


AAS-Environment exited with failure on docker start up

I clone the repo (https://github.com/eclipse-basyx/basyx-java-server-sdk/tree/main/examples) with the examples and only run the docker-compose up command. But then the aas-environment exited with the following code
2023-11-28 13:40:36 Loaded property file: file:application.properties
2023-11-28 13:40:36 Loaded property file: jar:file:/application/basyxExecutable.jar!/BOOT-INF/classes!/application.properties
2023-11-28 13:40:36   ____           _____
2023-11-28 13:40:36  |  _ \         / ____|
2023-11-28 13:40:36  | |_) |  __ _ | (___   _   _ __  __
2023-11-28 13:40:36  |  _ <  / _` | \___ \ | | | |\ \/ /
2023-11-28 13:40:36  | |_) || (_| | ____) || |_| | >  <
2023-11-28 13:40:36  |____/  \__,_||_____/  \__, |/_/\_\
2023-11-28 13:40:36 ======================== __/ |======
2023-11-28 13:40:36 AAS Environment         |___/
2023-11-28 13:40:36 2.0.0-PREVIEW
2023-11-28 13:40:36
2023-11-28 13:40:36 2023-11-28 12:40:36.430  INFO 1 --- [           main] o.e.d.b.a.c.AasEnvironmentComponent      : Starting AasEnvironmentComponent v2.0.0-SNAPSHOT using Java 11.0.19 on 4d4a1825ee0b with PID 1 (/application/basyxExecutable.jar started by nobody in /application)
2023-11-28 13:40:36 2023-11-28 12:40:36.435  INFO 1 --- [           main] o.e.d.b.a.c.AasEnvironmentComponent      : No active profile set, falling back to 1 default profile: "default"
2023-11-28 13:40:38 2023-11-28 12:40:38.119  WARN 1 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.support.BeanDefinitionOverrideException: Invalid bean definition with name 'getSubmodelServiceFactory' defined in class path resource [org/eclipse/digitaltwin/basyx/submodelrepository/MongoDBSubmodelRepositoryConfiguration.class]: Cannot register bean definition [Root bean: class [null]; scope=; abstract=false; lazyInit=null; autowireMode=3; dependencyCheck=0; autowireCandidate=true; primary=false; factoryBeanName=mongoDBSubmodelRepositoryConfiguration; factoryMethodName=getSubmodelServiceFactory; initMethodName=null; destroyMethodName=(inferred); defined in class path resource [org/eclipse/digitaltwin/basyx/submodelrepository/MongoDBSubmodelRepositoryConfiguration.class]] for bean 'getSubmodelServiceFactory': There is already [Root bean: class [null]; scope=; abstract=false; lazyInit=null; autowireMode=3; dependencyCheck=0; autowireCandidate=true; primary=true; factoryBeanName=submodelRepositoryConfiguration; factoryMethodName=getSubmodelServiceFactory; initMethodName=null; destroyMethodName=(inferred); defined in class path resource [org/eclipse/digitaltwin/basyx/submodelrepository/component/SubmodelRepositoryConfiguration.class]] bound.
2023-11-28 13:40:38 2023-11-28 12:40:38.156  INFO 1 --- [           main] ConditionEvaluationReportLoggingListener :
2023-11-28 13:40:38
2023-11-28 13:40:38 Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2023-11-28 13:40:38 2023-11-28 12:40:38.230 ERROR 1 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   :
2023-11-28 13:40:38
2023-11-28 13:40:38 ***************************
2023-11-28 13:40:38 APPLICATION FAILED TO START
2023-11-28 13:40:38 ***************************
2023-11-28 13:40:38
2023-11-28 13:40:38 Description:
2023-11-28 13:40:38
2023-11-28 13:40:38 The bean 'getSubmodelServiceFactory', defined in class path resource [org/eclipse/digitaltwin/basyx/submodelrepository/MongoDBSubmodelRepositoryConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [org/eclipse/digitaltwin/basyx/submodelrepository/component/SubmodelRepositoryConfiguration.class] and overriding is disabled.
2023-11-28 13:40:38
2023-11-28 13:40:38 Action:
2023-11-28 13:40:38
2023-11-28 13:40:38 Consider renaming one of the beans or enabling overriding by setting spring.main.allow-bean-definition-overriding=true
2023-11-28 13:40:38

I had used the newest version. But I deleted all images after your message and run the docker command again and now it works.


Sphinx configuration improvements

Small improvements of the Sphinx configuration:

Delete the autodoc configuration part (we are using autoapi)
Add some Intersphinx mappings
Delete the warning for the roseau.load_flow_engine.cy_engine module which is not found when generating the documentation.

@alihamdan By the way, the command make linkcheck already exists and checks all the external links found in the documentation. We should run it sometimes to ensure the documentation is up-to-date.

There is still a bug in sphinx-autoapi readthedocs/sphinx-autoapi#473 that needs to be solved to have a better documentation (ie. API doc similar to the "API Reference" section for each model)


Embed block: not working for non-pretty permalinks

Bug Description
As @kkalarickal just found out, the embed block does not work for URLs with non-pretty permalinks. The reason for that is a lack of URL-encoding.
While investigating this, I also realized that embedding local stories with plain permalinks did cause extra HTTP requests, even though we have some logic in place to avoid that (using url_to_postid()). Turns out url_to_postid() does not recognize plain permalinks like https://example.com/?web-story=my-story. It only looks for https://example.com/?p=123 and pretty permalinks.
Expected Behaviour
Embedding local stories with plain permalinks should work, and should not cause an extra HTTP request.
Steps to Reproduce

Disable pretty permalinks in the settings
Add new embed block in Gutenberg and try to embed local story

Screenshots

Additional Context

Plugin Version: 1.1.1
WordPress Version: 5.6
Operating System: macOS
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Finding that I have to select the EMBED button twice:
https://share.getcloudapp.com/KoullEgk

@csossi thanks for testing! I think you've uncovered another issue here that is unrelated and needs to be fixed separately of this. Since it is otherwise working as intended, that's a sign this change here does what it has to.

@csossi I am able to reproduce this error, but it also happens with pretty permalinks, so definitely not related.

The reason is testing with a story that has neither title nor poster.

Filed here: #5617

thanks for the info, @swissspidy
Verified in QA


Dazing Spell

https://www.d20pfsrd.com/feats/metamagic-feats/dazing-spell-metamagic/

Opted not to do this.


Checksum generation in pe.c version 3.7.0

Hi,
I think the generate_checksum may be wrong, I got the right checksum when i changed line 2038 in pe.c:
for (i = 0; i <= pe->data_size / 4; i++)
to (removing the /4):
for (i = 0; i <= pe->data_size ; i++)
and also the following line 2046:
if (4 * i + 4 < pe->data_size)
to (adding the equals)
if (4 * i + 4 <= pe->data_size)

If you do that you will have an out-of-bounds access in line 2048. Can you explain more about your case? Can you share the file for which the checksum is calculated wrongly?

Hi,
You're right that is not a proper fix.
I replicated the issue however, the following file is consent.exe in the windows directory:
Sha1 - d90de430940f1afd9d9a26a1b14b67289e0b095c
Dumpbin /headers tells me the checksum is 0x1e51f
Using the python pefile library to generate the checksum also returns 0x1e51f
However in Yara the generated checksum is 0x1e435

Fixed in 21d82ff7ddaf7c01e9b3a7364f4cb3820870bcb2

Great! Thanks for fixing it so quickly.


[semver:minor] Add test job

Add a job and command for the test workflow.
Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

The [semver:FOO] is a pipeline trigger in the Orb builder pipeline.


'Start Capture' button does nothing when clicked

I have successfully installed using docker-compose on Alpine linux 3.14. Had to manually create a user using the command line due to CGNAT of my ISP, seems to have problems with e-mail.
The problem I have is: the 'Start Capture' button on the webpage for capturing URLs does nothing when I click on it... I've tried three browsers, and I've tried the browsers on the server.
Thanks

Check your browser console for messages about failing to access something. I had to fix several NAT issues before capture started working. Conifer seems to use a lot of ports.
 (Including remote browser management ports?)

STUN/TURN/ICE is still broken for me somwhere per said console messages. That's probaby why my audio forwarding isn't working. I'm not sure yet if this hints at more fundamental NAT issues.


Logo url of betteruptime_status_page not persitent in state

Hi,
Using the betteruptime_status_page resource, when specifying a logo_url value - it keeps reappearing in the plan/apply. I suspect this is a bug where it's not being written to state after apply. Terraform wants to change the resource and add the value - as it thinks it's not currently configured. The change does proceed to be applied and is in effect in Better Stack.
Fixed it for now by using lifecycle policy;
lifecycle {
  ignore_changes = [
    logo_url
  ]
}

seems to have been reported a while ago; https://github.com/BetterStackHQ/terraform-provider-better-uptime/issues/74

Hello @fancybear-dev, thank you for reporting this, for your patience and sharing a workaround 🙌
We've fixed the issue with logo_url being sent of every terraform apply. There's no need to update your Terraform provider, we've managed to fix this on the API level.
Hope this helps 🚀