[$500] Desktop - Login - Magic code is sent twice or more after double tapping "Enter" button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Log out of NewDot
Enter an email in the login form that you have access to
Press the enter key on the keyboard two times quickly
Navigate to your email inbox
Verify that the magic code is sent only once

Expected Result:
The magic code is sent only once
Actual Result:
Magic code is sent twice or more after quickly double tapping "Enter" button
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/883da70c-b7dc-4ef8-927c-e14a169c1a10
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01837f964a8d992695
Upwork Job ID:<PHONE_NUMBER>883385344
Last Price Increase: 2023-12-19

Proposal
Please re-state the problem that we are trying to solve in this issue.
Desktop - Login - Magic code is sent twice or more after double tapping "Enter" button
What is the root cause of that problem?
We don't have any disable function until navigate to verifyCodePage
What changes do you think we should make in order to solve the problem?

We need to cover validateAndSubmitForm with singleExecution

onSubmit={singleExecution(validateAndSubmitForm)}

onSubmitEditing={singleExecution(validateAndSubmitForm)}

we need to add one condition.

if (props.network.isOffline || props.account.isLoading || isExecuting) {

https://github.com/Expensify/App/blob/48b5a29f33ca4cfa8a0b75361f68f6df83455613/src/pages/signin/LoginForm/BaseLoginForm.js#L168
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Login - Magic code is sent twice or more after double tapping "Enter" button
What is the root cause of that problem?
The root cause is that when the user rapidly presses the submit button two or three times, the validateAndSubmitForm function is invoked two or three times consecutively in src/pages/signin/LoginForm/BaseLoginForm.js
What changes do you think we should make in order to solve the problem?
In the context of the BaseLoginForm component, the utilization of _.debounce proves beneficial in preventing multiple submissions of the form in rapid succession. The useCallback hook serves to memoize a function, ensuring that the same function instance is returned for each render cycle. This memoization strategy helps mitigate performance issues stemming from the unnecessary recreation of functions during each render.
Through the synergistic application of useDebounce and useCallback, we adeptly address performance concerns arising from both swift, consecutive events and the avoidance of superfluous function recreations.
In src/pages/signin/LoginForm/BaseLoginForm.js, change to -
<FormAlertWithSubmitButton
    ...
    onSubmit={_.debounce(
        useCallback(() => validateAndSubmitForm(), []),
        400,
    )}
    ...
>

What alternative solutions did you explore? (Optional)

@aimane-chnaif
My proposal would prudently manage this phenomenon wherever it occurs.

okay. I will update my prev proposal soon.
Thank you for your feedback.

@aimane-chnaif - can you take a look please?

Proposal
Please re-state the problem that we are trying to solve in this issue.
On the login page, enter an email address and double tap enter key quickly, magic code is sent twice instead of once.
What is the root cause of that problem?
The validateAndSubmitForm function is being called twice because after the user clicks signin the props.account.isLoading is undefined and the if condition is skipped and another request is made when the expected would be to return on the if condition.
https://github.com/Expensify/App/blob/d376603d456f1023b7ea738fb6c3e78842eb17e1/src/pages/signin/LoginForm/BaseLoginForm.js#L168
The props.account.isLoading is only set to true after the api call BeginSignIn.
https://github.com/Expensify/App/blob/ae25d9a1eec32c32079306d30ec5017f158f4322/src/libs/actions/Session/index.ts#L284
What changes do you think we should make in order to solve the problem?
Need to add useRef variable for holding isLoading status and then set the variable to true after the if condition checking whether the isLoading status is true.
https://github.com/Expensify/App/blob/d376603d456f1023b7ea738fb6c3e78842eb17e1/src/pages/signin/LoginForm/BaseLoginForm.js#L94
const isLoading = useRef(false);

https://github.com/Expensify/App/blob/d376603d456f1023b7ea738fb6c3e78842eb17e1/src/pages/signin/LoginForm/BaseLoginForm.js#L168
if (props.network.isOffline || props.account.isLoading || isLoading.current) {
        return;
}
isLoading.current = true;

In the dependency array of useEffect add props.account.isLoading
https://github.com/Expensify/App/blob/d376603d456f1023b7ea738fb6c3e78842eb17e1/src/pages/signin/LoginForm/BaseLoginForm.js#L222
Then after the first if condition add another if condition
if(props.account.isLoading === false)
{
        isLoading.current = false;
}

What alternative solutions did you explore? (Optional)

@aimane-chnaif I agree the issue is also occurring on the web. Please review proposal.

@aimane-chnaif I have been able to reproduce the issue reliably on the web.

@aimane-chnaif The approach in this proposal was also suggested in this issue. But it was discarded by C+. Please have a look at comments in mentioned issue.

@aimane-chnaif I tested using the useSingleExecution hook and the issue is not resolved, still getting multiple emails. As explained by the C+ https://github.com/Expensify/App/issues/30508#issuecomment-1783114071, the useSingleExecution hook was removed on the rnw-upgrade PR for web and also the hook is only used for native issues.

@aimane-chnaif I can confirm the issue can be reliably reproduced. consider the useRef approach explained in the proposal. The useRef is reliably updated and catches the second tap.

@aimane-chnaif Please share any concerns or feedback on the useRef approach or if you have any other ideas I can try them out as well.

Waiting on @aimane-chnaif to review.

@aimane-chnaif if done correctly in android, user is able to get 3 emails instead of 1. The issue is testable on android.

@aimane-chnaif I tested the proposal on android and the useRef approach resolves the issue on android. No change was needed to the proposal, I have mentioned point in proposal that the issue is also resolved on android.

@aimane-chnaif Thanks. I understand I need to wait to get assigned before preparing PR.

Thanks @aimane-chnaif!
Hired @sourcecodedeveloper

@aimane-chnaif PR is ready for review

@aimane-chnaif - I'll release payment once the checks have been completed.

Bump @aimane-chnaif - I can pay the $500 once the checklist has been completed.


Issue 18

Here's the pull request to work off of. Currently, removed a few TODOs.

Oops, the commit message has the wrong issue number. One thing I would like to address is the minimum and maximum wavelength constants. Do we have any idea what those should be?

@heidiaclayton In this message I found that the intersection of wavelength ranges in the USGS Digital Spectral Library 06 and our AVIRIS image is [383.150, 2505.0363678] nm. We might have to change this once we look at the ASTER data or at more AVIRIS images.

@browtayl I'm having some issues figuring out what parameters to use for a lot of these functions (e.g. the eigenvectors). Lets set up a time to meet on this?

@heidiaclayton I'll be pretty wiped out Thursday due to the early morning lecture and a miderm, so I do not expect to be able to meet before Friday. I can stay late Friday if necessary, and I may be available online before then.
I don't think you have to worry about the eigenvectors, however. I believe the parameters to PrincipalComponents.reduce in the line in question are optional. That is, I assumed it would only be necessary to specify the num of vectors to keep (i.e., NUMBER_OF_LAYERS) and not worry about the eig indices or fraction of variance. You may want to look at the library source to verify that positional argument N is the same as keyword argument num, in which case you could just get rid of the question marks. I left them as a reminder to make sure the call was correct. You might want to try the call interactively to make sure that it works.

btw the docstrings are looking really good.

+1 docs strings are dynamite.

@heidiaclayton quick thought: when the time comes, you might consider cropping the image down to a more manageable size (e.g., 100x100x432 or whatever) so you can debug classification more efficiently. i'm pretty sure spectral has a way to choose a subset of an image and output it to a file. let me know if you'd like me to look into this.

@heidiaclayton please update the pull request to accommodate the new directory structure. Thank you and sorry for the inconvenience.

@lewismc rebased onto master.

@lewismc we got together and got some code regarding normalizing together. I'll be working on it this week.

@heidi here's something to address the TODO about unit conversion:
>>> img.metadata.get('wavelength units')
u'Nanometers'

note that it is arguably more convenient to make the units of the images consistent with the spectral library rather than vice versa.

@lewismc Alright, I've gotten rid of most of the '???'s in the code. There's just a couple left that I'm not sure what to do with.
There's an argument to LinearTransform that I'm not sure what to do about.
 A (:class:~numpy.ndarrray`):
            An (J,K) array to be applied to length-K targets.

`
There's also an argument to the creation of a PerceptronClassifier object, which inherits from Perceptron.
`            layers (sequence of integers):
            A list specifying the network structure. `layers`[0] is the number
            of inputs. `layers`[-1] is the number of perceptron outputs.
            `layers`[1: -1] are the numbers of units in the hidden layers.

`

@heidiaclayton As noted previously we may not need the linear transformation in line 192 if we are not doing any special processing.
But to answer your question, mathematically a linear transformation is equivalent to its transformation matrix. That is, the transformation T that takes matrices of dimension M to matrices of dimension N is equivalent to left multiplication by some matrix a. In other words, T : M → N | T(m) = am.
If we wanted to reduce the dimensions, or flip the pixel, or multiply certain rows by certain values (for atmospheric preprocessing, for example), then you would just feed some matrix a into the LinearTransform object — or just use NumPy's built-in matrix multiplication for a * pixel.
A matrix a could be be generated from the calibration file, and might look something like this:
w 0 0 0
0 x 0 0
0 0 y 0
0 0 0 z

Or, written differently:
[[w, 0, 0, 0], [0, x, 0, 0], [0, 0, y, 0], [0, 0, 0, z]]

For calibration values [w..z]. It may be premature to worry about this, though.

@heidiaclayton as for the arguments of the classifier, that would be the desired structure of the neural net. we might have to just guess here. a while back i did share a paper where someone used a neural net to work on AVIRIS images, so you could look there for possible values. or you might use the library database search to find research papers containing keywords "AVIRIS" and "neural network" or similar.

@lewismc Regarding nose tests, I've used them before but it was mostly in the back-end of another testing framework. It does look fairly simple though, so I think I can get pretty far on those.

@browtayl thanks for the explanations. I'm going to leave the linear transform in a comment until we decide if we need it or not.

@heidiaclayton that neural net structure looks great. that very first paper we read on AVIRIS and NNs might also have some hints for parameterization.

@heidiaclayton @lewismc it would be easy to write unit tests for normalize and __indexOfGreaterThan, however we probably won't be able to test the classification methods until we have done a bit more experimentation.
@heidiaclayton as mentioned during our meeting friday, i'm thinking the number of input neurons should be NUMBER_OF_LAYERS and the number of output neurons should be the number of classes in either the USGS or the ASTER library. since these are relatively large numbers, we might have to increase the number of perceptron layers. we may find that we need to further reduce our data to limit the complexity. sorry if the paper i linked wasn't as helpful as i thought it would be, but those folks were tackling a slightly different problem.

I will kick AWS off on Monday. Sorry... I'v been literally saturated.

@heidiaclayton can you please merge this into master and provide the unit test(s) in a separate pull request? Thanks

briliant.

@lewismc @heidiaclayton agreed, this is fantastic.


Cant get the index page

Hi ,I have install api-umbrella on cent os 6 .My main dir refer to /var/www/html/DocumentRoot/ I cant get the admin page.It s there any conf file a part from /etc/api-umbrella/api-umbrella.yml.

@toktak: Sorry, but I'm not sure I understand your question. By default, API Umbrella will run on port 80 and 443 to server HTTP and HTTPS traffic directly by itself. What exactly are you trying to do with your content in /var/www/html/DocumentRoot? Are you trying to serve the content out of there for your home page, while just using API Umbrella for APIs? Are you also running Apache on this same server?


Filename include "_ios" can not found in package [go1.16beta1]

What version of Go are you using (go version)?

$ go version
go version go1.16beta1 darwin/amd64

Does this issue reproduce with the latest release?
Can not install latest release on macOS with m1 chip.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/ahdai/Library/Caches/go-build"
GOENV="/Users/ahdai/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/ahdai/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/ahdai/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16beta1"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/8n/54zz2cw1489cc3028sn1t2g40000gn/T/go-build1849439780=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Can not found any structs or funcs in the file named iap_validator_ios.go,
but iap_validatorios.go .
What did you expect to see?
What did you see instead?

_ios.go is used for platform specific code, see https://github.com/golang/go/issues/42100

_ios.go is used for platform specific code, see https://github.com/golang/go/issues/42100


(Play as noise)After being defeated by Pizzaface Boss Fight, Pizzahead's body didn't turn black and emit smoke.

Here is the photo about this bug.

Thanks, will be fixed in SR 8


Remove unnecessary code from pkg/inject, and clarify why that package and pkg/controller exist.

/sig multicluster
Addresses one of the follow-up items in #229.
/assign @font @madhusudancs @pmorie

Is there no way to disable the creation of the controller generated code? It looks like kubebuilder offers a --controller flag to make generating the controller code optional when creating a resource as in:
kubebuilder create resource --controller=false ...

@font There is some code in kubebuilder docs that specifically references in a non-switchable way pkg/controller: https://github.com/kubernetes-sigs/kubebuilder/blob/561e4da021cdee17759d74580829ab1e9a6eb6cb/cmd/kubebuilder/docs/gen.go#L25
Filed https://github.com/kubernetes-sigs/kubebuilder/issues/249 to see if kubebuilder want to fix this internally.

Ah ok, thanks! Yes, kubebuilder should allow the controller to be optional when generating docs.
/lgtm


Update VIS and VIS client dependencies

Update actix-web to 1.0
Migrate to future-preview 0.3.0-alpha.16
Migrate to nightly rust (due to usage of await)
Improve VIS client errors handling

duplicate of #2


Improve speed and type stability of Species (formerly Particle)

I will call it Species here per #45 . Generating a species is type-unstable, this should be improved
julia> using AtomicAndPhysicalConstants: AtomicAndPhysicalConstants

julia> using BenchmarkTools, JET

julia> const Species = AtomicAndPhysicalConstants.Particle; # temporary until fix in made in issue #45

julia> @btime Species("electron");
  488.672 ns (13 allocations: 528 bytes)

julia> @report_opt Species("electron")
═════ 62 possible errors found ═════
...

I've gotten it down to 60 possible errors, all of type "runtime dispatch detected"
I'm not completely sure what to do about these, as all argument types in my structs and constructors are explicit.
Do you have any experience with this?


fixed issue #2632

toContext2d: html2canvas.scale: (this.prop.pageSize.width * this.prop.pageSize.k) / Math.max(this.prop.src.clientWidth, this.prop.src.scrollWidth, this.prop.src.offsetWidth)

Could you attach a small test case so I can test it?

I'll send you the link when I get a chance. But I just figured out it should be easier and better to just set the scale to 1.

https://kakugiki.github.io/jspdf_test/
tried zoom level at 500% and result is the same. Thanks.

@HackbrettXXX it's been a while, did you get a chance to look into this. This may also help to solve issue #2766.

Looks good.


Add Oz to the OWNERS file

Release note:

This change is

@geeknoid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Codecov Report

Merging #1483 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   84.66%   84.65%   -0.02%
==========================================
  Files         122      122
  Lines       11922    11922
==========================================
- Hits        10094    10092       -2
- Misses       1632     1634       +2
  Partials      196      196

Impacted Files
Coverage Δ

tools/codegen/pkg/inventory/generator.go
65.62% <0%> (-6.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a92c6...7739302. Read the comment docs.


Add support for struct/record types

Record/Struct types are not implemented

done in !164

closed


Configure file uploads

This is a screenshot of the current file upload interface:

It looks like we are limited to 2MB. We want to increase that.
We also need to ensure we have the full set of allowed and disallowed file types per our existing config.

There are some settings in PHP and some settings in MW that will need to be modified. Figure out what they are and FIX IT!

After selecting a file, it did not auto-complete/suggest the "Destination filename" based on the source filename.

For PHP, update the relevant params in the dev and production php.ini files. For creating a new MW install, I'm guessing the only way we can turn on file uploads and is find/replace the line that turns it off then appending config variables that need to be set to increase max size. For an imported MW install we'll just have a pre-built LocalSettings.php

Being worked in #102


Fix badge shields / URLs

Well, this is unusual. Some things needed to be changed to hummingbird-me, and some needed changing to NuckChorris. Fixes https://github.com/hummingbird-me/sidekiq-debounce/issues/15 . Broken build is expected until https://github.com/hummingbird-me/sidekiq-debounce/pull/14 is merged.

I think what happened is when I moved this to the org, Travis moved it too but CodeClimate didn't, so we wound up with this weird scenario... I actually can't even access settings on the CodeClimate any more, probably because there's no repo for them to authenticate me on 🤔
I guess all of this should be on hummingbird-me/sidekiq-debounce going forward.  I just set up CodeClimate on the new path, but it's errored due to an old rubocop.yml, I'll copy a new one in and that should fix it.
Thanks for all these PRs, I really appreciate it!

I've dropped the commit relating to CodeClimate badges. They're still mismatched link/badge but it makes the most sense to change them once the new repo is setup.


WebSocketTimeoutException (Bash on Windows)

I'm running Ubuntu 16.04 on Windows 10, Python 3.6.1 (Anaconda distribution). Everything seems to have installed fine (pysc2, maps), but when I run pysc2_agent --map Simple64 I get the following output and error. Do I need to have an X server or something set up for this to work? I assumed, even if no graphical output was on my screen, that it would be able to run a bot and save a reply of the match.
pysc2_agent --map Simple64
Version: B55958 (SC2.3.16)
Build: Jul 31 2017 13:19:41
Command Line: '"/home/neighthan/StarCraftII/Versions/Base55958/SC2_x64" -listen <IP_ADDRESS> -port 20058 -dataDir /home/neighthan/Star
CraftII/ -tempDir /tmp/sc-6h55h2cr/ -displayMode 0'
Starting up...

Listening on: <IP_ADDRESS>:20058 (20058)
Startup Phase 3 complete. Ready for commands.
Requesting to join a single player game
Configuring interface options
Configure: raw interface enabled
Configure: feature layer interface enabled
Configure: score interface enabled
Configure: render interface disabled
Entering load game phase.
Launching next game.
Next launch phase started: 2
Next launch phase started: 3
Next launch phase started: 4
Next launch phase started: 5
Next launch phase started: 6
Next launch phase started: 7
Next launch phase started: 8
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_socket.py", line 80, in recv
    bytes_ = sock.recv(bufsize)
socket.timeout: timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/neighthan/anaconda3/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/home/neighthan/anaconda3/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/bin/agent.py", line 74, in run_thread
    visualize=visualize) as env:
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/env/sc2_env.py", line 178, in __init__
    self._controller.join_game(join)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/remote_controller.py", line 80, in _valid_status
    return func(self, *args, **kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/remote_controller.py", line 55, in _check_error
    return check_error(func(*args, **kwargs), error_enum)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/stopwatch.py", line 197, in _stopwatch
    return func(*args, **kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/remote_controller.py", line 120, in join_game
    return self._client.send(join_game=req_join_game)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 127, in send
    res = self.send_req(sc_pb.Request(**kwargs))
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 113, in send_req
    return self.read()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/stopwatch.py", line 197, in _stopwatch
    return func(*args, **kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 86, in read
    response = self._read()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 152, in _read
    response_str = self._sock.recv()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 293, in recv
    opcode, data = self.recv_data()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 310, in recv_data
    opcode, frame = self.recv_data_frame(control_frame)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 323, in recv_data_frame
    frame = self.recv_frame()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 357, in recv_frame
    return self.frame_buffer.recv_frame()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_abnf.py", line 340, in recv_frame
    self.recv_header()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_abnf.py", line 288, in recv_header
    header = self.recv_strict(2)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_abnf.py", line 375, in recv_strict
    bytes_ = self.recv(min(16384, shortage))
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 427, in _recv
    return recv(self.sock, bufsize)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_socket.py", line 83, in recv
    raise WebSocketTimeoutException(message)
websocket._exceptions.WebSocketTimeoutException: timed out

WARNING:root:Terminating attempt 0...
WARNING:root:Terminated.

I also installed pysc2 and SC2 on Windows, and there things run fine (I do, of course, have the Linux SC2 installed as well). Ubuntu on Windows is probably a niche market, so if it's not entirely supported, I'll understand.
I wasn't sure where to ask this, especially as the project is so new, but if there's a Google group or such that would be better (as this is probably not an issue in pysc2 so much as a problem with my setup), please let me know.

I was having a socket issue as well, and I fixed it by updating SC2. They released the required version 4 days ago. It wasn't the exact same error, so updating may or may not help, but it's worth double checking.

That is the correct version (55958), so I'm not sure what's wrong.
Maybe modify lib/sc_process.py around line 70 with the extra arg "-verbose" to see if SC2 gives a better error message.

Okay, I made the following edit (only the '-verbose' part was added; the rest is for context):
args = [
        run_config.exec_path,
        "-listen", "<IP_ADDRESS>",
        "-port", str(self._port),
        "-dataDir", os.path.join(run_config.data_dir, ""),
        "-tempDir", os.path.join(self._tmp_dir, ""),
        "-displayMode", "1" if full_screen else "0",
        '-verbose',
    ]

And then the error message that I get is:
pysc2_agent --map Simple64
Version: B55958 (SC2.3.16)
Build: Jul 31 2017 13:19:41
Command Line: '"/home/neighthan/StarCraftII/Versions/Base55958/SC2_x64" -listen <IP_ADDRESS> -port 23630 -dataDir /home/neighthan/StarCraftI
I/ -tempDir /tmp/sc-7_iz5kkk/ -displayMode 0 -verbose'
Starting up...

Request menus.
Startup Input.
Startup Resource manager.
Startup Gfx.
Startup BattleNet.
Startup GameUI.
Startup Galaxy.
Startup UI.
Startup Local.
Startup Game.
Startup ResourceCache.
Startup CGlueUI.
Startup BattleUI.
InitializingAppGameStateLogging
ResponseThread: Waiting for response to send...
Listening on: <IP_ADDRESS>:23630 (23630)
Begin initial poll
Initial Poll 1
Initial Poll 2
Initial Poll 3
Initial Poll 4
Initial Poll 5
Initial Poll 6
Initial Poll 7
Initial Poll 8
Initial Poll 9
Initial Poll 10
End initial poll
Startup Phase 3 complete. Ready for commands.
RequestThread: Received a request.
CSocketBuffer: Queueing request...
CSocketBuffer: Request queued!
MainThread: Processing request type 19
MainThread: Sending response type 19
CSocketBuffer: Queueing response...
CSocketBuffer: Response queued!
MainThread: Response Sent.
ResponseThread: Response found!
ResponseThread: Response sent!
ResponseThread: Waiting for response to send...
RequestThread: Received a request.
CSocketBuffer: Queueing request...
CSocketBuffer: Request queued!
MainThread: Processing request type 1
MainThread: Sending response type 1
CSocketBuffer: Queueing response...
CSocketBuffer: Response queued!
MainThread: Response Sent.
ResponseThread: Response found!
ResponseThread: Response sent!
ResponseThread: Waiting for response to send...
RequestThread: Received a request.
CSocketBuffer: Queueing request...
CSocketBuffer: Request queued!
MainThread: Processing request type 2
Requesting to join a single player game
Configuring interface options
Configure: raw interface enabled
Configure: feature layer interface enabled
Configure: score interface enabled
Configure: render interface disabled
Entering load game phase.
Launching next game.
Next launch phase started: 2
Next launch phase started: 3
Next launch phase started: 4
Next launch phase started: 5
Next launch phase started: 6
Next launch phase started: 7
Next launch phase started: 8
ResponseThread: Waiting for response to send...
[The above line is repeated many times; omitted for brevity]
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_socket.py", line 80, in recv
    bytes_ = sock.recv(bufsize)
socket.timeout: timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/neighthan/anaconda3/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/home/neighthan/anaconda3/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/bin/agent.py", line 74, in run_thread
    visualize=visualize) as env:
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/env/sc2_env.py", line 178, in __init__
    self._controller.join_game(join)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/remote_controller.py", line 80, in _valid_status
    return func(self, *args, **kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/remote_controller.py", line 55, in _check_error
    return check_error(func(*args, **kwargs), error_enum)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/stopwatch.py", line 197, in _stopwatch
    return func(*args, **kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/remote_controller.py", line 120, in join_game
    return self._client.send(join_game=req_join_game)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 127, in send
    res = self.send_req(sc_pb.Request(**kwargs))
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 113, in send_req
    return self.read()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/stopwatch.py", line 197, in _stopwatch
    return func(*args, **kwargs)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 86, in read
    response = self._read()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/pysc2/lib/protocol.py", line 152, in _read
    response_str = self._sock.recv()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 293, in recv
    opcode, data = self.recv_data()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 310, in recv_data
    opcode, frame = self.recv_data_frame(control_frame)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 323, in recv_data_frame
    frame = self.recv_frame()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 357, in recv_frame
    return self.frame_buffer.recv_frame()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_abnf.py", line 340, in recv_frame
    self.recv_header()
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_abnf.py", line 288, in recv_header
    header = self.recv_strict(2)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_abnf.py", line 375, in recv_strict
    bytes_ = self.recv(min(16384, shortage))
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_core.py", line 427, in _recv
    return recv(self.sock, bufsize)
  File "/home/neighthan/anaconda3/lib/python3.6/site-packages/websocket/_socket.py", line 83, in recv
    raise WebSocketTimeoutException(message)
websocket._exceptions.WebSocketTimeoutException: timed out

ResponseThread: Waiting for response to send...
[the above repeats a few times]
WARNING:root:Terminating attempt 0...
WARNING:root:Terminated.

Try increasing the timeout: https://github.com/deepmind/pysc2/blob/master/pysc2/lib/sc_process.py#L139 . You could also run pysc2 with "--sc2_verbose 20" (or some larger number if you want to see more of what pysc2 is sending to SC2).
@KevinCalderone Any idea why JoinGame times out (2 minutes) on Ubuntu on Windows for Simple64?

We have not tested the Ubuntu windows subsystem. Probably not that high on our list of priorities at the moment.


Interdigitated Transmon Updates

Modified qcomponent file to make compatible with EPR/LOM/Z analysis. Modified tutorial notebooks as well.

What are the issues this pull addresses (issue numbers / links)?
No issue, just minor updates to qcomponent file.
Did you add tests to cover your changes (yes/no)?
Yes
Did you update the documentation accordingly (yes/no)?
No, documentation already exists.
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Minor updates to interdigitated transmon qcomponent.
Details and comments
Minor updates to interdigitated transmon qcomponent in order to make compatible with EPR/LOM/impedance/eigenmode analysis. Also minor bug fixes related to rotating/translating the component. Tutorial notebook updated as well.

need to sync with recent changes made to global qcomponent options.


Fixed property parsing

Instead of using the property value as a key. I'm using the actual property name as key, so the property parsing does actually make any sense.

Tested and merged. Thanks!


Support SPM

Supported Swift Package Manager as a means of package distribution.

Thank you for your review!


A more complete version of the Tokens How-To Guide

I've written a more comprehensive version of the How-To Guide for Tokens. I've followed a pretty similar structure to the other how-tos. Would love to get some extra eyes on it 😁
Here are some specific things I'd love some help reviewing:

[ ] Any grammatical stuff like word choice, consistency, proper-casing, etc.
[ ] The "main concepts" sections (the subheadings underneath "How it Works") I kindof just plucked out of thin air. I was trying to highlight some of the significant aspects of this example contract, and how it fits into the broader scope of soroban/smart contracts in general. Do those three sections offer a fair and/or useful summary here? Is there some stuff I should (shouldn't) write about?
[ ] Under the "Code" section, I've copied/pasted all the source files content in from the example contract, giving each one its own tab, with a code block within. Is this a clear way of presenting it? Should it be done differently?

Preview is available here:http://soroban-docs-pr468.previews.kube001.services.stellar-ops.com/

Here's the preview for the specific page that's been updated: https://soroban-docs-pr468.previews.kube001.services.stellar-ops.com/docs/how-to-guides/tokens

Preview is available here:http://soroban-docs-pr468.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr468.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr468.previews.kube001.services.stellar-ops.com/


2856: poi filter is too long for display and no scrolling available

Short description
The POI filter on 5,5" phone leads two categories to be cut and it's not possible to scroll.
Proposed changes
~- Used FlatList instead of .map() for build-in scrolling.~
~- Defined numbers of numColumns 3 to make it consistent on all devices~
~- Computed the flatListHeight dynamically from poiCategories length divided by numOfColumns to get number of rows multiplied by toggleButtonHeight.~

Used a ScrollView that wraps around opening hours section and categories section.
Tested on virtual devices with the following screen: 5.0, 5.5, 6.7 inches.

Side effects
None.
~Note: I disabled scrollView from Modal (scrollView={false}) because VirtualizedLists doesn't like to be nested in ScrollViews.~
Resolved issues

Fixes: #2856.

Oh, sorry, completely forgot: this should probably get a release note. You can find a template in the folder release-notes

Hey, thanks for your first PR in this project! 🎉 Our <Modal> component should already implement scrolling behavior (including the title, which should also be scrollable in my opinion). For some reason it is not working though, could you perhaps investigate that? I think that would be a little better solution compared to adding another scroll view.

Sure I will take a look at the modal...

Oh, sorry, completely forgot: this should probably get a release note. You can find a template in the folder release-notes
Sure after I investigate about the modal first..
I should add one at folder 2024.8.0 right?

Oh, sorry, completely forgot: this should probably get a release note. You can find a template in the folder release-notes

Sure after I investigate about the modal first.. I should add one at folder 2024.8.0 right?

Absolutely no worries. No, it always goes in the unrealeased dir and is automatically moved to the correct folder on release.


[WFCORE-5782] Reset 'java.security.manager' default value back to "allow" by default in WildFly shell scripts

https://issues.redhat.com/browse/WFCORE-5782

@jamezp It would be good if you could take a look at this one as well.
Note that as Jeff pointed out, we should merge this and https://github.com/wildfly/wildfly-core/pull/4934 at the same time.

Right @jamezp , launcher changes are in separate PR here: https://github.com/wildfly/wildfly-core/pull/4934

@ropalka thanks


MINOR: [Dev][Release] Stop post-04-website.sh script if archery isn't available

Rationale for this change
The release script at dev/release/post-04-website.sh doesn't quite work right if archery isn't available. The PR gets made but the changelog isn't included. See when this happened during the 18.0.0 release: https://github.com/apache/arrow-site/pull/551#discussion_r1822264990.
What changes are included in this PR?
Before the script does anything meaningful, it checks for archery and stops if it's not available.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Thanks @kou. I pulled your latest suggestions, tested locally, and it's working fine.


Relationships with non-primary keys

Hello guys, I`m having some trouble trying to figure out what is wrong with the code.
I have an hasOne relationship between Company and Partner.
Here are my Models:
App\Company.php
use Jenssegers\Mongodb\Eloquent\Model as Model;

class Company extends Model {
    protected $collection = "company";
    protected $primaryKey = "_id";

    public function partner(){
        return $this->hasOne(\App\Partner::class, "com_id");
    }
}

App\Partner.php
use Jenssegers\Mongodb\Eloquent\Model as Model;

class Partner extends Model {
    protected $collection = "partner";
    protected $primaryKey = "_id";

   protected $fillable = ["_id", "com_id", "email"];
}

If set foreign key from hasOne relationship pointing to primary key to model \App\Partner, It works like a charm.
But, If I set foreign key from relationship as com_id, returns NULL.
Both, _id and com_id have the same value.
Am I doing something wrong?

I'm having the same problem with a local key other than _id....


brew doctor warnings

Hello I've been seeing this warning for sometime. Is there anyway to tame this at all? I don't know where else to post for help. I am not sure what other information I can provide.
~ brew doctor                                                                                07:29:44
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: "config" scripts exist outside your system or Homebrew directories.
`./configure` scripts often look for *-config scripts to determine if
software packages are installed, and what additional flags to use when
compiling and linking.

Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew provided
script of the same name. We found the following "config" scripts:
  /Library/Frameworks/Python.framework/Versions/3.7/bin/python3.7-config
  /Library/Frameworks/Python.framework/Versions/3.7/bin/python3.7m-config
  /Library/Frameworks/Python.framework/Versions/3.7/bin/python3-config

Warning: Unbrewed header files were found in /usr/local/include.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Unexpected header files:
  /usr/local/include/python2.7/greenlet/greenlet.h

~ echo $PATH
/usr/local/bin /usr/local/sbin /usr/bin /bin /usr/sbin /sbin /opt/X11/bin /Library/Frameworks/Mono.framework/Versions/Current/Commands /Applications/Wireshark.app/Contents/MacOS /Library/Frameworks/Python.framework/Versions/3.7/bin

My /etc/paths (I added /usr/local/sbin) on a website's advice.
/usr/local/bin
/usr/local/sbin
/usr/bin
/bin
/usr/sbin
/sbin

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.
And also, the very first message of brew doctor:
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!


Rank() based on elo in the teams table to simplify the display on the leaderboard

Teams are sorted by score, it's just always zero. So I'll say this is closed


Feature request: suppress validation errors via magic comments

Sometimes, JSON schemas are out of date (compare https://github.com/astral-sh/ruff/issues/7261). In that case, it would be great if those errors could be suppressed, similar to # noqa comments in the Python world.

That's a good idea. I don't think it already exists, so it would need design and implementation. I'm adding the "help needed" label.


Why is ROUND_HALF_EVEN the default everywhere?

Why is ROUND_HALF_EVEN used across all the formatting definitions? It would seem to me like decimal.ROUND_HALF_UP is the proper one to use?
In [40]: Decimal("2953.125").quantize(Decimal("1.00"), decimal.ROUND_HALF_EVEN)
Out[40]: Decimal('2953.12')

In [41]: Decimal("2953.125").quantize(Decimal("1.00"), decimal.ROUND_HALF_UP)
Out[41]: Decimal('2953.13')

I'm from Sweden. Here it should definitely be 2953.13, but it's probably different for other currencies?
From localization.py:
_format("sv_SE", group_size=3, group_separator=" ", decimal_point=",",
        positive_sign="", trailing_positive_sign="",
        negative_sign="-", trailing_negative_sign="",
        rounding_method=ROUND_HALF_EVEN)

I think this will be dealt with as part of #118


Add disabilities data (based on HESA)

Context
We have the PR https://github.com/DFE-Digital/apply-for-teacher-training/pull/7171 to prepare for the end of the cycle and the disabilities data has changed slightly from one year to the other (added more records).
So I am taking the opportunity to start to move to the reference data.
Source: https://www.hesa.ac.uk/collection/c22053/e/disable
The match synonyms I used were purely based on Apply.
Guidance to review

All UUIDs are good?
The HESA code matches with the HESA link above?

Has this content been reviewed by a content designer? we might want Apply and Register’s content designers to review these - I'm not sure if we intend to use the literal text from HESA or not.
I'd also remove the match synonyms - they're more intended for autocompletes or processing free text input - which I don't think is needed for this data set.

Register's current prototype disabilities page looks like this - we don't use the exact hesa wording - but a short form and then a long form. I think Apply's might be similar. We probably want to think more about what we want in reference data before adding here.


Documentation

When you get a chance can you please add some documentation. Looks like a cool project.

Thanks Powerpass. Im working on a Wiki right now, should have something next week.

The Wiki has been updated with relevant documentation. Let me know if you think something is missing.

Closing this.


Cannot create external tables with partitions and non-default file format

Hi,
Thanks for developing this dbt adapter for Hive,
I have being suffering some issues while trying to create external partitions tables with some specific file formats , for instance using next configuration
{{
  config(
    materialized="incremental",
    incremental_strategy= "insert_overwrite",
    external=True,
    file_format= "orc",
    partition_by=["some colum"],
  )
}}

Looks like this issue is happening because when the file format is added when table is being created (https://github.com/cloudera/dbt-hive/blob/f293ba97eaea824604bd83fe684d92b84f67d4d9/dbt/include/hive/macros/adapters.sql#L125-L137)
This is not consistent with Hive CREATE TABLE definition that expect STORED AS TO BE after partitioning and before location.
So that, I guess it should be something like following
    {% else %}
      create {% if is_external == true -%}external{%- endif %} table {{ relation }}
    {% endif %}
    {{ options_clause() }}
    {{ partition_cols(label="partitioned by") }}
    {{ clustered_cols(label="clustered by") }}
    {{ file_format_clause() }}
    {{ location_clause() }}
    {{ comment_clause() }}
    {{ properties_clause(_properties) }}
    as
      {{ sql }}

Best Regards,
Zuma

This is resolved in #96


I get lost

Issue moved from MicrosoftDocs/feedback#2835

Please respond to @pmarcantonio.

From @pmarcantonio on Monday, June 8, 2020 3:31:06 PM
I am attempting to learn C sharp and Xanarin, as I follow YOUR build an App documents, I see and understand  what the Microsoft document is saying, but when I go past a chapter or two, the additional code generated by Visual Studio is not explained. such as the project Notes
I have not idea what
async void OnSaveButtonClicked(object sender, EventArgs e)
I have no idea what these are or how to view the content of object sender, EventArgs  or e.
Maybe you can suggest the best method for me to learn
<EMAIL_ADDRESS>

Issue moved from MicrosoftDocs/feedback#2835

Please respond to @welcome[bot].

From @welcome[bot] on Monday, June 8, 2020 3:31:07 PM
Thank you for creating the issue! One of our team members will get back to you shortly with additional information. If this is a product issue, please close this and contact the particular product's support instead (see https://support.microsoft.com/allproducts for the list of support websites).


Parametrics Export failing for some outputs

Parametrics export is failing to include outputs in some export files, but not others.
To replicate,

open the mini-grid-example.sam file on the quickstartFixes branch of SAM (not through the macro, just open the file)
Export the currently set up parametrics tab.
Open the file in Excel and see that the outputs aren't there.

However, when I export a simple PVWatts parametric setup, the outputs show up in the file. TBD if this is something I can hunt down, or if I'll need @sjanzou to step in. Will update this afternoon.

Appears to be because the formatting has changed between versions. Overwriting the parametrics export file with a data table written to CSV and then importing that as a parametric table worked in 2022.11.21, but we have since changed the format of the parametric import, so now writing an LK data table to a file does not import into parametrics correctly anymore in the current dev version. Solution to be identified.


Follow the same rules of morphology validation as MorphIO

Codecov Report

Merging #934 (f1009e7) into master (6f6bc24) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #934   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           37        37
  Lines         2132      2128    -4
=========================================
- Hits          2132      2128    -4

Thank you!


Do not modify users' Topology objects

This is a port of #350 targeting v0.2.x / Toolkit v0.11.x

This is all already in the main branch


Fix nested permalinks

Pages in subfolders are currently unavailable. That's bad! This fix resolves that problem while also removing a redundant data file. Win, win.

(The CSS files here needed to be rebuilt from a previous PR, I think.)


Cant Host Server

Hi,
I would like you to thank you for your amazing work. There is a Issue. I intalled the mod manually and Cities Skylines actually read it perfectly, the mod was suscesfully installed but there is a litte issue. I cannot host a servere, when I click on Host game it dosent do anything, but when I click join its works.
I would like to Host a game for me and my friend but it dosent do anything, can you help us.
Thank you for advance,
Greetings,
PS:Sorry for my bad english

I have not added a debug log, so it's hard to tell what's happening. But there is a good chance that either your firewall is blocking the port, or you need to port forward your router (if hosting over the internet)
It should also be noted that the mod only currently supports connecting, hosting servers and syncing simulation speed. That's about it.

Hi,
Thank you for your respond, Is it possible to play LAN toegether, but do we have to host of can we just only click connect. Beacuse If we are on the same internet IP it is possible to only click  join game. Or do you have to still host a game.
I checked my firewall and its still givinv a problem, I think its my router, beacuse I dont have a port forwaard connection.
greetings

If you are playing LAN, one person must host and the other will connect to it. In this case (as you are LAN), you do not need to port forward.
On the computer you want to host from, type 'ipconfig' in the command prompt to find your IP address, this is the address that the client will connect to.
For example:
Your PC: Type 'ipconfig' find an IP Address of <IP_ADDRESS>, host server.
Other PC: Click connect, type in '<IP_ADDRESS>' and it should connect to the server.

Oke,
If you click on host and nothing happends then you cant play (LAN) : (

I couldn't get the install script to run but copying the required files into the mod folder did the trick for me and the mod is now available to use. But as you mentioned in the issue #10 here, on using ModTools to debug for Host Game. Getting the error
TypeLoadException: Could not load type
'System.Threading.CancellationTokenSource' from assembly System.Threading

@shubham-root Is there a System.Threading dll in the mod bin folder? (It should automatically be generated). I forgot to include this in the libs when updating the mod last.

I updated the scripts a little while ago to take into account the new DLL, I've just updated the Continuious Integration (CI - see the readme file) to bundle this DLL into the zip folder. Easiest way to install the mod is now via the CI builds.
I'll also update the readme file with more information about hosting servers and connecting to them.


fix broken documentation link

Is this the expected page ?

link works fine here: https://reframe-hpc.readthedocs.io/en/latest/index.html
so maybe not an issue after all


Add code to VLD save that ensures that the freecen piece has a freecen2_place_id once we deploy the latter

Code at process_vld_file(filename, userid) lines 20 to 30

@Captainkirkdawson where are we up to on this?

This will be deployed when all other components of the transition to Freecen2 data model are ready


encode to base64 from 'spotifyClientId:spotifyClientSecret' in app

get 'spotifyClientId' and 'spotifyClientSecret' from the .env file and encode to base64 in app

Hi,
Thanks for your PR!
Can I ask what is the purpose of these changes?

Hi
Before these changes, you had to create a 'ClientId:ClientSecret' combination and convert it to base64, putting the resulting string in the .env file. It was a little confusing with just 'ClientId' in the .env file. With these changes, it's now a bit easier for common users to use.


Explain duplicate timestamps

CSP has a many-to-1 mapping between timestamps and engine cycle. This allows for duplication of timestamps in the same engine cycle, for specific use cases. This needs to be documented, potentially in https://github.com/Point72/csp/wiki/Execution-Modes.
An example (shared by rob);
def g():
    u = csp.unroll(csp.const.using(T=[int])([1, 2, 3]))
    s = csp.sample(csp.const(True), u)
    csp.print('u', u)
    csp.print('s', s)
csp.run(g, starttime=datetime(2024, 1, 1))
> 2024-01-01 00:00:00 u:1
> 2024-01-01 00:00:00 s:1
> 2024-01-01 00:00:00 u:2
> 2024-01-01 00:00:00 u:3

csp.unroll is also used in the seismology example

https://github.com/Point72/csp/wiki/Execution-Modes#csppushmode
Seems like this is appropriately documented.

The request here was to document the nuances / gotchas of having dup timestamps, ie in the example mentioned above the sample may not behave the way one would naively expect


Dynamic training PR

Random idea: could be nice to have some simplified way / template to create custom transforms.

Random idea: could be nice to have some simplified way / template to create custom transforms.

Yes, This can be easily done by inheriting the Transform class.

In this stade, dynamic training can be used in Summarization and Graph-to-sequence cases, as dynamic_dict option is supported.

Something missing I think: how to pass the alignment file -- for training with guided alignments (or other possible custom transforms) -- in the data config?
Or did I just miss it browsing the code?

Something missing I think: how to pass the alignment file -- for training with guided alignments (or other possible custom transforms) -- in the data config?
Or did I just miss it browsing the code?

For the alignment file, I haven't added it yet. We may introduce it the same way as src/tgt. But the question is, how to make sure it keeps consistent after all these transforms. It appears a little bit complicate, so I'll add them after clean up previous preprocess-training things.

Makes sense. As a first step we could probably raise a warning or even assert for some transforms that wouldn't be compatible in a straightforward way (most of them if not all indeed).

Something that came up while thinking about the new Readme: is the separate data_config.yaml really necessary? Since we merged preprocess and train it would probably make sense to have a single config file, don't you think?

Something that came up while thinking about the new Readme: is the separate data_config.yaml really necessary? Since we merged preprocess and train it would probably make sense to have a single config file, don't you think?

Sure, we can do this indeed.

What about the source features?
Do we drop support for the first release or do you think we can add them without too much hassle?

What about the source features?
Do we drop support for the first release or do you think we can add them without too much hassle?

What do you mean by source features? Is it word feature separate by |?
If so, I think it's not trivial to add them as they are the subfields requiring its proper vocab.
At the same time, it should be aligned to the word which means the transformation applied to the word should also handle the corresponding feature. While we do not assume the type of features (can be POS/Tag/etc..), means even we want to add them, we can only support it without any transformation.

What do you mean by source features? Is it word feature separate by |?
Yes, word features, sorry. I named it source features to the contrary of target features, which are another story to themselves.

I suppose we could have some asserts like for the 'align' case for incompatible transforms.
Though we could also see some features being added by some transforms (e.g. -case_feature in onmt_tokenize).
Let's put this on standby, we can always add it later (or take a PR from anyone willing to...).

Few thoughts:

we need to add onmt_build_vocab in the cli entry points of setup.py (if not already done in another PR)
could be good to add a flag to exit the training after the initial steps (can be useful to just check the samples, or for the usage as a library (https://opennmt.net/OpenNMT-py/Library.html) if we just want to build the fields for instance).

Few thoughts:
* we need to add `onmt_build_vocab` in the cli entry points of `setup.py` (if not already done in another PR)

Yeah, I'll add that.

* could be good to add a flag to exit the training after the initial steps (can be useful to just check the samples, or for the usage as a library (https://opennmt.net/OpenNMT-py/Library.html) if we just want to build the fields for instance).

Maybe exit training when n_sample set to > 0. As we normally use this to check the sample, it's therefore rational to stop there before we've checked all good.

Maybe exit training when n_sample set to > 0. As we normally use this to check the sample, it's therefore rational to stop there before we've checked all good.

Makes sense but we'll need to make it clear in the docs.

Suggestion: wouldn't it be cleaner to have a few more kwargs to the constructor of DynamicDatasetIter, and pass them in build_dynamic_dataset_iter, to prevent relying on the full opts Namespace?
I stumbled upon this while adapting the "OpenNMT-py as a library" example in the docs.
(From execution block [22] here: https://github.com/francoishernandez/OpenNMT-py/blob/update_docs/docs/source/Library.ipynb)

For -n_sample, I think it would be nice to have:

if -1 : use full corpus
if 0 : the current behaviour of -1
if N > 0 : the current behaviour

In the dynamic iteration pipeline, we need to add a check somewhere for src == "" or tgt == "".
We can either:

ignore the example silently;
raise a warning and show the example / line number;
raise an error and stop the process.

The best is probably to create a flag -empty_examples with choices=["ignore", "warning", "stop"], don't you think?

Another suggestion:
If -src_vocab / -tgt_vocab are not set, couldn't we check for the -save_data paths before raising the error?
I think it may be a bit more user-friendly to not necessarily have to set the -src_vocab / -tgt_vocab paths after having called onmt_build_vocab.

Suggestion: wouldn't it be cleaner to have a few more kwargs to the constructor of DynamicDatasetIter, and pass them in build_dynamic_dataset_iter, to prevent relying on the full opts Namespace?
I stumbled upon this while adapting the "OpenNMT-py as a library" example in the docs.
(From execution block [22] here: https://github.com/francoishernandez/OpenNMT-py/blob/update_docs/docs/source/Library.ipynb)

Addressed in #21.

Small issue: in the ONMTTokenizerTransform, we can set different types for source and target, but onmt_kwargs would be the same. We should probably make src_onmttok_kwargs and tgt_onmttok_kwargs.

Not necessary for the initial release, but it would probably be nice to be able to multiprocess the transforms in build_vocab at some point.

Final TODOs before initial release:

[ ] put transforms folder directly under onmt (! adapt paths in the docs)
[ ] merge code files that are duplicates (opts, parse, iterators maybe)
[ ] everything else that is in dynamic can be put under inputters I think
[ ] finish the docs #20 (almost done, but final touches will be required when everything else is done)

Anything else?


[Meta] Automated testing of containers configuration within this repo

I apologize in advance if it's not the right place to discuss this, but it's the best I could find.
After discovering recently an mismatch issue in a devcontainer definition (https://github.com/microsoft/vscode-dev-containers/issues/1306), I was wondering how we could prevent this kind of issue happening again in the future?
Is there a CI task already existing where I could add testing on a specific image configuration to avoid regressions like this?
If not, do you think it would be possible to create it? I can prototype a PR.
What's your thoughts about this?

There's an internal CI job but it relies on closed source code at the moment. As https://github.com/microsoft/dev-container-spec/issues/9 is completed we can move it into a better spot. That said, the way it works is that you can add a "test-project/test.sh" script to do more testing beyond building the container to verify contents.


[Feature] Add missing RPC namespaces and missing RPC methods

Component
rpc
Describe the feature you would like
Achieve full compatibility with Reth's JSON-RPC methods and namespaces
Link: https://ethereum.org/en/developers/docs/apis/json-rpc/#json-rpc-methods
Missing namespaces:

[x] rpc-types-web3: https://github.com/alloy-rs/alloy/pull/996
[x] rpc-types-net
[x] rpc-types-rpc
[x] rpc-types-mev: https://github.com/paradigmxyz/reth/issues/9027)

Missing methods:
For Trace:

[x] trace_rawTransaction: #925
[x] trace_replayBlockTransactions: #925
[x] trace_filter: #946
[x] trace_get: https://github.com/alloy-rs/alloy/pull/987

For Admin:

[x] admin_peerEvents_subscribe: https://github.com/alloy-rs/alloy/pull/991
[x] admin_peerEvents_unsubscribe

For Debug:

[x] debug_getRawHeader
[x] debug_getRawBlock
[x] debug_getRawTransaction
[x] debug_getRawReceipts
[x] debug_getBadBlocks
[x] debug_traceChain
[x] debug_traceBlock

Yeah, sorry about that, I updated the remaining methods with their PR. Thanks to everyone!


[BUG]: Video first frame do flickering when player load video and start playing, Demo Attached

Version
react-native-video: ^6.0.0-rc.0
react-native: 0.71.14
Video URL: HLS m3u8
What platforms are you having the problem on?
Android
Architecture
Old architecture
What happened?
I have a TikTok-like app where, on the home screen, when we try to scroll the video, there is a flickering issue. While this problem was not present in the previous version (v5), it has appeared now. I have recorded a demo video demonstrating this issue, and it is attached
Reproduction
repository link
Reproduction
Steps to reproduce this bug are:  Swipable videos like TikTok, and swiping the video, a flicker will appear. like when we swipe to video, the first frame is small having black spaces, then suddenly remove black spaces, goes to full mode

https://github.com/react-native-video/react-native-video/assets/66157395/9c652bf5-eafa-4129-87f8-129ed5bcb188

@KrzysztofMoch @freeboub You guys are doing a really good job, Thank you for your contribution, the latest v6 has made our lives easier, and only a few issues currently we are facing, Let me know if you need anything else from my end 🙌

@ZakirBangash mind if we connect, working on somthing similar.

Yeah sure Let's connect

@ZakirBangash You can use the<EMAIL_ADDRESS>this solves for me.
Now I request the maintainers to fix this issue this happens when we change the video quality or change the video on the fly.
So, please fix this issue The flickering is not happening in v6.0.0-alpha.11 and I tried it in v6.0.0-beta.4 and there also the flickering happens so please do this as it's in v6.0.0-alpha.11 so this will be fixed.
Thanks in advance.

In my mind (maybe I am wrong) there is no change regarding to View management between alpha.11 & next release.
Not sure where you investigated, but I think the fix shall be around shuttterView management.
I had a look, but I did find anything relevant yet ...

@MdAbubakar @tdammy92 @ZakirBangash I think I have found a solution to fix this issue.
can you please test linked PR ? I tested it sucessfully with the sample, but I think this is safer to test it with a real life app !

Hi @freeboub I just tried the latest release @6.0.0-rc.1, which contains this PR, this time player does not even load the video

@ZakirBangash can you try to revert my last change please ?

@freeboub I reverted the last changes related to shuttterView management and created PR, but I have verify it, then will let you know

@freeboub I reverted the last changes and created PR, tested it out, and the video is loading now.

@freeboub  @ZakirBangash which version is more stable now , @6.0.0-rc.1 or v6.0.0-alpha.11 ?

@tdammy92 for this flickering issue the v6.0.0-alpha.11 is more stable.

Notice this is a duplicate of https://github.com/TheWidlarzGroup/react-native-video/issues/3653

I just push another version of the fix, can you please test it ? Thank you

I will test it on Monday morning, I will let you know then, as I'm away from the keyboard atm 🙏

Hey @freeboub I tested it, The flickering is gone, but only the first frame of the video plays, then the rest of the frames paused, and the video frame movements stopped, but the audio is still going on, Let me share the recording

Please share a sample url !

We are using m3u8, I will share few m3u8 urls as well
https://github.com/TheWidlarzGroup/react-native-video/assets/66157395/ad4be56c-aa9d-46fc-96f7-4b2bb6073c63

Video URL : https://stream.mux.com/GBhY017Qx3X3PlDyQAx201Y3kTSADrOm4nMuD00YeLV602g.m3u8
thumbnail URL: https://image.mux.com/GBhY017Qx3X3PlDyQAx201Y3kTSADrOm4nMuD00YeLV602g/thumbnail.webp?time=0

@ZakirBangash I am too far to peint your wall to a normal color 😆
BTW, I don't reproduce the issue with the sample ...
The video play well when switching between streams (you video included)
Can it be linked to any other props like poster ? I suppose you use it as you provided thumbnail url.
Can you please try to simplify your usage of <Video and maybe identify if another prop make the issue ?
Did you try to reproduce it with the sample included in the repo ? (the video freeze)

Can you please try to apply following patch locally.
It is just a test to see if it work better.
diff --git a/src/Video.tsx b/src/Video.tsx
index 7cdbc211..aebda7ee 100644
--- a/src/Video.tsx
+++ b/src/Video.tsx
@@ -130,6 +130,7 @@ const Video = forwardRef<VideoRef, ReactVideoProps>(
           posterResizeMode && posterResizeMode !== 'none'
             ? posterResizeMode
             : 'contain',
+        opacity: 0.9,
       }),
       [posterResizeMode],
     );

I've encountered the same issue with the poster continuously showing. A simple solution I found is to add onReadyForDisplay to your Video component.
what i've done
        <Video
          onReadyForDisplay={() => {
            console.log("onReadyForDisplay");
          }} //add
          poster={mediaItem.thumbnailUrl}
          posterResizeMode="cover"
          ignoreSilentSwitch="ignore"
        />

@freeboub giving onReadyForDisplay callback works, we just need to give onReadyForDisplay empty callback, and then it works
    <Video             ref={videoRef}             onLoad={onLoad}             source={source}             **onReadyForDisplay={() => {}}**             paused={paused}             poster={updatedThumbnailWith0Frame}             resizeMode={'cover'}             style={styles.videoPreviews}             useTextureView={false}             playInBackground={false}             repeat={repeat}             disableFocus={true}             posterResizeMode={'cover'}             ignoreSilentSwitch={'ignore'}             onEnd={onEnd}             bufferConfig={{               minBufferMs: 0,               maxBufferMs: 0,               bufferForPlaybackMs: 0,               bufferForPlaybackAfterRebufferMs: 0,             }}           />

@ZakirBangash This is a very good clue to understand the issue, I was able to reproduce it with the sample now !
I just push a patch to fix it !
Notice that you can keep the onReadyForDisplay patch to continue using 6.0.0-RC.1 or 6.0.0-RC.2

@freeboub Giving onReadyForDisplay callback works, we just need to give onReadyForDisplay an empty callback, and then it works.

Can you explain the process of creating a poster using the ‘updateThumbnailWith0Frame’ method?


new API for list and cancel database operations

new API for list and cancel database operations

@jiawang003,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

ATTENTION REQUIRED.
We have changed the default branch in the azure-rest-api-specs repository to use the branch labeled current.
This PR is opened against the master branch.
You have two options:

Keep this PR open, and complete the review process as normal, and once this PR is merged against the master branch, we (@olydis & @fearthecowboy)  will create a PR against the current branch and make any updates required to work in the newly reorganized default branch.

Close this PR and create a new one. That would mean pulling in the changes from the new default branch current moving any files and switching to the configuration-based layout.  (You are more than welcome to choose option 2, but I don't expect anyone to do that)

Either way, the work you are currently doing against the previous default branch master will be the last PR against that branch that we will accept and all new PRs will go against the new default branch  current.
If you have any questions or concerns, ping @fearthecowboy or @olydis (or go ask on the #swagger channel in slack) ASAP and we can help you thru the process.

Reviewer will be assigned very shortly

@jiawang003 , @jaredmoo , @dsgouda
Is this PR nearly ready to merge? I'd like to get the last of the PRs against master completed and merged so we're not in this state.
If this is going to take much longer, you may need to create a new PR against  the current branch.

Requested changes have not been addressed yet, cannot merge. @jiawang003 please open this against the current branch as you anyway have to make some changes.

Closing -- please open a new PR against the current branch


De-minify javascript

This PR fixes issue #104 which adds in source js files for the site.  This PR also is a pre-requisite for additional work on PR #83 .  Once the js de-minification & refactor is complete, then more clean-up work can happen on that PR in implementing improvements around anchor links.
The original source js files were used as a starting point for de-minifying the original desktop.min.js file.  There was a significant amount of unused js in those files, so only included what was absolutely necessary and tried to go through them and clean up where I thought it was needed.  Notes below:

[x] De-minified desktop.min.js and removed it from version control.  During the js clean up was also able to remove 2 js libs that are not needed from the codebase (hoverintent & jquery migrate).

[x] The other big piece of de-minifying the js was to ensure a method to compile and optimize the de-minified js back into one minified js file to be used in production environments.  The source js is using require.js to load the necessary js files & libraries, so I included the r.js library and a build profile (app.build.js) for doing the optimization of the js.

The travis-checks file was then modified to incorporate the commands for building the source js as well as incorporated an sed function to modify the _config-deploy build configuration for production so when building for production, the concatenated & minified js file is used.  As you can see on my fork, and all forked repos, the un-minified js is being used.  The optimized js will only be used on production.
The compiled app.js file is also now included in the .gitignore to ensure it is not checked back into version control.

Additional notes for consideration of future tasks (considered out of scope for this PR, but if folks agree, we can work them in as well).

[ ]  There are some older versions of js libraries being used.  It might be good to consider updating these to the latest versions to stay current.

[ ]  There were a number of console.logs in the js code.  I didn't see anything about removing these in the js style guide however, it might be good to remove these unless someone feels differently?  They are currently in the desktop.min.js so kept them in for now, but doesn't seem like they are needed for anything and looks like normal troubleshooting code?  Alternatively, we can look into automatically removing these statements as part of build scripts for production.

This change is

Comments from the review on Reviewable.io


Scrambled service provider menu

It's not caused by the UCP but since you guys are the crusader experts I thought you might have an idea about what might cause this. It happened after I installed the official 1.41 patch.

Ive never seen that... are you still able to play multiplayer?

Unfortunately not, clicking the host button doesn't do anything. I should mention I'm running this through WINE on Linux Mint so I suspect something is happening there. But it was all fine before the 1.41 patch.

hmmmm... could be that the updater software is not good on linux.... do you have a windows pc you can copy the original game to, then update it there, and copy the updated files back?

Actually that's how I did it, I got my friend to install and update it on his Windows computer and it works fine, then I copied the files to my system.

Just wanted to let you know that I solved the issue. I needed to use a 32bit WINE prefix, I was using a 64bit one.


fatal error messages with git-radar on local untracked branches

$ git-radar --bash
fatal: ambiguous argument './master...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument './master...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
 git:(some-branch)

pushing the branch remotely fixes the issue
$ git push -u origin some-branch
Total 0 (delta 0), reused 0 (delta 0)
To git@github.com:PagerDuty/web.git
 * [new branch]      some-branch -> some-branch
Branch some-branch set up to track remote branch some-branch from origin.

$ git-radar --bash
 git:(some-branch)

Some info about my system stats:
os x el capitan version 10.11.1
git version 2.6.2

Same problem here...

Don't think I have the same problem with local untracked branches, but I did see this same error message yesterday when I made a new github repo.
I created the repo on github (repo is empty, no readme etc), I then cloned it. When I enter the repo this message appears, and continues to appear until I have pushed something.
Same similar in that it would be untracked until pushing, but I seem to only see it for new repos.
I am on Ubuntu

For me at least, I think the problem is the "git rev-parse --git-dir" command... When I run it I get the error message (perhaps try it on yours as well so we can see if maybe that is what caused it?).
see this stackoverflow page.

I think I have pinpointed my problem, and perhaps it is similar for everyone else...
in radar-base.sh there are two git commands that cause my error to come up which are:
git rev-list --right-only --count ${remote_branch}...HEAD
git rev-list --left-only --count ${remote_branch}...HEAD
This command lists the commit objects in reverse chronological order...
The first one (right only)  lists the commit objects in reverse order of HEAD in this case, and --left-only does the same but for whatever my ${remote_branch} happens to be... in this case, origin/master
I am guessing the error is because there are no objects in a new repo.
So if we are going to fix this, probably will need a check on the git commands to make sure there is actually something to read, or force an ignore of the error messages...
I noticed in some functions nearby that similar calls are appended by "2>/dev/null || printf '%s' "0""... If we do the same, this will probably go away (for me at least).
Maybe you can check if these are the same calls that are causing problems for you?
What also seems weird about the output you have provided is that the branch it displays is "./master...HEAD"... I have not seen a ./ in a branch before so this could be something else.
Question for the owner: is there a reason that the two calls mentioned above (in functions: commits_ahead_of_remote and commits_behind_of_remote) do not have 2>/dev/null appended, or is this something we can add easily (Just wondering if there is any actual reason that we would not want to add this).

Yep, I think @hallzy has it. An empty repo causes this problem. Appending 2>/dev/null fixes.
@thomasdziedzic It should also fix your problem, though the remote reference seems screwy. Can you run the following commands:
> git config --get "branch. some-branch.merge"
> git config --get "branch. some-branch.remote"

(assuming your branch is called some-branch)
You should see ref/heads/some-branch as the merge and origin as the remote. If they aren't like that then that might be what's going on. Either a bad sed on git-radars part or a misconfigured remote on your repo?

@michaeldfallen looks like the issue for me might be a misconfigured remote
both of the commands don't print out anything
$ git config --get "branch. some-branch.merge"
$ git config --get "branch. some-branch.remote"

@hallzy Your fix also solves #88 but in a seemingly error-squashing way.  I am trying to figure out if I would like to be notified if one of my tracked branches gets deleted, and burying the error in the bitbucket doesn't leave much room for options there.  Adding a check for tracked branches' existence and adding more emoji would be cool. :tada::confetti_ball::dolphin::whale:
This is totally up to @michaeldfallen, and I admit the consideration for error handling within a small utility like this may be overkill.  radar-base.sh already uses /dev/null in several places (git grep -e \/dev\/null), so I am a-OK with closing #88 if the error is just buried.

@thomasdziedzic There should be no space between branch. and the branch name.  You can also take a look inside your repository's .git/config file to see how each branch is setup.  This is what your some-branch configuration should look like on a remote that is not misconfigured according to @michaeldfallen's comment:
[branch "some-branch"]
	remote = origin
	merge = refs/heads/some-branch

This function is responsible for retrieving remote branch information and fetches the remote information from your git configuration.  Misconfigured branches would cause odd behavior in there.

I got the following:
$ git checkout -b some-branch
Branch some-branch set up to track local branch master.
Switched to a new branch 'some-branch'

$ git config --get "branch.some-branch.merge"
refs/heads/master

$ git config --get "branch.some-branch.remote"
.

@thomasdziedzic sorry about that, I added a space by accident. Yeah that remote config doesn't look right. it should be a name of a remote. Not entirely sure how we fix this. Can you check that the branches are properly configured when you clone a different repo and run git checkout -b new-branch; git push -u origin new-branch?

@colinsf nice catch with the extra space. My mistake :disappointed:.

@colinsf the "missing remote branch" indicator you mentioned is interesting. We have the upstream ⚡my-branch to do just that but it only seems to care if its not "set upstream". I suppose rather than squashing the error outputting that would be more informative to the user?

"Interesting" is about where I left off thinking about it as well.  Maybe throw it into a future feature?


Support for loading zipped buffer in file loader

If we want to load a binary file from an Accord Project archived (zip) it would be useful to extend the file loader with a loadFromBuffer method. This avoids turning it into a string (which performs additional normalisation, etc).
https://github.com/accordproject/cicero/pull/525#discussion_r397087125

I think this is resolved. Scream if not.


Add upload task to configuration

Previously, only a data task was being created when executing fetch. This adds the ability to designate a request as an IOSUploadTask on the RNFetchBlobConfig object. Doing so will also store the HTTP body of the request to a temporary file.

Might be worth adding a commit to document IOSUploadTask, and possibly IOSBackgroundTask too?


Mesh instance UV2 unwrapping improvements

The new option to set the unwrap mesh UV2 option in PrimitiveMeshes from the MeshInstance3DEditorPlugin now respects the global rules which disallows modifications to foreign resources and pre-emptively shows more informative error messages for common ArrayMesh unwrapping fail cases rather than conveying a generic popup error message and providing the actual information as a notification.

Updated, removed redundant explicit casting.

Fixed

Thanks!


Update to latest ICU4j library

The current version is 61.1. There is a security vulnerability reported for all versions lower than 63.1:
https://nvd.nist.gov/vuln/detail/CVE-2018-18928

I see DITA OT 3.7 already comes bundled with icu4j version 70.1


Add screenshots to /help/global-times

We should use actual screenshots to illustrate what messages with global times look like in https://chat.zulip.org/help/global-times#what-it-looks-like.
As suggested on CZO, we can try including a tooltip (just on the first one), and see how it looks.

CZO thread

Hey @alya , assign me this issue, working on it

@dakshkanaujia - Thanks for your interest in working on this issue! But I've got a PR up for it now.


Move plugin configs outside of plugin folder

Moves plugin configs to a dedicated folder(plugin_data) under data\[releaseChannel].
Adding a button to copy or sync configs across release channels might be useful but is likely outside the scope of this PR.
If merged, this change may prompt some support requests from users who find their configs missing. We could consider a temporary popup on the next update to offer moving the configs or, alternatively, include a highlighted note in the subsequent changelog.

Folder changed to data/plugins to reflect the results of the recent poll.
I forwent adding a prompt of any kind, as it seemed a bit awkward to do without any translations. Scrapped toasts from the transfer function for the same reason.


Consider updating Roslyn binaries

I noticed that the Roslyn package we use is super old.
https://github.com/microsoft/dotnet-framework-docker/blob/66cfc9536db13fa27b82c2bc33fd916e5f583366/eng/dockerfile-templates/aspnet/Dockerfile#L18
We're using a version from 2018. https://www.nuget.org/packages/Microsoft.Net.Compilers/
This package should probably get updated every time we release (as a checklist item). I'd recommend looking at all the content we curl down. It looks like there are some other assets that might be stale.
/cc @jaredpar

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

cc @HongGit

#786


Low coupling coefficient of transformer

The current transformer design should ensure a coupling coefficient of approximately 0.8-0.9, but current measurements show only 0.5.
Hypothesis:
Stray inductance in the primary winding is likely due to a questionable design of the primary windings.
Outcomes:

Overheating C1 battery, i.e. loosing energy
High load on H-Brindge and promary winding due to high-volatage ~1 kV in primary windings

Problem is clear now - parasitic inductance of wires.
Parallel winding in the primary inductive was bad idea.
New transformer desing coming soon.

Alternative solution - bring transfer as closest as possible to H-Bridge. Max distance - 5-10 cm.

Current transformer design doesn't fit.
Current transformer ratio definetely not enough.
New transformer design wto be ready by the middle of November

New transformer design uploaded https://github.com/kinetikalab/project_aetheris/blob/main/power_electronics/transformer/README.md
To be tested next week in real conditions.

Transformer design updated
https://github.com/kinetikalab/project_aetheris/blob/main/power_electronics/transformer/README.md
The problem was with parasitic capacity. Now it fixed. New transformer has very low parasitic capacity ~10 pF.
Tested in discharge - works perfect.


Create background image

Hi Vedasree,
i would like to work on your project.
please assign me the task!!
TY!

#4 added the image. hope u like it!!


drivers: pcie: add config support for enable PRT PCI Routing Table

Add config support for enable IRQ information retrieve via ACPI PRT (PCI Routing Table).
Fixes #63504

Waiting for Andrei to confirm

Waiting for Andrei to confirm

This works, but the question is: do we need ACPI for those boards? Was ACPI only used for IRQ allocation?

Waiting for Andrei to confirm

This works, but the question is: do we need ACPI for those boards? Was ACPI only used for IRQ allocation?

ACPI is not only use for retrieving interrupt routing info, but for CPU config etc. as well.

@najumon1980 there are a couple of build failures (at least on qemu_x86 as well as acrn_ehl_crb

@najumon1980 there are a couple of build failures (at least on qemu_x86 as well as acrn_ehl_crb

Talking about deprecation, acrn_ehl_crb is a good candidate for it. I recently tested ACRN and used acrn board on EHL.

@najumon1980 there are a couple of build failures (at least on qemu_x86 as well as acrn_ehl_crb

Talking about deprecation, acrn_ehl_crb is a good candidate for it. I recently tested ACRN and used acrn board on EHL.

Yes we can remove the EHL ACRN since it does not enable any passthrough devices (PCI devices) and the board config is same as "acrn" board.

@najumon1980 there are a couple of build failures (at least on qemu_x86 as well as acrn_ehl_crb

Talking about deprecation, acrn_ehl_crb is a good candidate for it. I recently tested ACRN and used acrn board on EHL.

Yes we can remove the EHL ACRN since it does not enable any passthrough devices (PCI devices) and the board config is same as "acrn" board.

We can remove the acrn_ehl_crb in the next release, need to update ACRN documentation.


Feature/fix array notif add notify specific user

Fixed notification of arrays not working at all
Added allServers option: notifications will be broadcasted to the entire cluster, not only the servers that handle a specific tenant (servers only receives a notification if they have a user for tenant being notified)
Added onlyUserId option: notify only a specific user instead of all the users of a tenant.

New options are currently not unit tested.


Fix - TRSV2-259: increased sentry errors  - develop

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@fc14f84). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 59d9fe9 differs from pull request most recent head b4ca279. Consider uploading reports for the commit b4ca279 to get more accurate results

@@            Coverage Diff             @@
##             develop     #162   +/-   ##
==========================================
  Coverage           ?   40.06%
==========================================
  Files              ?       78
  Lines              ?     3534
  Branches           ?      451
==========================================
  Hits               ?     1416
  Misses             ?     2095
  Partials           ?       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc14f84...b4ca279. Read the comment docs.


Insert global css after rehydrate recommended?

Is it recommended to call css.insert for global css after glamor has been rehydrated on the client, when the server has been called css.insert already?
Both of the following scenarios work. I just wonder if there's a difference between them.
Scenario 1:

Server

Insert global css with css.insert
Output HTML with style and glamor state

Client

Rehydrate from state

Scenario 2:

Server

Insert global css with css.insert
Output HTML with style and glamor state

Client

Rehydrate from state
Insert global css with css.insert (same as on the server)

You don't have to worry, glamor will make sure to dedupe and prevent redundant rules as long as you rehydrated correctly


WIP: Add riscv64 support

Proposed Changes
Get K3s working on riscv64
Types of Changes
hack
Verification
Testing
Linked Issues

https://github.com/k3s-io/k3s/issues/7151

User-Facing Change

NONE

Further Comments
Lots of caveats:

Only tested this on VisionFive2
Requires a custom kernel, as the one shipped by StarFive is missing pretty much everything - cgroups, iptables, vxlan, and so on. It is easy enough to rebuild a custom kernel and pack it into a flattened image tree that can be dropped in place of the existing one on the boot partition, using the sources at https://github.com/starfive-tech/VisionFive2
Don't have a static buildroot for riscv64 yet; at the moment I'm just using the riscv64/alpine:edge base image.

Currently working, with both docker and containerd:
/ # kubectl run busybox --restart=Never --rm -it --image docker.io/library/busybox:latest -- uname -a
Linux busybox 5.15.0 #4 SMP Thu Apr 13 00:16:53 UTC 2023 riscv64 GNU/Linux
pod "busybox" deleted
/ # kubectl get node -o wide
NAME           STATUS   ROLES                  AGE   VERSION                INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                   KERNEL-VERSION   CONTAINER-RUNTIME
k3s-server-1   Ready    control-plane,master   80s   v1.26.3+k3s-73fec085   <IP_ADDRESS>    <none>        K3s v1.26.3+k3s-73fec085   5.15.0           containerd://1.6.19-k3s1

root@riscv01:~# kubectl get node -o wide
NAME                STATUS   ROLES                       AGE   VERSION                INTERNAL-IP   EXTERNAL-IP   OS-IMAGE       KERNEL-VERSION   CONTAINER-RUNTIME
riscv01.lan.khaus   Ready    control-plane,etcd,master   78s   v1.26.3+k3s-398089cd   <IP_ADDRESS>    <none>        Ubuntu 22.10   5.15.0           docker://20.10.21

root@riscv01:~# kubectl run busybox --restart=Never --rm -it --image docker.io/library/busybox:latest -- uname -a
Linux busybox 5.15.0 #4 SMP Thu Apr 13 00:16:53 UTC 2023 riscv64 GNU/Linux

Here's a copy of the kernel config I'm currently using, in case anyone wants to play with this on their own:
config.gz

@brandond - check out ubuntu official starfive vision five 2 image, k3s-check script reports almost all-green lines and it's much easier to start with this build than build on your own. This kernel (6.2) contains some fixes from upstream and don't have issues like limited to 4GB memory on 8GB boards.
So far I found that only green led and nvme is problematic, that may be fixed soon. If You already updated u-boot then just burn eMMC or sd card.

This is implemented using cross-compiling in #7778.

I'm going to close this out - this was mostly just for me to tinker with, and the linked PR is much more comprehensive.

@brandond  thanks for information, should we see first binaries in next releases? I'll test them out :)

No, we don't have a solid timeline for even experimental binaries out of our CI pipeline. We will likely have to deal with some issues around riscv64 versions of our required images before we can move this forward.


useKeycloak hooks always returns keycloakStubInstance in next.js

Describe the bug
I am using @react-keycloak/ssr to build my next.js application
useKeycloak hook always returns a stub instance of keycloak so
createLoginUrl always returns an empty string.
I suspect that the problem is that the variable called initialized is always false, probably because of a problem with the SSR.
https://github.com/panz3r/react-keycloak/blob/master/packages/nextjs/src/useKeycloak.js#L11
I've tested it with react-keycloak-examples and I'm seeing similar symptoms.
I'm not sure if this is a bug or my lack of configuration.
To Reproduce
Steps to reproduce the behavior:

Get react-keycloak-examples
set keycloakCfg
yarn dev
Debug login button event

Expected behavior
I want to generate a link using createLoginUrl on the browser side.
Desktop (please complete the following information):

OS: Ubuntu
Browser chrome
Version

Additional context
Next.js version 9.4.4
@panz3r
Thank you for publishing a great library.
I gave a coffee fee through buymeacoffee.
This is my way of saying thank you.

Hi @rike422 ,
Thanks for your feedback, unfortunately when running server-side the stub for Keycloak is required (because keycloak-js requires a window object to be defined which is not available on Node) and currently the implemented one does not provide access to all the methods of keycloak-js, instead of using the createLoginUrl you should consider binding the login method of the keycloak instance returned by useKeycloak to the button.
Currently I'm working on a newer version of @react-keycloak/core which will allow a better experience also when using keycloak on the server-side.

Thank you for publishing a great library.
I gave a coffee fee through buymeacoffee.
This is my way of saying thank you.

Thanks, I really appreciate your support and I hope this library is helping you building your product as easily as possibile.

@panz3r
Thank you for reply!

unfortunately when running server-side the stub for Keycloak is required (because keycloak-js requires a window object to be defined which is not available on Node)

agree why stub is needed. though I have confirmed that stub is also used on the browser side.
I suspect that it is because the following line is not executed on the server side or context information is not carried over to the browser side.
https://github.com/panz3r/react-keycloak/blob/master/packages/nextjs/src/internals/context.js#L8

@panz3r
Sorry.
The problem was not solved.
I think the following line may not be executed in node.js or the state may not be inherited. When useKeycloak is executed in the browser, initialized is always false, so it's always returning a stub.
https://github.com/panz3r/react-keycloak/blob/master/packages/nextjs/src/internals/context.js#L8
I am using Next.js, but SSR is not required, so should I stop using SSRProvider and use KeycloakProvider?
I misunderstood that it was solved by the comment above because I forcibly set initialized to true in the forked react-keycloak project.
In that state, when using createLoginUrl, the adapter was undefined and did not work.
After changing createLoginUrl to login, the redirect was successful.

The following error is displayed when the javascript console is displaying a page.
This may be the cause because it is an error on the server side.
createReactKeycloakProvider
Uncaught ReferenceError: createReactKeycloakProvider is not defined at <anonymous>:1:1
``

Hi @rike422 ,
That is a strange error, I'm going to look into this issue in the coming days.
Thanks again for your feedback.

Hi @panz3r,
We are having the same issue on next-js, if you could look into it it would be nice 😄
Thanks for your help

Also encountering this issue :(

Hi @mattishii ,
The issue in the title should be resolved in the latest version (v3.0.0) of the @react-keycloak/ssrmodule.


[Menu] Colored variations of “.inverted.pointing.menu” should all have a colored pointer

Pointing indicator color in inverted colored pointing menu is wrong.
See on JSFiddle.

It would appear here:
https://github.com/Semantic-Org/UI-Menu/blob/master/menu.css#L1522
and here
https://github.com/Semantic-Org/UI-Menu/blob/master/menu.css#L1842
would be wear your issues are.. this is just my initial analysis so I could be completely wrong.
This seems to be where the pointing is defined
https://github.com/Semantic-Org/UI-Menu/blob/master/menu.css#L1809
.ui.pointing.menu .item:after {
  visibility: hidden !important;
}

That bit will hide it..
I believe the issue is with the CSS for it not being defined... (Just looking at the repo)
This should fix the issue:
.ui.inverted.green.three.item.pointing.menu .active.item:after {
  background-color: #3ca83e !important;
  /* color: #3ca83e !important; */
}```

Why this bug still here?!!

It’s in the process of being fixed, somebody already opened a PR the other day. Closing the issue as a duplicate of #2355.