_ExtraSdkVersion causes build break in 15.2

Packing a project with Dev15.2 fails with this:
msbuild /t:pack

C:\Users\andre.nuget\packages\msbuild.sdk.extras\1.0.4\buildMultiTargeting\MSBuild.Sdk.Extras.targets(8,14): error MSB4086: A numeric comparison was attempted on "$(_ExtrasSdkVersion)" that evaluates to "" instead of a number, in condition "'$(IncludeBuildOutput)' == 'true' and '$(_ExtrasSdkVersion)' < 2.0". [E:\git\c5\C5\C5.csproj]

v1.0.3 works fine. It breaks with v1.0.4

Should be fixed now in the 1.0.5-beta on the CI feed, can you validate? Issue was that the property detection was only in the single TFM targets and not the mutitargeting one.

Should be fixed in 1.0.5.

Thanks. I was camping till a few hours ago so I couldn't get to this earlier to validate.

np, please lmk if it's still not working for you


attempted fix of travis

Codecov Report

Merging #4241 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4241   +/-   ##
=======================================
  Coverage   88.65%   88.65%
=======================================
  Files          18       18
  Lines        2018     2018
=======================================
  Hits         1789     1789
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2022c...6257a2c. Read the comment docs.

not working

do not merge


Changed date format for certificate generation

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue: Closes #8859

Description

Changed the date formatting on generated certificates in order to match the image posted.

Its interesting that we have two PR's (this and #8863) almost simultaneously for the same issue.
:sparkles:  JINX :sparkles:
But this change will actually address the view of a user's certification, which we [also] want of course.
I have hence removed the closes tag (to prevent issue closure) and changed it to refers.
Nevertheless thanks for this @jaydenwindle !


Proto_IkePacket.c: fix MD5, SHA-256, SHA-384 and SHA-512 implementation

Fixes #552.
#294 added SHA-256, SHA-384, and SHA-512 support to the protocol, but part of it was removed in faee11ff096e7950b006ef1ae8dc636b6fe0131e, because it caused a buffer over-read crash.
It also broke the MD5 implementation because the switch-case block doesn't handle the type anymore:
https://github.com/SoftEtherVPN/SoftEtherVPN/blob/8fdd224ba7f5676f99d74c7c63f60e046d07ec97/src/Cedar/Proto_IkePacket.c#L2982-L2996
This pull request fixes all the implementations and improves the IkeHMac() function by using the dedicated hashing functions.

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
I choose option 1.

Hi. It seems that it doesn't work again on windows xp. Build 9744


c5d instances intermittently fail to get added to SGE

@tanantharaman reported in https://github.com/aws/aws-parallelcluster-cookbook/pull/141#issuecomment-480632129
Looks like the problem is not fully fixed for m5d instance types : instead the problem has become intermittent : I am using ParallelCluster 2.3.1 and find that around 4 out of 5 times the m5d.24xlarge (or m5d.metal) node is added without problem but around 1 out of 5 times it fails to add the node to SGE. I am able to ssh to the node from the master (using the public IP) and the /var/log/cfn-init.log (attached) shows a problem with the ephemeral drives.
Relates to issue #415
cfn-init.log
cfn-init-cmd.log
cfn-wire.log
dmesg.log
It would help if the node recovers without mounting the ephemeral drives when there is a problem instead of hitting an unhandled exception and leaving the node running but not added to SGE : In my case I had only one job in the SGE queue and jobwatcher on the master node keeps saying no more scaleout needed (desired= 1), but my job never runs.

This was fixed in #299 and will be included in the next release


Add python_requires to setup.py

https://github.com/JonathonReinhart/scuba/blob/516a513c63d466ee8dddffb85c397b1e42dec35c/setup.py#L51

I was able to find a pathway to install and use the master branch of gitlab-art on ubuntu:16.04 (end-of-life April 2026) which still uses python 3.5. It's probably not unreasonable to expect that someone may have a Docker image based on ubuntu:16.04 and would want to run this version of art without a virtual env.
I don't see any reason to say we don't support >=3.5, even though it's end-of-life, and even though starting to use some 3.7 features would be nice. At some point, our dependencies like click and gitlab-art are going to require us to upgrade.
# apt update ; apt install python3 python3-pip

## First upgrade to pip 9.0.0 to support python_requires
## then upgrade to the latest pip that supports python-3.5
# pip3 install --upgrade pip==9.0.0
# pip3 install --upgrade pip

# pip3 install ./kosma/gitlab-art
# /usr/local/bin/pip3 freeze
DEPRECATION: Python 3.5 reached the end of its life on September 13th, 2020. Please upgrade your Python as Python 3.5 is no longer maintained. pip 21.0 will drop support for Python 3.5 in January 2021. pip 21.0 will remove support for this functionality.
appdirs==1.4.4
certifi==2021.10.8
chardet==4.0.0
click==7.1.2
gitlab-art @ kosma/gitlab-art
idna==2.10
python-gitlab==1.15.0
PyYAML==5.3.1
requests==2.25.1
six==1.16.0
urllib3==1.26.9

Closed in #32


fix: socket.connnect JS : Scope & Closures

when io reconnect, a new socket well create.
but from front socket not be updated
the commit is fix it by global.elesocket
please check, or better method

Hi @mojinxun
Your changes seems to touch some non related files. Could you cleanup this PR or open a new one with only the needed changes from you?
Thanks!

ok， I create nuget, something error, so I delete it

I update it, please review it

@GregorBiswanger Please take a look.

@GregorBiswanger What about this PR?


Removed sex chromosomes from pulldowns by default and added option to GetHetCoverage and GetBayesianHetCoverage to include them.

Also some minor cleanup.
This is a quick fix that simply filters on "X" and "Y" in the contig name.  Note that this is not analogous to how sex chromosomes are handled in coverage collection, where we only collect coverage at targets specified in a file---which does not include targets on X and Y.  So the analogous thing to do would be to exclude SNPs on X and Y from the common SNP list we use to collect het coverage.
Also note that I didn't include a proper integration test for GetHetCoverage/GetBayesianHetCoverage because hg19mini.fasta doesn't include X or Y.
Closes #355.

@LeeTL1220 can you take a look at this?  I'm not actually convinced we should merge this (see comments above), but let me know what you think.

@samuelklee As per our discussion, are we going to keep this one open?

Let's close it without merging for now.


MarathonUI failed to capture stdout log for Helloworld example

I was able to launch the hello world example examples/hello-world/launch.sh. In the Marathon UI, I get an error whenever I try to access the error our output logs.
Image below.
Imgur

Ansible version (ansible --version): 1.9.6
Python version (python --version): 2.7.11+
Git commit hash or branch: 5cb8df5c373e0533324ef87f6e5db187d6bf6455
Cloud Environment: gce
Terraform version (terraform version):0.6.16

@Dacode45 unfortunately, this is a known issue and not something we can easily fix (requires changes to marathon). see #1530. the workaround is to view the logs from the mesos UI.


Failed to resolve 'rxjs/operators'

On build with parcel got this error:
🚨 Build failed.
@parcel/core: Failed to resolve 'rxjs/operators' from './node_modules/deox/dist/index.js'
./node_modules/deox/dist/index.js
./node_modules/deox/dist/index.js:7:25
  6 | var tslib_1 = require('tslib');
> 7 | var operators = require('rxjs/operators');
>   |                         ^^^^^^^^^^^^^^^^
  8 |
  9 | /**

Unfortunately, NPM doesn't support optional peer dependency. As denoted in package.json this library has a peer dependency on rxjs. So you should install it.

I understand, thanks


Cannot build the application.

Follow the README, I downloaded the code and run such script to build the example app:

I expect it to output:

But it actually output some errors:

I don't have any idea about this. Could you help me?
Information

version:
platform:
OS:

Same here, I've even tried with adding even more no code:

I'm on   OS too.

@AkdM well, you may try to install   before build, it help reduce some errors, but I still cannot generate a runnable app. It seems that the dependency of   has been out of date.

Got it, but I guess I will just have to wait an hotfix from the maintainers.
Problem is… my business uses this no code as its core feature. I am loosing millions right now.

@zhaoyao91 you need NoMachine to run this code

@tarikhagustia Genius! I have bought NoMachine, only to find I were unable to manipulate it. After sometime, my friend NoBody came to me and helped me out.  I really appreciate you smart guys~

Did you trying turn off and turn on it again?

@galpratama well, it seems no effect, since no machine uses no power, there is no way to turn off.


"scope" appears to be required

Received this response: The request body must contain the following parameter: 'scope', but scope is only listed as "Recommended" and not "Required"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b3eac288-4ddd-1099-1c86-885aa42a566f
Version Independent ID: 190585ca-8337-0644-2182-75b77f53c175
Content: Microsoft identity platform and OAuth 2.0 Resource Owner Password Credentials - Microsoft identity platform
Content Source: docs/identity-platform/v2-oauth-ropc.md
Service: identity-platform
GitHub Login: @OwenRichards1
Microsoft Alias: owenrichards

@thedanhoffman
Thanks for your feedback! We will investigate and update as appropriate.

@thedanhoffman
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Fix lstrip() calls.

We might want to consider a lint rule here, but these were the only two places we misused lstrip() in the codebase, so maybe not a huge thing to watch for.
The second use of lstrip() was certainly harmless but probably unintentional.

Great, merged, thanks @showell!


Tensor shape signature is not parsed safely with ParseTensors of TF Lite InterpreterBuilder on Big Endian machines

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): N
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 20.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.3.1
Python version: 3.8.5
Bazel version (if compiling from source): 3.1.0
GCC/Compiler version (if compiling from source): gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
Currently, InterpreterBuilder is retrieving the shape_signature field of a flatbuffer tensor in the following way:
    size_t dims_signature_rank = 0;
    const int* dims_signature_data = nullptr;
    if (tensor->shape_signature()) {
      dims_signature_rank = tensor->shape_signature()->size();
      dims_signature_data = tensor->shape_signature()->data();
    }

The type of tensor->shape_signature() is a flatbuffer int array (flatbuffers::Vector), and accessing it using data() method is not safe as the data is always stored in Little Endian format, which will break for Big Endian machines. So whenever this optional shape_signature field is set in a TF Lite model, the interpreter will break on Big Endian machines.
To access the data correctly, we should use the Get() method of the flatbuffer array. There actually is a handy function defined in InterpreterBuilder already, FlatBufferIntArrayToVector, which is used for retrieving the tensor->shape() field as follow:
std::vector<int> dims = FlatBufferIntArrayToVector(tensor->shape());

This helper function definitely could work for tensor->shape_signature() as well because they both are integer array fields. The only issue is that currently, we are expecting two variables dims_signature_rank and dims_signature_data in the SetTensorParametersReadWrite function that we need to call later rather than an std::vector.
I have also tried some other methods to use Get() to retrieve the data, but it is a bit tricky as we need the shape signature data to live long enough for the SetTensorParametersReadWrite to finish writing the data into tensor.dims_signature field. To avoid making lot of changes and introducing new variables, I wonder if we could change the SetTensorParametersReadWrite function signature to make it accept one dims_signature vector instead of one size variable and one data variable. This could work because in tensorflow/lite/core/subgraph.h, the expected input arguement is like this:
inline TfLiteStatus SetTensorParametersReadWrite(
      int tensor_index, TfLiteType type, const char* name,
      const std::vector<int>& dims, TfLiteQuantization quantization,
      bool is_variable = false, const size_t rank_dims_signature = 0,
      const int* dims_signature = nullptr) {
    return SetTensorParametersReadWrite(tensor_index, type, name, dims.size(),
                                        dims.data(), quantization, is_variable,
                                        rank_dims_signature, dims_signature);
  }
  TfLiteStatus SetTensorParametersReadWrite(
      int tensor_index, TfLiteType type, const char* name, const size_t rank,
      const int* dims, TfLiteQuantization quantization,
      bool is_variable = false, const size_t rank_dims_signature = 0,
      const int* dims_signature = nullptr);

Here we are using a reference to the dims vector and pass its size and data respectively to the function so that it will outlive the function call - the exact same thing could be done for dims_signature as well. If we get rid of dims_signature_rank and dims_signature_data and pass on a vector of dims_signature, we only need to make changes to these two places.
If such solution could work I will likely start a PR to it. Otherwise, please let me know if there are some other convenient ways to fix the parsing of shape_signature, thanks.
Describe the expected behavior
The shape_signature field should be parsed correctly on Big Endian machine.
Standalone code to reproduce the issue
bazel test --host_javabase="@local_jdk//:jdk" --cache_test_results=no --build_tests_only --test_output=errors -- //tensorflow/lite/python:lite_v2_test

This test will fail on Big Endian machines.
Other info / logs

It's tricky to fix it here since I can't find Big Endian machines.
Please feel free to send a PR. I can review it.

Thanks for the reply, I will test it using the approach I mentioned and send a PR shortly.

Maybe we'd better use https://github.com/tensorflow/tensorflow/issues/45009 for further discussion.

Close issue as PR has been merged.

Close issue as PR has been merged.


Multiple layers in TopoJSON vector tiles

This change introduces layerName and layers options on ol.format.TopJSON. This is useful when using TopoJSON vector tiles. It adds a grouping capability equal to ol.format.MVT.
This new feature is shown in an updated osm-vector-tiles.html example, and in a simplification of the topojson.html example. For osm-vector-tiles.html, now that Mapzen introduces quite low tile request limits, it is better to request only one tile set instead of three.

Updated the pull request to use the same API as in ol.format.MVT.

What wording were you envisioning @fredj? Existing apps continue to work without change.

@fredj: Or do you just want me to squash the commits - nameAsProperty was introduced with this PR's first commit, and then changed to layerName

Commits squashed.


Double path dir after error

Typing anything in code editor and running it will display an error. Game will exit and terminal will print out your dir path two times.
For example:

Type in code editor:
asdasd
Now, type run in terminal.
Game crash and you will see:
/> />

This patch will make terminal display /> only once.

Thanks !


RDK-29650 : AVInput Plugin failed to init HDMIInput

(cherry picked from commit 675aa0adb90bc0c92083fe4f78f48e76d6d119b0)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing because of conflicts. Created separate PR.

Closing because of conflicts. Created separate PR.


Add task definition family and revision to module outputs

Can be used by other tools to update the service

IMO no need to change README.yaml. The updated README.md is already in the PR.


Feat Request: Config filetypes like .Yaml, .Toml and .HCL

Description
Would be nice to have support added, the structure itself is very similar to Json, but tabbing is used to nest instead of moustache trees.
A sample of Yaml
# Docker Compose file for running a Ruby on Rails app
version: '2'
services:
  db:
    image: postgres
  web:
    build: .
    command: bundle exec rails s -p 3000 -b '<IP_ADDRESS>'
    volumes:
      - .:/myapp
    ports:
      - "3000:3000"
    depends_on:
      - db

A sample of Toml
baseurl = "http://yoursite.example.com/"
builddrafts = false
canonifyurls = true

[taxonomies]
  category = "categories"
  tag = "tags"

[params]
  description = "Tesla's Awesome Hugo Site"
  author = "Nikola Tesla"

a sample of HCL
resource "aws_security_group" "ssh" {
    name        = "ssh"
    description = "Allow all inbound SSH traffic"

    ingress {
        from_port   = 22
        to_port     = 22
        protocol    = "tcp"
        cidr_blocks = ["<IP_ADDRESS>/0"]
    }
}

Checklist
I have:

[x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue

Not a bug, so other tickboxes don't apply

still an issue

To clarify, you are requesting that beautifiers be added to support these types of files?

yes please 👍 😃

Do you know of any beautifiers out there for these filetypes for reference?


FilterBox control does not display

I've documented an issue I have with the FilterBox control in the attached pdf (with screen shots). This, I think, explains succinctly the issue. It's a very quick read. The orc:FilterBoxControl simply does not show, neither in design mode nor in debug mode.
This may be a newbie problem. I appreciate any help. Thank you kindly.
Issue FilterBoxControl.pdf

So sorry - wrong project.


Catch up Swift 4 snapshot 2017-09-16

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is 100%.


Make profile at top and editor at bottom of page (or make editor a modal that pops up)

-Switched profile and form display
-to revisit issue later to update form to modal


API-1509: Add aesgcm to EncryptionConfig

This PR reverts https://github.com/openshift/api/pull/1413 that incorrectly added aesgcm as a techpreview feature when this feature is targeting GA this release: https://issues.redhat.com/browse/API-1509

/cc @tkashem @mfojtik
/assign @deads2k

/lgtm

Have the implementation and tests passed?  Once they are in and passing, promoting to GA is appropriate and can be done in the same release

Implementations have been merged in 4.13:

https://github.com/openshift/cluster-kube-apiserver-operator/pull/1458
https://github.com/openshift/cluster-authentication-operator/pull/598
https://github.com/openshift/cluster-openshift-apiserver-operator/pull/521

E2E tests have also passed and been merged in cluster-kube-apiserver-operator as part of: https://github.com/openshift/cluster-kube-apiserver-operator/pull/1458.
I am planning to add these new tests to the other operators as a follow up, but it would be great if we could get this PR merged beforehand since having the API as techpreview currently requires the CI jobs to run in special tech-preview environment.

Closing in favor of https://github.com/openshift/api/pull/1419


Cannot get the pagination working

Hi!
In my child component I have the following import:
import { PAGINATION_DIRECTIVES } from 'ng2-bootstrap/ng2-bootstrap';
in template files:
<pagination [totalItems]="totalItems" [(ngModel)]="currentPage"  (pageChanged)="pageChanged($event)">
in the browser console got the following error message:
EXCEPTION: Template parse errors:
Can't bind to 'totalItems' since it isn't a known native property ("

][totalItems]="totalItems" (pageChanged)="pageChanged($event)">
What is wrong here?
Could you please help me to solve this issue? Thank you!

Did you installed ng2-bootstrap via npm ?

did you declare
directives = [PAGINATION_DIRECTIVES ],

Yes, I did.
Angular version can be the cause of this issue? I am using angular rc4

I had similar problem, try to look at #667 maybe this will help you.

Same problem here:
I am trying to use ng2-table. In the demo, It uses pagination
<pagination [totalItems]="totalItems"             [(ngModel)]="page"             (pageChanged)="onChangeTable(config, $event)"> </pagination>
I get this error:
Error: No value accessor for ''

Sorry, it was fixed. I think you need to update demo on :
http://valor-software.com/ng2-table/

@hoangnguyenba, @veaceslavz , how were u able to fix this?
I've added an issue 815 as well. Is this something you were facing?

Pagination not working. Anybody knows workaround?

not working with rc-6

ng2-bootstrap 1.1.1 is for Angular RC6
ng2-bootstrap 1.1.0 is for Angular RC5
ng2-bootstrap 1.0.24 is for Angular RC4
Don't mix the versions because it will not work. The reason is, that the Angular 2 team made breaking changes between RC4 and RC5 and between RC5 and RC6.

I have<EMAIL_ADDRESS>and @angular RC6 and still have this problem.  I have imported the PaginationModule in my app's @NgModule and still get the error:  "Can't bind to 'totalItems' since it isn't a known property of 'pagination'."

@gimmeshelter can you show us your ngmodule annotation code which imports the pagination and the template which causes the error?

@Martin-Wegner ,
Sorry, I should know better than to not include the evidence.  Here are the details:
app.module.ts
// Angular Imports
import { NgModule } from '@angular/core';
import { Router } from '@angular/router';
import { BrowserModule } from '@angular/platform-browser';
import { APP_BASE_HREF } from '@angular/common';
import { HttpModule } from '@angular/http';

// 3rd Party Imports
import { PaginationModule, PaginationComponent } from 'ng2-bootstrap/components/pagination';

// Project App Imports
import { AppComponent } from './app.component';
import { router, appRoutingProviders } from './app.routing';
import { ApiHttpModule } from './core/http/api_http.module';

// Project Component/Module Imports
import { HomeModule } from './components/home/home.module';
import { ReviewsModule } from './components/reviews/reviews.module';
import { NavComponent } from './components/nav/nav.component';

// Project Service Imports
import { ReviewsService } from './services/reviews/reviews.service';

@NgModule({
    imports: [
        BrowserModule,
        HttpModule,
        router,
        ApiHttpModule,
        PaginationModule,
        HomeModule,
        ReviewsModule,
    ],
    declarations: [AppComponent, NavComponent],
    providers: [
        {
            provide: APP_BASE_HREF,
            useValue: '/',
        },
        appRoutingProviders,
        ReviewsService
    ],
    bootstrap: [AppComponent],
})

export class AppModule { }

Usage from the template:
<pagination class="pagination-sm" [totalItems]="reviewsResp.totalItems" [(ngModel)]="currentPage" [maxSize]="7"
                [itemsPerPage]="reviewsResp.itemsPerPage" [boundaryLinks]="true" [rotate]="true" (numPages)="numPages = $event"></pagination>

The error I see:
zone.js:461Unhandled Promise rejection: Template parse errors:
Can't bind to 'totalItems' since it isn't a known property of 'pagination'. ("
            </div>
        </div>
        <pagination class="pagination-sm" [ERROR ->][totalItems]="reviewsResp.totalItems" [(ngModel)]="currentPage" [maxSize]="7"
                [items"): ReviewsComponent@39:42
Can't bind to 'ngModel' since it isn't a known property of 'pagination'. ("div>
        </div>
        <pagination class="pagination-sm" [totalItems]="reviewsResp.totalItems" [ERROR ->][(ngModel)]="currentPage" [maxSize]="7"
                [itemsPerPage]="reviewsResp.itemsPerPage" [b"): ReviewsComponent@39:80
Can't bind to 'maxSize' since it isn't a known property of 'pagination'. ("  <pagination class="pagination-sm" [totalItems]="reviewsResp.totalItems" [(ngModel)]="currentPage" [ERROR ->][maxSize]="7"
                [itemsPerPage]="reviewsResp.itemsPerPage" [boundaryLinks]="true" [rota"): ReviewsComponent@39:106
Can't bind to 'itemsPerPage' since it isn't a known property of 'pagination'. ("-sm" [totalItems]="reviewsResp.totalItems" [(ngModel)]="currentPage" [maxSize]="7"
                [ERROR ->][itemsPerPage]="reviewsResp.itemsPerPage" [boundaryLinks]="true" [rotate]="true" (numPages)="numPages"): ReviewsComponent@40:16
Can't bind to 'boundaryLinks' since it isn't a known property of 'pagination'. (" [(ngModel)]="currentPage" [maxSize]="7"
                [itemsPerPage]="reviewsResp.itemsPerPage" [ERROR ->][boundaryLinks]="true" [rotate]="true" (numPages)="numPages = $event"></pagination>
    </div>
    <d"): ReviewsComponent@40:58
Can't bind to 'rotate' since it isn't a known property of 'pagination'. ("ge" [maxSize]="7"
                [itemsPerPage]="reviewsResp.itemsPerPage" [boundaryLinks]="true" [ERROR ->][rotate]="true" (numPages)="numPages = $event"></pagination>
    </div>
    <div *ngIf="!!reviewsResp"): ReviewsComponent@40:81 ; Zone: <root> ; Task: Promise.then ; Value:

The template error comes from the ReviewsComponent, right? Why is this component not included in the declarations?
Offtopic: What is appRoutingProviders? Routing configuration must be imported!?

I see my mistake.  I did not import the PaginationModule in the ReviewsModule where the ReviewsComponent is declared, but rather thought it would flow down from the app module.  I apologize as I'm still getting used to the NgModule concept.
Offtopic: That was a vestige of a routing example from some previous RC.  It is not necessary now.
Thank you for your help, @Martin-Wegner

@Martin-Wegner I do not want to open a new issue but I have to ask if there is an additional step with the pagination component that I am missing.  I am using angular-ci release candidate 1.  I have a clickable pagination field, but I am getting all of the items on one page.    Shouldn't max-size or itemsPerPage limit the list?
Here are the steps that I took
Inside of my app.module
imports: [
BrowserModule,
FormsModule,
ReactiveFormsModule,
HttpModule,
PaginationModule.forRoot(),
RouterModule.forRoot(appRoutes)

],
Inside of my class I defined the values as
  maxSize:number = 15;
 bigTotalItems:number = 726; //hard coded for now
 bigCurrentPage:number = 1;
 numPages:number = 0;

Inside of my template I have took the example off the examples provided
 <div class="col-md-6">
        <pagination
            class="pagination-sm"
            [itemsPerPage]="15"
            [totalItems]="bigTotalItems"
            [(ngModel)]="bigCurrentPage"
            [maxSize]="maxSize"
            [boundaryLinks]="true"
            [rotate]="false"
            (numPages)="numPages = $event">
        </pagination>
    </div>


Pull documentation changes across to OOB branch

Changes should really have come directly to the OOB branch initially , this PR pulls them across.

Doc looks good


Dropdown disappears on clicking selection in Firefox on Mac

Running Firefox 72.0.2 (64-bit) on Mac.
Same issue as https://github.com/microsoft/vsts-extension-multivalue-control/issues/129. Attempting to select any option doesn't select and closes the dropdown. Works on Chrome on a Mac and Edge on Windows.

This issue should be fixed


Support Rails5

The major change would be using ApplicationRecord to replace inheritance from ActiveRecord::Base. Now we can just include CustomCounterCache::Model instead of
monkey-patching ActiveRecord::Base.
(This would be a big change and will drop support for older versions.)

@st0012 Thanks! Sorry for the delay, as I was on vacation. I'll take a look shortly.

+1 for this PR


Improper Server Configuration returns 401

Hi, i try to use this plugin in my flutter app.
I have an issue when i try to call loginCustomer.
woocommerce.loginCustomer(username: username, password: password)
GET https://www.mysite.com/wp-json/wp/v2/users/me
Status Code : 401
Unauthorized
i receive the token correctly but this call not work. Did y have any idea ?
I have install in my WP the JWT-Auth as your tutorial.
Tnk's

Hi i have found a solution but now the call work. The JSON arrived bu the response status is 403 !

Hello can you share the exact code you are using?

This is my code.
`class ProfileController extends ControllerMVC {
GlobalKey scaffoldKey;
GlobalKey loginFormKey;
UserAccount user = new UserAccount();
bool hidePassword = true;
String baseUrl = "https://www.myWebSite.com";
String consumerKey = "my_key";
String consumerSecret = "my_secret";
WooCommerce wooCommerce;
//WooUser customer;
ProfileController() {
this.scaffoldKey = new GlobalKey();
loginFormKey = new GlobalKey();
wooCommerce = WooCommerce(
baseUrl: baseUrl,
consumerKey: consumerKey,
consumerSecret: consumerSecret,
isDebug: true,
);
}
void getCurrentUser() async {
}
Future login() async {
if (loginFormKey.currentState.validate()) {
loginFormKey.currentState.save();
try {
await wooCommerce.logUserOut();
dynamic customer = await wooCommerce.loginCustomer(username: user.username.toLowerCase(), password: user.password);
print(customer);
} catch (ex) {
print(ex.toString());
}
}
}
}
`
i Receive token correctly but when your plugin call this function ""
GET https://www.myWebSite.com/wp-json/wp/v2/users/me
Status Code 403
But i receive the correct json in response body
{"id":52,"name":"my.name","url":"","description":"","link":"https:\/\/www.myWebSite.com\/author\/my-name\/","slug":"my-name","avatar_urls": ........
The function that receive wrong response is
`
/// Fetches already authenticated user, using Jwt
///
/// Associated endpoint : /wp-json/wp/v2/users/me
Future fetchLoggedInUserId() async {
_urlHeader['Authorization'] = 'Bearer '+_authToken;
final response =
await http.get(this.baseUrl + URL_USER_ME, headers: _urlHeader);
if (response.statusCode >= 200 && response.statusCode < 300) {
  final jsonStr = json.decode(response.body);
  if (jsonStr.length == 0)
    throw new WooCommerceError(
        code: 'wp_empty_user', message: "No user found or you dont have permission");
  _printToLog('account user fetch : '+jsonStr.toString());
  return jsonStr['id'];
} else {
    WooCommerceError err =
    WooCommerceError.fromJson(json.decode(response.body));
    throw err;
}

}
`

This likely has to do with your websites firewall, security configuration, or conflicting plugins. Do check this https://wordpress.org/support/topic/wp-rest-api-users-endpoint-returns-403-error/

ok i have fix by server configurations

Awesome. That's great.

@RayOkaah if it is fixed can u close it................Good work.

Hi i have found a solution but now the call work. The JSON arrived bu the response status is 403 !

Hi. Can you share what did you do? I have the same problem -
Status Code : 401
Unauthorized
I receive the token correctly but this call not work. Did y have any idea?
(So, I get the token correctly, but User is Unauthorized return)


handle different url of magma maintained 1.12.2

fix #2562

https://github.com/farafonoff https://github.com/aruneko please also review this


Specify smiles and box vector fixes

This is a quick PR to:

Allow the user to specify current SMILES along with a proposal molecule (this is to avoid the troubles related to round-tripping through an OpenMM Topology).

Ensure that equilibrium samples are written out with box vectors. It seems that even though the option was enabled as true, and the system had box vectors, periodic boundary conditions, and a barostat, the reporters do not write out box vectors unless the Topology object also has them. This has been remedied by setting the Topology box vectors to the default system box vectors before any simulation.

Would be good to get this merged when ready so we can open bugfix-specific PRs to fix the issues we just identified.

I think this is ready to merge

This actually looks really broken.
@pgrinaway : Can you schedule some time Thu to go through this with me?

@pgrinaway @hannahbrucemacdonald : I'm just going to merge this and pull the changes into #504 to keep fixing from there.


[FeedExpander] Fix item href being used as feed uri

Found this while debugging an url issue on the WordPress bridge

Makes sense, thanks for the fix!


The lint highlighter is marking the whole function for  missing-function-docstring

Issue Type: Bug
Behaviour
Expected vs. Actual
Expected: Before the most recent VSCode update, this would only make a small highlight on the first line of where the function is defined.
Actual: Linter will mark every line of the function with blue squiggly underlines, which is very distracting and makes it hard to see other linting issues.

Steps to reproduce:

Make a python file.
Define a function in the python file without adding a docstring.
Enable pylint for the python file in VSCode.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.9.7
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
Value of the python.languageServer setting: Pylance

User Settings

defaultLS: {"defaultLSType":"Pylance"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Pylance"

linting
• enabled: true
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: false
• flake8Path: "<placeholder>"
• lintOnSave: true
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: true
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "black"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: false
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: false
• optInto: []
• optOutFrom: []

insidersChannel: "off"

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2022.0.1786462952
VS Code version: Code 1.64.0 (5554b12acf27056905806867f251c859323ff7e9, 2022-02-03T04:23:11.224Z)
OS version: Linux x64 5.4.0-97-generic snap
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 4000)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
15.47GB (6.42GB free)

Process Argv
--no-sandbox --new-window /home/stian/LocalProjects/DeepLearning/optinet2 --crash-reporter-id 555d8fe7-2706-4fd0-b0bc-868f0b306f7a

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyl392:30425749
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dsc:30433058
pythonvs932:30410667
wslgetstarted:30433507
vs360cf:30404996
vsclayoutctrt:30425946
vsrem710cf:30416617
vscop841:30430977
vscscmwlcmc:30433760

Same problem, same versions of the Python extension and VS Code. Python version is 3.8.12, OS 18.04.1-Ubuntu.
The issue is extremely annoying, a workaround is to change linter or switch linting off completely. Hopefully there is a setting to switch back to a less distracting underlining visual.

@StianHanssen @kovla Please share the output from Output > Python. We are surfacing what pylint tells us. If you want this to mark less, you may have to file this on pylint (see here https://github.com/PyCQA/pylint/issues/5466)

Thanks @karthiknadig. Is there an option of installing an older version of the Python extension? If so, where to find it?

@kovla You can do this from the extensions view. Click on the gear icon next to the extension:

@StianHanssen @kovla Please share the output from Output > Python. We are surfacing what pylint tells us. If you want this to mark less, you may have to file this on pylint (see here PyCQA/pylint#5466)

It definitely seems to be an issue in pylint but what iteration of VS Code / the extension started supporting and using the error range data coming from pylint? So far, no matter how far back I revert the python extension, pylint is still marking everything due to missing docstrings.

If you pin pylint=2.11.1 it might work better. This change was added in version 2022.0.* (see here https://github.com/microsoft/vscode-python/blob/0856eb26cbcc3a2ec5e15edaa6ef9cdddca32790/CHANGELOG.md?plain=1#L15)

Ah, I was changing the version of python extension locally not on my remote. Reverting to Python extension v2021.12.1559732655 also fixes the issue, though probably easier to pin pylint.
A workaround would be to let vscode python users disable using error ranges...


ConsumerRecords are organized per topic partition

ConsumerRecords has records organized per topic partition, not per topic as ConsumerRecords javadoc suggested.

@sslavic Usage doesn't seem to match the comment (not due to your change). It looks like KafkaConsumer.poll returns a single ConsumerRecords instance which contains all partitions for all topics, not just a particular topic. Perhaps we should change the comment to reflect that usage, and maybe separately we can consider if poll() should return List instead?

@hachikuji IMO after my change gets merged, it will match reality. ConsumerRecords has records grouped per partition (TopicPartition) and not per topic. Partitions included in ConsumerRecords can belong to different topics.

@sslavic I think my confusion is about the phrase "There is one for every," which I interpreted to mean one instance of ConsumerRecords (which doesn't match current usage). If it means something else, perhaps we just clarify what it refers to.

@hachikuji I've updated pull request, change now includes clarification for "There is one for every" topic partition - it was referring to list of ConsumerRecord returned by poll, mentioned in first sentence in same javadoc.

@sslavic Thanks, that is clearer to me now. +1

LGTM.


cosigned may improperly block multi-arch images

Description
As I was thinking about https://github.com/sigstore/cosign/issues/784, this was another (largely orthogonal) thought
tl;dr cosigned only verifies root-level signatures, which for multi-arch indices may not be where the signatures live!
As we deal with multi-arch images, the signatures may exist deeper in the tree than on the tagged entity itself, so unless we do recursive verification this is going to be limiting.  We also don't necessarily know which arch/platform/os to resolve for the image (consider heterogeneous clusters).
I think the check we really want here is: "every leaf image or one of its containing indices satisfies the check we are performing."
Right now, all we check is "is it signed?", so this is simpler, but if/as this expands into the broader policy space, this will get complicated fast.

Closing as outdated, @mattmoor lemme know if this is still relevant.


Largest Odd number in string added

Resolved #1280

@surbhi594 resolve merge conflict and also delete the other file

@surbhi594 u have deleted that file from the main repo. So send another PR without deleting that file.


[FEATURE] Indicate the active generator/tool

Description
When user clicks on a tool, it should show what too, the tasks:

[ ] Show the tool at the top by adding a text of the generator

Screenshots

Additional information
Read the contributing.md file and the readme
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
None

Can you assign it to me now? :)

Can you assign it to me now? :)

No

Hey @Dun-sin,
I want to work on this feature. Could you assign it to me?
Thanks

Hey @Dun-sin,
I want to work on this feature. Could you assign it to me?
Thanks

Sure, it's pretty simple, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck

Hey @Dun-sin,
I want to work on this feature. Could you assign it to me?
Thanks

Sure, it's pretty simple, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck

Thanks. I'm on it.

Hi @Dun-sin,
I just wanted to confirm one thing with you. As you mentioned the title of the tool should be visible in the top left corner (as highlighted in the top left corner in the screenshot). I've added that title to the generator tool like the one below. Is that okay?
N.B. Additionally I added the generator description as well.
Thank you!

Hi @Dun-sin,
I just wanted to confirm one thing with you. As you mentioned the title of the tool should be visible in the top left corner (as highlighted in the top left corner in the screenshot). I've added that title to the generator tool like the one below. Is that okay?
N.B. Additionally I added the generator description as well.
Thank you!

Just the name is needed, the description is not

Alright, so I'm removing the description. And shall I show the title on the top left?

Alright, so I'm removing the description. And shall I show the title on the top left?

As you see in the issue

Here's the final result. Let me know if it's okay or not

Here's the final result. Let me know if it's okay or not

Perfect👌🏽

Thanks! Raising the pr! 😁

:tada: This issue has been resolved in version 2.65.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[DPAS]: Use 2d-loads instruction to load the operand of tt.dot

The operands of the Triton's tt.dot operation should be loaded by using specialized instruction to load 2D blocks of the matrices.
Loading the operands in blocks is more efficient than loading them by using regular loads @llvm.genx.GenISA.LSCPrefetch.
We might need to leverage the semantic information associated with Tritons blocked pointers (https://triton-lang.org/main/getting-started/tutorials/08-experimental-block-pointer.html) in order to generate 2d-Blocked loads.

Liyang, please check how cuda handle stride_xx.

Liyang, please check how cuda handle stride_xx.

Triton CUDA pipeline lower 2d-load to TMALoadTiledOp which does not have limitation on the last dim strides.
For Triton XPU pipeline, if we want to leverage GenISA_LSC2DBlockRead, it requires last dim (stride[-1]=1) continuous for each block pointer.
For the first stage, in the pass of 2d load conversion lowering, we will check the stride attr type. If the type is a constant, and meets the 2d block load case, we can leverage genx.matrix.2Dblockload. Otherwise, it will fallback to regular loads. This is the fastest way to enable 2DblockLoad in our pipeline with limited functionalities.
For the second stage, we will consider the dynamic stride case. If the stride attr type is a variable, the lowering strategy is to using a conditional branching to decide the if the last dim stride is 1 at kernel runtime. Then pick the block loads or regular loads.

@LiyangLingIntel as per our discussion could you please split this ticket by stage

@LiyangLingIntel as per our discussion could you please split this ticket by stage

Sure, I have add 2 issues(https://github.com/intel/intel-xpu-backend-for-triton/issues/413 and https://github.com/intel/intel-xpu-backend-for-triton/issues/415) to split this ticket as 2 stages.

Helping with refactoring and code review.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 607

Questions ?
Please refer to the Backport tool documentation


Issues running it on Mac Intel (12.6)

It seems one of the dependencies of this gem: llhttp-ffi is failing to load the ffi library on x86_64 intel mac.
I'm seeing this on a CI instance (running from Macstadium machine), so it's a bit harder to debug.
It seems the library was installed correctly, which I assume compiled the native library, but when executing code it can't find/load it:
LoadError: cannot find 'llhttp-ext' library
/.../.rvm/gems/ruby-3.0.5/gems/ffi-compiler-1.0.1/lib/ffi-compiler/loader.rb:21:in `find'
/.../.rvm/gems/ruby-3.0.5/gems/llhttp-ffi-0.4.0/lib/llhttp.rb:13:in `<module:LLHttp>'
/.../.rvm/gems/ruby-3.0.5/gems/llhttp-ffi-0.4.0/lib/llhttp.rb:6:in `<top (required)>'
/.../.rvm/gems/ruby-3.0.5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `require'
/.../.rvm/gems/ruby-3.0.5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `block in require'
/.../.rvm/gems/ruby-3.0.5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:299:in `load_dependency'
/.../.rvm/gems/ruby-3.0.5/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `require'
/.../.rvm/gems/ruby-3.0.5/gems/http-5.1.1/lib/http/response/parser.rb:3:in `<top (required)>'
...

relevant dependencies from the Gemfile.lock:
    http (5.1.1)
      addressable (~> 2.8)
      http-cookie (~> 1.0)
      http-form_data (~> 2.2)
      llhttp-ffi (~> 0.4.0)

I've also noticed that llhttp-ffi has a new version released, but unsure whether it could help here or not.

This seems like an llhttp-ffi issue. Can you report it upstream?
What Ruby runtime/version are you using? I would expect MRI to use the C extension rather than FFI.

We should probably add macOS CI, but FWIW I am unable to reproduce this problem on an Intel MacBook

@tarcieri thanks for testing it out. It seems this is a bundler issue. I was trying out the new "global cache" setting and it seems to be breaking native libraries when trying to reuse/reinstall from the cache: https://github.com/rubygems/rubygems/issues/6616


Update LICENSE_HEADER.md with Apache 2 License URL

Updated the URL at Line 74
Description
Changed
https://inside.corp.adobe.com/intellectual-property/copyrights.html#jcr-content_par_tab_Adobe-Copyright-Notices
to
http://www.apache.org/licenses/LICENSE-2.0
Related Issue
#10
Motivation and Context
The Copyright URL was of the Adobe Corporate instead of Apache Copyright URL
How Has This Been Tested?
Markdown edit, doesn't require explicit testing.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I think we could actually just remove this section as it is not that helpful.

Shall I go ahead with removing the complete other license section or just the link line?
Also, though it might not be useful, having a direct link to the License file shares more detail and (personally) I believe it might be good to keep.

Yes if you can remove the section that would be great, and I would accept the PR.

Made the changes. Small confusion: I created a new commit to my fork's patch-1 branch. Does that also update this PR or do I need to do something extra?

Lol, sorry, I meant just  remove the "for more info check out this corporate URL" section 🙈
Maybe best to start fresh? I'll close this PR but if you're still up for it feel free to send another PR.


Avoid conflict with the "screenshot" package

Because base16-theme's "screenshot.el" is isn't a library intended to
be loaded using (require 'screenshot), it also should not provide a
feature.
There exists an actual package "screenshot", consisting of a library
that provides the feature screenshot.  To reduce the risk of
conflicting with that, also add the file "screenshots/.nosearch",
which makes it much less likely that "screenshot.el" ends up on the
load-path.

Hm, I guess I'll have to take your word for this. I thought it wouldn't be included in the actual built package because :defaults only included *.el... but this still seems reasonable.
Thanks!

You are right about that. This change is for the benefit of non-Melpa users and people contributing to it.


Demo link no longer working

http://demo.zipsell.org/ is down
Any way to see how the platform looks like without installing it?

Hello
Is there any other demo links?


Panel titles do not get border on focus

Testing #36571

Enable Tab Moves Focus mode
Tab around
The actions on the right get border on focus but the panel titles and the overflow button dont

@isidorn I am still seeing this, the "..." is not getting the focus border for me when I try (on macOS).

Yes, there is a item capturing that for November


[Fix] Fix errors about in operator.

I'm using 'to-file-path' package, which depends on this package. But cannot work after your package upgrade to '1.0.3'.
Error stack:
TypeError: Cannot use 'in' operator to search for 'Symbol(Symbol.toStringTag)' in <IP_ADDRESS>
    at Function.isArguments (.../node_modules/is-arguments/index.js:7:52)
    at toFilePath (.../node_modules/to-file-path/index.js:37:36)
    at tofp (.../src/common/lib/ip_filter.js:70:35)
    at ipFilter (.../src/common/lib/ip_filter.js:63:29)
    at .../src/server/middlewares/ip_filter.js:65:22
    at .../node_modules/koa-mount/index.js:58:11

And this pull request just add check of object type before using in operator.

The in operator can only be used to check if a property is in an object. You can't search in strings, or in numbers, or other primitive types.
-- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/in_operator_no_object#What_went_wrong

Sure.

@ljharb Test is added.
Will this change be released today?

v1.0.4 released.


block plugins with blinking icons or disable blinking icons in plugin list

please block plugins with blinking icons or disable blinking icons in plugin list.
vscode is a great tool for focussed development work.
plugins like https://github.com/Dannark/Android-Launcher-for-VSCode with a blinking icon in the plugin list distract and annoy.
to stop this selfish attention stealing behaviour block plugins like https://github.com/Dannark/Android-Launcher-for-VSCode.

You can uninstall that extension if you do not like that or file an issue against that extension if you have bugs/features.

You can uninstall that extension if you do not like that or file an issue against that extension if you have bugs/features.

i can not uninstall the plugin marketplace.
i do not have the plugins installed

i can not uninstall the plugin marketplace.
i do not have the plugins installed


Update validation tool to be able to use the proxy settings

The validation tool is currently not capable of using the proxy settings (the node server is not currently interpreting the jsp file and is serving it raw)

Workaround is to host required resources locally.

The issue is when using webpack. The workaround is to enable CORS  in the servers hosting the services, or as Jay stated above , host required resources in same server as EMP map so use of proxy is not needed.

This is a webPack limitation when dealing with proxies of type jsp (Java). Closing this issue.


Rebase the feature/flow-aggregator branch with lastest master branch

@lzhecheng We have a separate branch feature/flow-aggregator for flow aggregator implementation. For eventual smooth merging with master, we want to do development on updated feature/flow-aggregator branch with the most recent commit on master. This will create an extra merge commit on master branch, when we eventually merge new commits from feature/* branch.
Since you worked on IPv6 branch, we want to check with you if this merge commit is ok or is there a better alternative way?

@lzhecheng Hi zhecheng, I'm going to rebase this feature/flow-aggregator with commits from master, however in this way all commits from master will be squashed into one commit and we will have one extra merge commit in the master in the future. Do you know is there a better approach to do this rebase work? Thanks!

@dreamtalen Spoke with Wenying. It is better to directly push to the remote feature/flow-aggregator branch directly. I am using other PR: #1598 for testing when we sync periodically; we just use that PR for testing and do not merge it.
I will take care of pushing to remote feature/flow-aggregator branch directly. I will do this on weekly basis or as and when need arises.
I am closing this PR.


Update header addition to add to test.

Any particular reason to use Set instead of Add?

@dburugupalli What i'm trying to say is we don't need to use Set here. We will be the ones who will send the header to any request correct, so there's no way for it to be updated. We only had to use Set because we were sending an Authorization header with the request, and some services like Duo required a different value for the same header.


Support syncing from Github with soft-deleted content records

When we re-sync a website from Github to the database and there are soft-deleted WebsiteContent records for the website, those records should be un-deleted if they still exist as files in Github. Right now, our sync logic attempts to create them, which causes text_id conflicts.
This will be easier to implement and test when #292 merges.

Yes, just tried it.

Do we only hit this issue when using the sync_backend_to_db management command?

I think so


responsive widths way off

let opts = {
    init                 : false,
    slidesPerView        : 4,
    spaceBetween         : 10,
    slidesPerColumn      : 2,
    slidesPerGroup       : 4,
    breakpoints          : {
        1007: {
            slidesPerView: 3
        }
    },
    slidesPerColumnFill  : 'row', // with row the lazy load acts weird
    preloadImages        : false,
    roundLengths         : true,
    watchOverflow        : true,
    watchSlidesProgress  : true,
    watchSlidesVisibility: true,
    lazy                 : true
};

my config posted above, and using minimal styles for the swiper container, just setting a max-width: of 88% on .swiper-container. If the slider initializes on desktop, it is 4 wide, no problem there, and when scaling it down it will go to 3 wide, also no problem. The issue is that it does some ridiculous hardcoded calculation putting the width of .swiper-wrapper a massive width. In my case on mobile it is 2820px which screws the whole page width up. What more strange is in in responsive mode in dev tools, if you slowly start to scale up the width, still keeping it below your desktop break point, the width of slider-wrapper gets worse.. In my case width: 1.55894e+06px;.. What is the world is goin' on here?

So for anyone curious or having this issue, I ended up finding a fix for it. I had a flex-basis: 100%; on the parent container, which seemed to work just fine for the rest of our site, but i guess for this library, it just will span the entire width of the gallery with all slides in line. I fixed by just adding max-width: 100%; to the container as well.


Cannot move issues where assignee is someone else

I am moving a bunch of issues from a repo where I am the owner. However I have a collaborator in that repo and some issues are assigned to him. These cannot be moved. I first need to remove the assignee then I can move them.

Actually it may be that the user is not in the destination repo. In this case it might be good if the assignee was removed, so that the issues can be migrated.

I encountered this issue. In my case, an issue on repo 1 was assigned to X. I wanted to move this issue to repo 2, in which X no longer was a member. The "move issue" button then returned "Can not retrieve "ez" of null" and the network tab showed a 422 unprocessable entity. Removing the assignment of X in repo 1 and trying to the move again fixed the issue.


Move ShouldHandleFileOpEvent unit tests into their own class

Additionally:

Reorder PrjFSKextTests files so they're in alphabetical order
Replace the usage of org_vfsforgit_PrjFSProviderUserClient with PrjFSProviderUserClient

Follow up work for comments left on #1194 after it was merged.
Resolves #1195

Waiting on #1200 to be merged before merging this PR.


Rework React DevTools resolution

Now searches in all of the paths described in the Chromium Project documentation:
https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/user_data_dir.md
As a result it should be able to find the extensions in the folders for Chrome, Chromium, Chrome Beta, and Chrome Canary
On top of that it also searches for directories for the following popular chromium-based browsers: Opera, Brave, Vivaldi, Microsoft Edge
Other candidates could include  Microsoft Edge and Opera GX among others but these were not included in this PR.
It would be nice if a Windows user could verify that it works properly, same for Mac but I will test that one myself as well.

Tested working on Windows using Edge by Disease

Since things are going manifest v3, we've decided not to go forward with this method.


🧑💻: Adding Google Authentication

:red_circle: Title : Adding Google Authentication using Firebase
:red_circle: Enhancement Aim : SignUp
Screenshots 📷

:white_check_mark: To be Mentioned while taking the issue :

Full name : Debashis Pani
What is your participant role? GSSOC

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@Avdhesh-Varshney Can I work on this?

@pani2004 Assign me this issue sir i will resolve it tommorow only

@Avdhesh-Varshney


Add solution.js to Largest-Number problem

Looks good. Don't forget to star this repository and share on your social media about this repo for hacktoberfest. Thank you for the contribution.


Is there an appetite for 1.6/2.0.1 conversions?

Thanks for providing this crate.
I've started to play around with providing conversions between 1.6 and 2.0.1 and my initial view is that, sans some renaming, 1.6 is a subset of 2.0.1, and it is semantically compatible.
I'm sure I'll discover more as I go, but I was wondering if they'd be interest in having the conversions available from this crate.
Here's an incomplete sample conversion:
pub struct Converter<T>(pub T);

...

impl TryFrom<v2_0_1::messages::authorize::AuthorizeRequest>
    for Converter<v1_6::messages::authorize::AuthorizeRequest>
{
    type Error = Error;
    fn try_from(v: v2_0_1::messages::authorize::AuthorizeRequest) -> Result<Self, Self::Error> {
        type To = v1_6::messages::authorize::AuthorizeRequest;
        {
            Ok(Self(To {
                id_tag: TryInto::<Converter<_>>::try_into(v.id_token)?.0,
            }))
        }
    }
}

(there is a conversion for the id_token also...)
I've then declared a macro to make the above a bit easier on the eyes. The above becomes:
convert!(
    v,
    v2_0_1::messages::authorize::AuthorizeRequest,
    v1_6::messages::authorize::AuthorizeRequest,
    {
        Ok(Self(To {
            id_tag: TryInto::<Converter<_>>::try_into(v.id_token)?.0,
        }))
    }
);

Now, I've only converted two messages and their fields so far... this could well end up being a futile exercise. What I'm looking for is to normalise my internal model to 2.0.1 and talk 1.6 to EVSEs etc.
Am I doomed, and is there interest in these conversions being integrated here? I realise there's a degree of lossiness going from 2.0.1 to 1.6, but I think that's manageable...

Hi @huntc and thank you for your suggestion and checking out this library crate.
I'm not sure the functionality should be part of this crate. I've decided to keep the lib very minimal and just focus on the types defined in the specification.
I've had many requests for implementing connectors and the like but I do not have the time, unfortunately, and will leave that up to the implementors.
It's hard to say if you are doomed or not. Of course 2.0.1 will have added types, since it's the next iteration of the specification, but there might also be changes to the types from 1.6. I cannot remember from the top of my head.
Maybe you can use the json test schemas under src/tests/schema_validation/schemas to check if this is possible before you dive too deep.

I'm not sure the functionality should be part of this crate. I've decided to keep the lib very minimal and just focus on the types defined in the specification.

Thanks. I think it’s important to remain focused. However, I’d say that conversions could still be in line with your focus of being confined to the specification’s types. Up to you though if course.
I’ll report back on my progress. We could also release our work separately, retaining a dependency on this crate.

Closing for now.


Result of the evaluate.py

Thanks for your contribution.
I have a question about the result of evaluate.py.
Why do I get a tensor after I run the evaluate.py?
And my result is as follows.
In my opinion, the result should be the values of loss and accuracy as well as the results of train.py.

do you konw it now,?


[C++][Compute] Row segmenter inefficiency

Describe the enhancement requested
The third item in #34475 :

Improve performance of grouping inside the segmenter (see this discussion)

Currently the algorithm has O(n^2) complexity, which is inefficient.
Component(s)
C++

Issue resolved by pull request 44053
https://github.com/apache/arrow/pull/44053


feat: (connector) handle unsupported networks

Currently if you connect to the app with an unsupported network like Matic the app will break. This handles that.
Description
Update Connector to check for supported networks and show a console.error
Motivation and Context
We want to provide a good experience to users even if they are on the wrong network.
To be more useful this probably needs more design to show a modal or similar telling the user to switch networks, and/or a a MetaMask prompt to switch to another network? This change is not included.
How Has This Been Tested?
Manual testing with Chrome and MetaMask 10.0.3
Screenshots (if appropriate):

https://www.figma.com/file/sghReDviy1lcr6kkNqlc0e/Kwenta-User-Flows?node-id=5688%3A232352
Link to Figma designs for the 'Unsupported Network' banner.

https://www.figma.com/file/R9dygkd4HBA7PdxtE3iLis/External?node-id=0%3A1
Updated Figma link!

@asherism looking great! Thanks.


@types/request is required

even through an alternate request object can be passed in to retry-request, there's an expectation that @types/request has been installed in the index.d.ts; this breaks libraries that use alternative transports, such as teeny-request.

@bcoe I added feature request, but feel free to relabel.


Check if MS PlanetaryComputer allows easy NDVI extraction

@cbutsko could you add a description to better frame the aim of this issue? Thanks!


Config use dictionary

Ref #261

The goal of this PR to enable script to define server configuration within the script / code self eliminating the need for a config file on the disk.

@alculquicondor please review.

thansk @alculquicondor


introduce sentence boundaries for additional root tokens

added the one line that @honnibal suggested to fix issue #322

the parser should not get into a loop again.
There is one issue with this way of introducing additional root nodes, and this is serious:
if we have a parse like this: heads [0,-1,-2,-3], deps [ROOT, ROOT, nsubj, nsubj]
arc_eager.finalize_state() will make the second token it's own root and therefore sentence
by changing it to [0,1,-2,-3] with [ROOT, ROOT, nsubj, nsubj]
This is a non-projective structure and the sentence boundary at the second token will
disconnect tokens 2 and 3 from their head 0. This will not be a valid state, but there is currently no mechanism to prevent this. The only reason why this is probably not showing currently is because the statistical model will rarely predict such a structure for proper input.
However, this is something we shouldn't rely on because the model could be used to parse unfamiliar input and will then break on it.

That structure is familiar --- I thought about that when doing the joint segmentation and parsing for speech. I thought I had constraints which prevented this, but obviously not. I'll have a look at this.

Definitely no constraints.
I'll start digging through the history to get a sense of what I was thinking and what options I tried.

cool. we should probably merge the pull request already anyway, because the loop bug is currently on the master branch


Add rehabilitation periods bar graphs

Ticket: https://trello.com/c/tClki61b
Add all the graphs that our (previous) service designer created for us, as they are quite visual and help understanding the different rehabilitation period rules and the drag-through.
More documentation that can help us (developers) can be place in the /docs directory.

@Davidslv If you can remember anything else that we could add to this please add it. I think I've added all the graphs but I might have missed some you may have?
Also what we can do next is adding a link in the spec scenarios to each of the corresponding graphs.


Found broken /docs link. Please fix!

Hey @TimLuong, could you provide more details about which link is broken?

will re-open if the broken link is shared


Hello, thank you very much for this project. Do you have any way to convert these models into onnx format?

Hello, thank you very much for this project. Do you have any way to convert these models into onnx format?

any update on this?

Hello, thank you very much for this project. Do you have any way to convert these models into onnx format?

onnx is not good, its better to tensorrt or similar backend to optim infer speed.


Jest fails in react-native-appsflyer

Report
Jest fails in react-native-appsflyer, even after running cd ios && pod install
Plugin Version
"@segment/analytics-react-native-plugin-appsflyer": "0.4.0"
"react-native-appsflyer": "6.8.2",
On what Platform are you having the issue?
IOS
What did you do?
Yarn test
I have run pod install, also have the ios folder
What did you expect to happen?
Jest test pass
What happened instead?
jest test fails
Please provide any other relevant information.
$ jest
FAIL  tests/App.test.jsx
● Test suite failed to run
Invariant Violation: `new NativeEventEmitter()` requires a non-null argument.

  at invariant (node_modules/invariant/invariant.js:40:15)
  at new NativeEventEmitter (node_modules/react-native/Libraries/EventEmitter/NativeEventEmitter.js:45:7)
  at Object.<anonymous> (node_modules/react-native-appsflyer/index.js:6:31)
  at Object.<anonymous> (node_modules/@segment/analytics-react-native-plugin-appsflyer/lib/commonjs/AppsflyerPlugin.tsx:10:1)

Hi, are you trying to run tests for your app or to run the tests that are inside appsflyer plugin?

Hi, are you trying to run tests for your app or to run the tests that are inside appsflyer plugin?

Running test in the app..

you need to add transformIgnorePatterns to your jest configuration to tell jest to ignore files or folder.
Read more here


Add invoke middleware that support invoking other service by middleware in middleware call chain

Description
In some case, we want to invoke other service to do something before calling real invoked service, we can use this middleware to achieve this goal.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#1680

Is there any proposal for this? I do not find how users can use it.

Is there any proposal for this? I do not find how users can use it.

Is there any proposal for this? I do not find how users can use it.

Hi,
I don't know the middleware need the proposal. If need, I will doc it. I don't provide the middleware doc, because I just want to know if the middleware is acceptable. Maybe you can view it quickly, if you think it is fine, I will doc the related doc and push it.

This middleware is invoke other service middleware. When we want to invoke middleware method in middleware call chain, we can use it. A common scenario is that invoke authorization service to authorize the permission before we invoke real service method.

This middleware is invoke other service middleware. When we want to invoke other service method in middleware call chain, we can use it. A common scenario is that invoke authorization service to authorize the current invoke permission before we invoke real service method.

Can you explain your scenario in some more detail? We have not really seen this sort of ask before, so it would be interesting to understand the details of the scenario you are trying to achieve.

Hello, @msfussell

Can you explain your scenario in some more detail? We have not really seen this sort of ask before, so it would be interesting to understand the details of the scenario you are trying to achieve.

I will illustrate my current scenario, maybe you can provide better solution, because I think my solution is not good. My solution just use the service invocation concept in the middleware layer, maybe it solved in dapr runtime will be better.

As shown in the figure above, I want to invoke authorization service to judge current invoke permission before I invoke target service's method. If pass, I will continue to invoke the target service's method, otherwise the request will be denied.

What are examples of such rules? I do believe this would work better in Dapr runtime because we would make it generic for HTTP and gRPC.

What are examples of such rules? I do believe this would work better in Dapr runtime because we would make it generic for HTTP and gRPC.

Yes, I agree with you!
Example:

I want to invoke target service method, but I need to verify the user permission firstly. I can just transfer my invoke to authorization service to verify user permission.If invoke pass, I will continue to invoke target service method. Otherwise the invoke will be denied and will not invoke the target service method.

Hello!
I want to know that how can I do now? @artursouza I think your consideration is correct! Will you achieve at the dapr runtime?

@li1234yun There are many ways to achieve this. A design proposal would be ideal to initiate the discussion. Here are some ideas:

Create a "Intercept" or "Chain" CRD that can be applied to an API for pre processing or post processing - basically expanding the notion of middleware beyond just HTTP.
Add it as a built-in feature in service invocation, where the authorization endpoint can be passed as a metadata and dapr runtime interprets it and makes the service invocation.

/cc @pkedy has some ideas related to item no. 1.

@li1234yun There are many ways to achieve this. A design proposal would be ideal to initiate the discussion. Here are some ideas:

Create a "Intercept" or "Chain" CRD that can be applied to an API for pre processing or post processing - basically expanding the notion of middleware beyond just HTTP.
Add it as a built-in feature in service invocation, where the authorization endpoint can be passed as a metadata and dapr runtime interprets it and makes the service invocation.

/cc @pkedy has some ideas related to item no. 1.

Hello! @artursouza @yaron2
I'm sorry for reply you now! I just forgot the pull request. I will wait the above achieve to avoid introducing new redundant code. Thank you!

@artursouza, can you provide an update on this PR? There is an open docs PR for this as well.

I don't think we should have this PR merged until there is a proposal and we can compare alternatives. This feature starts to get into workflows and I think it is better to think about that holistically.
/cc @yaron2 @pkedy @greenie-msft

@artursouza, let's close this PR.

Closing for now, but we can re-open if this is discussed and agreed on in a GitHub issue.


all: instrument with traces for observability

Customers are asking for traces to be added to this package so that they can properly diagnose latency issues and have observability for their systems.
I am tasked with implementing tracing for this library and this issue serves as the reference. I have implemented this functionality in my fork https://github.com/orijtech/nodejs-spanner/pull/3 and I shall progressively send code changes to this repository to make the software development process much more scalable and easier to merge.
Samples of results

with PII acknowledgement and annotations added

And completed!


Remove the requirement for users to specify alignment

Users are required to specify the alignment for n_byte_align and n_byte_align_empty. This is probably bad. Remove this either by using FFTW for memory management or by more direct use of pyfftw.simd_alignment.

Fixed by eb5645e4a0d660b06734cf3b20c9de7afbc3bc62.


Docker setup and connection

Dropping some notes while it's fresh. Had to do the following to get a working container (dockerfile below). Also had to use the SaaS connection string (https://motherduck.com/docs/key-tasks/authenticating-to-motherduck/#syntax) for connecting to motherduck. Don't enter the token in the field that renders on the screen because it complains about not understanding how to use it
Dockerfile
FROM eclipse-temurin:11-jre-jammy

# not using the default metabase image because of duckdb and glibc compatibility
# https://github.com/metabase/metabase/blob/master/bin/docker/

# dependencies
RUN apt-get update && \
    apt-get install -y bash fontconfig curl fonts-noto fonts-noto-cjk ca-certificates-java && \
    mkdir -p /app/certs && \
    curl https://truststore.pki.rds.amazonaws.com/global/global-bundle.pem -o /app/certs/rds-combined-ca-bundle.pem  && \
    keytool -noprompt -import -trustcacerts -alias aws-rds -file /app/certs/rds-combined-ca-bundle.pem -keystore /etc/ssl/certs/java/cacerts -keypass changeit -storepass changeit && \
    curl https://cacerts.digicert.com/DigiCertGlobalRootG2.crt.pem -o /app/certs/DigiCertGlobalRootG2.crt.pem  && \
    keytool -noprompt -import -trustcacerts -alias azure-cert -file /app/certs/DigiCertGlobalRootG2.crt.pem -keystore /etc/ssl/certs/java/cacerts -keypass changeit -storepass changeit && \
    mkdir -p /plugins && chmod a+rwx /plugins

ENV MB_PLUGINS_DIR=/plugins/

ADD https://downloads.metabase.com/v0.50.4/metabase.jar /app
ADD https://github.com/MotherDuck-Open-Source/metabase_duckdb_driver/releases/download/0.2.7/duckdb.metabase-driver.jar /plugins/
RUN chmod 744 /plugins/duckdb.metabase-driver.jar

COPY ./run_metabase.sh /app/

# expose our default runtime port
EXPOSE 3000

ENTRYPOINT ["/app/run_metabase.sh"]

Thanks so much for sharing this! I tried it out and it works.
I was able to use the md:my_db string without using saas_mode, and passing the token also works without errors.

Hi @sugendran, a new version of the connector has been released. If the token field still doesn't work, do you mind sharing the error message?

Good news. It worked, no errors.

Correction.. i had to hard refresh.. maybe some heavy caching on metabase

Correction.. i had to hard refresh.. maybe some heavy caching on metabase

Confirmed

One other thing would be to have it refresh the schema on demand. I press the button in the admin interface but it doesn't refetch the schema

Confirmed

One other thing would be to have it refresh the schema on demand. I press the button in the admin interface but it doesn't refetch the schema

The scheme doesn't update itself


feat: support describe()

Builds on #24
feat: support describe()

You've been quite industrious! Very cool to see! I've been on vacation last week and playing catch-up this one with my paid labor, but I will still try to review one PR a day, so this one I will get to tomorrow.


Feature: fuzzy search

Ability to search (either in the main whole-site search or filter views) using slightly incorrect or incomplete terms and still get results.

an overview of some possibilities https://arctype.com/blog/postgres-fuzzy-search/

single word searches are now treated as prefixes. So salt would match saltcorn etc


Tab: explore to keep close button stable when rapidly closing

Even though we have non-equal width tabs it would be nice if you could rapidly close tabs without moving the mouse.

Demo

@joaomoreno I actually wonder if this is also something that should go into the tabs widget because it is closely related to animations and timings. I thought about it once and could not come up with a good solution because our tabs are not even width.

Yeah if we keep the current tab width model, this isn't possible at all.

No plans of action here.


Maximum buffer size for contents of readdir?

I'm finding that only the first 3200 file names (approximately) added to my directory filler in readdir() get displayed in my file system, with names like (soccer\ scores\ Liverpool.txt).  When I run a test filller with 9000 numerically named files (00001.txt) it's fine.
I don't know what's going on but it looks like it's buffer size related. Are there any limitations on the buffer size of the directory filler?

This isn't documented much in fuse-jna or fuse either. I haven't confirmed this but I would guess that it is because your code isn't checking the return value of DirectoryFiller.add. It should return true on success, false on failure (because the buffer is full). Your code should return ENOMEM (out of memory) in this case, such that the caller knows it needs to ask again with a bigger buffer.
Let me know if my guess is correct. If it is I'll update the documentation and examples, otherwise I'll investigate further (but for that, I need a minimal example to reproduce it).

Thanks for the quick reply. I'll post here after trying it, which may take some time.

I just tried it with 30,000 files named with the following name length, and it was fine.
11111-11111-11111-11111-11111-11111-11111-11111-11111-11111-11111-11111-11111-helloworld.txt
So at this point it seems like there's something wrong in my specific code.
It's not fair for me to keep this bug open. But I may need to reopen it to get more help. Thanks for the info.

Did you add code to return ENOMEM on failure to add directory entries?

Checking the return status of DirectoryFiller.add and returning ENOMEM if non-zero didn't have any effect.
I should be able to gather a test case. I'll provide it soon. Thanks for maintaining interesting in resolving this.

Okay, here is a test case. Try running the main method. I think the problem is something in my specific file name data (with a loop that creates numerical file names, it works fine).
FuseTruncationProblem.java.txt

Sorry, I didn't notice this reply until just now.
Thanks a lot for writing this testcase. However, I wasn't able to reproduce the problem with it. I ran it and the directory listing contains all ~6000 files.
Maybe this is platform-dependent? Are you on OS X? I checked this on Linux 4.6. AFAIK it has a max path limit of 4096 character, but the filename length limit should be filesystem-dependent.
If this is an OS-X-specific problem, I could add a check on filename length that only applies on OS X.

You can close it. It's nothing to do with buffer size. Here are the relevant remarks:
It's nothing to do with buffer size afterall. A single file with this name causes issues:
files.add("3503::Mainstream American pop culture seem completely worthless! Why aren't people interested in more worthwhile activies? - Politics and Other Controversies -Democrats, Republicans, Libertarians, Conservatives, Liberals, Third Parties, Left-Wing, Right-Wing");
Conclusion
File names can be 255 characters maximum. This is not a limitation of FUSE. NTFS and EXT4 have this maximum.
Maybe consider adding a safety check somewhere in your library so that rookies like me don't get perplexed with an otherwise fantastic library. Thanks very much for creating this.

I understood what you said, but it works for me.
With the following code, which adds only a single file under 1dir:
package net.fusejna.examples;

import java.io.File;
import java.io.IOException;
import java.nio.ByteBuffer;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.LinkedList;
import java.util.List;

import net.fusejna.DirectoryFiller;
import net.fusejna.ErrorCodes;
import net.fusejna.FuseException;
import net.fusejna.StructFuseFileInfo.FileInfoWrapper;
import net.fusejna.StructStat.StatWrapper;
import net.fusejna.types.TypeMode.NodeType;
import net.fusejna.util.FuseFilesystemAdapterFull;

public class FuseTruncationProblem extends FuseFilesystemAdapterFull
{
	public static void main(final String... args) throws FuseException, IOException
	{
		Files.createDirectories(Paths.get("/tmp/fusejnaproblem"));
		new FuseTruncationProblem().log(false).mount("/tmp/fusejnaproblem");
	}

	final String filename = "/hello1.txt";
	final String contents = "Hello World\n";

	@Override
	public int getattr(final String path, final StatWrapper stat)
	{
		if (path.equals(File.separator)) { // Root directory
			stat.setMode(NodeType.DIRECTORY);
			return 0;
		}
		if (path.equals("/hello1.txt")) { // hello.txt
			stat.setMode(NodeType.FILE).size(contents.length());
			return 0;
		}
		if (path.endsWith("dir")) {
			stat.setMode(NodeType.DIRECTORY);
			return 0;
		}
		stat.setMode(NodeType.FILE).size(contents.length());
		return 0;
	}

	private List<String> getList()
	{
		final List<String> files = new LinkedList<String>();
		files.add(
				"3503::Mainstream American pop culture seem completely worthless! Why aren't people interested in more worthwhile activies? - Politics and Other Controversies -Democrats, Republicans, Libertarians, Conservatives, Liberals, Third Parties, Left-Wing, Right-Wing, Congress, President - Page 5 - City-Data Forum");
		return files;
	}

	@Override
	public int read(final String path, final ByteBuffer buffer, final long size, final long offset, final FileInfoWrapper info)
	{
		// Compute substring that we are being asked to read
		final String s = contents.substring((int) offset,
				(int) Math.max(offset, Math.min(contents.length() - offset, offset + size)));
		buffer.put(s.getBytes());
		return s.getBytes().length;
	}

	@Override
	public int readdir(final String path, final DirectoryFiller filler)
	{
		filler.add(filename);
		if (path.length() == 1) {
			filler.add("1dir");
		}
		if (path.endsWith("1dir")) {
			for (final String file : getList()) {
				final boolean added = filler.add(file);
				if (!added) {
					System.out.println("HelloWorldFuse.readdir() Failed to add");
					return ErrorCodes.ENOMEM();
				}
			}
		}
		return 0;
	}
}

I get:
$ ls /tmp/fusejnaproblem/1dir
'3503::Mainstream American pop culture seem completely worthless! Why aren'\''t people interested in more worthwhile activies? - Politics and Other Controversies -Democrats, Republicans, Libertarians, Conservatives, Liberals, Third Parties, Left-Wing, Right-Wing, Congress, President - Page 5 - City-Data Forum'
hello1.txt

Hence me asking if the behaviour is platform-specific.

Oh I see, my mistake. I was running this on Mac OS 10.7 I believe.


Update to v1.22.16

Signed-off-by: galal-hussein<EMAIL_ADDRESS>

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change

Further Comments

Merging anyway due to flaky tests


Add shell script to ensure consistent version of OTEL semconv

Which problem is this PR solving?
Resolves #4646
Description of the changes
Added a shell script to search the code for all usages of "go.opentelemetry.io/otel/semconv/v1.xx.x" and fail if they are not identical, with an error message and the source files along with their respective versions.
How was this change tested?
I have tested the changes locally by modifying import statements

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[ ] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

@perhapsmaple did you get any error while running make install-tools ?

@Mayhul-Jindal I had no errors while running make. Although, install-tools did not download the tparallel module on my machine

@yurishkuro I wanted to know if there was any way other than using curl to determines the latest version of semconv available. The go list command only seems to work for the go.opentelemetry.io/otel package. I would be willing to work on another script that updates all references to the latest version of semconv.

Hi @yurishkuro ,I have addressed all of your initial comments. Let me know if there are any further changes required


Feature/abbreviate logs

Overview
An issue that comes up when serving binary content is that the response object will get logged and print out the entire image/buffer/what have you as a utf-encoded string. This tends to A) fill up the entire terminal which makes it hard to read the rest of your logged messages, and B) notciably slow down your lambda function. This PR adds a flag (--abbrev [abbrev amount]) that reduces the size of loggedObject.body down to the specified length (with an ellipsis in the middle). Leaving the flag off causes output to be logged in full.
Demo
What output tends to look like now with --abbrev 200. Normally this body string is over 10k characters long (a 256x256 .png).
 19:07:13.775Z  INFO claudia-local-api:
     {
         "statusCode": 200,
         "headers": {
             "Content-Type": "image/png",
             "Access-Control-Allow-Origin": "*",
             "Access-Control-Allow-Headers": "Content-Type,Authorization,X-Amz-Date,X-Api-Key,X-Amz-Security-Token",
             "Access-Control-Allow-Methods": "GET,OPTIONS",
             "Access-Control-Allow-Credentials": "true",
             "Access-Control-Max-Age": "0"
        },
         "body": "iVBORw0KGgoAAAANSUhEUgAAAQAAAAEACAYAAABccqhmAABG6ElEQVR4nO19B5iUVbL26zDMwAw55wwSJElGlJwkqgTFiAEDioqo[...]+BIog6lSvEDcHIQ8hIMEqIcGrqcTTJHyXe4l7UBJ+z3O00+cjYWh7sbi1YT0HDB4f8DG3dx5Umi99kAAAAASUVORK5CYII=",
         "isBase64Encoded": true
     }

Notes

See my previous PR (#19) for context on the older commits, GitHub wouldn't let me set an unmerged branch as the base for this one.

Testing Instructions

Run the example claudia project in test/ and navigate to /img.
Output should be abbreviated rather than a gigantic UTF string.

Thanks for these updates.
Sorry, I have been negligent on making updates on my libraries.


Add namelock to Contributors list

...and escape the markdown underscore from @Guilemon

@namelock, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Feature/initial project

:x: Build LatLongNet-SDK-dotnet 1.0.39 failed (commit https://github.com/guibranco/LatLongNet-SDK-dotnet/commit/05a81c645f by @guibranco)

:white_check_mark: Build LatLongNet-SDK-dotnet 1.0.41 completed (commit https://github.com/guibranco/LatLongNet-SDK-dotnet/commit/b89f2c6401 by @guibranco)


Ignore case for search

Issue

close #676

Overview (Required)

Ignore case for search
Ignore case for Highlight

Links

Screenshot

Before
After

Looks good! Please take a look at small point🙏


Gazebo optical flow simulation: no position hold

I just tested the gazebo optical flow simulation (make posix gazebo_iris_opt_flow) and I could not get a position hold. Altitude hold works and I can see the distance topics in QGC but not the flow topics...

I have tested the simulation again with the newest master. Now I get the flow information. Altitude hold again works fine but as soon as I enable position hold the drone crashes.
@jgoppert The output of the flow looks fine. I guess it is something with the lpe? Or is it just wrongly tuned?

@ChristophTobler you need https://github.com/PX4/Firmware/pull/5958. Some of the tests are failing because of size constraints for older boards, but it works. Might have to make a build without ekf2 and just lpe on it.

Ok, works with https://github.com/PX4/Firmware/pull/5958. I'll leave the issue open until merged.

@jgoppert I saw that https://github.com/PX4/Firmware/pull/5958 has been merged into master. Now is it possible to switch to position hold but the quad dangles heavily. Does it need tuning?

@ChristophTobler For sitl pos hold (make posix_sitl_default gazebo_iris_opt_flow, commander takeoff) there is still a bit of a wobble, could be improved. In real life it works well. Please stay tuned to the PR: https://github.com/PX4/Firmware/pull/6045. I hope to surpass the optical flow performance of LPE with IEKF.


Lock hashie gem to the last working version

This can be reverted when https://github.com/intridea/hashie/pull/368 is merged and released.
@jrafanie

This can be reverted when intridea/hashie#368 is merged and released.

Nitpick, we'll require the number to the "fixed" version when it's released

LGTM :+1:

I released 3.4.6, please confirm that works.


Switch from GitHub Super Linter to CHKTEX

Is your feature request related to a problem? Please describe.
GitHub Super Linter breaks, see #53,  with every (major) release and takes a long time to started. The most important check can be done by chktex on Ubuntu 24.04 which is not yet publicly released yet.
Describe the solution you'd like
...
Describe alternatives you've considered
Create a custom action.
Additional context
...

Ubuntu 24.04 is now available as public beta.


Premerge build takes to long again (over 3 hours)

Describe the bug
The premerge build for pull requests takes over 3 hours again, it would be nice if it took less time.
investigate why its taking so long.
Perhaps we can drop support for some versions?  Spark should be releasing some new minor versions soon.

For most spark versions in pre-merge we only do build w/o test, so they should not cost too much time.
IMO most time comes from new tests/cases we added to integration tests, may be we can shrink the data_gen size in pre-merge only?

We've added a lot of tests that have tons of dimensions, and that adds a ton of tests to run.  For example, some of the slower tests are joins, and those test across the dimensions of join types, data types, and batch sizes (if not even more dimensions in some specific cases).  We may want to consider if some of these test combinations are not worth the cost it is taking to run them.  For example, do we really need to test every join type and every data type for a batch size of 100 (which is quite slow to run), or is it sufficient just to test one or just a handful of join types and data types for that extreme configuration?
Executive summary is that I think we need to audit which test files and individual tests are taking the longest and then see if we really need to run all the dimensions on those tests to get a satisfactory level of coverage from them.

I think that there are a few things happening.  We have some tests that are slow because we are doing exhaustive combinations.  We have other tests that are slow because we are doing a lot of computation. I totally agree that we probably don't need all combinations. We probably also don't need to cover as much data in the pre-merge which might reduce the amount of computation. But before we get into any of this we probably want to measure to see what each problem really is instead of just guessing.
Do we have stats somewhere about how long each test is taking? It looks like we can add --durations=N to the command line when running the tests and it will tell us the top N longest running tests, or 0 if we want to see all of them, but with a min time cutoff that is set by --durations-min. So we could get an idea about what is actually happening, and it can let us also test on a subset of the tests to see if our efforts would help without having to run all 3 hours of tests each time we want to make a change and see if it helped.
My guess is that both of you are right.  We have some tests that we know are very long running and we can probably turn off some versions of them without much hit to coverage. There are probably also a lot of really small tests. I am not sure if we drop the size of the data how big of an impact that will have.
I personally am more inclined to throw more hardware at the problem.  Can we run the integration tests in 2 containers instead of 1?  We are adding in more functionality all of the time. So is Spark. Neither of these are going to change any time soon, at least no as long as the projects are still viable.  So just doing a quick cleanup of tests is good, but I don't think we will be able to constantly find more tests to throw away. We need to go to a model where we can actually scale the hardware with the testing requirements.

First steps here are to identify the tests that are taking a long time.

also cc @zhanga5 for the latest case-level stats

with --junitxml=xxx pytest can create junit-xml style report and if collect on Jenkins we would be able to view test result info including detail case list, duration, even trend etc. Test PR https://github.com/pxLi/spark-rapids/pull/228 was created and generated one sample report on Jenkins: http://nv/2su (need vpn)

As expected we can tell join_test took longest time (>5h in total, note, this accumulated test cases cost in parallel testing) with exhausted cases (2,650). We could further look into join_test and tell which cases are most time consuming. I would suggest enable this test report all the time in order to evaluate and balance test scope & time cost easily.

+1 on enabling the test report all the time.  No reason not to.
Now we need someone to look at the tests propose a plan on which tests we should stop doing. It is fairly clear that we probably don't need to do all of the tests for test_cartesian_join_special_case_count[100. But I think there are likely to be others too.

OK, will enable such test report first

Build time is well under3 hours, and we're about to remove quite a few builds for the 30x shims (see #4915).  Closing this for now.  We can reopen or file a new one if this becomes a major issue again.


hunspellDicts: add pt_PT

Description of changes
Add language Portuguese from Portugal to hunspellDicts, and small fix on the description of Portuguese from Brazil which are misspell and not coherent with most of the previous languages.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality, added the package hunspellDicts.pt-pt and was fully functionally with Libreoffice suite.
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 246456 run on x86_64-linux 1

5 packages built:

hunspellDicts.pt-pt (hunspellDicts.pt_PT)
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper