Synthesis failed for Google.Cloud.Iam.Credentials.V1

Hello! Autosynth couldn't regenerate Google.Cloud.Iam.Credentials.V1. :broken_heart:
Please investigate and fix this issue within 5 business days.  While it remains broken,
this library cannot be updated with changes to the Google.Cloud.Iam.Credentials.V1 API, and the library grows
stale.
See https://github.com/googleapis/synthtool/blob/master/autosynth/TroubleShooting.md
for trouble shooting tips.
Here's the output from running synth.py:
2021-03-19 22:43:59,692 autosynth [INFO] > logs will be written to: /tmpfs/src/logs/Google.Cloud.Iam.Credentials.V1
2021-03-19 22:44:00,228 autosynth [DEBUG] > Running: git config --global core.excludesfile /home/kbuilder/.autosynth-gitignore
2021-03-19 22:44:00,233 autosynth [DEBUG] > Running: git config user.name yoshi-automation
2021-03-19 22:44:00,237 autosynth [DEBUG] > Running: git config user.email<EMAIL_ADDRESS>2021-03-19 22:44:00,241 autosynth [DEBUG] > Running: git config push.default simple
2021-03-19 22:44:00,245 autosynth [DEBUG] > Running: git branch -f autosynth-Google.Cloud.Iam.Credentials.V1
2021-03-19 22:44:00,249 autosynth [DEBUG] > Running: git checkout autosynth-Google.Cloud.Iam.Credentials.V1
Switched to branch 'autosynth-Google.Cloud.Iam.Credentials.V1'
2021-03-19 22:44:00,489 autosynth [DEBUG] > Running: git rev-parse --show-toplevel
2021-03-19 22:44:00,496 autosynth [DEBUG] > Running: git log -1 --pretty=%H
2021-03-19 22:44:00,500 autosynth [DEBUG] > Running: git remote get-url origin
2021-03-19 22:44:00,536 synthtool [ERROR] > Failed executing git checkout master:

error: Your local changes to the following files would be overwritten by checkout:
	google/cloud/dialogflow/v2/answer_record.proto
	google/cloud/dialogflow/v2/conversation.proto
	google/cloud/dialogflow/v2/conversation_profile.proto
	google/cloud/dialogflow/v2/participant.proto
Please commit your changes or stash them before you switch branches.
Aborting

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 312, in _inner_main
    git_source.enumerate_versions(sources, pathlib.Path(temp_dir))
  File "/tmpfs/src/github/synthtool/autosynth/git_source.py", line 202, in enumerate_versions
    source_versions = enumerate_versions_for_source(git_source, temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/git_source.py", line 166, in enumerate_versions_for_source
    local_repo_dir = str(synthtool_git.clone(remote))
  File "/tmpfs/src/github/synthtool/synthtool/sources/git.py", line 85, in clone
    shell.run(["git", "checkout", "master"], cwd=str(dest), check=True)
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/tmpfs/src/github/synthtool/synthtool/shell.py", line 33, in run
    encoding="utf-8",
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'checkout', 'master']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


rework parse:* scripts to avoid NODE_ENV set as orm configs now handle it

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (20265f1) 95.06% compared to head (ae3e1ff) 95.06%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   95.06%   95.06%
=======================================
  Files          21       21
  Lines         162      162
  Branches       16       16
=======================================
  Hits          154      154
  Misses          8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix Config type issues

What does this PR do?
JIRA https://datadoghq.atlassian.net/browse/OTEL-2192
When  Collector enforced strict types see issue , the OTLP ingest was breaking as we are alway do a get .
To overcome the issue we do following

After the string map is constructed, we decode into serializerexporter.MetricsConfig
We reverse decode  serializerexporter.MetricsConfig into map, that would result in map with strict types.

Motivation
Describe how to test/QA your changes
set env export DD_OTLP_CONFIG_METRICS_RESOURCE_ATTRIBUTES_AS_TAGS="true" and start the core agent with config
dd_url: https://app.datadoghq.com
api_key: XXX
hostname: mymachine
use_dogstatsd: yes
skip_ssl_validation: yes
dogstatsd_port: 18125
dogstatsd_non_local_traffic: yes
log_level: debug
logs_enabled: true
otlp_config:
  receiver:
    protocols:
      grpc:
        endpoint: localhost:4317
      http:
        endpoint: localhost:4318
  traces:
    internal_port: 50053
apm_config:
  remote_tagger: false
  enabled: true
  log_file: trace.log
  receiver_port: 18126

Possible Drawbacks / Trade-offs
Additional Notes

/merge


pin protobuf dep to < 3.4 while latest protobuf package is being fixed

Fixes this error in tests:
An error occurred while loading ./src/ruby/spec/pb/health/checker_spec.rb.
Failure/Error: require 'google/protobuf'

(issue https://github.com/google/protobuf/issues/3509)
3.4. was yanked, but it looks like this is needed to remove 3.4 from caches

google-protobuf <IP_ADDRESS> was released already, before tests on this PR are done.
closing this since <IP_ADDRESS> (without the issue) will get picked up now


Merkle proof library with tests and docs

Addresses #254
merkleTree.js contains a helper Merkle tree class that is used to generate Merkle trees, roots and proofs in the JS tests. When generating the Merkle tree, leaves are sorted and pre-images are also pair-wise sorted before being concatenated/hashed to create the parent of a pair of pre-images.
verifyProof in MerkleProof.sol assumes that the Merkle root provided is from a Merkle tree with sorted leaves and pair-wise sorted pre-images.
https://github.com/ameensol/merkle-tree-solidity/blob/master/src/MerkleProof.sol also contains a way to verify Merkle proofs that maintains the order of the leaves rather than sorting them, but verifying the proof in Solidity would also require the index of the leaf in the tree as a parameter. This initial implementation does not include this variation of verifying a Merkle proof, but depending on the needs of the community, it can be added as well.

@maraoz Bump!

Sorry, we're overwhelmed with the amount of PRs! Will try to review next week :)

Added a check that the Merkle proof length is actually a multiple of 32

Great contribution @yondonfu!


Release 1.0.4

Release notes
Close #11

Codecov Report

Merging #12 into master will increase coverage by 5.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   67.60%   72.72%   +5.12%
==========================================
  Files           2        2
  Lines          71       66       -5
  Branches        9        6       -3
==========================================
  Hits           48       48
+ Misses         19       16       -3
+ Partials        4        2       -2

Impacted Files
Coverage Δ

...src/main/kotlin/com/kizitonwose/time/Extensions.kt
26.66% <100.00%> (+3.13%)
:arrow_up:

time/src/main/kotlin/com/kizitonwose/time/Time.kt
86.27% <0.00%> (+4.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dfcfee...a3fbf17. Read the comment docs.


CHILD PTHREAD TERMINATION

  Description: When a tasks exits, shouldn't all of its child pthreads also be
               terminated?

               This behavior was implemented as an options controlled by the
               configuration setting CONFIG_SCHED_EXIT_KILL_CHILDREN.  This
               option must be used with caution, however.  It  should not be
               used unless you are certain of what you are doing.  Uninformed
               of this option can often lead to memory leaks since, for
               example, memory allocations held by threads are not
               automatically freed!

  Status:      Closed.  No, this behavior will not be implemented unless
               specifically selected.
  Priority:    Medium, required for good emulation of process/pthread model.
               The current behavior allows for the main thread of a task to
               exit() and any child pthreads will persist.  That does raise
               some issues:  The main thread is treated much like just-another-
               pthread but must follow the semantics of a task or a process.
               That results in some inconsistencies (for example, with robust
               mutexes, what should happen if the main thread exits while
               holding a mutex?)

@v01d this content could be moved to FAQ?

I don't see the option CONFIG_SCHED_EXIT_KILL_CHILDREN defined anywhere...
Is the original issue still applicable? Or has anything changed?

Oh, it's the default behaviour and can't be disabled.


Godot 4.2 Support

Does GodotSteam support Godot 4.2? If not, is there a timeline for when it will be implemented?
Thanks

From my testing offline, it compiles fine with 4.2 already.  Since I have no home internet currently, the pre-compiles are behind schedule.  I am working with the other maintainers to get this sorted in the meantime.
So yes, it works, and our pre-builds are coming soon!  :)

Godot 4.2 compiles without issues. We should be able to release it this Friday.
(Note that this is about the module, the GDExtension and GDNative plugins will need some extra work and time.)

If you're feeling adventurous the 4.2 artifacts can be downloaded here ahead of our official release: https://github.com/CoaguCo-Industries/GodotSteam/actions/runs/7091861869 However be quick, they expire in 11 hours.
If you find any issues with them, do tell. :)

I'll get them added today.  ;)

Those are now live so I will close this.


Docs on HexDocs

Docs also need to be improved

https://github.com/bernardolins/fake_server/commit/b2f8e0ff479f785189598fb897bacdff810320aa


[TEP-0075] Support Object Results substitution

Changes
This is part of work in TEP-0075.
This commit provides the support to apply object results replacements.
Previous this commit we support emitting object results so users can
write object results to task level, but we cannot pass object results from
one task to another within one pipeline. This commit adds the support for this.
/kind feature

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes
Support object results substitution as an alpha feature.

A task can specify a type to produce array result, such as:
results:
  - name: object-results
     type: object
     description: The object results
     properties:
        foo: {
          type: string
        }
        hello: {
          type: string
        }

And the task script can populate result in an object form with:

echo -n "{\"foo\":\"bar\",\"hello\":\"world\"}" | tee $(results.object-results.path)

and we can refer to the object results in param like:
  params:
    - name: whole-object
      value: "$(tasks.task1.results.object-results[*])"
    - name: object-element
      value: "$(tasks.task1.results.object-results.hello)"

This feature is part of the TEP-0075.

#4723

/lgtm

/retest

/lgtm

/retest


UI freezes

Once I have established a peer connection the UI freezes. I still see the video stream but buttons either don't receive callbacks or the callbacks are very delayed.
Using latest version.

What OS? Are you calling getStats? Was this happening with older versions?

@saghul iOS, react-native 0.44.1- I haven't used previous versions ofreact-native-webrtc`
I'm not calling getStats. Everything appears to be working correctly. I receive the peer connection, the video and audio streams come through, but all UI interactions outside of the video stream are slow.
This is the function I call when the component mounts to start the connection.
  async beginConnection () {
    const token = encodeURIComponent(`Bearer ${this.props.token}`)

    const peer = this.peer = new RTCPeerConnection({
      iceServers: config.ICE_SERVERS
    })

    const socket = this.socket = io(config.WEBSOCKET_API, {
      query: `authorization=${token}`
    })

    // We already have the peer and socket configured, time to check for
    // the status for the first time
    this.checkStatus()

    socket.on('connect', this.checkStatus)

    peer.onaddstream = event => {
      console.log('adding stream')
      this.setState({ remoteStreamUrl: event.stream.toURL() })
    }

    peer.oniceconnectionstatechange = this.checkStatus
    peer.onsignalingstatechange = this.checkStatus

    this.localStream = await this.getLocalStream()

    this.setState({
      selfStreamUrl: this.localStream.toURL()
    })

    peer.onicecandidate = event => {
      if (event.candidate) {
        socket.emit('candidate', {
          roomId: this.props.appointmentId,
          ...event.candidate
        })
      }
    }

    socket.on('error', capture)

    socket.on('exception', data => {
      capture(new Error('WebRTC signaling exception'), data)
      this.quit(data.message)
    })

    socket.on('initiate', () => {
      peer.createOffer(desc => {
        peer.setLocalDescription(desc, () => {
          socket.emit('offer', {
            roomId: this.props.appointmentId,
            sdp: peer.localDescription
          })
        }, capture)
      }, capture)
    })

    socket.on('offer', data => {
      peer.setRemoteDescription(new RTCSessionDescription(data.sdp), () => {
        peer.createAnswer(desc => {
          peer.setLocalDescription(desc, () => {
            socket.emit('answer', {
              roomId: this.props.appointmentId,
              sdp: peer.localDescription
            })
          }, capture)
        }, capture)
      }, capture)
    })

    socket.on('answer', data => {
      peer.setRemoteDescription(new RTCSessionDescription(data.sdp), noop => noop, capture)
    })

    socket.on('candidate', data => {
      peer.addIceCandidate(new RTCIceCandidate(data))
    })

    socket.on('connect', () => {
      socket.emit('join', {
        roomId: this.props.appointmentId
      })
    })

    socket.on('leave', socketId => {
      console.log('leaving socket: ', socketId)
    })

    socket.on('quit', () => this.quit('The appointment has ended'))

    peer.addStream(this.localStream)
    InCallManager.start({ media: 'video' })
  }

More info: upgrading to react-native 0.45.1 seems to help when running in Release mode, but still laggy in Debug mode

@bsiddiqui could you paste your checkStatus function code?

@renanpupin
  checkStatus = () => {
    const socketIsConnected = this.socket.connected
    const iceConnectionState = this.peer.iceConnectionState
    const connectingStates = ['have-remote-offer', 'stable', 'checking']

    if (!socketIsConnected) {
      return this.setState({ text: 'Joining the session' })
    } else if (iceConnectionState === 'new' || iceConnectionState === 'failed') {
      return this.setState({
        text: `Waiting for ${this.props.remoteClientName} to join the Session`
      })
    } else if (connectingStates.includes(iceConnectionState)) {
      return this.setState({
          text: `Connecting you to ${this.props.remoteClientName}`
      })
    } else if (iceConnectionState === 'disconnected') {
      return this.setState({
          text: 'Uh oh, it looks like you\'re experiencing some connection issues. We\'re attempting to reconnect you!'
      })
    } else {
      this.setState({ text: null })
    }
  }

@bsiddiqui Since you are in iOS I suggest you use Xcode's Instruments a run a CPU profile (https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/InstrumentsUserGuide/MeasuringCPUUse.html). That should give you more insight as for where the issue is.

#202
I was experiencing something similar as well.
What i did was use sdp-transform as suggested by @saghul to re-order the default video codecs to prefer h264 which then reduced the load quite a bit, no need to set resolutions lower, 720p minimum runs great.

@8BallBomBom so you parse the sdp, change the rtp order, and then re-write it? Do you have a code sample?

@8BallBomBom @saghul I tried parsing the sdp and changing the video media rtp order so the H265 is first but that didn't really change anything. Maybe I'm doing it wrong?
peer.localDescription.sdp = transformSdp(peer.localDescription.sdp)

transformSdp = sdp => {
    let parsedSdp = transform.parse(sdp)

    parsedSdp.media = parsedSdp.media.map(media => {
      if (media.type === 'video') {
        const baseRtp = [media.rtp.find(rtp => rtp.codec === 'H264')]
        media.rtp = baseRtp.concat(media.rtp)
      }

      return media
    })

    return transform.write(parsedSdp)
}

make sure you compare ignoring the case, I've seen H264 and h264.

@bsiddiqui Sorry not been about.
Try applying string.toLowerCase( rtp.codec ) === 'h264'`

@saghul I tried ignoring case - still 80-100% cpu usage on iPhone 6 and 7+. Is that normal?

Have you verified you are using H.264? You can check that by using a browser on the other end, and checking with chrome://webrtc-internals.
In addition, you might want to give the master branch a try, it has HW accelerated codecs enabled now.

@saghul I'll try verifying in chrome
On master it looks like HW is enabled for android. Is it also enabled for iOS?

@saghul definitely better on master but still uses quite a bit of battery (~1% / minute). I'll close for now and re-open if I'm not using H264 when testing in browser


Problem with Tor Expert Bundle

When i go to https://www.torproject.org/download/tor/ and i try to install the Windows (x86_64) tor expert bundle version, it installs a tar.gz file, and it's like a txt file. What do i have to do?

download 7zip (https://www.7-zip.org/) or winrar and extract it


Not working on Ubuntu 22.04

I can confirm that both Automatic and manual ways will not work anymore.
it will add the option in the layout setting, and you can add it, but it will not work as switching to this language is not working.

@rez4mt
HI. It's ok and it works on ubuntu 22 very well

it will add the option in the layout setting, and you can add it, but it will not work as switching to this language is not working.

when you add the files (you'd better use curl) you have to remove all Persian layouts from the settings and then, add this one
@sinadarvi
I think It's because it has the same name as the old layout of ubuntu when we add it
and its name shouldn't be 'ir'. it should be something like 'ir-win'

@tsalehm interesting,
I had no issue with Ubuntu 22, I will check some more and if the issue happened, I will consider your solution for the test.

@Aliallameh could you please also check and test this as well? if changing 'ir' to 'ir-win' works, I could change it in repo. thanks.

@sinadarvi

if changing 'ir' to 'ir-win' works, I could change it in repo.

when we add a new layout with the name 'ir', ubuntu settings will look for the old layout in the new file 'ir'
so it somehow screws the layouts. new setting files shouldn't have the same name as the old ones
when we remove Persian layouts and add them again, we're actually reloading layouts

The issue has been solved with a new PR. if you did have other problem, feel free to reopen this issue. thank you all.

Hi. It sill doesn't work on Ubuntu 22.04. With this keyboard layout selected, I only can write English.
Also, when I click on "View Keyboard Layout" in the keyboard settings, Ubuntu encounters an error and wants to send reports.
Specs: Ubuntu 22.04.1 LTS, 64-bit, GNOME Version 42.5.
Thanks.

could you please try again with new changes?

@MasterKia  I don't have access to a Linux system for a while, could you make a pull request with new changes?

@sinadarvi PR #15 will fix this bug
PLEASE DON'T merge any other PR related to this bug. because they will cause another bug

@sinadarvi yo!?

@tsalehm have been merged. thanks for your contribution. 🙏


Allow building a file with the hot-reload code inserted

Hi, and thanks for the great work you're doing on elm-watch. We're using it happily in our Django application at work. There are a few features that would make life much easier for us, especially as we would like to integrate our build more directly into Django.
Together with #68, it would be very useful for us to be able to elm-watch make a js file, but still insert the hot-reload code.
The way I would imagine this working is that we could, on a request to our website, generate the js file as a oneshot, which would have the hot-reload code attached so if a developer has elm-watch hot running, the hot-reload connects and they can develop efficiently.

See the discussion in https://github.com/lydell/elm-watch/issues/68


Black screen after GRUB

After installation the first reboot it goes through grub but after it results in a black screen with just my motherboards logo showing.
The only option after that is a reboot.
During the Arch install I selected sway, ext4, pipewire, multilib and for the graphics drivers I've left if on default which installed all open source.
My setup:
Nvidia GTX 1080ti
i7-4790k
Gigabyte z97x

Hmm, have you tried to change the boot order or select another boot device manually in your motherboard’s UEFI?

Yes, I've tried both.
I don't think the issue is caused by the script itself.
I've tried to manually install hyprland and NVIDIA drivers using their documentation however same issue arises.

Try using the command journalctl -Xe or just journalctl when being in the tty you can access it by pressing Ctrl + Alt + F2 and then login to your user or root and watch your logs to see if anything suspicious happens when starting hyprland.


Support for compound devices and "grandchildren"

This refactor furthers the generalizations done previously for devices that provide multiple services to allow for not only mapping of services to capabilities or components, but also multiple device records.
This allows for us to support devices such as the Dymera up/down light.
Other changes:

I found myself frequently introducing bugs related to using the Hue Bridge ID (MAC Address) as a Device ID, and the Bridge Device ID as a Hue Bridge ID. We renamed all instances of bridge_id referencing the MAC to bridge_network_id to try and alleviate the confusion.

Button support is further generalized to support two-button models, which covers the In-Wall Switch Module in the 2-gang configuration.

There's a lot going on here.

Yeah. Adjust the assumption of a Hue device service only exposing a single light service was a deep surgery 😢


Bump up mirror node chart version

Feature to Enhance
Bump up mirror node chart version

Requested Enhancement
Bump up mirror node chart version

Business Need
Bump up mirror node chart version

Additional Context
No response

:tada: This issue has been resolved in version 0.29.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: Add back Chaindesk retriever

Why was the Chaindesk retriever removed from the LangchainJS package?

Thank you! Removed the old Databerry docs and marked it as deprecated.

Why was the Chaindesk retriever removed from the LangchainJS package?

I don't think it was ever merged:
https://github.com/langchain-ai/langchainjs/pull/1837

Thanks for your patience!


Add context for the graph dates on the shutdown details page

I'm not sure I understand the date labels on the x-axis for the shutdown details (i.e. the travel times graph).
I assume the data after the shutdown corresponds to dates after shutdown and the before data corresponds to dates before the shutdown, but the values are displayed as if they are from the same dates (according to the x-axis label).
Not sure how this is a bug or if the axes just need to be labelled differently.

Those dates correspond to the dates of the shutdown. But yeah we should figure out a way to display the proper range


Watch mode exits after first run when using near-operation-file

Describe the bug

When using the near-operation-file preset watch mode exits right after the first iteration.
To Reproduce
Steps to reproduce the behavior:
Run gql-gen with near-operation-file configured

My GraphQL schema:

# Schema is huge. If you can't reproduce, I'll try to find the minimal reproduction setup

My GraphQL operations:

# Same as above

My codegen.yml config file:

schema: ./packages/app/src/graphql/schema/schema.graphql
overwrite: true
documents:
  - ./packages/app/src/**/*.fragment.ts
  - ./packages/app/src/**/*.query.ts
  - ./packages/app/src/**/*.mutation.ts
generates:
  ./packages/app/src/graphql/schema/index.ts:
    plugins:
      - add: '/* eslint-disable */'
      - typescript
    config:
      scalars:
        Date: Date
        DateTime: Date
        DateTimeOffset: Date
        Guid: string
        Decimal: number
        Seconds: number
        Milliseconds: number
  ./packages/app/src/graphql/schema/introspection.ts:
    plugins:
      - add: '/* eslint-disable */'
      - fragment-matcher
  ./packages/app/src:
    preset: near-operation-file
    presetConfig:
      extension: .generated.tsx
      baseTypesPath: graphql/schema
    plugins:
      - add: '/* eslint-disable */'
      - typescript-operations
      - typescript-react-apollo
    config:
      withHOC: false
      withComponent: false
      withHooks: true

Expected behavior

Watch mode should keep running
Environment:

OS: Windows 10
@graphql-codegen/1.3.1:
NodeJS: 12.3.1

Additional context

Other issues with near-operation-file

Output is quite spammy. As also seen above. Each generated file produces a √ Parse configuration line
While running, a weird warning appears (i think it comes from prettier, see screenshot below)
Execution is quite slow compared to generating a single file. At least 300% slower.
When referencing fragments, alot of unused imports are added to the generated files (i think this has been reported already)

The weird prettier error should be fixed by #2071

@dotansimha I think most of this is resolved, but are you still working out some kinks with near-operation-file? I noticed an issue where the base types file isn't always referenced in mutations and queries, when it should.
If you're not aware of that issue, I can create a new issue for it, and try to provide some minimal reproduction steps.

The issue I'm seeing somehow relates to this bit of code: https://github.com/dotansimha/graphql-code-generator/blob/master/packages/presets/near-operation-file/src/index.ts#L161
I'm wondering whether it may not be easier to just always reference the base types file, and not try to be smart about it. Are there ever cases where a file doesn't need it?

Fixed in 1.4.0 🎉


FLEX-2294 ~ Fixes validation when only tlsEnabled is used.

If the tlsPortNumber is omitted, the validation was incorrect.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 TlsConfigurationValidator.java#L36: The Cyclomatic Complexity of this method "isValid" is 11 which is greater than 10 authorized.

All is well.


New version: Google.AndroidStudio version 2<IP_ADDRESS>

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Will pass validation after index publish of:

#162940

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

https://github.com/microsoft/winget-pkgs/issues/142854


Use this Google Colab notebook to convert the encoder and decoder models

It's a nice idea but without a subscription, the free tier VM crashes due to lack of memory, and you never get the models.
Edit;
Looks like the files are available here:
https://huggingface.co/vietanhdev/segment-anything-2-onnx-models/tree/main
but the file names are a bit different.
For example:
sam2_hiera_base_plus.decoder.onnx -> sam2_hiera_base_plus_decoder.onnx
sam2_hiera_base_plus.encoder.onnx  -> sam2_hiera_base_plus_encoder.onnx

With the latest changes, other models will not work. Use these models:
https://github.com/ibaiGorordo/ONNX-SAM2-Segment-Anything/releases/tag/0.2.0


<EMAIL_ADDRESS>

PLEASE READ
If you have a support contract with Google, please create an issue in the support console. This will ensure a timely response.
Discover additional support services for the Google Maps Platform, including developer communities, technical guidance, and expert support at the Google Maps Platform support resources page.
If your bug or feature request is not related to this particular library, please visit the Google Maps Platform issue trackers.
Check for answers on StackOverflow with the google-maps tag.

Deleting for promoting irrelevant content.


Casting error when using optional with select

With the following schema:
module default {
  type Post {
    required postId: str;
  };
}

Running the following:
insert Post{ postId := "post1"};

select <optional Post>Post{*} limit 1;

I get an error message of:
QueryError: cannot cast object type 'default::Post' to 'default::Post', use `...[IS default::Post]` instead

Versions:

EdgeDB Version:3.1+1f030a7
EdgeDB CLI Version:3.4.0+160d07d
OS Version:Debian bullseye

Some (perhaps not relevant) context: https://discord.com/channels/841451783728529451/950503041889628200/1130007847233659010

This is expected.  Casts are not valid for object types.  Also, select Object is already optional because we can never guarantee that there is at least one such object in the database.

Ok, thanks. I'll close this.


Update: Common Id Field Conversion Scenarios For Import Prisma Schema

(docs): Adding the Common Id Field Conversion Scenarios section to th…e How Prisma Schema are converted into entities page.

Hey @abrl91, I just added the above section. Does it accurately list all the ways the id field can get handled? Please let me know. Thank you.
CC @GreenMachine01

@dericksozo approved, but I just saw it in another PR, so do we still need this PR?


It does not work when compare with golden

First capture
Tutorial02_Cube.exe --capture_path ./ --golden_image_mode capture --capture_name cube -w 640 -h 480 -m d3d11

Then Edit the dump image
Then compare
Tutorial02_Cube.exe --capture_path ./ --golden_image_mode compare --capture_name cube -w 640 -h 480 -m d3d11

But it worked when I debug with visual studio

When I run
Tutorial02_Cube.exe --capture_path C:/Users/xin.pan/source/repos/DiligentEngine/cmake_build/DiligentSamples/Tutorials/Tutorial02_Cube/Debug --golden_image_mode compare --capture_name cube -w 640 -h 480 -m d3d11

I get the exitcode 0. And there is no information indicating whether the result was a success or a failure.
In fact, it will be fail, because the golden image has been modify.
But when I debug with visual studio, set Tutorial02_Cube as startup project and set Debugging commad arguments
--capture_path C:/Users/xin.pan/source/repos/DiligentEngine/cmake_build/DiligentSamples/Tutorials/Tutorial02_Cube/Debug --golden_image_mode compare --capture_name cube -w 640 -h 480 -m d3d11

Then I got the info about compare fail with the golden and exit code 10

Maybe I use the wrong cmd to compare, pls tell me the right. Thx.

When I run
Tutorial02_Cube.exe --capture_path C:/Users/xin.pan/source/repos/DiligentEngine/cmake_build/DiligentSamples/Tutorials/Tutorial02_Cube/Debug --golden_image_mode compare --capture_name cube -w 640 -h 480 -m d3d11

I get the exitcode 0. And there is no information indicating whether the result was a success or a failure.
In fact, it will be fail, because the golden image has been modify.
But when I debug with visual studio, set Tutorial02_Cube as startup project and set Debugging commad arguments
--capture_path C:/Users/xin.pan/source/repos/DiligentEngine/cmake_build/DiligentSamples/Tutorials/Tutorial02_Cube/Debug --golden_image_mode compare --capture_name cube -w 640 -h 480 -m d3d11

Then I got the info about compare fail with the golden and exit code 10

Maybe I use the wrong cmd to compare, pls tell me the right. Thx.

I can reproduce the problem too - when I run the command, I see the return code is 0.
However, when I put the same command into a bat file and ran it, the return code was correct.
To be honest, I have no idea what is going on. Windows bash has always been a mystery to me.

I'm not very familiar too. It seems that should give the exit code to quit-message.  It work here.
   if (GoldenImgMode != NativeAppBase::GoldenImageMode::None)
    {
        g_pTheApp->Update(0, 0);
        g_pTheApp->Render();
        // Dear imgui windows that don't have initial size are not rendered in the first frame,
        // see https://github.com/ocornut/imgui/issues/2949
        g_pTheApp->Update(0, 0);
        g_pTheApp->Render();
        g_pTheApp->Present();
        auto ExitCode = g_pTheApp->GetExitCode();
        g_pTheApp.reset();
        PostQuitMessage(ExitCode);
        return ExitCode;
    }

I tried that, but it does not seem to make any difference.
The PostQuitMessage does not define the exit code, the code is still what is returned by the main function.
Why it is not picked up by the bash, I don't know really.

I don’t know either.  Close this issue？

Let's keep it open - this is really strange behavior. Maybe we will find solution at some point later.

Can you try these?
index 69b6e0c..ef58563 100644
--- a/NativeApp/src/Win32/WinMain.cpp
+++ b/NativeApp/src/Win32/WinMain.cpp
@@ -40,6 +40,10 @@
 #include "StringTools.hpp"
 #include "Timer.hpp"

+// clang-format off
+#pragma comment( linker, "/subsystem:\"console\" /entry:\"WinMainCRTStartup\"")
+// clang-format on
+
 using namespace Diligent;

 std::unique_ptr<NativeAppBase> g_pTheApp;```


Simple sync server and client

Your code is to complex for me and I was hoping you might have a very basic client server websocket example.  The websockect example  looks like what I am looking for but I can't get it working. I am trying to have a simple page with two buttons connect and add so I can see in a simple way how these components work.
I am sure you are busy, but if you get a chance anything will help.  Also I noticed that v2.0 has improved the syncable component thanks to you so kudos.

Unfortunatelly I don't have a client websocket example just https://github.com/nponiros/sync_server which has websocket support but I'm guessing that is the code you found complex.
What is the issue with the example in the dexie repo? Maybe you can post the error or show me your code.

This issue fixed my original problem of db.hasBeenClosed  but now it stays at Sync Status changed: CONNECTING.  No data is added.
TestServerClients.zip

Okay, I will try to have a look tomorrow. It's pretty late here

Thank you and have a good night.

So I spent over an hour trying to get this thing to work with no success. As it seems data is sent to the server but the server is not receiving the data. It might be some incompatibility issue between the server/client websocket implementation it might also be some other error because the client also didn't write any data into indexeddb. I'm afraid I can't help you with this.. Perhaps someone can help if you open an issue on the dexie repo..

Thank you very much for trying and putting so much time in. I really appreciate it!


Correctly rollback in ForkRepository

The rollback functionality in
services/repository/repository.go:ForkRepository is incorrect and could
lead to a deadlock as it uses DeleteRepository to delete the rolled-back
repository - a function which creates its own transaction.
This PR adjusts the rollback function to only use RemoveAll as any
database changes will be automatically rolled-back. It also handles
panics and adjusts the Close within WithTx to ensure that if there is a
panic the session will always be closed.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #17034 (966439c) into main (8af7a21) will increase coverage by 0.02%.
The diff coverage is 45.45%.

:exclamation: Current head 966439c differs from pull request most recent head 6da7f16. Consider uploading reports for the commit 6da7f16 to get more accurate results

@@            Coverage Diff             @@
##             main   #17034      +/-   ##
==========================================
+ Coverage   45.22%   45.24%   +0.02%
==========================================
  Files         766      766
  Lines       86632    86637       +5
==========================================
+ Hits        39178    39203      +25
+ Misses      41107    41088      -19
+ Partials     6347     6346       -1

Impacted Files
Coverage Δ

modules/repository/fork.go
54.28% <40.00%> (+5.89%)
:arrow_up:

models/context.go
56.00% <100.00%> (-1.15%)
:arrow_down:

modules/queue/queue_bytefifo.go
59.28% <0.00%> (-3.60%)
:arrow_down:

modules/queue/queue_channel.go
95.00% <0.00%> (-1.67%)
:arrow_down:

services/pull/pull.go
41.78% <0.00%> (-0.41%)
:arrow_down:

modules/queue/workerpool.go
46.94% <0.00%> (-0.39%)
:arrow_down:

models/issue_comment.go
52.05% <0.00%> (+0.88%)
:arrow_up:

modules/log/event.go
62.50% <0.00%> (+1.85%)
:arrow_up:

modules/git/utils.go
70.83% <0.00%> (+2.77%)
:arrow_up:

modules/git/repo_base_nogogit.go
85.71% <0.00%> (+2.85%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af7a21...6da7f16. Read the comment docs.

While I can completely understand the implementation,
adding a test might be beneficial here so that this potential deadlock does not occur again sometime else.

I don't think it's testable. The deadlock could only happen if there was an error whilst creating the fork, even then it would only occur extremely randomly. We can't force an error, we can't force the deadlock. Even if we had a fully mocked up xorm we'd have to code in what it means to deadlock.
There some very complex solutions that could help reduce the risk of these errors in future but they'd come with their own issues too.
If you can think of a test then I'm happy to discuss.

That is unfortunately correct.
The only thing we could test is whether it behaves correctly under normal circumstances.

make lgtm work


RLS: 0.17.1

looking to do this on around Nov 20th (next friday)

Sounds good!

so going to tag shortly.
@jorisvandenbossche if you'd build/upload docs would be awesome. lmk when ready.

yep, currently checking if there are still some doc issues with latest master

ok will wait for @TomAugspurger good to go
on styling and ok from you

@jorisvandenbossche do you have jupyter nbconvert installed? I haven't documented that anywhere, but that's what is used for the notebook -> html.
I hope that's not messing anything up with the doc build. I'm seeing a lot more output than I recall, but I haven't built the full API docs in a while.

yes, that is no problem. We should just update the doc building docs sometime
The doc build has grown a lot over the last years :-) (seeing a lot of output is normal, but you should be able to see the difference between normal output and errors/warnings)

Ok https://github.com/pydata/pandas/pull/11660 is merged.

@jreback You can tag after merging #11663 I think. I will only be able to build the docs later this evening or tomorrow morning (but it takes some time untill all artifacts are produced to be able to do the announcement anyway I think?)

@jorisvandenbossche yeh totally cool.
I'll tag after you merge that. Just won't send the announcement till docs are up.

ok, tagged and released on github. https://github.com/pydata/pandas/releases/tag/v0.17.1
will put on pypi / conda soon.
@jorisvandenbossche when builds are up, then links should be good & I will send out announcement & close this issue.
thanks everyone for making v0.17.1!

@jreback  right now http://pandas.pydata.org/pandas-docs/version/0.17.1/whatsnew.html#whatsnew-style doesn't have CSS. Looks like I messed something up? Will look in a bit.

yep, indeed, for some reason it does not give an error, but such a strange non-styled page if the version is not correctly specified

docs are up!

Thanks!

On Nov 21, 2015, at 01:36, Joris Van den Bossche<EMAIL_ADDRESS>wrote:
docs are up!
—
Reply to this email directly or view it on GitHub.

thanks everyone!

@jorisvandenbossche do you know if we need to do any redirection of links from the pandas.pydata.org website?
http://pandas.pydata.org/pandas-docs/stable/style.html is different from
http://pandas.pydata.org/pandas-docs/version/0.17.1/style.html. The first one doesn't seem to have the CSS changes I made.

@TomAugspurger for me (on Firefox), they both look the same (and really 'pretty', but I thought it was like this, also the travis docs look like that for me)

Looks like my browser was caching it. I reset that and things look good.


Update Personal Tasks Component filter out completed tasks and allow for max tasks

Category

[x] Feature request

Is your feature request related to a problem?

There is no way to limit the amount of tasks returned. If there are a lot of tasks in the planner or todo they will all be rendered and makes the page  longer than it should be.

Describe the solution you'd like

I would like to ability to customize the web part code in order to limit the amount of tasks rendered, and also be able to filter out tasks that have been marked as completed.

Describe alternatives you've considered

I have attempted to use the filter function mentioned in the official mgt-tasks documentation but efforts have been unsuccessful

Unfortunately this is not something is attainable with this web part, as we are using the MGT Component for Tasks, which does not provide methods for selecting max records to return.


Error of compilation on main branch

I have encountered following compilation errors on the main branch. It's okay on the v0.7 branch.

/workspace/include/tvm/support/logging.h:129:70: note: suggested alternative: 'clearerr'
<< ICHECK_INDENT << "Check failed: " << #x " " #op " " #y << *(_check_err.str) << ": "
^
/workspace/include/tvm/support/logging.h:140:25: note: in expansion of macro 'ICHECK_BINARY_OP'
#define ICHECK_EQ(x, y) ICHECK_BINARY_OP(_EQ, ==, x, y)
^~~~~~~~~~~~~~~~
/workspace/src/auto_scheduler/compute_dag.cc:863:5: note: in expansion of macro 'ICHECK_EQ'
ICHECK_EQ(ori_iter_names.size(), 1);
^~~~~~~~~
/workspace/src/auto_scheduler/compute_dag.cc: In member function 'tvm::runtime::String tvm::auto_scheduler::ComputeDAG::PrintDAG(bool) const':
/workspace/include/tvm/support/logging.h:126:13: error: 'LogCheckError' is not a member of 'dmlc'
if (dmlc::LogCheckError _check_err = dmlc::LogCheck##name(x, y)) \

So, i found the include/tvm/support/logging.h on the main branch is different with the v0.7 branch, and i couldn't find the LogCheckError in the tvm source directory.
Am i missing something?

Can you try updating your tvm git submodules?

It's working. Thank you very much!


added NVIDIA_DRIVER_DEVICES and NVIDIA_DRIVER_CAPABILITIES

Added these env variables to the docker run command in order to get access to nvidia libraries.
This looks like a necessary step for nvidia docker v2.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@hugomatic please sign the CLA. Thanks!


When "bigchaindb start", give user hints on what they can do next

When you start RethinkDB, it gives some hinds on what you can do next:
Listening for intracluster connections on port 29015
Listening for client driver connections on port 28015
Listening for administrative HTTP connections on port 8080
Listening on addresses: <IP_ADDRESS>, <IP_ADDRESS>, ::1
To fully expose RethinkDB on the network, bind to all addresses by running rethinkdb with the `--bind all` command line option.
Server ready, "ascribe3_XPS_8700_5nu" fafe8d60-0494-4ea9-ad78-5305b6fc97b5

Brett suggested we could have some hints like that when the user runs bigchaindb start. Here's what it says now:
Generating keypair
Database host? (default `localhost`):
Database port? (default `28015`):
Database name? (default `bigchain`):
Ready to go!
INFO:bigchaindb.config_utils:Configuration loaded from `/home/troy/.bigchaindb`
INFO:bigchaindb.db.utils:Create:
INFO:bigchaindb.db.utils: - database `bigchain`
INFO:bigchaindb.db.utils: - tables
INFO:bigchaindb.db.utils: - indexes
INFO:bigchaindb.db.utils: - genesis block
INFO:bigchaindb.db.utils:Done, have fun!
INFO:bigchaindb.commands.bigchain:Start bigchaindb main process
INFO:bigchaindb.processes:starting bigchain mapper
INFO:bigchaindb.processes:starting backlog mapper
INFO:bigchaindb.processes:starting block
INFO:bigchaindb.processes:starting voter
INFO:bigchaindb.block:bootstraping block module...
INFO:bigchaindb.block:finished reading past transactions
INFO:bigchaindb.voter:voter waiting for new blocks
INFO:bigchaindb.block:finished bootstraping block module...
INFO:bigchaindb.block:starting block module...

That is fairly informative, but then it feels like it maybe got stuck. Is it still starting block module? Is it "ready" in some sense? If so, in what sense?

Listening for intracluster connections on port 29015
Listening for client driver connections on port 28015
Listening for administrative HTTP connections on port 8080
Listening on addresses: <IP_ADDRESS>, <IP_ADDRESS>, ::1
To fully expose RethinkDB on the network, bind to all addresses by running rethinkdb with the --bind all command line option.
Server ready, "ascribe3_XPS_8700_5nu" fafe8d60-0494-4ea9-ad78-5305b6fc97b5

The lines are well informative, usually in Linux this means "process is running". I think just add "Process is running at PID xyzw" (the outcome from pgrep bigchaindb?) before "Server Ready" could be fine.
I usually run the command with: nohup bigchaindb start &, it prints back one of the PIDs.
This actually makes much clearer the thing and you get the command line usable again but I got some problems at stopping the background preocesses (as it starts 13 different processes). Having something like bigchaindb stop to kill all the processes would be great.
Addendum: it would be nice to have the precise command to run the conftest.py and other tests files added after the benchmark in the README.

A more descriptive initialization message is resolved in #139
Document how to run the tests will be resolved in #140
There is an open issue for a clean exit of all bigchaindb processes #122


支持仅配置需自定义的配置项

Allow partial config to be merged with default config 支持仅配置需自定义的配置项

这个方案可能会对新用户造成混淆，在末尾新建一个’merge_config’ kwarg 是不是更好一些？或者其他名字也可以
This may cause confusion in new users. How about adding an additional ‘merge_config’ kwarg at the end of the list? You may also come up with a better name.

这个方案可能会对新用户造成混淆，在末尾新建一个’merge_config’ kwarg 是不是更好一些？或者其他名字也可以
This may cause confusion in new users. How about adding an additional ‘merge_config’ kwarg at the end of the list? You may also come up with a better name.

新用户使用默认配置没有影响，这是进阶用户才会使用到的功能

I find the existing functionality confusing and this PR to be an improvement.
This should be valid but it's not:
swagger = Swagger(app,  config={
    "swagger_ui": False,
})

Instead users have to provide something like
swagger = Swagger(app,  config={
    "headers": [
    ],
    "specs": [
        {
            "endpoint": 'apispec_1',
            "route": '/apispec_1.json',
            "rule_filter": lambda rule: True,  # all in
            "model_filter": lambda tag: True,  # all in
        }
    ],
    "static_url_path": "/flasgger_static",
    "swagger_ui": False,
})

Since we have existing users expecting config to entirely replace self.DEFAULT_CONFIG.copy(), this change have the potential to create unexpected behaviors. It is nevertheless true that current behavior can be confusing. I think that a pull request with a different field name for this use case would be helpful. For this keyword argument, it is better to default to None and be initialized in function body to a dictionary out of convention. Additionally, a warning may be added in the documentations to warn the users that config replaces rather than amends self.DEFAULT_CONFIG.copy(). What do you think? @luohuaizhi @joeystevens00
由于我们已有用户希望config能够完全替代self.DEFAULT_CONFIG.copy()，因此此更改有可能产生意外行为。 但是，当前的行为确实令人困惑。 我认为对于此用例，使用不同字段名称的PR会有所帮助。 对于这个关键字参数，最好默认为None``并在函数体中初始化为dict()以此符合约定。 另外，最好在文档中添加警告以警告用户config代替而不是修改self.DEFAULT_CONFIG.copy()```。你怎么看？

A "merge=False" keyword argument will be added to the __init__ argument list and, when "merge=True", the behavior will be as defined in this commit. I will rebase and merge this commit with the above modification soon.

Merged in 63ed0ca5aef656105b3a6e39f07b7c259d3c4768 with modifications. Thank you for your contribution!


Add load/store scalarization through loops.

Currently, if we cannot detect contiguous memory access, we generate a sequence of scalar operations. In some cases, it might produce a lot of codes and cause a really long compilation. E.g. we use reduced input size in test_permute because of this problem.
This patch adds an option to generate scalar loops for such loads and stores. It helps to significantly reduce compilation time for scalarized loads/stores for big tensor sizes. We can now run the permute test with the original input size in a few seconds compared to several minutes when loops are not used.
Here is a store loop generated for perm_test:
    %alloca = memref.alloca() {alignment = 64 : i64} : memref<128x128xf32> loc(#loc4)
    vector.transfer_write %765, %alloca[%c0, %c0] {in_bounds = [true, true]} : vector<128x128xf32>, memref<128x128xf32> loc(#loc4)
    scf.for %arg4 = %c0 to %c128 step %c1 {
      scf.for %arg5 = %c0 to %c128 step %c1 {
        %766 = arith.index_castui %arg4 : index to i32 loc(#loc7)
        %767 = tt.addptr %arg2, %766 : !tt.ptr<f32>, i32 loc(#loc8)
        %768 = arith.index_castui %arg5 : index to i32 loc(#loc7)
        %769 = arith.muli %768, %arg3 : i32 loc(#loc9)
        %770 = tt.addptr %767, %769 : !tt.ptr<f32>, i32 loc(#loc10)
        %771 = memref.load %alloca[%arg4, %arg5] : memref<128x128xf32> loc(#loc4)
        tt.store %770, %771 : !tt.ptr<f32> loc(#loc6)
      } loc(#loc6)
    } loc(#loc6)

Here is the corresponding ASM code:
.LBB0_1:
        movslq  %eax, %rsi
        leaq    (%r9,%rsi,4), %rsi
        xorl    %edi, %edi
        xorl    %r8d, %r8d
.LBB0_2:
        movslq  %edi, %rdi
        vmovss  (%rdx,%r8,4), %xmm0
        vmovss  %xmm0, (%rsi,%rdi,4)
        incq    %r8
        addl    %ecx, %edi
        cmpq    $128, %r8
        jne     .LBB0_2
        incq    %rax
        addq    $512, %rdx
        cmpq    $128, %rax
        jne     .LBB0_1

Right now, it's done in memory op conversion pass. But I think we should introduce a more generic scalarization pass that would work on TTIR before transitioning to vectors. The goal of the pass would be to find operations that cannot be vectorized and generate scalar loops.
This patch should resolve #86

mostly makes sense, but MLIR tests would help me visualize this transform :)
also the test failure looks legit

also the test failure looks like it may be legit

Yes, the problem was in storing/restoring a vector mask. I've fixed it.

@int3 Thank you for your review! I've addressed all your comments.


Introduce dynamic cluster setting to disable concurrent segment search for given types of aggregations

Also refactored parent-join search ITs to support concurrent search parameterization and introduced a new test to cover concurrent search failures.
Description
Some types of aggregations, especially those in custom search plugins, may be unable to utilize concurrent segment search due to their internal implementation. This setting provides a way to disable concurrent segment search when certain types of aggregations are used.
For the newly added tests, both of these tests will actually pass with concurrent search enabled due to problem 2 here https://github.com/opensearch-project/OpenSearch/issues/9316#issue-1850332933. However, once problem 2 is fixed these tests will catch the issue in problem 1.
Related Issues
Resolves #9446
Relates #9316

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta @sohami opened a PR for #9446, could you please help review? Thanks!

@reta Thanks for the feedback! I briefly discussed that here #9446 (comment) (apologies the information is kind of spread out across a few issues). There are 2 main reasons why I think a dynamic cluster setting is preferable here:

I understand the tradeoffs of dynamic setting. Since at this moment we cannot guarantee that all aggregation out of the box are compatible with concurrent search, the safe option would be to enable them on per aggregation basis which will be done in backward compatible way (no issues here to have it in 2.x if implemented properly). The most beneficial thing to have it in API is awareness for plugin developers that there are additional considerations to take into account (and that would be done on explicit optin manner by plugin developers).
I assume the aggregation either works or does not work with concurrent search so flipping nature of dynamic setting is not helpful here. Plus, now we offload this burden to users, how they should know which aggregations are compatible with concurrent search and which are not? It is an option for sure but I think not the one we should implement.

I assume the aggregation either works or does not work with concurrent search so flipping nature of dynamic setting is not helpful here.

For the parent aggregation that kicked off this whole investigation, the "correctness" will actually depend on the cardinality of the data. If there is only 1 child document for every parent document, the current implementation will work just fine with concurrent search. In general it seems like the cardinality of the data can affect both the correctness and performance of aggregations, which is where the benefits of a dynamic setting come in.

in backward compatible way (no issues here to have it in 2.x if implemented properly). The most beneficial thing to have it in API is awareness for plugin developers

I'm splitting hairs a little bit here but I do think these two things are slightly at odds with each other. If we do this in a bwc way (default concurrent search support to false), then plugin developers won't necessarily be aware that there is a concurrent search support override they can add, especially for any existing plugins.

Plus, now we offload this burden to users, how they should know which aggregations are compatible with concurrent search and which are not?

I think this is a good point, but at the same time ideally any custom search plugin should have functionality testing to determine if the results are still correct after enabling concurrent search.

For the parent aggregation that kicked off this whole investigation, the "correctness" will actually depend on the cardinality of the data

Please, we are not discussing the edge cases here (everything will work with empty index as an example), we should be mindful so correctness means - the aggregation return the correct results all the time.

I'm splitting hairs a little bit here but I do think these two things are slightly at odds with each other. If we do this in a bwc way (default concurrent search support to false), then plugin developers won't necessarily be aware that there is a concurrent search support override they can add, especially for any existing plugins.

This is totally fine I think, remember that we would potentially require either additional work (or worst, complete rework), it is much safer (for 2.x) to follow the "least surprise". Also keep in mind, users would report bugs to plugin authors but we caused them.

I think this is a good point, but at the same time ideally any custom search plugin should have functionality testing to determine if the results are still correct after enabling concurrent search.

This is why we should make it API driven, not settings driven - plugin developer would not even notice there is a setting, and what should they do with it?

I think this is a good point, but at the same time ideally any custom search plugin should have functionality testing to determine if the results are still correct after enabling concurrent search.

This is why we should make it API driven, not settings driven - plugin developer would not even notice there is a setting, and what should they do with it?

I agree that API level override in Aggregation will be better for figuring in backend core engine about which Aggregation doesn't work with concurrent segment search and decide which path to take based on it. By default, it will be false and once plugin developer tested the specific Aggregation with concurrent segment search enabled they can flip it to true. We may need to add some documentation around this to make it more visible to plugin developers and not miss on opportunity where existing plugin will work just fine.
For dynamic setting, the thought process was that mostly we are not seeing Aggregations having issues with concurrent segment search. This setting can help for cases where on a cluster user is using multiple different aggregations across request types and ended up hitting some bugs for a particular aggregation. So they will have the option to disable it for specific aggregation request types. On thinking more about this was wondering if we can instead make it a request level option for such use cases. Cluster level is global backend setting and request level can be an override for global setting for specific request types. Request level will be generic for any other operators and not specific to aggregations only.
To summarize: We can do the API level change for now and let the plugins specific implementation to enable once the have verified. We can explore the need for request level as a follow-up, meanwhile index/cluster level settings can be used to handle cases where some unknown issues are seen with concurrent search.

Thanks @sohami

We may need to add some documentation around this to make it more visible to plugin developers and not miss on opportunity where existing plugin will work just fine.

Also, we may add log message to highlight that the concurrent path was not taken

To summarize: We can do the API level change for now and let the plugins specific implementation to enable once the have verified.

:+1:

@sohami @reta Thanks for the discussion!
I see now that coming at it from the plugin developer perspective, the dynamic cluster setting doesn't provide a way for the developer to indicate that their plugin does not support concurrent search. Moreover, the implementation I have here is using the "type" string of the aggregation, which is provided by the aggregation itself and can be re-used by different plugins (multiple aggregation with the same "type" just can't be installed at the same time). This means that there isn't really a good way to disable concurrent aggs for a given plugin by default.
Originally the thought was that there may be some undiscovered edge cases in some aggregations that do not work well with concurrent search and thus we should provide a way to dynamically disable concurrent search in those cases, however I agree that having this be a request level option is more user friendly. I'll create a separate issue for us to discuss the specifics of if/how we want a request level concurrent search parameter and I'll change this PR to have an API level check for concurrent search.

Pushed a new revision that adds a supportsConcurrentSegmentSearch() method to the Aggregator class which will be used in AggregatorFactory::create to update searchContext.useConcurrentSearch.
The default in Aggregator is false like we discussed but I have not implemented the override in all of the child classes yet since I wanted to check in and see if the general approach looks good first before doing so. Please let me know what you think @reta @sohami thanks!

Upon closer inspection, I don't think the latest commit will work because Aggregator objects are created from AggregationProcessor::preProcess which means this is too late in the request -- isConcurrentSegmentSearchEnabled() will have already been checked to create the AggregationCollectorManager. This means we will need to use implement supportsConcurrentSegmentSearch at the AggregatorFactory level and make sure we set the search context properly in SearchService::parseSource.

@reta @sohami this is ready for review now, let me know what you think. Thanks!


Issue with download

Amazon error under specific circumstances ends up in the file. I need to parse xml to validate errors.

An example of this is the following:
A file contains the following content:
ColumnA ColumnB ColumnC
1 2 3.00

But when downloading it, the following lines are added inside the file itself:
rror</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>ABVFASDFRDFG</RequestId><HostId>SomeHostID</HostId></Error>

Fixed in 0.8.0


Server-side only validation for nuxt pages/layouts

What problem does this feature solve?
The web application I am developing is a single nuxt app in universal mode. It provides an access to three different user groups. Each of these has their own separate interface which they are authorised to use and the login interface before they get there.
Currently there is no way for me to fully protect these interfaces from being retrieved by the users who fiddle with the source code and bypass a couple of things (rare, but nevertheless possible).
Solutions like middleware or nuxtServerInit are not useful as either they are executed both client and server-side (exposing the crucial bit of code to the user) or they are fired only once on the initial page load. Given the scenario when users begin on the main page of the website (before they log in), nuxtServerInit or serverMiddleware have already fired and there is no way to follow the same pattern once they hit the login button to validate their request and conditionally download secured chunks (as I mentioned above, we are all the time in the same nuxt app).
The only current solution I can think of is to create 4 separate nuxt applications (referring to my use case). One for the main page/login screen and three other for the interfaces of particular user groups downloaded only if the request is verified and appropriate user claims are present. Quite a bit of work to solve the issue mentioned above.
What does the proposed changes look like?
A server-side only middleware fired when requesting a page/layout which contains a particular field, for instance:
serverMiddleware: 'userGroup1'.
Presence of such field would also keep the specified page/layout in the server-side only bundle.

This feature request is available on Nuxt community (#c10717)

Could lazy loading those specific interfaces be an approach working for your requirements? This way the bundles could be separated and loading only initiated by your business logic.
Although I asked myself, will this really help you reaching your goals. Even if bundles are split I would assume they can be access / downloaded by anyone.

As you suspect, lazy-loaded chunks can be e.g. protected by the meta fields and have a vue router firing beforeEach, but this logic is still exposed in the client-side code, unless you think of other solution that is unfamiliar to me.
I am definitely missing a feature allowing me to keep the single-page app experience and yet be able to download chunks with a server-side validation only which have no code placed in the client bundle.
There was other recent request (#7474) where someone asks for exactly the opposite feature, allowing the middleware to run client-side only in SSR mode. I think that being provided with the choice of client/server-side only middleware would be a great feature to have in Nuxt.


[ffmpeg-qsv][gst-msdk][regression]the MediaSDK commit:e126273431b470a738e4c26896b829a6801cb455 will cause regression.

Our CI shows that the MediaSDK commit :  e126273431b470a738e4c26896b829a6801cb455 will cause  ffmpeg-qsv/gst-msdk avc decode regression.
For gst-msdk:
MediaSDK-e126273431b47
gst-msdk.decode.avc         total:310      pass:305     fail:5
MediaSDK-995f036b7ab00e
gst-msdk.decode.avc         total:310      pass:307     fail:3
We hope to get your help.
thanks~

@guowillyy , please prioritize .

sure, will look into it.

@yefengxx, may I know where can I get the failed test case and how to repro the issue?

@guowillyy here is the mediainfo details for one failing case:
Video
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile<EMAIL_ADDRESS>Format settings                          : CABAC / 4 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 4 frames
Duration                                 : 834 ms
Width                                    : 3 840 pixels
Height                                   : 3 840 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Variable
Frame rate                               : 59.940 (59940/1000) FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Writing library                          : x264 core 148 r2643 5c65704
Encoding settings                        : cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=6 / lookahead_threads=1 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=25 / scenecut=40 / intra_refresh=0 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=23.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00

Notice that it has 4 refs @ L5.2 (same as other failing case).  This causes an infinite loop at
https://github.com/Intel-Media-SDK/MediaSDK/blob/1334f76f9256eab85c3e18b1878ad00082fb8028/_studio/shared/umc/codec/h264_dec/include/umc_h264_task_supplier.h#L683
because it will never satisfy the loop terminator condition at
https://github.com/Intel-Media-SDK/MediaSDK/blob/1334f76f9256eab85c3e18b1878ad00082fb8028/_studio/shared/umc/codec/h264_dec/include/umc_h264_task_supplier.h#L753
due to your change at
https://github.com/Intel-Media-SDK/MediaSDK/commit/e126273431b470a738e4c26896b829a6801cb455#diff-205bc80d363db7407fbe2ddd4136cb43L786-R803

@yefengxx can you try #2327 patch?

@uartie  I tested with #2327 patch and the results is as follows:
gst-msdk.decode.avc total:310 pass:307 fail:3
This is the expected result, indicating that the issue has been fixed by this patch.


Move incoming answers

As an editor, I want to be able to assign incoming answers to other questions with two clicks in order to have answers arriving too late for the right question.

Pleas code this (20.6.2020)

I think we discussed different UIs for this in the past. One of them was to drag and drop into the correct request. I’m not sure how exactly that interaction would work – probably we’d have to show a list of all request at the side of the screen when users start dragging a reply.
I could imagine that dragging a reply might actually be a bit difficult and would go for a simpler solution:

Clicking the "verschieben" button opens a model that allows you to select one of the previous requests.
By default, the current request is selected.
The list of requests ist sorted in inverse-chronological order, i.e. latest request is at the top.
Only three clicks are needed to move a reply.
After moving a questions, editors stay on the same page and can continue browsing through the other replies.

@FrauCsu @drjakob Would that be a good solution for your use case?

YES, loving it, @tillprochaska

@FrauCsu @drjakob: The list of questions you might want to move a reply to might get quite long for long-running projects.
Just to be clear, this is the use case:

Editor sends request A on Monday.
Editor sends request B on Tuesday morning.
User replies to requests A and B on Tuesday evening.
Both replies are attached to the request B, although the first reply actually belongs to request A.
Editor sends request C on Wednesday.

I think we can derive the following constraints from this use case, but I’m not sure if those assumptions are correct:

We only ever want to move replies to requests older than the request the reply is currently attached to. In the example above, we wouldn’t want to move a reply to request C. When the user replied on Tuesday, they didn’t yet receive request C, so their replies belong to request C.
Most replies will belong to a recent request, i.e. there’s no need to show super old requests in the modal.

Yes, constrains are correct. The use case is recent questions. I think we need more information, e.g. date of the question. I think 5 requests will be sufficient.

Displaying the date of the requests is a good idea!

Question solved or need further discussion, @tillprochaska ?

Yes!

@drjakob: This would be the current UI – any feedback?

Yes, @tillprochaska ! Good solutions. Not more than five older questions displayed is also fine.


Revising terminology entry for deterministic builds

We have a couple of open tickets (#1084, #1658) related to improving our documentation around reproducible/deterministic builds.
This PR makes some minimal revisions to the existing terminology entry in order to clarify the meaning/importance of deterministic builds and how to use them.
IMO, we should hold off on adding a dedicated page on this topic until we address the engineering question of how to integrate deterministic builds into the foundry template developer workflow (which currently does not include cargo risczero). See #2075 & https://github.com/risc0/risc0-ethereum/issues/141

Also, in prose, I feel like there should be a space in "Image ID"

hmm ya i guess i agree. this applies to the whole terminology page; will leave fixing it elsewhere for a future PR.


Update README to thank contributors

Reminder to update the README to thank recent PR contributors and to reflect the enhancements they have added to the next release (hopefully out this week).

Contributors are now added to the website.


Update bug reports to list username as well

Would be good to have username (user_id) (with id in brackets) in case username changing is implemented, etc. Currently we just have the user id and you have to memorize who's who and ask around, but that's no fun.

Lol, this is not good first issue: you need to hack around the auth stuff because it's an open api


Output for data/intermediate/KBP/em/type.txt is strange

The content of intermediate/KBP/em/type.txt is strange for the KBP corpus. I haven't tested on other corpora.
type.txt:
/       0       466411
p       1       177541
e       2       270192
r       3       288178
s       4       182380
o       5       480385
n       6       380277
l       7       159181
d       8       28569
i       9       303219
,       10      170403
m       11      42962
a       12      236368
c       13      196298
h       14      38605
t       15      312620
u       16      59252
g       17      59662
z       18      16877
_       19      16360
w       20      5846
k       21      2778
f       22      3852
y       23      52196
b       24      4285
v       25      21442
x       26      1

For relation mentions, type.txt looks fine:
None    0       111343
per:country_of_death    1       10265
per:country_of_birth    2       12040
per:parents     3       6984
per:children    4       6984
per:religion    5       2584
per:countries_of_residence      6       1

I believe the problem is caused by ner_feature.py line 84 to line 91. For relation mention, mention.labels is a list so the code works ok. However, in the case of entity mention, mention.labels is a string (e.g. /person/soldier,/person/actor,/person/politician,/person/author,/person) and the for loop will loop over the characters in the string and thus creating weird type.txt.

Hi, thanks for raising the problem. It seems to be from a recent commit of nlp_parse.py. The issue should be fixed now.


NGOpt does not provide a way to ask for picklability

Steps to reproduce

Create NGOpt optimizer, in my case NGOpt(150, 3000)
Train it for several iterations
Try to save it to a file with optimizer.dump()

Observed Results
Traceback (most recent call last):
  File "opt.py", line 210, in <module>
    checkpoint(final=True)
  File "opt.py", line 202, in checkpoint
    optimizer.dump(optimizer_path)
  File "/home/mcs001/20194474/.local/lib/python3.7/site-packages/nevergrad/optimization/base.py", line 241, in dump
    pickle.dump(self, f)
  File "/home/mcs001/20194474/.local/lib/python3.7/site-packages/nevergrad/optimization/recaster.py", line 296, in __getstate__
    raise ValueError("If you want picklability you should have asked for it")
ValueError: If you want picklability you should have asked for it

But how do I ask for it? I couldn't find any such setting in NGOpt. The error occurs in SequentialRecastOptimizer class which has an .enable_pickling() method, NGOpt has no such method and I don't understand how we get from NGOpt to SequentialRecastOptimizer.
Expected Results
A file that can be used to continue training with optimizer.load()
Relevant Code
Abridged code:
optimizer = OPTIMIZER(parametrization=ng.p.Array(shape=(150,), lower=-6, upper=6), budget=3000)

try:
    for idx in range(optimizer.budget):
        candidate = optimizer.ask()
        fitness = evaluate_candidate(candidate)
        optimizer.tell(candidate, - fitness)
        if idx % CHECKPOINT_INTERVAL == 0:
            optimizer.dump(optimizer_path)
finally:
    optimizer.dump(optimizer_path)

See unabridged code in my repo

For the moment, I think you can add the following after the optimizer has been created.
if(isinstance(optimizer, ng.optimizers.NGOptBase) and isinstance(optimizer.optim, SequentialRecastOptimizer)):
    optimizer.optim.enable_pickling()

Thanks, this worked!

That commit added a function enable_pickling on all optimizers, so you could just call optimizer.enable_pickling after  the optimizer has been created (e.g. from the next version).


Add unit tests for bearer token policy token expiration and refresh

This will help catch and prevent bugs like these:
https://github.com/Azure/azure-sdk-for-cpp/pull/1593
cc @antkmsft, @schaabs

We need log policy and bearer token policy tests:

cc @RickWinter


[Release-1.30] - Bump kine to v0.13.0 for postgres perf enhancements

Backport fix for Bump kine to v0.13.0 for postgres perf enhancements

#10936

Validated with github action go.mod comparison - https://github.com/k3s-io/k3s/issues/10984#issuecomment-2407724045


[WIP] Backport upstream #2052

Backport https://github.com/knative-sandbox/eventing-kafka-broker/pull/2052
This backport is not super important, but it is good when we want to cherrypick things with the bot

/retest

/retest

/test 410-reconciler-aws-ocp-410

/hold
let's wait for the prober PR... to be safe :sweat_smile:

/unhold
@aliok  wanna cherry pick ?

/test 49-e2e-aws-ocp-49

/test 49-e2e-aws-ocp-49

/test 49-e2e-aws-ocp-49

/test 49-e2e-aws-ocp-49

/close


Update README.md with gemini chat()

Documenting ruby invocation for chat()
as it took me a while to make it work (unlike embeddings which was a no brainer)

@palladius I went ahead and made a more subtle note in the README here. Thank you!


LogDotZip has done a part two

LogDotZip has done a part two but I noticed that the book that he showcased is not in the latest version nor does the titanium sword have a new texture other then diamond. So I'm confused is this a old video that he made and just now decided to post or did you forget to put the new link on curseforge. Is this just old things you decided to remove in the new versions and LogDotZip is showcasing a old version?

Well I really doubt he'd ban me for asking a question. It would be pretty pity. I figured I ask for those who were curious about it as well.

yha sorry about that i was tired it was 12:00 am when i saw that
unfortunately its not out yet if you missed a 1 second of the book it
says wip Work In Process. -Darkspyro911
On 6/15/18, BrendonGomez<EMAIL_ADDRESS>wrote:

Well I really doubt he'd ban me for asking a question. It would be pretty
pity. I figured I ask for those who were curious about it as well.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/ImCoolYeah105/Mechanization/issues/7#issuecomment-397510852

--
Marc-Andre Maurice
<EMAIL_ADDRESS>

Update should come out this weekend. It's not quite done yet, still need to add gadgets and assembly to the book, and fix a few bugs.
You should consider joining the discord server for random questions and comments instead of opening a bunch of bug reports: https://discord.gg/6uJ4eJH

ok Thanks @ImCoolYeah105 -Darkspyro911
On 6/15/18, ImCoolYeah105<EMAIL_ADDRESS>wrote:

Update should come out this weekend. It's not quite done yet, still need to
add gadgets and assembly to the book, and fix a few bugs.
You should consider joining the discord server for random questions and
comments instead of opening a bunch of bug reports:
https://discord.gg/6uJ4eJH
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/ImCoolYeah105/Mechanization/issues/7#issuecomment-397650707

--
Marc-Andre Maurice
<EMAIL_ADDRESS>


Alaska is a thing

hourly_emissions_epacems goodtables validation constraints did not recognize AK as a valid state.
I have been to Alaska and I can attest it does in fact exist.

Huh, that's disturbing. Why did this never cause a problem before?

Huh, that's disturbing. Why did this never cause a problem before?


Update README.md

I've updated the README file with:

Added badges from Shields.io to showcase the tech stack.

Request
Kindly assign me Level and merge this pull request @4darsh-Dev .
Thank you!

I've updated the README file with:

Added badges from Shields.io to showcase the tech stack.

Request
Kindly assign me Level and merge this pull request @4darsh-Dev .
Thank you!

Can you add gssoc labels too. As WoB is closed now. M

sure @neeru24 , just share the labels proper name with me .

sure @neeru24 , just share the labels proper name with me .

level1, gssoc-ext, hacktoberfest, hacktoberfest-accepted

done .

done .

Thank you sir and can you also add "level" also... like level1 so that it can be counted towards the leaderboard.


Rajataggarwal91c/test changes

Test

This was a test PR to check if merge to main runs the lint_and_test workflows. Closing.


Revert "Feature/nd174 secrets accessible in plain text"

Reverts ministryofjustice/staff-device-dns-dhcp-infrastructure#322
Having issues with deployment to preprod, seeing the following error which was not seen in dev deployment which ran smoothly:
Stopped reason
ResourceInitializationError: unable to pull secrets or registry auth: execution resource retrieval failed: unable to retrieve secrets from ssm: service call has been retried 5 time(s): RequestCanceled: request context canceled caused by: context deadline exceeded. Please check your task network configuration.

closing this as found the problem, PR for change created here:
https://github.com/ministryofjustice/staff-device-dns-dhcp-infrastructure/pull/325


Please Help

I Opened The Ports 5595,2458 on my vps and i checked it on can u see me and I Sayed Its Opened But When Open The Server I Got This
=== Started 2016-12-13T10-09-03-937 ===
[INFO ][10:09:03] 0 IP ban records loaded.
[WARN ][10:09:03] User account "Local Administrator" disabled
[WARN ][10:09:03] User account "Local Moderator" disabled
[WARN ][10:09:03] User account "Local User" disabled
[INFO ][10:09:03] 0 user records loaded.
[INFO ][10:09:03] 419 bad words loaded
[INFO ][10:09:03] MultiOgar-Edited 1.4.2 - An open source multi-protocol ogar server
[INFO ][10:09:03] WebSocket: ws
[ERROR][10:09:04] Stats Server: listen EACCES <IP_ADDRESS>:2458
[ERROR][10:09:04] WebSocket: EACCES - listen EACCES <IP_ADDRESS>:5595
[ERROR][10:09:04] Please make sure you are running Ogar with root privileges.
[DEBUG][10:09:04] process.exit(1)
=== Shutdown 2016-12-13T10-09-04-091 ===
Please Help Please

That port can't be used. Are you running it with root privileges on an open port? Quite surprised how someone working on Facebook login to work with this can't figure out that he is under an incorrect port.

@kareemman00 make sure you are running with root privaleges, those errors are only caused by permission issues.


Image Files Do Not Preview Under Attachments (IE11)

On Internet Explorer 11, image files do not appear properly as a preview under the attachments portion of the WIT Identify Tab. Tested on Chrome, the images do preview properly. On IE11 they appear as a black box with an X.

I am having difficulty reproing this issue.
Can you check if this is the issue?
Otherwise please verify:

Is this issue specific to certain file formats (png/gif,jpeg)?
Are the errors in the console or network tab (f12)?
Does this repro across different windows machine installations? - Maybe there is some local configuration or setting that is causing this issue?

I've confirmed it is not a registry or internet option issue.

This is an issue across multiple machines. However, it is a government environment where our versions of software (should) be the same.
Your version of IE11 is slightly different, I'm not sure if that would be the only cause.

What happens if you try to download one of those not pictures with the extension (shift + d)?
I'm not getting those html errors you have on the console but can you check the network tab and look for downarrow.png there? Is it returning 200 ok or something else?
Can you upload a fresh picture and get the same error or is somehow related to how to the images were added originally?

The picture downloads as expected. Downloaded and viewed downarrow.png, worked fine.
Deleted downarrow.png, began network recording, added downarrow.png again. Result:

Uploading a new picture did not result in new errors in the console.

You network pane is showing the mime type of the attachment as a simple octet stream and this is more than likely the root cause of the issue.

In azure devops it returned with correct mimetype and so I suspect that this issue is tied to the version of tfs that you are using.


MVVM, Proper usage of BLOC state management and Folder by feature structure

Hey big fan of your videos.
Honestly, I have been waiting for this. So let's get to work.
I went through the code base.  I'd like to propose organising the directory as following for the new comers to adapt easily:

Ideally inside authentication directory this is what I normally do:

But since this is done in firebase, we don't have that much going on in here. So we can simplify this like the first image

We can also throw a local widget directory in there, if needed.

Great suggestion and thank you for writing out the structure so thoroughly!

@KalleHallden do you want me to convert a feature like this? I think Login, Sign up would be a great point to start. Let me know if you want that.
Also, if we start working on this, then until this gets merged we should not accept any other changes in the authentication area to avoid merge conflict. Given this would be a huge change. LMK, what you think

This is by far the biggest issue with the codebase and should be nailed down before continuing. Especially because you have open sourced this, You want anyone jumping in to understand the codebase and how it is to be structured.
I would recommend just making a new folder and start transferring stuff across, the app is small enough that it wouldn't take to long and it avoids all the merge conflicts. Once the new folder is in the desired state you can just point the 'main.dart' at the new folder
Another suggestion I have but can wait until after this change is complete is to move the app to the root of the repo.

@KalleHallden Expecting your feedback. If you agree I'll get started

Yeah definitely man! Go for it, seems like you have a better idea of creating proper structure than me so that would be awesome!

I believe this would be fine to work on in the master branch

@KalleHallden I have been wondering if we should stick with Bloc or change to something else? For example Riverpod may be? Let me know what you think. If you have any preferences or not.

@dinurymomshad As i can see, we aren't using the real bloc atm. I think it's more like an repository approach since the networking calls are directly inside the 'bloc'.
I would prefere to use Riverpod, since we can also provide own states with the StateNotifierProvider or simply can use AsyncData or something like that.
Architecture change suggestion
Also i would make a change in the architecture. I can't see any folder for logic, therefore i would suggest to create a 'domain' and inside a 'logic' folder where all the logic can stay. It forces the developer to seperate logic from ui.
Further more i would like to split the models into entity and model.

The entity is inside the domain folder. It is a class without any fromJson or toJson stuff.
The model is inside data folder. It extends the entity and has all needed parsing methods like fromJson and toJson.

Example:

@Scount https://github.com/KalleHallden/exer_log/issues/10#issuecomment-1206686825
What do think about this?

Yes you are right with the view --> controller including logic --> repository.
What i mean with logic is global logic, functions like sort and filter which are used multiple times from different controllers. I didn't dive in the code that deep to search for things like that but i think, if something like this exists it has to be defined globally so any controller hat access to the same logic.

I think I will get started with very basic implementation. And then we can proceed from there. I am using Riverpod

Work In Progress: https://github.com/dinurymomshad/exer_log/tree/feature/authentication-refactor
@KalleHallden can you assign this issue to me please? And also update in project board if you have any?

@dinurymomshad I suggest you to change the project folder to root too. (Currently its in app/exerlog/) Since this is already a massive update might as well add that too.
And, @KalleHallden, lets merge #55 pull request first than anything, then we can update other features and contribute base on this architecture.

@dinurymomshad I suggest you to change the project folder to root too. (Currently its in app/exerlog/) Since this is already a massive update might as well add that too.

You are right. Gonna do that.

@suzanpradhan done. Please give it a review if you will. I have built the project and ran the app.


VM edit has Link section, but no where in Add VM is there a place to do this

Version: master UI 0.90.0
Steps:

Turn VM on in settings
Add a packet host
Add a VM
Edit VM

Results: No place to add (and doesn't make sense to have) Links for Virtual machines
Expected: Remove Links

VM Service has a section for links.  So need to make sure that it's there for services but not for regular ADD under VM page

master 1/12
VM feature removed from Rancher. When added back in, will do a full retest.  Including retesting this bug.


GUACAMOLE-104: Sanitize filenames before upload or download.

To make tomcat happy, we can just replace slashes with something else - in this case underscores.

_ :+1:


allow space in between words of project name

Changes

Allows a space in the project path

Not sure if it's a great idea to allow this, but let's at least test if it works at all.
Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

I do not think we should be merging this, as the person who wanted to try it didn't get it to work and this change opens us up for many more potential issues.

as the person who wanted to try it didn't get it to work

It is working perfectly fine for us.
I have an unerelated issue with unity 2021.2.0f1 and macOS build when using unity-builder.
But unity-test-runner works good for us.
Ahh, there was only a minor issue that ls command to print project directory is not quoted. The unity build works however

Ah I see. Approving from my side, but let's see what @davidmfinol thinks about merging this as well.

If its been successfully tested in this branch, then I think its fine to merge.

@webbertakken I went ahead and rebuilt action/index.js, if you want to merge.

Thanks!


Cow: Watch cornellelectrical.com.au

Cow requests the watch of the watch_keyword cornellelectrical\.com\.au. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

cornellelectrical\.com\.au has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Some voicing strings still spoke when chrome tab muted

Is it expected that muting the chrome tab would mute all voicing audio? I thought so.
To reproduce:

checkout preferences branch in Ratio and Proportion
mute tab
launch sim with supportsVoicing=true
go to preferences dialog and enable voicing
Click on a couple of elements in the side-tool-bar, they will still speak.

I found a chromium bug report about this: https://bugs.chromium.org/p/chromium/issues/detail?id=814129

That one was closed, here is the one it was merged into: https://bugs.chromium.org/p/chromium/issues/detail?id=812767

@jessegreenberg and I added a comment to that post:
https://bugs.chromium.org/p/chromium/issues/detail?id=814129

Not sure what else to do here on my end, what about you @jessegreenberg?

I briefly looked for a property on the window or browser that notifies when the site is muted, but no such thing exists. I also checked with @jbphet over slack for assistance but he confirmed there probably isn't such a thing.
I added a section to https://github.com/phetsims/qa/blob/master/documentation/accessibility-bugs.md#32-chrome-bugs to describe this.
I don't think there is anything remaining to do here.

This seems to be fixed in Chrome as of Version 96.0.4664.45 (Official Build) (64-bit).


Adjusting cdn link in MediaLibrary

Fixing the function w3tc_attachment_url.
#515
The definition o w3tc_attachment_url (https://github.com/szepeviktor/w3-total-cache-fixed/blob/v0.9.5.x/Cdn_Plugin.php#L776) is wrong.
If idea is to work only in ADMIN, and cdn.admin.media_library=true, the if statement is wrong.

@raphaelquati thanks for your PR! befere marging your PR you should update README.md changleog section with a new row, eg.:
:beetle: Bug Fix | [Adjusting cdn link in MediaLibrary](https://github.com/szepeviktor/w3-total-cache-fixed/pull/516) |

is important because we have a changelog with all PRs over the official version.

Updated.

@raphaelquati Thank you for your contribution.


Add option to SpacyPreprocessor to enable GPU support

Is your feature request related to a problem? Please describe.
I need snorkel.preprocess.nlp.SpacyPreprocessor to perform better. GPU support for spacy is possible, and improves performance, if you install it via something like: pip install spacy[cuda100]. Therefore I want a boolean gpu=False option added to SpacyPreprocessor and if it is called it runs spacy.prefer_gpu() before assignin a spacy.Doc to self._nlp by calling nlp.
Describe the solution you'd like
spacy_processor = SpacyPreprocessor(
    text_field='_Lower_Text',
    doc_field='_Doc',
    memoize=True,
    gpu=True,
)

This calls:
        if gpu:
            spacy.prefer_gpu()
        self._nlp = spacy.load(language, disable=disable or [])

Describe alternatives you've considered
I tried importing this externally and it didn't seem to help performance. I believe it needs to be called within SpacyPreprocessor.
Additional context
Performance approximately doubled for my task preprocessing.

I don't precisely understand what to do about requirements for this. Do we need to put spacy[cudaXXX] in the setup or requirements some place or in the docs?

I am also not sure how to handle testing here. Could this go untested until such time as we have GPU instances available for continuous integration or should I put it in now?

Whoops, I detected a problem. This doesn't work with SparkLFApplier, it has a problem serializing the cupy array. I'll have to have it handle this somehow.

I spent half an hour trying to get the Spark stuff to work with GPU support but I run into a cupy msgpack serialization problem that is above my pay grade. I'm afraid it won't work for the Spark functions. Doing more testing with it now to see if the Spark stuff still behaves ok.

Ok, this holdup was my mistake. This works fine, I had fed gpu=True into the Spark label function. This LGTM again :)

@henryre can we merge this?

@ajratner @paroma @henryre sorry to bug you, but I’m wary of running a fork of Snorkel and wanted to see if this could be merged before the next release?

Added in https://github.com/snorkel-team/snorkel/pull/1523


I can't display the model immediately when I switch to local rendering

Hello all,
When I switch from remote rendering to local rendering, I need to drag my model to see the rendering results. I want to know the problem.
switch to local rendering

drag model

You may have to call reset camera at first then the camera should remain in synch.
But it is most likely a bug.

Thank you for your advice, but it doesn't work. I also think it is a bug.

Same as remote rendering. Just drag with left button. Did you click on the button to “reset the camera “ first?

My idea is not the operation of the interface, but the modification of the code. Clicking on the button to "reset the camera" first can indeed display the model, but I think local rendering can display it like the remote rendering when loading.

If you want that the local rendering show the same thing/position as remote, I’ve already acknowledged the bug which only appears the very first time.

If you are asking how you can extend the current code base so when you click on a button (or at startup), you want a specific camera position, then it’s another story.

Which one is it? 1 or 2?

Did you try with ParaView 5.6? I can't reproduce the issue. We may have fixed it when improved the vtk.js integration.

Actually I was able to reproduce the issue if we load the off-center model while in local rendering. While if you switch from remote rendering to local rendering, then everything is fine as the camera get properly synchronized.
Basically the client should call resetCamera the first data we load. This is automatically done on the server side, but that logic does not exist in our client. Hence the issue with the LocalRendering.
I'll see what I can do... Thanks for reporting the issue!

Release 3.1.10 should fix that


Add html output only function

Delete the commit 1280bd4 because has been already fix in master
Change option name html_output_only to html_output
Line 190 we need to handle pages https://github.com/TDenoncin/se-scraper/pull/1/commits/a309d906d379373bfdb3e25efbda7de2741c8540#diff-3605cd442cfa748a2fc74234dd3498bfR190 like this.html_output[keyword][page_num]
For the main return I propose to change to something like {results: , html_output: } when html_output is on https://github.com/TDenoncin/se-scraper/pull/1/commits/a309d906d379373bfdb3e25efbda7de2741c8540#diff-3605cd442cfa748a2fc74234dd3498bfR70


Flag for non-interactive CLI (Overwrite Y)

Is there anyway to get a flag that forces overwrite? like --force?

The problem with this solution is that it applies to everything.  I'm in the situation where I know I want to unprompted overwrite one file and know it's safe to do so, but I don't want to overwrite all of the other files just to do that!  It would be really nice to have a template attribute to do this with... like if unless_exists was explicitly set to false instead of being undefined, it would silently overwrite.  or if that doesn't seem safe enough, we just add a new always_overwrite attribute.


Start testing framework, with prefix sum

This adds a new testing directory, and starts populating it with prefix sum implementations, both decoupled look-back and tree reduction. The intent is to build out more tests, and more options for configuring and reporting, but for now it's pretty bare-bones.
This will subsume #92; I also plan to get updated versions of the atomic litmus tests in there and have a bunch locally that I'm experimenting with.
Shaders are built for 3 languages, but the code only runs on Vulkan for now. I have gotten the tree reduction working on both Metal and DX12 with some tweaks, though timer queries are not supported on either yet. I'll do some portability improvements as a follow-on (and will use these tests to push that work forward).

Going to merge this now even though it feels a bit incomplete, as I'm doing some of the DX12 portability (#125) work on top of it.


Support for unicode characters

If there are unicode characters in any of the value

@hdost As @mrec stated, once that is resolved it works as expected. Going to close for now,.