chrome extention

when you build the project arose the following problems:

there is no possibility to change the name of the directory _nuxt (_nuxt -> сustom_dir / in extensions are not valid user names of files and directories with an underscore)
using the mode: 'hash', incorrect references are generated, they still generated for mode: 'history'
how to use CopyWebpackPlugin only stage generate?

Hi @wormen

It's now possible with build.publicPath
The mode: 'hash' is not recommend if working with SSR
You should create your generate.js file which import nuxt, use a different configuration for const nuxt = new Nuxt(config) and then call nuxt.generate()

@Atinux With point 2, the question has not been resolved, the problem is still observed

@wormen why using mode: 'hash' for SSR ?

@alexchopin In applications for google chrome, SSRis not used, only statics

Ok I see, only an index.html file is needed when mode: 'hash' is activated.

I did, but after generating static, mode: 'hash' does not work, as described in paragraph 2
work absolute paths to HTML files


capabilities support: instead of using privileged permission, is there any plan for providing more precise capability configurations

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
Our k8s admission control prevents privileged pods from execution, can tetragon only takes CAP_BPF?
Describe the feature you would like
allow we run container or pod like:

docker: remove --privildged
k8s: securityContext:
allowPrivilegeEscalation: false

Describe your proposed solution
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for creating this issue.

Our k8s admission control prevents privileged pods from execution, can tetragon only takes CAP_BPF?

Having Tetragon only use the capabilities it needs definitely makes sense. There are still some things that we go beyond CAP_BPF and we would need to figure out how to do. One of them is access to (the host) /proc for scanning the existing processes.

I' working on the privileges collection.


DOC-332 add proprietary notice to features

Resolves Jira: DOC-332

https://s.armory.io/GGuQPKqY

The title of this Pull Request needs to be changed to match the format:
<type>(<scope>): <subject>

See more details here: https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions
Some common examples are:
feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense

The title of this Pull Request needs to be changed to match the format:
<type>(<scope>): <subject>

See more details here: https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions
Some common examples are:
feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense

The failure is cause of an issue in the Vale GH action: https://github.com/errata-ai/vale-action/issues/33


[Crtvg] Add Extractor

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

CRTVG or Televisión de Galicia, commonly known as A Galega, is a Spanish free-to-air television channel owned and operated by Televisión de Galicia S.A., the television subsidiary of Galician regional-owned public broadcaster Corporación Radio e Televisión de Galicia. Wikipedia
[debug] Loaded 1823 extractors
[Crtvg] Extracting URL: https://www.crtvg.es/tvg/a-carta/os-caimans-do-tea-5839623
[Crtvg] 5839623: Downloading webpage
https://ondemand-crtvg-origin.flumotion.com/videos/MD/2022/10/ac818cb4-6dc9-4377-8acf-20d5b2a6e601.mp4
[Crtvg] 5839623: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] 5839623: Downloading 1 format(s): 3268
[info] Writing video metadata as JSON to: test_Crtvg_5839623.info.json
ok

----------------------------------------------------------------------
Ran 1 test in 2.088s

OK

Fixes #6609
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at abca7ec
Summary
📦🆕🎥

Add a new extractor for crtvg.es videos. Create a new module crtvg.py that defines the CrtvgIE class and import it in _extractors.py.

CrtvgIE class
adds Galician videos
autumn leaves fall

Walkthrough

Add support for downloading videos from crtvg.es (link, link)

Import CrtvgIE class from crtvg.py module in _extractors.py (link)
Define CrtvgIE class in crtvg.py module (link)

update the test

Hm, which part of the test exactly?

Pull, run the test locally and see if it passes

Pull, run the test locally and see if it passes

Passed like a charm, give it a try..


Update README.md

The ros2 branch also does not compile ros distributions.
I removed all the results from ros xenial and bionic.

Addressed by a15df241092620f4d29286472427bff9ce9a032e.


<EMAIL_ADDRESS>is installed on new projets with npm instead of 7.14.

Describe the bug
<EMAIL_ADDRESS>gets installed when using npm. Few days ago it was 7.14 (which contains some specific fixes for a lib I am using).
Did you try recovering your dependencies?
Issues reproducible on brand new project after doing npm install -g npm@latest.
Which terms did you search for in User Guide?
I don't think this is relevant.
Environment
▶ npx create-react-app --info

Environment Info:

  current version of create-react-app: 4.0.3
  running from /home/froyer/.npm/_npx/c67e74de0542c87c/node_modules/create-react-app

  System:
    OS: Linux 5.10 Manjaro Linux
    CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
  Binaries:
    Node: 16.0.0 - /usr/bin/node
    Yarn: 1.22.10 - ~/.node_modules/bin/yarn
    npm: 7.13.0 - ~/.node_modules/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 88.0.1
  npmPackages:
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    react-scripts: 4.0.3 => 4.0.3
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

npx create-react-app my-app; cd my-app
npm install

▶ npm ls @babel/preset-env
<EMAIL_ADDRESS>/home/froyer/my-app
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>deduped

rm -rf node_modules package-lock.json yarn.lock
npm install

▶ npm ls @babel/preset-env
<EMAIL_ADDRESS>/home/froyer/my-app
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>deduped

Expected behavior
For the output of npm ls at step 3 to be the same than step 6, ie, to include babel 7.14.
Actual behavior
Babel 7.12 is installed which contains bugs for optional-chaining, making the project not compile if it contains optional-chaining.
Reproducible demo
As the issue is for a new project, I don't think a reproducible demo is useful. Let me know if you disagree and I'll try to come up with something.

Did spend the mandatory half hour on this issue.

Please note that this issue stills occurs when creating new react projects with npm.

Closing as the issue does not occur with react-scripts 5.0.0


Link to pre/post workshop results in Workshop activity list

I was discussing my struggle with finding the pre/post workshop survey results by searching through my emails for the links with a colleague and was wondering if it would be possible to have that link as a column in the workshop activity table that is part of the your profile page?

Thanks for bringing this up @sstevens2
I think this is addressed in #2016 so I am closing this here.  Please feel free to re-open or create a new issue if there is anything else you want to see.

Sorry I missed the other Issue @maneesha! Thanks for sending me there!


Upgrade gradle & android plugin

I've signed it

Seems like update of build-tools in Travis config is required for this to pass.

This conflicted with another PR but the effect should now be merged.


Make Enoki, Eigen, and FCPW optional

Please note that the diffbase of this PR is https://github.com/UPC-ViRVIG/SdfLib/pull/4 so a clean diff can be viewed once that one is submitted.

I will close the pull request and collect all changes in a single patch.


premake4 required to make premake4

In https://github.com/premake/premake-4.x/blob/master/BUILD.txt, a mere mention of the following:
 If you pulled the sources from BitBucket, you'll need to generate your
 own project files before you can build.

when I pulled it from GitHub...  too bad, we can't find the build subdirectory.
premake4 cannot be built as downloaded into a CentOS 6.5 without intensive out-reach to pull in packages to build this.
A non-starter, no?

You would need to download a source code package, which does include the build/ folder with regenerated project files. You can download a source package from SourceForge.
If you're just getting started with Premake, you should probably start with version 5 though, homepage here.

@egberts no idea which exact platform you're on, but for Windows I do provide code-signed binaries over here (it's a friendly fork of premake4).


Wire Remapper Loop

Might be intended behavior, but when at least two wire remappers have both sides linked to each other, any signals will become "stuck" at the highest value they've been set to.

"Intended" might be a bit strong, "accepted" is more accurate. The same happens with "discrete" remappers (see screenshot), it would be hard and annoying to fix. Discrete remappers would be harder than my "integrated" ones, but even for those it's more work than I'm willing to invest.


Don't require an app restart to see changes to controllers and models in debug/dev mode

Views can be changed when in debug/dev mode without restarting the app. Controllers and models require an app restart due to the way they're precompiled at app start.
Keep in mind that #46 will need to be taken into account if views are reworked as well.

Need to clear controller and route caches in order to mark this as done.

Nice to have: reload config on config file change. This should probably require the entire app to be flushed and reinitialized.


KeepAliveGatt EventHandler

Allows the consumer of this API to provide lambdas to run on either connection or disconnection events.

Unfortunately Android Studio and Kotlinter do not agree on import ordering. I think JetBrains has a fix coming so Android can play nicer with Kotlinter.
Until then, I've opted to have Kotlinter enforce it's import ordering. It's slightly cumbersome but at least makes ordering enforceable by CI. So you'll have to run ./gradlew formatKotlin whenever your CI build fails due to import ordering. Small price to pay for consistency?

@Chris-Corea re-requested review as we had to make substantial changes since you reviewed.


Implemented cups_job_full_username option in Windows port (and more)

I've just submitted the CLA. Apologies it's all one big commit.

Implemented cups_job_full_username option in Windows port
Added job_spooled_is_done option and implemented in Windows port
Renamed old SetJob to SetJobCommand since it only uses commands
Added SetJobUserName which is used to change the username
Corrected error handling for: EnumPrinters, OpenPrinter, ClosePrinter, GetJob, SetJob, StartDoc, EndDoc, StartPage, EndPage, SetGraphicsMode

Notes

The job_spooled_is_done feature is for software (like ours) which pauses the job and takes over the release process. You may want to rename the option.
Without global config, passing new options to depth is a bit painful. It would be easier to pass around a collection.
I have not added boilerplate "err == NO_ERROR" checks everywhere (for "The operation completed successfully" errors). Those Windows bugs are pretty rare.

Ok, I messed this one up sorry!
Will try again tomorrow.


Watch for circular references during HollowObjectMapper#initializeTypeState, fail fast

While working with hollow for the first time, I was trying to generate types for a fairly complex domain model. Running HollowObjectMapper#initializeTypeState(Class) on some of my types would generate StackOverflowErrors that were kind of tricky to diagnose.
It turns out that there is a circular reference within the data model I'm working with, not immediately obvious to see (which isn't supported per http://hollow.how/data-modeling/#circular-references).
I thought it might be helpful for others in similar circumstances to have hollow fail fast and point directly to the class that couldn't be mapped.
Sample Exception message:
java.lang.IllegalStateException: circular reference detected on field private final java.util.List com.netflix.hollow.core.write.objectmapper.DirectCircularReference.children; this type of relationship is not supported

Looking into the test failure, I'm going to try another approach to this.

This is a good idea, thanks.  Can we avoid the thread local variable?  Let us know if you need help understanding or addressing the test failures.


Add analyzer to search in Japanese

Describe your changes :

I changed OpenMetadata to be able to search in Japanese only for description fields of table and column.
Added Japanese analyzer to table_search_index and changed it to map to description fields.

Warning
kuromoji must be installed on Elasticsearch to enable this setting.

Type of change :

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] All new and existing tests passed.

Reviewers

@harshach

Thanks for proposing the changes @megumiie. I believe @harshach is handling them already in https://github.com/open-metadata/OpenMetadata/pull/9163


[BUG]: Showing black screen while playing DRM content on Airplay supported devices

Version
6.1.1
What platforms are you having the problem on?
iOS
System Version
iOS 17
On what device are you experiencing the issue?
Real device
Architecture
Old architecture
What happened?
A bug happened!
Apple TV or Airplay-supported TV are showing a black screen while playing  DRM content on Airplay after some time.
Reproduction
repository link
Reproduction
Steps to reproduce this bug are:
1- Play DRM content it will play on app
2- Start playing on Airplay
3- After some time Airplay supported tv starts showing black screen (Apple TV, MacBook, LG TV, Samsung TV).

@freeboub @YangJonghun can you guys help?

Need more clue.
This can happen for variety of reasons.

I am experiencing the same thing. Airplay doesn't work for me at all with DRM content. It works on device playing the drm content however over airplay it does not. Error is the following:
   { localizedRecoverySuggestion: 'Check your DRM config.',
     code: 4,
     domain: 'RCTVideo',
     localizedDescription: 'Error obtaining license.',
     localizedFailureReason: 'No spc received.' },
  target: 2705 }```

  I have tried with another player like bitmovin and airplay works with that player.

  License policy on drm token allows airplay as well.

const licensePolicy = {
policy_version: 2,
playback_true: {
persistent: true,
license_duration: 86400,
rental_duration: 259200,
playback_duration: 259200,
allowed_track_types: "ALL",
},
security_policy: [
{
track_type: "ALL",
...(widevineLvl1 && {
widevine: {
security_level: 1,
required_hdcp_version: "HDCP_V1",
required_cgms_flags: "COPY_NEVER",
disable_analog_output: false,
},
}),
fairplay: {
hdcp_enforcement: 1,
allow_airplay: true,
allow_av_adapter: true,
},
},
],
};```
Happy to provide whatever information is needed to help solve this issue. @YangJonghun


Allow setting the GNATCOLL_ICONV_OPT environment variable in Makefile

This issue is similar to this one: https://github.com/AdaCore/RecordFlux/issues/1289.
You should test to see if GNATCOLL_ICONV_OPT is set prior to setting it. The issue is here: https://github.com/AdaCore/RecordFlux/blob/e1cf41ea179a282131621e5fa1f163be9e53c5c6/Makefile#L318
Also, unrelated, but I think you need to include the path to gnatcoll in your GPR_PROJECT_PATH here: https://github.com/AdaCore/RecordFlux/blob/main/Makefile#L316. Otherwise, it won't find it. (I assume you happen to have gnatcoll installed already somewhere in your GPR_PROJECT_PATH.

We started using Alire to manage our projects so we don't necessarily have some of the libraries like gnatcoll in the GPR_PROJECT_PATH automatically. The exception to this is that we don't use Alire to install gnat and gprbuild: we install those directly from apt in our Debian development environment (and therefore we use the FSF gnat).
The reason for not using Alire to install the compiler is people on our team use different architectures: I use a Mac M1, others use older X86_64 Intel Mac's, some use Linux laptops, Windows machines, etc. and when we first started using Alire it didn't support different architectures (maybe it does now?).
Everyone develops in a Debian docker container so we have a multi-arch base image with the basic tools installed that works natively on both architectures, and Alire takes over after that to install additional dependencies for each project (e.g., gnatcoll).
We were looking at the source code for RecordFlux to see how easy it would be to add some features we wanted (we'll contribute them back if we end up implementing them!) and ran into this issue when setting up the development environment. We are able to address this, but it seems like if you append the path to the gnatcoll bindings that is brought in via Alire, it might make sense to also append the path to gnatcoll too that is also brought in via Alire.

If you're using Debian, did you try to install libgnatcoll21-dev? IIRC this should work out of the box.

but it seems like if you append the path to the gnatcoll bindings that is brought in via Alire

The gnatcoll bindings referenced in the Makefile are from checked out repositories. If you run make init it will check out both gnatcoll-gmp and gnatcoll-iconv. We can't add a generic path for gnatcoll itself as its location depends on the toolchain used.
make init is also documented in our development guide.

So we are able to get everything working no problem: gnatcoll is available to us, it is just not in the GPR_PROJECT_PATH (it is automatically pulled in when you use alire to pull in the bindings...). We have a step prior where we add it to the path.
My suggestion was to update the Makefile and, similar to the gnatcoll bindings, append the path to gnatcoll that is pulled in via the alire dependencies instead of assuming it is already available on the system. This would make it more reproducible in my opinion. This is just me nitpicking :).

(This line here also brings in gnatcoll: https://github.com/AdaCore/RecordFlux/blob/main/Makefile#L239.)

I'm surprised that gnatcoll is not in the GPR_PROJECT_PATH provided by alire. Which alire version do you use? I just created a new crate and withed both gnatcoll_iconv and gnatcoll_gmp without explicitly adding gnatcoll and when I run alr printenv the GPR_PROJECT_PATH contains gnatcoll:
$ alr with gnatcoll_iconv gnatcoll_gmp
Requested changes:

   ✓ gnatcoll_iconv ^23.0.0 (add)
   ✓ gnatcoll_gmp   ^23.0.0 (add)

Changes to dependency solution:

   +♼ gnat           12.2.1 (new,installed,gnat_native,indirect)
   +  gnatcoll       23.0.0 (new,indirect)
   +  gnatcoll_gmp   23.0.0 (new)
   +  gnatcoll_iconv 23.0.0 (new)
   +  libgmp         6.2.1  (new,indirect)
   +  libgpr         23.0.0 (new,indirect)
   +  xmlada         23.0.0 (new,indirect)

Do you want to proceed?
[Y] Yes  [N] No  (default is Yes) y
ⓘ Deploying libgmp=6.2.1...
ⓘ Deploying xmlada=23.0.0...
...
ⓘ Deploying gnatcoll=23.0.0...
ⓘ Deploying gnatcoll_gmp=23.0.0...
ⓘ Deploying gnatcoll_iconv=23.0.0...
...
$ /tmp/alr/test % alr printenv
export ALIRE="True"
export GNATCOLL_ALIRE_PREFIX="/tmp/alr/test/alire/cache/dependencies/gnatcoll_23.0.0_29478a20"
export GNATCOLL_BUILD_MODE="PROD"
export GNATCOLL_GMP_ALIRE_PREFIX="/tmp/alr/test/alire/cache/dependencies/gnatcoll_gmp_23.0.0_57de4a1a"
export GNATCOLL_ICONV_ALIRE_PREFIX="/tmp/alr/test/alire/cache/dependencies/gnatcoll_iconv_23.0.0_57de4a1a"
export GNATCOLL_ICONV_OPT="-v"
export GNATCOLL_OS="unix"
export GNATCOLL_VERSION="23.0.0"
export GPR_PROJECT_PATH="[...]:/tmp/alr/test\
   :/tmp/alr/test/alire/cache/dependencies/gnatcoll_23.0.0_29478a20\
   :/tmp/alr/test/alire/cache/dependencies/gnatcoll_gmp_23.0.0_57de4a1a/gmp\
   :/tmp/alr/test/alire/cache/dependencies/gnatcoll_iconv_23.0.0_57de4a1a/iconv\
   :/tmp/alr/test/alire/cache/dependencies/libgpr_23.0.0_34e332b9/gpr\
   :[...]
...

I'm running alire version 1.2.2 from January.
Also, at least to my understanding, gnatcoll-bindings does not contain gnatcoll itself. So https://github.com/AdaCore/RecordFlux/blob/main/Makefile#L239 does not bring in gnatcoll, it only adds the repository that includes the bindings for gmp and iconv (and others) but you still need gnatcoll itself.
Can you validate that alr with gnatcoll_iconv gnatcoll_gmp does not provide you with a proper GPR_PROJECT_PATH to gnatcoll? If that is the case that might be a bug in alire.

Hey,
So what you posted in your code snippet is the expected behaviour: alire will pull in transitive dependencies and flatten them in the dependencies folder (hence why you see gnatcoll there when you included gnatcoll_iconv and gnatcoll_gmp).
Alire will also modify the GPR_PROJECT_PATH to include all (transitive) dependencies when you are in an alire project (the presence of an alire.toml file makes that directory tree an alire project). So in your example above, gnatcoll is expected to be in the path when you are within an alire project.
However, alire does not permanently modify the GPR_PROJECT_PATH, so once you exit that directory tree it will no longer be set.
In regards to the issue I raised, I think I misunderstood what the install_gnat target was doing: I assumed that was where you were downloading the various dependencies required to build RecordFlux using alire. On further inspection, it seems like you are actually manually cloning dependencies (e.g., contrib/gnatcoll-bindings:) in addition to bringing them in via alire (e.g., alr -n with aunit gnatcoll_iconv gnatcoll_gmp).
The issue still stands that it assumes gnatcoll is available in the GPR_PROJECT_PATH whereas it makes no assumptions about the other dependencies and thus appends them.
I think you can clean up the dependency management (and therefore setting up the environment including GPR_PROJECT_PATH) using alire. You would save yourself from cloning the repos multiple times for some of the dependencies (e.g., alr -n with aunit gnatcoll_iconv gnatcoll_gmp and contrib/gnatcoll-bindings).
Hopefully this clarifies my issue and sorry for the confusion regarding some of the Makefile targets!

I think there are a few misunderstandings here, I'll try to clear things up a bit.
The Makefile aims to cover different toolchains. In particular these are GNAT Pro, GNAT Community and Alire. Both GNAT Pro and GNAT Community already provide gnatcoll which is the reason it is not included as a separately cloned dependency.
While Alire provides all the dependencies needed we cannot assume it is available in all circumstances so we cannot easily reference Alire dependencies in other make targets. What you can do is running eval $(alr printenv) to set the environment provided by Alire persistently. The install_gnat target is only meant to be used with Alire toolchains. If you use either GNAT Pro or GNAT Community you don't need to run that target. There is also printenv_gnat which is basically a wrapper around alr printenv so you could also run eval $(make printenv_gnat).

Ah ok - thanks! We will use the eval $(alr printenv) method.


Fix tuple composition

I am not quite sure why it fails, but the typechecking with nested tuples is unfinished. I created the file examples/notWorking/NestedTupleError in the remove-Position branch with some examples of how they fail.

I think I fixed this on this commit


Errors in large numbers of files (for ex. 5k) results in significant editor hangs

I don't know what the expectations are here, but I had some reports of VS Code hanging (not the extension host, but the whole editor locking up). For the one I was able to look into, it seemed to be caused by large numbers of files with errors. I'm able to repro with this extension code, which reports errors in 5,000 files (at 1ms intervals - aiming to somewhat simulate the initial analysis when opening a project):
import * as vs from 'vscode';

export function activate(context: vs.ExtensionContext) {
	const diagnostics = vs.languages.createDiagnosticCollection("foo");
	context.subscriptions.push(diagnostics);

	// Simulate finding errors in 5000 files during initial analysis.
	// Spread them out to 1-per-ms after an initial 100ms.
	for (var i = 0; i < 5000; i++) {
		let j = i;
		setTimeout(() => sendDiagnostics(diagnostics, j), 10000 + i);
	}
}

async function sendDiagnostics(diagnostics: vs.DiagnosticCollection, i: number): Promise<void> {
	const errors = Array.from({ length: 1 }, () =>
		new vs.Diagnostic(
			new vs.Range(new vs.Position(0, 0), new vs.Position(0, 0)),
			`Error ${i}`,
			vs.DiagnosticSeverity.Error,
		)
	);
	diagnostics.set(vs.Uri.file(`/tmp/test/file/${i}.foo`), errors);
}

export function deactivate() { }

A CPU profile suggests that updateBadge is being called a lot and is taking ~300ms per call because of some sorting (which is probably unnecessary since it only uses the count?):

I don't know if 5,000 files with errors is something you think is reasonable, but if you're looking for places you might be able to optimise, this might be one :-)

@sandy081 looks like get resourceMarkers always sorts even though the count is only needed. Also, you should consider looking into using IMarkerService#getStatistics which is incrementally updated

Good catch @DanTup

Great, thanks for the quick turnaround! I'll do some testing with insiders tomorrow and see if I can get the original users to verify it too.

We did some testing in Insiders, and Code remains completely responsive (both in my repro and for the original issue reported to me). It's made a huge difference - thanks!

🐎

That racing horse looks much faster on GitHub than it did in Gmail! 😄

haha

I'm not sure if it's related, or how I got here - but I just noticed this in Insiders:

Badge says 18, but there aren't any errors (and as far as I can tell, no filters).

Yeah it is related to the fix I did. I should not consider unknown markers.


[WIP] Fix custom HystrixConcurrencyStrategy/CommandExecutionHook doesn't wo…

…rk when using hystrix plugin

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues
#1892

Bug fix

Bug description.

How to fix?

WIP before I try to do the integration test. Any suggestion will be welcomed.

If we called reset, we need to restore these settings. Otherwise, lost them.

Sorry for my mistake. just ignore this. this PR is good to me

Ok. Got it. Then we need run automatically integration tests again.

@wu-sheng @acurtain please take a look at the unit-tests.


[Bug]: Dialog flickers before actual showing animation

What happened?
Project is a Blazor Server.
When opening a dialog with basic settings from mudex.org, dialog first shows with zoom transition, disappears and then shows again with actual configured animation.
Code looks as follows:
public DialogOptionsEx Options { get; set; } = new()
    {
        MaximizeButton = true,
        CloseButton = true,
        FullHeight = true,
        CloseOnEscapeKey = true,
        MaxWidth = MaxWidth.Medium,
        FullWidth = true,
        DragMode = MudDialogDragMode.Simple,
        Animations = new[] { AnimationType.SlideIn },
        Position = DialogPosition.CenterRight,
        DisableSizeMarginY = true,
        DisablePositionMargin = true
    };

public async Task OpenMudExDialog()
{
    await Task.Delay(1000);
    IDialogReference dlgReference = await DialogService.ShowEx<DlgYesNoPrompt>("Simple Dialog", dialog => { dialog.ContentText = "Hello from dialog sample page"; }, Options);
}

Expected Behavior
Dialog should not be shown using the MudBlazor standard animation before getting shown correctly
Screenshots
No response
What application type are you referring to?
ServerRendered
Custom Application Type
No response
MudBlazor.Extension Version
1.7.68-prev-2309182049-stream-and-blob
MudBlazor Version
6.10.0
What browser are you using?
Chrome
Sample Solution
No response
Pull Request
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Just add the class mud-ex-dialog-initial on your dialog
<MudDialog Class="mud-ex-dialog-initial">
   <TitleContent>
  ....
 ....
</MudDialog>

Well, reading the docs properly would have helped! Sorry and Thanks!

The Class helps, but behaviour is the same as described always the first time a Dialog is opened

Can you try to load styles manually
<link id="mudex-styles" href="_content/MudBlazor.Extensions/mudBlazorExtensions.min.css" rel="stylesheet">
To then prevent extra loading you should disable automatic css loading in service configuration
builder.Services.AddMudServicesWithExtensions(c => c.WithoutAutomaticCssLoading());

That solves it! Thanks!


Set up CI

Once we have figured out the local build process, we need to convert this to CI. As part of our org plan we get some free Github actions minutes per month - might be worth looking into.

I think I've got some basics going here, at least the build! No tests yet really, right?
https://github.com/gdryke/focus-launcher-android/runs/2083445901?check_suite_focus=true

Yes that's right, I haven't seen any tests so far. Build works fine for me locally too, will take a look at your CI yml, seems fine apart from the gradle step so hopefully it's something small 🤔

I propose new scheme for releases. There is three num version X.Y.Z:

X - major releases for some significant changes
Y - one or few feature release with bugfixes.
Z - bugfix or hotfix.

There is different ways of branching. But I propose the following.
Use three kinds of branches:

master branch - here we collect feature PRs and bugfixes for next release
hotfix branch - is used when it's required to fix and publish something without release
feature/bugfix branch - it used for every feature and bugfix. could be nested

At start of each release new version is set up in gradle build script and with PR (or without) master change it's version. In general it will looks like 1.0.10 -> 1.1.0.
All following PR's with new features and bugfixes should be targeted to master. When all required PR's merget to master we starts stabilization of master - testing and bugfixing.
When master is stabilized somebody marks last commit in master with tag release_X.Y.Z and builds artifact for Google Play.
When some critical bugs leaked to user we could make hotfix. Create hotfix branch from release tag of active release.  Make required fixes. Test them. Publish hotfix to Google play. And don't forget to merge hotfix changes to master.


Rebuild iOS wallet

Due to https://github.com/BeamMW/beam/issues/554 Fix
We need this fix in Beta candidate and current version
QA will need to rerun regression on Beta candidate again

checked


Fix missing tsp for codeblock in suppress warning

Found out this wasn't highlighted

No changes needing a change description found.

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Example of how to use YARD database?

If I want to use YARD to generate stubs from what its database - how do one go about doing that?
Templates are the thing for this? Looking at the docs I'm a little confused at how one would approach templates from scratch. What part of the folder structure described here required? http://www.rubydoc.info/gems/yard/file/docs/Templates.md#Creating_a_Template

You can access the registry programmatically to read objects:
http://www.rubydoc.info/gems/yard/YARD/Registry
See the Architecture Overview to understand how the code objects and registry are related. You do not need to use YARD's templating layer to generate code. You can, but you don't have to.

I think I got something working - using templates. When I looked at the text format template code instead of html it was a bit easier. Atm I have a simple script in myplugin/default/fulldoc/text/setup.rb. That seems to be all I need.
I was thinking the script to generate subs might be nice to wrap up into a gem. I guess using the registry directly vs template is no different in that context? Using the registry might be better - in avoiding the template system all together...

Using the registry directly will also run faster. YARD's templating system is the slowest part because it's build to be hyper-extensible for sub-template modifications, template replacements, custom files, etc.
If your use case is pre-defined and does not involve any user-driven behavior overriding, templates are probably overkill.
Both can be used to generate CLI tools as a gem.

So if I understand this correctly, Registry.load let me initiate the same parsing yardoc do? But I need to apply filtering myself - if I want to filter out any tags?

So if I understand this correctly, Registry.load let me initiate the same parsing yardoc do?

Registry.load does not parse code, it is just the database. See Yardoc#run for what yardoc does. The load call will load from disk, assuming the database exists. If you haven't yet parsed, you should use YARD.parse, or yard -n / YARD::CLI::Yardoc.run('-n').

But I need to apply filtering myself - if I want to filter out any tags?

Yes. If you're relying heavily on filters, that is definitely a benefit of using the template layer.

Thank you very much for all the feedback. I got something to play around with. Will see what I end up with.
Really appreciate it.

It appear that Registry.load will take care of parsing for you.
require 'yard'

project_path = File.expand_path(File.join(__dir__, '..', 'SUbD'))
pattern = File.join(project_path, 'Ruby', '**/*.rb')
files = Dir.glob(pattern).to_a

puts "#{files.size} files"

YARD::Registry.load(files)

puts YARD::Registry.all.count

That yielded:
178 files
1294

Yes, you can use Registry.load to parse, but you probably don't want to do this (it requires manually specifying the files which avoids using your .yardopts).

Gotcha. I'll keep playing around. I might end up using template in order to ensure parsing match yardoc. But I'm really enjoying tinkering with Registry directly here now. So much faster. I get ideas for more analysis tools. :D

Great! Can this be marked as closed?

Yes, I'm rolling! :D


Identical Helm named template across different charts causes wrong controller RBAC permissions

Describe the bug
A recent code-generator change moved RBAC permissions for the controller into _helpers.tpl with a static constant Helm named template controller-role-rules - https://github.com/aws-controllers-k8s/code-generator/pull/495.
When deploying multiple controller as Helm subcharts, the controller-role-rules named templates conflict and only the last one loaded will be used. This results in all but one of the controllers having the wrong RBAC permissions and failing.
Per the Helm chart template guide:

An important detail to keep in mind when naming templates: template names are global. If you declare two templates with the same name, whichever one is loaded last will be the one used. Because templates in subcharts are compiled together with top-level templates, you should be careful to name your templates with chart-specific names.

A better approach would be to include the controller name in the _helpers.tpl, for example iam.controller-role-rules for the IAM controller.
Steps to reproduce
Deploy two or more recent Helm charts as subcharts in a single Helm release:
Chart.yaml
apiVersion: v2
name: k8s-ack-controllers
description: Controllers for creating AWS resources in Kubernetes
version: 1.0.0
dependencies:
  - name: dynamodb-chart
    version: "1.2.7"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: ec2-chart
    version: "1.2.2"
    repository: oci://public.ecr.aws/aws-controllers-k8s

Check the permissions on the controller ClusterRoles.
Expected outcome
ClusterRoles and other resources to not conflict when deploying more than one controller as subcharts.
Environment

Kubernetes version: 1.27
Using EKS (yes/no), if so version?  Yes, 1.27
AWS service targeted (S3, RDS, etc.): Multiple, observed with DynamoDB, EC2, EventBridge, IAM, KMS, S3, SNS, SQS

We've been able to workaround this issue for now by using Helm's post rendering and kustomize to restore the ClusterRoles to the correct permissions.

@nampnguyen are you using ack-chart ? or this is also happening with single helm chart installations?

@a-hilaly We are not using ack-chart, but have our own chart that essentially does the same thing. The only difference is that we aren't aliasing our subcharts, so if others aren't seeing the same issue with ack-chart, then aliasing may be another workaround. Our full chart.yaml is below:
apiVersion: v2
name: k8s-ack-controllers
description: Controllers for creating AWS resources in Kubernetes
version: 1.0.0
dependencies:
  - name: dynamodb-chart
    version: "1.2.7"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: ec2-chart
    version: "1.2.2"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: eventbridge-chart
    version: "1.0.7"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: iam-chart
    version: "1.3.3"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: kms-chart
    version: "1.0.9"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: memorydb-chart # Not affected since RBAC not in _helpers.tpl
    version: "1.0.2"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: s3-chart
    version: "1.0.8"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: sns-chart
    version: "1.0.7"
    repository: oci://public.ecr.aws/aws-controllers-k8s
  - name: sqs-chart
    version: "1.0.8"
    repository: oci://public.ecr.aws/aws-controllers-k8s

I would expect a single subchart installation to not exhibit the issue since this is specifically a conflict between multiple subcharts.

@nampnguyen i'm shipping a fix today. QQ: does this also impact the other values declared in _helpers ? like the watch-namespace for example https://github.com/aws-controllers-k8s/s3-controller/blob/main/helm/templates/_helpers.tpl#L34-L38

@a-hilaly I would expect it to - we just don't use those features so it didn't come up for us. I think it would be a good idea to add a chart-specific prefix to all named templates to align with Helm recommendations.

@nampnguyen I agree, all the variables needs to be prefixed here, thanks for bringing that up! I opened a PR to start prefixing all the helm "templates" with ack-$SERVICE-controller - you can find a sample of the generated output here https://github.com/a-hilaly/ack-eks-controller/commit/acc3b212d6756fa16bfba38fd86116e3b089e395.

@nampnguyen let me know if this aligns well with what you were thinking and if it will resolve your issue. Planning on shipping it with the Go 1.22/new runtime (Tomorrow/Tuesday)

@nampnguyen I agree, all the variables needs to be prefixed here, thanks for bringing that up! I opened a PR to start prefixing all the helm "templates" with ack-$SERVICE-controller - you can find a sample of the generated output here a-hilaly/ack-eks-controller@acc3b21.

Yes that aligns with what I would expect. Thank you for addressing quickly.

We just merged the PR - we'll start patching all the controllers very soon

@nampnguyen all the controllers have patched except for memorydb and elasticache - the service teams for those will follow up on it.
/close


Link to page broken: Permissions to create Data Collection Rule objects in the workspace.

PEr subject line

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4722599e-952c-f9f1-4e00-1dbaadd6dccc
Version Independent ID: e7654b0b-b5d8-154f-b994-8af5da5d578c
Content: Tutorial - Add ingestion-time transformation to Azure Monitor Logs using Azure portal - Azure Monitor
Content Source: articles/azure-monitor/logs/tutorial-ingestion-time-transformations.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @guywi-ms
Microsoft Alias: guywild

@iwafula025 Thanks for your comment! We will review and provide an update as appropriate.

@iwafula025 I have verified and updated the link as required. The update should go live soon i.e., in less than 24 hours. Thanks again!


Implement Joins "ON" condition for equal-like clauses & "ORDER BY" relation table columns

Describe the feature

According to official GORM documentation about Preloading, Joins Preloading shows Joins statement with conditions. This feature is useful for One-to-one relation which will be better to use join statement rather than sub querying as Preload function did.
Motivation

Consider we have 2 model with one-to-one relation with this scheme:
entity News {
    ID: bigint <<PK, AI>>
    --
    ...
    categoryID: smalli
    ...
}

entity NewsCategory {
    ID: smallint <<PK, AI>>
    --
    ...
}

News "categoryID"||--||"ID" NewsCategory

We Find() News with Preloading NewsCategory. Preload function basically will execute two queries i.e. it will find the News then find NewsCategory where ID is all possible values of News.CategoryID with the conditions. Below is log of those queries:
INFO[2022-03-14T21:07:46+07:00]                                               elapsed=2.578791ms rows=2 service=DB sql="SELECT * FROM `news_category` WHERE `news_category`.`id` IN (1,2,3) AND `news_category`.`status_id` = 2"
INFO[2022-03-14T21:07:46+07:00]                                               elapsed=16.244958ms rows=10 service=DB sql="/* bitbucket.org/rctiplus/roov-repo/internal/repos/news/impl.(*reader).FindMany-fm */ SELECT * FROM `news` WHERE `news`.`title` LIKE '%A%' ORDER BY `news`.`sort` DESC LIMIT 10"

Based on this case, then we consider to Use Joins rather than Preload. But currently Joins doesn't support conditions of Relation tables. Below is log with Joins:
INFO[2022-03-14T21:11:56+07:00]                                               elapsed=10.325209ms rows=10 service=DB sql="/* bitbucket.org/rctiplus/roov-repo/internal/repos/news/impl.(*reader).FindMany-fm */ SELECT `news`.`id`,`news`.`slug`,`news`.`title`,`news`.`sort`,`news`.`category_id`,`news`.`content`,`news`.`banner_url`,`news`.`image_url`,`news`.`video_url`,`news`.`embed_url`,`news`.`status_id`,`news`.`metadata`,`news`.`created_at`,`news`.`updated_at`,`news`.`modified_by`,`news`.`version`,`NewsCategory`.`id` AS `NewsCategory__id`,`NewsCategory`.`slug` AS `NewsCategory__slug`,`NewsCategory`.`name` AS `NewsCategory__name`,`NewsCategory`.`image_url` AS `NewsCategory__image_url`,`NewsCategory`.`status_id` AS `NewsCategory__status_id`,`NewsCategory`.`created_at` AS `NewsCategory__created_at`,`NewsCategory`.`updated_at` AS `NewsCategory__updated_at`,`NewsCategory`.`modified_by` AS `NewsCategory__modified_by`,`NewsCategory`.`version` AS `NewsCategory__version` FROM `news` LEFT JOIN `news_category` `NewsCategory` ON `news`.`category_id` = `NewsCategory`.`id` WHERE `news`.`title` LIKE '%A%' ORDER BY `news`.`sort` DESC LIMIT 10"

By considering of this usage, I implement Joins function to support ON condition and ORDER BY relation table columns.

Actually, Join may suit your needs
u := query.Query.User
p := query.Query.Player

u.WithContext(ctx).Join(p, p.ID.EqCol(u.ID), p.Age.Gt(19), u.CreatedAt.Gt(time.Now())).

Have you tried querying in this way?

@riverchu yes, i've tried such that way, but the result doesn't seems as I expected as using Joins. Let we assume Player belongs to User . Hence the generated User & Player model will be like this:
type User struct {
    ID int32
    ...
    ...
    ...
}

type Player struct {
    ID int32
    ...
    ...
    ...
    User User
}

Then we find First match
u := query.Query.User
p := query.Query.Player

res := p.WithContext(ctx).Join(u, u.ID.EqCol(p.ID), u.CreatedAt.Gt(time.Now())).Where(p.Age.Gt(19)).First()

Actual res:
{
    ....Player columns
    User: nil
}

Expected res:
{
    ....Player columns
    User: {
        ...User columns
    }
}


Docs: update coverage section now that the addon supports Vite

Codecov Report
Base: 77.24% // Head: 77.24% // No change to project coverage :thumbsup:

Coverage data is based on head (12fcb67) compared to base (5735775).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #205   +/-   ##
=======================================
  Coverage   77.24%   77.24%
=======================================
  Files          13       13
  Lines         189      189
  Branches       41       41
=======================================
  Hits          146      146
  Misses         43       43

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create impressive.yml

http://impressive.sourceforge.net/

Thanks for submitting this. However, you need to submit the URL to an AppImage as outlined in the README. thanks.

I'm not a maintainer for Impressive, I just created an AppImage recipe that takes their latest release and bundles Python 2.7 in.
If this is required for AppImage recipes too, I'll try to upload it as a release to a github repo.


support Fine-tunes ?

support Fine-tunes ?

The fine-tuning feature is coming soon.

May I ask, approximately when?


Use function both as API and click function?

I am trying to reduce boilerplate code and it was my idea to just decorate an existing function with click decorators to make it available via click. It's unclear to me from the documentation if this use case is supported. I also search the issues for the below error message and couldn't find anything related.
When I decorate a function with click, I am not able to use it as a function within Python:
Here's the function code:
@click.command()
@click.argument('datestr')
def nasa_date_to_iso(datestr):
    """Convert the day-number based NASA format to ISO.

    Parameters
    ----------
    datestr : str
        Date string in the form Y-j

    Returns
    -------
    Datestring in ISO standard yyyy-mm-ddTHH:MM:SS.MMMMMM
    """
    date = dt.datetime.strptime(datestr, nasa_date_format)
    click.echo(date.isoformat())
    return date.isoformat()

Simple enough, right?
I install it via setup.py like so:
    entry_points={
        "console_scripts": [
            'nasa_date_to_iso = planetpy.utils:nasa_date_to_iso',
        ]
    },

but when I call it within ipython I get this:
In [1]: from planetpy.utils import nasa_date_to_iso

In [2]: nasa_date_to_iso('2017-090')
Usage: ipython [OPTIONS] DATESTR

Error: Got unexpected extra arguments (0 1 7 - 0 9 0)
An exception has occurred, use %tb to see the full traceback.

SystemExit: 2

/Users/klay6683/miniconda3/envs/stable/lib/python3.6/site-packages/IPython/core/interactiveshell.py:2971: UserWarning: To exit: use 'exit', 'quit', or Ctrl-D.
  warn("To exit: use 'exit', 'quit', or Ctrl-D.", stacklevel=1)

So, is it not possible to have the same function both as a click-cli function and an python-internal API?
System: Py3.6 via conda on macOS 10.12.6, click version 6.7

It's no longer a plain function, it's a command. You can run a command by calling it, which invokes its main method. Pass a list of args for the command to parse, and if you don't want it to exit, pass standalone_mode=False.
# will invoke Click pipeline
nasa_date_to_iso(['2017-090'], standalone_mode=False)
# equivalent
nasa_date_to_iso.main(['2017-090'], standalone_mode=False)

Assuming you know the given command is a direct wrapper for a function you wrote (and not a group or other type of command), you can get at the function with command.callback. However, calling it will just call the function, it won't invoke any of the Click pipeline for validation, callbacks, etc.
# won't invoke Click pipeline
nasa_date_to_iso.callback('2017-090')

Hm, that's of course not optimal, because now I have to decide between adding a boilerplate function with a different name just for click or change all my Python-internal API calls to include the callback method. Both not ideal. :/

def nasa_date_to_iso(value):
    ...

@click.command('nasa_date_to_iso')
def nasa_date_to_iso_command(value):
    click.echo(nasa_date_to_iso(value))

This would be pretty easy to write a decorator for to automate.

Thank you, that looks like the smallest extra code possible. I was just hoping that that wouldn't be necessary. Thanks anyway!

I would still call this a bad experience as a user. Why do we have to write the boilerplate? You have 5 args, you need to duplicate 5 args. If you go kwargs then you lose the signature.

A command is no longer a regular function. It may assume all sorts of other behaviors now, such as argument validation, and the availability of the Click. Extracting a behavior into a common function that's used in multiple situations is a common and perfectly acceptable refactor.


./configure; make; sudo make install should work as expected

I believe that this project should provide a standard interface from its Makefile.  This change changes the default command to make build instead of make help.  It also makes a blank configure script.

I'm not sure why the blank configure script is necessary but I agree with you about the default setting. Please let me know if you would like to discuss the configure script some more. Although I think it won't matter when we implement CMakeLists.


Do not remove outline on focus

Removing outline breaks applications for people who use keyboard only for
navigation (people with motor skill impairments for example)
This change needs to be clearly signaled in the release it's a part of, since it will probably be unexpected to see an outline appear on upgrading the library in an app.

[closes #172]

:+1:

Is there a way that we can make this look good while keeping the accessibility benefits?

@kylefiedler That would be ideal (I also think the default outline styling is terrible), but I believe that making this look “good” requires and means different things depending on the project.
So I’m a :+1: to this change with the mindset that this will help us to not forget about outline styles and encourage the author to tweak it to fit the needs and design for their specific project.

@tysongach I'm guessing that this is something that won't get changed as often as it needs to. I also imagine that a safer default will encourage others to change it rather than just remove it all together as we have done here.
What about specifying the outline style? I'm thinking:
outline: 1px solid $action-color;

@kylefiedler I was playing around with it last night a little and came up with something very similar:
&:focus {
  outline: 2px solid tint($action-color, 50%);
  outline-offset: 2px;
}

Will need to tweak and specify for inputs that aren’t text (we already have outline styling on those) and for buttons, still.

@tysongach :+1: I like that direction

It’s worth noting that outline-offset is not standardized yet, so not all browsers will pick up on that. But it’s just a small refinement…
I’ll continue working out the details to make sure it’s a nice look-and-feel for all elements and post some screenshots.

I'd look to go ahead and merge. If there are visual adjustments to be made, those can be addressed after we unbreak accessibility.
Good to merge

:tada:


Support 'passive' option on event listeners

Describe the bug
Most DOM events are not passive by default, but some are ( wheel, scroll, ..) .
see https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#passive
And it is not consistent among major Browsers.
Should Solids JSX support explicit passive options for event listeners ?
See how React addressed this issue: https://github.com/facebook/react/issues/6436 and the resolution:  https://github.com/facebook/react/pull/19654
Steps to Reproduce the Bug or Issue
see example on SolidJS Playground and below:
import { render } from "solid-js/web";
import { onMount } from "solid-js";

function Counter() {
  const wheel = (e:MouseEvent) => {
    e.preventDefault() // only works on not passive events
    e.stopPropagation()
    console.log("wheel stopped?")
  }

  let div ;
  onMount(() => div.addEventListener("wheel", wheel, {passive:false}) ) // most events are not passive by default but "wheel" is in Chrome

  return (
    <>

 In Chrome this gray div is the only div that prevents scrolling

    </>
  );
}

render(() => <Counter />, document.getElementById("app")!);

Expected behavior
Like on:* and oncapture:*
There could be a JSX syntax to specify the passive option for events. Maybe onpassive:*  and onnotpassive: * or onWheelNotPassive and onScrollNotPassive

Great suggestion. How are other frameworks handling it. Love to see some inspiration for this feature.

+1

This is very important. Otherwise, do we have to use addEventListener temporarily?

@chaosprint yes, currently have to use el.addEventListener("wheel", handler, {passive:false}) so that preventDefault() works in the handler.

Opened this PR to solve this capture/once/passive/signal
https://github.com/ryansolid/dom-expressions/pull/341

This is merged in commit: https://github.com/solidjs/solid/commit/2a3a1980643268b9b285976e58070ce646e09247
It will be in Solid 1.9


Change in Content for Invoice ID

[Enter feedback here]
Hello Bill,
I am from the Azure Billing team and have a feedback or a chage request for content on this page. I had a customer requesting for unique ID for department.
Invoice Section ID is not applicable for EA Customers as there is no concept of Department ID or a unique identified for Department. Invoice section ID would only be applicable for MCA and not EA.
Below is the snip of the content which is misleading customers.

Here's a snip from the Usage report and shows to be blank

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96771ba5-ef91-ed15-33a3-ff5e5b9e753f
Version Independent ID: de9baa15-55e1-4cb8-32d0-6583a8b5d689
Content: Understand your detailed usage and charges
Content Source: articles/cost-management-billing/understand/understand-usage.md
Service: cost-management-billing
Sub-service: billing
GitHub Login: @bandersmsft
Microsoft Alias: banders

@sandyv84 Thank you for sharing your valuable feedback. We will review the content wit doc owner and update as appropriate.
@bandersmsft Could you please review the PR - https://github.com/MicrosoftDocs/azure-docs-pr/pull/208237 and approve the changes?

@sandyv84 Thanks. I've updated the article as you requested.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/208275
#please-close

@bandersmsft Could you please review the PR - MicrosoftDocs/azure-docs-pr#208237 and approve the changes?

@SadiqhAhmed-MSFT Please close PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/208237. The source article contains HTML which is no longer allowed in the repo. I have https://github.com/MicrosoftDocs/azure-docs-pr/pull/208275 to remove the HTML and address this issue. Thanks.


fix(cli): Don't override config by setting cli options to undefined

This has been introduced by #2180. The change there will always set argv.dir, no matter if it's been there before or not. When it's not there, it will set it to undefined, which then will lead to vitest using the root as fallback instead of the config set in the config file, since CLI options override config options.
In our case, this config was essentially ignored since 0.24.4.
import { defineConfig } from "vite"

export default defineConfig({
  root: "app/javascript",
  test: {
    dir: "spec/javascript"
  }
})

with the only workaround of providing dir via CLI option.
Btw. I'd love to add tests, but I haven't found existing tests for this and didn't have too much time on my hands. Happy to take pointers and add them.

Reproduction to test: https://stackblitz.com/edit/node-lrwnma?file=vite.config.js
Or as repo: https://github.com/rmehner/vitest-pr-2330
Thanks for looking into this :)


Creating SVG sprites without Webpack loader

As is
shopify-quick-theme relies on the SVG sprite loader, which requires the use of webpack to create the sprites.
To be
Replace SVG sprite loader to svg-sprite.

Deleted svg-sprite feature.


Changelog, hand-curated categorized bug-fixes / improvements, etc. based on milestones, PRs, issues.

Related:
https://github.com/edrlab/readium-desktop/issues/93

My personal experience of "standard-version" is poor (unreadable / non-useful changelogs), but this is probably due to how GitHub metadata (commit messages, PRs, issues, etc.) is created in the first place:
https://github.com/conventional-changelog/standard-version

I personally like this comprehensive CHANGELOG style:
https://github.com/material-components/material-components-web/blob/master/CHANGELOG.md

Perhaps this project should follow the "conventional commits" recommendation:
https://conventionalcommits.org
...and use the "standard version" tools to generate clean changelogs / release notes:
https://github.com/conventional-changelog/standard-version
Note that Electron 2.0 has made the switch to semver (finally) and conventional changelogs:
https://github.com/electron/electron/blob/master/docs/tutorial/electron-versioning.md


Export data from view into excel did not retain the spacing or margin in front of each data cell.

1⃣ Is the bug applicable and reproducible to the latest version of the package and hasn't it been reported before? (Currently 3.1.x) - Yes
2⃣ What version of the package, Laravel, and PHP do you use? Please provide the FULL version number.

Laravel Excel version: 3.1.30
Laravel version: v8.17.0
PHP version: PHP 7.3.7

3⃣ Describe your issue. Please be short, but concise.
The space added in front of each data cell is not retained when we export into an excel.
In this sample, I tried to retain the space which I added in front of the cell value. The HTML view will retain the space but when I export it into excel then it converts it into a single space.
InvoiceExport.php
namespace App\Exports;

use App\Invoice;
use Illuminate\Contracts\View\View;
use Maatwebsite\Excel\Concerns\FromView;

class InvoicesExport implements FromView
{
    public function view(): View
    {
        return view('exports.invoices', [
            'invoices' => Invoice::all()
        ]);
    }
}

invoices.blade.php

        Number
        Amount

    @foreach($invoices as $invoice)

                {{ $invoice->number }}
               {{ $invoice->amount }}

    @endforeach

Stackoverflow link:- https://stackoverflow.com/questions/68077755
4⃣ How can the issue be reproduced? Please provide easy-to-reproduce steps (repository, simple code example, failing unit test).

Create a new InvoiceExport.php file with the code mention in step 3.
Add space in the blade.php file in front of each data cell. by using   or another way.
Download the excel file

5⃣ What should be the expected behavior?
It should retain the space, margin, or padding given to the data cell.
6⃣ Have you filled in the entire issue template? If not, your issue will be closed. Thanks for using the package! 🙌

I have a problem with names in general.
"Firstname Lastname" returns: "FirstnameLastname"

We use PhpSpreadsheet to load the html to spreadsheet, you'll have to report it there.


Getting path of Windows file URL adds a leading backslash before drive

import Foundation

let url = URL(string: "file:///c%3A/Users/alex")!
print(url.path)

Outputs /c:/Users/alex. As far as I can tell, the output should be c:/Users/alex (this is also what swift-corelibs-foundation produced).

I believe this is the same issue that was reported in #857, can you confirm?

Yes, that appears to be the same issue. Closing as a duplicate.


Safe connector stucks reconnecting state if phantom Wallet installed as extension

Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Describe the bug
i'm try to connect Safe connector however it's stucks reconnecting state while Phantom Wallet installed as browser extension. when we disable Phantom Wallet, it will be autoconnect without an issues.
Link to Minimal Reproducible Example
https://app.safe.global/apps/open?safe=base:0x03e030BE8Ad2A37aE849D2710d3d567F7005d2FA&appUrl=https://9114b809.new-wagmi-wtopom.pages.dev/
Steps To Reproduce
open this safe app URL while Phantom Wallet installed, you'll noticed the address that you connected however the connection state is hanging reconnecting

source
https://github.com/yulafezmesi/new-wagmi-wtopom
What Wagmi package(s) are you using?
wagmi
Wagmi Package(s) Version(s)
2.12.8
Viem Version
2.21.1
TypeScript Version
5.2.2
Anything else?

i've found the issue and fixed here, not sure perfect workaround please let me know if you have any recommendation.
Thanks.


Cache domains in cachedBeaconState.ts

Motivation
We don't want to compute domain all the time for the same values, should cache it somewhere.
Description
Cache domains in cacheBeaconState.ts
Closes #2505

After talking to @dapplion further about this, it might be nice to attach this cache/method to the IBeaconConfig so the domain logic can be shared across the beacon node and validator (the validator doesn't have a CachedBeaconState available).
The IBeaconConfig could load in a genesisValidatorsRoot, then be able to handle fork digests, domains, etc (anything combining the fork schedule and genesisValidatorsRoot information).

Also I have not data to prove that this is an actual performance issue, it was just an idea that would be nice to de-duplicate work but maybe it has a negligible impact.
You can browse the issues with the performance label which are proven to have a serious impact on the node performance https://github.com/ChainSafe/lodestar/labels/Performance

We should revisit this after merging https://github.com/ChainSafe/lodestar/pull/2585 seeing it has a noticeable performance improvement

waiting for #2585


Added C:\ to the path so that busybox works from CMD without a leading /

Closing for now. Let's try the suggestion in email first.


fix: Require only Kinesis from AWS SDK

Description of change
It is unnecessary to require the entire AWS SDK for the library to
function. It adds unnecessary weight to the module, regardless
whether the dependant project uses a bundler or not
Checklist

[x] TypeScript definitions are up-to-date

Thanks @rockaBe yes I thought about it too, but I wanted to avoid costly refactors for now.
Agreed that migrating to 3.x should definitely be on the roadmap 👍

@attila absolutely agreed and totally supported 👍

@jasonneylon Thanks for the reminder. I ran npm version patch for this in https://github.com/babbel/miza-kinesis/pull/216/commits/02643e037f82b77abfd0d90cf7dca7cba9cf4f83 but bear in mind that I cannot include a tag in my PR so tagging needs to be done by someone who has write access to this repo 👍

Is anyone planning to merge this anytime soon? We'd love to have a release from this changeset 👍

Merged. Thanks @attila!


added azizp128

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

Hey, thanks for contributing, kindly just add your name & GitHub link & please don't modify other lines.

Sorry, but I didn't modify other lines. I only copied and pasted the previous line.

Do I have to make a new pull request?

Do I have to make a new pull request?

Hi, thanks for contributing 😇
You just need to undo the changes made & by just adding your details, follow the same steps & push those changes here.
It will bring the changes here itself in the existing PR by default if you are making changes in the already created new branch ( which you created for opening this PR).
Hope it helps, if you need any help please feel free to ask from us.


Make BLAKE2b the default hash function

Libsodium is currently using BLAKE2b for its crypto_generichash. Besides keeping parity with the upstream library, compared to SHA2 BLAKE2b:

Is much faster.
Is not vulnerable to length-extension attacks.
Has built-in support for keying.

In sodiumoxide BLAKE2b is only exposed via libsodium_sys. I think that BLAKE2b should be brought into the main sodiumoxide library in a way that directs users to it, recommends it, and makes it the default (through namespacing and documentation). On the other hand, use of SHA2 should not be discouraged, but it should be placed slightly more "out of the way" (e.g., in the libsodium documentation it's placed under "Advanced.") There may be reasons (e.g., compliance) that people still need to use SHA2.

Closing in favor of #101.


Add unicode test files

[v] All tests passed. If this feature is not already covered by the tests, I added new tests.
[v] This pull request is on the dev branch.
[v] I used gofmt for formatting the code before submitting the pull request.

@barbelity I believe this PR introduced the problem in Issue #785


Categorical Input Dimension Limit

Hello, when I tried to give an embedding dimension >1024 I receive the following error:
RuntimeError: Expected max_D <= 1024 to be true, but got false.  (Could this error message be improved?  If so, please report an enhancement request to PyTorch.)
Is there a way to overcome this issue and work with larger embeddings?

hi @ayasar70,
The max embedding dim check is made in FBGEMM here. This was previously set due to shared memory limitation, but currently is limited by the binary size / compilation time. You can try changing this value locally, but it might require recompiling FBGEMM.
Alternatively, you can create multiple embedding tables with the same feature as a workaround.
Thanks!

For the larger  emb_dims , in addition to disabling the check and recompiling - are there alternate kernel(s)/optimization that should be used ? (cc: @jianyuh, @jspark1105)

Another workout could be to create two tables (one with 1024 embedding dim, the other with the extra dims). You may need some additional logic to stitch it together, but is good unblocker if you don't want to recompile FBGEMM


Robolectric 4 support

As I have read, tests written with androidx.test.* are supposed to be executed either as an instrumented test (in a real device or emulator) or in the JVM with robolectric 4. So I have copied the ChangeTextBehaviorKtTest in the test folder, and I have added robolectric 4 dependency to gradle file. Also I have copied the rest of androidx.test.* dependencies with testImplementation keyword. Everything seems ok, until I try to execute the tests.
This is what I get:
[Robolectric] com.example.android.testing.espresso.BasicSample.ChangeTextBehaviorKtTest2.changeText_sameActivity: sdk=28; resources=binary
Called loadFromPath(/system/framework/framework-res.apk, true); mode=binary sdk=28

androidx.test.espresso.PerformException: Error performing 'close keyboard' on view 'with id: com.example.android.testing.espresso.BasicSample:id/editTextUserInput'.

 <omitted full stacktrace>

Caused by: java.lang.RuntimeException: Attempt to close the soft keyboard did not result in soft keyboard to be hidden. resultCode = -1

So I have removed the call to closeSoftKeyboard() function, as I have noticed that is not necessary with instrumented tests so that they can be executed successfully.
When I remove the call to that funcion, the first test changeText_sameActivity is executed successfully, but the second still fails, with this new exception:
[Robolectric] com.example.android.testing.espresso.BasicSample.ChangeTextBehaviorKtTest2.changeText_newActivity: sdk=28; resources=binary
Called loadFromPath(/system/framework/framework-res.apk, true); mode=binary sdk=28

androidx.test.espresso.NoMatchingViewException: No views in hierarchy found matching: with id: com.example.android.testing.espresso.BasicSample:id/show_text_view

View Hierarchy:
+>DecorView{id=-1, visibility=VISIBLE, width=320, height=470, has-focus=true, has-focusable=true, has-window-focus=true, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, layout-params={(0,0)(fillxfill) ty=APPLICATION wanim=0x10302f8
  fl=LAYOUT_IN_SCREEN LAYOUT_INSET_DECOR SPLIT_TOUCH HARDWARE_ACCELERATED DRAWS_SYSTEM_BAR_BACKGROUNDS
  pfl=FORCE_DRAW_STATUS_BAR_BACKGROUND}, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=1}

I had the same problem. I needed to add
android.enableUnitTestBinaryResources=true
in my gradle.properties file


feat(react): improved useTimeout and added usePreservedCallback

Overview
@manudeli Hello! 👋
Currently, useTimeout hook is written to call the changed function when the callback function changes.
However, in practice, we're not actually calling the changed function, even if the function changes in the middle.
This is because the only value we currently depend on for useEffect is ms.
Adding ref to the dependency array doesn't solve this problem because it's not tracked.
These problems can be solved by using hooks like usePreservedCallback in toss/slash, which can preserve the reference of the callback function, while at the same time ensuring the function is up-to-date.

usePreservedCallback

Since the ref keeps updating during its lifecycle, when calling the function returned by useCallback, the latest function will be called by the closure attribute.
PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.84%. Comparing base (8eb8892) to head (16bdcf4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   80.67%   80.84%   +0.17%
==========================================
  Files          36       37       +1
  Lines         445      449       +4
  Branches       98       98
==========================================
+ Hits          359      363       +4
  Misses         77       77
  Partials        9        9

Components
Coverage Δ

@suspensive/react
97.02% <100.00%> (+0.04%)
:arrow_up:

@suspensive/react-query
∅ <ø> (∅)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/react-await
100.00% <ø> (ø)

@suspensive/react-image
23.52% <ø> (ø)

@manudeli

To make how to work be same between AS-IS and TO-BE, we should add useCallback in all components using useTimeout. There is no significant difference in components that use useTimeout, but it can be expected that performance will be slightly worse. So I'm confuse that this is really improvement. I need more reasons to merge this change

I did this because what was already written wasn't working as intended 🤔
If you don't want to guarantee up-to-date functions, the code below should be removed because it's pointless.
import { useEffect, useRef } from 'react'
import { useIsomorphicLayoutEffect } from './useIsomorphicLayoutEffect'

export const useTimeout = (fn: () => void, ms: number) => {
-  const fnRef = useRef(fn)

-  useIsomorphicLayoutEffect(() => {
-    fnRef.current = fn
-  }, [fn])

  useEffect(() => {
-    const id = setTimeout(fnRef.current, ms)
+    const id = setTimeout(fn, ms)
    return () => clearTimeout(id)
  }, [ms])
}

@manudeli I recently took a deep dive into the usePreservedCallback hook.
As a result of this reflection, I'm happy to contribute to a great library once again.


fix(ground_segmentation): fix bug

Description
Fix bug in ransac ground filter
Related links
Parent Issue:

Link
https://github.com/autowarefoundation/autoware.universe/pull/6791

How was this PR tested?
I confirmed that the RANSAC node runs without any errors using a single rosbag on my local PC.
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@yukkysaito @YoshiRi could you also approve this PR as codeowner of tier4_perception_launch?


New version Tracker: 0.2.0

Registering: Tracker
Repository: https://github.com/FluxML/Tracker.jl
Version: v0.2.0
Commit: ecba0a3fdfcd043a10c476daf70287d42484315c
Proposed by: @dhairyagandhi96
Reviewed by: @dhairyagandhi96
Reference: https://github.com/FluxML/Tracker.jl/commit/ecba0a3fdfcd043a10c476daf70287d42484315c#commitcomment-33291768

You probably want to setup TagBot on the Tracker repo.

I just set it up.  Thanks Stefan!

Just saw this, thanks @StefanKarpinski @staticfloat!!

@christopher-dG, could you trigger TagBot for them?


Use metavm

Closes: https://github.com/metarhia/config/issues/37

Landed in https://github.com/metarhia/config/commit/8cdd1589ed61082cefd5f40ac85b2c1829e16d77


Issue with executing of 'dnu pack' in Visual Studio post build event command line

When using 'dnu pack' in Visual Studio post build events, no any post build command (macro) can be executed after it.
For example:
cd cd $(ProjectDir)
dnu pack
copy x y
The last executed command in the sequence above will be dnu pack. Whatever is used after it, will simply be ignored.
Not sure if this is a VS or dnu issue.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


Add support for Windows (and MacOS)

Currently, no support is provided for printing from Windows (or macOS) devices to a Brother printer.
Proposal:
Add support for printing from Windows (and macOS) devices.
Extra info: our use case involves a model QL-820NWB printer from Brother if that is helpful.
Thanks in advance!

Hi @LucaCras !
Thanks for the great suggestion! I'll leave this open until we get some time to tackle it or someone from the community wants to wants to give it a shot.
Currently another_brother sits on top of the native SDKs from Brother which is great but also means adding support for a new platform entails bringing in that SDK and wiring things up. I have been hoping to write another_brother natively in Dart without any native SDK and thus get support for all Flutter platforms as they become available by default.
Thanks again,


Add non-mutating Array methods to es2023 in the lib/target suggestion list

A developer upgraded to TypeScript 5.5 and was confused when toSorted was no longer available when compiling. This was because toSorted (along with toReversed, toSpliced, and with) were moved from esnext.array to es2023.array.
This PR makes it so that we recommend es2023 appropriately.

This might be nice to back-port if we have other patch-worthy stuff.

@typescript-bot cherry-pick this to release-5.5


bintray packages aren't updating ... again

@anhou reset the bintray repos a week or two ago, but we're back to seeing that the packages built there aren't reflecting the latest code, as reported by @jlmcknight @ytjohn and John Inama in our slack channel.
We're pushing a "version" tag that is based on the branch, which for the latest builds on master is always "master" and never changing, so it's also impossible to tell what version the bintray deb packages are from.
IMO - we need to reset the package building to put some additional number on the tail end that's driven from Travis - even something as simple as a YYYYMMDD-HHMM - to extend the version detail with debian packaging so that we can validate the packages are getting updated, and have some better sense of metadata flowing into them to know if they're recent or older for people deploying the packages.

I go through on-http/on-taskgraph/.. travisci history ,  found  all packages are updated.  https://bintray.com/rackhd/debian/packages/master#files/dists/trusty/main/binary-amd64  not sure what's the problem. but I think add the version will help a lot for identify the problem


Transfer of large messages sometimes stalls

When testing using this WebRTC test page, sending 64MB using ordered mode, very frequently the transfer will stall at some point and resume a second or so later. Note that this page sends messages of size 256KB.
I was able to get a packet capture here: https://drive.google.com/file/d/1U2SxCRZTm9RtpLDjKwEiFSd08ohX8XAg/view?usp=sharing
The timing of packets may be a little confusing since both sides of the connection were recorded within the same tab; what you are seeing is the time at which packets were received by either side.
Anyway, the issue happens at around packet 12092. The issue seems to be that a_rwnd is reduced from 49576 bytes in the SACK in packet 12062 down to 1 in the SACK in packet 12075, even though the cumulative TSN only increased by 2. I don't understand why it would be reduced so suddenly, or why a partial message wouldn't be delivered to the application via the receive callback to free up space.
A quarter of a second later, there's one more SACK, still with a_rwnd of 1, and one more DATA chunk in return. Another quarter second later this repeats, then repeats again, until eventually a SACK is sent with a_rwnd 130816 and everything resumes.
This is using a February 20 branch of usrsctp. I'll try to reproduce it with tip-of-tree, but it's difficult to reproduce at all, at least when I want it to.
@tuexen Are you aware of any existing issue, or issue fixed between February and today that would explain this? If it's any clue, the message size of 256KB seems highly related, the issue doesn't reproduce if I reduce it to 255KB.

Hi @taylor-b ,
that sound very similar to a bug we've fixed last week.
See here
Can you try the most recent usrsctp version and report back?

Hi @taylor-b
here is what is happening:
There was a bug (fixed in https://github.com/sctplab/usrsctp/commit/8d7662e81b7192566eaa23a651210b7d07e009c1), which resulted in an much higher number of mbufs being used than necessary when handling incoming packets. Basically, we were not using mbuf clusters (although they were allocated), but long chains only consisting of mbufs.
Since you are using large message (which is fine), there is some buffering going on one the receiver side. To protect itself, a receiver announces a receive buffer of 1, if there are a substantial amount of mbufs being used. The above bug triggers this and you see this in the trace in various places. With the fix mentioned above, this should not occur anymore in this case.
However, such a case an happen (when dealing with a huge number of small packets).
What is happening and being described by you as "freezing", is not not really freeing. Is the sender honouring the peers receiver Window of 1 and only sending a single packets. This starts on the receiver side the delay ack timer and after 200ms the SACK is sent. This then triggers a SACK and so on. So you see delayed SACKs in frame 12093, 12095, 12097, and 12099.
What can be done to improve it? First of all, fix the memory allocation issue, which resulted in triggering this self protection when using large message. The delivery doesn't need to be fixed, since the protection should trigger when using small messages which can be delivered. What could be improved is to NOT delay SACKs when being in this situation. SACK are normally not delayed when there is loss or there are duplicated. So it would be consistent to do so. Will see if I can add such an improvement.
However, I would not expect this problem to occur anymore when using a version which contains https://github.com/sctplab/usrsctp/commit/8d7662e81b7192566eaa23a651210b7d07e009c1. Can you verify that?

So in short, the receiver runs low on memory because it's using mbuf chains instead of clusters, which are presumably more space efficient? Or is it because the clusters are allocated but not used?
I'll try to verify that 8d7662e fixes the issue, however as I mentioned it's quite temperamental. For whatever reason, I can reproduce it in an official Chrome build but not my local build; I'm assuming it's just very timing-dependent. Can you suggest any conditions that would make it more likely to occur?

So in short, the receiver runs low on memory because it's using mbuf chains instead of clusters, which are presumably more space efficient? Or is it because the clusters are allocated but not used?

It is because the stack monitors how much mbufs are used. If that is too high, the condition is triggered. In this case it is triggered, because you do some buffering (which is OK), but you just use mbufs for it (which is nit OK).

I'll try to verify that 8d7662e fixes the issue, however as I mentioned it's quite temperamental. For whatever reason, I can reproduce it in an official Chrome build but not my local build; I'm assuming it's just very timing-dependent. Can you suggest any conditions that would make it more likely to occur?

Not really. It might be possible to trigger it deterministically if one would have packetdrill support for the usrsctp stack, but it only works with the kernel stack and there the problem does not occur. However, not delaying the SACK might be testable with packetdrill and the kernel stack.

Was able to reproduce it even with 8d7662e. Will try to get a log with SCTP_DEBUG enabled tomorrow; any specific categories I should be enabling?

OK. Just use DEBUG_ALL and try to get a .pcapng file. What message sizes are you using? Ordered or unordered?

Still using 256KB messages, ordered.
Log: https://drive.google.com/file/d/1HI9RcsNt0ylurPSmLcAbJcvdRFjaRK-o/view?usp=sharing
pcap: https://drive.google.com/file/d/1r738wwRA0-Fpe-tErwDy4lzFQo06_bqt/view?usp=sharing
In this case it contains both incoming and outgoing packets. You can differentiate them from the frame header. Note that I cut the log off after the interesting bits because otherwise it was gigantic.
Gap occurs at packet 6546. I marked it in the text log with "GAP OCCURS HERE".
This appears to be a different problem than before. In this case some packets are lost.
At packet 6281, the chunk with TSN 290362123 is dropped.
It's retransmitted at packet 6379, though this retransmission is also not received.
Right afterwards there is another gap, indicating 290362127 was dropped. At packet 6489 it's retransmitted, at 6521 it's received.
Again there is a gap afterwards, between 290362181 and 290362188.
More SACKs are sent/received that indicate that 290362123 is still missing, until the receive window is exhausted. But then 290362123 is not retransmitted until a second later.
Is this just expected behavior when a retransmission is lost?
The reason the packets are getting dropped is actually because the socket send buffer was full. If we were returning ENOBUFS in this case, would usrsctp be smart enough to know that the chunk was not sent and needs to be retransmitted, even without the presence of the SACK?

Looking at the tracefile from the receiver's perspective, I think everything is as expected. As soon as there are gaps in the TSN space, SACKs are sent for each received packet containing a DATA chunk and the gaps are reported. In the area you are describing, the TSNs 290362123, 290362127, and 290362181- 290362188 are lost. I think we agree on this.
Looking at the tracefile from the sender's perspective, I also think everything is as expected. In frame 6274, 6377, and 6378 the TSN 290362123 is reported as missing. Therefore (after being reported lost for three times), a fast retransmission happens in frame 6379. The same happens for TSN 290362127. It is reported as missing in frame 6474, 6487, and 6488.  The fast retransmission happens in frame 6489.
The loss of TSNs 290362181- 290362188 is reported once in frame 6546 by reporting the TSN 290362189 as received. Due to the flowcontrol no TSNs after TSN 290362189 are transmitted. So there is no chance that the lost TSNs 290362181- 290362188 are recovered by fast retransmissions.
Therefore, a timer based retransmission has to resolve it. The minimum value has a default of 1 second as specified in RFC 4960. It could be changed via the API. Another way to improve the loss is to use an alternate loss recovery mechanism like RACK, which is currently being specified for TCP and @weinrank did some work for applying it to SCTP. However, his work is only done within a simulation environment right now.

Is this just expected behavior when a retransmission is lost?

Yes, a lost fast retransmission will be recovered by a timer based retransmission. Also tail drops or drops almost at the tail have to be recovered by timer based retransmissions, because they can't receive 3 gap reports. It would make much sense to use RACK also for SCTP.

The reason the packets are getting dropped is actually because the socket send buffer was full. If we were returning ENOBUFS in this case, would usrsctp be smart enough to know that the chunk was not sent and needs to be retransmitted, even without the presence of the SACK?

The stack is smart enough to try to avoid the immediate sending of further packets. But the stack has no idea when the situation has resolved. So it just relies on the fast retransmission / timer based retransmission recovery.
The problem you are experiencing can happen if the local socket send buffer or the remote receive buffer size is smaller than the advertised receiver window received by the peer. Would it be possible to bump up these values to get them consistent with the values used that the SCTP layer? That way you would avoid these packet losses at least on your end, which definitely tend to be tail drops...

The minimum value has a default of 1 second as specified in RFC 4960. It could be changed via the API.

I assume if the minimum is changed, the RTO will be determined based on when SACKs are received?

Would it be possible to bump up these values to get them consistent with the values used that the SCTP layer?

They're already pretty generous, but this particular sample page is trying to send as fast as possible, and is also very bursty, so it's basically the worst case scenario.
It looks like, post-8d7662e, things are working as expected, so closing.

The minimum value has a default of 1 second as specified in RFC 4960. It could be changed via the API.

I assume if the minimum is changed, the RTO will be determined based on when SACKs are received?

The RTT is constantly measured and the RTO is computed as the smoothed RTT plus four times the smoothed RTT variance. Then the value is forced in the interval [RTO.min, RTO.max]. After a timeout, the value is doubled. That is also done for TCP, just a lot of TCP implementation have lowered RTO.min.


windows - chinese username not supported

Description
For windows environment - chinese username not supported.
e.g:
C:\Users\张三.djl.ai\pytorch
Expected Behavior
Chinese username should be supported.

@mymagicpower
你用enhancement吧，别用bug，这是外国的项目，他们没必要非要支持中文。而且服务器上也没人用中文做路径

@mymagicpower I don't think this can be fixed, it's a bug in Java System.load() function.
I tried the following code, and it failed with Chinese file path:
Path file = Paths.get("asmjit.dll");

String path = file.toAbsolutePath().toString();

System.out.println("Loading file: " + path);

System.load(path);

System.out.println("Loaded file: " + path);

file = Paths.get("张三\\asmjit.dll");

path = file.toAbsolutePath().toString();

System.out.println("Loading file: " + path);

System.load(path);
System.out.println("Loaded file: " + path);

Loading file: C:\source\test\asmjit.dll
Loaded file: C:\source\test\asmjit.dll
Loading file: C:\source\test\张三\asmjit.dll
Exception in thread "main" java.lang.UnsatisfiedLinkError: C:\source\test\??\asmjit.dll: Can't find dependent libraries
        at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)
        at java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(NativeLibraries.java:384)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:228)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:170)
        at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2389)
        at java.base/java.lang.Runtime.load0(Runtime.java:755)
        at java.base/java.lang.System.load(System.java:1953)
        at org.example.Main.main(Main.java:22)

@frankfliu can we add a special character check before System.load command? This will fail regardless of System right?

We can add a warning if cache directory contains non-ASCII chars. But non-ASCII chars not necessary will always fail.
The problem is CJK Windows native charset is not set to UTF-8, it usually be "GBK", "Shitf-JIS" etc. For most of western language, non-ASCII chars should still work.


Calculate vh correctly for mobile editor

The mobile game gallery doesn't correctly determine the size of vh due to a flawed implementaion of vh (There is no clear guidance there when it comes to handling device and browser-specific differentiations)
Demo Screenshot

closing this PR due to inactivity. feel free to ping me and ask for this to be reopened and hopefully merged!

#1441


which function can I verify the user's audio is able to use ?

Hi,
Recently, I meet with a problem.
some user's microphone is not used.
And when I make a inbound call , the console will display "unable to acquire stream".
I am wondering if there is a function I can use to verify if the user has audio?
Thanks.
p.s. using 0.6.4

Hi @tuluxmu,
You can call getUserMedia independently, then pass that stream into SIP.js, instead of relying on SIP.js making that call. This should be the direct call that is error'ing out.
James

This question appears to be answered. Please direct any follow up to our mailing list.


Add a fun skinned mesh stress test based on the animated_fox example

Objective

Add a stress test for skinned meshes

https://user-images.githubusercontent.com/302146/167111578-55a7d58a-0ec8-4735-a043-f084f0ff3939.mp4

There should probably be some documentation somewhere that it takes an optional argument for the count.
There's also an open PR that adds a short description at the top of the file for every examples, so there should probably be one added in the file. I'd be ok with just pasting the one in the readme.

Done.

bors r+


Cannot connect to my Twitter account

When I go to settings I see

I click on "Connect your Twitter account"

My public profile is

And the twitter is wrong. I might have connected before so the settings page is wrong.

Hi @stevemao you'll need to add these credentials in .env file:
var credentials = { 	consumerKey: process.env.TWITTER_CONSUMER_KEY, 	consumerSecret: process.env.TWITTER_CONSUMER_SECRET, 	callbackURL: process.env.TWITTER_CALLBACK_URL };
You'll get them here: https://developer.twitter.com/en/apps/create


perf!: simplify how type are converted to string

BREAKING CHANGE: types aren't processed as much and thus not all override patterns are still
supported

#405  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on  Graphite

Merge activity

Apr 15, 12:52 AM EDT: @RebeccaStevens started a stack merge that includes this pull request via Graphite.


Add motion workflow creator (WIP)

Adds a new menu point to motion list view where new workflows can be created and edited

@emanuelschuetze still WIP - can be tested however
Current defects:

List of next states will vanish in table
no delete button for workflow states
some any

please test and expand the list

2 permissions are missing:

add new choice field for merge_amendment_into_final (label: "Show amendment in parent motoin") with values {-1|0|1}
add new choice field for access_level (label: "Access level") with values {
0: all users,
1: Submitters, managers and users with permission to manage metadata
2: Only managers and users with permission to manage metadata
3: Managers only}


Bump up is-proto-prop

Coverage remained the same at 100.0% when pulling 0010b5ce49187c2548d1b63ccbbe0c3141d78a55 on jorgegonzalez:patch-1 into 6b74153d10fa83024e840aab2f93def51dcf56c0 on dustinspecker:master.

This shouldn't be necessary because 1.0.1 is within ^1.0.0 version range. Can you please try reinstalling xo? Do you have a lockfile that is preventing it from getting 1.0.1?

 My lockfile was the issue.


Update nf-processthreadsapi-openprocesstoken.md

This page incorrectly states that the OpenProcessToken function
requires the provided HANDLE argument (ProcessHandle) to have the
PROCESS_QUERY_INFORMATION access permission, when it actually
only needs the PROCESS_QUERY_LIMITED_INFORMATION access permission.
This change corrects the statement.
I was informed of this discrepancy via StackOverflow and from my admittedly brief testing it appears to hold true.
Additional Info
This is the stackoverflow thread I am referring to: Check if a different process is running with elevated privileges
This is roughly the checked I performed to confirm this change is accurate:
#include <iostream>
#include <windows.h>

DWORD procId = getProcessIdByName("notepad.exe"); // Custom function, uses CreateToolhelp32Snapshot method
HANDLE hProcess = OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, FALSE, procId);
HANDLE tProcess;
bool tokenOpened =  OpenProcessToken(hProcess, TOKEN_QUERY, &tProcess);
std::cout << tokenOpened;
// Output: true

@oblivioncth : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @oblivioncth - can you provide the link to the stackoverflow thread?

@Karl-Bridge-Microsoft See the updated content of my original comment


Where does the location value(x, y, z) come from?

Hi,
I am wondering how you get the location value(3D object location x,y,z) which are necessary for 3D box calculation.
Do you suppose the location_x, location_y, and location_z are already regressed in 2D detector? It seems 3D location values are just read from 2D txt file according to your source code.
Please make me right if I misunderstood.

@smallcorgi Hi, if this not implement, then how to predict 3d box? Assuming that point is the center of 2d bouding box?

Hi I found someone else implemented the 2D/3D tight constraint based optimization to get the 3D location.
https://github.com/lzccccc/3d-bounding-box-estimation-for-autonomous-driving/blob/master/utils/correspondece_constraint.py


recovery from mxent checkpoint for wide & deep , accuracy decrease

use example/sparse/wide_deep/train.py to train
e.g. in first epoch the accuracy in 0.83 like below
2018-06-27 18:48:53,896 epoch 0, accuracy = 0.8382098765432099
2018-06-27 18:48:53,900 Saved checkpoint to "./checkpoint/checkpoint-0000.params"
2018-06-27 18:48:53,902 Saved optimizer state to "./checkpoint/checkpoint-0000.states"
2018-06-27 18:48:53,902 Training completed.
load the sample and use the validate dataset to score, the accuracy decrease to 0.79
INFO:logger:Finished inference with 16200 images
INFO:logger:Finished with<PHONE_NUMBER>17 images per second
INFO:logger:('accuracy', 0.7991358024691358)

this is the code to do inference, by default the params name is checkpoint_wd.params
inference.py.txt

inference2.py.txt
I write a very interesting code base on train.py
load checkpoint after save checkpoint

accuracy is the same for training epoch & load
accuracy is not the same after commend
mod.save_checkpoint(prefix, epoch, save_optimizer_states=True)
[21:06:29] src/operator/././../common/utils.h:417: Optimizer with lazy_update = True detected. Be aware that lazy update with row_sparse gradient is different from standard update, and may lead to different empirical results. See https://mxnet.incubator.apache.org/api/python/optimization/optimization.html for more details.
2018-06-27 21:06:29,316 Epoch[0] Batch [100]	Speed: 73784.02 samples/sec	accuracy=0.794300
2018-06-27 21:06:29,450 Epoch[0] Batch [200]	Speed: 74814.65 samples/sec	accuracy=0.803400
2018-06-27 21:06:29,583 Epoch[0] Batch [300]	Speed: 75327.38 samples/sec	accuracy=0.819000
2018-06-27 21:06:29,735 epoch 0, accuracy = 0.8308641975308642
2018-06-27 21:06:29,735 Loading symbol from file /home/lingyan/mxnet/dev_06/example/sparse/wide_deep_quantization/checkpoint-symbol.json
2018-06-27 21:06:29,735 Loading params from file /home/lingyan/mxnet/dev_06/example/sparse/wide_deep_quantization/checkpoint-0000.params
2018-06-27 21:06:29,854 epoch 0, checkout recovery accuracy = 0.7981481481481482

Hi @glingyan thanks for submitting the issue, @sandeep-krishnamurthy requesting this be labeled.

@ZiyueHuang

@eric-haibin-lin

I know the answer
for w&d ,the csr data need to be prepare with hash
which make every time the data is difference