removed unnecessary require and renaming of null to zero

I removed unnecessary require statement from ownerOf method inside ERC721 contract, as the zero address already got checked during the mint process. We are checking for zero address before storing in the _tokenOwner array. So, there is no need to check it again.
As per discussion, I also renamed null statement to zero.

Hello @princesinha19!
From the specification of 721, ownerOf must revert when the zero address is queried, so we can't get rid of that require statement (which is why the tests fail). The test description changes are good though!

Okay, thanks @nventuro.
I added the require statement.


Make PR title clickable to open PR page instead of having to click on Description in the drop down

Make the highlighted in blue in the treeview clickable to load the PR:

Hey @tanhakabir! Would the expected behaviour here be that clicking anywhere in the blue would open the PR page, except for the chevron which would open/close the dropdown?

Hey @joshuaobrien yes!

This would essentially mean getting rid of the 'Description' tree node.

Given that if you want to view the description you also probably want to view the file diffs, I'm going to leave this as is.

Why is the "Description" tree node needed?

It isn't really needed other than as a place to access the overview. However, I would guess that anyone who wants to see the overview also wants to view file diffs and would therefor expand the tree node anyway.


New Contact flow and dynamic modal

The dynamic modal is useful from both Vue and Backbone, letting us use the same patterns when creating modals from either origin location.
The new contact flow unifies how contact options work, but has only been implemented for the footer so far.

This was merged as part of https://github.com/codecombat/codecombat/pull/6069 and the changes requested can be started as a new branch + PR.


CreateJS sometimes renders content out of place when rendered using Chrome 64.0.3282.119

When rendering complex layouts, CreateJS will occassionally render the content incorrectly for a split second before snapping the content into its correct position. This only occurs on Chrome 64.0.3282.119. Similar behavior is not scene on other browsers and prior version of Chrome in the 63.x.x.x series.
I've attached a screen shot of the issue occuring as well as a zipped quicktime movie of it happening.

ninja_chrome_glitch.zip
We have not yet found a workaround for this issue.
It only appears to occur with really heavy content where the browser struggles to render the content.
This occurred on Windows 10.

Experiencing a very similar issue on mobile versions of Chrome 64. It seems that bounding boxes are not calculated correctly.

Could be a duplicate of https://github.com/CreateJS/EaselJS/issues/937
Canvas size exceeds 65536 pixels, starts causing some wacky issues! Chrome 64 bug.

Does this still persist with Chrome 65+? I am closing this, feel free to open if it still persists.


fix description of HASHTABLE_LOOKUP in smartreply doc

HASHTABLE_LOOKUP is a builtin op rather than a custom one.

Can one of the admins verify this patch?

Jenkins, test this please.

Jenkins, test this please.


Property Columns Implementation

This is a preliminary implementation of #139
I created some subs that need to be moved to the correct location and possibly shared to be used in the entire program.
Also, an implementation to save the columns from one session to another would be useful @rmcanany I would be glad if you take care of this
I have added comments to the code

That's slick!  I'll take care of the save/retrieve.  It would be nice if we could use FormPropertyPicker to populate the list.  It might be easier if I did that part since it's my code.  Let me know.

Yes sure, I wanted to take care of the UI first, if you know any part of code already made go on with it :)
Also, the list of the selected columns has a checkbox that I wanted to use to show-hide temporarily I don't know if it's useful or remove it. At the moment it does nothing.

OK, will do.
For me, it will be a set and forget thing.  So I wouldn't need to temporarily show/hide columns.  That said, it wouldn't bother me either.  We would have to track the checkbox state, but that could easily be done using a Dict instead of List.

Added ListOfColumns save/retrieve and prop selection from dialog.  Minimally tested.

Moved UpdatePropertiesColumns to UtilsFileList


Adopt EIP-7688: Forward compatible consensus data structures

EIP-4788 exposes the beacon root to smart contracts, but smart contracts using it need to be redeployed / upgraded whenever the indexing changes during a fork, even if that fork does not touch any used functionality.
This problem expands further to bridges on other blockchains, or even into wallet apps on a phone that verify data from the beacon chain instead of trusting the server. It is quite unrealistic to expect such projects to all align their release cadence with Ethereum's forks.
EIP-7688 fixes this by defining forward compatibility for beacon chain data structures. Electra Profile retain their Merkleization even when rebased to StableContainer definitions from future forks, enabling decentralized protocols to drop the requirement for trusted parties to periodically upgrade beacon state proof verifiers. (+1 squashed commit) Squashed commits:
[8b92f7b0f] Adopt EIP-7688: Forward compatible consensus data structures
EIP-4788 exposes the beacon root to smart contracts, but smart contracts using it need to be redeployed / upgraded whenever the indexing changes during a fork, even if that fork does not touch any used functionality.
This problem expands further to bridges on other blockchains, or even into wallet apps on a phone that verify data from the beacon chain instead of trusting the server. It is quite unrealistic to expect such projects to all align their release cadence with Ethereum's forks.
EIP-7688 fixes this by defining forward compatibility for beacon chain data structures. Electra Profile retain their Merkleization even when rebased to StableContainer definitions from future forks, enabling decentralized protocols to drop the requirement for trusted parties to periodically upgrade beacon state proof verifiers.

Also needs https://github.com/protolambda/remerkleable/pull/25 to avoid usage changes (and pass tests)

consensus-spec-tests

https://x.com/KaneWallmann/status/1816729724145795258 (Nitter)


Issue when installing latest version

When trying to install version 0.11.0 found issues with already existing installation requirements from Magento packages ( Magento OpenSource 2.4.3 )
> composer require --dev  bitexpert/phpstan-magento
Using version ^0.11.0 for bitexpert/phpstan-magento
./composer.json has been updated
Gathering patches for root package.
Loading composer repositories with package information
Warning from https://repo.packagist.org: Support for Composer 1 is deprecated and some packages will not be available. You should upgrade to Composer 2. See https://blog.packagist.com/deprecating-composer-1-support/
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for bitexpert/phpstan-magento ^0.11.0 -> satisfiable by bitexpert/phpstan-magento[v0.11.0].
    - bitexpert/phpstan-magento v0.11.0 requires phpstan/phpstan ^1.1.0 -> satisfiable by phpstan/phpstan[1.1.0, 1.1.1, 1.1.2, 1.2.0, 1.3.x-dev] but these conflict with your requirements or minimum-stability.

Installation failed, reverting ./composer.json to its original content.

Installing version 0.10.* works.

Thanks for opening your first issue.
This is a known issue and it's stated in the README file that the extension requires PHPStan 1.1. If you are using a Magento version that requires an older version of PHPStan, you need to manually upgrade before installing this extension.
Magento pinned PHPstan to a 0.12 version and PHPStan recently released version 1.0. Since there will be no support for older versions by PHPStan, we had to do this move. The next Magento release will require PHPStan 1.x which should fix this but for now, you have to manually adjust the PHPStan version if you want to use the extension.
Versions 0.10 and 0.11 of this extension are compatible in features, so you don't miss anything when using version 0.10. You could even pin that version in your composer.json. Sadly this will change in the next version 0.12 where we will add support for extension attributes.

Also thanks for giving this extension a try. Would love to hear your feedback!

Hi @shochdoerfer:
Thanks for the feedback. Might be needed to add explanation on the readme for this last change for those who are not familliar with the version mambo is going on with Magento and PHPStan.
I'm starting to review this tool to add to our interanl process and pipelines, so will let you know if there is something we can improve or discuss once we start giving it a spin on all our project.
You can close this issue if you like. I've already pinned the version on the composer file.
Regards
Esteban

I would have thought Composer automatically picks the previous version as it would have matched your constraint. I thought the issue only pops up when upgrading an existing Magento project.


If moving a non-owned buffer make sure to copy the buffer.

@vekterli PR

@vekterli Do you complete this one too, so I can prepare the essential one.


useless condition

dmlab2d/system/image/lua_image.cc line 517
Code:
if (!(0 >= hue_prime_ && hue_prime_ < 6.0)) {  // <- probably hue_prime_ >= 0.0
hue_prime_ -= 6.0 * std::floor(hue_prime_ / 6.0);
}

Can you explain why the condition is useless?
The condition saves doing the expensive floor and division calculation behind a branch-predicted condition.

if  0 >= hue_prime_ then automatically hue_prime_ is smaller than 6.0

Good Spot! is should be:
if (!(0 <= hue_prime_ && hue_prime_ < 6.0))
I'll update.

Fixed by 2261b939ebd574505346accd09ce5b9e30398998, thank you very much for reporting!


chore: add devcontainer and Makefile

As this project is adressing and solving a very important topic in the Terraform ecosystem, I think it would be valuable to make contributions as easy as possible. This PR should help developers to get started with the CLI as wel as with contributing to the CLI ba adding two features:

a devcontainer definition to enable the development in a devcontainer so that no local setup is needed (except for having Docker and VSCode up and running). This would also enbale the usage of GitHub Codespaces
a Makefile that comprises the most important commands especially for code contributions

Awesome! Thanks for adding this.


make hostname and port visible

in case of errors (ie "WARNING: Failed to download key certificates: …") make the server hostname and port visible.

oops


Clean up API readme - rewrite in markdown

You can use VSCode to see the parsed version of the markdown file by clicking on the displayed icon (top right corner when editor is open):

Refer to the following markdown documentation
Make sure you are working on a branch! Refer to the following wiki
PATH to the file is: packages/api/README.md

@IvanObreshkov @peti-krl hey guys, can you wrap up this PR after the hackathon? You can use an online converter to convert most of the text but some part might need to be manually done.
Additionally, can you add the new routes which were implemented by you?

@IvanObreshkov @peti-krl hey guys, can you wrap up this PR after the hackathon? You can use an online converter to convert most of the text but some part might need to be manually done.
Additionally, can you add the new routes which were implemented by you?

Deal


Permission denied  '/sys/kernel/debug/tracing' & Permission denied: '/run/user/1000/gvfs'

Output of the info page (if this is a bug)
From file /var/log/datadog/agent.log
2020-03-09 13:33:32 IST | CORE | WARN | (pkg/collector/python/datadog_agent.go:118 in LogMessage) | disk:e5dffb8bef24336f | (disk.py:75) | Unable to get disk metrics for /sys/kernel/debug/tracing: [Errno 13] Permission denied: '/sys/kernel/debug/tracing'
2020-03-09 13:33:33 IST | CORE | WARN | (pkg/collector/python/datadog_agent.go:118 in LogMessage) | disk:e5dffb8bef24336f | (disk.py:75) | Unable to get disk metrics for /run/user/1000/gvfs: [Errno 13] Permission denied: '/run/user/1000/gvfs'

Error From Log File

Error From datadog-agent health

Describe what happened:

Not able to see machine metrics , and its continuously emitting error log

Describe what you expected:

start sending machine metrics and stop shrowing error

Steps to reproduce the issue:
Additional environment details (Operating System, Cloud provider, etc):
Machine  - ubuntu 18.4
Datadog - Agent 7.17.1 - Commit: 378649d - Serialization version: 4.19.0 - Go version: go1.12.9

i had added  nodejs.d & config.yml manually
so both files had root permission so i changed it to dd-agent like other files in /etc/datadog-agent Folder then restart datadog and it started working


Changing theme in jupyter cad makes the scene blank

https://github.com/user-attachments/assets/cf27756c-1311-4914-bac9-386b3987351d

This is also the case in the JupyterLab extension.

Note: it seems to re-appear whenever we do something that triggers a redraw like resizing the viewer panel.

Note: it seems to re-appear whenever we do something that triggers a redraw like resizing the viewer panel.

Thanks for letting know, alright this also seems to need a pinch of resize event.


WIP: Added docs for new framework link attribute.

Platforms affected
Motivation and Context

This PR depends on...
https://github.com/apache/cordova-cli/pull/584
https://github.com/apache/cordova-ios/pull/1266
See linked PRs for details.
Description

Testing

I've ran lint.
Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

This change spans across 5 repositories. These are the 5 PRs:

https://github.com/apache/cordova-common/pull/179
https://github.com/apache/cordova-lib/pull/898
https://github.com/apache/cordova-cli/pull/584
https://github.com/apache/cordova-ios/pull/1266
https://github.com/apache/cordova-docs/pull/1267


Allow raw pointers in extern fn signature

See https://github.com/dtolnay/cxx/issues/122#issuecomment-615372359 for the rationale.
mod ffi {
    extern "C" {
        type T;
        unsafe fn f(_: *mut T);
    }
    extern "Rust" {
        unsafe fn g(_: *mut T);
    }
}

The presence of *const or *mut in a function argument should enforce that the function is marked unsafe.

Function pointers need to get the same check too. A function pointer type that has a raw pointer argument should be required to be specified as unsafe.
extern "Rust" {
    fn g(callback: unsafe fn(*mut T));
}

In contrast to argument position, a pointer in return position should not enforce that the function is unsafe. #283
extern "C++" {
    type socc_examples_fixture;
    type SDIDevicePropInfoDataset;

    fn wait_for_IsEnable(
        self: &mut socc_examples_fixture,
        code: u16,
        expect: u16,
        retry_count: i32,
    ) -> *mut SDIDevicePropInfoDataset;
}

I am trying to call the following function found in node.h from Node.js
// Set up per-process state needed to run Node.js. This will consume arguments
// from argv, fill exec_argv, and possibly add errors resulting from parsing
// the arguments to `errors`. The return value is a suggested exit code for the
// program; If it is 0, then initializing Node.js succeeded.
NODE_EXTERN int InitializeNodeWithArgs(std::vector<std::string>* argv,
                                       std::vector<std::string>* exec_argv,
                                       std::vector<std::string>* errors);

Given the std::vector<std::string>* ... arguments, I assume this falls into the problemspace for this issue?
Is there a workaround I could try?
My code currently looks like this:
#[cxx::bridge(namespace = "node")]
mod ffi {

    extern "C" {
        include!("node.h");

        fn InitializeNodeWithArgs(
            args: *const CxxVector<CxxString>,
            exec_args: *const CxxVector<CxxString>,
            errors: *const CxxVector<CxxString>,
        ) -> i32;
    }
}

This is likely to be the next thing I look into adding. I haven't started yet. If anyone else thinks they'll do something in this area, please let me know so we can avoid duplication.

This is likely to be the next thing I look into adding. I haven't started yet. If anyone else thinks they'll do something in this area, please let me know so we can avoid duplication.

This proved easier than I thought - WIP linked just above.
I need to do some thinking about what happens if a raw pointer is included in some other type, e.g. a CxxVector: either adding some code in check.rs and in UI tests to ensure that's not possible, or make it possible - in which case the logic to check for the presence of unsafe will need to dig deeper in the type.

This proved easier than I thought - WIP linked just above.
I need to do some thinking about what happens if a raw pointer is included in some other type, e.g. a CxxVector: either adding some code in check.rs and in UI tests to ensure that's not possible, or make it possible - in which case the logic to check for the presence of unsafe will need to dig deeper in the type.

Could the extern "Rust" functions be allowed without unsafe? I'd find the requirement confusing when it came up, since the Rust function would need to use unsafe internally to cause any soundness issue. (Of course, many functions would end up being unsafe by nature - I just worry that cxx enforcing it would make it less obvious that the author of the Rust function should document their requirements)


removeRow() fills the row with null values and doesn't actually remove the row

Hello, I am using the latest 2.0.0-null-safety-3 version and when I remove rows using removeRow(), the maxRows value doesn't change at all. But when I read the value at that particular row, I get a row filled with null.

@ashishbeck
How are you reading a value at a row ?

@ashishbeck
I'll look at it in the coming weekend if the maxRows function is really not updating.
Contributions / Pull-Requests are appreciated.

Also, appendRow() too doesn't work after doing removeRow(). I am not sure what really is causing them

The problem that I am encountering is that when I remove any row, a new element filled with null is added to the end of my list builder which causes unwanted widgets to be added to my list. It would be really helpful if the entire row could be removed. Otherwise, I might have to rewrite my code to copy all the excel contents to a custom object and then perform and sync write operations separately.

Spent hours on this - same issue. Not sure how to work around this one, let me know if anyone finds a solution too please!

For now, I am just checking if null, continue...
        final List<Data?> row = rows[i];
        if (row[0] == null) continue;


Broken permissions on v0.2.0-7-g9f930ec release

Hello!
I have no rights to download this tar:
HTTP request sent, awaiting response... 403 Forbidden

Deployment fails with errors:
Downloading Lattice Release tar from https://s3-us-west-2.amazonaws.com/lattice/releases/v0.2.0-7-g9f930ec/lattice.tgz => /home/demo/lattice/.lattice/lattice.tgz
...

module.lattice-aws.aws_instance.lattice-coordinator (remote-exec): Connected! Executing scripts...
module.lattice-aws.aws_instance.lattice-coordinator (remote-exec): tar: This does not look like a tar archive

module.lattice-aws.aws_instance.lattice-coordinator (remote-exec): gzip: stdin: unexpected end of file
module.lattice-aws.aws_instance.lattice-coordinator (remote-exec): tar: Child returned status 1
module.lattice-aws.aws_instance.lattice-coordinator (remote-exec): tar: Error is not recoverable: exiting now

Can you provide some more details about what platform you're running on?  I attempted to reproduce this locally and it worked fine.
I can tell what the problem is -- our scripts are wrongly identifying "v0.2.0-7-g9f930ec" as being a release version rather than an unstable version.  We do some pattern matching on the contents of the Version file to determine whether it's formatted like our unstable or release versions.
Would you mind giving me the output from the following:
cd /home/demo/lattice
egrep '\-\d+-g[0-9a-fA-F]{7,10}$' Version
echo $?
egrep --version

my output:
± dw+kk |develop ✓| → egrep '\-\d+-g[0-9a-fA-F]{7,10}$' Version
v0.2.0-7-g9f930ec
± dw+kk |develop ✓| → echo $?
0
± dw+kk |develop ✓| → egrep --version
egrep (BSD grep) 2.5.1-FreeBSD

terraform apply output (not the /unstable/ path instead of /releases/)
module.lattice-aws.aws_route_table_association.lattice-network: Creation complete
module.lattice-aws.aws_instance.lattice-coordinator: Provisioning with 'local-exec'...
module.lattice-aws.aws_instance.lattice-coordinator (local-exec): Executing: /bin/sh -c "LOCAL_LATTICE_TAR_PATH=.lattice/lattice.tgz LATTICE_VERSION_FILE_PATH=/Users/pivotal/workspace/diego-release/src/github.com/cloudfoundry-incubator/lattice/aws-terraform-playground/.terraform/modules/d23447c3d09f3485679e8999f1ac3dcc/terraform/aws/../../Version /Users/pivotal/workspace/diego-release/src/github.com/cloudfoundry-incubator/lattice/aws-terraform-playground/.terraform/modules/d23447c3d09f3485679e8999f1ac3dcc/terraform/aws/../local-scripts/download-lattice-tar"
module.lattice-aws.aws_instance.lattice-coordinator (local-exec): v0.2.0-7-g9f930ec
module.lattice-aws.aws_instance.lattice-coordinator (local-exec): Downloading Lattice Release tar from https://s3-us-west-2.amazonaws.com/lattice/unstable/v0.2.0-7-g9f930ec/lattice.tgz => /Users/pivotal/workspace/diego-release/src/github.com/cloudfoundry-incubator/lattice/aws-terraform-playground/.lattice/lattice.tgz
module.lattice-aws.aws_instance.lattice-coordinator (local-exec): Download complete
module.lattice-aws.aws_instance.lattice-coordinator: Provisioning with 'file'...

It seems to work for me as well.

@lexsys27 we're going to close this out.  Let's us know if it's still an issue for you.

Sorry for late answer! We have lost the instance in question and I couldn't manage to reproduce this issue today. So its ok to close.

By the way, it looks like we identified some faulty parsing logic in the terraform scripts that decides to download a release or unstable build that only affected Linux users.  This has been corrected and should be available in the latest unstable build.
https://github.com/cloudfoundry-incubator/lattice/issues/72

Nice to hear it!


chore: Update deps

:tada: This PR is included in version 2.10.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Show total execution time

Add total execution time at the end, so that I know how much time the process took.

Seems to be delivered by de4f8b6.


Can't be present at the same time

Toast pops up at the top, and then there's no way to pop alert

If I understand correctly; multiple entries cannot be displayed in parallel using this library, but SwiftEntryKit offers other solutions. Duplicate of #88 if I understand correctly.


Sign in not working

https://twitter.com/gitmerge/status/1304293817571512320

hi, I made the pull request here: https://github.com/cerebrowallet/cerebro-wallet/pull/16

hi, I made the pull request here: https://github.com/cerebrowallet/cerebro-wallet/pull/16


Support 2 byte reference number in UDH header

Hey there,
We're going to be running some services with this library that are going to be using a fairly large number of binds. With the current 1 byte reference number the chance of a collision would be relatively high and we'd like to use the alternative header with the 2 byte number. For now we've patched the library to add it in but was wanting to ask if you would accept a PR for it?
Cheers,
Lucian

That's cool. I'd be happy to review.

Alright I'll get started on it when I have a chance. Would you be alright with just supporting the 2 byte header or would you like to keep support for both?

If it doesn't break anything else it'd be fine with just 2, otherwise we need both.

Alright I've created the PR, as far as I'm aware both are fully supported in SMPP 3.4 but if you'd prefer I could create another function to use the longer header

Currently I don't have access to anything other than a simulator, so can't really tell whether SMSCs will play nice with this.

We've tested it with the simulator and the SMPP provider we use and both have worked. It's hard to track down whether it's a part of the base SMPP 3.4 spec though.

Thanks! 👍


way to share files between spiders

I've 1000 spiders and all use same files, right now Is there any way to share file?

@tikazyq

I don't think this feature is currently available

启动容器时挂载宿主机目录，宿主机挂载共享的公共存储空间可以实现，只是文件无法基于平台上传、编辑、同步


chore(main): release 0.34.0

:robot: I have created a release beep boop
0.34.0 (2024-12-14)
Features

Updates supported resource types (7) (#829) (c24e7ff)

This PR was generated with Release Please. See documentation.

Summary by CodeRabbit

New Features

Version 0.34.0 released with updates to supported resource types.

Chores

Updated version number across relevant files to reflect the new release.

:robot: Release is at https://github.com/udondan/cfn-teleport/releases/tag/v0.34.0 :sunflower:


ModuleNotFoundError when using tensorflow

VS Code Version: 1.53.2(system setup)
OS Version: Windows-NT x64 10.0.19041
Not sure if this is an extension related error but I looked at previous errors opened and this may be related to #9440 and #116655 . If I run the code at CMD, I can get the tensorflow to work(simple code only) but if I run my code in a python file, that's when I get the ModuleNotFoundError.

Steps to Reproduce:

Use Python 3.8.5

Create virtual environment. Install tensorflow. Tensorflow is successfully installed.

Execute simple python code in CMD and get a successful result.

Execute same line of code in python file and I get the ModuleNotFoundError.

Importing other module seems to be working normally.

Does this issue occur when all extensions are disabled?: Yes/No

/extPython


Unable to get owner of resource object does not deploy sidecar to deployable Kind specified

Expected Behavior
Operator attaches sidecar to deployable Kind in namespace.
Actual Behavior
2023-03-02T20:14:20Z    INFO    could not get owner     {"owner": "&OwnerReference{Kind:MyCustomResource,Name:custom-resource-thing,UID:66dea891-a7c7-482c-9346-a73822381ede,APIVersion:my.example.com/v1alpha1,Controller:*true,BlockOwnerDeletion:nil,}", "err": "Timeout: failed waiting for *v1.PartialObjectMetadata Informer to sync"}
2023-03-02T20:14:20Z    DEBUG   controller-runtime.webhook.webhooks     wrote response  {"webhook": "/mutate-pods", "code": 500, "reason": "", "UID": "be75e6a4-7d54-4d93-ad3f-6e38a72f807a", "allowed": false}

Steps to Reproduce the Problem
Using this AuthProxyWorkload CR, I am using Config Connector but that shouldn't matter here:
{{- range $.Values.cloudSQLInstances }}
apiVersion: cloudsql.cloud.google.com/v1alpha1
kind: AuthProxyWorkload
metadata:
  name: {{ template "my-operator.fullname" $ }}
  namespace: mynamespace
  annotations:
    cnrm.cloud.google.com/project-id: {{ $.Values.projectId }}
    cnrm.cloud.google.com/deletion-policy: abandon
  labels:
    {{- include "my-operator.labels" $ | nindent 4 }}
spec:
  workloadSelector:
    kind: "StatefulSet"
    name: "my-deployment"
  instances:
  - connectionString: "{{ $.Values.projectId }}:{{ $.Values.region }}:{{ .instance }}"
    port: 5432
    privateIP: true
{{- end }}

Specifications
023-03-02T19:47:57Z    INFO    Starting Cloud SQL Proxy Operator
2023-03-02T19:47:57Z    INFO    Version: 0.3.0 Build: 53b97905ee71b2902fcff985a7a5d414164e7323
2023-03-02T19:47:57Z    INFO    Runtime: go1.20.1 linux/amd64

Thanks @spstarr!
It appears that the pod admission webhook is failing improperly while looking for the parents of a pod. This can happen when owners of a pod are Custom Resources. The operator may not have the permissions to read that custom resource.
I'll update the implementation of the webhook so that it looks only for parents that are one of the workloads it is allowed to access: Pod, Deployment, ReplicaSet, DaemonSet, StatefulSet, Job, CronJob

Makes sense, yes, I am using a custom resource here, it spins up StatefulSets


feat: Add metadata parameter to ChromaDocumentStore.

Related Issues

fixes #891

Proposed Changes:

Adds a metadata parameter do ChromaDocumentStore to be passed directly to chroma client’s create_collection method.
How did you test it?
integration tests
Notes for the reviewer
Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I got that far but I wasn’t able to run the tests. I’m getting:
$ hatch run test
========================================== test session starts ===========================================
platform linux -- Python 3.11.9, pytest-8.2.2, pluggy-1.5.0
rootdir: /home/guillaume-pro/Work/Projets/Dev_Haystack/haystack-core-integrations/integrations/chroma
configfile: pyproject.toml
plugins: rerunfailures-14.0, anyio-4.4.0
collected 0 items / 1 error

================================================= ERRORS =================================================
_____________________________ ERROR collecting tests/test_document_store.py ______________________________
ImportError while importing test module '/home/guillaume-pro/Work/Projets/Dev_Haystack/haystack-core-integrations/integrations/chroma/tests/test_document_store.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../../../../.pyenv/versions/3.11.9/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_document_store.py:19: in <module>
    from haystack_integrations.document_stores.chroma import ChromaDocumentStore
E   ModuleNotFoundError: No module named 'haystack_integrations'
======================================== short test summary info =========================================
ERROR tests/test_document_store.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================ 1 error in 1.42s ============================================

I’ve never used hatch and can’t afford to spent more time on this for the moment. I followed the contributing guideline section to install hatch and clone the project and I’m running the tests with hatch run test from the directory integrations/chroma.
Please let me know if the PR is ok as is or how to solve the error above to run the tests.

The tests seem to have passed in cicd though.


About supporting KOR, CHN and TWN

I have decided to research the possibility of porting the exploit to the KOR, CHN and TWN builds of the game and sadly, I have bad news.
Those regions appear to be using a later build of the game in their download play childs (they even noticed the debug symbols in the romfs and removed them). For this reason, the current explotation path is not possible as the memory layout is completely different, so a simple port with different offsets cannot be done and brand new strategy would be needed.
Since there are alternatives to this exploit (and I'm pretty sure there will be more eventually), I've decided NOT to put the effort into porting the exploit as it would require a lot of time I currently not have. :c

OOH, that sucks. 6 months are definitely enough to fix some bugs. Hope alternative route developed later.


TX2 Support

This is not a feature request, but I am curious what work would need to be done to add support for the Jetson TX2? I dug one out of storage recently and would love to run NixOS on it.

We'd have to package Jetpack 4, which has enough differences compared with Jetpack 5 (old kernel, different bootloader) that I opted not to try.  This could possibly be done by adding enough conditionals everywhere to capture the differences between Jetpack 4 and Jetpack 5.  I haven't really looked closely at what would be required for this to happen.
However, when Jetpack 6 is released, it is expected to drop support for Xavier AGX and Xavier NX, and I'd like to keep Xavier AGX/NX support continuing, so at that time, we'll have to have some level of support for multiple versions of Jetpack.

https://forums.developer.nvidia.com/t/jetpack-6-0-production-release-announcement/291709
https://docs.nvidia.com/jetson/jetpack/release-notes/index.html
https://jetsonhacks.com/2024/05/06/jetpack-6-production-release/
A year have passed, what is your current support strategy for Xavier? If two jetpack are to be supported, is there any interest in TX1/2?

i'm interested in helping with tx1 support ! ( i can open a seperate issue for that if desired )


Error when using group parameter

When I run the command:
python retrieve_msgs.py XXXXXXXXX -g '\xf0\x9f\x8f\x89 Fantasy Framily'
I get this error:
Traceback (most recent call last):
File "retrieve_msgs.py", line 234, in
main(args.all, args.dm, args.group, args.csv, args.overwrite)
File "retrieve_msgs.py", line 212, in main
if group not in groups:
NameError: global name 'group' is not defined

Oops that's a bug. Change "group" to "group_name" on line 212 and you should be good. Alternatively, I pushed the fix so you can just pull again.


Can't receive heartbeet when using right-click-to-harvest mods?

Heya,
it seems like if i use mods that let you harvest crops with a right click (such as SimpleHarvest), i don't ever receive any heartbeats. To test this, i went into a creative world, set the randomTick gamerule to 10000, planted a field of beetroots and ran around holding right click with bone meal in my hand. After several minutes i have yet to receive any.
Then i switched to breaking the crops instead and planting seeds again and received heartbeets after a short while. Repeated this a few times to double check.
Is this something that could be added?
A config option to determine the drop chance of heartbeets would be great too.
Cheers,
SC

It sounds like the mods have implemented right click to not listen to the proper events. The way the drops work is by listening to the HarvestDropsEvent, which is the cleanest way to add extra drops. It is pretty easy for a mod to fire that, Tinkers Construct does so in its right click harvest (for kamas and scythes). You should find heartbeets drop from either of those tools.
Looking at the code for SimpleHarvest, they just get the block drops and never fire the Forge event for me to add more drops, so its a SimpleHarvest bug.
I do think the rate being configurable makes sense. Honestly its a bit on the rare side anyways.

Ah that makes sense, thanks. Will report it to the SimpleHarvest mod and see if they wanna change it up. In the meantime i'll try out another harvest mod, thanks!
And yeah i find the heartbeet somewhat rare heh, so the config option would be amazing.

I've made the drop a bit more common and added a config for the drop chance in 3a30b52

@Kiyaku did you end up reporting to SimpleHarvest? I'd like to crosslink the issue so I can keep track of it

@KnightMiner sorry i never did, i kinda stopped doing much with minecraft shortly after, until yesterday (good timing on asking lol). Will check it out today/this weekend and report to SimpleHarvest.

Late, but reported it over here: https://github.com/TehNut/Harvest/issues/12

Closing as the corresponding SimpleHarvest issue is closed.


Feature request: more lines output for errors

Hi, I've run into this a number or times so I'd thought I'd bring it up.
I currently have a parsing error that looks like this:
Uncaught ParseError: Unexpected closing tag at line 164 character 25:
                        </label>
                        ^----

However Ractive counts lines, whether it's by counting from the start of the inline template, or somehow using the position in the HTML doc, the line # never amounts to something meaningful / matching to my template.
Rather than focus on the line number issue (although getting insight on that would be nice too), what would help me is if the error output included more than just one line. I have LOTS of  closing tags in this particular template, so I end up visually inspecting all of them to try to find a parsing error.
If, however, the error output simply included more than one line, like two lines preceding the error, I would probably be able to find that easily in my code.
This has actually come up a lot for me, where I get an error, but the error information doesn't actually provide anything I can use to find the source of the problem. Is a little more verbosity possible?

I was able to figure out after some mathing that the line of the actual error was the position of the template in the HTML doc + the line of the error. Which makes sense, I suppose, but I still think having more lines would still help, since the math may not always be that simple, depending on how the template is imported.

Agree, this is particularly confusing in the templates-in-script-tags case. Perhaps we should have special treatment for those:
Uncaught ParseError: Unexpected closing tag at line 164 (relative to
<script id='template' type='text/html'>) character 25:
                        </label>
                        ^----

A couple of lines of padding either side wouldn't hurt either.


can i get the redisson more detail demo code ;

can i get the redisson more detail demo code ;
or  transform the sleuth tracer to opentracing  tracer.

there is a section in a README and you can look at tests.


Various fixes and small enhancements

This fix some issues that I think are mainly related to changes in dependencies and CFSSL api since this library was initialy written.

I'll fix tests tomorrow

Codecov Report

Merging #20 into master will decrease coverage by 5.71%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage     100%   94.28%   -5.72%
==========================================
  Files          13       13
  Lines         131      140       +9
  Branches        5        8       +3
==========================================
+ Hits          131      132       +1
- Misses          0        8       +8

Impacted Files
Coverage Δ

cfssl/models/certificate_request.py
100% <100%> (ø)
:arrow_up:

cfssl/cfssl.py
85.96% <20%> (-14.04%)
:arrow_down:

I've bring back 100% code coverage ! :)
I think it's ready to merge.
I've made another change today to allow raw API data structures instead of Domain objects (RequestCertificate, Host, SubjectInfo, and so one). They can now be replaced with string or dict, this will also work.

Maybe you could add Python 3 version in .travis.yml as it's not supported.

I've made another change today to allow raw API data structures instead of Domain objects (RequestCertificate, Host, SubjectInfo, and so one). They can now be replaced with string or dict, this will also work.

Good idea; I like.

Maybe you could add Python 3 version in .travis.yml as it's now supported.

I noticed your change in 2a4ed8a and created #21 to make the Travis change. Thanks for that!

Could you perform a pipy release after merge ?

Definitely


[Auto-generated] Update requirements.txt

Update requirements.txt
Automatically created PR from the ci_update_requirements.yml workflow.

Codecov Report

:exclamation: No coverage uploaded for pull request base (ci/dependabot-updates@b0209b7). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             ci/dependabot-updates     #132   +/-   ##
========================================================
  Coverage                         ?   68.62%
========================================================
  Files                            ?       18
  Lines                            ?      494
  Branches                         ?        0
========================================================
  Hits                             ?      339
  Misses                           ?      155
  Partials                         ?        0

Flag
Coverage Δ

pytest
68.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0209b7...fb8fcff. Read the comment docs.


Doc is not up to date

For example, for sign, the website gives this example:
error: Found argument '0x554b6fc625fbea8f56eb56262d92ccb083fd6eaaf5ee9a966eaab4db2062f4d0' which wasn't expected, or isn't valid in this context

USAGE:
    subkey sign [FLAGS] [OPTIONS]

For more information try --help`

but when I run ./target/release/subkey sign --message 0x554b6fc625fbea8f56eb56262d92ccb083fd6eaaf5ee9a966eaab4db2062f4d0
The message flag is mandatory

In the same manner, for verify the doc says $ echo "msg" | subkey verify <signature> <SS58-address> but calling verify --help gives different inputs


Publishing components

OC version: 0.33.22
node: 6.5.0
When trying to publish a new component to a registry, I get  the following error:
An error happened when publishing the component: TypeError: targz.extract is not a function
    at module.exports (/usr/src/app/node_modules/oc/src/registry/domain/extract-package.js:16:9)
    at /usr/src/app/node_modules/oc/src/registry/routes/publish.js:43:5
    at callbacks (/usr/src/app/node_modules/oc/node_modules/express/lib/router/index.js:164:37)
    at options.beforePublish (/usr/src/app/node_modules/oc/src/registry/domain/options-sanitiser.js:14:55)
    at callbacks (/usr/src/app/node_modules/oc/node_modules/express/lib/router/index.js:164:37)
    at param (/usr/src/app/node_modules/oc/node_modules/express/lib/router/index.js:138:11)
    at param (/usr/src/app/node_modules/oc/node_modules/express/lib/router/index.js:135:11)
    at param (/usr/src/app/node_modules/oc/node_modules/express/lib/router/index.js:135:11)
    at pass (/usr/src/app/node_modules/oc/node_modules/express/lib/router/index.js:145:5)
    at Router._dispatch (/usr/src/app/node_modules/oc/node_modules/express/lib/router/index.js:173:5)

The documentation for the package targz (https://www.npmjs.com/package/targz) says to use the function decompress instead of extract
Am I missing something ? Any help appreciated :)

Good catch I think this bug was introduced with 0.33.31 https://github.com/opentable/oc/pull/316
I'll have a look now. Thanks

Hi @matteofigus thanks for the quick response, will this be released as a new version soon ? :)

@debopamsengupta just released this with 0.33.23 ;) Thanks for your help!


Potential Memory Leaks with File Explorer

The FileExplorer::with_theme(theme).unwrap() could leak memory if the theme object or internal state is not properly managed.
Review how FileExplorer handles its internal state and ensure that resources are properly cleaned up when the explorer is closed or destroyed.

I really not sure what you mean by leaking here, the FileExplorer is used throughout the app lifetime, we just control if we render it or not, the object isn't destroyed, so nothing is leaked.

Yes i didnt look at the entire Codebase just the TUI.


Added a Coffee Website

Description
Built a Coffee website template for GSSOC'22
Fixes:  #711
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@harshraj29 do by tonight otherwise I will close this PR.

@harshraj29  navbar toggle is not working in mobile view

@harshraj29

Will fix it by the end of today


about train annotation

Hi Thanks for your work！
But I found there are duplicated anno id in annotations and may cause mismatch between anns and imgs when using coco api
Thanks again

Thanks for spotting this issue! I have updated the file with non-duplicated annotation ids.

Thank you very much
And I have been searching for annotations of modanet dataset for a while,I found that clone from modanet git repo is not usefule,becase annotations were pushed 2 years ago.
Can you share your modanet annotation with me? Thanks again!

hi, we also downloaded modanet annotations from the GitHub repo, so I think what you have is the same as what I have now.

hi, I do not have modanet dataset,
I download recently several times from different device and different account，and each time the same error occurred  which described as  the dataset is overdue
I think the dataset is overdue and i tried to remind author by commit issue, but nobody reply me
So could you please share dataset with me? Thank you very much!


Add DevOps pipeline examples epic to 0.3 milestone in roadmap.md

Description of your changes
add 0.3 DevOps pipeline epic link to roadmap.md
Checklist
I have:

[x ] Run make reviewable to ensure this PR is ready for review.
[ x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant [documentation], [examples], or [release notes].
[ ] Updated the RBAC permissions in [clusterrole.yaml] to include any new types.

[skipci]

@prasek just a reminder that the tag to use to skip builds/tests for doc only changes like this is [skip ci].
Reference: https://github.com/crossplaneio/crossplane/blob/master/INSTALL.md#ci-workflow-and-options


[Support]: How to pin an output?

Support Request

const funcA = async (task: any, item: number): Promise<void> => {
  task.output = 'funcA ' + item
}
const funcB = async (task: any, item: number): Promise<void> => {
  task.output = 'funcB ' + item
}

const tasks = new Listr([
  {
    title: '01',
    task: async (_, task): Promise<void> => {
      for await (const item of [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]) {
        // How can I pin this output to the top or bottom?
        task.output = `Pined: ${item}`

        await Tdelay(1000)
        await funcA(task, item)
        await delay(1000)
        await funcB(task, item)
      }
    },
    rendererOptions: {
      outputBar: 2,
    },
  },
  {
    title: '02',
    task: async (): Promise<void> => {},
  },
])

await tasks.run()

Preflight

[X] Read/Search existing issues and the provided documentation.

Hello @cdwmhcc,
You can use the persistent output option on default renderer to do so.
Please read the documentation on it at here.
Using the outputBar or bottomBar you can choose to keep the last n entries with the default behavior it will only keep the last one.
You can find more about this at here.

Hello @cdwmhcc,
You can use the persistent output option on default renderer to do so.
Please read the documentation on it at here.
Using the outputBar or bottomBar you can choose to keep the last n entries with the default behavior it will only keep the last one.
You can find more about this at here.

You may not understand what I mean. As shown in the example, a certain output is fixed under the same task.
For example, there is such a scene, Only two lines of output are retained, but one output needs to be pined.
rendererOptions: {
  outputBar: 2,
},

const arr = [0,1,2,3,4,5]
let index = 0
for await (const item of arr) {
    index += 1
    // Pin the output until the task is completed.
    task.output = `Completion progress: ${index}/${arr.length}`

    task.output = `In progress: ${item}`
    task.output = 'other output'
}
task.output = 'other output'

aaah i see. sorry for that. in that case with the current structure it is not possible to do so.
if further requests come in like this i can add that as an feature.

Thanks for your quick reply!This is how I currently handle it, but it doesn't look elegant enough.
{
    title: 'task title',
    task: async (ctx, task): Promise<void> => {
        const finished = []
        for await (const item of ctx.items) {
            finished.push(item.name)
            task.title = `task title ${green(finished.length)}/${ctx.apps.length}`
            await useUpdateData(item, { ctx, task })
        }
        task.title = 'task title'
    },
},


Create basic support for a slider

We need a support for giving slide-based presentations directly in GT.

A first presentation using Slider:


Inaccurate translation for "Next" in Chinese

Describe the bug
Inaccurate translation for "Next" in Chinese
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#editor
2.Switch language to Chinese
3.Tutorials----->Chase the Pizza---->Blocks Start Tutorial
Expect behavior
“下一步“ would be accurate.
Actual behavior
Inaccurate translation for "Next" in Chinese. “下一步“ would be more accurate than "下一...".

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.8.9
3.Microsoft MakeCode version: 7.4.17

@Sheila111 does this bug still repro?

@abchatra  Still repro on version 1.10.28


Updated object_sim with an example of pick_place_v0 using google_objects

The changes made are an example on how to use google_objects using arms env

@ShahRutav  -- Lets schedule this feature for v0.5 release. We will merge this post v0.4 release to avoid any unnecessary hickups for the upcoming release.

The codebase has been moved here


my panel is displayed on the nodes

What platform were you using when you found the bug?

React Flow / Svelte Flow version: React Flow
Browser and version: Google Chrome
OS and version: Linux ubuntu

Live code example
No response
Describe the Bug
I faced a bug when I added to the panel display on the nodes but I want to display nodes after the panel
Steps to reproduce the bug or issue

Expected behavior
I want to display nodes after the panel I don't want to use panel space search, status and button
Screenshots or Videos

Additional context
No response

What is the problem exactly? Your issue description isn't clear enough and doesn't, at least to me, communicate what the exact issue is.
Please provide a proper reproduction of the problem. You didn't provide any code, nothing, only a screenshot. You can't expect us to know what you've built and what the problem is.

I'm encountering a bug where my nodes are being displayed behind the search input, status dropdown, and recent button. I want the nodes to be displayed after these elements. Can you help me resolve this issue?
<ReactFlow
nodes={filteredNodes}
edges={visibleEdges}
onNodesChange={onNodesChange}
onEdgesChange={onEdgesChange}
onNodeClick={onNodeClick}
proOptions={proOptions}
nodeTypes={nodeTypes}
nodesDraggable={true}
nodesConnectable={false}
className={${FlowStyle.viewport}}
attributionPosition="top-left"
zoomOnDoubleClick={true}
elementsSelectable={true}>

<MiniMap
nodeColor={(n) => n.data.color}
nodeStrokeWidth={3}
zoomable
pannable
/>

  </ReactFlow>

  import React from 'react';

import { Form } from 'react-bootstrap';
import { Panel } from 'reactflow';
import HistoryButtons from '../networkMap/HistoryButtons';
interface NodeSearchType {
onSearchChange: (search: string) => void;
onStatusChange: (status: string) => void;
}
const NodeSearchPanel = ({ onSearchChange, onStatusChange }: NodeSearchType) => {
return (
<Panel position="top-left" style={{ display: 'flex', alignItems: 'center', gap: '10px' }}>
<Form.Control
placeholder="Filter by Name..."
onChange={(evt: { target: { value: string } }) => onSearchChange(evt.target.value)}
style={{ width: 160 }}
/>
<Form.Select
onChange={(evt: { target: { value: string } }) => onStatusChange(evt.target.value)}
style={{ width: 140 }}>
All Status
Ready
Pending
Running
Succeeded
Failed
Unknown
</Form.Select>

);
};
export default NodeSearchPanel;

I want the nodes to be displayed after these elements.

What is that supposed to mean? Your problem description is still vague and it's not clear what you want to achieve here and what your issues are, what you tried and what challenges you encountered.
Also the <Panel> component is rendered on top of the viewport. That's how it works.

Please re-open with a codesandbox https://new.reactflow.dev. A bunch of unformatted code is not helpful at all.


Only contribute to resources defined in merge target

What does this PR do?
This PR modifies the container contribution functionality for resource requirements.
With this change, the merge target's resource requirements will be summed with contribution resource requirements only for resource limits & requests that are already set in the merge target. For example, if the merge target does not set a CPU request and a container contribution does set a CPU request, the resulting CPU request of the merge target will remain unset.
This PR also moves functions related to corev1.ResourceRequirements into /pkg/library/resources/.
What issues does this PR fix or reference?
Fix #1056
Is it tested? How?
I added an automated test for all 4 types of container contributions (normal, spec, implicit and implicit-spec) which verifies that resource requirements are only summed if they are defined in the merge target component.
Additionally, the Che-Code container contribution test cases had to be modified by removing the expected CPU limit, CPU request and Memory Request as they are no longer contributed by the container contributions (since the tools container only defines a Memoy Limit)
Verify #1056 is fixed

Install DWO with the changes from this PR
Apply the Che-Code sample kubectl apply -f ./samples/code-latest.yaml -n $NAMESPACE
Check the spec of the code-latest workspace (kubectl describe code-latest -n $NAMESPACE) and ensure the dev container component does not have its CPU Request, CPU Limit, Memory Request or Memory Limit set.

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

@l0rd you raise an important point, and I think there is room for improvement here in the future. Prior to this PR, there were two competing elements -- the default limits/requests used for containers in DWO:
resources:
  limits:
    memory: 128M
  requests:
    memory: 64M

and the issue being fixed here, which is that we were adding any limits/requests in contributions even if there was nothing to add it to (i.e. we were interpreting an unset CPU limit as "0" CPU, and adding to that). With this PR, we've addressed one side of the issue (contributions can restrict resources unexpectedly) but we should still address the other side (defaults can restrict resources semi-unexpectedly)
I think one way to improve what we've got here would be

Make container default resources configurable (via DWOC), use these values for containers that do not set a field
Use this default as the base to add contributions' requests/limits to if a field is unset

I'll try to put together a quick PR to test this as a solution and we can discuss the approach there.

I think one way to improve what we've got here would be
1. Make container default resources configurable (via DWOC), use these values for containers that do not set a field

2. Use this default as the base to add contributions' requests/limits to if a field is unset

I'll try to put together a quick PR to test this as a solution and we can discuss the approach there.

This sounds like a good idea to me :+1:
If you get caught up with other tasks and want me to give a try at this, let me know :)


[FR] Add optional mDNS to docker image

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
Autodiscovery of the inventree server is not possible; so you need to set up the server on every device manually
Suggested solution
Autodisvocer via mDNS/DNS-SD;  We could include Avahi in the docker image and advertise the service.
This is also possible without d-bus.
Describe alternatives you've considered
There are other discovery solutions like preferred hostname, SNMP discovery, ... - most of them are for enterprises and not applicable to simple networks
Examples of other systems
No response
Do you want to develop this?

[X] I want to develop this.

mDNS is also implemented by Bonjour


Example: https://play.golang.org/p/zw76XV6YIb
On one hand this seems like well-defined behavior -- the option causes the parser to do what it's supposed to: eat white space. On the other, one would assume that a field's delimiter is not a part of the field -- it's a separator that demarcates two fields.
Right now the docs say:
If TrimLeadingSpace is true, leading white space in a field is ignored.
Since I assume changing the behavior of the CSV parser isn't backwards compatible, I think it'd be beneficial to add to the documentation with something like:
If TrimLeadingSpace is true, leading white space in a field is ignored. If the delimiter is white space then TrimLeadingSpace will trim the delimiter.
(Perhaps it'll save some of us who like to program while tired some grief in the future.)

A cursory reading of section 2 of RFC 4180 seems to indicate that delimiters are not part of a field:
Within the header and each record, there may be one or more
fields, separated by commas... The last field in the
record must not be followed by a comma."

Also, the ABNF grammar in section 2.7 also seems to indicate that delimiters are not a part of the field.

A fix for this issue (other than changing the documentation) would be to add this to line 257:
257,258c257
< 	for err == nil && r.TrimLeadingSpace &&
< 		r1 != '\n' && unicode.IsSpace(r1) && r1 != r.Comma {
---
> 	for err == nil && r.TrimLeadingSpace && r1 != '\n' && unicode.IsSpace(r1) {


Anti-aliasing

Hi,
Is the "anti-aliasing" option really working ?
I'm drawing players bones and, it doesn't seems to be "corrected".
this.Device           = new D2DDevice(new DeviceOptions()
{
	AntiAliasing  = true,
	Hwnd          = this.Window.WindowHandle,
	MeasureFps    = true,
	MultiThreaded = false,
	VSync         = false
});

AntiAliasing is only turned on for text.
there is a side effect where antialiasing in per primitive mode changes colors and pixels to make them look smooth.
Your red color (0xFF) would more likely look like (0x77). thats why i removed it

Ah, that's sad 😞
Any other way to fix that, even if it's "hacky" ?


strain: update tests

see #414

further info in commit messages

I've updated the PR after @ferhatelmas review


Refactoring towards GPU support

Overview
This PR lays the foundation for adding GPU support to Datashader.  It contains the refactoring portion of https://github.com/pyviz/datashader/pull/793, without adding the CUDA specific code. After this PR is reviewed and merged, I'll open another PR that adds the cuda support on top of this.
Fix
While refactoring, I found the cause of #792, which is fixed in 30a2ae2.  I think we could cherry pick this commit into a separate PR if folks would rather it be separated from this PR.
Changes

Move the data library specific modules (pandas, dask, xarray) under a new data_libraries  package. When cudf support is added, a new module will be added here. (258ceca )
Replace the former Glyph._compute_x_bounds and Glyph._compute_y_bounds methods with a single Glyph._compute_bounds method.  The old methods assumed the input was a numpy array. The new method checks if it is a numpy array or a pandas series. When cudf is added, this method will also check if the input is a cudf.Series object. (40c3b61 )
Refactor reduction methods to have a separate "append" method for the following cases: No reduction column is used (e.g. ds.count()), an integer reduction column is used (e.g. ds.count('int_column')), a float reduction column is used (e.g. ds.count('float_column')).  This is needed because numba's cuda mode does not seem support default arguments, and it doesn't allow the use of isnan on integer columns. (7b31140)
Extract use of np.interp in preparation for swapping in a different implementation for cudf.ndarray objects. (63ec2fd)
Explicitly cast result of np.nonzero to an integer as the cudf equivalent results in scalar array instead. (cc3ff21)
Various cleanup of the _interpolate function, which is called by shade (7a10a49)

Unify int/float/bool logic paths:
Add masked_clip_2d function that clips an array of either float or int values. There will be a cupy specific implementation of this later.
Copy input data once and perform offset in-place
construct uint32 view once at the end of function rather than in branches
Don't interpolate r/g/b unnecessarily when a single color is passed as cmap.

Isolate pandas specific code in dshape_from_pandas_helper in preparation for supporting cudf: cca1b87
Add internal _sum_zero reduction to compute sum from an array of zeros.  The standard sum reduction starts with an array of nans and the append operation has a different logic branch depending on whether a pixel starts as nan.  This approach is not compatible with the cuda atomic operations.  For cuda, sum will be implemented by combining _sum_zero with any. (cf7f5c8)
Refactor points, line, and area rendering to extract the inner loop as a cuda compatible function. (b57e0a9)
Expand the bounds and vt tuples in the signatures of numba functions as numba.cuda.jit doesn't seem to support tuples. (b57e0a9, 7fe52db).
Convert tuples of columns passed to numba functions into 2D arrays as as numba.cuda.jit doesn't seem to support tuples. (b57e0a9).
Convert from numpy.log and numpy.isnan to math.log and math.isnan for use in numba functions because numba.cuda.jit doesn't support the numpy versions. (e073961)
parameterize relevant test functions over data frame and array types. This will make it easier to add tests for new data frame (cudf) and array (cupy) types. (5e1d180)
Add custom test equality assertion functions for xarray and pandas. These will provide a central place to handling of numpy-like (e.g. cupy) and pandas-like (e.g. cudf) objects. (45a979d)
Convert the _bases and _temps properties of Reduction objects into methods (_build_bases, _build_temps). This way we can pass configuration options to them (like whether or not to operate in cuda mode). (517fc97)

I think I've figured out a way to support line/area with axis=0 with cuda. So I'm going to do a bit more line/area refactorting on this PR.

Ok, I did a bit more refactoring of lines in d7f3650 and area in b5dbf1d.
The goal was to make it possible to support parallelization with axis=0.  The reason that this was not as straightforward as axis=1 is because the prior logic to calculate breaks due to nans and out-of-bounds segments was sequential in nature.
I also managed to eliminate a fair amount of code duplication by having the draw_segment and draw_trapezoid functions input values in data, rather than pixel, coordinates. These functions now perform their own skipping/clipping logic, so this logic is no longer duplicated in every line line/area rendering function.

Thanks, I've done several benchmarks and I'm seeing equivalent performance (with +-5%). e.g., for 10 million points with count aggregation

points: From 65.2 ms -> 64.3 ms (after)
line: From 256 ms -> 268 ms (after)
area: 1800 ms -> 1750 ms (after)

Looks great, thanks!!


Add script methods at a general level

Question
Answer

Assue or Enhancementevel
Add script methods at a general level

Laravel Version
8.x

Project Version
3

Current Behavior
I install:
https://github.com/jeroennoten/Laravel-AdminLTE/wiki/Installation
I need to edit the main layout of adminlte, because I need a script method to run in all views.
but I can't find the main layout to add my script methods.
"@extends ('adminlte :: page')"
when i run the command
"php artisan vendor: publish --provider =" JeroenNoten\LaravelAdminLte\ServiceProvider " --tag = views"
this shows me:
"Unable to locate publishable resources."
I tried running the command:
php artisan adminlte: install --type = full
and I select all the options to overwrite all "yes", "yes", "yes" ...
but when I run the command:
php artisan adminlte: status
everything installed, except what I think I need:
main_views | The default package main views | Not Installed | false |

I need to add 3 js methods in all the views, and I don't want to repeat them for each view, this is how I would like to add it in the main layout "@extends ('adminlte :: page')" That means that I want it in the "page", so that these methods work in all views.
example of my methods:
<script>
    @if (session('update'))
        Swal.fire({
            position: 'center',
            icon: 'success',
            title: 'updade ok xxxxx',
            showConfirmButton: false,
            timer: 1500
        })
@endif
</script>

<script>
    @if (session('delete'))
        Swal.fire({
            position: 'center',
            icon: 'success',
            title: 'Delete ok  xxxx',
            showConfirmButton: false,
            timer: 1500
        })
        @endif
</script>

What could I do? Thank you very much to anyone who can help me.
Steps to Reproduce

install laravel:
"laravel new project"

composer require jeroennoten/laravel-adminlte

composer require laravel/ui

php artisan adminlte:install --type=full

php artisan adminlte:status

Please try following:
php artisan adminlte:install --type=full --with=main_views
The main views are not included with the install command.

@hernandoglobal To install main_views you need to use php artisan adminlte:install --only=main_views, read the Artisan Commands Section to check how use the commands.
However it will be better if you include your custom js file as a plugin, see the Plugins Section for that...
'plugins' => [
    /* Other plugins definition... */
    ...
    'MyCustomFiles' => [
        'active' => true,
        'files' => [
            [
                'type' => 'js',
                'asset' => true,
                'location' => 'vendor/custom-files/my-script-1.js',
            ],
            [
                'type' => 'js',
                'asset' => true,
                'location' => 'vendor/custom-files/my-script-2.js',
            ],
        ],
    ],
]

Then you can place your custom script file into public/vendor/custom-files/ folder...

Thanks to all, after several days, and many tests I have been able to do it, with the command:
php artisan adminlte:install --type=full --with=main_views
and I also checked that it can be done with the command:
php artisan adminlte:install --only=main_views
Shidersz
I can't use it as a plugin, in fact all this was to use some conditionals from the Sweetalert2 plugin, but I didn't want to repeat the conditions every time, for every view.
Thanks to all.


constraint_lookup_index: Assertion `index < con->root->count' failed.

This happened on c99e07777ec0c804609a4e44bea507a86ab598d3 (one commit behind the head of master as of this filing).
I can't recreate it. I've never seen it before or after.
$ sudo ./zmap -i eth1 --probe-module=dns --output-fields=* --target-port=53 --output-module=json --probe-args=MX,eecs.berkeley.edu <IP_ADDRESS>
Nov 17 20:58:08.830 [WARN] zmap: too few targets relative to senders, dropping to one sender
Nov 17 20:58:08.831 [INFO] zmap: output module: json
 0:00 0%; sent: 0 0 p/s (0 p/s avg); recv: 0 0 p/s (0 p/s avg); app success: 0 0 p/s (0 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.00% app hitrate: 0.00%
zmap: lib/constraint.c:231: constraint_lookup_index: Assertion `index < con->root->count' failed.

(Minor editing to remove machine name and path.)

I sporadically see this error too... on zmap 1.2.1 (the one in yum repos for CentOS 7.x).

@dadrian Do you have any ideas what's going on here? Is there a fix, or this a bug we can't really do anything with?

I believe we fixed this.

Hello,
I have still this issue on zmap 2.1.1. It happens sporadically.
The command used:
$ zmap -p 42 {IP}/32 -f saddr -o scan_port_42 -b blacklist_zmap.tmp
Sep 09 11:23:18.419 [WARN] zmap: too few targets relative to senders, dropping to one sender
Sep 09 11:23:18.653 [INFO] zmap: output module: csv
zmap: /build/zmap-qmPEEi/zmap-2.1.1/lib/constraint.c:231: constraint_lookup_index: Assertion `index < con->root->count' failed.
Aborted (core dumped)

With the same IP, sometimes it does work, sometimes it doesn't... I don't understand why...
Some others (maybe useful) info:
I runned this on a machine with Ubuntu 16.04.1 LTS (x86_64 GNU/Linux) with the kernel version: 4.4.0-34-generic
Regards,

I have the same.

I have also observed it :(


[💡 FEATURE REQUEST]: Improve clarity of worker errors when starting a server

Plugin
Server
I have an idea!
When my newbie was getting used to the RR, some problems arose that were difficult to diagnose.
Let's say i have typical RR config for production usage for Logs plugin:
logs:
    level: warn
    mode: production

and also a broken worker with a syntax error (for example).
Then the output will only include the EOF error without any details.
handle_serve_command: Function call error:
2024-10-06T18:27:36.449763889Z 	serve error from the plugin *http.Plugin stopping execution, error: static_pool_allocate_workers: WorkerAllocate: EOF

A newbie has questions: why the server won't start and what is EOF?
The problem is that errors from the worker only come from the debug level. In production mode, it is difficult to immediately understand what happened. EOF is too unclear a reason. Also, an error in the EOF text was sent to the browser without any details.
What if RR write a more meaningful error message right away? It seems that the worker startup error should be more understandable and the error level should be.
Another small question. Do RR really use STDERR to exchange data frames?
https://docs.roadrunner.dev/docs/php-worker/worker#communication-methods

Hey @Kaspiman 👋
Unfortunately, it is not possible to determine the exact error, I understand that EOF is too general error, but usually, it points to some error with the PHP file, e.g.: no such file for example or some garbage data in the process pipes which prevents RR to allocate a PHP process. The case is, RR does not know about PHP at all. From the RR perspective, it is just a child process and if the runtime can't provide additional information, RR unfortunately can't obtain such an info by itself somewhere.

Also, an error in the EOF text was sent to the browser without any details.
This is kind of strange, because EOF usually indicates a startup problem. When RR is running, this is highly unlikely to see this error. If you don't move the worker and send a ./rr reset command.

Another small question. Do RR really use STDERR to exchange data frames?

RR uses stdin/stdout to communicate with the PHP process. STDERR used to obtain logs/diagnostic information from the PHP process.

It would be nice if you attach to a ticket some examples of PHP workers + actual error messages + desired error messages.

Use Case #1:
Any broken php worker, for example with syntax error.
http:
    pool:
        num_workers: 1

logs:
    level: warn

Actual error:
[INFO] RoadRunner server started; version: 2024.2.1, buildtime: 2024-09-12T16:25:02+0000
[INFO] sdnotify: not notified
handle_serve_command: Function call error:
serve error from the plugin *http.Plugin stopping execution, error: static_pool_allocate_workers: WorkerAllocate: EOF

Desired error message with error level: Failed to allocate worker, check application logs with stacktrace from PHP.
Now this trace is visible only from the info level.
Logs with info level and broken php worker:
[INFO] RoadRunner server started; version: 2024.2.1, buildtime: 2024-09-12T16:25:02+0000
[INFO] sdnotify: not notified
INFO    server          Warning: Undefined variable $worker in /var/www/html/worker.php on line 20
 Fatal error: Uncaught TypeError: Spiral\RoadRunner\Http\PSR7Worker::__construct(): Argument #1 ($worker) must be of type Spiral\RoadRunner\WorkerInterface, null given, called in /var/www/html/worker.php on line 20 and defined in /var/www/html/vendor/spiral/roadrunner-http/src/PSR7Worker.php:42
 Stack trace:
 #0 /var/www/html/worker.php(20): Spiral\RoadRunner\Http\PSR7Worker->__construct(NULL, Object(Nyholm\Psr7\Factory\Psr17Factory), Object(Nyholm\Psr7\Factory\Psr17Factory), Object(Nyholm\Psr7\Factory\Psr17Factory))
 #1 {main}
   thrown in /var/www/html/vendor/spiral/roadrunner-http/src/PSR7Worker.php on line 42

 handle_serve_command: Function call error:
     serve error from the plugin *http.Plugin stopping execution, error: static_pool_allocate_workers: WorkerAllocate: EOF

Basically, we need to log the worker output at the error level unless otherwise stated.

Use Case #2:
debug = true and any broken php worker, for example with syntax error.
logs:
    level: warn

http:
    pool:
        debug: true

Logs:
[INFO] RoadRunner server started; version: 2024.2.1, buildtime: 2024-09-12T16:25:02+0000
[INFO] sdnotify: not notified
ERROR	http        	execute	{"start": "2024-10-07T07:32:12+0000", "elapsed": 9, "error": "EOF"}
ERROR	http        	execute	{"start": "2024-10-07T07:32:12+0000", "elapsed": 9, "error": "EOF"}

The server has started, and when processing one request, two* EOF errors are written to the logs.
Error 500 and EOF message in browser.
Desired error message in logs with error level:Failed to allocate worker, check application logs with stacktrace from PHP.
Desired error message in browser: Failed to allocate worker, check application logs with/without (idk) stacktrace from PHP.

Is it possible to rework this kind of error?
Typical error:
 handle_serve_command: Function call error:
     serve error from the plugin *http.Plugin stopping execution, error: static_pool_allocate_workers: WorkerAllocate: EOF

It contains a lot of information that is more useful to the developer than to the user.
Possible rework:
Error from the <PluginName> plugin, message: Failed to allocate worker, check application logs, code: static_pool_allocate_workers, stacktrace: ...

Ok, so, if I understand correctly, the problem is in log level, because under the info log level you may clearly see what is the actual error.
The error about Function call comes from the Endure, but definitely it is possible to add some link to docs or guideline of what to do next to see the error. Will add this to 2024.3 milestone.

The actual problem here, is that we don't have a log level from PHP. Thus, all worker-related messages (RR can't distinguish between a just message and an error message, from the RR POV all that is text) are logged under the info log level. And when you use warn, obviously, all info messages are not displayed (and this is the problem).
A real solution I want to see here is a some configuration exchange from the PHP worker side to RR. Like in the Temporal plugin. RR on the init stage pings all workers, so it would be nice to exchange a configuration info between RR <-> PHP. Logging configuration is the first and obvious step.

Is it possible to read all logs from an application with an error level if a specific level is not specified? This will also help in other cases, for example, when the output is erroneously sent to stdout.

Is it possible to read all logs from an application with an error level if a specific level is not specified?

This is not a proper solution to a problem. Worker's log level should be passed from the PHP Worker, otherwise - that particular worker should be treated as invalid and re-created.
If you would like to collaborate and create a PHP part, I would be happy to provide a protocol specs and RR implementation.

This problem may not only be in the worker. What if someone has their own worker, and not the one offered by Spiral?
What if it is a script launched in the Service plugin or in the server.on_init section? We won't be able to set up a worker there, it simply doesn't exist.
I think it's possible to interpret any output from the worker as an error. This will force people to catch errors and use the Logs plugin.

We do not support third-party workers. But all needs should be covered by the well-defined protocol. And from this point it doesn't actually matters, who created a worker.

I think it's possible to interpret any output from the worker as an error

This is possible, but logs are a very sensitive topic. And this topic should be well-discussed.

So, let's discuss with community. Discord or https://github.com/orgs/roadrunner-server/discussions?

You may create both, discussion on the GitHub and create a topic in the Discord forum.

The actual problem here, is that we don't have a log level from PHP. Thus, all worker-related messages (RR can't distinguish between a just message and an error message, from the RR POV all that is text) are logged under the info log level. And when you use warn, obviously, all info messages are not displayed (and this is the problem).
A real solution I want to see here is a some configuration exchange from the PHP worker side to RR. Like in the Temporal plugin. RR on the init stage pings all workers, so it would be nice to exchange a configuration info between RR <-> PHP. Logging configuration is the first and obvious step.

Could you please provide more accurate description of that exchange? What should do PHP worker in startup phrase?

Just a structure with some fields. Like version, desired log level and that's it at the moment I guess. You may take a look at the temporal PHP worker and worker info structure it sends to Go.


Merge entity ids into execute methods.

Get rid of cursor.execute_entity_ids and client._execute_entity_ids, and make these just cursor.execute and client._execute respectively.
This change will require some google-specific rewiring changes.

@alainjobart

LGTM You can keep the old version too if you want to do the import, then in a different CL do the fix


jvm monitoring disabled

Description
JVM monitoring disabled
Fixes #926
Type of Change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Automated Testing
Not applicable
Manual Scenario
Run tests as usual
Checklist (remove irrelevant options):

[ ] Comment appropriate section in the script
[ ] Remove javaagent option from GRADLE_OPTS
[ ] Run tests as usual

Also container monitoring commented. We don't use it so it's better to disable it as well


Check & fix Group entity and repository

https://github.com/toggl/toggl_api_docs/blob/master/chapters/groups.md

Groups are moved into /organizations/<id>/ and /organizations/<id>/workspaces/<id>/ paths, so refactoring is required


chezmoi: 2.0.12 -> 2.0.13

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/twpayne/chezmoi/releases.
meta.description for chezmoi is: "Manage your dotfiles across multiple machines, securely"
meta.homepage for chezmoi is: "https://www.chezmoi.io/"
meta.changelog for chezmoi is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/n31bm41n6is88k059n7fwy0gnl5pz7v8-chezmoi-2.0.13/bin/chezmoi passed the binary check.

1 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 2.0.13 with grep in /nix/store/n31bm41n6is88k059n7fwy0gnl5pz7v8-chezmoi-2.0.13

found 2.0.13 in filename of file in /nix/store/n31bm41n6is88k059n7fwy0gnl5pz7v8-chezmoi-2.0.13

directory tree listing: https://gist.github.com/45bd0a85ad49cde29ebc9abe9dba1714

du listing: https://gist.github.com/0be6460673e0cc97e65025c43a37d4c1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
chezmoi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n31bm41n6is88k059n7fwy0gnl5pz7v8-chezmoi-2.0.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A chezmoi https://github.com/r-ryantm/nixpkgs/archive/7abfd08f2e28a6ff0b66a7ad8d7e59f07c59363f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n31bm41n6is88k059n7fwy0gnl5pz7v8-chezmoi-2.0.13
ls -la /nix/store/n31bm41n6is88k059n7fwy0gnl5pz7v8-chezmoi-2.0.13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

chezmoi

Maintainer pings
cc @jhillyerd @kalbasit for testing.

Result of nixpkgs-review pr 124718 run on x86_64-linux 1

1 package built:

chezmoi


Update Clean grammar

This isn't necessary. ;-) Linguist grammars are updated automatically with every release, and changes won't show on the site until then. So even if we accepted this now, there'd still be no visible effect. =)

Ah, I see, thanks :)


[iOS] build failed with travis

I guess React Native can't run tranforming success in travis ios env, but I can not get the reason for too many days.
This is the travis/log.This is the repo.
 "react-native": "~0.19.0"

xcodebuild clean build -scheme autoresponsive_react_native_sample -configuration Debug -sdk iphonesimulator9.3 CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY=""

Tests on Travis CI are currently passing on master: https://travis-ci.org/facebook/react-native/branches so I believe the problem is with your own repo and not react-native.