error: object jblas is not a member of package org

I have done all the options to add classpath for jblas, but still getting this error. Could you please help me in this regard?

Hi srlaghm, sorry for the late reply, does the problem persist?


Replace docker for building images with something daemonless

In our current setup we use Docker to build images this has some drawbacks like in our testing scenario for containerd we install containerd from the official resources but this installation (for some reasons) is in conflict with Docker. Also I currently don't see the need to actually use Docker.
My suggestion would be something like img: https://github.com/genuinetools/img which can be downloaded as binary and than be used to build/login and push the image to a registry.

I will try to find some time to fix this since this will block my current PR.

If we change to minikube with the docker driver we can drop close this isssue


 Probably this is because in the build.yml
on:
push:
pull_request
is included. This uses a lot of computational power. @exactly-one-kas  do you think we can do the action only for pushes on master or do you need it for something else?
on:
push:
"master"
pull_request

I don't need a build on every push. If necessary, I can just manually start the pipeline with the workflow_dispatch trigger.


Add InterstellarFuelSwitch

I'm setting this up for FreeThinker on the KSP forums.

Not really sure why there is a merge conflict here... not editing any other files.

It already exists.

Whoops, haha!
Either way, it needs dependencies set up and the like. I'll resubmit my PR.


Github is displaying incorrect language project

After merge two branches, my project changed the name of the programming language Ruby to Javascript...
Why?
As you can see, there are more files/code wrote in Ruby rather than Javascript.
https://github.com/roadev/GearApuestas2/search?l=ruby

Hi @roadev - these large JavaScript files are skewing the stats for your project.

You can learn how to ignore these files using the Linguist overrides here


[markFeatureWriter] Duplicate mark classes data

Running the script generates the expected markclasses.fea and mark.fea files, but it also prepends the content from the markclasses.fea file to the mark.fea file, which makes makeOTF unhappy, and it will fail to build if you include markclasses.fea.

My bad, I see it’s a default in the script and my markclasses.fea file was outdated. Never mind!


Improve loading config files

Closes #4370.

failed due to YAML serialization on 1.8.7 being wonkey -- will improve the regexp

Should pass now

@indirect r?

@indirect ping

@homu r+

:pushpin: Commit 4d2e711 has been approved by segiddins

:hourglass: Testing commit 4d2e711 with merge 0446fa9...

:sunny: Test successful - status


Rename the context object from DetailView class.

The detail.html received an object 'question' via context, so we needed to rename the default object from DetailView class to 'question'. Before it was getting an error.
    # file_name: polls/views.py
    context_object_name = 'question'

This works for me as-is. DetailView adds that object to the context without this change.

Without this line I get this error.

q_id may be a typo in your project. This is usually question_id.

I'm using q_id instead of question_id, that is why I don't think is a typo.
In my project I used:
# file_name: polls/views.py
context_object_name = 'q'

And this is my detail.html

{{ q.question_text }}

{% if error_message %}
{{ error_message }}
{% endif %}

<form action="{% url 'polls:vote' q.id %}" method="post">
{% csrf_token %}
{% for choice in q.choice_set.all %}
    <input type="radio" name="choice" id="choice{{ forloop.counter }}" value="{{ choice.id }}" />
    {{ choice.choice_text }}

{% endfor %}
<input type="submit" value="Vote" />
</form>

Anyway, thank you for your attention to this matter.
:+1:


Can't generate mocks for rails Concerns

I'm using active_mocker version 2.1.3. I ran rake active_mocker:build for all of my models, and the two concerns I have failed to get mocked.
One concern, called RecordChanges is used by a model called Booking. The top of my generated file booking_mock.rb looks like the following:
require("active_mocker/mock")
class BookingMock < ActiveMocker::Base
  created_with("2.1.3")
  # _modules_constants.erb
  prepend(RecordChanges)  # OFFENDING LINE
  #_class_methods.erb
  class << self
  ... # more code here

The mention of RecordChanges causes the error:
Unable to autoload constant Concerns::RecordChanges, expected ~/myproj/app/models/concerns/record_changes.rb to define it

Even though it's declared right there:
# app/models/concerns/record_changes.rb
module RecordChanges
  extend ActiveSupport::Concern
  # ...
end

Why is active_mocker having such a hard time auto-loading / generating mocks out of concerns? I've managed to generate mocks just fine for other models.
Failed models: Concerns::Approval, Concerns::RecordChanges
2 mock(s) out of 21 failed.
To see more/less detail set error_verbosity = 0, 1, 2, 3

Ah hah. I found that RecordChanges was declared as a concern, which active_mocker failed to create a mock of.

@zeisler Any ideas?

Any included modules are assumed to be mock compatible code if is not then you may need to disable that feature with this line.
ActiveMocker::Config.disable_modules_and_constants = true
It seem like you are having a more specific issue, I will look into to it, but for now that line should get you past the error.

I've attached the full stack trace if it helps here:
Concerns::Approval has the following errors:
Unable to autoload constant Concerns::Approval, expected ~/myproj/app/models/concerns/approval.rb to define it
warn
Unable to autoload constant Concerns::Approval, expected ~/myproj/app/models/concerns/approval.rb to define it
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:495:in `load_missing_constant'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:184:in `const_missing'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:276:in `const_get'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:276:in `block in constantize'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:259:in `each'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:259:in `inject'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:259:in `constantize'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/core_ext/string/inflections.rb:66:in `constantize'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:38:in `get_model_const'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:17:in `block in call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `each'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/public_methods.rb:30:in `create_mocks'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/task.rake:12:in `block (2 levels) in <top (required)>'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `call'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `block in execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
~/.rvm/rubies/ruby-2.2.4/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:172:in `invoke_with_call_chain'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:165:in `invoke'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:150:in `invoke_task'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block (2 levels) in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:115:in `run_with_threads'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:100:in `top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:78:in `block in run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:176:in `standard_exception_handling'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:75:in `run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/bin/rake:33:in `<top (required)>'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `load'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `<main>'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `eval'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `<main>'
LoadError
Concerns::Approval has the following errors:
undefined method `to_a' for false:FalseClass
warn
undefined method `to_a' for false:FalseClass
~/.rvm/gems/ruby-2.2.4/gems/dissociated_introspection-0.4.1/lib/dissociated_introspection/ruby_class.rb:34:in `class_name'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/parent_class.rb:57:in `class_name'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/parent_class.rb:16:in `call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/mock_creator.rb:91:in `verify_class'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/mock_creator.rb:26:in `create'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:53:in `create_mock'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:24:in `block (2 levels) in call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:22:in `open'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:22:in `block in call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `each'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/public_methods.rb:30:in `create_mocks'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/task.rake:12:in `block (2 levels) in <top (required)>'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `call'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `block in execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
~/.rvm/rubies/ruby-2.2.4/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:172:in `invoke_with_call_chain'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:165:in `invoke'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:150:in `invoke_task'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block (2 levels) in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:115:in `run_with_threads'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:100:in `top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:78:in `block in run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:176:in `standard_exception_handling'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:75:in `run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/bin/rake:33:in `<top (required)>'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `load'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `<main>'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `eval'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `<main>'
NoMethodError
Concerns::RecordChanges has the following errors:
Unable to autoload constant Concerns::RecordChanges, expected ~/myproj/app/models/concerns/record_changes.rb to define it
warn
Unable to autoload constant Concerns::RecordChanges, expected ~/myproj/app/models/concerns/record_changes.rb to define it
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:495:in `load_missing_constant'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:184:in `const_missing'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:276:in `const_get'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:276:in `block in constantize'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:259:in `each'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:259:in `inject'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/inflector/methods.rb:259:in `constantize'
~/.rvm/gems/ruby-2.2.4/gems/activesupport-4.2.5/lib/active_support/core_ext/string/inflections.rb:66:in `constantize'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:38:in `get_model_const'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:17:in `block in call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `each'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/public_methods.rb:30:in `create_mocks'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/task.rake:12:in `block (2 levels) in <top (required)>'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `call'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `block in execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
~/.rvm/rubies/ruby-2.2.4/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:172:in `invoke_with_call_chain'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:165:in `invoke'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:150:in `invoke_task'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block (2 levels) in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:115:in `run_with_threads'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:100:in `top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:78:in `block in run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:176:in `standard_exception_handling'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:75:in `run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/bin/rake:33:in `<top (required)>'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `load'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `<main>'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `eval'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `<main>'
LoadError
Concerns::RecordChanges has the following errors:
undefined method `to_a' for false:FalseClass
warn
undefined method `to_a' for false:FalseClass
~/.rvm/gems/ruby-2.2.4/gems/dissociated_introspection-0.4.1/lib/dissociated_introspection/ruby_class.rb:34:in `class_name'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/parent_class.rb:57:in `class_name'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/parent_class.rb:16:in `call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/mock_creator.rb:91:in `verify_class'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/mock_creator.rb:26:in `create'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:53:in `create_mock'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:24:in `block (2 levels) in call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:22:in `open'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:22:in `block in call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `each'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/generate.rb:15:in `call'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/public_methods.rb:30:in `create_mocks'
~/.rvm/gems/ruby-2.2.4/gems/active_mocker-2.1.3/lib/active_mocker/task.rake:12:in `block (2 levels) in <top (required)>'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `call'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:240:in `block in execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:235:in `execute'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
~/.rvm/rubies/ruby-2.2.4/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:172:in `invoke_with_call_chain'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/task.rb:165:in `invoke'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:150:in `invoke_task'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block (2 levels) in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `each'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:106:in `block in top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:115:in `run_with_threads'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:100:in `top_level'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:78:in `block in run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:176:in `standard_exception_handling'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/lib/rake/application.rb:75:in `run'
~/.rvm/gems/ruby-2.2.4/gems/rake-10.5.0/bin/rake:33:in `<top (required)>'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `load'
~/.rvm/gems/ruby-2.2.4/bin/rake:23:in `<main>'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `eval'
~/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `<main>'
NoMethodError
Error Summary
errors: 0, warn: 4, info: 0
Failed models: Concerns::Approval, Concerns::RecordChanges
2 mock(s) out of 21 failed.
To see more/less detail set error_verbosity = 0, 1, 2, 3

@zeisler The line ActiveMocker::Config.disable_modules_and_constants = true doesn't seem to have helped with the error.

I failed to mention that you need to run rake active_mocker:build again after adding that to config/initailizers/active_mocker.rb

We've been seeing this with any of our modules in a namespace too. Was going to maybe look at what the fix was next week.
e.g.
#app/models/product.rb
class Product < ActiveRecord::Base
  # implicit -> Product::SomeNamespacedModule
  include SomeNamespacedModule
end

#app/models/product/some_namespaced_module.rb
class Product
  module SomeNamespaceModule
    def some_method
    end
  end
end

We've hacked a fix which is to edit the actual models to say include Product::SomeNamespacedModule. But that is obviously temporary whilst we look into the real solution.

Also when I try to run my test I get:
~/myproj/spec/mocks/booking_mock.rb:5:in `<class:BookingMock>': uninitialized constant BookingMock::RecordChanges (NameError)

Hmm.

The solution here is make all modules fully specify there namespace. These changes will take place in both/either https://github.com/zeisler/active_mocker/blob/master/lib/active_mocker/mock_creator.rb or https://github.com/zeisler/dissociated_introspection.

The reason this is happening is because in dissociated_introspection the module inclusion is being done in complete isolation without any context of where things are defined. There is no good reason to keep doing it that way, I should be able to compare the dissociated_introspection class version and the real model to determine the full name of included modules.

Sweet. So @zeisler I'm guessing this project is something you look at on weekends? We'll probably be wanting to fix (and provide a PR) for this issue during the next week. Do you have any particular pointers to look at for a fix? I've had a glance over the dissociated_introspection gem and it seems like it might be tricky.
The thing that makes me uncomfortable is the cyclic dependencies.
So in this scenario the Rails app depends on the gem, but also provides code which the gem (would) depend on. The dissociated_introspection gem seems like a really sweet solution to a tricky dependency problem.
I like the philosophy (and speed) of explicit dependencies. What I don't want to do is end up triggering loads of unnecessary (read slow) Rails autoloading at any point. But perhaps it is unavoidable with implicit module namespaces.
Do you have any thoughts on the matter, or a particular solution in mind?

There are two explicit phases of ActiveMocker the generation phase and running of the mocks phase. For the generation phase rails is loaded, it's necessary to get the schema information, because not everyone has a schema.rb. The purpose of dissociated_introspection is because of the difficulty to know what methods are user defined and what are ActiveRecord defined, through meta programming. So removing ActiveRecord from the picture is what dissociated_introspection does. The reason I think it may be necessary to use dissociated_introspection version of module inclusion is because ActiveRecord may include any number of modules dynamically. (There may be a way other than a blacklist to find the user defined modules in the hierarchy, worth looking into.) So I am suggesting that a fuzzy search be done from dissociated_introspection module list to the included modules on the ActiveRecord to obtain the correct namespace. That being the case the change would take place in ActiveMocker::MockCreator class and no change would be needed in dissociated_introspection .

Interesting idea. I'll take a good look at it next week.
It may be possible to use source location info too to determine user code vs framework code

With this PR https://github.com/zeisler/active_mocker/pull/62 it should address @markburns example not sure if it will also fix @fatuhoku issue. Let me know.

I've switched over to using Zeus to achieve fast tests for the time being. We also have been moving away from using Concerns :P


Fixes links in CONTRIBUTING.md

NetflixOSS » feign » feign-pull-requests #230 SUCCESS
This pull request looks good

Thanks!

:metal:


chore: Add Timo to user list

@liyinan926 Can you help to review it?

PRs updating who-is-using can be merged to clean up the backlog of open MRs:

#1808
#1795
#1615
#1449


[M] Sites Implementations - API - Park Site Object GET

Implementation ticket for ticket #332
Blocks ticket #394
Amendment:
While implementing this ticket, a requirement has been identify to include display name in the park site object. This allows for easier facilitation of ticket #394 because we do not need to do another query to get display name. To implement this, a migration has to be made to update the existing data.
Park site objects after this ticket should look like this:
{   pk: 1,   sk: Site::1,   displayName: Test site 1 }
AC:

Facilitates getting of a list of park site objects (PK is orcs, SK is Site::{siteId})

Endpoint path should be /parks/_identifier/sites GET
Biz rule: If a park is pending, public users should not be able to get its associated park site objects.

Postman is updated
Unit tests are updated
SAM template is updated
Migration to add displayName to current park site objects.

@danieltruong is this one supposed to be in PO review?

Whoops that was supposed to go to QA

Hi @danieltruong, when I am trying to GET the sites of a Park which is in "pending" status from Postman, I have no trouble getting the information. The ticket description says if the park is in pending then the public should not be able to get the site data. Will you be able to explain how that has been implemented and what i should expect to see?

I will pass this to PO review as the task has been completed.

During the stand-up today, @mark and @cameronpettit confirmed that we are not focusing on features related to "Pending" status and that can be ignored.
FYI @JLWade @Dianadec

moving to done


Remove catalog.cattle.io/scope annotation

Description

In order to list the kubewarden-controller chart on downstream clusters within Rancher, this annotation needs to be removed
Additional Information
This annotation would only be necessary if we did not want to enable Kubewarden on downstream clusters.

What do you mean with "downstream cluster"?

I mean any clusters managed by Rancher other than the local cluster.


[Cosmos] Implement background refresh of endpoints

When we reimplemented failover one item we skipped was background refresh of regional endpoints. Without this feature the SDK cannot recover automatically after an outage. The client must be reinitialized or the process rebooted.
Opening this issue to track work on implementing refresh. The initial plan is to match .NET behavior and async refresh endpoints every 5 minutes.

Hey there, I think automatic failover is a separate issue. This issue is related to endpoint discovery. We received another notice that automatic failover isn't working, this is a regression and can be mitigated by downgrading to 3.10.6. Can you please open a new issue to track?

@gkaniouris

@zfoster I have opened an issue for the failover here: https://github.com/Azure/azure-sdk-for-js/issues/15487

Hi folks do we have an ETA for this? It is also important as it avoids us having to recycle services manually during cases where we need to pull out or put regions into rotation.

This is actively being worked on

Released in 3.12.0

It seems to me that this option prevents in-memory instances of the CosmosClient client from being garbage collected in Azure Functions (v3) runtime. This is especially problematic if the Functions implementation does not honor the recommendation to use singleton clients multiplying zombie pollings on each function call leading to a continuous storm of GET / requests to the cosmos DB API over time


Bucketeer's Sprite Dump (initial)

Bucketeers Super Uber Ultra Sprite Dumper Collection Ver1.zip
So here's my initial dump of sprites that are (mostly) not default tileset items and currently in my stash.
Contents:

Arcane & Diesel unit sprite pack from my scrapped dieselpunk x fantasy genre mod idea FantasiAlpha
Sprite contributed by me to the Advanced Wars mod
Extra tile sprites of both tilesets, containing mostly requested sprites made for other modders.

FantasyHex extra tile sprites also contains some of my old attempts of different city center styles, and more recently the district prototypes.

My sprites used for Unit Style Set.
My sprites used for Warfare Expanded.
Sprite sheet of building components, for TC and districts, from Ancient up to Medieval. Medieval is not complete yet, but it should satisfy needs of some modders.

Notes: If you need to use those components from the sprite sheets, the modders may need image editing apps (Microsoft Paint would suffice) to extract the image manually.

Victory banners I made very long ago.

Feel free to reorganize them in the way you want! (:P)

Sprite sheets and victory banners we don't really have a place to add, all the rest added :)


set_from_config_parser: bbox_size and timeout

This function try to load the parameters bbox_size and timeout from the REDIS section of src.role.config.ini
self.bbox_size = config.getint(section='REDIS', option='BboxSize', fallback=2000)
self.timeout = config.getint(section='REDIS', option='Timeout', fallback=5400)
but in the config.ini, theses arguments are in the JOB section
[JOB]
BboxSize = 2000
Timeout = 5400

@tufftuff93 You are right unfortunately if forgot to update the README.
Now I updated the documentation and cleaned up the code in the configuration.py.
It would be great if you do some tests and give me some feedback.


TypeError: no implicit conversion of Symbol into Integer

I found it here:
TypeError: no implicit conversion of Symbol into Integer
	/action/judges/github-events/github-events.rb:68:in `block in fetch_contributors'
	/usr/local/bundle/gems/sawyer-0.9.2/lib/sawyer/resource.rb:128:in `each'
	/usr/local/bundle/gems/sawyer-0.9.2/lib/sawyer/resource.rb:128:in `each'
	/action/judges/github-events/github-events.rb:67:in `fetch_contributors'
	/action/judges/github-events/github-events.rb:278:in `fill_up_event'
	/action/judges/github-events/github-events.rb:332:in `block (4 levels) in <top (required)>'
	/usr/local/bundle/gems/factbase-0.4.0/lib/factbase/looged.rb:65:in `block in txn'
	/usr/local/bundle/gems/factbase-0.4.0/lib/factbase/rules.rb:73:in `block in txn'
	/usr/local/bundle/gems/factbase-0.4.0/lib/factbase.rb:168:in `txn'
	/usr/local/bundle/gems/factbase-0.4.0/lib/factbase/rules.rb:72:in `txn'
	/usr/local/bundle/gems/factbase-0.4.0/lib/factbase/pre.rb:62:in `txn'
	/usr/local/bundle/gems/factbase-0.4.0/lib/factbase/looged.rb:63:in `txn'
	/action/judges/github-events/github-events.rb:323:in `block (3 levels) in <top (required)>'
	/action/judges/github-events/github-events.rb:311:in `each'
	/action/judges/github-events/github-events.rb:311:in `each_with_index'
	/action/judges/github-events/github-events.rb:311:in `block (2 levels) in <top (required)>'
	/usr/local/bundle/gems/fbe-0.0.76/lib/fbe/iterate.rb:109:in `block (2 levels) in over'
	/usr/local/bundle/gems/fbe-0.0.76/lib/fbe/iterate.rb:88:in `each'
	/usr/local/bundle/gems/fbe-0.0.76/lib/fbe/iterate.rb:88:in `block in over']()

@yegor256 may I take this one?

@yegor256 may I take this one?

@Yegorov yes, please


fix fix ssl connection bug for JDBC 8.0.19

Proposed changes
Issue Number: close #20365

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0


Fix host discovering

regression: must try to ssh

done here https://github.com/towercomputers/toweros/commit/0250ce950d3e26d1f27eedb2f22ebd75e7462bc3


Adding License section in README.md

I would like to add the License section in the README for contributors to see easily!

I don't think that's necessary @the-amazing-atharva , because the contributors can easily see the licence from the right side navigation

Yeah actually its ok!


git.okkur.org server certificate verification failed

Is this a BUG REPORT or FEATURE REQUEST?:
bug
Discription
This is in ansible so it looks a bit different. git.okkur.org's cert is expired.
FAILED! => {"changed": false, "cmd": "/usr/bin/git submodule foreach /usr/bin/git fetch", "msg": "fatal: unable to access 'https://git.okkur.org/syna/': server certificate verification failed. CAfile: none CRLfile: none\nfatal: run_command returned non-zero status for themes/syna\n.", "rc": 128, "stderr": "fatal: unable to access 'https://git.okkur.org/syna/': server certificate verification failed. CAfile: none CRLfile: none\nfatal: run_command returned non-zero status for themes/syna\n.\n", "stderr_lines": ["fatal: unable to access 'https://git.okkur.org/syna/': server certificate verification failed. CAfile: none CRLfile: none", "fatal: run_command returned non-zero status for themes/syna", "."], "stdout": "Entering 'themes/syna'\n", "stdout_lines": ["Entering 'themes/syna'"]}

Environment:

Syna Theme version:  latest
Hugo version:  latest
Others:

Checking

Fixed. Had an issue with Let's Encrypt it seems and this wasn't caught. Thanks for notifying.


[help wanted] Generate subnets based on CIDR

This is a question, Is it possible to not write the public and private subnets and just put the CIDR block only and have the module auto generate the subnet CIDR ?

No, it is impossible to know what sizes of subnets and how many of them you want to use, so you need to specify them explicitly.


python3Packages.faraday-plugins: 1.5.6 -> 1.5.7

Motivation for this change
Update to latest upstream release 1.5.7
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 146675 run on x86_64-linux 1

3 packages built:

faraday-cli
python38Packages.faraday-plugins
python39Packages.faraday-plugins


AnimationParser.spriteSheet() arguments are all required

This Issue is about

A bug in the API
(or maybe An error in the documentation)

Documentation says that frameMax, margin and spacing arguments are optional, but if no value is specified, the method implementation doesn't assign default values (-1, 0 and 0), and the FrameData object returned is not correct.
Example:
bitmapdata.frameData = Phaser.AnimationParser.spriteSheet(game, bitmapdata.canvas, width, height)
the above code always fails, it must be:
bitmapdata.frameData = Phaser.AnimationParser.spriteSheet(game, bitmapdata.canvas, width, height, -1, 0, 0)

Could you give example where you use this?

Hello,
I was using it in a function that dynamically creates a BimapData with some frames for an animated sprite, but I have changed my code since then... now I create the frames by using bitmapdata.frameData.addFrame() because I need named frames, and Phaser.AnimationParser.spriteSheet() doesn't allow this.

This PR was fixed -- so we should close it. @photonstorm


memory leak in get_num_procs()

Seen in version 0.3.5+ds-1 as packaged by the Debian project for Debian Sid, on an AMD Threadripper 2950X system.
Some of my test programs are tripping GCC's memory leak detection built into their implementation of asan.  It looks like the error handling paths coming out of get_num_procs() are getting triggered, and they leak memory.
Hand-walking through get_num_procs():

sysconf(_SC_NPROCESSORS_CONF) returns 32
CPU_ALLOC_SIZE(32) returns 8.  However, sizeof(cpu_set_t) is 128.
Calling sched_getaffinity(0, CPU_ALLOC_SIZE(32), <a previously allocated cpu_set_t *>) returns -1: Illegal argument.  However, sched_getaffinity(0, sizeof(cpu_set_t), ) succeeds.

Its not clear to me just by reading the manpages whether or not it is glibc in error or openblas.  It certainly seems reasonable to pass CPU_ALLOC_SIZE(nprocs) instead of sizeof(cpu_set_t) as the second parameter.
That said, once ret is nonzero, get_num_procs() returns without CPU_FREE()'ing the previously CPU_ALLOC()'ed cpusetp, and memory is leaked.

You are talking about memory.c here I assume ? There is similar code in init.c that - I think - does not return (too) early.
That code was cobbled together from the manpages so it may well be wrong, on rereading it seems to me that the libc can use a fixed-size cpu_set_t that is bigger than the bare minimum number of bytes returned by CPU_ALLOC_SIZE. So perhaps that size should be the maximum of the two to encompass both systems with <1023 and >1023 cpus? (The manpage suggestion of probing different values on a big system until sched_getaffinity() succeeds looks strangely lame)

Further digging in the kernel sources:
sched_getaffinity() will return EINVAL if:

the len argument is not a multiple of sizeof(unsigned long)
the len argument isn't large enough to hold nr_cpu_ids

For AMD Threadripper 2950X, I see the following in dmesg:
[    0.000000] smpboot: Allowing 128 CPUs, 96 hotplug CPUs
[    0.000000] setup_percpu: NR_CPUS:512 nr_cpumask_bits:512 nr_cpu_ids:128 nr_node_ids:1
Sure enough, if I build up a cpu_set_t that is 128 bits large, everything works.  Maybe the bug is that _SC_NPROCESSORS_CONF is returning 32 instead of 128.


fix(components): Fix HoverView positioning issues with `Top

This fixes #1999. Before we had an inner node that was moving the position, but this removes that and just changes the anchor point's position.

/azp run


NullReferenceException in generated CSharp Client Code

The generated code with the default settings of the CSharp Client mode throws a NullReferenceException when the server WebApi returns  status=400 and ReadResponseString is false.
Then ObjectResponseResult will be initizialized with Text set to null which in turn will be used to inialize ApiExceptions response field.  The class ApiException does then the following, which leads then to a NullReferenceException
response.Substring(0, response.Length >= 512 ? 512 : response.Length

Ref: https://github.com/RicoSuter/NSwag/pull/1976

Will patch ASAP

v13.0.1

That was fast. Thanks!

@RicoSuter: Is this error introduced again? We are using NSwag 13.2.0 and gets NullReferenceException on timeout from server, as this don't have any content/response.
This is my response on timeout:
{ StatusCode: 408, ReasonPhrase: 'Request Timeout', Version: 1.1, Content: <null>, Headers: {} }
Generated client has this code:
if (status_ != "200" && status_ != "204")
{
    var responseData_ = response_.Content == null ? null : await response_.Content.ReadAsStringAsync().ConfigureAwait(false);
    throw new ApiException("The HTTP status code of the response was not expected (" + (int)response_.StatusCode + ").", (int)response_.StatusCode, responseData_, headers_, null);
}

When response._Content is null, then responseData gets null.
Null is sent as third parameter response to ApiException's constructor, where it results in NullReferenceException on response.Substring:
public ApiException(string message, int statusCode, string response, System.Collections.Generic.IReadOnlyDictionary<string, System.Collections.Generic.IEnumerable<string>> headers, System.Exception innerException)
    : base(message + "\n\nStatus: " + statusCode + "\nResponse: \n" + response.Substring(0, response.Length >= 512 ? 512 : response.Length), innerException)


Smart Mimic - HIP19 - 3rd Party Manufacturer Application

We're very happy to be part of Helium Network growth for 2 years as a loyal community member who already sent half a million messages over Helium Network with our Mimic GO products across the US. We hope to have a fun, design disclosure event along with our partner Sagem Teknoliji very soon as well as pricing of the product. Everyone in the Helium Community is invited! We're looking forward to expand Helium Network even more. Don't hesitate to contact us. We're here to help!
Rendered: https://github.com/onterferon/HIP/blob/master/0019-third-party-manufacturers/Smart-Mimic.md

I've received and reviewed identity & incorporation docs for Smart Mimic and can attest they are who they say they are

In recognition of:

[x] Support from the Helium community, as evidenced through discussions and informal polling on GitHub and Discord
[x] Identity verification/KYC (confirmed by DeWi, above)
[x] Hardware/software/security review of prototype (confirmed by Helium Inc privately)
[ ] Regulatory compliance (FCC – applied and expected to pass but not yet fully approved)

I am pleased to memorialize community consensus for approving Smart Mimic as a third-party manufacturer of Helium-compatible hotspots by marking this proposal approved ✅
DeWI has requested the company hold off on accepting pre-orders until regulatory compliance is fully certified.


Strategic reserves zones

WIBNI you could display lines 6" from the battlefield edges to show where strategic reserves can come in?

Fixed in bd703a2f93207e3e08310046b045cda99d932f19


Add Additional gRPC service handler hook

TL;DR
Extends the plugin registry with a configurable gPRC service handler hook to serve additional endpoints on the flyteadmin gRPC server.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[ ] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
^^^
Tracking Issue
N/A
Follow-up issue
NA

@pmahindrakar-oss sure I can save that for a follow-up
btw the monorepo is being finalized today - so I will need to add a duplicate PR there once we've cut over exclusively, but thanks for the review

closing in favor of https://github.com/flyteorg/flyte/pull/4171


hide and seek

Add a "#" in line 169 of the menu.js file since you're referring to the id of an HTML element.

Well spotted


Update options.js

Allow Spaces in Filter Users and Filter Services fields

I've changed the options.js to allow spaces in Filter User and Filter Services fields.

Closing this per discussion in #9


why not use solid ?

https://solidproject.org/

@romainPrignon can you expand on why Solid and how do you see Decentralized Web Nodes using Solid? How does this integration look like?

hey @cbruguera :-)
I don't know all the internals about solid and DWN to give you something usefull.
I was just pointing out that DWN and solid might share the same purpose.

Closing, no intent to abandon decentralized personal datastores for a more centralized content server project.


kubectl drain should have an option to not cordon the node

Currently, kubectl drain unconditionally cordons the node.
This might not always be desirable, for instance if the operator wants to use a different type of taint than the default, using kubectl taint for example.
So kubectl drain should have a flag to leave out the cordoning.

/kind feature

/sig cli
/area kubectl

/assign

I have filed a PR https://github.com/kubernetes/kubernetes/pull/91943 to solve this problem. If it got merged, we can disable cordon by kubectl drain --disable-cordon

I have filed a PR kubernetes/kubernetes#91943 to solve this problem. If it got merged, we can disable cordon by kubectl drain --disable-cordon

Awesome, thank you very much !

/priority P2


Update README with new features, project and cite us section

New introduction
Add a "More features!" section
Add a "The dynamiqs project" section
Add a "Cite us" section

Closes https://linear.app/dynamiqs/issue/DYN-119/add-a-cite-us-section-to-the-readme-and-the-documentation.

@gautierronan I will propagate the edits to the doc "Getting started" section once we've converged.


throw error if there is no bluetooth hardware present on host machine

So today in Ubiquity conference, I was trying this codelab. Ended up debugging for 15 minutes before I found out that there was no bluetooth device on the host machine. :stuck_out_tongue_closed_eyes:

May I ask which host machine you had?
I believe there were some Chromebooks available at the Ubiquity Conference.

Moreover, you should have seen a ""Bluetooth adapter not available."" error according to https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/bluetooth/bluetooth_dispatcher_host.cc&rcl=1452659659&l=646

Not sure, but the interface was OS-X based, so assuming Mac Mini, but even they have bluetooth hardware as I see in specs.
Tried the same codelab on my mac air with a bluetooth keyboard and trackpad attached, and got following error.

This is the same error I was getting at the event. And while debugging on the machine, and checking in system preferences, found that there was no bluetooth peripheral. But now since I am getting the same on my machine, seems something else is wrong her.

We don't support Mac well yet, and the codelab does say a "Chromebook or an Android M Device" is a prerequisite, but we should also give good error messages instead of just cancelling the chooser. We have https://crbug.com/529547 to track giving that error.

Ah! Thanks for the link @jyasskin. Will keep an eye on it. :+1: Closing this.


Honor workbench.editorAssociations in Notebooks

Version: 1.45.0-insider
Commit: d342048538c28d54afd1c6beea03f3a89af04359
Date: 2020-04-23T07:46:52.128Z (1 day ago)
Electron: 7.2.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0
Steps to Reproduce:

set this:

"workbench.editorAssociations": [
        {
            "viewType": "default",
            "filenamePattern": "*.ps1"
        }
    ]

Open a file that has a Notebook provider associated to it.

Expected: Opens in Text editor
Actual: Opens in Notebook
cc @rebornix

Already fixed in latest Insiders.

Can confirm. This is fixed.

Adding verified label per Tylers comment.


"This site can’t provide a secure connection" // cannot log in to the site

i can't log in to post to or edit the blog.
i am attempting to log in at https://creativecommons.org/wordpress/wp-admin/
using my username and password
have tried both chrome and safari
i am at home, not on public wifi
have tried the few tricks i know or that people have suggested to me: clearing cookies, removing the :80 in the address bar and trying to load the page again. can't get it to work.
screenshots attached

Hmm I don't get that error. Port 80 is http rather than https, so the web browser is right that it's not going to be a secure connection Please try:
https://creativecommons.org/wp-admin/
(note the lack of /wordpress/ ) and see if that's any happier?

Tried that, same problem. Cleared cookies again Tried in both Chrome and Safari.

And now I'm seeing the same problem.
@mattl I'm not sure what's going on here. The CAS server is redirecting to a bad url, presumably because WordPress is passing it one? e.g.:
https://creativecommons.org:80/wordpress/wp-login.php?redirect_to=https%3A%2F%2Fcreativecommons.org%2Fwordpress%2Fwp-admin%2F&ticket=ST-1468603000rPEGS9DRZi6ondMnQnZ

I've tried converting this to a simpler url, e.g.:
https://creativecommons.org/wordpress/wp-login.php?ticket=ST-1468603000rPEGS9DRZi6ondMnQnZ

but this gives a page with the h1:
CAS Authentication failed!

did we change anything in CASAuth on the WP server?

Yeah, because we're technically fronting the site with HAProxy, the site is correctly reporting that it runs on port 80.

Ohhh. But people have logged in and posted OK recently (e.g. Jennie yesterday) so what's up here?

Yeah, people are finagling the URL to get in. Looking at CAS Maestro now.

OK cool.

Temporary workaround:

Go to https://login.creativecommons.org/login
Regardless of whether the page tells you that you are already logged in or not, log in with your email and password.
You will see the message "You have successfully logged in." in a blue box under the CC logo.
In the same browser window, enter this url in the address field and press enter: https://creativecommons.org/wordpress/wp-login.php
This will redirect you to the WordPress admin page ready for you to start editing.

@ericsteuer Can you confirm if the work around posted works for you?

No, it does not work for me. I get the same error message. Screenshot
attached.
On Tue, Jul 19, 2016 at 9:31 AM, Matt Lee<EMAIL_ADDRESS>wrote:

@ericsteuer https://github.com/ericsteuer Can you confirm if the work
around posted works for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/creativecommons/creativecommons.org/issues/361#issuecomment-233689964,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIga0pYI4HSxgXts9SPqKaeN_sIon8GHks5qXPvugaJpZM4JNmD9
.

--
Invest in an open future. Support Creative Commons today:
http://bit.ly/19IjSKl

@ericsteuer Please try again.

tried again now using rob's method, and i was able to log in. is this the way i should be logging in going forward? using the first url, logging in, then entering the second one?

nah, actually just going to https://creativecommons.org/wordpress/wp-admin/ should just work now.

nice haiku :P


print the repo path on conflicts

Closes #193
Prints the repo path before the files which are conflicting to make it easier to open the entire repo when desired.

Great, thanks!
Can you do me a favor and update the snapshots? yarn test -u

You got it

Hmm, I see the same yargs errors on master

Yeah, it's because I'm using environment variables on travis and they are not available to contributors.
The env variable is defined in my project settings: https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings

I tried cleared cache and restarting the build but no luck. I want something like retest from Kibana...

Released in 5.4.2


fix: properly decode requests with none parameters

Current dependencies on/for this PR:

main

PR #106   👈

PR #107

PR #108

This comment was auto-generated by Graphite.


Add Quantuam Efficiency to galcheat

As discussed in the meeting yesterday, we so far have been assuming its 1 so electron = photons = photoelectrons. If not we can at least state this assumption explicitly in the documentation, etc.

I thought the end of the discussion was that QE is taken into account in the zeropoint computation from speclite(cc @mpaillassa) which end up computing a reference for 1 e-/second.
Since magnitudes are always computed relative to the band zeropoint, the prescription 1 photon = 1 e- is verified and is not just an assumption.
Do you agree @mpaillassa, @herjy ?

Yes I agree !

Yes that sounds good @aboucaud, in that case you can close this PR I think ?

Settled for now


Added netcoreapp3.0 to Supported Frameworks

Docs Build status updates of commit 9560e6e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/target-frameworks.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support the Vpc Construct

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Get this construct to work with pulumi-cdk:
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.Vpc.html
Affected area/feature

Apologies, I should have done the due diligence. @jkodroff FYI.


Style system

Could we assign theme and diagram style in a general style system, and move them to a .pintora-style file, instead of spreading over arbitrary config and artist.
For reference:

https://plantuml.com/zh/style-evolution

Could the sistem include filters/hooks for canvas drawing elements so we could use something like rough.js ?


[NoQA] fix: bottom tab transitions duration

Explanation of Change
Reduced animation transition to 150ms to make it faster.
Fixed Issues

$ https://github.com/Expensify/App/issues/53347
PROPOSAL: N/A
Tests

go through the tabs on Android/iOS and be sure animation doesn't take too long to switch the scene

Offline tests
N/A
QA Steps

go through the tabs on Android/iOS and be sure animation doesn't take too long to switch the scene

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/e25f8a69-ec9a-49eb-9e52-a8015159cd6b

Android: mWeb Chrome
https://github.com/user-attachments/assets/f76c038b-ee83-4aa1-99a7-3e4e6c71625a

iOS: Native
https://github.com/user-attachments/assets/38c54292-141c-412a-9ab1-5c60de146cde

iOS: mWeb Safari
https://github.com/user-attachments/assets/413768b8-04ba-40d5-b659-2ea94fcd4fee

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/ff054fe6-7e4e-4be5-9216-cf133846716c

MacOS: Desktop
https://github.com/user-attachments/assets/e765f6fc-e1ba-4262-9e59-cc19681c220a

@mountiny may I ask you to trigger a build and ask design team to make tests to be sure that the duration is okay now? 😊

@DylanDylann @kirillzyusko Could you please add recordings here? I cannot run the ad-hoc build unfortunately.

Sure, I will do it soon

Could you please add recordings here?

Ooops, I somehow uploaded wrong recordings 😔 I uploaded correct recordings now!

@kirillzyusko the test failed

@DylanDylann tests fixed!

@DylanDylann, what is your eta for this one?

@dannymcclain Could you make a build again and test on that build to ensure the duration is fine now? 😊

From my testing, I don't see a significant difference in the behavior compared to the main branch when clicking on bottom bar tab

From my testing, I don't see a significant difference in the behavior compared to the main branch when clicking on bottom bar tab

@DylanDylann did you make a clean installation of node_modules to apply a modified patch and then re-assembled the app?

It also kinda feels like the transition to the search tab takes longer than the other tabs... but maybe that's just in my head?

This is a separate issue. We tracked it here https://github.com/Expensify/App/issues/53818
This PR just focuses on reducing animation duration (I haven't optimized slow rendering of Search page in this PR, we decided that it would be better to solve different problems in different PRs).

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Hmm I think things are still broken? I was consistently tapping back and forth between Inbox and Settings and then the bottom tabs became totally unresponsive and now I can't change the tabs anymore. Can you reproduce on your end too?

When it works though, I think it feels better? Honestly I wouldn't hate it a tad faster though I think.

Tested it on both Android and iOS:

On iOS the transition timing looks almost fine, but the delay of the tap is now even more evident
On Android the delay can be seen even more clearly:

https://github.com/user-attachments/assets/74fdba84-cfe4-426f-8053-e55e096f0616
Part of me wonders if we should set the animation to like 50ms or lower (or even remove it), then figure out the timing of the tap -> animation start -> animation end. That way we can figure out what feels sluggish.

On Android the delay can be seen even more clearly:

Yes, because Android are typically less optimized and works slower comparing to iOS.

Part of me wonders if we should set the animation to like 50ms or lower (or even remove it), then figure out the timing of the tap -> animation start -> animation end. That way we can figure out what feels sluggish.

Yeah, for testing purposes we can set duration to 0 or completely remove the animation. But again, optimization of transitions should be made in a separate PR. The current problem is that after native-stack PR merge screens in bottom tabs are getting re-created whenever user changes them, but these screens should be created just once and then we should just change zIndex to show a correct screens (in this case transitions should be immediate).
Maybe @chrispader can shed more light on why the behavior has been changed 👀

Potentially problem with slow tab switching has been fixed in https://github.com/Expensify/App/pull/54030

Yes, because Android are typically less optimized and works slower comparing to iOS.

Testing it on iPhone 15 Pro and I'm still seeing a pretty big lag.
I don't know the technicals deeply but what you're all saying above sounds worth looking into

The current problem is that after native-stack PR merge screens in bottom tabs are getting re-created whenever user changes them, but these screens should be created just once and then we should just change zIndex to show a correct screens (in this case transitions should be immediate).

@kirillzyusko If that, we should mark this PR as NO QA and move test step to https://github.com/Expensify/App/pull/54030

@kirillzyusko When clicking on the search tab and then clicking on the settings or chat tab, it is unresponsive
https://github.com/user-attachments/assets/c1559ad4-f94e-4d12-bfb2-ae985534f4d8

@DylanDylann the same problem exists on main as well, so I don't think it should prevent this PR from being merged:
https://github.com/user-attachments/assets/17c1e14f-b924-4768-b03e-1826a4ba0506

If that, we should mark this PR as NO QA and move test step to https://github.com/Expensify/App/pull/54030

Okay, I marked it as NoQA 👍
cc @mountiny

@DylanDylann can you please complete the checklist and testing?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/user-attachments/assets/767bd41b-9a81-42ba-b1ce-a176ceeae37a

iOS: Native

iOS: mWeb Safari

https://github.com/user-attachments/assets/d9e3c4c4-789e-4d1f-bd48-5411e7768eb8

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/9c9111e9-29e0-4534-b0c6-24127c10029f

MacOS: Desktop

https://github.com/user-attachments/assets/a77df297-7070-4f8b-b095-47c9d39bb37e

All good now

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Enable const extern "C" fn definitions on Rust 1.62.0 and above

This was recently stabilized in https://github.com/rust-lang/rust/pull/95346,
and will be included in the 1.62.0 release.
This const-extern-fn feature can still be used to enable
these definitions on older compiler versions.

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

main.rs has this line:
#![cfg_attr(libc_const_extern_fn, feature(const_extern_fn))]

This will fail to compile on stable even if the feature is supported.


Count Palindrome Numbers in a Range

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement: Create a function that returns the number of palindrome numbers in a specified range (inclusive).
Problem Link: https://edabit.com/challenge/BRoBDeEc2be7wm8BD
Examples :
countPalindromes(1, 10) ➞ 9
 countPalindromes(555, 556) ➞ 1

 countPalindromes(878, 898) ➞ 3

Before submitting a PR please Check some details. Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to probelm
example -

'''
    Probem Task : This program will add two numbers
    Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
'''
*/
def main():
    return a + b

This repository is valid for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

Hey @sawamoha20 . Can i contribute to this issue?


[ci skip] adding user @YYYasin19

Hi! This is the friendly automated conda-forge-webservice.
I've added user @YYYasin19 as instructed in #17.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #17

@conda-forge/core as it is possible to see from https://github.com/conda-forge/stable-baselines3-feedstock/pull/11, apparently the mantainer @cyprienc is not able/interested to reply to issues and PRs since several months, so it would be great to merge this PR to have @yyyasin19 as active mantainer, thanks!

Thanks @h-vetinari !


Component-based API for global styling

Via https://github.com/styled-components/styled-components/issues/730#issuecomment-320035959
It would be great to have a React component for global styles that does the actual injecting (rendering null), removing the CSS when it is unmounted.
So instead of
    injectGlobal`...`

you'd do
const GlobalStyle = styled.global`
… (including prop interpolation)
`
...
return (
  <App>
    <GlobalStyle darkBg={this.props.dark} />
    ...
  </App>
)

The only differences with regular styled components would be:

Renders null
Does not wrap the CSS with an own class

This way:

Global styles can be easily modified via props
It works without issues in SSR
It's obvious what is happening

I think this would be a valuable change.
Myself and @geelen originally decided against going down this route because it seemed more tedious to use, but as you said it has a bunch of nice properties. A couple more are:

You can use the theme dynamically in the global styles
You can override global styles dynamically and change them
We can make global styles work with the coming StyleSheetManager, ref #1324

I'm open to doing this. My only concern is that I don't like overloading the styled.x convention and whether we want to introduce a new API or reuse the old one:
/* First possibility: injectGlobal now just returns a component */
const GlobalStyles = injectGlobal`
  body {
    background: blue;
  }
`

/* Second possiblity: Different API */
const GlobalStyles = injectGlobalAsComponent`
  body {
    background: blue;
  }
`

/* Third possibility: Radium-like

I'd personally prefer the first way. I'd rather not we have multiple ways of doing things, and we could break this in a major version without troubles.

@mxstbr I'm totally down for replacing injectGlobal with sth like your first or second variant. I think both styled.global and  are not favourable options.
I do think though that the name injectGlobal should be changed, but maybe we can go for a more succinct name like globalStyles.
I don't think this necessarily depends on #1324, but we do need to implement a way to remove styles from our sheet (or alternatively append & replace classes to body) which might conflict with refactors in #1208.

Doesn't depend on #1324 at all, but enables more functionality for the StyleSheetManager!
Yeah you're right, on second thought injectGlobal returning a component is kind of weird. What about const Style = createGlobalStyle or something to that effect?
With appending and replacing that doesn't matter for the first version of this component (though we should really tackle that) since right now people just work around the dynamicism with a function that gets called when the styles should change I assume.
On Wed, Nov 29, 2017 at 3:06 PM Max Stoiber<EMAIL_ADDRESS>wrote:

Doesn't depend on #1324
https://github.com/styled-components/styled-components/pull/1324 at
all, but enables more functionality for the StyleSheetManager!
Yeah you're right, on second thought injectGlobal returning a component
is kind of weird. What about const Style = createGlobalStyle or something
to that effect?
With appending and replacing that doesn't matter for the first version of
this component (though we should really tackle that) since right now people
just work around the dynamicism with a function that gets called when the
styles should change I assume.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1333#issuecomment-347869987,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlmrhB90b9BmcIj_R8LBKc0jwd_H5ks5s7WTWgaJpZM4Qu7YR
.

@mxstbr

You can override global styles dynamically and change them

Isn't this against goals of CSS-in-JS libraries to avoid this mess?

You can use the theme dynamically in the global styles

This would be a huge benefit. Unifying the theming of components with global styles like font-face and page background-color is something I'm definitely missing. A clearly defined place to perform global styling that has access to the theme would be great.

Alright, so it seems that everybody likes e.g.
import {createGlobalStyle} from 'styled-components'

const Style = createGlobalStyle`
  ${p => p.noScroll && `body { overflow: hidden; }`};
`

as an API? What are the next steps to make this happen? Is this a deep change to how the CSS is managed?

I don't think so, the only thing I'm not 100% sure about is re: server-side rendering and rehydration—would definitely be worth kicking off a first PR so that @geelen can take a look at that though!

Continue my thoughts from #1354
Helper keyframes works similar to injectGlobal. They generate componentId from hash of passed styles and inject computed styles through global instance of StyleSheet. We could reuse that companyId for injecting styles in Component-based API without breaking change for writing global styles / keyframes.
Proposed API examples:
import React from 'react';
import { injectGlobal, StyleInjector } from 'styled-components';

const globalStyles = injectGlobal`
  body: {
    // ...
  }
`;

const MyComponent

import React from 'react';
import { keyframes, StyleInjector } from 'styled-components';

const animationName = keyframes`
  0% { color: transparent; }
  100% { color: radboats; }
`;

StyleInjector will get componentId with provided prop name, then grab corresponding styles from global StyleSheet instance and finally insert them to closest StyleSheetManager target.

Something I've realized: The issue with introducing a new API like injectGlobalStyle is that it breaks all our tooling since that relies on the injectGlobal name. (think Babel plugin, stylelint processor,...)
Definitely not ideal... :confused:

Hmm, we can have both and deprecate injectGlobal?
On Sat, Dec 16, 2017, 11:56 AM Max Stoiber<EMAIL_ADDRESS>wrote:

Something I've realized: The issue with introducing a new API like
injectGlobalStyle is that it breaks all our tooling since that relies on
the injectGlobal name. (think Babel plugin, stylelint processor,...)
Definitely not ideal... 😕
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1333#issuecomment-352176072,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWljjo8ZlByFa5NU12TyiZHVjVyZnYks5tA6HDgaJpZM4Qu7YR
.

Yes of course, just a thing to note that it'll be a bit more work after we implement this API.

Alright, let's get started on this—anybody want to tackle a first PR that implements this new API?
We already have tests for most of the global behavior, so it should just be a matter of rewriting those tests to use the new API (at which point they'll all fail) and then slowly rebuild the new API until all tests pass again!

Just to clarify: is the blessed API the following?
import {createGlobalStyle} from 'styled-components'

const Style = createGlobalStyle`
  ${p => p.noScroll && `body { overflow: hidden; }`};
`

Yep! See #1416, would love if you could pick that up and implement some tests so we can ship it :blush:

I'll give this a shot, might get stuck on some WIP state though.

This is a thing in v4 :)

Hmm. Warning Use "createGlobalStyle" instead. in SC v3 confuses me. Is createGlobalStyle also available in v3?

Well you can continue to use injectGlobal in v3. However v4 has a few good features and perf upgrades so in case you want to switch you may have to move to createGlobalStyle.

Yeah... I think I’m just going to take it out. After more thought it doesn’t make sense to put in a non-actionable warning.


rsa_ossl.c: cache MONT_CTX for public modulus

Is there a reason why the cache MONT_CTX for public modulus is done AFTER setting up blinding for rsa_ossl_private_decrypt(), but is done BEFORE setting up blinding in rsa_ossl_private_encrypt()?
rsa_ossl_private_encrypt():
    if (rsa->flags & RSA_FLAG_CACHE_PUBLIC)
        if (!BN_MONT_CTX_set_locked(&rsa->_method_mod_n, rsa->lock,
                                    rsa->n, ctx))
            goto err;

    if (!(rsa->flags & RSA_FLAG_NO_BLINDING)) {
        blinding = rsa_get_blinding(rsa, &local_blinding, ctx);
        if (blinding == NULL) {
            ERR_raise(ERR_LIB_RSA, ERR_R_INTERNAL_ERROR);
            goto err;
        }
    }

rsa_ossl_private_decrypt:
    if (blinding != NULL) {
        if (!local_blinding && ((unblind = BN_CTX_get(ctx)) == NULL)) {
            ERR_raise(ERR_LIB_RSA, ERR_R_BN_LIB);
            goto err;
        }
        if (!rsa_blinding_convert(blinding, f, unblind, ctx))
            goto err;
    }

    /* do the decrypt */
    if ((rsa->flags & RSA_FLAG_EXT_PKEY) ||
         ...
    } else {
        ....

        if (rsa->flags & RSA_FLAG_CACHE_PUBLIC)
            if (!BN_MONT_CTX_set_locked(&rsa->_method_mod_n, rsa->lock,
                                        rsa->n, ctx)) {
                BN_free(d);
                goto err;
            }

The code in rsa_ossl_private_encrypt() was changed to do it earlier with PR https://github.com/openssl/openssl/pull/7586 and commit https://github.com/openssl/openssl/commit/2cc3f68cde77af23c61fbad65470602ee86f2575 "rsa/rsa_ossl.c: cache MONT_CTX for public modulus earlier.", but rsa_ossl_private_decrypt() was not changed....
This has an effect on the mod-expo operation that is performed as part of setting up the blinding factors (rsa_get_blinding() -> RSA_setup_blinding() -> BN_BLINDING_create_param(), or BN_BLINDING_update() -> BN_BLINDING_create_param() after 32 updates).
When a Montgomery context in rsa->_method_mod_n is available at the time the blinding is set up, BN_BLINDING_create_param() stores the Montgomery context together with the rsa->meth->bn_mod_exp function in the blinding structure. Only if both are not NULL, it will actually use the specified bn_mod_exp function, if the Montgomery context is NULL, then BN_mod_exp() is used.
So for rsa_ossl_private_encrypt() the Montgomery context is set up BEFORE blinding, an thus it will always use the RSA method's bn_mod_exp function, but for rsa_ossl_private_decrypt()  the Montgomery context is set up only AFTER blinding, and thus the RSA method's bn_mod_exp function is not used (unless the Montgomery context has been setup by other means already, but then blinding has most likelky als been set up already) .
While this may not make a big difference for the normal software implementation, it does make a big difference when the RSA method's bn_mod_exp function has been replaced with a function that performs this in hardware. This is for example the case when an engine is used (OK, not of too much interest anymore since OpenSSL 3.0), but also for the s390 Linux platform, where the rsa_pkcs1_ossl_meth RSA method is set up with alternative functions (s390x_mod_exp). So for rsa_ossl_private_encrypt() that mod-expo is performed in hardware, but for rsa_ossl_private_decrypt() it is performed in software. For every first or for repeating private decrypt operations on every 32th operation, an new blinding factor is set up involving that mod-expo call. So this may have some notable performance impact.

its a bug. see #20281 wehere this will be fixed.

PR https://github.com/openssl/openssl/pull/20281 which contains the fix for this has been merged, so this one can also be closed.


Add tests for form_text_field.1.dart

Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for

examples/api/lib/material/text_form_field/text_form_field.1.dart

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Reason for revert: Surprisingly, the following test seems to be consistently failing on Windows after the addition of this test:
flutter/packages/flutter/test/widgets/sliver_tree_test.dart: .toggleNodeWith, onNodeToggle

Reverted this since the above-mentioned test was failing consistently starting at this patch. The main possibility I was envisioning was some sort of non-hermetic crossover between the tests, but even after the revert, the above-mentioned test is consistently failing. It seems there's some other non-hermetic component of our tests.
@ValentinVignal apologies for the noise here. Please re-send out this patch and we'll get it re-landed.

Sure @cbracken , no problem, I re-created the PR here: https://github.com/flutter/flutter/pull/150750

Thank @ValentinVignal and apologies again for the churn!


Key bindings for command+# to select the nth tab

VSCode Version: 1.10.2
OS Version: OSX 10.11.6 (El Capitan)

In a number of other Mac programs (Firefox, Chrome, Atom, etc.) you can hit Command (Apple) + a number key to switch to the nth tab. So if I have 3 tabs open and I hit command+2, it'll switch over to the 2nd tab. In VSCode there are keybinding commands to do workbench.action.focusSecondEditorGroup, but it would be nice to have workbench.action.focusSecondEditor or workbench.action.focusSecondTab or something like that.
Any ideas?

Looks like it was already possible. I added this in my key bindings: (OSX Sierra 10.12.3, VSCode 1.10.2)
[
    { "key": "cmd+1",                "command": "workbench.action.openEditorAtIndex1" },
    { "key": "cmd+2",                "command": "workbench.action.openEditorAtIndex2" },
    { "key": "cmd+3",                "command": "workbench.action.openEditorAtIndex3" },
    { "key": "cmd+4",                "command": "workbench.action.openEditorAtIndex4" },
    { "key": "cmd+5",                "command": "workbench.action.openEditorAtIndex5" },
    { "key": "cmd+6",                "command": "workbench.action.openEditorAtIndex6" },
    { "key": "cmd+7",                "command": "workbench.action.openEditorAtIndex7" },
    { "key": "cmd+8",                "command": "workbench.action.openEditorAtIndex8" },
    { "key": "cmd+9",                "command": "workbench.action.openEditorAtIndex9" },
]

Awesome. Thanks!

IMO this would be better as default behavior


Install/Update failures: Code.exe being used by another process

VSCode Version: 1.32.3
OS Version: Windows 10.0.17134

Steps to Reproduce:

Attempt to update, or re-install VS Code

Does this issue occur when all extensions are disabled?: Yes/No
Yes, it occurs regardless of extensions
Upon attempting to update VS Code to 1.33.1,  get warnings indicating that Code.exe is being used by another application, and as such, the update fails. Similarly, uninstalling VS Code, and attempting to re-install, also fails with a similar warning.
In fact, upon attempting to re-install the application, and choosing to "Abort", it breaks the entire installation during it's rollback.

Uncaught Exception:
Error: Cannot find module 'C:\Users\BATMAN\AppData\Local\Programs\Microsoft VS Code\resources\app\out\main` at Module._resolveFilename (internal/modules/cjs/loader.js:602:15)

When attempting to update, I receive a warning that Code.exe is already in use:

C:\Users\BATMAN\AppData\Local\Programs\Microsoft VS Code\Code.exe
The process cannot access the file because it is being used by another process.

After having closed Visual Studio code, I noticed there were still several processes running via task manager. I manually terminated those, and tried to install --- same thing; Code.exe is being used by another process.
I'll note that, per another issue submitted (and has since been locked), I've tried disabling the background updates --- this did not resolve the issue. It still throws a warning that Code.exe is locked up.
I was however, able to resolve the issue by doing one notable thing: closing Slack. I feel as though this may be of particular importance considering that Slack is also built on-top of Electron. Something for the team to consider.

I have had the same problem since I use VScode.

I ended up booting into Safe Mode in Windows 10 and doing the update there. I couldn't get it to update any other way.

/duplicate #47841


Update the Examples Links

Hello:)
In the footer section there is an Examples button. It takes you to this link here, But with the new update it should take you the Example folder in the docs Branch.
I would like to work on it.

Thanks for noticing!

Closed because we have the example scripts and example notebooks in separate locations right now. This can be revisited after https://github.com/pybamm-team/PyBaMM/issues/3197


Enhances command outlook message list

Closes #5872

We'll try to review it ASAP!

Thanks for the thorough review. I (should) have resolved all comments. Could you please have another look?

@MartinLoeper, this PR is now available in our beta release. You can install it by running npm i -g @pnp/cli-microsoft365@next.

Shared Mailboxes just work as a charm! Tested on latest beta release. Thanks a lot!!!!


Use sonic gif instead of spinner

Before:

After:

Enough said, I think.
Truth be told, I'm not 100% certain this will work, but I'm ~85% sure it will.

I'm afraid this doesn't work.  It appears to be hardwired in html, so you will need to do some js surgery

Dang really? Is it live now? It should be hiding the image and setting the background of its parent div to sonic. Worked in the offline page I saved (which is a lousy way to test, really).

It is live now


fix: upgrade helm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/aprove

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Notice for non-premium customer disable

Notice for non-premium customer disable

@zhiweiwangmsft : Thanks for your contribution to the Azure documentation! The author, @billmath, has been notified to review your proposed change.


Odds: Fix crashes if league is neither 4 or 6

if this happens in the first loop, UnboundLocalError: local variable 'headers' referenced before assignment
headers was passed instead of url

Thank you, much appreciated.